From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:06:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:06:24 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:10:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:10:30 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #43 from Katrin Fischer --- Comment on attachment 44639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44639 [SIGNED OFF] Bug 8995: Show OpenURL links in OPAC search results Review of attachment 44639: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8995&attachment=44639) ----------------------------------------------------------------- Hi, I have started with a code review here: 1) Please remove the changes to opac-detail.tt and opac-results.tt. (see: http://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR1:_non-XSLT_search_results_and_bib_display_templates_deprecated) ::: C4/XSLT.pm @@ +215,5 @@ > $sysxml .= "$sp\n"; > } > $sysxml .= "\n"; > + > + $variables ||= {}; 2) Please chose a better variable name reflecting that this is about the OpenUrl feature. ::: installer/data/mysql/sysprefs.sql @@ +510,1 @@ > ; 2.5) Please do the librarian in me a favor... and keep the alphabetic order in this file :) ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ +324,4 @@ > both: "both top and footer" > top: "top" > footer: "only footer" > + - 3) Please create a new heading for the OpenURL preferences, so that they are listed in one section together. @@ +324,5 @@ > both: "both top and footer" > top: "top" > footer: "only footer" > + - > + - 'Complete URL of OpenURL resolver (starting with http:// or https://):' 4) Please remove the tags (see: https://www.w3.org/wiki/HTML/Elements/tt). I think we are using in some other preferences. @@ +349,5 @@ > + - > + - 'List of item type codes (separated by spaces) for those you want to show the OpenURL link:' > + - pref: OPACOpenURLItemTypes > + - '
' > + - 'It uses biblioitems.itemtype field, so if you map a MARC field to it, and link this MARC field to a list of authorised values (for example CCODE), you can use these values for system preference value.' 5) Sorry, but I think this is bad advice. One shouldn't redefine the biblioitems.itemtype field like that - or you will cause yourself trouble in a lot of other places. For example some of the circulation code falls back to the itemtype defined on biblio level now. What happens when pref is left empty? Can the OpenUrl be displayed for records with empty biblioitems.itemtype? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:10:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:10:38 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:22:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:22:54 +0000 Subject: [Koha-bugs] [Bug 15269] New: Layout tweaks for the opac-detail page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Bug ID: 15269 Summary: Layout tweaks for the opac-detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jen at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Make the following improvements to the layout of the OPAC detail page: * Image thumbnail has more white space * Summary is moved up the details block and font size is increased * Ratings controls are moved up the details * Small devices get a better layout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:23:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:23:46 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jen at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:30:03 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer --- Just a request for a small follow-up here: The system preference is not nicely formatted and I think the wording could be a bit more clear. Currently it reads: Send a copy in bcc of the ClaimAcquisition and ClaimIssues letters to the active user [Send|Don't send] My suggestion after discussing with a native speaker (thx Liz :) ) would be: [Send|Don't send] blind copy (BCC) to logged in user when sending serial or acquisitions claims notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:35:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:35:55 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber as filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Call number in the |Add collection, location, |filter of most circulated |and callnumber as filters |items |to report for most | |circulated items CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:47:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:47:29 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add collection, location, |Add collection, location, |and callnumber as filters |and callnumber filters to |to report for most |report for most circulated |circulated items |items --- Comment #9 from Katrin Fischer --- We should fix these reports sometime... but I am ok with 'not right now' :) I will attach a patch with some tiny follow-ups to the terminology used, can you please take a look? Also a question, why these commented out lines? + # These limits does not currently exist, maybe later? + # $colfilter[0] = @$filters[6] if ($column =~ /ccode/ ) ; + # $colfilter[0] = @$filters[7] if ($column =~ /location/ ) ; + $colfilter[0] = @$filters[8] if ($column =~ /category/ ) ; + # This commented out row (sort2) was not removed when adding new filters for ccode, shelving location and call number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:49:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:49:13 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 --- Comment #10 from Katrin Fischer --- Created attachment 45246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45246&action=edit Bug 10154: QA follow-up - Spelling and terminology - Changing capitalization: Any Patron category > Any patron category - Changing Collection code > Collection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:50:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:50:04 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:55:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:55:23 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #1 from Jen Zajac --- Created attachment 45247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45247&action=edit Bug 15269: Layout tweaks for the opac-detail page Make the following improvements to the layout of the OPAC detail page: * Image thumbnail has more white space * Summary is moved up the details block and font size is increased * Ratings controls are moved up the details * Small devices get a better layout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:55:42 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #2 from Jen Zajac --- Created attachment 45248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45248&action=edit Bug 15269: Compiled CSS changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 00:58:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Nov 2015 23:58:11 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #3 from Jen Zajac --- Created attachment 45249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45249&action=edit Screenshot of updated layout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:07:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:07:26 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:09:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:09:03 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jen at catalyst.net.nz |oleonard at myacpl.org Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:08:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:08:51 +0000 Subject: [Koha-bugs] [Bug 10468] Add pending holds to summary print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:08:44 +0000 Subject: [Koha-bugs] [Bug 10468] Add pending holds to summary print In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|patron print summary should |Add pending holds to |show more |summary print Status|Passed QA |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:07:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:07:29 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45217|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 45250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45250&action=edit [PASSED QA] Bug 10468: Adding holds table to summary print To test: 1) Add a hold to a patron 2) Go to patron page 3) Click Print Summary 4) Confirm that 'Pending Holds' table displays with correct information under appropriate headings (should be Title, Author, Placed on (reserve date), Expires on (expiration date), and Pick up library) Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:25:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:25:35 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45247|0 |1 is obsolete| | Attachment #45248|0 |1 is obsolete| | --- Comment #4 from Jen Zajac --- Created attachment 45251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45251&action=edit Bug 15269 [ENH]: Compiled CSS changes Sponsored-by: ByWater -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:28:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:28:16 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #5 from Jen Zajac --- Created attachment 45252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45252&action=edit Bug 15269 [ENH]: Layout tweaks for the opac-detail page Make the following improvements to the layout of the OPAC detail page: * Image thumbnail has more white space * Summary is moved up the details block and font size is increased * Ratings controls are moved up the details * Small devices get a better layout Sponsored-by: ByWater -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:28:28 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45251|0 |1 is obsolete| | --- Comment #6 from Jen Zajac --- Created attachment 45253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45253&action=edit Bug 15269 [ENH]: Compiled CSS changes Sponsored-by: ByWater -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:30:40 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #7 from Jen Zajac --- Sorry, the changes were just for commit message formatting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 01:36:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 00:36:41 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jen at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:17:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 08:17:35 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 --- Comment #11 from Eivin Giske Skaaren --- (In reply to Katrin Fischer from comment #9) > We should fix these reports sometime... but I am ok with 'not right now' :) > > I will attach a patch with some tiny follow-ups to the terminology used, can > you please take a look? > > Also a question, why these commented out lines? > + # These limits does not currently exist, maybe later? > + # $colfilter[0] = @$filters[6] if ($column =~ /ccode/ ) ; > + # $colfilter[0] = @$filters[7] if ($column =~ /location/ ) ; > + $colfilter[0] = @$filters[8] if ($column =~ /category/ ) ; > + # This commented out row (sort2) was not removed when adding new > filters for ccode, shelving location and call number I will take a look at the QA follow up tonight. For the commented out lines there were 2 considerations: 1. One already commented out line that seemed out of place but I did not remove it. 2. Fill in gaps just to make the magic numbers less confusing. It is easy to overlook a missing row etc in this type of code. I can remove the commented out code if that is preferred. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 09:47:42 +0000 Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables server-side processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 --- Comment #24 from Jonathan Druart --- (In reply to Barton Chittenden from comment #23) > Is it possible to port this back to 3.18? I don't think it's a good idea. The patches don't apply and the dependency tree is quite important (most of them are not in 3.18 yet). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 09:50:36 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 --- Comment #6 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #5) > Does this patch need to be backported to 3.20.x? As bug 14069 is in 3.20.x I would say yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 09:53:16 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #7 from Jonathan Druart --- (In reply to Tom Misilo from comment #6) > Did this make it into 3.22? Or was it pushed back to the next release? I > didn't notice it in the release notes. Thanks! No, it has not been pushed yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:08:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 10:08:13 +0000 Subject: [Koha-bugs] [Bug 15270] New: Koha::Objects->find can exploded if searching for nonexistent record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Bug ID: 15270 Summary: Koha::Objects->find can exploded if searching for nonexistent record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:11:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 10:11:54 +0000 Subject: [Koha-bugs] [Bug 15239] Add multiple items fail on barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- Could this be related to/similar to Bug 15042? Just a hunch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:15:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 10:15:29 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:15:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 10:15:31 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #1 from Jonathan Druart --- Created attachment 45254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45254&action=edit Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:17:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 10:17:52 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45254|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 45255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45255&action=edit Bug 15270: Add regression tests for Koha::Objects->find -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:18:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 10:18:10 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #3 from Jonathan Druart --- Created attachment 45256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45256&action=edit Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:18:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 10:18:30 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45256|Bug 15270: Make |[FOR 3.20.X ONLY] Bug description|Koha::Objects->find return |15270: Make |undef instead of crashing |Koha::Objects->find return | |undef instead of crashing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:19:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 10:19:26 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #4 from Jonathan Druart --- The 2 patches are for 3.20.x but it would be good to get the first one (the tests) on master too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:54:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 10:54:47 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #49 from Leif Andersson --- (In reply to David Cook from comment #47) > Leif and Andreas: > > If I understand correctly, your main use case for matching would be to make > sure that records previously imported from the union catalogue aren't > duplicated when you start using OAI-PMH, yes? > > In that case, would matching on the 001 be suitable? > If we are only importing from one source, 001 would be fine. But if we will be using several sources for our imports, then relying on 001 would sooner or later result in a "false matcning" where we end up having one record overwritten by a totally different one. How reliable would it be to add in 003? In MARC21 003 is the alphanumeric "MARC code for the organization whose control number is contained in field 001". I don't know how this fits UNIMARC, though. David suggested in a mail (to Koha devel list) to move field 001 to 035. Or even 001 + 003 to 035 In doing so some refinements could be done to this matching point (e.g. normalization, if 003 is empty then add what we know about the exporting catalog etc) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:00:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 11:00:44 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #1 from Alex Arnaud --- Created attachment 45257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45257&action=edit Bug 15188 - remove_unused_authorities.pl exit if all authorities should be deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:01:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 11:01:09 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:07:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 11:07:15 +0000 Subject: [Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188 --- Comment #2 from Alex Arnaud --- It looks like ZOOM module behaves like connection was established when zebra is not running (No error code, no error message or exception). I have libnet-z3950-zoom-perl 1.26 on debian wheezy. It would be interesting to test with version 1.30 (jessie package) but for wheezy i think the best fix is to ensure that all authorities will not be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 13:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 12:21:28 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 13:21:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 12:21:31 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 --- Comment #4 from Jonathan Druart --- Created attachment 45258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45258&action=edit Bug 15163: Do not erase patron attributes if limited to another library The patron attributes displayed on editing a patron are not displayed if limited to another library. This is the easy but dirty way to fix this issue: It supposes that the data are not sensitive as they are now displayed in the html document. A better way to fix it would be to modify C4::Members::Attributes::SetBorrowerAttributes to delete only attributes we are editing. Test plan: 1/ Create 2 patron attributes, without branch limitations. 2/ Edit a patron and set a value for these attributes 3/ Limit a patron attributes to a library (one you are not logged in with). 4/ Edit again the patron. => You should not see the limited attributes 5/ Edit the patron attributes and remove the branch limitation => Without this patch, it has been removed from the database and is not displayed anymore. => With this patch, you should see it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 13:22:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 12:22:23 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #5 from Jonathan Druart --- I have failed to provide a correct patch for this fix in a respectable time. This one should fix the issue but it is not the best way to do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 13:55:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 12:55:30 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #5 from Marc V?ron --- Created attachment 45259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45259&action=edit Bug 15163: Do not erase patron attributes if limited to another library The patron attributes displayed on editing a patron are not displayed if limited to another library. This is the easy but dirty way to fix this issue: It supposes that the data are not sensitive as they are now displayed in the html document. A better way to fix it would be to modify C4::Members::Attributes::SetBorrowerAttributes to delete only attributes we are editing. Test plan: 1/ Create 2 patron attributes, without branch limitations. 2/ Edit a patron and set a value for these attributes 3/ Limit a patron attributes to a library (one you are not logged in with). 4/ Edit again the patron. => You should not see the limited attributes 5/ Edit the patron attributes and remove the branch limitation => Without this patch, it has been removed from the database and is not displayed anymore. => With this patch, you should see it. Followed test plan, works as described. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 13:56:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 12:56:51 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 13:57:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 12:57:33 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #45259|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Comment on attachment 45259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45259 Bug 15163: Do not erase patron attributes if limited to another library Wrong bug numer, sorry for the noise... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 13:58:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 12:58:03 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45258|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 45260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45260&action=edit Bug 15163: Do not erase patron attributes if limited to another library The patron attributes displayed on editing a patron are not displayed if limited to another library. This is the easy but dirty way to fix this issue: It supposes that the data are not sensitive as they are now displayed in the html document. A better way to fix it would be to modify C4::Members::Attributes::SetBorrowerAttributes to delete only attributes we are editing. Test plan: 1/ Create 2 patron attributes, without branch limitations. 2/ Edit a patron and set a value for these attributes 3/ Limit a patron attributes to a library (one you are not logged in with). 4/ Edit again the patron. => You should not see the limited attributes 5/ Edit the patron attributes and remove the branch limitation => Without this patch, it has been removed from the database and is not displayed anymore. => With this patch, you should see it. Followed test plan, works as described. Signed-off-by: Marc V?ron http://bugs.koha-community.org/show_bug.cgi?id=15165 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 13:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 12:58:42 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:04:40 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #86 from Jonathan Druart --- Good catch Bernardo. Fixed. commit de101ae8b8e04eeb04abe83cbb69cc02bfa87eff Bug 13618: Fix for edit biblios and items On editing biblios or items, the marc_lib, marc_value and javascript values are often populated with html code which needs to be displayed raw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:07:22 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|maxime.beaulieu at inlibro.com |bouzid.fergani at inlibro.com CC| |bouzid.fergani at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:11:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:11:21 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #27 from Marc V?ron --- Applying the patches does some auto-merging: Auto-merging t/db_dependent/Budgets.t Auto-merging C4/Budgets.pm After that, t/db_dependent/Budgets.t fails (it passed OK without patches): Test Summary Report ------------------- t/db_dependent/Budgets.t (Wstat: 65280 Tests: 76 Failed: 1) Failed test: 76 Non-zero exit status: 255 Parse errors: Bad plan. You planned 122 tests but ran 76 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:14:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:14:32 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:25:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:25:16 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 --- Comment #5 from Marc V?ron --- Created attachment 45261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45261&action=edit Bug 15238: (followup) Remove word 'Note:' 'Note: ' removed as requested in comment #3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:53:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:53:44 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 --- Comment #6 from Galen Charlton --- Because overdue fines include title and original due date in the description, and because UpdateFine matches on the due date in the description when finding an existing account line to update... this script would still be a useful thing to run if ever a library decides to change the dateformat system preference. Of course, changing the dateformat is not a common decision. My vote: keep this script until such time as Koha no longer relies on matching dates in the description to find accountlines to update when adjusting an overdue fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:54:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:54:42 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:54:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:54:45 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45255|0 |1 is obsolete| | Attachment #45256|0 |1 is obsolete| | --- Comment #5 from Magnus Enger --- Created attachment 45262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45262&action=edit Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. Signed-off-by: Magnus Enger Set AnonymousPatron pref to a nonexistent borrowernumber. Before the patch, about.pl shows a nasty error. After applying the patch the error is gone. Tests in t/db_dependent/Objects.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:56:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:56:06 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #6 from Magnus Enger --- Created attachment 45263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45263&action=edit Bug 15270: Add regression tests for Koha::Objects->find Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:58:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 13:58:39 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45183|0 |1 is obsolete| | --- Comment #19 from Charles Farmer --- Created attachment 45264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45264&action=edit Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues There is already a syspref called "OverdueNoticeBcc" for sending Bcc copies of mails sent for overdues and other notices. This patch add a new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues alerts. Changed the wording of the system preference to: [Send|Don't send] blind copy (BCC) to logged in user when sending serial or acquisitions claims notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:06:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:06:39 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:08:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:08:40 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jen at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:14:44 +0000 Subject: [Koha-bugs] [Bug 15271] New: Calendar breaks on double quotes in title or description of holiday Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15271 Bug ID: 15271 Summary: Calendar breaks on double quotes in title or description of holiday Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If a holiday contains a double quote character in either the title or description a javascript error is thrown which prevents the datepicker fromm loading. To recreate: 1 - define a holiday (single or repeated) with a double quote in either title or description 2 - Date picker disappears and you cannot edit the holiday -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:14:49 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:14:52 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45173|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45265&action=edit Bug 15250: Fix Perl error on acqisition stats page To test: - Go to reports -> Acquisitions statistics - Populate with the following values: Acquisitions statistics Received on. Row: checked Column: checked From: 01/01/2015 To: Un-selected Cell value Count items Output: To screen into the browser: checked - Running the report will trigger the following error: Software error: Can't locate object method "field" via package "aqorders.datereceived" (perhaps you forgot to load "aqorders.datereceived"?) at /usr/share/koha/intranet/cgi-bin/reports/acquisitions_stats.pl line 293. - Apply the patch and repeat test - Verify the report now works correctly Note: Patch was created from notes and suggested fix on the bug report, written by Barton Chittenden. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:15:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:15:33 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |12151 --- Comment #4 from Jonathan Druart --- Introduced by commit 82e8a7a155807f50edae4e5f2b46791479c9b92d Date: Sat May 31 00:30:32 2014 -0300 Bug 12151: Remove uses of smartmatch operator in report scripts Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 [Bug 12151] remove remaining uses of the Perl smartmatch operator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:15:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:15:33 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15250 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:18:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:18:31 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #8 from Owen Leonard --- My initial reaction is that this looks really great. I'm going to test, but I want to point out that this bug has no test plan where it really needs a very vigorous one. There are a lot of OPAC settings which need to be tested on and off, and with XSLT turned on and off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:20:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:20:26 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:20:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:20:29 +0000 Subject: [Koha-bugs] [Bug 9184] Ordering from staged file in acq should not offer authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9184 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45176|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 45266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45266&action=edit Bug 9184: Acq - Don't show authority batches when ordering from staged file When ordering from a staged file, the list of files should only include imports of bilbiographic and no authority data. To test - start without the patch: 1) Stage an authority file 2) Stage a bilbiographic file 3) Create a new basked in acquisitions 4) Create a new order line selecting "From a staged file" 5) Verify that both files are shown 6) Apply patch 7) Verify that only the bibliographc file shows in the list now Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:22:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:22:53 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13104 --- Comment #7 from Marc V?ron --- (In reply to Galen Charlton from comment #6) > Because overdue fines include title and original due date in the > description, and because UpdateFine matches on the due date in the > description when finding an existing account line to update... this script > would still be a useful thing to run if ever a library decides to change the > dateformat system preference. > > Of course, changing the dateformat is not a common decision. > > My vote: keep this script until such time as Koha no longer relies on > matching dates in the description to find accountlines to update when > adjusting an overdue fine. Hi Galen, So I think we would have to make this bug dependent of a bug that resolves the issue. Is there a bug about the issue regarding matching dates? I only found: Bug 13104 - Changing date or time format on a production server will create duplicate fines! (It adds the note about duplicate fines to the syspref 'dateformat') Bug 12188 - fines duplicated after changing dateformat (Resolved - duplicate of 13104) I tried to find out where in the code the duplication happens, but I had no success. Any hint is welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:22:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:22:53 +0000 Subject: [Koha-bugs] [Bug 13104] Changing date or time format on a production server will create duplicate fines! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15076 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:23:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:23:24 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12188 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:23:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:23:25 +0000 Subject: [Koha-bugs] [Bug 12188] fines duplicated after changing dateformat In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12188 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15076 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:28:28 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:28:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:28:54 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45261|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 45267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45267&action=edit [SIGNED-OFF]Bug 15238: (followup) Remove word 'Note:' 'Note: ' removed as requested in comment #3 Signed-off-by: Hector Castro Word 'Note' removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:28:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:28:58 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #24 from Blou --- If I summarize, - Need for the help file to be modified - Require dropdown at the server level. We do not understand that last one : "As David said, I don't think it's a good idea to add this field at the server level, we could have the need to use 4=109 and 4=1 in the same query. A dropdown list in front of each field sounds more useful and flexible." The 4=109 4=1 are currently possible with this patch. As for the dropdown, where would that be? I can't picture it, I'm sorry. But wherever, that would be a more complex patch for a specialized need that "if you need it, you'll know what to do here". IMO. I'm sorry I can't offer any other use case. For us it's major since EVERYBODY requires this since this is our national library's z3950 that needs it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:30:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:30:24 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45128|0 |1 is obsolete| | Attachment #45180|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 45268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45268&action=edit Bug 15216: Returns - Show branch names and item type description Changes the table with returned items to display the branch names for home and holding branch and the itemtype description instead of the codes. To test: - Check out some items - Return the items - Verify the changes in the table of returned items Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:30:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:30:21 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:30:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:30:30 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 --- Comment #10 from Jonathan Druart --- Created attachment 45269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45269&action=edit Bug 15216: Returns - Show collection description The table of returns displays the collection code instead of the description. This patch fixes that. Same as first patch: To test: - Check out some items - Return the items - Verify the changes in the table of returned items Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:31:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:31:25 +0000 Subject: [Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |normal --- Comment #11 from Jonathan Druart --- I think this one can be considered as a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:31:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:31:26 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #20 from Katrin Fischer --- Hi Charles, for a small change request like this doing a follow-up patch and keep the 'Signed-off' would be ok next time! I just noticed comment#2 from Srdjan - can you comment on that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:47:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:47:23 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:47:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:47:25 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45235|0 |1 is obsolete| | Attachment #45236|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 45270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45270&action=edit Bug 15258: Fix Perl scripts declaring unused variables Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:47:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:47:32 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 --- Comment #10 from Jonathan Druart --- Created attachment 45271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45271&action=edit Bug 15258: Prevent unused declared variables Add a perlcritic rule to 00-perlcritic.t to prevent unused declared variable. TO TEST: - Apply the 1st patch (unit test) - Run the UT: prove -v t/00-testcritic.t - Note that several Perl script fail - Apply the 2nd patch - Run the UT, and confirm it passes. Signed-off-by: Hector Castro All tests pass successful. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:48:27 +0000 Subject: [Koha-bugs] [Bug 15258] Prevent unused declared variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart --- Well done Fr?d?ric :) I have added a new rule to the qa script: commit e50dc8eae505819ff3c9a7af67de7e2498c66902 CommitDate: Tue Dec 1 14:45:37 2015 +0000 Add ProhibitUnusedVariables to perlcritic rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:51:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:51:08 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 --- Comment #5 from Owen Leonard --- (In reply to Liz Rea from comment #4) > Buttons gone funky Thanks. FWIW I can see something similar in Chromium but not in Firefox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:54:12 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:54:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:54:14 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45033|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 45272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45272&action=edit [SIGNED-OFF] Bug 15213 - fix buttons on patron lists To test: go to tools -> patron lists notice that the buttons are not misaligned anymore You may need to force refresh the page to see the original issue, and to see it fixed. http://bugs.koha-community.org/show_bug.cgi?id=15223 Signed-off-by: Owen Leonard I can reproduce the problem in Chromium and the patch fixes it. No adverse effects in Firefox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:55:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:55:54 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #21 from Charles Farmer --- (In reply to Katrin Fischer from comment #20) > Hi Charles, > for a small change request like this doing a follow-up patch and keep the > 'Signed-off' would be ok next time! > I just noticed comment#2 from Srdjan - can you comment on that? Hi Katrin, Maxime already took care of it. This problem is avoided in the patch by first checking if the letter type is 'claimacquisition' or 'claimissues'. Never should a BCC be sent otherwise. I unfortunately cannot unit test this part though, because the email is never queued anywhere. But from the code, it looks like no unwanted BCC can be sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:57:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:57:15 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #10 from Marc V?ron --- (In reply to Fr?d?ric Demians from comment #8) > > But the description says: > > Show the following fields from the items database table as columns on the > > statistics tab on the patron record (...) > > > > I understand this as 'any' colums, not only location,itype and ccode > > Sorry, you're correct! My patch would be a severe regression for libraries > using other fields from 'items' table. > > What prevents me from signing your patch is that I don't like the idea of > checking the existence of items field (by calling DESCRIBE items) each time > the statistics fields are required. Have you explored the possibility using > the column setting tool? Here: > > /cgi-bin/koha/admin/columns_settings.pl Hi Fr?d?ric, I have no resources at the moment to implement a solution based on columns_settings.pl Since my patch resolves a bug that leads to a software error, I propose to use it as an immediate solution and then file a new bug for the solution you propose. What do you think about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:58:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:58:00 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #13 from Owen Leonard --- (In reply to Jonathan Druart from comment #12) > Could you detail how you managed to insert an invalid date? I typed it in the date input field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:58:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 14:58:30 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #9 from H?ctor Eduardo Castro Avalos --- (In reply to Owen Leonard from comment #8) > My initial reaction is that this looks really great. I'm going to test, but > I want to point out that this bug has no test plan where it really needs a > very vigorous one. There are a lot of OPAC settings which need to be tested > on and off, and with XSLT turned on and off. You're right Owen. Nice work Jen, the screen layout looks much better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:06:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:06:53 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12979 | --- Comment #14 from Marc V?ron --- Still applies. Removed 12979 as blocking (12979 is pushed to Master). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 [Bug 12979] Price formatting should only be defined at one place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:06:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:06:53 +0000 Subject: [Koha-bugs] [Bug 12979] Price formatting should only be defined at one place In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|4078 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Display active currency symbol on currency output and input -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:11:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:11:34 +0000 Subject: [Koha-bugs] [Bug 13093] Allow/Don't allow holds on items with set statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13093 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:11:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:11:40 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #10 from Marc V?ron --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:18:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:18:31 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #14 from Barton Chittenden --- (In reply to Colin Campbell from comment #2) > Upping priority as this needs applying to releases from 3.18.7 to stop > communication errors on renew. The change causing the error was bug 13315 I see that this has been pushed to 3.20.x, can we get it back-ported to 3.18.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:28:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:28:03 +0000 Subject: [Koha-bugs] [Bug 11038] Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:28:05 +0000 Subject: [Koha-bugs] [Bug 11038] Enable use of IntranetUserCSS and intranetcolorstylesheet on staff client login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45237|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 45273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45273&action=edit Bug 11038: Enable use of IntranetUserCSS on staff client login page This patch enable use of IntranetUserCss on staff client login page. To test: 1) Add something to IntranetUserCSS to modify login page, for example #login h1 a { height:30px; } 2) Logout from staff client, no changes on login page. 3) Apply the patch 4) Reload, now logo is cut in half :) Bonus) Login again an try changing image, add #login h1 { background: url(http://example.com/img/other-logo.png) no-repeat top center; } and fix height. Logout and check This also affects 3.20 and perhaps earlier versions. Re-upload to fix examples Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:32:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:32:24 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 --- Comment #16 from Marc V?ron --- Created attachment 45274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45274&action=edit Bug 15049: (Signed off) Hide currency but preserv alert This follow up hides currency, but the alert pops if no currency is active. To test: 1) Apply the patch 2) Unset any active currency 3) Alert must show on Acquisitons home 4) Set a currency active, no currency display on Acqui home 5) Check that currency IS displayed on /cgi-bin/koha/admin/aqbudgets.pl or /cgi-bin/koha/admin/aqbudgetperiods.pl Amended for better translation Currency does / does not display as described in test plan. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:33:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:33:23 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:33:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:33:25 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44152|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:33:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:33:27 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44359|0 |1 is obsolete| | Attachment #44360|0 |1 is obsolete| | Attachment #44361|0 |1 is obsolete| | Attachment #44362|0 |1 is obsolete| | Attachment #44363|0 |1 is obsolete| | --- Comment #53 from Kyle M Hall --- Created attachment 45275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45275&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:33:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:33:40 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #54 from Kyle M Hall --- Created attachment 45276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45276&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:33:44 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #55 from Kyle M Hall --- Created attachment 45277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45277&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:33:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:33:48 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #56 from Kyle M Hall --- Created attachment 45278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45278&action=edit Bug 8352 [QA Followup] * Add --confirm option to print_holds.pl * Modify old_reserves to match reserves Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:33:53 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #57 from Kyle M Hall --- Created attachment 45279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45279&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files Signed-off-by: Jenice Tate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:36:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:36:47 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12979 --- Comment #15 from Jonathan Druart --- (In reply to Marc V?ron from comment #14) > Still applies. > Removed 12979 as blocking (12979 is pushed to Master). I think it's a good thing to keep the dependencies, even when the patches are pushed. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 [Bug 12979] Price formatting should only be defined at one place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:36:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:36:47 +0000 Subject: [Koha-bugs] [Bug 12979] Price formatting should only be defined at one place In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4078 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Display active currency symbol on currency output and input -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:38:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:38:31 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 --- Comment #17 from Marc V?ron --- Note regarding comment #15 (...) Strange enough, with manage_circ_rules I can not only edit the circulation rules (what I would expect), but it seems that it allows to edit ALL of the parameters. I think this is a bug, what is yout opinion about? (...) This is not related to this bug. If it is an issue it should have it's own bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:40:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:40:51 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 --- Comment #18 from Marc V?ron --- If there is no ogjection I propose to switch the status to signed-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:41:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:41:37 +0000 Subject: [Koha-bugs] [Bug 15265] Instagram and pintrest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master --- Comment #1 from Owen Leonard --- I think all social media links should be made to be controlled by some kind of setting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:44:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:44:17 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45272|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Comment on attachment 45272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45272 [SIGNED-OFF] Bug 15213 - fix buttons on patron lists Sorry, wrong bug report! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:44:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:44:49 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED Patch complexity|Trivial patch |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:46:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:46:32 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 --- Comment #2 from Marc V?ron --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:57:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 15:57:40 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #46 from Kyle M Hall --- (In reply to Nick Clemens from comment #45) > I can't get SMS provider to save upon edit, and changing it through DB I > didn't get the email I can't reproduce your issue. Did you run updatedatabase.pl? Have you verified your server can send outgoing email successfully? Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:02:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 16:02:52 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #21 from Kyle M Hall --- (In reply to Mason James from comment #19) > (In reply to Kyle M Hall from comment #11) > > I see. I hadn't looked deeply enough to realize 1 was the card number. In > > that case my solution won't work. > > > > (In reply to Katrin Fischer from comment #10) > > > ... and 1 being the cardnumber. > > just to confirm, (1) appears to be random string from within the Overdrive > app > ..it's not related to any 'id' within Koha So for the patron status response, Koha is sending back the "(1)" but not for the patron information response? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:12:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 16:12:35 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 jvr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:21:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 16:21:12 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t fails with test 14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m --- Comment #1 from Jesse Weaver --- Cannot duplicate on latest master: [elf]:~/p/koha> prove t/db_dependent/Reserves.t -- [2015-12-01 09:12] ----------------------------------------------------------------------------------------------------------------------- t/db_dependent/Reserves.t .. 1/73 Subroutine C4::Context::userenv redefined at t/db_dependent/Reserves.t line 44. t/db_dependent/Reserves.t .. 2/73 C4::Context->userenv not defined! at /home/feoh3/p/koha/C4/Items.pm line 2336. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=73, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.34 cusr 0.06 csys = 1.43 CPU) Result: PASS That's even more worrisome, though. Marc, what's confusing to me is that borrower 277 shouldn't exist, from my reading of the test. $requestors{RPL} is the last borrower to be added. If this is reproducible, could you add in a: warn Dumper( GetMember( borrowernumber => $messages->{ResFound}->{borrowernumber} ) ); just before the failing test? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:35:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 16:35:14 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t fails with test 14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 --- Comment #2 from Marc V?ron --- With additional line 280: warn Dumper( GetMember( borrowernumber => $messages->{ResFound}->{borrowernumber} ) ); ...I get... ok 13 - restrictive library's items only fill requests by own patrons (bug 10272) $VAR1 = { 'category_type' => 'A', 'categorycode' => 'PT', 'B_address' => undef, 'ethnicity' => undef, 'contactnote' => undef, 'email' => undef, 'password' => '!', 'B_country' => undef, 'borrowernumber' => '267', 'branchcode' => 'CPL', 'lost' => undef, 'description' => 'Erwachsener', 'streettype' => undef, 'altcontactaddress3' => undef, 'contactfirstname' => undef, 'title' => undef, 'ethnotes' => undef, 'relationship' => undef, 'mobile' => undef, 'fax' => undef, 'primary_contact_method' => undef, 'altcontactphone' => undef, 'contactname' => undef, 'country' => undef, 'dateenrolled' => '2015-11-25', 'altcontactstate' => undef, 'guarantorid' => undef, 'address2' => undef, 'borrowernotes' => undef, 'dateexpiry' => '2016-11-25', 'sort2' => undef, 'contacttitle' => undef, 'phonepro' => undef, 'smsalertnumber' => undef, 'B_streetnumber' => undef, 'emailpro' => undef, 'altcontactcountry' => undef, 'firstname' => undef, 'gonenoaddress' => undef, 'othernames' => undef, 'dateofbirth' => undef, 'state' => undef, 'altcontactaddress2' => undef, 'B_streettype' => undef, 'debarred' => undef, 'B_state' => undef, 'B_address2' => undef, 'address' => '', 'privacy' => '1', 'streetnumber' => undef, 'surname' => 'borrower from CPL', 'cardnumber' => undef, 'altcontactsurname' => undef, 'altcontactzipcode' => undef, 'altcontactfirstname' => undef, 'opacnote' => undef, 'userid' => 'borrowerfromcpl', 'B_zipcode' => undef, 'B_email' => undef, 'city' => '', 'B_phone' => undef, 'debarredcomment' => undef, 'initials' => undef, 'sort1' => undef, 'flags' => undef, 'zipcode' => undef, 'phone' => undef, 'sex' => undef, 'altcontactaddress1' => undef, 'B_city' => undef }; not ok 14 - for generous library, its items fill first hold request in line (bug 10272) # Failed test 'for generous library, its items fill first hold request in line (bug 10272)' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:54:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 16:54:09 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|On renewal, the last fine |Fine not updated from 'FU' |is not marked as |to 'F' on renewal |accounttype 'F' when item | |is checked in. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:55:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 16:55:01 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:55:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 16:55:04 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44603|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 45280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45280&action=edit Bug 14390 [QA Followup] - Unit Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:55:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 16:55:12 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #15 from Kyle M Hall --- Created attachment 45281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45281&action=edit Bug 14390 - Fine not updated from 'FU' to 'F' on renewal Test Plan: 1) Find an overdue checkout with a fine 2) Renew item, note fine is not closed out (Account type F) 3) Apply this patch 4) Find another overdue checkout with a fine 5) Renew item, note fine is now correctly closed out 6) Backdate a checkout to be already overdue ( but not have a fine since fines.pl hasn't run yet ) 7) Renew item, note a closed out fine is created Signed-off-by: Sean Minkel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:57:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 16:57:51 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #16 from Kyle M Hall --- > 1) some problem noted by the QA script: > > FAIL C4/Circulation.pm > OK critic > OK forbidden patterns > OK pod > OK spelling > FAIL valid > "my" variable $borrower masks earlier declaration in same scope I cannot reproduce this qa bark. perl -c also doesn't give me any warnings. > 2) Also: can you please shorten the bug title a bit and explain what the > consequence of the fine not changed is in the commit message? Done! There is little consequence to the bug except that lots of closed out fines appear to be accruing from a librarian's perspective. > 3) I'd really like to see a regression test highlighting the changed > behaviour. Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:04:15 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #17 from Jonathan Druart --- (In reply to Kyle M Hall from comment #16) > > 1) some problem noted by the QA script: > > > > FAIL C4/Circulation.pm > > OK critic > > OK forbidden patterns > > OK pod > > OK spelling > > FAIL valid > > "my" variable $borrower masks earlier declaration in same scope > > I cannot reproduce this qa bark. perl -c also doesn't give me any warnings. perl -w will give you the warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:10:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:10:28 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t fails with test 14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 --- Comment #3 from Marc V?ron --- If I dump $messages (line 284) (undef, $messages, undef, undef) = AddReturn('bug10272_FPL', 'FPL'); warn Dumper( $messages ); ...I get...: $VAR1 = { 'NotIssued' => 'bug10272_FPL', 'ResFound' => { 'itemnumber' => '295', 'priority' => 2, 'reservenotes' => '', 'ResFound' => 'Reserved', 'reservedate' => '2015-12-01', 'found' => undef, 'timestamp' => '2015-12-01 18:04:24', 'biblionumber' => '45049', 'waitingdate' => undef, 'cancellationdate' => undef, 'reserve_id' => '151', 'borrowernumber' => '276', 'branchcode' => 'FPL' } }; That means that the item was not issued? - Test expects 'ResFound' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:25:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:25:35 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from H?ctor Eduardo Castro Avalos --- Hi Jen Average rating disappear when there not exists summary in record. Test with another book without summary (520) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:31:05 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t fails with test 14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 --- Comment #4 from Marc V?ron --- Ok previous comment was a mistake. I added the following after AddReturn (line 285): warn Dumper( $messages ); warn Dumper ($messages->{ResFound}->{borrowernumber}); warn Dumper ($requesters{'RPL'}); And I get: $VAR1 = { 'NotIssued' => 'bug10272_FPL', 'ResFound' => { 'itemnumber' => '301', 'priority' => 2, 'reservenotes' => '', 'ResFound' => 'Reserved', 'reservedate' => '2015-12-01', 'found' => undef, 'timestamp' => '2015-12-01 18:25:57', 'biblionumber' => '45053', 'waitingdate' => undef, 'cancellationdate' => undef, 'reserve_id' => '203', 'borrowernumber' => '292', 'branchcode' => 'FPL' } }; $VAR1 = '292'; $VAR1 = '293'; ...and for the next run it is $VAR1 = '300'; $VAR1 = '301'; Hmm, is the database not properly reset after the tests? The borrower numbers increase with every run. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:35:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:35:13 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:35:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:35:16 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #14 from Jonathan Druart --- Created attachment 45282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45282&action=edit Bug 14060: Force the input to contain a valid date Before this patch, the user was still allowed to enter a valid date. Now, if the date is not valid, the input is emptied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:35:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:35:53 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #15 from Jonathan Druart --- (In reply to Owen Leonard from comment #13) > (In reply to Jonathan Druart from comment #12) > > Could you detail how you managed to insert an invalid date? > > I typed it in the date input field. Indeed :) I was using another version of the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:50:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:50:48 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:50:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:50:51 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38503|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 45283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45283&action=edit Bug 13024 - Nonpublic note not appearing in the staff client The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) Test Plan: 1) Ensure your non-public note field is mapped to the items.itemnotes_nonpublic database column 2) Edit an item, add a test nonpublic note 3) Check out the item, verify the note is visible in the checkouts table 4) Check in the item, verify the note is visible in the checkins table 5) View the item details, verify the note is visible and editable if your account has the rights to edit items Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:51:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:51:01 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 --- Comment #7 from Kyle M Hall --- Created attachment 45284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45284&action=edit Bug 13024 [QA Followup] - Add nonpublic note to relatives' checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:52:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:52:59 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 --- Comment #8 from Kyle M Hall --- (In reply to Jonathan Druart from comment #4) > QA comments: > > 1/ The items.itemnotes does not appear in the return table (already before > this patch). I think it's because of circ/returns.pl: > 577 $ri{itemnote} = $biblio->{'itemnotes'}; > should be > 577 $ri{itemnote} = $item->{'itemnotes'}; Can't reproduce, is it fixed in master? > > 2/ The non public notes does not appear in the relatives issues table. > Fixed! > 3/ Do you know what is the span class "circ-hlt"? It makes text bold and red. Not sure why we only do that for notes on the day its checked out but that's how it is. > > Marked as Failed QA for 2, but it would be great to see 1 fixed too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 18:59:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 17:59:56 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #18 from Kyle M Hall --- Created attachment 45285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45285&action=edit Bug 14390 [QA Followup] - Fix warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 19:00:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 18:00:32 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #19 from Kyle M Hall --- (In reply to Jonathan Druart from comment #17) > (In reply to Kyle M Hall from comment #16) > > > 1) some problem noted by the QA script: > > > > > > FAIL C4/Circulation.pm > > > OK critic > > > OK forbidden patterns > > > OK pod > > > OK spelling > > > FAIL valid > > > "my" variable $borrower masks earlier declaration in same scope > > > > I cannot reproduce this qa bark. perl -c also doesn't give me any warnings. > > perl -w will give you the warnings. Thanks! Still not sure why koha-qa.pl didn't tell me that. Most odd. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 19:15:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 18:15:57 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t fails with test 14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- (In reply to Marc V?ron from comment #4) > $VAR1 = '292'; > $VAR1 = '293'; > > > ...and for the next run it is > $VAR1 = '300'; > $VAR1 = '301'; > > Hmm, is the database not properly reset after the tests? The borrower > numbers increase with every run. That's because the rollback is not resetting the AUTO_INCREMENT fields counter. MySQL behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:31:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 19:31:10 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t fails with test 14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 --- Comment #6 from Marc V?ron --- Found after systematically switching sysprefs: Syspref LocalHoldsPriority was set to "[Give] priority for filling holds to patrons whose... If I set it to [Don't give] the test passes OK. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:42:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 19:42:47 +0000 Subject: [Koha-bugs] [Bug 15244] Fix failing test 14 in t/db_dependent/Reserves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|t/db_dependent/Reserves.t |Fix failing test 14 in |fails with test 14 |t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:47:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 19:47:11 +0000 Subject: [Koha-bugs] [Bug 15244] Fix failing test 14 in t/db_dependent/Reserves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 --- Comment #7 from Tom?s Cohen Arazi --- Maybe the bug could be named "t/db_dependent/Reserves.t depends on external data/configuration" as the problem here is that the test doesn't set its needed variables before running. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 19:49:20 +0000 Subject: [Koha-bugs] [Bug 15244] Fix failing test 14 in t/db_dependent/Reserves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 --- Comment #8 from Marc V?ron --- Created attachment 45286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45286&action=edit Bug 15244: Fix failing test 14 in t/db_dependent/Reserves.t Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is set to "[Give] priority for filling holds to patrons whose... To verify: - Set syspref as above and run test. Test 14 fails. - Set syspref to [Don't give] and run test agein, it passes OK. To test: - Apply patch - Run test again with syspref set / not set Expected result: In both cases test should pass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:50:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 19:50:53 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix failing test 14 in |t/db_dependent/Reserves.t |t/db_dependent/Reserves.t |depends on external | |data/configuration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:52:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 19:52:42 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 --- Comment #9 from Marc V?ron --- Created attachment 45287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45287&action=edit Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is set to "[Give] priority for filling holds to patrons whose... To verify: - Set syspref as above and run test. Test 14 fails. - Set syspref to [Don't give] and run test agein, it passes OK. To test: - Apply patch - Run test again with syspref set / not set Expected result: In both cases test should pass (AMended to change bug title) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:52:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 19:52:59 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45286|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 19:54:43 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 21:00:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 20:00:53 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 --- Comment #12 from Eivin Giske Skaaren --- (In reply to Katrin Fischer from comment #10) > Created attachment 45246 [details] [review] > Bug 10154: QA follow-up - Spelling and terminology > > - Changing capitalization: Any Patron category > Any patron category > - Changing Collection code > Collection Sure we can change this. Before I reupload could you please let me know about what is preferred regarding the commented out lines. (Also since this is very minor changes perhaps you will just apply them when looking at this instead of me reuploading?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 21:18:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 20:18:06 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #28 from Bouzid --- Created attachment 45288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45288&action=edit Bug 11371 - QA fix 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 21:18:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 20:18:57 +0000 Subject: [Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45111|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 45289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45289&action=edit Bug 15243 - Place a hold on... Fix display issue and improve translatability Temporary patch, will need more work 1.12..2015/mv -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 21:20:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 20:20:58 +0000 Subject: [Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45289|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 45290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45290&action=edit Bug 15243 - Place a hold on... Fix display issue and improve translatability Temporary patch, will need more work 1.12..2015/mv -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 21:32:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 20:32:18 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #29 from Bouzid --- I fixed all tests for this patch, but a failed QA on the master before application of the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 21:32:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 20:32:49 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 21:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 20:33:59 +0000 Subject: [Koha-bugs] [Bug 15210] Novelist js throws an error if no ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |nick at bywatersolutions.com Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:10:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:10:02 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 --- Comment #10 from Marc V?ron --- Created attachment 45291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45291&action=edit Bug 15243 - Place a hold on... Fix display issue and improve translatability This patch fixes strings in request.tt that are untranslatable because of splitting by html tags inside the strings. Additionally, the value of maxreserves was used in one string, but not filled in every case. That's why the patch introduces a new function GetAllowedReserves in C4/Reserves.pm to retrieve the maximum count of allowed reserves (depending on syspref maxreserves and on issuingrules). To test: - If not yet done, apply patch from Bug 15244 - Run t/db_dependent/Reserves.t, verify that it passes OK - Apply this patch - Run t/db_dependent/Reserves.t again, should pass OK - Set syspref 'maxreserves' to 1 - Try to place a hold for a patron who already has holds - Verify that the warning message displays the value above - Set the syspref to a high value - Try to place a hold for a patron who has reached the maximum allowed holds defined by issuing rules - Verify that the warning message with the maximum number of holds allowed by issuing rules - Try to trigger other warning messages and/or carefully review code in request.tt line 307 and following. Additonal messages to trigger are: - Already in possession - Hold already placed - Age restricted - No items available - Too many holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:11:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:11:01 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45291|0 |1 is obsolete| | --- Comment #11 from Marc V?ron --- Comment on attachment 45291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45291 Bug 15243 - Place a hold on... Fix display issue and improve translatability Sorry, mistaked with bug number... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:11:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:11:43 +0000 Subject: [Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45290|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 45292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45292&action=edit Bug 15243 - Place a hold on... Fix display issue and improve translatability This patch fixes strings in request.tt that are untranslatable because of splitting by html tags inside the strings. Additionally, the value of maxreserves was used in one string, but not filled in every case. That's why the patch introduces a new function GetAllowedReserves in C4/Reserves.pm to retrieve the maximum count of allowed reserves (depending on syspref maxreserves and on issuingrules). To test: - If not yet done, apply patch from Bug 15244 - Run t/db_dependent/Reserves.t, verify that it passes OK - Apply this patch - Run t/db_dependent/Reserves.t again, should pass OK - Set syspref 'maxreserves' to 1 - Try to place a hold for a patron who already has holds - Verify that the warning message displays the value above - Set the syspref to a high value - Try to place a hold for a patron who has reached the maximum allowed holds defined by issuing rules - Verify that the warning message with the maximum number of holds allowed by issuing rules - Try to trigger other warning messages and/or carefully review code in request.tt line 307 and following. Additonal messages to trigger are: - Already in possession - Hold already placed - Age restricted - No items available - Too many holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:13:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:13:30 +0000 Subject: [Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:18:36 +0000 Subject: [Koha-bugs] [Bug 15272] New: vendor addresses are combined into "physical address" field Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 Bug ID: 15272 Summary: vendor addresses are combined into "physical address" field Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: rocio at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In the database, vendors can have text in up to 4 address fields. In the staff client, these 4 addresses appear in the same area next to a label of "Physical address". The addresses appear to belong to one field here, and are not separated by a space so the data looks bad. Clicking on Edit allows you to edit the "Physical address" box (containing the combined data from these 4 fields). If you modify the text in this box, and click save, you've modified the location of the data in the database. >From that point forward, the vendor only appears to have data in address1, and address2-address4 are set to NULL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:19:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:19:13 +0000 Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into "physical address" field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 rocio at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|vendor addresses are |aqbookseller addresses are |combined into "physical |combined into "physical |address" field |address" field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:19:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:19:53 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43489|0 |1 is obsolete| | Attachment #43490|0 |1 is obsolete| | Attachment #43491|0 |1 is obsolete| | Attachment #43492|0 |1 is obsolete| | Attachment #43493|0 |1 is obsolete| | Attachment #43494|0 |1 is obsolete| | --- Comment #26 from Barton Chittenden --- Created attachment 45293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45293&action=edit Bug 14292: Add patron category restrictions to longoverdue.pl Squashed prevoius patch set. Add command line options --category and --skip-category Convert usage() to pod2usage. (This was previous FIXME) Make borrower category handling more user friendly: Make --category and --skip-category mutally exclusive Check that categories specified by --category and --skip-category exist in categories table. Add --list-categories opttion to show available borrower categories. http://bugs.koha-community.org/show_bug.cgi?id=14292 QA Follow-up QA fixes - wording and trailing whitespaces Simplify the category list Basically we have 3 lists of categories: 1/ The full one, in the DB 2/ The one we want and list with --category 3/ The one we don't want and list with --skip-category The list of categories to process is: * 1 if none --category or --skip-category options are provided * 2 if --category is provided * 1 - 3 if --skip-category is provided (follow-up) Make --category and --skip-category case insensitive "my" variable $borrower_category masks earlier declaration in same scope "my" variable $skip_borrower_category masks earlier declaration in same scope Signed-off-by: hbraum at nekls.org Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:22:49 +0000 Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into "physical address" field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 rocio at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jweaver at bywatersolutions.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:24:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:24:28 +0000 Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into "physical address" field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 rocio at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rocio at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:26:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:26:10 +0000 Subject: [Koha-bugs] [Bug 15273] New: Fines Pay receipt should include all account lines selected for this pay Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 Bug ID: 15273 Summary: Fines Pay receipt should include all account lines selected for this pay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The fines payment process needs that the generated payment receipt contains all account lines selected for this payment. At now, it informs a laconic "Thanks". So all accounts lines selected and payed must be included in the payment receipt. Thus, librarians could print in only one receipt (the PAY one) all the accounts lines payed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:27:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:27:31 +0000 Subject: [Koha-bugs] [Bug 14668] Show serial enumeration in the checkin page and the patron's opac checkout summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:27:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:27:42 +0000 Subject: [Koha-bugs] [Bug 14668] Show serial enumeration in the checkin page and the patron's opac checkout summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 --- Comment #1 from Charles Farmer --- Created attachment 45294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45294&action=edit Bug 14668 - Show serial enumeration in the checkin page and the patron's opac checkout summary The enumchron is now displayed alongside the author name in the "Title" section of the item summary. TEST PLAN ========= 1) INTRANET 1) Edit an item and add something in the "h" subfield, ie: "volume #42" 2) Check out the item to a patron 3) In the patron page, both at the bottom of the page or in the "Check out" tab, you should see the enumchron concatenated with the title 2) OPAC 1) Search for the same patron you used earlier 2) In the "your summary" tab, you should see the enumchron in the Title 3) INTRANET 1) Check in the item you just borrowed 2) At check in, the enumchron should also appear in the Title. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:28:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:28:14 +0000 Subject: [Koha-bugs] [Bug 14668] Show serial enumeration in the checkin page and the patron's opac checkout summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com Assignee|koha-bugs at lists.koha-commun |charles.farmer at inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:29:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:29:47 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #30 from Marc V?ron --- Sorry, t/db_dependent/Budgets.t fails with: Parse errors: Bad plan. You planned 122 tests but ran 126. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:36:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:36:34 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45034|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 45295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45295&action=edit Bug 15213 - fix buttons on patron lists To test: go to tools -> patron lists notice that the buttons are not misaligned anymore You may need to force refresh the page to see the original issue, and to see it fixed. http://bugs.koha-community.org/show_bug.cgi?id=15223 With patch buttons display nicely. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:37:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:37:16 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 22:41:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 21:41:46 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #27 from Barton Chittenden --- Created attachment 45296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45296&action=edit Bug 14292: [Alternate for 3.18] Add patron category restrictions to longoverdue.pl This is the same patch set, rebased on 3.18.x Add command line options --category and --skip-category Convert usage() to pod2usage. (This was previous FIXME) Make borrower category handling more user friendly: Make --category and --skip-category mutally exclusive Check that categories specified by --category and --skip-category exist in categories table. Add --list-categories opttion to show available borrower categories. http://bugs.koha-community.org/show_bug.cgi?id=14292 QA Follow-up QA fixes - wording and trailing whitespaces Simplify the category list Basically we have 3 lists of categories: 1/ The full one, in the DB 2/ The one we want and list with --category 3/ The one we don't want and list with --skip-category The list of categories to process is: * 1 if none --category or --skip-category options are provided * 2 if --category is provided * 1 - 3 if --skip-category is provided (follow-up) Make --category and --skip-category case insensitive "my" variable $borrower_category masks earlier declaration in same scope "my" variable $skip_borrower_category masks earlier declaration in same scope Signed-off-by: hbraum at nekls.org Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:11:41 +0000 Subject: [Koha-bugs] [Bug 15274] New: Better translatability for circulation.pl / circulation.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Bug ID: 15274 Summary: Better translatability for circulation.pl / circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In /circ/circulation.pl, the sentence "Checkouts are BLOCKED because fine balance is OVER THE LIMIT." translates in German to: "Ausleihen sind GESPERRT weil Geb?hrenkonto ist ?BER BEGRENZUNG." That is simply wrong, and it is almost impossible to translate correctly because the strings are splitted by html tags. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:11:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:11:52 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #3 from Aleisha Amohia --- This patch works as expected! My only concern/problem is that going to More->Export today's checked in barcodes for a patron with settings set to "never" for keeping a reading history opens in a new tab. It would be good to stay on the same tab instead of opening another one as this makes it confusing for the user and things get a bit messy! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:13:46 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:13:46 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15274 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:21:27 +0000 Subject: [Koha-bugs] [Bug 15274] Better translatability for circulation.pl / circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14497 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:21:27 +0000 Subject: [Koha-bugs] [Bug 14497] Add warning to patron details page if patron's fines exceed noissuescharge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15274 --- Comment #4 from Marc V?ron --- This sentence will be almost intranslatable because it is splitted by html tags: Checkouts are BLOCKED because fine balance is OVER THE LIMIT. We have something similar with Bug 15274. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:22:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:22:01 +0000 Subject: [Koha-bugs] [Bug 14497] Add warning to patron details page if patron's fines exceed noissuescharge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:22:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:22:01 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14497 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:26:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:26:03 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:26:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:26:11 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44798|0 |1 is obsolete| | --- Comment #10 from Charles Farmer --- Created attachment 45297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45297&action=edit Bug 15030: Add tests This test will prevent regression on the lost of data when items.itemcallnumber is linked with a plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:35:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:35:25 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia at hotmail.com --- Comment #2 from Aleisha Amohia --- The patch does not apply, given these errors after applying: Can't locate Date/Range.pm in @INC (@INC contains: /home/koha/src /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/koha/src/Koha/DateUtils.pm line 21. BEGIN failed--compilation aborted at /home/koha/src/Koha/DateUtils.pm line 21. Compilation failed in require at /home/koha/src/C4/Search/History.pm line 7. BEGIN failed--compilation aborted at /home/koha/src/C4/Search/History.pm line 7. Compilation failed in require at /home/koha/src/C4/Auth.pm line 32. BEGIN failed--compilation aborted at /home/koha/src/C4/Auth.pm line 32. Compilation failed in require at /home/koha/src/mainpage.pl line 25. BEGIN failed--compilation aborted at /home/koha/src/mainpage.pl line 25. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:35:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2015 22:35:36 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #11 from Jen Zajac --- Good catch, H?ctor. I had tried to make it agnostic to the summary being there but it's a bit tricky. I will see if I can sort that out. Owen, regarding the test plan, my apologies it doesn't seem to be in the developer workflow on the wiki (this is my first proper Koha patch). Any chance you could point me at something on the wiki, or another bug I could look at as an example to see what that would look like? And then I can sort that out and get it added. Is it just like the "to test bit" in the commit message on the commit message page on the wiki? Like you say, I think a formal test plan for this would be a lot more complicated than that example, would the commit message be the right place for it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 01:37:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 00:37:45 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45031|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 01:38:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 00:38:00 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45033|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 01:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 00:38:10 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45031|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 01:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 00:38:41 +0000 Subject: [Koha-bugs] [Bug 15212] Patron lists tool page needs Tools area sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Liz Rea --- *** This bug has been marked as a duplicate of bug 15211 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 01:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 00:38:41 +0000 Subject: [Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 --- Comment #8 from Liz Rea --- *** Bug 15212 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 01:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 00:38:41 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Bug 15213 depends on bug 15212, which changed state. Bug 15212 Summary: Patron lists tool page needs Tools area sidebar http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 01:44:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 00:44:59 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fines Pay receipt should |Fines Payment receipt |include all account lines |should include all account |selected for this pay |lines selected for this pay -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 03:02:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 02:02:38 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45252|0 |1 is obsolete| | --- Comment #12 from Jen Zajac --- Created attachment 45298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45298&action=edit Bug 15269 [ENH]: Layout tweaks for the opac-detail page Make the following improvements to the layout of the OPAC detail page: * Image thumbnail has more white space * Summary is moved up the details block and font size is increased * Ratings controls are moved up the details * Small devices get a better layout To test: - Check that the ratings controls are moved up the page to be before the summary * If there is no summary, the controls should be under the series * If there is no summary or no series, the controls should be under the type * If there is no summary, no series, or no type, the controls should be under the authors (including contributing authors) - Check that the 520 field (Summary, Subject, Review, Scope and content, Abstract, Content advice) is rendered nearer to the top of the page, following material type, series, and the ratings. - Check that the font size for "Material type", "Series" and the 520 field (Summary, Subject, Review, Scope and content, Abstract, Content advice) are rendered at a 14px font size. - Check that authors and contributing authors are rendered at 16px font size. - Check that if any kind of cover image is present (or the no cover image placeholder image) it is rendered into a div with a class of 'span2' and appears on the left of the main item details. * Need to test every kind of cover image service * If no kind of cover image service is turned on, then the 'span2' div should not be present and the item details should be on the left of the content area. - Check that small devices (e.g. mobile phones) make the 'span2' image column take up the full width and appear above the rest of the item details. - Check that layout of the search results page is unaffected. - Check that changing 'OPACXSLTDetailsDisplay' to an empty string still yields the expected layout. Sponsored-by: ByWater -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 03:02:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 02:02:47 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45253|0 |1 is obsolete| | --- Comment #13 from Jen Zajac --- Created attachment 45299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45299&action=edit Bug 15269 [ENH]: Compiled CSS changes Sponsored-by: ByWater -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 03:07:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 02:07:01 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Jen Zajac --- Hi, I've updated the patch to make the logic for moving the ratings controls upwards a lot more robust and agnostic of the presence of particular fields. I've also added a crude test plan. I'm _not_ a Koha expert and it might be missing some necessary detail about specific configurations of fields that I'm unaware of, but hopefully it's a good starting place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 07:20:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 06:20:17 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #15 from H?ctor Eduardo Castro Avalos --- Hi Jen I think (IMHO) if you can divide in more divs the details, i.e., all data is contained in
and it could look much better if you separate in two or three divs depends on the data displayed. If record is too long -like motion pictures, dvds, etc- a white block is displayed below the cover image, so this way the second div can be aligned at left and so on. Here we must consider that two or more covers can be deployed. Also Koha notice this in Enhanced Content preferences in All section "NOTE: you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." If OPACLocalCoverImages is set to 'Display' and there is not a cover image
must be hide or display something like "No cover image available" in a box. I can not have access to Enhanced Content that require account and password like NoveList Select, If you have access, please paste a link for video like Kyle Hall did it in bug . I don't know if QA Team have access to this. I've been tested this with syprefs GoogleJackets, OpenLibraryCovers, OPACAmazonCoverImages and works excellent, I will test it with more syprefs involved. Could be great if you extend this to UNIMARC and NORMARC environment. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 07:12:24 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #7 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #4) > The 2 patches are for 3.20.x but it would be good to get the first one (the > tests) on master too. I can see the bug and the solution. Can I QA myself those patches, and then pushed them on 3.20, am I supposed to wait someone else from the QA team to validate this before? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:25:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 07:25:54 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #50 from David Cook --- (In reply to Katrin Fischer from comment #33) > I was told recently that 2-3 seconds is quite standard for OAI-PMH harvests. > Katrin, who said this to you? Andreas was also interested in every 2-3 seconds, but that doesn't seem very feasible to me. Today, I've tried downloading records, and I can download 21 records from a Swedish server in 4-5 seconds. The OAI-PMH harvester utilizes synchronous code for downloading records, so if you have multiple OAI-PMH servers, it will have to download first from Server A, then Server B, then Server C... and then it will start processing records. If each server takes 5 seconds, that's 15 seconds before you even start processing the first record. I think I might be able to find some asynchronous code for downloading records with Perl, but even then it might take 5 seconds or longer just to download records... that's longer than the ideal 2-3 seconds. Plus, the asynchronous code would require me to stop using the HTTP::OAI module and create my own asynchronous version of it... which would take some time and probably be more error-prone due to the speed which I'm trying to develop. I suppose 21 records might be a lot for a harvest running every 2-3 seconds... I just tried the query "verb=ListRecords&metadataPrefix=marcxml&from=2015-12-01T18:01:45Z&until=2015-12-01T18:01:47Z", and my browser downloaded 4 records in 1 second. I suppose it might only take another 1-2 seconds to process those 4 records and import them into Koha. That's just a guess though, as I haven't written the necessary new processing/importing code yet. I suppose if I'm sending HTTP requests asynchronously and if it only takes 1 second to fetch a handful of records, it might be doable in 2-3 seconds... but the more records to fetch from the server, the longer the download is going to take and that blows out the overall time. If 2-3 seconds is just an ideal, it might not matter if it it takes 5-10 seconds. I'm keen for feedback from potential uses of the OAI-PMH server. How much does time/frequency matter to you? This might be a case of premature optimisation. It might be better for me to focus on building a functional system, and then worry about improving the speed later. I did that recently on a different project, and it worked quite well. I focused the majority of my time on meeting the functional requirements, and then spent a few hours tweaking the code to reach massive increases in performance. However, if the system needs to be re-designed to gain those performance increases, then that seems wasteful. -- Another thought I had was to build an "import_oai" API into Koha, and then perhaps write the actual OAI-PMH harvester using a language which works asynchronously by design, like Node.js. Not that I'm excellent with Node.js. I've written code in my spare time which fetches data from a database and asynchronously updates a third-party REST API, but it's certainly not elegant... and requiring Node.js adds a layer of complexity that the Koha community itself would not want to support in any way shape or form I would think. But we could create an import API and then rely on individual libraries to supply their own OAI-PMH harvesters... although for that to work successfully, we would need standards for conversations between harvesters and importers. I'm thinking the "import_oai" or "import?type=oai" API might be a good idea in any case, although I'm not sure how Apache would cope with being hammered by an OAI-PMH harvester sending it multiple XML records every few seconds. Perhaps it's worthwhile having one daemon for downloading records, and another for importing records. Perhaps it's worth writing a forking server to handle incoming records in parallel. -- Honestly though, I would ask that people think further about the frequency of harvests. Is every 2-3 seconds really necessary? Do we really need it to be able to perform that quickly? If so, I'm open to ideas about how to achieve it. I have lots of ideas as outlined above, but more than happy to hear about suggestions, and even happier to be told not to worry about the speed. Unless people think it's a concern, I'm going to continue development with slower synchronous code. I want to make this harvester as modular as possible, so that future upgrades don't require a rewrite of the whole system. Right now, I see the bottleneck being with the downloading of records and passing those records to a processor/importer. The importer, at least for KB, is going to be difficult in terms of the logic involved, but I'm not necessarily that worried about its speed at this point. So I might try to prototype a synchronous downloader as fast as I can and spend more time on the importer and refactoring existing code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 07:33:13 +0000 Subject: [Koha-bugs] [Bug 15275] New: "To" has multiple meanings, making it impossible to translate Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275 Bug ID: 15275 Summary: "To" has multiple meanings, making it impossible to translate Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr msgid "To" is used in the following places: intranet-tmpl/prog/en/modules/circ/branchtransfers.tt meaning "transfer to this branch" intranet-tmpl/prog/en/modules/members/members-update.tt meaning "field was changed to this value" intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt intranet-tmpl/prog/en/modules/reports/issues_stats.tt intranet-tmpl/prog/en/modules/reports/reserves_stats.tt intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt meaning "up to this date" Three completely different meanings, so translating this is practically impossible for some languages. Translating this as a plain dash (" - ") is good enough for the date ranges, but not for the "transfer to this branch" or "changed to this value" meanings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 07:47:58 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45131|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS --- Created attachment 45300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45300&action=edit Bug 15252 - Patron search on start with does not work with several terms When searching a patron, search type can be 'start with' and 'contain'. If the search text contains a space (or a coma), this text is splitted into several terms. Actually, the search on 'start with' with several terms never returns a result. It is because the search composes an "AND" SQL query on terms. For example (I display only the surname part) : search type = contain : 'jean paul' => surname like '%jean% AND %paul%' search type = start with : 'jean paul' => surname like 'jean% AND paul%' The query for 'start with' is impossible. I propose, for search with start with, to not split terms : jean paul => surname like 'jean paul%' One can always use '*' to add more truncation : jea* pau* => surname like 'jea% pau%' This bug affects a lot surnames with several terms like 'LE GUELEC' or 'MAC BETH'. Note that the patch moves : $searchmember =~ s/,/ /g; It removes the test "if $searchmember" because $searchmember is tested and set to empty string previously : unless ( $searchmember ) { $searchmember = $dt_params->{sSearch} // ''; } Test plan : ========== - Create two patrons with firstname "Jean Paul" - Go to Patrons module - Choose "Starts with" in "Search type" filter - Perform a search on "Jean Paul" => without patch : you get no result => with this patch : you get the two results - Check you get the two results for search on "Jean Pau" - Check you get the two results for search on "Jea* Pau*" - Check you do not get results for search on "Jea Paul" - Choose "Contains" in "Search type" filter - Check you get the two results for search on "Jean Paul" - Check you get the two results for search on "Jean Pau" - Check you get the two results for search on "Jea* Pau*" - Check you get the two results for search on "Jea Paul" - Check you get the two results for search on "Paul Jean" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:48:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 07:48:09 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45132|0 |1 is obsolete| | --- Comment #7 from Fridolin SOMERS --- Created attachment 45301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45301&action=edit Bug 15252 - Patron search on start with does not work with several terms - followup 1 'start_with' is the default value of $searchtype, it can be explicit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:48:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 07:48:20 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45133|0 |1 is obsolete| | --- Comment #8 from Fridolin SOMERS --- Created attachment 45302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45302&action=edit Bug 15252 - correct UT searchtype value is contain and not contains -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:48:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 07:48:31 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45134|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS --- Created attachment 45303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45303&action=edit Bug 15252 - UT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:50:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 07:50:01 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #5) > - $searchmember =~ s/\*/%/g; # * is replaced with % for sql > + > + $term =~ s/\*/%/g; # * is replaced with % for sql > > This changes has 2 consequences: > 1/ Add a new feature: * is now a wildcard for the patron search > 2/ Introduce a regression: * is not a wildcard anymore for the patron > attribute search I corrected by keeping the original line but moved before creating terms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:57:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 07:57:18 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:06:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:06:45 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #51 from Leif Andersson --- (In reply to David Cook from comment #50) > Honestly though, I would ask that people think further about the frequency > of harvests. Is every 2-3 seconds really necessary? Do we really need it to > be able to perform that quickly? > Well, the use case envisioned by Stockholm UL would in practice ideally involve fetching ONE record every 10 minutes or so! The cataloger will be creating/modifying a bib record and a mfhd record in our union catalog. Next, the cataloger will turn to our local catalog, Koha, expecting to find this record already imported. If there is a way for the harvester to decide which ONE record to get...maybe even with some intervention by the cataloger...? So when this ONE record is asked for, we want it to be a quick process getting it from the source and into Koha. Then nightly more massive harvests could be performed to catch up with other modifications to the union catalog. >From my point of view it seems a little contrived to use a OAI harvester for this kind of job - synching Koha with union catalog just to be able to instantly work locally on a record. But it is what has been recommended to us by the union catalog from which we are importing records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:07:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:07:25 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:07:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:07:28 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #13 from Fridolin SOMERS --- Created attachment 45304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45304&action=edit Bug 14636: Item search - fix search and sort by publication date for MARC21 Problem: MARC21/NORMARC stores the publication date in biblio.copyrightdate, but UNIMARC uses biblioitems.publicationyear. To test: - Without patch in a MARC21 installation: - Search by publication date - Verify that the results don't match the publication year you searched for. - Try sorting the table by publication year. - Verify that the sort doesn't work. - Apply patch. - Repeat both, search and sort. - Verify both work correctly now. - Repeat tests on a UNIMARC installation. - Verify both still work. Signed-off-by: Owen Leonard Tested searching and sorting successfully in a MARC21 installation. DID NOT test in UNIMARC. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:07:43 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #14 from Fridolin SOMERS --- Created attachment 45305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45305&action=edit Bug 14636: Item search - improving display - Changes "Publication Date" to "Publication date" in the CSV export - Fixes 'no JavaScript fallback' display to match the normal display - only show 'by' when it's UNIMARC and an author exist - show copyrightdate if publicationyear is empty To test: - Turn of Javascript in your browser before you item search. This will activate the alternative display. - For MARC21: - Verify that the author displays when existing and no 'by' is shown. - Verify that the publication date is now shown. - For UNIMARC: - Verify that 'by' only displays when there is an author to display. - Verify that the publication date is still shown. - Try the CSV export. - Verify that the CSV header now reads 'Publication date'. Signed-off-by: Owen Leonard Successfully tested non-JS behavior and CSV export. DID NOT test UNIMARC. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:07:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:07:53 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45168|0 |1 is obsolete| | --- Comment #15 from Fridolin SOMERS --- Created attachment 45306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45306&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate Signed-off-by: Katrin Fischer Thx for the follow-up! Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:08:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:08:01 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45169|0 |1 is obsolete| | --- Comment #16 from Fridolin SOMERS --- Created attachment 45307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45307&action=edit Bug 14636: Follow-up - fix typo in system preference name The preference is named "marcflavour" not "marcflavor". Without this change, search will always use "copyrightyear" and break search by publication date for UNIMARC. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:08:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:08:40 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45120|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:09:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:09:03 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:09:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:09:45 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #17 from Fridolin SOMERS --- I signoff for UNIMARC, works perfect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:24:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:24:00 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #8 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #7) > (In reply to Jonathan Druart from comment #4) > > The 2 patches are for 3.20.x but it would be good to get the first one (the > > tests) on master too. > > I can see the bug and the solution. Can I QA myself those patches, and then > pushed them on 3.20, am I supposed to wait someone else from the QA team to > validate this before? I don't know, I think the RMaints have the responsibility of keeping their branch stable :) Since you are releasing at the end of the month, maybe it is worth to wait for another pair of eyes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:31:05 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Alex Arnaud --- Hello, There is 2 new dependencies: Date::Range and Date::Simple that you have to install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:36:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:36:20 +0000 Subject: [Koha-bugs] [Bug 15212] Patron lists tool page needs Tools area sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Liz, this is not a duplicate. Bug 15211 adds the tools sidebar for label/patron cards creator, not the patron lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:55:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:55:14 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 --- Comment #1 from Jonathan Druart --- Created attachment 45308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45308&action=edit Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Confirm that the admin/categorie.pl url still works (you need to apply the change to the apache config before). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:55:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:55:11 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:55:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 08:55:23 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:04:01 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15213 Depends on|15213 | --- Comment #7 from Jonathan Druart --- I don't see the bit button using chromium: Version 45.0.2454.85 Built on 8.1, running on Debian 8.2 (64-bit) or Version 46.0.2490.71 Built on 8.2, running on Debian 8.2 (64-bit) Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:04:01 +0000 Subject: [Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15223 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15223 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 [Bug 15223] Buttons on patron list main page funny after font awesome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:12:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:12:23 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:12:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:12:26 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44889|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 45309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45309&action=edit Bug 15180: Update Italian web installer sample files for 3.20 This patch is ONLY FOR 3.20.x, so you need to install 3.20.x to test it. - Completes translations in Italian of web installer sample files in 3.20.x - Some change in Italian default system preference settings. To test: - Run the web installer in Italian with all sample files selected - Confirm no error messages are shown http://bugs.koha-community.org/show_bug.cgi?id=15180 Signed-off-by: Bernardo Gonzalez Kriegel Tested on 3.20, italian installer, all sample files No errors detected Koha version: 3.20.05.000 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:13:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:13:10 +0000 Subject: [Koha-bugs] [Bug 15180] Update Italian web installer sample files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:18:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:18:18 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:38:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:38:02 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #26 from Jonathan Druart --- Comment on attachment 44826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44826 Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC Review of attachment 44826: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12528&attachment=44826) ----------------------------------------------------------------- The description for EnhancedMessagingPreferences is "allow/don't allow patrons to choose which notices they receive and when they receive them. I think it could be updated to highlight that it's for the staff interface only, or at least a reference to the new pref? Why don't you want the patrons to show the type of messages they receive? I could understand not to let the patrons change the settings, but I don't see the point to hide them completely. ::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql @@ +1,3 @@ > +INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES > +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') > +; It would be better to set the value of the other pref, to avoid any confusion. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt @@ +131,5 @@ > >
> + [% ELSE %] > +

You are not allowed to call this page directly

> + To report this problem, you can email the Koha Administrator. "admin" does not seem to be sent to the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:38:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:38:11 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:48:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:48:16 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #13 from Jonathan Druart --- Comment on attachment 44772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44772 Bug 14393 - Add collection code filter to inventory Review of attachment 44772: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14393&attachment=44772) ----------------------------------------------------------------- ::: tools/inventory.pl @@ +95,5 @@ > } > push @authorised_value_list,@$data; > } > + > + my $collection_authorised_value = C4::Koha::GetAuthValCode("items.ccode", $fwkcode); Does it really necessary to check all frameworks? Isn't be enough to get the default one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:52:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:52:44 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de, | |nicole at bywatersolutions.com --- Comment #3 from Jonathan Druart --- Katrin, Nicole, Could we get your opinion on this change please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:52:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:52:58 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:54:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 09:54:04 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Don't you think we could update existing installations too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:11:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:11:47 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart --- Alex, 1/ I think MarcRecordFromSuggestion is confusing. It does not take an existing suggestion in parameter, and that's why you use the default framework to get the marc fields. Either you rename it with something like MarcRecordFromNewSuggestion, or you take into account that this suggestion can already be linked to a record. 2/ Should not we have the same behavior on the staff side? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:15:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:15:56 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 --- Comment #13 from Jonathan Druart --- I personally don't plan to QA this patch as long as we don't get another signoff from someone involved on the discussion of bug 9011. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:19:48 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:27:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:27:39 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #15 from Jonathan Druart --- Still waiting for another signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:31:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:31:19 +0000 Subject: [Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- Kyle, it's not a good idea to replace use with require, you are skipping the compilation pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:33:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:33:03 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:33:05 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45114|0 |1 is obsolete| | Attachment #45174|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 45310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45310&action=edit Bug 12152: Holds to pull report - Show branch names and item type descriptions The 'Holds to pull' report shows branch and itemtype codes without this patch. With the patch, names and descriptions should display. To test: - Make sure there are some holds for available items in your system - Go to Circulation > Holds to pull - Verify changes mentioned above in the list of holds shown Signed-off-by: David Cook Works as described, although as Magnus mentioned, Locations still use codes instead of descriptions. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:33:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:33:10 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 --- Comment #9 from Jonathan Druart --- Created attachment 45311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45311&action=edit Bug 12152: Holds to pull report - Display location descriptions ...instead of their code Test plan: Same as before, confirm the the location codes are replaced with their descriptions. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:35:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:35:38 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:35:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:35:41 +0000 Subject: [Koha-bugs] [Bug 15238] Better translatability for Installer Step 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15238 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45108|0 |1 is obsolete| | Attachment #45267|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 45312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45312&action=edit Bug 15238: Better translatability for Installer Step 1 This Bug streamlines html in installer/step1.tt for better translatibility. To test: Reviwe code and verify that changes in text make sense. Signed-off-by: Hector Castro To reproduce in Debian environment, remove a required module with dpkg -r. Rewording Ok for translation purposes Bug 15238: (followup) Remove word 'Note:' 'Note: ' removed as requested in comment #3 Signed-off-by: Hector Castro Word 'Note' removed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:48:35 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #5 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > -

The column Koha field shows that the subfield is linked with a Koha > field. Koha can manage a MARC interface, or a Koha interface. This link > ensures that both DB are synchronized, thus you can change from a MARC to a > Koha interface easily.

> > +

The column 'Koha field' shows that the subfield is linked with a Koha > field. Koha can manage a MARC interface, and a Koha interface. This link > ensures that both DB are synchronized.

> > Why did you remove the end of the sentence? Ah, now I see what I did. It was not a mistake. Both texts have the same meaning, but a different wording. That's why I re-used the text from auth_subfields_structure.tt in marc_subfields_structure.tt I propose to switch back to signed-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:50:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:50:51 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:50:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:50:54 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45283|0 |1 is obsolete| | Attachment #45284|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 45313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45313&action=edit Bug 13024 - Nonpublic note not appearing in the staff client The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) Test Plan: 1) Ensure your non-public note field is mapped to the items.itemnotes_nonpublic database column 2) Edit an item, add a test nonpublic note 3) Check out the item, verify the note is visible in the checkouts table 4) Check in the item, verify the note is visible in the checkins table 5) View the item details, verify the note is visible and editable if your account has the rights to edit items Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:51:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:51:02 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 --- Comment #10 from Jonathan Druart --- Created attachment 45314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45314&action=edit Bug 13024 [QA Followup] - Add nonpublic note to relatives' checkouts Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:51:47 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 --- Comment #11 from Jonathan Druart --- (In reply to Kyle M Hall from comment #8) > (In reply to Jonathan Druart from comment #4) > > QA comments: > > > > 1/ The items.itemnotes does not appear in the return table (already before > > this patch). I think it's because of circ/returns.pl: > > 577 $ri{itemnote} = $biblio->{'itemnotes'}; > > should be > > 577 $ri{itemnote} = $item->{'itemnotes'}; > > Can't reproduce, is it fixed in master? Hum, it works actually. Sorry about that. Not sure what I tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 10:56:26 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |nicole at bywatersolutions.com --- Comment #6 from Jonathan Druart --- Nicole, do you agree to remove "thus you can change from a MARC to a Koha interface easily."? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:01:34 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #58 from Jonathan Druart --- (In reply to Kyle M Hall from comment #24) > Test Plan addition: > There are several new module dependencies for this feature: > HTML::HTMLDoc: Required for both LPR and CUPS printing if printing HTML > Net::Printer: Required for LPR printing > Printer: Required for CUPS printing Did you check how easy/difficult it is to package these 2 modules? They don't seem maintained anymore Printer-0.98 17 Aug 2004 HTML-HTMLDoc-0.11_01 03 Nov 2009 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:20:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:20:19 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #23 from Jonathan Druart --- Comment on attachment 44915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44915 [SIGNED-OFF]Bug 14939: Modularize OAI Server existing classes Review of attachment 44915: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14939&attachment=44915) ----------------------------------------------------------------- ::: C4/Installer/PerlDependencies.pm @@ +777,4 @@ > 'required' => '0', > 'min_ver' => '0.28', > }, > + 'Capture::Tiny' => { Is this really mandatory? The module has some known bugs (https://github.com/dagolden/Capture-Tiny/issues). One is "Capture::Tiny breaks under FCGI" and is not comforting. ::: opac/oai.pl @@ +1,3 @@ > #!/usr/bin/perl > > +# Copyright Tamil s.a.r.l. 2008-2015 Why did you remove BibLibre's copyright? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:23:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:23:09 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart --- FAIL Koha/OAI/Server/Identify.pm FAIL critic Package declaration must match filename at line 18, column 1. Correct the filename or package statement. FAIL Koha/OAI/Server/Repository.pm FAIL critic Code before strictures are enabled at line 20, column 11. See page 429 of PBP. FAIL spelling tranformed ==> transformed choosed ==> chose, chosen FAIL valid Can't locate package HTTP::OAI::Encapsulation for @HTTP::OAI::Error::ISA FAIL opac/oai.pl FAIL valid Can't locate package HTTP::OAI::Encapsulation for @HTTP::OAI::Error::ISA Should I install libhttp-oai-perl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:23:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:23:53 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #25 from Jonathan Druart --- After installing libhttp-oai-perl: FAIL opac/oai.pl FAIL valid Can't locate package HTTP::OAI::SAX::Base for @HTTP::OAI::Error::ISA Can't locate package HTTP::OAI::MemberMixin for @HTTP::OAI::Error::ISA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:38:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:38:59 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:39:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:39:02 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45304|0 |1 is obsolete| | Attachment #45305|0 |1 is obsolete| | Attachment #45306|0 |1 is obsolete| | Attachment #45307|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 45315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45315&action=edit Bug 14636: Item search - fix search and sort by publication date for MARC21 Problem: MARC21/NORMARC stores the publication date in biblio.copyrightdate, but UNIMARC uses biblioitems.publicationyear. To test: - Without patch in a MARC21 installation: - Search by publication date - Verify that the results don't match the publication year you searched for. - Try sorting the table by publication year. - Verify that the sort doesn't work. - Apply patch. - Repeat both, search and sort. - Verify both work correctly now. - Repeat tests on a UNIMARC installation. - Verify both still work. Signed-off-by: Owen Leonard Tested searching and sorting successfully in a MARC21 installation. DID NOT test in UNIMARC. Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:39:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:39:05 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #19 from Jonathan Druart --- Created attachment 45316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45316&action=edit Bug 14636: Item search - improving display - Changes "Publication Date" to "Publication date" in the CSV export - Fixes 'no JavaScript fallback' display to match the normal display - only show 'by' when it's UNIMARC and an author exist - show copyrightdate if publicationyear is empty To test: - Turn of Javascript in your browser before you item search. This will activate the alternative display. - For MARC21: - Verify that the author displays when existing and no 'by' is shown. - Verify that the publication date is now shown. - For UNIMARC: - Verify that 'by' only displays when there is an author to display. - Verify that the publication date is still shown. - Try the CSV export. - Verify that the CSV header now reads 'Publication date'. Signed-off-by: Owen Leonard Successfully tested non-JS behavior and CSV export. DID NOT test UNIMARC. Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:39:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:39:10 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #20 from Jonathan Druart --- Created attachment 45317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45317&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate Signed-off-by: Katrin Fischer Thx for the follow-up! Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:39:13 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #21 from Jonathan Druart --- Created attachment 45318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45318&action=edit Bug 14636: Follow-up - fix typo in system preference name The preference is named "marcflavour" not "marcflavor". Without this change, search will always use "copyrightyear" and break search by publication date for UNIMARC. Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:39:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:39:16 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #22 from Jonathan Druart --- Created attachment 45319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45319&action=edit Bug 14636: Remove debug message Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:50:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:50:06 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #26 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #23) > Comment on attachment 44915 [details] [review] > [SIGNED-OFF]Bug 14939: Modularize OAI Server existing classes > > Review of attachment 44915 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Installer/PerlDependencies.pm > @@ +777,4 @@ > > 'required' => '0', > > 'min_ver' => '0.28', > > }, > > + 'Capture::Tiny' => { > > Is this really mandatory? Is is used in tests to capture STDOUT. Do you have something to suggest to do the same thing without this module? > ::: opac/oai.pl > @@ +1,3 @@ > > #!/usr/bin/perl > > > > +# Copyright Tamil s.a.r.l. 2008-2015 > > Why did you remove BibLibre's copyright? Not intentional, even if Tamil copyright on this code deserves to come back. I wrote OAI server back in time, and Tamil copyright disappeared without being noticed by sharp eyes as yours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:50:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:50:50 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- The br and span tags should only be displayed if the value enumchron exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:53:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 11:53:31 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 --- Comment #10 from M. Tompsett --- (In reply to Jonathan Druart from comment #9) > http://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR1:_non- > XSLT_search_results_and_bib_display_templates_deprecated > > """ > As of 2014-07-02, use of the XSLT search results and bib details display > templates for the staff interface and public catalog is now the preferred > option. Consequently, the non-XSLT option is now deprecated and it will not > be maintained. > """ 3.22.x = now 3.20.x = july 3.18.x = last year 3.16.x = year before that Perhaps, if 3.16.x is to be maintained at all, this would still be a valid patch for 3.16.x? In the meantime, changing the OPACXSLTDetailsDisplay, OPACXSLTResultsDisplay, XSLTDetailsDisplay, and XSLTResultsDisplay all to default, as they are likely blank currently, would be the recommended course of action. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:07:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:07:50 +0000 Subject: [Koha-bugs] [Bug 12923] Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923 --- Comment #6 from Jonathan Druart --- Everything works fine but I am wondering if it couldn't be useful to display the branchcode too. A letter is not generated because it's missing for a given branchcode (here the one from the issue), not for a given patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:08:20 +0000 Subject: [Koha-bugs] [Bug 12923] Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:08:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:08:19 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:08:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:08:22 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44915|0 |1 is obsolete| | --- Comment #27 from Fr?d?ric Demians --- Created attachment 45320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45320&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. Add new dependency: Capture::Tiny -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:08:23 +0000 Subject: [Koha-bugs] [Bug 12923] Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34441|0 |1 is obsolete| | Attachment #44688|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 45321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45321&action=edit Bug 12923 Improve error logging for advance_notices.pl Show borrowernumber when no letter of type is found and force utf8 output when running advance_notices.pl with -n flag, diacritics run awol in the console output! Also when debugging which borrower requests undefined letter templates, it is very handy to log the borrowernumber so we catch and fix bad borrower message transport settings. TEST PREPARATION: 0. Edit the ODUEDGST letter, find an undefined letter for any trasport type. ::TESTS ARE (ALMOST) THE SAME AS IN bugg 12922:: TEST PLAN: 1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to the undefined digest. Set the "Days in Advance" to 1. 2. Check-out something for that borrower and set the due date for tomorrow. 3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal. 4. BEFORE THIS PATCH: You get an error "no letter of type 'PREDUEDGST' found. Please see sample_notices.sql at ./advance_notices.pl line 366." 4. AFTER THIS PATCH: You get an error "no letter of type 'PREDUEDGST' found for borrowernumber 1104659. Please see sample_notices.sql at ./advance_notices.pl line 368." Makes life more worth living for! Also diacritics printed on screen are displayed properly. Signed-off-by: Frederic Demians I confirm the diacritics issue and solution. borrowernumber is displayed with warning when the 'no letter...' message is displayed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:11:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:11:43 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #28 from Fr?d?ric Demians --- Jonathan, I've rebased the patch on master, and fixed perlcritic test errors, and copyright stuff. I'm open to any proposal to replace Tiny::Capture. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:28:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:28:21 +0000 Subject: [Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44299|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45322&action=edit Bug 15004: Allow to change amounts of duplicated budgets When duplicating a budget we now have the possibility to change amounts of budget and funds by a given percentage. Additionally, we can configure how to round the amounts. Test plan: 1. Create a budget and several funds with different amounts 2. Duplicate it using the 2 new options 3. Check that the amounts are correct Signed-off-by: Frederic Demians It works exactly as advertised. Was happy to see that decimal point can be used: for example, increase a budget by 2.6%, and round the amound to 0.5. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:28:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:28:25 +0000 Subject: [Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 --- Comment #4 from Jonathan Druart --- Created attachment 45323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45323&action=edit Bug 15004: Ensure that the reset_all_budgets behavior is kept Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:28:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:28:57 +0000 Subject: [Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Julian, Please add few lines in the help about these 2 new fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:29:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:29:10 +0000 Subject: [Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:36:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:36:50 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 --- Comment #2 from Fridolin SOMERS --- There is an index "Title-uniform" should it be used for 500 and facet su-ut ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:37:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:37:26 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #29 from Jonathan Druart --- The tests does not pass: t/db_dependent/OAI/Server.t .. 1/13 Can't call method "start_element" on an undefined value at /usr/share/perl5/HTTP/OAI/Verb.pm line 53. (In reply to Fr?d?ric Demians from comment #26) > > > +# Copyright Tamil s.a.r.l. 2008-2015 > > > > Why did you remove BibLibre's copyright? > > Not intentional, even if Tamil copyright on this code deserves to come back. > I > wrote OAI server back in time, and Tamil copyright disappeared without being > noticed by sharp eyes as yours. The idea wasn't to remove the Tamil copyright line, but reintroduce BibLibre one's :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:42:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:42:15 +0000 Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Fridolin SOMERS --- This has been corrected by Bug 13986 Cool :D *** This bug has been marked as a duplicate of bug 13986 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:42:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:42:15 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin SOMERS --- *** Bug 13761 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:54:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:54:07 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 --- Comment #2 from Owen Leonard --- At this time I think it's right to set up a guideline to avoid translation problems, but I think it's pretty clear that our translation system is broken if we can't use HTML within sentences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:59:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 12:59:12 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #30 from Fr?d?ric Demians --- > The tests does not pass: > t/db_dependent/OAI/Server.t .. 1/13 Can't call method "start_element" on an > undefined value at /usr/share/perl5/HTTP/OAI/Verb.pm line 53. I don't get this? What is you test environment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:08:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:08:19 +0000 Subject: [Koha-bugs] [Bug 15276] New: Add documentation for Template Toolkit syntax for slips and notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 Bug ID: 15276 Summary: Add documentation for Template Toolkit syntax for slips and notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The ability to use Template Toolkit syntax in slips and notices will need documentation in the help files for slips and notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:08:23 +0000 Subject: [Koha-bugs] [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:08:23 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15276 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:10:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:10:12 +0000 Subject: [Koha-bugs] [Bug 15277] New: Add Template Toolkit syntax for slips and notices to editor Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Bug ID: 15277 Summary: Add Template Toolkit syntax for slips and notices to editor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The ability to use Template Toolkit syntax for slips and notices should eventually be revealed in the editor somehow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:10:16 +0000 Subject: [Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:10:16 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15277 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 [Bug 15277] Add Template Toolkit syntax for slips and notices to editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:11:49 +0000 Subject: [Koha-bugs] [Bug 15278] New: Port default slips and notices from bespoke syntax to Template Toolkit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Bug ID: 15278 Summary: Port default slips and notices from bespoke syntax to Template Toolkit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This bug is an omnibus for converting all default slips and notices from our current bespoke syntax to Template Toolkit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:12:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:12:01 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:12:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:12:01 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:13:39 +0000 Subject: [Koha-bugs] [Bug 15279] New: Deprecate bespoke syntax for Slips and Notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 Bug ID: 15279 Summary: Deprecate bespoke syntax for Slips and Notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Once Template Toolkit syntax for Slips and Notices has gotten to the point where it can fully replace our bespoke format, we should deprecate and remove the old format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:13:44 +0000 Subject: [Koha-bugs] [Bug 15279] Deprecate bespoke syntax for Slips and Notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14758, 15276, 15277, 15278 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 [Bug 14758] Re-engineer Talking Tech support in Koha http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 [Bug 15277] Add Template Toolkit syntax for slips and notices to editor http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:13:44 +0000 Subject: [Koha-bugs] [Bug 14758] Re-engineer Talking Tech support in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15279 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 [Bug 15279] Deprecate bespoke syntax for Slips and Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:13:44 +0000 Subject: [Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15279 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 [Bug 15279] Deprecate bespoke syntax for Slips and Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:13:44 +0000 Subject: [Koha-bugs] [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15279 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 [Bug 15279] Deprecate bespoke syntax for Slips and Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:13:44 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15279 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 [Bug 15279] Deprecate bespoke syntax for Slips and Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:27:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:27:22 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37974|0 |1 is obsolete| | Attachment #37975|0 |1 is obsolete| | Attachment #37989|0 |1 is obsolete| | Attachment #39649|0 |1 is obsolete| | --- Comment #9 from Bouzid --- Created attachment 45324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45324&action=edit Bug 11300 - Add a Z39.50 Linker that searches for authority links in the specified Z39.50 server This patch depends on code added in Bug 11299, and must be applied after it. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) This patch adds a Z39.50 Linker which searches for authority links on a remote server. If a matching authority is found, it's imported in the local database for linking with the current biblio record. If no matching authority was found on the remote server, the Linker falls back to a local authority search. Configuration : * The option "Z39.50 Server" is added to the LinkerModule preference. You must choose this to use the new Linker. * The preference LinkerZ3950Server is required and specifies which server to use for linking. It must contain the "name" of the server, as defined in the z3950servers table. * You can set the "local_first" option in the LinkerOptions preference to force the Linker to search for authorities in the local database first. If no local authority match was found, the Linker falls back to a remote Z39.50 search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:28:05 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:49:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:49:09 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:49:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:49:12 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #2 from Kyle M Hall --- Created attachment 45325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45325&action=edit Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:55:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:55:05 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 --- Comment #6 from Fridolin SOMERS --- Created attachment 45326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45326&action=edit Bug 10163 - batch-mod items tool fails on files over 1000 lines long When using batch modification tool, if number of items is too big (default 1000), the edit form is not displayed. In perl script, when number of items is too big, template var "item_loop" is not defined and var "too_many_items"is set. This patch allows the display of edit form and text "The following barcodes were found: " even when number of items is too big. Test plan : - Create a file with 11 existing barcodes and 1 not existing in catalogue - Set syspref MaxItemsForBatch to 1000 - Go to Tools > Batch item modification - Select "Barcode file" and upload file - Click on continue => you see a warning with the not found barcode, a table with found items and the edit form - Set syspref MaxItemsForBatch to 10 - Go to Tools > Batch item modification - Select "Barcode file" and upload file - Click on continue => you see a warning with the not found barcode and a text "Too many items ..." => Without patch you don't see the edit form => With patch you see the edit form and can perform the batc modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:55:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:55:52 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:56:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:56:17 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:59:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 13:59:07 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Fridolin SOMERS --- I propose a corrected patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:12:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 14:12:59 +0000 Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 --- Comment #5 from Jonathan Druart --- Created attachment 45327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45327&action=edit Bug 15194: Display dropdown action menu on top of the language bar If you have lot of reports, the dropdown menu will be hidden by the language bar for the row at the bottom of the page. I am not sure this is a correct patch, I don't think we should display something above the language bar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:13:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 14:13:27 +0000 Subject: [Koha-bugs] [Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Status|NEW |In Discussion QA Contact|testopia at bugs.koha-communit | |y.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Component|Reports |Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:27:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 14:27:26 +0000 Subject: [Koha-bugs] [Bug 15104] Batch Record Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104 --- Comment #3 from Jonathan Druart --- Comment on attachment 44446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44446 Bug 15104: Batch Record Modification Performance Improvement Review of attachment 44446: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15104&attachment=44446) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +307,4 @@ > } > > if ( C4::Context->preference("CataloguingLog") ) { > + logaction( "CATALOGUING", "MODIFY", $biblionumber, "biblio BEFORE=>" . $record->as_formatted ); You are logging the modified record, not the original one. ::: tools/batch_record_modification.pl @@ +157,4 @@ > my ( $job ); > if ( $runinbackground ) { > + $job_size = scalar( @record_ids ); > + $job = C4::BackgroundJob->new( $sessionID, "FIXME", $ENV{SCRIPT_NAME}, $job_size ); Wrong change, your are reintroducing old lines (see bug 15005). @@ +183,4 @@ > my $progress = 0; > $dbh->{RaiseError} = 1; > RECORD_IDS: for my $record_id ( sort { $a <=> $b } @record_ids ) { > + $progress++; There is a ++$progress later, you are incrementing twice the same variable in the same block. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 14:49:29 +0000 Subject: [Koha-bugs] [Bug 15280] New: Switch CHECKOUT notice to Template Toolkit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Bug ID: 15280 Summary: Switch CHECKOUT notice to Template Toolkit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:49:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 14:49:54 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Notices |and plumbing | Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:49:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 14:49:59 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:50:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 14:50:14 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Notices |and plumbing | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:50:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 14:50:30 +0000 Subject: [Koha-bugs] [Bug 14758] Re-engineer Talking Tech support in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Notices |and plumbing | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:50:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 14:50:45 +0000 Subject: [Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Notices |and plumbing | Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:17:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:17:44 +0000 Subject: [Koha-bugs] [Bug 15193] Perl scripts missing exec permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 --- Comment #3 from Fridolin SOMERS --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > I still find some scripts without execute permissions, > is that ok? > > -rw-r--r-- 1 bgkriegel bgkriegel 266 Oct 15 18:51 ./kohaversion.pl I don't see why it could not have execute permissions. > -rw-r--r-- 1 bgkriegel bgkriegel 1287 Oct 15 18:51 > ./selenium/PERL/Members/FilterMembers.pl > -rw-r--r-- 1 bgkriegel bgkriegel 913 Oct 15 18:51 > ./selenium/PERL/Members/AddMember.pl > -rw-r--r-- 1 bgkriegel bgkriegel 1020 Oct 15 18:51 > ./selenium/PERL/Members/Searchmember.pl Selenium is special I think, keep like this. > -rw-r--r-- 1 bgkriegel bgkriegel 1529 Oct 15 18:51 ./install-CPAN.pl This is like Makefile.PL, maybe not executable to avoid launching by mistake. > -rw-r--r-- 1 bgkriegel bgkriegel 13064 Oct 15 18:51 > ./misc/load_testing/benchmark_staff.pl May have execute permissions I'd say. > -rw-r--r-- 1 bgkriegel bgkriegel 5082 Oct 15 18:51 > ./cataloguing/value_builder/EXAMPLE.pl Maybe on purpose since it is a sample. > -rw-r--r-- 1 bgkriegel bgkriegel 10593 Oct 15 18:51 > ./koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl This is an imported library so I'd say we don't change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:20:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:20:59 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Switch CHECKOUT notice to |Switch default CHECKOUT |Template Toolkit |notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:21:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:21:04 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:22:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:22:38 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #31 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #29) > The tests does not pass: > t/db_dependent/OAI/Server.t .. 1/13 Can't call method "start_element" on an > undefined value at /usr/share/perl5/HTTP/OAI/Verb.pm line 53. In Debian this doesn't fail prove -v t/db_dependent/OAI/Server.t t/db_dependent/OAI/Server.t .. 1..13 ok 1 - use Koha::OAI::Server::DeletedRecord; ok 2 - use Koha::OAI::Server::Description; ok 3 - use Koha::OAI::Server::GetRecord; ok 4 - use Koha::OAI::Server::Identify; ok 5 - use Koha::OAI::Server::ListIdentifiers; ok 6 - use Koha::OAI::Server::ListMetadataFormats; ok 7 - use Koha::OAI::Server::ListRecords; ok 8 - use Koha::OAI::Server::ListSets; ok 9 - use Koha::OAI::Server::Record; ok 10 - use Koha::OAI::Server::Repository; ok 11 - use Koha::OAI::Server::ResumptionToken; ok 12 - ListMetadataFormats ok 13 - ListIdentifiers without metadaPrefix argument ok All tests successful. Files=1, Tests=13, 8 wallclock secs ( 0.03 usr 0.01 sys + 1.06 cusr 0.08 csys = 1.18 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:25:39 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:25:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:25:41 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 --- Comment #1 from Kyle M Hall --- Created attachment 45328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45328&action=edit Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:31:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:31:48 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45328|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 45329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45329&action=edit Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:36:44 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:36:44 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15280 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 [Bug 15280] Switch default CHECKOUT notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:38:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:38:12 +0000 Subject: [Koha-bugs] [Bug 15281] New: Switch default CHECKOUT notice to Template Toolkit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15281 Bug ID: 15281 Summary: Switch default CHECKOUT notice to Template Toolkit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:38:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:38:17 +0000 Subject: [Koha-bugs] [Bug 15281] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15281 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:44:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:44:00 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #32 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #29) > The tests does not pass: > t/db_dependent/OAI/Server.t .. 1/13 Can't call method "start_element" on an > undefined value at /usr/share/perl5/HTTP/OAI/Verb.pm line 53. See: https://rt.cpan.org/Public/Bug/Display.html?id=102010 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:44:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:44:15 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:49:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:49:18 +0000 Subject: [Koha-bugs] [Bug 15281] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15281 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15278 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:49:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:49:18 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15281 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15281 [Bug 15281] Switch default CHECKOUT notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:49:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:49:57 +0000 Subject: [Koha-bugs] [Bug 15282] New: Switch default CHECKIN notice to Template Toolkit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Bug ID: 15282 Summary: Switch default CHECKIN notice to Template Toolkit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:51:43 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:51:43 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15282 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 [Bug 15282] Switch default CHECKIN notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:52:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:52:03 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:52:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:52:05 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 --- Comment #1 from Kyle M Hall --- Created attachment 45330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45330&action=edit Bug 15282 - Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:55:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:55:02 +0000 Subject: [Koha-bugs] [Bug 15281] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15281 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 15280 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:55:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:55:02 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 --- Comment #3 from Kyle M Hall --- *** Bug 15281 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:55:24 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15282 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 [Bug 15282] Switch default CHECKIN notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 15:55:24 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15280 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 [Bug 15280] Switch default CHECKOUT notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:17:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:17:44 +0000 Subject: [Koha-bugs] [Bug 14758] Re-engineer Talking Tech support in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:45:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:45:46 +0000 Subject: [Koha-bugs] [Bug 15283] New: Switch default ISSUEQSLIP notice to Template Toolkit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Bug ID: 15283 Summary: Switch default ISSUEQSLIP notice to Template Toolkit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:45:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:45:49 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:45:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:45:54 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #4 from Mirko Tietgen --- Created attachment 45331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45331&action=edit Bug 14168 - enhance streaming cataloging to include youtube Initial commit. POCish. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:46:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:46:10 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:46:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:46:12 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 --- Comment #1 from Kyle M Hall --- Created attachment 45332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45332&action=edit Bug 15283 - Switch default ISSUEQSLIP notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:46:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:46:30 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #5 from Mirko Tietgen --- Created attachment 45333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45333&action=edit Bug 14168 PerlDependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:47:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:47:32 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15283 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:47:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:47:32 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15282 Blocks| |15278 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 [Bug 15282] Switch default CHECKIN notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:47:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:47:32 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15283 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:49:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:49:59 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #6 from Mirko Tietgen --- Needs libwww-youtube-download-perl to work, which is in Jessie. https://packages.debian.org/jessie/libwww-youtube-download-perl Hardcoded video format: WEBM. Todo: - scans only for /youtube/ in the URL, should also know relevant URL shorteners - syspref (youtube yes/no?) - probably more :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:50:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:50:34 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #7 from Mirko Tietgen --- todo - add dependency to debian/contol -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:51:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:51:13 +0000 Subject: [Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:54:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 16:54:09 +0000 Subject: [Koha-bugs] [Bug 8494] use js_beautify.pl to format javascript/jquery code in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8494 --- Comment #1 from Owen Leonard --- What is the use case for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:05:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:05:40 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 45334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45334&action=edit Bug 15172: (follow-up)Serial enumchron/sequence not visible when returning/checking in Items Display br and span tag only if the value enumchron exists. To test -Apply patches -Follow the previous test plan -Checkin whichever material (e.g., book) without sequence or enumchrom -Open up source code for checkin page, search under title and verify that b and span tags do not appear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:06:02 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45332|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 45335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45335&action=edit Bug 15283 - Switch default ISSUEQSLIP notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:06:12 +0000 Subject: [Koha-bugs] [Bug 15172] Serial enumchron/sequence not visible when returning/checking in Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15172 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:18:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:18:58 +0000 Subject: [Koha-bugs] [Bug 15284] New: Switch default ISSUESLIP notice to Template Toolkit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 Bug ID: 15284 Summary: Switch default ISSUESLIP notice to Template Toolkit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:19:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:19:05 +0000 Subject: [Koha-bugs] [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:19:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:19:12 +0000 Subject: [Koha-bugs] [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15283 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:19:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:19:12 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15284 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:22:02 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45335|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 45336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45336&action=edit Bug 15283 - Switch default ISSUEQSLIP notice to Template Toolkit Test Plan: 1) Apply this patch 2) Replace your ISSUESLIP with the following: [% USE KohaDates %]

[% branch.branchname %]

Checked out to [% borrower.title %] [% borrower.firstname %] [% borrower.initials %] [% borrower.surname %]
([% borrower.cardnumber %])
[% today | $KohaDates %]

Checked Out Today

[% FOREACH checkout IN borrower.checkouts %] [% IF checkout.is_from_today %]

[% checkout.item.biblio.title %]
Barcode: [% checkout.item.barcode %]
Date due: [% checkout.date_due | $KohaDates %]

[% END %] [% END %] 3) Print a quick slip for a patron, note the data is complete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:26:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:26:37 +0000 Subject: [Koha-bugs] [Bug 15285] New: Upgrade DataTables to 1.10.10 or later Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15285 Bug ID: 15285 Summary: Upgrade DataTables to 1.10.10 or later Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org As of today DataTables is at version 1.10.10. The current version DataTables and its associated plugins (colVis, columnFilter, rowGrouping) blocks upgrade of jQuery from 1.7.x because the colVis plugin uses jQuery features which were deprecated in 1.7.x and removed in 1.11.x. The DataTables ColVis plugin is now "retired:" http://datatables.net/extensions/colvis/ ...and the functionality moved into "buttons:" http://datatables.net/reference/button/colvis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:36:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:36:40 +0000 Subject: [Koha-bugs] [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 17:36:42 +0000 Subject: [Koha-bugs] [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 --- Comment #1 from Kyle M Hall --- Created attachment 45337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45337&action=edit Bug 15284 - Switch default ISSUESLIP notice to Template Toolkit Test Plan: 1) Apply this patch 2) Replace your ISSUESLIP with the following: [% USE KohaDates %]

[% branch.branchname %]

Checked out to [% borrower.title %] [% borrower.firstname %] [% borrower.initials %] [% borrower.surname %]
([% borrower.cardnumber %])
[% today | $KohaDates %]

Checked Out

[% FOREACH checkout IN borrower.checkouts %] [% IF ! checkout.is_overdue %]

[% checkout.item.biblio.title %]
Barcode: [% checkout.item.barcode %]
Date due: [% checkout.date_due | $KohaDates %]

[% END %] [% END %]

Overdues

[% FOREACH checkout IN borrower.checkouts %] [% IF checkout.is_overdue %]

[% checkout.item.biblio.title %]
Barcode: [% checkout.item.barcode %]
Date due: [% checkout.date_due | $KohaDates %]

[% END %] [% END %]

News

<>

<>

Posted on <>

 3) Print a slip for a patron, note the data is complete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:03:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 19:03:47 +0000 Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:26:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 19:26:42 +0000 Subject: [Koha-bugs] [Bug 15286] New: Translate SQL scripts in installer/data/mysql/es-ES/optional:mandatory Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15286 Bug ID: 15286 Summary: Translate SQL scripts in installer/data/mysql/es-ES/optional:mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: hector.hecaxmmx at gmail.com Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org CC: bgkriegel at gmail.com, frederic at tamil.fr, tomascohen at gmail.com Some SQL scripts in installer/data/mysql/es-ES/optional:mandatory have not been translated to Spanish yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 19:26:56 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15275 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 19:26:56 +0000 Subject: [Koha-bugs] [Bug 15275] "To" has multiple meanings, making it impossible to translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Regarding intranet-tmpl/prog/en/modules/circ/branchtransfers.tt Line 113:
  • You cannot transfer items of [% errmsgloo.codeType %] [% errmsgloo.code %] to [% errmsgloo.tbr %]
    • Here it would help to remove the tags. Pootle would then display a string as follows: You cannot transfer items from %s to %s -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 19:34:16 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:34:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 19:34:52 +0000 Subject: [Koha-bugs] [Bug 15275] "To" has multiple meanings, making it impossible to translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275 --- Comment #2 from Marc V?ron --- For koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt line 97 we could do: Field Old value New value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:35:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 19:35:11 +0000 Subject: [Koha-bugs] [Bug 12014] Make self-checkout listing match circulation.pl pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12014 Ian Palko changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Ian Palko --- Marked as duplicate of Bug 14404 *** This bug has been marked as a duplicate of bug 14404 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:35:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 19:35:11 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Ian Palko changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library at stas.org --- Comment #11 from Ian Palko --- *** Bug 12014 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:14:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 20:14:25 +0000 Subject: [Koha-bugs] [Bug 15275] "To" has multiple meanings, making it impossible to translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275 --- Comment #3 from Marc V?ron --- We have some "To:" as well (meaning the end of a date range): koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 20:29:03 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 20:48:24 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45288|0 |1 is obsolete| | --- Comment #31 from Bouzid --- Created attachment 45338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45338&action=edit Bug 11371 - QA fix, Parse errors: Bad plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 20:49:29 +0000 Subject: [Koha-bugs] [Bug 13722] Titles with articles not sorting correctly in lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 20:54:32 +0000 Subject: [Koha-bugs] [Bug 15271] Calendar breaks on double quotes in title or description of holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15271 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Confirmed. Set the title to [My "quoted" holiday] and the calendar vanishes. To make the calendar appear again, a database administrator has to remove or to edit the entry in table special_holidays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 22:03:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 21:03:47 +0000 Subject: [Koha-bugs] [Bug 15257] authority records imported via z39.50 don't get authid in the 001 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15257 rocio at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rocio at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 22:19:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 21:19:39 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 --- Comment #14 from Heather Braum --- I don't have the ability to test this right now. But based on the description, I think this may be a good solution. I would be interested in having a date returned timestamp as well in the table, unless it's easily queried from another table. Items can get checked out over and over again by the same patron -- it may get difficult to distinguish which time was what to provide more info to the patron, plus the less tables you have to query, the easier the reports are to write and return. What happens when the item is returned again? Does the previous entry for the same item get deleted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 22:38:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 21:38:36 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #47 from Nick Clemens --- The issue is that the Koha/Schema/Result files are not automatically updated (so ModMember wasn't even looking to update the sms_rpovider_id column) , per discussion in koha irc: What's the current procedure for patches that use Koha::Database on tables they introduce? Is the patch expected to include the new autogenerated files in Koha/Schema/Result, to ease testing? pianohacker: you can, but please in a separate patch easier when rebasing and easier for th etester, because they don't need to remember to run the script cait: makes sense. and makes it sandbox testable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 22:46:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 21:46:10 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #27 from Francois Charbonnier --- (In reply to Jonathan Druart from comment #26) > Comment on attachment 44826 [details] [review] > Bug 12528 - Enable staff to deny message setting access to patrons on the > OPAC > > Review of attachment 44826 [details] [review]: > ----------------------------------------------------------------- > > The description for EnhancedMessagingPreferences is "allow/don't allow > patrons to choose which notices they receive and when they receive them. > I think it could be updated to highlight that it's for the staff interface > only, or at least a reference to the new pref? You're right. We will change the preference description. It will be : [Allow/Don't allow] staff to manage which notices patrons will receive and when they will receive them. Note : this only applies to courtesy notices. To manage if patrons have also access to these settings, use OPACEnhancedMessagingPreferences. > Why don't you want the patrons to show the type of messages they receive? > I could understand not to let the patrons change the settings, but I don't > see the point to hide them completely. By hiding them, you avoid the question : "Why can't I change my settings by myself?" ;^) > ::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql > @@ +1,3 @@ > > +INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES > > +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') > > +; > > It would be better to set the value of the other pref, to avoid any > confusion. EnhancedMessagingPreference is already setup by updatedatabase so I don't think this should be change by the atomicupdate here. Moreover, we don't want to change the current setting when the library will run this update. > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt > @@ +131,5 @@ > > > >
    > > + [% ELSE %] > > +

    You are not allowed to call this page directly

    > > + To report this problem, you can email the Koha Administrator. > > "admin" does not seem to be sent to the template. We are currently working on this. :^) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 22:47:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 21:47:09 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #22 from Katrin Fischer --- Thx, I can see it now! So all we need is another sign-off now - or the old signed patch + a new follow-up dealing with the string changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:10:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:10:00 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 --- Comment #11 from Katrin Fischer --- I think 3.16 can be considered EOL currently, as it has no maintainer: http://wiki.koha-community.org/wiki/Roles_for_3.24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:16:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:16:40 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #8 from Katrin Fischer --- I thought about it, but then opted for "no surprise". If you are used to edit the Reserve Slip it might be irritating to find it renamed... but I can certainly write a follow-up if you think. I'd check for "Reserve slip" in the description, because of possible translations then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:21:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:21:56 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:23:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:23:02 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Version|3.14 |unspecified Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:27:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:27:03 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency CC| |gmc at esilibrary.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:31:05 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |ASSIGNED --- Comment #1 from Katrin Fischer --- Hi jvr - "Needs Signoff" should be set, once we have a patch file attached here. Until a dev starts working on this, it should be "NEW". I am resetting the bug status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:31:17 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:31:30 +0000 Subject: [Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14971 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:31:30 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14245 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:32:36 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Do we need to change the database update statements in later versions now to avoid errors/warnings? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:33:31 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 --- Comment #9 from Katrin Fischer --- Ah, I see it already includes a check for existence - so should be safe :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:38:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:38:11 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45331|0 |1 is obsolete| | Attachment #45333|0 |1 is obsolete| | --- Comment #8 from Mirko Tietgen --- Created attachment 45339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45339&action=edit Bug 14168 - enhance streaming cataloging to include youtube Add optional embedding of YouTube videos via HTML5Media. New syspref: HTML5MediaYouTube: Embed/Don't embed videos. Format WEBM is hardcoded as it is the only format accepted by all modern browsers. Test plan: - apply patch - catalogue a YouTube link in 856$u - turn on HTML5MediaEnabled and HTML5MediaYouTube - open the record in OPAC and staff client, check that the 'Play media' tab is showing and playing the video works. Possible enhancements for followups: - check available formats, offer quality choice - accept official YT URL shortener -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:38:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:38:27 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:39:13 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #14 from David Cook --- (In reply to Fr?d?ric Demians from comment #12) > Forget this. I've added a [% IF %] in your patch that I've signed off in > order to not display this column when unnecessary. Cheers, Fr?d?ric :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:41:24 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 jvr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from jvr --- I already set "Needs Sigoff" several times in the pass, but it seems it doesn't save changes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:42:32 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Katrin Fischer --- Plese don't reset this to "Needs Signoff" as it has no patch to test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:42:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:42:37 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:42:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:42:54 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 --- Comment #4 from Katrin Fischer --- The correct status is new - this indicates it needs someone to write a patch for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:44:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:44:09 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #15 from David Cook --- Comment on attachment 44772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44772 Bug 14393 - Add collection code filter to inventory Review of attachment 44772: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14393&attachment=44772) ----------------------------------------------------------------- ::: tools/inventory.pl @@ +95,5 @@ > } > push @authorised_value_list,@$data; > } > + > + my $collection_authorised_value = C4::Koha::GetAuthValCode("items.ccode", $fwkcode); In practice, it might be enough to get the default one, but in theory you could use different authorized value categories than "CCODE" for "item.ccode" depending on the framework of the biblio to which an item is attached. Originally, I just used the default framework, but then realized that it wasn't necessarily comprehensive enough. In practice, I don't know if anyone would map multiple categories to "item.ccode", but it is theoretically possible. You might only allow certain collections for a certain framework. Framework A might use "CCODE" which refers to textual collections while Framework B might use "CCODE2"which refers to audiovisual collections. That would probably be madness, but it's possible madness. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:44:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:44:22 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45298|0 |1 is obsolete| | --- Comment #16 from Jen Zajac --- Created attachment 45340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45340&action=edit Bug 15269 [ENH]: Layout tweaks for the opac-detail page Make the following improvements to the layout of the OPAC detail page: * Image thumbnail has more white space * Summary is moved up the details block and font size is increased * Ratings controls are moved up the details * Small devices get a better layout To test: - Check that the ratings controls are moved up the page to be before the summary * If there is no summary, the controls should be under the series * If there is no summary or no series, the controls should be under the type * If there is no summary, no series, or no type, the controls should be under the authors (including contributing authors) - Check that the 520 field (Summary, Subject, Review, Scope and content, Abstract, Content advice) is rendered nearer to the top of the page, following material type, series, and the ratings. - Check that the font size for "Material type", "Series" and the 520 field (Summary, Subject, Review, Scope and content, Abstract, Content advice) are rendered at a 14px font size. - Check that authors and contributing authors are rendered at 16px font size. - Check that if any kind of cover image is present (or the no cover image placeholder image) it is rendered into a div with a class of 'span2' and appears on the left of the main item details. * Need to test every kind of cover image service * If no kind of cover image service is turned on, then the 'span2' div should not be present and the item details should be on the left of the content area. - Check that small devices (e.g. mobile phones) make the 'span2' image column take up the full width and appear above the rest of the item details. - Check that layout of the search results page is unaffected. - Check that changing 'OPACXSLTDetailsDisplay' to an empty string still yields the expected layout. Sponsored-by: ByWater -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:44:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:44:34 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jen Zajac changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45299|0 |1 is obsolete| | --- Comment #17 from Jen Zajac --- Created attachment 45341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45341&action=edit Bug 15269 [ENH]: Compiled CSS changes Sponsored-by: ByWater -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:44:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:44:42 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #16 from David Cook --- ^ that last comment was for Jonathan. Perhaps I should've just replied to the comment rather than on the splinter review... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:45:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:45:29 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 --- Comment #18 from Jen Zajac --- Hi H?ctor, Thanks again for you work looking into this. It looks like the local cover images not having a proper placeholder is a bug as a 1x1 pixel image is returned. There is a bug that addresses this at: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 I'm aware that there is whitespace under the cover image (or images if you have more than one source turned on). This is by design, IMO it makes the page look less cluttered. Having a narrower column for the main details is not necessarily a bad thing, there are studies that say that slightly narrower columns are easier to read (see e.g. http://graphicdesign.stackexchange.com/questions/13724/recommended-column-width-for-text-reading-digital-vs-printed). I had a look at porting some of the changes to NOMARC and UNIMARC but I'm a bit leery of messing with them as I'm not sure I'm grokking some of the data structures. I could help with porting the changes from this patch to those systems as a later patchset. In the meantime, those systems will still get some but not all of the changes from this patch: the cover image column, larger font size for the authors, ratings controls moved up under the authors. They won't get the item summary moved up and the larger font sizes for series, summary and item type. I have made one change in the most recent update. The 773 data in MARC21slim2OPACDetail.xsl is moved back down to its original location. I had moved it up along with the summary field, but I don't think any more that they need to move together, and leaving it in its original position reduces the scope of this change. I don't unfortunately have any credentials either, but I am checking with my colleagues if we can shoulder tap someone who does to do a bit more testing on that front. Thanks, Jen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:53:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 22:53:40 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- You are right, it's theoretically possible... but in my opinoin not recommendable. Think about features like item batch editing or any search form/report that offers you a list of collections. It will cause lots of inconvenience if someone does that. I think we don't need to cover this possibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:00:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:00:10 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #33 from David Cook --- (In reply to Fr?d?ric Demians from comment #32) > (In reply to Jonathan Druart from comment #29) > > The tests does not pass: > > t/db_dependent/OAI/Server.t .. 1/13 Can't call method "start_element" on an > > undefined value at /usr/share/perl5/HTTP/OAI/Verb.pm line 53. > > See: > > https://rt.cpan.org/Public/Bug/Display.html?id=102010 Are you sure about that? As H?ctor pointed out, it looks like the version in Wheezy and Jessie is the same: https://packages.debian.org/wheezy/libhttp-oai-perl https://packages.debian.org/jessie/libhttp-oai-perl As I pointed out on https://rt.cpan.org/Public/Bug/Display.html?id=102010, someone had force installed 4.03 on the openSUSE machine I was on, and it failed miserably. It worked fine when I downgraded back to 3.28, but Debian should be using 3.27-1 for both Wheezy and Jessie which should be fine... It does appear that someone has recently done some work to add 4.03 into Debian: https://anonscm.debian.org/cgit/pkg-perl/packages/libhttp-oai-perl.git/ Both Debian Stretch (ie testing) and Debian Sid (ie unstable) are using 4.03-1 which at a glance looks like it doesn't include any fix for that CPAN ticket, so all use of HTTP::OAI would break...: https://packages.debian.org/stretch/libhttp-oai-perl https://packages.debian.org/sid/libhttp-oai-perl -- H?ctor: What version of Debian are you using? Jonathan: What version of Debian are you using? Fr?d?ric: What OS/version are you using? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:01:43 +0000 Subject: [Koha-bugs] [Bug 15275] "To" has multiple meanings, making it impossible to translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to Marc V?ron from comment #2) > For koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt line > 97 we could do: > > Field > Old value > New value That would work for me and fix a really annoying translation issue :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:08:20 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #34 from David Cook --- Fr?d?ric: I noticed on https://rt.cpan.org/Public/Bug/Display.html?id=102010 that you asked if there was anything you could do to fix the problem. I'm guessing that HTTP::OAI itself isn't maintained so well anymore on CPAN, but you could report a bug in Debian perhaps: https://www.debian.org/Bugs/ Robin reported a bug in the idzebra-2.0 package earlier in the year but didn't have much success: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=777515. Although I think that's because the package maintainer didn't see it or isn't active anymore. In the case of HTTP::OAI, it seems that the maintainer gregor herrmann is fairly active: https://anonscm.debian.org/cgit/pkg-perl/packages/libhttp-oai-perl.git/, so it might be worth contacting him as well, even if the problems are just in Debian Testing and Debian Unstable... It would be great if someone could confirm for sure that there are problems in Debian Jessie, although I think Robin has been using Jessie for a while and he was doing quite a bit with HTTP::OAI this year so I would've thought he'd notice an issue during that time... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:09:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:09:13 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 --- Comment #4 from Katrin Fischer --- Changes look good to me - I like the clearer structure. I think I found a small mistake, a stray     tag:
    • Example 1: INSTID:12345,LANG:fr
    • -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:09:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:09:30 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #18 from David Cook --- (In reply to Katrin Fischer from comment #17) > You are right, it's theoretically possible... but in my opinoin not > recommendable. Think about features like item batch editing or any search > form/report that offers you a list of collections. It will cause lots of > inconvenience if someone does that. I think we don't need to cover this > possibility. Ok. I'm fine with that. I was mostly just following the pattern that already existed in the script. Other things than collection code do this same check. Should a follow-up remove this "all framework checking" for all criteria? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:15:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:15:01 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 --- Comment #8 from Katrin Fischer --- I think it happens when the system has to decide wether to update an existing fine or to add a new fine. Take a look at the UpdateFines routine: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Overdues.pm;hb=3dfb6252faf6abec64cfc50a090aa0ce7d272115#l537 I think this isn't easy to fix/change right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:16:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:16:21 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #16 from Nick Clemens --- The holds transfer as expected, and the patron gets the email but I am not getting the admin email. I also got the error below when running misc/cronjobs/holds/cancel_expired_holds.pl: DBD::mysql::st execute failed: Duplicate entry '6' for key 'PRIMARY' [for Statement " INSERT INTO old_reserves SELECT * FROM reserves WHERE reserve_id = ? " with ParamValues: 0='6'] at C4/Reserves.pm line 1080. Can't locate object method "new" via package "C4::Dates" (perhaps you forgot to load "C4::Dates"?) at C4/Reserves.pm line 2073. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:16:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:16:48 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 --- Comment #9 from Katrin Fischer --- (In reply to Marc V?ron from comment #7) > (In reply to Galen Charlton from comment #6) > > Of course, changing the dateformat is not a common decision. We just introduced a new dateformat (DD.MM.YYYY), so I think some switching will happen soon, at least for installations in some areas :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:18:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:18:16 +0000 Subject: [Koha-bugs] [Bug 11757] dependency on POE is not longer necessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11757 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- The new work I'm doing for http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662, which hasn't been posted yet, will be using libpoe-perl (and potentially libpoe-component-client-http-perl) for the OAI-PMH harvester daemon. Galen, how would you like folk to ask for Perl dependencies to be added to Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:20:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:20:58 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14825 CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure if this is possible with the way we currently store the data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:20:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:20:58 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15273 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:21:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:21:51 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 --- Comment #12 from M. Tompsett --- Created attachment 45342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45342&action=edit Bug 14259: OPAC system preference BiblioDefaultView is ignored (3.16.x) Cover image links ignore the BiblioDefaultView value for non-XSLT. TEST PLAN --------- 1) Back up your database 2) drop you db and do a fresh install of the sample data 3) set koha admin to a super librarian, and set up a username and password for it. 4) catalog "The Road To Character" by David Brooks. 5) using koha admin import a small set of data. 6) stop zebra and do a full reindex then restart it. 7) Change the 'OPACXSLTDetailsDisplay' and 'OPACXSLTResultsDisplay' system preferences to blank! -- This corrects the non-XSLT things missed by 12574. 7) Change the 'GoogleJackets' system preference to 'Add'. 8) Change the 'BiblioDefaultView' system preference to 'in their MARC form'. 9) Change the 'IDreamBooksResults' system preference to 'Add'. 10) Search for something that will find "The Road To Character" and something else in the OPAC. 11) Run your mouse over the title text in the search results. -- Link will be to opac-MARCdetail.pl 12) Run your mouse over the cover image or lack thereof. -- Link will be to opac-detail.pl -- This will fail for both "The Road to Character" and the non-"The Road to Character" entries. 13) Apply this patch 14) Refresh the OPAC page -- Links under the cover images will be corrected. 15) In the staff client, change 'IDreamBooksReviews' to 'Add'. 16) Refresh the OPAC page -- "The Road to Character" will be correct, but have a '#idb_critic_reviews' appended. 17) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:22:12 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Please wait for the QA team. If something is urgently needed, feel free to nudge me or one of the others about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:26:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:26:16 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Katrin Fischer --- I understand now why the lines have been added, I am ok with keeping them. If you want and agree, you can sign off my QA follow-up patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:27:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:27:08 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED --- Comment #13 from M. Tompsett --- As per Katrin's comment #11, I felt this best to mark as RESOLVED WONT FIX. Though, in the off chance there is found a 3.16.x maintainer, I've attached what I believe will work for 3.16. Otherwise, based on Jonathan Druart's comment #9, I'll reiterate what seems to be the recommendation that I stated in comment #10: - Change the OPACXSLTDetailsDisplay, OPACXSLTResultsDisplay, XSLTDetailsDisplay, and XSLTResultsDisplay all to default, as they are likely blank currently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:41:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:41:49 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 --- Comment #5 from Marc V?ron --- Created attachment 45343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45343&action=edit Bug 15231: (followup) Remove stray tag This patch removes a stray tag (see comment #4) and a superfluous blank. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:49:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:49:01 +0000 Subject: [Koha-bugs] [Bug 15144] Fix dashboard font to be Arial, Helvetica, sans-serif for all text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15144 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:51:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:51:48 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 --- Comment #2 from bondiurbano --- So there's no way to generate a single receipt of all accounts paid when the payment is triggered... what a pity... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:52:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:52:34 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 --- Comment #3 from bondiurbano --- Created attachment 45344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45344&action=edit Pay receipt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:54:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2015 23:54:20 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 --- Comment #4 from bondiurbano --- it is realy anti intuitive... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 01:00:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 00:00:34 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alexklbuckley at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:14:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 01:14:57 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #52 from David Cook --- (In reply to Leif Andersson from comment #51) > (In reply to David Cook from comment #50) > > Honestly though, I would ask that people think further about the frequency > > of harvests. Is every 2-3 seconds really necessary? Do we really need it to > > be able to perform that quickly? > > > > Well, the use case envisioned by Stockholm UL would in practice ideally > involve fetching ONE record every 10 minutes or so! > The cataloger will be creating/modifying a bib record and a mfhd record in > our union catalog. > Next, the cataloger will turn to our local catalog, Koha, expecting to find > this record already imported. > If there is a way for the harvester to decide which ONE record to > get...maybe even with some intervention by the cataloger...? > So when this ONE record is asked for, we want it to be a quick process > getting it from the source and into Koha. > What's Stockholm UL? So you're saying that the union catalogue will only have updates about once every 10 minutes? Or that the cataloguer will only be accessing a record in the union catalogue and Koha once every 10 minutes? I am including a mechanism for fetching "one" record, so long as the user knows the OAI-PMH identifier they're after. They'll be able to add a task for that. Perhaps a future development could be done to provide an interface in the cataloguing module for adding/updating a single record. In place of that interface, they'll be able to add a task in the same area as the other tasks in order to get the one record... > Then nightly more massive harvests could be performed to catch up with other > modifications to the union catalog. > Those nightly harvests would certainly be possible with the current design. > From my point of view it seems a little contrived to use a OAI harvester for > this kind of job - synching Koha with union catalog just to be able to > instantly work locally on a record. > But it is what has been recommended to us by the union catalog from which we > are importing records. What do you mean by "work locally on a record"? The union catalog will be the source of truth, so any modifications to a record in Koha would be overwritten by a change in the union catalogue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:46:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 01:46:34 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:46:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 01:46:39 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #167 from Liz Rea --- Created attachment 45345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45345&action=edit Bug 12929: (followup) fix license I fix it myself. Signed-off-by: Bernardo Gonzalez Kriegel http://bugs.koha-community.org/show_bug.cgi?id=12919 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:49:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 01:49:37 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45343|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 45346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45346&action=edit [SIGNED-OFF]Bug 15231: (followup) Remove stray tag This patch removes a stray tag (see comment #4) and a superfluous blank. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 02:14:41 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #35 from H?ctor Eduardo Castro Avalos --- (In reply to David Cook from comment #33) > H?ctor: What version of Debian are you using? > Jonathan: What version of Debian are you using? > Fr?d?ric: What OS/version are you using? Hi David I applied the patch in both Jessie and Wheezy and test passed successfully, maybe fail with Ubuntu. I Enabled OAI-PMH and play with: cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:1&metadataPrefix=marcxml cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:1&metadataPrefix=oai_dc And works well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 02:24:26 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #36 from David Cook --- (In reply to H?ctor Eduardo Castro Avalos from comment #35) > (In reply to David Cook from comment #33) > > > H?ctor: What version of Debian are you using? > > Jonathan: What version of Debian are you using? > > Fr?d?ric: What OS/version are you using? > > Hi David > > I applied the patch in both Jessie and Wheezy and test passed successfully, > maybe fail with Ubuntu. > It looks like Ubuntu 15.10 Wily has the 4.03-1 version, but 14.04 has 3.27-1. http://packages.ubuntu.com/wily/libhttp-oai-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:39:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 02:39:43 +0000 Subject: [Koha-bugs] [Bug 15287] New: Use font-awesome on the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Bug ID: 15287 Summary: Use font-awesome on the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: francescalamoore at gmail.com QA Contact: testopia at bugs.koha-community.org Font-awesome is now being used in the staff intranet and should be used in the OPAC as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:43:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 02:43:03 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28270|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45347&action=edit [SIGNED-OFF]BUG 11602: [ENH] Fix localcover display Adds a css class of thumbnail to local covers Don't show the 1px "No image found" image (since we'll ususally try another image provider) Add a class to local thumbnails and don't show 1px no-image-found Signed-off-by: Hector Castro Box with "No cover image availabe" fixed when syspref OPACLocalCoverImages set to display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:43:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 02:43:24 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 04:04:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 03:04:32 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #19 from H?ctor Eduardo Castro Avalos --- You're right Jen if you apply 11602 on top the placeholder is fixed it up. For me status need to change to Needs sign-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 04:28:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 03:28:04 +0000 Subject: [Koha-bugs] [Bug 15193] Perl scripts missing exec permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44874|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 45348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45348&action=edit [SIGNED-OFF]Bug 15193: Perl scripts missing exec permission Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl. This patch corrects some common perl scripts. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 04:28:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 03:28:26 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #168 from Liz Rea --- Created attachment 45349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45349&action=edit DBRev 3.23.00.000: 2016 Year of the Monkey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 04:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 03:28:28 +0000 Subject: [Koha-bugs] [Bug 15193] Perl scripts missing exec permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 05:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 04:11:16 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hector.hecaxmmx at gmail.com, | |veron at veron.ch --- Comment #17 from H?ctor Eduardo Castro Avalos --- (In reply to Nick Clemens from comment #16) > The holds transfer as expected, and the patron gets the email but I am not > getting the admin email. > > I also got the error below when running > misc/cronjobs/holds/cancel_expired_holds.pl: > > DBD::mysql::st execute failed: Duplicate entry '6' for key 'PRIMARY' [for > Statement " > INSERT INTO old_reserves > SELECT * FROM reserves > WHERE reserve_id = ? > " with ParamValues: 0='6'] at C4/Reserves.pm line 1080. > Can't locate object method "new" via package "C4::Dates" (perhaps you forgot > to load "C4::Dates"?) at C4/Reserves.pm line 2073. You're right Nick, patch Fail QA since Marc has been removed C4::Dates from system. Kyle, please remove C4::Dates and use Koha::DateUtils instead. substitute => { today => C4::Dates->new()->output() }, in line 2077 I add here Marc since he removed the C4::Dates from Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 07:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 06:20:25 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #37 from Fr?d?ric Demians --- I confirm that Jessie/Wheezy package 3.2x version. Jonathan who reported the issue should use a CPAN installed version of HTTP::OAI. I've also have reported the bug on Github: https://github.com/timbrody/perl-oai-lib But no response yet. We may give a phone call to Tim Brody... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 07:23:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 06:23:21 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #10 from Fr?d?ric Demians --- (In reply to Katrin Fischer from comment #9) > Please wait for the QA team. If something is urgently needed, feel free to > nudge me or one of the others about it. OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 08:58:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 07:58:10 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15273 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 [Bug 15273] Fines Payment receipt should include all account lines selected for this pay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 08:58:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 07:58:10 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Depends on| |14826 --- Comment #5 from Josef Moravec --- I think it depends on bud 14826 - this should introduce table to link payments to fines. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 [Bug 14826] Resurrect account offsets table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 09:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 08:25:25 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #53 from Magnus Enger --- > What's Stockholm UL? Probably Stockholm University Library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 09:36:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 08:36:57 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #54 from Leif Andersson --- > What's Stockholm UL? Stockholm University Library > So you're saying that the union catalogue will only have updates about once > every 10 minutes? Or that the cataloguer will only be accessing a record in > the union catalogue and Koha once every 10 minutes? > As a rough estimate the cataloger will access a record every 10 minutes. > What do you mean by "work locally on a record"? The union catalog will be > the source of truth, so any modifications to a record in Koha would be > overwritten by a change in the union catalogue. Sorry for being unclear. I ment item data: barcode, item type... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 09:43:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 08:43:47 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #28 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #27) > > Why don't you want the patrons to show the type of messages they receive? > > I could understand not to let the patrons change the settings, but I don't > > see the point to hide them completely. > > By hiding them, you avoid the question : "Why can't I change my settings by > myself?" ;^) But can answer the question "Why am I receiving email for that?" We can imagine a quick sentence "Contact your library if you want to change them" > > ::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql > > @@ +1,3 @@ > > > +INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES > > > +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') > > > +; > > > > It would be better to set the value of the other pref, to avoid any > > confusion. > > EnhancedMessagingPreference is already setup by updatedatabase so I don't > think this should be change by the atomicupdate here. Moreover, we don't > want to change the current setting when the library will run this update. OPACEnhancedMessagingPreferences is added (for existing install, so in updatedatabase.pl) and enabled. It does not hurt if EnhancedMessagingPreference is disabled, because in the code both are checked. But it would be better to enable OPACEnhancedMessagingPreferences only if EnhancedMessagingPreference is enabled too. It will avoid to have "OPACEnhancedMessagingPreference is enabled but not really because EnhancedMessagingPreference is not" on the admin pref page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:06:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 09:06:34 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #38 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #37) > I confirm that Jessie/Wheezy package 3.2x version. Jonathan who reported the > issue should use a CPAN installed version of HTTP::OAI. > > I've also have reported the bug on Github: > > https://github.com/timbrody/perl-oai-lib > > But no response yet. We may give a phone call to Tim Brody... So sorry, I was using testing! Indeed it's 3.27 on my Jessie box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:10:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 09:10:46 +0000 Subject: [Koha-bugs] [Bug 15288] New: 404 page: Remove string splitting by html tags to avoid weird translations Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Bug ID: 15288 Summary: 404 page: Remove string splitting by html tags to avoid weird translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr On the Koha Error 404 page the following sentence is not properly translatable due to string splitting: To report a broken link or any other issue, please send an email to the Koha Administrator In German, it results in: Um diesen Fehler zu melden, k?nnen Sie E-Mail an den Koha-Administrator. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:13:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 09:13:48 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #29 from Fr?d?ric Demians --- Suggestion for OPACEnhancedMessagingPreferences. It could have 3 values rather than 2: 0- Not displayed 1- Displayed 2- Modifiable When updating an existing DB (see Jonathan comment): my $emp = C4::Context->preference('EnhancedMessagingPreferences') ? 2 : 0; INSERT INTO systempreferences (variable, value, options, explanation, type) VALUES ('OPACEnhancedMessagingPreferences', $emp, NULL, 'Not display/display/modify patrons messaging setting on the OPAC.', 'YesNo') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:20:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 09:20:49 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:20:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 09:20:53 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45264|0 |1 is obsolete| | --- Comment #23 from Fr?d?ric Demians --- Created attachment 45350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45350&action=edit Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues There is already a syspref called "OverdueNoticeBcc" for sending Bcc copies of mails sent for overdues and other notices. This patch add a new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues alerts. Changed the wording of the system preference to: [Send|Don't send] blind copy (BCC) to logged in user when sending serial or acquisitions claims notices. Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:44:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 09:44:50 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #39 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #38) > So sorry, I was using testing! > Indeed it's 3.27 on my Jessie box. And does it work? Are tests passing? If so, H?ctor could re-sign-off the attached patch, which is supposed to fix test failings you pointed out. It remains that HTTP::OAI v4 is a time bomb... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:51:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 09:51:38 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 11:02:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 10:02:52 +0000 Subject: [Koha-bugs] [Bug 15289] New: "borrowers" permission doesn't allow to see current loans Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Bug ID: 15289 Summary: "borrowers" permission doesn't allow to see current loans Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Permission "borrowers" gives an access to the Details page of a patron. But, in our previous version, we can see the list of the document checkout in this page. Now, we just have the information 'loading' in the checkout tables, but we can't see documents on loan. We should have an access to list of the loan, even without the "circulate" permission, to be able to inform patrons about the books they have, tell them the due date... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:09:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 11:09:09 +0000 Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 --- Comment #13 from Koha Team Lyon 3 --- Hi, we are really interested in this bug and ready to test it as soon as a new patch is send. Thanks, Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:18:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 11:18:30 +0000 Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 --- Comment #14 from Amit Gupta --- Thanks for comment we will try to rework and send to community. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:28:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 12:28:02 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 45351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45351&action=edit Bug 14971: fix RIS export This patch removes a limit in RIS.pm print_isbn sub. To test: 1) Find in opac a book with an isbn with length(isbn) > 10 (with dashes or isbn13) 2) Export record to RIS format, check truncated SN field in exported file 3) Apply the patch 4) Export again, no more truncation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 12:28:59 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Assignee|oleonard at myacpl.org |bgkriegel at gmail.com Status|NEW |Needs Signoff Severity|enhancement |minor Patch complexity|--- |Trivial patch --- Comment #6 from Bernardo Gonzalez Kriegel --- This is not UNIMARC specific. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:56:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 12:56:13 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 --- Comment #6 from bondiurbano --- I understand. #14826 is a structural change to prepare tables for future enhancements (i.e. payment receipt with detail information). I will mark as duplicate #15273. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:57:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 12:57:41 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 --- Comment #7 from Katrin Fischer --- Hi bondiurbano, I think it's worth having this bug open, as it shows what we need to do after we got the linked bugs resolved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:00:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 13:00:21 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #1 from bondiurbano --- Resolve this bug opens many oportunities of enhancements that are being waiting by the librarian communitiy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:04:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 13:04:49 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #9 from Katrin Fischer --- Created attachment 45352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45352&action=edit Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations Title and description are updated separately, in case that the library has changed one of them when editing the slip. To test: - Verify that you have a letter named 'Reserve Slip' in your database - Run the database update - Verify the slip has been renamed correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:05:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 13:05:48 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 --- Comment #8 from bondiurbano --- Thanks Katrin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 13:08:47 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Katrin Fischer --- I have added another patch to update existing installations - please test and comment if you think if this change is useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:26:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 13:26:07 +0000 Subject: [Koha-bugs] [Bug 15290] New: SQL reports encoding problem Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Bug ID: 15290 Summary: SQL reports encoding problem Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: vfernandes at keep.pt QA Contact: testopia at bugs.koha-community.org The problem appears when running a SQL report or exporting a SQL report. The column header are in incorrect encoding. Test plan: 1 - Add a new SQL report using the following SQL for example: SELECT borrowers.cardnumber 'N?mero cart?o', CONCAT (borrowers.firstname, ' ' , borrowers.surname) Nome, categories.description Grupo, borrowers.branchcode Biblioteca,borrowers.dateenrolled 'Data de inscri??o', borrowers.dateexpiry 'Data limite' FROM borrowers INNER JOIN categories ON borrowers.categorycode = categories.categorycode ORDER BY borrowers.cardnumber ASC 2 - Run the report 3 - The column headers are incorrect. 4 - Export the report to CSV. 5 - The column headers on the file are incorrect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:26:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 13:26:21 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Vitor Fernandes changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:43:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 13:43:54 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #9 from Mirko Tietgen --- I forgot to say that the following still applies: Needs libwww-youtube-download-perl to work, which is in Jessie. https://packages.debian.org/jessie/libwww-youtube-download-perl Install it before testing :) The Jessie module will likely work in Wheezy too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:12:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:12:22 +0000 Subject: [Koha-bugs] [Bug 15289] "borrowers" permission doesn't allow to see current loans In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:13:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:13:14 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #59 from Katrin Fischer --- Is it possible both modules are not packaged for Ubuntu? I couldn't install/find either via apt-get? I think the dependency questions need to be resolved first, before we can move this further through QA! Starting with a code review anyway: 1) QA script FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/printers.tt FAIL spelling recieve ==> receive FAIL misc/cronjobs/holds/print_holds.pl FAIL pod *** ERROR: =over on line 135 without closing =back (at head1) in file misc/cronjobs/holds/print_holds.pl 2) New notice a) The insert statements are missing the message_transport_type: +INSERT INTO `letter` (`module`,`code`,`branchcode`,`name`,`is_html`,`title`,`content`) b) HOLD_PLACED_PRINT sounds like there is a connection to the existing HOLD_PLACED feature. If this is the case, should this be just the 'print' version of the HOLD_PLACED notice? And if not, should we rename to make the difference clear? c) Notice is missing from the translated web installers. 3) Templates a) Icons need to be switched to Font Awesome. For example: koha-tmpl/intranet-tmpl/prog/en/includes/printers-toolbar.inc. b) koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt changes the heading and description of one of the toolbar items back to the old one, should be: Z39.50/SRU searvers c) I think page title/breadcrumbs and the new entry on Administration should match. Personally I'd prefer the simpler 'Printers' to 'Printer editor' as it's more in line with our other pages. d) This would be nicer to translate using the newer syntax and a placeholder: else if (confirm(_("Are you sure you wish to delete printer(s) ") + idsToDelete + "?")) See: Bug 12138 - Use placeholders in translatable javascript strings 4) Terminology Holds!! :) koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/printers.tt print automatic reserve notices 5) Copyright Is the copyright correct on the new file svc/printer? +# Copyright 2014 ByWater Solutions +# Copyright 2012 Foundations Bible College Inc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:14:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:14:48 +0000 Subject: [Koha-bugs] [Bug 15289] "borrowers" permission doesn't allow to see current loans In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 --- Comment #1 from Fridolin SOMERS --- Indeed, the file svc/checkouts contains : my ( $auth_status, $sessionID ) = check_cookie_auth( $input->cookie('CGISESSID'), { circulate => 'circulate_remaining_permissions' } ); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:14:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:14:54 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:15:47 +0000 Subject: [Koha-bugs] [Bug 15289] "borrowers" permission doesn't allow to see current loans In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 --- Comment #2 from Fridolin SOMERS --- Maybe it should depend on which page calls the code -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:23:32 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master Assignee|gmcharlt at gmail.com |tomascohen at gmail.com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:23:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:23:37 +0000 Subject: [Koha-bugs] [Bug 15288] Staff error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | Component|I18N/L10N |Architecture, internals, | |and plumbing Summary|404 page: Remove string |Staff error pages: Code |splitting by html tags to |duplication removal and |avoid weird translations |better translatability --- Comment #1 from Marc V?ron --- The problem is related to all error pages (400, 401, 402, 403, 404 500). Changing Bug title to "Staff error pages: Code duplication removal and better translatability" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:24:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:24:00 +0000 Subject: [Koha-bugs] [Bug 15288] Staff error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:29:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:29:24 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:29:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:29:27 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 45353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45353&action=edit Bug 15290: SQL reports headers encoding problem To test: - Create an SQL report with column names containing UTF characters - Run the report => FAIL: The column names are double encoded - Export the report => FAIL: The column names are double encoded in the exported file - Apply the patch - Re-run the report (reload works) => SUCCESS: Encoding correct - Export the report => SUCCESS: Encoding correct - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:32:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:32:10 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #2 from Tom?s Cohen Arazi --- (In reply to Tom?s Cohen Arazi from comment #1) > - Export the report > => SUCCESS: Encoding correct It doesn't fix the exported files. Followup needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:48:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:48:40 +0000 Subject: [Koha-bugs] [Bug 15288] Staff error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #2 from Marc V?ron --- Created attachment 45354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45354&action=edit Bug 15288: Staff error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by one template only. Additionally it removes a translatability issue due to a sentence split by html tags. To test: - Apply patch - Trigger 404 error by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:49:34 +0000 Subject: [Koha-bugs] [Bug 15291] New: Can't import item data in acquisition from a stage file with modification templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15291 Bug ID: 15291 Summary: Can't import item data in acquisition from a stage file with modification templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org It is possible to use modification templates to import data in items if importing it in the catalog but it isn't possible if we import it in a basket during the acquisition process. For example, I have in the marc framework, all items data are in 995 field and the callnumber in 995$k subfield. In a marc file, I have the callnumber in 921$a. I use a MARC modification templates to copy 921$a subfield in 995$k subfield. If I use this modification template to import a stage file with 921$a in catalog, it creates item with for callnumber the value stored in 921$a. But, if I use this modification template to import a stage file from a basket during the acquisition process, it creates items without callnumber. I hope that I'm enough clear... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:51:47 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #3 from H?ctor Eduardo Castro Avalos --- (In reply to Tom?s Cohen Arazi from comment #2) > (In reply to Tom?s Cohen Arazi from comment #1) > > - Export the report > > => SUCCESS: Encoding correct > > It doesn't fix the exported files. Followup needed. Just fail in comma separated in tab separated and open document doesn't fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:55:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:55:02 +0000 Subject: [Koha-bugs] [Bug 15288] Staff error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45354|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 45355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45355&action=edit Bug 15288: Staff error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by one template only. Additionally it removes a translatability issue due to a sentence split by html tags. To test: - Apply patch - Trigger 404 error by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:58:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 14:58:30 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #4 from Vitor Fernandes --- CSV fails. Tab separated text fails. Open Document spreadsheet it's fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:04:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:04:39 +0000 Subject: [Koha-bugs] [Bug 15292] New: Libris (Swedish national catalogue) item status service Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 Bug ID: 15292 Summary: Libris (Swedish national catalogue) item status service Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: xarragon at gmail.com QA Contact: testopia at bugs.koha-community.org In Sweden most libraries pulls their MARC records from a central repository run by the Royal Library in Stockholm. These MARC records include a unique identifier in control field 001 which is used to identify a particular bibliographic entry. Anyone can browse this online database of available works. Once an interesting title is found the visitor can list all libraries that holds that particular book. Once a library is selected, the status of that item can be queried in realtime from the home page. In order to facilitate that query the ILS must implement a handler for a specific HTTP request. The request has a single parameter, the Libris ID of the bibliographic entry, stored in the MARC record. This patch adds a new ILS-DI service called GetLibrisAvailability that takes a single string as an ID and uses Zebra/Z39.50 to search for it (Koha luckily indexes this field by default). If found, the search result is used to locate the entry in the SQL database to retrieve the current status of the item. This is returned as an XML document to the central Libris server. I need feedback on how to implement tests for Z39.50 functionality. I would like to programmatically insert a faked work much like how TestBuilder can be used to generate fake SQL data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:07:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:07:12 +0000 Subject: [Koha-bugs] [Bug 15288] Staff error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45355|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 45356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45356&action=edit Bug 15288: Staff error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by one template only. Additionally it removes a translatability issue due to a sentence split by html tags. To test: - Apply patch - Trigger 404 error by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:07:22 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:07:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:07:21 +0000 Subject: [Koha-bugs] [Bug 15293] New: Move the C4::Branch related code to Koha::Libraries Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 Bug ID: 15293 Summary: Move the C4::Branch related code to Koha::Libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:07:22 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:07:22 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:07:22 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:07:22 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:07:22 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:07:22 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:09:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:09:46 +0000 Subject: [Koha-bugs] [Bug 15294] New: Move the C4::Branch related code to Koha::Libraries - part 1 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Bug ID: 15294 Summary: Move the C4::Branch related code to Koha::Libraries - part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This first part will include: - move Koha::Branch[es] to Koha::Librar[y|ies] - use Koha::Libraries from admin/branches.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:13:46 +0000 Subject: [Koha-bugs] [Bug 15293] Move the C4::Branch related code to Koha::Libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15295 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:13:46 +0000 Subject: [Koha-bugs] [Bug 15295] New: Move the C4::Branch related code to Koha::Libraries - part 2 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Bug ID: 15295 Summary: Move the C4::Branch related code to Koha::Libraries - part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15293 In this second part, the following subroutines from C4::Branch will be removed by using methods from Koha::Libraries. - DelBranch - DelBranchCategory - CheckCategoryUnique - CheckBranchCategorycode - GetBranchCategory - GetBranchCategories - GetCategoryTypes - GetBranchesCount - ModBranchCategoryInfo Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 [Bug 15293] Move the C4::Branch related code to Koha::Libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:13:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:13:52 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15293 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 [Bug 15293] Move the C4::Branch related code to Koha::Libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:13:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:13:52 +0000 Subject: [Koha-bugs] [Bug 15293] Move the C4::Branch related code to Koha::Libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15294 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:17:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:17:03 +0000 Subject: [Koha-bugs] [Bug 15288] Staff error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45356|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 45357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45357&action=edit Bug 15288: Staff error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by one template only. Additionally it removes a translatability issue due to a sentence split by html tags. To test: - Apply patch - Trigger 404 error by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files (Amended to fix a typo) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:17:43 +0000 Subject: [Koha-bugs] [Bug 15296] New: MEMBER logging in action_logs does not give enough detail. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15296 Bug ID: 15296 Summary: MEMBER logging in action_logs does not give enough detail. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com One of our libraries was trying to track down an issue where a patron was charged an enrollment fee -- looking at the patron's category code, it was clear that the patron was not currently in a category that should have been charged. I wanted to see if the patron's category code had changed. Here's what I found in action_logs: select * from action_logs where object='5056' and module='MEMBERS'; +-----------+---------------------+------+---------+--------+--------+--------------------------------+ | action_id | timestamp | user | module | action | object | info | +-----------+---------------------+------+---------+--------+--------+--------------------------------+ | 1109625 | 2015-12-02 15:36:32 | 3805 | MEMBERS | CREATE | 5056 | | | 1109636 | 2015-12-02 15:58:28 | 3804 | MEMBERS | MODIFY | 5056 | UPDATE (executed w/ arg: 5056) | | 1109637 | 2015-12-02 16:02:50 | 3804 | MEMBERS | MODIFY | 5056 | UPDATE (executed w/ arg: 5056) | +-----------+---------------------+------+---------+--------+--------+--------------------------------+ The 'info' field simply tells me that patron 5056 was modified -- which doesn't give me any information that I couldn't glean from the 'object' and 'action' fields -- I really needed to know which fields in the borrower record were changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:19:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:19:07 +0000 Subject: [Koha-bugs] [Bug 15288] Staff error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:26:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:26:37 +0000 Subject: [Koha-bugs] [Bug 15292] Libris (Swedish national catalogue) item status service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 --- Comment #1 from Martin Persson --- Created attachment 45358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45358&action=edit Bug 15292 - Libris ILS-DI item status (service) This patch adds the GetLibrisAvailability method to the ILS-DI service module. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:27:06 +0000 Subject: [Koha-bugs] [Bug 15292] Libris (Swedish national catalogue) item status service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 --- Comment #2 from Martin Persson --- Created attachment 45359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45359&action=edit Bug 15292 - Libris ILS-DI item status (tests) This patch adds the GetLibrisAvailability tests. Sponsored-By: Halland County Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:27:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:27:30 +0000 Subject: [Koha-bugs] [Bug 15292] Libris (Swedish national catalogue) item status service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 --- Comment #3 from Martin Persson --- Created attachment 45360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45360&action=edit Bug 15292 - Libris ILS-DI item status (opac) This patch adds the GetLibrisAvailability method to the ILS-DI service endpoint in the OPAC. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:29:48 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:29:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:29:52 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45350|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 45361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45361&action=edit [PASSED QA] Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues There is already a syspref called "OverdueNoticeBcc" for sending Bcc copies of mails sent for overdues and other notices. This patch add a new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues alerts. Changed the wording of the system preference to: [Send|Don't send] blind copy (BCC) to logged in user when sending serial or acquisitions claims notices. Signed-off-by: Fr?d?ric Demians Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:32:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:32:37 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #60 from Kyle M Hall --- (In reply to Jonathan Druart from comment #58) > (In reply to Kyle M Hall from comment #24) > > Test Plan addition: > > There are several new module dependencies for this feature: > > HTML::HTMLDoc: Required for both LPR and CUPS printing if printing HTML > > Net::Printer: Required for LPR printing > > Printer: Required for CUPS printing > > Did you check how easy/difficult it is to package these 2 modules? > > They don't seem maintained anymore > Printer-0.98 17 Aug 2004 > HTML-HTMLDoc-0.11_01 03 Nov 2009 I have no experience packaging modules nor do I see any documentation on the Koha wiki. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:33:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:33:02 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45278|0 |1 is obsolete| | --- Comment #61 from Kyle M Hall --- Created attachment 45362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45362&action=edit Bug 8352 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:33:31 +0000 Subject: [Koha-bugs] [Bug 15292] Libris (Swedish national catalogue) item status service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:40:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:40:31 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #30 from Marc V?ron --- For the sake of better translatability (no string spltting by html tags), I propose to change koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt line 135: To report this problem, you can email the Koha Administrator. ... to something like: To report this problem, please contact the Koha Administrator: Email. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:43:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:43:18 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15288 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:43:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:43:18 +0000 Subject: [Koha-bugs] [Bug 15288] Staff error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:43:59 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 jvr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from jvr --- Patch applied on my test KOHA machine. Problem no longer exists... Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:45:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:45:05 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmc at esilibrary.com Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:47:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:47:25 +0000 Subject: [Koha-bugs] [Bug 15292] Libris (Swedish national catalogue) item status service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45358|0 |1 is obsolete| | --- Comment #4 from Martin Persson --- Created attachment 45363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45363&action=edit Bug 15292 - Libris ILS-DI item status (service) This patch adds the GetLibrisAvailability method to the ILS-DI service module. Updated version with whitespace fixes. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:50:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:50:00 +0000 Subject: [Koha-bugs] [Bug 15292] Libris (Swedish national catalogue) item status service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #5 from Martin Persson --- Setting to 'Needs Signoff' to get feedback. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:58:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:58:45 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:58:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 15:58:59 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:04:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:04:31 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:04:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:04:34 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45347|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 45364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45364&action=edit [PASSED QA] BUG 11602: [ENH] Fix localcover display Adds a css class of thumbnail to local covers. Don't show the 1px "No image found" image (since we'll ususally try another image provider) Signed-off-by: Hector Castro Box with "No cover image availabe" fixed when syspref OPACLocalCoverImages set to display Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:05:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:05:43 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:05:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:05:46 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #62 from Kyle M Hall --- Created attachment 45365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45365&action=edit Bug 8352 [QA Followup] - Notices for translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:06:54 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 --- Comment #4 from Katrin Fischer --- I see 2 sides on this: - It makes local covers behave more like the other cover services, showing the standard 'no-image'. (consistency) - It means a change to existing installations, but the newly showing image can be easily hidden with CSS... so not sure this should stop this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:08:27 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #63 from Katrin Fischer --- Kyle, can you verify that the dependencies both need packaging? Are there possible alternatives? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:09:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:09:29 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #64 from Katrin Fischer --- I am marking this blocked until we know more about the added dependencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:13:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:13:33 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:13:36 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 --- Comment #1 from Jonathan Druart --- Created attachment 45366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45366&action=edit Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] There was already 2 Koha::Branch[es] using Koha::Object[s] before. For this new rewrite, it seems preferable to start with good basis and name the new modules Koha::Library and Koha::Libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:13:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:13:55 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 --- Comment #2 from Jonathan Druart --- Created attachment 45367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45367&action=edit Bug 15294: Koha::Libraries - Rewrite the admin scripts This patch rewrites the admin/branches.pl script to use the new modules instead of C4::Branches. Test plan: 1/ Create libraries using all the fields available 2/ Create groups of libraries 3/ Assign 1+ libraries to some groups 4/ Delete libraries and groups of libraries You should not able to delete a library if items or patrons use it. You should not able to delete a group of libraries if there are still libraries using it. 5/ Update libraries and groups of libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:15:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:15:41 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:15:44 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 --- Comment #1 from Jonathan Druart --- Created attachment 45368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45368&action=edit Bug 15295: Koha::Libraries - Remove DelBranch and DelBranchCategory These 2 subroutines are not used anymore, there were only used from the admin script rewrote on bug 15294. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:15:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:15:46 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 --- Comment #2 from Jonathan Druart --- Created attachment 45369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45369&action=edit Bug 15295: Koha::Libraries - Remove CheckCategoryUnique This subroutine is not used anymore and was not really useful. The branchcategories table has a primary key defined on categorycode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:15:49 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 --- Comment #3 from Jonathan Druart --- Created attachment 45370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45370&action=edit Bug 15295: Koha::Libraries - Remove CheckBranchCategorycode This verification is now done in admin/branches.pl, no need for a special subroutine/method, it's 1 line only called once. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:15:55 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 --- Comment #5 from Jonathan Druart --- Created attachment 45372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45372&action=edit Bug 15295: Koha::Libraries - Remove GetBranchCategories Test plan 1/ enable OpacAddMastheadLibraryPulldown 2/ Defined a group of libraries as searchdomain and tick 'show in pull down' 3/ At the OPAC, go on the advanced search form, limit by the group of libraries you have just created. 4/ The group should be selected by default in the dropdown list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:15:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:15:52 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 --- Comment #4 from Jonathan Druart --- Created attachment 45371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45371&action=edit Bug 15295: Koha::Libraries - Remove GetBranchCategory This has been replaced with Koha::Libraries->find -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:15:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:15:58 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 --- Comment #6 from Jonathan Druart --- Created attachment 45373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45373&action=edit Bug 15295: Koha::Libraries - Remove GetCategoryTypes 'searchdomain' and 'properties' were hardcoded in this subroutine. Now there are in the admin script. Not a big deal, we could improve that later if someone wants to add a third values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:16:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:16:00 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 --- Comment #7 from Jonathan Druart --- Created attachment 45374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45374&action=edit Bug 15295: Koha::Libraries - Remove GetBranchesCount This is replaced with Koha::Libraries->search->count. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:16:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:16:03 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 --- Comment #8 from Jonathan Druart --- Created attachment 45375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45375&action=edit Bug 15295! Koha::Libraries - Remove ModBranchCategoryInfo This has been replaced with Koha::Library->update_categories and Koha::Library->add_to_categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:16:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:16:26 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45246|0 |1 is obsolete| | --- Comment #14 from Owen Leonard --- Created attachment 45376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45376&action=edit [SIGNED-OFF] Bug 10154: QA follow-up - Spelling and terminology - Changing capitalization: Any Patron category > Any patron category - Changing Collection code > Collection Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:16:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:16:29 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #65 from Katrin Fischer --- (In reply to Kyle M Hall from comment #60) > I have no experience packaging modules nor do I see any documentation on the > Koha wiki. http://wiki.koha-community.org/wiki/Building_Debian_Dependencies/Dependency_Guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:16:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:16:48 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15295 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:16:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:16:48 +0000 Subject: [Koha-bugs] [Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15294 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:18:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:18:34 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #5 from H?ctor Eduardo Castro Avalos --- (In reply to Vitor Fernandes from comment #4) > CSV fails. > Tab separated text fails. > Open Document spreadsheet it's fine. I'm working on it, I found some issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:18:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:18:47 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:18:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:18:51 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44882|0 |1 is obsolete| | Attachment #45376|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 45377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45377&action=edit [PASSED QA] Bug 10154 Add Call number in the filter of most circulated items This patch adds call number, collection code and shelving location to the filter. To test: It is of course a prerequisite to have items in the DB with the correct MARC fields and that they have been checked out etc. to get a valid result when testing. 1. Apply patch to koha synced to master. 2. Go to /cgi-bin/koha/reports/cat_issues_top.pl 3. Select filters, the new ones are Call number, Collection code and Shelving location 4. Hit submit. Expected result: The filters chosen will be printed under "Filtered on". A table with the result is shown. For manual verification here is some SQL to run: SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues` LEFT JOIN items USING(itemnumber) LEFT JOIN biblio USING(biblionumber) LEFT JOIN biblioitems USING(biblionumber) LEFT JOIN borrowers USING(borrowernumber) WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK DESC; Put in your valid values in the WHERE clause for the values in the single quotes ''. Sponsored-by: Halland county library Signed-off-by: Fr?d?ric Demians It works as described. Valid results, tested in various combinations. Follows the coding (awful) style of the original script, without introducing any regression. It would have been great to have callnumber interval, but anyway... Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:19:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:19:07 +0000 Subject: [Koha-bugs] [Bug 10154] Add collection, location, and callnumber filters to report for most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 --- Comment #16 from Katrin Fischer --- Created attachment 45378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45378&action=edit Bug 10154: QA follow-up - Spelling and terminology - Changing capitalization: Any Patron category > Any patron category - Changing Collection code > Collection Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:21:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:21:13 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #40 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #39) > (In reply to Jonathan Druart from comment #38) > > > So sorry, I was using testing! > > Indeed it's 3.27 on my Jessie box. > > And does it work? Are tests passing? If so, H?ctor could re-sign-off the > attached patch, which is supposed to fix test failings you pointed out. Yes, all tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:23:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:23:40 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:26:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:26:29 +0000 Subject: [Koha-bugs] [Bug 14994] Add RSS/Atom feed proxy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14994 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:37:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:37:30 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:40:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:40:47 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39098|0 |1 is obsolete| | --- Comment #6 from Martin Persson --- Created attachment 45379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45379&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 100 years from the current date. Default value selected is current date minus 15 years; this assumes that 15 years is a common age for new patrons. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The default selected date will be current date minus one. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The default selected date should be current year minus 15. - The year selection drop-down should show current year minus 100. Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:40:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:40:42 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:42:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:42:17 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #66 from Kyle M Hall --- (In reply to Katrin Fischer from comment #64) > I am marking this blocked until we know more about the added dependencies. Based on the documentation here: http://wiki.koha-community.org/wiki/Building_Debian_Dependencies/Dependency_Guidelines I ran "dh-make-perl --pkg-perl --build --cpan The::Module" for each of the new deps and it didn't generate any errors, so I think that means building the packages shouldn't be a problem! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:42:26 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:55:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 16:55:18 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #67 from Kyle M Hall --- Side note: this feature will also require the addition of the debian package htmldoc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 18:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 17:05:45 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45379|0 |1 is obsolete| | --- Comment #7 from Martin Persson --- Created attachment 45380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45380&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 18:07:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 17:07:53 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45380|0 |1 is obsolete| | --- Comment #8 from Martin Persson --- Created attachment 45381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45381&action=edit Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. Updated version with proper description and default value moved to a separate bug/commit. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 18:30:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 17:30:06 +0000 Subject: [Koha-bugs] [Bug 15297] New: OPAC Patron registration datepicker dropdown shows only 10 years Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15297 Bug ID: 15297 Summary: OPAC Patron registration datepicker dropdown shows only 10 years Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: xarragon at gmail.com QA Contact: testopia at bugs.koha-community.org Bug 12342 has a fix for the staff interface (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342) for date picker available range. This is the same fix but for the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 18:44:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 17:44:46 +0000 Subject: [Koha-bugs] [Bug 15297] Patron registration default date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15297 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored CC| |gmcharlt at gmail.com Summary|OPAC Patron registration |Patron registration default |datepicker dropdown shows |date |only 10 years | Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|OPAC |Staff Client --- Comment #1 from Martin Persson --- This was originally part of bug 12342 but was moved out to a separate feature. When new patrons are added the default selected date is the current date minus one day. I assume we do not register people on the day that they are born. This patch changes the default to -15 years, assuming the average patron entry age is around that age. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 18:56:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 17:56:25 +0000 Subject: [Koha-bugs] [Bug 15298] New: z39.50 admin setup, options column suggested changes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Bug ID: 15298 Summary: z39.50 admin setup, options column suggested changes Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl On the z39.50 server admin page (cgi-bin/koha/admin/z3950servers.pl), the options column has three links lumped together for edit, copy, delete. Could those options be restyled to match the actions menu on the saved reports page? cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 19:01:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 18:01:20 +0000 Subject: [Koha-bugs] [Bug 15299] New: Add delete confirmation for deleting saved reports Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Bug ID: 15299 Summary: Add delete confirmation for deleting saved reports Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org In pretty much all areas of Koha, if you delete something (item, patron, setting, authorised values, etc.) you must confirm the deletion. When you delete a saved report, the report just deletes. Could a confirmation message be added, before the deletion happens? 1. Go to Saved Reports. 2. Create a new report and save it. 3. Go back to Saved Reports and find the report you just created . 4. Click on the Actions menu for that report, and choose Delete. 5. Note that the report deletes without a confirmation message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 19:08:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 18:08:28 +0000 Subject: [Koha-bugs] [Bug 15300] New: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300 Bug ID: 15300 Summary: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr "From" and "To" in members-update.tt are ambiguous and can not be properly translated.(See Bug 15275). Replace them with to make them unambiguous: Field Old value New value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 19:09:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 18:09:50 +0000 Subject: [Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15275 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 19:09:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 18:09:50 +0000 Subject: [Koha-bugs] [Bug 15275] "To" has multiple meanings, making it impossible to translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15300 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 19:21:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 18:21:44 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 19:21:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 18:21:52 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44562|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 45382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45382&action=edit [PASSED QA] Bug 12544 - Send scheduled reports as an attachment This patch adds the ability to add the report as an attached file to the sent email. Test Plan: 1) Email yourself a test report 2) Apply this patch 3) Repeat step 1, note there is no difference 4) Add the -a parameter, note your also recieve the report as an attachment Sponsored-by: Briar Cliff University Signed-off-by: Kyle M Hall Signed-off-by: Julius Fleschner Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 19:24:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 18:24:41 +0000 Subject: [Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300 --- Comment #1 from Marc V?ron --- Created attachment 45383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45383&action=edit Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt This patch replaces semantically ambigous words "From" and "To" in koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt for better translatability. To test: - Apply patch - Make sure that patrons can request detail changes in OPAC (sysprefs opacuserlogin, OPACPatronDetails) - Log in to OPAC, request a change of personal details (cgi-bin/koha/opac-memberentry.pl) - Log in to staff client - Click link 'Patrons requesting modifications' or go to Home > Patrons > Update patron records - Verify that table headers make sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 19:25:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 18:25:36 +0000 Subject: [Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:18:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 19:18:01 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 45384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45384&action=edit Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:23:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 19:23:37 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45384|0 |1 is obsolete| | --- Comment #7 from H?ctor Eduardo Castro Avalos --- Created attachment 45385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45385&action=edit Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -Save in Comma separated text, Tab seprated text, and Open Document. -Verify in the three options the file exported is Ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 19:35:00 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45320|0 |1 is obsolete| | --- Comment #41 from H?ctor Eduardo Castro Avalos --- Created attachment 45386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45386&action=edit [SIGNED-OFF]Bug 14939: Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI::Server namespace. UT begining. Add new dependency: Capture::Tiny Signed-off-by: Hector Castro OAI server moduralized succefully. Works for Debian Jessie and Wheezy. Test pass successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 19:35:17 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:40:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 19:40:51 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Ian Palko changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library at stas.org --- Comment #2 from Ian Palko --- In trying to set up a test server with Plack (on Ubuntu 15.10 given that 14.04 doesn't have Apache 2.4.10), koha is uninstallable. The package apache2-mpm-itk, has been removed. Yes, Debian may still work for the next year or more, but without a fix Koha will be broken on the next Ubuntu LTS (16.04) this April. Not supporting Ubuntu would certainly be a serious problem. Perhaps this might suggest an expedited fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:44:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 19:44:41 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:44:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 19:44:44 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #72 from Owen Leonard --- Created attachment 45387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45387&action=edit Bug 12395: QA follow-up - Use Bootstrap modal instead of Greybox - Using Bootstrap modals reduces unnecessary dependencies and allows for more consistent styling (contents of the modal are styled by the current page's CSS). - Using standard
      +
        markup for showorder.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 19:48:27 +0000 Subject: [Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45383|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45388&action=edit [SIGNED-OFF]Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt This patch replaces semantically ambigous words "From" and "To" in koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt for better translatability. To test: - Apply patch - Make sure that patrons can request detail changes in OPAC (sysprefs opacuserlogin, OPACPatronDetails) - Log in to OPAC, request a change of personal details (cgi-bin/koha/opac-memberentry.pl) - Log in to staff client - Click link 'Patrons requesting modifications' or go to Home > Patrons > Update patron records - Verify that table headers make sense Signed-off-by: Hector Castro Rewording Ok for translation purpose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:48:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 19:48:41 +0000 Subject: [Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 21:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 20:33:11 +0000 Subject: [Koha-bugs] [Bug 15288] Staff error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |In Discussion --- Comment #6 from H?ctor Eduardo Castro Avalos --- Why you leave 405.tt even though you don't touch 405.pl? >
      1. To report a broken link or any other issue, please contact the Koha >Administrator Email
        2. I think (IMHO) that you can change "Email" for "Email the administrator" or something like that. Another thing is that the OPAC has the same error pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 21:56:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 20:56:27 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #31 from Francois Charbonnier --- (In reply to Jonathan Druart from comment #28) > > > ::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql > > > @@ +1,3 @@ > > > > +INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES > > > > +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo') > > > > +; > > > > > > It would be better to set the value of the other pref, to avoid any > > > confusion. > > > > EnhancedMessagingPreference is already setup by updatedatabase so I don't > > think this should be change by the atomicupdate here. Moreover, we don't > > want to change the current setting when the library will run this update. > > OPACEnhancedMessagingPreferences is added (for existing install, so in > updatedatabase.pl) and enabled. > It does not hurt if EnhancedMessagingPreference is disabled, because in the > code both are checked. > But it would be better to enable OPACEnhancedMessagingPreferences only if > EnhancedMessagingPreference is enabled too. > It will avoid to have > "OPACEnhancedMessagingPreference is enabled but not really because > EnhancedMessagingPreference is not" on the admin pref page. I agree. We will change the atomic update to enable the OPACEnhancedMessagingPreferences only if EnhancedMessagingPreference is enable as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:05:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:05:31 +0000 Subject: [Koha-bugs] [Bug 15301] New: Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Bug ID: 15301 Summary: Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two ambiguous words 'to' and a sentence splitted up by html tags, leading to weird translations. Example in German: "Sie k?nnen keine Exemplare aus itemtype transferieren BK f?r: Airfield" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:06:28 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45381|0 |1 is obsolete| | --- Comment #9 from H?ctor Eduardo Castro Avalos --- Created attachment 45389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45389&action=edit [SIGNED-OFF]Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:06:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:06:40 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:16:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:16:45 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45300|0 |1 is obsolete| | --- Comment #11 from Alex --- Created attachment 45390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45390&action=edit DBRev 3.23.00.000: 2016 Year of the Monkey Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) http://bugs.koha-community.org/show_bug.cgi?id=15252 Signed-off-by: Alex http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:20:25 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45301|0 |1 is obsolete| | Attachment #45390|0 |1 is obsolete| | --- Comment #12 from Alex --- Created attachment 45391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45391&action=edit DBRev 3.23.00.000: 2016 Year of the Monkey Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) http://bugs.koha-community.org/show_bug.cgi?id=15252 Signed-off-by: Alex http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) Signed-off-by: Alex 0002-Bug-15252-Patron-search-on-start-with-does-not-work-.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:21:28 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45302|0 |1 is obsolete| | Attachment #45391|0 |1 is obsolete| | --- Comment #13 from Alex --- Created attachment 45392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45392&action=edit DBRev 3.23.00.000: 2016 Year of the Monkey Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) http://bugs.koha-community.org/show_bug.cgi?id=15252 Signed-off-by: Alex http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) Signed-off-by: Alex 0002-Bug-15252-Patron-search-on-start-with-does-not-work-.patch Signed-off-by: Alex 0003-Bug-15252-correct-UT-searchtype-value-is-contain-and.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:22:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:22:20 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45303|0 |1 is obsolete| | Attachment #45392|0 |1 is obsolete| | --- Comment #14 from Alex --- Created attachment 45393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45393&action=edit DBRev 3.23.00.000: 2016 Year of the Monkey Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) http://bugs.koha-community.org/show_bug.cgi?id=15252 Signed-off-by: Alex http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) Signed-off-by: Alex 0002-Bug-15252-Patron-search-on-start-with-does-not-work-.patch Signed-off-by: Alex 0003-Bug-15252-correct-UT-searchtype-value-is-contain-and.patch Signed-off-by: Alex 0001-Bug-15252-Patron-search-on-start-with-does-not-work-.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:22:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:22:22 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:22:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:22:46 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 --- Comment #1 from Marc V?ron --- Created attachment 45394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45394&action=edit Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two ambiguous words 'to' and a sentence splitted up by html tags, leading to weird translations. Example in German: "Sie k?nnen keine Exemplare aus itemtype transferieren BK f?r: Airfield" To test: - Apply patch - Set up transfer policies for item types and collection codes in Home > Administration > Set library checkin and transfer policy Make sure that you have rules that deny and others that allow transfers - Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce' - Set 'BranchTransferLimitTypes' to 'item type' - Go to Home > Circulation > Transfers - Transfer an item that is allowed for item type - Verify that the table of transferred items displays information about Item type, Collection code and Destination - Transfer an item that is not allowed for the item type - Verify that the information about not allowing the transfer displays properly and is meaningfull - Set 'BranchTransferLimitTypes' to 'collection code' - Repeat the transfer steps above for allowed / not allowed collection code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:23:11 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45393|0 |1 is obsolete| | --- Comment #15 from Alex --- Created attachment 45395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45395&action=edit DBRev 3.23.00.000: 2016 Year of the Monkey Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) http://bugs.koha-community.org/show_bug.cgi?id=15252 Signed-off-by: Alex http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Alex (use "git reset HEAD^1 ..." to unstage) (use "git add ..." to include in what will be committed) Signed-off-by: Alex 0002-Bug-15252-Patron-search-on-start-with-does-not-work-.patch Signed-off-by: Alex 0003-Bug-15252-correct-UT-searchtype-value-is-contain-and.patch Signed-off-by: Alex 0001-Bug-15252-Patron-search-on-start-with-does-not-work-.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:24:23 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:25:14 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15275 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:25:14 +0000 Subject: [Koha-bugs] [Bug 15275] "To" has multiple meanings, making it impossible to translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15301 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:25:39 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:27:37 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Hi Alex, something is not quite right here - your squashed patch included one commit too many - the year of the monkey one. Please check, best would be to reattach the 4 original patches with your signed off line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:36:30 +0000 Subject: [Koha-bugs] [Bug 15275] "To" has multiple meanings, making it impossible to translate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15275 --- Comment #5 from Marc V?ron --- intranet-tmpl/prog/en/modules/circ/branchtransfers.tt meaning "transfer to this branch" -> Fixed in Bug 15301 (with some more streamlining) intranet-tmpl/prog/en/modules/members/members-update.tt meaning "field was changed to this value" -> Fixed in Bug 15300 The remaining files we found seem all to be related to date ranges and 'From[:]' and 'To[:]' can be translated as appropriate (e.g. in German as 'Von' / 'Bis'): intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt intranet-tmpl/prog/en/modules/reports/issues_stats.tt intranet-tmpl/prog/en/modules/reports/reserves_stats.tt intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt koha-tmpl/intranet-tmpl/prog/en/modules/reports/bor_issues_top.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:39:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 21:39:06 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #32 from Francois Charbonnier --- (In reply to Jonathan Druart from comment #28) > (In reply to Francois Charbonnier from comment #27) > > > Why don't you want the patrons to show the type of messages they receive? > > > I could understand not to let the patrons change the settings, but I don't > > > see the point to hide them completely. > > > > By hiding them, you avoid the question : "Why can't I change my settings by > > myself?" ;^) > > But can answer the question "Why am I receiving email for that?" > We can imagine a quick sentence "Contact your library if you want to change > them" I like Frederic's option but we will not do it. :^) If anyone want his third option, I'll suggest to open a new ticket for the enhancement. My thoughts on this are : this patch does not change the current behaviour if not activated. For libraries who can see how useful it is (like the one who sponsored it, use it for more than a year now and hasn't got any complaint so far), it's there. For libraries who doesn't see it, they just don't activate it. Everybody's happy! :^) In the end, I'll just take the opportunity to say that I know how developers don't like new system preferences (I understand their points) but us, librarians, do like them a lot. They allow us to be even more in control of our ILS which I think is fantastic. We can all agree Koha is all about empowering librarians with new features, right? But, the difficulty is to find the better way do it. I think we should always see it as a step by step process. This patch is the first step for a better courtesy notices management. Once this patch is pushed, it will benefit the libraries who see its usefullness and change nothing for libraries who can't see it. AND it will let anybody who want to enhanced it to go further. So please, lets not abandoned this patch in the small enhancement patches limbo of bugzilla because we want to move two steps at a time. Let's do it step by step! Thanks!!! :^) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 23:05:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 22:05:13 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #169 from Chris Cormack --- test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 23:09:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 22:09:12 +0000 Subject: [Koha-bugs] [Bug 15302] New: Use of LIMIT in reports breaks pagination Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15302 Bug ID: 15302 Summary: Use of LIMIT in reports breaks pagination Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When creating a SQL report if you add a LIMIT ### statement the results are correctly returned, however, pagination links at the top of the page alter only the starting point of results and all results are displayed on one page. To clarify: Create a report with over 100 results and specify LIMIT 100 You will see the first 100 results for the report on the first page with link to 5 pages at the top Clicking on page 2 will take you to a new page displaying results 21-100 on a single page Note: Many libraries use limit to specifically make all results appear on one page. Suggested resolution would be to remove pagination when LIMIT is present in report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 23:49:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 22:49:00 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #42 from David Cook --- (In reply to Fr?d?ric Demians from comment #39) > It remains that HTTP::OAI v4 is a time bomb... Indeed it does. I would hope that it wouldn't get into the next stable release of Debian... that they'd notice it fails in Debian Testing and thus continue with the existing stable version, but you never know... Ubuntu 15.10 Wily was released in October, and it has 4.x, so there is a popular Debian-based OS there with a bad HTTP::OAI package it seems http://packages.ubuntu.com/wily/libhttp-oai-perl. I haven't tested it though as I don't have a Ubuntu 15.10 install at hand... (Interesting that Robin Sheat is listed as a maintainer... also listed as a maintainer at https://packages.debian.org/source/jessie/libhttp-oai-perl although he's no longer involved with Koha...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 23:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 22:51:09 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #43 from David Cook --- (In reply to Fr?d?ric Demians from comment #37) > But no response yet. We may give a phone call to Tim Brody... That would be great. I'd love to know if he's still maintaining the project, or if he's open to someone taking it over. Not that I'm necessarily volunteering but it would be good to know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 00:11:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 23:11:17 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #55 from David Cook --- (In reply to Leif Andersson from comment #54) > > What's Stockholm UL? > > Stockholm University Library > I had a feeling, but I thought you were at the national library, so I was just a bit confused. > > So you're saying that the union catalogue will only have updates about once > > every 10 minutes? Or that the cataloguer will only be accessing a record in > > the union catalogue and Koha once every 10 minutes? > > > > As a rough estimate the cataloger will access a record every 10 minutes. > In terms of updates, are we aiming at providing very up-to-date records for just cataloguers or both cataloguers and OPAC users? > > What do you mean by "work locally on a record"? The union catalog will be > > the source of truth, so any modifications to a record in Koha would be > > overwritten by a change in the union catalogue. > > Sorry for being unclear. I ment item data: barcode, item type... Interesting... I've been wondering about that. While I think we can create Koha item records from MFHD records, I'm not sure how we'd update Koha item records from MFHD records, especially if the MFHD records don't have barcodes. The model I'm working with right now is that the local record is replaced by the incoming OAI-PMH record... which would eliminate any local changes (including barcode, item type, etc). Trying to automatically merge an incoming MFHD record with a local Koha item record might work but it could be error prone. Also, without a unique identifier like a barcode, you can't match incoming MFHD records to Koha item records (which weren't originally imported via OAI-PMH). Leif: Can you explain more about how you envision the OAI harvester working with MFHD records and Koha items? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 00:24:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 23:24:28 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #33 from David Cook --- No idea where this is at now (even after reading most of the comments), but it's exciting nonetheless! I usually hide these using jQuery, which isn't really the best solution, so it would be great to have a system preference for this... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 00:36:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 23:36:09 +0000 Subject: [Koha-bugs] [Bug 15292] Libris (Swedish national catalogue) item status service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- I don't know what others think, but it seems inappropriate to add GetLibrisAvailability as a ILS-DI function, since ILS-DI is an API with a pre-existing specification to which "GetLibrisAvailability" does not belong: https://old.diglib.org/architectures/ilsdi/DLF_ILS_Discovery_1.1.pdf I'm not an expert on ILS-DI, but that's my understanding. I would suggest adding a service in the "svc/" directory instead as that doesn't depend on any standards. Also, is there a reason why you use Zebra/Z39.50 instead of just checking the database directly? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 00:37:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 23:37:14 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff error pages: Code |Error pages: Code |duplication removal and |duplication removal and |better translatability |better translatability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 00:37:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 23:37:52 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #7 from Marc V?ron --- Created attachment 45396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45396&action=edit Bug 15288: Error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by only one template for staff and only one template for OPAC. Additionally it removes a translatability issues due to sentence splitings by html tags. To test: - Apply patch - Trigger 404 error for staff and for OPAC by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt and koha-tmpl/intranet-tmpl/prog/en/modules/errorpage.tt (Amended to fix a typo) (Amended for comment #6) (Amended to cover OPAC error pages as well) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 00:38:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 23:38:26 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45357|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 00:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 23:38:41 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 00:46:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 23:46:08 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #34 from Marc V?ron --- (In reply to Francois Charbonnier from comment #32) (...) > So please, lets not abandoned this patch in the small enhancement patches > limbo of bugzilla because we want to move two steps at a time. Let's do it > step by step! Step by step ++ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 00:52:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2015 23:52:47 +0000 Subject: [Koha-bugs] [Bug 15303] New: Letsencrypt option for Debian package installations Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Bug ID: 15303 Summary: Letsencrypt option for Debian package installations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Koha Debian packages should have an option to automatically generate a letsencrypt certificate, validate it and use it in Apache. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:07:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:07:42 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:14:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:14:18 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #1 from Mirko Tietgen --- Created attachment 45397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45397&action=edit Bug 15303 Letsencrypt option for Debian package installations Apache file for https only setups with automatic certificate generation via letsencrypt. We need a workiung web server for the letsencrypt magic, but we can't start on 443 without certs. So we start on 80, get the certs, switch to 443 and restart apache. 80 gets forwarded to https. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:28:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:28:02 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:28:05 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 --- Comment #2 from Katrin Fischer --- Created attachment 45398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45398&action=edit Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:35:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:35:49 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #2 from Mirko Tietgen --- Created attachment 45399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45399&action=edit Bug 15303 --force-https option for koha-create koha-create --force-https - generates letsencrypt certificates - sets up a https-only website - redirects 80 to https (not yet) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:40:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:40:27 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:42:01 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45397|0 |1 is obsolete| | Attachment #45399|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 45400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45400&action=edit Bug 15303 Letsencrypt option for Debian package installations Apache file for https only setups with automatic certificate generation via letsencrypt. We need a workiung web server for the letsencrypt magic, but we can't start on 443 without certs. So we start on 80, get the certs, switch to 443 and restart apache. 80 gets forwarded to https. New option koha-create --force-https - generates letsencrypt certificates - sets up a https-only website - redirects 80 to https (not yet) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:50:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:50:59 +0000 Subject: [Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Updating currency exchange |Add separate permission for |rates should not require |managing currencies and |'parameters' permission |exchange rates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:51:47 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Attachment #45300|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:52:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:52:10 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45301|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:52:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:52:15 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45302|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:52:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:52:22 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #56 from David Cook --- Just realized that I forgot to respond to this comment... (In reply to Leif Andersson from comment #49) > (In reply to David Cook from comment #47) > > Leif and Andreas: > > > > If I understand correctly, your main use case for matching would be to make > > sure that records previously imported from the union catalogue aren't > > duplicated when you start using OAI-PMH, yes? > > > > In that case, would matching on the 001 be suitable? > > > > If we are only importing from one source, 001 would be fine. > But if we will be using several sources for our imports, then relying on 001 > would sooner or later result in a "false matcning" where we end up having > one record overwritten by a totally different one. > Agreed. I think that would be a very real risk. > How reliable would it be to add in 003? > In MARC21 003 is the alphanumeric "MARC code for the organization whose > control number is contained in field 001". > I don't know how this fits UNIMARC, though. > It should be trivial to merge the 001 and 003 together to form a 035 like "(OCoLC)814782" (http://www.loc.gov/marc/bibliographic/bd035.html). That would certainly help eliminate that risk of "false matching" mentioned above. However, in the LIBRIS data that I've seen, I haven't seen any examples of a 003. I'm not sure how this fits UNIMARC either. Hopefully some of the French people lurking on this bug can provide some insight there. > David suggested in a mail (to Koha devel list) to move field 001 to 035. > Or even 001 + 003 to 035 > In doing so some refinements could be done to this matching point (e.g. > normalization, if 003 is empty then add what we know about the exporting > catalog etc) Hmm, yeah, that would probably be achievable. However, that wouldn't really help too much, because your local Koha records will be missing that 003/additional exporting catalog information. So the matching will still fail. In terms of your local Koha catalogue, you could add a 003 to all records before starting to use the OAI-PMH harvester. Then either update records in LIBRIS to have a 003 as well, OR have the harvester inject a 003 into incoming records which will match the 003 in your local Koha catalogue. That's probably the way to go... Actually, let me think about that for a second... What do your existing Koha records have for 001 and 003? If they've been previously imported from LIBRIS, do they have the LIBRIS 001 in the Koha 001 field? -- In terms of matching, we basically need to make sure that incoming data can map/match to existing data. If Koha records have 001 but no 003, then we have to be able to match using just the 001 from the incoming record. If Koha records have 001 and 003, then we need to match the 001 and 003 of the incoming record against those... Failing that, we need to match a 035 on the incoming record with a 035 on an existing Koha record. I imagine that none of the records have a 035 field. Perhaps it would be worthwhile to create one of those as well as I described above... that would probably be best (at least for bibliographic records and authority records). As I noted in my other comment, matching item records is going to be tricky, as we won't have the 035 mechanism available, unless we cheat a bit and put it in the 952$i (inventory number) or something like that... -- I admit that I'm starting to think a bit about how to add support for MARC holdings into Koha. While long-term we do want to get rid of MARC, I wonder if it could be useful having a "holdings" database in Zebra as well. In terms of library systems, I imagine there will always be a separation of abstract entities and print/digital holdings. Right now, we're really limited using the 952 field for items in Koha... but we do it that way instead of supporting MFHD because there was no other way of searching Zebra using both "bibliographic" and "holdings" data at the same time if that data was in separate records. I suppose that brings me back to the idea that Koha should really have an intermediary extensible metadata format which is indexed. MARC bibliographic and MARC holdings records could be held separately and then processed into a single intermediary record which is indexed and used for search. Display... we could either use the intermediary record or use the internal system numbers to fetch the original MARC metadata for display. Of course, that would require a significant and separate development effort to achieve... Plus... even if we could match a MARC holdings record to a MARC holdings record... each holdings record can have X items specified within it... so you still need a unique identifier at the item-level in order to do full matching. -- An added problem with using OAI-PMH and items is that items can be on loan or otherwise in a "process" which cannot be affected by changes upstream at the OAI-PMH server. Actually, now that I think about it, there is so much data stored in the 952 item record that cannot be overwritten by an upstream change... What is the ideal scenario for harvesting MFHD records via OAI-PMH? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:52:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:52:23 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45303|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:52:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:52:31 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:57:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:57:49 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45300|0 |1 is obsolete| | --- Comment #17 from Alex --- Created attachment 45401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45401&action=edit DBRev 3.23.00.000: 2016 Year of the Monkey Signed-off-by: Alex 0001-Bug-15252-Patron-search-on-start-with-does-not-work-.patch Signed-off-by: Alex 0001-Bug-15252-Patron-search-on-start-with-does-not-work-.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 01:58:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 00:58:10 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:00:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 01:00:54 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45400|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen --- Created attachment 45402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45402&action=edit Bug 15303 Letsencrypt option for Debian package installations Apache file for https only setups with automatic certificate generation via letsencrypt. We need a workiung web server for the letsencrypt magic, but we can't start on 443 without certs. So we start on 80, get the certs, switch to 443 and restart apache. 80 gets forwarded to https. New option koha-create --force-https - generates letsencrypt certificates - sets up a https-only website - redirects 80 to https (not yet) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:20:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 01:20:09 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45300|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:20:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 01:20:16 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45401|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 01:46:09 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45300|0 |1 is obsolete| | --- Comment #18 from Alex --- Created attachment 45403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45403&action=edit Bug 15252 - Patron search on start with does not work with several terms When searching a patron, search type can be 'start with' and 'contain'. If the search text contains a space (or a coma), this text is splitted into several terms. Actually, the search on 'start with' with several terms never returns a result. It is because the search composes an "AND" SQL query on terms. For example (I display only the surname part) : search type = contain : 'jean paul' => surname like '%jean% AND %paul%' search type = start with : 'jean paul' => surname like 'jean% AND paul%' The query for 'start with' is impossible. I propose, for search with start with, to not split terms : jean paul => surname like 'jean paul%' One can always use '*' to add more truncation : jea* pau* => surname like 'jea% pau%' This bug affects a lot surnames with several terms like 'LE GUELEC' or 'MAC BETH'. Note that the patch moves : $searchmember =~ s/,/ /g; It removes the test "if $searchmember" because $searchmember is tested and set to empty string previously : unless ( $searchmember ) { $searchmember = $dt_params->{sSearch} // ''; } Test plan : ========== - Create two patrons with firstname "Jean Paul" - Go to Patrons module - Choose "Starts with" in "Search type" filter - Perform a search on "Jean Paul" => without patch : you get no result => with this patch : you get the two results - Check you get the two results for search on "Jean Pau" - Check you get the two results for search on "Jea* Pau*" - Check you do not get results for search on "Jea Paul" - Choose "Contains" in "Search type" filter - Check you get the two results for search on "Jean Paul" - Check you get the two results for search on "Jean Pau" - Check you get the two results for search on "Jea* Pau*" - Check you get the two results for search on "Jea Paul" - Check you get the two results for search on "Paul Jean" Signed-off-by: Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 01:47:58 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45402|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen --- Created attachment 45404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45404&action=edit Bug 15303 Letsencrypt option for Debian package installations Apache file for https only setups with automatic certificate generation via letsencrypt. We need a workiung web server for the letsencrypt magic, but we can't start on 443 without certs. So we start on 80, get the certs, switch to 443 and restart apache. 80 gets forwarded to https. New option koha-create --force-https - generates letsencrypt certificates - sets up a https-only website - redirects 80 to https (not yet) Test plan: - build a debian package with all patches for bug 15303 applied - checkout letsencrypt on the vm where you are testing the package git clone https://github.com/letsencrypt/letsencrypt - install koha with your new package - use koha-create with the new options: sudo koha-create --create-db --force-https --letsencrypt /home/mirko/letsencrypt - wait until setup is finished, check that you got a working OPAC and staff client with certificates Todo - use letsencrypt default path in debian when we know where that is - enable redirect from port 80 to https in apache config -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:07:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 02:07:26 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #6 from Mirko Tietgen --- The server this is tested on has to be accessible on port 80 from the outside world. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:12:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 02:12:29 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45302|0 |1 is obsolete| | --- Comment #19 from Alex --- Created attachment 45405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45405&action=edit Bug 15252 - correct UT searchtype value is contain and not contains -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 02:19:58 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45303|0 |1 is obsolete| | --- Comment #20 from Alex --- Created attachment 45406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45406&action=edit DBRev 3.23.00.000: 2016 Year of the Monkey Signed-off-by: Alex 0004-Bug-15252-UT.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 02:22:12 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45303|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:22:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 02:22:21 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 04:06:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 03:06:16 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Alex changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45303|0 |1 is obsolete| | --- Comment #21 from Alex --- Created attachment 45407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45407&action=edit Bug 15252 - UT Signed-off-by: Alex 0004-Bug-15252-UT.patch Signed-off-by: Alex 0004-Bug-15252-UT.patch Signed-off-by: Alex 0004-Bug-15252-UT.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 06:51:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 05:51:31 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45404|0 |1 is obsolete| | --- Comment #7 from Mirko Tietgen --- Created attachment 45408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45408&action=edit Bug 15303 Letsencrypt option for Debian package installations Apache file for https only setups with automatic certificate generation via letsencrypt. We need a workiung web server for the letsencrypt magic, but we can't start on 443 without certs. So we start on 80, get the certs, switch to 443 and restart apache. 80 gets forwarded to https. New option koha-create --force-https - generates letsencrypt certificates - sets up a https-only website - redirects 80 to https (not yet) Test plan: - build a debian package with all patches for bug 15303 applied - checkout letsencrypt on the vm where you are testing the package git clone https://github.com/letsencrypt/letsencrypt - install koha with your new package - use koha-create with the new options: sudo koha-create --create-db --force-https --letsencrypt /home/mirko/letsencrypt - wait until setup is finished, check that you got a working OPAC and staff client with certificates Todo - use letsencrypt default path in debian when we know where that is - enable redirect from port 80 to https in apache config -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 07:17:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 06:17:38 +0000 Subject: [Koha-bugs] [Bug 15304] New: Norwegian patron database: translatable strings added to all po files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Bug ID: 15304 Summary: Norwegian patron database: translatable strings added to all po files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The strings in nl-search.tt are picked up for translation, but a lot of those are in Norwegian. The file should either be all in English, or excluded from translation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 07:25:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 06:25:24 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #35 from Fr?d?ric Demians --- (In reply to Francois Charbonnier from comment #32) > So please, lets not abandoned this patch in the small enhancement patches > limbo of bugzilla because we want to move two steps at a time. Let's do it > step by step! I agree. You have to strike while the iron is hot. I'd be pleased to re-sign-off this patch as soon as issue rightly raised by Jonathan will be addressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 07:53:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 06:53:51 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45408|0 |1 is obsolete| | --- Comment #8 from Mirko Tietgen --- Created attachment 45409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45409&action=edit Bug 15303 Letsencrypt option for Debian package installations Apache file for https only setups with automatic certificate generation via letsencrypt. We need a workiung web server for the letsencrypt magic, but we can't start on 443 without certs. So we start on 80, get the certs, switch to 443 and restart apache. 80 gets forwarded to https. New option koha-create --force-https - generates letsencrypt certificates - sets up a https-only website - redirects 80 to https (not yet) Test plan: - build a debian package with patch applied - checkout letsencrypt on the machine where you are testing the package git clone https://github.com/letsencrypt/letsencrypt - use apache mod_ssl sudo a2enmod ssl - make sure the machine is accessible on 80 (needed for letsencrypt) and 443 from the internet - install koha with your new package - use koha-create with the new options: sudo koha-create --create-db --force-https --letsencrypt /home/mirko/letsencrypt - wait until setup is finished, check that you got a working OPAC and staff client with certificates make sure to use https:// to open both sites Todo - use letsencrypt default path in debian when we know where that is - enable redirect from port 80 to https in apache config -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 07:54:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 06:54:51 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 07:57:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 06:57:07 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #9 from Mirko Tietgen --- > --letsencrypt /home/mirko/letsencrypt Use your own /path/to/letsencryptfolder instead ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 08:55:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 07:55:31 +0000 Subject: [Koha-bugs] [Bug 15305] New: KOHA SIP2 checkout doesn't update of the item holding status Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 Bug ID: 15305 Summary: KOHA SIP2 checkout doesn't update of the item holding status Change sponsored?: --- Product: Koha Version: 3.20 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: fridayjune at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Created attachment 45410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45410&action=edit KOHA_SIP2_Checkout I am using KOHA version 3.20 and I am able to check out the item, but the item status is always showing Available. 1) This is my checkout message: 11NN20151202 08062920151227 030629AOmylib|AAthida|ABB1246857|AC| 2) This is my institution policy in SIPconfig.xml. 3) The first item is checked out by using SIP2 in the following screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 09:10:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 08:10:42 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #57 from Viktor Sarge --- > It should be trivial to merge the 001 and 003 together to form a 035 like > "(OCoLC)814782" (http://www.loc.gov/marc/bibliographic/bd035.html). That > would certainly help eliminate that risk of "false matching" mentioned above. > > However, in the LIBRIS data that I've seen, I haven't seen any examples of a > 003. Interesting. I've actually perceived it the other way around - that Libris is actually quite good at sticking "SE-LIBR" into 003 of all their records. (A quick example http://libris.kb.se/bib/14862617?vw=full&tab3=marc) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 09:21:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 08:21:09 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #58 from Magnus Enger --- (In reply to Viktor Sarge from comment #57) > Interesting. I've actually perceived it the other way around - that Libris > is actually quite good at sticking "SE-LIBR" into 003 of all their records. > > (A quick example http://libris.kb.se/bib/14862617?vw=full&tab3=marc) A search for se-libr in Hylte gives 7538 hits: http://hylte.bibkat.se/cgi-bin/koha/opac-search.pl?q=se-libr The total number of records is 64397. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:04:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 11:04:08 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #54 from Julian Maurice --- Changed status to Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 11:21:39 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jcamins at cpbibliography.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:32:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 11:32:22 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:34:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 11:34:22 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmc at esilibrary.com, | |katrin.fischer at bsz-bw.de Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:35:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 11:35:22 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmc at esilibrary.com, | |katrin.fischer at bsz-bw.de Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:51:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 12:51:40 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #55 from Fr?d?ric Demians --- (In reply to Katrin Fischer from comment #53) > If I understand Tomas correctly it's still a problem for the packages, even > tho the dependencies are non-mandatory. In order to use the script: yes, otherwise: no. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:07:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 13:07:19 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #10 from Martin Persson --- I realized I should have changed the format string to "c-120:c", but since it is signed off.. well, hardly worth it. Doing it would allow us to drop the "maxDate" attribute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:32:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 13:32:55 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #10 from Mirko Tietgen --- I have a much cleaner Apache config using Define. But then it would not work with Apache 2.2 :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:59:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 13:59:27 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 13:59:31 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38432|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 45411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45411&action=edit Bug 9805 - Lost items are un-lost if returned, but not if renewed. If an item has a lost status, that status is removed when the item is returned. However, it is not removed if the item is renewed. Test Plan: 1) Check an item out to a patron, back date the due date 6 months 2) Run misc/cronjobs/longoverdue.pl -l 30=2 --confirm 3) Verify the item is now checked out but lost 4) Renew the item, verify the item is still lost 5) Apply this patch 6) Renew the item again, verify the item is no longer lost Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:59:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 13:59:45 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38433|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 45412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45412&action=edit Bug 9805 [QA Followup] - Control renewing and finding of list items via circ rules Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circ rules 4) Note the "Renew lost?" and "Renewal marks lost found" rules 5) Set and test each of the rules both ways for the rules for all libraries 6) Repeat but for a specific branch this time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:00:23 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45412|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 45413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45413&action=edit Bug 9805 [QA Followup] - Control renewing and finding of lost items via circ rules Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circ rules 4) Note the "Renew lost?" and "Renewal marks lost found" rules 5) Set and test each of the rules both ways for the rules for all libraries 6) Repeat but for a specific branch this time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:07:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:07:27 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #7 from Nicole C. Engard --- Yes, I agree, but I have another question. What does 'Koha can manage a MARC interface, and a Koha interface.' mean? What is a koha interface? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:12:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:12:14 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #8 from Marc V?ron --- I took the text as it was. I propose to remove the sentence "Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized."(In reply to Nicole C. Engard from comment #7) > Yes, I agree, but I have another question. What does 'Koha can manage a MARC > interface, and a Koha interface.' mean? What is a koha interface? > > Nicole I took the text as it was. What about removing the sentence the whole sentence? ("Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:15:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:15:19 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:19:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:19:14 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Passed QA |RESOLVED --- Comment #4 from Kyle M Hall --- It appears that this was already fixed as a small part of bug 14965. *** This bug has been marked as a duplicate of bug 14965 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:19:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:19:14 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Kyle M Hall --- *** Bug 15138 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:26:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:26:15 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Patch pushed to master. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:27:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:27:16 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45409|0 |1 is obsolete| | --- Comment #11 from Mirko Tietgen --- Created attachment 45414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45414&action=edit Bug 15303 Letsencrypt option for Debian package installations Apache file for https only setups with automatic certificate generation via letsencrypt. We need a workiung web server for the letsencrypt magic, but we can't start on 443 without certs. So we start on 80, get the certs, switch to 443 and restart apache. 80 gets forwarded to https. New option koha-create --force-https - generates letsencrypt certificates - sets up a https-only website - redirects 80 to https (not yet) New option --letsencrypt - sets the path where letsencrypt-auto lives - default value /usr/bin, but there is noch Debian package yet Test plan: - build a debian package with patch applied - checkout letsencrypt on the machine where you are testing the package git clone https://github.com/letsencrypt/letsencrypt - use apache mod_ssl sudo a2enmod ssl - make sure the machine is accessible on 80 (needed for letsencrypt) and 443 from the internet - install koha with your new package - use koha-create with the new options: sudo koha-create --create-db --force-https --letsencrypt /home/mirko/letsencrypt - wait until setup is finished, check that you got a working OPAC and staff client with certificates make sure to use https:// to open both sites - check that http redirects to https -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:31:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:31:56 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45414|0 |1 is obsolete| | --- Comment #12 from Mirko Tietgen --- Created attachment 45415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45415&action=edit Bug 15303 Letsencrypt option for Debian package installations Apache file for https only setups with automatic certificate generation via letsencrypt. We need a workiung web server for the letsencrypt magic, but we can't start on 443 without certs. So we start on 80, get the certs, switch to 443 and restart apache. 80 gets forwarded to https. New option koha-create --force-https - generates letsencrypt certificates - sets up a https-only website - redirects http to https New option --letsencrypt - sets the path where letsencrypt-auto lives - default value /usr/bin, but there is no Debian package yet Test plan: - build a debian package with patch applied - checkout letsencrypt on the machine where you are testing the package git clone https://github.com/letsencrypt/letsencrypt - use apache mod_ssl sudo a2enmod ssl - make sure the machine is accessible on 80 (needed for letsencrypt) and 443 from the internet - install koha with your new package - use koha-create with the new options: sudo koha-create --create-db --force-https --letsencrypt /home/mirko/letsencrypt - wait until setup is finished, check that you got a working OPAC and staff client with certificates make sure to use https:// to open both sites - check that http redirects to https -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:39:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:39:16 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #9 from Nicole C. Engard --- Makes perfect sense to me. Delete away! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:44:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:44:37 +0000 Subject: [Koha-bugs] [Bug 15306] New: Don't show translate link for item types if only one language is installed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Bug ID: 15306 Summary: Don't show translate link for item types if only one language is installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. I think the page should check for the existence of multiple installed languages before showing the link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:48:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:48:51 +0000 Subject: [Koha-bugs] [Bug 15307] New: Delete link doesn't appear for newly-added item type translations Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15307 Bug ID: 15307 Summary: Delete link doesn't appear for newly-added item type translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Immediately after adding an item type translation (Item types -> Translate into other languages) the new translation is added to the table but the last cell where the delete link usually appears is empty. That means that if you made a mistake you have to close the modal window, re-open it, delete the translation, and then re-enter it. It would be better if: 1. It was possible to edit (rather than only delete and re-add) translations. 2. It was possible to delete translations immediately after adding. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:49:58 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall --- Patches pushed to master. Thanks self! ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:55:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 14:55:49 +0000 Subject: [Koha-bugs] [Bug 15307] Delete link doesn't appear for newly-added item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15307 --- Comment #1 from Owen Leonard --- Oh, I see now that the table cell is editable directly. I could only tell because I was inspecting the source! How we indicate to the user that they can edit? Another issue: When I edit something I get an error message every time: "An error occurred when updating this translation," although my edits seem to be getting saved each time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:05:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 15:05:55 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #10 from Marc V?ron --- Created attachment 45416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45416&action=edit Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:07:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 15:07:54 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #11 from Marc V?ron --- I hope it's OK to switch back to "Signed-off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:17:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 15:17:05 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45416|0 |1 is obsolete| | --- Comment #12 from H?ctor Eduardo Castro Avalos --- Created attachment 45417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45417&action=edit [SIGNED-OFF]Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:20:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 15:20:33 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #11 from H?ctor Eduardo Castro Avalos --- (In reply to Martin Persson from comment #10) > I realized I should have changed the format string to "c-120:c", but since > it is signed off.. well, hardly worth it. Doing it would allow us to drop > the "maxDate" attribute. Hi Martin If you want to do another change in patch, do it, I will sign-off again. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:37:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 15:37:07 +0000 Subject: [Koha-bugs] [Bug 15308] New: Suggested new interface for item type translation process Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15308 Bug ID: 15308 Summary: Suggested new interface for item type translation process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Created attachment 45418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45418&action=edit Mockup of suggested changes I find the new item type translation interface confusing, so I have attached a screenshot showing an idea for how to change it. We've got two competing modes in the current interface: A typical form for adding new translations and a hidden inline editing system for existing translations. I think we can combine the two: - List all installed languages. - Put an "Add" in rows for languages which lack a translation. - Put an "Edit" link in rows for languages which have a translation. - Use "Delete" text of the delete link for clarity and consistency. The way I picture it, clicking the "Edit" link would move the focus to and highlight the existing text in such a way to suggest that it is editable (perhaps by imitating the style of a text input). Clicking the "Add" link would move the focus to the "Empty" cell and set the style of the cell in a way to suggest that it is editable. I would further suggest that while an add or edit is being performed, the corresponding add/edit link be replaced with a save button. Right now the user has to both guess that the text is editable and guess that the changes will be saved. This is a good opportunity to establish a good usable pattern for using contenteditable interactions so that they can be extended to more places in Koha. I would love to hear comments. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 15:48:23 +0000 Subject: [Koha-bugs] [Bug 15308] Suggested new interface for item type translation process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15308 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15307 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 15:48:23 +0000 Subject: [Koha-bugs] [Bug 15307] Delete link doesn't appear for newly-added item type translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15307 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15308 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 16:13:39 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Patch pushed to master. Thanks Nicholas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:18:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 16:18:59 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Patches pushed to master. Thanks Katrin and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:46:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 16:46:59 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #24 from Nicole C. Engard --- Can someone bring this back to the forefront, it's a big deal if we're anonymizing patron circ history because we lose the category. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 18:01:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 17:01:35 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace Greybox library |Replace usage of Greybox |with jQueryUI Dialog |modals with Bootstrap | |modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 18:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 17:04:18 +0000 Subject: [Koha-bugs] [Bug 15309] New: Use Bootstrap modal for cataloging search MARC and Card preview Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Bug ID: 15309 Summary: Use Bootstrap modal for cataloging search MARC and Card preview Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 8290 The "MARC" and "Card" links on the cataloging search results page should trigger previews in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 18:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 17:04:18 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15309 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 [Bug 15309] Use Bootstrap modal for cataloging search MARC and Card preview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 18:10:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 17:10:04 +0000 Subject: [Koha-bugs] [Bug 15310] New: Fix duplicate fines issue when changing date or time format Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Bug ID: 15310 Summary: Fix duplicate fines issue when changing date or time format Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Changing the sysprefs 'dateformat' and/or 'TimeFormat' on a production server with overdue items that are accruing fines can result in duplicate fines. It happens when the system has to decide wether to update an existing fine or to add a new fine. It is related to C4/Overdues.pm line 538 that parses the fines description for a date in the current syspref date format ($due_qr). if ($rec->{itemnumber} == $itemnum && $rec->{description} =~ /$due_qr/) If the dateformat is changed, parsing will not find the date in previous fines and an extra fine will be applied. It is not possible to automatically parse for all date formats since dd/mm/yyyy and mm/dd/yyyy can be ambiguous. The system needs an information about what the previous date format was (if it changed). To bridge the issue until we have a rewrite of the accounts system ready, the previous date- / and time format can be indicated in additional sysprefs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 18:32:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 17:32:19 +0000 Subject: [Koha-bugs] [Bug 15310] Fix duplicate fines issue when changing date or time format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hm, not sure about the system prefernece idea - what if someone changes it multiple times? forgets to keep track of the changes? It would also need the date it was changed etc. It's tricky. Could we do a global switch to the db date format and fix it for display maybe? I think a big warning and a script to fix the entries in the accountlines table to the new dateformat would be ok for me until we can move the date totally out of the description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:08:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:08:13 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after logout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #36 from Galen Charlton --- Noting/requesting that as this patch fixes a patron privacy bug, it would be good it for it to be backported. It cherry-picks cleanly onto 3.20.x and with only a minor merge conflict onto 3.18.x. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:18:35 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after logout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr, | |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:26:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:26:57 +0000 Subject: [Koha-bugs] [Bug 15311] New: Let libraries set text to display when OpacMaintenance = on Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Bug ID: 15311 Summary: Let libraries set text to display when OpacMaintenance = on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org Setting OpacMaintenance = on displays a standard message in the OPAC. It would be easy to add another syspref that could take arbitrary text to be displayed as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:29:05 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15310 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:29:05 +0000 Subject: [Koha-bugs] [Bug 15310] Fix duplicate fines issue when changing date or time format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15076 --- Comment #2 from Marc V?ron --- Thanks for the comment, Katrin. You are right, it is very tricky and errorprone to fix the issue. We have the script fix_accountlines_date.pl. However, the current version handles only 'us' and 'metric' as previous date formats. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:31:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:31:20 +0000 Subject: [Koha-bugs] [Bug 15310] Fix duplicate fines issue when changing date or time format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 --- Comment #3 from Katrin Fischer --- I think it might be worth fixing the script - what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:31:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:31:49 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after logout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #37 from Fr?d?ric Demians --- (In reply to Galen Charlton from comment #36) > Noting/requesting that as this patch fixes a patron privacy bug, it would be > good it for it to be backported. It cherry-picks cleanly onto 3.20.x and > with only a minor merge conflict onto 3.18.x. What is the right process for this? Do I have to wait that 3.22 RMaint pushes this patch to its branch for pushing it to 3.20, or do I have to pick it up directly from master? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:37:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:37:17 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after logout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #38 from Katrin Fischer --- Hi Frederic, these patches are already in 3.22. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:40:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:40:12 +0000 Subject: [Koha-bugs] [Bug 15312] New: Make fix_accountlines_date.pl handle all date formats Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15312 Bug ID: 15312 Summary: Make fix_accountlines_date.pl handle all date formats Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Changing the sysprefs 'dateformat' and/or 'TimeFormat' on a production server with overdue items that is accruing fines can result in duplicate fines. Reason: The date is stored in syspref format in the table accountlines, description field and parsed is from there. Until we have a rewrite of the accounts system ready, the script fix_accountlines_date.pl can be used to parse and change the date format. However it handles only 'us' and 'metric' as previous date formats. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:40:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:40:50 +0000 Subject: [Koha-bugs] [Bug 15312] Make fix_accountlines_date.pl handle all date formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15312 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15310 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:40:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:40:50 +0000 Subject: [Koha-bugs] [Bug 15310] Fix duplicate fines issue when changing date or time format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15312 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:42:00 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15312 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:42:00 +0000 Subject: [Koha-bugs] [Bug 15312] Make fix_accountlines_date.pl handle all date formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15312 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15076 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:42:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:42:52 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:45:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:45:33 +0000 Subject: [Koha-bugs] [Bug 13104] Changing date or time format on a production server will create duplicate fines! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15312 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:45:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 18:45:33 +0000 Subject: [Koha-bugs] [Bug 15312] Make fix_accountlines_date.pl handle all date formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15312 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13104 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:07:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:07:02 +0000 Subject: [Koha-bugs] [Bug 15309] Use Bootstrap modal for cataloging search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:07:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:07:23 +0000 Subject: [Koha-bugs] [Bug 15309] Use Bootstrap modal for cataloging search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:07:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:07:25 +0000 Subject: [Koha-bugs] [Bug 15309] Use Bootstrap modal for cataloging search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 --- Comment #1 from Owen Leonard --- Created attachment 45419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45419&action=edit Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 4. Perform a search which will return results from the reservoir. 5. Test the corresonding "MARC" and "Card" links for those results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:16:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:16:32 +0000 Subject: [Koha-bugs] [Bug 15312] Make fix_accountlines_date.pl handle all date formats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15312 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #1 from Marc V?ron --- ...and it does not touch the time format at all. Changing the time format can result in duplicate fines as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:22:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:22:04 +0000 Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:22:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:22:06 +0000 Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38809|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 45420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45420&action=edit Bug 14134 - Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set If ExpireReservesMaxPickUpDelay is enabled, the "holds over" tab becomes useless. It would be nice if the "holds over" tab would display *tomorrow's* "holds over" so the librarian can see what will be automatically canceled over night. Test Plan: 1) Apply this patch 2) Enable ExpireReservesMaxPickUpDelay 3) Note the "holds over" list now displays holds that will have been waiting more than the number of days defined in ReservesMaxPickUpDelay as of tomorrow. Signed-off-by: Jason Burds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:24:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:24:58 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after logout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #39 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:25:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:25:21 +0000 Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:25:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:25:24 +0000 Subject: [Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38815|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 45421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45421&action=edit Bug 14137 - Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay Some libraries would like to be able to use ExpireReservesMaxPickUpDelayCharge without ExpireReservesMaxPickUpDelay. ExpireReservesMaxPickUpDelay automatically cancels the holds but some librarians would prefer to cancel the holds manually but still have the patron's charged the fee for allowing a waiting hold to become expired and canceled. Test Plan: 1) Apply this patch 2) Set a fee amount in ExpireReservesMaxPickUpDelayCharge 3) Cancel a hold from the "holds over" tab 4) View the patron record, note the fee has been added Signed-off-by: Jason Burds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:27:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:27:04 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45396|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 45422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45422&action=edit Bug 15288: Error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by only one template for staff and only one template for OPAC. Additionally it removes a translatability issues due to sentence splitings by html tags. To test: - Apply patch - Trigger 404 error for staff and for OPAC by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt and koha-tmpl/intranet-tmpl/prog/en/modules/errorpage.tt (Amended to fix a typo) (Amended for comment #6) (Amended to cover OPAC error pages as well) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:31:30 +0000 Subject: [Koha-bugs] [Bug 15313] New: Use Bootstrap modal for z39.50 search MARC and Card preview Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Bug ID: 15313 Summary: Use Bootstrap modal for z39.50 search MARC and Card preview Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/z3950_search.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 8290 When performing a Z39.50 search in cataloging, the "MARC" and "Card" links should trigger previews in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:31:30 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15313 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:41:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:41:58 +0000 Subject: [Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- Sorry about that! I guess we are talking about strings like "hjemmebibliotek", "opprettet" and "opprettet_av" from lines like these: [% IF ( p.hjemmebibliotek ) %]
      2. hjemmebibliotek: [% p.hjemmebibliotek | html_entity %]
        3. [% END %] [% IF ( p.opprettet ) %]
      3. opprettet: [% p.opprettet | html_entity %]
        4. [% END %] [% IF ( p.opprettet_av ) %]
      4. opprettet_av: [% p.opprettet_av | html_entity %]
        5. [% END %] The trouble is, those Norwegian strings just echo the field names that we get from the Natonal patron database API. (The XML elements have Norwegian names.) So on the one hand translating those field names does not make a lot of sense, but on the other hand we need to be able to translate the page as such, especially when the day comes that someone revives the "nynorsk" translation. So... The ideal would be to be able to exclude just those strings from tranlsation. Since that is not possible, I guess I better translate them into English and make sure I translate them the right way back again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:48:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:48:41 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #13 from Mirko Tietgen --- Looks like i broke it with the last update. Fix coming soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:51:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:51:04 +0000 Subject: [Koha-bugs] [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:51:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 19:51:06 +0000 Subject: [Koha-bugs] [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 --- Comment #1 from Owen Leonard --- Created attachment 45423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45423&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 21:13:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 20:13:41 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #9 from Marc V?ron --- Created attachment 45424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45424&action=edit Bug 15288: (followup) Remove obsolete *.tt files Follwoing files were not yet deleted: koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/400.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/401.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/402.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/403.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/500.tt Note: the 404.tt file was renamed to errorpage.tt To test: Verify that files are deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 22:01:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 21:01:18 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Hi Hector, I could reproduce the blank screen issue and it is resolved with your patch. Regarding the bad utf8 encoding (#4 in test plan), can you give a hint on what is wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 22:20:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 21:20:44 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45422|0 |1 is obsolete| | --- Comment #10 from H?ctor Eduardo Castro Avalos --- Created attachment 45425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45425&action=edit [SIGNED-OFF]Bug 15288: Error pages: Code duplication removal and better translatability This patch changes the 400, 401, 402, 403, 404, 500 error pages to be handled by only one template for staff and only one template for OPAC. Additionally it removes a translatability issues due to sentence splitings by html tags. To test: - Apply patch - Trigger 404 error for staff and for OPAC by calling a page that does not exist - Try to trigger other error pages and/or carefully review code changes in the *.pl files - Review koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/errorpage.tt and koha-tmpl/intranet-tmpl/prog/en/modules/errorpage.tt (Amended to fix a typo) (Amended for comment #6) (Amended to cover OPAC error pages as well) Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 22:20:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 21:20:54 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45424|0 |1 is obsolete| | --- Comment #11 from H?ctor Eduardo Castro Avalos --- Created attachment 45426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45426&action=edit [SIGNED-OFF]Bug 15288: (followup) Remove obsolete *.tt files Follwoing files were not yet deleted: koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/400.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/401.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/402.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/403.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/errors/500.tt Note: the 404.tt file was renamed to errorpage.tt To test: Verify that files are deleted. Signed-off-by: Hector Castro Files removed, new errorpage.tt added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 22:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 21:21:34 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 22:31:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 21:31:57 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #4 from H?ctor Eduardo Castro Avalos --- (In reply to Marc V?ron from comment #3) > Hi Hector, I could reproduce the blank screen issue and it is resolved with > your patch. > > Regarding the bad utf8 encoding (#4 in test plan), can you give a hint on > what is wrong? Hi Marc, for me the patch works well, maybe I need to reword message of commit. Let me improve. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 22:52:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 21:52:20 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44887|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 45427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45427&action=edit Bug 15190: Bad utf8 decode to unapi and fixing blank screen error status Fix bad utf8 decoding, also fix cgi->header(-status) to redirect to one of the posible error pages in /cgi-bin/koha/errors/ To reproduce the issue in OPAC 1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with special characters 2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4&format=marcxml 3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise 4) A marcxml record will display, notice about the bad utf8 decoding characters 5) Search the record in opac and try to save in Zotero (see bad decoding) 6) To reproduce blank screen (error status) play with: cgi-bin/koha/unapi?id=koha:biblionumber:4&format= cgi-bin/koha/unapi?id=koha:biblionumber:4&format=none cgi-bin/koha/unapi?id=koha:biblionumber:&format=marcxml cgi-bin/koha/unapi?&format=oai_dc 7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162) Test plan -Apply patch -Follow steps 2 to 6 -You will see no errors in utf8 and redirection to one of the error pages in /cgi-bin/koha/errors/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 23:31:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 22:31:31 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #6 from H?ctor Eduardo Castro Avalos --- (In reply to Marc V?ron from comment #3) > Regarding the bad utf8 encoding (#4 in test plan), can you give a hint on > what is wrong? Ahh.. Ok I understand the deconding problem only happend with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc The format marcxml works well doesn't have utf8 decoding problem. Antolog????a de entremeses del Siglo de Oro / Arellano, Ignacio. Garc????a Vald????s, Celsa Carmen, ed. If you apply the patch Antolog?a de entremeses del Siglo de Oro / Arellano, Ignacio. Garc?a Vald?s, Celsa Carmen, ed. I saw the problem in 3.14 or 3.16 but I think in some way someone corrected the problem, Zotero take metadata from marcxml. Whe i was testing this bug I only tested with oai_dc, srw_dc and rdfdc. That's my mistake -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 23:36:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 22:36:08 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45427|0 |1 is obsolete| | --- Comment #7 from H?ctor Eduardo Castro Avalos --- Created attachment 45428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45428&action=edit Bug 15190: Bad utf8 decode to unapi and fixing blank screen error status Fix bad utf8 decoding, also fix cgi->header(-status) to redirect to one of the posible error pages in /cgi-bin/koha/errors/ To reproduce the issue in OPAC 1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with special characters 2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4&format=oai_dc play with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc. Note: marcxml does not fail 3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise 4) An oai_dc record will display, notice about the bad utf8 decoding characters 5) Search the record in OPAC 6) To reproduce blank screen (error status) play with: cgi-bin/koha/unapi?id=koha:biblionumber:4&format= cgi-bin/koha/unapi?id=koha:biblionumber:4&format=none cgi-bin/koha/unapi?id=koha:biblionumber:&format=oai_dc cgi-bin/koha/unapi?&format=oai_dc 7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162) Test plan -Apply patch -Follow steps 2 to 6 -You will see no errors in utf8 and redirection to one of the error pages in /cgi-bin/koha/errors/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 00:47:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 23:47:49 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15314 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 [Bug 15314] Use Bootstrap modal for cataloging merge MARC preview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 00:47:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2015 23:47:49 +0000 Subject: [Koha-bugs] [Bug 15314] New: Use Bootstrap modal for cataloging merge MARC preview Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 Bug ID: 15314 Summary: Use Bootstrap modal for cataloging merge MARC preview Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/merge.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 8290 The "MARC" link on the cataloging merge page should trigger a preview in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 01:52:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 00:52:08 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15315 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15315 [Bug 15315] Non-XSLT detail view still uses Greybox for MARC preview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 01:52:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 00:52:08 +0000 Subject: [Koha-bugs] [Bug 15315] New: Non-XSLT detail view still uses Greybox for MARC preview Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15315 Bug ID: 15315 Summary: Non-XSLT detail view still uses Greybox for MARC preview Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/detail.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 8290 The XSLT version of the detail view in the staff client has used a Bootstrap modal for a while now. The non-XSLT version still uses Greybox, and this should be corrected. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 02:28:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 01:28:09 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after logout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #40 from Galen Charlton --- (In reply to Fr?d?ric Demians from comment #39) > This patch has been pushed to 3.20.x, will be in 3.20.7. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 06:41:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 05:41:05 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #56 from Galen Charlton --- I have decided to exclude the patches for this bug from the package for 3.20.6, as I will not build packages if 'make test' fails... which it now does during package construction in 3.20.x. This is because the new dependencies are required for Koha::Sitemap to compile (as is tested by t/00-load.t). I will not add new dependencies because doing so would break apt-get upgrade for the oldstable stream. It was contrary to custom to backport a new feature to a maintenance branch to begin with. While, of course, there is room for some discretion on the part of the RMaint, for the new package maintainer -- i.e. me, adding new dependencies to the package for a maintenance release is a no-go for anything short of a major security issue that has no other plausible solution. The sitemaps feature is not, of course, a security issue. In the case of 3.14.10, which I think was the last time a dist-upgrade was forced for a maintenance release, the patches for bug 8044 at least had the promise of expanding the scope of I18N (although I note that that promise has yet to be fulfilled). I realize that this puts folks in an awkward position. I would prefer that 11190 be reverted from 3.20.x as a matter of policy; alternative approaches to deliver the functionality to users who are not yet ready to upgrade to 3.22.x include establishing a contrib package for the sitemap generator; and if needs must, I can revisit my decision for 3.20.7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 07:45:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 06:45:33 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #14 from Galen Charlton --- Very promising start. Since the Let's Encrypt certificates are short-lived (90 days, IIRC), there will also need to be a mechanism in place to automatically renew them. An /etc/cron.monthly/koha-common might do for now (although I'm kinda hoping that the Debian Let's Encrypt packagers come up with a way to centralize management of the periodic cert renewals/replacmenets). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 07:47:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 06:47:48 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|robin at catalyst.net.nz |gmcharlt at gmail.com CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 08:04:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 07:04:51 +0000 Subject: [Koha-bugs] [Bug 2509] create Debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2509 --- Comment #3 from Galen Charlton --- Debian packages for Koha have existed for years, so I think this bug can be safely closed. In fact, I shall do so. :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 08:04:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 07:04:59 +0000 Subject: [Koha-bugs] [Bug 2509] create Debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2509 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 08:06:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 07:06:36 +0000 Subject: [Koha-bugs] [Bug 5517] After removal of koha-common package in Debian Squeeze cron jobs are not deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5517 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master Assignee|robin at catalyst.net.nz |gmcharlt at gmail.com CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 08:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 07:16:58 +0000 Subject: [Koha-bugs] [Bug 15127] (Plack on packages) plack.psgi should check for changed files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15127 --- Comment #1 from Galen Charlton --- (In reply to Tom?s Cohen Arazi from comment #0) > This is documented on the Wiki. Where? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 08:32:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 07:32:57 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #57 from Fr?d?ric Demians --- This patch has been reverted from 3.20.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 11:30:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 10:30:15 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #15 from Mirko Tietgen --- It is supposed to be automated in itself.[1] The experimental Debian package[2] has a letsencrypt and a letencrypt-renew binary.[3] For now using a copy of the line used to generate the first certificate in a monthly cronjob should work. Or maybe a koha-list --letsencrypt flag that lists all instances created that way and a cronjob that uses this. I will add something as seperate patch so it can be ommited when its not needed anymore at push time. [1] https://letsencrypt.readthedocs.org/en/latest/using.html#renewal [2] https://packages.debian.org/experimental/letsencrypt [3] https://github.com/letsencrypt/letsencrypt/issues/257 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 13:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 12:49:51 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #16 from Mirko Tietgen --- It would probably be better to have a single option for koha-create. Just --letsencrypt , and if path is not given, use default /usr/bin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 13:53:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 12:53:32 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 --- Comment #17 from Mirko Tietgen --- The "real" IfDefine version (not on bz) does not work with apache 2.2, this one (using IfDefine as a way to comment out parts of the conf file) does not work for me on 2.4. I will go back to the uglier first version with a lot of # comments in the file that get removed after certs are created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 13:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 12:54:26 +0000 Subject: [Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #18 from Mirko Tietgen --- Setting to in disussion for now, patch does not work atm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 16:57:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 15:57:35 +0000 Subject: [Koha-bugs] [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 16:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 15:57:38 +0000 Subject: [Koha-bugs] [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45423|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 45429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45429&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:01:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:01:39 +0000 Subject: [Koha-bugs] [Bug 15309] Use Bootstrap modal for cataloging search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:01:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:01:41 +0000 Subject: [Koha-bugs] [Bug 15309] Use Bootstrap modal for cataloging search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45419|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 45430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45430&action=edit Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 4. Perform a search which will return results from the reservoir. 5. Test the corresonding "MARC" and "Card" links for those results. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:11:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:11:05 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:11:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:11:08 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45287|0 |1 is obsolete| | --- Comment #12 from Galen Charlton --- Created attachment 45431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45431&action=edit Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is set to "[Give] priority for filling holds to patrons whose... To verify: - Set syspref as above and run test. Test 14 fails. - Set syspref to [Don't give] and run test agein, it passes OK. To test: - Apply patch - Run test again with syspref set / not set Expected result: In both cases test should pass (AMended to change bug title) Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:22:43 +0000 Subject: [Koha-bugs] [Bug 14153] Noisy warns in admin/transport-cost-matrix.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153 --- Comment #2 from Galen Charlton --- Comment on attachment 38880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38880 Bug 14153: Noisy warns in admin/transport-cost-matrix.pl Review of attachment 38880: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14153&attachment=38880) ----------------------------------------------------------------- ::: admin/transport-cost-matrix.pl @@ +42,4 @@ > }); > my $use_transport_cost_matrix = C4::Context->preference("UseTransportCostMatrix"); > > +my $update = {$input->param('op')} eq 'set-cost-matrix'; Adding the curly brace here means that the code is trying to create an anonymous hash containing the contents of $input->param('op'), and that can't be compared to the scalar value 'set-cost-matrix'. Also, when trying to update an entry in the table, an "Odd number of elements in anonymous hash" error is thrown. Something like this would do the trick: my $update = ( $input->param('op') // '' ) eq 'set-cost-matrix'; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:22:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:22:58 +0000 Subject: [Koha-bugs] [Bug 14153] Noisy warns in admin/transport-cost-matrix.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:34:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:34:37 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45428|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 45432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45432&action=edit Bug 15190: Bad utf8 decode to unapi and fixing blank screen error status Fix bad utf8 decoding, also fix cgi->header(-status) to redirect to one of the posible error pages in /cgi-bin/koha/errors/ To reproduce the issue in OPAC 1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with special characters 2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4&format=oai_dc play with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc. Note: marcxml does not fail 3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise 4) An oai_dc record will display, notice about the bad utf8 decoding characters 5) Search the record in OPAC 6) To reproduce blank screen (error status) play with: cgi-bin/koha/unapi?id=koha:biblionumber:4&format= cgi-bin/koha/unapi?id=koha:biblionumber:4&format=none cgi-bin/koha/unapi?id=koha:biblionumber:&format=oai_dc cgi-bin/koha/unapi?&format=oai_dc 7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162) Test plan -Apply patch -Follow steps 2 to 6 -You will see no errors in utf8 and redirection to one of the error pages in /cgi-bin/koha/errors/ -- Bad formatting reproduced e.g. with format=srw_dc, blank page reproduced with oai_dc, after applying patch formatting and redirect to error page OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:36:42 +0000 Subject: [Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:43:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:43:26 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #3 from Galen Charlton --- I've also had issues getting Text::Unaccent to install on RedHat-like distros. That said, at the moment Text::Unaccent::PurePerl is not packaged for Debian or Ubuntu. It is also (presumably) slower than Text::Unaccent, although given that unac_string() is used only when registering a new patron, I don't speed matters much here. I'd like to suggest an alternative way to get the job done - use Unicode::Normalize, which is already a Koha dependency: http://stackoverflow.com/a/17561928/880696 If we do that, we can drop the dependency on Text::Unaccent entirely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:44:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:44:42 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:47:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:47:44 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:54:05 +0000 Subject: [Koha-bugs] [Bug 15310] Fix duplicate fines issue when changing date or time format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:57:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:57:41 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7411 CC| |sophie.meynieux at biblibre.co | |m --- Comment #4 from Katrin Fischer --- I didn't remember, but it looks like I introduced this dependency. I am in favor of reducing troublesome dependencies - so I am totally fine with an alternative solution. Unfortunately the initial bug 7411 has no clear problem description, so it's hard to tell now why we made the change in the first place. Maybe Biblibre could check the linked Mantis entry? http://mantis.biblibre.com/view.php?id=7744 Adding Sophie to this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 17:57:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 16:57:41 +0000 Subject: [Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14759 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 18:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 17:01:33 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #5 from Jonathan Druart --- The patch is for stable versions, please see commit message. Bug 14965 is an enh and won't be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 18:01:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 17:01:48 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 18:01:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 17:01:58 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 18:02:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 17:02:08 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 18:02:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 17:02:19 +0000 Subject: [Koha-bugs] [Bug 15138] typo in reports/borrowers_out.pl - issues.timestamap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 18:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 17:27:14 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #5 from Galen Charlton --- I wrote a little test program to compare the options: ___BEGIN___ #!/usr/bin/perl use Modern::Perl; use Text::Unaccent qw//; use Text::Unaccent::PurePerl qw//; use utf8; use Unicode::Normalize; binmode STDOUT, ':utf8'; my @str = ( '?t?', 'umla?t', '?????', '??????', '???', '?? ?? ?? ?? ?? ?? ??', '??????????' ); sub unaccent { my $str = NFKD(shift); $str =~ s/\p{NonspacingMark}//g; return $str; } foreach (@str) { if ($_ eq '??????????') { # special case to avoid locking my terminal session (!) print "Text::Unaccent - $_ => *refusing to let Text::Unaccent do this*\n"; } else { print "Text::Unaccent - $_ => " . Text::Unaccent::unac_string('utf-8', $_) . "\n"; } print "Text::Unaccent::PurePerl - $_ => " . Text::Unaccent::PurePerl::unac_string($_) . "\n"; print "Strip NonspacingMark - $_ => " . unaccent($_) . "\n"; } ___END___ Here's its output: Text::Unaccent - ?t? => ete Text::Unaccent::PurePerl - ?t? => ete Strip NonspacingMark - ?t? => ete Text::Unaccent - umla?t => umlaut Text::Unaccent::PurePerl - umla?t => umlaut Strip NonspacingMark - umla?t => umlaut Text::Unaccent - ????? => ???????? Text::Unaccent::PurePerl - ????? => ????? Strip NonspacingMark - ????? => ????? Text::Unaccent - ?????? => ???????? Text::Unaccent::PurePerl - ?????? => ?????? Strip NonspacingMark - ?????? => ???? Text::Unaccent - ??? => ?????? Text::Unaccent::PurePerl - ??? => ??? Strip NonspacingMark - ??? => ??? Text::Unaccent - ?? ?? ?? ?? ?? ?? ?? => ??? ??? ??? ??? ??? ??? ??? Text::Unaccent::PurePerl - ?? ?? ?? ?? ?? ?? ?? => ?? ?? ?? ?? ?? ?? ?? Strip NonspacingMark - ?? ?? ?? ?? ?? ?? ?? => ?? ?? ?? ?? ?? ?? ?? Text::Unaccent - ?????????? => *refusing to let Text::Unaccent do this* Text::Unaccent::PurePerl - ?????????? => ?????????? Strip NonspacingMark - ?????????? => ????? Some conclusions: [1] Text::Unaccent mangles non-Latin characters outright; that's enough reason to get rid of it. [2] Both Text::Unaccent::PurePerl and stripping NonspacingMark characters are better -- they strip accents from Latin scripts, and don't mangle non-Latin. Removing NonspacingMark characters is more aggressive; I think we need input from Arabic, Hebrew, and Greek suers as to whether that is acceptable -- or, alternatively, if we need a system preference, or need to bite the bullet and package Text::Unaccent::PurePerl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 19:48:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 18:48:57 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|3.20 |master --- Comment #6 from Katrin Fischer --- Seeing the bad results for non-latin scripts I am promoting this from enhancement to bug. Not sure about the Arabic - I think we need a native speaker/reader. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:38:56 +0000 Subject: [Koha-bugs] [Bug 15316] New: Use Bootstrap modal for authority Z39.50 search results preview Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Bug ID: 15316 Summary: Use Bootstrap modal for authority Z39.50 search results preview Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/z3950_auth_search.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 8290 When viewing authority Z39.50 search results, the "MARC" link should trigger a preview in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:38:56 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15316 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:40:52 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15317 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 [Bug 15317] Use Bootstrap modal for MARC and Card preview when ordering from staged files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:40:52 +0000 Subject: [Koha-bugs] [Bug 15317] New: Use Bootstrap modal for MARC and Card preview when ordering from staged files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Bug ID: 15317 Summary: Use Bootstrap modal for MARC and Card preview when ordering from staged files Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/addorderiso2709.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 8290 When adding to an order from a staged file, the "MARC" and "Card" links should trigger a preview in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:42:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:42:33 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15318 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318 [Bug 15318] Use Bootstrap modal for MARC and Card preview when ordering an external source -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:42:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:42:33 +0000 Subject: [Koha-bugs] [Bug 15318] New: Use Bootstrap modal for MARC and Card preview when ordering an external source Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318 Bug ID: 15318 Summary: Use Bootstrap modal for MARC and Card preview when ordering an external source Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/z3950_search.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 8290 When adding to an order from an external source, the "MARC" and "Card" links on the search results list should trigger a preview in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:51:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:51:32 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15319 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:51:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:51:32 +0000 Subject: [Koha-bugs] [Bug 15319] New: Use Bootstrap modal for MARC preview when performing batch record modifications Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Bug ID: 15319 Summary: Use Bootstrap modal for MARC preview when performing batch record modifications Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/batch_record_modification.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 8290 When confirming batch record modifications, the "Preview MARC" link on the results list should trigger a preview in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:58:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:58:33 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15320 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15320 [Bug 15320] Use Bootstrap modal for MARC preview when ordering from an existing record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 20:58:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 19:58:33 +0000 Subject: [Koha-bugs] [Bug 15320] New: Use Bootstrap modal for MARC preview when ordering from an existing record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15320 Bug ID: 15320 Summary: Use Bootstrap modal for MARC preview when ordering from an existing record Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/neworderbiblio.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 8290 When searching existing records in order to add to an order, "View MARC" link on the results list should trigger a preview in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 00:41:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2015 23:41:47 +0000 Subject: [Koha-bugs] [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #3 from Owen Leonard --- Whoops, I see a mistake with this patch. I'll resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 03:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 02:23:11 +0000 Subject: [Koha-bugs] [Bug 15321] New: Add delete report option to a saved report output screen Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Bug ID: 15321 Summary: Add delete report option to a saved report output screen Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org It would be nice if the saved report output screen (cgi-bin/koha/reports/guided_reports.pl?reports=[report number]&phase=Run%20this%20report) had a delete option. Sometimes you need to write a report and then immediately delete it. Right now, you have to go back to the saved reports module and delete from there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 03:25:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 02:25:01 +0000 Subject: [Koha-bugs] [Bug 15322] New: Add delete report option to edit saved report screen Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15322 Bug ID: 15322 Summary: Add delete report option to edit saved report screen Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org It would be nice if the saved report edit screen (cgi-bin/koha/reports/guided_reports.pl?reports=[report number]&phase=Edit%20SQL) had a delete option. When editing reports/checking reports, sometimes you can tell on the edit report screen that the report needs to be deleted. Right now, you have to go back to the saved reports module and delete from there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 03:36:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 02:36:04 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 --- Comment #1 from Heather Braum --- FYI: when you select multiple reports to delete from the saved SQL reports page, and click the "Delete selected" button, you do get a "Are you sure you want to delete the selected reports?" confirmation message. The issue is with individual report deletion -- no delete confirmation message is triggered there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 15:35:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 14:35:48 +0000 Subject: [Koha-bugs] [Bug 15323] New: ./t/Prices.t fails without a valid database Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Bug ID: 15323 Summary: ./t/Prices.t fails without a valid database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtj at kohaaloha.com QA Contact: gmcharlt at gmail.com more info to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 20:16:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 19:16:00 +0000 Subject: [Koha-bugs] [Bug 15315] Non-XSLT detail view still uses Greybox for MARC preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15315 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- Isn't non-XSLT detail view deprecated anyway? http://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR1:_non-XSLT_search_results_and_bib_display_templates_deprecated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 20:45:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 19:45:47 +0000 Subject: [Koha-bugs] [Bug 15292] Libris (Swedish national catalogue) item status service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I think I like the idea of this being separate from ILS-DI somewhere in the svc directory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 21:06:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 20:06:19 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #43 from bondiurbano --- (In reply to Holger Mei?ner from comment #42) > Rebased on master. Holger, I do not understand what is the status of this issue... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 21:15:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 20:15:40 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer --- Hi Kyle, some complaints form the QA script: FAIL C4/Circulation.pm FAIL spelling neccessary ==> necessary FAIL valid BEGIN failed--compilation aborted Compilation failed in require Global symbol "$borrower" requires explicit package name Also: HoldsQueue.t is failing: perl t/db_dependent/HoldsQueue.t 1..23 Global symbol "$borrower" requires explicit package name at /home/katrin/kohaclone/C4/Circulation.pm line 2939. Compilation failed in require at /home/katrin/kohaclone/C4/Overdues.pm line 30. BEGIN failed--compilation aborted at /home/katrin/kohaclone/C4/Overdues.pm line 30. Compilation failed in require at /home/katrin/kohaclone/C4/Members.pm line 29. BEGIN failed--compilation aborted at /home/katrin/kohaclone/C4/Members.pm line 29. Compilation failed in require at t/db_dependent/HoldsQueue.t line 19. BEGIN failed--compilation aborted at t/db_dependent/HoldsQueue.t line 19. # Looks like your test exited with 255 before it could output anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 21:23:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 20:23:12 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- This seems to work fine as it is - passing QA. Please let me know if you want to do a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 21:24:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 20:24:34 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 21:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 20:24:38 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45389|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 45433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45433&action=edit [PASSED QA] Bug 12342: Patron registration datepicker dropdown shows only 10 years This patch changes the options to the date picker, allowing easy selection of dates up to 120 years from the current date. To test: - Click on 'Patrons' from the main menu, select 'New patron' - Set input focus to the 'Date of birth' input field, the date selection widget should show up. - The year selection drop-down will only show current year minus 10. - Apply the patch - Go back to the same screen, set input focus to the 'Date of birth' field. - The year selection drop-down should show current year minus 120. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 21:39:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 20:39:10 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 21:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 20:39:13 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45351|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 45434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45434&action=edit [PASSED QA] Bug 14971: fix RIS export This patch removes a limit in RIS.pm print_isbn sub. To test: 1) Find in opac a book with an isbn with length(isbn) > 10 (with dashes or isbn13) 2) Export record to RIS format, check truncated SN field in exported file 3) Apply the patch 4) Export again, no more truncation Signed-off-by: jvr Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 21:39:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 20:39:47 +0000 Subject: [Koha-bugs] [Bug 14971] RIS only outputs the first 10 characters for either ISBN10 or ISBN13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 --- Comment #9 from Katrin Fischer --- I have added the sign-off line in the QA step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:15:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:15:26 +0000 Subject: [Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This works as described. With the proposed solution the values of the hidden patron attribute are visible in the HTML source of the page. I am not super happy about this, as it seems like a potential privacy problem to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:21:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:21:44 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:21:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:21:47 +0000 Subject: [Koha-bugs] [Bug 15223] Buttons on patron list main page funny after font awesome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45295|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 45435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45435&action=edit [PASSED QA] Bug 15213 - fix buttons on patron lists To test: go to tools -> patron lists notice that the buttons are not misaligned anymore You may need to force refresh the page to see the original issue, and to see it fixed. http://bugs.koha-community.org/show_bug.cgi?id=15223 With patch buttons display nicely. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:23:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:23:46 +0000 Subject: [Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:23:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:23:49 +0000 Subject: [Koha-bugs] [Bug 15300] Translatability: Replace ambiguous 'From' and 'To' in members-update.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15300 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45388|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 45436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45436&action=edit [PASSED QA] Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt This patch replaces semantically ambigous words "From" and "To" in koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt for better translatability. To test: - Apply patch - Make sure that patrons can request detail changes in OPAC (sysprefs opacuserlogin, OPACPatronDetails) - Log in to OPAC, request a change of personal details (cgi-bin/koha/opac-memberentry.pl) - Log in to staff client - Click link 'Patrons requesting modifications' or go to Home > Patrons > Update patron records - Verify that table headers make sense Signed-off-by: Hector Castro Rewording Ok for translation purpose Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:26:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:26:05 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:26:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:26:08 +0000 Subject: [Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45431|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 45437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45437&action=edit [PASSED QA] Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is set to "[Give] priority for filling holds to patrons whose... To verify: - Set syspref as above and run test. Test 14 fails. - Set syspref to [Don't give] and run test agein, it passes OK. To test: - Apply patch - Run test again with syspref set / not set Expected result: In both cases test should pass (AMended to change bug title) Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:31:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:31:00 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:31:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:31:02 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45262|0 |1 is obsolete| | Attachment #45263|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 45438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45438&action=edit [PASSED QA] Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. Signed-off-by: Magnus Enger Set AnonymousPatron pref to a nonexistent borrowernumber. Before the patch, about.pl shows a nasty error. After applying the patch the error is gone. Tests in t/db_dependent/Objects.t pass. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:31:30 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #12 from Katrin Fischer --- Created attachment 45439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45439&action=edit [PASSED QA] Bug 15270: Add regression tests for Koha::Objects->find Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:36:42 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Comment on attachment 45410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45410 KOHA_SIP2_Checkout It looks like this issue is caused by the fact that the items.onloan is not updated correctly with the due date, while the entry in the issues table is correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:46:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:46:49 +0000 Subject: [Koha-bugs] [Bug 15309] Use Bootstrap modal for cataloging search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 22:46:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 21:46:51 +0000 Subject: [Koha-bugs] [Bug 15309] Use Bootstrap modal for cataloging search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15309 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45430|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 45440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45440&action=edit [PASSED QA] Bug 15309 - Use Bootstrap modal for cataloging search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 4. Perform a search which will return results from the reservoir. 5. Test the corresonding "MARC" and "Card" links for those results. Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 23:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 22:32:25 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #59 from David Cook --- (In reply to Viktor Sarge from comment #57) > > It should be trivial to merge the 001 and 003 together to form a 035 like > > "(OCoLC)814782" (http://www.loc.gov/marc/bibliographic/bd035.html). That > > would certainly help eliminate that risk of "false matching" mentioned above. > > > > However, in the LIBRIS data that I've seen, I haven't seen any examples of a > > 003. > > Interesting. I've actually perceived it the other way around - that Libris > is actually quite good at sticking "SE-LIBR" into 003 of all their records. > > (A quick example http://libris.kb.se/bib/14862617?vw=full&tab3=marc) That's very interesting, Viktor! When I look at http://libris.kb.se/bib/219553?vw=full&tab3=marc, I see a 003. However, when I look at http://data.libris.kb.se/bib/oaipmh?verb=GetRecord&metadataPrefix=marcxml&identifier=http://libris.kb.se/resource/bib/219553, I do not see a 003. There are a fair number of other discrepancies between the catalogue and the OAI-PMH server (which is password protected) it seems. I think the OAI-PMH server is still in beta, so perhaps that's the explanation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 00:03:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2015 23:03:19 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- My knowledge of Arabic is pretty much non-existent, but I recall a librarian I know once wanting Zebra to remove hamza for search purposes... (https://en.wikipedia.org/wiki/Arabic_diacritics) What's the purpose of Text::Unaccent currently? It's only used when adding members? Is it for generating a userid? Do we really need to remove accents for that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 07:33:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 06:33:01 +0000 Subject: [Koha-bugs] [Bug 15270] Koha::Objects->find can exploded if searching for nonexistent record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #13 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:08:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 08:08:29 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 june changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from june --- (In reply to Katrin Fischer from comment #1) > Comment on attachment 45410 [details] > KOHA_SIP2_Checkout > > It looks like this issue is caused by the fact that the items.onloan is not > updated correctly with the due date, while the entry in the issues table is > correct. How can I solve to update the item.onloan correctly? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:24:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 09:24:22 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #19 from Jonathan Druart --- (In reply to David Cook from comment #18) > (In reply to Katrin Fischer from comment #17) > > You are right, it's theoretically possible... but in my opinoin not > > recommendable. Think about features like item batch editing or any search > > form/report that offers you a list of collections. It will cause lots of > > inconvenience if someone does that. I think we don't need to cover this > > possibility. > > Ok. I'm fine with that. I was mostly just following the pattern that already > existed in the script. Other things than collection code do this same check. > Should a follow-up remove this "all framework checking" for all criteria? I would prefer to keep it, to avoid undesired side-effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:56:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 09:56:40 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:56:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 09:56:42 +0000 Subject: [Koha-bugs] [Bug 15231] Import patrons: Remove string splitting by html tags to avoid weird translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15231 --- Comment #7 from Jonathan Druart --- Created attachment 45441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45441&action=edit Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations Some of the strings in Home > Tools > Import patrons contain html tags and therefore are splitted in the translation tool. This makes it nearly impossible to create correct translations from the partial strings. Additinally, the notes for Extended patron attributes never displayed (due to a bug). To test: - Apply patch - Enable Syspref 'ExtendedPAtronAttributes' - Go to Home > Tools > Import patrons and verify, that the Notes at the right of the screen make sense Signed-off-by: Hector Castro Split html tags removed, notes at right side it displayed correctly Bug 15231: (followup) Remove stray tag This patch removes a stray tag (see comment #4) and a superfluous blank. Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart Squash the 2 patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:59:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 09:59:26 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #36 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #35) > (In reply to Francois Charbonnier from comment #32) > > > So please, lets not abandoned this patch in the small enhancement patches > > limbo of bugzilla because we want to move two steps at a time. Let's do it > > step by step! > > I agree. You have to strike while the iron is hot. I'd be pleased to > re-sign-off this patch as soon as issue rightly raised by Jonathan will be > addressed. And I will be happy to re-qa it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:03:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:03:06 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:03:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:03:08 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45109|0 |1 is obsolete| | Attachment #45417|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 45442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45442&action=edit Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. Signed-off-by: Hector Castro Rewording Ok for translation purposes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:03:12 +0000 Subject: [Koha-bugs] [Bug 15233] Cataloging subfield editors: Clean up html and streamline text for better translatability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15233 --- Comment #14 from Jonathan Druart --- Created attachment 45443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45443&action=edit Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:03:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:03:17 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:08:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:08:34 +0000 Subject: [Koha-bugs] [Bug 15250] Software error: Can't locate object method "field" via package "aqorders.datereceived" in reports/acquisitions_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15250 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:20:25 +0000 Subject: [Koha-bugs] [Bug 15289] "borrowers" permission doesn't allow to see current loans In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- It's not obvious which permission should be required to see the checkout list. Katrin and Nicole, will you agree that a user with only the borrowers permission could access to this list? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:20:55 +0000 Subject: [Koha-bugs] [Bug 15289] "borrowers" permission doesn't allow to see current loans In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:24:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:24:49 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #13 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:37:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:37:21 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:37:50 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:40:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 10:40:48 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:24:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 12:24:21 +0000 Subject: [Koha-bugs] [Bug 15127] (Plack on packages) plack.psgi should check for changed files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15127 --- Comment #2 from Tom?s Cohen Arazi --- (In reply to Galen Charlton from comment #1) > (In reply to Tom?s Cohen Arazi from comment #0) > > This is documented on the Wiki. > > Where? I mistakenly thought a piece of code was doing that and Dobrica told me it wasn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:13:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 13:13:29 +0000 Subject: [Koha-bugs] [Bug 15256] Items table on detail page can be broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 13:13:44 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #14 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:14:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 13:14:00 +0000 Subject: [Koha-bugs] [Bug 11602] Fix localcover display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11602 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #7 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:14:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 13:14:14 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #12 from Fr?d?ric Demians --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:19:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 13:19:35 +0000 Subject: [Koha-bugs] [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:19:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 13:19:37 +0000 Subject: [Koha-bugs] [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45429|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 45445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45445&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the visible "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" and "Card" links it displays. Corrected: The original patch didn't address the hidden menu which appears if you click in any table cell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:46:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 13:46:31 +0000 Subject: [Koha-bugs] [Bug 15324] New: Checkout page shows title "Waiting holds:" even for patron without waiting holds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Bug ID: 15324 Summary: Checkout page shows title "Waiting holds:" even for patron without waiting holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The checkout page shows the H3 title "Waiting holds:" even if the patron does not have holds waiting. To reproduce: - Make sure that you have a patron A with waiting holds and A patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B - At the right, you see a stray title "Waiting holds:" Expected: The title is not displayes if patron has no holds waiting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:46:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 13:46:34 +0000 Subject: [Koha-bugs] [Bug 15320] Use Bootstrap modal for MARC preview when ordering from an existing record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:46:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 13:46:36 +0000 Subject: [Koha-bugs] [Bug 15320] Use Bootstrap modal for MARC preview when ordering from an existing record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15320 --- Comment #1 from Owen Leonard --- Created attachment 45446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45446&action=edit Bug 15320 - Use Bootstrap modal for MARC preview when ordering from an existing record In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from an existing record so that the "View MARC" preview is displayed in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to search for an existing record. 4. Perform any search which will return results. 5. Test the "View MARC" link for multiple results and confirm that the correct data is shown each time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:10:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:10:09 +0000 Subject: [Koha-bugs] [Bug 15317] Use Bootstrap modal for MARC and Card preview when ordering from staged files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 --- Comment #1 from Owen Leonard --- Created attachment 45447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45447&action=edit Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from a staged file so that the "MARC" and "Card" previews display in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from a staged file. 4. Click "Add orders" from any staged file. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:10:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:10:07 +0000 Subject: [Koha-bugs] [Bug 15317] Use Bootstrap modal for MARC and Card preview when ordering from staged files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:24:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:24:05 +0000 Subject: [Koha-bugs] [Bug 15325] New: rebuild_zebra.pl table option (-t) doesn't work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 Bug ID: 15325 Summary: rebuild_zebra.pl table option (-t) doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Depends on: 12368 $table is always set to 'biblioitems', no matter what is given on the command line. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:24:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:24:05 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15325 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 [Bug 15325] rebuild_zebra.pl table option (-t) doesn't work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:28:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:28:25 +0000 Subject: [Koha-bugs] [Bug 15325] rebuild_zebra.pl table option (-t) doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 --- Comment #1 from Julian Maurice --- Created attachment 45448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45448&action=edit Bug 15325: Fix --table option of rebuild_zebra.pl Option's value given on command line was never used and 'biblioitems' was used instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:28:34 +0000 Subject: [Koha-bugs] [Bug 15325] rebuild_zebra.pl table option (-t) doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:34:16 +0000 Subject: [Koha-bugs] [Bug 15325] rebuild_zebra.pl table option (-t) doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 --- Comment #2 from Julian Maurice --- Test plan: 1. git checkout master 2. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42" 3. You should see errors printed on screen about an unknown column 4. Apply patch 5. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42" 6. No errors \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:39:22 +0000 Subject: [Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:53:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:53:42 +0000 Subject: [Koha-bugs] [Bug 15326] New: Add CMS feature Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Bug ID: 15326 Summary: Add CMS feature Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: xarragon at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com As part of the sponsored project at Region Halland in Sweden we have added simple CMS functionality to Koha. This allows a library to add content pages without having to do any manual work. The content of the pages can be edited from the Staff client in WYSIWYG mode and navigation links are automatically added to OPAC and the staff client. Pages can be specific to branches, languages or OPAC and/or the staff interface. Several levels of pages are supported. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:56:50 +0000 Subject: [Koha-bugs] [Bug 14438] RTF / CSV /ODS format in Download cart option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14438 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:57:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 14:57:43 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:03:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:03:57 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:09:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:09:02 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checkout page shows title |Checkout page: Hide title |"Waiting holds:" even for |"Waiting holds:" for |patron without waiting |patrons without waiting |holds |holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:12:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:12:27 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 --- Comment #1 from Marc V?ron --- Created attachment 45449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45449&action=edit Bug 15324: Checkout page: Hide title "Waiting holds:" for patrons without waiting holds To reproduce: - Make sure that you have a patron A with waiting holds and A patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B - At the right, you see a stray title "Waiting holds:" To test: - Apply patch - Repeat steps above - Verify that the title "Waiting holds: does no longer display for patrons without waiting holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:13:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:13:24 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:17:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:17:22 +0000 Subject: [Koha-bugs] [Bug 15318] Use Bootstrap modal for MARC and Card preview when ordering an external source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:17:24 +0000 Subject: [Koha-bugs] [Bug 15318] Use Bootstrap modal for MARC and Card preview when ordering an external source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318 --- Comment #1 from Owen Leonard --- Created attachment 45450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45450&action=edit Bug 15318 - Use Bootstrap modal for MARC and Card preview when ordering an external source In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from an external source so that the "MARC" and "Card" previews display in Bootstrap modals. This patch also fixes a bug where the in-table popup menu points to the wrong record (fixed in Cataloging by Bug 6367). To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from an external source.. 4. Perform a search which will return multiple results. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 6. Click anywhere in the results table to show the hidden menu and test the "MARC" and "Card" links it displays, confirming that the data looks correct and corresponds correctly to the title you selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:29:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:29:46 +0000 Subject: [Koha-bugs] [Bug 15318] Use Bootstrap modal for MARC and Card preview when ordering an external source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45450|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 45451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45451&action=edit Bug 15318 - Use Bootstrap modal for MARC and Card preview when ordering an external source In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from an external source so that the "MARC" and "Card" previews display in Bootstrap modals. This patch also fixes a bug where the in-table popup menu points to the wrong record (fixed in Cataloging by Bug 6367). To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from an external source.. 4. Perform a search which will return multiple results. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 6. Click anywhere in the results table to show the hidden menu and test the "MARC" and "Card" links it displays, confirming that the data looks correct and corresponds correctly to the title you selected. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:30:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:30:05 +0000 Subject: [Koha-bugs] [Bug 15318] Use Bootstrap modal for MARC and Card preview when ordering an external source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:32:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:32:23 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:32:25 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45449|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 45452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45452&action=edit [SIGNED-OFF] Bug 15324: Checkout page: Hide title "Waiting holds:" for patrons without waiting holds To reproduce: - Make sure that you have a patron A with waiting holds and A patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B - At the right, you see a stray title "Waiting holds:" To test: - Apply patch - Repeat steps above - Verify that the title "Waiting holds: does no longer display for patrons without waiting holds. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:32:46 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #18 from Viktor Sarge --- Thanks for all the feedback and help! We sort of hoped that this would be more of a good "warm up" patch and with time running out for Martin in our project I have to point him in other directions so we're abandoning this one. We may be able to pick it up later, but I don't dare to make any such promises. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:36:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:36:27 +0000 Subject: [Koha-bugs] [Bug 15320] Use Bootstrap modal for MARC preview when ordering from an existing record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15320 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45446|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 45453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45453&action=edit Bug 15320 - Use Bootstrap modal for MARC preview when ordering from an existing record In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from an existing record so that the "View MARC" preview is displayed in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to search for an existing record. 4. Perform any search which will return results. 5. Test the "View MARC" link for multiple results and confirm that the correct data is shown each time. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:41:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:41:43 +0000 Subject: [Koha-bugs] [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45445|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 45454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45454&action=edit Bug 15313 - Use Bootstrap modal for z39.50 search MARC and Card preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging Z39.50 search results page so that "MARC" and "Card" previews are displayed in Bootstrap modals. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Cataloging. 2. Click the "New from Z39.50/SRU button to open the search window. 3. Perform any search which will return results. 4. Test the visible "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" and "Card" links it displays. Corrected: The original patch didn't address the hidden menu which appears if you click in any table cell. Followed test plan, works as expected (including click in table cell). Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:42:00 +0000 Subject: [Koha-bugs] [Bug 15313] Use Bootstrap modal for z39.50 search MARC and Card preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15313 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:42:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:42:46 +0000 Subject: [Koha-bugs] [Bug 15320] Use Bootstrap modal for MARC preview when ordering from an existing record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15320 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:51:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:51:39 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #8 from Galen Charlton --- (In reply to David Cook from comment #7) > Is it for generating a userid? Yes > Do we really need to remove accents > for that? Per bug 7411, there was apparently an issue searching on usernames with diacritics, although in retrospect that may simply have been an issue with mismatched Unicode normalization forms -- impossible to tell now. The current patcheset for bug 7679 also proposes to use Text::Unaccent, but I'm dubious about that one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:54:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:54:02 +0000 Subject: [Koha-bugs] [Bug 15317] Use Bootstrap modal for MARC and Card preview when ordering from staged files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45447|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 45455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45455&action=edit Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from a staged file so that the "MARC" and "Card" previews display in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from a staged file. 4. Click "Add orders" from any staged file. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:54:33 +0000 Subject: [Koha-bugs] [Bug 15317] Use Bootstrap modal for MARC and Card preview when ordering from staged files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:57:38 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45385|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 45456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45456&action=edit Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -Save in Comma separated text, Tab seprated text, and Open Document. -Verify in the three options the file exported is Ok Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:58:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:58:48 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:58:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:58:50 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45353|0 |1 is obsolete| | --- Comment #9 from Fr?d?ric Demians --- Created attachment 45457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45457&action=edit Bug 15290: SQL reports headers encoding problem To test: - Create an SQL report with column names containing UTF characters - Run the report => FAIL: The column names are double encoded - Export the report => FAIL: The column names are double encoded in the exported file - Apply the patch - Re-run the report (reload works) => SUCCESS: Encoding correct - Export the report => SUCCESS: Encoding correct - Sign off :-D Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:59:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 15:59:47 +0000 Subject: [Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:04:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:04:43 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:04:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:04:45 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 --- Comment #1 from Owen Leonard --- Created attachment 45458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45458&action=edit Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the batch record modification page so that the "Preview MARC" link triggers a preview in a Bootstrap modal. To test: 1. Apply the patch and navigate to Tools -> Batch record modification. 2. Submit multiple biblionumbers for batch modification. 3. In the results list, click the "Preview MARC" link for multiple results and confirm that the correct data is shown each time. 4. Use the "Modify record using the following template" menu to change the modification template. 5. Confirm that the "Preview MARC" links still work and show data correctly modified by your newly chosen template. 6. Repeat steps 2-5 with authority record numbers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:07:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:07:29 +0000 Subject: [Koha-bugs] [Bug 15325] rebuild_zebra.pl table option (-t) doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:07:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:07:31 +0000 Subject: [Koha-bugs] [Bug 15325] rebuild_zebra.pl table option (-t) doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45448|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 45459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45459&action=edit Bug 15325: Fix --table option of rebuild_zebra.pl Option's value given on command line was never used and 'biblioitems' was used instead. Test plan: 1. git checkout master 2. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42" 3. You should see errors printed on screen about an unknown column 4. Apply patch 5. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42" 6. No errors \o/ Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:08:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:08:00 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45340|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 45460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45460&action=edit [SIGNED-OFF] Bug 15269 [ENH]: Layout tweaks for the opac-detail page Make the following improvements to the layout of the OPAC detail page: * Image thumbnail has more white space * Summary is moved up the details block and font size is increased * Ratings controls are moved up the details * Small devices get a better layout To test: - Check that the ratings controls are moved up the page to be before the summary * If there is no summary, the controls should be under the series * If there is no summary or no series, the controls should be under the type * If there is no summary, no series, or no type, the controls should be under the authors (including contributing authors) - Check that the 520 field (Summary, Subject, Review, Scope and content, Abstract, Content advice) is rendered nearer to the top of the page, following material type, series, and the ratings. - Check that the font size for "Material type", "Series" and the 520 field (Summary, Subject, Review, Scope and content, Abstract, Content advice) are rendered at a 14px font size. - Check that authors and contributing authors are rendered at 16px font size. - Check that if any kind of cover image is present (or the no cover image placeholder image) it is rendered into a div with a class of 'span2' and appears on the left of the main item details. * Need to test every kind of cover image service * If no kind of cover image service is turned on, then the 'span2' div should not be present and the item details should be on the left of the content area. - Check that small devices (e.g. mobile phones) make the 'span2' image column take up the full width and appear above the rest of the item details. - Check that layout of the search results page is unaffected. - Check that changing 'OPACXSLTDetailsDisplay' to an empty string still yields the expected layout. Sponsored-by: ByWater Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:07:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:07:58 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:08:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:08:09 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45341|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 45461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45461&action=edit [SIGNED-OFF] Bug 15269 [ENH]: Compiled CSS changes Sponsored-by: ByWater Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:09:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:09:04 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #22 from Nick Clemens --- Tested with all non-subscription cover sources and novelist, all looks really good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:16:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:16:29 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45458|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 45462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45462&action=edit Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the batch record modification page so that the "Preview MARC" link triggers a preview in a Bootstrap modal. To test: 1. Apply the patch and navigate to Tools -> Batch record modification. 2. Submit multiple biblionumbers for batch modification. 3. In the results list, click the "Preview MARC" link for multiple results and confirm that the correct data is shown each time. 4. Use the "Modify record using the following template" menu to change the modification template. 5. Confirm that the "Preview MARC" links still work and show data correctly modified by your newly chosen template. 6. Repeat steps 2-5 with authority record numbers. Signed-off-by: Fr?d?ric Demians Works as described. No regression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:16:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:16:26 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:37:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:37:21 +0000 Subject: [Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:37:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:37:23 +0000 Subject: [Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 --- Comment #1 from Owen Leonard --- Created attachment 45463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45463&action=edit Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the authorities Z39.50 search results page so that MARC previews are displayed in Bootstrap modals. This patch also modifies the authorities toolbar include file to make the Z39.50 search popup size match that in cataloging. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Authorities. 2. Click the "New from Z39.50" button to open the search window. 3. Perform any search which will return multiple results. 4. Test the visible "MARC" link for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" link it displays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:40:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:40:16 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 --- Comment #2 from Fr?d?ric Demians --- Your patch works as described. But the UI change a little bit. Without your patch, the 'Transferred items' table on branchtransfers.pl page contains 7 columns: Title, Author, Barcode, Shelving location, Call number, Type, To With your patch, the same table contains 6 columns: Title, Author, Barcode, Shelving location, Call number, Item type, Collection code, Destination Without your patch, the 'Type' labelled column contains the item type specified in syspref BranchTransferLimitsType (ccode or item type). With you patch, both column are simply displayed. It's not an issue from my perspective. It could even be intersting to display both info there. But it could be perceived as a regression by some libraries that don't use CCODE for example. The use of Administration > Configure columns functionalities could be a solution in the long run. But in the meantime, couldn't you just add "id" to the table and tags in order to allow hiding them with JS? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:53:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:53:36 +0000 Subject: [Koha-bugs] [Bug 15314] Use Bootstrap modal for cataloging merge MARC preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:53:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:53:38 +0000 Subject: [Koha-bugs] [Bug 15314] Use Bootstrap modal for cataloging merge MARC preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 --- Comment #1 from Owen Leonard --- Created attachment 45464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45464&action=edit Bug 15314 - Use Bootstrap modal for cataloging merge MARC preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging merge selection page so that the MARC preview is shown in a Boostrap modal. This patch also changes the preview link to be the text "View MARC" so that it is clear what it does. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Select two records and click the "Merge selected" button to begin the merge process. 4. Test the "View MARC" link for both merge choices and confirm that the correct data is shown each time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:54:32 +0000 Subject: [Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45463|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 45465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45465&action=edit Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the authorities Z39.50 search results page so that MARC previews are displayed in Bootstrap modals. This patch also modifies the authorities toolbar include file to make the Z39.50 search popup size match that in cataloging. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Authorities. 2. Click the "New from Z39.50" button to open the search window. 3. Perform any search which will return multiple results. 4. Test the visible "MARC" link for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" link it displays. Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:54:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:54:30 +0000 Subject: [Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:56:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 16:56:21 +0000 Subject: [Koha-bugs] [Bug 15316] Use Bootstrap modal for authority Z39.50 search results preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15316 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- Side note: Since there is this contextual menu to view/import biblio records, why do we keep the 2 columns with links MARC/Import? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:06:50 +0000 Subject: [Koha-bugs] [Bug 15327] New: Minor tweaks to Bootstrap modal handling on Staged MARC management page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Bug ID: 15327 Summary: Minor tweaks to Bootstrap modal handling on Staged MARC management page Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/manage-marc-import.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org I have a few tweaks to the way the Bootstrap modal is handled on Staged MARC management page. - Use the prettier "html" format for the data preview - Remove some obsolete code left over from when the page used Greybox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:10:26 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:10:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:10:29 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45147|0 |1 is obsolete| | --- Comment #15 from Nicole C. Engard --- Created attachment 45466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45466&action=edit [SIGNED-OFF] Bug 14945 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the table items_last_borrower ( id, itemnumber, borrowernumber ) * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha insert into this table the patron who last returned this item. Replace existing row based on itemnumber if exists. * If table has a row for a given item, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the last patron to return the item. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Nick Clemens Signed-off-by: Jen DeMuth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:16:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:16:38 +0000 Subject: [Koha-bugs] [Bug 15327] Minor tweaks to Bootstrap modal handling on Staged MARC management page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:16:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:16:40 +0000 Subject: [Koha-bugs] [Bug 15327] Minor tweaks to Bootstrap modal handling on Staged MARC management page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 --- Comment #1 from Owen Leonard --- Created attachment 45467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45467&action=edit Bug 15327 - Minor tweaks to Bootstrap modal handling on Staged MARC management page This patch makes a couple of minor corrections to the template for staged MARC management. The MARC preview is now formatted using the "html" option, and some obsolete Greybox-related code has been removed. To test: 1. Apply the patch and go to Tools -> Staged MARC management. 2. Click any staged MARC file containing multiple records. 3. Click the title in the "Citation" column and confirm that a Bootstrap modal is triggered showing the correct data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:30:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:30:09 +0000 Subject: [Koha-bugs] [Bug 15328] New: Z39 replaces authorities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15328 Bug ID: 15328 Summary: Z39 replaces authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 45468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45468&action=edit buttons At the top of authority records there is a 'new from z39.50' button. In cataloging this creates a new record. In authorities it replaces the record. The button is either broken or need to be relabeled as 'replace via z39.50' Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:42:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:42:02 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #122 from Nicole C. Engard --- Created attachment 45469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45469&action=edit serials area where text shows I'm documenting this and am wondering where the text displays other than in the serials module. Shouldn't is show in the holdings area? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:45:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:45:14 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:45:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:45:22 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 18:54:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 17:54:30 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #68 from Galen Charlton --- Noting licenses of the proposed dependencies: Net::Printer - BSD; GPL- and DFSG-compatible Printer - Artistic License; not GPL-compatible, but DFSG-free. (Ancient module, though, and doesn't appear to be currently maintained). HTML::HTMLDoc - Perl license. (Also ancient, doesn't appear to be currently maintained, and has 23 open issues on CPAN). I wonder if Net::CUPS might be a better bet; it's currently packaged for Debian, but on the other hand, the Perl module doesn't appear to be maintained either. :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 19:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 18:02:58 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #2 from Owen Leonard --- Heather can you please check this again? In my tests 3.18.x and master there is already a delete confirmation warning. It is possible that a JavaScript error elsewhere on the page is short-circuiting the confirmation. Do you have custom JS in your staff client system preferences which might be causing problems? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 19:03:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 18:03:41 +0000 Subject: [Koha-bugs] [Bug 15299] Add delete confirmation for deleting saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15299 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 19:13:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 18:13:59 +0000 Subject: [Koha-bugs] [Bug 10121] unhighlight doesn't carry over to other pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10121 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 19:17:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 18:17:02 +0000 Subject: [Koha-bugs] [Bug 15127] (Plack on packages) plack.psgi should check for changed files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15127 --- Comment #3 from Galen Charlton --- What is the use case for this? For a production setup, in theory the only time a file of interest to Starman would change is when a package upgrade occurs, in which case Starman would be bounced anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 19:43:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 18:43:36 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 20:21:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 19:21:58 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13136=5D__No_documentation_for_Home_?= =?utf-8?b?4oC6IFRvb2xzIOKAuiBMYWJlbHMgaG9tZSDigLogTWFuYWdlIGxhYmVsIExh?= =?utf-8?q?youts?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 --- Comment #2 from Nicole C. Engard --- Created attachment 45470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45470&action=edit [BUG 13136] Add missing help file for label-manage.pl This patch adds in a help file for the new label-manage page. To test: * visit label creator * click manage and choose an option * click 'help' and confirm the file loads * repeat for all options under manage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 20:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 19:22:05 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13136=5D__No_documentation_for_Home_?= =?utf-8?b?4oC6IFRvb2xzIOKAuiBMYWJlbHMgaG9tZSDigLogTWFuYWdlIGxhYmVsIExh?= =?utf-8?q?youts?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 20:24:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 19:24:48 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Currently Koha does not release notes| |allow to checkout several | |items at once to a user. | |This can cause a waste of | |time when a user want to | |checkout more than 10 | |items. This development | |has been asked to have | |statistics on in-house use. | |Every night, a librarian | |will e CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 20:37:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 19:37:00 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 20:52:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 19:52:51 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 20:52:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 19:52:53 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 --- Comment #3 from Owen Leonard --- Created attachment 45471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45471&action=edit Bug 11280 - Change Withdrawn toggle to drop down selection of authorized values 'Withdrawn' is an authorised value just like 'Lost' and 'Damaged,' so the item detail screen should offer the same means of selecting one of multiple values. This patch re-uses the same template markup and code 'Lost' and 'Damage' use to make it possible to select a specific withdrawn value. To test you should have multiple values entered for the authorised value category 'WITHDRAWN'. 1. Apply the patch and locate any record in the catalog. 2. From the detail screen, click the barcode in the items table to go to the item detail page. 3. Confirm that there is a dropdown list of choices for 'Withdrawn status.' 4. Try both setting and unsetting various withdrawn statuses. 5. Confirm that setting Lost or Damaged statuses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 21:13:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 20:13:15 +0000 Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/page for terms and conditions of use in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 21:39:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 20:39:51 +0000 Subject: [Koha-bugs] [Bug 15327] Minor tweaks to Bootstrap modal handling on Staged MARC management page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45467|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45472&action=edit [SIGNED-OFF]Bug 15327: Minor tweaks to Bootstrap modal handling on Staged MARC management page This patch makes a couple of minor corrections to the template for staged MARC management. The MARC preview is now formatted using the "html" option, and some obsolete Greybox-related code has been removed. To test: 1. Apply the patch and go to Tools -> Staged MARC management. 2. Click any staged MARC file containing multiple records. 3. Click the title in the "Citation" column and confirm that a Bootstrap modal is triggered showing the correct data. Signed-off-by: Hector Castro Modal looks much better. Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 21:40:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 20:40:04 +0000 Subject: [Koha-bugs] [Bug 15327] Minor tweaks to Bootstrap modal handling on Staged MARC management page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 22:46:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 21:46:06 +0000 Subject: [Koha-bugs] [Bug 15314] Use Bootstrap modal for cataloging merge MARC preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45464|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45473&action=edit [SIGNED-OFF]Bug 15314: Use Bootstrap modal for cataloging merge MARC preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the cataloging merge selection page so that the MARC preview is shown in a Boostrap modal. This patch also changes the preview link to be the text "View MARC" so that it is clear what it does. To test: 1. Apply the patch and navigate to Cataloging. 2. Perform a search which will return results from the catalog. 3. Select two records and click the "Merge selected" button to begin the merge process. 4. Test the "View MARC" link for both merge choices and confirm that the correct data is shown each time. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 22:46:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 21:46:21 +0000 Subject: [Koha-bugs] [Bug 15314] Use Bootstrap modal for cataloging merge MARC preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 23:09:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 22:09:26 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #73 from David Cook --- Fr?d?ric, I think the text you put into "Text to go in the release notes" has been truncated :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 23:45:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2015 22:45:45 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #20 from David Cook --- (In reply to Jonathan Druart from comment #19) > I would prefer to keep it, to avoid undesired side-effects. That also seems reasonable. I'm happy to go with whatever QA decides in the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 01:13:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 00:13:48 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #9 from David Cook --- (In reply to Galen Charlton from comment #8) > (In reply to David Cook from comment #7) > > Do we really need to remove accents > > for that? > > Per bug 7411, there was apparently an issue searching on usernames with > diacritics, although in retrospect that may simply have been an issue with > mismatched Unicode normalization forms -- impossible to tell now. > > The current patcheset for bug 7679 also proposes to use Text::Unaccent, but > I'm dubious about that one. It's surprising that Text::Unaccent doesn't appear to be working correctly, since it is using iconv for the heavy lifting, and iconv seems to be pretty good when it comes to character conversions. I can't speak to Hebrew or Greek (while I thought I wasn't bad with the modern Greek alphabet, I didn't know they used accents...), Arabic is sure interesting. So we have the following string: ?????????? If we run the following: echo "??????????" | xxd -p We get this hex: d985d98fd8afd98ed8b1d990d991d8b3d98ed8a90a If we look at the first couple bytes there using a UTF-8 table (http://www.utf8-chartable.de/unicode-utf8-table.pl) d985 = ? = ARABIC LETTER MEEM d98f = ?? = ARABIC DAMMA Together, these are written like ?? However, if you add the letter "dal": d8af = ? = ARABIC LETTER DAL You'll get something like the following: ??? We'd recognize that from the "English end/Arabic start" of the string: "??????????" I had forgotten that Hebrew only has consonants in its alphabet, and it appears Arabic is the same. So that "damma" indicates a vowel sound but isn't a letter per se. I'd say it's a diacritic and this would agree: https://en.wikipedia.org/wiki/Arabic_diacritics#.E1.B8.8Cammah So the output for "Strip Nonspacing Mark" looks good in the very first case at least: Strip NonspacingMark - ?????????? => ????? Although I don't know if it makes sense semantically as I don't read Arabic. If I understand correctly, you can omit vowel sounds from written Arabic and rely purely on context for meaning? (https://en.wikipedia.org/wiki/Arabic_alphabet#Vowels) At a glance, the Strip NonspacingMark looks OK for Greek too as those diacritics appear to be there purely for pronunciation like in languages written in the Roman alphabet. (https://en.wikipedia.org/wiki/Modern_Greek#Phonology_and_orthography) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 01:59:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 00:59:52 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #10 from David Cook --- So I think I've tracked down the C code behind Text::Unaccent: https://github.com/gitpan/Text-Unaccent/blob/master/unac.c The only reference I see to "damma" is in the U+FE70...U+FEFF code point range which appears to list isolated forms which is not what we're dealing with in these examples. While I haven't reviewed the code extensively, it looks like the tables used for Text::Unaccent are lacking... If you replace the following line in Galen's script: use Text::Unaccent qw//; with use Text::Unaccent qw/unac_debug/; unac_debug($Text::Unaccent::DEBUG_HIGH); You'll get more details of how Text::Unaccent is working (or not working as it were). Here's the output I get for the Arabic: unac.c:13708: unac_data0[5] & unac_positions[0][6]: 0x0645 => untouched unac.c:13708: unac_data0[15] & unac_positions[0][16]: 0x064f => untouched unac.c:13708: unac_data34[15] & unac_positions[34][16]: 0x062f => untouched unac.c:13708: unac_data0[14] & unac_positions[0][15]: 0x064e => untouched unac.c:13708: unac_data34[17] & unac_positions[34][18]: 0x0631 => untouched unac.c:13708: unac_data0[16] & unac_positions[0][17]: 0x0650 => untouched unac.c:13708: unac_data0[17] & unac_positions[0][18]: 0x0651 => untouched unac.c:13708: unac_data34[19] & unac_positions[34][20]: 0x0633 => untouched unac.c:13708: unac_data0[14] & unac_positions[0][15]: 0x064e => untouched unac.c:13708: unac_data34[9] & unac_positions[34][10]: 0x0629 => untouched Text::Unaccent - ?????????? => ???????????????????? Strip NonspacingMark - ?????????? => ????? Here's the output I get for the Greek: unac.c:13708: unac_data21[6] & unac_positions[21][7]: 0x0386 => 0x0391 unac.c:13708: unac_data22[12] & unac_positions[22][13]: 0x03ac => 0x03b1 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[8] & unac_positions[21][9]: 0x0388 => 0x0395 unac.c:13708: unac_data22[13] & unac_positions[22][14]: 0x03ad => 0x03b5 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[9] & unac_positions[21][10]: 0x0389 => 0x0397 unac.c:13708: unac_data22[14] & unac_positions[22][15]: 0x03ae => 0x03b7 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[10] & unac_positions[21][11]: 0x038a => 0x0399 unac.c:13708: unac_data22[15] & unac_positions[22][16]: 0x03af => 0x03b9 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[12] & unac_positions[21][13]: 0x038c => 0x039f unac.c:13708: unac_data23[12] & unac_positions[23][13]: 0x03cc => 0x03bf unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[14] & unac_positions[21][15]: 0x038e => 0x03a5 unac.c:13708: unac_data23[13] & unac_positions[23][14]: 0x03cd => 0x03c5 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[15] & unac_positions[21][16]: 0x038f => 0x03a9 unac.c:13708: unac_data23[14] & unac_positions[23][15]: 0x03ce => 0x03c9 Text::Unaccent - ?? ?? ?? ?? ?? ?? ?? => ???? ???? ???? ???? ???? ???? ???? Strip NonspacingMark - ?? ?? ?? ?? ?? ?? ?? => ?? ?? ?? ?? ?? ?? ?? Interestingly we can see a reference to the Greek cpaital letter alpha with the tonos diacritic: * 0386 GREEK CAPITAL LETTER ALPHA WITH TONOS * 0391 GREEK CAPITAL LETTER ALPHA Indeed, in the output, we can see that 0x0386 was changed to 0x0391... although admittedly I don't know exactly how. It looks like a binary operation that uses a bitmask to produce a certain value... we don't need to know 100% how that mechanism is working right now... just that it works as described above. -- So in the Arabic example... everything was "untouched" and yet the output is garbled. That's certainly an encoding issue... Indeed, look at the following: dcook at koha:~/experiments> echo "??????????" | iconv -f latin1 -t utf-8 ???????????????????? That is the same output as Text::Unaccent: Text::Unaccent - ?????????? => ???????????????????? So somewhere along the line that UTF-8 string is getting double-encoded. Check this out: dcook at koha:~/experiments> echo "??????????" | iconv -f latin1 -t utf-8 | iconv -f utf-8 -t latin1 ?????????? I think the double-encoding is down to us using "binmode STDOUT, ':utf8';" (which tells Perl to output UTF-8 encoded bytes instead of Latin-1 (or some other single byte encoding it normally uses) and "use utf8" which tells Perl that the source code uses UTF-8... Removing those gets us the following: Text::Unaccent - ?t? => ete Strip NonspacingMark - ?t? => A?tA? Text::Unaccent - umla?t => umlaut Wide character in print at unaccent.pl line 47. Strip NonspacingMark - umla??t => umlaA1?4t Text::Unaccent - ????? => ????? Strip NonspacingMark - ????? => ??? ??a Text::Unaccent - ?????? => ?????? Strip NonspacingMark - ?????? => ??O1?O ? Text::Unaccent - ??? => ??? Strip NonspacingMark - ??? => a??ao?a ? Text::Unaccent - ?? ?? ?? ?? ?? ?? ?? => ?? ?? ?? ?? ?? ?? ?? Strip NonspacingMark - ?? ?? ?? ?? ?? ?? ?? => I?I? I?I? I?I? I?I I?I? I?I? I?I? Text::Unaccent - ?????????? => ?????????? Strip NonspacingMark - ?????????? => U?U?? U??U?U??3U?? At a glance, Text::Unaccent looks like it works for French, German, and Greek... but doesn't touch Hebrew, Japanese(?), or Arabic. Here's that output again with the debugging: unac.c:13708: unac_data3[10] & unac_positions[3][10]: 0x00e9 => 0x0065 unac.c:13708: unac_data0[20] & unac_positions[0][21]: 0x0074 => untouched unac.c:13708: unac_data3[10] & unac_positions[3][10]: 0x00e9 => 0x0065 Text::Unaccent - ?t? => ete Strip NonspacingMark - ?t? => A?tA? unac.c:13708: unac_data0[21] & unac_positions[0][22]: 0x0075 => untouched unac.c:13708: unac_data0[13] & unac_positions[0][14]: 0x006d => untouched unac.c:13708: unac_data0[12] & unac_positions[0][13]: 0x006c => untouched unac.c:13708: unac_data0[1] & unac_positions[0][2]: 0x0061 => untouched unac.c:13708: unac_data3[29] & unac_positions[3][29]: 0x00fc => 0x0075 unac.c:13708: unac_data0[20] & unac_positions[0][21]: 0x0074 => untouched Text::Unaccent - umla?t => umlaut Wide character in print at unaccent.pl line 47. Strip NonspacingMark - umla??t => umlaA1?4t unac.c:13708: unac_data0[2] & unac_positions[0][3]: 0x05e2 => untouched unac.c:13708: unac_data0[17] & unac_positions[0][18]: 0x05d1 => untouched unac.c:13708: unac_data0[8] & unac_positions[0][9]: 0x05e8 => untouched unac.c:13708: unac_data0[25] & unac_positions[0][26]: 0x05d9 => untouched unac.c:13708: unac_data0[10] & unac_positions[0][11]: 0x05ea => untouched Text::Unaccent - ????? => ????? Strip NonspacingMark - ????? => ??? ??a unac.c:13708: unac_data0[23] & unac_positions[0][24]: 0x05d7 => untouched unac.c:13708: unac_data0[21] & unac_positions[0][22]: 0x05d5 => untouched unac.c:13708: unac_data0[25] & unac_positions[0][26]: 0x05b9 => untouched unac.c:13708: unac_data0[28] & unac_positions[0][29]: 0x05dc => untouched unac.c:13708: unac_data0[24] & unac_positions[0][25]: 0x05b8 => untouched unac.c:13708: unac_data0[29] & unac_positions[0][30]: 0x05dd => untouched Text::Unaccent - ?????? => ?????? Strip NonspacingMark - ?????? => ??O1?O ? unac.c:13708: unac_data0[23] & unac_positions[0][24]: 0x5317 => untouched unac.c:13708: unac_data0[12] & unac_positions[0][13]: 0x4eac => untouched unac.c:13708: unac_data0[2] & unac_positions[0][3]: 0x5e02 => untouched Text::Unaccent - ??? => ??? Strip NonspacingMark - ??? => a??ao?a ? unac.c:13708: unac_data21[6] & unac_positions[21][7]: 0x0386 => 0x0391 unac.c:13708: unac_data22[12] & unac_positions[22][13]: 0x03ac => 0x03b1 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[8] & unac_positions[21][9]: 0x0388 => 0x0395 unac.c:13708: unac_data22[13] & unac_positions[22][14]: 0x03ad => 0x03b5 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[9] & unac_positions[21][10]: 0x0389 => 0x0397 unac.c:13708: unac_data22[14] & unac_positions[22][15]: 0x03ae => 0x03b7 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[10] & unac_positions[21][11]: 0x038a => 0x0399 unac.c:13708: unac_data22[15] & unac_positions[22][16]: 0x03af => 0x03b9 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[12] & unac_positions[21][13]: 0x038c => 0x039f unac.c:13708: unac_data23[12] & unac_positions[23][13]: 0x03cc => 0x03bf unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[14] & unac_positions[21][15]: 0x038e => 0x03a5 unac.c:13708: unac_data23[13] & unac_positions[23][14]: 0x03cd => 0x03c5 unac.c:13708: unac_data0[0] & unac_positions[0][1]: 0x0020 => untouched unac.c:13708: unac_data21[15] & unac_positions[21][16]: 0x038f => 0x03a9 unac.c:13708: unac_data23[14] & unac_positions[23][15]: 0x03ce => 0x03c9 Text::Unaccent - ?? ?? ?? ?? ?? ?? ?? => ?? ?? ?? ?? ?? ?? ?? Strip NonspacingMark - ?? ?? ?? ?? ?? ?? ?? => I?I? I?I? I?I? I?I I?I? I?I? I?I? unac.c:13708: unac_data0[5] & unac_positions[0][6]: 0x0645 => untouched unac.c:13708: unac_data0[15] & unac_positions[0][16]: 0x064f => untouched unac.c:13708: unac_data34[15] & unac_positions[34][16]: 0x062f => untouched unac.c:13708: unac_data0[14] & unac_positions[0][15]: 0x064e => untouched unac.c:13708: unac_data34[17] & unac_positions[34][18]: 0x0631 => untouched unac.c:13708: unac_data0[16] & unac_positions[0][17]: 0x0650 => untouched unac.c:13708: unac_data0[17] & unac_positions[0][18]: 0x0651 => untouched unac.c:13708: unac_data34[19] & unac_positions[34][20]: 0x0633 => untouched unac.c:13708: unac_data0[14] & unac_positions[0][15]: 0x064e => untouched unac.c:13708: unac_data34[9] & unac_positions[34][10]: 0x0629 => untouched Text::Unaccent - ?????????? => ?????????? Strip NonspacingMark - ?????????? => U?U?? U??U?U??3U?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 02:59:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 01:59:48 +0000 Subject: [Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Mason James --- hmm, a bit odd.. but git-bisect says this commit broke the test?! commit bc668dccd3af3fba14e04a764499b0d762c63455 Author: Tomas Cohen Arazi Date: Fri Nov 6 11:21:56 2015 -0300 Bug 15151: Avoid DB access to load C4::Members any ideas, good people? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 03:00:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 02:00:29 +0000 Subject: [Koha-bugs] [Bug 15323] ./t/Prices.t fails without a valid database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 03:50:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 02:50:44 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #11 from David Cook --- Analyzing what "use utf8" does and it's... interesting. #use utf8; #binmode STDOUT, ':utf8'; say "Hex = ".unpack("H*",$_); Hex = d985d98fd8afd98ed8b1d990d991d8b3d98ed8a9 Text::Unaccent - ?????????? => ?????????? echo "??????????" | xxd -p d985d98fd8afd98ed8b1d990d991d8b3d98ed8a90a [That last 0a byte is just a LF character (ie \n)] use utf8; #binmode STDOUT, ':utf8'; say "Hex = ".unpack("H*",$_); Hex = 454f2f4e315051334e29 Text::Unaccent - ?????????? => ???????????????????? #use utf8; binmode STDOUT, ':utf8'; say "Hex = ".unpack("H*",$_); Hex = d985d98fd8afd98ed8b1d990d991d8b3d98ed8a9 Text::Unaccent - ???????????????????? => ???????????????????? use utf8; binmode STDOUT, ':utf8'; say "Hex = ".unpack("H*",$_); Hex = 454f2f4e315051334e29 Text::Unaccent - ?????????? => ???????????????????? -- I have no idea what 454f2f4e315051334e29 is... it's not UTF-8 or Latin1. In fact, if you try to read it as either... you'll just read that EO/N1PQ3N). Ahh, I was missing this error message: Character in 'H' format wrapped in unpack at unaccent.pl line 46. Here's some more info using Devel::Peek::Dump(): PV = 0x1ba6b20 "\331\205\331\217\330\257\331\216\330\261\331\220\331\221\330\263\331\216\330\251"\0 [UTF8 "\x{645}\x{64f}\x{62f}\x{64e}\x{631}\x{650}\x{651}\x{633}\x{64e}\x{629}"] Indeed, if we look back at our UTF-8 table: http://www.utf8-chartable.de/unicode-utf8-table.pl?start=1536 0645 is the code point for ARABIC LETTER MEEM which would be encoded as d9 85. 454f2f4e315051334e29 is clearly a butchering of the internal string of Unicode codepoints "\x{645}\x{64f}\x{62f}\x{64e}\x{631}\x{650}\x{651}\x{633}\x{64e}\x{629}" where only the low-byte values of the code point is being shown. -- Ahh... I think I might have figured it out. When you use "use utf8": $_ = PV = 0xf25f60 "\331\205\331\217\330\257\331\216\330\261\331\220\331\221\330\263\331\216\330\251"\0 [UTF8 "\x{645}\x{64f}\x{62f}\x{64e}\x{631}\x{650}\x{651}\x{633}\x{64e}\x{629}"] Text::Unaccent::unac_string('UTF-8', $_) = PV = 0x2a0a0c0 "\331\205\331\217\330\257\331\216\330\261\331\220\331\221\330\263\331\216\330\251"\0 If you print out the content of "Text::Unaccent::unac_string('UTF-8', $_)" on its own, you'll get ??????????. However, if you mix $_ and $unaccented in a single concatenated string, you're going to wind up with a correct $_ but a double-encoded $unaccented. If you look at the concatenated string, you'll get a PV of: PV = 0x29028c0 "Text::Unaccent - \331\205\331\217\330\257\331\216\330\261\331\220\331\221\330\263\331\216\330\251 - \303\231\302\205\303\231\302\217\303\230\302\257\303\231\302\216\303\230\302\261\303\231\302\220\303\231\302\221\303\230\302\263\303\231\302\216\303\230\302\251 \n"\0 [UTF8 "Text::Unaccent - \x{645}\x{64f}\x{62f}\x{64e}\x{631}\x{650}\x{651}\x{633}\x{64e}\x{629} - \x{d9}\x{85}\x{d9}\x{8f}\x{d8}\x{af}\x{d9}\x{8e}\x{d8}\x{b1}\x{d9}\x{90}\x{d9}\x{91}\x{d8}\x{b3}\x{d9}\x{8e}\x{d8}\x{a9} \n"] So in that UTF8 section you have $_ represented by Unicode codepoints while the UTF-8 encoded bytes of $unaccepted have been transformed into a string of codepoints using a hexadecimal byte for each code point. If you wanted to concatenate them both in the string, you'd first have to run "$unaccented = decode('UTF-8', $unaccented)". Then your concatenated string would internally look like: PV = 0x27812a0 "Text::Unaccent - \331\205\331\217\330\257\331\216\330\261\331\220\331\221\330\263\331\216\330\251 - \331\205\331\217\330\257\331\216\330\261\331\220\331\221\330\263\331\216\330\251 \n"\0 [UTF8 "Text::Unaccent - \x{645}\x{64f}\x{62f}\x{64e}\x{631}\x{650}\x{651}\x{633}\x{64e}\x{629} - \x{645}\x{64f}\x{62f}\x{64e}\x{631}\x{650}\x{651}\x{633}\x{64e}\x{629} \n"] And that would be correct: Text::Unaccent - ?????????? - ?????????? Strip NonspacingMark - ?????????? => ????? I mean... the output still doesn't do us much good, but that explains the mangling. While we gave Text::Unaccent a Perl string with a UTF8 flag set, it took that string through to some C code using a XS interface, did a few things (depending on the scenario), and then passed back a Perl string without a UTF8 flag set, which seems to confuse Perl. If we do a utf8::upgrade($unaccented) earlier, it still creates a string with incorrect code points... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 04:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 03:33:11 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 04:49:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 03:49:49 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #12 from David Cook --- More interesting things... You can still have a Perl string with a UTF8 flag set, even when you're not using "use utf8"... My example: my $arabic = "\x{0645}"; PV = 0x190e950 "\331\205"\0 [UTF8 "\x{645}"] Interestingly, if I don't use "use utf8", and use a UTF8 encoded character in my source code, I get a string without a UTF8 flag: my $arabic_text = "?"; PV = 0x1ea92b0 "\331\205"\0 I imagine use of the \x{} construct must do a utf8::upgrade... -- In any case, if I put $arabic and $arabic_text into the same string, I get the following: my $arabic_result = "Arabic = $arabic_text = $arabic"; say $arabic_result; Arabic = ?? = ? PV = 0x29feda0 "Arabic = \303\231\302\205 = \331\205"\0 [UTF8 "Arabic = \x{d9}\x{85} = \x{645}"] However, if I try "$arabic_text = decode("UTF-8",$arabic_text")", which according to http://perldoc.perl.org/Encode.html means: $characters = decode('UTF-8', $octets), then I get the following: Arabic = ? = ? PV = 0x15efe50 "Arabic = \331\205 = \331\205"\0 [UTF8 "Arabic = \x{645} = \x{645}"] Alternatively, I could have done "$arabic = encode("UTF-8",$arabic);", which would yield this result: Arabic = ? = ? PV = 0x832210 "Arabic = \331\205 = \331\205"\0 This explains the UTF8 flag a bit: http://perldoc.perl.org/Encode.html#The-UTF8-flag So yeah... that's cool... who knew that was a thing, eh? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 04:59:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 03:59:25 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #13 from David Cook --- (In reply to Galen Charlton from comment #5) > Some conclusions: > > [1] Text::Unaccent mangles non-Latin characters outright; that's enough > reason to get rid of it. As I pointed out in my overly long comments, it doesn't appear that Text::Unaccent is actually mangling non-Latin characters. Rather, in your example, it looks like Perl doesn't correctly handle the concatenated string composed of one string with a UTF8 flag set and one string without a UTF8 flag set. It looks like Perl tries to do a utf8::upgrade() on the string without the UTF8 flag set (ie the one returned from Text::Unaccent's C code), and instead of reading it as an octet string and correctly translating into a UTF8 string of corresponding Unicode code points, it reads each octet in as a code point, which creates a completely different string for display purposes even though the underlying octets are the same. When given the octets d9 and 85 (ie the Arabic letter Meem), it creates a "UTF8 string" with the code points of "\x{d9}\x{85}" when it should create a "UTF8 string" with the code point "\x{645}". Instead of creating "\x{645}", Perl reads the octets d9 and 85 in as "\x{d9}\x{85}" This only appears to be a problem when you put the Text::Unaccent string in the same string as a Perl string with a UTF8 flag. If you were to break them into two separate lines, they'd display correctly in the terminal. Or you could use Encode::decode("UTF-8",$unaccented) to create a Perl string with a UTF8 flag with the proper code point "\x{645}"; > [2] Both Text::Unaccent::PurePerl and stripping NonspacingMark characters > are better -- they strip accents from Latin scripts, and don't mangle > non-Latin. Removing NonspacingMark characters is more aggressive; I think > we need input from Arabic, Hebrew, and Greek suers as to whether that is > acceptable -- or, alternatively, if we need a system preference, or need to > bite the bullet and package Text::Unaccent::PurePerl. I suspect that Text::Unaccent and Text::Unaccent::PurePerl are mostly the same, but that Text::Unaccent::PurePerl doesn't lose the UTF8 flag on the input string. We could avoid Text::Unaccent::PurePerl if we simply use "Encode::decode("UTF-8",$unaccented)" when using Text::Unaccent to translate the internal byte string into an internal UTF8 string. While it might not be required that we do that, doing so would probably prevent future buggy behaviour from occurring. That said, Text::Unaccent and Text::Unaccent::PurePerl don't necessarily look good enough. They miss diacritics in Arabic at least, although I think we definitely need input from Arabic, Hebrew, and CJK users regarding how stripping NonspacingMark affects those strings. My guess is that it's fine to strip the diacritics out of Arabic, but there are people much more qualified than me to answer that question on the listserv. Greek actually looks OK with Text::Unaccent if the encoding is handled. We can see that a bit more clearly with the following lines: use Text::Unaccent qw/unac_debug/; unac_debug($Text::Unaccent::DEBUG_HIGH); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 06:44:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 05:44:45 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13136=5D__No_documentation_for_Home_?= =?utf-8?b?4oC6IFRvb2xzIOKAuiBMYWJlbHMgaG9tZSDigLogTWFuYWdlIGxhYmVsIExh?= =?utf-8?q?youts?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #3 from H?ctor Eduardo Castro Avalos --- (In reply to Nicole C. Engard from comment #2) > Created attachment 45470 [details] [review] > [BUG 13136] Add missing help file for label-manage.pl > > This patch adds in a help file for the new label-manage page. > > To test: > > * visit label creator > * click manage and choose an option > * click 'help' and confirm the file loads > * repeat for all options under manage I have a problem when attaching the patch with git bz UnicodeEncodeError: 'ascii' codec can't encode character u'\u203a' in position 54: ordinal not in range(128) I don't know if only is my problem, please confirm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:06:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:06:21 +0000 Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21192|0 |1 is obsolete| | --- Comment #29 from Alex Arnaud --- Created attachment 45474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45474&action=edit BUG 9163 - Cataloguing validation workflow Added 3 systems preferences instead of one: - 1 to use/not use the validation workflow - 1 to set the validation framework code - 1 to set the users with access to the validation framework addbook.pl and addbiblio.pl show the frameworkcodes in the drop list according to settings: - if validation off shows all - if validation on and framework code is different than validation framework code, shows the framework code - if validation on and framework code equal to validation framework code and the user have permissions, shows the framework code - if validation on and framework code equal to validation framework code and the user doesn't have permissions, don't shows the framework code addbiblio.pl also changed to: - prevent any user to use the validation framework (if validation on) when putting the code in the browser URL - if validation on always set suppress = 1 in framework different than the validating one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:06:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:06:29 +0000 Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21194|0 |1 is obsolete| | --- Comment #30 from Alex Arnaud --- Created attachment 45475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45475&action=edit BUG 9163 - Patch2 use user permissions instead of systempreferences New user permission added to access the validation framework, under edit catalogue section. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:07:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:07:00 +0000 Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|Patch doesn't apply |Needs Signoff --- Comment #31 from Alex Arnaud --- Patch rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:36:44 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #69 from Jonathan Druart --- Kyle, For bug 8007, I have first used HTML::HTMLDoc too, but finally changed for PDF::FromHTML. Indeed HTML::HTMLDoc is buggy, see bug 8007 comment 64. Have a loot at Koha::Borrower::Discharge::generate_as_pdf for an example on how to use it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:41:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:41:32 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36055|0 |1 is obsolete| | --- Comment #46 from Alex Arnaud --- Created attachment 45476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45476&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:41:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:41:43 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36056|0 |1 is obsolete| | --- Comment #47 from Alex Arnaud --- Created attachment 45477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45477&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:41:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:41:53 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36057|0 |1 is obsolete| | --- Comment #48 from Alex Arnaud --- Created attachment 45478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45478&action=edit Bug 12802: FIX use the first valid email address if noemail is needed Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:42:01 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36058|0 |1 is obsolete| | --- Comment #49 from Alex Arnaud --- Created attachment 45479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45479&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:42:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:42:10 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36059|0 |1 is obsolete| | --- Comment #50 from Alex Arnaud --- Created attachment 45480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45480&action=edit Bug 12802: Fix QA script issues FAIL C4/Reserves.pm FAIL pod Spurious =cut command in file C4/Reserves.pm Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:42:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:42:17 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39762|0 |1 is obsolete| | --- Comment #51 from Alex Arnaud --- Created attachment 45481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45481&action=edit Bug 12802: Fix tests in Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:42:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:42:24 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40167|0 |1 is obsolete| | --- Comment #52 from Alex Arnaud --- Created attachment 45482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45482&action=edit Bug 12802: Fix tests in Reserves.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 10:42:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 09:42:51 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:17:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:17:05 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 --- Comment #4 from Jonathan Druart --- Created attachment 45484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45484&action=edit Bug 15319: Move marcPreview modal div to avoid duplication Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:17:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:17:01 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45462|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45483&action=edit Bug 15319 - Use Bootstrap modal for MARC preview when performing batch record modifications In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the batch record modification page so that the "Preview MARC" link triggers a preview in a Bootstrap modal. To test: 1. Apply the patch and navigate to Tools -> Batch record modification. 2. Submit multiple biblionumbers for batch modification. 3. In the results list, click the "Preview MARC" link for multiple results and confirm that the correct data is shown each time. 4. Use the "Modify record using the following template" menu to change the modification template. 5. Confirm that the "Preview MARC" links still work and show data correctly modified by your newly chosen template. 6. Repeat steps 2-5 with authority record numbers. Signed-off-by: Fr?d?ric Demians Works as described. No regression. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:18:02 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Owen, Could you have a look at the second patch please? I have moved the marcPreview div to avoid duplication in biblios and authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:18:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:18:08 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:27:54 +0000 Subject: [Koha-bugs] [Bug 15327] Minor tweaks to Bootstrap modal handling on Staged MARC management page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:27:57 +0000 Subject: [Koha-bugs] [Bug 15327] Minor tweaks to Bootstrap modal handling on Staged MARC management page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45472|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45485&action=edit Bug 15327: Minor tweaks to Bootstrap modal handling on Staged MARC management page This patch makes a couple of minor corrections to the template for staged MARC management. The MARC preview is now formatted using the "html" option, and some obsolete Greybox-related code has been removed. To test: 1. Apply the patch and go to Tools -> Staged MARC management. 2. Click any staged MARC file containing multiple records. 3. Click the title in the "Citation" column and confirm that a Bootstrap modal is triggered showing the correct data. Signed-off-by: Hector Castro Modal looks much better. Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:35:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:35:01 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45394|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 45486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45486&action=edit Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two ambiguous words 'to' and a sentence splitted up by html tags, leading to weird translations. Example in German: "Sie k?nnen keine Exemplare aus itemtype transferieren BK f?r: Airfield" To test: - Apply patch - Set up transfer policies for item types and collection codes in Home > Administration > Set library checkin and transfer policy Make sure that you have rules that deny and others that allow transfers - Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce' - Set 'BranchTransferLimitTypes' to 'item type' - Go to Home > Circulation > Transfers - Transfer an item that is allowed for item type - Verify that the table of transferred items displays information about Item type, Collection code and Destination - Transfer an item that is not allowed for the item type - Verify that the information about not allowing the transfer displays properly and is meaningfull - Set 'BranchTransferLimitTypes' to 'collection code' - Repeat the transfer steps above for allowed / not allowed collection code (Amended to add ids to table and 8 columns, see comment #2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:37:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:37:41 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 --- Comment #4 from Marc V?ron --- Fr?d?ric, I added ids to the th and td tags of the 8 columns only, please let me know if the table itself needs an id as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:52:55 +0000 Subject: [Koha-bugs] [Bug 15314] Use Bootstrap modal for cataloging merge MARC preview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Owen, Shouldn't we apply the same change as what you suggest on bug 15327? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:53:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:53:50 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13136=5D__No_documentation_for_Home_?= =?utf-8?b?4oC6IFRvb2xzIOKAuiBMYWJlbHMgaG9tZSDigLogTWFuYWdlIGxhYmVsIExh?= =?utf-8?q?youts?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 --- Comment #4 from Marc V?ron --- QA tools complain about tab chars in prog/en/modules/help/labels/label-manage.tt forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 70) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 65) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 69) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:54:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:54:37 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 11:56:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 10:56:46 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #87 from Jonathan Druart --- Please guys, we need a quick push of this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 12:04:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 11:04:56 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13136=5D__No_documentation_for_Home_?= =?utf-8?b?4oC6IFRvb2xzIOKAuiBMYWJlbHMgaG9tZSDigLogTWFuYWdlIGxhYmVsIExh?= =?utf-8?q?youts?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 --- Comment #5 from Marc V?ron --- (In reply to H?ctor Eduardo Castro Avalos from comment #3) (...) > > I have a problem when attaching the patch with git bz > > UnicodeEncodeError: 'ascii' codec can't encode character u'\u203a' in > position 54: ordinal not in range(128) > > I don't know if only is my problem, please confirm The character \u203a' is a quote character that looks like '>' In earlier commits, I produced such errors by copy-pasting the breadcrumbs from the staff client (like Home > Tools > Label creator) to the commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 12:13:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 11:13:52 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 --- Comment #5 from Fr?d?ric Demians --- (In reply to Marc V?ron from comment #4) > Fr?d?ric, I added ids to the th and td tags of the 8 columns only, please > let me know if the table itself needs an id as well. No, its perfect. Just one important detail: it is necessary to have 'class' argument for 'td' tag, and 'id' for 'th'. I can do it if you want. This way 'ccode' column could be hidden with that js: $('#circ_branchtransfers').ready(function() { $('.ccode').hide(); $('#ccode').hide(); }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 12:16:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 11:16:37 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #60 from Andreas Hedstr?m Mace --- (In reply to David Cook from comment #52) > (In reply to Leif Andersson from comment #51) > > (In reply to David Cook from comment #50) > > > Honestly though, I would ask that people think further about the frequency > > > of harvests. Is every 2-3 seconds really necessary? Do we really need it to > > > be able to perform that quickly? > > > > > > > Well, the use case envisioned by Stockholm UL would in practice ideally > > involve fetching ONE record every 10 minutes or so! > > The cataloger will be creating/modifying a bib record and a mfhd record in > > our union catalog. > > Next, the cataloger will turn to our local catalog, Koha, expecting to find > > this record already imported. > > If there is a way for the harvester to decide which ONE record to > > get...maybe even with some intervention by the cataloger...? > > So when this ONE record is asked for, we want it to be a quick process > > getting it from the source and into Koha. > > To confuse things a little, I will have to contradict my colleague at Stockholm Univ. Library a little buy saying that I don't see why we would want to replicate functionality already offered by LIBRIS (the Swedish union catalogue, for those lurking this thread) - where you can download records individually and then run batch exports at night - rather than creating something better/faster. For me it is preferable to have the catalogue as up-to-date as possible, since LIBRIS will be the "master" (or source of truth as David calls it) for our data. I would rather want the harvester to run every ten seconds or so (or however fast we can get it), to get all updates made to "our" records. The only drawback I can see from such an approach would be an increased load on the servers, which is not a trivial thing of course, but something that should be manageable. (LIBRIS might have a bigger problem if a lot of Swedish libraries start using OAI-PMH harvesting with this approach, but they have themselves recommended this use and will have to handle it accordingly.) Also, I would prefer if the process of harvesting records can be as automated as possible, not involving any extra steps on the catalogers part. We want to make their cataloging easier - not more complex! > So you're saying that the union catalogue will only have updates about once > every 10 minutes? Or that the cataloguer will only be accessing a record in > the union catalogue and Koha once every 10 minutes? Records that we handle, i.e. adding/updating either the bibliographic record or the holdings record (or both), is probably only done around every 5-10 min as Leif say. But changes to the bibliographic records, for which we have holdings attached, made by other Swedish libraries is probably much more often. I will try to look at this in the upcoming days, manually harvesting at close intervals (I'm thinking about both trying a 3 second and 10 second approach) to see how many records are downloaded with each harvest. > I am including a mechanism for fetching "one" record, so long as the user > knows the OAI-PMH identifier they're after. They'll be able to add a task > for that. Perhaps a future development could be done to provide an interface > in the cataloguing module for adding/updating a single record. In place of > that interface, they'll be able to add a task in the same area as the other > tasks in order to get the one record... > > > Then nightly more massive harvests could be performed to catch up with other > > modifications to the union catalog. > > > > Those nightly harvests would certainly be possible with the current design. As I mentioned above, ideally I would want the harvester to run repeatedly, on short intervals. But other libraries whom are interested in using the harvester might have other ideas on which set-up would be best for them. So having the flexibility of running either way (individual harvest+night more massive harvestes or repeated harvest every 10 seconds or so) would be wonderful! I think Davids idea for a plug-in approach, together with the harvest tasks, will work well here! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 12:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 11:19:18 +0000 Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/page for terms and conditions of use in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14980 --- Comment #1 from Marc V?ron --- Maybe something for an enhanced (CMS-ised) News system? - I add "Bug 14980 - Add a page showing one news" as related. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 12:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 11:19:18 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13376 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 12:28:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 11:28:38 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45486|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 45487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45487&action=edit Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two ambiguous words 'to' and a sentence splitted up by html tags, leading to weird translations. Example in German: "Sie k?nnen keine Exemplare aus itemtype transferieren BK f?r: Airfield" To test: - Apply patch - Set up transfer policies for item types and collection codes in Home > Administration > Set library checkin and transfer policy Make sure that you have rules that deny and others that allow transfers - Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce' - Set 'BranchTransferLimitTypes' to 'item type' - Go to Home > Circulation > Transfers - Transfer an item that is allowed for item type - Verify that the table of transferred items displays information about Item type, Collection code and Destination - Transfer an item that is not allowed for the item type - Verify that the information about not allowing the transfer displays properly and is meaningfull - Set 'BranchTransferLimitTypes' to 'collection code' - Repeat the transfer steps above for allowed / not allowed collection code (Amended to add ids to table and 8 columns, see comment #2) (Amended for comment #5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 13:03:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 12:03:26 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 13:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 12:03:29 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45487|0 |1 is obsolete| | --- Comment #7 from Fr?d?ric Demians --- Created attachment 45488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45488&action=edit Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two ambiguous words 'to' and a sentence splitted up by html tags, leading to weird translations. Example in German: "Sie k?nnen keine Exemplare aus itemtype transferieren BK f?r: Airfield" To test: - Apply patch - Set up transfer policies for item types and collection codes in Home > Administration > Set library checkin and transfer policy Make sure that you have rules that deny and others that allow transfers - Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce' - Set 'BranchTransferLimitTypes' to 'item type' - Go to Home > Circulation > Transfers - Transfer an item that is allowed for item type - Verify that the table of transferred items displays information about Item type, Collection code and Destination - Transfer an item that is not allowed for the item type - Verify that the information about not allowing the transfer displays properly and is meaningfull - Set 'BranchTransferLimitTypes' to 'collection code' - Repeat the transfer steps above for allowed / not allowed collection code (Amended to add ids to table and 8 columns, see comment #2) (Amended for comment #5) Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 13:15:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 12:15:38 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- (In reply to Blou from comment #2) > This was done differently (fixed) by Kyle recently in master. > > The issue is just with 3.20, then. I suppose this makes this little patch > useless. How was it fixed in master? Couldn't it be backported? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 13:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 12:22:49 +0000 Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 13:22:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 12:22:52 +0000 Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42135|0 |1 is obsolete| | --- Comment #6 from Fr?d?ric Demians --- Created attachment 45489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45489&action=edit Bug 14363: OAI-PMH: Handle records without marcxml Test plan: 1/ git checkout 3.18.x 2/ GET http://OPAC/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml 3/ Take the first biblionumber from the results ($biblionumber) 4/ mysql> update biblioitems set marcxml=null where biblionumber=$biblionumber 5/ Repeat step 2 => XML error 6/ Apply patch 7/ Repeat step 2 => no errors Signed-off-by: Fr?d?ric Demians Works on 3.20.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 13:34:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 12:34:59 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 13:35:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 12:35:02 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45398|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 45490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45490&action=edit Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084 Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 13:40:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 12:40:22 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #1) > Confirm that the admin/categorie.pl url still works (you need to apply > the change to the apache config before). I don't understand why an Apache rewrite rule is needed, and why it should be required that admin/categorie.pl continues to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 13:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 12:54:32 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- (In reply to Mason James from comment #0) > looking that the code its obvious that the intended behavior is to not > display the items, yet still allow the items to be edited Fridolin patch restores the above, ie the items are not displayed when there are more than MaxItemsForBatch items, but editing them globally is possible. The question may be that MaxItemsForBatch syspref states: Process up to MaxItemsForBatch in a single modification or deletion batch. It seems that the wording is not exactly true. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:01:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:01:25 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45484|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 45491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45491&action=edit [SIGNED-OFF] Bug 15319: Move marcPreview modal div to avoid duplication Signed-off-by: Jonathan Druart Signed-off-by: Owen Leonard Good catch Jonathan, thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:01:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:01:23 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:04:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:04:08 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 --- Comment #6 from Blou --- I tried it, but it didn't apply. Before that patch (13853), there are at least two others that modify the structure of svc/holds. So maybe it would be the right solution. But it would certainly require more work, if it's only to patch on an older release. I know what we did locally. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:11:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:11:03 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Magnus Enger --- The patch uses this: C4::Context->config('installdir') There is no trace of installdir in current Koha. According to Joubu on IRC this config variable was introduced by the Solr work and later removed. Comments 6 and 7 also need to be addressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:16:28 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #14 from Galen Charlton --- (In reply to David Cook from comment #13) > As I pointed out in my overly long comments, it doesn't appear that > Text::Unaccent is actually mangling non-Latin characters. > > Rather, in your example, it looks like Perl doesn't correctly handle the > concatenated string composed of one string with a UTF8 flag set and one > string without a UTF8 flag set. Other way around: Text::Unaccent is not, as it would be much preferable, emitting Perl Unicode strings; rather, it is emitting octet-sequences. A good pattern is aim for is using *only* Unicode strings within core code, and relegating use of Encode and friends to input and output; Text::Unaccent would get in the way of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:17:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:17:01 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:17:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:17:03 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45352|0 |1 is obsolete| | --- Comment #11 from Fr?d?ric Demians --- Created attachment 45492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45492&action=edit Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations Title and description are updated separately, in case that the library has changed one of them when editing the slip. To test: - Verify that you have a letter named 'Reserve Slip' in your database - Run the database update - Verify the slip has been renamed correctly Signed-off-by: Fr?d?ric Demians Job done on a Koha English version. It won't hurt other langages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:17:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:17:44 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Jonathan Druart --- Could you give information about the holidays? How many entries do you have in the special_holidays and repeatable_holidays tables? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:19:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:19:49 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 --- Comment #7 from Fr?d?ric Demians --- (In reply to Blou from comment #6) > I tried it, but it didn't apply. Before that patch (13853), there are at > least two others that modify the structure of svc/holds. Thanks for the explanation. Since #13853 is an enhancement, it mustn't be backported, and so your 3.20 & 3.18 patch is valid, imho. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:24:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:24:01 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 --- Comment #3 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #2) > (In reply to Jonathan Druart from comment #1) > > > Confirm that the admin/categorie.pl url still works (you need to apply > > the change to the apache config before). > > I don't understand why an Apache rewrite rule is needed, and why it should > be required that admin/categorie.pl continues to work. To avoid 404 using old links (from the browser history for instance). But indeed, it could be removed if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:24:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:24:05 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:24:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:24:07 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44840|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 45493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45493&action=edit Bug 14846 - Items with no holdingbranch causes svc/holds to crash When trying to display the holds for a user, if an item has no holdingbranch, it causes the svc/holds service to crash and the display to freeze. Tentative steps to reproduce on any DB: 1) put 1 or more items on hold for a given user. 2) go into the database and set the item.holdingbranch to NULL 3) In the user's page, in checkouts (circulation.pl), click the tab that should be written 1 Hold(s) 4) It will be "Processing" indefinitely. The cause is the svc/holds code that crashes. The fix will validate that there's an holdingbranch before proceding with the code. Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:25:30 +0000 Subject: [Koha-bugs] [Bug 15319] Use Bootstrap modal for MARC preview when performing batch record modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:35:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:35:40 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 --- Comment #4 from Fr?d?ric Demians --- > To avoid 404 using old links (from the browser history for instance). > But indeed, it could be removed if needed. I would feel more comfortable signing this patch without the rewrite rule. Just because Koha code has already its load of idiosyncrasies whose reasons are lost in immemorial time... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:57:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:57:08 +0000 Subject: [Koha-bugs] [Bug 15329] New: Show budget in addition to fund for late orders in acquisition Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 Bug ID: 15329 Summary: Show budget in addition to fund for late orders in acquisition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The late orders table in acquisitions shows the fund for an order line, but not the budget. It would be nice if both would be shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 14:58:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 13:58:11 +0000 Subject: [Koha-bugs] [Bug 15330] New: Allow to search for late orders by budget and fund Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15330 Bug ID: 15330 Summary: Allow to search for late orders by budget and fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if the table for late orders in acquisition also allowed searching by budget and fund. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 15:22:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 14:22:03 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45308|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 45494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45494&action=edit Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Confirm that the admin/categorie.pl url still works (you need to apply the change to the apache config before). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 15:22:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 14:22:23 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 --- Comment #6 from Jonathan Druart --- Here it is! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 15:33:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 14:33:57 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 15:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 14:33:59 +0000 Subject: [Koha-bugs] [Bug 15099] Fix file name: categorie.pl should be either category.pl or categories.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15099 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45494|0 |1 is obsolete| | --- Comment #7 from Fr?d?ric Demians --- Created attachment 45495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45495&action=edit Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Signed-off-by: Fr?d?ric Demians No reference to categorie.pl anywhere in the code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 15:39:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 14:39:41 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.20 |master --- Comment #9 from Jonathan Druart --- The bug exists on master, and the patch fixes the described issue. Could you please explain how you can have a holdingbranch value set to NULL? -- You are receiving this mail because: You are watching all bug changes. From irfan.itscholar at gmail.com Tue Dec 8 15:46:37 2015 From: irfan.itscholar at gmail.com (Muhammad Irfan Awan) Date: Tue, 8 Dec 2015 19:46:37 +0500 Subject: [Koha-bugs] Import record file Message-ID: How i import all my data to koha.In Detailed please Muhammad Irfan -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:13:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:13:50 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:13:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:13:53 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45452|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 45496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45496&action=edit Bug 15324: Do not display 'Waiting holds:" if no holds are waiting Test plan: - Make sure that you have a patron A with waiting holds and a patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B => Without this patch "Waiting holds:" is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:14:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:14:20 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron at veron.ch |jonathan.druart at bugs.koha-c | |ommunity.org Severity|minor |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Marc, this is the way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:15:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:15:01 +0000 Subject: [Koha-bugs] [Bug 13851] Replace waiting holds logic in circulation.pl with Koha Objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15324 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:15:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:15:01 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13851 --- Comment #5 from Jonathan Druart --- Introduced by bug 13851. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851 [Bug 13851] Replace waiting holds logic in circulation.pl with Koha Objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:17:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:17:48 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 --- Comment #8 from Jonathan Druart --- Comment on attachment 45488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45488 Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence Review of attachment 45488: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15301&attachment=45488) ----------------------------------------------------------------- ::: circ/branchtransfers.pl @@ +203,4 @@ > my ( $tbr, $typecode ) = split( /::/, $messages->{'NotAllowed'} ); > $err{tbr} = $branches->{ $tbr }->{'branchname'}; > $err{code} = $typecode; > + $err{codeType} = C4::Context->preference("BranchTransferLimitsType"); Retrieve it from the template using Koha.Preference ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt @@ +175,4 @@ > > > > + Why do you id an id here? title, author, ccode, etc. are too much generic. A class name should be enough (th.title/td.title). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:17:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:17:54 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:19:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:19:47 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |oleonard at myacpl.org --- Comment #23 from Jonathan Druart --- Owen, could you have a look at this one please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:21:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:21:57 +0000 Subject: [Koha-bugs] [Bug 15325] rebuild_zebra.pl table option (-t) doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45459|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 45497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45497&action=edit Bug 15325: Fix --table option of rebuild_zebra.pl Option's value given on command line was never used and 'biblioitems' was used instead. Test plan: 1. git checkout master 2. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42" 3. You should see errors printed on screen about an unknown column 4. Apply patch 5. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42" 6. No errors \o/ Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:21:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:21:54 +0000 Subject: [Koha-bugs] [Bug 15325] rebuild_zebra.pl table option (-t) doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:22:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:22:36 +0000 Subject: [Koha-bugs] [Bug 15325] rebuild_zebra.pl table option (-t) doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15325 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Erk, sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:34:07 +0000 Subject: [Koha-bugs] [Bug 14324] "Add Child" button missing on moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14324 --- Comment #13 from Marc V?ron --- Created attachment 45498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45498&action=edit Bug 15324: Do not display 'Waiting holds:" if no holds are waiting Test plan: - Make sure that you have a patron A with waiting holds and a patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B => Without this patch "Waiting holds:" is displayed Sign-off on Jonathan's patch Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:34:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:34:53 +0000 Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:34:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:34:57 +0000 Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45489|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 45499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45499&action=edit Bug 14363: OAI-PMH: Handle records without marcxml Test plan: 1/ git checkout 3.18.x 2/ GET http://OPAC/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml 3/ Take the first biblionumber from the results ($biblionumber) 4/ mysql> update biblioitems set marcxml=null where biblionumber=$biblionumber 5/ Repeat step 2 => XML error 6/ Apply patch 7/ Repeat step 2 => no errors Signed-off-by: Fr?d?ric Demians Works on 3.20.x Signed-off-by: Jonathan Druart Fix works for 3.18.x and 3.20.x 3.22 is not impacted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:37:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:37:14 +0000 Subject: [Koha-bugs] [Bug 14324] "Add Child" button missing on moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14324 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #45498|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Comment on attachment 45498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45498 Bug 15324: Do not display 'Waiting holds:" if no holds are waiting Sorry, wrong bug number... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:37:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:37:51 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45496|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 45500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45500&action=edit Bug 15324: Do not display 'Waiting holds:" if no holds are waiting Test plan: - Make sure that you have a patron A with waiting holds and a patron B without waiting holds - Go to the checkout page for patron A (Home > Circulation > Checkouts > ...) - At the right, there is a title "Waiting holds:" and a list of holds waiting - Go to the checkout page for patron B => Without this patch "Waiting holds:" is displayed Sign-off on Jonathan's patch Signed-off-by: Marc V?ron http://bugs.koha-community.org/show_bug.cgi?id=14324 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:38:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:38:18 +0000 Subject: [Koha-bugs] [Bug 15324] Checkout page: Hide title "Waiting holds:" for patrons without waiting holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15324 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:47:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:47:35 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:47:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:47:38 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45456|0 |1 is obsolete| | Attachment #45457|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 45501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45501&action=edit Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -Save in Comma separated text, Tab seprated text, and Open Document. -Verify in the three options the file exported is Ok Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:47:42 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 --- Comment #11 from Jonathan Druart --- Created attachment 45502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45502&action=edit Bug 15290: SQL reports headers encoding problem To test: - Create an SQL report with column names containing UTF characters - Run the report => FAIL: The column names are double encoded - Export the report => FAIL: The column names are double encoded in the exported file - Apply the patch - Re-run the report (reload works) => SUCCESS: Encoding correct - Export the report => SUCCESS: Encoding correct - Sign off :-D Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:50:22 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15290 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:50:22 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 --- Comment #12 from Jonathan Druart --- Linked to bug 11944. Must be backported to 3.22.x and 3.20.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 16:54:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 15:54:36 +0000 Subject: [Koha-bugs] [Bug 15257] authority records imported via z39.50 don't get authid in the 001 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15257 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:02:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:02:55 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:02:58 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45119|0 |1 is obsolete| | Attachment #45492|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 45503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45503&action=edit Bug 8085: Rename 'Reserve slip' to 'Hold slip' This patch changes all occurrences of 'Reserve slip' to 'Hold slip' in the sample notices files and in one of the system preferences. To test: - Make sure the sample_notices.sql are correctly changed. - Verify the description of the SlipCSS system preference has been changed correctly. Checked the working in system preferences and re-loaded notices from the updated English sample notices SQL. Changes look correct. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:03:05 +0000 Subject: [Koha-bugs] [Bug 8085] Rename 'Reserve slip' to 'Hold slip' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8085 --- Comment #13 from Jonathan Druart --- Created attachment 45504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45504&action=edit Bug 8085: Follow-up: Update to 'Hold Slip' for existing installations Title and description are updated separately, in case that the library has changed one of them when editing the slip. To test: - Verify that you have a letter named 'Reserve Slip' in your database - Run the database update - Verify the slip has been renamed correctly Signed-off-by: Fr?d?ric Demians Job done on a Koha English version. It won't hurt other langages Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:06:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:06:19 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:06:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:06:22 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45490|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 45505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45505&action=edit Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084 Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:14:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:14:56 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 --- Comment #9 from Marc V?ron --- Created attachment 45506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45506&action=edit Bug 15301: (followup) Translatability: branchtransfers.tt Followup for comment #8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:15:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:15:21 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:31:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:31:14 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:31:17 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45488|0 |1 is obsolete| | Attachment #45506|0 |1 is obsolete| | --- Comment #10 from Fr?d?ric Demians --- Created attachment 45507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45507&action=edit Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two ambiguous words 'to' and a sentence splitted up by html tags, leading to weird translations. Example in German: "Sie k?nnen keine Exemplare aus itemtype transferieren BK f?r: Airfield" To test: - Apply patch - Set up transfer policies for item types and collection codes in Home > Administration > Set library checkin and transfer policy Make sure that you have rules that deny and others that allow transfers - Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce' - Set 'BranchTransferLimitTypes' to 'item type' - Go to Home > Circulation > Transfers - Transfer an item that is allowed for item type - Verify that the table of transferred items displays information about Item type, Collection code and Destination - Transfer an item that is not allowed for the item type - Verify that the information about not allowing the transfer displays properly and is meaningfull - Set 'BranchTransferLimitTypes' to 'collection code' - Repeat the transfer steps above for allowed / not allowed collection code (Amended to add ids to table and 8 columns, see comment #2) (Amended for comment #5) Followup for comment #8 Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:32:25 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 --- Comment #11 from Fr?d?ric Demians --- Marc, I've merged your follow-up with the initial patch for readability purpose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:48:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:48:02 +0000 Subject: [Koha-bugs] [Bug 15331] New: Sort order breaks at offset=1000 (both OPAC and Intranet) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 Bug ID: 15331 Summary: Sort order breaks at offset=1000 (both OPAC and Intranet) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To re-create: 1) Go to the advanced search page, in either Staff Client or OPAC. 2) Run a search which will return many thousands of results, sort by A-Z 3) Go to the page prior to offset=1000 (i.e. page 50 if you have 20 results/page or 40 if you have 25 results/page). This page will be properly sorted alphabetically. 5) Go to the next page. This will *not* be sorted alphabetically. Example: http://catalog.bywatersolutions.com/cgi-bin/koha/opac-search.pl?&limit=mc-itype%2Cphr%3ABOOK&offset=980&sort_by=title_az The results are Amazing armored animals / Amazing bats / Amazing birds / The amazing bone / The amazing book of bird records : the largest, the smallest, the fastest, and many more! / Amazing buildings / Amazing buildings / Amazing dinosaur facts / Amazing flying machines / Amazing grace / Amazing grace / The amazing impossible Erie Canal / Amazing Leonardo da Vinci inventions you can build yourself : learn some hands-on history! / The amazing life of Benjamin Franklin / The amazing life of birds : (the twenty-day puberty journal of Duane Homer Leech) / An amazing machine / Amazing magic tricks : apprentice level / Amazing magic tricks : master level / Amazing mammals / The Amazing Maurice and his educated rodents / The next titles in the catalog should be Amazing mazes : mind bending mazes for ages 6-60 / The amazing Mrs. Pollifax The amazing odorous adventures of Stinky Dog / Instead, we get http://catalog.bywatersolutions.com/cgi-bin/koha/opac-search.pl?&limit=mc-itype%2Cphr%3ABOOK&offset=1000&sort_by=title_az The history of Herodotus Thucydides. Hippocratic writings. The day after Roswell / The demon-haunted world : science as a candle in the dark / The UFO phenomenon / Champ, beyond the legend (updated edition) / Area 51 : the dreamland chronicles / UFO crash at Roswell : the genesis of a modern myth / Chaos : making a new science / The black swan : the impact of the highly improbable / PC annoyances : how to fix the most annoying things about your personal computer / PC help desk in a book : the do-it- yourself guide to PC troubleshooting and repair / The little Mac book / Where wizards stay up late : the origins of the Internet / Web design tools and techniques / Degunking your email, spam, and viruses / IPhone and iPad apps marketing : secrets to selling your iPhone and iPad apps / Office 2007 all-in-one desk reference for dummies / Windows 95 secrets / -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 17:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 16:57:46 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 --- Comment #12 from Marc V?ron --- (In reply to Fr?d?ric Demians from comment #11) > Marc, I've merged your follow-up with the initial patch for readability > purpose. That's perfect, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 18:09:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 17:09:08 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #19 from Marc V?ron --- Tested, still applies. @Bernardo (comment #15): Yes, it is CAN_user_parameters_parameters_remaining_permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 18:22:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 17:22:10 +0000 Subject: [Koha-bugs] [Bug 15331] Sort order breaks at offset=1000 (both OPAC and Intranet) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7041 CC| |frederic at tamil.fr --- Comment #1 from Fr?d?ric Demians --- Take a look at bug 7041 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7041 [Bug 7041] Sort >1000 search results with sortmax parameter in zebra config file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 18:22:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 17:22:10 +0000 Subject: [Koha-bugs] [Bug 7041] Sort >1000 search results with sortmax parameter in zebra config file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7041 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15331 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 [Bug 15331] Sort order breaks at offset=1000 (both OPAC and Intranet) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 18:36:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 17:36:19 +0000 Subject: [Koha-bugs] [Bug 14609] Warning "Hold found (item is already waiting)" only appears at holding branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14609 NancyK. changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkeener at washoecounty.us --- Comment #1 from NancyK. --- This has happened to us twice this year. A popular item with many holds gets put back on the regular shelf because it failed to indicate it was on hold. The patron forgot to check it out and it got returned to a different branch. I reported a bug similar to this in 2012 when we were first on Koha. The problem was fixed, but now it's back. I think the original bug was about the hold losing focus. NancyK. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 18:56:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 17:56:33 +0000 Subject: [Koha-bugs] [Bug 15332] New: ModMember not interpreting dates (Batch patron modification) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Bug ID: 15332 Summary: ModMember not interpreting dates (Batch patron modification) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org ModMember is not correctly interpreting dates if not passed in in ISO format. To see the issue: Go to Tools->Batch patron modification Enter some cardnumbers update any date field for the patrons Result is all null in that column The dates are being passed directly to ModMember without reformatting but there is an issue with DBIx::Class::ResultSet update where by dates are not processed/deflated http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/ResultSet.pm#update I don't know whether the correct path here is to fix the call in Modmember, or to make modborrowers.pl pass the dates in a better format Marking as critical since data can be lost -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:00:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:00:04 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44269|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 45508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45508&action=edit Bug 15096: Export today's checked in barcodes: Display warning if reading history is set to "never" If a patron's privacy settings are set to "Never" for keeping a reading history, "Export today's checked in barcodes" returns an empty file. This patch skips the export if such privacy rule is set and dsiplays a message. To test: - Apply patch - Search for a user who has privacy rules set to never keeping a circulation history - Check out / check in in some items - On users detail page, go to More->Export today's checked in barcodes - Verify that a message appears about user's privacy settings (in same window) - Click left tab "Circulation history" - Verify that the same message appearsar - Verify the same with the other conditions that prevent the display of the user's circulation history: - Syspref 'intranetreadinghistory' is 'Don't allow' - Patron is 'Anonymous patron' (syspref 'Anonymous patron') - Search for a user who allows circulation history - repeat steps above, verify that circulation history appears (if allowed by syspref 'intranetreadinghistory' and that today's checkouts are exported. (Amended for comment #3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:10:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:10:54 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #16 from Marc V?ron --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:18:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:18:11 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #2 from Martin Renvoize --- We have a system that's really struggling with the same issue. 262 rows in special_holidays 9 rows in repeatable_holidays We also have a system where the preferences are set to ignore the holidays and this runs much more quickly (though still isn't super quick). It has 921 special_holidays and 307 repeatable_holidays. Hope that helps a little. I'm happy to run a profile at the next run of the scripts unless someone else beats me to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:23:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:23:45 +0000 Subject: [Koha-bugs] [Bug 14015] Entering 0 (zero) as barcode on checkout page leads to software error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Entering 0 (zero) as |Entering 0 (zero) as |barcode reloads checkout |barcode on checkout page |page without patron |leads to software error |information | --- Comment #1 from Marc V?ron --- New behaviour on current master: - Go to Home > Circulation > Checkouts > [a patron] - Enter 0 (zero) in barcode field and hit Enter Result: Can't use string ("1") as a HASH ref while "strict refs" in use at /usr/share/kohaclone/circ/circulation.pl line 473 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:26:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:26:02 +0000 Subject: [Koha-bugs] [Bug 14015] Entering 0 (zero) as barcode on checkout page leads to software error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:32:31 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #3 from Mason James --- (In reply to Katrin Fischer from comment #1) > Comment on attachment 45410 [details] > KOHA_SIP2_Checkout > > It looks like this issue is caused by the fact that the items.onloan is not > updated correctly with the due date, while the entry in the issues table is > correct. hi Katrin, did you confirm this bug, yourself? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:37:50 +0000 Subject: [Koha-bugs] [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #68 from Marc V?ron --- *** Bug 14064 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:37:50 +0000 Subject: [Koha-bugs] [Bug 14064] Implement language overlay for item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14064 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Marc V?ron --- *** This bug has been marked as a duplicate of bug 14100 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:40:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:40:49 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to a saved report output screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 --- Comment #1 from Magnus Enger --- *** Bug 15322 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:40:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:40:49 +0000 Subject: [Koha-bugs] [Bug 15322] Add delete report option to edit saved report screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15322 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |magnus at libriotech.no Status|NEW |RESOLVED --- Comment #1 from Magnus Enger --- *** This bug has been marked as a duplicate of bug 15321 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:42:58 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add delete report option to |Add delete report option to |a saved report output |Show, Edit and Run screens |screen | CC| |magnus at libriotech.no Assignee|gmcharlt at gmail.com |magnus at libriotech.no --- Comment #2 from Magnus Enger --- Because of the way the relevant templates are structured, it is easy to add the Delete link to the Show, Edit and Run screens in one go, so I have marked bug 15322 as a duplicate of this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:44:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:44:06 +0000 Subject: [Koha-bugs] [Bug 7985] In Checkout, list of items checked out should show Charge from table accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7985 --- Comment #5 from Marc V?ron --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:52:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:52:18 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:52:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:52:21 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 --- Comment #3 from Magnus Enger --- Created attachment 45509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45509&action=edit Bug 15321 - Add delete report link to Show, Edit and Run screens Currently, if you are editing or viewing the results of running a report and you decide you want to delete it, you have to go back to the list of saved reports to do so. This patch adds a "Delete" link in some convenient places. To test: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 20:58:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 19:58:03 +0000 Subject: [Koha-bugs] [Bug 15290] SQL reports encoding problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15290 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:07:46 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 --- Comment #4 from Heather Braum --- Magnus, you just made my day with this! I've tested it, to check for it in the three places (edit, "report has been saved", and run screens), and it's present in all three places. Before signing off, though, I did notice there's no delete confirmation message appearing -- the reports just delete. Can that be fixed in the scope of this bug or does it need to be a separate bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:18:02 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:18:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:18:32 +0000 Subject: [Koha-bugs] [Bug 15333] New: Use Koha::Cache for caching all holidays Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 Bug ID: 15333 Summary: Use Koha::Cache for caching all holidays Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org Now that bug 14522 is pushed to master, this follow-up bug is to add Koha::Cache style caching for all 'holiday' subs() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:19:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:19:05 +0000 Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:19:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:19:29 +0000 Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14522 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 [Bug 14522] Use Koha::Cache for accessing single_holidays() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:19:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:19:29 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15333 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 [Bug 15333] Use Koha::Cache for caching all holidays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:29:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:29:56 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 --- Comment #16 from Tom Misilo --- Created attachment 45510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45510&action=edit Bug 14945 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the table items_last_borrower ( id, itemnumber, borrowernumber ) * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha insert into this table the patron who last returned this item. Replace existing row based on itemnumber if exists. * If table has a row for a given item, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the last patron to return the item. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Nick Clemens Signed-off-by: Jen DeMuth Signed-off-by: Tom Misilo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:30:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:30:08 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45510|0 |1 is obsolete| | --- Comment #17 from Tom Misilo --- Created attachment 45511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45511&action=edit Bug 14945 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the table items_last_borrower ( id, itemnumber, borrowernumber ) * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha insert into this table the patron who last returned this item. Replace existing row based on itemnumber if exists. * If table has a row for a given item, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the last patron to return the item. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Nick Clemens Signed-off-by: Jen DeMuth Signed-off-by: Tom Misilo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:39:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:39:53 +0000 Subject: [Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:39:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:39:56 +0000 Subject: [Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #2 from Magnus Enger --- Created attachment 45512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45512&action=edit Bug 15304 - Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:43:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:43:48 +0000 Subject: [Koha-bugs] [Bug 15334] New: Accountlines should link to issues/old_issues using issue_id. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15334 Bug ID: 15334 Summary: Accountlines should link to issues/old_issues using issue_id. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We have perennial problems with fines due to the fact that fines don't link back to check-outs... now that we've added issue_id, we should add a linking field in accountlines, and use that wherever it's possible in the fines code (for example, fines.pl should try to link to issue_id, and only fall back to reading the description if issue_id is NULL). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 21:44:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 20:44:06 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 --- Comment #5 from Magnus Enger --- Ah, when you click Delete from the list of saved reports there is a JavaScript confirmation that I missed. I'll see if I can get that to work with the new links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 22:02:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 21:02:33 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45509|0 |1 is obsolete| | --- Comment #6 from Magnus Enger --- Created attachment 45513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45513&action=edit Bug 15321 - Add delete report link to Show, Edit and Run screens Currently, if you are editing or viewing the results of running a report and you decide you want to delete it, you have to go back to the list of saved reports to do so. This patch adds a "Delete" link in some convenient places. To test: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional, including the JavaScript confirmation dialogue - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! Version 2: This version makes sure the JavaScript confirmation is shown before an actual delete is carried out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 22:13:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 21:13:37 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Heather Braum --- I've followed the testing plan below, including the patch update in version 2, and this works as described. Thanks Magnus! Test plan: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional, including the JavaScript confirmation dialogue - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! Version 2: This version makes sure the JavaScript confirmation is shown before an actual delete is carried out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 22:16:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 21:16:57 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 --- Comment #10 from Blou --- I asked Francois, and he has no idea how we got to that. But we had TWO clients with the situation, one of which it couldn't be blamed on a migration issue. The clerk put the item on Reserve to put them aside when they would come back. We thought he had no branch associated, but then he probably could not do much, and anyway we confirmed it was not the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 22:18:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 21:18:22 +0000 Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 --- Comment #1 from Martin Renvoize --- Fantastic that your looking into this mason. The patches on the prior bug go a long way to improving performance.. Nit only by reducing database hits by caching but also by reducing DateTime instantiations within loops, which are a well known performance bottleneck. So pleased to see work going on in this area. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 22:38:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 21:38:31 +0000 Subject: [Koha-bugs] [Bug 15335] New: Online payment of fines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15335 Bug ID: 15335 Summary: Online payment of fines Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martin at bugs.koha-community.org.xinxidi.net QA Contact: testopia at bugs.koha-community.org Make it possible for borrowers to pay their fines using online payment services such as DIBS/Paypal/etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 22:39:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 21:39:03 +0000 Subject: [Koha-bugs] [Bug 15335] Online payment of fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15335 Martin Stenberg changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |martin at bugs.koha-community. | |org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 23:11:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 22:11:39 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #15 from David Cook --- (In reply to Galen Charlton from comment #14) > Other way around: Text::Unaccent is not, as it would be much preferable, > emitting Perl Unicode strings; rather, it is emitting octet-sequences. Sorry, I must have been unclear; I meant to say that Text::Unaccent is emitting octet-sequences (hence why using encode() on the string returned by Text::Unaccent would create a Perl Unicode string). And that Perl itself was causing problems when it tried to create a new string from an octet sequence string and a Perl Unicode string. > A good pattern is aim for is using *only* Unicode strings within core code, > and relegating use of Encode and friends to input and output; Text::Unaccent > would get in the way of that. Fair enough. I'm not in favour of Text::Unaccent per se. I was curious why it seemed to mangle some strings, and I shared what answers I found. I suspect Unicode::Normalize will really be the way to go, as you suggest. It seems much more comprehensive than Text::Unaccent and Text::Unaccent::PurePerl. I imagine we just need feedback from people experienced in Arabic, Hebrew, and CJK languages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 23:14:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 22:14:19 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 23:17:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 22:17:07 +0000 Subject: [Koha-bugs] [Bug 15331] Sort order breaks at offset=1000 (both OPAC and Intranet) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- (In reply to Fr?d?ric Demians from comment #1) > Take a look at bug 7041 You might also take a look at "sortmax" at http://www.indexdata.com/zebra/doc/zebra-cfg.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 8 23:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 22:23:16 +0000 Subject: [Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 00:12:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Dec 2015 23:12:50 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 --- Comment #4 from Katrin Fischer --- Sorry, I didn't confirm via SIP - should have been more clear in my comment. We discussed it on IRC and came to the conclusion that this would cause the display we can see at the detail page - checked out and available at the same time. I think you will see the same as the screenshot, if you check out an item and then reset the items.onloan to null/empty. We definitely still need to test and confirm this with SIP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 01:17:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 00:17:19 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13136=5D__No_documentation_for_Home_?= =?utf-8?b?4oC6IFRvb2xzIOKAuiBMYWJlbHMgaG9tZSDigLogTWFuYWdlIGxhYmVsIExh?= =?utf-8?q?youts?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #6 from H?ctor Eduardo Castro Avalos --- (In reply to Marc V?ron from comment #5) > The character \u203a' is a quote character that looks like '>' > In earlier commits, I produced such errors by copy-pasting the breadcrumbs > from the staff client (like Home > Tools > Label creator) to the commit > message. I've tried to change to a valid > also I changed the tab char but I couldn't attach it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 02:08:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 01:08:52 +0000 Subject: [Koha-bugs] [Bug 9857] Did you mean? from authorities uses incorrect punctuation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #5 from H?ctor Eduardo Castro Avalos --- Hi all I did a search of this type su:country music the search result still presented with /cgi-bin/koha/opac-search.pl?q=su-na=country music I think IMHO this needs a follow-up Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 03:39:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 02:39:53 +0000 Subject: [Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45512|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 45514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45514&action=edit [SIGNED-OFF]Bug 15304: Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po Signed-off-by: Hector Castro nl-search.tt translated to English -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 03:40:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 02:40:18 +0000 Subject: [Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 04:02:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 03:02:05 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 --- Comment #5 from june --- I got this error for SIP checkout although the item has been successfully checked out and display available status at the detail page. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_dev_koha`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at C4/Items.pm line 2384. ERROR in _koha_modify_item UPDATE items SET issues=?,datelastborrowed=?,holdingbranch=?,itemlost_on=?,itemlost=?,onloan=? WHERE itemnumber=?: Cannot add or update a child row: a foreign key constraint fails (`koha_dev_koha`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at C4/Items.pm line 2387. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 04:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 03:22:02 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 --- Comment #6 from Mason James --- > We definitely still need to test and confirm this with SIP. some good news... I issued an item via SIP, and the incorrect 'available' text was not shown. so 'works for me' on Koha-3.20.6 also, items.onloan column was correctly populated too -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 04:24:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 03:24:48 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 --- Comment #7 from Mason James --- (In reply to june from comment #5) > I got this error for SIP checkout although the item has been successfully > checked out and display available status at the detail page. > > DBD::mysql::st execute failed: Cannot add or update a child row: a foreign > key constraint fails (`koha_dev_koha`.`items`, CONSTRAINT `items_ibfk_3` > FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE > CASCADE) at C4/Items.pm line 2384. > ERROR in _koha_modify_item UPDATE items SET > issues=?,datelastborrowed=?,holdingbranch=?,itemlost_on=?,itemlost=?, > onloan=? WHERE itemnumber=?: Cannot add or update a child row: a foreign key > constraint fails (`koha_dev_koha`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN > KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE > CASCADE) at C4/Items.pm line 2387. ^... i think that error is caused by your item having a $branchcode that does not exist in the 'branches' table? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 04:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 03:40:21 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 --- Comment #8 from june --- It has branchecode.This are items and branches tables screenshot: https://goo.gl/jFpnHz https://goo.gl/GZOsFw -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 06:14:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 05:14:12 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #61 from David Cook --- I've been doing more thinking about OAI-PMH harvesting of holdings records... I looked at some online documentation for how systems like Voyager link holdings records and item records, and while the information I found was a bit spotty, the linkage seems rather tenuous. It looks like the holdings record will store a location and a call number in a 852 field, and then when creating an item, that location and call number will be pulled into the item. It looks like the item is also linked in some manner to the holdings record. So when you're viewing a bibliographic record in the catalogue, you'll also see data from the holdings record merged together with data from the item record. -- So one bibliographic record can be linked to many holdings records which can be linked to many item records. The problem with harvesting holdings records and trying to do something with them in Koha is that Koha doesn't support MARC holdings records. This leads us to want to create item records directly from holdings records, but holdings records aren't item records. While they store item-level data, they themselves aren't item records. Nor do they appear to have any way of specifying how many items are actually held. They have holdings statements for things like journals, but that's free-form plain text. Not really something that can be used programmatically. -- So I don't think you can actually reliably create items from a holdings record, as you don't know how many items to create, nor do you have anything like a barcode to identify those items. If an item record in Koha had a link to a holdings record, (such as in a 952$H subfield), you could use the holdings record to update select subfields in multiple existing Koha item records though. But that's about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 06:48:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 05:48:07 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #62 from David Cook --- It's worth mentioning that my above comment regarding holdings is probably only relevant for some systems like Voyager, and are not relevant for all holdings records... Those comments are based on the following pages: http://library.princeton.edu/departments/tsd/katmandu/voyager/holitmono.html http://library.princeton.edu/departments/tsd/katmandu/voyager/relink.html http://library.princeton.edu/departments/tsd/katmandu/voyager/chgloc.html http://www.library.illinois.edu/cam/training/voyagerscript.html However, it does appear that there are fields in holdings records for individual items: 876$a is an "Internal item number" (http://www.loc.gov/marc/holdings/hd876878.html). While I haven't seen this in LIBRIS holdings data, it is a field/subfield which exists. 876$p could then be used for the barcode. Looking at this example: 852 0#$aTxAM$bStacks$hHD9195.A5$iW5 876 ##$aAAH8128-1-1$c$13.75$pA14802137389 852$a = Location (ie Library) 852$b = Sublocation/Collection (Branch) 852$h = Classification part (start of call number) 852$i = Item part (end of call number) 876$a = Internal item number (itemnumber) 876$c = Cost (cost) 876$p = Piece designation (barcode) However... the 876 subfields are really only useful if they're present. If your record just has a 852 without any actual item-level data... you can't very well do add/match/update items in Koha without it. Even in the event though that you have 876 data, there are hurdles as outlined below. It's not too bad when there is one 852 and one 876 for a single part item: "One copy, one 852 field - Item fields do not need a linking subfield as all apply to the one holdings item. (Holdings are recorded at level 1 or 2 in Leader/17 (Encoding Level).) [See example under subfield $p below]" (http://www.loc.gov/marc/holdings/hd876878.html). However, "Multiple copies, one or more 852 fields - Subfield $3 is used to link item fields to the appropriate copy in 852 field(s). (Holdings are recorded at level 1 or 2 in Leader/17 (Encoding Level).) [See example under subfield $e below]" (http://www.loc.gov/marc/holdings/hd876878.html). But the $3 subfield isn't a coded field. It's free text, which foils any consistent automated linking. It gets even more complicated for "Multiple physical part holdings item": "Holdings in 866-868 (Textual Holdings) fields - Subfield $3 is used to link item fields to the appropriate part specified in fields 866-868. (Holdings are recorded at level 3 or 4 in Leader/17 (Encoding Level).) [See example under subfield $h below] Holdings in 863-865 (Enumeration and Chronology) fields - Subfield $8 is used to link item fields to the appropriate part specified in fields 863-865. Each part (volume or volumes) for which item level information is included requires a separate 863-865 field. (Holdings are recorded at level 3 or 4 with piece designation in Leader/17 (Encoding Level).) [See example under subfield $l below]" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 07:07:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 06:07:06 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #63 from David Cook --- Finally, I don't know how much sense it makes harvesting MARC holdings records via OAI-PMH. I can understand harvesting MARC authority records and MARC bibliographic records, as both are theoretically very universal and interchangeable. You might need to change the system numbers, but that's about it. However, with holdings records, you're describing something that is local to your particular library. In theory, wouldn't you want to be uploading holdings records to a union catalogue, rather than downloading holdings records from it? I believe that's how it works with the National Library of Australia. We do some automated exports for the National Library of Australia union catalogue. I think some bibliographic details are included for matching purposes, and then we export all the item data so that they can update the holdings in the union catalogue on a regular (I think it's nightly) basis. -- In the case of LIBRIS, it appears minimal information about "items" is included in a holdings record. Really just the sublocation/collection and the call number. I haven't seen any indication as to the number of items, their barcodes, or really anything specific about "items". So I think it would be difficult if not impossible to use the data I've seen to add/update items in Koha. That said, the data in 866 does certainly seem valuable regarding holdings, and I can see the utility in adding that to the local catalogue. Part of me wants to add support for MARC holdings records in Koha, although I imagine there would be resistance to that, as it further entrenches our use of MARC. The problem with adding OAI-PMH support for holdings is that merging holdings data in to bibliographic records would be tricky. Easy to add it initially, but difficult - if not impossible - to reliably update later. But it would be trivially to import the holdings records into a table and link them to an existing bibliographic record. We could then embed holdings records into bibliographic records at index time (like we already do with item records), so that data from holdings records would be searchable and displayable on the detail page and search results page. That would make it rather easy to "merge" MARC holdings records into MARC bibliographic records for search/retrieval and display. It wouldn't help with "items" but at least the holdings data would be in Koha. We could also consider linking items and holdings records... although I think we'd want to think about the long-term implications of that in a non-MARC environment. It probably would be OK... because "more_subfields_xml" really is filling that gap at the moment, and "items" could just be used for more transactional data while additional data could be offloaded to a XML record (like we do for authorities and bibliographic records... and how we probably would with RDF records anyway). Mind you, it would be more complex with holdings, because holdings records can still refer to multiple items... the idea of linking "items" and "holdings" still seems like it's very specialized and ILS-specific which is no good at all... -- Anyway, hopefully these 3 epic-length comments help further the conversation around harvesting MARC holdings records via OAI-PMH. I think it's a very difficult thing... and provides us with challenges not necessarily in terms of "logic" but rather with "data", links, and relationships. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 08:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 07:01:33 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 08:01:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 07:01:36 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44628|0 |1 is obsolete| | --- Comment #30 from Fr?d?ric Demians --- Created attachment 45515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45515&action=edit Bug 5572 Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios A new syspref AuthCleanBiblios controls how modified info in a modified authority are propagated to the attached biblio records. By default, the merge() behavior isn't changed. When AuthCleanBiblios is set to yes, the subfields of the authority heading are copied to biblio field. If the biblio field contains subfields that are not anymore in the authority, they are removed (this is true only for the authority subfields that are neither ignored nor hidden in the authority editor) This patch does some code refactoring: - New function C4::AuthoritiesMarc::GetBibliosByAuthid - New function C4::Biblios::GetBiblionumber($record) - Minimizing SQL queries, and caching - Code cleaning + doc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 08:02:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 07:02:14 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|januszop at gmail.com |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 08:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 07:02:41 +0000 Subject: [Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|refinements to function |Improve |merge sub merge in |C4::AuthoritiesMarc->merge( |C4::AuthoritiesMarc |) + syspref | |AuthCleanBiblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 08:26:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 07:26:22 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 --- Comment #9 from Katrin Fischer --- Hi Mason, thx for testing! I was worried about this one. June, could you check 2 things in your installation? - Make sure there is no space/whitespace after your branchcodes. It's a bit hard to see, but I had that happen and it was no fun :) - Check your SIP configuration carefully - I think . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 08:59:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 07:59:07 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 --- Comment #10 from june --- Hi Katrin, I have checked 2 things. There is no whitespace in branchcodes. And , I have already changed . But, It is still showing available status for checked out item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 09:15:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 08:15:13 +0000 Subject: [Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 --- Comment #11 from Katrin Fischer --- Is the error still shown when you check out an item now? The one you copied from the log? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 09:27:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 08:27:41 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45507|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 45516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45516&action=edit Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two ambiguous words 'to' and a sentence splitted up by html tags, leading to weird translations. Example in German: "Sie k?nnen keine Exemplare aus itemtype transferieren BK f?r: Airfield" To test: - Apply patch - Set up transfer policies for item types and collection codes in Home > Administration > Set library checkin and transfer policy Make sure that you have rules that deny and others that allow transfers - Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce' - Set 'BranchTransferLimitTypes' to 'item type' - Go to Home > Circulation > Transfers - Transfer an item that is allowed for item type - Verify that the table of transferred items displays information about Item type, Collection code and Destination - Transfer an item that is not allowed for the item type - Verify that the information about not allowing the transfer displays properly and is meaningfull - Set 'BranchTransferLimitTypes' to 'collection code' - Repeat the transfer steps above for allowed / not allowed collection code (Amended to add ids to table and 8 columns, see comment #2) (Amended for comment #5) Followup for comment #8 Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 09:27:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 08:27:38 +0000 Subject: [Koha-bugs] [Bug 15301] Translatability: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15301 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 09:41:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 08:41:53 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 09:41:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 08:41:56 +0000 Subject: [Koha-bugs] [Bug 14846] [3.20] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45493|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 45517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45517&action=edit Bug 14846 - Items with no holdingbranch causes svc/holds to crash When trying to display the holds for a user, if an item has no holdingbranch, it causes the svc/holds service to crash and the display to freeze. Tentative steps to reproduce on any DB: 1) put 1 or more items on hold for a given user. 2) go into the database and set the item.holdingbranch to NULL 3) In the user's page, in checkouts (circulation.pl), click the tab that should be written 1 Hold(s) 4) It will be "Processing" indefinitely. The cause is the svc/holds code that crashes. The fix will validate that there's an holdingbranch before proceding with the code. Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 09:44:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 08:44:28 +0000 Subject: [Koha-bugs] [Bug 14846] Items with no holdingbranch causes user's holds display to freeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[3.20] Items with no |Items with no holdingbranch |holdingbranch causes user's |causes user's holds display |holds display to freeze |to freeze --- Comment #12 from Jonathan Druart --- I don't know if we should allow NULL in items.holdingbranch and items.homebranch. But since it's possible at the moment, we should take it into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 09:53:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 08:53:44 +0000 Subject: [Koha-bugs] [Bug 15333] Use Koha::Cache for caching all holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 --- Comment #2 from Martin Renvoize --- Whilst we're on performance, I'd be interested to see if there was any discernible difference in using List::Utils any function over the loop found around line 140 of Koha::Calendar? Anyone fancy testing that.. use List::Utils qw/any/; #(It's in core perl in more recent releases anyways) return (any { /$date/ } @$holidays); They do exactly the same thing, only I think List::Utils functions does so in c instead of perl so I 'think' is usually quicker ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 09:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 08:55:51 +0000 Subject: [Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- paxed, do you agree with this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 10:11:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 09:11:53 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 10:11:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 09:11:55 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45513|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 45518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45518&action=edit Bug 15321 - Add delete report link to Show, Edit and Run screens Currently, if you are editing or viewing the results of running a report and you decide you want to delete it, you have to go back to the list of saved reports to do so. This patch adds a "Delete" link in some convenient places. To test: - Apply the patch - Make sure you have at least one saved report - Make sure you have the create_reports permission - Go to the Show, Edit and Run screens and verify the Delete link is present and functional, including the JavaScript confirmation dialogue - Change to a user without the create_reports permission and check that the Delete link is not displayed on the Show, Edit and Run screens - Sign ye off merrily! Version 2: This version makes sure the JavaScript confirmation is shown before an actual delete is carried out. Signed-off-by: Heather Braum Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 10:11:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 09:11:58 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 --- Comment #9 from Jonathan Druart --- Created attachment 45519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45519&action=edit Bug 15321: No need to add the change trigger conditionally It will be applied with the button exists. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 10:12:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 09:12:14 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 10:12:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 09:12:53 +0000 Subject: [Koha-bugs] [Bug 15321] Add delete report option to Show, Edit and Run screens In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45519|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 45520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45520&action=edit Bug 15321: No need to add the change trigger conditionally It will be applied if the button exists. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 10:38:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 09:38:36 +0000 Subject: [Koha-bugs] [Bug 15336] New: Script for merging booksellers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Bug ID: 15336 Summary: Script for merging booksellers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Sometimes, librarian create and use duplicates booksellers. Here is a command-line tool that can merge 2 booksellers. In fact, it moves baskets, basketgroups, contracts etc ... in the target bookseller. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 10:44:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 09:44:23 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging booksellers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 10:46:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 09:46:22 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com Summary|subscription endddate is |Fixing subscription |copied into subscription |endddate inconsistency: |history histendate field |should be empty when the |during renew process |subscription is running --- Comment #4 from Paul Poulain --- The Renewal of a subscription fills the subscriptionhistory.enddate field. This field is not filled when you create a subscription. It is supposed to keep track of the subscription end for ended subscription. The renewal should follow the same workflow as the creation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:16:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:16:04 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging booksellers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #1 from Alex Arnaud --- Created attachment 45521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45521&action=edit Bug 15336 - New command-line script: merge_bookseller.pl Test plan (i.e. merge bookseller n? 3 into the n? 6): run perl misc/migration_tools/merge_booksellers.pl -f 3 -t 6 -v -c Check that basketgroups, baskets, contacts, contracts and invoices had moved into bookseller 6. Check that bookseller n? 3 has been deleted. Remove -c (confirm) parameter to run in test mode only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:16:28 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging booksellers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:24:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:24:39 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:24:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:24:43 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45466|0 |1 is obsolete| | Attachment #45511|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 45522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45522&action=edit Bug 14945 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the table items_last_borrower ( id, itemnumber, borrowernumber ) * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha insert into this table the patron who last returned this item. Replace existing row based on itemnumber if exists. * If table has a row for a given item, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the last patron to return the item. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Nick Clemens Signed-off-by: Jen DeMuth Signed-off-by: Tom Misilo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:27:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:27:42 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 --- Comment #19 from Jonathan Druart --- All works fine, thanks Kyle for your tenacity :) Thanks for the additional signoffs too! I have just noticed 1 weird behavior on testing: If the last patron to return has required privacy, on the items detail page, the "Last borrower" and "Last returned by" will differ. I know that it's all the point of this patch, but the info are not obvious in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:31:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:31:02 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 --- Comment #20 from Jonathan Druart --- Created attachment 45523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45523&action=edit Bug 14945: Add 2 more tests for StoreLastBorrower Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:31:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:31:15 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #3 from Colin Campbell --- (In reply to Fr?d?ric Demians from comment #2) > With this: > > my $timeout = $self->{service}->{client_timeout} || > $config->{client_timeout}; > > what will happen after Koha upgrade if a library doesn't add the new > 'client_timeout' parameter to its config file. Wouldn't it be better to have > something like: > > my $timeout = $self->{service}->{client_timeout} || > $config->{client_timeout} || > $self->{service}->{timeout} || $config->{timeout}; > > And/or a note via updatabase.pl to notify that SIP config file has to be > reviewed after upgrade. If the client_timeout is not present the current situation remains the same (or in fact reverts to the situation before timeout was incorrectrly extended to timeout active connections) Your suggestions for adding it to the test preserves the bad code from patch 13432 which has caused in my experience to make previously working installs go unstable. Once this gives a working system, I'm hoping to overhaul the cxonfig file which is under documented -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:32:54 +0000 Subject: [Koha-bugs] [Bug 15337] New: Koha Item Type sorted by Code instead of Description Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Bug ID: 15337 Summary: Koha Item Type sorted by Code instead of Description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When adding items (holdings), options on the dropdown list for Koha Item Type needs to be sorted by headings themselves not linked Codes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:33:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:33:16 +0000 Subject: [Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha Item Type sorted by |Koha Item Type sorted by |Code instead of Description |Codes instead of | |Descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:46:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:46:20 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 11:46:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 10:46:29 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha at univ-lyon3.fr |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 12:19:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 11:19:59 +0000 Subject: [Koha-bugs] [Bug 15124] Allow SIP2 passwordless operation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124 --- Comment #4 from Colin Campbell --- Katrin is right. A password is not present in a (e.g) checkout transaction. The password checking logic is in the machine itself, the server end does not have the concept of a user session (each request is dealt with irrespective of what preceeds it). Whether the machine requires the user to authenticate with a password is an option on some of these, they ignore the field rather than asking us to lie about its validity. I'm a bit worried a that its not clear what the import of the code is and that the config file is being swamped by extra options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 12:33:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 11:33:32 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #20 from Jonathan Druart --- Comment on attachment 30622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30622 [PASSED QA] Bug 12529: Add a syspref to make overdue notices respect holidays Review of attachment 30622: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12529&attachment=30622) ----------------------------------------------------------------- ::: misc/cronjobs/overdue_notices.pl @@ +422,5 @@ > foreach my $branchcode (@branches) { > + if ( C4::Context->preference('OverdueNoticeCalendar') ) { > + my $calendar = Koha::Calendar->new( branchcode => $branchcode ); > + if ( $calendar->is_holiday($date_to_run) ) { > + next; Why do we skip the library is today is holiday? It seems that should only be done if --triggered|-t is given. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 12:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 11:33:59 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #21 from Jonathan Druart --- s/is/if -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 12:35:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 11:35:39 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #22 from Katrin Fischer --- I think the idea is that you don't want to have a fine set on a holiday - but making it so that it depends on -t would work for us. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 12:47:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 11:47:30 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #3 from Jonathan Druart --- Created attachment 45524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45524&action=edit Bug 15240: Do not process issues with a date due later than today There is no need to do this job in Perl, MySQL could do it instead. The idea is to only retrieve the issues info which could be overdued. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 12:49:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 11:49:45 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #4 from Jonathan Druart --- Sophie, Martin, If you are not using OverdueNoticeCalendar, the number of holidays should not change anything for you actually. It would be great if you could have a look at this patch and compare the execution time, with and without. Do not do it in production, I have not tested this patch enough to be 100% confident :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 12:49:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 11:49:56 +0000 Subject: [Koha-bugs] [Bug 15338] New: Remove inconsistency in location of SIPServer.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 Bug ID: 15338 Summary: Remove inconsistency in location of SIPServer.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com For historical reasons the SIPServer has not been located in the bin directory but in the lib hierarchical - these reasons no longer apply and this is only a source of confusion and "special case" workarounds. Relocate the server to its logical place in the hierarchy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 12:56:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 11:56:13 +0000 Subject: [Koha-bugs] [Bug 15338] Remove inconsistency in location of SIPServer.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 45525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45525&action=edit Proposed patch Testing: Using the amended start up and shutdown scripts the server should behave as before this patch was applied -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 13:05:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 12:05:09 +0000 Subject: [Koha-bugs] [Bug 15339] New: TestBuilder build parameter warnings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Bug ID: 15339 Summary: TestBuilder build parameter warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: xarragon at gmail.com QA Contact: gmcharlt at gmail.com TestBuilder's build function ignores any parameters that it does not recognize. If the developer forgets to wrap the column values in a 'value' hashref he or she might waste time checking the code rather than the tests. This patch makes TestBuilder issue a warning whenever unregonized parameters are passed to build. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 13:19:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 12:19:09 +0000 Subject: [Koha-bugs] [Bug 15338] Remove inconsistency in location of SIPServer.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338 --- Comment #2 from Colin Campbell --- Created attachment 45526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45526&action=edit Supplementary patch Supplementary patch removes obsolete comments and applies consistent formatting to the code. Adds a comment to indicate Net::Server::Fork is a valid alternative to PreFork -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 13:27:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 12:27:03 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #1 from Martin Persson --- Created attachment 45527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45527&action=edit Bug 15339: TestBuilder warnings (code) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch holds the code changes. Examples of the kind of errors that it catches are in the tests (separate patch). Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 13:27:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 12:27:20 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 --- Comment #2 from Martin Persson --- Created attachment 45528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45528&action=edit Bug 15339: TestBuilder warnings (tests) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch contains the tests that doubles as a demonstration of the kind of error the patch is intended to prevent. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 13:28:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 12:28:16 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 13:59:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 12:59:32 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Assignee|claire.hernandez at biblibre.c |alex.arnaud at biblibre.com |om | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 14:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 13:08:20 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #5 from Martin Renvoize --- That's what I meant by 'system where the preferences are set to ignore the holidays' in comment 2, I just couldn't remember what the pref was called ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 14:09:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 13:09:40 +0000 Subject: [Koha-bugs] [Bug 15335] Online payment of fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15335 --- Comment #1 from Owen Leonard --- I hope this is being developed with Bug 11622 in mind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 14:21:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 13:21:46 +0000 Subject: [Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 14:31:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 13:31:47 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #5 from Paul Poulain --- Created attachment 45529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45529&action=edit Bug 7728: fix subs history end date consistency Without this patch, there is an inconsistency in subscriptions: * a new subscription has no history end date set (as expected) * if you renew it, a date is set. This patch removes the setting of the history end date during renewal Test plan: * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set * renew the subscription => a date has been set * apply the patch * create another subscription * renew it => no history end date has been set * sign-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 14:34:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 13:34:02 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 14:53:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 13:53:05 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging booksellers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45521|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 45530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45530&action=edit Bug 15336 - New command-line script: merge_bookseller.pl Test plan (i.e. merge bookseller n? 3 into the n? 6): run perl misc/migration_tools/merge_booksellers.pl -f 3 -t 6 -v -c Check that basketgroups, baskets, contacts, contracts and invoices had moved into bookseller 6. Check that bookseller n? 3 has been deleted. Remove -c (confirm) parameter to run in test mode only. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 15:00:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 14:00:21 +0000 Subject: [Koha-bugs] [Bug 15336] Script for merging booksellers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 15:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 14:14:39 +0000 Subject: [Koha-bugs] [Bug 9321] holds queue printable version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9321 --- Comment #7 from Kyle M Hall --- I think changes in Koha since I submitted this patch have made it superfluous. It should probably be marked resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 15:14:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 14:14:51 +0000 Subject: [Koha-bugs] [Bug 14798] Renew and checkin do not update parts of checkout page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14798 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 15:41:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 14:41:25 +0000 Subject: [Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 15:58:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 14:58:02 +0000 Subject: [Koha-bugs] [Bug 15332] ModMember not interpreting dates (Batch patron modification) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Danielle Elder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om --- Comment #1 from Danielle Elder --- I was able to view this in action in batch patron modification where a library entered a new date expiry using the date picker and the date was set to 0000 - 00-00 Example: Before modification in tool: TEMP0041 | 2015-08-11 | TEMP0042 | 2015-11-15 | TEMP0043 | 2015-11-15 | After modification: TEMP0041 | 0000-00-00 | TEMP0042 | 0000-00-00 | TEMP0043 | 0000-00-00 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:01:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:01:53 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:01:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:01:55 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38208|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 45531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45531&action=edit Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length. Test Plan: 1) Apply this patch 2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl 3) Note you are redirected back to the holds over tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:02:21 +0000 Subject: [Koha-bugs] [Bug 15332] ModMember not interpreting dates (Batch patron modification) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 --- Comment #2 from Danielle Elder --- I was able to view this in action in batch patron modification where a library entered a new date expiry using the date picker and the date was set to 0000 - 00-00 Example with altered cardnumber: Before modification in tool: TEMP0041 | 2015-08-11 | TEMP0042 | 2015-11-15 | TEMP0043 | 2015-11-15 | After modification: TEMP0041 | 0000-00-00 | TEMP0042 | 0000-00-00 | TEMP0043 | 0000-00-00 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:06:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:06:43 +0000 Subject: [Koha-bugs] [Bug 13136] No documentation for Home > Tools > Labels home > Manage label Layouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No documentation for Home ? |No documentation for Home > |Tools ? Labels home ? |Tools > Labels home > |Manage label Layouts |Manage label Layouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:07:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:07:02 +0000 Subject: [Koha-bugs] [Bug 15340] New: Translatability: fix issue with 'or choose' splitted by tag Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Bug ID: 15340 Summary: Translatability: fix issue with 'or choose' splitted by tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr To verify: - make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or ausw?hlen' (instead of 'oder ausw?hlen') - This is due to the tags around 'choose' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:11:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:11:48 +0000 Subject: [Koha-bugs] [Bug 13136] No documentation for Home > Tools > Labels home > Manage label Layouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45470|0 |1 is obsolete| | --- Comment #7 from H?ctor Eduardo Castro Avalos --- Created attachment 45532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45532&action=edit [SIGNED-OFF]Bug 13136: Add missing help file for label-manage.pl This patch adds in a help file for the new label-manage page. To test: * visit label creator * click manage and choose an option * click 'help' and confirm the file loads * repeat for all options under manage Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:12:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:12:04 +0000 Subject: [Koha-bugs] [Bug 13136] No documentation for Home > Tools > Labels home > Manage label Layouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:13:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:13:37 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 --- Comment #14 from Jonathan Druart --- This fix is not good for the performance. I have reverted it and cannot longer reproduce the original bug. Could someone confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:16:58 +0000 Subject: [Koha-bugs] [Bug 15341] New: Performance - Retrieve all sysprefs at once Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Bug ID: 15341 Summary: Performance - Retrieve all sysprefs at once Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org C4::Context->preference generates a call to Koha::Config::SysPrefs->find for all different sysprefs we are searching for. It seems to be a performance killer and be better to retrieve them all together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:17:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:17:09 +0000 Subject: [Koha-bugs] [Bug 15340] Translatability: fix issue with 'or choose' splitted by tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 --- Comment #1 from Marc V?ron --- Created attachment 45533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45533&action=edit Bug 15340: Translatability: fix issue with 'or choose' splitted by tag This patch fixes a translatability issue due to tags. To verify: - Make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or ausw?hlen' (instead of 'oder ausw?hlen') - This is due to the tags around 'choose' To test: - Apply patch - Verify that the tags around 'choose' are removed in: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:17:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:17:31 +0000 Subject: [Koha-bugs] [Bug 15340] Translatability: fix issue with 'or choose' splitted by tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:27:06 +0000 Subject: [Koha-bugs] [Bug 13136] No documentation for Home > Tools > Labels home > Manage label Layouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 --- Comment #8 from H?ctor Eduardo Castro Avalos --- QA Tool FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/labels/label-manage.tt FAIL forbidden patterns forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 70) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 65) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 69) The patch fails because summary has character \u203a' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:29:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:29:09 +0000 Subject: [Koha-bugs] [Bug 15340] Translatability: fix issue with 'or choose' splitted by tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:29:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:29:11 +0000 Subject: [Koha-bugs] [Bug 15340] Translatability: fix issue with 'or choose' splitted by tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45533|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 45534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45534&action=edit Bug 15340: Translatability: fix issue with 'or choose' splitted by tag This patch fixes a translatability issue due to tags. To verify: - Make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or ausw?hlen' (instead of 'oder ausw?hlen') - This is due to the tags around 'choose' To test: - Apply patch - Verify that the tags around 'choose' are removed in: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc Signed-off-by: Fr?d?ric Demians Obvious issue/solution -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:29:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:29:37 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com --- Comment #34 from Kyle M Hall --- I see merge conflict markers in the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:33:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:33:16 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #35 from Kyle M Hall --- (In reply to Kyle M Hall from comment #34) > I see merge conflict markers in the first patch. Make that the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:35:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:35:02 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #1 from Jonathan Druart --- Created attachment 45535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45535&action=edit Bug 15341: Retrieve all sysprefs at once C4::Context->preference generates a call to Koha::Config::SysPrefs->find for all different sysprefs we are searching for. It seems to be a performance killer and be better to retrieve them all together. I have enabled general_log in the MariaDB config file, the GET circ/circulation.pl?borrowernumber=42 There are 293 queries of the following form: SELECT me.variable, me.value, me.options, me.explanation, me.type FROM systempreferences me WHERE ( me.variable = 'MY_SYSPREF' ) Then benchmarking before and after this patch (using plackup, and the misc/plack/koha.psgi file with Profiler::NYTProf enabled): Before: Profile of /home/koha/perl5/bin/plackup for -2.07s (of 616ms), executing 158857 statements and 588479 subroutine calls in 427 source files and 73 string evals. 885 174ms 4.03s C4::Context::preference After: Profile of /home/koha/perl5/bin/plackup for -1.70s (of 349ms), executing 94273 statements and 397525 subroutine calls in 437 source files and 79 string evals. 1138 194ms 1.99s C4::Context::preference (calls) (exclusive time) (inclusive time) Could someone confirm that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:34:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:34:58 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:35:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:35:29 +0000 Subject: [Koha-bugs] [Bug 15340] Translatability: fix issue with 'or choose' splitted by References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: fix issue |Translatability: fix issue |with 'or choose' splitted |with 'or choose' splitted |by tag |by References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13967 CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |mirko at abunchofthings.net, | |tomascohen at gmail.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 [Bug 13967] Add package for System preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:37:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:37:31 +0000 Subject: [Koha-bugs] [Bug 13967] Add package for System preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15341 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 [Bug 15341] Performance - Retrieve all sysprefs at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:37:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:37:42 +0000 Subject: [Koha-bugs] [Bug 13136] No documentation for Home > Tools > Labels home > Manage label Layouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45532|0 |1 is obsolete| | --- Comment #9 from H?ctor Eduardo Castro Avalos --- Created attachment 45536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45536&action=edit [SIGNED-OFF]Bug 13136: Add missing help file for label-manage.pl This patch adds in a help file for the new label-manage page. To test: * visit label creator * click manage and choose an option * click 'help' and confirm the file loads * repeat for all options under manage Signed-off-by: Hector Castro Works as advertised. Tab char corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:38:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:38:49 +0000 Subject: [Koha-bugs] [Bug 15342] New: Performance 3.22 - Omnibus Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Bug ID: 15342 Summary: Performance 3.22 - Omnibus Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:39:39 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15342 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:39:39 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15240, 15341 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 [Bug 15240] Performance issue running overdue_notices.pl http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 [Bug 15341] Performance - Retrieve all sysprefs at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:39:39 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15342 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:41:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:41:07 +0000 Subject: [Koha-bugs] [Bug 13877] seasonal predictions showing wrong in test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 --- Comment #3 from Marjorie Barry-Vila --- Created attachment 45537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45537&action=edit season in english Hi, I have the same problem even if Season is on X and locale is set on French, language of prediction is always english. When I received an issue, language is always in English. Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:43:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:43:02 +0000 Subject: [Koha-bugs] [Bug 13136] No documentation for Home > Tools > Labels home > Manage label Layouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 --- Comment #10 from H?ctor Eduardo Castro Avalos --- Hi Nicole I changed the summary or title of the bug and I fixed the tab char up. The bug remained authored by you. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:44:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:44:30 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #23 from Jonathan Druart --- For me it's a bug, I don't plan to fix it if I am the only one to think it's a bug :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:47:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:47:26 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #6 from Jonathan Druart --- So it could be related to the number of issues in the DB and this patch could do the job :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:57:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:57:29 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15342 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:57:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:57:29 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15262 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:59:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:59:39 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39566|0 |1 is obsolete| | --- Comment #30 from Alex Arnaud --- Created attachment 45538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45538&action=edit Bug 12993: Add a default tax rate on item types This enhancement permits to set a default tax rate for item types. If a default tax rate is defined for an item type, the tax rate will be automatically selected when the librarian choose the type of the item to order. Test plan: 0/ Execute the updatedb entry. 1/ Define a default tax rate for some item types. 2/ Create an order and verify the tax rate is selected after you have chosen the item type. Note that the item type is only displayed if defined at the biblio level. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:59:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:59:48 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39567|0 |1 is obsolete| | --- Comment #31 from Alex Arnaud --- Created attachment 45539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45539&action=edit Bug 12993: Select automatically itemtype on neworderempty.pl Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:59:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:59:58 +0000 Subject: [Koha-bugs] [Bug 15105] Batch Item Modification Performance Improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11051 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 16:59:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 15:59:58 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15105 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:00:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:00:42 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39568|0 |1 is obsolete| | --- Comment #32 from Alex Arnaud --- Created attachment 45540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45540&action=edit Bug 12993: Add a default tax rate on item types - DB changes This patch adds a new DB field: itemtypes.gstrate Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:00:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:00:50 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39569|0 |1 is obsolete| | --- Comment #33 from Alex Arnaud --- Created attachment 45541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45541&action=edit Bug 12993: (qa-follow-up) Display the column only when it is useful As mention by comment 19, the default tax rate defined for item types is only useful when the items are created on ordering and the item type is defined at the biblio level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:00:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:00:56 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #34 from Alex Arnaud --- Created attachment 45542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45542&action=edit Bug 12993: Fix operator errors in itemtypes.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:01:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:01:01 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #35 from Alex Arnaud --- Created attachment 45543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45543&action=edit Bug 12993: Add gstrate in itemtypes form and table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:02:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:02:01 +0000 Subject: [Koha-bugs] [Bug 3707] Add system preference for customization of the OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3707 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:03:18 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:09:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:09:20 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45199|0 |1 is obsolete| | --- Comment #36 from Eivin Giske Skaaren --- Created attachment 45544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45544&action=edit Remove merge conflict markers http://bugs.koha-community.org/show_bug.cgi?id=1277 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:10:26 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Sally Healey --- Hold fee is applied if all items for the record are issued and at least one hold already exists on the record. This patch adds the ability to charge for any hold placed, regardless of the conditions. Test plan: 1) Execute the updatedb entry to insert the new pref 2) Confirm that the behavior is the same as before applying this patch 3) Change the HoldFeeMode pref to 'always' 4) Note that the fee is applied for any hold placed This patch has been tested and works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:14:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:14:49 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45199|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:15:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:15:19 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45544|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:22:12 +0000 Subject: [Koha-bugs] [Bug 15343] New: Allow patrons to choose their own password on self registration. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Bug ID: 15343 Summary: Allow patrons to choose their own password on self registration. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently patron passwords are auto-generated and a patron must either immediately log in to change their password and/or record them. This patch would simply allow the patron to create their password during registration. Work to be done: * Extend AddMember_Opac to allow passing in the password. * Add update to make password field hidden by default. * Add password/confirm password fields and relevant error messages to opac-memberentry.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:22:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:22:39 +0000 Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:28:50 +0000 Subject: [Koha-bugs] [Bug 9313] add fine amounts to overdue with fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9313 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:31:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:31:22 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45199|0 |1 is obsolete| | --- Comment #37 from Eivin Giske Skaaren --- Created attachment 45545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45545&action=edit Bug 12772 - Update Database (Based on Bug13624) This patch applies to Bug13624. Removes letter number from overduerules and overdurules_transport_types modified: installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl modified: installer/data/mysql/kohastructure.sql Remove merge conflict markers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 17:50:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 16:50:26 +0000 Subject: [Koha-bugs] [Bug 14902] Add qualifier menu to staff side "Search the Catalog" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14902 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:02:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:02:42 +0000 Subject: [Koha-bugs] [Bug 15344] New: GetMemberDetails called unecessary Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Bug ID: 15344 Summary: GetMemberDetails called unecessary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This one is crazy, prepare yourself to dream. For any pages opened from the staff or the OPAC interfaces, the GetMemberDetails is called from get_template_and_user. This subroutine calls GetMemberAccountRecords which retrieve the items infos for all accountlines entries of the logged in user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:07:43 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45198|0 |1 is obsolete| | --- Comment #38 from Eivin Giske Skaaren --- Created attachment 45546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45546&action=edit Bug 12772: Add back file so next patch does not fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:07:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:07:47 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45545|0 |1 is obsolete| | --- Comment #39 from Eivin Giske Skaaren --- Created attachment 45547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45547&action=edit Bug 12772 - Update Database (Based on Bug13624) This patch applies to Bug13624. Removes letter number from overduerules and overdurules_transport_types modified: installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl modified: installer/data/mysql/kohastructure.sql Remove merge conflict markers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:07:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:07:50 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45200|0 |1 is obsolete| | --- Comment #40 from Eivin Giske Skaaren --- Created attachment 45548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45548&action=edit Bug 12772 - Overdue rules tool and backend library modified: C4/Overdues.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt modified: tools/overduerules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:07:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:07:54 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45201|0 |1 is obsolete| | --- Comment #41 from Eivin Giske Skaaren --- Created attachment 45549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45549&action=edit Bug 12772 - Reworked overdue_notices.pl script modified: misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:07:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:07:58 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45202|0 |1 is obsolete| | --- Comment #42 from Eivin Giske Skaaren --- Created attachment 45550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45550&action=edit Bug 12772 - Renames atomic update file, .pl -> .perl renamed: update_13624_overduerules_transport_type.pl -> update_13624_overduerules_transport_type.perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:08:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:08:02 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45203|0 |1 is obsolete| | --- Comment #43 from Eivin Giske Skaaren --- Created attachment 45551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45551&action=edit Bug 12772 - Fix warnings This commit fixes a bunch of warnings for verbose messages which would clutter up the output. They should not affect normal excution. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:08:06 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45204|0 |1 is obsolete| | --- Comment #44 from Eivin Giske Skaaren --- Created attachment 45552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45552&action=edit Bug 12772 - Fix rule updates Overduerules ID was not sent correctly when editing rules, resulting in rule being cleared instead of updated. This patch fixes this issue, and a couple of uninitilized values as a bonus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:08:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:08:43 +0000 Subject: [Koha-bugs] [Bug 15124] Allow SIP2 passwordless operation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:10:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:10:19 +0000 Subject: [Koha-bugs] [Bug 15344] GetMemberDetails called unecessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #1 from Jonathan Druart --- Created attachment 45553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45553&action=edit Bug 15344: Remove unucessary call to GetMemberDetails This subroutine does a lot a processing and should only be called when necessary. In the get_template_and_user subroutine (so called from any pages of Koha), it is call to pass the branchcode, title, firstname, surname and borrowernumber values for the logged in user. This subroutine calls GetMemberAccountRecords which retrieve the items infos for all accountlines entries of the logged in user. On members/members.pl, let's say you have 74 entries in the accountlines tables, the page will execute 115 SELECT instead of 35 if you don't have any accountlines entries. With this patch, the number of SELECT is always 31. To test this patch you should have technical skills to know what to do. Note that USER_INFO was an array of... 1 element. Now it's a hashref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:10:16 +0000 Subject: [Koha-bugs] [Bug 15344] GetMemberDetails called unecessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:10:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:10:41 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15344 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 [Bug 15344] GetMemberDetails called unecessary -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:10:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:10:41 +0000 Subject: [Koha-bugs] [Bug 15344] GetMemberDetails called unecessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15342 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:12:03 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #45 from Eivin Giske Skaaren --- I have fixed so that this patch can be applied to current master again and removed the merge conflict markers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:12:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:12:08 +0000 Subject: [Koha-bugs] [Bug 15344] GetMemberDetails called unecessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #2 from Jonathan Druart --- Not that this patch could be improved and the call to GetMember removed. But to be easily backportable, I'd prefer to keep it light. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:26:00 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- On my box, without plack, execution time: - Without your patch: 1.70s - With your patch: 1.54s I can see in NYTProf stats that 1/3 of execution time is spent in C4::Context::preference. Isn't plack supposed to bring some persistency? And so couldn't we have preferences available somewhere from one page to the other? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:35:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:35:43 +0000 Subject: [Koha-bugs] [Bug 15345] New: Translatability: fix issue in facets (Availability' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15345 Bug ID: 15345 Summary: Translatability: fix issue in facets (Availability' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Fix issue with splitted sentence in facets (Avalability) that leads to weird translation, e.g. in German: Zeige nur Verf?gbar Exemplare. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:37:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:37:01 +0000 Subject: [Koha-bugs] [Bug 15345] Translatability: fix issue in facets (Availability') In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15345 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: fix issue |Translatability: fix issue |in facets (Availability' |in facets (Availability') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:39:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:39:09 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #47 from Kyle M Hall --- I'm not sure what I can possibly do to get this Passed QA. I get no unit test failures. You aren't getting them with my "Fix unit tests" followup ( iirc ). So there is not really anything I can do on my what. Jonthan, can you please investigate this since you are getting the failures as well? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:52:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:52:08 +0000 Subject: [Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #7 from Jonathan Druart --- Created attachment 45554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45554&action=edit Bug 15344: Remove some other calls of GetMemberDetails from pl scripts Same as previously. For these files it's a bit less obvious. To make sure these changes won't introduce any regression, check that the variable returned by GetMember is never used to get something else than a borrower fields. The 'flags' should not be get neither. For opac-user.tt it's different, other keys are got but there are defined in the pl script. On the way: - 'showname' is removed (never used) - fix scope var issue in opac-user.tt (BORROWER_INF.OPACPatronDetails vs OPACPatronDetails) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:53:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:53:28 +0000 Subject: [Koha-bugs] [Bug 15345] Translatability: fix issue in facets (Availability') In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15345 --- Comment #1 from Marc V?ron --- Created attachment 45555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45555&action=edit Bug 15345: Translatability: fix issue in facets (Availability') This patch fixes an issue with a splitted sentence in facets (Avalability) that leads to weird translations e.g.: German: 'Zeige nur Verf?gbar Exemplare' French: 'Montrer seulement disponible exemplaires' Additionally, the link "Show all items" gets it's own li tags to display nicely like the other links in the facets column and it removes superfluous dots. To test in OPAC and Staff client: - Apply patch - Do a search that results in more than one available items - In column "Refine your search", click on "Limit to currently available items" - Verify that the message "Showing only available items" and the link "Show all items" display nicely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:54:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:54:31 +0000 Subject: [Koha-bugs] [Bug 15345] Translatability: fix issue in facets (Availability') In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15345 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 18:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 17:59:14 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #6 from Jonathan Druart --- Please provide tests to highlight the changes ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 19:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 18:11:32 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #3 from Fr?d?ric Demians --- > I can see in NYTProf stats that 1/3 of execution time is spent in > C4::Context::preference. But, this time is in fact spent in Koha::Database::schema, than DBIx::Class::Schema::load_namespaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 20:29:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 19:29:07 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45531|0 |1 is obsolete| | --- Comment #5 from Tom Misilo --- Created attachment 45556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45556&action=edit Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length. Test Plan: 1) Apply this patch 2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl 3) Note you are redirected back to the holds over tab Signed-off-by: Tom Misilo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 20:29:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 19:29:12 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 20:29:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 19:29:55 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 20:32:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 19:32:08 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 --- Comment #6 from Tom Misilo --- Jonathan, I tested your case as well, and it does not appear to do that with the latest patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 20:35:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 19:35:45 +0000 Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 20:53:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 19:53:00 +0000 Subject: [Koha-bugs] [Bug 15345] Translatability: fix issue in facets (Availability') In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15345 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45555|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 45557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45557&action=edit [SIGNED-OFF]Bug 15345: Translatability: fix issue in facets (Availability') This patch fixes an issue with a splitted sentence in facets (Avalability) that leads to weird translations e.g.: German: 'Zeige nur Verf?gbar Exemplare' French: 'Montrer seulement disponible exemplaires' Additionally, the link "Show all items" gets it's own li tags to display nicely like the other links in the facets column and it removes superfluous dots. To test in OPAC and Staff client: - Apply patch - Do a search that results in more than one available items - In column "Refine your search", click on "Limit to currently available items" - Verify that the message "Showing only available items" and the link "Show all items" display nicely. Signed-off-by: Hector Castro use_zebra_facets set to 0 in koha-conf.xml to test. Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 20:53:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 19:53:15 +0000 Subject: [Koha-bugs] [Bug 15345] Translatability: fix issue in facets (Availability') In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15345 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 21:07:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 20:07:17 +0000 Subject: [Koha-bugs] [Bug 15339] TestBuilder build parameter warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Martin Persson --- Realized there are some shortcomings that I need to fix before this is worth looking at. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 21:30:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 20:30:49 +0000 Subject: [Koha-bugs] [Bug 15346] New: Translatability: fix sentence splitting issue in memberentrygen.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346 Bug ID: 15346 Summary: Translatability: fix sentence splitting issue in memberentrygen.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Fix sentences in memberentrygen.tt that are split by tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence). Example: Es sind Keine Bibliotheken definiert. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 21:39:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 20:39:18 +0000 Subject: [Koha-bugs] [Bug 15346] Translatability: fix sentence splitting issue in memberentrygen.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 21:40:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 20:40:05 +0000 Subject: [Koha-bugs] [Bug 15346] Translatability: fix sentence splitting issue in memberentrygen.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346 --- Comment #1 from Marc V?ron --- Created attachment 45558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45558&action=edit Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt Fix sentences in memberentrygen.tt that are split by tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence). Example: Es sind Keine Bibliotheken definiert. To test: - Apply patch - To trigger the messages, you have to edit a patron in a system where no libraries and no patron categories are defined - Alternatively, carefully review the changes in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 21:40:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 20:40:41 +0000 Subject: [Koha-bugs] [Bug 15346] Translatability: fix sentence splitting issue in memberentrygen.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 22:27:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 21:27:32 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hector.hecaxmmx at gmail.com --- Comment #15 from H?ctor Eduardo Castro Avalos --- Hi R?mi This patch doesn't apply anymore: Conflict merge: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm Please resolve the problem. Please squash the two patches. Could be great if you include changes in SQL frameworks for fresh installations and update database for frameworks already installed. Note: For debian this package is needed libregexp-common-perl in debian/control Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 9 23:45:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Dec 2015 22:45:38 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 --- Comment #16 from Galen Charlton --- Comment on attachment 41231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41231 Bug 8609 - Add an URL validation plugin for authority and biblio frameworks Review of attachment 41231: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8609&attachment=41231) ----------------------------------------------------------------- ::: cataloguing/value_builder/url.pl @@ +57,5 @@ > + my $regex = $RE{URI}; > + $regex =~ s/\//\\\//g; > + > + my $res = < +
        Transferred items
        Title