[Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721

--- Comment #10 from Marc Véron <veron at veron.ch> ---
(In reply to Frédéric Demians from comment #8)
> > But the description says:
> > Show the following fields from the items database table as columns on the
> > statistics tab on the patron record (...)
> > 
> > I understand this as 'any' colums, not only location,itype and ccode
> 
> Sorry, you're correct! My patch would be a severe regression for libraries
> using other fields from 'items' table.
> 
> What prevents me from signing your patch is that I don't like the idea of
> checking the existence of items field (by calling DESCRIBE items) each time
> the statistics fields are required. Have you explored the possibility using
> the column setting tool? Here:
> 
> /cgi-bin/koha/admin/columns_settings.pl

Hi Frédéric,

I have no resources at the moment to implement a solution based on
columns_settings.pl

Since my patch resolves a bug that leads to a software error, I propose to use
it as an immediate solution and then file a new bug for the solution you
propose.

What do you think about?

-- 
You are receiving this mail because:
You are watching all bug changes.