[Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45290|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc Véron <veron at veron.ch> ---
Created attachment 45292
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45292&action=edit
Bug 15243 - Place a hold on... Fix display issue and improve translatability

This patch fixes strings in request.tt that are untranslatable because of
splitting by html tags inside the strings.

Additionally, the value of maxreserves was used in one string, but not
filled in every case.

That's why the patch introduces a new function GetAllowedReserves in
C4/Reserves.pm to retrieve the maximum count of allowed reserves (depending
on syspref maxreserves and on issuingrules).

To test:
- If not yet done, apply patch from Bug 15244
- Run t/db_dependent/Reserves.t, verify that it passes OK
- Apply this patch
- Run t/db_dependent/Reserves.t again, should pass OK
- Set syspref 'maxreserves' to 1
- Try to place a hold for a patron who already has holds
- Verify that the warning message displays the value above
- Set the syspref to a high value
- Try to place a hold for a patron who has reached the maximum
  allowed holds defined by issuing rules
- Verify that the warning message with the maximum number of
  holds allowed by issuing rules
- Try to trigger other warning messages and/or carefully review
  code in request.tt line 307 and following.
  Additonal messages to trigger are:
  - Already in possession
  - Hold already placed
  - Age restricted
  - No items available
  - Too many holds

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.