[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Dec 2 10:38:02 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 44826
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44826
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC

Review of attachment 44826:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12528&attachment=44826)
-----------------------------------------------------------------

The description for EnhancedMessagingPreferences is "allow/don't allow patrons
to choose which notices they receive and when they receive them.
I think it could be updated to highlight that it's for the staff interface
only, or at least a reference to the new pref?

Why don't you want the patrons to show the type of messages they receive?
I could understand not to let the patrons change the settings, but I don't see
the point to hide them completely.

::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql
@@ +1,3 @@
> +INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES
> +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo')
> +;

It would be better to set the value of the other pref, to avoid any confusion.

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
@@ +131,5 @@
>                      </form>
>                  </div> <!-- / #usermessaging -->
> +                [% ELSE %]
> +                    <h4>You are not allowed to call this page directly</h4>
> +                    <span> To report this problem, you can <a href="mailto:[% admin %]">email the Koha Administrator</a>.</span>

"admin" does not seem to be sent to the template.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list