[Koha-bugs] [Bug 14939] OAI Server classes must be modularized

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939

--- Comment #26 from Frédéric Demians <frederic at tamil.fr> ---
(In reply to Jonathan Druart from comment #23)
> Comment on attachment 44915 [details] [review]
> [SIGNED-OFF]Bug 14939: Modularize OAI Server existing classes
> 
> Review of attachment 44915 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Installer/PerlDependencies.pm
> @@ +777,4 @@
> >          'required' => '0',
> >          'min_ver'  => '0.28',
> >      },
> > +    'Capture::Tiny' => {
> 
> Is this really mandatory?

Is is used in tests to capture STDOUT. Do you have something to suggest to
do the same thing without this module?

> ::: opac/oai.pl
> @@ +1,3 @@
> >  #!/usr/bin/perl
> >  
> > +# Copyright Tamil s.a.r.l. 2008-2015
> 
> Why did you remove BibLibre's copyright?

Not intentional, even if Tamil copyright on this code deserves to come back. I
wrote OAI server back in time, and Tamil copyright disappeared without being
noticed by sharp eyes as yours.

-- 
You are receiving this mail because:
You are watching all bug changes.