[Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 45326
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45326&action=edit
Bug 10163 - batch-mod items tool fails on files over 1000 lines long

When using batch modification tool, if number of items is too big (default
1000), the edit form is not displayed.

In perl script, when number of items is too big, template var "item_loop" is
not defined and var "too_many_items"is set.

This patch allows the display of edit form and text "The following barcodes
were found: " even when number of items is too big.

Test plan :
- Create a file with 11 existing barcodes and 1 not existing in catalogue
- Set syspref MaxItemsForBatch to 1000
- Go to  Tools > Batch item modification
- Select "Barcode file" and upload file
- Click on continue
=> you see a warning with the not found barcode, a table with found items and
the edit form
- Set syspref MaxItemsForBatch to 10
- Go to  Tools > Batch item modification
- Select "Barcode file" and upload file
- Click on continue
=> you see a warning with the not found barcode and a text "Too many items ..."
=> Without patch you don't see the edit form
=> With patch you see the edit form and can perform the batc modifications

-- 
You are receiving this mail because:
You are watching all bug changes.