[Koha-bugs] [Bug 15104] Batch Record Modification Performance Improvement

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 44446
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44446
Bug 15104: Batch Record Modification Performance Improvement

Review of attachment 44446:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15104&attachment=44446)
-----------------------------------------------------------------

::: C4/Biblio.pm
@@ +307,4 @@
>      }
>  
>      if ( C4::Context->preference("CataloguingLog") ) {
> +        logaction( "CATALOGUING", "MODIFY", $biblionumber, "biblio BEFORE=>" . $record->as_formatted );

You are logging the modified record, not the original one.

::: tools/batch_record_modification.pl
@@ +157,4 @@
>      my ( $job );
>      if ( $runinbackground ) {
> +        $job_size = scalar( @record_ids );
> +        $job = C4::BackgroundJob->new( $sessionID, "FIXME", $ENV{SCRIPT_NAME}, $job_size );

Wrong change, your are reintroducing old lines (see bug 15005).

@@ +183,4 @@
>      my $progress = 0;
>      $dbh->{RaiseError} = 1;
>      RECORD_IDS: for my $record_id ( sort { $a <=> $b } @record_ids ) {
> +        $progress++;

There is a ++$progress later, you are incrementing twice the same variable in
the same block.

-- 
You are receiving this mail because:
You are watching all bug changes.