[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #27 from Francois Charbonnier <francois.charbonnier at inlibro.com> ---
(In reply to Jonathan Druart from comment #26)
> Comment on attachment 44826 [details] [review]
> Bug 12528 - Enable staff to deny message setting access to patrons on the
> OPAC
> 
> Review of attachment 44826 [details] [review]:
> -----------------------------------------------------------------
> 
> The description for EnhancedMessagingPreferences is "allow/don't allow
> patrons to choose which notices they receive and when they receive them.
> I think it could be updated to highlight that it's for the staff interface
> only, or at least a reference to the new pref?

You're right. We will change the preference description.
It will be :

[Allow/Don't allow] staff to manage which notices patrons will receive and when
they will receive them. Note : this only applies to courtesy notices. To manage
if patrons have also access to these settings, use
OPACEnhancedMessagingPreferences.


> Why don't you want the patrons to show the type of messages they receive?
> I could understand not to let the patrons change the settings, but I don't
> see the point to hide them completely.

By hiding them, you avoid the question : "Why can't I change my settings by
myself?" ;^)

> ::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql
> @@ +1,3 @@
> > +INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES
> > +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo')
> > +;
> 
> It would be better to set the value of the other pref, to avoid any
> confusion.

EnhancedMessagingPreference is already setup by updatedatabase so I don't think
this should be change by the atomicupdate here. Moreover, we don't want to
change the current setting when the library will run this update.

> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
> @@ +131,5 @@
> >                      </form>
> >                  </div> <!-- / #usermessaging -->
> > +                [% ELSE %]
> > +                    <h4>You are not allowed to call this page directly</h4>
> > +                    <span> To report this problem, you can <a href="mailto:[% admin %]">email the Koha Administrator</a>.</span>
> 
> "admin" does not seem to be sent to the template.

We are currently working on this. :^)

-- 
You are receiving this mail because:
You are watching all bug changes.