[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Dec 3 09:43:47 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Francois Charbonnier from comment #27)
> > Why don't you want the patrons to show the type of messages they receive?
> > I could understand not to let the patrons change the settings, but I don't
> > see the point to hide them completely.
> 
> By hiding them, you avoid the question : "Why can't I change my settings by
> myself?" ;^)

But can answer the question "Why am I receiving email for that?"
We can imagine a quick sentence "Contact your library if you want to change
them"

> > ::: installer/data/mysql/atomicupdate/sysprefs_Bug12528.sql
> > @@ +1,3 @@
> > > +INSERT INTO systempreferences ( variable, value, options, explanation,type ) VALUES
> > > +('OPACEnhancedMessagingPreferences', '1', NULL, 'If ON, show patrons messaging setting on the OPAC.', 'YesNo')
> > > +;
> > 
> > It would be better to set the value of the other pref, to avoid any
> > confusion.
> 
> EnhancedMessagingPreference is already setup by updatedatabase so I don't
> think this should be change by the atomicupdate here. Moreover, we don't
> want to change the current setting when the library will run this update.

OPACEnhancedMessagingPreferences is added (for existing install, so in
updatedatabase.pl) and enabled.
It does not hurt if EnhancedMessagingPreference is disabled, because in the
code both are checked.
But it would be better to enable OPACEnhancedMessagingPreferences only if
EnhancedMessagingPreference is enabled too.
It will avoid to have
"OPACEnhancedMessagingPreference is enabled but not really because
EnhancedMessagingPreference is not" on the admin pref page.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list