[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is it possible both modules are not packaged for Ubuntu? I couldn't
install/find either via apt-get? 

I think the dependency questions need to be resolved first, before we can move
this further through QA!

Starting with a code review anyway:

1) QA script
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/printers.tt
   FAIL   spelling
                 recieve  ==> receive
 FAIL   misc/cronjobs/holds/print_holds.pl
   FAIL   pod
                *** ERROR: =over on line 135 without closing =back (at head1) 
in file misc/cronjobs/holds/print_holds.pl

2) New notice
a) The insert statements are missing the message_transport_type:
+INSERT INTO `letter`
(`module`,`code`,`branchcode`,`name`,`is_html`,`title`,`content`)

b) HOLD_PLACED_PRINT sounds like there is a connection to the existing
HOLD_PLACED feature. If this is the case, should this be just the 'print'
version of the HOLD_PLACED notice? And if not, should we rename to make the
difference clear?

c) Notice is missing from the translated web installers. 

3) Templates
a) Icons need to be switched to Font Awesome. For example:
koha-tmpl/intranet-tmpl/prog/en/includes/printers-toolbar.inc.

b) koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt changes the
heading and description of one of the toolbar items back to the old one, should
be: Z39.50/SRU searvers

c) I think page title/breadcrumbs and the new entry on Administration should
match. Personally I'd prefer the simpler 'Printers' to 'Printer editor' as it's
more in line with our other pages.

d) This would be nicer to translate using the newer syntax and a placeholder:
 else if (confirm(_("Are you sure you wish to delete printer(s) ") +
idsToDelete + "?"))
See: Bug 12138 - Use placeholders in translatable javascript strings

4) Terminology 
Holds!! :)
koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/printers.tt
print automatic reserve notices

5) Copyright
Is the copyright correct on the new file svc/printer?
+# Copyright 2014 ByWater Solutions
+# Copyright 2012 Foundations Bible College Inc.

-- 
You are receiving this mail because:
You are watching all bug changes.