[Koha-bugs] [Bug 14153] Noisy warns in admin/transport-cost-matrix.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153

--- Comment #2 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 38880
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38880
Bug 14153: Noisy warns in admin/transport-cost-matrix.pl

Review of attachment 38880:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14153&attachment=38880)
-----------------------------------------------------------------

::: admin/transport-cost-matrix.pl
@@ +42,4 @@
>                              });
>  my $use_transport_cost_matrix = C4::Context->preference("UseTransportCostMatrix");
>  
> +my $update = {$input->param('op')} eq 'set-cost-matrix';

Adding the curly brace here means that the code is trying to create an
anonymous hash containing the contents of $input->param('op'), and that can't
be compared to the scalar value 'set-cost-matrix'. Also, when trying to update
an entry in the table, an "Odd number of elements in anonymous hash" error is
thrown.

Something like this would do the trick:

my $update = ( $input->param('op') // '' ) eq 'set-cost-matrix';

-- 
You are receiving this mail because:
You are watching all bug changes.