[Koha-bugs] [Bug 12529] Overdue notices do not respect holidays

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 30622
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30622
[PASSED QA] Bug 12529: Add a syspref to make overdue notices respect holidays

Review of attachment 30622:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12529&attachment=30622)
-----------------------------------------------------------------

::: misc/cronjobs/overdue_notices.pl
@@ +422,5 @@
>  foreach my $branchcode (@branches) {
> +    if ( C4::Context->preference('OverdueNoticeCalendar') ) {
> +        my $calendar = Koha::Calendar->new( branchcode => $branchcode );
> +        if ( $calendar->is_holiday($date_to_run) ) {
> +            next;

Why do we skip the library is today is holiday?
It seems that should only be done if --triggered|-t is given.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.