[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Whaou, an ajax request looks like a bit overkill imo...
Anyway, now it's done.

Quick QA comments:
1/ catch error when retrieving the answer of the ajax request (empty .hint)
2/ CalculateAge should only be done if CheckDate return success (otherwise
empty .hint)
3/ Use string_var.format(number) in JS code to display the string
4/ Why do you use gettext? pass age_month and age_year to the template and let
it display/translate the string accordingly
5/ I think "year(s)" could be replaced with "year" :) And manage the plural for
month/months should not be too difficult.

-- 
You are receiving this mail because:
You are watching all bug changes.