[Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45326|0                           |1
        is obsolete|                            |

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 45723
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45723&action=edit
[SIGNED-OFF] Bug 10163 - batch-mod items tool fails on files over 1000 lines
long

When using batch modification tool, if number of items is too big
(default 1000), the edit form is not displayed.

In perl script, when number of items is too big, template var
"item_loop" is not defined and var "too_many_items"is set.

This patch allows the display of edit form and text "The following
barcodes were found: " even when number of items is too big.

Test plan :
- Create a file with 11 existing barcodes and 1 not existing in
  catalogue
- Set syspref MaxItemsForBatch to 1000
- Go to  Tools > Batch item modification
- Select "Barcode file" and upload file
- Click on continue
  => you see a warning with the not found barcode, a table with found
     items and the edit form
- Set syspref MaxItemsForBatch to 10
- Go to  Tools > Batch item modification
- Select "Barcode file" and upload file
- Click on continue
  => you see a warning with the not found barcode and a text "Too many
     items ..."
  => Without patch you don't see the edit form
  => With patch you see the edit form and can perform the batc
     modifications

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Test plan followed successfully. Item modifications completed correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.