[Koha-bugs] [Bug 15243] Place a hold on... Fix display issue and improve translatability

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15243

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Tests made on french interface on sandbox (so Reserves.t have not been checked)

1) Too many holds : Seems ok under the aspect of the limit number but part of
translation has not been set in staff interface
test with maxreserves syspref = 1
message STAFF :
Impossible de réserver
Trop de réservations : Bruno B121 can only place a maximum of total 1 holds.
OPAC
Désolé, vous ne pouvez faire plus de 1 réservations.

2) Too many holds : on staff interface the hold is blocked as expected but the
limit displayed does not correspond to the one set in circulation rules.
                    on opac, the message is not correct.
tested with reserves=2 set in circulations rules, "pukapuka" branch, type
LIVRE. maxreserves=10. 
message STAFF
Impossible de réserver
Trop de réservations : Bruno B121 can only place a maximum of total 5 holds.
OPAC
Pas d'exemplaire disponible.

3) Already in possession : ok
AllowHoldsOnPatronsPossessions syspref set to "not allow"
message STAFF :
Impossible de réserver
Already in possession: Benjamin B111 has already one item checked out.
message OPAC :
Désolé, aucune réservation possible sur ces documents.
....
Ce titre ne peut pas être réservé car il est déjà en votre possession.

4) Hold already placed : OK as for the message displayed, but here again, part
of staff message is not translated.
message STAFF :
Impossible de réserver
Hold already placed: Bruno B121 already has a hold on this item.
message OPAC :
Vous avez déjà ce titre en réservation.

5) Age restricted and No items available
I dont't find how to produce theese messages. Can you give details ?

Conclusion : Sorry, I can't sign off because of point 2. 
Maybe the incorrect translations come from a pure translation error, but maybe
they are due to the Html splitting.

Aesthetic remark (slightly ergonimic too, even I'm asking too much), that would
be better to have only one frame for the messages (the generic and the precise
one) 
like this :
Désolé, aucune réservation possible sur ces documents.
Ce titre ne peut pas être réservé car il est déjà en votre possession :

Chercher la petite bête by Olliver C.

rather than this :
Désolé, aucune réservation possible sur ces documents.

Ce titre ne peut pas être réservé car il est déjà en votre possession.

Chercher la petite bête by Olliver C.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.