[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Frédéric Demians from comment #4)
> For me what happens here is the same field as what you have observed with
> system preferences. We have information serialized in the relational DB model
> (so a lot of linked tables) which could be more easily represented in other
> data structures. Koha is requesting ad nauseam multiple tables. I fear that
> your patches are just overcomplexifying something which is already far too
> complex. It's becoming byzantines. Finally, you're creating multiples classes
> to access data found in one table (auth_types) which can contain up to 10
> records.

I am following the same design for all admin scripts.
I create a Koha::Object then use it for CRUD when it is possible to use it
quickly.
I have reduced the code to 2/3 and remove 4 subroutines in the deprecated C4
namespace, I think it is the way to go, and don't think it's overcomplexifying
the area.
If we will need to return auth types in another structure, it will be easy to
create a new method in Koha::Authority::Types.

-- 
You are receiving this mail because:
You are watching all bug changes.