[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking a bit deeper into this, I think there is a confusion about the data in
the reserves table:

reserves.expirationdate is NOT the date when a hold expires for pick-up. It's
the date the user set for not needing the hold any longer when placing it. It
should probably be used to automatically cancel holds.
I think this one should always display as it is in the database and the old
feature was built on a wrong assumption about the existing column.

What we would need additionally is a 'pickup-expirationdate'. We don't have a
column for this in the reserves table currently. So we can either introduce a
new column or calculate it to be put in the notices on the fly. 

And only this date should then take the ReservesMaxPickUpDelay into account and
be calculated like Kyle says: waitingdate + ReservesMaxPickUpDelay. It shoudl
also probably take the calendar into account in some way, maybe by using
methods like the useDaysMode preference.

-- 
You are receiving this mail because:
You are watching all bug changes.