[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 45903
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45903
Bug 15381: Fix error in SearchAuthorities when no authtypecode

Review of attachment 45903:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15381&attachment=45903)
-----------------------------------------------------------------

::: C4/AuthoritiesMarc.pm
@@ +291,5 @@
>          my %newline;
>          $newline{authid} = $authid;
>          if ( !$skipmetadata ) {
> +            my $auth_tag_to_report;
> +            $auth_tag_to_report = Koha::Authority::Types->find($authtypecode)->auth_tag_to_report

Does this not just move the error further downstream in the code, as you will
now just be passing an undefined $auth_tag_to_report to line 298 instead. 
Under what circumstance might $authtypecode be undefined in the first place?

-- 
You are receiving this mail because:
You are watching all bug changes.