[Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Dec 23 10:59:45 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 45888
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45888
Bug 4078 - Display active currency symbol on currency output and input

Review of attachment 45888:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=4078&attachment=45888)
-----------------------------------------------------------------

You will have to write tests.

I don't think it's the good approach. What about the other cases?
For instance : "-£127.54" vs "-127,54 €", you will have to add 3 values.
I think that what you are trying to add with this patch should be done at the
currency level (currency table), not the syspref.
Actually the syspref should be removed.

::: Koha/Number/Price.pm
@@ +79,4 @@
>  
>  sub _format_params {
>      my ( $self, $params ) = @_;
> +    my $with_symbol = $params->{with_symbol};

You do you remove this default value, it does not look mandatory.

@@ +96,5 @@
> +        $p_cs_precedes = 1 unless ( defined $p_cs_precedes );
> +    }
> +
> +    if ( $currency_format =~ m/(_TRAIL)/ ) {
> +        $p_cs_precedes = 0 unless ( defined $p_cs_precedes );

You are mixing ternary operator in the conditions, it does not make the code
easy to read.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list