[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hector:
Thanks for your patch.
I think we still need some changes before moving this to PQA:

[1] The encoding problem is imo concentrated in these lines:

Around line 155 we should do:
print $cgi->header( -type =>'application/xml', -charset => 'UTF-8' );
Add the character set ! (Maybe this is needed a few times more..)

Around line 147 we should use chars instead of toString:
# $content = $record_dom->toString();
$content = $transformer->output_as_chars( $record_dom );

According to my testing that should resolve the encoding problem. Note that I
would prefer to stick to the binmode statement and not add the decodes.

[2] The change from 406 to 400 is arguable. Why change it now?

[3] Do not redirect to other Koha scripts. This is a separate unAPI
implementation. What does unAPI exactly say about such statuses? (I could not
reach its site for now..) Note that the browser may affect the results
displayed too. I saw differences here between FF and IE.

-- 
You are receiving this mail because:
You are watching all bug changes.