[Koha-bugs] [Bug 15438] New: Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

            Bug ID: 15438
           Summary: Checking out an on-hold item sends holder's
                    borrowernumber in AF (screen message) field.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Replicated in master.

Description: Let's say that 'Holding Patron' puts a hold on title 'ASDF'. If
'SIP  Patron' then tries to check out ASDF, Holding Patron's card number
appears in the AF (i.e. Screen Message) field. This only occurs if the hold has
*not* yet been finalized -- If ASDF is waiting for Holding Patron, the screen
message will read "Item is on hold shelf for another patron."

The screen message containing only the Holding Patron's borrowernumber is
confusing because a) It contains no context as to the nature of the number
showing on the screen b) SIP devices work with borrower card numbers, so the
number being returned has the wrong context. Furthermore, we're leaking patron
information in a place where we probably would never check.

Replicating the problem:

Set up instance with two patrons, as well as a bib/item to put on hold/check
out.
Make sure that circ rules allow holds.
Set up SIPconfig.xml to allow checkouts on the IP/port of your choice.
Start SIP2. Make sure that authentication, checkin and check out work for the
'SIP Patron'.
Ensure that AllowItemsOnHoldCheckout is set to "Don't Allow".

In the steps to replicate, the Title/barcode of the item on hold/being checked
out will be 'asdf'. The Holding Patron will be referred to as 'holder' and the
checkout patron will be referred to as 'sipper'. Let's say that sipper's
borrowernumber is 52.

1/ Place a biblio level hold for asdf, with holder as the holding patron.
2/ Start `sudo tail -f /var/log/syslog | grep sip`
3/ Attempt to check out asdf to sipper. You will see the sip checkout message
'11...' followed by a '120...|AF52|...' sip checkout response. This indicates
that the checkout has failed (which we would expect), and that the screen
message is '52'.

Example using ./misc/sip_cli_emulator.pl

$ ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su staff -sp staff -l CPL
--patron 23529001223636
--password 1234 --item 1234 -m checkout
Attempting socket connection to 127.0.0.1:6001...connected!
SEND: 9300CNstaff|COstaff|CPCPL|
READ: 941

Trying 'checkout'
SEND: 11YN20151229    05321120151229   
053211AOCPL|AA23529001223636|AB1234|ACstaff|AD1234|BON|BIN|
READ: 120NUN20151229    053211AOCPL|AA23529001223636|AB1234|AJTheories of human
development :|AH|AF52|BLY|BV5.00|BHUSD|BT06|

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.