[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Dec 30 13:47:47 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45994|0                           |1
        is obsolete|                            |

--- Comment #7 from Frédéric Demians <frederic at tamil.fr> ---
Created attachment 46072
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46072&action=edit
Bug 15429 - sub _parseletter should not change referenced values

In C4/Letters.pm, sub _parseletter changes values that are passed by
reference. E.g. patron's expiry date can change from iso format to
syspref format, leading to strange behaviour in the calling routines
(see Bug 15423).

This patch makes sub _parseletter work on a copy of the referenced values.

(Submitted to get feedback - is this the way to go?)

Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
  Good solution to real time bomb.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list