From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 04:35:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 03:35:40 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 11:54:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 10:54:57 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 --- Comment #8 from Marc V?ron --- Created attachment 35648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35648&action=edit [Signed-off] Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. REPLICATE THE ISSUE: 1. Find a Borrower. 2. Go to the details-tab. 3. Under "Patron messaging preferences" click edit to edit just the messaging preferences. 4. Just save, no need to make any modifications. 5. Observe the error "Username/password already exists" This happens to all/most of the sub-forms in the Borrower's Details-view. AFTER THIS PATCH: Check_Userid() get the $userid from the new parameters, or if not present, from the koha.borrowers-table. TEST FOR REGRESSION: 1. Edit a borrower normally. Notice no errors. 2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no errors. DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's extent without my permission. As long as it makes to Koha I am happy. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 11:55:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 10:55:41 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 11:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 10:56:15 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35437|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 21:54:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 20:54:00 +0000 Subject: [Koha-bugs] [Bug 13626] Permission for "forgive fines on return" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Marjorie, I think the 'waive fines' permission could work there. If you don't want to use the feature at all, we could also try helping you to hide it with css or jquery. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 21:57:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 20:57:18 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Label/patron card printing |Database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 22:03:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 21:03:27 +0000 Subject: [Koha-bugs] [Bug 13627] Urdu Language Support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Muhammed, there are known problems with the PDF functionality and Unicode characters, see bug 2246. *** This bug has been marked as a duplicate of bug 2246 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 22:03:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 21:03:27 +0000 Subject: [Koha-bugs] [Bug 2246] Label printing doesn't work with Unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.naveed789 at gmail.com --- Comment #20 from Katrin Fischer --- *** Bug 13627 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 22:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 21:33:44 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 22:33:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 21:33:47 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35635|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 35649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35649&action=edit [PASSED QA] Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. Followed test plan. Icon displays as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as described, good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 22:45:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 21:45:07 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 --- Comment #9 from Katrin Fischer --- Created attachment 35650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35650&action=edit [PASSED QA] Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. REPLICATE THE ISSUE: 1. Find a Borrower. 2. Go to the details-tab. 3. Under "Patron messaging preferences" click edit to edit just the messaging preferences. 4. Just save, no need to make any modifications. 5. Observe the error "Username/password already exists" This happens to all/most of the sub-forms in the Borrower's Details-view. AFTER THIS PATCH: Check_Userid() get the $userid from the new parameters, or if not present, from the koha.borrowers-table. TEST FOR REGRESSION: 1. Edit a borrower normally. Notice no errors. 2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no errors. DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's extent without my permission. As long as it makes to Koha I am happy. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 22:48:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 21:48:17 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 22:48:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 21:48:21 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35648|0 |1 is obsolete| | Attachment #35650|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 35651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35651&action=edit [PASSED QA] Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. REPLICATE THE ISSUE: 1. Find a Borrower. 2. Go to the details-tab. 3. Under "Patron messaging preferences" click edit to edit just the messaging preferences. 4. Just save, no need to make any modifications. 5. Observe the error "Username/password already exists" This happens to all/most of the sub-forms in the Borrower's Details-view. AFTER THIS PATCH: Check_Userid() get the $userid from the new parameters, or if not present, from the koha.borrowers-table. TEST FOR REGRESSION: 1. Edit a borrower normally. Notice no errors. 2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no errors. DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's extent without my permission. As long as it makes to Koha I am happy. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:00:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:00:35 +0000 Subject: [Koha-bugs] [Bug 13650] New: Parenthesis in subject links problematic for search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Bug ID: 13650 Summary: Parenthesis in subject links problematic for search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Searching Assignee: wsalesky at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:13:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:13:25 +0000 Subject: [Koha-bugs] [Bug 13650] Parenthesis in subject links problematic for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:14:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:14:18 +0000 Subject: [Koha-bugs] [Bug 13650] Parenthesis in subject links problematic for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:14:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:14:33 +0000 Subject: [Koha-bugs] [Bug 13650] Parenthesis in subject links problematic for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:14:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:14:36 +0000 Subject: [Koha-bugs] [Bug 13650] Parenthesis in subject links problematic for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 --- Comment #1 from Katrin Fischer --- Created attachment 35652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35652&action=edit [PASSED QA] Bug 13650: Remove parens from links to fix searches This patch will resolve the issue of not being able to search with parens in a subject heading by editing the xslt To test: * Apply patch * Search Koha for a title with ( ) in the subject * Click the subject * Results should be returned * Repeat in OPAC and Staff client Signed-off-by: Nick Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:17:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:17:06 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #35646|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Comment on attachment 35646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35646 [SIGNED OFF] Bug 1807: Remove parens from links to fix searches Hi Winona, don't worry, your patch hasn't gone missing! I moved it to bug 13650, as it deals with the subject links perfectly, but didn't fix the general problem that entering search terms with () is a problem. I'd like to keep this bug open in hope that gets fixed too at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:17:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:17:27 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13650 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:17:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:17:27 +0000 Subject: [Koha-bugs] [Bug 13650] Parenthesis in subject links problematic for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=1807 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:21:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:21:10 +0000 Subject: [Koha-bugs] [Bug 9212] Parentheses in subject headings break search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- Sorry, I missed this at first glance and created bug 13650, which is a different approach to fixing this that seems to avoid the problems Marcel found nicely. I tested with different variations of TraceCompleteSubfields and TraceSubjectSubdivisions and didn't find any problems. Marking this duplicate. *** This bug has been marked as a duplicate of bug 13650 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:21:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:21:10 +0000 Subject: [Koha-bugs] [Bug 13650] Parenthesis in subject links problematic for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Katrin Fischer --- *** Bug 9212 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:21:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:21:56 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED Assignee|wsalesky at gmail.com |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 1 23:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Feb 2015 22:22:02 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 05:35:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 04:35:18 +0000 Subject: [Koha-bugs] [Bug 13651] New: Provision for monthly library fee Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 Bug ID: 13651 Summary: Provision for monthly library fee Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Dear Developers, Many public libraries charge monthly subscription fee (e.g. INR 30 per month)for patrons. We would like to see a provision for charging monthly fee in coming version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 05:35:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 04:35:39 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |new feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 05:46:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 04:46:18 +0000 Subject: [Koha-bugs] [Bug 13652] New: Need the display of fine amount against each book Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13652 Bug ID: 13652 Summary: Need the display of fine amount against each book Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 35653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35653&action=edit Checkout box screenshot Dear Developers, Outstanding fee total now display on check out window. If it display against each book, convenient for library staff to find amount for each book. No need to go 'Fines' section to tell each books fine amount. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 07:58:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 06:58:46 +0000 Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I thought that we'd officially deprecated GRS1 and that it was scheduled for removal? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 08:58:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 07:58:18 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #6 from M. de Rooy --- (In reply to Kyle M Hall from comment #5) > I think the best solution would be to automatically strip times from items > due at 23:59 > > Would this not solve the issue completely without the need for any special > markup? This patch offers more than the due date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 08:59:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 07:59:26 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 --- Comment #11 from M. de Rooy --- (In reply to Kyle M Hall from comment #10) > I think the best solution would be to automatically strip times from items > due at 23:59 Could be. But imo it is in the same ad-hoc category as the proposed solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 09:49:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 08:49:16 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 09:51:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 08:51:36 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 09:53:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 08:53:57 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 09:59:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 08:59:45 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 10:08:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 09:08:14 +0000 Subject: [Koha-bugs] [Bug 13652] Need the display of fine amount against each book In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi vimal, the charge columns is used for rental fees - that's why it's displaying 0 in your example screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 10:42:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 09:42:46 +0000 Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 --- Comment #3 from Jonathan Druart --- Hello David, I found this bug because we have backported bug 11944 on 3.18.x for a customer. I thought this patch would be useful to someone else, that why I submitted it here. I don't mind if it is not pushed to master, but since it's a fix for bug 11944, it could be helpful to have it, for the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 10:55:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 09:55:37 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #31 from Katrin Fischer --- Hi Robin, having a discussion about his on IRC right now - we are all quite curious about your work - could you write up some installation docs and/or a summary what the ES patches will include/not include? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 11:18:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 10:18:19 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 14:33:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 13:33:32 +0000 Subject: [Koha-bugs] [Bug 13653] New: Check in error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13653 Bug ID: 13653 Summary: Check in error Change sponsored?: --- Product: Koha Version: unspecified Hardware: Macintosh OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: smonaghen at usd259.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When checking in items we receive the following error. Looking for how to fix. The only solution is the use the back button, or a link to the main home page. Software error: Can't bless non-reference value at /usr/share/koha/lib/C4/ItemType.pm line 64. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. Items are checked in, but the error message pops up every time an item is returned. System Details as reported by Koha: Server information Koha version: 3.19.00.006 OS version ('uname -a'): Linux kohaimac 3.2.0-4-amd64 #1 SMP Debian 3.2.65-1+deb7u1 x86_64 GNU/Linux Perl interpreter: /usr/bin/perl Perl version: 5.014002 Perl @INC: /usr/share/koha/lib /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl . MySQL version: mysql Ver 14.14 Distrib 5.5.41, for debian-linux-gnu (x86_64) using readline 6.2 Apache version: Server version: Apache/2.2.22 (Debian) Zebra version: Zebra 2.0.44 (C) 1994-2010, Index Data ApS Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: 419ad759807269fdfa379799a051ed3a551c6541 Using ICU -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 15:28:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 14:28:49 +0000 Subject: [Koha-bugs] [Bug 13652] Need the display of fine amount against each book In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13652 --- Comment #2 from vimal kumar --- I know about rental columns, its nice separate columns for book dues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 15:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 14:35:00 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 --- Comment #1 from Owen Leonard --- I think Koha can already do what you want: Set up a patron category which has an enrollment period of one month and an enrollment fee of INR 30. Each month the patron's account will expire. When you renew the account the fee will be automatically added. If that sounds like what you need please mark this bug as resolved-invalid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 15:39:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 14:39:47 +0000 Subject: [Koha-bugs] [Bug 13653] Check in error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13653 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- Since checking items in is a feature which is known to work this sounds like a support request rather than a bug report. Support requests should be made on the Koha mailing list, on IRC, or by contracting with a support vendor. All these options are linked to here: http://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 16:25:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 15:25:08 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #32 from Jonathan Druart --- (In reply to Robin Sheat from comment #30) > (In reply to Jonathan Druart from comment #29) > > Try with the lastest (1.4.2): > > > > $ wget > > https://download.elasticsearch.org/elasticsearch/elasticsearch/elasticsearch- > > 1.4.2.deb > > For what it's worth, I'm using 1.3.7 which is the latest stable. I wouldn't > think that would make a difference really though. Will try with 1.3.7, but I believe I got the same error as before ( with this version. > Sitting on "committing" is consistent with not being able to talk to the ES > server, and there's currently no error handling for that (I'd expect it to > time out eventually, but who knows how long that'll take.) If I were you, > that's where I'd start looking. Make sure you can hit it with curl, and that > the config in koha-conf.xml is correct. fwiw, mine is: > > > koha-es:9200 > koha_robin > Yes, I have something similar: 303 304 http://localhost:9200/ 305 koha_instance 306 > If you're keen, fire it up in the debugger (perl -d) and do: > > c Catmandu::Store::ElasticSearch::Bag::commit Actually it never reach commit: % perl -d misc/search_tools/rebuild_elastic_search.pl Loading DB routines from perl5db.pl version 1.44 Editor support available. Enter h or 'h h' for help, or 'man perldebug' for more help. main::(misc/search_tools/rebuild_elastic_search.pl:92): 92: my $verbose = 0; DB<1> c Catmandu::Addable::add_many Indexing biblios 3 Catmandu::Addable::add_many(/usr/share/perl5/Catmandu/Addable.pm:84): 84: my ($self, $many) = @_; DB<2> n Catmandu::Addable::add_many(/usr/share/perl5/Catmandu/Addable.pm:86): 86: if (is_hash_ref($many)) { DB<2> Catmandu::Addable::add_many(/usr/share/perl5/Catmandu/Addable.pm:91): 91: if (is_array_ref($many)) { DB<2> Catmandu::Addable::add_many(/usr/share/perl5/Catmandu/Addable.pm:96): 96: if (is_invocant($many)) { DB<2> Catmandu::Addable::add_many(/usr/share/perl5/Catmandu/Addable.pm:97): 97: $many = check_able($many, 'generator')->generator; DB<2> Catmandu::Addable::add_many(/usr/share/perl5/Catmandu/Addable.pm:100): 100: check_code_ref($many); DB<2> Catmandu::Addable::add_many(/usr/share/perl5/Catmandu/Addable.pm:102): 102: my $data; DB<2> Catmandu::Addable::add_many(/usr/share/perl5/Catmandu/Addable.pm:103): 103: my $n = 0; DB<2> Catmandu::Addable::add_many(/usr/share/perl5/Catmandu/Addable.pm:104): 104: while (defined($data = $many->())) { DB<2> use Data::Dumper; warn Dumper $many; $VAR1 = sub { "DUMMY" }; at (eval 1256)[/usr/share/perl/5.20/perl5db.pl:732] line 2. eval 'no strict; ($@, $!, $^E, $,, $/, $\\, $^W) = @DB::saved;package Catmandu::Addable; $^D = $^D | $DB::db_stop; use Data::Dumper; warn Dumper $many;; ' called at /usr/share/perl/5.20/perl5db.pl line 732 DB::eval called at /usr/share/perl/5.20/perl5db.pl line 3094 DB::DB called at /usr/share/perl5/Catmandu/Addable.pm line 104 Catmandu::Addable::add_many(Catmandu::Store::ElasticSearch::Bag=HASH(0xd5c503c), Catmandu::Iterator=CODE(0xc565080)) called at Koha/ElasticSearch/Indexer.pm line 80 Koha::ElasticSearch::Indexer::update_index(Koha::ElasticSearch::Indexer=HASH(0xcd60c00), ARRAY(0xca8ca80), ARRAY(0xca8cae4)) called at misc/search_tools/rebuild_elastic_search.pl line 184 main::do_reindex(CODE(0xcae4dc0), "biblios") called at misc/search_tools/rebuild_elastic_search.pl line 132 DB<3> warn ref($many); CODE at (eval 1257)[/usr/share/perl/5.20/perl5db.pl:732] line 2. at (eval 1257)[/usr/share/perl/5.20/perl5db.pl:732] line 2. eval 'no strict; ($@, $!, $^E, $,, $/, $\\, $^W) = @DB::saved;package Catmandu::Addable; $^D = $^D | $DB::db_stop; warn ref($many);; ' called at /usr/share/perl/5.20/perl5db.pl line 732 DB::eval called at /usr/share/perl/5.20/perl5db.pl line 3094 DB::DB called at /usr/share/perl5/Catmandu/Addable.pm line 104 Catmandu::Addable::add_many(Catmandu::Store::ElasticSearch::Bag=HASH(0xd5c503c), Catmandu::Iterator=CODE(0xc565080)) called at Koha/ElasticSearch/Indexer.pm line 80 Koha::ElasticSearch::Indexer::update_index(Koha::ElasticSearch::Indexer=HASH(0xcd60c00), ARRAY(0xca8ca80), ARRAY(0xca8cae4)) called at misc/search_tools/rebuild_elastic_search.pl line 184 main::do_reindex(CODE(0xcae4dc0), "biblios") called at misc/search_tools/rebuild_elastic_search.pl line 132 DB<4> n And nothing else (no CPU activity neither). the ref($many) returning "CODE" does not smell good :) continuing DB<4> n ^CqMARC::File::USMARC::_next(/usr/share/perl5/MARC/File/USMARC.pm:53): 53: local $/ = END_OF_RECORD; DB<4> q % pmvers MARC::File::USMARC /usr/bin/pmvers: unknown version for module `MARC::File::USMARC' hum... Since I installed it using the CPAN first, I removed it: % sudo cpanm -U Catmandu::Importer::MARC [...] Successfully uninstalled Catmandu::Importer::MARC % dpkg -l libcatmandu-marc-perl ii libcatmandu-marc-perl | 0.206-2 | all | modules for working with MARC data within the Catmandu framework % perl misc/search_tools/rebuild_elastic_search.pl [lot of logs] 25888 records indexed. \o/ Sorry about that! I should have tried pmpath MARC::File::USMARC to catch the problem quickly. Now, search records! OPAC: cgi-bin/koha/opac-search.pl returns Can't locate Koha/ElasticSearch/Search.pm in @INC It's seem to be caused by the last commit Bug 12478 - authority work in progress diff --git a/Koha/ElasticSearch/Search.pm b/Koha/ElasticSearch/Search.pm deleted file mode 100644 I tried to fix some compilation errors (patch coming), but the branch looks to be let in an unusable state. The next error is: Can't locate object method "mk_accessors" via package "Koha::SearchEngine::ElasticSearch::Search" I don't want to continue and add conflicts with something you have already fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 16:26:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 15:26:26 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #33 from Jonathan Druart --- previous comment tldr: indexing: OK searching: KO, branch in an unusable state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 16:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 15:27:14 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #34 from Jonathan Druart --- Created attachment 35654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35654&action=edit Bug 12478: fix some compilation errors Feel free to obsolete this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 16:42:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 15:42:37 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #33 from Fridolin SOMERS --- (In reply to Amit from comment #32) > Hi Owen, > > I have written some test cases will share by this monday. Up, have you these tests ? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 16:49:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 15:49:12 +0000 Subject: [Koha-bugs] [Bug 13638] Batch patron modification tool missing option to switch language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 16:49:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 15:49:21 +0000 Subject: [Koha-bugs] [Bug 13638] Batch patron modification tool missing option to switch language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35633|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 35655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35655&action=edit Bug 13638 - Batch patron modification tool missing option to switch language The batch patron modification tool's template was created without the footer include at the bottom. Without the footer include the language toolbar will not be displayed. All page templates should include the global footer include: [% INCLUDE 'intranet-bottom.inc' %] To test: - Install at least a second language - Enable at least 2 languages (language system preference) - Go to tools > Batch patron modification - Verify that at the bottom of the page the language chooser is shown Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 16:58:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 15:58:20 +0000 Subject: [Koha-bugs] [Bug 13654] New: Cannot place a hold for biblio with too many Items to display unless viewing them all. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Bug ID: 13654 Summary: Cannot place a hold for biblio with too many Items to display unless viewing them all. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org REPLICATE: 1. Find a Biblio with many Items. 2. Set the system preference "OpacMaxItemsToDisplay" to something less than the amount of Items the Biblio has, but more than 0. 3. Go to the OPAC-details.pl -page for the Biblio. 4. Observe the notification "This record has many physical items (??). Click here to view them all." and the missing "Place hold" on the rightmost frame. 5. Clicking the "view them all"-button enables the "Place hold"-button. Quick hack is provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 16:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 15:59:16 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many Items to display unless viewing them all. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35656&action=edit Bug 13654 - Cannot place a hold for biblio with too many Items to display unless viewing them all. Certainly not a complete fix, but makes it possible to place holds on Serial Items again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:03:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:03:41 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many Items to display unless viewing them all. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |olli-antti.kivilahti at jns.fi --- Comment #2 from Owen Leonard --- Please remember to include the bug number, description, and test plan in your patch's commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:12:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:12:41 +0000 Subject: [Koha-bugs] [Bug 12472] Unit Tests failing with "MySQL server has gone away" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13610 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:12:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:12:41 +0000 Subject: [Koha-bugs] [Bug 13610] delete_patrons.pl crashes on debian squeeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12472 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:14:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:14:57 +0000 Subject: [Koha-bugs] [Bug 13610] delete_patrons.pl crashes on debian squeeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13610 --- Comment #5 from Jonathan Druart --- The patch on bug 12472 fixes the problem (at least for the script I submitted). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:20:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:20:13 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from vimal kumar --- Thank you for the information. I will share the information to public library people. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:25:26 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:37:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:37:43 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 --- Comment #11 from Jonathan Druart --- Comment on attachment 35651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35651 [PASSED QA] Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences Review of attachment 35651: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13602&attachment=35651) ----------------------------------------------------------------- ::: members/memberentry.pl @@ +329,5 @@ > } > } > + # Check if the userid is unique. Userid might not always be present in the edited values list when editing certain sub-forms, so we need to dig for it a bit. > + my $userid = $newdata{'userid'}; > + $userid = $borrower_data->{userid} unless $userid; #Get the userid straight from the DB In my opinion, my $userid = $newdata{userid} ? $newdata{userid} : $borrower_data->{userid}; or my $userid = $newdata{userid}; $userid ||= $borrower_data->{userid}; Would have been more readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:45:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:45:00 +0000 Subject: [Koha-bugs] [Bug 13655] New: Can't save organisation type patron without entering userid/password Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Bug ID: 13655 Summary: Can't save organisation type patron without entering userid/password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Ran into another problem here - if you leave the password/userid empty on creating a new organisation type patron, you get an error message. Koha should be able to create a userid for organisation patrons (no firstname) too or leave it empty (ILL libraries etc. don't need a login). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:45:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:45:21 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13655 --- Comment #12 from Katrin Fischer --- Ran into another problem here - if you leave the password/userid empty on creating a new organisation type patron, you get an error message. It should totally be possible to create users with no login or let Koha create the userid automatically. (Filed a new bug 13655) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 17:45:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 16:45:21 +0000 Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without entering userid/password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13602 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 18:10:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 17:10:35 +0000 Subject: [Koha-bugs] [Bug 13656] New: "Change" button for linking a member to an organisation not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13656 Bug ID: 13656 Summary: "Change" button for linking a member to an organisation not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr "Change" button for linking a member to an organisation on patron edit form is not translatable. To test: - install and activate an additional langauge - create a organisation type patron - create a member of organisation type patron - link second patron to your created organisation patron - verfiy the "change" button is not translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 18:18:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 17:18:52 +0000 Subject: [Koha-bugs] [Bug 13657] New: Don't show extra comma after guarantor name on patron details Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Bug ID: 13657 Summary: Don't show extra comma after guarantor name on patron details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron is linked to an organisation, the name of the 'guarantor' is shown on the patron details page in staff. An organisation has no firstname, but the template expects one and adds an extra comma after the name. Example: Garantor: Organisation, To test: - Create 2 patrons, one each for - an organisation type patron category - a member of organisation type patron category - Link both from the 'member patron' edit form - Note that the guarantor is now shown on the details tab - Verify there is an extra comma after the organisation's name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 18:19:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 17:19:02 +0000 Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name on patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 18:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 17:29:40 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many Items to display unless viewing them all. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Olli-Antti Kivilahti --- Thanks for the tip Owen, but I think this patch is far from being included to the master. I am just too busy now with stuff breaking around me to provide proper unit tests etc. The status was left to "New" on purpose. Take care. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 18:31:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 17:31:19 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many Items to display unless viewing them all. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 --- Comment #4 from Olli-Antti Kivilahti --- There must be some consequences to this modification I made. They shouldn't be dangerous, so I am waiting for feedback from our librarians. So far so good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 19:06:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 18:06:26 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |WISHLIST CC| |indradg at gmail.com Status|RESOLVED |VERIFIED --- Comment #3 from Indranil Das Gupta --- Owen: No this actually does not solve the issue. Here is why : 1/ There is often an one-time enrolment fee and then a monthly subscription in some cases. 2/ The membership categories in public libraries are often defined in Acts of the state and hence has statutory parameters. A 30-day enrolment would "solve" the problem "technically", but it will create legal non-compliance. An example: A solution as proposed will be in violation of Section 3(3) sub clause (b), Section 3 (5), Section 5 (4) sub-clause (a) and (b) of West Bengal Sponsored Public Library Management Rules, 2005 - http://www.wbpublibnet.gov.in:8080/openenrichv41/LIBRARY_new/pdf/man-rules.pdf as notified by the Government of West Bengal. 3/ Likely to complicate matter than solve it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 19:09:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 18:09:21 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P3 Severity|new feature |enhancement Component|Circulation |Patrons --- Comment #4 from Indranil Das Gupta --- Changed component to Patron (from Circulation), Importance to P3 enhancement (from 'new feature) as it calls for extending the patron category. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 19:13:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 18:13:38 +0000 Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without entering userid/password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 19:45:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 18:45:02 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4. Pushing this because I want bug 12954 which depends on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 19:45:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 18:45:38 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 19:49:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 18:49:23 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 21:00:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 20:00:25 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mpprasanth75 at gmail.com --- Comment #5 from Indranil Das Gupta --- *** Bug 9096 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 21:00:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 20:00:25 +0000 Subject: [Koha-bugs] [Bug 9096] Subscription Fee for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9096 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Status|RESOLVED |VERIFIED Resolution|INVALID |DUPLICATE --- Comment #2 from Indranil Das Gupta --- *** This bug has been marked as a duplicate of bug 13651 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 21:11:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 20:11:57 +0000 Subject: [Koha-bugs] [Bug 9096] Subscription Fee for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9096 --- Comment #3 from Indranil Das Gupta --- This enhancement probably has to be a funded/sponsored development. But the requested feature is necessary for statutory legal compliance in public libraries across India. So, changing status as VERIFIED and duplicate of 13651. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 2 22:15:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Feb 2015 21:15:09 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #35 from Robin Sheat --- (In reply to Jonathan Druart from comment #33) > previous comment tldr: > indexing: OK Yay! > searching: KO, branch in an unusable state. Yeah, I forgot to mention that sorry. Roll it back a bit, I'm in the middle of a bit of refactoring (just moving a module to a more consistent place, but I haven't updated the references to it yet), and also developing the authorities searching (though only some of that has been pushed so far.) I'll try to get it to a properly working state again today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 02:11:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 01:11:01 +0000 Subject: [Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #23 from David Cook --- (In reply to Fridolin SOMERS from comment #21) > In Biblibre Solr version of Koha, there are plugins that can be defined on > (sub)fields to perform such operations before indexing. One exists for ISBN > adding normalized and without hyphens forms. > > Note that when using ICU indexing, the hyphen is a special separator so > search with or without hyphens matchs ISBN, even adding hyphens in random > place. I don't really understand ICU indexing, but it looks like there is a specific transliteration rule in the master words-icu.xml for hyphens when they're preceded by numbers: http://userguide.icu-project.org/transforms/general#TOC-Context http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=etc/zebradb/etc/words-icu.xml;h=57498cbca4a3ea2c76399f424b792e3055dcea01;hb=HEAD It looks to me that hyphens get removed... But then as Colin Campbell points out, there is a problem searching using hyphens when using ICU: http://lists.indexdata.dk/pipermail/zebralist/2013-August/002576.html -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 02:44:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 01:44:53 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #36 from Robin Sheat --- (In reply to Robin Sheat from comment #35) > I'll try to get it to a properly working state again today. And done, it should work again. I'll try to put together a wiki page with some info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 02:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 01:46:03 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 03:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 02:49:20 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #37 from Robin Sheat --- (In reply to Robin Sheat from comment #36) > I'll try to put together a wiki page with some info. http://wiki.koha-community.org/wiki/Elasticsearch It's a quick brain dump, so feel free to update and polish if I've missed things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 05:18:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 04:18:06 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 --- Comment #6 from Prasanth M.P. --- Each month the patron's account will expire,the solution practically not possible bacause most of the members subscription fee payment lumsum in 6 months or 3 months sometime due 3 or 4 months.In this case the solution deosent work..? circulation continues.Clear subscription fee every month, most of public libraries survival is not possible.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 07:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 06:30:03 +0000 Subject: [Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 --- Comment #24 from David Cook --- I've also run into the same problem as Colin... although I've discovered that it appears to be an issue with newer versions of Zebra such as 2.0.59. Older versions such as 2.0.47 and 2.0.44 (this latter is the default in the Debian and Ubuntu repositories) seem to be unaffected. So if you installed Zebra via the Indexdata repositories or newer versions by source, you might be affected by this bug as well... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 09:47:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 08:47:38 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #38 from Jonathan Druart --- Thanks Robin for the wiki page. I have quickly tested this morning, to confirm the search works. Just some quick notes: - The indexation should commit every 1k biblio (minimum), the commit is a slow op indeed. - You have removed the use of search/results.tt in your last commit, is it intended? I am pretty sure it's not a good idea to use the same template for ES and Zebra, but maybe it's temporary. Note that there are encoding errors in facets (and in the table results also), the "Show more" link appears even if only 1 entry is displayed. I only get 2 facets: authors and itemtype. Do you plan to rebase your work against master? It would be great to see these patches on top of bug 11944. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 10:58:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 09:58:05 +0000 Subject: [Koha-bugs] [Bug 13658] New: Show 'damaged' items as available in OPAC XSLT result list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13658 Bug ID: 13658 Summary: Show 'damaged' items as available in OPAC XSLT result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org As some libraires will loan damaged items displaying the damaged items separately and in red in the OPAC is sometimes confusing. It would be nice if the damaged items could be optionally be listed as available without showing them separately in the result list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 11:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 10:08:59 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 11:09:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 10:09:02 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35636|0 |1 is obsolete| | --- Comment #3 from Jacek Ablewicz --- Created attachment 35657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35657&action=edit Bug 13645: Cache the DBIx connection We don't want to recreate a new connection to the DB every time we want a new schema. This patch creates a $database package level variable on the same way it's done in C4::Context for $dbh. Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 12:20:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 11:20:09 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #4 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #2) > Here my try. It does vastly improve Koha DBIx performace, and as far as I can tell after eyeballing it comprehensively, it rather shouldn't break anything important. So I change status to signed off. Would be nice to have some kind of test plan for it, though.. OTOH, in theory it can indirectly affect a lot of different places where Koha::Database->.. calls are being used, so any meaningfull test plan is probably out of the question anyway ;). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 12:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 11:34:51 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #5 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #4) > (In reply to Jonathan Druart from comment #2) > > Here my try. > > It does vastly improve Koha DBIx performace, and as far as I can tell after > eyeballing it comprehensively, it rather shouldn't break anything important. > So I change status to signed off. Thanks Jacek! Did you benchmark the scripts booksellers.pl and invoices.pl with this patch? > Would be nice to have some kind of test plan for it, though.. > > OTOH, in theory it can indirectly affect a lot of different places where > Koha::Database->.. calls are being used, so any meaningfull test plan is > probably out of the question anyway ;). Yes, a test plan could be: Verify there is no regression/error with scripts using a dbic connection :) Which is vague... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 12:38:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 11:38:14 +0000 Subject: [Koha-bugs] [Bug 13659] New: "stack smashing detected", when Zebra indexing a subfield with a very long (1000+) word Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13659 Bug ID: 13659 Summary: "stack smashing detected", when Zebra indexing a subfield with a very long (1000+) word Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org I encountered this when migrating another library group to Koha: *** stack smashing detected ***: /usr/bin/zebraidx terminated After a long search using the rebuild_zebra_sliced.sh I managed to isolate the culprit to a MARCXML Record with a subfield consisting of a single word with a length of ~1000 characters. A fix for this issue is to sanitate the marc-records to not contain such silly words. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 12:42:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 11:42:51 +0000 Subject: [Koha-bugs] [Bug 13659] "stack smashing detected", when Zebra indexing a subfield with a very long (1000+) word In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13659 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Olli-Antti Kivilahti --- A word of warning. Anyone with Cataloguing-permission can nuke Koha-indexing with this subfield content: "T??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??L" Having a word like this in your DB will make full reindexing a PITA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 12:51:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 11:51:59 +0000 Subject: [Koha-bugs] [Bug 13660] New: rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Bug ID: 13660 Summary: rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org When looking for a bad MARC Record using the rebuild_zebra_sliced.sh, it is useful to skip the complete MARCXML exporting from Koha and reuse the exported files for Zebra indexing. This patch adds a new parameter: -x | --exclude-export Do not export Biblios from Koha, but use the existing export-dir Which depends on the: -d | --export-dir Where rebuild_zebra.pl will export data Default: $EXPORTDIR !---------! ! TEST PLAN ! !---------! 1. Run "./rebuild_zebra_sliced.sh --length 1000" to export 1000 MARC Records and slice them to one big 1000-Record chunk. 2. Realize that you get an imaginary "stack smashing detected"-error crashing your indexing at some Record you dont know of and can't make out from the indexing logging. 3. Start looking for the bad Record by running: "./rebuild_zebra_sliced.sh --exlude-export --chunk-size 10" To skip Biblios export from Koha which takes ~2h and get straight into splitting your exported biblios to chunks of 10, and importing them. You know which chunk fails so it is much easier to find the issue there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 12:52:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 11:52:13 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13659 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 12:52:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 11:52:13 +0000 Subject: [Koha-bugs] [Bug 13659] "stack smashing detected", when Zebra indexing a subfield with a very long (1000+) word In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13659 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13660 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:01:45 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35658&action=edit Bug 13660 - rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. When looking for a bad MARC Record using the rebuild_zebra_sliced.sh, it is useful to skip the complete MARCXML exporting from Koha and reuse the exported files for Zebra indexing. This patch adds a new parameter: -x | --exclude-export Do not export Biblios from Koha, but use the existing export-dir Which depends on the: -d | --export-dir Where rebuild_zebra.pl will export data Default: $EXPORTDIR !---------! ! TEST PLAN ! !---------! 1. Run "./rebuild_zebra_sliced.sh --length 1000" to export 1000 MARC Records and slice them to one big 1000-Record chunk. 2. Realize that you get an imaginary "stack smashing detected"-error crashing your indexing at some Record you dont know of and can't make out from the indexing logging. 3. Start looking for the bad Record by running: "./rebuild_zebra_sliced.sh --exlude-export --chunk-size 10" To skip Biblios export from Koha which takes ~2h and get straight into splitting your exported biblios to chunks of 10, and importing them. You know which chunk fails so it is much easier to find the issue there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:01:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:01:51 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:02:03 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:06:44 +0000 Subject: [Koha-bugs] [Bug 13661] New: Prevent sabotaging Zebra indexing from the cataloguing module by creating a subfield with a very long word. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13661 Bug ID: 13661 Summary: Prevent sabotaging Zebra indexing from the cataloguing module by creating a subfield with a very long word. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl !--------!-!-------! ! REPLICATE THE ISSUE ! !--------!-!-------! 1. Add this to any subfield: T??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??LT??L 2. Make a full Zebra reindexing. 3. Observe a "*** stack smashing detected ***: /usr/bin/zebraidx terminated"-error, when the faulty Biblio is indexed, and a possibly broken search index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:07:36 +0000 Subject: [Koha-bugs] [Bug 13661] Prevent sabotaging Zebra indexing from the cataloguing module by creating a subfield with a very long word. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13661 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13659 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:07:36 +0000 Subject: [Koha-bugs] [Bug 13659] "stack smashing detected", when Zebra indexing a subfield with a very long (1000+) word In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13659 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13661 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:29:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:29:39 +0000 Subject: [Koha-bugs] [Bug 13662] New: Serial permissions: receive_serials Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Bug ID: 13662 Summary: Serial permissions: receive_serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com There are some issues with serial permissions. For instance it's not possible to receive serials if the edit_subscription is not set. It worked in a previous version (before 3.14). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:29:48 +0000 Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:37:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:37:40 +0000 Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:37:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:37:42 +0000 Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 --- Comment #1 from Jonathan Druart --- Created attachment 35659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35659&action=edit Bug 13662: Fix the serials.receive_serials permissions There are some issues with serial permissions. For instance it's not possible to receive serials if the edit_subscription is not set. Also the toolbar is empty. Test plan: 1/ Set the serials => receive_serials permissions to a patron (and only this one for the serials module). 2/ Verify you cannot create a new subscription, you can search subscriptions but cannot edit them. 3/ On the serial result list, receive a serial (action > Serial receive). You can now change the status and receive it. 4/ On the serial collection, you can edit 1+ serials to reveice it. 5/ Set the serials => edit_subscription permission and confirm there is no regression. QA note: I think we should introduce a C4::Serials::can_receive_serials subroutine, to test the IndependentBranches pref, but I don't want to add to much processing to check permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 13:49:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 12:49:48 +0000 Subject: [Koha-bugs] [Bug 13655] Can't save organisation type patron without entering userid/password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 14:03:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 13:03:53 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|VERIFIED |REOPENED Resolution|WISHLIST |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 14:03:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 13:03:59 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 14:07:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 13:07:03 +0000 Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651 --- Comment #7 from Owen Leonard --- I think "New" is the correct status for this bug since it's open and unassigned. We don't have an established procedure for using "verified" or "wishlist." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 14:57:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 13:57:02 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #9 from Magnus Enger --- Created attachment 35660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35660&action=edit Simple script to test the new API calls A simple script that makes 4 basic calls to the API, to authenticate, then create, update and delete a patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 15:05:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 14:05:55 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Magnus Enger --- I did some basic exercising of the API calls with the attached script, and it seems to work as advertised. Yay! * Minor problem: - The POD (synopsis and description) in C4/Output/XMLStream.pm seems to mix up XML and JSON a bit. * Major problem: - EnhancedMessagingPreferences = allow - Create a new patron from scratch - Change the category from the default one - Firebug reports a 500 error for /cgi-bin/koha/members/default_messageprefs.pl The actual error reported: Software error: Can't use string ("C4::Service") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Service.pm line 262. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 15:55:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 14:55:03 +0000 Subject: [Koha-bugs] [Bug 13663] New: offline circ permission issue Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Bug ID: 13663 Summary: offline circ permission issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com circ/offline.pl needs the perm circulate_remaining_permissions but tools/upload-file.pl needs tools => * That means a librarian cannot upload the .koc files generated offline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 16:02:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 15:02:06 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 16:02:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 15:02:09 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 --- Comment #1 from Jonathan Druart --- Created attachment 35661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35661&action=edit Bug 13663: allow a librarian with circulate_remaining_permissions to upload koc files The tools/upload-file.pl script require one of the tools permissions to upload koc files. This script is called by offline_circ/process_koc.pl which requires circulate_remaining_permissions. It does not make sense to require another permission for this script. Test plan: Verify that the circulate_remaining_permissions perm is enough to upload .koc file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 19:41:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 18:41:22 +0000 Subject: [Koha-bugs] [Bug 13664] New: Add password strength plugin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 Bug ID: 13664 Summary: Add password strength plugin Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Add password strength plugin using complexify. This should be linked to system preferences, and apply to both staff and public logins. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 19:41:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 18:41:52 +0000 Subject: [Koha-bugs] [Bug 13664] Add password strength plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 20:00:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 19:00:32 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #12 from Christopher Brannon --- Koha 3.16.4 with Firefox Nightly 31.0, all add-ons (Firebug) disabled, still doesn't open in new window. Same for IE11. I don't think it has to do with number of results, as it isn't from a results page. It is from the record page (detail.pl). And I don't think it is the number of items in the record, because it is doing it with a record that only has 3 items. I can't reproduce Marc's findings. Tim has the most plausible scenario. I did a search for an item and the URL included a URL searchid parameter. When I click on the Open in new window link, it opens the OPAC in the current tab. When I back up, delete the searchid parameter and hit enter, same record opens without the Return to results control, and when I click on the link, it opens the OPAC in a new tab. When I put the searchid back, the problem comes back. I think Tim found the culprit. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 20:39:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 19:39:06 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11890 CC| |nick at quecheelibrary.org --- Comment #13 from Nick Clemens --- Just adding bug 11890 as a possible related issue. Seeing the same searchid appended to the link. VOKAL has both issues on our system. Disabling javascript clears the issue in both cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 20:39:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 19:39:06 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11937 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 21:13:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 20:13:49 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 21:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 20:16:11 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13644 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 21:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 20:16:11 +0000 Subject: [Koha-bugs] [Bug 13644] Paging Javascript breaks links with anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11937 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 21:17:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 20:17:27 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29591|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 21:17:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 20:17:46 +0000 Subject: [Koha-bugs] [Bug 6499] OCLC # Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29605|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 22:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 21:18:36 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 --- Comment #14 from Liz Rea --- The number of search results only matters because, if you search and get only one result, you won't have the search navigation.Clicking the link will work. If you, say, click the 3rd record in a list of several results, you will then have the search navigation (upper left hand side), and the link will open in the current window. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 22:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 21:20:06 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 --- Comment #15 from Christopher Brannon --- (In reply to Liz Rea from comment #14) > The number of search results only matters because, if you search and get > only one result, you won't have the search navigation.Clicking the link will > work. If you, say, click the 3rd record in a list of several results, you > will then have the search navigation (upper left hand side), and the link > will open in the current window. > > :) Yes, I agree. :) Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 22:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 21:23:32 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 --- Comment #16 from Liz Rea --- Hooray! We understand each other! o/*HIGHFIVE*\o -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 22:35:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 21:35:27 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 22:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 21:48:06 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Nick Clemens --- I tried testing and got odd results with one number displaying as batch id, but the results saving into the DB with a higher batch id, I suspect there is some double increment due to the placeholder records. I am wondering if instead of adding a placeholder at object creation the batch id could be assigned after the first items are added? Maybe assign batch ID -1, don't display it in the add screen, and then in the add items function check for batch id -1 and create the new items then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 23:12:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 22:12:39 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 --- Comment #20 from Mason James --- (In reply to M. Tompsett from comment #13) > Comment on attachment 21221 [details] [review] > Bug 10554 - Add more options to 'AllowSelfCheckReturns' syspref > > Review of attachment 21221 [details] [review]: > ----------------------------------------------------------------- > > ::: installer/data/mysql/sysprefs.sql > @@ +419,5 @@ > > ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), > > ('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo') > > ; > > + > > +installer/data/mysql/sysprefs.sql > > I think this is a mistake. yes, the addition of those two lines is a mistake > > ::: koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt > @@ +140,4 @@ > > [% END %] > > Please see a member of the library staff. > >

> > +[% IF (AllowSelfCheckReturns == 'nonblocked' and returnitem ) or AllowSelfCheckReturns == 'all' %] > > Why not leave the > [% IF ( returnitem ) %] > line, and then just change the next line to: > [% IF AllowSelfCheckReturns == 'nonblocked' or AllowSelfCheckReturns == > 'all' %] > Because returnitem should be set correctly, should it not? And if not, > where's the logic for it that needs fixing? if your suggestion tests OK, then i am happy it makes no difference to me which syntax is used :) > ::: opac/sco/sco-main.pl > @@ +83,4 @@ > > $template->param(SelfCheckTimeout => $selfchecktimeout); > > > > # Checks policy laid out by AllowSelfCheckReturns, defaults to 'on' if preference is undefined > > +my $allowselfcheckreturns = 'nonblocked'; > > Actually, I was thinking these 4 lines could be optimized to: > my $allowselfcheckreturns = C4::Context->preference('AllowSelfCheckReturns') > // 'nonblocked'; yes, looks good? > > @@ +152,4 @@ > > "circ_error_$issue_error" => 1, > > title => $item->{title}, > > hide_main => 1, > > + barcode => $barcode, > > Is this a secondary bug that you discovered while fixing this? yep, its a small secondary bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 23:13:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 22:13:33 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 --- Comment #21 from Mason James --- (In reply to Jonathan Druart from comment #17) > Mason, > > Could you please answer to Mark's comment please? > > Marked as Failed QA. yep, answered above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 23:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 22:16:07 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 --- Comment #22 from Mason James --- > > @@ +152,4 @@ > > > "circ_error_$issue_error" => 1, > > > title => $item->{title}, > > > hide_main => 1, > > > + barcode => $barcode, > > > > Is this a secondary bug that you discovered while fixing this? > > yep, its a small secondary bug the bug was that barcode info was not being passed to the template, therefore was not being displayed to the screen, as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 23:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 22:21:26 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #39 from Robin Sheat --- (In reply to Jonathan Druart from comment #38) > Thanks Robin for the wiki page. > I have quickly tested this morning, to confirm the search works. > Just some quick notes: > - The indexation should commit every 1k biblio (minimum), the commit is a > slow op indeed. Yeah. The commit rate I'm defining is currently actually not useful as Catmandu has its own buffering and committing system. I think that's changeable though. I also think the whole indexing process can be optimised a fair bit. I just haven't looked into it yet. > - You have removed the use of search/results.tt in your last commit, is it > intended? I am pretty sure it's not a good idea to use the same template for > ES and Zebra, but maybe it's temporary. Hmm? I'm not totally sure what you mean here. I am totally deliberately using the same template to show ES results as also shows zebra results, that's by design. Any other way would require copy-pasting 99% of the template, when there's already a perfectly good one that shows search results. I'm also trying to make a bit of an abstract search layer thing, not totally perfectly, to make it easier to work with this sort of thing in the future (very much based off your solr stuff in that respect.) > Note that there are encoding errors in facets (and in the table results > also), the "Show more" link appears even if only 1 entry is displayed. Yep, definitely. There'll be a lot of things like that that just need to be polished. > I only get 2 facets: authors and itemtype. MARC21 or UNIMARC? You should get more, though I haven't looked at that for a while. For example, http://elasticsearch.koha.catalystdemo.net.nz/cgi-bin/koha/opac-search.pl?q=chicken give availability, item types, authors and topics. But the facet stuff as a whole will need more work, I mostly got it to the point where it works at all and then moved on. > Do you plan to rebase your work against master? It would be great to see > these patches on top of bug 11944. Yes, I do. I'm just a little afraid to as I know it'll conflict with many, many things. One day soon I'll suck it up and do it though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 23:25:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 22:25:52 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #40 from Robin Sheat --- (In reply to Robin Sheat from comment #39) > MARC21 or UNIMARC? You should get more, though I haven't looked at that for > a while. > > For example, > http://elasticsearch.koha.catalystdemo.net.nz/cgi-bin/koha/opac-search. > pl?q=chicken > > give availability, item types, authors and topics. But the facet stuff as a > whole will need more work, I mostly got it to the point where it works at > all and then moved on. Oh, whether a field is suitable for faceting is now defined in the mapping table in the database. This might be why it's not working if you're in unimarc, the field definitions may not be correct for it. I want (eventually) to extend this to make what is facetable configurable, at the moment it's hardcoded into the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 23:32:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 22:32:07 +0000 Subject: [Koha-bugs] [Bug 12705] News not possible for one sublanguage if two sublanguages are installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12705 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 23:35:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 22:35:04 +0000 Subject: [Koha-bugs] [Bug 12705] News not possible for one sublanguage if two sublanguages are installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12705 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 3 23:59:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 22:59:46 +0000 Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 --- Comment #15 from Mason James --- (In reply to Tom?s Cohen Arazi from comment #13) > Patch pushed to master. > > Thanks Mason! > > PS. try to tidy your commit messages a bit next time :-D can you show me an example of an untidy commit message from me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 00:00:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 23:00:50 +0000 Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 00:04:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 23:04:09 +0000 Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 --- Comment #16 from Mason James --- (In reply to Chris Cormack from comment #14) > Pushed to 3.18.x, will be in 3.18.2 Patch pushed for 3.16.8 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 00:50:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Feb 2015 23:50:20 +0000 Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 --- Comment #17 from Tom?s Cohen Arazi --- (In reply to Mason James from comment #15) > (In reply to Tom?s Cohen Arazi from comment #13) > > Patch pushed to master. > > > > Thanks Mason! > > > > PS. try to tidy your commit messages a bit next time :-D > > can you show me an example of an untidy commit message from me? Sorry, I meant the subject! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 02:05:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 01:05:37 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 04:15:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 03:15:52 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #11 from David Cook --- Comment on attachment 34316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34316 Bug 13414 - Enable automatic right truncation while searching by relevance Review of attachment 34316: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13414&attachment=34316) ----------------------------------------------------------------- ::: installer/data/mysql/sysprefs.sql @@ +343,4 @@ > ('QueryAutoTruncate','1',NULL,'If ON, query truncation is enabled by default','YesNo'), > ('QueryFuzzy','1',NULL,'If ON, enables fuzzy option for searches','YesNo'), > ('QueryStemming','1',NULL,'If ON, enables query stemming','YesNo'), > +('QueryWeightFields','1','0|1|2','Enable field weighting research','Choice'), "Enable field weighting research"? What does research mean in this context? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 04:54:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 03:54:31 +0000 Subject: [Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 07:32:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 06:32:06 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33726|0 |1 is obsolete| | --- Comment #79 from M. Tompsett --- Created attachment 35662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35662&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 08:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 07:37:35 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #30 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 09:53:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 08:53:46 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #12 from Koha Team Lyon 3 --- Yes, it would be more exact to say "Enable field weighting sorting" or to keep the initial label "enables field weighting" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 10:59:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 09:59:51 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #6 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #5) > Did you benchmark the scripts booksellers.pl and invoices.pl with this patch? Patched master: 166 booksellers: - acqui/booksellers.pl: 1.3 sec - acqui/invoices.pl: 1.2 sec 1660 booksellers: - acqui/booksellers.pl: 6.4 sec - acqui/invoices.pl: 5.5 sec 16600 booksellers: - acqui/booksellers.pl: 55.8 sec - acqui/invoices.pl: 47.5 sec Unpatched master: 166 booksellers: - acqui/booksellers.pl: 4.06 sec - acqui/invoices.pl: 3.94 sec 1660 booksellers: - acqui/booksellers.pl: 33.2 sec - acqui/invoices.pl: 31.7 sec Test setup with pre-DBIx bookseller code (3.17.00.014), different server with ca 10-25% faster CPU, but otherwise rather similar software and hardware-wise: 166 booksellers: - acqui/booksellers.pl: 0.68 sec - acqui/invoices.pl: 0.61 sec 1660 booksellers: - acqui/booksellers.pl: 1.71 sec - acqui/invoices.pl: 0.64 sec 16600 booksellers: - acqui/booksellers.pl: 10.8 sec - acqui/invoices.pl: 1.16 sec Other difference between patched and unpatched master is that when running booksellers.pl on the unpatched master, CPU usage is 99+% for booksellers.pl and just 1.2-1.5% for mysqld, while for patched master it is ca 87% for a script and 12% for mysqld. Before filing this bug report I've tried to profile booksellers.pl with nytprof; there are some intriguing things in the results, for example: suspiciously high amount of CPU time (20% or so) is being spent in the various XML::* modules - I think I figured why it does that, separate bug report + patch will follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 12:14:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 11:14:22 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13665 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 12:14:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 11:14:22 +0000 Subject: [Koha-bugs] [Bug 13665] New: Retrieve facets from zebra is slow Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 Bug ID: 13665 Summary: Retrieve facets from zebra is slow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 11232 With a 1 million biblio records installation (MARC21 + DOM), a search is very slow if facets are retrieved from zebra. Debugging, I found where the processing time is spent: In C4::Search::_get_facet_from_result_set, the line my $facet = $rs->record( 0 )->raw; can spent up to 3 seconds! Actually it's the ->record call, not the ->raw. In ZOOM->record, the time is spent in my $_rec = Net::Z3950::ZOOM::resultset_record($this->_rs(), $which); I stopped the track game at this point. So for instance, with a facet holdingbranch, (FacetMaxCount set to 20) the element zebra::facet::su-to:0:20" is set, $rs->size returns 962076, and the total execution time for _get_facet_from_result_set (only for this facet!) is 3.2sec. If I set FacetMaxCount to 1, I got: 0.3 sec, for 10: 1.67. So quite linear. Lets compare with yaz-client: Z> open unix:/home/koha/var/run/zebradb/bibliosocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.009150 Z> base biblios Z> format xml Z> elem zebra::facet::holdingbranch:0:20 Z> f d Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 809470, setno 1 SearchResult-1: term=d cnt=809470 records returned: 0 Elapsed: 0.078905 Z> s 1+1 Sent presentRequest (1+1). Records: 1 Record type: XML br1 [...] nextResultSetPosition = 2 Elapsed: 1.393694 To compare with the old facet method, I calculated the time spend in C4::Search::GetFacets (for 20 facets): >From zebra (new): 9.3sec >From Records (old): 0.16sec (with maxRecordsForFacets = 20) >From Records (old): 1.85sec (with maxRecordsForFacets = 100) >From Records (old): 15.1sec (with maxRecordsForFacets = 1000) Note that the machine is a test machine (VE) and is quite slow. Firebug tells me that with the new method (20 facets), the total load page is ~30sec, with the old method (20 facets calculated from 20 records) is 8-9sec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 12:44:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 11:44:24 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it Status|Needs Signoff |Failed QA --- Comment #7 from Paola Rossi --- I've applied the patch against master 3.19.00.006 head 13235. (In reply to David Cook from comment #3) > 4) Note that the descriptions are exactly the same as before No, the descriptions were not exactly the same as before. These are the 9 differences : now against before (i.e. master): 1) View Catalog (Librarian Interface) Required for staff login. Staff access, allows viewing of catalogue in staff client. 2) Allow staff members to modify permissions for other staff members Set user permissions 3) Edit Catalog (Modify bibliographic/holdings data) Edit catalog (Modify bibliographic/holdings data) 4) Edit Items Edit items 5) Upload patron images in batch or one at a time Upload patron images in a batch or one at a time 6) Edit Authorities Edit authorities 7) Create SQL Reports Create SQL reports 8) Required for staff login. Staff access, allows viewing of catalogue in staff client. Allow staff members to modify permissions for other staff members 9) Course Reserves Course reserves For now I pass the patch to "Failed QA" status. > > [...] change the text in > `permissions.description` and `userflags.flagdesc` and notice > that the text on the page doesn't change. > Yes, as required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 13:47:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 12:47:56 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #7 from Jonathan Druart --- I did a quick test (master): inserted 1000 booksellers, launched use Modern::Perl; use Koha::Acquisition::Bookseller; Koha::Acquisition::Bookseller->search; perl benchmark_bookseller.pl 33.83s user 0.12s system 99% cpu 34.280 total I quickly implemented Koha::Acquisition::Bookseller using Koha::Object (see bug 13019) and tested with use Modern::Perl; use Koha::Acquisition::Booksellers; my $booksellers = Koha::Acquisition::Booksellers->search; while ( my $b = $booksellers->next ) { say $b->name; } perl benchmark_bookseller.pl 1.00s user 0.03s system 96% cpu 1.072 total -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 14:00:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 13:00:14 +0000 Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 14:13:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 13:13:15 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11889 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 14:13:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 13:13:15 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13417 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 14:35:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 13:35:24 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- I did git grep for the files all removed files, no references behalve of: git grep 'opac-tmpl/lib/yui/reset-fonts-grids.css' Result: koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css git grep 'opac-tmpl/lib/yui/skin.css' Result: koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css Are opac-old.css and sco-old.css still used / present in the system or is this just a local issue in my dev installation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 15:44:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 14:44:15 +0000 Subject: [Koha-bugs] [Bug 13666] New: Allow SIP2 checkin/checkout to get branch from institution_id field AO Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Bug ID: 13666 Summary: Allow SIP2 checkin/checkout to get branch from institution_id field AO Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: benjamin.rokseth at kul.oslo.kommune.no QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Although SIP2 specifies the required AO field to be institution_id and it doesn't neccessarily map to a branch in Koha, this is probably the case for most. Allowing for AO to set the C4::Context->userenv->{branch} transaction-time would open up for a more flexible transaction scenario: - SIP2 connections could fetch from a pool of connections, so e.g. ten SIP2 workers could easily serve hundreds of clients - SIPConfig.xml would not need reconfiguration each time a new client is added Please advise if this is in collision with other SIP2 logic in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 15:48:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 14:48:41 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #8 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #7) > I quickly implemented Koha::Acquisition::Bookseller using Koha::Object (see > bug 13019) and tested with > > use Modern::Perl; > use Koha::Acquisition::Booksellers; > my $booksellers = Koha::Acquisition::Booksellers->search; > while ( my $b = $booksellers->next ) { > say $b->name; > } > > perl benchmark_bookseller.pl 1.00s user 0.03s system 96% cpu 1.072 total Speed-wise, I'm getting pretty much the same results with the following quick&dirty mod: --- a/Koha/Acquisition/Bookseller.pm +++ b/Koha/Acquisition/Bookseller.pm @@ -46,13 +46,12 @@ sub search { } my $rs = $schema->resultset('Aqbookseller')->search( $search_params, - { order_by => 'name' } + { order_by => 'name' }, { result_class => 'DBIx::Class::ResultClass::HashRefInflator' } ); my @booksellers; while ( my $b = $rs->next ) { - my $t = Koha::Acquisition::Bookseller->fetch({ id => $b->id }); - push @booksellers, $t; + push @booksellers, $b; } return @booksellers; } With it, booksellers.pl loading times are 0.96 sec / 1.82 sec / 10.3 sec for 170 / 1700 / 17000 booksellers in the database. Whenever DBIx object is cached or not cached doesn't seem to matter much with such mod - I guess because there would be just one DBIx schema/connection object created in this case anyway? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 16:22:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 15:22:19 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #10 from H?ctor Eduardo Castro Avalos --- Created attachment 35663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35663&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML is not well-formed document and do not follows the DC-XML recommendations as should be. New feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Apply patch[es]. 2) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C and OAI-DC can be validated by other validator. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities not found in .deb package -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:11:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:11:46 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35637|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:12:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:12:55 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35639|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:13:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:13:21 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:13:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:13:48 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:14:08 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:14:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:14:27 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35640|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:14:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:14:45 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:15:11 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:15:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:15:25 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35645|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 17:18:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 16:18:10 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 18:10:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 17:10:22 +0000 Subject: [Koha-bugs] [Bug 13667] New: Provide script to regularly clean deletedpatrons table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Bug ID: 13667 Summary: Provide script to regularly clean deletedpatrons table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Currently when a patron record is deleted in Koha the information in the table borrowers is moved to the table deletedborrowers. But Koha currently provides no way to clean up the table deletedborrowers regularly. The data is kept forever or has to be deleted via SQL. We should provide a script that checks for a timestamp (see bug 8926) and deletes data older than x days. It might also be desirable to offer an option to never save data into the deletedborrowers table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 18:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 17:28:31 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- (In reply to Katrin Fischer from comment #3) > Could this be a duplicate to bug 12514 and bug 7255? Yes, I believe those should be marked as duplicates of this bug. The one has no patches, and the other has a patch that will never pass qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 18:40:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 17:40:39 +0000 Subject: [Koha-bugs] [Bug 13668] New: Creator of an SQL report shoudl be NULL when the staff patron is deleted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Bug ID: 13668 Summary: Creator of an SQL report shoudl be NULL when the staff patron is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When deletig a staff patron his/her reports are still linked to his/her former borrowernumber. It would be better to delete the connection to the creator when the staff patron is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 19:54:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 18:54:46 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 19:55:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 18:55:18 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 19:55:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 18:55:46 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #20 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 20:22:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 19:22:45 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 20:22:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 19:22:48 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34529|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 35664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35664&action=edit [SIGNED-OFF] Bug 13482 - A race condition prevents item info from being available for ReserveSlip (hold notice) printing. Occasionally the ReserveSlip doesn't have any values from the koha.items-table. There is no apparent reason why. The issue seems to be more prevalent when fulfilling holds (checkin-in) to be transferred to another branch. Traced the issues to a race condition between printing a just-fulfilled hold and writing the itemnumber to the reserves-table. TEST PLAN: 1. Find a borrower, make a hold for him, and check-in the book to trigger the "Hold found:"-prompt. Do not Confirm it! 2. Reproduce the print error by entering the following to a javascript console at the same page. Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=10904891&biblionumber=469263&op=slip'); 3. Notice the missing item fields. After this patch, one can confirm that it works by using this command: Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=10904891&biblionumber=469263&itemnumber=10563811&op=slip'); MAKE SURE TO REPLACE PARAMETERS WITH CORRECT VALUES. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 20:47:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 19:47:36 +0000 Subject: [Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 20:47:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 19:47:40 +0000 Subject: [Koha-bugs] [Bug 12571] Add ability to customize SIP2 screen messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12571 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 20:47:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 19:47:45 +0000 Subject: [Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 20:47:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 19:47:48 +0000 Subject: [Koha-bugs] [Bug 6254] Set default for privacy by patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 20:47:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 19:47:53 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 21:03:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 20:03:28 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34187|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 35665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35665&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su -sp -l --item -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 21:45:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 20:45:46 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #1 from Nick Clemens --- FWIW I would kind of like to know who created a report even if they are removed from the system. Maybe link it to the deletedborrowers table and display in red or with a note? Some people's reports you might want to save, and some delete, harder to suss out if all set to null. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 21:46:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 20:46:19 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedpatrons table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 21:49:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 20:49:53 +0000 Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 21:57:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 20:57:21 +0000 Subject: [Koha-bugs] [Bug 13658] Show 'damaged' items as available in OPAC XSLT result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13658 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 4 23:59:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 22:59:30 +0000 Subject: [Koha-bugs] [Bug 12908] Add a German RELTERMS authorized value list to the web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12908 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 00:05:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 23:05:39 +0000 Subject: [Koha-bugs] [Bug 13669] New: Webinstaller fails on MySQL 5.6 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Bug ID: 13669 Summary: Webinstaller fails on MySQL 5.6 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Due to a change in MySQL 5.6 [1] the web installer fails to load the kohastructure.sql and the chosen sample data files. This is because C4::Installer::load_sql relies on a command line call to the mysql binary, which from now on doesn't support passing the user password as parameter on the command line, YAY! [1] http://dev.mysql.com/doc/refman/5.6/en/upgrading-from-previous-series.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 00:05:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Feb 2015 23:05:47 +0000 Subject: [Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 01:55:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 00:55:52 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 09:50:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 08:50:01 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35457|0 |1 is obsolete| | --- Comment #13 from Benjamin Rokseth --- Created attachment 35666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35666&action=edit Bug 13159 - Enhancements to the SIP2 command line emulator I needed to be able to perform checkout operations for testing from the command line. I ended up reengineering the SIP2 command line tester quite a bit. Enhancements: * Moved message generation code to subroutines * Added support for more messages * Added command line switches for each supported message * Enabled use of Sip::Constants to keep code DRY and more understandable * Moved script from misc to C4/SIP * Designed with an eye towards possibly moving some code to CPAN in the future * Also designed to make adding new messages much easier in the future Test Plan: 1) Apply this patch 2) Look at help via ./C4/SIP/sip_cli_emulator.pl --help 3) Test patron status request and patron information, should work as before except you need to pass the command line switche -m 4) Test the new checkout option using -m checkout -i Signed-off-by: Benjamin Rokseth Worked as advertised, with one warning at renew only: Trying 'renew' Use of uninitialized value $value in concatenation (.) or string at ./sip_cli_emulator.pl line 462, chunk 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 09:50:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 08:50:24 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |benjamin.rokseth at kul.oslo.k | |ommune.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 09:53:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 08:53:27 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #8 from Benjamin Rokseth --- Isabela, would you care to sign off if you tested and it worked according to the description? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 11:20:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 10:20:09 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #9 from Isabela Terra --- (In reply to Benjamin Rokseth from comment #8) > Isabela, would you care to sign off if you tested and it worked according to > the description? Yes, i can do this! How? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 12:06:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 11:06:03 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #5 from Benjamin Rokseth --- Not able to confirm expected behaviour. checkin of item checked out works ok: Trying 'checkin' SEND: 09Y201515 115144201515 115144APCPL|AOCPL|AB123456|ACautopass|BIN| READ: 101YNN20150205 115144AOCPL|AB123456|AQCPL|AJEn tittel|AA2| but checkin of not checked out item returns error: Trying 'checkin' SEND: 09Y201515 115147201515 115147APCPL|AOCPL|AB123456|ACautopass|BIN| Use of uninitialized value $data in concatenation (.) or string at ./sip_cli_emulator.pl line 270, chunk 1. READ: command used: perl -I. ./sip_cli_emulator.pl -l CPL -su autouser -sp autopass --port=6001 --address=localhost --item 123456 -m checkin --patron 2 output from SIPServer log: Use of uninitialized value $id in string ne at C4/SIP/ILS.pm line 84. Use of uninitialized value $_[1] in sprintf at /usr/lib/perl/5.14/Sys/Syslog.pm line 368. Use of uninitialized value in negation (-) at /usr/lib/perl5/DateTime.pm line 1764. DBD::mysql::st execute failed: called with 1 bind variables when 0 are needed at C4/Members.pm line 596. Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 12:15:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 11:15:33 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35665|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 35667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35667&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su -sp -l --item -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 13:01:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 12:01:38 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #10 from Benjamin Rokseth --- (In reply to Isabela Terra from comment #9) > (In reply to Benjamin Rokseth from comment #8) > > Isabela, would you care to sign off if you tested and it worked according to > > the description? > > Yes, i can do this! > How? You can do it from within bugzilla. Describe in short what you did to confirm it worked. Then change status to Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 13:09:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 12:09:04 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 13:09:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 12:09:07 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35657|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 35668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35668&action=edit [PASSED QA] Bug 13645: Cache the DBIx connection We don't want to recreate a new connection to the DB every time we want a new schema. This patch creates a $database package level variable on the same way it's done in C4::Context for $dbh. Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 13:24:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 12:24:39 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #66 from Jacek Ablewicz --- (In reply to Robin Sheat from comment #64) > Created attachment 33940 [details] [review] > Bug 11998 - fix some compile warnings > > This lazy-loads C4::Context and some other modules so that they can be > be safely used by C4::Context without introducing problematic circular > dependencies. This approach may be somehow problematic IMO.. Looks like it relies on the unwritten assumption that 'use C4::Context' would be always used somewhere beforehand at least once - because if not, usually there will be no default/already existing context to rely upon. Currently, initial context is most often created & stored as default in the import() function in C4::Context (and typically only there ?). Take this part for example: --- a/Koha/Database.pm +++ a/Koha/Database.pm @@ -34,7 +34,6 @@ Koha::Database use Modern::Perl; use Carp; -use C4::Context; use Koha::Schema; use base qw(Class::Accessor); @@ -46,6 +45,7 @@ __PACKAGE__->mk_accessors(qw( )); # returns it. sub _new_schema { + require C4::Context; my $context = C4::Context->new(); with it applied, some simple code chunks like that: use Koha::Database; my $scnt = Koha::Database->new()->schema()->resultset('Subscription')->count(); would fail ("... Can't call method "config" on unblessed reference at /home/koha/devkohaclone/C4/Context.pm line 780"). It's possible that this particular issue is being addressed in some other patch[es] belonging to this bug report, but it's hard to say for sure, as the whole patch set does not apply on the current master at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 13:28:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 12:28:32 +0000 Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 13:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 12:28:59 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 13:38:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 12:38:03 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35667|0 |1 is obsolete| | --- Comment #7 from Benjamin Rokseth --- Created attachment 35669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35669&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su -sp -l --item -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 13:38:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 12:38:20 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 13:47:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 12:47:31 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 --- Comment #2 from Katrin Fischer --- The idea behind this is that we shoudln't keep information about people (staff or patrons) forever in the database. When you have left the library, there should be a point where they are no longer saving things about you in their computer systems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 14:26:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 13:26:29 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OCLC # Indexing & Matching |MARC21 035 -- | |Other-control-number -- | |Indexing & Matching --- Comment #7 from Barton Chittenden --- Changed title of bug to remove pesky '#' character, and to better classify the change being made. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 14:59:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 13:59:48 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 --- Comment #11 from Magnus Enger --- If I try to include one of the B_* fields in my borrower data, I get this : failed data Invalid fieldname provided: B_address Probably because of this line: die "Invalid fieldname provided (update): $f\n" if $f =~ /[^A-Za-z0-9]/; Also, the "message" in the response would look better without the trailing newline, I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 15:20:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 14:20:57 +0000 Subject: [Koha-bugs] [Bug 13670] New: Patron holds table not loading when holds tab anchor is used Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Bug ID: 13670 Summary: Patron holds table not loading when holds tab anchor is used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a link to a patron record ends with #reserves, the holds tab is selected on page load, but the holds table does not load. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 15:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 14:21:02 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 15:21:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 14:21:24 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 15:24:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 14:24:27 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 15:24:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 14:24:29 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 --- Comment #1 from Kyle M Hall --- Created attachment 35670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35670&action=edit Bug 13670 - Patron holds table not loading when holds tab anchor is used If a link to a patron record ends with #reserves, the holds tab is selected on page load, but the holds table does not load. Test Plan: 1) Build your holds queue 2) From the holds queue report, open any patron link 3) Note the patron's reserves do not load 4) Apply this patch 5) Clear your browser cache 6) Repeat step 2 7) Note the holds table now loads -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 15:26:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 14:26:57 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35670|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 35671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35671&action=edit Bug 13670 - Patron holds table not loading when holds tab anchor is used If a link to a patron record ends with #reserves, the holds tab is selected on page load, but the holds table does not load. Test Plan: 1) Build your holds queue 2) From the holds queue report, open any patron link 3) Note the patron's reserves do not load 4) Apply this patch 5) Clear your browser cache 6) Repeat step 2 7) Note the holds table now loads -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 15:40:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 14:40:10 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 15:59:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 14:59:03 +0000 Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 --- Comment #1 from Benjamin Rokseth --- Created attachment 35672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35672&action=edit Bug 13666 - Allow SIP2 checkin/checkout to get branch from institution_id field AO This patch adds a policy flag in SIPConfig.xml that allows overriding branch on SIP2 checkout with the AO (institution id) field. Since SIP2 also uses C4::Context this patch has to modify C4::Context->userenv->{'branch'} Test plan: 1) Either use telnet or apply patch from bug #13159 to use sip command line client 2) Checkout book with SIP2 using a modified institution id (field AO) than the one defined in SIPConfig.xml for the account 3) Notice returned AO is still same as in SIPConfig account 4) Also notice checkout history in admin gives same 'checked out from' 5) Apply this patch and add 'allow_branch_override="true" to the policy of your ILS 6) Restart SIP server 7) Repeat 2) 8) Notice that 3) and 4) now reports the modified institution id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 15:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 14:59:31 +0000 Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 17:05:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 16:05:37 +0000 Subject: [Koha-bugs] [Bug 13671] New: Search returning empty Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 Bug ID: 13671 Summary: Search returning empty Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: isabelaterra at cp2.g12.br QA Contact: testopia at bugs.koha-community.org After migration from 3.14 to 3.18 koha even with the database fed the search always returns empty. I noticed that the installation of the pt-BR language is in conflict with the Zebra. The zebra indicates en-US and Koha indicates pt-BR. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 17:16:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 16:16:38 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Paul A. changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.a at navalmarinearchive.c | |om --- Comment #3 from Paul A. --- The following is perhaps simpler and is backwards compatible (I wrote it for 3.18, tested it on our production 3.08): me at hood:/usr/share/koha/intranet/cgi-bin$ diff about.pl about.pl_orig 61d60 < $apacheVersion = (`/usr/sbin/apachectl -v`) unless $apacheVersion; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 17:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 16:33:41 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13666 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 17:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 16:33:41 +0000 Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13159 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 17:34:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 16:34:04 +0000 Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 17:49:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 16:49:49 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:15:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:15:36 +0000 Subject: [Koha-bugs] [Bug 13671] Search returning empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- It sounds like an invalid bug. You should at least reproduce the steps you followed to reach this error condition. It should include: - Install method. - Steps done to get the DB migrated. - If you installed using the packages, the way you created the instance - Steps you followed to reindex the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:19:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:19:28 +0000 Subject: [Koha-bugs] [Bug 13672] New: OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Bug ID: 13672 Summary: OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org I have confirmed this issue reported by one of our partners: I made a screencast of the problem. We just started a NoveList subscription, I'm not sure if it's our scripts conflicting with theirs. I can replicate the problem in the Los Gatos catalog (they also use NoveList). I tried to replicate on non-NoveList OPACs like NEXpress and Plum Creek but the series searching keeps giving me 404s and empty searches. Screencast: http://screencast.com/t/TLV0G4xfgPN To replicate: Search a title with a series (i.e. The Hunger Games) Click into the record Click on the series to search it Click on a title in the search results If Firefox doesn't crash, it gives the unresponsive script message (seen in the screencast) Setting OpacHighlightedWords to Don't Highlight fixes the problem. We may go this route but I wanted to make you aware of the problem. It appears that an empty string is sneaking into the list of words to highlight and that is causing the browser to freak out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:22:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:22:00 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:22:02 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 --- Comment #1 from Kyle M Hall --- Created attachment 35673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35673&action=edit Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords It appears that an empty string is sneaking into the list of words to highlight and that is causing the browser to freak out. Test Plan: 1) Enable NoveList 2) Enable OpacHighlightedItems 3) Search a title with a series (i.e. The Hunger Games) 4) Click into the record 5) Click on the series to search it 6) Click on a title in the search results 7) If Firefox doesn't crash, it gives the unresponsive script message 8) Apply this patch 9) Repeat steps 3-6 10) Browser doesn't freak our -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:25:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:25:22 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:26:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:26:05 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:26:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:26:25 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:27:14 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 --- Comment #4 from Tom?s Cohen Arazi --- This bug exists in current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:38:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:38:04 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34621|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 35674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35674&action=edit Bug 13486: Apache version empty in about page if Apache 2.4 This patch makes about.pl query the running Apache version using the apache2ctl command. I tested it on Apache 2.2 and is backwards compatible (it is present in both). To test: ( On an Apache 2.4 setup ) - Go to the about page => FAIL: "Apache version:" is empty - Apply the patch - Reload the page => SUCCESS: "Apache version:" shows the correct version. - Sign off :-D If you have an Apache 2.2 setup to try it, verify that there are no regressions (trivial because you can run apache2ctl manually and verify the first result is the expecte). Regards PS. I even changed the order in which Apache version is tested because most people is using Debian/Ubuntu and it was the last option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:42:14 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 --- Comment #21 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #19) > Patch doesn't change display apart from optional formatting of the amounts. > So I am passing it - still curious about the TOTAL column, maybe something > for yet another tax bug? Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:43:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:43:07 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:43:09 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35673|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 35675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35675&action=edit Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords It appears that an empty string is sneaking into the list of words to highlight and that is causing the browser to freak out. Test Plan: 1) Enable NoveList 2) Enable OpacHighlightedItems 3) Search a title with a series (i.e. The Hunger Games) 4) Click into the record 5) Click on the series to search it 6) Click on a title in the search results 7) If Firefox doesn't crash, it gives the unresponsive script message 8) Apply this patch 9) Repeat steps 3-6 10) Browser doesn't freak our Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:43:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:43:15 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:48:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:48:19 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:48:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:48:22 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35671|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 35676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35676&action=edit Bug 13670 - Patron holds table not loading when holds tab anchor is used If a link to a patron record ends with #reserves, the holds tab is selected on page load, but the holds table does not load. Test Plan: 1) Build your holds queue 2) From the holds queue report, open any patron link 3) Note the patron's reserves do not load 4) Apply this patch 5) Clear your browser cache 6) Repeat step 2 7) Note the holds table now loads Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:55:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:55:55 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #11 from Marc V?ron --- Exporting to Dublin Core... Simple DC-RDF -> Can save file DC-XML -> Can save file OAI-DC -> Can save file DC-RDF (Recommendend) and all of the additional selections (rdfxml or rdfjson etc) -> Software error: Only alphanumerics are allowed in N-Triples bnode labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:57:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:57:27 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:57:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:57:57 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:58:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:58:25 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Robin and Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:58:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:58:48 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:59:20 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Frido and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 18:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 17:59:50 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Thomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:00:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:00:16 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:00:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:00:47 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:01:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:01:14 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:05:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:05:09 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Couldn't we just make the --where clause to apply to an inner join of both tables instead? This way we would avoid adding complexity. We know those tables should be one if it didn't imply some performance penalty. Setting to "In discussion", to discuss this idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:09:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:09:38 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31338|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 35677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35677&action=edit Bug 10877 - Add "Order Record" processing Order Record Processing will allow a library to stage an "order record" file which is a standard marc file with some additional information in it about how to create items automatically ( quantity, itemtype, etc ). The location of these fields is defined in the system preference MarcFieldsToOrder from bug 7180. The workflow is thus: 1) A librarian uploads an "order record" file, and marks the batch as an order file during the staging process. 2) The librarian selects an acquisitions basket and chooses "from a staged order file" 3) From here, the librarian can view all the records that will be created, along with quantity and other data ( from bug 7180 ). The librarian will *not* see the item fields, as those are automatically created using the minimum data needed ( branches, itype ). 4) The librarian hits "save" and the items are automatically generated on order. Later ( using features not directly tied to this feature ), the librarian will receive a new marc batch file with items attached ( including itemnumbers ). The vendor will have this information because it was sent via EDI ( bug 7736 ). The librarian will then use the marc record staging feature to overlay those bare bones item records with the full data ( via bug 7131 ). Signed-off-by: Aaron Sakovich -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:11:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:11:40 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 --- Comment #35 from Kyle M Hall --- (In reply to Katrin Fischer from comment #33) > I feel like I don't understand this feature well - at least not the > differences to the existing staged MARC records workflow. I'll see what I can do to make this happen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:14:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:14:03 +0000 Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for waiting holds on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:20:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:20:57 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35527|0 |1 is obsolete| | Attachment #35528|0 |1 is obsolete| | Attachment #35529|0 |1 is obsolete| | Attachment #35530|0 |1 is obsolete| | Attachment #35531|0 |1 is obsolete| | Attachment #35532|0 |1 is obsolete| | --- Comment #184 from Kyle M Hall --- Created attachment 35678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35678&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:21:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:21:17 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35678|0 |1 is obsolete| | --- Comment #185 from Kyle M Hall --- Created attachment 35679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35679&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:21:29 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #186 from Kyle M Hall --- Created attachment 35680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35680&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:21:34 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #187 from Kyle M Hall --- Created attachment 35681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35681&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:21:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:21:38 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #188 from Kyle M Hall --- Created attachment 35682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35682&action=edit Bug 9303 [QA Followup] - Don't drop non-existant keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:21:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:21:43 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #189 from Kyle M Hall --- Created attachment 35683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35683&action=edit Bug 9303 [QA Followup 2] - Fix db update, move 'show' field to guarantor area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:21:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:21:47 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #190 from Kyle M Hall --- Created attachment 35684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35684&action=edit Bug 9393 [QA Followup 3] - Remove use of EncodeUTF8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:28:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:28:07 +0000 Subject: [Koha-bugs] [Bug 13262] Add parameters to XSLT Handler transform method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 35685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35685&action=edit Bug 13262: (QA followup) fix duplicate variable definition Running $ prove t/db_dependent/XSLT_Handler.t raises a couple warnings because of variable redefinitions. This small patch fixes that. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:28:50 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:29:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:29:15 +0000 Subject: [Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:29:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:29:49 +0000 Subject: [Koha-bugs] [Bug 12860] Tools > Data export : "Don't export fields" option doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12860 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:30:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:30:16 +0000 Subject: [Koha-bugs] [Bug 12601] aqorders.budget_id should be a foreign key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:31:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:31:03 +0000 Subject: [Koha-bugs] [Bug 13262] Add parameters to XSLT Handler transform method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks David! It opens us for interesting improvements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:34:29 +0000 Subject: [Koha-bugs] [Bug 2711] No Holds on Lost Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2711 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:34:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:34:43 +0000 Subject: [Koha-bugs] [Bug 13673] New: Remove warnings from t/db_dependent/Barcodes.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 Bug ID: 13673 Summary: Remove warnings from t/db_dependent/Barcodes.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:35:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:35:24 +0000 Subject: [Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #1 from Tom?s Cohen Arazi --- All diags should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:36:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:36:02 +0000 Subject: [Koha-bugs] [Bug 13674] New: Remove useless output from t/Debug.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13674 Bug ID: 13674 Summary: Remove useless output from t/Debug.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com All useless output should be removed, including warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:50:39 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:50:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:50:42 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35679|0 |1 is obsolete| | --- Comment #191 from Brendan Gallagher --- Created attachment 35686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35686&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:50:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:50:52 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35680|0 |1 is obsolete| | --- Comment #192 from Brendan Gallagher --- Created attachment 35687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35687&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:51:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:51:00 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35681|0 |1 is obsolete| | --- Comment #193 from Brendan Gallagher --- Created attachment 35688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35688&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:51:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:51:08 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35682|0 |1 is obsolete| | --- Comment #194 from Brendan Gallagher --- Created attachment 35689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35689&action=edit Bug 9303 [QA Followup] - Don't drop non-existant keys Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:51:15 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35683|0 |1 is obsolete| | --- Comment #195 from Brendan Gallagher --- Created attachment 35690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35690&action=edit Bug 9303 [QA Followup 2] - Fix db update, move 'show' field to guarantor area Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:51:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:51:22 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35684|0 |1 is obsolete| | --- Comment #196 from Brendan Gallagher --- Created attachment 35691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35691&action=edit Bug 9393 [QA Followup 3] - Remove use of EncodeUTF8 http://bugs.koha-community.org/show_bug.cgi?id=9303 Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 19:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 18:52:55 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 --- Comment #20 from Tom?s Cohen Arazi --- Created attachment 35692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35692&action=edit Bug 7904: (QA followup) fix tests The package name for SIP wasn't fixed in the tests by the original patches. This patch fixes it. To test: - Run $ prove t/db_dependent/SIP_ILS.t - Tests should pass with the patch. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 20:18:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 19:18:44 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 --- Comment #6 from Paul A. --- (In reply to Tom?s Cohen Arazi from comment #5) [snip] > If you have an Apache 2.2 setup to try it, verify that there are no > regressions > (trivial because you can run apache2ctl manually and verify the first result > is the expecte). > > Regards > > PS. I even changed the order in which Apache version is tested because > most people is using Debian/Ubuntu and it was the last option. I suggest leaving it as last line. Apache2 responds with: me at production:/$ apache2ctl -v /usr/sbin/apache2ctl: 87: ulimit: error setting limit (Operation not permitted) Server version: Apache/2.2.22 (Ubuntu) Server built: Feb 13 2012 01:51:56 unless you edit /etc/security/limits.conf to include a hard and soft file limit of 8192 instead of the debian/ubuntu default 1024 ($ ulimit -n). I don't think Koha should oblige users to change "security" settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 20:19:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 19:19:12 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 --- Comment #7 from Paul A. --- (In reply to Tom?s Cohen Arazi from comment #5) [snip] > If you have an Apache 2.2 setup to try it, verify that there are no > regressions > (trivial because you can run apache2ctl manually and verify the first result > is the expecte). > > Regards > > PS. I even changed the order in which Apache version is tested because > most people is using Debian/Ubuntu and it was the last option. I suggest leaving it as last line. Apache2 responds with: me at production:/$ apache2ctl -v /usr/sbin/apache2ctl: 87: ulimit: error setting limit (Operation not permitted) Server version: Apache/2.2.22 (Ubuntu) Server built: Feb 13 2012 01:51:56 unless you edit /etc/security/limits.conf to include a hard and soft file limit of 8192 instead of the debian/ubuntu default 1024 ($ ulimit -n). I don't think Koha should oblige users to change "security" settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 20:19:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 19:19:36 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 --- Comment #8 from Paul A. --- (In reply to Tom?s Cohen Arazi from comment #5) [snip] > If you have an Apache 2.2 setup to try it, verify that there are no > regressions > (trivial because you can run apache2ctl manually and verify the first result > is the expecte). > > Regards > > PS. I even changed the order in which Apache version is tested because > most people is using Debian/Ubuntu and it was the last option. I suggest leaving it as last line. Apache2 responds with: me at production:/$ apache2ctl -v /usr/sbin/apache2ctl: 87: ulimit: error setting limit (Operation not permitted) Server version: Apache/2.2.22 (Ubuntu) Server built: Feb 13 2012 01:51:56 unless you edit /etc/security/limits.conf to include a hard and soft file limit of 8192 instead of the debian/ubuntu default 1024 ($ ulimit -n). I don't think Koha should oblige users to change "security" settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 20:28:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 19:28:11 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 --- Comment #3 from Nick Clemens --- Agreed. My thinking was factoring in bug 13667. Once deletedborrowers is cleared, borrowernumber seems a fairly anonymous piece of info, but that might just be how we use it as staff here. As far as I can tell, the statistics table doesn't null out borrowernumber when deleting a patron either. Not a big deal and okay with this solution, just giving my 2 cents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 20:36:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 19:36:48 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 --- Comment #9 from Tom?s Cohen Arazi --- (In reply to Paul A. from comment #8) > (In reply to Tom?s Cohen Arazi from comment #5) > [snip] > > If you have an Apache 2.2 setup to try it, verify that there are no > > regressions > > (trivial because you can run apache2ctl manually and verify the first result > > is the expecte). > > > > Regards > > > > PS. I even changed the order in which Apache version is tested because > > most people is using Debian/Ubuntu and it was the last option. > > I suggest leaving it as last line. Apache2 responds with: > > me at production:/$ apache2ctl -v > /usr/sbin/apache2ctl: 87: ulimit: error setting limit (Operation not > permitted) > Server version: Apache/2.2.22 (Ubuntu) > Server built: Feb 13 2012 01:51:56 > > unless you edit /etc/security/limits.conf to include a hard and soft file > limit of 8192 instead of the debian/ubuntu default 1024 ($ ulimit -n). I > don't think Koha should oblige users to change "security" settings. Be it the first or the last line won't change the result. httpd and httpd2 would fail to run on deb?an anyway. Those warnings are painless btw. Please test the bugfix and sign if it works for you, in the about page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 21:37:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 20:37:40 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Paul A. changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Paul A. --- It does in fact make a difference (3.08, Apache 2.22). As last line, it is compatible with all other "About" entries. If not last line (i.e. inserted at line 60) it adds the "Build date." I can definitely sign-off adding: $apacheVersion = (`/usr/sbin/apachectl -v`) unless $apacheVersion; as line 61. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 23:03:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 22:03:19 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #12 from H?ctor Eduardo Castro Avalos --- (In reply to Marc V?ron from comment #11) > Exporting to Dublin Core... > Simple DC-RDF -> Can save file > DC-XML -> Can save file > OAI-DC -> Can save file > > DC-RDF (Recommendend) and all of the additional selections (rdfxml or > rdfjson etc) -> > Software error: > Only alphanumerics are allowed in N-Triples bnode labels Hi, Marc, this error is because you need to up-to date RDF-Helper or RDF-Trine with CPAN modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 23:07:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 22:07:12 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 --- Comment #22 from Katrin Fischer --- Jonathan and I discussed it on IRC and I think we agreed that some other patch in the series will fix it, so there was no need for a new bug report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 23:20:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 22:20:20 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #197 from Katrin Fischer --- Hi Brendan, could you please comment if the problem I notes earlier worked for you? > Changing the allowance from the 'personal details' page [in OPAC] is not being > saved. I tried using the update button and also make a full change > request, nothing worked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 23:23:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 22:23:02 +0000 Subject: [Koha-bugs] [Bug 13262] Add parameters to XSLT Handler transform method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #20 from David Cook --- (In reply to Tom?s Cohen Arazi from comment #19) > Patch pushed to master. > > Thanks David! It opens us for interesting improvements. Thanks, Tomas! I hope so! I think it would be interested to try XML::LibXSLT->register_function($uri, $name, $subref) as well. I use this locally for a few XSLT mods, and it works rather nicely. It doesn't require any mods to the Koha::XSLT_Handler either. You just "use XML::LibXSLT", register a function, and you're good to go! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 5 23:40:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 22:40:55 +0000 Subject: [Koha-bugs] [Bug 13668] Creator of an SQL report shoudl be NULL when the staff patron is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 --- Comment #4 from Katrin Fischer --- Hi Nick, I understand your point - we are a bit crazy here about saving/deleting things :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 00:30:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Feb 2015 23:30:02 +0000 Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 04:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 03:33:54 +0000 Subject: [Koha-bugs] [Bug 12165] Add description of charges (bug 2546) to Bootstrap OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12165 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11573 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 04:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 03:33:54 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Depends on|12165 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 04:58:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 03:58:22 +0000 Subject: [Koha-bugs] [Bug 11573] change description of charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Nick Clemens --- Needs a rebase, and I am unclear on whether to apply just the last three patches, or all 5? I hit conflicts in both scenarios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 06:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 05:28:50 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 06:28:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 05:28:53 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35288|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 35693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35693&action=edit [SIGNED OFF] Bug 13562: Fix item search on item MARC subfields Test plan: 1. Add 4 item search fields (in Administration ? Items search fields): a. 1 biblio field linked to a DB field b. 1 biblio field not linked to a DB field c. 1 item field linked to a DB field d. 1 item field not linked to a DB field 2. Make sure you have some data in those fields to search on. 3. Go to item search page and do a search using these new fields, make sure the result is correct. Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 07:34:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 06:34:50 +0000 Subject: [Koha-bugs] [Bug 11573] change description of rental charges in account fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|change description of |change description of |charges in account fines |rental charges in account | |fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 09:52:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 08:52:29 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 --- Comment #23 from Jonathan Druart --- Yes, as I noted in the commit msg "The values displayed before and after the patch must be the same". I tested on the 13323 branch, and the values are fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 10:02:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 09:02:05 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 --- Comment #10 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #9) > Couldn't we just make the --where clause to apply to an inner join of both > tables instead? This way we would avoid adding complexity. > We know those tables should be one if it didn't imply some performance > penalty. I didn't want to increase the execution time for other users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 10:03:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 09:03:19 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger --- Any movement here? :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 10:30:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 09:30:06 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #15 from Jonathan Druart --- I am under the impression there is a big issue introduced by this patch, MariaDB [koha]> select itemnumber,date_due from issues where borrowernumber=8408; +------------+---------------------+ | itemnumber | date_due | +------------+---------------------+ | 27127 | 2015-03-03 23:59:00 | | 27143 | 2015-01-01 14:31:00 | | 27754 | 2014-12-22 14:31:00 | +------------+---------------------+ Overdue rules are 1:7, 2:15, 3:21 On master, the following diff diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 4d05ff7..d4dd153 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -627,6 +627,9 @@ END_SQL } } else { + if ( $borrowernumber == 8408 ) { + warn "$item_info->{itemnumber} : $days_between >= $mindays && $days_between <= $maxdays"; + } unless ( $days_between >= $mindays && $days_between <= $maxdays ) { output: 27127 : 25 >= 21 && 25 <= 90 at misc/cronjobs/overdue_notices.pl line 631. 27143 : 36 >= 21 && 36 <= 90 at misc/cronjobs/overdue_notices.pl line 631. 27754 : 46 >= 21 && 46 <= 90 at misc/cronjobs/overdue_notices.pl line 631. The itemnumber 27127 should not be embedded in the notice (it is). The problem comes from the $MAX=90 and the $date_between. Note that I launched the script without the -t option, but I am pretty sure some cases can cause problem even with -t Don't have the time to investigate more. Could someone confirm? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 10:52:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 09:52:05 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #11 from Colin Campbell --- In the perl world using $x->{one}->{two} rather than $x->{one}{two} is the most common. one reason is that the arrow syntax can be used in a string e.g. print "Var: $x->{one}->{two}" using the non-arrow syntax in this way does not do what you may think it does Plus when you get to multiple levels of indirection the arrow-less version gets more ambigious -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 11:19:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 10:19:36 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 --- Comment #21 from Colin Campbell --- As a footnote the reason SIPServer.pm's package statement was not changed was it is not a module.(nothing uses or requires it) The name does create that illusion and I think (like a few other things) stems from some confusion in the initial implementation. I think a separate bug should open renaming it to avoid confusion and moving it out of its current location in the library modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 11:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 10:29:05 +0000 Subject: [Koha-bugs] [Bug 13671] Search returning empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 --- Comment #2 from Isabela Terra --- Hi, Tom?s! I do usually from 3:18 installation. After test and verify it was working normally, did the migration of 3.14 database to 3.18 and then the errors began to appear. The main thing is that even with the supplied base, results in searches are always empty. "No results matching your search for 'kw, wrdl: assis'". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 12:29:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 11:29:50 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #12 from Jonathan Druart --- (In reply to Colin Campbell from comment #11) > In the perl world using $x->{one}->{two} rather than $x->{one}{two} is the > most common. one reason is that the arrow syntax can be used in a string > e.g. print "Var: $x->{one}->{two}" > > using the non-arrow syntax in this way does not do what you may think it does Are you sure? I often use it, use Modern::Perl; my $h = { foo => { bar => 'foobar' } }; say "my string with $h->{foo}->{bar}"; say "my string with $h->{foo}{bar}"; outputs: my string with foobar my string with foobar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 13:31:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 12:31:41 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35693|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Created attachment 35694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35694&action=edit [PASSED QA] Bug 13562: Fix item search on item MARC subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 13:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 12:32:02 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 13:44:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 12:44:29 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 13:55:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 12:55:41 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 13:55:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 12:55:44 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34746|0 |1 is obsolete| | Attachment #34747|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 35695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35695&action=edit [PASSED QA] Bug 13380: Add the AV in the install files (This will completely done when the patch will be QAed) Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 13:56:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 12:56:25 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #16 from Kyle M Hall --- Created attachment 35696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35696&action=edit [PASSED QA] Bug 13380: Fill order cancellation reasons from AV Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. Also, it will be easier to filter or create reports. Test plan: 0/ Don't apply the patch 1/ Cancel some orders and give a cancelletion reason 2/ Apply the patch and execute the updatedb entry 3/ Cancel an order and verify the you have a list with the reason you previously filled + 3 new ones ('No reason', 'Sold out' and 'Restocking'); 4/ Choose one and verify the value is correctly displayed on the basket page 5/ You can also try to add other values from the admin module. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 13:59:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 12:59:07 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #17 from Kyle M Hall --- (In reply to Jonathan Druart from comment #13) > (In reply to Kyle M Hall from comment #12) > > QA Issue: The new authorized values need to be added to each translation. > > Kyle, > As you know, this change is very boring to do. > I would prefer to wait for the QA step passes and the wording is validated > before to add the changes to all languages. > I hope it makes sense for you. In that case, I would suggest No reason => No reason provided Sold out => Out of stock Restocking => Already ordered Does that make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 14:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 13:09:23 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #18 from Katrin Fischer --- Wondering, what is meant here? Restocking => Already ordered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 14:21:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 13:21:35 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28986|0 |1 is obsolete| | --- Comment #12 from Julian Maurice --- Created attachment 35697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35697&action=edit Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 14:24:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 13:24:35 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #13 from Julian Maurice --- Patch rebased on master (and consequently on top of bug 13116) There is one unit test that fails in t/db_dependent/Holds.t (line 331), but it fails on master too. Should I open a separate bug for this ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 14:31:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 13:31:22 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 14:41:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 13:41:44 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #13 from M. Tompsett --- (In reply to Jonathan Druart from comment #12) [SNIP] > I often use it, > > use Modern::Perl; > my $h = { foo => { bar => 'foobar' } }; > say "my string with $h->{foo}->{bar}"; > say "my string with $h->{foo}{bar}"; > > outputs: > > my string with foobar > my string with foobar I wrote my own code to see the same thing. Which is why I said, "I agree with Fr?d?ric Demians on this, though only because it makes the change more apparently equal to me, not because it actually generates a better or different data structure." back in comment #4. Structurally, it seems identical, but syntax-wise, I still prefer the $h->{foo}->{bar}. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 14:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 13:43:59 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 14:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 13:59:44 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 35698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35698&action=edit Bug 12944: (QA followup) fix POD errors from koha-qa.pl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:12:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:12:46 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29102|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 35699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35699&action=edit Bug 12460: Allow to start a new search from multiple search history lines Rebased on master Still depends on bug 11430 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:13:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:13:31 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:28:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:28:16 +0000 Subject: [Koha-bugs] [Bug 13671] Search returning empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 --- Comment #3 from Isabela Terra --- I visualized the log and found the following errors in the files: So does the OPAC and Intranet log files. ERROR: [Fri Feb 06 12:46:18.784614 2015] [cgi:error] [pid 13873] [client 192.168.52.72:64110] AH01215: [Fri Feb 6 12:46:18 2015] search.pl: CGI::param called in list context from package main line 169, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://192.168.3.82:8080/cgi-bin/koha/catalogue/search.pl?q=assis [Fri Feb 06 12:46:18.929536 2015] [cgi:error] [pid 13873] [client 192.168.52.72:64110] AH01215: [Fri Feb 6 12:46:18 2015] search.pl: CGI::param called in list context from package main line 387, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://192.168.3.82:8080/cgi-bin/koha/catalogue/search.pl?q=assis [Fri Feb 06 12:46:18.929818 2015] [cgi:error] [pid 13873] [client 192.168.52.72:64110] AH01215: [Fri Feb 6 12:46:18 2015] search.pl: CGI::param called in list context from package main line 395, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://192.168.3.82:8080/cgi-bin/koha/catalogue/search.pl?q=assis [Fri Feb 06 12:46:18.930056 2015] [cgi:error] [pid 13873] [client 192.168.52.72:64110] AH01215: [Fri Feb 6 12:46:18 2015] search.pl: CGI::param called in list context from package main line 403, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://192.168.3.82:8080/cgi-bin/koha/catalogue/search.pl?q=assis [Fri Feb 06 12:46:18.930293 2015] [cgi:error] [pid 13873] [client 192.168.52.72:64110] AH01215: [Fri Feb 6 12:46:18 2015] search.pl: CGI::param called in list context from package main line 407, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://192.168.3.82:8080/cgi-bin/koha/catalogue/search.pl?q=assis [Fri Feb 06 12:46:18.930529 2015] [cgi:error] [pid 13873] [client 192.168.52.72:64110] AH01215: [Fri Feb 6 12:46:18 2015] search.pl: CGI::param called in list context from package main line 417, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://192.168.3.82:8080/cgi-bin/koha/catalogue/search.pl?q=assis [Fri Feb 06 12:46:18.930766 2015] [cgi:error] [pid 13873] [client 192.168.52.72:64110] AH01215: [Fri Feb 6 12:46:18 2015] search.pl: CGI::param called in list context from package main line 420, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://192.168.3.82:8080/cgi-bin/koha/catalogue/search.pl?q=assis [Fri Feb 06 12:46:18.931003 2015] [cgi:error] [pid 13873] [client 192.168.52.72:64110] AH01215: [Fri Feb 6 12:46:18 2015] search.pl: CGI::param called in list context from package main line 421, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://192.168.3.82:8080/cgi-bin/koha/catalogue/search.pl?q=assis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:30:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:30:14 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32074|0 |1 is obsolete| | Attachment #32077|0 |1 is obsolete| | --- Comment #47 from Julian Maurice --- Created attachment 35700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35700&action=edit Bug 7290: More granular permissions for order receiving Rebased on master and squashed with 4th patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:30:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:30:23 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32075|0 |1 is obsolete| | --- Comment #48 from Julian Maurice --- Created attachment 35701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35701&action=edit Bug 7290: QA fixes 1) Use the new isSuperlibrarian instead of $userflags->{superlibrarian} 2) Fix capitalization of "Duplicate Barcode" 3) Add comments in t/Acquisition/CanUserReceiveBasket.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:30:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:30:34 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32076|0 |1 is obsolete| | --- Comment #49 from Julian Maurice --- Created attachment 35702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35702&action=edit Bug 7290: Fix CanUserReceiveBasket tests Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:30:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:30:52 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:32:54 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:33:44 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35517|0 |1 is obsolete| | --- Comment #4 from Paola Rossi --- Created attachment 35703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35703&action=edit [SIGNED OFF] Bug 13352: On editing, prices should not be formatted I've applied the patch against master 3.19.00.008 head 7904. Everything's OK as required by the test plan, with either FR or US CurrencyFormat syspref. So I pass the patch to the "Signed Off" status. NB1. The error message to fix is the following [blocking] one: "Form not submitted because of the following problem(s) - Amount must be a valid number, or empty" Editing a budgetperiod, the value 'hhh' in the budget's "Total-amount" input field gets the same error message [IMO RIGHT]. (A) Editing a fund, the 'hhh' in the fund's "Amount" input field doesn't get the message error, and sets the fund's amount to 0 [IMO WRONG]. This (A) error is the same against master, so IMO it's not related to this bug 13352. NB2. Editing a budgetperiod, "Save" brings back to "Budget Administration" [i.e. the budgets' list]. Editing a budgetperiod X, "Cancel" doesn't bring back to "Budget Administration": it brings to the "Funds for X". Is it OK? NB3. On editing the budget/fund, with the "FR" CurrencyFormat syspref the decimal mark was the dot, like with "US". The comma could be the decimal mark with "FR". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:42:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:42:10 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:45:42 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #14 from Kyle M Hall --- Created attachment 35704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35704&action=edit Bug 13240 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:47:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:47:59 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:48:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:48:01 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35361|0 |1 is obsolete| | Attachment #35362|0 |1 is obsolete| | Attachment #35704|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 35705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35705&action=edit [PASSED QA] Bug 13240: Remove some code obfuscation my $bar; my $foo = $bar->{borrowernumber} ||= {}; $foo->{one} ||= 'something'; $foo->{two}++; What does $bar contain? $VAR1 = { 'borrowernumber' => { 'two' => 1, 'bar' => 'something' } }; Not really obvious. Maybe something I did not see is hidden. Test plan: Verify the digest for DUE and PREDUE work as before. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:48:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:48:08 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #16 from Kyle M Hall --- Created attachment 35706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35706&action=edit [PASSED QA] Bug 13240: Remove commented warns Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 15:48:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 14:48:11 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #17 from Kyle M Hall --- Created attachment 35707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35707&action=edit [PASSED QA] Bug 13240 [QA Followup] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 16:08:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 15:08:46 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #18 from Colin Campbell --- (In reply to Jonathan Druart from comment #12) > (In reply to Colin Campbell from comment #11) > > In the perl world using $x->{one}->{two} rather than $x->{one}{two} is the > > most common. one reason is that the arrow syntax can be used in a string > > e.g. print "Var: $x->{one}->{two}" > > > > using the non-arrow syntax in this way does not do what you may think it does > > Are you sure? > I often use it, > > use Modern::Perl; > my $h = { foo => { bar => 'foobar' } }; > say "my string with $h->{foo}->{bar}"; > say "my string with $h->{foo}{bar}"; > > outputs: > > my string with foobar > my string with foobar Without pausing fpr thought its not obvious which of the first three is doing what you want: #!/usr/bin/perl use feature qw( say ); my $list = [ 'foo', 'bar' ]; say "my string with $list[0]"; say "my string with ${list}[0]"; say "my string with ${$list}[0]"; say "my string with $list->[0]"; outputs: my string with my string with ARRAY(0x936cb8)[0] my string with foo my string with foo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 16:19:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 15:19:05 +0000 Subject: [Koha-bugs] [Bug 13675] New: the budget of an order is set to null if not changed on receiving Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Bug ID: 13675 Summary: the budget of an order is set to null if not changed on receiving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Note that this bug should not appear using the interface. C4::Acquisition::ModReceiveOrder updates the aqorders with budget_id=NULL if no budget_id given in parameter. Actually the same budget_id should be used. In tests (especially t/db_dependent/Acquisition/TransferOrder.t), ModReceiveOrder is not called with a budget_id param and set to NULL the budget_id value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 16:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 15:22:43 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 16:22:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 15:22:47 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 --- Comment #1 from Jonathan Druart --- Created attachment 35708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35708&action=edit Bug 13675: Do not set aqorders.budget_id to NULL C4::Acquisition::ModReceiveOrder updates the aqorders with budget_id=NULL if no budget_id given in parameter. Actually the same budget_id should be used. In tests (especially t/db_dependent/Acquisition/TransferOrder.t), ModReceiveOrder is not called with a budget_id param and set to NULL the budget_id value. test plan: prove t/db_dependent/Acquisition/TransferOrder.t should return green Note that this bug should not appear using the interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 16:23:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 15:23:06 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 16:27:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 15:27:38 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22726|0 |1 is obsolete| | --- Comment #21 from Julian Maurice --- Created attachment 35709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35709&action=edit Bug 7957: Routing lists enhancements Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 16:27:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 15:27:44 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 16:27:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 15:27:48 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35708|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 35710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35710&action=edit Bug 13675: Do not set aqorders.budget_id to NULL C4::Acquisition::ModReceiveOrder updates the aqorders with budget_id=NULL if no budget_id given in parameter. Actually the same budget_id should be used. In tests (especially t/db_dependent/Acquisition/TransferOrder.t), ModReceiveOrder is not called with a budget_id param and set to NULL the budget_id value. test plan: prove t/db_dependent/Acquisition/TransferOrder.t should return green Note that this bug should not appear using the interface. Signed-off-by: Tomas Cohen Arazi The fix makes sense, and running $ prove t/db_dependent/Acq* returns all green. koha-qa.pl also likes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 16:27:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 15:27:50 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 17:37:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 16:37:36 +0000 Subject: [Koha-bugs] [Bug 13676] New: OpacSuppression description says 'items' but means 'records' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676 Bug ID: 13676 Summary: OpacSuppression description says 'items' but means 'records' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The OpacSuppression preference description is not clear: ... items marked as suppressed from OPAC search results. Note that you must have the Suppress index set up in Zebra and at least one suppressed item, or your searches will be broken. ... The feature works on record level, not on item level. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 17:37:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 16:37:44 +0000 Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 17:39:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 16:39:58 +0000 Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 --- Comment #2 from Marc V?ron --- Still valid in current master 3.19.00.008 Additionally, Language selector displays at top of page 2 and overlays other text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 18:11:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 17:11:00 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #13 from H?ctor Eduardo Castro Avalos --- (In reply to H?ctor Eduardo Castro Avalos from comment #12) > (In reply to Marc V?ron from comment #11) > > Exporting to Dublin Core... > > Simple DC-RDF -> Can save file > > DC-XML -> Can save file > > OAI-DC -> Can save file > > > > DC-RDF (Recommendend) and all of the additional selections (rdfxml or > > rdfjson etc) -> > > Software error: > > Only alphanumerics are allowed in N-Triples bnode labels > > Hi, Marc, this error is because you need to up-to date RDF-Helper or > RDF-Trine with CPAN modules. Sorry about my previous short message, Marc. Let me ask you a question. Did you install RDF::Helper and, RDF::Trine from a .deb package? Because the .deb packages are not up-to-date (librdf-helper-perl, librdf-trine-perl). I forgot to explain in the commit message that is necessary to upgrade these modules. I upgraded with App::cpanminus. Go to > More > About Koha > Perl modules to see if these modules need to be upgraded. Regards P.S. If another error found, please let me know -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 18:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 17:21:20 +0000 Subject: [Koha-bugs] [Bug 13677] New: UseKohaPlugins is on Catalog enrichtment tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13677 Bug ID: 13677 Summary: UseKohaPlugins is on Catalog enrichtment tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In the system preference editor UseKohaPlugins appears on the enhanced content tab. As it enables a whole new module on staff side, it would maybe be better under staff client? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 18:41:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 17:41:17 +0000 Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 18:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 17:51:43 +0000 Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 --- Comment #3 from Marc V?ron --- Created attachment 35711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35711&action=edit Bug 12399 - opaccredits printing at top on printable version This patch introduces a new class "noprint" in koha-tmpl/opac-tmpl/bootstrap/css/print.css With this class, unwanted elements can be hidden when printing. To test: In OPAC, do a search with many results (> 1 Page) Print page or do a print preview See that footer elements are not displayed correctly (as of screenshot in comment #1) and that on top of page 2 the language selector overlays the list Apply patch Repeat steps above. Verify that printed page looks much nicer now by hiding unwanted elements (including e.g. RSS icon, toolbar etc.) This mechanism can be used on other pages as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 18:52:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 17:52:59 +0000 Subject: [Koha-bugs] [Bug 12399] opaccredits printing at top on printable version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 19:03:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 18:03:15 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Suzanne Fayle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 19:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 18:05:35 +0000 Subject: [Koha-bugs] [Bug 13678] New: library locator in mobile view (or all views) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13678 Bug ID: 13678 Summary: library locator in mobile view (or all views) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Would be great if when you were on your mobile device you could click library locator and find libraries that are near by to where you are. It would even be great if this was on the browser view as well. Maybe we can use this technology: http://www.w3schools.com/html/html5_geolocation.asp Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 19:37:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 18:37:02 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #14 from Marc V?ron --- Hi H?ctor, Yes, I installed both from a .deb package I was then able to update RDF::Helper to the required version using cpan, but not RDF::Trine (got a lot of dependency errors and had no luck to track them down). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 19:56:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 18:56:33 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Jerry Weng changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #11 from Jerry Weng --- Indeed, using "-v (lower case)" instead of "-V (upper case)" to get the Apache version information is better and should be faster. But I would keep the [0] part to extract only the needed Apache version info., especially the 'uname -a' is already there, and the "Server built:" time is meaningless in apt-get installed package. > $apacheVersion = (`/usr/sbin/apache2ctl -v`)[0] unless $apacheVersion; Regards, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 20:19:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 19:19:26 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #15 from H?ctor Eduardo Castro Avalos --- (In reply to Marc V?ron from comment #14) > Hi H?ctor, > > Yes, I installed both from a .deb package > > I was then able to update RDF::Helper to the required version using cpan, > but not RDF::Trine (got a lot of dependency errors and had no luck to track > them down). Try to install libmodule-install-rdf-perl and then upgrade RDF::Trine with cpanm. So the question is how to add this file into debian/control? Do you know something about it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 23:23:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 22:23:12 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 23:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 22:23:16 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34994|0 |1 is obsolete| | --- Comment #43 from Nick Clemens --- Created attachment 35712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35712&action=edit [SIGNED OFF] Bug 9351 - item type not recorded correctly in statistics for returns and some local use When returning a loan, or when returning an item for local use, the corresponding entry in the statistics table takes the item type from the bib level. This is incorrect when item-level item types is enabled. This patch corrects this problem by getting itemtype from $item->{'itype'} which comes from item or biblio level in GetItem(). Test plan : - On a catalogue with itemtype on item level, perform a return an look at statistics table - Idem for a catalogue with itemtype on biblio level Signed-off-by: Kyle M Hall Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 23:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 22:23:27 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34995|0 |1 is obsolete| | --- Comment #44 from Nick Clemens --- Created attachment 35713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35713&action=edit [SIGNED OFF] Bug 9351 - sql update on existing statistics Signed-off-by: Kyle M Hall Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 23:23:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 22:23:38 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35578|0 |1 is obsolete| | --- Comment #45 from Nick Clemens --- Created attachment 35714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35714&action=edit [SIGNED OFF] Bug 9351 - item type not recorded correctly in statistics for returns and some local use - followup This patch corrects previous for AddReturn() : - $item->{'itype'} instead of $biblio->{'itype'} - and my $biblio is not set so it is useless - removes FIXME comment Also adds a TODO comment in CanBookBeIssued() : - $item->{'itemtype'}=$item->{'itype'}, this line may be useless now Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 6 23:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Feb 2015 22:38:10 +0000 Subject: [Koha-bugs] [Bug 12403] Batch record deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 05:04:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 04:04:12 +0000 Subject: [Koha-bugs] [Bug 13679] New: There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Bug ID: 13679 Summary: There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 05:06:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 04:06:26 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 05:06:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 04:06:29 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 --- Comment #1 from Chris Cormack --- Created attachment 35715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35715&action=edit Bug 13679 : Bug in listing overdues To test 1/ Create some overdues and some issues due in the future 2/ Run the overdues script 3/ Notice item due in the future is in the list 4/ Apply patch 5/ Run script again 6/ Notice in the future not in the list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 05:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 04:06:50 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12529 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 05:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 04:06:50 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13679 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 16:14:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 15:14:48 +0000 Subject: [Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Status|Needs Signoff |Failed QA --- Comment #2 from Nick Clemens --- I tried testing, in terms of not letting me check digest box until I checked email it worked. But I ran into some issues: 1 - When initially trying to click on the digest box (with nothing else checked) my browser focus jumps to the top of the page, same when I click on email box. Third try stayed and let me click email box. 2 - If I had only email enabled I was unable to save any preferences, I got a "Please enter a valid email address" note in red next to the checkbox. Entering a valid email did not clear it, entering secondary etc. emails did not. Editing the account to add a valid email, saving, then trying to check a messaging box also failed. The only way I could past this error was to enable additional transports, phone or SMS in any combination removed the error amd actually let me check email whether or not I had a valid email address on file. When I switch to master I cannot get this error 3 - While I was prevented from checking digest until another transport was selected, digest wasn't cleared when I unchecked the emial box. It didn't save, which is good, but the box should be cleared too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 16:32:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 15:32:58 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |nick at quecheelibrary.org --- Comment #24 from Nick Clemens --- I tried looking at this, I think that two patches were obsoleted that shouldn't have been. If I am right 32747 and 34813 should be un-obsoleted and the patch can be moved to passed-qa as I think a small rebase doesn't need a new signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 17:29:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 16:29:30 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 18:24:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 17:24:52 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 18:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 17:24:55 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35030|0 |1 is obsolete| | --- Comment #105 from Brendan Gallagher --- Created attachment 35716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35716&action=edit Bug 7904: (QA followup) fix tests The package name for SIP wasn't fixed in the tests by the original patches. This patch fixes it. To test: - Run $ prove t/db_dependent/SIP_ILS.t - Tests should pass with the patch. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 18:28:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 17:28:02 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35716|0 |1 is obsolete| | --- Comment #106 from Brendan Gallagher --- Created attachment 35717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35717&action=edit Bug 7904: (QA followup) fix tests The package name for SIP wasn't fixed in the tests by the original patches. This patch fixes it. To test: - Run $ prove t/db_dependent/SIP_ILS.t - Tests should pass with the patch. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 18:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 17:28:28 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #107 from Brendan Gallagher --- Created attachment 35718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35718&action=edit Bug 7736 Edifact QUOTE, ORDER and INVOICE handling Handle Electronic Ordering via Edifact Messages This commits adds files to allow interfacing with book suppliers using Edifact Messages Currently this supports transferring files by ftp or sftp There is also an option to read/write to a local directory which may be useful for testing or other scenarios Quote messages are used to create baskets in Koha and will create the associated bib and item records if required If the user chooses to generate an edifact order from a basket an Edifact format message is created for submission If receiving an Invoice Message a corresponding invoice is created in Koha and the order is receipted Suppliers interfaces need to be properly configured to send the correct budget, item type etc info For more info on Edifact Formats see http://www.editeur.org/31/Library-Book-Supply Signed-off-by: Brendan Gallagher Following test plan this works great. Doesn't break ACQ. There are a few little spots QA can followup with but should go through. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 18:29:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 17:29:25 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35717|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 18:31:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 17:31:52 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #108 from Brendan Gallagher --- (In reply to Brendan Gallagher from comment #106) > Created attachment 35717 [details] [review] > Bug 7904: (QA followup) fix tests > > The package name for SIP wasn't fixed in the tests by the original patches. > > This patch fixes it. > > To test: > - Run > $ prove t/db_dependent/SIP_ILS.t > - Tests should pass with the patch. > > Signed-off-by: Tomas Cohen Arazi > > Signed-off-by: Brendan Gallagher Sorry grabbed the wrong patch (too overzealous) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 19:00:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 18:00:27 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 19:00:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 18:00:29 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35600|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 35719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35719&action=edit Bug 12911 - batch_id for new labels batches can be asssigned to several batches Currently batch_id is assigned upon creation of a new batch object. This patch leaves batch_id as 0 at creation and adds a check when adding items. If batch is new then batch_id is created then Test plan: 1 -In one browser window, go to tools->label creator and click the new batch button 2 - Before adding items, open a new browser, and go tools->label creator and click the new batch button 3 - Note that both batches have the same number listed 4 - Add an item to the first batch - you should now see one item in the batch 5 - Add an item to the second batch, you should see two items in the batch 6 - Apply patch and repeat steps 1&2 7 - Note that neither batch lists a batch number 8 - Add an item to the first batch, you should see one item and a batch number 9 - Add an item to the second batch, you should see one item and a new batch number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 19:39:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 18:39:20 +0000 Subject: [Koha-bugs] [Bug 13680] New: Items list on edit items page separates add items form from header and sidebar Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Bug ID: 13680 Summary: Items list on edit items page separates add items form from header and sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nick at quecheelibrary.org QA Contact: testopia at bugs.koha-community.org Created attachment 35720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35720&action=edit Proposed layout On records with multiple items attached the add items form can be pushed down the page, separating it from the header and sidebar and requiring a choice between where pages focus should fall and often leading to scrolling depending on your action. See bug 11905 A different solution would be to move the existing items list to the bottom of the page. This is a fairly striking difference, but with the addition of edit item links on the record detail page I don't think it makes selecting an item to edit more onerous. That being said, change is upsetting and I believe this would need some discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 19:48:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 18:48:10 +0000 Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 19:48:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 18:48:13 +0000 Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #1 from Nick Clemens --- Created attachment 35721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35721&action=edit Bug 13680 - Items list on edit items page separates add items form from header and sidebar This patch moves the items table on the edit items screen to the bottom of the page. Test plan: 1 - Apply patch 2 - Ensure adding/editing items works as previously -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 19:48:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 18:48:45 +0000 Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Assignee|oleonard at myacpl.org |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 21:16:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 20:16:03 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 22:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 21:24:59 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #109 from Chris Cormack --- > > Signed-off-by: Brendan Gallagher > Following test plan this works great. Doesn't break ACQ. > There are a few little spots QA can followup with but should > go through. Thanks! Can you let us know what the spots are? To help QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 22:29:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 21:29:08 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #110 from Brendan Gallagher --- (In reply to Chris Cormack from comment #109) > > > > Signed-off-by: Brendan Gallagher > > Following test plan this works great. Doesn't break ACQ. > > There are a few little spots QA can followup with but should > > go through. Thanks! > > Can you let us know what the spots are? To help QA? Sure thing! Running the QA script I see that is having some trouble with the license (that's an easy QA follow-up IMO). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 22:32:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 21:32:49 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #111 from Katrin Fischer --- If you spot this while signing off, please note and fail - it will save the time of a QA team member - and easy to sign off on the follow up then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 22:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 21:38:28 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #112 from Brendan Gallagher --- Hey Collin or Martin - Can you run these through the QA script and fix up the errors, then I'll be happy to mark it as signed off again. Thanks, Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 22:56:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 21:56:24 +0000 Subject: [Koha-bugs] [Bug 13681] New: Enable/Disable Marc Frameworks Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13681 Bug ID: 13681 Summary: Enable/Disable Marc Frameworks Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 35722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35722&action=edit Marc Framework list It would be nice to enable or disable MARC Frameworks without the need of deleting them. It should be done as a new column in the list of frameworks or with a new checkbox (ON/OFF) where it is edited.This will be take effect in the pulldown framework selection control in the cataloging screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 7 22:57:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Feb 2015 21:57:16 +0000 Subject: [Koha-bugs] [Bug 13681] Enable/Disable Marc Frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13681 --- Comment #1 from bondiurbano --- Created attachment 35723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35723&action=edit Framework selection in cataloging module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 03:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 02:24:30 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nick Clemens --- *** Bug 11924 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 03:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 02:24:30 +0000 Subject: [Koha-bugs] [Bug 11924] warning about hold when item checked in at wrong library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11924 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |nick at quecheelibrary.org --- Comment #1 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 13153 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 13:19:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 12:19:42 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Hi H?ctor, I took a quick look at the list of files in your patch - there are a lot of permission changes on files in there, that I think were not intentional - could you check please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 13:21:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 12:21:55 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #17 from Katrin Fischer --- Also adding Robin here, because of the new dependencies added by this patch. All dependencies needed for Koha should be available as packages later (comment#15). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 13:25:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 12:25:34 +0000 Subject: [Koha-bugs] [Bug 13621] OpacTopissue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13621 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Christopher, maybe this would be better on the mailing list? - Only a few people are reading the bugs list, so not a lot of people will notice your question here. On the other hand for a bug report we'd need more information on the problems you see. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 13:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 12:28:48 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 13:30:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 12:30:23 +0000 Subject: [Koha-bugs] [Bug 13661] Prevent sabotaging Zebra indexing from the cataloguing module by creating a subfield with a very long word. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I wonder, shouldn't the max length definition on the subfield configuration page stop you from doing this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 13:33:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 12:33:32 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #81 from Katrin Fischer --- Hi Nick, reading your comment - good catch! Moving to Failed QA for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 14:55:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 13:55:37 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:21:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:21:44 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 --- Comment #5 from Katrin Fischer --- Comment on attachment 35703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35703 [SIGNED OFF] Bug 13352: On editing, prices should not be formatted Review of attachment 35703: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13352&attachment=35703) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt @@ +462,5 @@ > > >
  • > > + I think it's not needed here - this is a percentage, not a price. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:26:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:26:18 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:26:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:26:21 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35703|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 35724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35724&action=edit [PASSED QA] Bug 13352: On editing, prices should not be formatted Bug 12979 refactored the way to display prices. The price format configuration was duplicated everywhere it was used. All calls looks good except the one in admin/aqbudgetperiods.pl In this one, the prices are formatted for an edition field (input). This means the input is incorrectly filled even if the user does not update the field. At the end, maybe should we manage formatted prices everywhere, even in inputs, but it's not in the scope of this bug. Technically, a new subroutine format_for_editing is added to the Koha::Number::Price module. It should be called everywhere a price is displayed in an input field. At the moment, it only does a sprintf("%.2f"), but it is a first step to let the number of decimals to display configurable. To test: 1/ Verify the issue described is fixed (editing a budget with a total amount > 1000 (With CurrencyFormat is US or FR). 2/ Verify you can edit a fund with a total amount > 1000 Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:26:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:26:45 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 --- Comment #7 from Katrin Fischer --- Created attachment 35725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35725&action=edit Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:36:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:36:32 +0000 Subject: [Koha-bugs] [Bug 13488] FastMmap can not be disable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Running into this again right now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:44:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:44:57 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #24 from Katrin Fischer --- Tested with both patches applied after running into the FastMmap issue again. This seems to work fine, but there is a small discrepancy to the test plan: >3) Do not include UID in the sharefile name (it will be constructed >using namespace + database name + database host instead). > >Test plan addendum: > > s/and UID// My files were created in: /tmp/sharefile-koha-koha-localhost-koha So it looks like the UID is still present? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:49:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:49:15 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #25 from Katrin Fischer --- Maybe just a documentation issue? Test plan says: namespace + database name + database host But code looks more like: namespace + database host + database name + $share_file = join( '-', + "/tmp/sharefile-koha", $self->{'namespace'}, + C4::Context->config('hostname'), C4::Context->config('database') ); Signing off - please check my assumptions are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:51:07 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:51:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:51:11 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34453|0 |1 is obsolete| | Attachment #34826|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer --- Created attachment 35726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35726&action=edit [SIGNED OFF] Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues 1) Removed 'use C4::Context;' because it can lead to introduction of circular reference in the near future 2) Put fastmmap initialization code into an eval {} block, to catch various kinds of errors which can still occur during it's init in some [less usual] Koha setups and/or more unusual circumstances 3) Do not include UID in the sharefile name (it will be constructed using namespace + database name + database host instead). Test plan addendum: s/and UID// Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:52:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:52:10 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #27 from Katrin Fischer --- Created attachment 35727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35727&action=edit [SIGNED OFF] Bug 13431 - Shared FastMmap file causes issues Koha::Cache package does not take into account that, when using fastmmap caching variant, mmaped cache file created in /tmp (typically: /tmp/sharefile-koha-koha), would only be further accessible to the one given OS user - the one which created it. In many Koha setups, in the circumstances when various system scripts are executed by 2+ users with diffrent UIDs (like multi-tenant servers, for example) this may cause many kinds of issues. Observable symptom is usually the appearance of the below error when searching, or looking at MARC Framework pages and a few other places: Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. This patch: - disables initialisation of fastmmap caching subsystem unless it is explicitly requested by the user (CACHING_SYSTEM=fastmmap) - disables fastmmap cache usage for command line scripts (i.e. when GATEWAY_INTERFACE environment variable is not defined) - adds the database name, host name and an ID of the OS user to the mmaped file name created in /tmp, to prevent various kinds of unintentional conflicts and/or permission problems from happening To test: 1) remove the /tmp/sharefile-koha-* file[s] (if any) 2) do something which would lead to its re-creation (e.g., performing any search in OPAC should be sufficient to cause that) 3) observe that /tmp/sharefile-koha-koha got created 4) remove it 5) apply patch 6) redo step 2) 7) observe that aforementioned file is no longer created in /tmp 8) set CACHING_SYSTEM environment variable to 'fastmmap' 9) redo step 2), observe that /tmp/sharefile-koha-* file got created and that it's name now contains hostname, database name and UID 10) ensure that everything still works like it should and that there are no regressions of any kinds anywhere in the system ;) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:52:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:52:14 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35726|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 35728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35728&action=edit [SIGNED OFF] Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues 1) Removed 'use C4::Context;' because it can lead to introduction of circular reference in the near future 2) Put fastmmap initialization code into an eval {} block, to catch various kinds of errors which can still occur during it's init in some [less usual] Koha setups and/or more unusual circumstances 3) Do not include UID in the sharefile name (it will be constructed using namespace + database name + database host instead). Test plan addendum: s/and UID// Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:53:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:53:50 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #29 from Katrin Fischer --- One last note: How can we best document the new CACHING_SYSTEM=fastmmap? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:54:33 +0000 Subject: [Koha-bugs] [Bug 13488] FastMmap can not be disable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- bug 13431 will fix this problem by making it necessary to turn it on explicitly. *** This bug has been marked as a duplicate of bug 13431 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:54:33 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaune at biblibre.c | |om --- Comment #30 from Katrin Fischer --- *** Bug 13488 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:56:18 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:59:20 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 16:59:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 15:59:23 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35675|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 35729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35729&action=edit [PASSED QA] Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords It appears that an empty string is sneaking into the list of words to highlight and that is causing the browser to freak out. Test Plan: 1) Enable NoveList 2) Enable OpacHighlightedItems 3) Search a title with a series (i.e. The Hunger Games) 4) Click into the record 5) Click on the series to search it 6) Click on a title in the search results 7) If Firefox doesn't crash, it gives the unresponsive script message 8) Apply this patch 9) Repeat steps 3-6 10) Browser doesn't freak our Signed-off-by: Jason Robb Signed-off-by: Katrin Fischer could not confirm the problem, but small change and highlighting terms on result list and couldn't find any regressions in highlighting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:06:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:06:45 +0000 Subject: [Koha-bugs] [Bug 13636] Search results item status incorrect for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13636 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:06:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:06:48 +0000 Subject: [Koha-bugs] [Bug 13636] Search results item status incorrect for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13636 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35608|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 35730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35730&action=edit [PASSED QA] Bug 13636 - Staff search results item status incorrect for holds Imagine this scenario: we have one record with four items. Two of those items are checked out, one of those items is a waiting hold, and one of those items is available. We would expect to see this on the search results page. Instead, we will see both non-checked out items as unavailable due to waiting holds. This is due to a semantic issue GetReserveStatus. C4::Search::searchResults uses GetReserveStatus to get the reserve status of each item, but unlike all other calls to the sub, this one passes in not only itemnumber, but biblionumber. When no reserve is found for the available item, the subroutine uses the biblionumber to grab what is essentially an arbitrary reserve to use for the status. This makes no sense and this functionality should be entirely removed from the subroutine so regressions like this will be prevented in the future. Test Plan: 1) Create one record with 4 items a) check two of the items out to patrons b) set one of the items as a waiting hold c) leave the fourth item as available 2) Run a search where this record will be in the results list 3) Note that the results list 2 items on loan, two unavailable 4) Apply this patch, reload the search results 5) Note that the results list 1 available, 2 on loan, 1 unavailable Signed-off-by: John Andrews Signed-off-by: Sheila Kearns Signed-off-by: Katrin Fischer Note: This is for the staff search result list! Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:12:40 +0000 Subject: [Koha-bugs] [Bug 13682] New: Capitalization: Holds Queue Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Bug ID: 13682 Summary: Capitalization: Holds Queue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org "Holds Queue" should be "Holds queue" on the Circulation > Holds queue page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:12:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:12:50 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:18:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:18:15 +0000 Subject: [Koha-bugs] [Bug 13683] New: Display library name on holds queue page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13683 Bug ID: 13683 Summary: Display library name on holds queue page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org On the holds queue report page if holds are found for a library, it displays: x items found for MPL above the table. Instead of showing 'MPL' it should show the library's name using the TT plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:18:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:18:21 +0000 Subject: [Koha-bugs] [Bug 13683] Display library name on holds queue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:20:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:20:02 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:20:06 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35676|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 35731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35731&action=edit [PASSED QA] Bug 13670 - Patron holds table not loading when holds tab anchor is used If a link to a patron record ends with #reserves, the holds tab is selected on page load, but the holds table does not load. Test Plan: 1) Build your holds queue 2) From the holds queue report, open any patron link 3) Note the patron's reserves do not load 4) Apply this patch 5) Clear your browser cache 6) Repeat step 2 7) Note the holds table now loads Signed-off-by: Sean McGarvey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:26:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:26:25 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:26:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:26:28 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35710|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 35732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35732&action=edit [PASSED QA] Bug 13675: Do not set aqorders.budget_id to NULL C4::Acquisition::ModReceiveOrder updates the aqorders with budget_id=NULL if no budget_id given in parameter. Actually the same budget_id should be used. In tests (especially t/db_dependent/Acquisition/TransferOrder.t), ModReceiveOrder is not called with a budget_id param and set to NULL the budget_id value. test plan: prove t/db_dependent/Acquisition/TransferOrder.t should return green Note that this bug should not appear using the interface. Signed-off-by: Tomas Cohen Arazi The fix makes sense, and running $ prove t/db_dependent/Acq* returns all green. koha-qa.pl also likes it. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:40:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:40:48 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #46 from Katrin Fischer --- Ok, it works now alright for item-level itypes = specific item, but setting the syspref to bibio level it still takes the itype from the item level? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:52:55 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28926|0 |1 is obsolete| | --- Comment #8 from Viktor Sarge --- Created attachment 35733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35733&action=edit Bug 7843 Create an RSS feed for news in Opac Test plan: * Install the patch * Make shure there is news in the Opac * Go to the Opac (opac-main.pl) * Make shure you see an RSS icon below the news and a short text. * Click the RSS icon and verify that you get an RSS feed that validates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:52:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:52:58 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #22 from Katrin Fischer --- I fail to replicate the issue in the bootstrap OPAC. I am not able to place another hold, but there is no good feedback - the button just won't work. Investigating further. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 20:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 19:59:50 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- I fail to see a message on the bootstrap OPAC with the patches as well. Test done: - Place an item level hold on a record - Get redirected to patron account - Use back button of the browser - Hit 'place hold' button again - it's not functional, nothing happens Kyle, can you please take a look? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 21:07:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 20:07:18 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Viktor Sarge --- Ok first of all - sorry I forgot about this one for a long time. But here's a new patch. Validation of the feed is ok but it still wants an unique identifier. I chose however to rather keep it a small patch and update if people are ok with the additional changes to news. Especially since I'd like to have a newsarchive + a view for single newsitems to link to. The text "RSS for the librarys general newsfeed." on opac-main.pl is there to try and explain to people will se only news directed to all libraries and will not get the news they might be seeing if they are logged in to a branch. We will need a way to switch between branches since both news, CSS and other content might be different on the branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 21:09:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 20:09:06 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 21:09:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 20:09:09 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35450|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 35734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35734&action=edit [PASSED QA] Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment The hbyymmincr autoBarcode builder looks up all barcodes that begin with any number of letters ( the branchcode ) and a two-digit year directly afterward ( e.g. MPL15 ), then grabs the last four digits as the increment counter. The problem is, this does not take months into account, so unlike the description that says the system is limited to 10,000 items a month, it is limited to 10,000 items per *year*. This situation can easily be corrected my adding the month into the lookup ( e.g. MPL1501 ). Test Plan: 1) Enable autoBarcode, set to hbyymmincr 2) Catalog an item, let the barcode.pl plugin generate the next barcode. 3) Catalog an item with the barcode MPL15009999 4) Catalog another item, use the barcode.pl plugin to generate the next barcode. 5) Note the barcode is generated ends with '0001' instead of the correct increment 6) Apply this patch 7) Repeat step 4 8) Note the barcode now ends with the correct increment Signed-off-by: Kyle M Hall Signed-off-by: Jeanne Heicher Signed-off-by: Katrin Fischer Problem confirmed - the continuing number bit was not reset to start counting from 1 again on the beginning of a new month. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 21:10:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 20:10:47 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 --- Comment #5 from Katrin Fischer --- After testing this I understand better - the problem is that the last bit of the number is not reset each month but keeps counting. I feel ok about changing it now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 22:10:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 21:10:58 +0000 Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 22:11:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 21:11:02 +0000 Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648 --- Comment #1 from Katrin Fischer --- Created attachment 35735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35735&action=edit Bug 13648: OPAC = hidden removes pull down from edit item form If you uncheck the checkbox OPAC in the bibliographic framework definition for an item subfield that is linked to an authorized value list, the pull down will disappear from the item edit form on staff. The label still shows. 1) Go to administration > bibliographic frameworks 2) Select a framework and go to the item field (MARC21: 952) 3) Edit a subfield with an authorized values list like damaged, lost or withdrawn 4) Uncheck the checkbox for OPAC visibility 5) Edit or add an item within your chosen framework 6) Verify the subfield code and description are shown, but the pull down has disappeared 7) Apply patch, verify the pull down shows now 8) Also test following hidden combination works correctly: OPAC: checked All other options: unchecked Documentation of hidden values: http://wiki.koha-community.org/wiki/Hidden_values With special thanks to Jonathan Druart for helping me figure this out! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 22:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 21:13:44 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 --- Comment #3 from Katrin Fischer --- Hi Marc, I have the same result, but the css files don't seem to be linked to from anywhere. My guess is, that we kept them around for look-up, but that they are not used any longer. Owen, could you confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 22:19:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 21:19:21 +0000 Subject: [Koha-bugs] [Bug 13643] Can't subscribe to serial emails anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Nicole, I have tested this on 3.18.3 and current master and the link shows alright for me. Conditions: In the subscription a notification template has been chosen and the user is logged in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 22:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 21:25:47 +0000 Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35735|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 35736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35736&action=edit Bug 13648: OPAC = hidden removes pull down from edit item form If you uncheck the checkbox OPAC in the bibliographic framework definition for an item subfield that is linked to an authorized value list, the pull down will disappear from the item edit form on staff. The label still shows. 1) Go to administration > bibliographic frameworks 2) Select a framework and go to the item field (MARC21: 952) 3) Edit a subfield with an authorized values list like damaged, lost or withdrawn 4) Uncheck the checkbox for OPAC visibility 5) Edit or add an item within your chosen framework 6) Verify the subfield code and description are shown, but the pull down has disappeared 7) Apply patch, verify the pull down shows now 8) Also test following hidden combination works correctly: OPAC: checked All other options: unchecked Documentation of hidden values: http://wiki.koha-community.org/wiki/Hidden_values With special thanks to Jonathan Druart for helping me figure this out! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 22:31:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 21:31:07 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #25 from Katrin Fischer --- I tested with one patch visible on the bug report right now and found a small regression: Problem: Amazon cover exists, no local cover With patch: no cover is shown in detail page Without patch: Amazon cover shows Problem?: Amazon cover and local cover exist With patch: local cover is shown Without patch: Amazon cover is shown OK: Only local cover exists With patch: local cover is shown Without patch: no cover is shown Simith or Maxime, can you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 22:49:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 21:49:36 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #10 from Mirko Tietgen --- (In reply to M. de Rooy from comment #9) > QA Comment: > What about: Your configuration file seems to be setup for . > And for grs1: Your configuration file still seems to be setup for . OK. > > Warning message: The entry is set to dom, but your > system appears to be set up for grs1 indexing. It is safe to ignore this > warning if biblio search is working. > I would recommend to remove the last sentence. There is something wrong > here. Let them find out and correct. If we already add 'safe to ignore', > does this warning still have any function? OK. As GRS1 seems to be kicked out pretty soon now, I agree with your changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 8 23:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 22:27:34 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #198 from Katrin Fischer --- (In reply to Kyle M Hall from comment #165) > (In reply to Katrin Fischer from comment #164) > > Hi Kyle, > > > > have you been able to reproduce/fix the first issue with the javascript > > error in the OPAC? > > Not yet, would it be possible for you to create a video to demonstrate the > issue? That way I can see if I'm making mistakes in my attempt to reproduce > the problem. I can't do a video - but I found the reason: "NetworkError: 404 Not Found - http://localhost/cgi-bin/koha/svc/patron/show_checkouts_to_relatives" This file is not added by this patch set, but referenced in opac-memberentry.tt on line 829. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 00:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 23:16:20 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #18 from Robin Sheat --- (In reply to Katrin Fischer from comment #17) > Also adding Robin here, because of the new dependencies added by this patch. > All dependencies needed for Koha should be available as packages later > (comment#15). Packages need to be created for: HTML::Entities XML::Entities Please verify that the versions specified for: RDF::Trine RDF::Helper are actually the real minimum required, as they are not in any released debian version as they are specified, and that makes life substantially harder. Hopefully the dependency issues noted by Marc aren't too serious, or it simply might not be possible to backport these modules to squeeze. It might be a while before I get to look into doing these (though they are added to my todo list) as I'm quite busy, if someone wants to help speed it along, try building the packages using dh-make-perl and testing them under squeeze (a pbuilder environment helps here), and noting anything special that has to be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 00:21:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 23:21:17 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 00:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 23:21:23 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 --- Comment #12 from Robin Sheat --- Created attachment 35737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35737&action=edit Bug 13607: fix to account for _ in fieldnames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 00:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Feb 2015 23:22:55 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 --- Comment #13 from Robin Sheat --- (In reply to Magnus Enger from comment #11) > Also, the "message" in the response would look better without the trailing > newline, I think. I agree, but if you remove the \n then die adds "in file blah.pl line 123", which I think is even worse than a trailing newline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 06:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 05:20:55 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #47 from David Cook --- (In reply to Katrin Fischer from comment #46) > Ok, it works now alright for item-level itypes = specific item, but setting > the syspref to bibio level it still takes the itype from the item level? Yes, but that's already the default behaviour for the other existing instances of UpdateStats() (e.g. issues and renewals). I think requiring handling of biblio level itypes would be scope creep for this bug, since this bug is just trying to create consistency. If we want to support biblio level itypes, I think that should be a separate bug which then fixes it across the board for all calls of UpdateStats(). But that's just my 2 cents :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 06:48:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 05:48:59 +0000 Subject: [Koha-bugs] [Bug 12916] Use of uninitialized values $max and $min in C4/Tags.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12916 --- Comment #16 from M. Tompsett --- Could this be included in 3.16.x? It applies cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 07:52:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 06:52:20 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #62 from M. Tompsett --- Comment on attachment 28360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28360 Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Review of attachment 28360: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=28360) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2414,5 @@ > + my @branches = GetIndependentGroupModificationRights(); > + $query .= > + " AND ( borrowers.branchcode = ? OR borrowers.branchcode IN ( " > + . join( ',', ('?') x @branches ) . " ) ) "; > + push( @query_params, @branches ); 2416 has a ? in addition to the join'd ones on 2417. This leads to an off by one error. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 08:06:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 07:06:40 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #48 from Katrin Fischer --- Hm, are you sure? >This patch corrects this problem by getting itemtype from $item->{'itype'} >which comes from item or biblio level in GetItem(). Maybe the reason is that I had both and it only falls back if you have no item level itypes? Fridolin, could you take a quick look and confirm what is he correct default behaviour? I would be really interesting to know if record level itypes still used by a lot of libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 08:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 07:39:35 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #14 from M. de Rooy --- (In reply to Julian Maurice from comment #13) > Patch rebased on master (and consequently on top of bug 13116) > > There is one unit test that fails in t/db_dependent/Holds.t (line 331), but > it fails on master too. > Should I open a separate bug for this ? Current master e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac does not fail this test with me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:46:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:46:57 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #19 from Marc V?ron --- During the weekend I finally was able to install the modules following comment #15. Feature seems to work OK, but I have the inpression that I messed up something in my VM during the installation of the modules. Have to go back to a previous copy of the VM. I have not to mutch time at the moment for further testing, sorry. Maybe somebody else can try to install the modules and test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:47:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:47:22 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29921|0 |1 is obsolete| | --- Comment #67 from Julian Maurice --- Created attachment 35738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35738&action=edit [SIGNED-OFF] Bug 8064: Merge several biblios Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:47:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:47:40 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29922|0 |1 is obsolete| | --- Comment #68 from Julian Maurice --- Created attachment 35739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35739&action=edit [SIGNED-OFF] Bug 8064: Change the way target record is built. Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:47:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:47:57 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29923|0 |1 is obsolete| | --- Comment #69 from Julian Maurice --- Created attachment 35740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35740&action=edit [SIGNED-OFF] Bug 8064: Fix issues with control fields and non-repeatable check Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:48:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:48:16 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29924|0 |1 is obsolete| | --- Comment #70 from Julian Maurice --- Created attachment 35741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35741&action=edit [SIGNED-OFF] Bug 8064: Little fix for 003, 005, 008 in MARC21 Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:48:35 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29925|0 |1 is obsolete| | --- Comment #71 from Julian Maurice --- Created attachment 35742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35742&action=edit [SIGNED-OFF] Bug 8064: Fix unit tests for createMergeHash Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:49:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:49:25 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:59:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:59:17 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|More ?System information? |More System information |about GRS1 vs DOM settings |about GRS1 vs DOM settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:59:31 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34745|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 09:59:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 08:59:41 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 10:00:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 09:00:00 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #11 from M. de Rooy --- Created attachment 35743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35743&action=edit Bug 13404 - More System information about GRS1 vs DOM settings System information indicates missing and entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for and if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 10:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 09:00:45 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #12 from M. de Rooy --- Created attachment 35744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35744&action=edit Bug 13404 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 10:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 09:01:10 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #13 from M. de Rooy --- Created attachment 35745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35745&action=edit Bug 13404: [QA Follow-up] Minor rewording of some warnings Changes are confirmed with author (Mirko Tietgen). See Bugzilla. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 10:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 09:02:21 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from M. de Rooy --- Struggling again with utf8 stuff in commit message, git/git-bz. Had to remove some special chars here and there.. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 12:32:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 11:32:42 +0000 Subject: [Koha-bugs] [Bug 12916] Use of uninitialized values $max and $min in C4/Tags.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12916 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 12:38:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 11:38:18 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35109|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 35746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35746&action=edit [SIGNED-OFF] Bug 13563: Add AngularJS Library to Koha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 12:38:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 11:38:55 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 12:39:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 11:39:02 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 13:22:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 12:22:59 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30385|0 |1 is obsolete| | Attachment #30386|0 |1 is obsolete| | Attachment #30387|0 |1 is obsolete| | Attachment #30388|0 |1 is obsolete| | Attachment #30389|0 |1 is obsolete| | Attachment #30390|0 |1 is obsolete| | --- Comment #36 from Julian Maurice --- Created attachment 35747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35747&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 13:23:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 12:23:26 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #37 from Julian Maurice --- All patches rebased and squashed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 14:51:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 13:51:11 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #11) > Comment on attachment 35651 [details] [review] > [PASSED QA] Bug 13602 - Username/password already exists when editing > borrower attributes and messaging preferences > > Review of attachment 35651 [details] [review]: > ----------------------------------------------------------------- > > ::: members/memberentry.pl > @@ +329,5 @@ > > } > > } > > + # Check if the userid is unique. Userid might not always be present in the edited values list when editing certain sub-forms, so we need to dig for it a bit. > > + my $userid = $newdata{'userid'}; > > + $userid = $borrower_data->{userid} unless $userid; #Get the userid straight from the DB > > In my opinion, > > my $userid = $newdata{userid} ? $newdata{userid} : > $borrower_data->{userid}; > > or > > my $userid = $newdata{userid}; > $userid ||= $borrower_data->{userid}; > > Would have been more readable. We could even use the defined-or operator: my $userid = $newdata->{ userid } // $borrower_data->{ userid }; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 14:51:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 13:51:59 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Created attachment 35725 [details] [review] > Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)" Looks consistent, thanks for the follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 14:54:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 13:54:47 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 15:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 14:40:52 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34936|0 |1 is obsolete| | --- Comment #88 from Julian Maurice --- Created attachment 35748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35748&action=edit Bug 11708: Add aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 15:41:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 14:41:03 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34937|0 |1 is obsolete| | --- Comment #89 from Julian Maurice --- Created attachment 35749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35749&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 15:41:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 14:41:16 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34938|0 |1 is obsolete| | --- Comment #90 from Julian Maurice --- Created attachment 35750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35750&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 15:41:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 14:41:29 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34939|0 |1 is obsolete| | --- Comment #91 from Julian Maurice --- Created attachment 35751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35751&action=edit Bug 11708: explicitly remove pagination Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 15:41:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 14:41:40 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34940|0 |1 is obsolete| | --- Comment #92 from Julian Maurice --- Created attachment 35752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35752&action=edit Bug 11708: All basketgroups on one page - several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 15:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 14:41:51 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34941|0 |1 is obsolete| | --- Comment #93 from Julian Maurice --- Created attachment 35753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35753&action=edit Bug 11708: Remove the amount columns Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 15:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 14:42:01 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34977|0 |1 is obsolete| | --- Comment #94 from Julian Maurice --- Created attachment 35754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35754&action=edit Bug 11708: Fix bad resolution conflict with bug 12896 Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 16:27:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 15:27:52 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #95 from Julian Maurice --- Created attachment 35755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35755&action=edit Bug 11708: Add descriptions in unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 16:27:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 15:27:56 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #96 from Julian Maurice --- Created attachment 35756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35756&action=edit Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 16:33:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 15:33:20 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #97 from Julian Maurice --- (In reply to M. de Rooy from comment #86) > QA Comment: > > Passes qa tools. > > Verified Basketgroups.t. > This test does not contain any testnames in the calls to ok, is, etc. It is > encouraged to do so. Could you please add? Added by attachment 35755 > > Question: Do we still need the column closed, if you add a closeddate in > aqbasketgroups? > Do we create redundancy? And what about confusion like: Hey closed=0 but > there is a closeddate? > Please convince me that we should have both columns. We probably don't need both. Removed in attachment 35756 > > [PATCH 6/7] Bug 11708: Remove the amount columns > Commit message says only: This should be managed in a specific bug. > Please explain. The amount columns show wrong amounts (comment 45) so they are removed until a specific bug addresses this issue. If you think it's better to keep them, we can remove this patch I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:44:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:44:44 +0000 Subject: [Koha-bugs] [Bug 13684] New: C4::Output uses C4::Budgets Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Bug ID: 13684 Summary: C4::Output uses C4::Budgets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org ... for nothing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:45:50 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:45:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:45:53 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 --- Comment #1 from Jonathan Druart --- Created attachment 35757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35757&action=edit Bug 13684: C4::Budgets should not be used in C4::Output Bug 12844 removed the call to C4::Budgets::GetCurrency. The use of this module can be completely removed from C4::Output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:46:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:46:18 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:46:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:46:24 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12844 CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:46:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:46:24 +0000 Subject: [Koha-bugs] [Bug 12844] Introduce a centralized way to display prices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13684 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:46:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:46:53 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:47:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:47:32 +0000 Subject: [Koha-bugs] [Bug 13638] Batch patron modification tool missing option to switch language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13638 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:48:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:48:00 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:48:27 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:49:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:49:03 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:49:29 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:49:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:49:55 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:50:22 +0000 Subject: [Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:53:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:53:45 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 17:53:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 16:53:48 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35757|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 35758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35758&action=edit [SIGNED OFF] Bug 13684: C4::Budgets should not be used in C4::Output Bug 12844 removed the call to C4::Budgets::GetCurrency. The use of this module can be completely removed from C4::Output. Signed-off-by: Tomas Cohen Arazi It makes sense and no runtime errors found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 18:06:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 17:06:49 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- We should just stop doing this, and use normalized data... with a proper borrower_phone table... with a column labeled 'type'... a 'primary' checkbox... and allow users to have an arbitrary number of phone numbers. And show them with a pretty icon depicting the type of phone... Just saying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 18:10:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 17:10:46 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #31 from Jacek Ablewicz --- (In reply to Katrin Fischer from comment #25) > Maybe just a documentation issue? > > Test plan says: > namespace + database name + database host > > But code looks more like: > > namespace + database host + database name > > + $share_file = join( '-', > + "/tmp/sharefile-koha", $self->{'namespace'}, > + C4::Context->config('hostname'), > C4::Context->config('database') ); > > Signing off - please check my assumptions are correct. Yes, the database host in file name is before the database name. Including database name & host is probably a bit of overkill - as a result, file name will be kind of funny looking.. But after this patch, this file will only be created on such rare setups which are consciously using this particular cache system (I'm estimating there are maybe 2-5 such setups existing in the wild ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 18:43:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 17:43:22 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #32 from Jacek Ablewicz --- (In reply to Katrin Fischer from comment #29) > One last note: How can we best document the new CACHING_SYSTEM=fastmmap? I'm thinking that on this stage it may be better to leave it as is (ie., as undocumented feature, for those who are willing to test / use it in purely experimental way) - it's not clear if it is efficient enough to be worth a trouble (proverbial jury is still out on this one), and it seems to have some not yet fully evaluated potential issues (e.g., apparently it is not thread-safe). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 18:45:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 17:45:58 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 18:46:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 17:46:01 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35613|0 |1 is obsolete| | --- Comment #20 from Nicole C. Engard --- Created attachment 35759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35759&action=edit BUG 13382: RDA 700s This patch updates the visibility of the 7xx fields in the XSLT display in the staff and OPAC. To test: * Search the opac for a title with 7xx fields * Click the title * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 18:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 17:47:04 +0000 Subject: [Koha-bugs] [Bug 13685] New: Sorting Patron Reading History Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685 Bug ID: 13685 Summary: Sorting Patron Reading History Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: amy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Librarian requested we add for patrons the option to sort by author and title to patron check out history on the patron's detail screen in opac. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:10:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:10:17 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #33 from Tom?s Cohen Arazi --- I'd vote for disabling the use of fastmmap, as it is not clear how "efficient" it is. Some people did benchmark it and found it was counter productive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:24:30 +0000 Subject: [Koha-bugs] [Bug 13299] Add home library column to the holds ratios report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13299 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:29:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:29:59 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #32 from Tom?s Cohen Arazi --- Could you please rebase? There's a conflict with pl-PL files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:41:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:41:59 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #34 from Katrin Fischer --- I think Jacek patch will deactivate it - I am also ok with removing it, but would like to see this resolved soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:56:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:56:35 +0000 Subject: [Koha-bugs] [Bug 12842] Add classification to MARC21 XSLT detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12842 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:57:03 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:57:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:57:50 +0000 Subject: [Koha-bugs] [Bug 13298] Holds ratios report ignores ordered items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13298 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:58:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:58:16 +0000 Subject: [Koha-bugs] [Bug 13299] Add home library column to the holds ratios report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13299 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:58:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:58:38 +0000 Subject: [Koha-bugs] [Bug 11954] Clean up currency default files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11954 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:59:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:59:12 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #26 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 19:59:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 18:59:37 +0000 Subject: [Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 20:01:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 19:01:41 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #35 from Chris Cormack --- Jacek's patch does the right thing, disables it unless people explicitly turn it on. Which is the best of both worlds. Can someone else in the QA team please take a look, it'd be great to get this in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 20:24:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 19:24:15 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:16:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:16:42 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen at gmail.com --- Comment #25 from Tom?s Cohen Arazi --- I like the feature, but failing because of the fact that being the available options a fixed list, I think it fits better with the 'multiple' syspref type, which is less error-prone, and user-friendly. If anyone objects failing it, please mark as 'In discussion' and add your comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:18:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:18:54 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Pushed by Module Maintainer |Pushed to Master --- Comment #36 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Amit! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:19:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:19:29 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Pushed by Module Maintainer |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Brandon! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:20:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:20:00 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Pushed by Module Maintainer |Pushed to Master --- Comment #51 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:34:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:34:26 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Hmm this doesnt apply on 3.18.x .. if you think it should be on there, could you please rebase it for that. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:37:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:37:24 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:38:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:38:57 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:44:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:44:28 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:48:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:48:11 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:52:55 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 21:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 20:55:51 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 9 22:49:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Feb 2015 21:49:09 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #20 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 01:01:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 00:01:12 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Large patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 01:01:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 00:01:23 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35662|0 |1 is obsolete| | --- Comment #80 from M. Tompsett --- Created attachment 35760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35760&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 02:09:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 01:09:04 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 04:41:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 03:41:25 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 04:41:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 03:41:28 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35595|0 |1 is obsolete| | --- Comment #8 from David Cook --- Created attachment 35761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35761&action=edit Bug 13632 - Use a translateable file instead of the database for managing permission descriptions This patch defines a couple of blocks in "permissions.inc", which is included/processed in member-flags.tt to show the descriptions for the permissions and sub-permissions. _TEST PLAN_ Before applying: 1) Look at the descriptions for permissions and subpermissions 2) Open another tab/window and load the same page Apply the patch 3) Reload the second tab/window 4) Note that the descriptions are exactly the same as before If you're feeling bold, you can change the text in `permissions.description` and `userflags.flagdesc` and notice that the text on the page doesn't change. However, you should not delete the `permissions.description` column or change the text to NULL or blank. C4::Auth::get_all_subpermissions() uses the description for creating a hashref of subpermissions. If it can't get the column, Koha will explode. If there is nothing in the column, your subpermissions won't work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 04:42:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 03:42:49 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #9 from David Cook --- Thanks for testing this bug, Paola! It turns out that the up-to-date strings from "userflags.sql" and "userpermissions.sql" weren't in my database, as the updated versions weren't included in upgrades via updatedatabase.pl! I've remedied that now. So here's the updated English version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 08:23:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 07:23:46 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #10 from David Cook --- Tomas: I re-wrote my original script, which used the values in my dev database to generate the permissions.inc file, so that it would use the SQL scripts. You can find it here: https://github.com/minusdavid/koha-toolbox However, in hindsight, you probably wanted something that would generate PO files? That would be easy enough to do as well... I just didn't think of it ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 08:37:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 07:37:00 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- If the include is TT it might already be translatable, all you might have to do is add a little HTML, so the strings get parsed. What I'd like to see is that the installer automatically picks up the permission sql file from outside the language specific directories (just like with sysprefs.sql) so we can remove all the other files and stop updating them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:08:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:08:26 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13637 --- Comment #12 from Jonathan Druart --- Weird, I opened the same bug report on the same day! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:08:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:08:26 +0000 Subject: [Koha-bugs] [Bug 13637] Make the permission's descriptions translatable in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:17:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:17:13 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:17:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:17:17 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35083|0 |1 is obsolete| | Attachment #35084|0 |1 is obsolete| | Attachment #35085|0 |1 is obsolete| | Attachment #35086|0 |1 is obsolete| | Attachment #35089|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 35762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35762&action=edit Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:17:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:17:25 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #34 from Jonathan Druart --- Created attachment 35763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35763&action=edit Bug 13417: Limit the permission to delete It's preferable to limit the permission to delete shelves. Apply both patches before testing, then follow this test plan Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to delete all public lists Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:17:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:17:31 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #35 from Jonathan Druart --- Created attachment 35764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35764&action=edit Bug 13417: (qa follow-up) Rename the permission to delete_public_lists Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:17:36 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #36 from Jonathan Druart --- Created attachment 35765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35765&action=edit Bug 13417: Add the permission for all languages Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:17:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:17:42 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #37 from Jonathan Druart --- Created attachment 35766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35766&action=edit Bug 13417: Remove warnings Without this patch perl -wc C4/VirtualShelves.pm failed: Constant subroutine C4::VirtualShelves::SHELVES_MASTHEAD_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_COMBO_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_MGRPAGE_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_POPUP_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHARE_INVITATION_EXPIRY_DAYS redefined at /usr/share/perl/5.20/constant.pm line 156. Subroutine GetShelves redefined at C4/VirtualShelves.pm line 103. Subroutine GetAllShelves redefined at C4/VirtualShelves.pm line 159. Subroutine GetSomeShelfNames redefined at C4/VirtualShelves.pm line 189. Subroutine GetShelf redefined at C4/VirtualShelves.pm line 230. Subroutine GetShelfContents redefined at C4/VirtualShelves.pm line 262. Subroutine AddShelf redefined at C4/VirtualShelves.pm line 315. Subroutine AddToShelf redefined at C4/VirtualShelves.pm line 353. Subroutine ModShelf redefined at C4/VirtualShelves.pm line 394. Subroutine ShelfPossibleAction redefined at C4/VirtualShelves.pm line 454. Subroutine DelFromShelf redefined at C4/VirtualShelves.pm line 545. Subroutine DelShelf redefined at C4/VirtualShelves.pm line 589. Subroutine GetBibliosShelves redefined at C4/VirtualShelves.pm line 603. Subroutine ShelvesMax redefined at C4/VirtualShelves.pm line 628. Subroutine HandleDelBorrower redefined at C4/VirtualShelves.pm line 648. Subroutine AddShare redefined at C4/VirtualShelves.pm line 683. Subroutine AcceptShare redefined at C4/VirtualShelves.pm line 703. Subroutine IsSharedList redefined at C4/VirtualShelves.pm line 731. Subroutine RemoveShare redefined at C4/VirtualShelves.pm line 750. Subroutine _shelf_count redefined at C4/VirtualShelves.pm line 764. Subroutine _CheckShelfName redefined at C4/VirtualShelves.pm line 788. C4/VirtualShelves.pm syntax OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:26:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:26:47 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #8 from Benjamin Rokseth --- As a sidenote, I can confirm that if the returned character 3in the SIP Checkout Response is 0 for an item that is not checked out, it breaks automation and circulation logic altogether, as any item returned should trigger a transfer if applicable. Therefore I'd like to up the severity of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:31:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:31:37 +0000 Subject: [Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13675 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:31:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:31:37 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13007 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:35:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:35:56 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #16 from Jonathan Druart --- Thanks Chris for the fix (bug 13679). It looks easier than I expected :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:36:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:36:52 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:40:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:40:46 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #19 from Jonathan Druart --- (In reply to Katrin Fischer from comment #18) > Wondering, what is meant here? > Restocking => Already ordered Yes I am not sure it's what I meant. Restocking means the supplier does not have the item and you want to cancel it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:48:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:48:16 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #20 from Jonathan Druart --- Created attachment 35767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35767&action=edit Bug 13380: Wording changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:48:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:48:52 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #13 from Katrin Fischer --- And I commented on both... I am getting old :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:50:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:50:05 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #21 from Jonathan Druart --- Created attachment 35768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35768&action=edit Bug 13380: Add ORDER_CANCELLATION_REASON AV to all language files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 09:55:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 08:55:02 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #22 from Katrin Fischer --- Maybe we could just leave it out and go with 2 status? Restocking and out of stock seem very similar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 10:00:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 09:00:13 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #23 from Katrin Fischer --- Hi Joubu, I think there is a little typo: ('ORDER_CANCELLATION_REASON', 1, 'Old of stock'), it's in a/installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 10:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 09:26:19 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33837|0 |1 is obsolete| | --- Comment #23 from Julian Maurice --- Created attachment 35769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35769&action=edit Bug 12395: Save order line's creator Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 10:26:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 09:26:29 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33838|0 |1 is obsolete| | --- Comment #24 from Julian Maurice --- Created attachment 35770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35770&action=edit Bug 12395 [QA Followup] Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 10:26:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 09:26:40 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33839|0 |1 is obsolete| | --- Comment #25 from Julian Maurice --- Created attachment 35771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35771&action=edit Bug 12395: Update aqorders.created_by with aqbasket.authorisedby Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 10:26:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 09:26:47 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #26 from Julian Maurice --- Created attachment 35772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35772&action=edit Bug 12395: Add unit test to check created_by is correctly set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 10:30:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 09:30:47 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #27 from Julian Maurice --- Patches rebased on master + new unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 10:33:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 09:33:16 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35767|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 35773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35773&action=edit Bug 13380: Wording changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 10:51:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 09:51:55 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #10 from Jonathan Druart --- Created attachment 35774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35774&action=edit Bug 13645: Use DBIx::Connector -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 11:07:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 10:07:48 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #11 from Jonathan Druart --- This needs discussion, I really would like to see more people involved here. I submitted a second patch, here the benchmark result for Koha::Acquisition::Bookseller->search; Patch 1 is "Cache the DBIx connection" Patch 2 is "Use DBIx::Connector" With 14 suppliers in DB On master Perl benchmark_bookseller.pl 1.34s user 0.05s system 96% cpu 1.444 total Perl benchmark_bookseller.pl 1.38s user 0.03s system 97% cpu 1.448 total Perl benchmark_bookseller.pl 1.37s user 0.04s system 97% cpu 1.445 total Perl benchmark_bookseller.pl 1.38s user 0.02s system 97% cpu 1.437 total Perl benchmark_bookseller.pl 1.35s user 0.03s system 97% cpu 1.418 total On master + patch 1 Perl benchmark_bookseller.pl 0.92s user 0.04s system 96% cpu 0.999 total Perl benchmark_bookseller.pl 0.94s user 0.05s system 96% cpu 1.031 total Perl benchmark_bookseller.pl 0.90s user 0.06s system 96% cpu 0.988 total Perl benchmark_bookseller.pl 0.94s user 0.04s system 96% cpu 1.021 total Perl benchmark_bookseller.pl 0.93s user 0.04s system 96% cpu 1.003 total On master + patch 1 & patch 2 Perl benchmark_bookseller.pl 0.93s user 0.03s system 95% cpu 1.002 total Perl benchmark_bookseller.pl 0.96s user 0.03s system 95% cpu 1.031 total Perl benchmark_bookseller.pl 0.97s user 0.03s system 95% cpu 1.046 total Perl benchmark_bookseller.pl 0.99s user 0.02s system 96% cpu 1.048 total Perl benchmark_bookseller.pl 0.93s user 0.04s system 95% cpu 1.013 total On master + patch 2 Perl benchmark_bookseller.pl 1.40s user 0.02s system 97% cpu 1.464 total Perl benchmark_bookseller.pl 1.36s user 0.04s system 96% cpu 1.436 total Perl benchmark_bookseller.pl 1.36s user 0.04s system 97% cpu 1.428 total Perl benchmark_bookseller.pl 1.39s user 0.01s system 97% cpu 1.439 total Perl benchmark_bookseller.pl 1.37s user 0.05s system 97% cpu 1.454 total With 1014 suppliers in DB On master perl benchmark_bookseller.pl 35.66s user 0.14s system 99% cpu 35.977 total perl benchmark_bookseller.pl 35.36s user 0.14s system 99% cpu 35.591 total On master + patch 1 perl benchmark_bookseller.pl 2.50s user 0.07s system 95% cpu 2.675 total perl benchmark_bookseller.pl 2.56s user 0.07s system 95% cpu 2.739 total perl benchmark_bookseller.pl 2.66s user 0.05s system 95% cpu 2.849 total perl benchmark_bookseller.pl 2.49s user 0.06s system 96% cpu 2.655 total perl benchmark_bookseller.pl 2.42s user 0.08s system 96% cpu 2.581 total On master + patch 1 & patch 2 perl benchmark_bookseller.pl 2.45s user 0.05s system 96% cpu 2.596 total perl benchmark_bookseller.pl 2.49s user 0.04s system 96% cpu 2.629 total perl benchmark_bookseller.pl 2.49s user 0.04s system 96% cpu 2.629 total perl benchmark_bookseller.pl 2.48s user 0.09s system 96% cpu 2.678 total perl benchmark_bookseller.pl 2.40s user 0.08s system 96% cpu 2.562 total On master + patch 2 perl benchmark_bookseller.pl 34.75s user 0.11s system 99% cpu 34.927 total perl benchmark_bookseller.pl 34.22s user 0.12s system 99% cpu 34.397 total perl benchmark_bookseller.pl 35.12s user 0.15s system 99% cpu 35.343 total At first glance, patch 2 does not seem to be efficient, but I am not confident with patch 1, I got bad results with other tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 12:01:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 11:01:00 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #12 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #11) > I got bad results with other tests. What kinds of bad results? Do you mean something performance-related only, or did you perhaps encountered some unforseen problems, regressions etc elsewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 12:19:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 11:19:26 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #13 from Jonathan Druart --- It's performance-related only, I will sent an email to koha-devel today (hopefully). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 12:40:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 11:40:35 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #15 from Julian Maurice --- (In reply to M. de Rooy from comment #14) > Current master e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac does not fail this > test with me. Maybe this is the kind of test that depends on some configuration in database that you have and I have not. Could you try to apply the patch and see if the test pass ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 12:51:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 11:51:08 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 12:59:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 11:59:21 +0000 Subject: [Koha-bugs] [Bug 12041] Improve Koha::Cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041 --- Comment #15 from Jonathan Druart --- This patch set changed the prototype of set_in_cache, but did not update the calls in t/Cache.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 13:29:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 12:29:32 +0000 Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name on patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 --- Comment #1 from Thomas Wright --- Created attachment 35775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35775&action=edit Bug 13657 - Don't show extra comma after guarantor name on patron details Removed second name and comma from template file Testing plan: - Create 2 patrons, one each for - an organisation type patron category - a member of organisation type patron category - Link both from the 'member patron' edit form - Note that the guarantor is now shown on the details tab - Verify there is no extra comma after the organisation's name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 13:29:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 12:29:54 +0000 Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name on patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomsStudy at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 13:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 12:38:10 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 13:39:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 12:39:40 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35761|0 |1 is obsolete| | --- Comment #14 from Paola Rossi --- Created attachment 35776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35776&action=edit [SIGNED OFF] Bug 13632 - Use a translateable file instead of the database for managing permission descriptions In reply to David Cook from Comment #9: >[...] here's the updated English version. Thanks, David. I've applied the patch against master 3.19.00.010 This was the only difference I saw: applied: Add and delete budgets (but can't modify budgets) master : Add and delete budgets (but can't modifiy budgets) So I pass the patch to the "Signed Off" status. > > [...] change the text in > `permissions.description` and `userflags.flagdesc` and notice > that the text on the page doesn't change. > Yes, as required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 13:50:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 12:50:13 +0000 Subject: [Koha-bugs] [Bug 13686] New: Add a hint about collation to the "alphabet" syspref Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Bug ID: 13686 Summary: Add a hint about collation to the "alphabet" syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: viktor.sarge at regionhalland.se QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Today it's possible to define your own alphabet in the I18N/L10N preferences. This shows up in members-home.pl and lets you browse patrons. If you define an alphabet outside of the A-Z comfort zone (as in swedish with additional characters ?,?,? at the end) then the browsing will mix together for example ?,?,A and only view the additional letters as diacritics. A quick solution is to change the collation in the database but there is nothing in the syspref explaining this. My ambition here is to give users a quick hint that this can be done. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:03:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:03:25 +0000 Subject: [Koha-bugs] [Bug 13687] New: ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Bug ID: 13687 Summary: ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:03:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:03:33 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:03:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:03:43 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:04:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:04:39 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 --- Comment #1 from Julian Maurice --- Created attachment 35777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35777&action=edit Bug 13687: Move hold policy check into CanItemBeReserved This way ILS-DI HoldItem and HoldTitle services also benefit from this check Test plan: 1/ Define some default holds policies by item type in /admin/smart-rules.pl 2/ Use ILS-DI HoldItem service and check that those rules are respected 3/ Check that staff and opac hold behaviour is unchanged regarding these rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:04:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:04:54 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:05:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:05:25 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:05:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:05:28 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #1 from Viktor Sarge --- Created attachment 35778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35778&action=edit Bug 13686 Add a hint about collation to the "alphabet" syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:11:32 +0000 Subject: [Koha-bugs] [Bug 11641] ILS-DI: Some more work for HoldTitle and HoldItem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11641 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #1 from Julian Maurice --- (1) is fixed by bug 11999 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:14:06 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #28 from Paola Rossi --- I've tried to apply the patch against master 3.19.00.010 head 13675 Applying: Bug 12395: Save order line's creator Using index info to reconstruct a base tree... :234: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Failed to merge in the changes. Patch failed at 0001 Bug 12395: Save order line's creator So I pass the patch to "Patch doesn't apply" status. NB. All the first 3 patches relate to updatedatabase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:31:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:31:33 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35769|0 |1 is obsolete| | --- Comment #29 from Julian Maurice --- Created attachment 35779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35779&action=edit Bug 12395: Save order line's creator Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:31:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:31:47 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35770|0 |1 is obsolete| | --- Comment #30 from Julian Maurice --- Created attachment 35780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35780&action=edit Bug 12395 [QA Followup] Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:31:59 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35771|0 |1 is obsolete| | --- Comment #31 from Julian Maurice --- Created attachment 35781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35781&action=edit Bug 12395: Update aqorders.created_by with aqbasket.authorisedby Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:32:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:32:12 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35772|0 |1 is obsolete| | --- Comment #32 from Julian Maurice --- Created attachment 35782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35782&action=edit Bug 12395: Add unit test to check created_by is correctly set Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:32:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:32:37 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:42:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:42:07 +0000 Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Colin Campbell --- Updated status to signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:53:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:53:32 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34553|0 |1 is obsolete| | --- Comment #98 from Tom?s Cohen Arazi --- Created attachment 35783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35783&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:53:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:53:46 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34554|0 |1 is obsolete| | --- Comment #99 from Tom?s Cohen Arazi --- Created attachment 35784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35784&action=edit Bug 11395: Add links to the new tool page This patch adds links in the tool module to the new batch tool and in the basket. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:54:05 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34555|0 |1 is obsolete| | --- Comment #100 from Tom?s Cohen Arazi --- Created attachment 35785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35785&action=edit Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:54:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:54:37 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34556|0 |1 is obsolete| | --- Comment #101 from Tom?s Cohen Arazi --- Created attachment 35786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35786&action=edit Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:54:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:54:55 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34557|0 |1 is obsolete| | --- Comment #102 from Tom?s Cohen Arazi --- Created attachment 35787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35787&action=edit Bug 11395: DB: Add permission tools_records_batchmod Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:55:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:55:10 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34558|0 |1 is obsolete| | --- Comment #103 from Tom?s Cohen Arazi --- Created attachment 35788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35788&action=edit Bug 11395: Fix path for the checkboxes jQuery plugin This patch fixes a bad resolution conflict (bug 12107). Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:55:24 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34559|0 |1 is obsolete| | --- Comment #104 from Tom?s Cohen Arazi --- Created attachment 35789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35789&action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:55:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:55:36 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34560|0 |1 is obsolete| | --- Comment #105 from Tom?s Cohen Arazi --- Created attachment 35790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35790&action=edit Bug 11395: Raise an alert if control field is used If a control field is used with a copy or move action, the interface should block the user in some cases: - If a control field is used with a regular field - The subfield should be empty Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:55:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:55:50 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34561|0 |1 is obsolete| | --- Comment #106 from Tom?s Cohen Arazi --- Created attachment 35791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35791&action=edit Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:56:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:56:04 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34562|0 |1 is obsolete| | --- Comment #107 from Tom?s Cohen Arazi --- Created attachment 35792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35792&action=edit Bug 11395: A control field is a field with tag < 10 This patch fixes the existing test about control fields. A control field is < 10, not <=10! Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 14:58:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 13:58:51 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |tomascohen at gmail.com --- Comment #108 from Tom?s Cohen Arazi --- Hi, i like this patch set, I signed it myself too. But I'm marking as Signed-off because I want more people involved. It is a great feature, that could potentially break people's records. So I'm asking Marcel and/or Katrin to give it a ride before pushing it. I rebased it to current master also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:06:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:06:53 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 --- Comment #4 from Owen Leonard --- > Owen, could you confirm? I confirm. opac-old.css and sco-old.css were in-development reference files and shouldn't have made it into the original patch. They can be ignored for the purposes of this patch and deleted by another one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:09:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:09:50 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #15 from Bernardo Gonzalez Kriegel --- Hi, good to see new strings to translate :) But, can I suggest a little rewriting? First) Can you put a ... surrounding the text? In that way each text is taken by translation script individually, if not we finish with a big and ugly string, difficult to translate or update So I suggest changing this [%- CASE 'superlibrarian' -%] Access to all librarian functions [%- CASE 'circulate' -%] Check out and check in items [%- CASE 'catalogue' -%] Required for staff login. Staff access, allows viewing of catalogue in staff client. to this [%- CASE 'superlibrarian' -%] Access to all librarian functions [%- CASE 'circulate' -%] Check out and check in items [%- CASE 'catalogue' -%] Required for staff login. Staff access, allows viewing of catalogue in staff client. Second) To improve readability, can you put the text next to the options? And also add space to align things? For example, change this [%- CASE 'superlibrarian' -%] Access to all librarian functions [%- CASE 'circulate' -%] Check out and check in items [%- CASE 'catalogue' -%] Required for staff login. Staff access, allows viewing of catalogue in staff client. to this [%- CASE 'superlibrarian' -%]Access to all librarian functions [%- CASE 'circulate' -%]Check out and check in items [%- CASE 'catalogue' -%]Required for staff login. Staff access, allows viewing of catalogue in staff client. Bernardo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:30:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:30:24 +0000 Subject: [Koha-bugs] [Bug 13688] New: Hiding subfields in edit item form leaves "empty space" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13688 Bug ID: 13688 Summary: Hiding subfields in edit item form leaves "empty space" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When hiding a lot of subfields in the edit item form you might be left with big white gaps between the fields. To test: - Hide every 952 between 3 and i (or later) - Look at the item edit form and see that there is a visible gap between 3 and i -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:35:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:35:06 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Hi Viktor, The text does not display at all, only the form field is visible. Reason: The text contains a colon (:), that breaks the display. Solution: Put the text in quotes. Marc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:42:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:42:10 +0000 Subject: [Koha-bugs] [Bug 13685] Sorting Patron Reading History In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13685 --- Comment #1 from Owen Leonard --- Does this bug refer to /cgi-bin/koha/opac-readingrecord.pl? That page can already sort by title. Do you mean sorting by title and author together? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:44:20 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 --- Comment #5 from Marc V?ron --- Created attachment 35793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35793&action=edit [Signed-off] Bug 13612 - Remove old YUI javacript libraries from opac-tmpl YUI files were left behind in opac-tmpl/lib/yui after the removal of the prog theme. These files are unused and can be safely removed. To test, apply the patch and search for references to any of the YUI files. You should find none in the OPAC templates. No references found. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:44:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:44:53 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:45:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:45:17 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:50:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:50:42 +0000 Subject: [Koha-bugs] [Bug 13689] New: Remove opac-old.css and sco-old.css Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Bug ID: 13689 Summary: Remove opac-old.css and sco-old.css Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The following files are obsolete and should be removed: koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css (see Bug 13612, Comment #4) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:51:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:51:06 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:51:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:51:06 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13689 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:51:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:51:22 +0000 Subject: [Koha-bugs] [Bug 13688] Hiding subfields in edit item form leaves "empty space" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13688 --- Comment #1 from Katrin Fischer --- Created attachment 35794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35794&action=edit screenshot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:58:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:58:47 +0000 Subject: [Koha-bugs] [Bug 13690] New: 3.18 performance issues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Bug ID: 13690 Summary: 3.18 performance issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 15:59:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 14:59:01 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:01:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:01:19 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 --- Comment #1 from Marc V?ron --- Created attachment 35795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35795&action=edit Bug 13689 - Remove opac-old.css and sco-old.css The following files are obsolete and should be removed: koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css To test: Apply patch. Search for the files; they should no longer exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:02:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:02:20 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:02:21 +0000 Subject: [Koha-bugs] [Bug 13691] New: Add some selenium scripts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Bug ID: 13691 Summary: Add some selenium scripts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at biblibre.com QA Contact: gmcharlt at gmail.com To catch performance regressions it would be great to have some selenium scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:02:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:02:31 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:03:18 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13691, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13645 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:03:18 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:03:18 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:04:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:04:38 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 --- Comment #1 from Jonathan Druart --- Created attachment 35796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35796&action=edit Bug 13690: use Koha::Schema only when it's needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:18:39 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Paola Rossi --- Thanks, Julian. I've applied the patch against master 3.19.00.010 head 13675. On /cgi-bin/koha/serials/subscription-detail.pl I've selected the "Create routing list" [/ "Edit routing list"] at the left of the page. I've received the "Create routing list" [/ "Routing list for ...."] page. In both the 2 cases, then I've selected : "Serial collection" at the left of this page. I saw:

    Software error:

    Undefined subroutine &main::check_routing called at
/[....]/serials/serials-collection.pl line 132.
    So I pass the patch to "Failed QA" status. NB-1) The patch needed a trivial rebase. NB-2) Step 1: Make a search, in the results list you have a column 'Routing lists' (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New' link. Otherwise you have an 'Edit(X)' link, where X is the number of routing lists. RoutingSerials "Use"/"Don't use" is OK as required. But at present the "column" is an "Actions". Could you update the test plan please? [A numbered indentation would be very helpful to me in this long test plan.] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:26:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:26:14 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 --- Comment #1 from Jonathan Druart --- Created attachment 35797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35797&action=edit Bug 13691: Add basic selenium script This script has been used to compare 3.16.x and 3.18.x performances on bug 13690. What it does: - Go on the mainpage and process a log in - Create a patron category - Create a patron - Add 3 items - check the 3 items out to the patron - check the 3 items in How to use it? $ wget http://selenium-release.storage.googleapis.com/2.44/selenium-server-standalone-2.44.0.jar $ vim /etc/apt/sources.list.d/firefox.list deb http://packages.linuxmint.com debian import $ apt-get update $ apt-get install firefox $ sudo apt-get install xvfb $ SELENIUM_PATH=/home/koha/tools/selenium-server-standalone-2.44.0.jar $ Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & $ DISPLAY=:1 java -jar $SELENIUM_PATH perl t/db_dependent/selenium/basic_workflow.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:26:59 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart --- This is a POC, feedback welcome :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:27:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:27:20 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 --- Comment #3 from Jonathan Druart --- Created attachment 35798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35798&action=edit Bug 13691: Remove existing selenium scripts They are not usable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:38:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:38:15 +0000 Subject: [Koha-bugs] [Bug 13692] New: series link is taking you to just 800a instead of whole 800 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 Bug ID: 13692 Summary: series link is taking you to just 800a instead of whole 800 Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 35799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35799&action=edit series link See attached. When you click a series link in the staff client it does a search for the series author only 800a - instead of the series as it implies. It should probably search 800t if it can be only one subfield, but it should really be a & t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:38:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:38:30 +0000 Subject: [Koha-bugs] [Bug 13692] series link is taking you to just 800a instead of whole 800 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13692 --- Comment #1 from Nicole C. Engard --- Created attachment 35800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35800&action=edit series in marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:39:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:39:18 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35709|0 |1 is obsolete| | --- Comment #23 from Julian Maurice --- Created attachment 35801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35801&action=edit Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import' >From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Routing lists' (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New' link. Otherwise you have an 'Edit(X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data. >From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above) Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl (rebased and test plan updated) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:39:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:39:24 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #24 from Julian Maurice --- Created attachment 35802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35802&action=edit Bug 7957: Remove uses of check_routing which doesn't exist anymore Also remove a unit tests about C4::Serials::addroutingmember which also no longer exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:42:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:42:52 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35801|0 |1 is obsolete| | --- Comment #25 from Julian Maurice --- Created attachment 35803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35803&action=edit Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import' >From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Actions' that should contain a "New/Edit routing list" link" (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New routing list' link. Otherwise you have an 'Edit routing lists (X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New routing list' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data. >From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above) Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:42:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:42:59 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35802|0 |1 is obsolete| | --- Comment #26 from Julian Maurice --- Created attachment 35804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35804&action=edit Bug 7957: Remove uses of check_routing which doesn't exist anymore Also remove a unit tests about C4::Serials::addroutingmember which also no longer exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:43:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:43:19 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:46:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:46:12 +0000 Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name on patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 --- Comment #2 from Marc V?ron --- Created attachment 35805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35805&action=edit [ALTERNATIVE PATCH] Bug 13657 - Don't show extra comma after guarantor name on patron details This patch suppresses the first name part (including comma) if first name is empty. This way, first name is still displays with natural persons, but not with organizations. To test: Apply this patch (without the first patch). Have one patron with a natural person as guarantor and one patron with an organization as guarantor. Verify that both display properly on the patron details page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:47:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:47:08 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:56:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:56:28 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 35806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35806&action=edit Bug 13545: (followup) POD and error handling This patch adds POD to the new /svc/barcode service, and also implements some error handling. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 16:59:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 15:59:30 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- I'm failing this one, even though I attached a followup so the author checks both the followup and the POD I added. It should be clear which barcode 'types' we support, and they should be added to the dependencies if needed. For instance, I'm not sure we might add GD::Barcode to the dependencies. I tried with GD::Barcode:::QRcode and GD::Barcode::UPCE, and it works fine. I tested using an empty barcode number to generate an error. Please revisit and sign if it is ok, but at least the POD should be ammended. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 17:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 16:14:42 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 --- Comment #5 from Marc V?ron --- Created attachment 35807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35807&action=edit [Signed-off] Bug 12911 - batch_id for new labels batches can be asssigned to several batches Currently batch_id is assigned upon creation of a new batch object. This patch leaves batch_id as 0 at creation and adds a check when adding items. If batch is new then batch_id is created then Test plan: 1 -In one browser window, go to tools->label creator and click the new batch button 2 - Before adding items, open a new browser, and go tools->label creator and click the new batch button 3 - Note that both batches have the same number listed 4 - Add an item to the first batch - you should now see one item in the batch 5 - Add an item to the second batch, you should see two items in the batch 6 - Apply patch and repeat steps 1&2 7 - Note that neither batch lists a batch number 8 - Add an item to the first batch, you should see one item and a batch number 9 - Add an item to the second batch, you should see one item and a new batch number Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 17:15:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 16:15:08 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #35719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 17:18:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 16:18:19 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 17:38:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 16:38:50 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart --- Some users have the feeling that 3.18.x is slower than 3.18.x I tried to prove that. I have created a selenium script (see bug 13691) which: - goes on the mainpage and processes a log in (main) - creates a patron category (add patron category) - creates a patron (add patron) - adds 3 items (add items) - checks the 3 items out to the patron (checkout) - checks the 3 items in (checkin) On 3.18.x, the execution of the script takes ~65sec against 50sec on 3.16.x But looking at the detailed times, the difference is much more important. (Note that the values are the same for master and 3.18.x) Here is the time spent for each operation =3.18= CP main = 4.04 + 4.52 + 3.86 + 4.17 => 4.15 CP add patron category = 5.87 + 5.75 + 5.84 + 6.64 => 6.02 CP add patron = 7.71 + 6.84 + 7.31 + 8.15 => 7.5 CP add items = 15.08 + 15.47 + 15.09 + 14.82 => 15.12 CP checkout = 13.31 + 14.00 + 13.63 + 13.93 => 13.72 CP checkin = 11.78 + 12.70 + 12.81 + 11.71 => 12.25 =3.16= CP main = 2.73 + 2.64 + 2.74 + 2.78 + 2.70 => 2.72 CP add patron category = 3.93 + 3.76 + 3.82 + 3.85 + 3.78 => 3.83 CP add patron = 5.44 + 5.12 + 5.37 + 5.18 + 5.15 => 5.25 CP add items = 10.82 + 10.90 + 10.34 + 11.44 + 10.64 => 10.83 CP checkout = 14.18 + 13.49 + 13.60 + 13.35 + 15.58 => 14.04 CP checkin = 8.32 + 8.30 + 8.50 + 8.17 + 8.28 => 8.31 # Difference between both version # diff ((3.18-3.16)/3.16)*100 CP main = +53% CP add patron category = +57% CP add patron = +43% CP add items = +40% CP checkout = -2% CP checkin = +47% Now, I would like to know if the patch I submitted on bug 13645 (Bug 13645: Cache the DBIx connection) is useful or not, repeat again =3.18+13645= CP main = 4.20 + 4.15 + 4.42 + 4.06 + 4.52 => 4.3 CP add patron category = 6.01 + 5.89 + 5.92 + 5.78 + 6.32 => 6 CP add patron = 7.02 + 7.79 + 7.06 + 6.80 + 7.30 => 7.2 CP add items = 15.34 + 15.10 + 15.31 + 16.89 + 17.03 => 15.9 CP checkout = 15.35 + 14.01 + 14.14 + 14.07 + 14.08 => 14.3 CP checkin = 14.38 + 11.85 + 11.86 + 12.17 + 12.17 => 12.5 Quite the same as without the patch, even a bit worse... I would like to understand what is the difference (4.15 vs 2.72) for the main page. Go to see the apache access logs for the GET + POST on the main page: 3.16 "GET /cgi-bin/koha/mainpage.pl HTTP/1.1" 200 2233 time=738896 "POST /cgi-bin/koha/mainpage.pl HTTP/1.1" 200 3675 time=763546 3.18 "GET /cgi-bin/koha/mainpage.pl HTTP/1.1" 200 2285 time=1374552 "POST /cgi-bin/koha/mainpage.pl HTTP/1.1" 200 3836 time=1381786 So NYTProf should help us, comparing the profiling between 3.16 and 3.18. $ git checkout 3.16.x;rm -r /tmp/home;perl -d:NYTProf mainpage.pl Profile of mainpage.pl for 185ms (of 258ms), executing 62528 statements and 9841 subroutine calls in 89 source files and 24 string evals. $ git checkout 3.18.x;rm -r /tmp/home;perl -d:NYTProf mainpage.pl Profile of mainpage.pl for 209ms (of 276ms), executing 63812 statements and 9444 subroutine calls in 81 source files and 23 string evals. Not really... With wget, I can reproduce the difference easily. $ time wget http://pro.koha-qa.vm/cgi-bin/koha/mainpage.pl 3.16 ~700ms 3.18 ~1300-1400ms Now that it's easy to reproduce the difference, I will try to find the first bad commit with git bisect: $ git checkout 3.18.x $ git bisect start HEAD 50078d04c6c3e3e85d6f8ed3645368f7a69402e5 $ time perl mainpage.pl => 1a737dcee6f600fc9d853f7318e1591b75b1349b is the first bad commit $ git show 1a737dcee6f600fc9d853f7318e1591b75b1349b commit 1a737dcee6f600fc9d853f7318e1591b75b1349b Date: Thu Dec 5 07:35:00 2013 -0500 Bug 6254: make it possible to set default privacy setting for new patrons I suspect it's because C4::Members now uses Koha::Database which uses Koha::Schema I comment Koha::Database l.12 #__PACKAGE__->load_namespaces; $ time wget http://pro.koha-qa.vm/cgi-bin/koha/mainpage.pl returns ~700ms So 700ms more spent in the mainpage is caused by the DBIx::Class schema loading. But the DBIC schema is not used in the mainpage... Try the second patch on bug 13645 (Bug 13645: Use DBIx::Connector) $ git checkout 3.18 $ git apply patches 1, 2 $ git log --oneline e64240b Bug 13645: Use DBIx::Connector 73f3835 Bug 13645: Cache the DBIx connection CP main = 4.06 + 4.11 + 4.09 + 4.18 + 4.32 => 4.2 CP add patron category = 5.86 + 5.77 + 5.70 + 6.15 + 5.85 => 5.9 CP add patron = 6.88 + 7.30 + 7.47 + 6.58 + 6.56 => 7 CP add items = 15.47 + 15.42 + 14.75 + 14.71 + 15.04 => 15.1 CP checkout = 13.18 + 13.20 + 13.35 + 13.25 + 13.16 => 13.2 CP checkin = 11.77 + 11.83 + 11.80 + 11.94 + 11.76 => 11.8 A bit better, but no important improvement. Let's try to use it only if needed (Bug 13690: use Koha::Schema only when it's needed). 3 patches will be tested: patch 1: Bug 13645: Cache the DBIx connection patch 2: Bug 13645: Use DBIx::Connector patch 3: Bug 13690: use Koha::Schema only when it's needed $ git checkout 3.18.x $ git apply patches 1, 2, 3 $ git log --oneline ad54b4c Bug 13690: use Koha::Schema only when it's needed e64240b Bug 13645: Use DBIx::Connector 73f3835 Bug 13645: Cache the DBIx connection CP main = 2.70 + 2.91 + 2.72 + 2.76 + 2.84 => 2.8 CP add patron category = 3.97 + 3.81 + 4.01 + 3.84 + 4.08 => 3.9 CP add patron = 7.01 + 5.91 + 5.88 + 6.51 + 6.31 => 6.3 CP add items = 11.59 + 11.10 + 11.12 + 11.00 + 11.05 => 11.2 CP checkout = 13.71 + 13.67 + 13.25 + 13.19 + 13.23 => 13.4 CP checkin = 8.38 + 8.53 + 8.21 + 8.16 + 8.06 => 8.3 Ok we absolutely need the patch 3. What's happen with only patch 3 applied? it checkout 3.18 git apply patch 3 git log --oneline 4ca93b1 Bug 13690: use Koha::Schema only when it's needed CP main = 2.87 + 2.86 + 2.67 + 2.76 + 2.67 => 2.8 CP add patron category = 4.16 + 3.81 + 3.78 + 4.02 + 3.82 => 3.9 CP add patron = 6.65 + 6.32 + 6.00 + 6.14 + 6.20 => 6.3 CP add items = 10.93 + 11.08 + 11.61 + 10.92 + 11.10 => 11.1 CP checkout = 13.24 + 13.03 + 13.06 + 13.81 + 13.74 => 13.4 CP checkin = 8.24 + 8.07 + 8.63 + 8.16 + 8.19 => 8.3 So this patch 3 looks sufficient, but the selenium script almost does not used parts of Koha where DBIx::Class is implemented. If I cross these results with the ones on bug 13645 (especially comment 11): $ git checkout master (BACK ON MASTER) $ time perl benchmark_bookseller.pl # this script is available on bug 13645 comment 7 perl benchmark_bookseller.pl 35.66s user 0.14s system 99% cpu 35.977. $ git apply patch 3 $ git log --oneline e2a1558 Bug 13690: use Koha::Schema only when it's needed $ time perl benchmark_bookseller.pl perl benchmark_bookseller.pl 34.03s user 0.15s system 99% cpu 34.241 total This patch 3 is not enough if DBIx:Class is used. git checkout master $ git apply patch 1, 2, 3 $ git log --oneline e2a1558 Bug 13690: use Koha::Schema only when it's needed 72facc6 Bug 13645: Use DBIx::Connector 3397a58 Bug 13645: Cache the DBIx connection $ time perl benchmark_bookseller.pl perl benchmark_bookseller.pl 2.43s user 0.06s system 96% cpu 2.585 total perl benchmark_bookseller.pl 2.45s user 0.06s system 96% cpu 2.599 total perl benchmark_bookseller.pl 2.45s user 0.06s system 96% cpu 2.592 total perl benchmark_bookseller.pl 2.48s user 0.08s system 96% cpu 2.663 total perl benchmark_bookseller.pl 2.50s user 0.08s system 96% cpu 2.679 total With 3 patches applied, it seems that the performances are highly better. They globally reach the same time as 3.16.x And... with Plack? =3.18 + Plack= CP main = 1.86 + 2.16 + 1.81 + 1.66 + 2.26 => 2 CP add patron category = 2.23 + 2.10 + 2.32 + 2.25 + 2.17 => 2.2 CP add patron = 3.27 + 2.89 + 3.17 + 3.29 + 3.38 => 3.2 CP add items = 8.50 + 8.75 + 8.45 + 8.05 + 8.00 => 8.4 CP checkout = 6.76 + 6.26 + 5.74 + 6.79 + 6.16 => 6.3 CP checkin = 4.80 + 5.35 + 4.82 + 5.60 + 5.44 => 5.2 Whaou, cool :) What about these patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 17:40:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 16:40:22 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 --- Comment #3 from Jonathan Druart --- Created attachment 35808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35808&action=edit Perf differences between 3.16 and 3.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 17:50:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 16:50:55 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Patch does not apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 17:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 16:54:12 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:03:34 +0000 Subject: [Koha-bugs] [Bug 13693] New: course reserve status isn't correct Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13693 Bug ID: 13693 Summary: course reserve status isn't correct Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: carmen at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 35809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35809&action=edit Status correct in catalog when an item is on order, the status shows properly in the catalog but not in course reserve. (see attachments) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:05:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:05:42 +0000 Subject: [Koha-bugs] [Bug 13693] course reserve status isn't correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13693 --- Comment #1 from Carmen --- Created attachment 35810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35810&action=edit Course status wrong -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:09:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:09:19 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:09:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:09:45 +0000 Subject: [Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:10:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:10:07 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:10:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:10:32 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:17:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:17:44 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:21:59 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 --- Comment #1 from Marc V?ron --- Created attachment 35811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35811&action=edit Bug 13682 - Capitalization: Holds Queue This patch changes capitalization of Holds Queue to Holds queue in koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueu$ To test: Apply patch Go to Circulation > Holds queue page Verify that the capitalization is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:23:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:23:02 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch CC| |veron at veron.ch Status|NEW |Needs Signoff Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:34:16 +0000 Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Colin Campbell --- I tried using the patch on a site and it didnt accept the fee acknowledgement. I've got a fixed patch which a site is testing with some 3M machines, will upload if they dont find any further probs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:36:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:36:20 +0000 Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676 --- Comment #1 from Marc V?ron --- Created attachment 35812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35812&action=edit Bug 13676 - OpacSuppression description says 'items' but means 'records' This patch changes the wording for the OpacSuppression preference description. Without patch: ... items marked as suppressed from OPAC search results. Note that you must have the Suppress index set up in Zebra and at least one suppressed item, or your searches will be broken. ... With patch: ... items marked as suppressed from OPAC search results. Note that you must have the Suppress index set up in Zebra and at least one suppressed biblio record, or your searches will be broken. ... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:37:50 +0000 Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |Trivial patch CC| |veron at veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 18:43:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 17:43:25 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 19:00:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 18:00:59 +0000 Subject: [Koha-bugs] [Bug 13049] Improve self-registration cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #3 from Kyle M Hall --- Are you still planning on submitting a patch for this bug? (In reply to M. de Rooy from comment #2) > (In reply to Kyle M Hall from comment #1) > > What do you think? > > Thanks. This is quite clear. I will send a proposed patch. Still thinking a > little bit on the provisional category-case.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 19:20:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 18:20:48 +0000 Subject: [Koha-bugs] [Bug 13694] New: Potential privacy issue with OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13694 Bug ID: 13694 Summary: Potential privacy issue with OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This was reported by a partner: "So there is kind of a pretty big security bug, the logged in pages are being cached by the browser, so on a public OPAC machine even after the user has logged out you can click the back button to see all the account pages they looked at. You can't actually do anything because then it asks for login, but that's still a really major problem." I'm not sure how or if we can fix this issue. I tried the solution here: http://stackoverflow.com/questions/1341089/using-meta-tags-to-turn-off-caching-in-all-browsers But it did not help at all in FireFox or Chrome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 19:21:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 18:21:50 +0000 Subject: [Koha-bugs] [Bug 13694] Potential privacy issue with OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 19:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 18:37:28 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #54 from Kyle M Hall --- Created attachment 35813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35813&action=edit Bug 13019 [QA Followup] - Allow chaining By returning the object itself instead of a boolean, we can chain methods together while retaining the exact same functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 19:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 18:47:47 +0000 Subject: [Koha-bugs] [Bug 13694] Potential privacy issue with OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 5371 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 19:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 18:47:47 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #9 from Owen Leonard --- *** Bug 13694 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 19:58:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 18:58:14 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Looks good to me Jonathan. As long as we get no regressions in functions, I think we should push these patches. I might try to get them into 3.18.4 if QA is happy no regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 20:02:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 19:02:17 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #55 from Kyle M Hall --- Created attachment 35814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35814&action=edit Bug 13019 [QA Followup] - Fix stale unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 20:12:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 19:12:23 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35814|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall --- Created attachment 35815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35815&action=edit Bug 13019 [QA Followup] - Fix stale unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 20:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 19:19:58 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 20:50:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 19:50:23 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #34 from Brendan Gallagher --- Didn't apply cleanly. Kyle can you rebase this. (it's just the updatedatabase.pl and structure ones. Should be pretty quick. I'd like to find someone to sign-off on this. Thanks, Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 21:08:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 20:08:29 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 21:08:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 20:08:33 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34181|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 35816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35816&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 21:15:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 20:15:15 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #20 from H?ctor Eduardo Castro Avalos --- Hi all I Apologize, first one, because I couldn't get access to internet till today, second because I'm very newbie on Koha, git, etc., and thanks to Bernardo because he has guided me through this patch. Katrin (comment 16). I changed the permission but was unintentionally because I couldn't install Koha and change all the permission on my kohaclone directory. Not sure if it necessary to redo the patch with the old permissions or if the RM or QA Manager could change the permission when apply the patch. Since long time that I'm working with the code, I forgot how to install RDF::Trine and the missed dependencies. I did a fresh installation for document all this dependencies. List::Util libscalar-list-utils-perl Scalar::Util Optional to List::Util libscalar-util-numeric-perl autobox::List::Util libautobox-list-util-perl TryCatch libtrycatch-perl B::Hooks::OP::Check libb-hooks-op-check-perl B::Hooks::OP::PPAddr libb-hooks-op-ppaddr-perl Scope::Upper libscope-upper-perl Clone libdata-clone-perl Devel::Declare libdevel-declare-perl Parse::Method::Signatures libparse-method-signatures-perl MooseX::Traits libmoosex-traits-perl PPI libppi-perl But there exist a problem with List::Util and RDF::Trine, these modules launch an error when you try to install them. List::Util can not be installed with any method: cpanm; perl -MCPAN -e 'shell' install; dh-make-perl fail too. So the only way to install this module is manually, i.e., download the tar.gz from search.cpan.org. perl Makefile.PL make make test make install Then you can install cpanm RDF::Trine and the module will upgrade. Regards PS. I'm working with debian stable (wheezy) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 22:34:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 21:34:46 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #3 from Viktor Sarge --- Created attachment 35817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35817&action=edit Bug 13686 Add a hint about collation to the alphabet syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. This patch is hopefully also working - thanks Marc! Guess it goes to prove that no patch is too small to test properly before posting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 22:36:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 21:36:51 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #4 from Viktor Sarge --- I also learned not to put anything outside of A-Z in the commit messages. Had to learn how to use --amend in git :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 22:46:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 21:46:05 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 22:48:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 21:48:53 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 22:51:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 21:51:48 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 23:02:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 22:02:20 +0000 Subject: [Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 23:03:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 22:03:31 +0000 Subject: [Koha-bugs] [Bug 12860] Tools > Data export : "Don't export fields" option doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12860 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 23:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 22:24:26 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 23:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 22:25:17 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13417 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 23:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 22:25:17 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 23:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 22:27:37 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #16 from David Cook --- Jonathan: That is weird! Bernardo: Yep, that's certainly doable. I might not have time today but I'll look at this again. Happy for this to be set to Failed QA in the meantime... Katrin: I suppose I'd have to look closer at the installation process. I don't know too much about how translation works, as only one of our libraries use other languages than English, so happy to receive any advice on that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 10 23:39:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 22:39:56 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #17 from Katrin Fischer --- It's not so much a translation thing - Bernardo already has provided the fix for that, but a maintenance/web installer problem. The web installer will use the files in the language directory from the language you picked at the beginning of the installation process. There is no fallback to en if a file is missing. So currently, when a new permission is added, we have to maintain not one central file, but the en file plus all translated files. Not good. For systempreferences the web installer knows that sysprefs.sql is mandatory, even tho it lives outside of the web installer files. I think maybe we can handle the permissions file the same way. One file - always installed independent of the picked language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:00:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:00:51 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #21 from Robin Sheat --- (In reply to H?ctor Eduardo Castro Avalos from comment #20) > Since long time that I'm working with the code, I forgot how to install > RDF::Trine and the missed dependencies. I did a fresh installation for > document all this dependencies. That looks not too bad. > But there exist a problem with List::Util and RDF::Trine, these modules > launch an error when you try to install them. List::Util is included in core perl, you shouldn't be installing it manually. > So the only way to install this module is manually, i.e., download the > tar.gz from search.cpan.org. Why do you need to install it manually? > Then you can install cpanm RDF::Trine and the module will upgrade. More importantly, I need to know if the versions specified in the dependencies are actually the minimum versions. If the code can handle lower versions of those modules, then things will be a lot easier. For example, there is already a librdf-trine-perl module. Why aren't you using that? > PS. I'm working with debian stable (wheezy) We also need to support debian oldstable (squeeze) for the moment. We can't have people using cpanm, if this is to go in to Koha, we need the dependencies produced too. I can do that, but I need a more information, mostly about what _really_ the minimum version numbers that are allowable are. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:05:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:05:13 +0000 Subject: [Koha-bugs] [Bug 7917] Print/download new arrivals list in ISBD format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7917 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- Savitra, are you working on this? Which is the scope of the idea? How would you calculate the new arrivals? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:18:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:18:27 +0000 Subject: [Koha-bugs] [Bug 13695] New: Allow ISBD format export Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Bug ID: 13695 Summary: Allow ISBD format export Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Some users might benefit from an ISBD export option in the OPAC, which is user-configurable and can easily be used for copya & paste. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:18:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:18:56 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7917 CC| |hagud at orex.es Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:18:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:18:56 +0000 Subject: [Koha-bugs] [Bug 7917] Print/download new arrivals list in ISBD format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7917 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13695 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:19:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:19:02 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:44:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:44:21 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 35818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35818&action=edit Bug 13695: Add ISBD to OpacExportOptions This patch adds 'isbd' as an export option on the system preferences. Note this patch doesn't add the feature. To test: - On master, search for the OpacExportOptions syspref => FAIL: There is no ISBD option. - Apply the patch - Search for the OpacExportOptions syspref => SUCCESS: There is a new ISBD option. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:44:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:44:27 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 35819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35819&action=edit Bug 13695: Add ISBD export option to OPAC (detail) This patch adds the option to export a record (from within the OPAC record detail page) in the ISBD format. To test: - Enable ISBD on the OpacExportOptions syspref - Look for a record on your opac - On the detail page, notice there's a new ISBD option for 'Save record' - Choose ISBD => SUCCESS: a file containing the ISBD format for the record is downloaded Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:45:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:45:08 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 35820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35820&action=edit Bug 13695: Add ISBD export option for the OPAC cart and lists This patch adds the option to download records from the cart, and lists in the ISBD format from the OPAC. To test (cart): - Apply the patch - Add several records to your OPAC cart. - Go to your cart, and choose 'Download' => SUCCESS: There's an ISBD option - Dowload and open the exported records => SUCCESS: The file contains the ISBD format for the records on the cart To test (lists): - Add several records to a list (i did it from the cart ;-)) - Open the list - Choose 'Download list' => SUCCESS: There's an ISBD option - Download and open the exported records => SUCCESS: The file contains the ISBD format for the records on the list. - Sign off :-D Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 00:45:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Feb 2015 23:45:24 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 07:01:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 06:01:54 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- I'm wondering if you could make a copy of your database available and the selenium test? I can grab a copy when I am there for hackfest. It would be nice to try some of these same tests. I really need to spend the time to get myself some selenium tests set up. Or did we have a place that we were placing selenium tests before? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 08:15:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 07:15:05 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- A note about this: as things currently are, we will send out information that has been marked as not visible in the OPAC or labelled as internal note. I wonder if we should make including items in the staff/cart optional for the time being as fixing the problem with visibility is a much bigger issue. There has been a discussion about this for OAI as well, but things OPAC side might need a different treatment (bug 12252). I know this patch just makes things more consistent as one download includes items and the other does not - if people are ok with the idea of optional, I will try to work up a patch on a separate bug - not blocking this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 08:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 07:30:31 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |viktor.sarge at regionhalland. |ity.org |se -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 08:33:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 07:33:45 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 08:39:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 07:39:20 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #5 from Marc V?ron --- Hi Viktor, You can put qoutes around the whole text and leave the colon (:) in it: - "for lists of browsable letters. This should be a space separated list of uppercase letters. Hint: Changing collation in the database for the surname column of members is helpful to make browsing by last name work in members-home.pl when using an alphabet outside of A-Z." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 08:40:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 07:40:02 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 --- Comment #4 from Julian Maurice --- (In reply to Jonathan Druart from comment #3) > Julian, > Could you please have a look? It seems that the script > catalogue/itemsearch.pl is never caller with format="html". > Actually the html value is set in the form, but it is DT that calls the > script with format="json". format="html" is a fallback mode for when javascript is disabled. Try disabling JS and reload the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 09:02:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 08:02:59 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #6 from Magnus Enger --- (In reply to Brendan Gallagher from comment #5) > Or did we have a place that we were placing selenium tests before? There are some in the selenium dir: http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=selenium;hb=HEAD These were added by HDL 5-6 years ago and have not been maintained. Jonathan is suggesting we replace them with new ones on bug 13691, which is awesome! Koha could really benefit from some integration tests, imho. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 09:05:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 08:05:19 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 09:30:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 08:30:29 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 --- Comment #7 from Jonathan Druart --- Yep, as Magnus said :) And I would add that you can launch the selenium tests using any DB (in theory, I did not try!). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 09:53:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 08:53:03 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 --- Comment #6 from Jonathan Druart --- yes, we should at least call GetMarcBiblio with the 3rd param set to 1 (opac=1). It is introduced by bug 12252. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 10:12:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 09:12:33 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 --- Comment #7 from Katrin Fischer --- The opac=1 flag will remove items hidden with opachiddenitems - so it would be really good to add that here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 10:39:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 09:39:46 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #23 from Marc V?ron --- We need this feature for Switzerland and it would be great to have it soon. Is anybody working on it at the moment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 10:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 09:47:46 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35817|0 |1 is obsolete| | --- Comment #6 from Viktor Sarge --- Created attachment 35821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35821&action=edit Bug 13686 Add a hint about collation to the alphabet syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. Third times a charm hopefully :) This patch reintroduces the colon in "Hint:" and also corrects a weird wordning. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:08:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:08:50 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 --- Comment #4 from Jonathan Druart --- If the community thinks that these tests are relevant and useful, I can rewrite them to make them pushable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:10:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:10:14 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:11:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:11:08 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #7 from Marc V?ron --- Hi Viktor, This patch seems to be on top of the first (obsoleted) patch and does not apply. I think the best way to resolve is to obsolete this latest patch and reactivate the very first patch. Then add the double quotes, do git add for the changed file and then do git commit --amend -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:20:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:20:51 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35793|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 35822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35822&action=edit Bug 13612 - Remove old YUI javacript libraries from opac-tmpl YUI files were left behind in opac-tmpl/lib/yui after the removal of the prog theme. These files are unused and can be safely removed. To test, apply the patch and search for references to any of the YUI files. You should find none in the OPAC templates. No references found. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:20:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:20:46 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:22:05 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13689 CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- (In reply to Owen Leonard from comment #4) > > Owen, could you confirm? > > I confirm. opac-old.css and sco-old.css were in-development reference files > and shouldn't have made it into the original patch. They can be ignored for > the purposes of this patch and deleted by another one. I am marking this bug depends on bug 13689, IMO they should be pushed together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:22:05 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:22:55 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:31:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:31:24 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Jonathan Druart --- Since I suggest the same patch I completely agree with it :) This patch should also remove all the slq files too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:32:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:32:12 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #19 from Jonathan Druart --- *** Bug 13637 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:32:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:32:12 +0000 Subject: [Koha-bugs] [Bug 13637] Make the permission's descriptions translatable in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 13632 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:47:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:47:15 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #14 from Jonathan Druart --- This looks awesome! I am just wondering why you have moved the script to C4/Sip. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 11:53:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 10:53:13 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Signed Off |BLOCKED --- Comment #4 from Jonathan Druart --- This should be pushed before being used. Looking forward your implementation/examples :) Marked as blocked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:18:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:18:43 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35727|0 |1 is obsolete| | Attachment #35728|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 35823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35823&action=edit Bug 13431 - Shared FastMmap file causes issues Koha::Cache package does not take into account that, when using fastmmap caching variant, mmaped cache file created in /tmp (typically: /tmp/sharefile-koha-koha), would only be further accessible to the one given OS user - the one which created it. In many Koha setups, in the circumstances when various system scripts are executed by 2+ users with diffrent UIDs (like multi-tenant servers, for example) this may cause many kinds of issues. Observable symptom is usually the appearance of the below error when searching, or looking at MARC Framework pages and a few other places: Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. This patch: - disables initialisation of fastmmap caching subsystem unless it is explicitly requested by the user (CACHING_SYSTEM=fastmmap) - disables fastmmap cache usage for command line scripts (i.e. when GATEWAY_INTERFACE environment variable is not defined) - adds the database name, host name and an ID of the OS user to the mmaped file name created in /tmp, to prevent various kinds of unintentional conflicts and/or permission problems from happening To test: 1) remove the /tmp/sharefile-koha-* file[s] (if any) 2) do something which would lead to its re-creation (e.g., performing any search in OPAC should be sufficient to cause that) 3) observe that /tmp/sharefile-koha-koha got created 4) remove it 5) apply patch 6) redo step 2) 7) observe that aforementioned file is no longer created in /tmp 8) set CACHING_SYSTEM environment variable to 'fastmmap' 9) redo step 2), observe that /tmp/sharefile-koha-* file got created and that it's name now contains hostname, database name and UID 10) ensure that everything still works like it should and that there are no regressions of any kinds anywhere in the system ;) Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:18:39 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:18:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:18:52 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #37 from Jonathan Druart --- Created attachment 35824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35824&action=edit Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues 1) Removed 'use C4::Context;' because it can lead to introduction of circular reference in the near future 2) Put fastmmap initialization code into an eval {} block, to catch various kinds of errors which can still occur during it's init in some [less usual] Koha setups and/or more unusual circumstances 3) Do not include UID in the sharefile name (it will be constructed using namespace + database name + database host instead). Test plan addendum: s/and UID// Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:26:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:26:58 +0000 Subject: [Koha-bugs] [Bug 4283] Merge bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Jonathan Druart --- Olli, did you see my comment 2? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:31:04 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- Olli, could you please provide a couple of tests for this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:32:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:32:20 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #8 from Paul Poulain --- (In reply to Jonathan Druart from comment #2) > And... with Plack? > =3.18 + Plack= > CP main = 1.86 + 2.16 + 1.81 + 1.66 + 2.26 => 2 > CP add patron category = 2.23 + 2.10 + 2.32 + 2.25 + 2.17 => 2.2 > CP add patron = 3.27 + 2.89 + 3.17 + 3.29 + 3.38 => 3.2 > CP add items = 8.50 + 8.75 + 8.45 + 8.05 + 8.00 => 8.4 > CP checkout = 6.76 + 6.26 + 5.74 + 6.79 + 6.16 => 6.3 > CP checkin = 4.80 + 5.35 + 4.82 + 5.60 + 5.44 => 5.2 > > Whaou, cool :) 3.18 with Plack and this patch or without this patch ? (next step according to me: improve checkout ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:34:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:34:55 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #27 from Jonathan Druart --- Back to in discussion for the number of pref choice... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:35:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:35:22 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #12 from Jonathan Druart --- This is blocked by the discussion on bug 11625. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:43:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:43:33 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 --- Comment #9 from Jonathan Druart --- (In reply to Paul Poulain from comment #8) > (In reply to Jonathan Druart from comment #2) > > And... with Plack? > > =3.18 + Plack= > > CP main = 1.86 + 2.16 + 1.81 + 1.66 + 2.26 => 2 > > CP add patron category = 2.23 + 2.10 + 2.32 + 2.25 + 2.17 => 2.2 > > CP add patron = 3.27 + 2.89 + 3.17 + 3.29 + 3.38 => 3.2 > > CP add items = 8.50 + 8.75 + 8.45 + 8.05 + 8.00 => 8.4 > > CP checkout = 6.76 + 6.26 + 5.74 + 6.79 + 6.16 => 6.3 > > CP checkin = 4.80 + 5.35 + 4.82 + 5.60 + 5.44 => 5.2 > > > > Whaou, cool :) > 3.18 with Plack and this patch or without this patch ? It's 3.18.x and Plack, so without any other patches applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:47:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:47:05 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 --- Comment #10 from Kyle M Hall --- If these patches don't cause any regressions I see absolutely no reason why we shouldn't not get these changes into master. Great sleuthing Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:55:35 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #30 from Jonathan Druart --- (In reply to Kyle M Hall from comment #16) > (In reply to Jonathan Druart from comment #15) > > QA comment: > > I am quite confuse by this patch. > > IMO there are some inconsistencies: > > 1/ I don't understand the usefulness to pass by the template plugin to know > > if a borrower has overdues or not. > > By using a TT plugin, we don't have to modify each and every script that > uses the members toolbar. Yes, but it's the way it's done everywhere into Koha. I still really don't like to see an other overhead to get this kind of info. Other QA pov needed here please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:57:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:57:06 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 --- Comment #11 from Paul Poulain --- (In reply to Jonathan Druart from comment #9) > > 3.18 with Plack and this patch or without this patch ? > > It's 3.18.x and Plack, so without any other patches applied. What about results with 3.18+Plack+your patches ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:57:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:57:26 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #31 from Jonathan Druart --- (In reply to Kyle M Hall from comment #29) > Created attachment 35538 [details] [review] > Bug 12933 [QA Followup] - Remove trailing whitespace from Members.pm There are 26 patches in the queue modifying C4/Members.pm. IMO this patch does not give enough benefit to be required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:57:46 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35821|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 12:58:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 11:58:18 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35778|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:01:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:01:09 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #30 from Kyle M Hall --- (In reply to Jonathan Druart from comment #29) > (In reply to Kyle M Hall from comment #28) > > (In reply to Jonathan Druart from comment #27) > > > Kyle, How did you tidy Ris.pm? > > > It seems you did not used perltidy: > > > $ perltidy C4/Ris.pm > > > $ diff C4/Ris.pm C4/Ris.pm.tdy | wc > > > 214 1064 10403 > > > > Yes, I did indeed use perltidy. > > Do you use a specific .perltidyrc file? Here is the entiretly of my tidy rc file. I know it's deviating from the standard default, but we live in an age where monitors are a bit bigger than they used to be: -l=120 I can re-tidy the file with pure default Tidy ( the currently accepted Koha standard iirc ) if you wish. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:05:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:05:11 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #8 from Viktor Sarge --- Created attachment 35825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35825&action=edit Bug 13686 Add a hint about collation to the alphabet syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. Trying to follow Marcs instructions on how to wrestle Git into posting the corrected patch. Fingers crossed.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:08:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:08:02 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35485|0 |1 is obsolete| | Attachment #35487|0 |1 is obsolete| | Attachment #35489|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 35826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35826&action=edit Bug 12357 - Enhancements to RIS and BibTeX exporting Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: TY: 942$c LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field, a 942$c field, and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the replaced TY field, the LC field, and multiple NT fields 7) Add the following to the new syspref BibtexExportAdditionalFields: '@': 942$c lccn: 010$a notes: [501$a, 505$g] 9) Using the previously selected record, choose "Save" and select BIBTEX 10) Inspect the downloaded file, note the lccn, the multiple note fields, and the new record type value Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:08:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:08:12 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #32 from Kyle M Hall --- Created attachment 35827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35827&action=edit Bug 12357 - Tidy Ris.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:08:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:08:17 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #33 from Kyle M Hall --- Created attachment 35828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35828&action=edit Bug 12357 - Tidy Record.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:10:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:10:25 +0000 Subject: [Koha-bugs] [Bug 13049] Improve self-registration cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #4 from M. de Rooy --- (In reply to Kyle M Hall from comment #3) > Are you still planning on submitting a patch for this bug? Yes. It is still on my list :) Just need some time.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:14:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:14:32 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #109 from M. de Rooy --- (In reply to Tom?s Cohen Arazi from comment #108) > Hi, i like this patch set, I signed it myself too. > But I'm marking as Signed-off because I want more people involved. It is a > great feature, that could potentially break people's records. So I'm asking > Marcel and/or Katrin to give it a ride before pushing it. I will try to do it within reasonable time (..) I have been working on some of the dependent reports before. If a day just had 28 hours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:27:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:27:15 +0000 Subject: [Koha-bugs] [Bug 13696] New: Add support for Font Awesome icons in Koha Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Bug ID: 13696 Summary: Add support for Font Awesome icons in Koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:27:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:27:20 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:29:48 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:29:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:29:56 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #1 from Kyle M Hall --- Created attachment 35829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35829&action=edit Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:32:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:32:44 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #9 from Viktor Sarge --- Hm. When applying the patch on a new branch with git bz after having marked the first one as active and run --amend it still wants to apply both patches. Using interactive mode I tried to get attachment 35825 but that only messed up things with markup code in the .pref file. Will try to deactivate the first one again and hopefully leave 35825 applicable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:33:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:33:38 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 13:40:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 12:40:03 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #11 from Julian Maurice --- > 1) I am not sure about adding ordereddate and orderedby as those seem > duplicating the information we can get from aqorders.entrydate and > aqbasket.authorisedby. It seems there is no direct link between a suggestion and an order line. Are you suggesting we should create this link ? > 3) For MARC21 the publicationyear is saved in the copyrightdate column > in the database. Please change so that copyrightdate is used in the > SQL query for MARC21 databases. It seems in fact that suggestions.publicationyear is not used at all (my own database only contains NULL or 0 in this column whereas copyrightdate contains the actual data) > In testing this I had difficulties with getting a suggestion into the > ORDERED status with and without the patches - can you check if that > works for you? The new database fields stayed empty too :( Yes, it worked for me, but I will re-check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:10:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:10:31 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #26 from Tom?s Cohen Arazi --- Created attachment 35830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35830&action=edit Bug 10848: (QA followup) use the 'multiple' syspref type instead This patch makes the feature use the 'multiple' syspref type. It does so by changing the type in opac.pref and fixing the relevant files that are used to insert the data on the DB. It also changes opac-suggestions.pl to use ',0 as separator, as used by the 'multiple' syspref type. To test: - Verify there's no behaviour change besides the change in the sysprefs definition. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:11:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:11:08 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:12:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:12:59 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:13:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:13:37 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #27 from Tom?s Cohen Arazi --- I put it back on the QA queue. Hope someone can take a look ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:27:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:27:47 +0000 Subject: [Koha-bugs] [Bug 13697] New: Option to don't add a fee, if the patron changes to a category with enrolment fee Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Bug ID: 13697 Summary: Option to don't add a fee, if the patron changes to a category with enrolment fee Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: christophe.croullebois at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a borrower's category is changed during his subscription (i.e : a child who moves to adult) if category adult in this case have an enrolment fee, fees are added. Many libraries do not want these fees in these cases. So I have made a patch to offer this choice via a system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:30:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:30:30 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12550 CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:30:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:30:30 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:36:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:36:39 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #34 from Jonathan Druart --- Kyle, same with these patch. For instance: diff C4/Ris.pm C4/Ris.pm.tdy returns: < elsif ( $fieldname eq "534" ) { < @subfields = < ( 'a', 'b', 'c', 'e', 'f', 'k', 'l', 'm', 'n', 'p', 't', 'x', 'z' ); < } < elsif ( $fieldname eq "535" ) { --- > } elsif ( $fieldname eq "534" ) { > @subfields = ( 'a', 'b', 'c', 'e', 'f', 'k', 'l', 'm', 'n', 'p', 't', 'x', 'z' ); > } elsif ( $fieldname eq "535" ) { and 898,901c811 < my @subfields = ( < 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'j', 'k', 'l', 'm', 'n', 'o', < 'p', 'q', 'r', 's', 't', 'u', 'v', 'x', 'y', 'z', '2', '3', '4' < ); --- > my @subfields = ( 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'x', 'y', 'z', '2', '3', '4' ); It's weird because I have 40 --maximum-line-length=178 in my ~/.perltidyrc But it does not seem to be take into account. If I launch it with perltidy C4/Ris.pm --noprofile I get the same file as you. I think I have spot a problem in the file: 275 '607', '608', '610', '615', '620', '660' . '661', should be 275 '607', '608', '610', '615', '620', '660' , '661', It existed before this patch. I won't block this patch, but maybe it could be good to have a specific bug report for tidying these files and talk about a common perltidyrc file to use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:41:51 +0000 Subject: [Koha-bugs] [Bug 13698] New: A template for linking almost MARC21 linking fields (76x-78x) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13698 Bug ID: 13698 Summary: A template for linking almost MARC21 linking fields (76x-78x) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org Now with XSLT in MARC21 Koha writes links in linking section (76x-78x) only for fields 773, 775, 789, 785. We want to create a xslt template that could be used from any linking field, except 780 and 785 that have a more complex system in 2? indicator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:42:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:42:46 +0000 Subject: [Koha-bugs] [Bug 13698] A template for linking almost MARC21 linking fields (76x-78x) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13698 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |z.tajoli at cineca.it Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:43:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:43:04 +0000 Subject: [Koha-bugs] [Bug 13698] A template for linking almost MARC21 linking fields (76x-78x) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13698 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:43:17 +0000 Subject: [Koha-bugs] [Bug 13698] A template for linking almost MARC21 linking fields (76x-78x) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13698 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 14:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 13:51:43 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 --- Comment #12 from Jonathan Druart --- (In reply to Paul Poulain from comment #11) > (In reply to Jonathan Druart from comment #9) > > > 3.18 with Plack and this patch or without this patch ? > > > > It's 3.18.x and Plack, so without any other patches applied. > What about results with 3.18+Plack+your patches ? =3.18 + Plack + patches 1, 2, 3= CP main = 1.64 + 1.59 + 1.61 + 1.59 + 1.53 => 1.6 CP add patron category = 2.48 + 2.21 + 2.07 + 2.07 + 2.20 => 2.2 CP add patron = 2.73 + 2.62 + 2.69 + 2.63 + 2.66 => 2.7 CP add items = 7.89 + 7.96 + 7.82 + 8.08 + 7.91 => 7.9 CP checkout = 5.29 + 5.77 + 4.96 + 5.42 + 5.39 => 5.3 CP checkin = 4.92 + 4.78 + 5.90 + 4.99 + 5.45 => 5.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:10:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:10:01 +0000 Subject: [Koha-bugs] [Bug 13697] Option to don't add a fee, if the patron changes to a category with enrolment fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois at bibl | |ibre.com --- Comment #1 from Christophe Croullebois --- Created attachment 35831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35831&action=edit Option to don't add a fee, if the patron changes to a category with enrolment fee thx for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:14:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:14:27 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #199 from Kyle M Hall --- Created attachment 35832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35832&action=edit Bug 9303 [QA Followup] - Restore missing file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:15:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:15:18 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:15:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:15:56 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35760|0 |1 is obsolete| | --- Comment #81 from M. Tompsett --- Created attachment 35833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35833&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again on kohadevbox... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:17:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:17:10 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:17:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:17:29 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35760|1 |0 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:17:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:17:49 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35833|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:18:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:18:07 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34958|0 |1 is obsolete| | Attachment #35454|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 35834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35834&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl Test Plan: 1) Apply this patch 2) Find a waiting hold 3) Browse to reserve/request.pl for that record 4) Notice the "Item waiting" message now has "since " Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:28:50 +0000 Subject: [Koha-bugs] [Bug 13697] Option to don't add a fee, if the patron changes to a category with enrolment fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:35:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:35:32 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34328|0 |1 is obsolete| | --- Comment #12 from Julian Maurice --- Created attachment 35835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35835&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:35:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:35:45 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34329|0 |1 is obsolete| | --- Comment #13 from Julian Maurice --- Created attachment 35836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35836&action=edit Bug 13392: New statistics assistant for suggestions Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:35:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:35:52 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #14 from Julian Maurice --- Created attachment 35837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35837&action=edit Bug 13392: QA fixes 1/ Add tests descriptions 2/ Do not use Koha::I18N for suggestion statuses, and add statuses from SUGGEST_STATUS authorised values 3/ Use copyrightdate instead of publicationyear which seems to be unused 4/ Display free text filters if there is no values in corresponding authorised values list 5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:40:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:40:46 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from Julian Maurice --- > > In testing this I had difficulties with getting a suggestion into > > the ORDERED status with and without the patches - can you check if > > that works for you? The new database fields stayed empty too :( > > Yes, it worked for me, but I will re-check. Apparently it works only when the suggestion is not linked to an existing record (ie. the record is created while creating the order line). I don't know if this is a bug or not. And of course you need to run updatedatabase and misc/devel/update_dbix_class_files.pl (I always forget the latter) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 15:50:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 14:50:26 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Paola Rossi --- Thank you very much, Julian. I've applied the patches against master 3.19.00.010 head 13240. The sw error in comment #22 is OK! About: >Run the updatedatabase.pl script >Existing routing lists should have been imported in a routing list named 'import' All existing routing lists were named "import", as required. But the note field of the existing RLs were all lost. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:10:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:10:27 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- https://github.com/pianohacker/koha/tree/angular-circ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:25:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:25:59 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #614 from Katrin Fischer --- I'd really like to see some testing notes about this feature with the sign-off. This is huge and no library uses all features. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:29:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:29:27 +0000 Subject: [Koha-bugs] [Bug 10363] [DEPENDS ON 13019] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33860|0 |1 is obsolete| | Attachment #33861|0 |1 is obsolete| | Attachment #33862|0 |1 is obsolete| | Attachment #33949|0 |1 is obsolete| | --- Comment #63 from Kyle M Hall --- Created attachment 35838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35838&action=edit Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:29:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:29:36 +0000 Subject: [Koha-bugs] [Bug 10363] [DEPENDS ON 13019] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #64 from Kyle M Hall --- Created attachment 35839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35839&action=edit Bug 10363: Use Koha::AuthorisedValue[s] in the admin page Now we have packages, we need use them in the pl script. Test plan: Verify there are no regression on addind/editing/deleting authorised values. Done forget to test the branch limitation. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:29:40 +0000 Subject: [Koha-bugs] [Bug 10363] [DEPENDS ON 13019] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #65 from Kyle M Hall --- Created attachment 35840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35840&action=edit Bug 10363 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:29:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:29:44 +0000 Subject: [Koha-bugs] [Bug 10363] [DEPENDS ON 13019] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #66 from Kyle M Hall --- Created attachment 35841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35841&action=edit Bug 10363: Fix pod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:31:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:31:41 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #28 from Julian Maurice --- Created attachment 35842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35842&action=edit Bug 7957: Retrieve routing notes from serial table and remove serial.routingnotes column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:32:54 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #29 from Julian Maurice --- I was not aware of this note field. With this patch it should be retrieved during the updatedatabase process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:45:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:45:36 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #22 from H?ctor Eduardo Castro Avalos --- (In reply to Robin Sheat from comment #21) > (In reply to H?ctor Eduardo Castro Avalos from comment #20) > > Since long time that I'm working with the code, I forgot how to install > > RDF::Trine and the missed dependencies. I did a fresh installation for > > document all this dependencies. > > That looks not too bad. > > > But there exist a problem with List::Util and RDF::Trine, these modules > > launch an error when you try to install them. > > List::Util is included in core perl, you shouldn't be installing it manually. > > > So the only way to install this module is manually, i.e., download the > > tar.gz from search.cpan.org. > > Why do you need to install it manually? > > > Then you can install cpanm RDF::Trine and the module will upgrade. > > More importantly, I need to know if the versions specified in the > dependencies are actually the minimum versions. If the code can handle lower > versions of those modules, then things will be a lot easier. For example, > there is already a librdf-trine-perl module. Why aren't you using that? > > > PS. I'm working with debian stable (wheezy) > > We also need to support debian oldstable (squeeze) for the moment. > > We can't have people using cpanm, if this is to go in to Koha, we need the > dependencies produced too. I can do that, but I need a more information, > mostly about what _really_ the minimum version numbers that are allowable > are. Hi, Robin. The problem is that RDF has been changing since was created. If you use librdf-trine-perl (1.0001) and librdf-helper-perl (2.01) launch an error (comment 11) when using bnode labels like 'ISO3166', the new modules from cpan didn't do it. So, for that reason I took the decision to upgrade the modules. It is not recommended to use XML modules for RDF (like XML::LibXML). Furthermore RDF modules give the opportunity to serialize metadata in other formats. I will follow up your advice about to change the code to accommodate with the modules provided by Debian. I'll get in touch with you as soon as possible. This is the list of packages on Debian: XML::Entities, package need to be created. HTML::Entities come in libhtml-parser-perl (3.66-1) squeeze and wheezy adhered to the debian/control RDF::Helper come in librdf-helper-perl (2.0-1) just for wheezy. RDF::Trine come in librdf-trine-perl (1.000-1) just for wheezy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:49:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:49:14 +0000 Subject: [Koha-bugs] [Bug 11431] [DEPENDS ON 13019] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34864|0 |1 is obsolete| | Attachment #34865|0 |1 is obsolete| | Attachment #34866|0 |1 is obsolete| | Attachment #34867|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall --- Created attachment 35843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35843&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:49:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:49:24 +0000 Subject: [Koha-bugs] [Bug 11431] [DEPENDS ON 13019] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #65 from Kyle M Hall --- Created attachment 35844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35844&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:49:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:49:31 +0000 Subject: [Koha-bugs] [Bug 11431] [DEPENDS ON 13019] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #67 from Kyle M Hall --- Created attachment 35846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35846&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:49:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:49:27 +0000 Subject: [Koha-bugs] [Bug 11431] [DEPENDS ON 13019] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #66 from Kyle M Hall --- Created attachment 35845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35845&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:54:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:54:04 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35760|0 |1 is obsolete| | --- Comment #82 from M. Tompsett --- Created attachment 35847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35847&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/it-IT/necessari/notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again on kohadevbox... Also fixed missing sample notices. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 16:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 15:56:15 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #6 from Jonathan Druart --- Comment on attachment 35834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35834 Bug 13517 - Show waiting date on reserve/request.pl Review of attachment 35834: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13517&attachment=35834) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +303,4 @@ > # Find the desired items in the reserves > my @params; > my $query = " > + SELECT * FROM reserves WHERE biblionumber = ? "; Please keep the field list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 17:01:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 16:01:13 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Paola Rossi --- Thanks, Julian. I've applied the patches against master 3.19.00.010 head 13240. After having run updatedatabase, the new "created_by" field of the already existing aqorders was set to the basket's creator code, as expected. On acqui/parcel.pl, in "More" column, for each already existing aqorder, on "Order" link this Creator's name appeared, as required. On acqui/orderreceive.pl, receiving an already existing order, I saw this Creator's name in front of "Created by:" label, as required. For new orders, in DB the "created_by" field of aqorder record was set to NULL (ERROR). On acqui/parcel.pl, in "More" column, on "Order" link I saw none "Creator" (ERROR). On acqui/orderreceive.pl, I saw "No name" in front of "Created by:" label, to the right of the page (ERROR). So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 17:09:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 16:09:32 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35557|0 |1 is obsolete| | Attachment #35558|0 |1 is obsolete| | Attachment #35559|0 |1 is obsolete| | Attachment #35560|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 35848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35848&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 17:09:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 16:09:40 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #23 from Kyle M Hall --- Created attachment 35849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35849&action=edit Bug 12598 - Tidy import_borrowers.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 17:09:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 16:09:43 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #24 from Kyle M Hall --- Created attachment 35850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35850&action=edit Bug 12598 - Move importing code to a subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 17:09:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 16:09:46 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #25 from Kyle M Hall --- Created attachment 35851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35851&action=edit Bug 12598 - Update command line script to use patron import subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 18:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 17:20:56 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Paola Rossi --- Thanks, Julian. I've applied the 3 patches against master 3.19.00.010. The existing imported-RLs' notes were present, as expected. On master, on Patrons the tag ?Routing lists? of a patron lists the subscriptions? RL-s the patron-borrower is in. On the contrary, after having applied the patches, the tag ?Routing lists? of a patron lists no (neither new nor imported) RL-s the patron is in: 0 Subscription routing lists Patron does not belong to any subscription routing lists. I think this could be an error. For now I pass the patch to "Failed QA". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 18:25:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 17:25:56 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35847|0 |1 is obsolete| | --- Comment #83 from M. Tompsett --- Created attachment 35852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35852&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/it-IT/necessari/notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again on kohadevbox... Fixed from who... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 18:27:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 17:27:15 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35852|0 |1 is obsolete| | --- Comment #84 from M. Tompsett --- Created attachment 35853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35853&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/it-IT/necessari/notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again on kohadevbox... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 18:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 17:33:43 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35853|0 |1 is obsolete| | --- Comment #85 from M. Tompsett --- Created attachment 35854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35854&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/it-IT/necessari/notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again on kohadevbox... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 21:24:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 20:24:32 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 21:26:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 20:26:06 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 21:26:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 20:26:06 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13695 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 21:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 20:58:42 +0000 Subject: [Koha-bugs] [Bug 3006] ability to hide a collection / location from OPAC users In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3006 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 22:25:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 21:25:10 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #16 from Katrin Fischer --- Hi Julian, sorry, I don't understand the last comment - can you give an example/step by step for both cases maybe? Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 22:33:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 21:33:51 +0000 Subject: [Koha-bugs] [Bug 3006] ability to hide a collection / location from OPAC users In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think that this is mostly covered by opachiddenitems these days - Nicole, could you confirm? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 22:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 21:40:52 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #23 from Robin Sheat --- I wouldn't go changing the code to make it work with lower versions unless that's easy to do. However, it's only one or two minor releases off of what's in debian, so if it works with that, then that'd be easier (so often, people just specify the most recent version because that's all that they tested, when it's not necessary.) If it requires the versions you specified, that's fine too. I'll just make those packages (assuming it's possible - which it probably is.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 23:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 22:57:46 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #20 from David Cook --- (In reply to Katrin Fischer from comment #17) > It's not so much a translation thing - Bernardo already has provided the fix > for that, but a maintenance/web installer problem. > > The web installer will use the files in the language directory from the > language you picked at the beginning of the installation process. There is > no fallback to en if a file is missing. > > So currently, when a new permission is added, we have to maintain not one > central file, but the en file plus all translated files. Not good. > > For systempreferences the web installer knows that sysprefs.sql is > mandatory, even tho it lives outside of the web installer files. I think > maybe we can handle the permissions file the same way. One file - always > installed independent of the picked language. I think I understand what you're saying, but I'm not sure that will be an issue in this case? Since the file will live in the regular "en" includes, won't it just be a regular candidate for translation? If it gets translated, then users will see translated text. If it doesn't get translated, users will see English. Isn't that right? That's where I'm confused :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 11 23:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 22:58:24 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #21 from David Cook --- (In reply to Jonathan Druart from comment #18) > Since I suggest the same patch I completely agree with it :) > > This patch should also remove all the slq files too. Hehe. Yay! Good call! I suppose it should also remove any references to the SQL files in the installer. I'll have a look at this again when I have some free time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 00:17:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 23:17:28 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 --- Comment #14 from David Cook --- (In reply to Tom?s Cohen Arazi from comment #13) > We should just stop doing this, and use normalized data... with a proper > borrower_phone table... with a column labeled 'type'... a 'primary' > checkbox... and allow users to have an arbitrary number of phone numbers. > And show them with a pretty icon depicting the type of phone... > > Just saying. Agreed! I seem to recall saying the same thing on an older bug report. We'd want to do the same thing with email addresses as well. Also mailing addresses. Fax would probably be included in the phone table... Contacts should also be normalized... Really a lot of the data in the borrowers table should probably be moved out into their own tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 00:48:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 23:48:21 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 00:48:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Feb 2015 23:48:51 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #49 from David Cook --- (In reply to Katrin Fischer from comment #48) > Hm, are you sure? > > >This patch corrects this problem by getting itemtype from $item->{'itype'} >which comes from item or biblio level in GetItem(). > > Maybe the reason is that I had both and it only falls back if you have no > item level itypes? Fridolin, could you take a quick look and confirm what is > he correct default behaviour? > > I would be really interesting to know if record level itypes still used by a > lot of libraries. Hehe. I'm never sure after you ask me if I'm sure ;). Here's my quick review of the source: -- Instances of UpdateStats(): 1) AddReturn() Currently uses: "$biblio->{'itemtype'}" $item defined by: C4::GetItem() This is interesting because $biblio actually appears to be null in AddReturn(). So it looks like all the stats for returns will probably have a null itemtype. (My claim should only be false if there's a function that modifies $biblio without taking it as an argument, which... would also be suboptimal.) 2) AddRenewal() Currently uses: $item->{itype} $item defined by: C4::GetItem() 3) CanBookBeIssued() Currently uses: $item->{'itemtype'} $item defined by: C4::GetItem() It appears that $item->{'itemtype'} is actually defined by $item->{'itype'}, so changing this should just improve readability. The values should be identical. NOTE: This only uses UpdateStats() for statistical borrowers 4) AddIssue() Currently uses: $item->{'itype'} $item defined by: C4::GetItem() -- In regards to C4::GetItem(): $item->{itype} will equal "biblioitems.itemtype" if "items.itype" is false. Katrin: I don't know what that means exactly. I always use item-level item types. I assume this means that if one were to use biblio-level itemtypes, that items.itype would be false (ie null or blank) and thus biblioitems.itemtype would be places in $item->{itype}... However, regardless of the behaviour in C4::GetItem(), using $item->{'itype'} when calling UpdateStats() should guarantee consistency. At the moment, it looks to me that AddRenewal(), CanBookBeIssued(), and AddIssue() are probably using item-level itemtypes... while AddReturn() is probably using a blank value (as UpdateStats will use a blank value if itemtype doesn't exist). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 06:51:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 05:51:13 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 06:51:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 05:51:16 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33689|0 |1 is obsolete| | --- Comment #58 from Brendan Gallagher --- Created attachment 35855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35855&action=edit Bug 11592 - MARC Visibility settings not respected The advanced constraints section while editing subfield structure for a particular MARC bibliographic framework allow the user to set visibility settings for OPAC and Intranet. These settings are not fully respected. This was first discovered while comparing the information displayed on the opac-MARCdetail and opac-detail pages. To this end, this patch will provide the ability to correct this problem across the board as desired, but will focus primarily on the OPAC interface. This was accomplished by adding 3 functions to C4/Biblio.pm: - ShouldDisplayOnInterface - ShouldHideMARC - GetFilteredBiblio And also by modifying GetMarcBiblio to filter or not based on parameter style and parameter values passed. ShouldDisplayOnInterface is a wrapper routine which just returns a hash of hashes which let us know if something is visible (1) or not (0 or undef) for a given interface (opac or intranet). This allows us to add/remove to the advance constraints section and then not have to update multiple routines to keep the filtering working properly, though if it is a drastic refactoring that would be necessary. ShouldHideMARC takes a field from marc_subfield_structure, and determines if it should be hidden. It does this for all the fields for a given framework code on a particular interface. If no framework code is given, the framework code used is the default one. If not interface is specified, OPAC is assumed. This routine returns a hash reference to the corresponding hash that was built. GetFilteredBiblio takes a MARC::Record, clones it, and then strips all the fields that should not be visible for a given framework code and interface. If no framework code is specied, it assumes the default one. If no interface is given, OPAC is assumed. The routine then returns the filtered record. GetMarcBiblio was modified to accept a hash style parameter. This allowed for filtering if the new convention was used, and no apparent change if the old convention is used. These functions allowed for filtering, but frequently there were problems with titles, subjects, etc. This required other tweaks. In C4/Biblio.pm, GetMarcSubjects was returning the subject, even it was supposed to be hidden. C4/XSLT.pm tried to replace a field with no field, rather than properly delete it. With the filtering being implemented based on the parameter style, it just required a minor tweak in opac-ISDBdetail to filter. The title needed to be purposefully not set if it was supposed to be hidden in opac-MARCdetail. However, opac-detail was interesting challenge. First, changing the parameter style did filtering, but the output still was leaking things which should be hidden. This is the main reason ShouldHideMARC was written, because there is an insidious little loop that runs through a set of keys and sets template parameters to values. Second, By skipping to the next key based on the hash ref returned by ShouldHideMARC, the template parameter is not set, and thus the value is properly hidden. Third, the subtitle was grabbed by GetRecordValue. This was refactored so filtering worked properly. Then opac-MARCdetail's 'view plain' was still showing details. This required converting the XML record to a MARC::Record, filtering it, and then converting it back. By tweaking opac-export and opac-showmarc to use the new parameter calling convention, records were filtered properly. And of course, with modifications and additions to C4/Biblio.pm, tests were required. t/Biblio.t has been modified to check the new function ShouldDisplayOnInterface. t/db_dependent/Biblio.t has also been modified. It confirms that both old and new calling conventions work. It also tests hiding the title field (200$a UNIMARC, 245$a MARC). It includes tests for ShouldHideMARC, GetFilteredBiblio, and GetMarcBiblio. TEST PLAN --------- 1) Back up your DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be mostly hidden as before until you... 13) Click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) perldoc C4::Biblio -- Look for ShouldHideMARC and confirm that the perldoc entries are okay. 17) prove -v t/Biblio.t -- 'Visibility values confirmed.' test should pass. 18) prove -v t/db_dependent/Biblio.t -- tests 26 through 41 should pass for UNIMARC and MARC21. It would be good to test this patch on both types of systems. 19) Refresh the opac-MARCdetail page. Title should hide now. 20) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 21) Click Normal view 22) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 23) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 24) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields do hide in 'MARC view', but not normal view. This patch does not deal with 952 fields. 25) Attempt to 'Save record' in a variety of types. -- Only unhidden fields should display. Signed-off-by: Brendan Gallagher TOOK me awhile but it works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 06:52:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 05:52:30 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35855|0 |1 is obsolete| | --- Comment #59 from Brendan Gallagher --- Created attachment 35856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35856&action=edit Bug 11592 - MARC Visibility settings not respected The advanced constraints section while editing subfield structure for a particular MARC bibliographic framework allow the user to set visibility settings for OPAC and Intranet. These settings are not fully respected. This was first discovered while comparing the information displayed on the opac-MARCdetail and opac-detail pages. To this end, this patch will provide the ability to correct this problem across the board as desired, but will focus primarily on the OPAC interface. This was accomplished by adding 3 functions to C4/Biblio.pm: - ShouldDisplayOnInterface - ShouldHideMARC - GetFilteredBiblio And also by modifying GetMarcBiblio to filter or not based on parameter style and parameter values passed. ShouldDisplayOnInterface is a wrapper routine which just returns a hash of hashes which let us know if something is visible (1) or not (0 or undef) for a given interface (opac or intranet). This allows us to add/remove to the advance constraints section and then not have to update multiple routines to keep the filtering working properly, though if it is a drastic refactoring that would be necessary. ShouldHideMARC takes a field from marc_subfield_structure, and determines if it should be hidden. It does this for all the fields for a given framework code on a particular interface. If no framework code is given, the framework code used is the default one. If not interface is specified, OPAC is assumed. This routine returns a hash reference to the corresponding hash that was built. GetFilteredBiblio takes a MARC::Record, clones it, and then strips all the fields that should not be visible for a given framework code and interface. If no framework code is specied, it assumes the default one. If no interface is given, OPAC is assumed. The routine then returns the filtered record. GetMarcBiblio was modified to accept a hash style parameter. This allowed for filtering if the new convention was used, and no apparent change if the old convention is used. These functions allowed for filtering, but frequently there were problems with titles, subjects, etc. This required other tweaks. In C4/Biblio.pm, GetMarcSubjects was returning the subject, even it was supposed to be hidden. C4/XSLT.pm tried to replace a field with no field, rather than properly delete it. With the filtering being implemented based on the parameter style, it just required a minor tweak in opac-ISDBdetail to filter. The title needed to be purposefully not set if it was supposed to be hidden in opac-MARCdetail. However, opac-detail was interesting challenge. First, changing the parameter style did filtering, but the output still was leaking things which should be hidden. This is the main reason ShouldHideMARC was written, because there is an insidious little loop that runs through a set of keys and sets template parameters to values. Second, By skipping to the next key based on the hash ref returned by ShouldHideMARC, the template parameter is not set, and thus the value is properly hidden. Third, the subtitle was grabbed by GetRecordValue. This was refactored so filtering worked properly. Then opac-MARCdetail's 'view plain' was still showing details. This required converting the XML record to a MARC::Record, filtering it, and then converting it back. By tweaking opac-export and opac-showmarc to use the new parameter calling convention, records were filtered properly. And of course, with modifications and additions to C4/Biblio.pm, tests were required. t/Biblio.t has been modified to check the new function ShouldDisplayOnInterface. t/db_dependent/Biblio.t has also been modified. It confirms that both old and new calling conventions work. It also tests hiding the title field (200$a UNIMARC, 245$a MARC). It includes tests for ShouldHideMARC, GetFilteredBiblio, and GetMarcBiblio. TEST PLAN --------- 1) Back up your DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be mostly hidden as before until you... 13) Click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) perldoc C4::Biblio -- Look for ShouldHideMARC and confirm that the perldoc entries are okay. 17) prove -v t/Biblio.t -- 'Visibility values confirmed.' test should pass. 18) prove -v t/db_dependent/Biblio.t -- tests 26 through 41 should pass for UNIMARC and MARC21. It would be good to test this patch on both types of systems. 19) Refresh the opac-MARCdetail page. Title should hide now. 20) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 21) Click Normal view 22) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 23) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 24) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields do hide in 'MARC view', but not normal view. This patch does not deal with 952 fields. 25) Attempt to 'Save record' in a variety of types. -- Only unhidden fields should display. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 06:53:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 05:53:28 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33357|0 |1 is obsolete| | --- Comment #60 from Brendan Gallagher --- Created attachment 35857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35857&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 06:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 05:53:49 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35856|0 |1 is obsolete| | --- Comment #61 from Brendan Gallagher --- Created attachment 35858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35858&action=edit Bug 11592 - MARC Visibility settings not respected The advanced constraints section while editing subfield structure for a particular MARC bibliographic framework allow the user to set visibility settings for OPAC and Intranet. These settings are not fully respected. This was first discovered while comparing the information displayed on the opac-MARCdetail and opac-detail pages. To this end, this patch will provide the ability to correct this problem across the board as desired, but will focus primarily on the OPAC interface. This was accomplished by adding 3 functions to C4/Biblio.pm: - ShouldDisplayOnInterface - ShouldHideMARC - GetFilteredBiblio And also by modifying GetMarcBiblio to filter or not based on parameter style and parameter values passed. ShouldDisplayOnInterface is a wrapper routine which just returns a hash of hashes which let us know if something is visible (1) or not (0 or undef) for a given interface (opac or intranet). This allows us to add/remove to the advance constraints section and then not have to update multiple routines to keep the filtering working properly, though if it is a drastic refactoring that would be necessary. ShouldHideMARC takes a field from marc_subfield_structure, and determines if it should be hidden. It does this for all the fields for a given framework code on a particular interface. If no framework code is given, the framework code used is the default one. If not interface is specified, OPAC is assumed. This routine returns a hash reference to the corresponding hash that was built. GetFilteredBiblio takes a MARC::Record, clones it, and then strips all the fields that should not be visible for a given framework code and interface. If no framework code is specied, it assumes the default one. If no interface is given, OPAC is assumed. The routine then returns the filtered record. GetMarcBiblio was modified to accept a hash style parameter. This allowed for filtering if the new convention was used, and no apparent change if the old convention is used. These functions allowed for filtering, but frequently there were problems with titles, subjects, etc. This required other tweaks. In C4/Biblio.pm, GetMarcSubjects was returning the subject, even it was supposed to be hidden. C4/XSLT.pm tried to replace a field with no field, rather than properly delete it. With the filtering being implemented based on the parameter style, it just required a minor tweak in opac-ISDBdetail to filter. The title needed to be purposefully not set if it was supposed to be hidden in opac-MARCdetail. However, opac-detail was interesting challenge. First, changing the parameter style did filtering, but the output still was leaking things which should be hidden. This is the main reason ShouldHideMARC was written, because there is an insidious little loop that runs through a set of keys and sets template parameters to values. Second, By skipping to the next key based on the hash ref returned by ShouldHideMARC, the template parameter is not set, and thus the value is properly hidden. Third, the subtitle was grabbed by GetRecordValue. This was refactored so filtering worked properly. Then opac-MARCdetail's 'view plain' was still showing details. This required converting the XML record to a MARC::Record, filtering it, and then converting it back. By tweaking opac-export and opac-showmarc to use the new parameter calling convention, records were filtered properly. And of course, with modifications and additions to C4/Biblio.pm, tests were required. t/Biblio.t has been modified to check the new function ShouldDisplayOnInterface. t/db_dependent/Biblio.t has also been modified. It confirms that both old and new calling conventions work. It also tests hiding the title field (200$a UNIMARC, 245$a MARC). It includes tests for ShouldHideMARC, GetFilteredBiblio, and GetMarcBiblio. TEST PLAN --------- 1) Back up your DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be mostly hidden as before until you... 13) Click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) perldoc C4::Biblio -- Look for ShouldHideMARC and confirm that the perldoc entries are okay. 17) prove -v t/Biblio.t -- 'Visibility values confirmed.' test should pass. 18) prove -v t/db_dependent/Biblio.t -- tests 26 through 41 should pass for UNIMARC and MARC21. It would be good to test this patch on both types of systems. 19) Refresh the opac-MARCdetail page. Title should hide now. 20) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 21) Click Normal view 22) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 23) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 24) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields do hide in 'MARC view', but not normal view. This patch does not deal with 952 fields. 25) Attempt to 'Save record' in a variety of types. -- Only unhidden fields should display. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 07:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 06:08:59 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 07:09:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 06:09:01 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 --- Comment #7 from Brendan Gallagher --- Created attachment 35859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35859&action=edit BZ12631: Inventory: fix "wrong place" and "item not scanned" "item not scanned": when calling GetItemsForInventory, datelastseen should be used when "compare barcodes list to result" is checked. Otherwise, when loading multiple barcodes files for the same inventory, many items will be marked as "item not scanned" when loading the last barcode file ("compare barcodes list to result" checked) even though they were scanned. "wrong place": when searching for wrongly placed items, we should only check for the location (callnumbers, location and branch). To fix this, A new call to GetItemsForInventory has been made with location filters only. Otherwise, any item with a different itemtype for instance will be marked as wrong place even if the location is correct. Test plan: "item not scanned" status: 1) Split a barcode file in two. 2) Load the first barcode file without checking "compare barcodes list to result". 3) Load the second barcode file with "compare barcodes list to result" checked. 4) Check in the csv report that you have a lot of scanned items with the "item not scanned" status. Then apply the patch, do the same, and check that the false "item not scanned" statuses are gone. "wrong place" status: 1) Load a barcode file with barcode matching an item that has a correct location, but a different itemtype than what you're looking for. 2) Check in the results that this item will be marked as "change item status" and "wrong place". Then apply the patch, do the same, and check that the only status for this item is "change item status", which is correct. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 07:11:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 06:11:12 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher --- (In reply to Brendan Gallagher from comment #7) > Created attachment 35859 [details] [review] > BZ12631: Inventory: fix "wrong place" and "item not scanned" > > "item not scanned": when calling GetItemsForInventory, datelastseen should > be used when "compare barcodes list to result" is checked. > > Otherwise, when loading multiple barcodes files for the same inventory, many > items will be marked as "item not scanned" when loading the last barcode > file > ("compare barcodes list to result" checked) even though they were scanned. > > "wrong place": when searching for wrongly placed items, we should only check > for the location (callnumbers, location and branch). To fix this, A new call > to GetItemsForInventory has been made with location filters only. > > Otherwise, any item with a different itemtype for instance will be marked as > wrong place even if the location is correct. > > Test plan: > > "item not scanned" status: > > 1) Split a barcode file in two. > 2) Load the first barcode file without checking "compare barcodes list to > result". > 3) Load the second barcode file with "compare barcodes list to result" > checked. > 4) Check in the csv report that you have a lot of scanned items with the > "item > not scanned" status. > > Then apply the patch, do the same, and check that the false "item not > scanned" > statuses are gone. > > "wrong place" status: > > 1) Load a barcode file with barcode matching an item that has a correct > location, but a different itemtype than what you're looking for. > 2) Check in the results that this item will be marked as "change item status" > and "wrong place". > > Then apply the patch, do the same, and check that the only status for this > item is "change item status", which is correct. > > Signed-off-by: Brendan Gallagher I recently had a support ticket that dealt with inventory, so I easily had a few copies of barcodes. I split into two and followed the test plan. Excellent timing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 07:16:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 06:16:41 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- I think that would be quite a rewrite involving lots of code, patron import and every page where we show address information/phone numbers. But should this reallybe blocking this patch? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 07:17:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 06:17:11 +0000 Subject: [Koha-bugs] [Bug 11431] [DEPENDS ON 13019] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #68 from paxed --- (In reply to Kyle M Hall from comment #67) > Created attachment 35846 [details] [review] Just wondering if http:// vs https:// matters for this: + // This is way faster than substring + if ( ! ( sound.charAt(4) == ':' && sound.charAt(5) == '/' && sound.charAt(6) == '/' ) ) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 09:07:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 08:07:23 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #31 from Julian Maurice --- Created attachment 35860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35860&action=edit Bug 7957: Fix members/routing-lists.pl page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 09:09:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 08:09:35 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Julian Maurice --- Thanks for your comments Paola, I didn't even know this page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 09:19:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 08:19:12 +0000 Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS --- What is the purpose of the line : $mr; ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 09:23:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 08:23:03 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #17 from Julian Maurice --- Here's a simple step by step example that worked for me: 1/ Create a new suggestion 2/ Mark it as ACCEPTED 3/ Create a new order from this suggestion After these steps a new biblio record should be created, the suggestion should be linked to it and its status should be ORDERED. In the basket view, you should see a link to the suggestion. But before that make sure you've run the updatedatabase script and the script in misc/devel/update_dbix_class_files.pl My remark was about if we create a suggestion from a suggestion that is already linked to a biblionumber (maybe the suggestion was already ORDERED and someone reset status to ACCEPTED), then the suggestion status is not updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 09:52:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 08:52:18 +0000 Subject: [Koha-bugs] [Bug 13699] New: DBD::mysql mysql_auto_reconnect attribute ceases to function after DBIx call[s] Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13699 Bug ID: 13699 Summary: DBD::mysql mysql_auto_reconnect attribute ceases to function after DBIx call[s] Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org While testing Bug 13645 patch #2, I noticed that DBIx calls apparently do interfere with DBD::mysql mysql_auto_reconnect attribute. We have mysql auto reconnect enabled since Bug 10611, and it works fine as long as there are no DBIx calls being made - but if there is such a call in the given code, this attribute gets reseted to 0 as a side affect, disabling auto reconnect feature for all further DBI or DBIx calls being made from the same process and/or thread. E.g.: use Modern::Perl; use C4::Context; use Koha::Acquisition::Bookseller; my $dbh = C4::Context->dbh; print "Auto reconnect: ".$dbh->{mysql_auto_reconnect}."\n"; my @booksellers = Koha::Acquisition::Bookseller->search(); print "Auto reconnect: ".$dbh->{mysql_auto_reconnect}."\n"; ## $dbh->{mysql_auto_reconnect}=1; sleep(15); ## mysqld to be reloaded in the meanwhile @booksellers = Koha::Acquisition::Bookseller->search(); Auto reconnect: 1 Auto reconnect: 0 DBD::mysql::st execute failed: MySQL server has gone away at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1593. At first I assumed that it may be caused by 'Bug 13645: Use DBIx::Connector', but nope, it turns out that this issue is also present in unpatched master. Probably not such a big problem for the plain CGI setups in most typical circumstances, but lack of working auto reconnect may be quite a nuisance under plack/mod_perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 09:53:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 08:53:12 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #34 from Julian Maurice --- It works for me. Did you run misc/devel/update_dbix_class_files.pl ? Are you logged in with a real user (not the database user) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 10:06:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 09:06:48 +0000 Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Julian Maurice --- Changed status to signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 10:18:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 09:18:13 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #13 from Jonathan Druart --- Switch the status to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 10:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 09:18:39 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #14 from Jonathan Druart --- Switch the status back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 10:32:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 09:32:32 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 --- Comment #14 from Paul Poulain --- Calculated sums : * 3.18 + Plack without those patches : 27.3s * 3.18 + Plack with those patches: 24.9 (compared to 65 for 3.18 and 50 for 3.16 in CGI mode) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 10:32:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 09:32:56 +0000 Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 --- Comment #5 from Jonathan Druart --- To assign $mr to $marc_record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 10:33:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 09:33:48 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:06:41 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Paola Rossi --- Thanks, Julian. [And the name of each RL is shown in the RL-s' table, added against master!] I was trying to "Add a borrower" to a RL. On /cgi-bin/koha/serials/member-search.pl, I: A) have selected a Library and a Category, and these input values have been crossed in AND [OK]: Library AND Category B) have selected a Library, a Category and a Name, and these input values have been crossed in (?): Name OR (Library AND Category) Name OR Library Name OR Category while I was expecting Name AND Library AND Category Name AND Library Name AND Category I think this could be an error. So I pass to "Failed QA" status. NB-1) On /cgi-bin/koha/serials/member-search.pl, I selected a library, and the library [code] appeared in the table result, and IMO this is a benefit for the user. On the contrary, if I selected a category, the category didn't appear in the table result. Perhaps it could be added? NB-2) On /cgi-bin/koha/serials/routinglists.pl, the RL is shown to be: Routing lists for X, where X is the serial-bibliographic-record's title. But the RL is about 1 subscription, and a serial-biblio-record can have some subscriptions. In other parts of koha [serials/serials-collection.pl], koha shows the serial-bibliographic-record title and the "Subscription num." #numbercode's link. Perhaps it could be helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:17:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:17:00 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Is this still a problem with the new server side processing of the patron search table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:21:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:21:06 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:21:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:21:09 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35834|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 35861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35861&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl Test Plan: 1) Apply this patch 2) Find a waiting hold 3) Browse to reserve/request.pl for that record 4) Notice the "Item waiting" message now has "since " Signed-off-by: Aleisha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:21:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:21:13 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #8 from Jonathan Druart --- Created attachment 35862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35862&action=edit Bug 13517: Reintroduce the field list It is preferable to list the fields we retrieve from the DB. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:21:19 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #9 from Jonathan Druart --- Created attachment 35863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35863&action=edit Bug 13517: Add a regression test Be sure GetReservesFromBiblionumber will return the waitingdate value. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:21:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:21:47 +0000 Subject: [Koha-bugs] [Bug 1368] Use of FOREIGN_KEY_CHECKS = 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|mjr at software.coop |koha-bugs at lists.koha-commun | |ity.org --- Comment #3 from Katrin Fischer --- This bug hasn't been touched in almost 3 years. I am resetting the asignee to default - MJ, please undo if you plan on working on this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:26:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:26:12 +0000 Subject: [Koha-bugs] [Bug 2426] Management Permissions Deprecated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #6 from Katrin Fischer --- It appears the only remaining code for this permission has been changed since and now also checks for another permission: 66 [% IF ( CAN_user_management || CAN_user_editcatalogue_edit_catalogue ) %] 67
  • 68 Set library 69
    • 70 [% END %] Might be a good time to finally remove the permission? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:27:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:27:56 +0000 Subject: [Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|enable Perl warnings in all |Omnibus: Enable Perl |modules and scripts |warnings in all modules and | |scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:30:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:30:27 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Jonathan Druart --- Tried again, and got the error. MariaDB [koha_ut]> select count(*) from systempreferences where variable="HoldsQueueSkipClosed"; +----------+ | count(*) | +----------+ | 1 | +----------+ % git diff diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t index a73eac1..b67a2e2 100755 --- a/t/db_dependent/HoldsQueue.t +++ b/t/db_dependent/HoldsQueue.t @@ -307,6 +307,7 @@ C4::Calendar->new( branchcode => 'MPL' )->insert_single_holiday( ); C4::HoldsQueue::CreateQueue(); $holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} }); +warn Data::Dumper::Dumper $holds_queue; is( scalar( @$holds_queue ), 1, "Holds not filled with items from closed libraries" ); C4::Context->set_preference('HoldsQueueSkipClosed', 0); % prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 18/23 $VAR1 = [ { 'itemcallnumber' => undef, 'reservedate' => '2015-02-12', 'borrowernumber' => '70', 'phone' => undef, 'surname' => 'Surname', 'holdingbranch' => 'CPL', 'pickbranch' => 'CPL', 'title' => 'Test Holds Queue XXX', 'item_level_request' => '0', 'notes' => undef, 'biblionumber' => '14', 'firstname' => 'Firstname', 'cardnumber' => 'CARDNUMBER1', 'itemnumber' => '127', 'barcode' => '350699408070' }, { 'reservedate' => '2015-02-12', 'itemcallnumber' => undef, 'borrowernumber' => '71', 'surname' => 'Surname', 'phone' => undef, 'pickbranch' => 'CPL', 'holdingbranch' => 'FFL', 'item_level_request' => '0', 'title' => 'Test Holds Queue XXX', 'notes' => undef, 'firstname' => 'Firstname', 'biblionumber' => '14', 'cardnumber' => 'CARDNUMBER2', 'itemnumber' => '128', 'barcode' => '350699408071' } ]; # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 311. # got: '2' # expected: '1' # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 328. # got: '3' # expected: '2' # Looks like you failed 2 tests of 23. t/db_dependent/HoldsQueue.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/23 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 512 Tests: 23 Failed: 2) Failed tests: 21, 23 Non-zero exit status: 2 Files=1, Tests=23, 3 wallclock secs ( 0.02 usr 0.00 sys + 1.96 cusr 0.04 csys = 2.02 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:31:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:31:13 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #21 from Jonathan Druart --- And I confirm the tests pass on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:38:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:38:44 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #34 from Julian Maurice --- This search generates a quite long SQL query: http://pastebin.com/qYULAHsm where the search is done on firstname, surname, email, othernames and cardnumber. But basically you're right, it does something like (Name OR (Library AND Category)) I don't know if this is intended or not, and as the behaviour is the same as master, I suggest to open a new bug for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:42:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:42:24 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- The code looks good but I am not confident enough with this part of code to mark it as passed QA. Another pair of eyes needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 11:52:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 10:52:25 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart --- The description of the pref is " (Note: title field would be always implicitly required, no need to enter it here).". But it's wrong, if the pref is empty, the title is mandatory. You can save and get "Your suggestion has been submitted.", but nothing has been saved. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 12:10:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 11:10:32 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #62 from Jonathan Druart --- Be care, prototype of GetMarcBiblio is modified here, bug 12252 did it too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 12:11:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 11:11:37 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #63 from Jonathan Druart --- Comment on attachment 35858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35858 Bug 11592 - MARC Visibility settings not respected Review of attachment 35858: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11592&attachment=35858) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +1369,5 @@ > =cut > > sub GetMarcBiblio { > + my @catch_parameters = @_; > + Passing a hashref would be better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 12:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 11:23:44 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #35 from Paola Rossi --- (In reply to Julian Maurice from comment #34) > Are you logged in with a real user (not the database user) ? The user was not a database user [it was the same user OK on already-existing-order]. > Did you run misc/devel/update_dbix_class_files.pl ? Thanks, Julian, I run the command but the problem was not solved. So I keep the status "Failed QA". [NB. If the above command be required, the test plan could be updated about it.] Now the already-existing-order had not the Creator's name on receiving (ERROR). [The already-existing-order' More was still OK.] See also: prove t/db_dependent/Acquisition/NewOrder.t t/db_dependent/Acquisition/NewOrder.t .. 1/8 # Failed test 'Koha::Acquisition::Order->insert set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 91. # got: undef # expected: '42' # Looks like you failed 1 test of 8. t/db_dependent/Acquisition/NewOrder.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests Test Summary Report ------------------- t/db_dependent/Acquisition/NewOrder.t (Wstat: 256 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=8, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.83 cusr 0.08 csys = 0.92 CPU) Result: FAIL I hope this error can help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 12:50:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 11:50:26 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #36 from Julian Maurice --- Created attachment 35864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35864&action=edit Bug 12395: Fix call to set_userenv in unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 12:56:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 11:56:55 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #37 from Julian Maurice --- This patch should fix the test. I don't understand why it doesn't work for you... :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 12:58:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 11:58:58 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #38 from Julian Maurice --- > Now the already-existing-order had not the Creator's name on receiving > (ERROR). [The already-existing-order' More was still OK.] And this is weird, because both use the same data... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:06:13 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #64 from M. Tompsett --- (In reply to Jonathan Druart from comment #62) > Be care, prototype of GetMarcBiblio is modified here, bug 12252 did it too! This change catches the old way and a hashref. Though, because a third parameter was added in 12252, this would require a more detailed look there. However, that would more likely come anyways if that is pushed to master first anyways, because this would need a rebase. Thanks for the heads up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:11:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:11:28 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #91 from Julian Maurice --- Why is the bug status "Failed QA" ? Shouldn't it be "Needs Signoff" ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:28:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:28:04 +0000 Subject: [Koha-bugs] [Bug 1368] Use of FOREIGN_KEY_CHECKS = 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1368 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr at software.coop --- Comment #4 from MJ Ray (software.coop) --- Please take it with my blessing. It looks like it either dates from my time as default assignee for the installer or from an overbroad post-migration reset. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:31:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:31:02 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33006|0 |1 is obsolete| | --- Comment #92 from Julian Maurice --- Created attachment 35865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35865&action=edit Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:31:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:31:12 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33007|0 |1 is obsolete| | --- Comment #93 from Julian Maurice --- Created attachment 35866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35866&action=edit Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:31:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:31:23 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33008|0 |1 is obsolete| | --- Comment #94 from Julian Maurice --- Created attachment 35867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35867&action=edit Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:31:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:31:33 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33009|0 |1 is obsolete| | --- Comment #95 from Julian Maurice --- Created attachment 35868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35868&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:31:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:31:44 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33010|0 |1 is obsolete| | --- Comment #96 from Julian Maurice --- Created attachment 35869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35869&action=edit Bug 8296: Display publisheddatetext in OPAC bootstrap theme Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:31:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:31:55 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33011|0 |1 is obsolete| | --- Comment #97 from Julian Maurice --- Created attachment 35870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35870&action=edit Bug 8296: Fix unit tests in t/db_dependent/Serials.t Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:32:11 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33012|0 |1 is obsolete| | --- Comment #98 from Julian Maurice --- Created attachment 35871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35871&action=edit Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is empty Rebased on master and signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:33:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:33:00 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:34:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:34:43 +0000 Subject: [Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:36:18 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #15 from Jacek Ablewicz --- Not sure what to think about patch #2 (Bug 13645: Use DBIx::Connector) - is it needed for patch #1 or patch #3 (from Bug 13690) to work properly? I'm not seeing any measurable performance gains with patch #2 (on the contrary, in most test performed so far it seems to be a little bit slower to me - but in any case, the differences are insignificant, +3/-2 msec or so); same results when tested alone, or in combination with #1 and #3. Generally, DBIx::Connector looks like a move in the right direction (I guess it should improve stability/DBI connection handling safety in persistent environments, at least in theory ?), but in comparison with #1 & #3, it would be a lot harder to evaluate it for possible regressions, issues etc. While testing #2 I found one issue (Bug 13699), but this bug is also reproducible in unpatched master :). BTW, DBIx::Connector is not on the dependencies list (don't know if it needs to be added, on my test setup I had this module package already installed because I was toying with it previously). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:37:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:37:18 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation and add field for giving a reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:37:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:37:19 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 7162, which changed state. Bug 7162 Summary: Factorize code for order cancellation and add field for giving a reason http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:37:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:37:19 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Bug 13380 depends on bug 7162, which changed state. Bug 7162 Summary: Factorize code for order cancellation and add field for giving a reason http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:39:26 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Julian Maurice --- Changing status to Failed QA, as it requires some work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 13:54:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 12:54:42 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #39 from Paola Rossi --- (In reply to Julian Maurice from comment #36) > Created attachment 35864 [details] [review] > Bug 12395: Fix call to set_userenv in unit tests Sorry, the 5-th patch doesn't fix: prove t/db_dependent/Acquisition/NewOrder.t t/db_dependent/Acquisition/NewOrder.t .. 1/8 # Failed test 'Koha::Acquisition::Order->insert set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 91. # got: undef # expected: '42' # Looks like you failed 1 test of 8. t/db_dependent/Acquisition/NewOrder.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests Test Summary Report ------------------- t/db_dependent/Acquisition/NewOrder.t (Wstat: 256 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=8, 1 wallclock secs ( 0.00 usr 0.01 sys + 0.83 cusr 0.07 csys = 0.91 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 14:13:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 13:13:34 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #40 from Julian Maurice --- Hmm... could you check that you have the aqorders.created_by field in your database and that Koha/Schema/Result/Aqorder.pm contains an entry about created_by ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 14:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 13:30:43 +0000 Subject: [Koha-bugs] [Bug 13700] New: Translated item search not working Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Bug ID: 13700 Summary: Translated item search not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Testing the new item search from available from the advanced search page in the staff client I found it only working in English, but not in its German translation. This is a 3.18.3 installation with current templates. The Javascript errors shown in Firebug are very unspecific - I haven't been able yet to find the source of the problem. Any help much appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 14:30:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 13:30:59 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 14:44:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 13:44:23 +0000 Subject: [Koha-bugs] [Bug 13701] New: Sharing lists: Text hardcoded to 2 weeks, but could be any time frame Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13701 Bug ID: 13701 Summary: Sharing lists: Text hardcoded to 2 weeks, but could be any time frame Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When you invite someone to share a list with you, there is a text displayed on the confirmation page: An invitation to share list ... will be sent shortly to test at ... You will receive an email notification if someone accepts your share within two weeks. I think the invitations are cleaned up using cronjobs - so maybe the text should be less specific? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 14:46:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 13:46:12 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 14:48:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 13:48:00 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35803|0 |1 is obsolete| | --- Comment #35 from Paola Rossi --- Created attachment 35872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35872&action=edit [SIGNED OFF] Bug 7957: Routing lists enhancements I've applied the 4 patches against master 3.19.00.010 head 13240. Everything is OK. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 14:48:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 13:48:37 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35804|0 |1 is obsolete| | --- Comment #36 from Paola Rossi --- Created attachment 35873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35873&action=edit [SIGNED OFF] Bug 7957: Remove uses of check_routing which doesn't exist anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 14:49:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 13:49:09 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35842|0 |1 is obsolete| | --- Comment #37 from Paola Rossi --- Created attachment 35874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35874&action=edit [SIGNED OFF] Bug 7957: Retrieve routing notes from serial table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 14:49:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 13:49:40 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35860|0 |1 is obsolete| | --- Comment #38 from Paola Rossi --- Created attachment 35875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35875&action=edit [SIGNED OFF] Bug 7957: Fix members/routing-lists.pl page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:09:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:09:16 +0000 Subject: [Koha-bugs] [Bug 13701] Sharing lists: Text hardcoded to 2 weeks, but could be any time frame In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13701 --- Comment #1 from M. de Rooy --- I recall starting with a hardcoded value of 14 days, but yes, it is a parameter now of cleanup_database.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:10:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:10:55 +0000 Subject: [Koha-bugs] [Bug 13701] Sharing lists: Text hardcoded to 2 weeks, but could be any time frame In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13701 --- Comment #2 from Katrin Fischer --- Just noting things I find in testing Marcel - it would also be nice to make the email field a bit longer... small stuff mostly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:17:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:17:31 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 --- Comment #16 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #15) > I think that would be quite a rewrite involving lots of code, patron import > and every page where we show address information/phone numbers. But should > this reallybe blocking this patch? :) Not a blocker, "just saying" :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:32:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:32:55 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:49:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:49:43 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #15) > Not sure what to think about patch #2 (Bug 13645: Use DBIx::Connector) - is > it needed for patch #1 or patch #3 (from Bug 13690) to work properly? No, there are all independent. > I'm not seeing any measurable performance gains with patch #2 (on the > contrary, in most test performed so far it seems to be a little bit slower > to me - but in any case, the differences are insignificant, +3/-2 msec or > so); same results when tested alone, or in combination with #1 and #3. In my tests, it was better, see the png file on bug 13690. > BTW, DBIx::Connector is not on the dependencies list (don't know if it needs > to be added, on my test setup I had this module package already installed > because I was toying with it previously). Yes, should be added if the patch is validated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:51:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:51:59 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 --- Comment #14 from Benjamin Rokseth --- any status on this bug? it was tagged for 3_16 but never pushed. It still applies cleanly on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:52:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:52:22 +0000 Subject: [Koha-bugs] [Bug 13702] New: Subroutine to check if a Biblio exists or is deleted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13702 Bug ID: 13702 Summary: Subroutine to check if a Biblio exists or is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl A handy helper function when looking for a biblio. Is it alive? Deleted? or has it never existed (or DELETEd from the deleted* tables)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:53:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:53:43 +0000 Subject: [Koha-bugs] [Bug 13702] Subroutine to check if a Biblio exists or is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13702 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35876&action=edit Bug 13702 - Subroutine to check if a Biblio exists or is deleted A handy helper function when looking for a biblio. Is it alive? Deleted? or has it never existed (or DELETEd from the deleted* tables)? TEST PLAN: 0. Make a code review. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:55:21 +0000 Subject: [Koha-bugs] [Bug 13702] Subroutine to check if a Biblio exists or is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13702 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:55:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:55:59 +0000 Subject: [Koha-bugs] [Bug 13702] Subroutine to check if a Biblio exists or is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13702 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Olli-Antti Kivilahti --- Unit tests pending. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 15:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 14:59:31 +0000 Subject: [Koha-bugs] [Bug 13703] New: batchRebuildBiblioTables.pl should also update from database to MARC Record. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13703 Bug ID: 13703 Summary: batchRebuildBiblioTables.pl should also update from database to MARC Record. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When adding a new column to biblio or biblioitems and populating it with legacy data, the MARC Record needs to be updated to match the values in DB, so they can be indexed for searching. Upgrading the batchRebuildBiblioTables.pl -script to make updates upstream (DB columns to MARC Record) and downstream (MARC Record to DB columns), based on the "Koha to MARC mappings". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 16:03:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 15:03:49 +0000 Subject: [Koha-bugs] [Bug 13703] batchRebuildBiblioTables.pl should also update from database to MARC Record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13703 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35877&action=edit Bug 13703 - batchRebuildBiblioTables.pl should also update from database to MARC Record. When adding a new column to biblio or biblioitems and populating it with legacy data, the MARC Record needs to be updated to match the values in DB, so they can be indexed for searching. Upgrading the batchRebuildBiblioTables.pl -script to make updates upstream (DB columns to MARC Record) and downstream (MARC Record to DB columns), based on the "Koha to MARC mappings". Also improves the batchRebuildBiblioTables.pl -script's documentation and parameter handling. TEST PLAN: 1. Add a new column to biblio or biblioitems-tables. 2. Map the column to "Koha to MARC mappings". 3. Define the mapped MARC Field as a new search index to Zebra and all the relevant hassle what comes with defining a new search index. 4. Populate legacy data to the new DB column. 5. Run the batchRebuildBiblioTables.pl to update the MARC Records from the new DB column. 6. Reindex the whole DB. 7. Make searches from your new index. 8. Split hairs :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 16:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 15:37:35 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Kyle M Hall --- I'll write a followup to remove the plugin sub and use of it, replacing it with something more common. Until then, setting to Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 16:52:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 15:52:01 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #5 from Jonathan Druart --- 1/ 51 files changed, 5515 insertions(+), 1722 deletions(-) (11703 in it) => Should be split 2/ based on 3.16, need a rebase 3/ Squash please, ~40 commits 4/ Decent commit messages, with test plan 5/ Without test plan I had to git grep the code to know where circ/checkout.pl was called 6/ on circ/circulation.pl, More > Switch checkout client Enter a barcode, click on the Check out button, nothing append: 500 Internal Server Error in koha logs: patrons: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/koha/src/C4/Circulation.pm line 747. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 16:58:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 15:58:34 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #6 from Jonathan Druart --- Brendan gave me the angular-circ url yesterday, but https://github.com/pianohacker/koha/tree/angular-submit seems to be more recent. Jesse, could you confirm where is the work related to this bug report ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 17:17:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 16:17:46 +0000 Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33994|0 |1 is obsolete| | Assignee|kyle at bywatersolutions.com |colin.campbell at ptfs-europe. | |com --- Comment #12 from Colin Campbell --- Created attachment 35878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35878&action=edit Revised Patch Revised patch. Found some problems with earlier patch, i.e. it was not allowing the checkout once the fee was acknowledged (it was bailing out of the routine too early). Also it didnt handle the scenario in renew (renew in MsgType was aware of the field but called routines that ignored it). Have handled it in a way that is consistent with how Renew originally intended. Patch functionality has been tested at Chshire Libraries in the UK who are now live with it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 17:24:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 16:24:42 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #62 from Jonathan Druart --- What is the status of this one? Is it still dependent on bug 10486? I would say no, but it's the first step of the test plan. Is it UNIMARC compatible? I found encoding related issues on saving a record, please have a look. Also needs a (trivial) rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 17:39:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 16:39:14 +0000 Subject: [Koha-bugs] [Bug 13704] New: Add ability to backup patron attributes on update Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13704 Bug ID: 13704 Summary: Add ability to backup patron attributes on update Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be useful to be able to auto-backup the previous values of some extended patron attributes. For example, if a person's driver's license ( stored in DRV_LC ) has changed, it this would allow the previous license number to be stored in a different attribute ( e.g. DRV_LC_PRV ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 17:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 16:39:22 +0000 Subject: [Koha-bugs] [Bug 13704] Add ability to backup patron attributes on update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13704 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 17:40:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 16:40:36 +0000 Subject: [Koha-bugs] [Bug 13704] Add ability to backup patron attributes on update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13704 --- Comment #1 from Kyle M Hall --- Created attachment 35879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35879&action=edit Bug 13704 - Add ability to backup patron attributes on update It would be useful to be able to auto-backup the previous values of some extended patron attributes. For example, if a person's driver's license ( stored in DRV_LC ) has changed, it this would allow the previous license number to be stored in a different attribute ( e.g. DRV_LC_PRV ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 17:42:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 16:42:42 +0000 Subject: [Koha-bugs] [Bug 13704] Add ability to backup patron attributes on update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13704 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12598 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 17:42:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 16:42:42 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13704 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 17:51:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 16:51:20 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #41 from Paola Rossi --- Thank you very much, Julian! [in the meanwhile I've installed some not-required perl modules.] (In reply to Julian Maurice from comment #40): >could you check that Koha/Schema/Result/Aqorder.pm contains an entry about > created_by ? yes, it does! The file Koha/Schema/Result/Aqorder.pm in my branch has been updated: cat -n Koha/Schema/Result/Aqorder.pm | grep 'created_by' 97 =head2 created_by 273 "created_by", >could you check that you have the aqorders.created_by field in your > database ? yes, I have; and now the "created_by" field is OK, either for existing orders or for new orders! Now the "More" option is OK either for existing orders or for new orders! Whilst the orderreceive.pl still shows "Created by: No name" in both the cases of orders (ERROR). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 17:52:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 16:52:21 +0000 Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35634|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 35880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35880&action=edit [SIGNED OFF] Bug 13646: Fix facets encoding problem for GSR1 Since bug 11944, the facets are not correctly encoded if the indexing mode is GRS1. In MARC::File::USMARC # if utf8 the we encode the string as utf8 if ( $marc->encoding() eq 'UTF-8' ) { $tagdata = marc_to_utf8( $tagdata ); } $marc->encoding return 'MARC8' because the utf8 flag is not set on the marc record. Test plan: On an installation set with GRS1, launch a search and verify you have facets correctly encoded. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 18:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 17:02:58 +0000 Subject: [Koha-bugs] [Bug 13704] Add ability to backup patron attributes on update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13704 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 18:17:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 17:17:26 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #1 from Owen Leonard --- I see this problem too. I checked out 3.18.3, installed and switched to the German templates, and tried the item search. The search results table never renders. I don't see any errors in the Firebug console, but looking at the data being sent to DataTables I see some differences in the English versus the German output. English: [ "Endless ocean by ", "", "Nintendo of America,", "", "33000000094272", "Wii Endless", "The Plains", "The Plains", "", "", "", "0", "Edit" ] German: [ "Endless ocean von ", "", "Nintendo of America,", "", "33000000094272", "Wii Endless", "The Plains", "The Plains", "", "", "", "0", "Bearbeiten" ] In the German version the quotes around HTML attributes are double quotes instead of the single quotes seen in the English version. I assume that is what is breaking things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 18:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 17:29:19 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11759 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 18:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 17:29:19 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13630 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 18:43:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 17:43:47 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Templates |and plumbing | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 18:45:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 17:45:13 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #2 from Owen Leonard --- Created attachment 35881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35881&action=edit Screenshot showing before and after Looks like it's not quite a drop-in replacement. I'd like to see more testing done to see why things look off-kilter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 19:30:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 18:30:15 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #38 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jacek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 19:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 18:30:43 +0000 Subject: [Koha-bugs] [Bug 13636] Search results item status incorrect for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13636 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 19:31:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 18:31:18 +0000 Subject: [Koha-bugs] [Bug 13335] Holds and priority display via OPACShowHoldQueueDetails confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13335 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 19:31:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 18:31:54 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #57 from Tom?s Cohen Arazi --- Patchset pushed to master. Thanks Kyle, Jonathan and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 19:35:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 18:35:26 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Can u please rebase? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 19:37:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 18:37:17 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- Everything looks good, but it doesn't apply anymore, please rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 19:38:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 18:38:31 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 20:17:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 19:17:54 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #41 from Marjorie Barry-Vila --- Hi, Someone is still working on it? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 22:10:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 21:10:33 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #7 from Jesse Weaver --- (In reply to Jonathan Druart from comment #6) > Brendan gave me the angular-circ url yesterday, but > https://github.com/pianohacker/koha/tree/angular-submit seems to be more > recent. > > Jesse, could you confirm where is the work related to this bug report ? Ah, yes, sorry. The angular-submit branch is more recent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 22:28:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 21:28:56 +0000 Subject: [Koha-bugs] [Bug 2927] Saving on enter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2927 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 22:37:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 21:37:25 +0000 Subject: [Koha-bugs] [Bug 13638] Batch patron modification tool missing option to switch language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13638 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x this will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 22:40:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 21:40:25 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #15 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 22:43:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 21:43:08 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger --- Zeno: You are right, ln:n needs to be replaced with ln:w, both for MARC21 and NORMARC. I can do a patch, but now that grs1 is on the way out, do we still edit biblio-koha-indexdefs.xml and generate biblio-zebra-indexdefs.xsl from that, or do we edit biblio-zebra-indexdefs.xsl directly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 22:44:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 21:44:06 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 23:11:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 22:11:14 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 23:13:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 22:13:42 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 23:28:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 22:28:09 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 23:36:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 22:36:56 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack --- I think this is well worth having in 3.18.4 so have pushed it to 3.18.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 23:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 22:42:44 +0000 Subject: [Koha-bugs] [Bug 13701] Sharing lists: Text hardcoded to 2 weeks, but could be any time frame In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13701 --- Comment #3 from Katrin Fischer --- I mean to say - not a big thing, just wanted to note for later :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 23:47:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 22:47:28 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 12 23:57:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 22:57:10 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 00:16:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 23:16:18 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |director at plaistowlibrary.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 00:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 23:34:20 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 00:34:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Feb 2015 23:34:22 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35661|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 35882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35882&action=edit Bug 13663: allow a librarian with circulate_remaining_permissions to upload koc files The tools/upload-file.pl script require one of the tools permissions to upload koc files. This script is called by offline_circ/process_koc.pl which requires circulate_remaining_permissions. It does not make sense to require another permission for this script. Test plan: Verify that the circulate_remaining_permissions perm is enough to upload .koc file. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 02:17:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 01:17:34 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 02:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 01:20:55 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |Pushed to Master --- Comment #11 from Chris Cormack --- Doesn't apply cleanly on 3.18.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 02:21:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 01:21:56 +0000 Subject: [Koha-bugs] [Bug 13298] Holds ratios report ignores ordered items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13298 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 04:55:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 03:55:31 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #17 from Brendan Gallagher --- Jonathan - I got a merge CONFLICT on the updatedatabase.pl part. After I fix the updatedatabase.pl part - I git-bz apply --continue and get this.. Auto-merging t/db_dependent/Members.t CONFLICT (content): Merge conflict in t/db_dependent/Members.t Auto-merging t/db_dependent/Letters.t Auto-merging opac/opac-shareshelf.pl Auto-merging opac/opac-memberentry.pl Auto-merging misc/cronjobs/overdue_notices.pl Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Auto-merging C4/Message.pm CONFLICT (content): Merge conflict in C4/Message.pm Auto-merging C4/Members.pm Auto-merging C4/Letters.pm Can you rebase for me? Send me IRC ping (or @later) and I will test once you have rebased. *Also note I do see the depends on 9043. But 9043 is already pushed to master ( so I think I don't need to also include 9043 patch - that is correct right? ) Let me know if I am wrong here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:11:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:11:07 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Magnus Enger --- This problem from comment 10 is still a problem: * Major problem: - EnhancedMessagingPreferences = allow - Create a new patron from scratch - Change the category from the default one - Firebug reports a 500 error for /cgi-bin/koha/members/default_messageprefs.pl The actual error reported: Software error: Can't use string ("C4::Service") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Service.pm line 262. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:22:12 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 --- Comment #12 from Jonathan Druart --- (In reply to Chris Cormack from comment #11) > Doesn't apply cleanly on 3.18.x I didn't try to reproduce on 3.18.x, but since bug 12979 is not in it, it should not be needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:28:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:28:54 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 --- Comment #13 from Katrin Fischer --- Hi, I just tested on 3.18.3 - editing funds is ok, but the problem occurs for the budget. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:32:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:32:41 +0000 Subject: [Koha-bugs] [Bug 13705] New: Move indexation subs in C4::ZebraIndex Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bug ID: 13705 Summary: Move indexation subs in C4::ZebraIndex Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Move indexation-related subs from rebuild_zebra.pl to new module C4::ZebraIndex and create two new subs IndexRecord and DeleteRecordIndex This should allow easier indexation from scripts other than rebuild_zebra.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:33:43 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #1 from Julian Maurice --- Created attachment 35883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35883&action=edit Bug 13705: Move indexation subs in C4::ZebraIndex Move indexation-related subs from rebuild_zebra.pl to new module C4::ZebraIndex and create two new subs IndexRecord and DeleteRecordIndex This should allow easier indexation from scripts other than rebuild_zebra.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:33:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:33:46 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #2 from Julian Maurice --- Created attachment 35884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35884&action=edit Bug 13705: Prevent a warning in _fix_unimarc_100 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:35:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:35:16 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Julian Maurice --- To test, run rebuild_zebra.pl trying the different options. The behaviour should remain identical. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:35:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:35:51 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25087|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:36:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:36:38 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #2 from Katrin Fischer --- Thx Owen for taking the time to look at this! I fixed a few problems with the strings, but it still doesn't work. And the problem with the quotes does not seem to exist in the po file? I went through all strings for this template, but had no luck finding anything that would explain it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:37:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:37:03 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 --- Comment #52 from Julian Maurice --- The patch that move indexation subs out of rebuild_zebra.pl was moved to a new bug (Bug 13705) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:39:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:39:32 +0000 Subject: [Koha-bugs] [Bug 13706] New: Deduping authorities script (dedup_authorities.pl) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Bug ID: 13706 Summary: Deduping authorities script (dedup_authorities.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: MARC Authority data support Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:39:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:39:45 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13706 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:39:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:39:45 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13705 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:40:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:40:19 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 --- Comment #1 from Julian Maurice --- Created attachment 35885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35885&action=edit Bug 13706: New script dedup_authorities.pl This script allow to deduplicate authorities automatically. It works this way: 1) authorities are fetched from the database. You can limit fetched results by authtypecode, or directly by specifying WHERE clause 2) for each authority: 2.1) build a Zebra query, depending on --match parameter(s) 2.2) run the query, retrieve the results 2.3) for each result check if result is really a duplicate. check is customizable with option --check. 2.4) among real duplicates, choose the one we want to keep (use --choose-method option). 2.5) use C4::Authorities::merge to merge authorities 3) index updated biblios and authorities, and remove from index removed authorities Use --help for more informations on options Script is in misc/migration_tools/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:40:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:40:32 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:41:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:41:09 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25088|0 |1 is obsolete| | --- Comment #53 from Julian Maurice --- Comment on attachment 25088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25088 Bug 7419: New script dedup_authorities.pl Moved the dedup_authorities.pl patch to a new bug (bug 13706) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:42:03 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:42:03 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13706 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:43:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:43:51 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18713|0 |1 is obsolete| | --- Comment #54 from Julian Maurice --- Created attachment 35886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35886&action=edit Bug 7419: correct LCCN/see from indexing Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:44:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:44:12 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20783|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 35887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35887&action=edit Bug 7419: General-purpose record deduplicator Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:44:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:44:26 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20784|0 |1 is obsolete| | --- Comment #56 from Julian Maurice --- Created attachment 35888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35888&action=edit Bug 7419: Add more missing authority indexes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:44:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:44:39 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20785|0 |1 is obsolete| | --- Comment #57 from Julian Maurice --- Created attachment 35889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35889&action=edit Bug 7419: quiet warnings in deduplicator Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:48:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:48:11 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33864|0 |1 is obsolete| | Attachment #33865|0 |1 is obsolete| | Attachment #33866|0 |1 is obsolete| | Attachment #33867|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 35890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35890&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:48:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:48:18 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #19 from Jonathan Druart --- Created attachment 35891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35891&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:48:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:48:22 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #20 from Jonathan Druart --- Created attachment 35892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35892&action=edit Bug 12802: FIX use the first valid email address if noemail is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:48:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:48:26 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #21 from Jonathan Druart --- Created attachment 35893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35893&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:48:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:48:41 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #3 from Katrin Fischer --- I think this appears to be a problem with the translation script. It appears other translations that I tested this with are not complete - only in the German version of the file some things appear as translated, but not in fr-FR, nb-NO etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:49:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:49:38 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #22 from Jonathan Druart --- (In reply to Brendan Gallagher from comment #17) > Jonathan - > Can you rebase for me? Send me IRC ping (or @later) and I will test once > you have rebased. Done :) > *Also note I do see the depends on 9043. But 9043 is already pushed to > master ( so I think I don't need to also include 9043 patch - that is > correct right? ) Let me know if I am wrong here. Yes, if it is pushed to master, don't care of the dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:56:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:56:02 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #4 from Katrin Fischer --- The problem also exists in the more complete es-ES translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:56:15 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |frederic at tamil.fr Component|Searching |I18N/L10N Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:57:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:57:43 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 --- Comment #14 from Jonathan Druart --- Created attachment 35894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35894&action=edit [3.18.x] Bug 13352: On editing, prices should not be formatted Bug 12979 refactored the way to display prices. The price format configuration was duplicated everywhere it was used. All calls looks good except the one in admin/aqbudgetperiods.pl In this one, the prices are formatted for an edition field (input). This means the input is incorrectly filled even if the user does not update the field. At the end, maybe should we manage formatted prices everywhere, even in inputs, but it's not in the scope of this bug. Technically, a new subroutine format_for_editing is added to the Koha::Number::Price module. It should be called everywhere a price is displayed in an input field. At the moment, it only does a sprintf("%.2f"), but it is a first step to let the number of decimals to display configurable. To test: 1/ Verify the issue described is fixed (editing a budget with a total amount > 1000 (With CurrencyFormat is US or FR). 2/ Verify you can edit a fund with a total amount > 1000 Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:57:56 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 --- Comment #15 from Jonathan Druart --- Created attachment 35895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35895&action=edit [3.18.x] Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:58:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:58:38 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #58 from Julian Maurice --- I always have the same error while running the script: oAuth error: Unsupported Used attribute (114) Any Bib-1 Examples: perl misc/migration_tools/dedup_records.pl -t -v -a -r --match=he/200a Query: @or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "X" (where X is the content of 200$a) perl misc/migration_tools/dedup_records.pl -t -v -a -r --match=at/152b Query: @or @attr 7=1 @attr 4=109 @attr 1=Local-Number 0 @attr 1=Any @attr 4=1 @attr 5=100 @attr 6=3 "X" (where X is 152$b) Also, the documentation says we could use --match=he/2..a but it doesn't seem to work (no zebra query is launched) Changing status to Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 09:58:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 08:58:58 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #13) > Hi, I just tested on 3.18.3 - editing funds is ok, but the problem occurs > for the budget. Yes, you are right, the patches are needed in 3.18.x (because of bug 12844). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 10:02:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 09:02:06 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 10:17:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 09:17:02 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #8 from Jonathan Druart --- Please provide a detailed test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 10:24:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 09:24:07 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #9 from Jonathan Druart --- This bug depends on bug 12272 and bug 13563, does the enh can be tested checking out the branch on github? Testing with the angular-submit branch: The checkout table looks broken and there are no action buttons (circ/checkout.pl), that means this patch adds a 3rd place where this table is defined. Maybe it could be good to refactor some code here. Still got the error 500. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 10:41:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 09:41:01 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEPENDS ON 13019] There is |There is no package for |no package for authorised |authorised values. |values. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 10:41:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 09:41:08 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEPENDS ON 13019] Add |Add additional sound |additional sound options |options for warnings |for warnings | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 10:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 09:42:28 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #5 from Julian Maurice --- I think there is two different ways to fix this: 1/ Fix tmpl_process3.pl to put the same quotes (single or double) as in the original file 2/ exclude includes/catalogue/itemsearch_item.json.inc from the list of files to translate (by changing its extension ?) and use Koha::I18N for translatable text in this file My preferences goes to 2. What do you think ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 10:53:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 09:53:42 +0000 Subject: [Koha-bugs] [Bug 13707] New: Adding a new column datereceived for items and biblioitems Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Bug ID: 13707 Summary: Adding a new column datereceived for items and biblioitems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org This column tells when the Item or Biblio has been received for the first time into a library. Date-of-acquisition (dateaccessioned) answers, when the Item has been ordered. Date-of-receival (datereceived) answers, when the Item has arrived to the library or when the first Item for the Biblio has for the first time arrived to the library. This is very useful regarding statistics of acquisitions if they are based on the date received instead of the date acquired. Also other cool stuff can be built on top of it, like better searches for new material. This patch adds new DB columns items.datereceived, biblioitems.datereceived, deleteditems.datereceived, deletedbiblioitems.datereceived and populates those columns from the acorders.datereceived if the Item has been acquired using the acquisitions module, or from the items.dateaccessioned-column if no acquisitions module has been used. Biblioitems.datereceived is always the oldest timestamp from all the Items the Biblio has. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 10:57:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 09:57:52 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #6 from Julian Maurice --- Template parsing is done by HTML::Parser and I can't find in the doc how to know if attributes values were specified with single or double quotes. So maybe (1) is not even a solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 11:24:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 10:24:50 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #2 from Zeno Tajoli --- Hi, I think that the best option now is to edit biblio-koha-indexdefs.xml and generate biblio-zebra-indexdefs.xsl from that. But I ask about this topic in koha-dev: http://lists.koha-community.org/pipermail/koha-devel/2015-February/041178.html Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 11:32:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 10:32:05 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #3 from Magnus Enger --- Thanks! Feel free to do the patch if you want. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 11:32:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 10:32:34 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #7 from Katrin Fischer --- Hm, What about 3)? Could we rewrite the file in a way, that will avoid the multiple quotes? Like building the string separately and then using a variable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 11:33:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 10:33:42 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #8 from Katrin Fischer --- I think changing the file ending would work - I have used this trick to avoid auto-translations in some other place in the past. But not a 'nice' solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 11:58:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 10:58:47 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 12:28:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 11:28:15 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #9 from Julian Maurice --- (2) will fail anyway, in case the translated string contains single quotes ... :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 12:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 11:56:15 +0000 Subject: [Koha-bugs] [Bug 13708] New: MARC Mapping Item columns to several MARC Fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 Bug ID: 13708 Summary: MARC Mapping Item columns to several MARC Fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Because we have ran out of MARC subfield codes, we cannot add more Item-columns from the DB to the search indexable MARC Record. This patch enables support for "Koha to MARC mapping" to work on other Fields as well. This patch enables editing Items' columns mapped to non-standard MARC Items Fields. No further issues regarding using non-standard Item fields identified yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:00:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:00:13 +0000 Subject: [Koha-bugs] [Bug 13708] MARC Mapping Item columns to several MARC Fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35896&action=edit Bug 13708 - MARC Mapping Item columns to several MARC Fields Because we have ran out of MARC subfield codes, we cannot add more Item-columns from the DB to the search indexable MARC Record. This patch enables support for "Koha to MARC mapping" to work on other Fields as well. This patch enables editing Items' columns mapped to non-standard MARC Items Fields. No further issues regarding using non-standard Item fields identified yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:00:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:00:52 +0000 Subject: [Koha-bugs] [Bug 13703] batchRebuildBiblioTables.pl should also update from database to MARC Record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13703 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:00:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:00:59 +0000 Subject: [Koha-bugs] [Bug 13702] Subroutine to check if a Biblio exists or is deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13702 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:01:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:01:14 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:01:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:01:19 +0000 Subject: [Koha-bugs] [Bug 13708] MARC Mapping Item columns to several MARC Fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:37:20 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #10 from Julian Maurice --- Created attachment 35897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35897&action=edit Bug 13700: Fix item search templates for translation Since translator rebuild HTML tags with double quotes for attributes values, use double quotes in english template too and escape them with backslash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:37:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:37:33 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:43:42 +0000 Subject: [Koha-bugs] [Bug 13708] MARC Mapping Item columns to several MARC Fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- We have used Uppercase letters successfully for some things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:43:59 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #58 from Kyle M Hall --- (In reply to Tom?s Cohen Arazi from comment #57) > Patchset pushed to master. > > Thanks Kyle, Jonathan and Marcel! Documentation for using Koha::Object and Koha::Objects can be found on the community wiki ( http://wiki.koha-community.org/wiki/Koha_Objects ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:45:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:45:55 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 --- Comment #11 from Katrin Fischer --- Yay! Thx Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:53:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:53:11 +0000 Subject: [Koha-bugs] [Bug 13708] MARC Mapping Item columns to several MARC Fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 --- Comment #3 from Olli-Antti Kivilahti --- Thanks for the comment! What do you mean with "some" things? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:54:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:54:54 +0000 Subject: [Koha-bugs] [Bug 13708] MARC Mapping Item columns to several MARC Fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 --- Comment #4 from Olli-Antti Kivilahti --- Also I have a feeling that MARC standard has only lowercase subfield codes? I don't know for sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 13:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 12:56:50 +0000 Subject: [Koha-bugs] [Bug 13708] MARC Mapping Item columns to several MARC Fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 --- Comment #5 from Katrin Fischer --- Storing additional item related information - Koha seems to deal with it well, although you might be right about the standard :) I know we have uppercase subfield codes in some of the data we receive as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 14:01:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 13:01:50 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #42 from Julian Maurice --- So you have the correct borrowernumber in aqorders.created_by, but "No name" is displayed on orderreceive.pl ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 14:01:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 13:01:50 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 14:12:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 13:12:09 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 14:12:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 13:12:12 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35807|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 35898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35898&action=edit [PASSED QA] Bug 12911 - batch_id for new labels batches can be asssigned to several batches Currently batch_id is assigned upon creation of a new batch object. This patch leaves batch_id as 0 at creation and adds a check when adding items. If batch is new then batch_id is created then Test plan: 1 -In one browser window, go to tools->label creator and click the new batch button 2 - Before adding items, open a new browser, and go tools->label creator and click the new batch button 3 - Note that both batches have the same number listed 4 - Add an item to the first batch - you should now see one item in the batch 5 - Add an item to the second batch, you should see two items in the batch 6 - Apply patch and repeat steps 1&2 7 - Note that neither batch lists a batch number 8 - Add an item to the first batch, you should see one item and a batch number 9 - Add an item to the second batch, you should see one item and a new batch number Patch behaves as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 14:49:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 13:49:26 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35897|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 35899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35899&action=edit [SIGNED-OFF] Bug 13700: Fix item search templates for translation Since translator rebuild HTML tags with double quotes for attributes values, use double quotes in english template too and escape them with backslash. Signed-off-by: Bernardo Gonzalez Kriegel It works well!! Test: 1) Intall translation (de-DE, es-ES) 2) to Go to item search, in english, do a search that gives results 3) Switch language, repeat search, result's table does not render 4) Apply patch 5) Install translation again 6) Repeat 3, now results are displayed No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 14:49:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 13:49:44 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:19:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:19:54 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:19:58 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35738|0 |1 is obsolete| | Attachment #35739|0 |1 is obsolete| | Attachment #35740|0 |1 is obsolete| | Attachment #35741|0 |1 is obsolete| | Attachment #35742|0 |1 is obsolete| | --- Comment #72 from Kyle M Hall --- Created attachment 35900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35900&action=edit [PASSED QA] Bug 8064: Merge several biblios This patch improves the existing merging tool by adding possibility to merge more than 2 biblios. There is no functional changes: - Add some biblios to a list - In the list check some biblios and click on 'Merge selected records' - Choose the biblio which will be kept, all others will be deleted - On the next page you have all biblios you chose in tabs (left side of the screen) and the preview of result (right side) - Pick some fields or subfields from records that will be deleted or delete some fields from reference record. - Click on 'Merge', if there is no errors you are redirected to the biblio view. Added checks for non-repeatable subfields Added checks for mandatory fields and subfields before submitting the form. Added a final report which display deleted records (see syspref MergeReportFields) Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:20:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:20:30 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #73 from Kyle M Hall --- Created attachment 35901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35901&action=edit [PASSED QA] Bug 8064: Change the way target record is built. Instead of copying/removing a piece of DOM in target record each time a checkbox is checked/unchecked, the target record is *entirely* rebuilt each time a checkbox is checked/unchecked. This is slower but allow for a more consistent and less error-prone behaviour. This patch also fix the mandatory check for subfields Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:20:35 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #74 from Kyle M Hall --- Created attachment 35902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35902&action=edit [PASSED QA] Bug 8064: Fix issues with control fields and non-repeatable check Fields < 010 were systematically unchecked during target rebuild because they have no subfields (unchecking manually all subfields of a field automatically uncheck the field) When user check a field or a subfield, we have to uncheck it before calling (sub)field_can_be_added. Otherwise, field is treated as if it was already in target record, and this is a problem for non-repeatable fields. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:20:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:20:39 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #75 from Kyle M Hall --- Created attachment 35903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35903&action=edit [PASSED QA] Bug 8064: Little fix for 003, 005, 008 in MARC21 I found a little bug in the patch. Subfield '@' of tags 003, 005, 008 in MARC21 were not correctly handled by function check_mandatory() in merge.tt. I fixed the problem. In my opinion, the patch can be signed off. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:20:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:20:43 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #76 from Kyle M Hall --- Created attachment 35904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35904&action=edit [PASSED QA] Bug 8064: Fix unit tests for createMergeHash Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:20:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:20:47 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #77 from Kyle M Hall --- Created attachment 35905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35905&action=edit [PASSED QA] Bug 8064 [QA Followup] - Remove trailing whitespace Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:26:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:26:12 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #78 from Kyle M Hall --- QA Note: holds are merged in a very odd, un-good way, but the behavior exists on master, so the issue predates this patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:36:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:36:08 +0000 Subject: [Koha-bugs] [Bug 13709] New: Patron cards creator doesn't work with diacritics, utf-8 or ttf fonts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709 Bug ID: 13709 Summary: Patron cards creator doesn't work with diacritics, utf-8 or ttf fonts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org Bug 8375 introduced ttf fonts for labels printing to support diacritics and utf-8 encoding, but this change was never implemented for patron cards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:42:14 +0000 Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with diacritics, utf-8 or ttf fonts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 15:42:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 14:42:17 +0000 Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with diacritics, utf-8 or ttf fonts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 35906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35906&action=edit Bug 13709 - Patron cards creator utf-8 encoding and ttf fonts broken This change is similar to Bug 8375 which introduced ttf fonts for labels printing in order to support diacritics and utf-8 encoding, but this change was never implemented for patron cards. Test scenario: 1. make sure that you have font mapping in koha-conf.xml 2. define partron card layout, template, profile and batch (with utf-8 chars, probably in patron firstname or surname) 3. verify that without this patch pdf export file is error message Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820 4. apply this patch and verify that generated pdf has correct encoding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 16:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 15:10:16 +0000 Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with diacritics, utf-8 or ttf fonts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica at ffzg.hr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 16:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 15:22:05 +0000 Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with diacritics, utf-8 or ttf fonts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 16:40:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 15:40:29 +0000 Subject: [Koha-bugs] [Bug 13708] MARC Mapping Item columns to several MARC Fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED --- Comment #6 from Olli-Antti Kivilahti --- Katrin, thanks for the tip. I'l ltry your suggestion. The additems.pl is such an ridiculous mess any modifications I would make would make it even worse. The remnants of MARC:ified Items need bo be better encapsulated instead of thrown around in every conceivable file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 16:43:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 15:43:05 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Brooksml changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jerry at brookslibraryvt.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 16:46:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 15:46:24 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35899|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 35907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35907&action=edit [PASSED QA] Bug 13700: Fix item search templates for translation Since translator rebuild HTML tags with double quotes for attributes values, use double quotes in english template too and escape them with backslash. Signed-off-by: Bernardo Gonzalez Kriegel It works well!! Test: 1) Intall translation (de-DE, es-ES) 2) to Go to item search, in english, do a search that gives results 3) Switch language, repeat search, result's table does not render 4) Apply patch 5) Install translation again 6) Repeat 3, now results are displayed No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 16:46:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 15:46:22 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 16:58:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 15:58:04 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35908&action=edit Bug 13707 - Adding a new column datereceived for items and biblioitems. Value accessors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:07:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:07:32 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 35909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35909&action=edit Bug 13707 - Adding a new column datereceived for items and biblioitems. New sortable Zebra index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:09:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:09:29 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 35910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35910&action=edit Bug 13707 - Adding a new column datereceived for items and biblioitems This column tells when the Item or Biblio has been received for the first time into a library. Date-of-acquisition (dateaccessioned) answers, when the Item has been ordered. Date-of-receival (datereceived) answers, when the Item has arrived to the library or when the first Item for the Biblio has for the first time arrived to the library. This is very useful regarding statistics of acquisitions if they are based on the date received instead of the date acquired. Also other cool stuff can be built on top of it, like better searches for new material. This patch adds new DB columns items.datereceived, biblioitems.datereceived, deleteditems.datereceived, deletedbiblioitems.datereceived and populates those columns from the acorders.datereceived if the Item has been acquired using the acquisitions module, or from the items.dateaccessioned-column if no acquisitions module has been used. Biblioitems.datereceived is always the oldest timestamp from all the Items the Biblio has. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:16:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:16:30 +0000 Subject: [Koha-bugs] [Bug 13703] batchRebuildBiblioTables.pl should also update from database to MARC Record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13703 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35877|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 35911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35911&action=edit Bug 13703 - batchRebuildBiblioTables.pl should also update from database to MARC Record. When adding a new column to biblio or biblioitems and populating it with legacy data, the MARC Record needs to be updated to match the values in DB, so they can be indexed for searching. Upgrading the batchRebuildBiblioTables.pl -script to make updates upstream (DB columns to MARC Record) and downstream (MARC Record to DB columns), based on the "Koha to MARC mappings". Also improves the batchRebuildBiblioTables.pl -script's documentation and parameter handling. TEST PLAN: 1. Add a new column to biblio or biblioitems-tables. 2. Map the column to "Koha to MARC mappings". 3. Define the mapped MARC Field as a new search index to Zebra and all the relevant hassle what comes with defining a new search index. 4. Populate legacy data to the new DB column. 5. Run the batchRebuildBiblioTables.pl to update the MARC Records from the new DB column. 6. Reindex the whole DB. 7. Make searches from your new index. 8. Split hairs :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:21:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:21:50 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #9 from Kyle M Hall --- (In reply to Tom?s Cohen Arazi from comment #8) > I'm failing this one, even though I attached a followup so the author checks > both the followup and the POD I added. > > It should be clear which barcode 'types' we support, and they should be > added to the dependencies if needed. For instance, I'm not sure we might add > GD::Barcode to the dependencies. > > I tried with GD::Barcode:::QRcode and GD::Barcode::UPCE, and it works fine. > > I tested using an empty barcode number to generate an error. > > Please revisit and sign if it is ok, but at least the POD should be ammended. All the barcode types are part of the GD::Barcode module with the exception of Code93 which is used by the Canadian postal server. As such, I've left it out of the list for simplicity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:22:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:22:26 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #12 from Kyle M Hall --- Created attachment 35914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35914&action=edit Bug 13545 [QA Followup] - Complete POD documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:22:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:22:14 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35325|0 |1 is obsolete| | Attachment #35806|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 35912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35912&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image Signed-off-by: Brandon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:22:12 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:22:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:22:24 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #11 from Kyle M Hall --- Created attachment 35913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35913&action=edit Bug 13545: (followup) POD and error handling This patch adds POD to the new /svc/barcode service, and also implements some error handling. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:23:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:23:02 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35914|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 35915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35915&action=edit Bug 13545 [QA Followup] - Complete POD documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:31:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:31:53 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #28 from Kyle M Hall --- My opinion is that these two sections of Koha have little to do with each other. They aren't even in the same sections! One is in tools, the other in administration. As such, I feel that is more appropriate to keep the behaviors as two separate preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:37:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:37:17 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:39:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:39:41 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35747|0 |1 is obsolete| | --- Comment #38 from Paola Rossi --- Created attachment 35916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35916&action=edit [SIGNED OFF] Bug 8995: Show OpenURL links in OPAC search results The new sysprefs are 5: NB - OPACShowOpenURL: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link NB - OPACOpenURLItemTypes: List of item type codes (separated by spaces) for those you want to show the OpenURL link Link is displayed as an image if OpenURLImageLocation is defined. Link is displayed as an text if OpenURLText is defined. If neither OpenURLImageLocation nor OpenURLText are defined, link is displayed as the text "OpenURL". If either OpenURLImageLocation or OpenURLText are defined, link is displayed as an image whose title-text is the OpenURLText text. I've applied the patch against master 3.19.00.011 The patch contains "3.17.00" and needs to be rebased trivially. Soon after upgrading, and having set the sysprefs to enable OpenURL, I re-indexed zebra. Everything is OK as required. So I pass the patch to "Signed OFF" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 17:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 16:47:21 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #22 from Kyle M Hall --- Starting with a fresh database with all sample data. 1) t/db_dependent/HoldsQueue.t passes on master 2) t/db_dependent/HoldsQueue.t passes with bug 12803 pre-updatedatabase.pl 3) t/db_dependent/HoldsQueue.t passes with bug 12803 post-updatedatabse.pl I have no idea where to go from here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 18:13:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 17:13:13 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 18:13:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 17:13:40 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 18:14:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 17:14:11 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #38 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 18:14:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 17:14:45 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 18:22:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 17:22:31 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #43 from Paola Rossi --- I've applied the patches against master 3.19.00.010 head 13189. I've upgraded the DB. I've run misc/devel/update_dbix_class_files.pl : it was OK. The DB was OK for existing and new orders. On parcel.pl the "More" Order was OK for existing and new orders. (In reply to Julian Maurice from comment #42) > So you have the correct borrowernumber in aqorders.created_by, yes, >but "No name" is displayed on orderreceive.pl ? yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 18:34:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 17:34:14 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35909|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 35917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35917&action=edit Bug 13707 - Adding a new column datereceived for items and biblioitems. New sortable Zebra index. For new Biblios, this feature is automatically enabled, but if you want to make your existing biblios searchable, you must update your MARC Records from the koha DB. The easiest way is to run 'misc/batchRebuildBiblioTables.pl --upstream' to update your MARC Records from the koha DB, but you need to have Bugg 13703 deployed. After that Zebra needs to be fully reindexed. TEST PLAN: (index search) 1. Add a new Biblio. 2. Add an Item to it, either via the acquisitions module or the cataloguing module. 3. Reindex zebra partially with the "./rebuild_zebra.pl -b -z -v" or wait a while if automatic Zebra indexing is enabled in your environment. 4. Make the following search to the search box: datereceived=2015-12-04 where the Date is the day when you added those Items from step 2. (should be today) 5. You should find the Biblio you just added. TEST PLAN: (sorting search) 0. You need to prepare a searchable index of Records with the datereceived indexed. The easiest way is to use the batchRebuildBiblioTables.pl but some records can be manually created as well. M. Manual path: M.1. Add new Biblios, and Items to the using the cataloguing module's additems.pl. You can set the datereceived from the Item-form, so set some Items to past and some Items to have a datereceived in the future. Be aware that the first Item created sets the Parent Biblio's datereceived. M.2. Make a search which should find all the Biblios you manually made. ALL PATHS 3. Sort based on the datereceived (Receival date - Newest to oldest) 4. All the Records should be ordered with the most newly received Biblio on top. Note: Since we can only put Dates to Zebra, sorting is only based on the day-portion of the datereceived. The time-portion is only for potential statistical/logistical optimization reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 18:57:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 17:57:50 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #23 from Tom?s Cohen Arazi --- I have an Ubuntu 14.04 (amd64) box, all stock (I only have the koha repo, and the git ppa for the latest git). What I did was: - > DROP DATABASE koha_devel; CREATE DATABASE koha_devel; - Went through the install process, all default data loaded. - Run $ prove t/db_dependent/HoldsQueue.t => SUCCESS: all green - Applied the patches (small rebase for updatedatabase.pl) - Run $ perl installer/data/mysql/updatedatabase.pl Upgrade to 3.19.00.XXX done (Bug 12803 - Add ability to skip closed libraries when generating the holds queue) - Run $ prove t/db_dependent/HoldsQueue.t => FAIL: t/db_dependent/HoldsQueue.t .. 23/23 # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 327. # got: '1' # expected: '2' # Looks like you failed 1 test of 23. t/db_dependent/HoldsQueue.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/23 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 256 Tests: 23 Failed: 1) Failed test: 23 Non-zero exit status: 1 Files=1, Tests=23, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.49 cusr 0.06 csys = 1.57 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 20:11:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 19:11:05 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #33 from Kyle M Hall --- Created attachment 35918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35918&action=edit Bug 12933 [QA Followup] - Remove Template plugin and use thereof -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 20:11:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 19:11:29 +0000 Subject: [Koha-bugs] [Bug 13710] New: add column for patron category on overdue report (overdue.pl) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13710 Bug ID: 13710 Summary: add column for patron category on overdue report (overdue.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi, It would be fine to see patron category on overdue circulation report (/cgi-bin/koha/circ/overdue.pl) It should be a column you can sort on. Thanks. Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 20:42:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 19:42:55 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 --- Comment #2 from Nick Clemens --- I tried testing but cannot recreate Patron has items due: 2 days ago, yesterday, today, and 2 weeks in future Notice triggers at 1,5 and 10 days Running script with -csv and I only see the two overdues I checked the message queue and see the same there testing on kohadevbox -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 20:59:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 19:59:33 +0000 Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #7 from Mirko Tietgen --- Any reason why this is still listed as ?needs signoff?? Tomas: did you just forget to change the status? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 22:19:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 21:19:34 +0000 Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Needs Signoff |Signed Off --- Comment #8 from Tom?s Cohen Arazi --- (In reply to Mirko Tietgen from comment #7) > Any reason why this is still listed as ?needs signoff?? > > Tomas: did you just forget to change the status? I did, I'm sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 13 23:08:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Feb 2015 22:08:05 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Brendan Gallagher --- Hello Jonathan I run this through the qa script and find errors. Global symbol "$to_address" requires explicit package name BEGIN failed--compilation aborted Compilation failed in require That happens in multiple spots. I did remember to run updatadatebase and I have all dependencies. If this is something that I don't have right - just let me know. Thanks, Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 07:57:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 06:57:36 +0000 Subject: [Koha-bugs] [Bug 11954] Clean up currency default files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11954 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 08:11:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 07:11:45 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #37 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 08:23:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 07:23:30 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #15 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 08:28:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 07:28:21 +0000 Subject: [Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 08:31:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 07:31:19 +0000 Subject: [Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 08:38:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 07:38:13 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #39 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 08:59:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 07:59:29 +0000 Subject: [Koha-bugs] [Bug 13636] Search results item status incorrect for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13636 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 09:12:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 08:12:18 +0000 Subject: [Koha-bugs] [Bug 13335] Holds and priority display via OPACShowHoldQueueDetails confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13335 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushes to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 09:15:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 08:15:59 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 09:19:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 08:19:27 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- holding until unit tests are pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 09:24:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 08:24:09 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #18 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 09:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 08:28:34 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 16:39:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 15:39:52 +0000 Subject: [Koha-bugs] [Bug 13711] New: can't call "fields" on undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 683. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13711 Bug ID: 13711 Summary: can't call "fields" on undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.p l line 683. Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 35919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35919&action=edit koha-error_log showing what happened This fails with the subject error when running on openSUSE built from the tar file for 3.18.03. It works on a Debian based systems installed from the Debian package. Steps to show the bug on a system built from the tar release 1. Go to cataloging 2. Create a book to add 3. Save it Attached is the section of /var/log/koha/koha-error_log with the 'CGI::param called in list context' errors removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 16:40:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 15:40:17 +0000 Subject: [Koha-bugs] [Bug 13711] can't call "fields" on undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 683. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13711 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 18:19:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 17:19:05 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 18:19:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 17:19:08 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35758|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 35920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35920&action=edit [PASSED QA] Bug 13684: C4::Budgets should not be used in C4::Output Bug 12844 removed the call to C4::Budgets::GetCurrency. The use of this module can be completely removed from C4::Output. Signed-off-by: Tomas Cohen Arazi It makes sense and no runtime errors found. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 14 18:45:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Feb 2015 17:45:58 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- If the patron doesn't have any tools permission, you have to log in again after uploading the file. I think this is because upload-file-progress.pl still requires the tool permission. Are we sure those files are only used for the offline circulation file upload? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 15 06:53:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Feb 2015 05:53:32 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #17 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 thanks for the 3.18.x patches Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 15 17:59:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Feb 2015 16:59:04 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #4 from Zeno Tajoli --- Created attachment 35921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35921&action=edit Patch for MARC21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 15 18:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Feb 2015 17:01:06 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #5 from Zeno Tajoli --- Created attachment 35922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35922&action=edit Patch for Normarc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 15 18:04:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Feb 2015 17:04:10 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Zeno Tajoli --- To test on MARC21: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records To test on Normarc: the same as MARC21, but you need a Normarc setup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 09:03:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 08:03:57 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #7 from Magnus Enger --- (In reply to Zeno Tajoli from comment #2) > Hi, > > I think that the best option now is to edit biblio-koha-indexdefs.xml and > generate biblio-zebra-indexdefs.xsl from that. > > But I ask about this topic in koha-dev: > http://lists.koha-community.org/pipermail/koha-devel/2015-February/041178. > html Tomas answered this on the mailing list, I'm pasting in the answer here for future reference: --- The existence of biblio-koha-indexdefs.xml is not related to GRS-1 right now. It might have been (for a while) a way to transform the record.abs file into something translatable to XSLT. But it is a more useful thing now. The XML file provides with a user-friendly syntax for defining indexes (and now also facets). The etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl file is designed to process that syntax for creating a suitable XSLT for use in DOM. So, if you want to change some indexes, or facet definitions: do it on the XML file. If you want to change the behaviour of DOM indexing (for example, you could want to generate an index for the 'availability' filter on each record, so it is calculated on indexing time instead of complex un-doable PQF queries), then you should patch the meta-XSLT (koha-indexdefs-to-zebra.xsl) so it generates an XSLT that generates that specific index out of a MARCXML record. It's been a while since we stopped re-generating the DOM files from the GRS-1, as we've been forcing people to fix both GRS-1 *and* DOM each time. Hope this clarifies the landscape. Regards Tomas http://lists.koha-community.org/pipermail/koha-devel/2015-February/041179.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 09:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 08:23:15 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 --- Comment #3 from Jonathan Druart --- Did you launch with or without the -t parameter? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 09:56:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 08:56:54 +0000 Subject: [Koha-bugs] [Bug 13712] New: Missing newline in DB update 3.19.00.010 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Bug ID: 13712 Summary: Missing newline in DB update 3.19.00.010 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The DB update in updatedatabase.pl looks like this: 9755 $DBversion = "3.19.00.010"; 9756 if ( CheckVersion($DBversion) ) { 9757 $dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('SessionRestrictionByIP','1','Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.','','YesNo')"); 9758 print "Upgrade to $DBversion done (Bug 5511 - SessionRestrictionByIP)"; 9759 SetVersion ($DBversion); 9760 } The missing newline at the end of line 9758 means that when you run the webinstaller, this update and the next one are displayed on one line/as one bullet point: * Upgrade to 3.19.00.009 done (Bug 13007 - Add new foreign key suggestions.budgetid) * Upgrade to 3.19.00.010 done (Bug 5511 - SessionRestrictionByIP)Upgrade to 3.19.00.011 done (Bug 13417: Add permission to delete public lists) Not a big deal, of course, but it would look better on two lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 10:35:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 09:35:46 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35922|0 |1 is obsolete| | --- Comment #8 from Magnus Enger --- Created attachment 35923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35923&action=edit Bug 12948 - [SIGNED-OFF] Patch-for-filter-language-in-Advanced-Search This patch is for Normarc Same test plan as patch for MARC21, except you need a setup with Normarc. http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger - Added a record with "bul" in 008pos35-37 - Verified that this did not turn up in an advanced search with language = Bulgarian - Applied the patch - I was testing on a gitified install, so I had to copy the patched index file to the right location with this command: sudo cp etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl - Did a full reindex - Verified that the record *did* turn up in an advanced search with language = Bulgarian - Signing off! Thanks Zeno! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 10:39:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 09:39:25 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 10:39:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 09:39:28 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35921|0 |1 is obsolete| | --- Comment #9 from Magnus Enger --- Created attachment 35924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35924&action=edit Bug 12948 - [SIGNED-OFF] Patch for filter 'language' in Advanced Search. This patch is for MARC21. To test: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger I have *not* actually tested this, but the changes are identical to the ones done for NORMARC, which I have tested, so I think it is safe to sign off. If anyone disagrees, please reset the bug to "Needs signoff". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 10:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 09:54:05 +0000 Subject: [Koha-bugs] [Bug 13712] Missing newline in DB update 3.19.00.010 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 10:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 09:54:08 +0000 Subject: [Koha-bugs] [Bug 13712] Missing newline in DB update 3.19.00.010 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 --- Comment #1 from Magnus Enger --- Created attachment 35925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35925&action=edit Bug 13712 - Missing newline in DB update 3.19.00.010 To test: - Make sure your database is pre 3.19.00.010 (for example by loading in an older backup) - Run through the web-based database update (web installer, step 3) - Verify that updates 3.19.00.010 and 3.19.00.011 are squashed together on one line - Apply the patch - Reset the database and run the web-based database upgrade again - Verify that the two uupdates are noe displayed on separate lines (as separate bullet points) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 11:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 10:09:14 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 11:09:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 10:09:18 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35890|0 |1 is obsolete| | Attachment #35891|0 |1 is obsolete| | Attachment #35892|0 |1 is obsolete| | Attachment #35893|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 35926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35926&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 11:09:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 10:09:34 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #25 from Jonathan Druart --- Created attachment 35927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35927&action=edit Bug 12802: Sent notices using several email addresses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 11:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 10:09:41 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #26 from Jonathan Druart --- Created attachment 35928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35928&action=edit Bug 12802: FIX use the first valid email address if noemail is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 11:09:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 10:09:50 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #27 from Jonathan Druart --- Created attachment 35929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35929&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 11:10:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 10:10:07 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #28 from Jonathan Druart --- Created attachment 35930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35930&action=edit Bug 12802: Fix QA script issues FAIL C4/Reserves.pm FAIL pod Spurious =cut command in file C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 11:11:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 10:11:03 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #29 from Jonathan Druart --- (In reply to Brendan Gallagher from comment #23) > Hello Jonathan > > I run this through the qa script and find errors. > > Global symbol "$to_address" requires explicit package name > BEGIN failed--compilation aborted > Compilation failed in require Sorry about that, I did not launch the qa script before submitting :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 11:20:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 10:20:31 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 --- Comment #4 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > If the patron doesn't have any tools permission, you have to log in again > after uploading the file. > > I think this is because > upload-file-progress.pl still requires the tool permission. > > Are we sure those files are only used for the offline circulation file > upload? Hum, I was sure I tested that, but actually you are right, the file is used by other scripts: upload-file.pl is used in file-upload.in which is used in - offline_circ/process_koc.tt - tools/stage-marc-import.tt - tools/upload-images.tt So this patch does not fix the problem correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 12:46:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 11:46:36 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 12:46:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 11:46:42 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35432|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 35931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35931&action=edit BUG 13596: Prevent utf8mb4 -> utf8 convertion utf8mb4 is a superset of utf8 and thus is compatible. We should not force an entire db change upon people who have proactively set utf8mb4 encoding before now. This patch also removed the deprecated use of ->tables stanza in favour of the table_info stanza. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:00:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:00:55 +0000 Subject: [Koha-bugs] [Bug 13711] can't call "fields" on undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 683. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13711 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- This seems to be a duplicate of bug 13523. Please reopen if I am wrong. *** This bug has been marked as a duplicate of bug 13523 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:00:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:00:55 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com --- Comment #11 from Jonathan Druart --- *** Bug 13711 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:14:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:14:16 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:14:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:14:19 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35456|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 35932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35932&action=edit Bug 13523 - AddBiblio fails on mysql with STRICT_TRANS_TABLES This patch removes the NOT NULL restriction on biblioitems.marcxml and deletedbiblioitems.marcxml due to STRICT_TRANS_TABLES default in Mysql 5.6.22 and onwards. Test: 1. check mysql global settings: mysql > SELECT @@GLOBAL.sql_mode; verify that STRICT_TRANS_TABLES is not set 2. set STRICT_TRANS_TABLES (or upgrade mysql to > 5.6.21) mysql > SET @@GLOBAL.sql_mode = 'STRICT_TRANS_TABLES'; 3. try to add biblio in Cataloguing module verify that it fails with a "software error" 4. apply patch 5. repeat 3 and verify that there is no "software error" any more Signed-off-by: Jonathan Druart I confirm with the problem with mariadb and STRICT_TRANS_TABLES enabled. On adding a biblio (C4::Biblio::AddBiblio), biblioitems is populate in _koha_add_biblioitem but marxcml is not generated yet. It's in ModBiblioMarc, few lines later. The NOT NULL condition is not valid here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:15:37 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |benjamin.rokseth at kul.oslo.k | |ommune.no CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:30:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:30:37 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, | |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Jonathan Druart --- Is it still valid or can be closed? cc Martin -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:36:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:36:00 +0000 Subject: [Koha-bugs] [Bug 9411] Multiple uses of javascript eval on ajax responses in acq.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #12 from Jonathan Druart --- Hugh, Any chances to see this resubmitted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:46:48 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5366 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:46:48 +0000 Subject: [Koha-bugs] [Bug 5366] Koha does not work right with MariaDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13523 --- Comment #20 from Jonathan Druart --- (In reply to Mason James from comment #6) > Created attachment 13478 [details] [review] > Bug 5366 - Standing enh req for code changes enabling database agnosticism The first patch will be useless with bug 13523. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:48:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:48:50 +0000 Subject: [Koha-bugs] [Bug 5366] Koha does not work right with MariaDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #21 from Jonathan Druart --- Comment on attachment 13480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13480 Bug 5366 - [2/2] Standing enh req for code changes enabling database agnosticism Review of attachment 13480: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5366&attachment=13480) ----------------------------------------------------------------- ::: C4/ImportBatch.pm @@ +1354,1 @@ > A better would be to remove the NOT NULL condition in the DB structure for the import_records table. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:49:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:49:50 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #13 from Jonathan Druart --- Same problem could happen on the import_records table, see bug 5366. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:59:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:59:35 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13601 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 13:59:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 12:59:35 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10995 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 14:13:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 13:13:31 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 14:15:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 13:15:04 +0000 Subject: [Koha-bugs] [Bug 13708] MARC Mapping Item columns to several MARC Fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:10:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:10:15 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35917|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 35933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35933&action=edit Bug 13707 - Adding a new column datereceived for items and biblioitems. New sortable Zebra index. For new Biblios, this feature is automatically enabled, but if you want to make your existing biblios searchable, you must update your MARC Records from the koha DB. The easiest way is to run 'misc/batchRebuildBiblioTables.pl --upstream' to update your MARC Records from the koha DB, but you need to have Bugg 13703 deployed. After that Zebra needs to be fully reindexed. TEST PLAN: (index search) 1. Add a new Biblio. 2. Add an Item to it, either via the acquisitions module or the cataloguing module. 3. Reindex zebra partially with the "./rebuild_zebra.pl -b -z -v" or wait a while if automatic Zebra indexing is enabled in your environment. 4. Make the following search to the search box: datereceived=2015-12-04 where the Date is the day when you added those Items from step 2. (should be today) 5. You should find the Biblio you just added. TEST PLAN: (sorting search) 0. You need to prepare a searchable index of Records with the datereceived indexed. The easiest way is to use the batchRebuildBiblioTables.pl but some records can be manually created as well. M. Manual path: M.1. Add new Biblios, and Items to the using the cataloguing module's additems.pl. You can set the datereceived from the Item-form, so set some Items to past and some Items to have a datereceived in the future. Be aware that the first Item created sets the Parent Biblio's datereceived. M.2. Make a search which should find all the Biblios you manually made. ALL PATHS 3. Sort based on the datereceived (Receival date - Newest to oldest) 4. All the Records should be ordered with the most newly received Biblio on top. Note: Since we can only put Dates to Zebra, sorting is only based on the day-portion of the datereceived. The time-portion is only for potential statistical/logistical optimization reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:24:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:24:39 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 --- Comment #16 from Tom Misilo --- (In reply to Tom?s Cohen Arazi from comment #15) > My followup for bug 13218 broke this one. Could you please rebase? Tom?s what would I need to do in order to rebase this? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:44:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:44:41 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10887 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:44:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:44:41 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |9533 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:46:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:46:59 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:47:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:47:02 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35319|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 35934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35934&action=edit Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:47:21 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:52:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:52:06 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:53:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:53:30 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35700|0 |1 is obsolete| | --- Comment #50 from Paola Rossi --- Created attachment 35935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35935&action=edit Bug 7290: More granular permissions for order receiving I've applied the 3 patches against master 3.19.00.011 head 13603. The first patch needed a trivial rebase. Upgrading the DB, for all the patrons with "order_receive" permission ON the "order_receive_all" permission had been set to ON. Everything is OK as required by the test plan (see comment #37). I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:53:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:53:55 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35701|0 |1 is obsolete| | --- Comment #51 from Paola Rossi --- Created attachment 35936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35936&action=edit Bug 7290: QA fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 15:54:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 14:54:22 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35702|0 |1 is obsolete| | --- Comment #52 from Paola Rossi --- Created attachment 35937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35937&action=edit Bug 7290: Fix CanUserReceiveBasket tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:03:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:03:27 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25387|0 |1 is obsolete| | Attachment #27604|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 35938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35938&action=edit Bug 11317: Adds a page to access log files on the server from the intranet. The directory used is defined by the "publiclogdir" preference in koha-conf.xml. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : ... /tmp/koha-public ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:03:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:03:55 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:03:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:03:58 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #14 from Jonathan Druart --- Created attachment 35939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35939&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:04:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:04:03 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #15 from Jonathan Druart --- Created attachment 35940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35940&action=edit Bug 11317: Rename publiclogdir with publicdir Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:04:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:04:43 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #16 from Jonathan Druart --- I suggest to rename publiclogdir with publicdir. Feel free so obsolete the patch if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:07:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:07:19 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34268|0 |1 is obsolete| | Attachment #34269|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 35941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35941&action=edit Bug 7741: Added Clearing Capability to the Z39.50 Search fields Tested in: /koha/cataloguing/z3950_auth_search.pl (Home:Authorities:New from Z39.50) /koha/cataloguing/z3950_search.pl (Home:Cataloging:New from Z39.50/SRU) /koha/acqui/z3950_search.pl (Home:Acquisitions:[Bookshop]:[Basket]:Order from external source) All three forms can now be cleared. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:07:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:07:26 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 --- Comment #18 from Jonathan Druart --- Created attachment 35942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35942&action=edit Bug 7741 [Follow-up] Clear search terms in Z3950 search page This patch makes a follow-up change and takes as its basis a dependency on Bug 13218 - usability enhancement for z39.50 search. If we have a one-column search form it's possible to put the "Clear search form" link at the bottom of the form rather than in the header, logically associating it with the grouping of form fields which will be affected. Doing so also allows us to eliminate all the custom styling which was an issue for QA. Other changes made by this patch: Fixing the indentation error, correcting the case of the link text ("Clear search form" instead of "Clear Search Form"), and adding "preventDefault()" to the click handler so that clicking the link doesn't scroll the user back to the top of the page. To test, apply the previous patch and this one on top of Bug 13218. Repeat the test plan. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:08:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:08:35 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #19 from Jonathan Druart --- Apply cleanly here, resubmitting... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:10:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:10:50 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 --- Comment #20 from Tom Misilo --- Thank you Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:21:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:21:50 +0000 Subject: [Koha-bugs] [Bug 13506] Sip/Configuration/*.pm classes are unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:21:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:21:53 +0000 Subject: [Koha-bugs] [Bug 13506] Sip/Configuration/*.pm classes are unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34858|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 35943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35943&action=edit Bug 13506: Remove unused Sip/Configuration Classes Sip::Configuration calls new on Account, Institution and Service classes but does not store or subsequently use the returned objects ( which immediately go out of scope ). Their existence just obscures the code and misleads the reader. Remobe them Removed redundant commented out code from Configyration module which was not serving any useful purpose Ran Configuration.pm through perltidy to make layout more consistent Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:22:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:22:37 +0000 Subject: [Koha-bugs] [Bug 13506] Sip/Configuration/*.pm classes are unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- There is 1 occurrence of Sip::Configuration::Institution left in C4/SIP/ILS.pod. Maybe should it be removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:23:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:23:55 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:27:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:27:19 +0000 Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #2 from Jonathan Druart --- Comment on attachment 35318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35318 Bug 13586: Makefile.PL mentions win32 Review of attachment 35318: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13586&attachment=35318) ----------------------------------------------------------------- ::: Makefile.PL @@ -1481,4 @@ > unless exists $skip_directories->{$key}; > } > } > - elsif ($^O eq 'MSWin32' ) { # On Win32, the install probably needs to be done under the user account koha will be running as... What's done in this block should be removed too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:30:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:30:10 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 35944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35944&action=edit Bug 13707 - 1. Adding a new column datereceived for items and biblioitems This column tells when the Item or Biblio has been received for the first time into a library. Date-of-acquisition (dateaccessioned) answers, when the Item has been ordered. Date-of-receival (datereceived) answers, when the Item has arrived to the library or when the first Item for the Biblio has for the first time arrived to the library. This is very useful regarding statistics of acquisitions if they are based on the date received instead of the date acquired. Also other cool stuff can be built on top of it, like better searches for new material. This patch adds new DB columns items.datereceived, biblioitems.datereceived, deleteditems.datereceived, deletedbiblioitems.datereceived and populates those columns from the acorders.datereceived if the Item has been acquired using the acquisitions module, or from the items.dateaccessioned-column if no acquisitions module has been used. Biblioitems.datereceived is always the oldest timestamp from all the Items the Biblio has. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:30:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:30:58 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 --- Comment #7 from Olli-Antti Kivilahti --- Created attachment 35945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35945&action=edit Bug 13707 - 2. Adding a new column datereceived for items and biblioitems. Value accessors. This makes sure that the datereceived-columns are populated, eg the Item and biblio get the date of receival. This happens when an Item is added using the cataloguin/additem.pl or the acqui/finishreceive.pl TEST PLAN: (cataloguing) 1. Add a new Biblio, either via Z39.50 or cataloguing/addbiblio.pl 2. Add an Item for the new Biblio using the cataloguing/additem.pl. This is the default view you get after saving the Biblio. 3. Observe that the new Item has a datereceived-field with current time as the timestamp. 4. Observe that the new Biblio has datereceived populated in the field where you have it mapped to. This defaults to 942$1. TEST PLAN: (acquisitions) 1. Add a new Biblio, either via Z39.50 or cataloguing/addbiblio.pl 2. Add an Item for the new Biblio using the acquisitions workflow. Close the basketgroup. 3. Receive the Item using the acqui/finishreceive.pl. 4. Observe that the new Item has a datereceived-field with current time as the timestamp. 5. Observe that the new Biblio has datereceived populated in the field where you have it mapped to. This defaults to 942$1. TEST PLAN: (break it, after any test path) 10. Receive new Items using both the acquisitions module and the cataloguin module. 11. Observe that Biblio's datereceived-field (942$1) doesn't change, but remains as the value set when receiving the first Item. 12. Observe that each Item gets the original timestamp when it has been received. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:31:28 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 35946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35946&action=edit Bug 13707 - 3. Adding a new column datereceived for items and biblioitems. New sortable Zebra index. For new Biblios, this feature is automatically enabled, but if you want to make your existing biblios searchable, you must update your MARC Records from the koha DB. The easiest way is to run 'misc/batchRebuildBiblioTables.pl --upstream' to update your MARC Records from the koha DB, but you need to have Bugg 13703 deployed. After that Zebra needs to be fully reindexed. TEST PLAN: (index search) 1. Add a new Biblio. 2. Add an Item to it, either via the acquisitions module or the cataloguing module. 3. Reindex zebra partially with the "./rebuild_zebra.pl -b -z -v" or wait a while if automatic Zebra indexing is enabled in your environment. 4. Make the following search to the search box: datereceived=2015-12-04 where the Date is the day when you added those Items from step 2. (should be today) 5. You should find the Biblio you just added. TEST PLAN: (sorting search) 0. You need to prepare a searchable index of Records with the datereceived indexed. The easiest way is to use the batchRebuildBiblioTables.pl but some records can be manually created as well. M. Manual path: M.1. Add new Biblios, and Items to the using the cataloguing module's additems.pl. You can set the datereceived from the Item-form, so set some Items to past and some Items to have a datereceived in the future. Be aware that the first Item created sets the Parent Biblio's datereceived. M.2. Make a search which should find all the Biblios you manually made. ALL PATHS 3. Sort based on the datereceived (Receival date - Newest to oldest) 4. All the Records should be ordered with the most newly received Biblio on top. Note: Since we can only put Dates to Zebra, sorting is only based on the day-portion of the datereceived. The time-portion is only for potential statistical/logistical optimization reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:34:54 +0000 Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #3 from Jonathan Druart --- Created attachment 35947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35947&action=edit Bug 13586: Remove the entire block Previous patch remove the condition but not the block tested. The entire block should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:34:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:34:59 +0000 Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #4 from Jonathan Druart --- Created attachment 35948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35948&action=edit Bug 13586: Remove some other occurrences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:40:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:40:01 +0000 Subject: [Koha-bugs] [Bug 13713] New: Remove useless constraint in Koha::Schema::Result::Biblio Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Bug ID: 13713 Summary: Remove useless constraint in Koha::Schema::Result::Biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org 2 patches need to be moved from bug 11518. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:41:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:41:27 +0000 Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in Koha::Schema::Result::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 --- Comment #1 from Jonathan Druart --- Created attachment 35949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35949&action=edit Bug 13713: WIP - Remove useless constraints previously added This patch removes the 3 constraints added by patch from bug 11518. Having 1-n + 1-1 relations for the same field is a non-sense. Signed-off-by: Marcel de Rooy Added a follow-up for removing some unneeded code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:41:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:41:31 +0000 Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in Koha::Schema::Result::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 --- Comment #2 from Jonathan Druart --- Created attachment 35950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35950&action=edit Bug 13713: Follow-up removing biblioitem routines There is no need to define biblioitem routines, if we can access them via biblioitemnumber. Note that we actually need a FK for biblio in the items table. Now we do need the intermediate level via biblioitems in the Items.t code. Even better, we should move biblioitem to biblio. Formally it is 1-n, but in reality it is 1-1. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:41:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:41:45 +0000 Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in Koha::Schema::Result::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:42:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:42:04 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13713 --- Comment #35 from Jonathan Druart --- 2 last patches moved to bug 13713. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:42:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:42:04 +0000 Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in Koha::Schema::Result::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11518 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:42:44 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:42:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:42:45 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Bug 11703 depends on bug 11518, which changed state. Bug 11518 Summary: Add new method to Koha::Schema::Result::Item that will always return the correct itemtype http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:42:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:42:46 +0000 Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in Koha::Schema::Result::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Bug 13713 depends on bug 11518, which changed state. Bug 11518 Summary: Add new method to Koha::Schema::Result::Item that will always return the correct itemtype http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:43:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:43:12 +0000 Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in Koha::Schema::Result::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:52:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:52:05 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #10 from Olli-Antti Kivilahti --- Created attachment 35951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35951&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC when... - Followup 1 To fix the failing test "ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location." When adding an Item, set the permanent_location to location if present. This behaviour is consistent with ModItem where permanent_location is set to location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:54:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:54:27 +0000 Subject: [Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Fr?d?ric, It would be great to provide a couple of tests to confirm the patch does not introduce any regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:55:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:55:58 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35951|0 |1 is obsolete| | --- Comment #11 from Olli-Antti Kivilahti --- Created attachment 35952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35952&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC when... - Followup 1 To fix the failing test "ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location." When adding an Item, set the permanent_location to location if present. This behaviour is consistent with ModItem where permanent_location is set to location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:57:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:57:36 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Olli-Antti Kivilahti --- Thanks Chris for the sign off! Thanks Joubu for kicking my ass! Followup supplied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 16:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 15:59:20 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #9 from Jonathan Druart --- Could you provide an example of how we could use this module from others Koha modules (C4::*, Koha::*) and scripts (module/*.pl)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 17:00:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 16:00:56 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35952|0 |1 is obsolete| | --- Comment #13 from Olli-Antti Kivilahti --- Created attachment 35953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35953&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC when... - Followup 1 To fix the failing test "ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location." When adding an Item, set the permanent_location to location if present. This behaviour is consistent with ModItem where permanent_location is set to location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 17:02:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 16:02:28 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #34 from Jonathan Druart --- No signoffers interested? This patch could be very useful for developers and pre-production installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 17:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 16:15:44 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #14 from Jonathan Druart --- 1/ FAIL C4/Items.pm FAIL pod *** ERROR: Unknown command 'head' in file C4/Items.pm *** ERROR: Spurious text after =cut in file C4/Items.pm You need an empty line avec the =cut 2/ Please prefer creating a subtest (`git grep subtest t` for examples), instead of a sub, in the test file. 3/ Why do you create a new routine? IMO you should use C4::Items::GetItem($itemnumber)->{permanent_location}. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 17:16:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 16:16:39 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #15 from Jonathan Druart --- You need an empty line avec the =cut means: You need to add an empty line avec the '=cut' in the pod. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 17:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 16:17:24 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #16 from Jonathan Druart --- s/avec/after (hum, I need some fresh air...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 17:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 16:33:41 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #35 from M. Tompsett --- (In reply to Jonathan Druart from comment #34) > No signoffers interested? > > This patch could be very useful for developers and pre-production > installations. Could you post a full and complete test plan, so we don't have to read through the comments? This has been off my radar for while, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 18:14:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 17:14:26 +0000 Subject: [Koha-bugs] [Bug 13714] New: Problems deleting the delay field in overdue triggers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13714 Bug ID: 13714 Summary: Problems deleting the delay field in overdue triggers Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It is not possible to delete the delay field in the overdue triggers policy if it is the last notice tab to be edited. To reproduce: Go to an overdue trigger policy (cgi-bin/koha/tools/overduerules.pl) that contains a delay in the 1st, 2nd and 3rd tabs. Delete all of the values from the delay fields in the first and second tabs. Save changes. Delete the values from the delay fields in the third overdue tab. Save. The changes will not be saved. It does not matter in which order the tabs are edited. If the check boxes are also edited at the same time as the last delay fields are edited, these changes will not be saved either, although they can be saved if the delay fields are not edited. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 19:17:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 18:17:53 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #14 from Bob Ewart --- auth_header, import_items and import_records all have marcxml set as NOT NULL, marcxml_old in import_records is also. New from Z39.50/SRU fails ever time on marcxml_old does not have a default value. Removing the restriction make it work. I'm using Mariadb 10.0.13 on openSUSE 13.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 19:43:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 18:43:37 +0000 Subject: [Koha-bugs] [Bug 13715] New: problem with "limit to items available" with a notice has multiple items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 Bug ID: 13715 Summary: problem with "limit to items available" with a notice has multiple items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Created attachment 35954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35954&action=edit limit_available_items Hi, In OPAC, a record has multiple items, one of which is on loan, when you click on "Limit to items Currently available", record will disappear from result's list while an item has the status Available. Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 19:53:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 18:53:01 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 20:01:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 19:01:20 +0000 Subject: [Koha-bugs] [Bug 13714] Problems deleting the delay field in overdue triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13714 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 21:19:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 20:19:08 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #3) > Did you launch with or without the -t parameter? With -t I only see the item 2 days overdue Without -t I see the items due yesterday and 2 days before. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 21:25:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 20:25:33 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master --- Comment #6 from Nick Clemens --- I am seeing this on master as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 21:33:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 20:33:34 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Status|Needs Signoff |ASSIGNED --- Comment #10 from Magnus Enger --- No patches to sign off at the moment. Viktor: Maybe do a new patch from scratch? :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 22:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 21:01:49 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 22:01:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 21:01:53 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35811|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 35955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35955&action=edit Bug 13682 - Capitalization: Holds Queue This patch changes capitalization of Holds Queue to Holds queue in koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueu$ To test: Apply patch Go to Circulation > Holds queue page Verify that the capitalization is correct Signed-off-by: Magnus Enger Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 22:04:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 21:04:33 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 22:04:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 21:04:37 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #11 from Viktor Sarge --- Created attachment 35956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35956&action=edit Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 22:09:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 21:09:02 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #12 from Viktor Sarge --- Ok - new attempt from a new branch after cleaning out my entire local Git. I don't have very high hopes, but it looks ok and seem to apply without complaints now. Fingers crossed and thanks for the patience. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 22:43:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 21:43:54 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35663|0 |1 is obsolete| | --- Comment #24 from H?ctor Eduardo Castro Avalos --- Created attachment 35957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35957&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML is not well-formed document and do not follows the DC-XML recommendations as should be. New feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Apply patch[es]. 2) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C and OAI-DC can be validated by other validator. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities not found in .deb package -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 22:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 21:45:06 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #13 from Marc V?ron --- Created attachment 35958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35958&action=edit [Signed-off] Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch. Text appears as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 22:46:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 21:46:28 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 16 22:46:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Feb 2015 21:46:46 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 01:50:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 00:50:37 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #10 from Srdjan Jankovic --- There is a number of examples in the POD (patch 1). Also, patches 2 and 3 are supposed to be working implementations. Can you please have a look and tell me if anything needs expanding/reformulating/improving, happy to do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 01:52:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 00:52:26 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #11 from Srdjan Jankovic --- USAGE and ADVANCED USAGE sections in POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 03:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 02:45:04 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 03:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 02:45:39 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 03:46:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 02:46:10 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 03:46:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 02:46:57 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Thomas! And congratulations for your patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 03:47:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 02:47:24 +0000 Subject: [Koha-bugs] [Bug 13684] C4::Output uses C4::Budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13684 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 03:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 02:58:13 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #17 from Tom?s Cohen Arazi --- I think both patches should be used together: in a persistent environment (in the sense of plack-like one-time-load execution) we need a module to take care of reconnections and keep connections open as needed. Caching the database connection object to reuse it, seems ok. But how long? what if the connection drops for some reason? That's when DBIx::Connector proves handy. My only concern was about this approach being kosher or not, and that's why I tried to contact ribasushi on the IRC channel, because it smells like a trivial use case everyone faces when using DBIx::Class :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 04:51:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 03:51:25 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35668|0 |1 is obsolete| | --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 35959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35959&action=edit [PASSED QA] Bug 13645: Cache the DBIx connection We don't want to recreate a new connection to the DB every time we want a new schema. This patch creates a $database package level variable on the same way it's done in C4::Context for $dbh. Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 04:52:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 03:52:09 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35774|0 |1 is obsolete| | --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 35960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35960&action=edit [SIGNED OFF] Bug 13645: Use DBIx::Connector Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 04:52:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 03:52:05 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 05:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 04:01:43 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 05:01:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 04:01:47 +0000 Subject: [Koha-bugs] [Bug 13690] 3.18 performance issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35796|0 |1 is obsolete| | --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 35961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35961&action=edit [SIGNED OFF] Bug 13690: use Koha::Schema only when it's needed Happy to sign this one. The only extra comment would be that DBIx::Class performance issues remain after this patch, but is being handled in a different bug. It makes a lot of sense after reading: http://search.cpan.org/~ribasushi/DBIx-Class-0.082810/lib/DBIx/Class/Schema.pm#load_namespaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 05:03:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 04:03:22 +0000 Subject: [Koha-bugs] [Bug 13690] Koha::Schema should be lazy-loaded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|3.18 performance issues |Koha::Schema should be | |lazy-loaded CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 05:05:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 04:05:18 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Current integration tests rely on Test::WWW::Mechanize. This option seems more interesting, but we should try to think "what" we want to actually test first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 08:39:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 07:39:58 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #10 from Jesse Weaver --- (In reply to Jonathan Druart from comment #9) > This bug depends on bug 12272 and bug 13563, does the enh can be tested > checking out the branch on github? > > Testing with the angular-submit branch: > The checkout table looks broken and there are no action buttons > (circ/checkout.pl), that means this patch adds a 3rd place where this table > is defined. Maybe it could be good to refactor some code here. > > Still got the error 500. Will get you a detailed test plan. We were working on fixing some issues with the checkouts datatable, but any permanent fix will likely depend on Kyle. Yes, the branch should be testable simply by checking out the Github branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 08:48:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 07:48:41 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #63 from Jesse Weaver --- (In reply to Jonathan Druart from comment #62) > What is the status of this one? > Is it still dependent on bug 10486? I would say no, but it's the first step > of the test plan. > Is it UNIMARC compatible? > > I found encoding related issues on saving a record, please have a look. > Also needs a (trivial) rebase. This is no longer dependent on bug 10486, due to removing the dependency on pazpar2 for Z39.50 searching. The code should be UNIMARC (or NORMARC) compatible, all MARC21-exclusive code is properly switched on marcflavour. Much like the rest of Koha, it cannot handle MARC21 and UNIMARC within the same installation. However, there are no fixed field widgets for UNIMARC at the present time. There is support for the XML widget format used for the MARC21 006 and 008 widgets, but no other existing widgets can be used. Could I ask what encoding issues you saw? We've seen similar issues crop up recently after being previously fixed. Rebase is done, working on cleaning up a patch series to be submitted soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 09:09:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 08:09:34 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #64 from Jonathan Druart --- (In reply to Jesse Weaver from comment #63) > Could I ask what encoding issues you saw? We've seen similar issues crop up > recently after being previously fixed. Double-encoded characters, I just edited/saved/showed. Note that I used the patches attached to this bug report, not the branch (based on 3.15). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 09:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 08:28:05 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Tomas, Kyle, Do you confirm the problem existed before this patch (I didn't test)? Because this case should be take into account with another line: if ( q_array[x].length > 0 ) { There have been a lot of other reports for this issue (at least bug 10956, bug 9419 and bug 8646), and this line does not exist at the other places. That makes me think that this patch was unnecessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 09:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 08:37:50 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 --- Comment #5 from Jonathan Druart --- Nick, Yes actually the test plan is not precis enough. The problem comes from the 3rd overdue, so you need something like: - Notice triggers at 1, 5, 10 days - And items due 1, 2 days ago and 11+ (<90) days in the future. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 10:51:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 09:51:04 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Christophe Brocquet changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.brocquet at yahoo.f | |r --- Comment #2 from Christophe Brocquet --- I tested the patch for the 13568 with the following sandbox http://pro.test1.biblibre.com/cgi-bin/koha/sandbox.pl I used the "UNIMARC public library (2) = UNIMARC BM" dataset. 1. First I activated the following system preferences in the staff interface - OAI-PMH : enabled - OAI-PMH:AutoUpdateSets : enabled - OAI-PMH:MaxCount : 500 2. Then I tested with - http://catalogue.test1.biblibre.com/cgi-bin/koha/oai.pl/request?verb=ListIdentifiers&metadataPrefix=marcxml - http://catalogue.test1.biblibre.com/cgi-bin/koha/oai.pl/request?verb=ListRecords&metadataPrefix=marcxml 3. The last resumtionToken which was generated is "marcxml/4500/1970-01-01/2015-02-17/" and the last identifier was "KOHA-OAI-TEST:5000" : after this record there was no more resumptionToken. But it is said here http://koha-fr.org/content/bacs-%C3%A0-sable that the "UNIMARC public library (2) = UNIMARC BM" dataset contains 19000 bibliographical records. So I am not sure the patch works well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:17:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:17:51 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35908|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:18:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:18:10 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35910|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:18:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:18:16 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:26:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:26:09 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 --- Comment #3 from Fr?d?ric Demians --- > 3. The last resumtionToken which was generated is > "marcxml/4500/1970-01-01/2015-02-17/" and the last identifier was > "KOHA-OAI-TEST:5000" : after this record there was no more resumptionToken. > But it is said here http://koha-fr.org/content/bacs-%C3%A0-sable that the > "UNIMARC public library (2) = UNIMARC BM" dataset contains 19000 > bibliographical records. > So I am not sure the patch works well. You could see that without the patch, even asking records with "marcxml/4500/1970-01-01/2015-02-17/" resumption token, you will have a resumption token in the response. The dataset doesn't contain 19000 records but 4848. You can check with this SQL query: SELECT COUNT(*) FROM biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:45:37 +0000 Subject: [Koha-bugs] [Bug 13716] New: On adding recipients/patrons to a routing list, searching fields are filtered in OR instead of AND Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13716 Bug ID: 13716 Summary: On adding recipients/patrons to a routing list, searching fields are filtered in OR instead of AND Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: paola.rossi at cineca.it QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com In Home ? Serials ? [serial title] ? Edit routing list, I'm trying to "Add a recipient[/patron/borrower]" to a Rooting List of a subscription. On /cgi-bin/koha/serials/member-search.pl, the 3 input fields are crossed so: Library AND Category Name OR (Library AND Category) Name OR Library Name OR Category On the contrary I'm expecting this way of building the query: Name AND Library AND Category Name AND Library Name AND Category -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:48:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:48:14 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:48:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:48:14 +0000 Subject: [Koha-bugs] [Bug 13716] On adding recipients/patrons to a routing list, searching fields are filtered in OR instead of AND In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13716 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7957 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:49:51 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #39 from Paola Rossi --- (In reply to Julian Maurice from comment #34) > This search generates a quite long SQL query: http://pastebin.com/qYULAHsm > where the search is done on firstname, surname, email, othernames and > cardnumber. > But basically you're right, it does something like (Name OR (Library AND > Category)) > I don't know if this is intended or not, and as the behaviour is the same as > master, I suggest to open a new bug for that. I opened the new bug 13716 on this topic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:58:13 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Christophe Brocquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:58:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:58:25 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 11:58:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 10:58:37 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 35962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35962&action=edit Bug 13568 OAI Server doesn't handle properly resumption token When responding to ListRecords and ListIdentifiers verbs, OAI server doesn't return proper resumption token. At the end of a result set, OAI server generates a resumption token even if there isn't anymore records. Consequently, OAI harverster will send a new request, based on this invalid resumption, token. OAI Server responds with an empty resultset, which is considered as an invalid response by most of the harvesters. TO TEST: - Find in your DB, a day where a few biblio records have been created. The number of created biblios must inferior to OAI-PMH:MaxCount. - Let say this day is 2014-01-09. Send an OAI-PMH request to Koha OAI Server: /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2014-01-09&until=2014-01-09 - At the end of the result, you will see a resumption token which looks like that: marcxml/47/2014-01-09/2014-01-09/ This is wrong. No resumptiion token should be sent since there isn't anymore records to harvest. - Apply the patch. - Resend the OAI-PMH request. There is no resumption token at the end of the result. - You could test also with ListIdenfiers verb in place of ListRecord. Signed-off-by: Christophe Brocquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 12:08:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 11:08:39 +0000 Subject: [Koha-bugs] [Bug 6513] Library and Category filters when searching for a borrower to add to a routing list don't work correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6513 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13716 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 12:08:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 11:08:39 +0000 Subject: [Koha-bugs] [Bug 13716] On adding recipients/patrons to a routing list, searching fields are filtered in OR instead of AND In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13716 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6513 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 12:17:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 11:17:10 +0000 Subject: [Koha-bugs] [Bug 13716] On adding recipients/patrons to a routing list, searching fields are filtered in OR instead of AND In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13716 --- Comment #1 from Paola Rossi --- See also this comment: bug 6513 #9: >Jonathan Druart 2014-11-10 10:38:03 UTC: >Bug 13021 and bug 12648 use the member search webservice. >When they will be pushed, maybe this one [bug 6513] will be easy to implement >using the same way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 12:25:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 11:25:48 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 --- Comment #7 from Kyle M Hall --- Excellent work! I was able to create a patch based on your fix here! (In reply to Pete Edwards from comment #2) > I'm not familiar enough with Koha to offer a patch but here is a workaround > that is OK for me. > > I had to modify C4::Templates::themelanguage(). For normal pages this is > fine but plugin templates have an absolute path (in $tmpl) so the code to > check for a template in the correct language completely fails: > for my $theme (@themes) { > if ( -e "$htdocs/$theme/$lang/$where/$tmpl" ) { > return ( $theme, $lang, uniq( \@themes ) ); > } > } > Instead, we drop through both loops and come out of the function without any > return. This seems pretty bad practice. At the end of the function I added: > if ($tmpl =~ /^\//) { > return ( $themes[0], $lang, uniq( \@themes ) ); > } > This probably doesn't fix every possible situation, nor do I know about > themes but it might help whoever does try and fix the problem. > > As an aside, it would be better to run uniq on the themes array before > checking for files existing so it reduces the number of times it may try the > wrong location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 12:26:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 11:26:09 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 12:26:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 11:26:12 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 --- Comment #8 from Kyle M Hall --- Created attachment 35963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35963&action=edit Bug 13473 - Plugins fail in 3.18 When trying to execute or configure the plugin on 3.18 I got: Template process failed: file error - doc-head-open.inc: not found at /usr/share/koha/lib/C4/Templates.pm line 129. Test Plan: 1) Install the Kitchen Sink plugin 2) Go to the configuration page of the plugin 3) Note the template processing error 4) Apply this patch 5) Refresh the page 6) Note the page now loads -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 12:26:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 11:26:34 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 12:26:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 11:26:55 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 13:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 12:06:17 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #26 from Kyle M Hall --- Created attachment 35964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35964&action=edit Bug 12598 - Move Koha::Patrons::Import to Koha::Borrower::Import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 13:12:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 12:12:52 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 13:12:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 12:12:57 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35963|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 35965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35965&action=edit [SIGNED OFF] Bug 13473 - Plugins fail When trying to execute or configure the plugin on 3.18 I got: Template process failed: file error - doc-head-open.inc: not found at /usr/share/koha/lib/C4/Templates.pm line 129. Test Plan: 1) Install the Kitchen Sink plugin 2) Go to the configuration page of the plugin 3) Note the template processing error 4) Apply this patch 5) Refresh the page 6) Note the page now loads Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 13:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 12:14:41 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plugins fail in 3.18 |Plugins fail when loading | |templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 13:47:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 12:47:50 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35945|0 |1 is obsolete| | --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 35966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35966&action=edit Bug 13707 - 2. Adding a new column datereceived for items and biblioitems. Value accessors. This makes sure that the datereceived-columns are populated, eg the Item and biblio get the date of receival. This happens when an Item is added using the cataloguin/additem.pl or the acqui/finishreceive.pl TEST PLAN: (cataloguing) 1. Add a new Biblio, either via Z39.50 or cataloguing/addbiblio.pl 2. Add an Item for the new Biblio using the cataloguing/additem.pl. This is the default view you get after saving the Biblio. 3. Observe that the new Item has a datereceived-field with current time as the timestamp. 4. Observe that the new Biblio has datereceived populated in the field where you have it mapped to. This defaults to 942$1. TEST PLAN: (acquisitions) 1. Add a new Biblio, either via Z39.50 or cataloguing/addbiblio.pl 2. Add an Item for the new Biblio using the acquisitions workflow. Close the basketgroup. 3. Receive the Item using the acqui/finishreceive.pl. 4. Observe that the new Item has a datereceived-field with current time as the timestamp. 5. Observe that the new Biblio has datereceived populated in the field where you have it mapped to. This defaults to 942$1. TEST PLAN: (break it, after any test path) 10. Receive new Items using both the acquisitions module and the cataloguin module. 11. Observe that Biblio's datereceived-field (942$1) doesn't change, but remains as the value set when receiving the first Item. 12. Observe that each Item gets the original timestamp when it has been received. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 13:52:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 12:52:46 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35946|0 |1 is obsolete| | --- Comment #10 from Olli-Antti Kivilahti --- Created attachment 35967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35967&action=edit Bug 13707 - 3. Adding a new column datereceived for items and biblioitems. New sortable Zebra index. For new Biblios, this feature is automatically enabled, but if you want to make your existing biblios searchable, you must update your MARC Records from the koha DB. The databaseupdate.pl -script does this for you. Also the table 'marc_subfield_structure' has an case-insensitive collation preventing adding subfield 'R' when 'r' is present. The collation is changed to utf8_bin. This has no adverse side effects since there is no need for complex text-based sorting using this table. After that Zebra needs to be fully reindexed. TEST PLAN: (index search) 1. Add a new Biblio. 2. Add an Item to it, either via the acquisitions module or the cataloguing module. 3. Reindex zebra partially with the "./rebuild_zebra.pl -b -z -v" or wait a while if automatic Zebra indexing is enabled in your environment. 4. Make the following search to the search box: datereceived=2015-12-04 where the Date is the day when you added those Items from step 2. (should be today) 5. You should find the Biblio you just added. TEST PLAN: (sorting search) 0. You need to prepare a searchable index of Records with the datereceived indexed. The easiest way is to use the batchRebuildBiblioTables.pl but some records can be manually created as well. M. Manual path: M.1. Add new Biblios, and Items to the using the cataloguing module's additems.pl. You can set the datereceived from the Item-form, so set some Items to past and some Items to have a datereceived in the future. Be aware that the first Item created sets the Parent Biblio's datereceived. M.2. Make a search which should find all the Biblios you manually made. ALL PATHS 3. Sort based on the datereceived (Receival date - Newest to oldest) 4. All the Records should be ordered with the most newly received Biblio on top. Note: Since we can only put Dates to Zebra, sorting is only based on the day-portion of the datereceived. The time-portion is only for potential statistical/logistical optimization reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 13:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 12:53:25 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 --- Comment #11 from Olli-Antti Kivilahti --- Created attachment 35968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35968&action=edit Bug 13707 - 4. Adding a new column datereceived for items and biblioitems. Unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 13:55:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 12:55:37 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #12 from Olli-Antti Kivilahti --- Pushed this to production here. Waiting for trouble! Have fun! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:16:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:16:04 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:30:31 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #12 from Barton Chittenden --- Created attachment 35969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35969&action=edit Bug 12847 [Follwup] - Remove code that calculates "overdue" key as C4::Members::GetPendingIssues already creates it Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:30:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:30:29 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:43:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:43:23 +0000 Subject: [Koha-bugs] [Bug 13707] Adding a new column datereceived for items and biblioitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13707 --- Comment #13 from Olli-Antti Kivilahti --- Created attachment 35970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35970&action=edit KD-245 - Bug 13707 - 5. Prepared searches. NOT FOR MASTER An example on how to utilize this new search index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:43:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:43:31 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:44:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:44:38 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35748|0 |1 is obsolete| | --- Comment #98 from Paola Rossi --- Created attachment 35971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35971&action=edit Bug 11708: Add aqbasketgroups.closeddate I've applied the 9 patches against master 3.19.00.011 head 7741 . The first patch: Add aqbasketgroups.closeddate needed a trivial rebase. Just as required, this patch : 1) on ACQ start page, basketgroup.pl displayed basketgroups for all suppliers 2) added these columns in basketgroups' table: -- No. of ordered titles -- No. of received titles -- closed date in closed basketgroups tables. 3) Added filters to basketgroup tables columns. 4) Shew "Basket groups" link only if the user has "group_manage" permission. 5) Removed basketgroups pagination (20+ tested). 6) Instead of "Basket grouping" used "Basket groups" . 7) Displayed vendor name in front of "Basket groups for" . 8) Added bug number in updatedatabase.pl. 9) Verified Basketgroups.t. 10) From the ACQ start page, the Baskets groups link could be run. The upgrading of DB set the current date as the closed date to the closed existent basket groups. So I pass this patch to "Signed Off" status. IMO in the 2 tags "Open" and "Closed" the numbers of the related basket groups could be added: "Open (X)" "Closed (X)" increasing the plainness of the resulting list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:45:15 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35749|0 |1 is obsolete| | --- Comment #99 from Paola Rossi --- Created attachment 35972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35972&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:45:42 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35750|0 |1 is obsolete| | --- Comment #100 from Paola Rossi --- Created attachment 35973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35973&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:46:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:46:06 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35751|0 |1 is obsolete| | --- Comment #101 from Paola Rossi --- Created attachment 35974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35974&action=edit Bug 11708: explicitly remove pagination -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:46:33 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35752|0 |1 is obsolete| | --- Comment #102 from Paola Rossi --- Created attachment 35975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35975&action=edit Bug 11708: All basketgroups on one page - several fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:46:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:46:55 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35753|0 |1 is obsolete| | --- Comment #103 from Paola Rossi --- Created attachment 35976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35976&action=edit Bug 11708: Remove the amount columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:47:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:47:24 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35754|0 |1 is obsolete| | --- Comment #104 from Paola Rossi --- Created attachment 35977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35977&action=edit Bug 11708: Fix bad resolution conflict with bug 12896 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:47:47 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35755|0 |1 is obsolete| | --- Comment #105 from Paola Rossi --- Created attachment 35978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35978&action=edit Bug 11708: Add descriptions in unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:48:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:48:15 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35756|0 |1 is obsolete| | --- Comment #106 from Paola Rossi --- Created attachment 35979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35979&action=edit Bug 11708: Remove column aqbasketgroups.closed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 15:54:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 14:54:55 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #107 from Paola Rossi --- koha-pl is OK too. >>koha-qa.pl -c 9 -v 2 testing 9 commit(s) (applied to 6b12857 'Bug 7741 [Follow-up] Clear search ter') Processing files before patches |========================>| 6 / 6 (100.00%) Processing files after patches |========================>| 6 / 6 (100.00%) OK C4/Acquisition.pm OK critic OK forbidden patterns OK pod OK valid OK installer/data/mysql/updatedatabase.pl OK critic OK forbidden patterns OK pod OK valid OK t/db_dependent/Acquisition/Basketgroups.t OK critic OK forbidden patterns OK pod OK valid OK acqui/basketgroup.pl OK critic OK forbidden patterns OK pod OK valid OK koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt OK forbidden patterns OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc OK forbidden patterns OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 16:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 15:29:57 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Does not apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 16:54:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 15:54:18 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #3) > The dataset doesn't contain 19000 records but 4848. You can check with this > SQL query: SELECT COUNT(*) FROM biblio. mysql> select count(*) from biblio; +----------+ | count(*) | +----------+ | 4848 | +----------+ 1 row in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 17:08:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 16:08:57 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #59 from Kyle M Hall --- Created attachment 35980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35980&action=edit Store list of objects as needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 17:10:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 16:10:10 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35980|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 17:19:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 16:19:44 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #60 from Tom?s Cohen Arazi --- Kyle, maybe a new bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 17:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 16:43:39 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35957|0 |1 is obsolete| | --- Comment #25 from H?ctor Eduardo Castro Avalos --- Created attachment 35981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35981&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML is not well-formed document and do not follows the DC-XML recommendations as should be. New feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Apply patch[es]. 2) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C and OAI-DC can be validated by other validator. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities not found in .deb package -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 17:56:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 16:56:13 +0000 Subject: [Koha-bugs] [Bug 13717] New: Add ability to move old patron attributes when importing borrowers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717 Bug ID: 13717 Summary: Add ability to move old patron attributes when importing borrowers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries would like to move the value of a patron attribute to a different attribute when updating patrons via the import patrons tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 17:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 16:56:18 +0000 Subject: [Koha-bugs] [Bug 13717] Add ability to move old patron attributes when importing borrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 17:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 16:56:22 +0000 Subject: [Koha-bugs] [Bug 13717] Add ability to move old patron attributes when importing borrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12598 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 17:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 16:56:22 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13717 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 17:56:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 16:56:24 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35981|0 |1 is obsolete| | --- Comment #26 from H?ctor Eduardo Castro Avalos --- Created attachment 35982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35982&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML is not well-formed document and do not follows the DC-XML recommendations as should be. New feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document is not well formed 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C and OAI-DC can be validated by other validator. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities not found in .deb package New patch for work with librdf-helper-perl (2.0) and librdf-trine-perl (1.000). RDF::Trine and RDF::Helper not need to be upgraded. Tested in both (upgraded and not upgraded) Fix some utf8 encoding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 18:19:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 17:19:42 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35982|0 |1 is obsolete| | --- Comment #27 from H?ctor Eduardo Castro Avalos --- Created attachment 35983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35983&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML is not well-formed document and do not follows the DC-XML recommendations as should be. New feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document is not well formed 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C and OAI-DC can be validated by other validator. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities not found in .deb package New patch for work with librdf-helper-perl (2.0) and librdf-trine-perl (1.000). RDF::Trine and RDF::Helper not need to be upgraded. Tested in both (upgraded and not upgraded) Fix some utf8 encoding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 18:29:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 17:29:21 +0000 Subject: [Koha-bugs] [Bug 13718] New: Paying fines references non-existent function on submit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13718 Bug ID: 13718 Summary: Paying fines references non-existent function on submit Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.field at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com paycollect.tt has (for a long time) contained a onsubmit reference which refers to a function that has never existed. It causes noise in browser debuggers but no other side effects. Should be removed ideally.
    2 occurrences of the above in this file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 18:32:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 17:32:44 +0000 Subject: [Koha-bugs] [Bug 13717] Add ability to move old patron attributes when importing borrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717 --- Comment #1 from Kyle M Hall --- Created attachment 35984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35984&action=edit Bug 13717 - Add ability to move old patron attributes when importing new patron data Some libraries would like to move the value of a patron attribute to a different attribute when updating patrons via the import patrons tool. Test Plan: 1) Enable patron attributes 2) Create 2 attributes TEST and TEST_PREV 3) Create a patron with a TEST attribute 4) Create a patrons CSV file with that patron in it, containing a new TEST attribute 5) Go to tool/import patrons 6) Select your CSV file 7) At the bottom of the form is the to/from selector for attributes, choose TEST to be 'from', and TEST_PREV to be 'to' 8) Submit the form 9) Observe the patron record, note the previous value for TEST has now been moved to an instance of TEST_PREV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 18:32:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 17:32:42 +0000 Subject: [Koha-bugs] [Bug 13717] Add ability to move old patron attributes when importing borrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 18:42:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 17:42:20 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #28 from H?ctor Eduardo Castro Avalos --- Hi all I attached new patch that will work with all version of RDF::Trine and RDF::Helper especially with the version that come with debian package, even if you upgrade from CPAN. Sorry for my lack of experience with git and git bz. Regards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 19:34:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 18:34:02 +0000 Subject: [Koha-bugs] [Bug 13719] New: Store list of objects as needed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Bug ID: 13719 Summary: Store list of objects as needed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 19:34:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 18:34:31 +0000 Subject: [Koha-bugs] [Bug 13719] Store list of objects as needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 --- Comment #1 from Kyle M Hall --- Created attachment 35985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35985&action=edit Bug 13719 - Store list of objects as needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 19:34:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 18:34:41 +0000 Subject: [Koha-bugs] [Bug 13719] Store list of objects as needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 19:39:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 18:39:28 +0000 Subject: [Koha-bugs] [Bug 13708] MARC Mapping Item columns to several MARC Fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13708 --- Comment #7 from Katrin Fischer --- Hm, from the comments on IRC maybe I misunderstood what you are trying to do? What we do is use upper case letters with no explicit mapping to a field in the items table in the configuration - this way the data ends up in items.more_subfields_xml. If you found a problem with this approach it would be good to know! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 19:41:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 18:41:26 +0000 Subject: [Koha-bugs] [Bug 13719] Store list of objects as needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |gmcharlt at gmail.com Depends on| |13019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 19:41:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 18:41:26 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13719 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 19:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 18:54:33 +0000 Subject: [Koha-bugs] [Bug 6890] Add reserves to modification logging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 19:59:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 18:59:01 +0000 Subject: [Koha-bugs] [Bug 13720] New: freeze columns/headers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13720 Bug ID: 13720 Summary: freeze columns/headers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Is there a way in HTML or JS to freeze frames like you can in Excel. The idea would be to free the columns and rows on the circ & fine rules that you need to see at all times like the header and then the item types and patrons categories since when you scroll you can't see the important info anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 20:00:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 19:00:12 +0000 Subject: [Koha-bugs] [Bug 13721] New: apply tags to all titles Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13721 Bug ID: 13721 Summary: apply tags to all titles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be great if staff had a way to apply a tag that is on one title to all formats of that title. I envision something like a search button next to each title that finds other items with the same title and then checkboxes where the staff select the titles they want to copy the tags to so that they can easily have the same tags on all versions of the title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 20:49:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 19:49:10 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 20:49:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 19:49:13 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35715|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 35986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35986&action=edit [SIGNED OFF] Bug 13679 : Bug in listing overdues To test 1/ Create some overdues and some issues due in the future 2/ Run the overdues script 3/ Notice item due in the future is in the list 4/ Apply patch 5/ Run script again 6/ Notice in the future not in the list Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 20:50:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 19:50:02 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #5) > Nick, > Yes actually the test plan is not precis enough. > The problem comes from the 3rd overdue, so you need something like: > - Notice triggers at 1, 5, 10 days > - And items due 1, 2 days ago and 11+ (<90) days in the future. Somehow leaving my VM over the weekend and coming back today made it trigger right. :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 21:17:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 20:17:29 +0000 Subject: [Koha-bugs] [Bug 13489] Notices variable for library hours In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13489 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 21:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 20:17:59 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight circulation of reference books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 21:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 20:21:28 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 21:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 20:21:29 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 22:35:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 21:35:56 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 --- Comment #5 from Marc V?ron --- A possible solution could be to have the address blocks in different include files and to have a preference to choose them as appropriate. I will attach a patch for the staff interface (memberentry.pl) that could be a starting point for this idea. It simply extracts the address blocks to 3 includes (see patch that follows). The behaviour while adding / editing a patron will be the same as before. As a next step, different includes could be added for the different country styles, along with the functionality to select them using the syspref. What do others think of this idea? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 22:40:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 21:40:03 +0000 Subject: [Koha-bugs] [Bug 13722] New: Titles with articles not sorting correctly in lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722 Bug ID: 13722 Summary: Titles with articles not sorting correctly in lists Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: jesse at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We've noticed that in lists sorted by title, titles with articles, e.g., that being with "The..." are sorting under the article even though the second indicator of the 245 field is set correctly. E.g. this list, "Lighthouses (West Coast)": http://keys.bywatersolutions.com/cgi-bin/koha/opac-shelves.pl?sortfield=title&viewshelf=66&itemoff=3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 22:42:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 21:42:08 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 --- Comment #6 from Marc V?ron --- Created attachment 35987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35987&action=edit Bug 4041 - First step (staff interface): Extract address blocks to include files This patch extracts the address blocks in memberentrygen.tt to include files. To test: The overall functionality should remain the same with this patch. In further steps, more country- or region-dependent includes could be added, along with functionality to select them using a system preference. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 23:30:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 22:30:36 +0000 Subject: [Koha-bugs] [Bug 13723] New: OPAC cart not pulling date from RDA tag 264 only tag 260 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13723 Bug ID: 13723 Summary: OPAC cart not pulling date from RDA tag 264 only tag 260 Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: danielle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When adding an items from the catalog or staff client to the cart, the dates in the 264$c are not being added to the cart, but date from the 260$c are. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 23:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 22:39:26 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 23:48:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 22:48:30 +0000 Subject: [Koha-bugs] [Bug 13724] New: Not possible to undo a selected facet when search started with an authority id search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13724 Bug ID: 13724 Summary: Not possible to undo a selected facet when search started with an authority id search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If you are searching by authority id first and then select a facet in the result list, it's impossible to undo the facet. Example: - Click on a link in the detail page, that uses an authority id for the search, like a subject or an author - On the result list, pick a facet to limit the list further - Notice, that the x behind the selected facet is not showing up - you can't undo the facet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 17 23:52:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 22:52:58 +0000 Subject: [Koha-bugs] [Bug 10581] Authority search: no results should not display as 404 error page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10581 --- Comment #1 from Katrin Fischer --- Still an issue in 3.18.3 and current master. Very common in our catalogs as the authorities from the union catalog may contain references to other authorities that are not part of the library's collection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 00:12:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 17 Feb 2015 23:12:09 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #65 from Jesse Weaver --- Pushed updates to https://github.com/pianohacker/koha/tree/rancor-submit . Encoding error is not yet fixed, but the code is a bit cleaner. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 01:06:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 00:06:27 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 03:59:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 02:59:32 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #24 from David Cook --- Chatted with Chris Cormack, Chris Vella, and Mason about this a bit on IRC. Screen readers will still read the 'negcap' field, which is suboptimal. However, even if a screenreader does read the field, hopefully people will still leave this blank. Perhaps it might be an idea to include a more obvious label name like "do not fill me in". Anyway, just leaving some links here. Chris Vella found the one about "aria-hidden". That could be really good to add. Relevant links: http://www.w3.org/TR/wai-aria/states_and_properties#aria-hidden http://www.visionaustralia.org/living-with-low-vision/learning-to-live-independently/using-technology-and-computers/blog---accessibility-and-assistive-technology-blog/blog/accessibility-blog/2014/12/09/effective-alternatives-to-inaccessible-captchas http://webaim.org/techniques/css/invisiblecontent/#absolutepositioning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:30:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:30:25 +0000 Subject: [Koha-bugs] [Bug 13725] New: Wrong zebra index type for ln in 008/35-37 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13725 Bug ID: 13725 Summary: Wrong zebra index type for ln in 008/35-37 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: januszop at gmail.com QA Contact: testopia at bugs.koha-community.org Index type for ln index (language) definded over 008/35-57(in MARC21 biblio dom configuration) is wrongly set to 'n' instead of 'w' (as in 041). As a result language limit in advanced search does not take into account language information form 008 and thus does not work as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:32:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:32:44 +0000 Subject: [Koha-bugs] [Bug 13712] Missing newline in DB update 3.19.00.010 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35925|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 35988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35988&action=edit [PASSED QA] Bug 13712 - Missing newline in DB update 3.19.00.010 To test: - Make sure your database is pre 3.19.00.010 (for example by loading in an older backup) - Run through the web-based database update (web installer, step 3) - Verify that updates 3.19.00.010 and 3.19.00.011 are squashed together on one line - Apply the patch - Reset the database and run the web-based database upgrade again - Verify that the two uupdates are noe displayed on separate lines (as separate bullet points) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:32:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:32:41 +0000 Subject: [Koha-bugs] [Bug 13712] Missing newline in DB update 3.19.00.010 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:33:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:33:14 +0000 Subject: [Koha-bugs] [Bug 13712] Missing newline in DB update 3.19.00.010 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- Passing this trivial patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:42:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:42:22 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- *** Bug 13725 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:42:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:42:22 +0000 Subject: [Koha-bugs] [Bug 13725] Wrong zebra index type for ln in 008/35-37 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13725 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |tomascohen at gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 12948 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:42:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:42:51 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:53:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:53:37 +0000 Subject: [Koha-bugs] [Bug 13725] Wrong zebra index type for ln in 008/35-37 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13725 --- Comment #2 from Janusz Kaczmarek --- Created attachment 35989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35989&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:58:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:58:47 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35923|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 35990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35990&action=edit [SIGNED OFF] Bug 12948: Use word indexing for language (NORMARC) This patch is for Normarc Same test plan as patch for MARC21, except you need a setup with Normarc. http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger - Added a record with "bul" in 008pos35-37 - Verified that this did not turn up in an advanced search with language = Bulgarian - Applied the patch - I was testing on a gitified install, so I had to copy the patched index file to the right location with this command: sudo cp etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl - Did a full reindex - Verified that the record *did* turn up in an advanced search with language = Bulgarian - Signing off! Thanks Zeno! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 13:58:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 12:58:57 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35924|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 35991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35991&action=edit [SIGNED OFF] Bug 12948: Use word indexing for language (MARC21) This patch is for MARC21. To test: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger I have *not* actually tested this, but the changes are identical to the ones done for NORMARC, which I have tested, so I think it is safe to sign off. If anyone disagrees, please reset the bug to "Needs signoff". Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:01:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:01:54 +0000 Subject: [Koha-bugs] [Bug 13725] Wrong zebra index type for ln in 008/35-37 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13725 --- Comment #3 from Janusz Kaczmarek --- Ah, yes, a duplicate. Did not notice before filing. I am sorry, Tom?s. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:03:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:03:07 +0000 Subject: [Koha-bugs] [Bug 13725] Wrong zebra index type for ln in 008/35-37 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13725 --- Comment #4 from Tom?s Cohen Arazi --- No worries, please take a look at the other bug's patches just in case too. They are similar to yours but cover NORMARC also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:15:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:15:21 +0000 Subject: [Koha-bugs] [Bug 13726] New: Koha::Acquisition::Bookseller should use Koha::Object Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Bug ID: 13726 Summary: Koha::Acquisition::Bookseller should use Koha::Object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Koha::Acquisition::Bookseller has been introduced by bug 12896 but no consensus on the DBIx::Class implementation was reach. Now that we have Koha::Object (cf bug 13019), it should use it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:15:39 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12896, 13019, 13719 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:15:39 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13726 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:15:39 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13726 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:15:39 +0000 Subject: [Koha-bugs] [Bug 13719] Store list of objects as needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13726 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:16:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:16:44 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:16:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:16:48 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 --- Comment #1 from Jonathan Druart --- Created attachment 35992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35992&action=edit Bug 13726: Make Koha::Acq::Bookseller using Koha::Object This patch create a Koha::Acquisition::Booksellers module and Koha::Acquisition::Bookseller::Contract[s] modules. All code in the acquisition module is adapted to use the CRUD methods of Koha::Object[s]. The former C4 routines are removed. Test plan: Since a lot of files are impacted by this patch, try a complete acquisition workflow and try to catch errors. Be focused on bookseller and bookseller's contracts data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:18:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:18:37 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |tomascohen at gmail.com --- Comment #2 from Jonathan Druart --- I did not test this patch deeply and there are certainly some bugs, but I would like to get feedback on it. I am waiting for confirmation before continuing with Koha::Acquisition::Order and Koha::Acquisition::Contract. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:21:23 +0000 Subject: [Koha-bugs] [Bug 13719] Store list of objects as needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com --- Comment #2 from Tom?s Cohen Arazi --- Kyle, what would "Store list of objects" mean? I'm sorry but it is too generic for my idiomatic limitations! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:21:39 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 --- Comment #3 from Jonathan Druart --- Note also that a lot of code could be removed (we should pass the object directly to the template instead of all values), but I would prefer to do that in another patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:27:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:27:11 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #17 from Olli-Antti Kivilahti --- I created a new subroutine, because I only need the location-data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:28:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:28:40 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #18 from Olli-Antti Kivilahti --- It's a bit like, if one chocolate bar makes you happy, why eat 4? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:33:54 +0000 Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with diacritics, utf-8 or ttf fonts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:34:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:34:03 +0000 Subject: [Koha-bugs] [Bug 13709] Patron cards creator doesn't work with diacritics, utf-8 or ttf fonts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13709 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:37:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:37:29 +0000 Subject: [Koha-bugs] [Bug 13725] Wrong zebra index type for ln in 008/35-37 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13725 --- Comment #5 from Janusz Kaczmarek --- Sure. They are tthe same (plus NORMARC, of corse). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:42:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:42:39 +0000 Subject: [Koha-bugs] [Bug 13727] New: Validation of authorized values Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13727 Bug ID: 13727 Summary: Validation of authorized values Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: rurik.greenall at kul.oslo.kommune.no QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl While automatically testing item creation, we added randomized alphanumeric values to NOT_LOAN. When we attempted to add NOT_LOAN statuses to items, we found that Koha did one of two things: 1) allowed us to set the status in the interface, but failed silently 2) allowed us to set the status, but added only part of the value REPLICATION: Type one: 1) create a new authorized value for category NOT_LOAN 2) add a value (value: "abc1de", description: "new1", OPAC description: "New 1") 3) create new item 4) set Not for loan to "New 1" Result: Item's "Not for loan" status is "" Type two: 1) create a new authorized value for category NOT_LOAN 2) add a value (value: "12abce", description: "new2", OPAC description: "New 2") 3) create new item 4) set Not for loan to "New 2" Result: Item's "Not for loan" status is 12 We notice that the documentation clearly states that the values of NOT_LOAN must not be alphabetical http://manual.koha-community.org/3.18/en/basicparams.html#notforloan however, we would argue that the ability to set values opens for an expectation that they should be usable. In terms of a fix, it is possible to add a validation pattern to the authorized value at creation time; which is then stored in the table with the value and can be used to validate entry via the jQuery validation plugin and a html5 data-field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 14:51:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 13:51:57 +0000 Subject: [Koha-bugs] [Bug 13727] Validation of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13727 Rurik Greenall changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.18 OS|All |Linux Hardware|All |PC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 15:20:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 14:20:45 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #19 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #17) > I created a new subroutine, because I only need the location-data. It's another subroutine to maintain, I am not sure it's a good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 15:25:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 14:25:03 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31286|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 15:48:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 14:48:08 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #24 from Mirko Tietgen --- I would like to see this resolved somehow, it's the standard date format for Germany too. Do I understand correctly that this is not going in before someone refactors stuff that is currently done in C4::Dates to be done in Koha::DateUtils (which is not really within the scope of this bug)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:21:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:21:07 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #25 from Jonathan Druart --- (In reply to Mirko Tietgen from comment #24) > I would like to see this resolved somehow, it's the standard date format for > Germany too. Do I understand correctly that this is not going in before > someone refactors stuff that is currently done in C4::Dates to be done in > Koha::DateUtils (which is not really within the scope of this bug)? The patch adds new enh in a deprecated module, so yes it's in the scope of this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:27:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:27:08 +0000 Subject: [Koha-bugs] [Bug 13728] New: koha-translate -l -a shows po files instead of language codes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Bug ID: 13728 Summary: koha-translate -l -a shows po files instead of language codes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org When 'prog' got removed the koha-translate was fixed so it uses the bootstrap .po files to check language availability, but a leftover (-i-) makes $ koha-translate --list --available incorrectly show the .po file names instead of the language codes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:31:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:31:12 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:31:17 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:31:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:31:53 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:31:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:31:56 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 35993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35993&action=edit Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:45:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:45:53 +0000 Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 --- Comment #6 from Jonathan Druart --- Created attachment 35994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35994&action=edit Bug 11062: rename shipmentcost with shipping For more consistency, the shipmentcost variables and labels will be renamed with shipping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:45:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:45:57 +0000 Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 --- Comment #7 from Jonathan Druart --- Created attachment 35995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35995&action=edit Bug 11062: Fill shipping tax excluded This patch adds the ability to enter the shipping tax excluded. Note that the total will continue to be calculated using the shipping tax included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:46:00 +0000 Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 --- Comment #8 from Jonathan Druart --- Created attachment 35996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35996&action=edit Bug 11062: Update DB entry 3 new DB field: aqbooksellers.invoiceincgst aqbooksellers.shipping_tax_rate aqinvoices.shipping_tax_rate 1 DB field renamed aqinvoices.shipmentcost => aqinvoices.shipping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:46:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:46:16 +0000 Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Attachment #31033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:46:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:46:35 +0000 Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simith.doliveira at inlibro.co |jonathan.druart at biblibre.co |m |m Severity|minor |enhancement Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:47:04 +0000 Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13323 --- Comment #9 from Jonathan Druart --- Patches to apply on top of kohac/ft/bug_13323 (cf bug 13323 for more information). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 16:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 15:47:04 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11062 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 17:03:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 16:03:47 +0000 Subject: [Koha-bugs] [Bug 13512] Add sort-string-utf.chr for Polish and Latin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13512 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- Michal, please provide a patch for this. The single file is not enough. If you don't know how to do it, just let me know. Otherwise this bug won't move and will finish as "invalid" soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 17:03:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 16:03:54 +0000 Subject: [Koha-bugs] [Bug 13512] Add sort-string-utf.chr for Polish and Latin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13512 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 17:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 16:04:01 +0000 Subject: [Koha-bugs] [Bug 13512] Add sort-string-utf.chr for Polish and Latin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13512 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Searching |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 17:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 16:37:27 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 --- Comment #7 from Marc V?ron --- Created attachment 35997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35997&action=edit Bug 4041 - Second Step: Add system preference and "German style" address formats for staff To test: Apply patch Do a database update (e.g. by changing version number in kohaversion.pl) Find new system preference 'addressformat' in I18N/L10N Choose 'German style' Go to Patrons and edit a patron / create new patron Verify that Zip code appears above City Change system preference to 'US style' Verify that Zip code appears between State and Country. BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g. fr for "French style") and copy / modify the includes using the same code as postfix. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 17:39:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 16:39:33 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 17:53:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 16:53:47 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it --- Comment #19 from Paola Rossi --- I've applied the patches against master 3.19.00.011 head 7741. (In reply to mathieu saby from comment #17) > [...] to test I suppose you could do the run: > zebrasrv -f $KOHA_CONF Thanks, Mathieu! OK. > Make some searches with and without QP activated [....] 1) I've thought that QP activating was about setting the syspref "UseQueryParser" to "Do not try" or to "Try": Is it right? 2) But, on ADMIN, I've read this syspref UseQueryParser's note: UseQueryParser : to use the QueryParser module for parsing queries. Please note: enabling this will have no impact if you do not have QueryParser installed, and everything will continue to work as usual. Which QueryParser had I to install? Perhaps one of the 2 following ones? >apt-cache search queryparser liblucene-queryparser-perl - Turn a Lucene query into a Perl data structure libsearch-queryparser-perl - Perl module to parse URI query strings into a data structure 3) My installation is a MARC21 one. I tested the "bio" and "tpubdate" indexes. bio was OK: it found biblio records. tpubdate found none (ERROR). Is this error relating to this bug? Or is this bug OK? Thanks in advance. I keep the current "Needs Signoff" status for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 18:16:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 17:16:45 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #29 from Marc V?ron --- Sorry, I get: Applying: Bug 13642 [ENH] Adding new features for Dublin Core metadata fatal: sha1 information is lacking or useless (Koha/DublinCoreTransformer.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13642 [ENH] Adding new features for Dublin Core metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 18:48:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 17:48:56 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 --- Comment #5 from Marc V?ron --- Created attachment 35998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35998&action=edit [Signed-off] Bug 13593: 'stock number' should be 'inventory number' To make Koha easier to use, we should use terms consistently. This patch fixes some occurrences of 'stock number' to be 'inventory number' as this is also the term used in the frameworks. Item search, accessible via the link from staff's advanced search 1) Do a search for items, but choose CSV as output 2) Verify that the header row says 'inventory number' Acquisition 3) Set AcqCreateItem to 'order' 4) Create a new order, check the labels on the item table in the order 5) Receive the order, check the labels on the item table on receive 6) Set AcqCreateItem to 'receive' 7) Check the item table on receiving an order Followed test plan (including item search with JavaScipt disabled). Headers / labels display as expected. http://bugs.koha-community.org/show_bug.cgi?id=13564 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 18:49:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 17:49:11 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35347|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 18:49:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 17:49:22 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 19:00:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 18:00:06 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #30 from H?ctor Eduardo Castro Avalos --- Hi Marc. I do not know why the failure. I applied the patch and I get something different: Applying: Bug 13642 [ENH] Adding new features for Dublin Core metadata Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... No changes -- Patch already applied. This can happen for all the mistakes I made before. I will try to generate the patch with git format-patch origin and upload manually without using git-bz. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 19:06:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 18:06:09 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 19:10:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 18:10:33 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #31 from H?ctor Eduardo Castro Avalos --- Created attachment 35999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35999&action=edit Bug-13642-ENH-Adding-new-features-for-Dublin-Core-me #1/2 The first or original patch. Apply this first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 19:12:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 18:12:05 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #32 from H?ctor Eduardo Castro Avalos --- Created attachment 36000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36000&action=edit 0001-Bug-13642-ENH-Adding-new-features-for-Dublin-Core-me #2/2 The second patch correct the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 19:15:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 18:15:54 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36000|0001-Bug-13642-ENH-Adding-n |Bug-13642-ENH-Adding-new-fe description|ew-features-for-Dublin-Core |atures-for-Dublin-Core-me |-me #2/2 |#2/2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 19:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 18:16:58 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #33 from H?ctor Eduardo Castro Avalos --- Hi Marc. If this doesn't work I'll give up. Manually test plan Test plan --------------- 1) Apply patch[es]. 2) Follow the last test plan. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 20:13:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 19:13:38 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #9 from Marc V?ron --- Created attachment 36001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36001&action=edit Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 20:19:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 19:19:30 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 20:23:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 19:23:56 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 20:28:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 19:28:46 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from Marc V?ron --- I hope it is OK to switch to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 20:38:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 19:38:32 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to Marc V?ron from comment #10) > I hope it is OK to switch to "Needs Signoff" It is! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:05:17 +0000 Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Why not add a title tag to the "Cart" link? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:07:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:07:34 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:10:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:10:53 +0000 Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 --- Comment #3 from Marc V?ron --- Created attachment 36002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36002&action=edit Bug 11900 - OPAC cart can confuse patrons This patch adds a title tag to the "Cart" link on Opac main page (and to the "Lists" link as well). Wording should be verified by a native speaker :-) To test: Apply patch Go to OPAC main page, verify that a tooltip appears on the "Cart" and "Lists" links at the top of the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:11:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:11:30 +0000 Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3719 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:11:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:11:30 +0000 Subject: [Koha-bugs] [Bug 3719] Create syspref to allow sites to rename OPAC Cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3719 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11900 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:12:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:12:08 +0000 Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Marc V?ron --- I hope it is OK to switch status to "Needs signoff" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:13:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:13:47 +0000 Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:14:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:14:04 +0000 Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:25:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:25:41 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #34 from Marc V?ron --- Hi H?ctor, patches apply now. Great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:38:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:38:17 +0000 Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 36003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36003&action=edit Bug 13350 - Untranslatable strings in aqbudgetperiods.tt This patch fix a few untranslatable strings in aqbudgetperiods.tt. Style not pretty but work. The section modified is BREADCRUMBS. This patch adds html tags to be recognized by misc/translator/translate script. Test plan --------------- 1) Use another language (not English) 2) Go to More > Administration > Budgets. Notice that "> Budgets administration" is untranslatable in the Navigation section. 3) Try to create a New budget. Notice the same happens as previous step. 4) Try delete, edit, duplicate, and close a budget. The result is the same. 5) Apply the patch. 6) Run perl translate update xx-XX (in my case es-ES) 7) Edit es-ES-i-staff-t-prog-v-3006000.po 8) Get notice that a new lines has been adhered to po file. 9) Run perl translate install es-ES 10) Go to Global system preferences and search for "language" in I18N/L10N preferences. Enable Espa?ol(es-ES). 11) Follow step 2 and 3 and notice that the strings were translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:54:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:54:06 +0000 Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36003|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 36004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36004&action=edit Bug 13350 - Untranslatable strings in aqbudgetperiods.tt This patch fix a few untranslatable strings in aqbudgetperiods.tt. Style not pretty but work. The section modified is BREADCRUMBS. This patch adds html tags to be recognized by misc/translator/translate script. Test plan --------------- 1) Use another language (not English) 2) Go to More > Administration > Budgets. Notice that "> Budgets administration" is untranslatable in the Navigation section. 3) Try to create a New budget. Notice the same happens as previous step. 4) Try delete, edit, duplicate, and close a budget. The result is the same. 5) Apply the patch. 6) Run perl translate update xx-XX (in my case es-ES) 7) Edit es-ES-i-staff-t-prog-v-3006000.po 8) Get notice that a new lines has been adhered to po file. 9) Run perl translate install es-ES 10) Go to Global system preferences and search for "language" in I18N/L10N preferences. Enable Espa?ol(es-ES). 11) Follow step 2 and 3 and notice that the strings were translated. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:55:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:55:09 +0000 Subject: [Koha-bugs] [Bug 13350] Untranslatable strings in aqbudgetperiods.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13350 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:57:38 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #35 from Marc V?ron --- Created attachment 36005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36005&action=edit [Signed-off] Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML is not well-formed document and do not follows the DC-XML recommendations as should be. New feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document is not well formed 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C and OAI-DC can be validated by other validator. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities not found in .deb package New patch for work with librdf-helper-perl (2.0) and librdf-trine-perl (1.000). RDF::Trine and RDF::Helper not need to be upgraded. Tested in both (upgraded and not upgraded) Fix some utf8 encoding. Tested with both patches, followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:59:14 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35999|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 21:59:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 20:59:36 +0000 Subject: [Koha-bugs] [Bug 13729] New: Give news in Opac a unique anchor Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Bug ID: 13729 Summary: Give news in Opac a unique anchor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: viktor.sarge at regionhalland.se QA Contact: testopia at bugs.koha-community.org While coding RSS for news in Opac the need for a unique link to each item in the news became clear. A quick fix that still doesn't clash with later adding a single newsitem view is to give news in Opac a unique anchor for linking purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:00:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:00:14 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7843 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:00:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:00:14 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13729 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:01:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:01:48 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36005|0 |1 is obsolete| | --- Comment #36 from Marc V?ron --- Created attachment 36006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36006&action=edit [Signed-off] Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML is not well-formed document and do not follows the DC-XML recommendations as should be. New feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document is not well formed 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C and OAI-DC can be validated by other validator. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities not found in .deb package New patch for work with librdf-helper-perl (2.0) and librdf-trine-perl (1.000). RDF::Trine and RDF::Helper not need to be upgraded. Tested in both (upgraded and not upgraded) Fix some utf8 encoding. Tested with both patches, following test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:04:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:04:21 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:04:53 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36005|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:06:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:06:45 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36005|[Signed-off] Bug 13642 |[Signed-off] Bug 13642 description|[ENH] Adding new features |[ENH] 1/2 Adding new |for Dublin Core metadata |features for Dublin Core | |metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:07:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:07:16 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36006|[Signed-off] Bug 13642 |[Signed-off] Bug 13642 description|[ENH] Adding new features |[ENH] 2/2 Adding new |for Dublin Core metadata |features for Dublin Core | |metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:09:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:09:42 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:11:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:11:02 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:11:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:11:05 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 --- Comment #1 from Viktor Sarge --- Created attachment 36007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36007&action=edit Bug 13729 Give news in Opac a unique anchor This patch introduces the use of the idnew-value from the opac_news table as a base for a unique anchor on each newsitem in Opac. The anchor can be used for linking to specific newsitems and also for improving bug 7843 (RSS stream for news) with a unique link to each item in the RSS stream. Test plan: * Make shure you have a few news in the opac. Best is if it's enough to hide a few beneath the bottom of the window. * Install the patch. * Verify that you can access newitems with links like mykoha/cgi-bin/koha/opac-main.pl#newsitem4 * Experiment with removing newsitems and verify that that the newsitem-id stay unique to each newsitem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:16:35 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 --- Comment #2 from Magnus Enger --- Created attachment 36008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36008&action=edit Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data TEST PLAN --------- 1) Make sure there are no 'J', 'K', nor 'YA' patron category codes. 2) Make sure there are no 'CPL' nor 'MPL' branch codes. 3) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- dies horribly 4) apply patch 5) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- passes 6) Run koha qa test tools Signed-off-by: Magnus Enger For me, the tests fail because I have a Norweian setup with different categories etc. After applying the patch the tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:17:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:17:07 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:17:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:17:30 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:19:50 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13729 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:19:50 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7843 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:53:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:53:28 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 22:53:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 21:53:31 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36007|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 36009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36009&action=edit Bug 13729 - [SIGNED-OFF] Give news in Opac a unique anchor This patch introduces the use of the idnew-value from the opac_news table as a base for a unique anchor on each newsitem in Opac. The anchor can be used for linking to specific newsitems and also for improving bug 7843 (RSS stream for news) with a unique link to each item in the RSS stream. Test plan: * Make shure you have a few news in the opac. Best is if it's enough to hide a few beneath the bottom of the window. * Install the patch. * Verify that you can access newitems with links like mykoha/cgi-bin/koha/opac-main.pl#newsitem4 * Experiment with removing newsitems and verify that that the newsitem-id stay unique to each newsitem. Signed-off-by: Magnus Enger Works as advertised. Nice enhancement! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 23:53:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 22:53:59 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 18 23:54:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Feb 2015 22:54:47 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 07:04:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 06:04:24 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pasi.kallinen at pttk.fi |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 07:29:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 06:29:09 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #30 from Brendan Gallagher --- (In reply to Jonathan Druart from comment #29) > (In reply to Brendan Gallagher from comment #23) > > Hello Jonathan > > > > I run this through the qa script and find errors. > > > > Global symbol "$to_address" requires explicit package name > > BEGIN failed--compilation aborted > > Compilation failed in require > > Sorry about that, I did not launch the qa script before submitting :-/ Excellent - all pass now. Running some email tests tonight. Will not have time to finish. Since it is late enough, I was thinking I would set a cronjob to test that, since I will see result in the morning (10:30pm here now). -Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 09:44:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 08:44:52 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 09:44:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 08:44:55 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31318|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 36010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36010&action=edit Bug 12858: Add error handling to Syndetics Index * Syndetics routines include a statement to check that the returned content from Syndetics is xml. The get_syndetics_index routine was missing this check and so when a 'not found' html page was returned the opac-detail page would take a long time to load whilst xml::simple attempted to parse the large html document. Test Plan 1. Enable Syndetics indexes on opac. 2. Head over to an opac-detail page on the opac. 3. Remove the ISBN from the same item in the staff client. 4. Reload the opac-detail page for the item noticeing a much slower page load. 5. Apply the patch 6. Reload the opac-detail page for the item and note that it now laods in a reasonable timescale again. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 09:49:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 08:49:57 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35389|0 |1 is obsolete| | --- Comment #22 from Chris Cormack --- Created attachment 36011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36011&action=edit Bug 12669: Use floating timezone when handling dates without hours, minutes and seconds. Test plan: 1. Create a new serial record or pick an existing one; 2. Add a "New subscription" and set the "First issue publication date" and "Frequency" values so that the "Planned date" for a given issue hits a day where a transition to Daylight Saving Time (DST) occurs ex:. 1979-04-01 in Europe/Lisbon (http://www.timeanddate.com/time/change/portugal/lisbon?year=1979) ... use this website page as a source http://www.timeanddate.com/time/dst/2014.html to find a suitable transition to DST in your timezone in the current year. 3. From the "Subscription detail" page in Koha for the given record click the "Serial collection" link on the left side context menu. Expected result: Prior to applying the patch the error described in this bug report should occur. After the patch is applied the "Serial collection" page should load correctly. Signed-off-by: Colin Campbell Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 09:50:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 08:50:12 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 09:50:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 08:50:17 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35390|0 |1 is obsolete| | --- Comment #23 from Chris Cormack --- Created attachment 36012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36012&action=edit Bug 12669: Centralize the timezone handle into Koha::DateUtils This patch adds unit tests for the previous changes and centralize the timezone handle into the Koha::DateUtils module. Like that the behavior will affect all date manipulations using this module (should be all dates in Koha). Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 09:53:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 08:53:33 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 09:53:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 08:53:36 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35993|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 36013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36013&action=edit Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:06:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:06:57 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:07:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:07:00 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35777|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 36014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36014&action=edit Bug 13687: Move hold policy check into CanItemBeReserved This way ILS-DI HoldItem and HoldTitle services also benefit from this check Test plan: 1/ Define some default holds policies by item type in /admin/smart-rules.pl 2/ Use ILS-DI HoldItem service and check that those rules are respected 3/ Check that staff and opac hold behaviour is unchanged regarding these rules. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:11:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:11:50 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #20 from Jonathan Druart --- Tomas, this is *not* in master yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:14:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:14:23 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23952|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 36015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36015&action=edit Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:14:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:14:43 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:14:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:14:47 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36001|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 36016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36016&action=edit Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:20:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:20:54 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #15 from Jonathan Druart --- Tomas, this is *not* in master yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:24:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:24:34 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:24:38 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35733|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 36017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36017&action=edit Bug 7843 Create an RSS feed for news in Opac Test plan: * Install the patch * Make shure there is news in the Opac * Go to the Opac (opac-main.pl) * Make shure you see an RSS icon below the news and a short text. * Click the RSS icon and verify that you get an RSS feed that validates. Signed-off-by: Chris Cormack I took the liberty of fixing the copyright statement when signing it off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:27:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:27:24 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- I still completely disagree with this kind of patch, see my comments on bug 13457. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:47:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:47:43 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:47:46 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35962|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 36018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36018&action=edit Bug 13568 OAI Server doesn't handle properly resumption token When responding to ListRecords and ListIdentifiers verbs, OAI server doesn't return proper resumption token. At the end of a result set, OAI server generates a resumption token even if there isn't anymore records. Consequently, OAI harverster will send a new request, based on this invalid resumption, token. OAI Server responds with an empty resultset, which is considered as an invalid response by most of the harvesters. TO TEST: - Find in your DB, a day where a few biblio records have been created. The number of created biblios must inferior to OAI-PMH:MaxCount. - Let say this day is 2014-01-09. Send an OAI-PMH request to Koha OAI Server: /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2014-01-09&until=2014-01-09 - At the end of the result, you will see a resumption token which looks like that: marcxml/47/2014-01-09/2014-01-09/ This is wrong. No resumptiion token should be sent since there isn't anymore records to harvest. - Apply the patch. - Resend the OAI-PMH request. There is no resumption token at the end of the result. - You could test also with ListIdenfiers verb in place of ListRecord. Signed-off-by: Christophe Brocquet Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:48:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:48:45 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 10:48:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 09:48:59 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 11:52:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 10:52:51 +0000 Subject: [Koha-bugs] [Bug 13730] New: Install required when using web-based installer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13730 Bug ID: 13730 Summary: Install required when using web-based installer Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: ravijoshi9590 at yahoo.co.in QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 36019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36019&action=edit koha error log file after inserting kohastructure.sql and systempreference.sql within koha databse it showing me error in the context.pm that indicates username and password issue i inserted manually within the context.pm. after restarting the services i have getting below errors. in the log let me know the correct steps for the web installer. [Thu Feb 19 16:08:37 2015] [error] [client 192.168.1.104] [Thu Feb 19 16:08:37 2015] mainpage.pl: Install required, redirecting to Installer at /usr/share/koha/lib/C4/Auth.pm line 627. [Thu Feb 19 16:08:37 2015] [error] [client 192.168.1.104] [Thu Feb 19 16:08:37 2015] Context.pm: Subroutine C4::Context::confess redefined at /usr/local/share/perl5/Exporter.pm line 66. [Thu Feb 19 16:08:37 2015] [error] [client 192.168.1.104] [Thu Feb 19 16:08:37 2015] Context.pm: Subroutine C4::Context::croak redefined at /usr/local/share/perl5/Exporter.pm line 66. [Thu Feb 19 16:08:37 2015] [error] [client 192.168.1.104] [Thu Feb 19 16:08:37 2015] Context.pm: Subroutine C4::Context::carp redefined at /usr/local/share/perl5/Exporter.pm lin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 11:56:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 10:56:06 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 11:56:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 10:56:09 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35986|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 36020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36020&action=edit Bug 13679 : Bug in listing overdues To test 1/ Create some overdues and some issues due in the future 2/ Run the overdues script 3/ Notice item due in the future is in the list 4/ Apply patch 5/ Run script again 6/ Notice in the future not in the list Signed-off-by: Nick Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 11:58:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 10:58:01 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #9 from Jonathan Druart --- I am raising the severity of this bug. I confirm it could affect the -t parameter also. For instance, if you have a trigger at day = X and you have 2 overdue items due at today - X and today + X, both will be marked as late. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:02:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:02:20 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34817|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36021&action=edit Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:05:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:05:06 +0000 Subject: [Koha-bugs] [Bug 13719] Store list of objects as needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 --- Comment #3 from Kyle M Hall --- (In reply to Tom?s Cohen Arazi from comment #2) > Kyle, what would "Store list of objects" mean? I'm sorry but it is too > generic for my idiomatic limitations! Sorry, I was just posting the code to get it out there. I will be writing up a better explanation and a test plan shortly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:16:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:16:43 +0000 Subject: [Koha-bugs] [Bug 13719] Store list of objects as needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 --- Comment #4 from Kyle M Hall --- We can both simplify and improve the functioning of Koha::Objects by removing out reliance on DBIC for set iteration ( first(), next(), reset(), etc ). The problem is that DBIC destroys and refetches results every time reset() is called. For example, take the following code: my $borrowers = Koha::Borrowers->search({ firstname => 'Kyle' }). my $kyle1 = $borrowers->next(); $borrowers->reset(); my $kyle2 = $borrowers->next(); In this case, we would expect $kyle1 and $kyle2 to refer to the exact same object in memory, but they do *not*. This is simply a limitation of DBIx::Class. However, by handling this issue ourselves, we not only solve the problem, but I believe we also reduce the complexity of our code. This is all accomplished without changing the external behavior of the Koha::Objects module. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Borrowers.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:17:43 +0000 Subject: [Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Store list of objects as |Make Koha::Objects store |needed |list of resultant objects | |on an as needed basis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:20:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:20:01 +0000 Subject: [Koha-bugs] [Bug 13731] New: Suggestions reason Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Bug ID: 13731 Summary: Suggestions reason Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org When you, as librarian make decisions about purchase suggestions, you can choose one of the SUGGEST authorized value, which describes, why do you decide this way. But, unfortunetely, this reason isn't presented anywhere, it looks like it isn't saved into database either... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:21:34 +0000 Subject: [Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35985|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 36022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36022&action=edit Bug 13719 - Make Koha::Objects store list of resultant objects on an as needed basis We can both simplify and improve the functioning of Koha::Objects by removing out reliance on DBIC for set iteration ( first(), next(), reset(), etc ). The problem is that DBIC destroys and refetches results every time reset() is called. For example, take the following code: my $borrowers = Koha::Borrowers->search({ firstname => 'Kyle' }). my $kyle1 = $borrowers->next(); $borrowers->reset(); my $kyle2 = $borrowers->next(); In this case, we would expect $kyle1 and $kyle2 to refer to the exact same object in memory, but they do *not*. This is simply a limitation of DBIx::Class. However, by handling this issue ourselves, we not only solve the problem, but I believe we also reduce the complexity of our code. This is all accomplished without changing the external behavior of the Koha::Objects module. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Borrowers.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:21:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:21:32 +0000 Subject: [Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:23:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:23:01 +0000 Subject: [Koha-bugs] [Bug 13595] Checking out an issued item doesn't return it after confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13595 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #3 from Josef Moravec --- I can't reproduce it now, so closing this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:26:19 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #12 from Jonathan Druart --- Actually this patch is stuck in NSO without any test plan. Since I really would like to see a logging module integrated into Koha, I just try to make this moving forward. So let's test this lazily: $ git bz apply 13413 # ok Try to use the module: diff --git a/C4/Context.pm b/C4/Context.pm index c5f92ee..9a88758 100644 --- a/C4/Context.pm +++ b/C4/Context.pm @@ -107,6 +107,8 @@ use DateTime::TimeZone; use Module::Load::Conditional qw(can_load); use Carp; +use Koha::Log qw(:log with_debug); + =head1 NAME C4::Context - Maintain and manipulate the context of a Koha script @@ -564,6 +566,7 @@ sub preference { } $sysprefs{lc $var} = $value; + log_debug{"pref $var = $value"}; return $value; } diff --git a/mainpage.pl b/mainpage.pl index ab3a7ab..635a233 100755 --- a/mainpage.pl +++ b/mainpage.pl @@ -30,6 +30,8 @@ use C4::Suggestions qw/CountSuggestion/; use C4::Tags qw/get_count_by_tag_status/; use Koha::Borrower::Modifications; +use Koha::Log qw(:log with_debug); + my $query = new CGI; my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user( @@ -42,6 +44,8 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user( } ); +log_debug{'User on the mainpage!'}; + my $homebranch; if (C4::Context->userenv) { $homebranch = C4::Context->userenv->{'branch'}; $ tail -f koha_logs Go on the mainpage. boom, module is missing ok let's install it (no mention in the commit messages) $ sudo apt-get install liblog-contextual-perl Go on the mainpage, nothing in the logs. Ha, debug no defined, let's replace with log_info Go on the mainpage. The messages appear in the logs \o/ So the question is: How can I configure a log level for all the application? perldoc Koha/Log.pm mentions 3 levels: debug, info, warn. What about others? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:28:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:28:16 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #13 from Jonathan Druart --- Did you read the discussion on bug 8190? There are a lot of ideas on it. The way to use it is: my $logger = C4::Context->logger(); $logger->info("OPAC: Search for $query"); You can have a look at the tests for more information. All the job is mainly done in the constructor (Koha::Utils::Logger->new) and the write method. And a syspref controls the log level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:34:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:34:27 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Signed Off |ASSIGNED --- Comment #13 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > I think the other problem blocking this is that people haven't been able to > see the issue, could we get a more detailed test plan? > Maybe with an example date? Could we get an answer? Please add the syspref value + the dates to reproduce the issue. Confirm the issue is still on master. Back to assigned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:47:58 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Lennon Mazonde changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |okay7675 at gmail.com --- Comment #40 from Lennon Mazonde --- (In reply to Martin Renvoize from comment #1) > I'm seeing this issue more and more on IRC as people upgrade their package > installs. > > The symptom is the appearance of the below error when searching, or looking > at MRC Framework pages and a few other places: > > Open of share file /tmp/sharefile-koha-koha failed: Permission denied at > /usr/lib/perl5/Cache/FastMmap.pm line 640. > > The fastest fix I've found to get your system back up and running whilst I > work on a longer term fix, is to: > > 1) Add/Set 'SetEnv MEMCACHED_NAMESPACE="instancename"' per instance you have > running in the apache virtual host configuration > 2) Delete the existing temp file /tmp/somthing-koha-koha > > This will ensure koha creates a seperate temp file for caching pursposes on > a epr instance basis, and the deletion will ensure it happens upon the next > request per instance. Hello, this seems to have worked for me. I have two instances of koha running on my server. After making the adjustments as suggested above, two temp files are now being created- sharefile-koha-xxa, sharefile-koha-xxb. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:48:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:48:36 +0000 Subject: [Koha-bugs] [Bug 13730] Install required when using web-based installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13730 Ravi Joshi changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:54:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:54:28 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36017|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 36023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36023&action=edit Bug 7843 Create an RSS feed for news in Opac Test plan: * Install the patch * Make shure there is news in the Opac * Go to the Opac (opac-main.pl) * Make shure you see an RSS icon below the news and a short text. * Click the RSS icon and verify that you get an RSS feed that validates. Signed-off-by: Chris Cormack I took the liberty of fixing the copyright statement when signing it off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:54:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:54:25 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:54:32 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #12 from Jonathan Druart --- Created attachment 36024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36024&action=edit Bug 7843: Remove the useless use of casAuthentication Certainly a c/p error from opac-main.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:54:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:54:36 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #13 from Jonathan Druart --- Created attachment 36025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36025&action=edit Bug 7843: (qa-followup) Create an RSS feed for news in Opac 1/ use strict and warnings are useless, Modern::Perl is used 2/ Prefer to use the interface and theme TT var instead of the hard coded path -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:55:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:55:34 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 12:55:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 11:55:37 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36009|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36026&action=edit Bug 13729 - Give news in Opac a unique anchor This patch introduces the use of the idnew-value from the opac_news table as a base for a unique anchor on each newsitem in Opac. The anchor can be used for linking to specific newsitems and also for improving bug 7843 (RSS stream for news) with a unique link to each item in the RSS stream. Test plan: * Make shure you have a few news in the opac. Best is if it's enough to hide a few beneath the bottom of the window. * Install the patch. * Verify that you can access newitems with links like mykoha/cgi-bin/koha/opac-main.pl#newsitem4 * Experiment with removing newsitems and verify that that the newsitem-id stay unique to each newsitem. Signed-off-by: Magnus Enger Works as advertised. Nice enhancement! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 13:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 12:26:49 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 13:26:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 12:26:53 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28358|0 |1 is obsolete| | Attachment #28359|0 |1 is obsolete| | Attachment #28360|0 |1 is obsolete| | Attachment #28361|0 |1 is obsolete| | Attachment #28367|0 |1 is obsolete| | --- Comment #63 from Kyle M Hall --- Created attachment 36027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36027&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 13:27:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 12:27:19 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36027|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall --- Created attachment 36028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36028&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 13:27:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 12:27:30 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #65 from Kyle M Hall --- Created attachment 36029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36029&action=edit Bug 10276 [QA Followup] - Extend IndependentBranches to support groups of libraries Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 13:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 12:27:34 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #66 from Kyle M Hall --- Created attachment 36030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36030&action=edit Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 13:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 12:27:37 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #67 from Kyle M Hall --- Created attachment 36031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36031&action=edit Bug 10276 [QA Followup 3] - Fix inability to change patron's branch Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 13:27:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 12:27:41 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #68 from Kyle M Hall --- Created attachment 36032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36032&action=edit Bug 10276 [QA Followup 4] - Fix edit links on catalogue/detail.pl Bug 11746 has been pushed to master, which is good. However, this means that the links displayed in the catalogue/details.pl page are displaying Edit on items which the user should not have edit links for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 13:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 12:28:31 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #21 from Tom?s Cohen Arazi --- Oh, sorry for that. I think it was a typo using git-bz. Will test right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 13:59:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 12:59:12 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23638|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 36033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36033&action=edit Bug 10278 - Add ability to hide items and records from search results for Independent Branches For the staff intranet, enabling IndependentBranchesRecordsAndItems will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library. In add addition, all items whose homebranch is not that libraries will be filtered and hidden from the search results and record details. This system preference will not affect the OPAC, unless the environment variable BRANCHCODE is defined in the koha-httpd.conf file. If it is defined, the same filters are applied to the OPAC, but based on the branchcode value of the environment variable BRANCHCODE, rather than the logged in branch. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesRecordesAndItems 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:11:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:11:46 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #22 from Tom?s Cohen Arazi --- I'm sorry Jonathan. It is now pushed. I might have messed up some of my working branches at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:12:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:12:01 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #16 from Tom?s Cohen Arazi --- I'm sorry Jonathan. It is now pushed. I might have messed up some of my working branches at s ome point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:12:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:12:27 +0000 Subject: [Koha-bugs] [Bug 13712] Missing newline in DB update 3.19.00.010 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:12:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:12:56 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:19:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:19:51 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- Unfortunately this one is not cleanly applying after I pushed 12976 and 12970. Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:37:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:37:37 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:37:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:37:41 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35624|0 |1 is obsolete| | Attachment #35625|0 |1 is obsolete| | Attachment #35626|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 36034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36034&action=edit Bug 13244: Merge GetOrders and GetCancelledOrders These two subroutines did the same job (same select, same join, etc.) Test plan: Go on the basket list page and verify you see the pending and the cancelled baskets. Signed-off-by: Marcel de Rooy Two small things are adjusted in separate follow-ups. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:37:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:37:46 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 --- Comment #21 from Jonathan Druart --- Created attachment 36035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36035&action=edit Bug 13244: (follow-up) fix mixup to and from in the sql query Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:38:10 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #69 from M. Tompsett --- Comment on attachment 36030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36030 Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Review of attachment 36030: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=36030) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2401,5 @@ > + my @branches = GetIndependentGroupModificationRights(); > + $query .= > + " AND ( borrowers.branchcode = ? OR borrowers.branchcode IN ( " > + . join( ',', ('?') x @branches ) . " ) ) "; > + push( @query_params, @branches ); There is @branches+1 ?'s, but only @branches parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:38:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:38:30 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 --- Comment #22 from Jonathan Druart --- Rebased, second patch skipped (not used anymore). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:39:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:39:54 +0000 Subject: [Koha-bugs] [Bug 13722] Titles with articles not sorting correctly in lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.16 |master --- Comment #1 from Owen Leonard --- This bug could just as easily be titled "Teach Koha how to ignore nonfiling characters," because Koha doesn't take nonfiling characters into account at all. As far as I understand it, Zebra can be configured to ignore certain stop words, and some tables which are sorted by JavaScript are configured to ignore articles on titles. Anything which is sorted by MySQL is going to be ignorant of stop words or nonfiling characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:58:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:58:04 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36013|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36036&action=edit Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:58:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:58:00 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 14:58:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 13:58:34 +0000 Subject: [Koha-bugs] [Bug 13732] New: Incorrect total charges on the checkouts table in a patron record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13732 Bug ID: 13732 Summary: Incorrect total charges on the checkouts table in a patron record Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 36037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36037&action=edit Screenshot showing 0.00 total under the charges column The patron checkouts table contains a column for charges. The total at the bottom of this column is the total fines, not total charges. Therefore, the situation can arise where the list of charges each contains 0.00 in the charge column, but the total contains a different value entirely, for example: Item 1 : 0.00 Item 2 : 0.00 Total : 8.00 The charges column is not the same as fines, so the charges total shouldn't be displaying the fines total. A possible solution might be to include a column for fines in addition to the charges column (possibly instead of the replacement price field, which is of little use in this table). The attached screenshot is from a 3.10.13 system, but the problem is still apparent on a 3.18.x system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:00:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:00:22 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEPENDS ON 11708] Display |Display basketgroup closed |basketgroup closed date at |date at OPAC |OPAC | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:04:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:04:26 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Jonathan Druart --- (In reply to paxed from comment #68) > (In reply to Kyle M Hall from comment #67) > > Created attachment 35846 [details] [review] [review] > > Just wondering if http:// vs https:// matters for this: > > + // This is way faster than substring > + if ( ! ( sound.charAt(4) == ':' && sound.charAt(5) == '/' && > sound.charAt(6) == '/' ) ) { Good catch, maybe a regex is much more appropriate here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:13:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:13:42 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:13:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:13:45 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35958|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 36038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36038&action=edit Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch. Text appears as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Amended patch: add a br tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:15:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:15:17 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:15:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:15:19 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35955|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36039&action=edit Bug 13682 - Capitalization: Holds Queue This patch changes capitalization of Holds Queue to Holds queue in koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueu$ To test: Apply patch Go to Circulation > Holds queue page Verify that the capitalization is correct Signed-off-by: Magnus Enger Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:17:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:17:03 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:19:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:19:43 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, oleonard at myacpl.org --- Comment #14 from Jonathan Druart --- It does not look much nicer for me :) Ccing Owen to get his opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:28:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:28:18 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #37 from Jonathan Druart --- Hello H?ctor, Please have a look at the patch, it adds a massive chmod on a big part (all) of the Koha code :) 2310 files changed, 1370 insertions(+), 611 deletions(-) and 1.56Mb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:28:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:28:29 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:32:36 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #15 from Jonathan Druart --- oleonard: Joubu: I suggest "Changing collation in the database for the 'surname' column of the 'borrowers' table is helpful to make browsing by last name work in members-home.pl when using an alphabet outside of A-Z" oleonard: I don't like referring to "members-home.pl" but I don't know a better way to say it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:35:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:35:35 +0000 Subject: [Koha-bugs] [Bug 13732] Incorrect total charges on the checkouts table in a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13732 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:36:30 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #16 from Jonathan Druart --- Created attachment 36040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36040&action=edit Bug 13686: Change wording Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:53:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:53:46 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:53:49 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35998|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 36041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36041&action=edit Bug 13593: 'stock number' should be 'inventory number' To make Koha easier to use, we should use terms consistently. This patch fixes some occurrences of 'stock number' to be 'inventory number' as this is also the term used in the frameworks. Item search, accessible via the link from staff's advanced search 1) Do a search for items, but choose CSV as output 2) Verify that the header row says 'inventory number' Acquisition 3) Set AcqCreateItem to 'order' 4) Create a new order, check the labels on the item table in the order 5) Receive the order, check the labels on the item table on receive 6) Set AcqCreateItem to 'receive' 7) Check the item table on receiving an order Followed test plan (including item search with JavaScipt disabled). Headers / labels display as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:53:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:53:53 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 --- Comment #7 from Jonathan Druart --- Created attachment 36042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36042&action=edit Bug 13593: (follow-up) 'stock number' should be 'inventory number' Add one more. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 15:58:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 14:58:07 +0000 Subject: [Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 --- Comment #1 from Kyle M Hall --- Created attachment 36043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36043&action=edit Bug 12272 - Add new Koha::Service class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:08:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:08:01 +0000 Subject: [Koha-bugs] [Bug 13733] New: Give librarians the ability to add messages to an item Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Bug ID: 13733 Summary: Give librarians the ability to add messages to an item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some librarians would like the ability to leave messages attached to an item ( outside the scope of itemnotes and itemnotes_nonpublic ). This feature would give the librarians the ability to add and remove messages of arbitrary types defined in an authorised value list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:09:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:09:53 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Paola Rossi --- I've applied the patches against master 3.19.00.011 head 7741. My installation is a MARC21 one. The QP-file was the one in the $KOHA_KONF's XML element: /.....-dev/etc/searchengine/queryparser.yaml which I had linked to the truly patched QP-file [not in the dev library]: /..../etc/searchengine/queryparser.yaml via a symb link. I've set the syspref "UseQueryParser" to "Do not try" and to "Try", as required, to test. The following 5 search test cases had been submitted to the intranet catalog's simple search. To the log activated by: >zebrasrv -f $KOHA_KONF these were these differences between "Try" and "Do not try": 1) bio:a try: RPN @attrset Bib-1 @attr 4=6 @attr 5=1 @attr 1=8834 @attr 2=102 a dnt: RPN @attrset Bib-1 @attr 1=8834 a 2) aceee [i.e. a single word in simple search...] try: RPN @attrset Bib-1 @or @or @attr 4=6 @attr 5=1 @attr 1=1016 @attr 2=102 aceee @attr 4=6 @attr 5=1 @attr 9=20 @attr 2=102 aceee @attr 4=6 @attr 5=1 @attr 9=34 @attr 2=102 aceee dnt: RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 ACEEE 3) tpubdate:c try: RPN @attrset Bib-1 @attr 4=6 @attr 5=1 @attr 1=8806 @attr 2=102 c dnt: RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 tpubdate:c 4) pn:rossi try: RPN @attrset Bib-1 @attr 4=6 @attr 5=1 @attr 1=Personal-name @attr 2=102 rossi dnt: RPN @attrset Bib-1 @attr 1=Personal-name rossi For documentation, no differences about these other searching cases: 5) pn,wrdl:rossi [on simple search] RPN @attrset Bib-1 @attr 1=Personal-name @attr 4=6 rossi 6) Personal Name rossi [on advanced search]: RPN @attrset Bib-1 @attr 1=Personal-name @attr 4=6 @attr 5=1 rossi IMO in 1), 3) and 4) desc rilevance has been added. In 3) on dnt the index "tpubdate" has not been recognized (IMO RIGHT) and so it has become the keyword index 1016. Are those differences real errors? I'm not sure. For now I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:10:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:10:07 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:10:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:10:09 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 --- Comment #1 from Kyle M Hall --- Created attachment 36044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36044&action=edit Bug 13733 - Give librarians the ability to add messages to an item Some librarians would like the ability to leave messages attached to an item ( outside the scope of itemnotes and itemnotes_nonpublic ). This feature would give the librarians the ability to add and remove messages of arbitrary types defined in an authorised value list. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create some ITEM_MESSAGE authorised values 4) View an item's details 5) Try adding and deleting messages on an item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:10:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:10:32 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13563, 12272 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:10:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:10:32 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13733 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:10:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:10:32 +0000 Subject: [Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13733 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:18:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:18:03 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36044|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 36045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36045&action=edit Bug 13733 - Give librarians the ability to add messages to an item Some librarians would like the ability to leave messages attached to an item ( outside the scope of itemnotes and itemnotes_nonpublic ). This feature would give the librarians the ability to add and remove messages of arbitrary types defined in an authorised value list. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create some ITEM_MESSAGE authorised values 4) View an item's details 5) Try adding and deleting messages on an item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:29:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:29:02 +0000 Subject: [Koha-bugs] [Bug 13727] Validation of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13727 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org Severity|enhancement |normal Component|Cataloging |System Administration CC| |gmcharlt at gmail.com OS|Linux |All Hardware|PC |All -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 16:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 15:47:16 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 17:35:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 16:35:32 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #70 from M. Tompsett --- For reason given in comment #69. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 17:44:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 16:44:27 +0000 Subject: [Koha-bugs] [Bug 13730] Install required when using web-based installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13730 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug report. Support requests should be made on the Koha mailing list, on IRC, or by contracting with a support vendor. All these options are linked to here: http://koha-community.org/support/ Be sure to include details about the version of Koha you're using and the method of installation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 17:44:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 16:44:50 +0000 Subject: [Koha-bugs] [Bug 13734] New: RDA: Display 33xs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Bug ID: 13734 Summary: RDA: Display 33xs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 10344 Created attachment 36046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36046&action=edit example It would be nice to have the option to see the new 33x fields in the staff and the OPAC. They should have their own ID tag though so they can be hidden by those who don't want to see them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 17:44:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 16:44:50 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13734 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 17:45:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 16:45:36 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 17:50:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 16:50:00 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #1 from Owen Leonard --- When viewing accepted suggestions in the staff client you should see a "status" column which includes the reason which was specified when the suggestion was accepted. The information is stored in the "reason" column in the suggestions table. Are you not seeing it like that, or are you expecting it to display somewhere else? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 17:53:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 16:53:00 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36045|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 36047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36047&action=edit Bug 13733 - Give librarians the ability to add messages to an item Some librarians would like the ability to leave messages attached to an item ( outside the scope of itemnotes and itemnotes_nonpublic ). This feature would give the librarians the ability to add and remove messages of arbitrary types defined in an authorised value list. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create some ITEM_MESSAGE authorised values 4) View an item's details 5) Try adding and deleting messages on an item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 18:47:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 17:47:35 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 20:08:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 19:08:56 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #14 from Nick Clemens --- Taking a guess at problems I had in bug 13679 I was able to recreate the issue today. Materials needed to be issued prior to today, but due today. I checked out an item as due today (February 19, 2015) , updated the issuedate to set it to 8 days prior (February 11, 2015), then printed a due slip: item showed as overdue Applied patch: Item no longer showed as overdue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 20:14:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 19:14:59 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 20:15:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 19:15:02 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31280|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 36048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36048&action=edit [SIGNED OFF] Bug 12847 - Date comparisons in C4::Members::IssueSlip are broken Test Plan: 1) Ensure you have the default Koha issue slip 2) Check out an item 3) Print the issue slip for that patron 4) Even though the item is not overdue, it will show in the 'Overdues' section 5) Apply this patch 6) Re-print the issue slip 7) The item should no longer be in the overdues section Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 20:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 19:15:11 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35969|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 36049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36049&action=edit [SIGNED OFF] Bug 12847 [Follwup] - Remove code that calculates "overdue" key as C4::Members::GetPendingIssues already creates it Signed-off-by: Laurie McKee Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 20:28:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 19:28:35 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 20:28:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 19:28:38 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35934|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 36050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36050&action=edit [SIGNED OFF] Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 20:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 19:46:48 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to marc subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Nick Clemens --- Applying: Bug 8643 - Add important constraint to marc subfields Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging cataloguing/addbiblio.pl Auto-merging admin/marctagstructure.pl Auto-merging admin/marc_subfields_structure.pl Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 8643 - Add important constraint to marc subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:08:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:08:54 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:08:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:08:56 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34539|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 36051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36051&action=edit [SIGNED OFF] Bug 10773 - Add item-level descriptions for Label Printing This patch adds new fields ccode_description, homebranch_description, holdingbranch_description, location_description and permanent_location_description which can be used in the Label Creator to display names/descriptions instead of codes Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch_description" and perhaps "ccode_description" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Verify that you see descriptions for fields which you added Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:09:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:09:06 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35031|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 36052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36052&action=edit [SIGNED OFF]Bug 10773 - add help for *_description fields Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:11:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:11:29 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:15:55 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 --- Comment #4 from Marc V?ron --- Created attachment 36053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36053&action=edit [Signed-off] Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. I could not verify step 1/, because at least one Patron category can not be deleted (Staff, since I'm logged in as a Staff patron and you can not delete categories that are in use). Tested 0/ and 2/ Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:16:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:16:23 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:16:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:16:48 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:17:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:17:14 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:31:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:31:14 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 21:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 20:31:17 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35478|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 36054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36054&action=edit [SIGNED OFF]Bug 9528 - Add delivery branch to the place hold display When viewing the list of a patron's holds from the circulation or patron detail page the pickup library is not listed. This patch adds a column to the table of holds which shows the pickup branch. This patch also removes some unnecessary markup from the generation of the table and corrects an instance where the term "reserve" was used instead of "hold." This patch also modifies the language describing an item which is marked waiting at the current library: "Item is waiting here" instead of "Item waiting." To test, add several holds to a patron's account with various pickup locations. - Confirm that those pickup locations are correctly displayed under the Holds tab in Circulation. - Check in and confirm a hold which is to be picked up at the current branch. Confirm that the revised language appears. - Confirm that table sorting works correctly. Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 22:48:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 21:48:41 +0000 Subject: [Koha-bugs] [Bug 6223] Patron categories should have a default set of permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6223 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 19 23:30:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Feb 2015 22:30:00 +0000 Subject: [Koha-bugs] [Bug 6223] Patron categories should have a default set of permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6223 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 02:41:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 01:41:33 +0000 Subject: [Koha-bugs] [Bug 12238] tools/export.pl: file list of ids as input parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12238 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 02:45:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 01:45:21 +0000 Subject: [Koha-bugs] [Bug 13735] New: public note characer limitation when editing item in serials module Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Bug ID: 13735 Summary: public note characer limitation when editing item in serials module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jb.australian at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Although the public note subfield is set to have a character limitation of 9999, it only allows 255 characters when adding an item through receive function in the serials module. It is possible to add more characters to this field for items created this way by editing them in the biblio record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 05:32:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 04:32:30 +0000 Subject: [Koha-bugs] [Bug 13736] New: Enable EDS Plugin Patch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736 Bug ID: 13736 Summary: Enable EDS Plugin Patch Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: contact at alvet.com.au QA Contact: testopia at bugs.koha-community.org The EDS plugin requires 2 files to be patched. OPEN doc-dead-close.inc in \opac\htdocs\opac-tmpl\\includes and add the below line to the end of the file. [% IF ( EDSEnabled ) %][% END %] OPEN Auth.pm in \lib\C4 and add the below line after CalendarFirstDayOfWeek => at approx. line 397 EDSEnabled => C4::Context->preference("EDSEnabled"), -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 05:40:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 04:40:56 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 05:40:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 04:40:58 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35926|0 |1 is obsolete| | --- Comment #31 from Brendan Gallagher --- Created attachment 36055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36055&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 05:41:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 04:41:21 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35927|0 |1 is obsolete| | --- Comment #32 from Brendan Gallagher --- Created attachment 36056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36056&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 05:41:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 04:41:30 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35928|0 |1 is obsolete| | --- Comment #33 from Brendan Gallagher --- Created attachment 36057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36057&action=edit Bug 12802: FIX use the first valid email address if noemail is needed Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 05:41:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 04:41:37 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35929|0 |1 is obsolete| | --- Comment #34 from Brendan Gallagher --- Created attachment 36058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36058&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 05:41:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 04:41:46 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35930|0 |1 is obsolete| | --- Comment #35 from Brendan Gallagher --- Created attachment 36059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36059&action=edit Bug 12802: Fix QA script issues FAIL C4/Reserves.pm FAIL pod Spurious =cut command in file C4/Reserves.pm Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 05:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 04:45:15 +0000 Subject: [Koha-bugs] [Bug 13736] Enable EDS Plugin Patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736 Alvet changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |contact at alvet.com.au Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |contact at alvet.com.au --- Comment #1 from Alvet --- Created attachment 36060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36060&action=edit EDS Plugin Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 08:56:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 07:56:28 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #2 from Josef Moravec --- I can't see it anywhere... and in the database, in table suggestions, i have just NULL value in column reason in every row. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 10:15:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 09:15:13 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Since I don't have a syndetics account, I am not able to test this patch. But I am wondering if get_syndetics_index could return directly if no isbn is given, it'd avoid a call to the webservice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 10:31:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 09:31:10 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 10:31:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 09:31:12 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36054|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 36061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36061&action=edit Bug 9528 - Add delivery branch to the place hold display When viewing the list of a patron's holds from the circulation or patron detail page the pickup library is not listed. This patch adds a column to the table of holds which shows the pickup branch. This patch also removes some unnecessary markup from the generation of the table and corrects an instance where the term "reserve" was used instead of "hold." This patch also modifies the language describing an item which is marked waiting at the current library: "Item is waiting here" instead of "Item waiting." To test, add several holds to a patron's account with various pickup locations. - Confirm that those pickup locations are correctly displayed under the Holds tab in Circulation. - Check in and confirm a hold which is to be picked up at the current branch. Confirm that the revised language appears. - Confirm that table sorting works correctly. Signed-off-by: Nick Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 10:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 09:36:24 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #17 from Jonathan Druart --- Kyle (or someone else), Could you add some tests to highlight the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 10:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 09:42:40 +0000 Subject: [Koha-bugs] [Bug 11156] check-url.pl is not utf friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- I think we can consider this as invalid. Please reopen if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 10:59:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 09:59:02 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 10:59:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 09:59:05 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #16 from Jonathan Druart --- Created attachment 36062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36062&action=edit Bug 8436: Replace GetBranches with GetBranchesLoop The branch selection logic still exists in GetBranchesLoop, it should be used here. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:18:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:18:41 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13596 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:18:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:18:41 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10855 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:20:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:20:26 +0000 Subject: [Koha-bugs] [Bug 12994] Batch modifications for records - preview marc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12395 |11395 --- Comment #2 from Jonathan Druart --- Typo, it was bug 11395. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:20:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:20:26 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12994 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:20:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:20:26 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12994 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:20:55 +0000 Subject: [Koha-bugs] [Bug 12994] Batch modifications for records - preview marc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- This is done in bug 11395. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:33:52 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:33:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:33:56 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #44 from Jonathan Druart --- Created attachment 36063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36063&action=edit Bug 12395: Display created_by even if surname is missing on receiving On receiving orders, "no name" was displayed if the surname of creator was not filled. The firstname should be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:35:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:35:01 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #45 from Jonathan Druart --- Paola, I think I have found your problem. If the firstname (or surname) was not filled, "no name" was display on this screen. The last patch should fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:36:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:36:39 +0000 Subject: [Koha-bugs] [Bug 12291] remove acronym for CAS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Attachment #28348|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Comment on attachment 28348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28348 Bug 12291 - remove acronym for CAS (prog) Since the prog theme has been deleted, this patch is not needed anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:39:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:39:59 +0000 Subject: [Koha-bugs] [Bug 12291] remove acronym for CAS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 --- Comment #6 from Jonathan Druart --- Fridolin, this should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:44:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:44:46 +0000 Subject: [Koha-bugs] [Bug 12291] remove acronym for CAS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:44:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:44:50 +0000 Subject: [Koha-bugs] [Bug 12291] remove acronym for CAS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28347|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 36064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36064&action=edit Bug 12291: Replace acronym with tag at the OPAC On the OPAC authentification page, the acronym tag is used, but deprecated. It should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym Test plan: Enable the CAS authentification and verify the tags have correctly been replaced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 11:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 10:45:15 +0000 Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|remove acronym for CAS |Replace the acronym HTML | |tag with abbr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:07:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:07:42 +0000 Subject: [Koha-bugs] [Bug 6271] GetItemIssue(s) : renewals in both items and issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- Is the issue still exist? Can we have an example? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:26:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:26:50 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:26:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:26:53 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33918|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 36065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36065&action=edit Bug 1985 - Email notification of new OPAC comments This feature adds YAS 'CommentModeratorsEmail', where an email (template code COMMENT_CREATED) is sent when a borrower creates/modifies an comment/review. The syspref is empty by default and no email is sent when the syspref is empty. This feature is needed because we want to alert our content moderators to take action when needed. Usually it is our librarians who write reviews and this improvement makes the process of moving Koha reviews to our CMS more smooth. TEST SETUP: -1. Run updatedatabase.pl to add the syspref and the new letter template. 0. Go to admin/preferences.pl?tab=opac, and set the 'CommentModeratorsEmail'-syspref to your email-address. TEST PLAN: 1. Log in to OPAC and find any Biblio. 2. Make a comment/review for it. 3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'. You should see the reasonable default message. You can change the message in tools/letter.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:30:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:30:18 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- (In reply to M. Tompsett from comment #4) > I think this will fail the koha qa tests. No need to be explicit with the > undef; Does this mean the patch work as expected? The failed QA status should not be used to raise QA issues when the bug is on the NSO step. It removes the patch from the NSO queue and won't be tested. However you can use it if the patch does not work as expected. This kind of issues will be caught on the QA step and can be fixed by the QAer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:30:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:30:51 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #9 from Jonathan Druart --- The last patch now passes the qa script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:31:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:31:37 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #10 from Jonathan Druart --- Comment on attachment 36065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36065 Bug 1985 - Email notification of new OPAC comments Review of attachment 36065: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=1985&attachment=36065) ----------------------------------------------------------------- ::: C4/Review.pm @@ +200,5 @@ > + > +=cut > + > +sub SendReviewAlert { > + my $review = shift; Olli, this $review is not used in the subroutine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:48:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:48:20 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:48:24 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36015|0 |1 is obsolete| | Attachment #36016|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 36066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36066&action=edit [PASSED QA] Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:48:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:48:31 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #16 from Kyle M Hall --- Created attachment 36067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36067&action=edit [PASSED QA] Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:53:49 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Jonathan Druart --- $ mysql MariaDB [koha]> drop database koha; MariaDB [koha]> create database koha CHARACTER SET utf8 COLLATE utf8_unicode_ci; $ git checkout master $ mysql < installer/data/mysql/kohastructure.sql $ git bz apply 13624 $ perl installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl DBD::mysql::db do failed: Duplicate foreign key constraint name 'koha/overduerules_fk' at installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl line 33. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:57:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:57:22 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:57:25 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36011|0 |1 is obsolete| | Attachment #36012|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 36068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36068&action=edit [PASSED QA] Bug 12669: Use floating timezone when handling dates without hours, minutes and seconds. Test plan: 1. Create a new serial record or pick an existing one; 2. Add a "New subscription" and set the "First issue publication date" and "Frequency" values so that the "Planned date" for a given issue hits a day where a transition to Daylight Saving Time (DST) occurs ex:. 1979-04-01 in Europe/Lisbon (http://www.timeanddate.com/time/change/portugal/lisbon?year=1979) ... use this website page as a source http://www.timeanddate.com/time/dst/2014.html to find a suitable transition to DST in your timezone in the current year. 3. From the "Subscription detail" page in Koha for the given record click the "Serial collection" link on the left side context menu. Expected result: Prior to applying the patch the error described in this bug report should occur. After the patch is applied the "Serial collection" page should load correctly. Signed-off-by: Colin Campbell Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:57:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:57:33 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 --- Comment #25 from Kyle M Hall --- Created attachment 36069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36069&action=edit [PASSED QA] Bug 12669: Centralize the timezone handle into Koha::DateUtils This patch adds unit tests for the previous changes and centralize the timezone handle into the Koha::DateUtils module. Like that the behavior will affect all date manipulations using this module (should be all dates in Koha). Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:59:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:59:24 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #17 from Jonathan Druart --- See comment 14, I was waiting for feedbacks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 12:59:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 11:59:49 +0000 Subject: [Koha-bugs] [Bug 6772] Implementation of a recommendations engine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6772 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- (In reply to Robin Sheat from comment #10) > It would need a lot more really. We're mostly leaving it here because we use > it, and other people might want it too. For eligibility to Koha, it'd need a > lot of work to address Fr?d?ric and Paul's points as well. But yes, new > namespace and unit tests would also be good things. Does it mean you don't plan to work on it anymore? If so, then could you remove your name from the assigned to field? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:01:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:01:28 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:01:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:01:30 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36050|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 36070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36070&action=edit [PASSED QA] Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. Signed-off-by: Nick Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:08:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:08:22 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #31 from Jonathan Druart --- Robin, which version of Memcached did you use? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:19:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:19:44 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35931|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 36071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36071&action=edit [PASSED QA] BUG 13596: Prevent utf8mb4 -> utf8 convertion utf8mb4 is a superset of utf8 and thus is compatible. We should not force an entire db change upon people who have proactively set utf8mb4 encoding before now. This patch also removed the deprecated use of ->tables stanza in favour of the table_info stanza. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:19:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:19:41 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:25:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:25:54 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:25:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:25:56 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36010|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 36072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36072&action=edit [PASSED QA] Bug 12858: Add error handling to Syndetics Index * Syndetics routines include a statement to check that the returned content from Syndetics is xml. The get_syndetics_index routine was missing this check and so when a 'not found' html page was returned the opac-detail page would take a long time to load whilst xml::simple attempted to parse the large html document. Test Plan 1. Enable Syndetics indexes on opac. 2. Head over to an opac-detail page on the opac. 3. Remove the ISBN from the same item in the staff client. 4. Reload the opac-detail page for the item noticeing a much slower page load. 5. Apply the patch 6. Reload the opac-detail page for the item and note that it now laods in a reasonable timescale again. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:26:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:26:07 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 --- Comment #7 from Kyle M Hall --- Created attachment 36073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36073&action=edit [PASSED QA] Bug 12858 [QA Followup] - Don't call webservice if we have no data Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:27:37 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36073|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 36074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36074&action=edit [PASSED QA] Bug 12858 [QA Followup] - Don't call webservice if we have no data Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:49:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:49:19 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #46 from Paola Rossi --- (In reply to Jonathan Druart from comment #45) > Paola, I think I have found your problem. > If the firstname (or surname) was not filled, "no name" was display on this > screen. > The last patch should fix that. Thanks, Jonathan. It fixes! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:53:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:53:59 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #47 from Paola Rossi --- (In reply to Jonathan Druart from comment #44) > Created attachment 36063 [details] [review] > Bug 12395: Display created_by even if surname is missing on receiving > > On receiving orders, "no name" was displayed if the surname of creator > was not filled. > The firstname should be displayed. The surname is mandatory ("Required") for a patron/borrower/creator. So I've changed the patch's subject to: Bug 12395: Display created_by even if firstname is missing on receiving > > On receiving orders, "no name" was displayed if the firstname of creator > was not filled. > The surname should be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:55:42 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:57:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:57:02 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35779|0 |1 is obsolete| | --- Comment #48 from Paola Rossi --- Created attachment 36075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36075&action=edit Bug 12395: Save order line's creator Thanks, Julian and Jonathan. I've applied the patches against master 3.19.00.011 head 13728. I've upgraded the DB. Then I've run misc/devel/update_dbix_class_files.pl on my branch. Everything was OK as required by the test plan (see comment #1). So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:57:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:57:27 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35780|0 |1 is obsolete| | --- Comment #49 from Paola Rossi --- Created attachment 36076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36076&action=edit Bug 12395 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:57:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:57:52 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35781|0 |1 is obsolete| | --- Comment #50 from Paola Rossi --- Created attachment 36077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36077&action=edit Bug 12395: Update aqorders.created_by with aqbasket.authorisedby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:58:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:58:21 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35782|0 |1 is obsolete| | --- Comment #51 from Paola Rossi --- Created attachment 36078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36078&action=edit Bug 12395: Add unit test to check created_by is correctly set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:58:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:58:45 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35864|0 |1 is obsolete| | --- Comment #52 from Paola Rossi --- Created attachment 36079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36079&action=edit Bug 12395: Fix call to set_userenv in unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 13:59:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 12:59:35 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36063|0 |1 is obsolete| | --- Comment #53 from Paola Rossi --- Created attachment 36080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36080&action=edit Bug 12395: Display created_by even if firstname is missing on receiving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:27:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:27:11 +0000 Subject: [Koha-bugs] [Bug 13737] New: Add Koha RESTful Services Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Bug ID: 13737 Summary: Add Koha RESTful Services Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We should add as many REST services as possible to Koha. This will not only give Koha the best third-party API possible, but we can utilize these services internally as well! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:27:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:27:21 +0000 Subject: [Koha-bugs] [Bug 13737] Add Koha RESTful Services In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12272 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:27:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:27:21 +0000 Subject: [Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13737 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:27:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:27:28 +0000 Subject: [Koha-bugs] [Bug 13737] Add Koha RESTful Services In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:27:54 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Koha RESTful Services |[OMNIBUS] Add Koha RESTful | |Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:28:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:28:49 +0000 Subject: [Koha-bugs] [Bug 13738] New: Add RESTful Borrower service Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Bug ID: 13738 Summary: Add RESTful Borrower service Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We should have a basic RESTful CRUD service for Koha patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:28:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:28:58 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13738 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:28:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:28:58 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13737 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:29:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:29:13 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12272 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:29:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:29:13 +0000 Subject: [Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13738 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:37:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:37:43 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 --- Comment #1 from Kyle M Hall --- Created attachment 36081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36081&action=edit [WIP] Bug 13738 - Add RESTful Borrower service -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:37:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:37:51 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:39:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:39:05 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #38 from H?ctor Eduardo Castro Avalos --- Hi Jonathan Yes, it's a big mistake. I will fix this and send the patch again. Regards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:43:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:43:52 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 --- Comment #2 from Kyle M Hall --- My first inclination is to remove the ability to fetch a borrower by multiple id types. Instead, I think we should force it to be my borrowernumber only, and if you don't have the borrowernumber, you can find it by searching ( not yet implemented ) on userid or cardnumber. Any thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:44:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:44:57 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:45:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:45:00 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35859|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 36082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36082&action=edit [PASSED QA] Bug 12631: Inventory: fix "wrong place" and "item not scanned" "item not scanned": when calling GetItemsForInventory, datelastseen should be used when "compare barcodes list to result" is checked. Otherwise, when loading multiple barcodes files for the same inventory, many items will be marked as "item not scanned" when loading the last barcode file ("compare barcodes list to result" checked) even though they were scanned. "wrong place": when searching for wrongly placed items, we should only check for the location (callnumbers, location and branch). To fix this, A new call to GetItemsForInventory has been made with location filters only. Otherwise, any item with a different itemtype for instance will be marked as wrong place even if the location is correct. Test plan: "item not scanned" status: 1) Split a barcode file in two. 2) Load the first barcode file without checking "compare barcodes list to result". 3) Load the second barcode file with "compare barcodes list to result" checked. 4) Check in the csv report that you have a lot of scanned items with the "item not scanned" status. Then apply the patch, do the same, and check that the false "item not scanned" statuses are gone. "wrong place" status: 1) Load a barcode file with barcode matching an item that has a correct location, but a different itemtype than what you're looking for. 2) Check in the results that this item will be marked as "change item status" and "wrong place". Then apply the patch, do the same, and check that the only status for this item is "change item status", which is correct. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:52:40 +0000 Subject: [Koha-bugs] [Bug 13506] Sip/Configuration/*.pm classes are unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:52:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:52:43 +0000 Subject: [Koha-bugs] [Bug 13506] Sip/Configuration/*.pm classes are unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35943|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 36083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36083&action=edit [PASSED QA] Bug 13506: Remove unused Sip/Configuration Classes Sip::Configuration calls new on Account, Institution and Service classes but does not store or subsequently use the returned objects ( which immediately go out of scope ). Their existence just obscures the code and misleads the reader. Remobe them Removed redundant commented out code from Configyration module which was not serving any useful purpose Ran Configuration.pm through perltidy to make layout more consistent Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 14:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 13:52:54 +0000 Subject: [Koha-bugs] [Bug 13506] Sip/Configuration/*.pm classes are unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 --- Comment #5 from Kyle M Hall --- Created attachment 36084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36084&action=edit Bug 13506 [QA Follouwp] - Fix POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:04:40 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:04:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:04:42 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36051|0 |1 is obsolete| | Attachment #36052|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 36085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36085&action=edit [PASSED QA] Bug 10773 - Add item-level descriptions for Label Printing This patch adds new fields ccode_description, homebranch_description, holdingbranch_description, location_description and permanent_location_description which can be used in the Label Creator to display names/descriptions instead of codes Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch_description" and perhaps "ccode_description" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Verify that you see descriptions for fields which you added Signed-off-by: Nick Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:04:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:04:50 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #15 from Kyle M Hall --- Created attachment 36086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36086&action=edit [PASSED QA] Bug 10773 - add help for *_description fields Signed-off-by: Nick Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:13:04 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Chr?s! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:13:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:13:35 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Rolando and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:14:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:14:02 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:14:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:14:33 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:14:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:14:57 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:15:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:15:24 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:22:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:22:21 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35932|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 36087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36087&action=edit [PASSED QA] Bug 13523 - AddBiblio fails on mysql with STRICT_TRANS_TABLES This patch removes the NOT NULL restriction on biblioitems.marcxml and deletedbiblioitems.marcxml due to STRICT_TRANS_TABLES default in Mysql 5.6.22 and onwards. Test: 1. check mysql global settings: mysql > SELECT @@GLOBAL.sql_mode; verify that STRICT_TRANS_TABLES is not set 2. set STRICT_TRANS_TABLES (or upgrade mysql to > 5.6.21) mysql > SET @@GLOBAL.sql_mode = 'STRICT_TRANS_TABLES'; 3. try to add biblio in Cataloguing module verify that it fails with a "software error" 4. apply patch 5. repeat 3 and verify that there is no "software error" any more Signed-off-by: Jonathan Druart I confirm with the problem with mariadb and STRICT_TRANS_TABLES enabled. On adding a biblio (C4::Biblio::AddBiblio), biblioitems is populate in _koha_add_biblioitem but marxcml is not generated yet. It's in ModBiblioMarc, few lines later. The NOT NULL condition is not valid here. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:22:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:22:18 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:30:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:30:53 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #17 from Kyle M Hall --- FAIL reports/report_files.pl FAIL critic I/O layer ":utf8" used at line 78, column 9. Use ":encoding(UTF-8)" to get strict validation. Bareword file handle opened at line 78, column 9. See pages 202,204 of PBP. FAIL forbidden patterns forbidden pattern: trailing space char (line 61) forbidden pattern: trailing space char (line 8) forbidden pattern: tab char (line 45) forbidden pattern: trailing space char (line 60) forbidden pattern: tab char (line 52) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 42) forbidden pattern: Koha is now under the GPLv3 license (line 13) forbidden pattern: tab char (line 43) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 44) forbidden pattern: tab char (line 40) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/report_files.tt FAIL forbidden patterns forbidden pattern: tab char (line 10) forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 5) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 19) forbidden pattern: tab char (line 30) forbidden pattern: tab char (line 18) forbidden pattern: tab char (line 9) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:36:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:36:56 +0000 Subject: [Koha-bugs] [Bug 13690] Koha::Schema should be lazy-loaded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:36:59 +0000 Subject: [Koha-bugs] [Bug 13690] Koha::Schema should be lazy-loaded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35961|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 36088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36088&action=edit [PASSED QA] Bug 13690: use Koha::Schema only when it's needed This patch makes Koha::Database lazy-load the whole Koha::Schema libraries. It doesn't seem to have negative effects, and makes scripts not using DBIx::Class notably faster [1]. Regards [1] If you read the DBIx::Class::Schema docs, it explains that it it uses Module::Find to load all schema files... http://search.cpan.org/~ribasushi/DBIx-Class-0.082810/lib/DBIx/Class/Schema.pm#load_namespaces Signed-off-by: Tomas Cohen Arazi Happy to sign this one. The only extra comment would be that DBIx::Class performance issues remain after this patch, but is being handled in a different bug. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:41:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:41:07 +0000 Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in Koha::Schema::Result::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35949|0 |1 is obsolete| | Attachment #35950|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 36089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36089&action=edit [PASSED QA] Bug 13713: Follow-up removing biblioitem routines There is no need to define biblioitem routines, if we can access them via biblioitemnumber. Note that we actually need a FK for biblio in the items table. Now we do need the intermediate level via biblioitems in the Items.t code. Even better, we should move biblioitem to biblio. Formally it is 1-n, but in reality it is 1-1. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:41:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:41:04 +0000 Subject: [Koha-bugs] [Bug 13713] Remove useless constraint in Koha::Schema::Result::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13713 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:47:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:47:10 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:47:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:47:13 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35990|0 |1 is obsolete| | Attachment #35991|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 36090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36090&action=edit [PASSED QA] Bug 12948: Use word indexing for language (NORMARC) This patch is for Normarc Same test plan as patch for MARC21, except you need a setup with Normarc. http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger - Added a record with "bul" in 008pos35-37 - Verified that this did not turn up in an advanced search with language = Bulgarian - Applied the patch - I was testing on a gitified install, so I had to copy the patched index file to the right location with this command: sudo cp etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl - Did a full reindex - Verified that the record *did* turn up in an advanced search with language = Bulgarian - Signing off! Thanks Zeno! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:49:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:49:52 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 --- Comment #14 from Kyle M Hall --- Created attachment 36091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36091&action=edit [PASSED QA] Bug 12948: Use word indexing for language (MARC21) This patch is for MARC21. To test: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger I have *not* actually tested this, but the changes are identical to the ones done for NORMARC, which I have tested, so I think it is safe to sign off. If anyone disagrees, please reset the bug to "Needs signoff". Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:52:54 +0000 Subject: [Koha-bugs] [Bug 13690] Koha::Schema should be lazy-loaded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks a lot Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:53:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:53:50 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Zeno! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:55:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:55:31 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:55:35 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35959|0 |1 is obsolete| | Attachment #35960|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 36092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36092&action=edit [PASSED QA] Bug 13645: Cache the DBIx connection We don't want to recreate a new connection to the DB every time we want a new schema. This patch creates a $database package level variable on the same way it's done in C4::Context for $dbh. Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:55:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:55:44 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #21 from Kyle M Hall --- Created attachment 36093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36093&action=edit [PASSED QA] Bug 13645: Use DBIx::Connector Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 15:55:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 14:55:47 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #22 from Kyle M Hall --- Created attachment 36094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36094&action=edit [PASSED QA] Bug 13645 [QA Followup] - Add DBIx::Connector to the list of dependancies Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 16:05:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 15:05:51 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13738 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 16:05:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 15:05:51 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13607 CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 16:26:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 15:26:11 +0000 Subject: [Koha-bugs] [Bug 13739] New: KohaDates should display hours if they exists by default unless specified Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 Bug ID: 13739 Summary: KohaDates should display hours if they exists by default unless specified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There are many parts of Koha that are new hiding hours by default. This is rarely helpful. KohaDates should display hours by default unless the time is 23:59, in which case the hours should be not be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 16:29:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 15:29:56 +0000 Subject: [Koha-bugs] [Bug 13739] KohaDates should display hours if they exists by default unless specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 16:29:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 15:29:59 +0000 Subject: [Koha-bugs] [Bug 13739] KohaDates should display hours if they exists by default unless specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 --- Comment #1 from Kyle M Hall --- Created attachment 36095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36095&action=edit Bug 13739 - KohaDates should display hours if they exists by default unless specified There are many parts of Koha that are now hiding hours by default. This is rarely helpful. KohaDates should display hours by default unless the time is 23:59, in which case the hours should be not be displayed. Test Plan: 1) Check out two items, one due at at an hour, one not 2) View the patron's circ history, note you don't see the hours 3) Apply this patch 4) View the circ history again, note the hours are listed for date/time where the time is not 23:59. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 16:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 15:31:17 +0000 Subject: [Koha-bugs] [Bug 13740] New: Timeout on deleting patrons if too many patrons Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 Bug ID: 13740 Summary: Timeout on deleting patrons if too many patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org C4::Borrowers::GetBorrowersToExpunge should not use a "NOT IN", it is not efficient at all. With only 1 guarantor and more than 136k patrons, the not in clause in this subroutine takes ages: mysql> select count(*) FROM borrowers where borrowernumber NOT IN (SELECT guarantorid FROM borrowers WHERE guarantorid IS NOT NULL AND guarantorid <> 0) ; [...] not ended after 5min -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 16:34:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 15:34:23 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 16:34:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 15:34:26 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 --- Comment #1 from Jonathan Druart --- Created attachment 36096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36096&action=edit Bug 13740: Remove the NOT NULL clause in GetBorrowersToExpunge C4::Borrowers::GetBorrowersToExpunge should not use a "NOT IN", it is not efficient at all. With only 1 guarantor and more than 136k patrons, the not in clause in this subroutine takes ages: mysql> select count(*) FROM borrowers where borrowernumber NOT IN (SELECT guarantorid FROM borrowers WHERE guarantorid IS NOT NULL AND guarantorid <> 0) ; [...] not ended after 5min With the query modified by this patch, the results come after 1 sec :) Test plan: Verify the delete_patrons.pl cronjob or the cleanborrowers tools work as before. Especially with guarantors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:01:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:01:39 +0000 Subject: [Koha-bugs] [Bug 11811] tools/import_borrowers.pl doesn't support utf-8 encoded CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #16 from Jonathan Druart --- I have just tested with the CSV file against master and it works \o/ Please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:04:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:04:26 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12979 CC| |jonathan.druart at biblibre.co | |m Status|In Discussion |ASSIGNED Assignee|aleksa at vujicic.com |oleonard at myacpl.org --- Comment #11 from Jonathan Druart --- Should be done on top of bug 12979, see Koha::Number::Price. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:04:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:04:26 +0000 Subject: [Koha-bugs] [Bug 12979] Price formatting should only be defined at one place In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4078 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:06:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:06:59 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:07:38 +0000 Subject: [Koha-bugs] [Bug 13739] KohaDates should display hours if they exists by default unless specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:07:38 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:09:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:09:31 +0000 Subject: [Koha-bugs] [Bug 13741] New: "No fund found" not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 Bug ID: 13741 Summary: "No fund found" not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The message "no funds found" that appears on the fund page before you have funds defined / koha-tmpl / intranet-tmpl / prog / en / modules / admin / aqbudgets.tt 421 [% ELSE %] 422 No fund found 423 [% END %] The problem might be that the text is not inside an HTML tag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:09:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:09:31 +0000 Subject: [Koha-bugs] [Bug 7879] Memoize::Memcached two times slower than it should be In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Dobrica, this is still valid? Where is the "discussion"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:09:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:09:43 +0000 Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:10:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:10:04 +0000 Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 --- Comment #1 from Katrin Fischer --- ... is not translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:14:06 +0000 Subject: [Koha-bugs] [Bug 6698] Detail page for organisations should show only valid fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- Is this still valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:14:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:14:32 +0000 Subject: [Koha-bugs] [Bug 12771] Enhancement to manage more than 3 levels of overdue notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12771 --- Comment #2 from Blou --- *** Bug 11092 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:14:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:14:32 +0000 Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from Blou --- I'm not sure exactly how to close this, but this bz will never get further. We have developped a much larger and improved solution described in http://wiki.koha-community.org/wiki/Overdue_Notice_Enhancement#Enhancement_to_manage_more_than_3_levels_of_overdue_notice The following bugzillas are involved for the various steps/patches: #13624,#12768,#12769,#12770,#12771 and #12772. That is where our energy is being put. *** This bug has been marked as a duplicate of bug 12771 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:15:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:15:43 +0000 Subject: [Koha-bugs] [Bug 8310] All parts an instance should be under one path In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:18:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:18:16 +0000 Subject: [Koha-bugs] [Bug 1918] Minify JavaScript and CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- Any progress here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:21:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:21:54 +0000 Subject: [Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #17 from Jonathan Druart --- It looks like a duplicate of bug 8952. *** This bug has been marked as a duplicate of bug 8952 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:21:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:21:54 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adrien.saurat at biblibre.com --- Comment #42 from Jonathan Druart --- *** Bug 7307 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:24:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:24:09 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, tomascohen at gmail.com --- Comment #4 from Jonathan Druart --- Tomas, Does this make sense for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:35:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:35:46 +0000 Subject: [Koha-bugs] [Bug 13742] New: Object accessor for overduerules- and overduerules_transport_types-tables. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13742 Bug ID: 13742 Summary: Object accessor for overduerules- and overduerules_transport_types-tables. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:35:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:35:59 +0000 Subject: [Koha-bugs] [Bug 13742] Object accessor for overduerules- and overduerules_transport_types-tables. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13742 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4171 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:35:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:35:59 +0000 Subject: [Koha-bugs] [Bug 4171] overduerules.pl needs an overhaul In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4171 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13742 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:39:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:39:01 +0000 Subject: [Koha-bugs] [Bug 13742] Object accessor for overduerules- and overduerules_transport_types-tables. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13742 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 36097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36097&action=edit Bug 13742 - Object accessor for overduerules- and overduerules_transport_types-tables. Adds a Koha::Cache:able OverdueRulesMap-object to present a nicer interface for using overduerules. Easily extendable to move a lot of scripting from overduerules.pl with proper setters. Unit test included. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:45:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:45:43 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35104|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 36098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36098&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:51:15 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36098|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 36099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36099&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:55:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:55:16 +0000 Subject: [Koha-bugs] [Bug 13742] Object accessor for overduerules- and overduerules_transport_types-tables. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13742 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 17:57:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 16:57:24 +0000 Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #2 from Paola Rossi --- I've applied the patch against master 3.19.00.011 head 12948. A) Step 5: Permission edit_subscription ON, receive_serials OFF: on /cgi-bin/koha/serials/subscription-detail.pl toolbar over "Subscription for [serial-title]: Master: "Edit" and "Close" are shown; no "New Subscription" is shown. APPLIED: "Edit", "Close" and "New Subscription" are shown. Selecting "New subscription" gets "Error: you do not have the permission to access this page ..." (RIGHT). Anyway, I think that adding "New subscription" is a regression error of this bug. B) Permission edit_subscription OFF, receive_serials ON : on /cgi-bin/koha/serials/subscription-detail.pl toolbar over "Subscription for [serial-title]:" Master: toolbar is shown but it's empty. APPLIED: "New Subscription" and "Receive" are shown. Selecting "Receive" works fine (RIGHT). Selecting "New subscription" gets "Error: you do not have the permission to access this page ..." (RIGHT). Anyway, I think that adding "New subscription" is an error of this bug (ERROR). C) Permission edit_subscription OFF, receive_serials ON : C1) on /cgi-bin/koha/serials/serials-collection.pl toolbar over "Serial collection information for [serial-title]:" Master: toolbar is shown but it's empty. APPLIED: no toolbar at all is shown (Is it RIGHT that the toolbar is empty? IMO yes, RIGHT fix). C2) on /cgi-bin/koha/serials/serials-collection.pl "Edit" column at the left of the issues table: Master: "disabled" is shown APPLIED: selectable checkboxes (RIGHT, a good fix out of the test plan). For the A) and B) errors I pass this patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 18:12:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 17:12:55 +0000 Subject: [Koha-bugs] [Bug 13505] No advanced constraints for subfields $t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13505 --- Comment #2 from Pablo AB --- Thanks Katrin! I confirm disabling Adblock solves the problem. Is a false positive from ABP, a filter rule filtering "###advt", as commented on closed (equivalent?) bug #11898, where Fridolin SOMERS consider this is an ABP issue, but the URL where he report it now gives 404 (domain a 403). Maybe following this instructions[0] and crossing fingers solve the problems. [0] https://adblockplus.org/en/getting_started#false-positives -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 18:28:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 17:28:35 +0000 Subject: [Koha-bugs] [Bug 13743] New: Primary key for issues-table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743 Bug ID: 13743 Summary: Primary key for issues-table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 18:34:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 17:34:59 +0000 Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 36100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36100&action=edit Bug 13743 - Primary key for issues-table Each table must have a primary key. This makes extending issues-related functionality much easier. TEST PLAN: 1. Check-out Items for you. 2. Check-in Items from you. 3. Check-out using the SIP2-server. 4. Check-in using the SIP2-server. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 18:41:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 17:41:13 +0000 Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36100|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 36101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36101&action=edit Bug 13743 - Primary key for issues-table Each table must have a primary key. This makes extending issues-related functionality much easier. TEST PLAN: 1. Check-out Items for you. 2. Check-in Items from you. 3. Check-out using the SIP2-server. 4. Check-in using the SIP2-server. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 18:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 17:43:29 +0000 Subject: [Koha-bugs] [Bug 13743] Primary key for issues-table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36101|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 36102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36102&action=edit Bug 13743 - Primary key for issues-table Each table must have a primary key. This makes extending issues-related functionality much easier. TEST PLAN: 1. Check-out Items for you. 2. Check-in Items from you. 3. Check-out using the SIP2-server. 4. Check-in using the SIP2-server. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 19:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 18:34:51 +0000 Subject: [Koha-bugs] [Bug 13742] Object accessor for overduerules- and overduerules_transport_types-tables. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13742 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36097|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 36103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36103&action=edit Bug 13742 - Object accessor for overduerules- and overduerules_transport_types-tables. Adds a Koha::Cache:able OverdueRulesMap-object to present a nicer interface for using overduerules. Easily extendable to move a lot of scripting from overduerules.pl with proper setters. Unit test included. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 19:49:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 18:49:05 +0000 Subject: [Koha-bugs] [Bug 13506] Sip/Configuration/*.pm classes are unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 19:49:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 18:49:44 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan and Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 20:25:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 19:25:59 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #8 from Kyle M Hall --- Created attachment 36104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36104&action=edit Add Zebra index "Other-control-number" covering MARC21 035$a, 035$z and 035 (entire tag) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 20:28:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 19:28:25 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #9 from Barton Chittenden --- Updated test procedure. After patch is applied: 1) Make sure that you have a bib that has MARC21 035$a (and possibly also 035$z) populated. 2) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z 3) Add the following to the intranetuserjs syspref: $(document).ready(function(){ // Add Other Control Number to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append(''); } } Do an advanced search, select "Other Control Number" from the search menu, then add the Other Control Number in 035$a for the bib specified in step 1. The advanced search should return that biblio record. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 20:32:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 19:32:15 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #10 from Barton Chittenden --- Katrin, I've cleaned up the patch, and updated the testing procedures (minor change to javascript in the test procedure). The patch should apply to MASTER. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 20:33:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 19:33:00 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 23:29:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 22:29:51 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 20 23:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 22:30:03 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36104|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 36105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36105&action=edit Add Zebra index "Other-control-number" covering MARC21 035$a, 035$z and 035 (entire tag) http://bugs.koha-community.org/show_bug.cgi?id=6499 Signed-off-by: Nick -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 00:06:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 23:06:10 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 00:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 23:06:13 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35187|0 |1 is obsolete| | --- Comment #28 from Brendan Gallagher --- Created attachment 36106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36106&action=edit Bug 10480: New module and unit test for framework plugins This patch introduces the Koha::FrameworkPlugin object to Koha. This object supports the current "old-style" plugins while adding a new style based on the concept of two anynomous subroutines for building and launching. I will summarize the advantages of this new approach, justifying the additional lines of code in this patch: [1] Centralizing the code for building and launching plugins. [2] Extensive unit testing: this was not possible before. [3] Simplicity: Only define what you need in the plugin. A follow-up patch will delete 1500 lines with *empty* routines. [4] Make it possible to restore the warnings pragma for all plugins. New style plugins do no longer depend on redefinition. [5] Event binding moved from HTML attributes moved to jQuery code. This separates behavior and presentation. [6] Much more documentation, including EXAMPLE plugin in follow-up. [7] Improved error handling. [8] Usability: property noclick tells you if plugin's buttonDot is active. [9] More events supported: Change, keyboard/mouse events. See EXAMPLE. NOTE ON EXAMPLE PLUGIN: The example plugin is added in the third patch of this report. Since it is new style, it can be used only after we start using this object. It also contains an example for a keypress and mouseover event. NOTE ON ITEM PLUGINS: Old style plugins for items contain an additional parameter in the js functions for Blur, Focus and Change. This distinction has no actual use and is resolved for new plugins in the object code. When converting item plugins, this minor correction will be addressed. In the meantime old style item plugins behave as expected. TEST PLAN: Run the new test t/db_dependent/FrameworkPlugin.t At this point in time, you do not need to do anything more. Follow-up patches will incorporate the object in real-life Koha and provide additional test plans. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 00:06:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 23:06:20 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35188|0 |1 is obsolete| | --- Comment #29 from Brendan Gallagher --- Created attachment 36107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36107&action=edit Bug 10480: Use the framework plugin object in cataloguing This patch implements the use of Koha::FrameworkPlugin in Cataloguing, Authorities, Acquisition, Serials and Tools. The main change is architectural: see the commit message of the previous patch. No changes in behavior are expected, but the support of new events may provide additional functionality in the future. Some small bugs are resolved along the way. The change primarily focuses on the MARC and items editor in Cataloguing. But the MARC editor for Authorities and the item editor in Acquisition, Serials and Tools are touched too. This commit message gives some comments per module. NOTE FOR CATALOGUING: A new plugin without popup (or other click event code) now shows the title No popup when hovering over the tag editor image. The image alerts the user on a plugin, the title tells about its status. The noclick property allows for further style modifications in the template. Note that a follow-up patch will clean up the old style plugins too with the same effect. Some additional code in cataloging.js makes it possible to clone subfields with plugins (although only theoretically useful). The clones use the same javascript functions but event.data contains an updated id. This effectively resolves bug 13306. Note that if old plugins do not use the javascript parameter for the id but the perl variable, cloning does still operate on the wrong field (with and without this patch set). In the absence of report 12176 in master, it is not yet necessary to modify additem.tt. When it gets pushed, it should be an easy rebase. New style item plugins will no longer need an extra parameter. (The code in the FrameworkPlugin object actually takes care of that.) NOTE FOR AUTHORITIES: This patch also adds class name tag_editor to the buttonDot anchors. This effectively makes the same tag editor image appear as in Cataloguing. Futhermore it removes the button from the tab sequence if there is no click event (really effective after conversion to the new style, since the old style plugins contain empty onclicks and launchers). Both small adjustments increase consistency between auth and bib edits. NOTE FOR ACQUISITION: In Acquisition two scripts use an item editor, but in a different way. The scripts addorderiso2709 and neworderempty both rely on the routine PrepareItemrecordDisplay in C4::Items, but neworderempty creates item blocks dynamically via an ajax call to services/itemrecorddisplay.pl. In order to make the dynamic item blocks work with plugins, some code changes were needed in additem.js. (Normally the event binding is done at document ready time; now it must be done later.) At this moment the routine in Items.pm contains the html tags, and this makes changes to the following templates not necessary for now: * acqui/addorderiso2709.tt * services/itemrecorddisplay.tt Report 13397 has been opened to address moving the html to the templates. NOTE FOR SERIALS: Script serial-edit relies also on C4::Items (just as in Acquisition). This makes changes to serials/serials-edit.tt not necessary for now. NOTE FOR TOOLS: The current code in tools/batchMod.pl allows the use of plugins for batch modification of items. This patch just converts that code to use the new object. Most item plugins however may not be very useful for operating on multiple items at once. PERFORMANCE: I have benchmarked build_tabs in addbiblio to see how especially the additional processing of the javascript in the FrameworkPlugin object would impact performance. Testing default MARC21 framework with 8 plugins gave the following figures: - Old situation: 851 ms - New situation: 942 ms (+10,7%) - New situation after plugin cleanup: 881 ms (+3,4%) Note also that adding lines for event binding is compensated by removing lines for unused events. Page load should essentially be the same. TEST PLAN: Suggestion: If you also apply the next patch with the EXAMPLE plugin, you can test with a rather harmless plugin (with popup) on various places :) But your test should also include old style plugins, with[out] popups. If you want to test a new plugin without popup, rename/remove Click$id in the javascript code of the $builder definition (temporarily). [1] Test Cataloguing: - Add/Edit biblio. Try plugins with and without popup. - Add/Edit items. (EXAMPLE can be used as an item plugin with popup.) - Clone a subfield with plugin (use EXAMPLE): Verify that the plugin works on both original and clone with the respective field values. Is the value put back in the right field too? [2] Test Authorities: Edit an authority record. Try plugins with an without popup. [3] Test Acquisition: Set system preference AcqCreateItem to "placing an order". Check the item editor in the following two places: a- addorderiso2709: Open a basket, add an order from a staged file. Select a file, click Add orders, and go to tab Item information. b- neworderempty: Open a basket, add an order from a new empty record. [4] Test Serials: Check the item editor on serials-edit. Go to subscription detail. Click Receive. Choose "Click to add item". (Note that this subscription should create an item record when receiving this serial.) [5] Test Tools: Check the item editor for batch item modification. Enter a few valid barcodes and press Continue to reach the item editor. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 00:06:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 23:06:27 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35189|0 |1 is obsolete| | --- Comment #30 from Brendan Gallagher --- Created attachment 36108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36108&action=edit Bug 10480: EXAMPLE plugin with associated template The EXAMPLE plugin helps you to create a new style framework plugin by providing a simple working example and additional documentation for developers. Test plan: [1] Connect the EXAMPLE plugin to one or more fields. [2] Try the following events: a- Focus: If the field is empty, it should put EXAMPLE: into it. b- MouseOver: If the field is empty and you move your mouse over it, it should have the same effect as Focus. c- Change: Edit the field in the editor and tab out of it, the color of the text should toggle (randomly) between red, green and blue. d- KeyPress: If you edit the field and you type @, it should give AT. e- Click: Click on the tag editor. Change the value in the popup. If you press OK, the field should be changed. [3] Would the documentation in the perl script help you to create a plugin? Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 00:06:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 23:06:35 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35286|0 |1 is obsolete| | --- Comment #31 from Brendan Gallagher --- Created attachment 36109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36109&action=edit Bug 10480: Remove useless routines and irrelevant pod lines This patch makes the following cleanup actions for all plugins: 1- Remove sub plugin_parameters. This function is not used. 2- Remove empty plugin or empty plugin_javascript subs. 3- Remove empty Blur, Clic or Focus routines from javascript. 4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs. 5- Remove the last 1; line. It is no longer needed. Test plan: Run the unit test t/db_dependent/FrameworkPlugins.t Test some cataloguing plugins in addbiblio. Test some item plugins in additem and neworderempty. Signed-off-by: Marcel de Rooy I also checked the syntax of all plugins with perl -c. And checked the pod (if any) with podchecker: Two files still produce a warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 00:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 23:06:41 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35287|0 |1 is obsolete| | --- Comment #32 from Brendan Gallagher --- Created attachment 36110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36110&action=edit Bug 10480: Follow-up for unimarc_field_686a/_700-4.pl This patch fixes the pod errors on those two files by removing the pod section that actually does not add anything useful. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 00:13:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Feb 2015 23:13:06 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #33 from Brendan Gallagher --- Notes - Followed test plan and recommendations. I couldn't find anything wrong with it. It took me a long time to get through it - not sure if I am just slow or what - so heads up for QA (I poked at parts for a few differnt days . As I went through it I didn't really find an extra area that needed checking. So QA should be able to follow plans forward. Also read through the code and didn't find anything that was out of place for code. Thanks, Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 14:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 13:21:39 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #34 from M. de Rooy --- (In reply to Brendan Gallagher from comment #33) > Followed test plan and recommendations. I couldn't find anything wrong with > it. It took me a long time to get through it - not sure if I am just slow > or what - so heads up for QA (I poked at parts for a few differnt days . As > I went through it I didn't really find an extra area that needed checking. > So QA should be able to follow plans forward. Also read through the code > and didn't find anything that was out of place for code. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 16:06:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 15:06:34 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #21 from Nick Clemens --- The only issue I see is that when displaying at a 'Contained Work' the last character of the field preceding the relator terms is clipped. When displaying contributors all looks fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 16:30:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 15:30:51 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Status|Needs Signoff |ASSIGNED --- Comment #20 from Nick Clemens --- Marking as ASSIGNED as current patch doesn't seem to do what I think everyone has agreed. My understanding at the end of of this is: The following change should be made to the MARC21 details in the staff and OPAC: 245 Display complete title and statement of responsibility at the beginning of the record (brief/full display) Subfield c (statement of responsibility) and subfield h (medium) should be displayed, but wrapped in a with a class to make them easily selectable/editable for styling/hiding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 17:40:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 16:40:39 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 19:07:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 18:07:34 +0000 Subject: [Koha-bugs] [Bug 12148] EAN filter on ordering from subscriptions should be hidden for MARC21 installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10971 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 19:07:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 18:07:34 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 --- Comment #2 from Katrin Fischer --- *** Bug 12148 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 19:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 18:21:19 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 19:26:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 18:26:02 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 19:26:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 18:26:05 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 --- Comment #3 from Katrin Fischer --- Created attachment 36111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36111&action=edit Bug 10971: Hide EAN search for MARC21 / template corrections This patch hides the EAN filter on the page for ordering from a subscription when the marcflavour is not UNIMARC as it will only work for this flavour currently. It also corrects - branch to library - supplier to vendor - the library code in the result list to the branch name To test: - Make sure you have a subscription, not the vendor - Create a new basket for the subscription vendor - Choose 'from a subscription' to create your order line - Look at the filters on the left side, switch the marcflavour system preference to see change for the EAN filter - Verify changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 19:42:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 18:42:56 +0000 Subject: [Koha-bugs] [Bug 13744] New: Paging on some datatables slightly broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744 Bug ID: 13744 Summary: Paging on some datatables slightly broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Some more datatables have broken paging - fixes will be similar to those on bug 13487. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 19:54:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 18:54:07 +0000 Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 20:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 19:32:11 +0000 Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 20:32:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 19:32:14 +0000 Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744 --- Comment #1 from Katrin Fischer --- Created attachment 36112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36112&action=edit Bug 13744: Fix datatables paging on 'order from subscription' page The paging of the datatable on the 'order from subscription' page is broken without this patch. To test: - Make sure you have a subscription, note the vendor - Create a new basket for this vendor - Add a new order line 'from a subscription' - Check paging on the result table displays correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 20:42:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 19:42:59 +0000 Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744 --- Comment #2 from Katrin Fischer --- Created attachment 36113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36113&action=edit Bug 13744: Fix datatables paging on 'Holds to pull' report The paging of the datatables on the 'holds to pull' report page is broken without this patch. To test: - Make sure that some holds are placed on available items in your installation - Go to the circulation start page - Open the 'holds to pull' report - Verify that the patch fixes the paging on the result table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 20:54:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 19:54:14 +0000 Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 20:54:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 19:54:19 +0000 Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 --- Comment #2 from Katrin Fischer --- Created attachment 36114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36114&action=edit Bug 13741: "No fund found" is not translatable The string "No fund found" on the funds overview page is not translatable. To test: - Create a new budget - Check for the string on the funds page of the new budget - Run an update on one of the po file sets cd misc/translator perl translate update - Verify that the string now appars in the po file for staff - Verify the page still looks the same as before the patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 20:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 19:54:26 +0000 Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:16:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:16:25 +0000 Subject: [Koha-bugs] [Bug 13643] Can't subscribe to serial emails anymore / Emails not being sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't subscribe to serial |Can't subscribe to serial |emails anymore |emails anymore / Emails not | |being sent --- Comment #2 from Katrin Fischer --- Hm, I can subscribe to the emails, but I see problems in generating the email. Can someone confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:17:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:17:18 +0000 Subject: [Koha-bugs] [Bug 13643] Can't subscribe to serial emails anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't subscribe to serial |Can't subscribe to serial |emails anymore / Emails not |emails anymore |being sent | --- Comment #3 from Katrin Fischer --- ... and now the email arrived. Feature works all correct for me on current master then. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:19:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:19:31 +0000 Subject: [Koha-bugs] [Bug 13745] New: Serial collection page shows branchcode instead of branchname Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745 Bug ID: 13745 Summary: Serial collection page shows branchcode instead of branchname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org On the serial collection page the first table with the subscriptions shows the branch code, while the second table with the issues shows the branch name. Both should be showing the branch name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:27:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:27:05 +0000 Subject: [Koha-bugs] [Bug 13745] Serial collection page shows branchcode instead of branchname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745 --- Comment #1 from Katrin Fischer --- Created attachment 36115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36115&action=edit Bug 13745: Fix serial collection page to always show branch name The serial collection page shows 2 tables, one for the subscriptions and a second for the issues. Both show the branch, but the first showed the code while the second showed the name. With this patch both tables show the name. To test: - Search for a subscription or create one - Navigate to the serial collection page (navigation on left side) - Check both tables on the page show the branch name with the patch applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:27:02 +0000 Subject: [Koha-bugs] [Bug 13745] Serial collection page shows branchcode instead of branchname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:33:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:33:47 +0000 Subject: [Koha-bugs] [Bug 13746] New: On creating a new subscription, notes fields get confused Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Bug ID: 13746 Summary: On creating a new subscription, notes fields get confused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When creating a new subscription, check 'manual history' and put text into the internal and public note fields. After saving, the notes are not only saved to the normal note fields, but also copied to the subscription history. After initial creation of the subscription, the notes fields behave normally and are saved to the correct fields in the database when edited. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:37:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:37:02 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #1 from Katrin Fischer --- Database fields are: Subscription subscription.notes (public) subscription.internalnotes (internal) Subscription history subscriptionhistory.opacnote (public) subscripitonhistory.librariannote (internal) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:56:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:56:08 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:56:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:56:12 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #2 from Katrin Fischer --- Created attachment 36116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36116&action=edit Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:57:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:57:59 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #3 from Katrin Fischer --- All existing tests pass with the change. Not sure about new unit tests - could someone suggest what would be good to test here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:58:09 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 22:58:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 21:58:16 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 23:06:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 22:06:56 +0000 Subject: [Koha-bugs] [Bug 13747] New: Frequency description doesn't work well with strings containing quotes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13747 Bug ID: 13747 Summary: Frequency description doesn't work well with strings containing quotes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Found this by coincidence during training: If a serial frequency description contains quotes or is surrounded by quotes, the description is empty ("TEST" > empty) or shown without the quotes part (TEST "sth" > TEST) on editing the frequency. To test: - Create a new frequency - description: "Test" - Modify frequency - Verify the description field is empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 23:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 22:19:58 +0000 Subject: [Koha-bugs] [Bug 13724] Not possible to undo a selected facet when search started with an authority id search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13724 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 21 23:57:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 22:57:59 +0000 Subject: [Koha-bugs] [Bug 4960] No way to enter custom purchase order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- Closing this bug as fixed, assuming that the basket name can be used for the custom purchase order number. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:38:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:38:13 +0000 Subject: [Koha-bugs] [Bug 3006] ability to hide a collection / location from OPAC users In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:41:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:41:10 +0000 Subject: [Koha-bugs] [Bug 11011] rephrase "in keyword" in OPAC authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I am not sure what is meant here - maybe it 'in the complete record' ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:43:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:43:27 +0000 Subject: [Koha-bugs] [Bug 12925] sys pref editor displays search terms with diacritics broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12925 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- Problems appear to be fixed on current master. Closing bug, please reopen if you still see any problems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:44:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:44:02 +0000 Subject: [Koha-bugs] [Bug 11072] Add pagination to search results in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:44:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:44:26 +0000 Subject: [Koha-bugs] [Bug 8396] back to results in catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8396 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- This feature is now available :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:49:17 +0000 Subject: [Koha-bugs] [Bug 11825] Hide shelving locations from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- paxed, would opachiddenitems work here for you? It also hides the items, but this might be more than you need? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:49:51 +0000 Subject: [Koha-bugs] [Bug 11959] overdrive page in opac needs a way back to search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12421 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:49:51 +0000 Subject: [Koha-bugs] [Bug 12421] no way to get back to search results from overdrive results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 --- Comment #2 from Katrin Fischer --- *** Bug 11959 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:51:07 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #21 from mathieu saby --- Thank you for testing, and for all those details. I'll try to take an other look in a few days. For the install of queryparser, I suppose the package is installed automatically with other dependancies when you install Koha, but not sure of that... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:51:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:51:40 +0000 Subject: [Koha-bugs] [Bug 9793] clear screen option for advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- Hm, assuming 'new search' does the job here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:57:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:57:11 +0000 Subject: [Koha-bugs] [Bug 8813] issue slip lists items as overdue that are not overdue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- I suspect this is a duplicate to something that is being worked on - marking as such, please correct, if I am wrong. Also note: we are still looking for a good test plan to bring the problem to light. *** This bug has been marked as a duplicate of bug 12847 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:57:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:57:11 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #18 from Katrin Fischer --- *** Bug 8813 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 00:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Feb 2015 23:59:20 +0000 Subject: [Koha-bugs] [Bug 10133] System preference search behaves different with translated templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10133 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 01:02:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 00:02:47 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 01:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 00:03:05 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 01:03:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 00:03:46 +0000 Subject: [Koha-bugs] [Bug 11698] Add validity check for amount on budget page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|can't create a budget |Add validity check for | |amount on budget page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 01:06:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 00:06:27 +0000 Subject: [Koha-bugs] [Bug 11449] Syntax error in moredetail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure which file this is appearing in? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 01:08:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 00:08:08 +0000 Subject: [Koha-bugs] [Bug 11449] Syntax error in moredetail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- Wait... it's getting late - moredetail.pl But I can't locate this code there anymore. Marking WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 01:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 00:08:59 +0000 Subject: [Koha-bugs] [Bug 5167] adding more items to order doesn't fill in all fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5167 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I just retested this with various pull down and free text item fields - they all copied after adding the first item on the order. Marking fixed, please reopen if you still see problems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 01:11:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 00:11:29 +0000 Subject: [Koha-bugs] [Bug 6729] block received order lines from editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6729 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|ability to edit received |block received order lines |items |from editing -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 01:12:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 00:12:34 +0000 Subject: [Koha-bugs] [Bug 6742] can't tell what's a child fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- We now have a hierachical display for funds :) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 10:01:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 09:01:18 +0000 Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- The search part of the manual states that a 'begins with' search is not possible with ICU - this here seems a bit related. Is there way we can make this work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 10:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 09:18:26 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_11147=5D__Changes_on_the_=E2=80=9Cne?= =?utf-8?q?w_purchase_suggestion=E2=80=9D_page?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11147 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- You can define a separate pull down for a reason using the OPAC_SUG authorised value. It would also be possible to use jquery to change the text and labelling of the fields to better suit your needs. The manual has screenshots showing the additional field: http://manual.koha-community.org/3.18/en/purchasesuggest.html I think since there is a specific field for the reason, renaming the notes field would get a bit confusing. I think as the needs of the libraries are very different, we probably need to stick with a general text or add options to better customize. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 10:22:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 09:22:32 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Owen and Josef, I just tested this after some weirdness seen in training. I can confirm the problem: It's not really a display problem, but if you accept/reject a suggestion right now, the reason doesn't seem to get saved into the suggestion at all :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 10:22:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 09:22:40 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 10:44:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 09:44:40 +0000 Subject: [Koha-bugs] [Bug 13215] letter.code is considered as a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7997 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 10:44:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 09:44:40 +0000 Subject: [Koha-bugs] [Bug 7997] Can't create a notice with the same code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13215 --- Comment #17 from Katrin Fischer --- The problem has been fixed with bug 13215. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 10:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 09:46:48 +0000 Subject: [Koha-bugs] [Bug 6819] Don't offer delete links for received order lines on basket summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|can delete items you have |Don't offer delete links |received |for received order lines on | |basket summary -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 10:48:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 09:48:18 +0000 Subject: [Koha-bugs] [Bug 9968] Error when a search is done with Standard number option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 11:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 10:01:43 +0000 Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for items "Waiting" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 11:04:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 10:04:36 +0000 Subject: [Koha-bugs] [Bug 13748] New: Acquisition wizard: some strings not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Bug ID: 13748 Summary: Acquisition wizard: some strings not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Under Reports > Acquisition wizard appear 2 untranslatable strings in the pull downs: - All item types - All funds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 11:12:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 10:12:59 +0000 Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744 --- Comment #3 from Katrin Fischer --- Created attachment 36117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36117&action=edit Bug 13744: Fix datatables paging on 'checkout history' page The paging in the datatable on the 'circulation history' page is broken without this patch. /cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=... To test: - Search for a record with items that have been checked out in the past - From the detail page, open the 'checkout history' tab - Check paging displays correctly with this patch and is broken without -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 11:21:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 10:21:50 +0000 Subject: [Koha-bugs] [Bug 13749] New: On loading holds in patron account 'processing' is not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Bug ID: 13749 Summary: On loading holds in patron account 'processing' is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The message shown while loading holds in the patron account "Processing..." is not translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 11:28:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 10:28:00 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Katrin Fischer --- This is also true for the 'Loading...' shown directly inside the table. I tried looking at the code, but not sure why some strings appear to work and others not. Could someone else take a look? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 11:49:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 10:49:45 +0000 Subject: [Koha-bugs] [Bug 13750] New: Holds queue: Always show branch name, not branch code Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750 Bug ID: 13750 Summary: Holds queue: Always show branch name, not branch code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When limiting the holds queue to one branch, on top of the table it displays: X items found for This should show the branch name instead of the code, as the branch name is also shown inside the holds table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 11:52:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 10:52:39 +0000 Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name, not branch code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 11:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 10:52:48 +0000 Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name, not branch code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750 --- Comment #1 from Katrin Fischer --- Created attachment 36118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36118&action=edit Bug 13750: Holds queue - Show branch name instead of branch code When the holds queue report is limited to one library, it shows items found for With the patch applied, the branch name is shown instead of the code. To test: - Go to circulation > Holds queue - Limit to one branch with holds waiting to be processed - Confirm the string has changed to show the branch name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 11:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 10:53:16 +0000 Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name, not branch code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 12:47:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 11:47:00 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #4 from Katrin Fischer --- I did a git bisect as I couldn't spot the problem right away, it points to: 1c2744a83f99027386f9409ad43e725707ae45f8 is the first bad commit commit 1c2744a83f99027386f9409ad43e725707ae45f8 Author: Yohann Dufour Date: Fri Aug 8 15:11:18 2014 +0200 Bug 12627: SQLHelper replacement - C4::Suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 13:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 12:14:42 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #5 from Katrin Fischer --- ... I fail to spot the problem, could someone else please take a look? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 13:23:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 12:23:37 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |In Discussion --- Comment #4 from Katrin Fischer --- Moving this to "In Discussion". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 16:21:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 15:21:16 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- See also bug 13732. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 16:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 15:21:59 +0000 Subject: [Koha-bugs] [Bug 13732] Incorrect total charges on the checkouts table in a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13732 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi David, good summary! I like the idea of a separate column. Marking this duplicate with an older bug report about the charges column *** This bug has been marked as a duplicate of bug 9481 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 16:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 15:21:59 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om --- Comment #14 from Katrin Fischer --- *** Bug 13732 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 16:30:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 15:30:32 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #20 from Katrin Fischer --- I agree with Jonathan - in this case a new subroutine is probably a bit too specific. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 22:46:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 21:46:34 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suggestions reason |Suggestions reason doesn't | |save -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 23:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 22:21:49 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 23:22:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 22:22:14 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 23:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 22:54:12 +0000 Subject: [Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Template changes, held for 3.18.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 23:57:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 22:57:02 +0000 Subject: [Koha-bugs] [Bug 13700] Translated item search not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13700 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #15 from Chris Cormack --- String changes, held for 3.18.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 22 23:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 22:59:44 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- No string changes pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:00:45 +0000 Subject: [Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:04:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:04:08 +0000 Subject: [Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:04:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:04:21 +0000 Subject: [Koha-bugs] [Bug 7917] Print/download new arrivals list in ISBD format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7917 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com --- Comment #2 from Indranil Das Gupta --- (In reply to Tom?s Cohen Arazi from comment #1) > Savitra, are you working on this? Which is the scope of the idea? How would > you calculate the new arrivals? Tom?s, Savitra is no longer with this company. In fact as far as I know, he is no longer working in the ILS domain. -idg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:07:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:07:02 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #27 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:07:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:07:40 +0000 Subject: [Koha-bugs] [Bug 13682] Capitalization: Holds Queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- String changes held for 3.18.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:12:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:12:37 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:13:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:13:15 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- String changes, held for 3.18.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:14:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:14:21 +0000 Subject: [Koha-bugs] [Bug 13690] Koha::Schema should be lazy-loaded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:16:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:16:09 +0000 Subject: [Koha-bugs] [Bug 12948] The language filter in advance search doen't work with DOM MARC21 - NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12948 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:17:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:17:58 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #24 from Chris Cormack --- Holding for 3.18.5, I need to test this more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 00:27:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Feb 2015 23:27:29 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Katrin - I feel like I've seen this before but described a little bit differently. I am looking for a similar bug (I haven't found it yet). I think I've seen language like - manual history fails. (no comment for new direction on the unit tests). If I do not find a similar bug then I'll be glad to test this. Of course any enlightenment for me is always welcome. Cheers, Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 01:35:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 00:35:40 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #7 from Indranil Das Gupta --- The "Library Catalog" (default) search option will search quite successfully for an item's barcode (952$p). IMHO, this is redundant. Still, the same functionality can be achieved by a single line of jQuery placed into opacuserjs $("select[name='idx']").append(""); Setting the bug status to RESOLVED WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 03:00:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 02:00:38 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |mtj at kohaaloha.com Resolution|WONTFIX |--- --- Comment #8 from Mason James --- (In reply to Indranil Das Gupta from comment #7) > The "Library Catalog" (default) search option will search quite successfully > for an item's barcode (952$p). IMHO, this is redundant. Still, the same > functionality can be achieved by a single line of jQuery placed into > opacuserjs > > $("select[name='idx']").append(""); that solution will not work for a multi-language Koha install so, not resolved? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 06:40:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 05:40:18 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- (In reply to Mason James from comment #8) > (In reply to Indranil Das Gupta from comment #7) > > The "Library Catalog" (default) search option will search quite successfully > > for an item's barcode (952$p). IMHO, this is redundant. Still, the same > > functionality can be achieved by a single line of jQuery placed into > > opacuserjs > > > > $("select[name='idx']").append(""); > > > that solution will not work for a multi-language Koha install > > so, not resolved? I imagine a lot of people don't think it should be added to the masthead search, so I suppose the other alternative would be for them to roll their release with translated templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 06:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 05:42:01 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- Hmm, I haven't had any issues with the resumption tokens... I'll have to take a gander at this sometime... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 06:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 05:49:17 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #5 from Katrin Fischer --- Hi Brendan, this is just for the note fields - the less complicated part of the self-updating history. I have seen some other things while testing in the issue related fields, but haven't looked into it yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 06:53:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 05:53:38 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 --- Comment #10 from Katrin Fischer --- Hi David, thx for thinking about translations. :) Actually, you can do that with a little bit more jQuery, also checking for the selected language. I do that a lot to provide German and English when I add something to the OPAC. I think I agree that we should not add another option to the masthead search, when it's available in advanced search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 07:47:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 06:47:52 +0000 Subject: [Koha-bugs] [Bug 13512] Add sort-string-utf.chr for Polish and Latin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13512 --- Comment #4 from Michal Dudzik --- Tom?s, If you can please add this patch on my behalf. Thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 08:13:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 07:13:41 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion --- Comment #11 from Indranil Das Gupta --- (In reply to Katrin Fischer from comment #10) > Hi David, thx for thinking about translations. :) > > Actually, you can do that with a little bit more jQuery, also checking for > the selected language. I do that a lot to provide German and English when I > add something to the OPAC. > > I think I agree that we should not add another option to the masthead > search, when it's available in advanced search. exactly what I would do, so +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 08:15:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 07:15:03 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 --- Comment #12 from Indranil Das Gupta --- (In reply to Mason James from comment #8) > (In reply to Indranil Das Gupta from comment #7) > > The "Library Catalog" (default) search option will search quite successfully > > for an item's barcode (952$p). IMHO, this is redundant. Still, the same > > functionality can be achieved by a single line of jQuery placed into > > opacuserjs > > > > $("select[name='idx']").append(""); > > > that solution will not work for a multi-language Koha install > > so, not resolved? Does http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302#c10 work for you? :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 08:51:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 07:51:30 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Bug 13428 depends on bug 13425, which changed state. Bug 13425 Summary: There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13425 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 08:51:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 07:51:29 +0000 Subject: [Koha-bugs] [Bug 13425] There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13425 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolyn.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #47 from Fridolin SOMERS --- Not needed for 3.14.x, I set has resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 08:56:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 07:56:16 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 --- Comment #11 from Fr?d?ric Demians --- (In reply to David Cook from comment #10) > Hmm, I haven't had any issues with the resumption tokens... I'll have to > take a gander at this sometime... It depends on OAI-PMH harvester: some accepts an empty result set returned to a resumption query. A well known discovery tool, edited by an US-Israeli company, fails to handle an empty resultset, report it, and stop harvesting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 10:12:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 09:12:55 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 --- Comment #3 from Martin Renvoize --- Comment on attachment 36081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36081 [WIP] Bug 13738 - Add RESTful Borrower service Review of attachment 36081: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13738&attachment=36081) ----------------------------------------------------------------- Generally I'm really happy with this, it's a great starting point for us to expand upon. Nice work Kyle! ::: Koha/Service/Borrower.pm @@ +39,5 @@ > + authnotrequired => 0, > + needed_flags => { borrowers => 1 }, > + routes => [ > + [ qr'GET /(\d+)', 'get_borrower' ], > + [ qr'POST /(\d+)', 'add_borrower' ], Untested, but I beleive the '/(\d+) on this line is superflous and may infact mean the POST method is unreachable if my memory serves my correctly. @@ +88,5 @@ > +=head2 POST > + > + Syntax: /rest/borrower > + > + Creates a new patron. Data must be supplied as a POST of JSON data. JSON data, I'm loving JSON and fully support it's use.. however, for the borrower service I tihnk we should attempt to support XML aswell via content negotiation. I can see this route being used internally in Koha allot, and also being used for institutions to manage their borrowers externally.. Many said institutions are still stuck in the dark ages of XML ;) @@ +104,5 @@ > + my $data = from_json( $json, { utf8 => 1 } ); > + > + my $borrower = Koha::Borrower->new()->set($data)->store(); > + > + $self->output( $borrower->as_hashref() ); Great start, but we should probably end up with some error handling here so we can return a meaningful json error body if the insert isn't allowed for some reason or another. @@ +153,5 @@ > + > + my $borrower = Koha::Borrowers->find( { get_id_field() => $id } ); > + > + if ($borrower) { > + $borrower->delete(); #TODO Use C4::Members to delete Related to the #TODO: Personally, I think I'd rather see the delete functionality from C4::Members rolled into the $borrower object, an eventually for scripts to all strt using the object as the defactly point of truth for this sort of thing. I would be nice to start the move into the Koha with a clean sweep of these sorts of functions :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 10:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 09:15:47 +0000 Subject: [Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- Cheers Kyle, I'd been meaning to submit exactly that for a while now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 10:19:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 09:19:15 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Remind me, which bug adds Koha::Borrower and Koha::Borrowers.. it needs to be a dependancy ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 10:41:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 09:41:25 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 10:46:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 09:46:12 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 11:02:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 10:02:43 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- About the delete - this will probably create a problem with lists if we don't use the internal functions. We do a bit more there and not all is caught by FK constraints in the database (actually there are some bugs for stuff that we should catch, but don't). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 11:18:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 10:18:29 +0000 Subject: [Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13731 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 11:18:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 10:18:29 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12627 CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 12:09:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 11:09:27 +0000 Subject: [Koha-bugs] [Bug 13751] New: "Begins with" search not possible with ICU indexing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 Bug ID: 13751 Summary: "Begins with" search not possible with ICU indexing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org With ICU activated, a "begins with" search like ti,ext= will return the same results as a ti= search. This is a problem for libraries with big collections where a title you look for can be pretty unspecific and you need a way to do more exact searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 12:35:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 11:35:02 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 --- Comment #1 from Katrin Fischer --- Hm, I have to correct: ti= gives more results than ti,ext= But: results don't match the expected result. I am not really sure what is happening there. On a non-ICU installation something like: ti,ext=P?dagogik Works perfectly, all titles shown start with P?dagogik. The manual: http://manual.koha-community.org/3.18/en/searchguide.html#searchguide-advanced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 12:35:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 11:35:57 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6425 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 12:35:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 11:35:57 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 12:35:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 11:35:57 +0000 Subject: [Koha-bugs] [Bug 6425] Advanced search: begins with and contains searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13751 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 12:36:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 11:36:06 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11158 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 12:36:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 11:36:06 +0000 Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13751 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 12:36:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 11:36:09 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #6 from Jonathan Druart --- Created attachment 36119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36119&action=edit Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 13:14:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 12:14:16 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13019 --- Comment #6 from Jonathan Druart --- (In reply to Martin Renvoize from comment #4) > Remind me, which bug adds Koha::Borrower and Koha::Borrowers.. it needs to > be a dependancy ;) It's bug 13019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 13:14:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 12:14:16 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13738 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 14:25:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 13:25:18 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi at osslabs.biz --- Comment #4 from Tom?s Cohen Arazi --- *** Bug 7917 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 14:25:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 13:25:18 +0000 Subject: [Koha-bugs] [Bug 7917] Print/download new arrivals list in ISBD format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7917 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #3 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 13695 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 14:28:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 13:28:07 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 --- Comment #7 from Martin Renvoize --- (In reply to Katrin Fischer from comment #5) > About the delete - this will probably create a problem with lists if we > don't use the internal functions. We do a bit more there and not all is > caught by FK constraints in the database (actually there are some bugs for > stuff that we should catch, but don't). That's sort of the point of my comment cait.. I'd like to see the Objects moving towards being a single piont fo truth.. so i'd rather see the logic around deleting, creating, updateing and even reading a borrower moved from C4::Members into Koha::Borrowers... whether this starts as the Koha::Borrower object referencing the C4::Members routine, or writing it properly I don't really mind.. but in new code I'd certainly like to strive for 'doing it right' the first time and using only the Koha::* stuff in the Koha::Services unless absolutely nesessary. Just my thoughts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 14:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 13:32:31 +0000 Subject: [Koha-bugs] [Bug 10112] add test for ./debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com --- Comment #5 from Tom?s Cohen Arazi --- If we had such tests, they should generate the control file out of the control.in file as Robin does, and test it instead. Because we want to test the control file generation, not the validity of the current file. It could be done on a temporary directory as other tests do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:00:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:00:12 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 --- Comment #8 from Katrin Fischer --- Sounds all good to me :) Just wanted to point out that actually we *must* do it differently, because else it will be buggy. Also we should have one central place to check for fines, checkouts, existing guarantor etc. - have to get that right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:02:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:02:11 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:02:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:02:15 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35965|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 36120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36120&action=edit Bug 13473 - Plugins fail When trying to execute or configure the plugin on 3.18 I got: Template process failed: file error - doc-head-open.inc: not found at /usr/share/koha/lib/C4/Templates.pm line 129. Test Plan: 1) Install the Kitchen Sink plugin 2) Go to the configuration page of the plugin 3) Note the template processing error 4) Apply this patch 5) Refresh the page 6) Note the page now loads Signed-off-by: Nick Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:14:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:14:10 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #15 from Martin Renvoize --- Is there any prospect for this bug getting solved? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:28:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:28:26 +0000 Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:28:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:28:29 +0000 Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35659|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36121&action=edit Bug 13662: Fix the serials.receive_serials permissions There are some issues with serial permissions. For instance it's not possible to receive serials if the edit_subscription is not set. Also the toolbar is empty. Test plan: 1/ Set the serials => receive_serials permissions to a patron (and only this one for the serials module). 2/ Verify you cannot create a new subscription, you can search subscriptions but cannot edit them. 3/ On the serial result list, receive a serial (action > Serial receive). You can now change the status and receive it. 4/ On the serial collection, you can edit 1+ serials to reveice it. 5/ Set the serials => edit_subscription permission and confirm there is no regression. QA note: I think we should introduce a C4::Serials::can_receive_serials subroutine, to test the IndependentBranches pref, but I don't want to add to much processing to check permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:30:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:30:00 +0000 Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 --- Comment #4 from Jonathan Druart --- (In reply to Paola Rossi from comment #2) Good catch Paola! That should be fixed with the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:30:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:30:59 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 --- Comment #16 from Katrin Fischer --- Rafal, do you have time to make the fixes pointed out by Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:35:00 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart --- Failing QA for missing tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:40:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:40:14 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 --- Comment #17 from Rafal Kopaczka --- Sorry I've forgot about this bug... But it seems that there isn't much work to do (beside rebase), but currently I'm working on something else. So if anyone want to work on this feel free to do so. If not I'll have time to look at this patch for about 1-2 weeks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:42:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:42:25 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #200 from Jonathan Druart --- Kyle, Any chances to see this patch set resubmitted in a more readable way? The schema is updated in another patch than the "Schema Updates" one, "Remove use of EncodeUTF8" could be squashed with another one, the missing file should be part of the main patch, etc. Moreover I don't see the point (except a too lazy way) of the Koha::Template::Plugin::Koha::Find method, IMO the data should be fetch in the pl file. Another QA point of view is needed here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:46:33 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #7 from Charles Farmer --- (In reply to Jonathan Druart from comment #6) > DBD::mysql::db do failed: Duplicate foreign key constraint name > 'koha/overduerules_fk' at > installer/data/mysql/atomicupdate/bug_13624_overduerules_transport_types.pl > line 33. I changed the foreign key name and placed the changes in updatedatabase.pl instead of a stand alone file. I hope this solves the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:48:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:48:13 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:48:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:48:15 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35587|0 |1 is obsolete| | --- Comment #8 from Charles Farmer --- Created attachment 36122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36122&action=edit [PATCH] Bug #13624: Remove columns branchcode, categorytype from table overduerules_transport_types Sponsored by Halland County Library This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice In installer/data/mysql/updatedatabase.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' TEST PLAN --------- 1) Apply the patch 2) Run the script installer/data/mysql/updatedatabase.pl - It will create new tables and migrate the data 3) Run Overdues.t. Tests should be successful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 15:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 14:48:35 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:12:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:12:54 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #22 from Winona Salesky --- (In reply to Nick Clemens from comment #21) > The only issue I see is that when displaying at a 'Contained Work' the last > character of the field preceding the relator terms is clipped. > > When displaying contributors all looks fine. Thanks for catching that. I will make sure it gets fixed. -Winona -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:24:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:24:57 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:25:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:25:00 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18719|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 36123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36123&action=edit Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:26:00 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:42:27 +0000 Subject: [Koha-bugs] [Bug 2806] issuingbranch isn't used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:42:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:42:30 +0000 Subject: [Koha-bugs] [Bug 2806] issuingbranch isn't used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 --- Comment #3 from Jonathan Druart --- Created attachment 36124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36124&action=edit Bug 2806: Remove issuingbranch columns This column is not in used in the Koha code and could be removed. Test plan: Verify the branch is correctly displayed on the circulation history (members/readingrec.pl) and that both reports Most-cisulated items (cat_issues_top.pl) and Avg checkout (issues_avg_stats.pl) work as before. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:42:40 +0000 Subject: [Koha-bugs] [Bug 2806] issuingbranch isn't used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:53:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:53:10 +0000 Subject: [Koha-bugs] [Bug 10059] admin user can't see budgets on acq page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #10 from Jonathan Druart --- I think this one can be considered as invalid. Please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:57:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:57:59 +0000 Subject: [Koha-bugs] [Bug 9492] Children funds not clear if limited to my branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9492 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- This should have been fixed by bug 11578. *** This bug has been marked as a duplicate of bug 11578 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:57:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:57:59 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #46 from Jonathan Druart --- *** Bug 9492 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 16:59:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 15:59:11 +0000 Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|In Discussion |Failed QA --- Comment #7 from Jonathan Druart --- Amit, do you plan to work again on this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 17:02:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 16:02:32 +0000 Subject: [Koha-bugs] [Bug 10928] Acq Note does not appear when receiving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED Status|In Discussion |RESOLVED --- Comment #5 from Jonathan Druart --- We have aqorders.order_vendornote which is displayed on receiving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 17:11:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 16:11:19 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 17:11:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 16:11:22 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 --- Comment #5 from Jonathan Druart --- Created attachment 36125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36125&action=edit Bug 9742: Does not display the popup on creating new record The new confirmation on starting a z39.50 serach in cataloguing always pops up, even when you are working on a new record that has not been saved yet. Test plan: 1/ Edit an existing record, click on the Z3950 search button, confirm the popup appears. 2/ Create a new record, click on the Z3950 search button, confirm the popup does not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 17:12:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 16:12:20 +0000 Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 --- Comment #8 from Amit --- Hi Jonathan Druart, Yes i have plan will recreate and submit the patch again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 17:12:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 16:12:31 +0000 Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 17:13:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 16:13:18 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 17:15:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 16:15:23 +0000 Subject: [Koha-bugs] [Bug 10391] specify due date remaining even if not selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- *** Bug 11289 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 23 17:15:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 16:15:23 +0000 Subject: [Koha-bugs] [Bug 11289] sticky due date is always active In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #4 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 10391 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 00:14:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 23:14:49 +0000 Subject: [Koha-bugs] [Bug 13752] New: Item level holds crossed if item moved to another bib Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13752 Bug ID: 13752 Summary: Item level holds crossed if item moved to another bib Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I haven't tested this yet by moving an item from one bib to another, but we did see an instance where an item level hold was placed on an item that was ordered in acquisitions in one basket, and then the item was transferred to another basket. We think this somehow attached the item to another bib in the process, and then the hold was showing up on the item itself, but not that bibs holds, and showing in the holds on a different bib (the one the item was originally attached to. Need some help testing this. If this is the case when moving an item with item level holds from one basket to another in acq, or in cataloging alone, there needs to be either a mechanism to stop the transfer of the item from bib to bib, or it needs to update the holds properly. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 00:15:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 23:15:10 +0000 Subject: [Koha-bugs] [Bug 13752] Item level holds crossed if item moved to another bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13752 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 00:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 23:38:24 +0000 Subject: [Koha-bugs] [Bug 6772] Implementation of a recommendations engine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6772 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|robin at catalyst.net.nz |oleonard at myacpl.org Change sponsored?|Sponsored |--- -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 00:42:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Feb 2015 23:42:20 +0000 Subject: [Koha-bugs] [Bug 11051] Performance of opac-search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #32 from Robin Sheat --- (In reply to Jonathan Druart from comment #31) > Robin, which version of Memcached did you use? In early February last year? I have no idea. Whatever was in whatever my dev VM was running then, most likely. Probably Wheezy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 01:10:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 00:10:31 +0000 Subject: [Koha-bugs] [Bug 13752] Item level holds crossed if item moved to another bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13752 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #1 from Joy Nelson --- I have verified this in Christopher's data. An order was placed, item created and attached to biblionumber 232243. A hold was placed on that on order item and a line in the reserves table created. The order was moved to another basket and the biblionumber on that basket was 246109. The item moved (i.e. biblionumber in items table changed), however, the reserves table retained the old biblionumber (232243) and not the new one. -joy nelson (In reply to Christopher Brannon from comment #0) > I haven't tested this yet by moving an item from one bib to another, but we > did see an instance where an item level hold was placed on an item that was > ordered in acquisitions in one basket, and then the item was transferred to > another basket. We think this somehow attached the item to another bib in > the process, and then the hold was showing up on the item itself, but not > that bibs holds, and showing in the holds on a different bib (the one the > item was originally attached to. > > Need some help testing this. If this is the case when moving an item with > item level holds from one basket to another in acq, or in cataloging alone, > there needs to be either a mechanism to stop the transfer of the item from > bib to bib, or it needs to update the holds properly. > > Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 01:15:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 00:15:40 +0000 Subject: [Koha-bugs] [Bug 6772] Implementation of a recommendations engine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6772 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 01:17:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 00:17:25 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- It would be interesting to look at this using yaz-client... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 02:41:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 01:41:43 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Francois Charbonnier --- In the end, about the set up 3, Laurence, Sonia, I agree with both of you. About the set up 4, I'll keep what we have now because it shares the same logic thabn the set up 3. I tested the patches on Biblibre's sandbox17. Jonathan, could you sign them off on my behalf? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 05:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 04:21:49 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 05:21:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 04:21:51 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36116|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher --- Created attachment 36126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36126&action=edit Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 05:22:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 04:22:39 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #25 from Robin Sheat --- Needs a squeeze package for DBIx::Connector. I'll have a go at building the wheezy one for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 05:46:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 04:46:52 +0000 Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 05:46:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 04:46:54 +0000 Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36114|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher --- Created attachment 36127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36127&action=edit Bug 13741: "No fund found" is not translatable The string "No fund found" on the funds overview page is not translatable. To test: - Create a new budget - Check for the string on the funds page of the new budget - Run an update on one of the po file sets cd misc/translator perl translate update - Verify that the string now appars in the po file for staff - Verify the page still looks the same as before the patch Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 05:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 04:55:35 +0000 Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 05:55:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 04:55:38 +0000 Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35721|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 36128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36128&action=edit Bug 13680 - Items list on edit items page separates add items form from header and sidebar This patch moves the items table on the edit items screen to the bottom of the page. Test plan: 1 - Apply patch 2 - Ensure adding/editing items works as previously Signed-off-by: Brendan Gallagher I like this idea a lot. I think if everyone gave it a shot and got used to the work flow then everyone would love it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:02:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:02:28 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #26 from Robin Sheat --- (In reply to Robin Sheat from comment #25) > Needs a squeeze package for DBIx::Connector. I'll have a go at building the > wheezy one for it. So the packages built surprisingly easily on squeeze. And then a series of cockups on my part made it take forever to actually get into the repo :) It's there now though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:19:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:19:00 +0000 Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name, not branch code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:19:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:19:03 +0000 Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name, not branch code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36118|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 36129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36129&action=edit Bug 13750: Holds queue - Show branch name instead of branch code When the holds queue report is limited to one library, it shows items found for With the patch applied, the branch name is shown instead of the code. To test: - Go to circulation > Holds queue - Limit to one branch with holds waiting to be processed - Confirm the string has changed to show the branch name Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:30:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:30:02 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:30:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:30:06 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35795|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 36130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36130&action=edit Bug 13689 - Remove opac-old.css and sco-old.css The following files are obsolete and should be removed: koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css To test: Apply patch. Search for the files; they should no longer exist. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:33:11 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #27 from Robin Sheat --- Created attachment 36131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36131&action=edit Bug 13645: dependencies for libdbix-connector-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:33:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:33:39 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:33:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:33:46 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:33:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:33:51 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:33:54 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36111|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher --- Created attachment 36132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36132&action=edit Bug 10971: Hide EAN search for MARC21 / template corrections This patch hides the EAN filter on the page for ordering from a subscription when the marcflavour is not UNIMARC as it will only work for this flavour currently. It also corrects - branch to library - supplier to vendor - the library code in the result list to the branch name To test: - Make sure you have a subscription, not the vendor - Create a new basket for the subscription vendor - Choose 'from a subscription' to create your order line - Look at the filters on the left side, switch the marcflavour system preference to see change for the EAN filter - Verify changes Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:33:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:33:55 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:34:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:34:14 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #28 from Robin Sheat --- The patch I've attached will need to go in alongside this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 06:49:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 05:49:36 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #29 from Robin Sheat --- I've uploaded a master build, and included my patch in it. It seemed to be happy. Have a go with that if you want an easy test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 07:16:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 06:16:39 +0000 Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 07:16:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 06:16:41 +0000 Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35812|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 36133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36133&action=edit Bug 13676 - OpacSuppression description says 'items' but means 'records' This patch changes the wording for the OpacSuppression preference description. Without patch: ... items marked as suppressed from OPAC search results. Note that you must have the Suppress index set up in Zebra and at least one suppressed item, or your searches will be broken. ... With patch: ... items marked as suppressed from OPAC search results. Note that you must have the Suppress index set up in Zebra and at least one suppressed biblio record, or your searches will be broken. ... Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 07:25:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 06:25:33 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 07:25:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 06:25:36 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35818|0 |1 is obsolete| | --- Comment #5 from Brendan Gallagher --- Created attachment 36134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36134&action=edit Bug 13695: Add ISBD to OpacExportOptions This patch adds 'isbd' as an export option on the system preferences. Note this patch doesn't add the feature. To test: - On master, search for the OpacExportOptions syspref => FAIL: There is no ISBD option. - Apply the patch - Search for the OpacExportOptions syspref => SUCCESS: There is a new ISBD option. Sponsored-by: Orex Digital Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 07:25:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 06:25:49 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35819|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher --- Created attachment 36135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36135&action=edit Bug 13695: Add ISBD export option to OPAC (detail) This patch adds the option to export a record (from within the OPAC record detail page) in the ISBD format. To test: - Enable ISBD on the OpacExportOptions syspref - Look for a record on your opac - On the detail page, notice there's a new ISBD option for 'Save record' - Choose ISBD => SUCCESS: a file containing the ISBD format for the record is downloaded Sponsored-by: Orex Digital Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 07:25:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 06:25:55 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35820|0 |1 is obsolete| | --- Comment #7 from Brendan Gallagher --- Created attachment 36136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36136&action=edit Bug 13695: Add ISBD export option for the OPAC cart and lists This patch adds the option to download records from the cart, and lists in the ISBD format from the OPAC. To test (cart): - Apply the patch - Add several records to your OPAC cart. - Go to your cart, and choose 'Download' => SUCCESS: There's an ISBD option - Dowload and open the exported records => SUCCESS: The file contains the ISBD format for the records on the cart To test (lists): - Add several records to a list (i did it from the cart ;-)) - Open the list - Choose 'Download list' => SUCCESS: There's an ISBD option - Download and open the exported records => SUCCESS: The file contains the ISBD format for the records on the list. - Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 09:11:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 08:11:10 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 --- Comment #3 from Katrin Fischer --- I'd be happy to help testing - just not sure how to do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 09:48:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 08:48:50 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #9 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #8) > I tested the patches on Biblibre's sandbox17. > > Jonathan, could you sign them off on my behalf? > > Thanks! Thanks Fran?ois! I will add you signoff to the commit on the remote branch. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 10:23:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 09:23:26 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 10:23:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 09:23:30 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36130|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36137&action=edit Bug 13689 - Remove opac-old.css and sco-old.css The following files are obsolete and should be removed: koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css To test: Apply patch. Search for the files; they should no longer exist. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 10:33:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 09:33:17 +0000 Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695 --- Comment #8 from Hugo Agud --- We have applied the patch and it works, but we have found some issues 1. charset issues with utf8 2. issues with html labels _____________________________ Barcelona institucions 2000 Direcci?: ?ngel Fern?ndez Mart?nez, Francesc Galm?s i D?az-Plaja ; col?laboradors: M. Dulce de Torres Ruiz de Porras ... [et al.] - Barcelona: Diputaci? de Barcelona;Ajuntament de Barcelona - 696 p. ; 21 cm - Paper

    8477947376

    2478


    Barcelona (Prov?ncia) -- Directoris -- 2000
    Barcelona (Prov?ncia) -- Guies -- 2000

    061.1(460.23) ___________________________________ We have modified a little the patch changing txt to html and all these issues are fixed, the user may copy and paste to txt or keep it in html. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 12:08:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 11:08:18 +0000 Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 12:09:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 11:09:10 +0000 Subject: [Koha-bugs] [Bug 13662] Serial permissions: receive_serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36121|0 |1 is obsolete| | --- Comment #5 from Paola Rossi --- Created attachment 36138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36138&action=edit 36121: Bug 13662: Fix the serials.receive_serials permissions Thanks, Jonathan. I've applied the patch against master 3.19.00.011 head 13645. All the 3 cases about: Permission edit_subscription ON, receive_serials OFF, Permission edit_subscription OFF, receive_serials ON, Permission edit_subscription ON, receive_serials ON, were OK. Everything was OK as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 13:25:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 12:25:50 +0000 Subject: [Koha-bugs] [Bug 3006] ability to hide a collection / location from OPAC users In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3006 --- Comment #2 from MJ Ray (software.coop) --- For completeness http://manual.koha-community.org/3.18/en/administration.html#OpacHiddenItems -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 13:48:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 12:48:21 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 --- Comment #6 from Marc V?ron --- Created attachment 36139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36139&action=edit [Signed-off] Bug 9742: Does not display the popup on creating new record The new confirmation on starting a z39.50 serach in cataloguing always pops up, even when you are working on a new record that has not been saved yet. Test plan: 1/ Edit an existing record, click on the Z3950 search button, confirm the popup appears. 2/ Create a new record, click on the Z3950 search button, confirm the popup does not appear. Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 13:48:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 12:48:52 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #36125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 13:49:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 12:49:16 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 14:01:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 13:01:30 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #8 from Marc V?ron --- I think the changes to installer/data/mysql/updatedatabase.pl are missing in this patch (Attachment #36123). They were in previous, obsoleted patch (Attachment #18719). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 14:10:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 13:10:53 +0000 Subject: [Koha-bugs] [Bug 13753] New: INDEXER_DAEMON default is incorrect in koha-indexer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Bug ID: 13753 Summary: INDEXER_DAEMON default is incorrect in koha-indexer Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: I.Brown at littleover.derby.sch.uk QA Contact: testopia at bugs.koha-community.org After upgrading to Koha 3.18 I thought I'd try the new daemon indexing as our librarian is always complaining about the delay before things appear in searches. I followed the instructions at http://wiki.koha-community.org/wiki/PackagesIndexDaemon to enable it but it did not seem to be working. Looking at ps output to see if it was running I noticed something strange: lcs-koha 947 0.0 0.0 17176 712 ? S Feb06 0:58 daemon --name=lcs-koha-indexer --errlog=/var/log/koha/lcs/indexer-error.log --stdout=/var/log/koha/lcs/indexer.log --output=/var/log/koha/lcs/indexer-output.log --verbose=1 --respawn --delay=30 --user=lcs-koha.lcs-koha -- -daemon -x -sleep 5 The executable name seemed to be missing. Further investigation led me to /usr/sbin/koha-indexer line 177: # Check if an alternate indexer has been set if [ -z $ALTERNATE_INDEXER_DAEMON ]; then INDEXER_DAEMON="$ALTERNATE_INDEXER_DAEMON" else # We default to rebuild_zebra.pl if no alternate indexer set INDEXER_DAEMON="${KOHA_HOME}/bin/migration_tools/rebuild_zebra.pl" fi Surely this means that if the INDEXER_DAEMON is zero length then set it to the zero length string! The default daemon program is never set. The INDEXER_DAEMON assigments should be swapped. I'm surprised no one else has reported this but I can't find any other bug reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 14:45:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 13:45:29 +0000 Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in koha-indexer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|3.18 |master Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 14:54:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 13:54:54 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #7 from Marc V?ron --- Created attachment 36140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36140&action=edit [Signed-off] Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 14:55:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 13:55:41 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #36119|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 14:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 13:56:30 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 14:59:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 13:59:57 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi at cineca.it --- Comment #19 from Paola Rossi --- On bug 12826 all the 11 "Depends-on" bugs [except the "Overview" Bug 12964 ...] have already been pushed to master/stable. So I've tried to applied the 7 patches of this bug 13321 against master 3.19.00.011 head 13645. The first patch: Applying: Bug 13321: Rename variables fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13321: Rename variables 1) So I pass the patch to "Patch doesn't apply" status. 2) Otherwise, should the 7 patches of this bug 13321 still be tested on the sandbox 17? If this is the case, I beg your pardon and ask you, please, to pass this bug back to "Needs Signoff" status. 3) Are the problems in comment 18 been resolved by the 7 current patches? Or would this Bug 13321 be passed to an "In discussion" status? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 15:00:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 14:00:27 +0000 Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in koha-indexer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 15:00:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 14:00:30 +0000 Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in koha-indexer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 36141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36141&action=edit Bug 13753: koha-indexer contains invalid statement An incorrect conditional makes the indexer daemon fail to load. To test: - Enable the indexer daemon on packages [1] - Restart koha-common: $ service koha-common restart - Run $ ps waux | grep koha-indexer => FAIL: there's no reference to the rebuild_zebra.pl script (line should look like *rebuild_zebra.pl -daemon*) Run ps -ef | grep rebuild_zebra.pl too to make sure. - Apply the patch, repeat the steps => SUCCESS: the rebuild_zebra.pl script is ran - Sign off :-D Thanks Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 15:06:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 14:06:25 +0000 Subject: [Koha-bugs] [Bug 9072] Add CheckValidity option to Linker In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #15 from Fridolin SOMERS --- Is now invalid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 15:24:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 14:24:00 +0000 Subject: [Koha-bugs] [Bug 13754] New: Missing changelogs for debian package Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13754 Bug ID: 13754 Summary: Missing changelogs for debian package Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Probably this show clearly the problem: # apt-get changelog koha-common Err Changelog for koha-common (http://packages.debian.org/changelogs/pool/main/k/koha/koha_3.18.03/changelog) 404 Not Found Err Changelog for koha-common (http://debian.koha-community.org/koha/pool/main/k/koha/koha_3.18.03.changelog) 404 Not Found E: changelog download failed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 15:29:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 14:29:13 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 --- Comment #6 from Colin Campbell --- The dependency on 7981 appears to be bogus. Applying the patch caused the CT and CV fields to be set appropriately for transits where they were previously missing. I'll try and test fully and sign off if ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 15:42:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 14:42:21 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 --- Comment #15 from Kyle M Hall --- (In reply to Jonathan Druart from comment #14) > This looks awesome! > I am just wondering why you have moved the script to C4/Sip. Because it uses Sip::MsgType Moving it there means no need to run it with perl -I at the command line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 15:48:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 14:48:18 +0000 Subject: [Koha-bugs] [Bug 12087] Improve purge of suggestions: to delete only suggestions with specified status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12087 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 15:48:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 14:48:44 +0000 Subject: [Koha-bugs] [Bug 13755] New: Suggestions: Strange additional tab if suggestion is saved without choosing a status Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13755 Bug ID: 13755 Summary: Suggestions: Strange additional tab if suggestion is saved without choosing a status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Created attachment 36142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36142&action=edit Strange additional tab in suggestion management Saving a suggestion without setting a status results in an additional tab that contains all of the suggestions. To reproduce: 1) Create some suggestions with different statuses. 2) Go to the suggestion list view (suggestion/suggestion.pl) 3) In datatable, check one of the suggestions. 4) Leave dropdown "Status" on "--Choose a status --" and click "Submit" Result: Edited suggestion is no longer visible in this tab. Suggestion list view gets a strange new tab with count of all suggestions as header and containing all of suggestions (including edited suggestion). See attachment with screenshots. What I would expect: Some warning "Please choose a status" or better Update record without status change if a Reason but no status is given. --- Reproduced on current master 3.19.00.011 with and without Patch for Bug 13731 Reproduced on 3.18.01.000 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 15:59:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 14:59:46 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 --- Comment #16 from Kyle M Hall --- Created attachment 36143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36143&action=edit Bug 13159 [QA Followup] - Fix flag parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 16:10:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 15:10:43 +0000 Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27031|0 |1 is obsolete| | --- Comment #13 from Koha Team Lyon 3 --- Created attachment 36144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36144&action=edit Bug 12074 - Filter duplicates when adding a full batch from a staged file patch rebased -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 16:17:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 15:17:39 +0000 Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 16:22:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 15:22:10 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Just a guess: git grep 'Loading\.\.\.' The (long) result list contains following files. I have the impression that they are not translated. koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.min.js koha-tmpl/opac-tmpl/lib/jquery/plugins/jquery.dataTables.min.js koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.jeditable.mini.js -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 16:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 15:25:47 +0000 Subject: [Koha-bugs] [Bug 13756] New: Holds over date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13756 Bug ID: 13756 Summary: Holds over date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Would like to see hold over date calculated at time of hold and recorded in the requests table with the hold. As I understand it, holds over dates are calculated when the holds over table is looked at. This is a very loose calculation, since if the value of ReservesMaxPickUpDelay is changed at any time, the holds over period changes with that, regardless of when the hold was filled. Some libraries may prefer to have that date fixed in place on the table, while others might want the fluid, on the spot calculation, so perhaps it should be an option. For me, as someone dealing with consistency and reports, a fixed date in the table is preferred. It would be great to be able to run custom reports and see those dates. It would be great to have that date show in the holds information for both item and patron screens on the staff side. It would be great to be able to print that date on the hold slips. It would be great to know that if we let patrons know how long they have to pick something up, that won't change because an adjustment is made to ReservesMaxPickUpDelay (although, how often does that happen?). My two cents. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 16:27:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 15:27:46 +0000 Subject: [Koha-bugs] [Bug 13757] New: Make patron attributes editable in the opac if set to be visible Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Bug ID: 13757 Summary: Make patron attributes editable in the opac if set to be visible Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Following on from Bug 12718 where Patron Extended Attributes were made visible in the My Details page of the OPAC, it would be useful if these could be editable by the patron, instead of just viewable. This should only apply to any attributes that are configured to display in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 16:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 15:27:57 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to be visible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 16:34:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 15:34:08 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Jonathan Druart --- (In reply to Paola Rossi from comment #19) Hi Paola, See comment 10, the patches attached to this bug are only there for reference. I don't update/maintain them. > 3) Are the problems in comment 18 been resolved by the 7 current patches? > Or would this Bug 13321 be passed to an "In discussion" status? I did not find any issues when testing, so yes, it is the way it's done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 17:37:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 16:37:03 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it --- Comment #6 from Paola Rossi --- On master 3.19.00.001 head 13645, using FireFox 36 I edited a journal, ACEEE ISSN 2158-754X. Using "Tag editor", I edited the 008 MARC21 field of the journal. A new window was opened, whose current URL was: On 15-17 field, first I emptied the field. Then I wrote n, waiting for an autocompletion drop down list of all the country codes beginning by 'n'. But no list appeared. Then I wrote ny, waiting for the value's autocompletion "nyu", but it didn't appear. So I could not reproduce the bug. I keep the status of this bug to "Needs Signoff" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 17:48:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 16:48:22 +0000 Subject: [Koha-bugs] [Bug 13748] Acquisition wizard: some strings not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13748 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- "All item types ": See reports/acquisitions/stats.pl line 128 "All funds": See line 147 Additionally, 'Collection code' seems not to be translated (first column), it is related to a variable $ccode_lable that is set in reports/acquisitions/stats.pl line 237, and this variable depends on GetMarcSubfieldsStructureFromKohaField (C4/Bilio.pm) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 17:52:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 16:52:14 +0000 Subject: [Koha-bugs] [Bug 9968] Error when a search is done with Standard number option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:02:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:02:45 +0000 Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 36145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36145&action=edit Bug 7793 - redefine the field message_id as PRIMARY KEY of message_queue Making message_queue work nicely with DBIx. DROP the existing KEY and replace with an PRIMARY KEY. If somebody has managed to get duplicate message_ids in his/her message_queue-table, this patch takes care of them as well, but givin all duplicate message_id's a new id. TEST INSTRUCTIONS: in the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:03:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:03:03 +0000 Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Assignee|stephane.delaune at biblibre.c |olli-antti.kivilahti at jns.fi |om | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:04:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:04:10 +0000 Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:04:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:04:24 +0000 Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11743|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:06:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:06:20 +0000 Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from Olli-Antti Kivilahti --- Sorry to steal your bug. Here is everything inside one commit + the rare case of duplicate PKs. No discussion for this one. It is a no-brainer to have a PRIMARY KEY, especially since DBIx-operations fail without it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:18:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:18:38 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:19:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:19:17 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:21:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:21:01 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #16 from Tom?s Cohen Arazi --- Created attachment 36146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36146&action=edit Bug 13523: DBIC updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:24:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:24:45 +0000 Subject: [Koha-bugs] [Bug 13689] Remove opac-old.css and sco-old.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13689 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:25:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:25:11 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:25:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:25:42 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:43:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:43:36 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to be visible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- This would be very useful, e.g. for managing newsletters. I think we should have two settings in /cgi-bin/koha/admin/patron-attr-types.pl - Viewable but not not editable: Display in OPAC: [] Check to display this attribute on a patron's details page in the OPAC. - Viewable and editable: Edit in OPAC: [] Check to display and allow to edit this attribute on a patron's details page in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 18:47:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 17:47:49 +0000 Subject: [Koha-bugs] [Bug 13727] Validation of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13727 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 19:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 18:13:36 +0000 Subject: [Koha-bugs] [Bug 12329] Inventory setting date last seen to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12329 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 19:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 18:14:24 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Viktor! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 19:14:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 18:14:54 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Benjamin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 19:15:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 18:15:24 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail when loading templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:24:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:24:39 +0000 Subject: [Koha-bugs] [Bug 6481] Koha doesn't have a way to set a preferred language from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6481 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:25:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:25:57 +0000 Subject: [Koha-bugs] [Bug 13681] Enable/Disable Marc Frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13681 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:27:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:27:51 +0000 Subject: [Koha-bugs] [Bug 9968] Error when a search is done with Standard number option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:32:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:32:08 +0000 Subject: [Koha-bugs] [Bug 13727] Validation of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13727 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:37:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:37:42 +0000 Subject: [Koha-bugs] [Bug 13758] New: KOHAVERSION should be statically set Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Bug ID: 13758 Summary: KOHAVERSION should be statically set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Currently, C4::Context::KOHAVERSION calculates the version number by running kohaversion.pl on a new Perl interpreter: sub KOHAVERSION { my $cgidir = C4::Context->intranetdir; # Apparently the GIT code does not run out of a CGI-BIN subdirectory # but distribution code does? (Stan, 1jan08) if(-d $cgidir . "/cgi-bin"){ my $cgidir .= "/cgi-bin"; } do $cgidir."/kohaversion.pl" || die "NO $cgidir/kohaversion.pl"; return kohaversion(); } There's no point on doing this, as it is a hardcoded value we write on each DB update. It adds several milliseconds of latency to each request as the version comparisson is done on each request to detect needed DB updates. It should be statically set as $VERSION is (hmpf) on C4::Context, and if for some reason we want to keep kohaversion.pl we should definitely read C4::Context::VERSION (or KOHAVERSION if we rename it). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:38:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:38:07 +0000 Subject: [Koha-bugs] [Bug 12392] trying to vote gets invalid parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12392 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Still valid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:40:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:40:55 +0000 Subject: [Koha-bugs] [Bug 13701] Sharing lists: Text hardcoded to 2 weeks, but could be any time frame In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13701 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:42:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:42:12 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:42:40 +0000 Subject: [Koha-bugs] [Bug 11448] Accessibility: Make it possible to enter date for restriction without using the datepicker widget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11448 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 20:44:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 19:44:54 +0000 Subject: [Koha-bugs] [Bug 13543] Differences in patron account sidebar cause translation problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13543 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 21:06:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 20:06:20 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Still valid on 3.19.00.012 Seems to be by design See: suggestion/suggestion.pl around line 132 ###FIXME:Search here if suggestion already exists. my $suggestions_loop = SearchSuggestion( $suggestion_only ); if (@$suggestions_loop>=1){ #some suggestion are answering the request Donot Add } else { ## Adding some informations related to suggestion &NewSuggestion($suggestion_only); } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 21:09:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 20:09:47 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 21:14:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 20:14:00 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 21:14:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 20:14:27 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 21:22:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 20:22:25 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 21:40:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 20:40:44 +0000 Subject: [Koha-bugs] [Bug 6967] Create suggestion from z39.50 / existing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6967 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 21:44:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 20:44:12 +0000 Subject: [Koha-bugs] [Bug 13729] Give news in Opac a unique anchor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 --- Comment #5 from Viktor Sarge --- Always fun to get something pushed. Thanks :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 22:48:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 21:48:12 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #39 from H?ctor Eduardo Castro Avalos --- Created attachment 36147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36147&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML is not well-formed document and do not follows the DC-XML recommendations as should be. New feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document is not well formed 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C and OAI-DC can be validated by other validator. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities not found in .deb package New patch for work with librdf-helper-perl (2.0) and librdf-trine-perl (1.000). RDF::Trine and RDF::Helper not need to be upgraded. Tested in both (upgraded and not upgraded) Fix some utf8 encoding. Tested with chinese record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 24 22:55:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Feb 2015 21:55:53 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #40 from H?ctor Eduardo Castro Avalos --- Hi Marc and Jonathan Sorry about the inconvenience. After new Koha's cloning and installation, the patch is ready. I fix it up the code about the chmod changes. Please, test the patch again. Regards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 01:15:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 00:15:40 +0000 Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax included values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Francois Charbonnier --- Jonathan submited a patch to fix the issue I mentionned in comment3. Since, the discussion spread through two tickets (13324 and 13321), the patch I'm talking about is here : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321#c15 I tested again the feature from this ticket and everyting works like a charm. I did the testing on biblibre's sanbox 17. Jonathan, could you sign this patch off on my behalf? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 01:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 00:52:48 +0000 Subject: [Koha-bugs] [Bug 13754] Missing changelogs for debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13754 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Robin Sheat --- Added changelog generation to the package deploying process. $ apt-get changelog koha-common Fout Logbestand met veranderingen aan koha-common (http://packages.debian.org/changelogs/pool/main/k/koha/koha_3.19~git+20150224183809.993028f9/changelog) 404 Not Found Ophalen:1 Logbestand met veranderingen aan koha-common (http://debian.koha-community.org/koha/pool/main/k/koha/koha_3.19~git+20150224183809.993028f9.changelog) [8657 B] 8657 B opgehaald in 5s (1545 B/s) Although you'll not find the changelog for 3.18.03 there anyway, as 3.18.04 is the current one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 02:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 01:22:49 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #21 from Francois Charbonnier --- I tested on BibLibre's sandbox 17 all the configurations from the RFC (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC) and compared every displayed numbers. All calculations are good except for one. It's a very small glitch on the invoice page. The tax valule is not correct. It doesn't take the quantity into consideration. To reproduce the problem : 1. Create a vendor (ordre price includes tax, invoice price includes tax) 2. Add an order : - 2 items - vendor price : 10 euros - tax rate : 5% tax 3. Close the basket and receive the 2 ordered items 4. Check the "Already received" table : the tax is 0,95 euros 5. Click finish receiving (invoice.pl) 6. Check the "Invoice details" table : the tax is 0.48 euros (the value for 1 item). It should be multiply by the quantity. Jonathan, do you want to fix this here OR do you want to open another issue specific to the invoice page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 03:28:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 02:28:26 +0000 Subject: [Koha-bugs] [Bug 13754] Missing changelogs for debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13754 --- Comment #2 from Pablo AB --- Thank you Robin! That was fast :) I'm not sure if this is the expected behavior (to stdout): apt-get changelog koha-common Err Changelog for koha-common (http://packages.debian.org/changelogs/pool/main/k/koha/koha_3.18.04/changelog) 404 Not Found Des:1 Changelog for koha-common (http://debian.koha-community.org/koha/pool/main/k/koha/koha_3.18.04.changelog) [9.123 B] Next a man interface with: koha (3.18.04) squeeze; urgency=medium * New upstream release (3.18.04) -- Robin Sheat Tue, 24 Feb 2015 14:53:21 +1300 koha (3.18.03) squeeze; urgency=medium * New upstream release (3.18.03) -- Robin Sheat Fri, 23 Jan 2015 12:59:53 +1300 koha (3.18.02) squeeze; urgency=medium * New upstream release (3.18.02) -- Robin Sheat Mon, 29 Dec 2014 17:53:02 +1300 and so one, not a "real" changelog. That's OK? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 03:45:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 02:45:51 +0000 Subject: [Koha-bugs] [Bug 13754] Missing changelogs for debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13754 --- Comment #3 from Robin Sheat --- That is the changelog :) Most debian projects are like this, but they also document their own extra patches. I don't (generally) apply my own patches. There's little point in repeating the documentation which is installed into /usr/share/doc/koha-common anyway, and is on the website/mailing lists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 04:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 03:54:05 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #3) > I'd be happy to help testing - just not sure how to do it. 1) Find the unix socket for your zebra database Find "koha-conf.xml" and get the value from e.g. "unix:/blah/blah/zebradb/bibliosocket" 2) Connect to the socket using yaz-client "yaz-client unix:/blah/blah/zebradb/bibliosocket" 3) Select the correct database "base biblios" 3) Run some queries "find @attr 1=4 P?dagogik" "find @attr 1=4 @attr 4=1 @attr 6=3 P?dagogik" @attr 1=4 @attr 4=1 @attr 6=3 is the PQF equivalent of the "ti,ext" CCL, while @attr 1=4 is the same as "ti". 4) Compare the results to see if they return the same results or not -- This should show whether or not these queries are returning the same results. If they are returning the same results, it's a bug in Zebra. If they aren't returning the same results using yaz-client, but they are when using Koha, then it's down to the "extra stuff" that we do to queries before sending them off to Zebra. In that case, you'd need to add some debugging code to see the query before it gets sent off to Zebra. This is probably best done in search.pl or opac-search.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:02:41 +0000 Subject: [Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 --- Comment #5 from David Cook --- For what it's worth, I just tried: Z> base biblios Z> find @attr 1=4 test Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 5, setno 4 SearchResult-1: term=test cnt=5 records returned: 0 Elapsed: 0.000979 Z> find @attr 1=4 @attr 4=1 @attr 6=3 test Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 0, setno 5 SearchResult-1: term=test cnt=0 records returned: 0 Elapsed: 0.000381 This is using Zebra 2.0.60 from IndexData's Debian repository. -- I just tried in the staff client of Koha 3.8 and got the same results as I did in Zebra. I've tried changing the QueryAutoTruncate, QueryStemming, and QueryWeightFields system preferences to see if they made a difference, but there was no difference. -- Maybe I just don't have the right test string though. What do you mean when you say that "results don't match the expected result"? Can you share the URL of the site where you're experiencing the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:09:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:09:48 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 --- Comment #15 from Robin Sheat --- Created attachment 36148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36148&action=edit Bug 13607: fix to set default messaging preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:10:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:10:56 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Robin Sheat --- (In reply to Magnus Enger from comment #14) > - EnhancedMessagingPreferences = allow > - Create a new patron from scratch > - Change the category from the default one > - Firebug reports a 500 error for > /cgi-bin/koha/members/default_messageprefs.pl I did this with the new patch added, and it doesn't fail. With the previous version, I was failing to set the default preferences, and this apparently upsets something in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:31:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:31:41 +0000 Subject: [Koha-bugs] [Bug 13745] Serial collection page shows branchcode instead of branchname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:31:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:31:43 +0000 Subject: [Koha-bugs] [Bug 13745] Serial collection page shows branchcode instead of branchname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36115|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 36149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36149&action=edit Bug 13745: Fix serial collection page to always show branch name The serial collection page shows 2 tables, one for the subscriptions and a second for the issues. Both show the branch, but the first showed the code while the second showed the name. With this patch both tables show the name. To test: - Search for a subscription or create one - Navigate to the serial collection page (navigation on left side) - Check both tables on the page show the branch name with the patch applied Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:33:26 +0000 Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Needs Signoff |Failed QA --- Comment #4 from Brendan Gallagher --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 40) from the qa script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:37:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:37:13 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:37:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:37:15 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36096|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 36150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36150&action=edit Bug 13740: Remove the NOT NULL clause in GetBorrowersToExpunge C4::Borrowers::GetBorrowersToExpunge should not use a "NOT IN", it is not efficient at all. With only 1 guarantor and more than 136k patrons, the not in clause in this subroutine takes ages: mysql> select count(*) FROM borrowers where borrowernumber NOT IN (SELECT guarantorid FROM borrowers WHERE guarantorid IS NOT NULL AND guarantorid <> 0) ; [...] not ended after 5min With the query modified by this patch, the results come after 1 sec :) Test plan: Verify the delete_patrons.pl cronjob or the cleanborrowers tools work as before. Especially with guarantors. Signed-off-by: Brendan Gallagher I had 2 guarantors/guarentees - worked ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:40:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:40:56 +0000 Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 05:40:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 04:40:59 +0000 Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35431|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 36151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36151&action=edit Bug 13605 - _AUTHOR_ not replaced in relatives checkouts In members/moremember.pl, in relatives checkouts tab, "by _AUTHOR_" appears before author. This code sould be replaced in JS. Test plan : - Go to a borrower with relative's checkouts => without patch : you see "by _AUTHOR_" string before author name => with patch : you see "by" string before author name Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:04:40 +0000 Subject: [Koha-bugs] [Bug 13578] Parameter public is lost on creating a report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:04:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:04:42 +0000 Subject: [Koha-bugs] [Bug 13578] Parameter public is lost on creating a report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35181|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 36152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36152&action=edit Bug 13578: Make sure the 'public' parameter is passed to the last step If no caching system is up ($usecache == 0), the public parameter is lost on the step 3. The hash passed to the template looks like: 'cache_expiry', 300, 'cache_expiry_units', 'public', 1 So the template receives cache_expiry = 300, cache_expiry_units = 'public' and 1 = undef. This patch fixes the problem passing the cache_expiry* parameters only if the usecache is set. Test plan: 0/ Disable any caching system 1/ Create a new public report and go up to the 6th step, save the report and verify the report is created as public 2/ Enable a caching system 2/ Create a public report with a cache expiry value, save it and verify the report is created as public and the cache expiry value is correct. Signed-off-by: Brendan Gallagher Been a bit since I've been in the guided reports. This worked, I had memcached (on/off) also tested with Starman (on/off). So good by me. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:11:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:11:12 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:24:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:24:29 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:24:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:24:31 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35351|0 |1 is obsolete| | --- Comment #5 from Brendan Gallagher --- Created attachment 36153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36153&action=edit Bug 13539 - Remove unused table patroncards It appears that the table patroncards hasn't been used since the database updates for the rewritten label modules ('3.01.00.107'). It's time to remove them from the database. As the patron card batches were needed for printing and the data has not been accessible in a long time, it seems safe to delete it. Signed-off-by: Brendan Gallagher Removes the tables. Seems safe to delete to me too, while testing through the patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:33:04 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #41 from Marc V?ron --- Created attachment 36154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36154&action=edit [Signed-off]Bug 13642 - Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML is not well-formed document and do not follows the DC-XML recommendations as should be. New feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document is not well formed 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C and OAI-DC can be validated by other validator. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities not found in .deb package New patch for work with librdf-helper-perl (2.0) and librdf-trine-perl (1.000). RDF::Trine and RDF::Helper not need to be upgraded. Tested in both (upgraded and not upgraded) Fix some utf8 encoding. Tested with chinese records. http://bugs.koha-community.org/show_bug.cgi?id=13642 Followed test plan. Works as expected. (Changed title of commit message.) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:34:29 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36147|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:35:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:35:03 +0000 Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:35:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:35:05 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:35:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:35:07 +0000 Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35878|0 |1 is obsolete| | --- Comment #13 from Brendan Gallagher --- Created attachment 36155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36155&action=edit Bug 12820: Handle rental fees in Sip issue and renew Implement correct handling of fees associated with checking out an item. This is associated with fee acknowledged field (BO) To quote from the Sip2 document " If this field is N in a Checkout message and there is a fee associated with checking out the item, the ACS should tell the SC in the Checkout Response that there is a fee, and refuse to check out the item. If the SC and the patron then interact and the patron agrees to pay the fee, this field will be set to Y on a second Checkout message, indicating to the ACS that the patron has acknowledged the fee and checkout of the item should not be refused just because there is a fee associated with the item" So there are two Checkout requests the first with BO not set to Y is rejected but the fee amount is returned. The Second Checkout with BO set to Y should succeed. Added a debug log message indicating why we block a checkout when we dont otherwise indicate Signed-off-by: Brendan Gallagher I tested with telnet and generated sip messages to get response. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 06:38:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 05:38:17 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher --- (In reply to David Cook from comment #5) > Note to testers: > > These patches can be tested one by one or all at once, since Pt. 2 carries > forward the change from Pt. 1. Testing with ? ? ? ? ? ? ? ? ? ? ? Hebrew... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 10:23:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 09:23:21 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36123|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 36156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36156&action=edit Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 10:23:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 09:23:50 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 --- Comment #10 from Jonathan Druart --- (In reply to Marc V?ron from comment #8) > I think the changes to installer/data/mysql/updatedatabase.pl are missing in > this patch (Attachment #36123 [details]). > They were in previous, obsoleted patch (Attachment #18719 [details]). Yes of course, thanks for the catch Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 10:54:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 09:54:39 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 --- Comment #3 from Jonathan Druart --- (In reply to Brendan Gallagher from comment #2) > Created attachment 36150 [details] [review] > Bug 13740: Remove the NOT NULL clause in GetBorrowersToExpunge > Signed-off-by: Brendan Gallagher > I had 2 guarantors/guarentees - worked ok. Arg, the partner has found a problem with this patch. Actually it catches the patrons *with* a guarantor, and it is not what we want here. I will submit a follow-up and switch the status back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 10:55:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 09:55:46 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 10:55:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 09:55:49 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 --- Comment #4 from Jonathan Druart --- Created attachment 36157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36157&action=edit Bug 13740: Fix null vs not null in the query The previous patch did not work, only patrons *with* guanrantees were deleted! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 11:24:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 10:24:49 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #22 from Jonathan Druart --- Very nice catch Fran?ois :) That comes from a commit on bug 13323: commit b5e9c8a8821f950933c19b8524fe2af3a98d05d7 Author: Jonathan Druart Date: Wed Nov 19 17:01:17 2014 +0100 Bug 13323: Tax rate can change on receiving This commit permits to update the tax rate on receiving. diff --git a/acqui/invoice.pl b/acqui/invoice.pl index 3a163c5..9fcef0e 100755 --- a/acqui/invoice.pl +++ b/acqui/invoice.pl @@ -126,7 +126,8 @@ foreach my $order (@$orders) { - $line->{tax_value} *= $line->{quantity}; + $line->{tax_value} = $line->{tax_value_on_receiving}; + $line->{tax_rate} = $line->{tax_rate_on_receiving}; It should have been: - $line->{tax_value} *= $line->{quantity}; + $line->{tax_value} = $line->{tax_value_on_receiving} * $line->{quantity}; + $line->{tax_rate} = $line->{tax_rate_on_receiving}; The quantity has been forgotten. I updated the commit, the branch and the sandbox with this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 11:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 10:39:35 +0000 Subject: [Koha-bugs] [Bug 12705] News not possible for one sublanguage if two sublanguages are installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12705 --- Comment #11 from Mason James --- (In reply to Tom?s Cohen Arazi from comment #10) > Patch pushed to master. > > Thanks Marc! Pushed to 3.16.x, patch will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 11:44:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 10:44:34 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 11:44:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 10:44:37 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36153|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 36158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36158&action=edit Bug 13539 - Remove unused table patroncards It appears that the table patroncards hasn't been used since the database updates for the rewritten label modules ('3.01.00.107'). It's time to remove them from the database. As the patron card batches were needed for printing and the data has not been accessible in a long time, it seems safe to delete it. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 11:54:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 10:54:47 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 --- Comment #13 from Mason James --- (In reply to Tom?s Cohen Arazi from comment #10) > Patch pushed to master. Pushed to 3.16.x, patch will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:02:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:02:40 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #16 from Mason James --- (In reply to Jonathan Druart from comment #15) > Magnus, could you please confirm this patch works for 3.16.x? > > (I tested it and it fixes the problem for 3.16.x) I've tested this 2nd patch on 3.16.x. It works OK for me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:03:48 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #17 from Mason James --- (In reply to Mason James from comment #16) > (In reply to Jonathan Druart from comment #15) > > Magnus, could you please confirm this patch works for 3.16.x? > > > > (I tested it and it fixes the problem for 3.16.x) > > > I've tested this 2nd patch on 3.16.x. Pushed to 3.16.x, patch will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:12:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:12:36 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #21 from Mason James --- (In reply to Mason James from comment #20) > Pushed to 3.16.x, will be in 3.16.7 Oops, I accidentally introduced a merge bug in the .tt file, with this patchset I'm going to revert this for the 3.16.8 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:16:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:16:56 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:16:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:16:59 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36132|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 36159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36159&action=edit Bug 10971: Hide EAN search for MARC21 / template corrections This patch hides the EAN filter on the page for ordering from a subscription when the marcflavour is not UNIMARC as it will only work for this flavour currently. It also corrects - branch to library - supplier to vendor - the library code in the result list to the branch name To test: - Make sure you have a subscription, not the vendor - Create a new basket for the subscription vendor - Choose 'from a subscription' to create your order line - Look at the filters on the left side, switch the marcflavour system preference to see change for the EAN filter - Verify changes Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:25:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:25:16 +0000 Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name, not branch code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:25:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:25:19 +0000 Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name, not branch code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36129|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36160&action=edit Bug 13750: Holds queue - Show branch name instead of branch code When the holds queue report is limited to one library, it shows items found for With the patch applied, the branch name is shown instead of the code. To test: - Go to circulation > Holds queue - Limit to one branch with holds waiting to be processed - Confirm the string has changed to show the branch name Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:25:25 +0000 Subject: [Koha-bugs] [Bug 13750] Holds queue: Always show branch name, not branch code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13750 --- Comment #4 from Jonathan Druart --- Created attachment 36161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36161&action=edit Bug 13750: Fix capitalization All vs ALL Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:31:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:31:02 +0000 Subject: [Koha-bugs] [Bug 13745] Serial collection page shows branchcode instead of branchname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:31:05 +0000 Subject: [Koha-bugs] [Bug 13745] Serial collection page shows branchcode instead of branchname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13745 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36149|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36162&action=edit Bug 13745: Fix serial collection page to always show branch name The serial collection page shows 2 tables, one for the subscriptions and a second for the issues. Both show the branch, but the first showed the code while the second showed the name. With this patch both tables show the name. To test: - Search for a subscription or create one - Navigate to the serial collection page (navigation on left side) - Check both tables on the page show the branch name with the patch applied Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:31:38 +0000 Subject: [Koha-bugs] [Bug 13731] Suggestions reason doesn't save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:31:59 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:35:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:35:59 +0000 Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:36:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:36:02 +0000 Subject: [Koha-bugs] [Bug 13741] "No fund found" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36127|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 36163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36163&action=edit Bug 13741: "No fund found" is not translatable The string "No fund found" on the funds overview page is not translatable. To test: - Create a new budget - Check for the string on the funds page of the new budget - Run an update on one of the po file sets cd misc/translator perl translate update - Verify that the string now appars in the po file for staff - Verify the page still looks the same as before the patch Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:38:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:38:08 +0000 Subject: [Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|3.16 |master --- Comment #1 from Mason James --- Hmm, I think this bug is applicable for 'master' Koha too, not just 3.16.x I will update bug... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:41:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:41:58 +0000 Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744 --- Comment #5 from Katrin Fischer --- Good catch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:44:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:44:09 +0000 Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #3 from Jonathan Druart --- Comment on attachment 36128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36128 Bug 13680 - Items list on edit items page separates add items form from header and sidebar Review of attachment 36128: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13680&attachment=36128) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ +134,4 @@ > >
    >
    > +

    Add items to [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])

    Not sure this change is consistent: If you edit an item, you see: Add items to my_bib Edit Item #23192 There is Add vs Edit on the same page. Maybe it is better to keep the original wording here, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:49:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:49:19 +0000 Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:49:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:49:22 +0000 Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36133|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36164&action=edit Bug 13676 - OpacSuppression description says 'items' but means 'records' This patch changes the wording for the OpacSuppression preference description. Without patch: ... items marked as suppressed from OPAC search results. Note that you must have the Suppress index set up in Zebra and at least one suppressed item, or your searches will be broken. ... With patch: ... items marked as suppressed from OPAC search results. Note that you must have the Suppress index set up in Zebra and at least one suppressed biblio record, or your searches will be broken. ... Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:50:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:50:35 +0000 Subject: [Koha-bugs] [Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate, | |rel_3_16_candidate --- Comment #11 from Mason James --- (In reply to Jonathan Druart from comment #10) > Mason, Fridolin, > IMO it makes sense to backport this one. cheers, i'll take a look -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 12:57:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 11:57:45 +0000 Subject: [Koha-bugs] [Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Mason James --- (In reply to Mason James from comment #11) > (In reply to Jonathan Druart from comment #10) > > Mason, Fridolin, > > IMO it makes sense to backport this one. > > cheers, i'll take a look Pushed to 3.16.x branch. Patch will be in included in 3.16.8 release -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 13:25:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 12:25:13 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 13:25:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 12:25:16 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36126|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 36165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36165&action=edit Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 13:25:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 12:25:24 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #8 from Jonathan Druart --- Created attachment 36166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36166&action=edit Bug 13746: Add tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 13:25:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 12:25:24 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 13:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 12:31:38 +0000 Subject: [Koha-bugs] [Bug 12705] News not possible for one sublanguage if two sublanguages are installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12705 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 13:40:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 12:40:35 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | --- Comment #17 from Mason James --- (In reply to Galen Charlton from comment #15) > Pushed to master. Thanks, Fridolin! Patch already added to 3.16.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 13:49:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 12:49:35 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #42 from Jonathan Druart --- (In reply to Marc V?ron from comment #41) > Created attachment 36154 [details] [review] > [Signed-off]Bug 13642 - Adding new features for Dublin Core metadata > > When Koha export a bibliographic record to DC, makes it in XML format. This > XML is not well-formed document and do not follows the DC-XML > recommendations as should be. How can I know if the xml is not well-formed? I tested on http://validator.w3.org/check and got: This document was successfully checked as well-formed XML! Result: Passed, 2 warning(s) > XML::Entities not found in .deb package Maybe XML::LibXML can do the trick? > New patch for work with librdf-helper-perl (2.0) and librdf-trine-perl > (1.000). > RDF::Trine and RDF::Helper not need to be upgraded. Tested in both (upgraded > and not upgraded) I don't have librdf-helper-perl E: Unable to locate package librdf-helper-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 13:50:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 12:50:19 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #43 from Jonathan Druart --- (In reply to Jonathan Druart from comment #42) > > New patch for work with librdf-helper-perl (2.0) and librdf-trine-perl > > (1.000). > > RDF::Trine and RDF::Helper not need to be upgraded. Tested in both (upgraded > > and not upgraded) > > I don't have librdf-helper-perl > E: Unable to locate package librdf-helper-perl Ha, it is in wheezy but not in jessie. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:21:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:21:25 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | Status|Pushed to Master |Pushed to Stable --- Comment #32 from Mason James --- Patch already included in 3.16.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:25:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:25:29 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | --- Comment #69 from Mason James --- (In reply to Galen Charlton from comment #68) > Pushed to master, along with follow-ups. Thanks, Kyle! Enhancement, skipping patch for 3.16.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:27:10 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | --- Comment #33 from Mason James --- (In reply to Galen Charlton from comment #23) > Pushed to master. Thanks, Colin! Patch already included in 3.16.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:28:28 +0000 Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | --- Comment #17 from Mason James --- (In reply to Galen Charlton from comment #15) > Pushed to master. Thanks, Jonathan! Patch already included in 3.16.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:28:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:28:46 +0000 Subject: [Koha-bugs] [Bug 11715] Z39.50 search page does not check authorization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11715 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:29:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:29:41 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | --- Comment #20 from Mason James --- (In reply to Galen Charlton from comment #18) > Pushed to master. Thanks, Adrien and Christophe! Patch already included in 3.16.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:31:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:31:46 +0000 Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | CC| |mtj at kohaaloha.com Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:32:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:32:35 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:32:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:32:58 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:33:59 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:34:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:34:24 +0000 Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:34:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:34:52 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:35:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:35:11 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:35:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:35:48 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:40:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:40:56 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | CC| |mtj at kohaaloha.com Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:41:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:41:43 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:43:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:43:49 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:44:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:44:41 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:45:10 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:45:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:45:49 +0000 Subject: [Koha-bugs] [Bug 12778] Regression: Item lost status doesn't show in list of checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12778 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:46:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:46:20 +0000 Subject: [Koha-bugs] [Bug 13122] Patron holds table no longer display date item went in transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13122 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:47:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:47:22 +0000 Subject: [Koha-bugs] [Bug 13168] "Today's checkouts" sort improperly because issuedate lacks seconds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13168 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:49:51 +0000 Subject: [Koha-bugs] [Bug 13195] Regression: Circulation checkouts table no longer shows item type description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13195 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:50:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:50:47 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 14:51:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 13:51:06 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 15:20:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 14:20:04 +0000 Subject: [Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron personal details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 15:43:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 14:43:21 +0000 Subject: [Koha-bugs] [Bug 13759] New: git-build-snapshot misses YUI and dies of sorrow during build Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13759 Bug ID: 13759 Summary: git-build-snapshot misses YUI and dies of sorrow during build Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Due to a line in debian/rules, git-build-snapshot tries to delete a YUI-related path that does not exist anymore (bug 13612 I guess). Build process ends with an error. rm: cannot remove `/tmp/buildd/koha-3.19.01/debian/tmp/usr/share/koha/opac/htdocs/opac-tmpl/lib/yui': No such file or directory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 15:43:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 14:43:38 +0000 Subject: [Koha-bugs] [Bug 13759] git-build-snapshot misses YUI and dies of sorrow during build In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13759 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 15:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 14:51:15 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #5 from Paola Rossi --- I've applied the patch against master 3.19.00.012 head 13473. On tools I've copied an ACCTDETAILS' notice to CPL, checking ON its "Html message" box as required. I received a mail against a new patron. The source of the message of the mail I received was exactly the same of the mail's source I received on master (f.e. still "text/plain"). If I asked to the email client to show the received mail as "HTML" or as "text" I saw no difference. [Is there any notice which is OK about the "HTML message" option?] I think this bug had not fixed the error. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 15:55:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 14:55:26 +0000 Subject: [Koha-bugs] [Bug 13759] git-build-snapshot misses YUI and dies of sorrow during build In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13759 --- Comment #1 from Mirko Tietgen --- Created attachment 36167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36167&action=edit Bug 13759 - git-build-snapshot misses YUI and dies of sorrow during build Due to a line in debian/rules, git-build-snapshot tries to delete a YUI-related path that does not exist anymore (bug 13612 I guess). Build process ends with an error. This patch deletes the line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 15:56:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 14:56:00 +0000 Subject: [Koha-bugs] [Bug 13759] git-build-snapshot misses YUI and dies of sorrow during build In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13759 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 16:17:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 15:17:02 +0000 Subject: [Koha-bugs] [Bug 13760] New: Authorities merge sometimes create duplicate fields in biblio Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Bug ID: 13760 Summary: Authorities merge sometimes create duplicate fields in biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When merging two authorities the biblio records linked to those authorities are updated. It is directly done if syspref "dontmerge" is on "Do". Actually some cases create a duplicate field. For example, a biblio record as : 600 $9 11 $a Son Goku 600 $9 12 $a Vegeta If you merge the authorities id=11 and id=12 into id=11 (creating Gogeta), you actually get : 600 $9 11 $a Son Goku 600 $9 11 $a Son Goku Having two identical fields linked to the same authority is useless. The same problem is even more frequent when merging two authorities of different type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 16:40:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 15:40:10 +0000 Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 --- Comment #1 from Fridolin SOMERS --- Created attachment 36168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36168&action=edit Bug 13760 - Authorities merge sometimes create duplicate fields in biblio When merging two authorities the biblio records linked to those authorities are updated. It is directly done if syspref "dontmerge" is on "Do". Actually some cases create a duplicate field. For example, a biblio record as : 600 $9 11 $a Son Goku 600 $9 12 $a Vegeta If you merge the authorities id=11 and id=12 into id=11 (creating Gogeta), you actually get : 600 $9 11 $a Son Goku 600 $9 11 $a Son Goku Having two identical fields linked to the same authority is useless. The same problem is even more frequent when merging two authorities of different type. This patch corrects this behavior by searching already existing field with the link to the autority, using flag $field_to_exists. This flag is not used in case the merge is after a single authority modification. Note that this patch changes the minium of code in order to rebase it easyly. A followup will do the code formatting. Test plan : - Set syspref dontmerge to 'Do' - Create a biblio record - Link a field to an authority (the field gets a $9). For example : 600 $9 11 $a Son Goku - Link a field to another authority (the field gets a $9). For example : 600 $9 12 $a Vegeta - Save the record - Index Zebra queue - Search for autority "Vegeta" - Click on "Merge" - Search for autority "Son Goku" - Click on "Merge" - Click on "Next" - Click on "Merge" - Go to biblio record => Without the patch : you see 2 fields linked to the same authority "Son Goku" => With the patch : you see 1 field linked to the authority "Son Goku" - Test also with autoritites of different type. - Check that modifying the autority "Son Goku" impacts the biblio record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 16:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 15:40:07 +0000 Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 16:55:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 15:55:23 +0000 Subject: [Koha-bugs] [Bug 9275] Missing '<' closing pharagraph tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9275 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 16:58:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 15:58:56 +0000 Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 16:59:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 15:59:35 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5572 CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 16:59:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 15:59:35 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11315 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 17:01:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 16:01:20 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 --- Comment #8 from Fridolin SOMERS --- Looks like it is close to the purpose of Bug 5572 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 17:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 16:29:29 +0000 Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in koha-indexer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36141|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 36169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36169&action=edit Bug 13753: koha-indexer contains invalid statement An incorrect conditional makes the indexer daemon fail to load. To test: - Enable the indexer daemon on packages [1] - Restart koha-common: $ service koha-common restart - Run $ ps waux | grep koha-indexer => FAIL: there's no reference to the rebuild_zebra.pl script (line should look like *rebuild_zebra.pl -daemon*) Run ps -ef | grep rebuild_zebra.pl too to make sure. - Apply the patch, repeat the steps => SUCCESS: the rebuild_zebra.pl script is ran - Sign off :-D Thanks Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 17:29:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 16:29:49 +0000 Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in koha-indexer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 17:30:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 16:30:59 +0000 Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in koha-indexer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #3 from Mirko Tietgen --- Not in the scope of this patch: I had to manually start koha-indexer. That is neither mentioned here nor on the Wiki, so I wonder if it is supposed to run automatically? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 17:43:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 16:43:33 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it --- Comment #7 from Paola Rossi --- (In reply to David Cook from comment #4) > Created attachment 34657 [details] [review] > Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8 > Pt. 2 > > The emails sent via SendAlerts don't take into account HTML format. > > _TEST PLAN_ > > Before applying: > > 1) Change system preference "AutoEmailOpacUser" to "Send" > 2) Change "ACCTDETAILS" notice to HTML and add HTML to it > 3) Create a new user with your email address > 4) Note how the email displays the HTML tags as plain text > > Apply patch > > 5) Create a new user with your email address > 6) Note how the email displays the email as an HTML email > > For thoroughness: > > 7) Change "ACCTDETAILS" notice to non-HTML > 8) Create a new user with your email address > 9) Note how the email displays the HTML as plain text I've applied the patch Pt.2 against master 3.19.00.012 head 13473. The patch needed a trivial rebase. Everything was OK just as required by the test plan. After the rebase, the patch Pt.2 about "html/plain" option will be able to be signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 17:44:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 16:44:08 +0000 Subject: [Koha-bugs] [Bug 13761] New: Hide toolbar when printing a list page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Bug ID: 13761 Summary: Hide toolbar when printing a list page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When printing a list page at Intranet, the toolbar is useless. Hide it in print.css. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 17:49:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 16:49:49 +0000 Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 --- Comment #1 from Fridolin SOMERS --- Created attachment 36170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36170&action=edit Bug 13761 - Hide toolbar when printing a list page When printing a list page at Intranet, the toolbar is useless. This patch add #searchheader to print.css. It will hide at print the toolbar in several pages : catalogue/results.tt members/member.tt patron_lists/list.tt patroncards/members-search.tt serials/member-search.tt virtualshelves/shelves.tt Test plan : - Try to print the page (you can use print preview) - Check the toolbar is missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 17:49:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 16:49:47 +0000 Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:01:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:01:23 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Paola Rossi --- (In reply to David Cook from comment #3) > Created attachment 34656 [details] [review] > Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8 > Pt 1 > > The UTF-8 charset in the content type is written as "utf8" instead of "utf-8" > in SendAlerts(), which causes UTF-8 characters to display incorrectly. > > _TEST PLAN_ > > Before Applying: > > 1) Edit ACCTDETAILS > 2) Add some UTF-8 characters > I recommend using the following website > http://www.ltg.ed.ac.uk/~richard/unicode-sample.html > > In my tests, I added the samples from Hebrew, Arabic, Basic Latin, > Latin-1 Supplement, Latin Extended-A, and Latin Extended-B. > > 3) Set the system preference "AutoEmailOpacUser" to "Send" > 4) Create a new user account with your email address > > 5) Note that the email in your inbox doesn't display the Unicode > characters correctly > > Apply the patch > > 6) Create a new user account with your email address > 7) Note that the email in your inbox _does_ display the > Unicode characters correctly. I've applied the patch Pt.1 against master 3.19.00.012 head 13473. I wrote some Greek chars in the Notice in: the Message subject, the Message body, in the Surname of the newing borrower/patron. There was nearby no difference between master and applied. This was a part of the source of the received mail, with the 1 diff I saw: ------- Subject: Your new Koha account details CPL- noHTML APPl ?????????? Charset: utf8 Date: Wed, 25 Feb 2015 17:53:39 +0100 Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" (1 diff: "utf8" on master) To: a.rossi at cineca.it Content-Transfer-Encoding: quoted-printable From: JeffSummCPL at gmail.com Message-Id: [...] ----------- I think the patch Pt.1 about UTF-8 didn't fix the problem. So I pass this Bug 12739 to "Failed QA" Status (see also Comment #7 about Pt.2). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:04:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:04:41 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12739 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:04:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:04:41 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13241 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:23:11 +0000 Subject: [Koha-bugs] [Bug 13762] New: biblionumber field and subfield can be called once in authorities merge Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Bug ID: 13762 Summary: biblionumber field and subfield can be called once in authorities merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In AuthoritiesMarc::merge, the call of GetMarcFromKohaField( "biblio.biblionumber", '' ) is into several foreach loops. This call can be extracted to be executed only once. Also, the biblionumber of each record can be stored in @reccache to avoid finding it twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:23:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:23:18 +0000 Subject: [Koha-bugs] [Bug 13762] biblionumber field and subfield can be called once in authorities merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:23:27 +0000 Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:23:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:23:47 +0000 Subject: [Koha-bugs] [Bug 13762] biblionumber field and subfield can be called once in authorities merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13760 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:23:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:23:47 +0000 Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13762 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:30:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:30:29 +0000 Subject: [Koha-bugs] [Bug 13762] biblionumber field and subfield can be called once in authorities merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 18:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 17:30:31 +0000 Subject: [Koha-bugs] [Bug 13762] biblionumber field and subfield can be called once in authorities merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 --- Comment #1 from Fridolin SOMERS --- Created attachment 36171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36171&action=edit Bug 13762 - biblionumber field and subfield can be called once in authorities merge In AuthoritiesMarc::merge, the call of GetMarcFromKohaField( "biblio.biblionumber", '' ) is into several foreach loops. This call can be extracted to be executed only once. Also, the biblionumber of each record can be stored in @reccache to avoid finding it twice. Test plan : - Set syspref dontmerge to 'Do' - Merging 2 authoritites - Check linked biblio records are impacted - Change an authority heading - Check linked biblio records are impacted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 20:08:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 19:08:25 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #23 from Francois Charbonnier --- I tested jonathan's last patch today. It works nicely. I placed orders with different vendors (different settings) and coulnd't find any side effects. Considering all the tests I did yesterday, I can safely sign off these patches. I tested on BibLibre's sandbox 17. Jonathan, could you sign this off for me? Thanks. PS : about comment 15, I tested the patch for BZ13324 (see comment 8). It works perfectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 21:04:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 20:04:49 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 --- Comment #11 from Marc V?ron --- Created attachment 36172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36172&action=edit [Signed-off] Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet Test plan (from comment #1) 1) Apply this patch 2) Run updatedatabase.pl 3) Verify the system pref OpacColorStyleSheet still works i.e. no change should be noted Additionally, I changed the path to an other stylesheet and verified that it worked. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 21:05:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 20:05:22 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 21:05:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 20:05:42 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 22:19:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 21:19:39 +0000 Subject: [Koha-bugs] [Bug 13763] New: Renew feature does not check for the BarcodeInputFilter option Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Bug ID: 13763 Summary: Renew feature does not check for the BarcodeInputFilter option Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jaker at mvwsd.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I noticed that the renew feature under circulation does not check to see if the itemBarcodeInputFilter is being used. Adding the following line directly after it assigns the barcode variable fixes this issue. $barcode = barcodedecode($barcode) if( $barcode && C4::Context->preference('itemBarcodeInputFilter')); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 23:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 22:26:59 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #6 from Mirko Tietgen --- How often is a value like this changed? I would expect this to be set once and probably never touched again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 23:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 22:29:34 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I think there is a use case for making the options easy to configure from the gui - multiple instances hosted on one server. Then every instance can decide on their defaults and you don't have to touch the cronjobs to make it happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 23:38:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 22:38:32 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 --- Comment #9 from David Cook --- (In reply to Paola Rossi from comment #8) > I think the patch Pt.1 about UTF-8 didn't fix the problem. > > So I pass this Bug 12739 to "Failed QA" Status (see also Comment #7 about > Pt.2). That's rather bizarre... it definitely worked for me when I wrote the patch. I'll have to look at this again when I find some time some day. What email client are you using? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 25 23:49:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 22:49:27 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 --- Comment #8 from Mirko Tietgen --- Right, I did not think about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 00:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Feb 2015 23:21:39 +0000 Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #4 from Nick Clemens --- Yeah, see your point, my only thought was it might seem odd to say "Items for TITLE_OF_BIB" when the items are not listed immediately. 'why I added the "Existing items for TITLE_OF_BIB" above the item list I am happy to keeping the wording as is, but maybe would prefer either: 1 - "Edit items for TITLE_OF_BIB" 2 - "TITLE_OF_BIB" and let the "Add item/Edit item #" indicate the current action -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 02:38:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 01:38:45 +0000 Subject: [Koha-bugs] [Bug 13759] git-build-snapshot misses YUI and dies of sorrow during build In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13759 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 02:38:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 01:38:49 +0000 Subject: [Koha-bugs] [Bug 13759] git-build-snapshot misses YUI and dies of sorrow during build In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13759 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36167|0 |1 is obsolete| | --- Comment #2 from Robin Sheat --- Created attachment 36173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36173&action=edit Bug 13759 - git-build-snapshot misses YUI and dies of sorrow during build Due to a line in debian/rules, git-build-snapshot tries to delete a YUI-related path that does not exist anymore (bug 13612 I guess). Build process ends with an error. This patch deletes the line. Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 02:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 01:39:26 +0000 Subject: [Koha-bugs] [Bug 13759] git-build-snapshot misses YUI and dies of sorrow during build In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13759 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Status|Signed Off |Passed QA Priority|P5 - low |P3 --- Comment #3 from Robin Sheat --- That must have crept in just after I did a master build yesterday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 02:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 01:57:46 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 03:36:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 02:36:55 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #44 from Robin Sheat --- (In reply to Jonathan Druart from comment #43) > > I don't have librdf-helper-perl > > E: Unable to locate package librdf-helper-perl > > Ha, it is in wheezy but not in jessie. ruh roh batman, that's often a bad sign. Any idea why? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 03:43:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 02:43:32 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 03:44:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 02:44:30 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 --- Comment #10 from Mason James --- (In reply to Chris Cormack from comment #9) > Pushed to 3.18.x will be in 3.18.4 possible selection for 3.16.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 03:47:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 02:47:09 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- (In reply to Chris Cormack from comment #8) > Pushed to 3.18.x will be in 3.18.4 possible selection for 3.16.9 --- Comment #10 from Mason James --- (In reply to Chris Cormack from comment #8) > Pushed to 3.18.x will be in 3.18.4 possible selection for 3.16.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 03:47:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 02:47:09 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- (In reply to Chris Cormack from comment #8) > Pushed to 3.18.x will be in 3.18.4 possible selection for 3.16.9 --- Comment #10 from Mason James --- (In reply to Chris Cormack from comment #8) > Pushed to 3.18.x will be in 3.18.4 possible selection for 3.16.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 03:48:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 02:48:43 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 --- Comment #13 from Mason James --- (In reply to Chris Cormack from comment #12) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 03:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 02:49:17 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #13 from Mason James --- (In reply to Chris Cormack from comment #12) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:05:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:05:50 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #7 from Mason James --- (In reply to Chris Cormack from comment #6) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:07:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:07:15 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #6 from Mason James --- (In reply to Chris Cormack from comment #5) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:10:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:10:22 +0000 Subject: [Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #10 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:11:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:11:24 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #15 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:18:36 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com Status|Pushed to Master |Pushed to Stable --- Comment #14 from Mason James --- (In reply to Chris Cormack from comment #13) > Pushed to 3.18.x will be in 3.18.4 release Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:21:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:21:54 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- (In reply to Chris Cormack from comment #8) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:30:35 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Possible selection for 3.16.9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:32:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:32:38 +0000 Subject: [Koha-bugs] [Bug 12111] Improving templates regarding order notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Mason James --- (In reply to Galen Charlton from comment #8) > Pushed to master, Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:34:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:34:27 +0000 Subject: [Koha-bugs] [Bug 12860] Tools > Data export : "Don't export fields" option doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12860 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- (In reply to Chris Cormack from comment #8) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:37:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:37:04 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #20 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:39:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:39:00 +0000 Subject: [Koha-bugs] [Bug 13638] Batch patron modification tool missing option to switch language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13638 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- (In reply to Chris Cormack from comment #5) > Pushed to 3.18.x this will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:43:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:43:19 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- (In reply to Chris Cormack from comment #15) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 04:45:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 03:45:18 +0000 Subject: [Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 05:29:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 04:29:01 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #6 from Mason James --- Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 05:30:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 04:30:16 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 05:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 04:32:36 +0000 Subject: [Koha-bugs] [Bug 13298] Holds ratios report ignores ordered items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13298 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 05:35:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 04:35:20 +0000 Subject: [Koha-bugs] [Bug 11954] Clean up currency default files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11954 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #6 from Mason James --- Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 05:42:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 04:42:07 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #16 from Mason James --- Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 05:55:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 04:55:47 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #41 from Mason James --- (In reply to Chris Cormack from comment #39) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 06:02:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 05:02:07 +0000 Subject: [Koha-bugs] [Bug 13636] Search results item status incorrect for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13636 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 06:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 05:04:48 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #10 from Mason James --- Pushed to 3.16.x, will be in 3.16.8r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 06:06:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 05:06:58 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 06:11:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 05:11:26 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 06:13:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 05:13:22 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 3.16.x, will be in 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 07:09:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 06:09:13 +0000 Subject: [Koha-bugs] [Bug 13761] Hide toolbar when printing a list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13761 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Hi Fridolin, I'd like to hide such stuff in print too. But with this approach, the H1 title disppears as well. It contains important information about the list, e.g. catalogue/results.tt: 621 result(s) found for 'kw,wrdl: mus'. member.tt: Results found for patron on street address fields containing ha I think it would be better to use the existing class 'noprint' for elements that are not intended to appear in print. E.g. in catalogue/results.tt line 309 for div selection_ops: class="cartlist noprint" instead of class="cartlist" What do you think about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 09:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 08:15:37 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 --- Comment #7 from Jacek Ablewicz --- (In reply to Paola Rossi from comment #6) > On master 3.19.00.001 head 13645, using FireFox 36 I edited a journal, > Then I wrote n, waiting for an autocompletion drop down list of all the > country codes beginning by 'n'. > But no list appeared. > Then I wrote ny, waiting for the value's autocompletion "nyu", but it didn't > appear. > > So I could not reproduce the bug. I can't reproduce it any longer as well in Firefox 36.. Up-to-date Chrome also does not save any newly entered form data for autocompletion (but it displays drop down list with older values which were entered some months ago). In Firefox 34 and in Pale Moon 25.2.1 form data in plugin windows is still being saved and offered for autocompletion. Looks like there were some chages introduced in some browsers recently, which prevent entered form data from being stored (unless the form is actually submitted with POST or GET, I guess ?). Some of our librarians are (allegedly) using this autocompletion feature in their daily work, so after it ceased to function in recent browsers, I expect there will be probably some complains in 3.. 2.. 1.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 09:36:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 08:36:49 +0000 Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax included values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 --- Comment #9 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #8) > Jonathan, could you sign this patch off on my behalf? Thanks! Added on the remote branch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 09:37:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 08:37:10 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #24 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #23) > Jonathan, could you sign this off for me? Thanks. Added on the remote branch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 09:37:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 08:37:16 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #10 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #8) > Jonathan, could you sign them off on my behalf? Added on the remote branch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 09:53:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 08:53:47 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #45 from Jonathan Druart --- (In reply to Robin Sheat from comment #44) > (In reply to Jonathan Druart from comment #43) > > > I don't have librdf-helper-perl > > > E: Unable to locate package librdf-helper-perl > > > > Ha, it is in wheezy but not in jessie. > > ruh roh batman, that's often a bad sign. Any idea why? I would say: https://wiki.debian.org/Teams/DebianPerlGroup/OpenTasks => https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710983 "librdf-helper-perl: FTBFS with perl 5.18: test failures" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 10:26:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 09:26:18 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Blocks| |11300 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 10:26:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 09:26:18 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 11:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 10:27:58 +0000 Subject: [Koha-bugs] [Bug 13764] New: Installation of git Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13764 Bug ID: 13764 Summary: Installation of git Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: rakesh.s88 at nic.in QA Contact: testopia at bugs.koha-community.org Hi Team, I have installed ubuntu 10.10.When I am installing Koha on ubuntu below are the setps that I am following. 1) installation of Git: I am using Below line of command to install GIT sudo apt-get install git Below are error message : [sudo] password for koha: Reading package lists... Done Building dependency tree Reading state information... Done E: Unable to locate package git Request you to help in Installing GIT and Cloning Koha. Looking for the reply. Thanks in advance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:21:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:21:10 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #25 from Jonathan Druart --- This has been selected by someone for the hackfest in Marseille, but the patches are not testable. Any chance to see this rebased? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:23:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:23:08 +0000 Subject: [Koha-bugs] [Bug 12289] stage_file.pl does not allow control of nomatch options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:23:16 +0000 Subject: [Koha-bugs] [Bug 13569] Shibboleth example config for Packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:23:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:23:35 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:23:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:23:51 +0000 Subject: [Koha-bugs] [Bug 12625] Batch delete component parts when deleting the parent from detailed-view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:26:19 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:26:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:26:30 +0000 Subject: [Koha-bugs] [Bug 13448] runreport.pl html email striping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:26:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:26:40 +0000 Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |matthias.meusburger at biblibr | |e.com CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:27:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:27:33 +0000 Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:27:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:27:39 +0000 Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:27:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:27:50 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:29:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:29:06 +0000 Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:32:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:32:17 +0000 Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:46:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:46:23 +0000 Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name on patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Attachment #35775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:46:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:46:37 +0000 Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name on patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35805|[ALTERNATIVE PATCH] Bug |Bug 13657 - Don't show description|13657 - Don't show extra |extra comma after guarantor |comma after guarantor name |name on patron details |on patron details | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:47:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:47:18 +0000 Subject: [Koha-bugs] [Bug 13657] Don't show extra comma after guarantor name on patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:49:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:49:23 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 13:56:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 12:56:20 +0000 Subject: [Koha-bugs] [Bug 13697] Option to don't add a fee, if the patron changes to a category with enrolment fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- This needs a test plan and tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 14:06:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 13:06:59 +0000 Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 14:11:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 13:11:23 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 14:11:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 13:11:53 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 14:12:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 13:12:50 +0000 Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the opac-user.pl when browsing own holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 14:13:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 13:13:50 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 14:15:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 13:15:00 +0000 Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |benjamin.rokseth at kul.oslo.k |ity.org |ommune.no -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 14:36:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 13:36:23 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 14:38:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 13:38:54 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 --- Comment #5 from Fridolin SOMERS --- In this particular case, I think we should squash the 2 patches. It will be more safe for inclusion into stable branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 14:47:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 13:47:06 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:00:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:00:38 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 --- Comment #6 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #5) > In this particular case, I think we should squash the 2 patches. > It will be more safe for inclusion into stable branches. Why is it more safe? The first patch has already been signed off, and the second patch highlights the sql error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:01:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:01:53 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34656|0 |1 is obsolete| | --- Comment #10 from Paola Rossi --- Created attachment 36174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36174&action=edit [SIGNED OFF] Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8 Pt 1 Thanks, David. I've made some more tests. I've applied tha patch Pt.1 against 3.19.00.012 head 13473. I saw "utf-8" as required. So I attach the "SIGNED OFF" version of the patch Pt.1. NB1. > The UTF-8 charset [....], which causes UTF-8 characters to display incorrectly. Using the mail client Thunderbird, there were no differences in displaying UTF-8 chars of the received mail. In particular, viewing the received mail (resulting by "Opening the message" on the incoming-mail list) all the UTF-8 chars [in subject and body] of the mail were OK, either on master or on applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:07:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:07:25 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Jonathan Druart --- (In reply to Katrin Fischer from comment #20) > I agree with Jonathan - in this case a new subroutine is probably a bit too > specific. So, failing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:09:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:09:51 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:11:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:11:13 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:12:07 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34657|0 |1 is obsolete| | --- Comment #11 from Paola Rossi --- Created attachment 36175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36175&action=edit [SIGNED OFF] Bug 12739 - SendAlerts function does not take care of "html" format Pt. 2 (In reply to David Cook from comment #4) > Created attachment 34657 [details] [review] > Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8 > Pt. 2 > > The emails sent via SendAlerts don't take into account HTML format. > > _TEST PLAN_ > > Before applying: > > 1) Change system preference "AutoEmailOpacUser" to "Send" > 2) Change "ACCTDETAILS" notice to HTML and add HTML to it > 3) Create a new user with your email address > 4) Note how the email displays the HTML tags as plain text > > Apply patch > > 5) Create a new user with your email address > 6) Note how the email displays the email as an HTML email > > For thoroughness: > > 7) Change "ACCTDETAILS" notice to non-HTML > 8) Create a new user with your email address > 9) Note how the email displays the HTML as plain text I've applied the patch Pt.2 against master 3.19.00.012 head 13473. The patch has been trivially rebased. Everything was OK just as required by the test plan. So the patch Pt.2 can be signed off. I pass all the 2 patches Pt.1 and Pt.2 to "Signed OFF" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:16:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:16:59 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Paola Rossi --- The problem has been fixed by Bug 12739, which is even a more wide solution. So I pass the status of this bug to "RESOLVED/WORKSFORME". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:26:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:26:03 +0000 Subject: [Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Needs Signoff |BLOCKED --- Comment #2 from Jonathan Druart --- Blocked by bug 8133 (which is blocked too...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:31:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:31:52 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13762 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:31:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:31:52 +0000 Subject: [Koha-bugs] [Bug 13762] biblionumber field and subfield can be called once in authorities merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:31:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:31:58 +0000 Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:31:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:31:58 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13760 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:35:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:35:11 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart --- This needs an answer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:35:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:35:15 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 --- Comment #8 from Paola Rossi --- (In reply to Jacek Ablewicz from comment #7) >[...] Up-to-date Chrome > also does not save any newly entered form data for autocompletion (but it > displays drop down list with older values which were entered [...]). The same as Firefox 36 ! [And Explorer 11 too.] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:37:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:37:40 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29278|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 36176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36176&action=edit Bug 12446 - Enable an adult to have a guarantor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:37:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:37:57 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Easy conflict, fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:38:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:38:03 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:39:26 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Jonathan Druart --- Answer needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:45:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:45:08 +0000 Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and checkins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:47:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:47:14 +0000 Subject: [Koha-bugs] [Bug 13765] New: Only serial issue can be deleted causing error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13765 Bug ID: 13765 Summary: Only serial issue can be deleted causing error Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com A subscription is set up and a serial issue is created. Click on Serial Collection (to the left). Click on Serial issue checkbox. Click Edit Serial button. Select delete as in the dropdown for the Status. Click Save. Following error appears: Software error: Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at /home/load13/kohaclone/C4/Serials.pm line 2379. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:51:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:51:50 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #28 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #19) > Created attachment 28177 [details] [review] > Bug 11700: Avoid to try to delete the authority twice There is also a delete after merge in misc/migration_tools/merge_authority.pl. (In reply to Jonathan Druart from comment #18) > (In reply to Jonathan Druart from comment #17) > > Created attachment 28176 [details] [review] [review] > > Bug 11700: Avoid to try to delete the authority twice > > Not sure dying is the best thing to do... Same for me, a warn is enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:54:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:54:14 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35854|0 |1 is obsolete| | --- Comment #86 from Jonathan Druart --- Created attachment 36177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36177&action=edit Bug 5010 - Fix OPACBaseURL to include protocol -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:54:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:54:53 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #87 from Jonathan Druart --- Last patch fixed an easy conflict on updatedatabase.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:55:24 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #236 from Jonathan Druart --- fatal: sha1 information is lacking or useless (catalogue/detail.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:58:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:58:37 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35493|0 |1 is obsolete| | Attachment #35494|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 36178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36178&action=edit Bug 9223: Add SupportsAuthorizedValues syspref (followup 1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:58:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:58:47 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #35 from Jonathan Druart --- Created attachment 36179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36179&action=edit Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 15:59:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 14:59:19 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #36 from Jonathan Druart --- Last patches fixed easy conflict on updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:05:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:05:08 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:05:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:05:11 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34668|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Created attachment 36180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36180&action=edit Bug 8007: Discharge - DB changes This patch adds: - syspref useDischarge - the new table discharges - the discharge notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:05:17 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34669|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart --- Created attachment 36181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36181&action=edit Bug 8007: Discharge - DBIx changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:05:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:05:21 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34670|0 |1 is obsolete| | --- Comment #77 from Jonathan Druart --- Created attachment 36182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36182&action=edit Bug 8007: Discharge - Glue This patch adds: - links to the new pages. - syspref description - links on the main page (intranet) - the DISCHARGE type for debarment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:05:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:05:26 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34671|0 |1 is obsolete| | --- Comment #78 from Jonathan Druart --- Created attachment 36183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36183&action=edit Bug 8007: Discharge management This patch is the main patch. It adds new package and files for the new pages (opac-discharge, members/discharge and members/discharges). At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and a discharge if it has been validated by a librarian. Requirements: The perl module PDF::FromHTML New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Verify a new tab appears in the patron page (intranet and opac). - Verify the discharge cannot be generated if the patron has issues. - Verify the patron can request a discharge from it's opac area. - The request appears on the main page (intranet). - Generate the discharge from the intranet. - Try to download it (from the opac and the intranet). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:05:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:05:30 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34672|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart --- Created attachment 36184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36184&action=edit Bug 8007: Discharge - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:05:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:05:34 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34673|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart --- Created attachment 36185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36185&action=edit Bug 8007 : Discharge - Adding Perl dependencie HTML::HTMLDoc is required in order to generate the discharges in PDF format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:05:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:05:40 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34674|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart --- Created attachment 36186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36186&action=edit Bug 8007: Replace HTML::HTMLDoc with PDF::FromHTML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:05:45 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34675|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart --- Created attachment 36187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36187&action=edit Bug 8007: Compatibility with bug 11944 This patch should be applied to work with bug 11944. If you don't have 11944 yet, just don't apply this patch. Note that the line binmode(STDOUT); in pl files is mandatory. It comes from bug 11944 that adds the line binmode( STDOUT, ":utf8" ); in C4::Templates::gettemplate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:06:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:06:06 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #83 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:13:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:13:10 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35835|0 |1 is obsolete| | Attachment #35836|0 |1 is obsolete| | Attachment #35837|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 36188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36188&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:13:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:13:14 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #19 from Jonathan Druart --- Created attachment 36189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36189&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:13:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:13:20 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #20 from Jonathan Druart --- Created attachment 36190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36190&action=edit Bug 13392: QA fixes 1/ Add tests descriptions 2/ Do not use Koha::I18N for suggestion statuses, and add statuses from SUGGEST_STATUS authorised values 3/ Use copyrightdate instead of publicationyear which seems to be unused 4/ Display free text filters if there is no values in corresponding authorised values list 5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:13:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:13:51 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #21 from Jonathan Druart --- Last patches fixed an easy conflict on updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:15:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:15:09 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Jonathan Druart --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:16:58 +0000 Subject: [Koha-bugs] [Bug 13765] Only serial issue can be deleted causing error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13765 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:20:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:20:19 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34667|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:20:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:20:53 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35452|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 36191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36191&action=edit Bug 10937 - Grouped ItemTypes - Patch should apply properly on latest master. Easy conflict on updatedatabase.pl fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:22:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:22:42 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36099|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 36192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36192&action=edit Bug 12461 - Add patron clubs feature Easy conflict on updatedatabase.pl fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:25:14 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #615 from Jonathan Druart --- Applying: Bug 6427 - Update existing Koha perl modules CONFLICT (content): Merge conflict in C4/SIP/ILS/Transaction/FeePayment.pm CONFLICT (content): Merge conflict in C4/Reserves.pm -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:26:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:26:28 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #46 from H?ctor Eduardo Castro Avalos --- Hi Jonathan (In reply to Jonathan Druart from comment #42) > (In reply to Marc V?ron from comment #41) > > Created attachment 36154 [details] [review] [review] > > [Signed-off]Bug 13642 - Adding new features for Dublin Core metadata > > > > When Koha export a bibliographic record to DC, makes it in XML format. This > > XML is not well-formed document and do not follows the DC-XML > > recommendations as should be. > > How can I know if the xml is not well-formed? > I tested on http://validator.w3.org/check and got: > This document was successfully checked as well-formed XML! > Result: Passed, 2 warning(s) This is because you're not validating against the specified XSD schema. Use this one The old Dublin Core (XML) file is in uppercase eg. dc:Date, dc:Creator, and if you compare with the recommendation at section 4.2 cite "Recommendation 4. The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator. Also, this file use an improper xsi:schemaLocation: xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" This XML schema does not exist. And is explained in is Section "4.3 Example - a simple DC record". The file generated with this patch deal with both. The DC-XML file generate a not-valid file if you don't have a proper XSD schema. But if you donwload an OAI-DC this has one. > > > XML::Entities not found in .deb package > > Maybe XML::LibXML can do the trick? XML::LibXML uses the library libxml. This library only uses the five basic entities (<, >, ", &, and &apos), if you want more entities, you need to declare them in a DTD Doctype file. Record.pm in C4/ use sub _entity_encode with Unicode::Normalize (NFC function) in a foreache with a regexp for marcxml files, but got the problem of mix the five basics entities with hexadecimal entities. (eg. > &xFFFF) RDF::Helper use the same five basic entities. DublinCoreTransformer.pm in Koha/ is coded to use the entities or not. If you think that this is a problem I can change the code to eliminate XML::Entities and use the solution of C4::Record sub _entity_encode. > > > New patch for work with librdf-helper-perl (2.0) and librdf-trine-perl > > (1.000). > > RDF::Trine and RDF::Helper not need to be upgraded. Tested in both (upgraded > > and not upgraded) > > I don't have librdf-helper-perl > E: Unable to locate package librdf-helper-perl I didn't know about isn't on Jessie Debian. I can try to fix this only using RDF::Trine this module still on Jessie Please, let me know what you think about my comment, and I will start to doing the changes. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:28:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:28:23 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #29 from Jonathan Druart --- I fixed the conflict on the first patch bug get fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). on applying the second one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:30:54 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34947|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 36193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36193&action=edit Bug 13478: Database revision for table biblio_force_item_holds Easy conflict on updatedatabase.pl fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:31:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:31:48 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Jonathan Druart --- CONFLICT (content): Merge conflict in t/db_dependent/Budgets.t CONFLICT (content): Merge conflict in t/db_dependent/Acquisition.t CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 16:36:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 15:36:38 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35549|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 36194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36194&action=edit Bug 13364 - fix tablesorter and squash Easy conflict on the css file fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 18:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 17:43:39 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #47 from H?ctor Eduardo Castro Avalos --- This another module is a better option to use: HTML::Entities::Nubered at The debian package is libhtml-entities-numbered-perl and is listed in all debian version (oldstable, stable and testing) at So XML::Entities not necessary to use. And we eliminate the cause of this headache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 19:25:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 18:25:34 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #25 from simith.doliveira at inlibro.com --- Created attachment 36195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36195&action=edit Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 19:26:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 18:26:29 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34605|1 |0 is patch| | Attachment #34605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 19:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 18:26:49 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35315|1 |0 is patch| | Attachment #35315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 19:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 18:27:54 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #26 from simith.doliveira at inlibro.com --- Patchs cherry picked to create a new one to be tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 20:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 19:22:12 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 20:22:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 19:22:16 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36195|0 |1 is obsolete| | --- Comment #27 from Nick Clemens --- Created attachment 36196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36196&action=edit Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 20:35:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 19:35:25 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #237 from M. Tompsett --- Okay, I'll try to work on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 20:36:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 19:36:11 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #28 from Nick Clemens --- This seems to work as expected, tested it with next available, item specific, and holds that don't respect holds rules, all seemed fine. Other buttons seemed to work too. Cancel hold checkbox would ideally be moved into/next to the 'Yes Checkout' button as it is otherwise invalid, but that is probab;y beyond scope. I like this idea, but the text seems odd to me ('Don't check and print slip'), it makes sense if you think about it, but I don't see it making intuitive sense to all of our circ staff. That being said, I can't think of a better phrasing so signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 20:40:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 19:40:08 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #29 from Marc V?ron --- Created attachment 36197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36197&action=edit [Signed-off] Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear Signed-off-by: Nick Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 20:40:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 19:40:36 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:16:02 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #6 from Nick Clemens --- All seemed to work as expected except for the test in step 2 (output below): t/db_dependent/Reserves.t .. 1/57 Subroutine C4::Context::userenv redefined at t/db_dependent/Reserves.t line 42. t/db_dependent/Reserves.t .. 29/57 C4::Context->userenv not defined! at /usr/share/koha/lib/C4/Items.pm line 2282 Undefined subroutine &C4::Reserves::CheckBiblioForceItemHolds called at t/db_dependent/Reserves.t line 512. # Looks like you planned 57 tests but ran 53. # Looks like your test exited with 255 just after 53. t/db_dependent/Reserves.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 4/57 subtests Test Summary Report ------------------- t/db_dependent/Reserves.t (Wstat: 65280 Tests: 53 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 57 tests but ran 53. Files=1, Tests=53, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.72 cusr 0.04 csys = 0.79 CPU) Result: FAIL Could be something I am missing but passed on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:20:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:20:05 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #28 from Marc V?ron --- I followed the test plan (comment #26) Selected callnumber.pl in step #6 -> did not work Selected cn_browser.pl in step #6 -> worked, shows Call Numbers browser Questions & remarks: 1) Is callnumber.pl obsolete? 2) Breadcrumb navigation and language selection appear in "Call number browser": I think this is not necessary in a popup window. 3) Capitalization of title? (Should be "Call numbers browser" instead of "Call Numbers browser") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:20:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:20:34 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32384|0 |1 is obsolete| | --- Comment #238 from M. Tompsett --- Created attachment 36198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36198&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:20:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:20:45 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32385|0 |1 is obsolete| | --- Comment #239 from M. Tompsett --- Created attachment 36199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36199&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:21:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:21:12 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32386|0 |1 is obsolete| | --- Comment #240 from M. Tompsett --- Created attachment 36200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36200&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:21:26 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32387|0 |1 is obsolete| | --- Comment #241 from M. Tompsett --- Created attachment 36201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36201&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:25:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:25:20 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36198|0 |1 is obsolete| | --- Comment #242 from M. Tompsett --- Created attachment 36202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36202&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:25:30 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36199|0 |1 is obsolete| | --- Comment #243 from M. Tompsett --- Created attachment 36203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36203&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:25:39 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36200|0 |1 is obsolete| | --- Comment #244 from M. Tompsett --- Created attachment 36204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36204&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:25:47 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36201|0 |1 is obsolete| | --- Comment #245 from M. Tompsett --- Created attachment 36205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36205&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:25:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:25:57 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32388|0 |1 is obsolete| | --- Comment #246 from M. Tompsett --- Created attachment 36206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36206&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:26:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:26:05 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32389|0 |1 is obsolete| | --- Comment #247 from M. Tompsett --- Created attachment 36207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36207&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:26:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:26:14 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32390|0 |1 is obsolete| | --- Comment #248 from M. Tompsett --- Created attachment 36208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36208&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:26:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:26:22 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32391|0 |1 is obsolete| | --- Comment #249 from M. Tompsett --- Created attachment 36209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36209&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:26:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:26:31 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32392|0 |1 is obsolete| | --- Comment #250 from M. Tompsett --- Created attachment 36210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36210&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, particularly the OPAC system preference: OpacProtocol. This is used to generate the http or https for the OPACBaseURL. This now checks for proper configuration of the system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:26:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:26:39 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32393|0 |1 is obsolete| | --- Comment #251 from M. Tompsett --- Created attachment 36211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36211&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:30:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:30:32 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:39:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:39:16 +0000 Subject: [Koha-bugs] [Bug 13334] Add a warning during the return of a document that was reserved to a course. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13334 --- Comment #4 from simith.doliveira at inlibro.com --- Created attachment 36212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36212&action=edit This patch adds the following warning during the return of a document that was reserved to a course: "Please return 'title' to the 'course name' class reserve." Testing: 1) Define a document as a course reserve see manual.koha-community.org/3.14/en/coursereserves.html 2) Checkout and checkin this document. Validade the warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:39:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:39:53 +0000 Subject: [Koha-bugs] [Bug 13334] Add a warning during the return of a document that was reserved to a course. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13334 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33907|1 |0 is patch| | Attachment #33907|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 21:41:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 20:41:34 +0000 Subject: [Koha-bugs] [Bug 13334] Add a warning during the return of a document that was reserved to a course. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13334 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from simith.doliveira at inlibro.com --- The warning was changed to "[ title ] is part of the [ course ] course reserve." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:05:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:05:49 +0000 Subject: [Koha-bugs] [Bug 5071] Make the 'koha' package set things up so that zebra etc. just work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5071 Xai changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xai.castro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:28:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:28:08 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #48 from Robin Sheat --- (In reply to Jonathan Druart from comment #45) > I would say: > https://wiki.debian.org/Teams/DebianPerlGroup/OpenTasks > => > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710983 > > "librdf-helper-perl: FTBFS with perl 5.18: test failures" Yeah, that means a) it's probably not going to get back in any time soon, and b) I won't be able to make packages for it anyway as it's unbuildable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:46:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:46:40 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36202|0 |1 is obsolete| | --- Comment #252 from M. Tompsett --- Created attachment 36213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36213&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:46:48 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36203|0 |1 is obsolete| | --- Comment #253 from M. Tompsett --- Created attachment 36214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36214&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:46:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:46:57 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36204|0 |1 is obsolete| | --- Comment #254 from M. Tompsett --- Created attachment 36215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36215&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:47:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:47:05 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36205|0 |1 is obsolete| | --- Comment #255 from M. Tompsett --- Created attachment 36216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36216&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:47:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:47:13 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36206|0 |1 is obsolete| | --- Comment #256 from M. Tompsett --- Created attachment 36217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36217&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:47:21 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36207|0 |1 is obsolete| | --- Comment #257 from M. Tompsett --- Created attachment 36218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36218&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:47:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:47:30 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36208|0 |1 is obsolete| | --- Comment #258 from M. Tompsett --- Created attachment 36219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36219&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:47:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:47:37 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36209|0 |1 is obsolete| | --- Comment #259 from M. Tompsett --- Created attachment 36220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36220&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:47:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:47:45 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36210|0 |1 is obsolete| | --- Comment #260 from M. Tompsett --- Created attachment 36221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36221&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, particularly the OPAC system preference: OpacProtocol. This is used to generate the http or https for the OPACBaseURL. This now checks for proper configuration of the system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 26 23:47:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Feb 2015 22:47:53 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36211|0 |1 is obsolete| | --- Comment #261 from M. Tompsett --- Created attachment 36222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36222&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:04:44 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36213|0 |1 is obsolete| | --- Comment #262 from M. Tompsett --- Created attachment 36223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36223&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:04:53 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36214|0 |1 is obsolete| | --- Comment #263 from M. Tompsett --- Created attachment 36224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36224&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:05:01 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36215|0 |1 is obsolete| | --- Comment #264 from M. Tompsett --- Created attachment 36225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36225&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:05:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:05:12 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36216|0 |1 is obsolete| | --- Comment #265 from M. Tompsett --- Created attachment 36226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36226&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:05:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:05:20 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36217|0 |1 is obsolete| | --- Comment #266 from M. Tompsett --- Created attachment 36227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36227&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:05:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:05:28 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36218|0 |1 is obsolete| | --- Comment #267 from M. Tompsett --- Created attachment 36228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36228&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:05:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:05:37 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36219|0 |1 is obsolete| | --- Comment #268 from M. Tompsett --- Created attachment 36229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36229&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:05:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:05:47 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36220|0 |1 is obsolete| | --- Comment #269 from M. Tompsett --- Created attachment 36230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36230&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:05:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:05:58 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36221|0 |1 is obsolete| | --- Comment #270 from M. Tompsett --- Created attachment 36231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36231&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, in that the protocol is assumed in the OpacBaseURL system preference. It also adds improved error handling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:06:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:06:08 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36222|0 |1 is obsolete| | --- Comment #271 from M. Tompsett --- Created attachment 36232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36232&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:07:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:07:44 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:08:20 +0000 Subject: [Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 01:57:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 00:57:13 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC|robin at catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 02:09:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 01:09:50 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #272 from M. Tompsett --- I have moved this to assigned, like I did in comment #208, because I have yet to retest the rebase, not to mention, I had issues rebasing, so some fixing jumped from one patch into another. I wish to retest as a result. The test plan is in comment #175, with later comments perhaps containing some other things to look at. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 02:56:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 01:56:54 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 09:50:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 08:50:52 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 --- Comment #7 from M. de Rooy --- (In reply to Nick Clemens from comment #6) Thanks for testing ! > t/db_dependent/Reserves.t .. 1/57 Subroutine C4::Context::userenv redefined > at t/db_dependent/Reserves.t line 42. This warning is as expected (just as it is now). > t/db_dependent/Reserves.t .. 29/57 C4::Context->userenv not defined! at > /usr/share/koha/lib/C4/Items.pm line 2282 I have this result: ok 30 - patron not notified a second time (bug 11445) C4::Context->userenv not defined! at /usr/share/koha/testclone/C4/Items.pm line 2282. This warning is also to be expected (we could call this a separate bug in master). Test number 31 calls DelItemCheck($dbh, $bibnum, $itemnumber) and this routine goes to userenv on line 2287 in Items.pm. In conclusion: Not related to this report. > Undefined subroutine &C4::Reserves::CheckBiblioForceItemHolds called at > t/db_dependent/Reserves.t line 512. This is actually very strange. (I do not see this warning; for me the test passes.) Note that this routine CheckBiblioForceItemHolds is created by the first patch. Is your perl5lib path pointing at the right koha clone, or something like that ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 10:11:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 09:11:46 +0000 Subject: [Koha-bugs] [Bug 12398] CAS authentication not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Bug 12398 depends on bug 11219, which changed state. Bug 11219 Summary: CAS authentication fails with URL parameters http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 10:11:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 09:11:45 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 10:17:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 09:17:27 +0000 Subject: [Koha-bugs] [Bug 13697] Option to don't add a fee, if the patron changes to a category with enrolment fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Christophe Croullebois --- Test plan : 1/ create 2 categories (A & B). B with enrolment fee 2/ create a patron in category A 3/ change the patron category from A to B 4/ check that the patron has an enrolment fee to pay Apply the patch 1/ create a new patron in category A 2/ change the patron category from A to B. 3/ check that the patron has an enrolment fee to pay 4/ change the system preference => UPDATE `systempreferences` SET `value` = '1' WHERE `systempreferences`.`variable` ='FeeOnChangePatronCategory'; 5/ create a new patron in category A 6/ change the patron category from A to B 7/ check that the patron has no enrolment fee to pay thx -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 11:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 10:28:31 +0000 Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #23 from Martin Renvoize --- Is this one dead in the water... wondering if it's going to move anywhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 11:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 10:43:14 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #616 from Martin Renvoize --- I don't see how this got to a signed off state, a large part of the testing spreadsheet recording test results shows half of it is untested. I know when I tested it, I found all sorts of issues with display on the staff client. I also found issues with the code when delving into it to try and fix said bugs, I'd love to see a good comprehensive re-write of accounts, but this code shows that it was written some time ago and I don't believe it actually improved matters. PTFS Europe spent a fair chunk of time attempting to get this in shape for passing through community so we could base our Cash Management work upon it, but we didn't even complete testing before we realised how difficult it would be to extend/enhance it further. I also found that too much changed in this one bug.. The db backend and th display both change dramatically, which means doing a side by side comparison to check that the db update it actually catching everything is near impossible. Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 11:45:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 10:45:24 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #617 from Martin Renvoize --- Further to the above, when I attempted to lookup the original RFC for this, it does not remotely resemble the actually work, further confusing testing. Please don't see this as completely negative.. I just feel things have moved on allot since this patch was written.. and that the way in which it has been posted as one massive bug is unmanageable for both testers and qa team. I have a alternative schema I'd love to post as a counter patch.. but that all depends upon having a moment to get to it. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 11:45:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 10:45:33 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #618 from Martin Renvoize --- Further to the above, when I attempted to lookup the original RFC for this, it does not remotely resemble the actually work, further confusing testing. Please don't see this as completely negative.. I just feel things have moved on allot since this patch was written.. and that the way in which it has been posted as one massive bug is unmanageable for both testers and qa team. I have a alternative schema I'd love to post as a counter patch.. but that all depends upon having a moment to get to it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 12:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 11:30:03 +0000 Subject: [Koha-bugs] [Bug 13766] New: biblioitems.ean field is too short Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Bug ID: 13766 Summary: biblioitems.ean field is too short Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org biblioitems.ean field is too short. It's a VARCHAR(13) type. EAN can be longer, especially if it's repeated in the biblio record. When biblio records are imported, and 073 (Unimarc) or 024 (MARC21) field is repeated, their content can't be stored in biblioitems.ean field : it stopped the biblio record import. This field should be aligned to biblioitems.isbn type: MEDIUMTEXT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 12:34:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 11:34:06 +0000 Subject: [Koha-bugs] [Bug 13766] biblioitems.ean field is too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 --- Comment #1 from Fr?d?ric Demians --- Created attachment 36233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36233&action=edit Bug 13766 Set biblioitems.ean type to MEDIUMTEXT biblioitems.ean field is too short. It's a VARCHAR(13) type. EAN can be longer, especially if it's repeated in the biblio record. When biblio records are imported, and 073 (Unimarc) or 024 (MARC21) field is repeated, their content can't be stored in biblioitems.ean field: it stops the biblio record import. This field should be aligned to biblioitems.isbn type: MEDIUMTEXT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 12:34:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 11:34:31 +0000 Subject: [Koha-bugs] [Bug 13766] biblioitems.ean field is too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 12:34:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 11:34:46 +0000 Subject: [Koha-bugs] [Bug 13766] biblioitems.ean field is too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13766 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 12:39:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 11:39:29 +0000 Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in koha-indexer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #4 from Tom?s Cohen Arazi --- (In reply to Mirko Tietgen from comment #3) > Not in the scope of this patch: I had to manually start koha-indexer. That > is neither mentioned here nor on the Wiki, so I wonder if it is supposed to > run automatically? Mirko, have you set /etc/default/koha-common ? And restarted the koha-common service? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 12:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 11:49:34 +0000 Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in koha-indexer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #5 from Mirko Tietgen --- (In reply to Tom?s Cohen Arazi from comment #4) > (In reply to Mirko Tietgen from comment #3) > > Not in the scope of this patch: I had to manually start koha-indexer. That > > is neither mentioned here nor on the Wiki, so I wonder if it is supposed to > > run automatically? > > Mirko, have you set /etc/default/koha-common ? And restarted the koha-common > service? Yes, I did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 12:56:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 11:56:08 +0000 Subject: [Koha-bugs] [Bug 13697] Option to don't add a fee, if the patron changes to a category with enrolment fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35831|0 |1 is obsolete| | --- Comment #4 from Christophe Croullebois --- Created attachment 36234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36234&action=edit Syspref to not add a fee when a patron changes to a category with enrolment fee Test plan : 1/ create 2 categories (A & B). B with enrolment fee 2/ create a patron in category A 3/ change the patron category from A to B 4/ check that the patron has an enrolment fee to pay Apply the patch 1/ create a new patron in category A 2/ change the patron category from A to B. 3/ check that the patron has an enrolment fee to pay 4/ change the system preference 'FeeOnChangePatronCategory' to 'Don't'; 5/ create a new patron in category A 6/ change the patron category from A to B 7/ check that the patron has no enrolment fee to pay thx -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 12:58:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 11:58:05 +0000 Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Option to don't add a fee, |Syspref to not add a fee |if the patron changes to a |when a patron changes to a |category with enrolment fee |category with enrolment fee -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 14:11:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 13:11:52 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36194|0 |1 is obsolete| | --- Comment #29 from simith.doliveira at inlibro.com --- Created attachment 36235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36235&action=edit Bug 13364 - fix tablesorter and squash When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home ? Administration ? MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (?) beside Full call number input 8) Click in ? Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 14:19:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 13:19:02 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #30 from simith.doliveira at inlibro.com --- Corrections : 1) Breadcrumb navigation and language selection removed; 2) Title changed ("Call numbers browser" instead of "Call Numbers browser"); 3) Test texte correction : 6) cn_browser.pl instead of callnumber.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 15:20:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 14:20:51 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 15:34:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 14:34:04 +0000 Subject: [Koha-bugs] [Bug 13767] New: Readonly::XS (1:02) is not installed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Bug ID: 13767 Summary: Readonly::XS (1:02) is not installed Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: isabelaterra at cp2.g12.br QA Contact: testopia at bugs.koha-community.org I'm really looking for some help here, please, my brain (whatever is left!) Is swimming in Perl code. All perl modules are present (except tells me que Readonly :: XS (1:02) is not installed, but I have 1.05), permissions Have Been verified, ps -u koha shows the daemon and zebrasrv running, mysqlcheck is clean, etc. Searches return empty and analytical reports report that is registered in the database. I'm using Debian 7 u3 and Koha 3.18. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 16:28:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 15:28:13 +0000 Subject: [Koha-bugs] [Bug 13753] INDEXER_DAEMON default is incorrect in koha-indexer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13753 --- Comment #6 from Mirko Tietgen --- (In reply to Mirko Tietgen from comment #5) > (In reply to Tom?s Cohen Arazi from comment #4) > > (In reply to Mirko Tietgen from comment #3) > > > Not in the scope of this patch: I had to manually start koha-indexer. That > > > is neither mentioned here nor on the Wiki, so I wonder if it is supposed to > > > run automatically? > > > > Mirko, have you set /etc/default/koha-common ? And restarted the koha-common > > service? > > Yes, I did. Sorry, I did not read carefully. I set /etc/koha/koha-common.conf. I did not set /etc/default/koha-common as it was not mentioned in the wiki. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 16:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 15:42:27 +0000 Subject: [Koha-bugs] [Bug 13768] New: in quotes.tt line 14 the use of \" break the translation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 Bug ID: 13768 Summary: in quotes.tt line 14 the use of \" break the translation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: christophe.croullebois at biblibre.com QA Contact: testopia at bugs.koha-community.org In quotes.tt line 14 we have : var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button to add a quote."); The use of \" inside double quotes breaks the js in the translated pages. i.e : in french pages in the table we have "Chargement des donn?es..." and can't go ahead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 18:50:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 17:50:35 +0000 Subject: [Koha-bugs] [Bug 13404] More System information about GRS1 vs DOM settings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #17 from Mirko Tietgen --- (In reply to M. de Rooy from comment #9) > I would recommend to remove the last sentence. There is something wrong > here. Let them find out and correct. If we already add 'safe to ignore', > does this warning still have any function? > > Please provide some feedback first before I finish QA. Now I remember why I added that sentence? if you have an older package installation and manually switched to DOM, the check will tell you that there is a problem when it isn't. It looks for zebra-biblios-dom.cfg and gives a warning if that file is not present. But if you followed the wiki to switch to DOM indexing manually, your file will be called zebra-biblios.cfg and you will get a warning when there is no problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 19:07:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 18:07:52 +0000 Subject: [Koha-bugs] [Bug 13769] New: Barcode showing blank in catalog/null in database Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13769 Bug ID: 13769 Summary: Barcode showing blank in catalog/null in database Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: jcintron at hccc.edu QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 36236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36236&action=edit Barcodes showing in item edit. But No barcode in catalog I recently added a record for a book into my catalog. I then added items, 2 copies, of the book. Added the information I had at hand. The issues I'm running into is when I search the title in the catalog, the record comes up and shows both items attached to that records. When I go to edit the items for that record, the barcodes attached to the items show fine. When I view the items when searching the record, the barcode column shows blank and also shows null in the database. If I manually add the barcodes for the items through the database, they then show in the staff client, and those items can then be checked out to patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 22:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 21:06:28 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 22:06:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 21:06:32 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34948|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 36237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36237&action=edit Bug 13478: Force item holds only for specific biblios This patch adds the option to selectively force item holds for specific biblionumbers. These numbers are saved in a separate table. The patch adds routine C4::Reserves::CheckBiblioForceItemHolds. It is tested in Reserves.t. The preference OPACItemHolds gets a new choice: selectiveforce. The description of the pref is adjusted. Please note that this option is specifically targeted for the OPAC. Staff users still have both possibilities. A follow-up patch adds the possibility for staff users to add or remove a biblio from the list of books with forced item holds. TEST PLAN: [ 1] Run the unit test t/db_dependent/Reserves.t. [ 2] Set OPACItemHolds to force. [ 3] Add a hold in the OPAC; verify that you cannot place a next/av hold. [ 4] Set OPACItemHolds to Allow. [ 5] Add a hold in the OPAC; verify that you can place both hold types. [ 6] Set OPACItemHolds to Do not allow. [ 7] Add a hold in the OPAC; verify that you can only place next/av holds. [ 8] Add two biblio numbers into table biblio_force_item_holds. [ 9] Set OPACItemHolds to Selectively force. [10] Add a hold on three biblionumbers at once (including these two). Verify that you have two hold types for the single biblio and that you have only item holds for the two other biblios. Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 22:06:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 21:06:39 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36193|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 36238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36238&action=edit Bug 13478: Database revision for table biblio_force_item_holds TEST PLAN: [1] Run the database revision. Check if the new table is present. Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 22:07:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 21:07:59 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 --- Comment #10 from Nick Clemens --- Ah, fixed it, but then did a new koha-shell and didn't fix it again, d'oh > Is your perl5lib path pointing at the right koha clone, or > something like that ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 22:46:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 21:46:38 +0000 Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 22:46:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 21:46:44 +0000 Subject: [Koha-bugs] [Bug 11900] OPAC cart can confuse patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11900 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36002|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 36239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36239&action=edit Bug 11900 - OPAC cart can confuse patrons This patch adds a title tag to the "Cart" link on Opac main page (and to the "Lists" link as well). Wording should be verified by a native speaker :-) To test: Apply patch Go to OPAC main page, verify that a tooltip appears on the "Cart" and "Lists" links at the top of the page. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 23:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 22:46:00 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 23:46:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 22:46:04 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36191|0 |1 is obsolete| | --- Comment #52 from Nick Clemens --- Created attachment 36240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36240&action=edit Bug 10937 - Grouped ItemTypes - Patch should apply properly on latest master. This allows to group certain item types in a category, to be displayed (and searched) as such in OPAC's advanced search. For example, you can group Reserve 2h and Reserve 12h into a Reserve category. The 2 and 12h types won't appear anymore. This also allows to simply prevent an item type from displaying as a search option. TEST PLAN ------------------ 0) Back up database, so you can reset and retest easily. ;) 1) Apply the patch 2) Run Koha QA tool. 3) prove -v t/db_dependent/Koha.t -- all tests should pass. 4) run ./installer/data/mysql/updatedatabase.pl to add the two columns to itemtypes -- Does a meaningful message get printed? Are the columns added? "DESCRIBE itemtypes;" should list hideinopac and searchcategory. 5) You need to add a category to group your item types: a) In Intranet/Koha Admin/Authorized values, select DOCTYPECAT in the 'Show category:' dropdown i) If you do not have a DOCTYPECAT category, create one. b) Click button "New authorized value for DOCTYPECAT" c) Enter Authorized value: HARDWARE Description : Hardware Description (OPAC): Hardware 6) Group your items under that new category a) In Intranet/Koha Admin/Item types, choose (at least) two item types and for each: - Click action/Edit on the right column - Third row (below Description) is the Search category list box, select Hardware - click Save changes at the bottom 7) Select at least one item to be hidden in the OPAC search a) In Intranet/Koha Admin/Item types (again), choose a different item type: - Click action/Edit - Click the checkbox "Hide in OPAC" below the list of icons. 8) Go test your modifications a) Go to OPAC/Adv search. b) Validate that all items modified above (hidden or grouped) do not appear in Item type list c) Validate that new item type Hardware does appear instead. d) Select item Hardware, start Search. ) Validate returned items are the of the two types that were grouped into the Hardware category in step 4. Sponsored-by: Vanier college Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 27 23:52:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 22:52:01 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #53 from Nick Clemens --- I like this idea, but have a a small readability issue with the Hide In OPAC description on the Modify Item type page. It says: (if checked, items of this type will be hidden as filters in OPAC's advanced search) I think more on the lines of: If checked, the option to filter by items of this type will be hidden in OPAC advanced search (item of this type will not explicitly be hidden by this preference) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 00:16:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 23:16:17 +0000 Subject: [Koha-bugs] [Bug 13770] New: There should be a command in Debian packages to switch to DOM indexing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13770 Bug ID: 13770 Summary: There should be a command in Debian packages to switch to DOM indexing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz We should offer an easy way to upgrade from GRS1 to DOM indexing. People could use it manually now and it should be part of the upgrade process to 3.20 or legacy (-ish package) installations will break. zebra-biblios-dom.cfg creation could be done with something like sed -e "s/__KOHASITE__/instancename/g" \ -e "s/__ZEBRA_MARC_FORMAT__/marcflavour/g" \ -e "s/__ZEBRA_LANGUAGE__/en/g" \ "/etc/koha/zebra-biblios-dom-site.cfg.in" > "/etc/koha/sites/instancename/zebra-biblios-dom.cfg" maybe for all instances found by koha-list. koha-conf.xml has to be checked for zebra_*_index_mode and use_zebra_facets and they need to be changed or added, the xi: stuff has to be added to the biblioserver section. Zebra restarted and rebuilt afterwards. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 00:20:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 23:20:31 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28472|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 36241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36241&action=edit Bug 7939 - Separate po files for different MARC dialects This patch implements separate PO files for different MARC dialects. It depends on correct filenames, i.e. it will build PO files using files with/without "unimarc|normarc|marc21" on their names. Changes: A) LangInstaller.pm Added definitions to create or update xx-YY-{MARCFLAVOR}.po, minor change to create and install procedure, and modification of install procedure to handle multiple target dirs. Updated documentation. B) Standarization of filenames STAFF po file is now xx-YY-staff-prog.po MARC dialects po files are xx-YY-marc-{MARCFLAVOUR}.po To test: 1) Update po files for your preferred language, ej. nn-NO cd misc/translator perl translate update nn-NO 2) Do some copying/renaming cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-UNIMARC.po cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-NORMARC.po cp po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-marc-MARC21.po mv po/nn-NO-i-staff-t-prog-v-3006000.po po/nn-NO-staff-prog.po (most MARC dialect strings are on staff, so we use that as basis) 3) Apply the patch 4) Update again to fix translation files, verbose perl translate update nn-NO -v 5) Install language, verbose, verify translations perl translate install nn-NO -v 6) Create translation files rm po/nn-NO* perl translate create nn-NO we must have this list: po/nn-NO-marc-MARC21.po po/nn-NO-marc-NORMARC.po po/nn-NO-marc-UNIMARC.po po/nn-NO-opac-bootstrap.po po/nn-NO-pref.po po/nn-NO-staff-help.po po/nn-NO-staff-prog.po Additional tests: 7) Number of msgids 7.a) Before patch and after upgrade, extract and count msgids for i in $(ls po/nn-NO-*po); \ do msginit -i $i -o nn-old.po --no-translator --no-wrap --locale=nn_NO; \ egrep ^msgid nn-old.po >> old; \ done sort old | uniq | tee s-old | wc -l > n-old s-old: have all msgids n-old: number of msgids 7.b) After patch and after creation of new files Repeat procedure, diferent files (s-new, n-new) 7.c) Compare (diff s-old snew), they are the same (save for a strange UNIMARC char in my case, but it's present on corresponding PO file) 8) Installed dirs/files 8.a) List of EN dirs/files cd koha-tmpl find | egrep "/en/" > en 8.b) List of nn-NO dirs/files. After patch and language install cd koha-tmpl find | egrep "/nn-NO/" | sed 's|/nn-NO/|/en/|' > nn 8.c) Compare (diff en nn), they are the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 00:20:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Feb 2015 23:20:59 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 01:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 00:04:44 +0000 Subject: [Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #3 from Mirko Tietgen --- (In reply to Katrin Fischer from comment #2) > 8) Also test following hidden combination works correctly: > OPAC: checked > All other options: unchecked Hiding in the staff client does not work for me, I can still see the status. The problem given in the bug description is solved though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 04:10:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 03:10:10 +0000 Subject: [Koha-bugs] [Bug 13334] Add a warning during the return of a document that was reserved to a course. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13334 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 04:14:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 03:14:05 +0000 Subject: [Koha-bugs] [Bug 11930] Add a dropdown menu to search instructor on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11930 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 04:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 03:15:11 +0000 Subject: [Koha-bugs] [Bug 12940] enter start and end date for course In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12940 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 04:15:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 03:15:24 +0000 Subject: [Koha-bugs] [Bug 12941] batch enable/disable courses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12941 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 04:46:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 03:46:59 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu --- Comment #1 from Tom Misilo --- Created attachment 36242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36242&action=edit Proposed Patch I don't have a system to test this on yet, however I believe this should do what you want. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 09:42:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 08:42:24 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|sarah at secadvertising.com |koha-bugs at lists.koha-commun | |ity.org CC| |mirko at abunchofthings.net --- Comment #5 from Mirko Tietgen --- Switching this to unassigned/ new because there has never been any work made public in over three years. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 11:51:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 10:51:48 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 15:57:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 14:57:36 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 18:17:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 17:17:05 +0000 Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 23:23:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 22:23:28 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #10 from Katrin Fischer --- There is a conflict in ILS.pm - please rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 23:38:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 22:38:20 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 28 23:47:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Feb 2015 22:47:59 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #27 from Katrin Fischer --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13014: Notify budget owner on new suggestion - UT fatal: sha1 information is lacking or useless (C4/Suggestions.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. :( -- You are receiving this mail because: You are watching all bug changes.