[Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

--- Comment #20 from Mason James <mtj at kohaaloha.com> ---
(In reply to M. Tompsett from comment #13)
> Comment on attachment 21221 [details] [review]
> Bug 10554 - Add more options to 'AllowSelfCheckReturns' syspref
> 
> Review of attachment 21221 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: installer/data/mysql/sysprefs.sql
> @@ +419,5 @@
> >  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
> >  ('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo')
> >  ;
> > +
> > +installer/data/mysql/sysprefs.sql
> 
> I think this is a mistake.

yes, the addition of those two lines is a mistake

> 
> ::: koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt
> @@ +140,4 @@
> >     [% END %]
> >     Please see a member of the library staff.
> >  </p>
> > +[% IF  (AllowSelfCheckReturns == 'nonblocked' and returnitem ) or AllowSelfCheckReturns  == 'all' %]
> 
> Why not leave the
> [% IF ( returnitem ) %]
> line, and then just change the next line to:
> [% IF AllowSelfCheckReturns == 'nonblocked' or AllowSelfCheckReturns ==
> 'all' %]
> Because returnitem should be set correctly, should it not? And if not,
> where's the logic for it that needs fixing?

if your suggestion tests OK, then i am happy

it makes no difference to me which syntax is used :)

> ::: opac/sco/sco-main.pl
> @@ +83,4 @@
> >  $template->param(SelfCheckTimeout => $selfchecktimeout);
> >  
> >  # Checks policy laid out by AllowSelfCheckReturns, defaults to 'on' if preference is undefined
> > +my $allowselfcheckreturns = 'nonblocked';
> 
> Actually, I was thinking these 4 lines could be optimized to:
> my $allowselfcheckreturns = C4::Context->preference('AllowSelfCheckReturns')
> // 'nonblocked';

yes, looks good…

> 
> @@ +152,4 @@
> >              "circ_error_$issue_error" => 1,
> >              title                     => $item->{title},
> >              hide_main                 => 1,
> > +            barcode                   => $barcode,
> 
> Is this a secondary bug that you discovered while fixing this?

yep, its a small secondary bug

-- 
You are receiving this mail because:
You are watching all bug changes.