[Koha-bugs] [Bug 13645] DBIx connection needs to be cached

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
This needs discussion, I really would like to see more people involved here.

I submitted a second patch, here the benchmark result for
  Koha::Acquisition::Bookseller->search;

Patch 1 is "Cache the DBIx connection"
Patch 2 is "Use DBIx::Connector"

With 14 suppliers in DB

On master
Perl benchmark_bookseller.pl  1.34s user 0.05s system 96% cpu 1.444 total
Perl benchmark_bookseller.pl  1.38s user 0.03s system 97% cpu 1.448 total
Perl benchmark_bookseller.pl  1.37s user 0.04s system 97% cpu 1.445 total
Perl benchmark_bookseller.pl  1.38s user 0.02s system 97% cpu 1.437 total
Perl benchmark_bookseller.pl  1.35s user 0.03s system 97% cpu 1.418 total

On master + patch 1
Perl benchmark_bookseller.pl  0.92s user 0.04s system 96% cpu 0.999 total
Perl benchmark_bookseller.pl  0.94s user 0.05s system 96% cpu 1.031 total
Perl benchmark_bookseller.pl  0.90s user 0.06s system 96% cpu 0.988 total
Perl benchmark_bookseller.pl  0.94s user 0.04s system 96% cpu 1.021 total
Perl benchmark_bookseller.pl  0.93s user 0.04s system 96% cpu 1.003 total

On master + patch 1 & patch 2
Perl benchmark_bookseller.pl  0.93s user 0.03s system 95% cpu 1.002 total
Perl benchmark_bookseller.pl  0.96s user 0.03s system 95% cpu 1.031 total
Perl benchmark_bookseller.pl  0.97s user 0.03s system 95% cpu 1.046 total
Perl benchmark_bookseller.pl  0.99s user 0.02s system 96% cpu 1.048 total
Perl benchmark_bookseller.pl  0.93s user 0.04s system 95% cpu 1.013 total

On master + patch 2
Perl benchmark_bookseller.pl  1.40s user 0.02s system 97% cpu 1.464 total
Perl benchmark_bookseller.pl  1.36s user 0.04s system 96% cpu 1.436 total
Perl benchmark_bookseller.pl  1.36s user 0.04s system 97% cpu 1.428 total
Perl benchmark_bookseller.pl  1.39s user 0.01s system 97% cpu 1.439 total
Perl benchmark_bookseller.pl  1.37s user 0.05s system 97% cpu 1.454 total

With 1014 suppliers in DB
On master
perl benchmark_bookseller.pl  35.66s user 0.14s system 99% cpu 35.977 total     
perl benchmark_bookseller.pl  35.36s user 0.14s system 99% cpu 35.591 total

On master + patch 1
perl benchmark_bookseller.pl  2.50s user 0.07s system 95% cpu 2.675 total
perl benchmark_bookseller.pl  2.56s user 0.07s system 95% cpu 2.739 total
perl benchmark_bookseller.pl  2.66s user 0.05s system 95% cpu 2.849 total
perl benchmark_bookseller.pl  2.49s user 0.06s system 96% cpu 2.655 total
perl benchmark_bookseller.pl  2.42s user 0.08s system 96% cpu 2.581 total

On master + patch 1 & patch 2
perl benchmark_bookseller.pl  2.45s user 0.05s system 96% cpu 2.596 total
perl benchmark_bookseller.pl  2.49s user 0.04s system 96% cpu 2.629 total
perl benchmark_bookseller.pl  2.49s user 0.04s system 96% cpu 2.629 total
perl benchmark_bookseller.pl  2.48s user 0.09s system 96% cpu 2.678 total
perl benchmark_bookseller.pl  2.40s user 0.08s system 96% cpu 2.562 total

On master + patch 2
perl benchmark_bookseller.pl  34.75s user 0.11s system 99% cpu 34.927 total
perl benchmark_bookseller.pl  34.22s user 0.12s system 99% cpu 34.397 total
perl benchmark_bookseller.pl  35.12s user 0.15s system 99% cpu 35.343 total

At first glance, patch 2 does not seem to be efficient, but I am not confident
with patch 1, I got bad results with other tests.

-- 
You are receiving this mail because:
You are watching all bug changes.