[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi, good to see new strings to translate :)

But, can I suggest a little rewriting?

First) 
Can you put a <span>...</span> surrounding the text?
In that way each text is taken by translation script individually, if not we
finish with a big and ugly string, difficult to translate or update

So I suggest changing this

[%- CASE 'superlibrarian' -%]
Access to all librarian functions
[%- CASE 'circulate' -%]
Check out and check in items
[%- CASE 'catalogue' -%]
<b>Required for staff login.</b> Staff access, allows viewing of catalogue in
staff client.

to this

[%- CASE 'superlibrarian' -%]
<span>Access to all librarian functions</span>
[%- CASE 'circulate' -%]
<span>Check out and check in items</span>
[%- CASE 'catalogue' -%]
<span><b>Required for staff login.</b> Staff access, allows viewing of
catalogue in staff client.</span>

Second) 
To improve readability, can you put the text next to the options?
And also add space to align things?

For example, change this

[%- CASE 'superlibrarian' -%]
<span>Access to all librarian functions</span>
[%- CASE 'circulate' -%]
<span>Check out and check in items</span>
[%- CASE 'catalogue' -%]
<span><b>Required for staff login.</b> Staff access, allows viewing of
catalogue in staff client.</span>

to this

[%- CASE 'superlibrarian' -%]<span>Access to all librarian functions</span>
[%- CASE 'circulate'      -%]<span>Check out and check in items</span>
[%- CASE 'catalogue'      -%]<span><b>Required for staff login.</b> Staff
access, allows viewing of catalogue in staff client.</span>

Bernardo

-- 
You are receiving this mail because:
You are watching all bug changes.