[Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357

--- Comment #34 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Kyle, same with these patch.

For instance:

diff C4/Ris.pm C4/Ris.pm.tdy returns:
<     elsif ( $fieldname eq "534" ) {
<         @subfields =
<           ( 'a', 'b', 'c', 'e', 'f', 'k', 'l', 'm', 'n', 'p', 't', 'x', 'z'
);
<     }
<     elsif ( $fieldname eq "535" ) {
---
>     } elsif ( $fieldname eq "534" ) {
>         @subfields = ( 'a', 'b', 'c', 'e', 'f', 'k', 'l', 'm', 'n', 'p', 't', 'x', 'z' );
>     } elsif ( $fieldname eq "535" ) {


and 

898,901c811
<     my @subfields = (
<         'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'j', 'k', 'l', 'm', 'n', 'o',
<         'p', 'q', 'r', 's', 't', 'u', 'v', 'x', 'y', 'z', '2', '3', '4'
<     );
---
>     my @subfields = ( 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'x', 'y', 'z', '2', '3', '4' );


It's weird because I have
  40 --maximum-line-length=178

in my ~/.perltidyrc
But it does not seem to be take into account.
If I launch it with
  perltidy C4/Ris.pm --noprofile

I get the same file as you.

I think I have spot a problem in the file:
 275             '607', '608', '610', '615', '620', '660' . '661',
should be
 275             '607', '608', '610', '615', '620', '660' , '661',

It existed before this patch.
I won't block this patch, but maybe it could be good to have a specific bug
report for tidying these files and talk about a common perltidyrc file to use.

-- 
You are receiving this mail because:
You are watching all bug changes.