[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #20 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Tried again, and got the error.

MariaDB [koha_ut]> select count(*) from systempreferences where
variable="HoldsQueueSkipClosed";
+----------+
| count(*) |
+----------+
|        1 |
+----------+

% git diff
diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t
index a73eac1..b67a2e2 100755
--- a/t/db_dependent/HoldsQueue.t
+++ b/t/db_dependent/HoldsQueue.t
@@ -307,6 +307,7 @@ C4::Calendar->new( branchcode => 'MPL'
)->insert_single_holiday(
 );
 C4::HoldsQueue::CreateQueue();
 $holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", {
Slice => {} });
+warn Data::Dumper::Dumper $holds_queue;
 is( scalar( @$holds_queue ), 1, "Holds not filled with items from closed
libraries" );
 C4::Context->set_preference('HoldsQueueSkipClosed', 0);


% prove t/db_dependent/HoldsQueue.t
t/db_dependent/HoldsQueue.t .. 18/23 $VAR1 = [
          { 
            'itemcallnumber' => undef,
            'reservedate' => '2015-02-12',
            'borrowernumber' => '70',
            'phone' => undef,
            'surname' => 'Surname',
            'holdingbranch' => 'CPL',
            'pickbranch' => 'CPL',
            'title' => 'Test Holds Queue XXX',
            'item_level_request' => '0',
            'notes' => undef,
            'biblionumber' => '14',
            'firstname' => 'Firstname',
            'cardnumber' => 'CARDNUMBER1',
            'itemnumber' => '127',
            'barcode' => '350699408070'
          },
          { 
            'reservedate' => '2015-02-12',
            'itemcallnumber' => undef,
            'borrowernumber' => '71',
            'surname' => 'Surname',
            'phone' => undef,
            'pickbranch' => 'CPL',
            'holdingbranch' => 'FFL',
            'item_level_request' => '0',
            'title' => 'Test Holds Queue XXX',
            'notes' => undef,
            'firstname' => 'Firstname',
            'biblionumber' => '14',
            'cardnumber' => 'CARDNUMBER2',
            'itemnumber' => '128',
            'barcode' => '350699408071'
          }
        ];

#   Failed test 'Holds not filled with items from closed libraries'
#   at t/db_dependent/HoldsQueue.t line 311.
#          got: '2'
#     expected: '1'

#   Failed test 'Holds not filled with items from closed libraries'
#   at t/db_dependent/HoldsQueue.t line 328.
#          got: '3'
#     expected: '2'
# Looks like you failed 2 tests of 23.
t/db_dependent/HoldsQueue.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/23 subtests 

Test Summary Report
-------------------
t/db_dependent/HoldsQueue.t (Wstat: 512 Tests: 23 Failed: 2)
  Failed tests:  21, 23
  Non-zero exit status: 2
Files=1, Tests=23,  3 wallclock secs ( 0.02 usr  0.00 sys +  1.96 cusr  0.04
csys =  2.02 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.