[Koha-bugs] [Bug 13712] New: Missing newline in DB update 3.19.00.010

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Feb 16 09:56:54 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712

            Bug ID: 13712
           Summary: Missing newline in DB update 3.19.00.010
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: magnus at enger.priv.no
          Reporter: magnus at enger.priv.no
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The DB update in updatedatabase.pl looks like this: 

9755 $DBversion = "3.19.00.010";
9756 if ( CheckVersion($DBversion) ) {
9757     $dbh->do("INSERT INTO `systempreferences`
(variable,value,explanation,options,type)
VALUES('SessionRestrictionByIP','1','Check for Change in  Remote IP address for
Session Security. Disable when remote ip address changes
frequently.','','YesNo')");
9758     print "Upgrade to $DBversion done (Bug 5511 -
SessionRestrictionByIP)";
9759     SetVersion ($DBversion);
9760 }

The missing newline at the end of line 9758 means that when you run the
webinstaller, this update and the next one are displayed on one line/as one
bullet point:

* Upgrade to 3.19.00.009 done (Bug 13007 - Add new foreign key
suggestions.budgetid)
* Upgrade to 3.19.00.010 done (Bug 5511 - SessionRestrictionByIP)Upgrade to
3.19.00.011 done (Bug 13417: Add permission to delete public lists)

Not a big deal, of course, but it would look better on two lines.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list