[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sat Feb 21 00:06:35 CET 2015
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480
Brendan Gallagher <brendan at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #35286|0 |1
is obsolete| |
--- Comment #31 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36109
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36109&action=edit
Bug 10480: Remove useless routines and irrelevant pod lines
This patch makes the following cleanup actions for all plugins:
1- Remove sub plugin_parameters. This function is not used.
2- Remove empty plugin or empty plugin_javascript subs.
3- Remove empty Blur, Clic or Focus routines from javascript.
4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs.
5- Remove the last 1; line. It is no longer needed.
Test plan:
Run the unit test t/db_dependent/FrameworkPlugins.t
Test some cataloguing plugins in addbiblio.
Test some item plugins in additem and neworderempty.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
I also checked the syntax of all plugins with perl -c.
And checked the pod (if any) with podchecker: Two files still produce a
warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl.
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list