[Koha-bugs] [Bug 13578] Parameter public is lost on creating a report

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35181|0                           |1
        is obsolete|                            |

--- Comment #2 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 36152
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36152&action=edit
Bug 13578: Make sure the 'public' parameter is passed to the last step

If no caching system is up ($usecache == 0), the public parameter is
lost on the step 3.
The hash passed to the template looks like:
   'cache_expiry', 300,
   'cache_expiry_units',
   'public', 1
So the template receives cache_expiry = 300, cache_expiry_units =
'public' and 1 = undef.

This patch fixes the problem passing the cache_expiry* parameters only
if the usecache is set.

Test plan:
0/ Disable any caching system
1/ Create a new public report and go up to the 6th step, save the report
and verify the report is created as public
2/ Enable a caching system
2/ Create a public report with a cache expiry value, save it and verify
the report is created as public and the cache expiry value is correct.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Been a bit since I've been in the guided reports.  This worked, I had 
memcached (on/off) also tested with Starman (on/off).  So good by me.  Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.