From bugzilla-daemon at bugs.koha-community.org Thu Jan 1 07:17:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jan 2015 06:17:17 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 1 07:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jan 2015 06:17:21 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 34851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34851&action=edit Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices If only 1 item exist in the message, the marker is not removed. This marker is removed by render_metadata, but this method is only called on appending. Test plan: 1/ Enable the CHECKIN and/or CHECKOUT notices for a patron 2/ check and item in or out and verify that the marker is no longer displayed in the generated notices. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 1 07:24:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jan 2015 06:24:33 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34777|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 34852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34852&action=edit Bug 13496: add a method for the templates to print Koha version as desired This patch introduces a simple template plugin function that returns the Koha version number in different suitable formats. It introduces unit tests for the new function. They are run with To test: - Apply the patch - Run $ prove t/Koha_Template_Plugin_Koha.t => SUCCESS: the tests pass. - Sign off :-D Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 1 07:24:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jan 2015 06:24:47 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 1 07:24:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jan 2015 06:24:50 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34778|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 34853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34853&action=edit Bug 13496: make auth.tt use a template plugin to get the Koha version This patch makes the installer login template use the new Koha.Version template plugin to get the correct Koha version. This way we don't need to maintain the auth.tt file on each version change, and are sure screen readers tell the correct version. To test: - Create a situation where the login screen from the installer shows - Navigate the HTML code (Ctrl+u) => FAIL: "Koha 3.0 Installer" shows on the HTML code - Apply the patch - Reload the page => SUCCESS: The correct version number is shown. - Sign off :-D Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 1 19:20:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jan 2015 18:20:49 +0000 Subject: [Koha-bugs] [Bug 13505] New: No advanced constraints for subfields $t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13505 Bug ID: 13505 Summary: No advanced constraints for subfields $t Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 34854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34854&action=edit Example of bug for subfield 505$t on serials framework On Home ? Administration ? MARC frameworks ? AnyFramework, on any field, for subfield $t we can't open/expand Advanced constraints: http://myKoha/cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=710&frameworkcode=SER#advt I suspected a Javascript issue, but Firefox (v34.0) console only throw ?Empty string passed to getElementById()?. Chromium (v39.0.2171.65 Ubuntu 14.10) with same issue. Koha 3.18.2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 1 19:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jan 2015 18:33:13 +0000 Subject: [Koha-bugs] [Bug 13505] No advanced constraints for subfields $t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Pablo, I have seen this recently - For me it starts working when I deactivate Adblock Plus. Hope this doesn't sound too weird :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 1 23:16:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jan 2015 22:16:53 +0000 Subject: [Koha-bugs] [Bug 12547] Create better API for handling external authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 --- Comment #5 from David Cook --- (In reply to Martin Renvoize from comment #4) > I am slowly on the case here.. starting with a non-destructive tidy of the > code found in bug 13499. > > The aim is to Tidy -> Document -> Write Tests -> Refactor -> Rewrite over a > long period... even if I only get steps one and two done I'd be pretty happy > that we're moving forward. > > Fancy verifying that my tidy actually improves things and maintain git blame > history David? It's been a while now since I've looked at the C4::Auth code, but I'll do my best when I can to check it out :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 10:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 09:13:04 +0000 Subject: [Koha-bugs] [Bug 5441] SSO CAS improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5441 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |REMIND Status|NEW |RESOLVED --- Comment #3 from Paul Poulain --- wow... did I really wrote this ? I don't understand most of what is written... Maybe Matthias knows, but, afaik, there's nothing pending for us around this. Closing BZ -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 10:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 09:34:07 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34831|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 34855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34855&action=edit Bug 13501: Use combobox plugin on cataloguing and batch items edit pages Tested with drop downs in cataloguing (edit and new record/item) and batch item editing. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 10:37:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 09:37:15 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34830|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 34856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34856&action=edit Bug 13501: Add jQuery UI plugin combobox It allows autocompletion on selects. Based on http://jqueryui.com/autocomplete/#combobox Note: This patch reset $.fn.button to the jQuery UI one (was overwritten by Bootstrap) Tested together with patch #2 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 10:38:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 09:38:27 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34855|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 34857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34857&action=edit Bug 13501: Use combobox plugin on cataloguing and batch items edit pages Tested with drop downs in cataloguing (edit and new record/item) and batch item editing. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 10:39:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 09:39:20 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 10:43:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 09:43:53 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34739|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 10:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 09:44:25 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 11:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 10:21:34 +0000 Subject: [Koha-bugs] [Bug 13506] New: Sip/Configuration/*.pm classes are unused Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Bug ID: 13506 Summary: Sip/Configuration/*.pm classes are unused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The classes Sip::Configuration::Account, Sip::Configuration::Institution and Sip::Configuration::Service are not actually used. Sip::Configuration calls new on all three but does not save the returned objects. Access to accounts, institutions and services is always to the hashref stored in the Configuration object not to objects of these classes. The Config code should be cleaned up by removing these Classes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 12:14:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 11:14:51 +0000 Subject: [Koha-bugs] [Bug 13506] Sip/Configuration/*.pm classes are unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 34858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34858&action=edit Proposed patch Removes the unused classes, remove the useless calls to their new methods. Took advantage to remove other obsolete code from configuration Simple Test plan: Select a repeatable series of sip transactions (e.g. an issue and discharge) run before applying patch to confirm all ok, run after applying patch and server should behave identically -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 12:56:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 11:56:08 +0000 Subject: [Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:16:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:16:31 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:16:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:16:33 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 --- Comment #1 from Kyle M Hall --- Created attachment 34859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34859&action=edit Bug 13441 - Branchcodes should not be allowed to have spaces in them In multiple cases I've seen issues arise in Koha where a librarian accidentally puts a space at the end of a new branchcode. This of course causes endless confusion because the branchcode looks perfectly fine in every case unless you wrap the code with some characters to reveal the hidden space! Test Plan: 1) Try creating a new branch with one or more spaces in the branchcode 2) Note you are able to 3) Apply this patch 4) Repeat step 1 5) Note you are no longer able to -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:16:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:16:40 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:17:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:17:41 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34859|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 34860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34860&action=edit Bug 13441 - Branchcodes should not be allowed to have spaces in them In multiple cases I've seen issues arise in Koha where a librarian accidentally puts a space at the end of a new branchcode. This of course causes endless confusion because the branchcode looks perfectly fine in every case unless you wrap the code with some characters to reveal the hidden space! Test Plan: 1) Try creating a new branch with one or more spaces in the branchcode 2) Note you are able to 3) Apply this patch 4) Repeat step 1 5) Note you are no longer able to -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:18:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:18:01 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #77 from Jonathan Druart --- I tested on v5.18.2 and I did not get any failures caused by double encoded problems. The following diff makes pass all tests: diff --git a/t/db_dependent/www/search_utf8.t b/t/db_dependent/www/search_utf8.t index be5ac96..6136950 100644 --- a/t/db_dependent/www/search_utf8.t +++ b/t/db_dependent/www/search_utf8.t @@ -246,7 +246,7 @@ sub test_search{ $intra_text = $agent->text(); like( $intra_text, qr|Publisher: $publisher|, ); - my $expected_base = q|search.pl\?idx=kw&q=| . uri_escape_utf8( $publisher ); + my $expected_base = q|q=| . uri_escape_utf8( $publisher ); $agent->base_like(qr|$expected_base|, ); ok ( ( length(Encode::encode('UTF-8', $intra_text)) != length($intra_text) ) , 'UTF-8 are multi-byte. Goog') ; @@ -269,7 +269,9 @@ sub test_search{ $opac_text = $agent->text(); like( $opac_text, qr|Publisher: $publisher|, ); - $expected_base = q|opac-search.pl\?idx=&q=| . uri_escape_utf8( $publisher ); + $expected_base = q|q=| . uri_escape_utf8( $publisher ); + my $base = $agent->base; + warn $base; $agent->base_like(qr|$expected_base|, ); ok ( ( length(Encode::encode('UTF-8', $opac_text)) != length($opac_text) ) , 'UTF-8 are multi-byte. Goog') ; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:19:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:19:36 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 --- Comment #3 from Kyle M Hall --- Please note this patch only stops the creation of new branchcodes with whitespace in them, so this should not cause any issues for existing Koha installations where the branchcodes may already contain spaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:23:15 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #165 from Kyle M Hall --- (In reply to Katrin Fischer from comment #164) > Hi Kyle, > > have you been able to reproduce/fix the first issue with the javascript > error in the OPAC? Not yet, would it be possible for you to create a video to demonstrate the issue? That way I can see if I'm making mistakes in my attempt to reproduce the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:58:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:58:14 +0000 Subject: [Koha-bugs] [Bug 8909] MARC21 240$a (Uniform title) is not a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:58:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:58:17 +0000 Subject: [Koha-bugs] [Bug 8909] MARC21 240$a (Uniform title) is not a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34689|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34861&action=edit [PASSED QA] Bug 8909: MARC21 240$a (Uniform title) is not a URL Patch removes the 'isUrl' attribute from all 240$a fields in the various frameworks. The change removes the broken link from the staff detail MARC tab view. Changes are a little easier to spot with: git diff --color-words HEAD^ To test: - Load some or all of the frameworks - Verify that 240$a is no longer marked as being an URL Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 13:59:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 12:59:55 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #11 from Marc V?ron --- Created attachment 34862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34862&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:00:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:00:46 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:01:04 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:02:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:02:27 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:10:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:10:23 +0000 Subject: [Koha-bugs] [Bug 9124] 942e tied to undefined CN_EDITION in default MARC21 framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9124 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34737|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34863&action=edit [PASSED QA] Bug 9124: Remove non-existing field mapping and auth value for 942$e 942$e is mapped to biblioitems.cn_edition, which doesn't exist and to an authorized value CN_EDITION, which doesn't exist either. Patch removes the wrong mapping and non-existing auth value from the frameworks. To test: - git diff --color-words HEAD^ is helpful - Check all mappings are changed and SQL is still valid Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:10:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:10:21 +0000 Subject: [Koha-bugs] [Bug 9124] 942e tied to undefined CN_EDITION in default MARC21 framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9124 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:19:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:19:25 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34717|0 |1 is obsolete| | Attachment #34718|0 |1 is obsolete| | Attachment #34719|0 |1 is obsolete| | Attachment #34720|0 |1 is obsolete| | --- Comment #60 from Kyle M Hall --- Created attachment 34864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34864&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:19:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:19:35 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #61 from Kyle M Hall --- Created attachment 34865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34865&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:19:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:19:38 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #62 from Kyle M Hall --- Created attachment 34866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34866&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:19:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:19:41 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #63 from Kyle M Hall --- Created attachment 34867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34867&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:20:25 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34860|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 34868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34868&action=edit Bug 13441 - Branchcodes should not be allowed to have spaces in them In multiple cases I've seen issues arise in Koha where a librarian accidentally puts a space at the end of a new branchcode. This of course causes endless confusion because the branchcode looks perfectly fine in every case unless you wrap the code with some characters to reveal the hidden space! Test Plan: 1) Try creating a new branch with one or more spaces in the branchcode 2) Note you are able to 3) Apply this patch 4) Repeat step 1 5) Note you are no longer able to Followed test plan with cache cleared. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:21:02 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:50:36 +0000 Subject: [Koha-bugs] [Bug 12730] Pre-due Notices not being sent. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12730 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Jesse, Please give more detail. I tested with TalkingTechItivaPhoneNotification enabled and disabled, the item due notice is correctly generated using DUEDGST. Which notices are not generated? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:50:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:50:54 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12774 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:50:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:50:54 +0000 Subject: [Koha-bugs] [Bug 12774] Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12922 CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:57:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:57:51 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:57:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:57:54 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34440|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 34869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34869&action=edit Bug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!! We failed to deliver advance_notices because a template for sms's is undefined, because we don't support sending sms' as advance_notice. This crashed the cronjob because digests are set to die instead of the warn used in non-digest. And we get angry customers asking for compensation! This patch replaces the die with warn. TEST PREPARATION: 0. Edit the ODUEDGST letter, find an undefined letter for any trasport type. TEST PLAN: 1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to the undefined digest. Set the "Days in Advance" to 1. 2. Check-out something for that borrower and set the due date for tomorrow. 3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal. 4. BEFORE THIS PATCH: You get an error "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609." and the script dies. 4. AFTER THIS PATCH: You get an error "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609." but the script keep on going! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:59:28 +0000 Subject: [Koha-bugs] [Bug 12774] Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #4 from Jonathan Druart --- Kyle, I prefer the patch proposed on bug 12922. It does the same thing but at one other place. *** This bug has been marked as a duplicate of bug 12922 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 14:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 13:59:28 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Jonathan Druart --- *** Bug 12774 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:00:43 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:00:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:00:46 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34782|0 |1 is obsolete| | Attachment #34783|0 |1 is obsolete| | Attachment #34784|0 |1 is obsolete| | Attachment #34785|0 |1 is obsolete| | Attachment #34786|0 |1 is obsolete| | Attachment #34787|0 |1 is obsolete| | Attachment #34788|0 |1 is obsolete| | Attachment #34789|0 |1 is obsolete| | Attachment #34790|0 |1 is obsolete| | Attachment #34791|0 |1 is obsolete| | --- Comment #77 from Kyle M Hall --- Created attachment 34870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34870&action=edit [PASSED QA] Bug 11023: Toggle "new" status This patch adds: - a new DB field items.new. - a new page to configure this new status (tools/toggle_new_status.pl). - a new cronjob script (misc/cronjob/toggle_new_status.pl). Why this status is useful for some libraries ? The use cases are: - to know easily what are the new items (with a simple sql query). - to display an icon in the search results. - issuing rules can be adapt for new items. Automatically (using the cronjob script), the status change (depending the configuration) and the item can be issued, for example. - a RSS/Atom feeds can be created on these new items. Test plan: - log in with a librarian having the tools > items_batchmod permission. - navigate to Home > Tools > Toggle new status - click on the edit button - there are 3 "blocks": * duration: the duration during an item is considered as new. * conditions: the status will change only if the conditions are meet. * substitutions: if there is no substitution, no action will be done. You can add some change to apply to the matching items. E.g. ccode=3 new='' If the value is an empty string (in other words, the input does not contain anything), the field will be deleted. You can create as many rules as you want. - test the interface : add/remove rule, conditions, substitutions, submit the form, edit, etc. (There is a looot of JS everywhere, so certainly a looot of bugs...). - when you have your rules defined, you can now launch the cronjob script without any parameter. A report will be displayed with the matching itemnumber and the substitutions to apply. Verify results are consistent. - launch the script with the -c argument and verify values have been modified depending the substitution rules. Signed-off-by: juliette et remy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:01 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #78 from Kyle M Hall --- Created attachment 34871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34871&action=edit [PASSED QA] Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. Signed-off-by: juliette et remy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:04 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #79 from Kyle M Hall --- Created attachment 34872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34872&action=edit [PASSED QA] Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t Signed-off-by: juliette et remy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:08 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #80 from Kyle M Hall --- Created attachment 34873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34873&action=edit [PASSED QA] Bug 11023: FIX - condition on biblioitems table does not work If a rule contains a condition on the biblioitems table, the match won't work. This patch fixes this issue. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:11 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #81 from Kyle M Hall --- Created attachment 34874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34874&action=edit [PASSED QA] Bug 11023: Use DBIx-Class to retrieve column names Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:14 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #82 from Kyle M Hall --- Created attachment 34875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34875&action=edit [PASSED QA] Bug 11023: Don't use the biblioitems fields for the subtitution It's dangerous to allow a change on the biblioitems fields with this feature. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:17 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #83 from Kyle M Hall --- Created attachment 34876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34876&action=edit [PASSED QA] Bug 11023: DB changes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:21 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #84 from Kyle M Hall --- Created attachment 34877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34877&action=edit [PASSED QA] Bug 11023: Rename the duration parameter with 'age' Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:24 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #85 from Kyle M Hall --- Created attachment 34878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34878&action=edit [PASSED QA] Bug 11023: The age parameter should be a number The template should check if the age parameter is correctly filled (should be a number). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:27 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #86 from Kyle M Hall --- Created attachment 34879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34879&action=edit [PASSED QA] Bug 11023: Change the name of the feature Originaly this feature only permits to update the "new" field. Now all item fields can be updated. The name of the feature is now "Automatic item modifications by age". Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:31 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #87 from Kyle M Hall --- Created attachment 34880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34880&action=edit Bug 11023 [QA Followup] * Update DB version * Fix capitalization error * Rename misc/cronjobs/toggle_new_status.pl to misc/cronjobs/automatic_item_modification_by_age.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:01:34 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #88 from Kyle M Hall --- Created attachment 34881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34881&action=edit Bug 11023 [QA Followup] - Complete the renaming of "toggle new status" to "automatic item modification by age" Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:09:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:09:49 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34881|0 |1 is obsolete| | --- Comment #89 from Kyle M Hall --- Created attachment 34882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34882&action=edit Bug 11023 [QA Followup] - Complete the renaming of "toggle new status" to "automatic item modification by age" Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:14:37 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34882|0 |1 is obsolete| | --- Comment #90 from Kyle M Hall --- Created attachment 34883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34883&action=edit Bug 11023 [QA Followup] - Complete the renaming of "toggle new status" to "automatic item modification by age" Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:44:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:44:42 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10177 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:44:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:44:42 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13441 --- Comment #2 from Marc V?ron --- This bug is similar to Bug 13441 and should be fixed the same way as Bug 13441 (prevent new passwords with whitespace characters, but do not touch functionalliy for existing passwords that already could contain spaces characters). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:47:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:47:31 +0000 Subject: [Koha-bugs] [Bug 7754] displaying the number of days a document is late In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7754 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:57:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:57:05 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #16 from Kyle M Hall --- (In reply to Jonathan Druart from comment #15) > QA comment: > I am quite confuse by this patch. > IMO there are some inconsistencies: > 1/ I don't understand the usefulness to pass by the template plugin to know > if a borrower has overdues or not. By using a TT plugin, we don't have to modify each and every script that uses the members toolbar. > 2/ Why did you move parse_letter to the pm file? A subroutine with the same > name exists in advance_notices.pl cronjob script (which uses C4::Overdues > too, so introduces a redefinion of it)? I moved it so we could use the same subroutine in both the cron script and the new script. I'll submit a followup to rename it to parse_overdues_letter > 3/ Same for C4::Members::GetOverdues, we already have a GetOverdues > subroutine in C4::Overdues. C4::Members::GetOverdues deals with getting a specific borrowers overdues, and gets more data than C4::Overdues::GetOverdues. They really do two different jobs. > 4/ Tests are missing for changes in packages. Will do! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:57:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:57:24 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:57:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:57:27 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34474|0 |1 is obsolete| | Attachment #34475|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 34884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34884&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:57:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:57:34 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #18 from Kyle M Hall --- Created attachment 34885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34885&action=edit Bug 12933 - Add new OVERDUES_SLIP letter Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:57:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:57:36 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #19 from Kyle M Hall --- Created attachment 34886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34886&action=edit Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 15:57:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 14:57:39 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #20 from Kyle M Hall --- Created attachment 34887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34887&action=edit Bug 12933 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:02:12 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34886|0 |1 is obsolete| | Attachment #34887|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 34888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34888&action=edit Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:02:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:02:28 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #22 from Kyle M Hall --- Created attachment 34889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34889&action=edit Bug 12933 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:14:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:14:58 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #24 from Jonathan Druart --- Created attachment 34890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34890&action=edit Bug 12252: Add tests for EmbedItemsInMarcBiblio Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:18:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:18:56 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:18:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:18:59 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34749|0 |1 is obsolete| | Attachment #34750|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 34891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34891&action=edit [PASSED QA] Bug 12368: Rebuild Zebra improvement: allow to specify a DB table Currently the --where parameter only allow to specify a condition on fields in the biblioitems table. For some needs it would be great to specify a condition on the field in the items table. The use case is the following: you want to reindex biblios with items modified since a specific timestamp. Test plan: 1/ Pick an item randomly in your catalogue 2/ Edit it and save 3/ Note that the items.timestamp has been set to today but not the biblioitems.timestamp 4/ launch rebuild_zebra without the new parameter perl misc/migration_tools/rebuild_zebra.pl -b -v --where "timestamp >= XXX" where XXX is the today date (e.g. "2014-06-05 00:00:00"). Note that the biblio has not been indexed. 5/ launch rebuild_zebra using the new parameter: perl misc/migration_tools/rebuild_zebra.pl -b -v -t items --where "timestamp >= XXX" Note the biblio has been indexed. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:19:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:19:05 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 --- Comment #8 from Kyle M Hall --- Created attachment 34892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34892&action=edit [PASSED QA] Bug 12368: Die if the --table value is not allowed. If the table given in parameter is not in the white list, the script should die rathen than correct to a default value. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:21:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:21:45 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:22:02 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34869|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 34893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34893&action=edit [PASSED QA] Bug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!! We failed to deliver advance_notices because a template for sms's is undefined, because we don't support sending sms' as advance_notice. This crashed the cronjob because digests are set to die instead of the warn used in non-digest. And we get angry customers asking for compensation! This patch replaces the die with warn. TEST PREPARATION: 0. Edit the ODUEDGST letter, find an undefined letter for any trasport type. TEST PLAN: 1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to the undefined digest. Set the "Days in Advance" to 1. 2. Check-out something for that borrower and set the due date for tomorrow. 3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal. 4. BEFORE THIS PATCH: You get an error "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609." and the script dies. 4. AFTER THIS PATCH: You get an error "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609." but the script keep on going! Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:22:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:22:00 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:22:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:22:33 +0000 Subject: [Koha-bugs] [Bug 13507] New: Add intranet support for CAS authentication Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507 Bug ID: 13507 Summary: Add intranet support for CAS authentication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Add intranet support for CAS authentication. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:23:16 +0000 Subject: [Koha-bugs] [Bug 5553] can click buttons when error appears on circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5553 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Is this still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:37:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:37:14 +0000 Subject: [Koha-bugs] [Bug 6349] auto print hold slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Is this still valid? - If I check in a book that is on hold I get a message with the options to confirm hold or to confirm hold and print slip. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:39:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:39:48 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:39:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:39:50 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33237|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 34894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34894&action=edit [PASSED QA] Bug 12743: ACQ: default values for catalogue records At the moment, it is possible to create records in acquisitions, but the ACQ framework is only used for items created in this module. This patch allows to defined default values in the ACQ framework for records created on the acquisition module. Test plan: 1/ Make sure you have the ACQ framework created (otherwise create it from the default framework). 2/ Define a default value for a field (for instance 099$z=1). 3/ Go in the acquisition module and create a new order from a new record. 4/ Fill mandatory information and save. 5/ Go on the detail page of this record and verify the default value exist. Signed-off-by: Gaetan Boisson Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:47:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:47:12 +0000 Subject: [Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:47:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:47:14 +0000 Subject: [Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34748|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34895&action=edit [PASSED QA] Bug 13346: OpacExportOptions becomes multiple The list of options is limited, the interface could be more ergonomic. Test plan: - verify that you are still allowed to change (add/remove) options for the OpacExportOptions pref. - At the OPAC, verify the selected options appear correctly (check the 3 pages opac-ISBDdetail.pl, opac-MARCdetail.pl and opac-detail.pl). Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:47:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:47:48 +0000 Subject: [Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- (In reply to Jonathan Druart from comment #4) > (In reply to Katrin Fischer from comment #3) > > The new list is much nicer, but it adds a small regression - you can no > > longer change the sequence the options are displayed in. I think if someone > > really wanted to, they can do so via SQL, so probably not worth holding this > > up. > > To be fair, I did not think about that. It could be accomplished with some javascript in opacuserjs if need be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:54:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:54:45 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:54:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:54:47 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34851|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34896&action=edit [PASSED QA] Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices If only 1 item exist in the message, the marker is not removed. This marker is removed by render_metadata, but this method is only called on appending. Test plan: 1/ Enable the CHECKIN and/or CHECKOUT notices for a patron 2/ check and item in or out and verify that the marker is no longer displayed in the generated notices. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:58:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:58:16 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:58:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:58:18 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34856|0 |1 is obsolete| | Attachment #34857|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 34897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34897&action=edit [PASSED QA] Bug 13501: Add jQuery UI plugin combobox It allows autocompletion on selects. Based on http://jqueryui.com/autocomplete/#combobox Note: This patch reset $.fn.button to the jQuery UI one (was overwritten by Bootstrap) Tested together with patch #2 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 16:58:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 15:58:27 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #7 from Kyle M Hall --- Created attachment 34898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34898&action=edit [PASSED QA] Bug 13501: Use combobox plugin on cataloguing and batch items edit pages Tested with drop downs in cataloguing (edit and new record/item) and batch item editing. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:00:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:00:01 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Looks good, but could perhaps use some styling, as the box is the same color as the background on the edit items page. Of course, it used to be the same color as the background on the edit record page, so it's kind of a wash in that respect ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:02:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:02:47 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:02:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:02:49 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34852|0 |1 is obsolete| | Attachment #34853|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34899&action=edit [PASSED QA] Bug 13496: add a method for the templates to print Koha version as desired This patch introduces a simple template plugin function that returns the Koha version number in different suitable formats. It introduces unit tests for the new function. They are run with To test: - Apply the patch - Run $ prove t/Koha_Template_Plugin_Koha.t => SUCCESS: the tests pass. - Sign off :-D Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:02:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:02:55 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 --- Comment #6 from Kyle M Hall --- Created attachment 34900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34900&action=edit [PASSED QA] Bug 13496: make auth.tt use a template plugin to get the Koha version This patch makes the installer login template use the new Koha.Version template plugin to get the correct Koha version. This way we don't need to maintain the auth.tt file on each version change, and are sure screen readers tell the correct version. To test: - Create a situation where the login screen from the installer shows - Navigate the HTML code (Ctrl+u) => FAIL: "Koha 3.0 Installer" shows on the HTML code - Apply the patch - Reload the page => SUCCESS: The correct version number is shown. - Sign off :-D Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:03:34 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #9 from Owen Leonard --- I think this is a useful enhancement, but I think in its current state it removes some of the built-in usability of a default HTML dropdown. The new dropdown has a fixed width, which in my system means it is not wide enough to show the complete description for some of my codes. After I have selected an item from the dropdown, I expect to be able to see the full description of the selected item by opening the dropdown again. In a , type the first letters of the item you're looking for. Item is selected. New: Tab to combobox, type the word you're looking for. Use arrow key to select the item you want. That may not be a deal-breaker for the feature, but I know the different will be noticeable to catalogers. Another problematic difference: After you select an item from the list, if you hit ENTER the form submits. We have been working to eliminate that behavior from forms in Koha, so I would consider it a regression to introduce a feature that brings it back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:03:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:03:44 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:06:54 +0000 Subject: [Koha-bugs] [Bug 6349] auto print hold slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6349 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov --- Comment #2 from Peggy Thrasher --- We would love to print a hold slip automatically, but that would need to be configurable on a per branch basis for us since our other branches don't use receipt printers. Alternatively, we would like to be able to change the default on thie confirmation box - so that the enter key would print the slip rather than just confirm. This would be similar to the CircAutoPrintQuickSlip system preference, where you can choose which action is the default. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:10:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:10:33 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:10:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:10:35 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34738|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34901&action=edit [PASSED QA] Bug 13495: Use "checked in" instead of "returned" in circulation To test: - check out one or many items on a patron account - return the items from the checkout table - notice that a message "Checked in" is now shown in the first and last column, instead of "Returned" as before Signed-off-by: Chris Cormack I feel dirty signing this off, but I guess we have to be consistent in our language Signed-off-by: Kyle M Hall Fixed merge conflict by removing changed lines no longer needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:10:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:10:43 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #9 from Kyle M Hall --- Created attachment 34902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34902&action=edit Bug 12495 [QA Followup] - Re-work "Renew or return" button as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:11:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:11:07 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34902|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 34903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34903&action=edit Bug 12495 [QA Followup] - Re-work "Renew or return" button as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:11:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:11:50 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34903|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:12:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:12:09 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #11 from Kyle M Hall --- Created attachment 34904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34904&action=edit Bug 12495 [QA Followup] - Re-word "Renew or return" button as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:12:32 +0000 Subject: [Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:12:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:12:58 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 --- Comment #4 from Kyle M Hall --- Created attachment 34905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34905&action=edit Bug 13495 [QA Followup] - Re-word "Renew or return" button as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:14:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:14:29 +0000 Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507 --- Comment #1 from Matthias Meusburger --- Created attachment 34906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34906&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:14:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:14:53 +0000 Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507 --- Comment #2 from Matthias Meusburger --- Created attachment 34907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34907&action=edit unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:26:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:26:26 +0000 Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Matthias Meusburger --- Test plan: CAS Intranet setup is identical to OPAC setup, but you have to set the StaffClientBaseUrl syspref (with the http or https prefix / http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7770 for more infos on why it is needed) Check that CAS login works in the intranet (except for the koha user, which is a special user). Check that CAS still works at the OPAC. Check that database login still works at both intranet and OPAC. Check that authenticating against multiple CAS servers work (see C4/Auth_cas_servers.yaml.orig) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:27:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:27:05 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #9 from Kyle M Hall --- Created attachment 34908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34908&action=edit Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:29:34 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:29:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:29:37 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34598|0 |1 is obsolete| | Attachment #34604|0 |1 is obsolete| | Attachment #34908|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 34909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34909&action=edit [PASSED QA] Bug 13485 - Add a proxy page To test: I) Apply the patch II) Run updatedatabase.pl scenario I) 1) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 2) Add your machine ip (ex. 127.0.0) 3) Validate cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents. scenario II) 1) Logout opac page 2) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 3) Add other ip that your machine ip. 4) Validate: cgi-bin/koha/opac-proxypage.pl shows a login page. 5) Validate: cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents after login. Followed both scenarios, works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:29:43 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #11 from Kyle M Hall --- Created attachment 34910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34910&action=edit [PASSED QA] Bug 13485 [QA Followup] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:31:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:31:26 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- (In reply to David Cook from comment #8) > (In reply to Eric B?gin from comment #7) > > David, > > > > You are correct. The proxy page is used for ressources that are restricted > > to connected users. > > > > The main usage is to allow patrons to access resources available by > > providers using a HTTP Referer mechanism. > > > > Note : This implementation doesn't include any password mechanism. Adding it > > would be possible. Borrowers attributes could be use to manage the username > > / passwords. For exemple, user accessing proxypage.pl?id=ebsco could look at > > ebscoUsername and ebscoPassword attributes. > > Thanks for confirming, Eric :). > > I might take a look at adding that later down the track, depending if we > have anyone needing it. We have a client or two who are looking at something > along these lines, but nothing has been 100% decided yet. To make this more extensible, we could simply evaluate the ProxyPageContent pref as TT, and then one could take advantage of all the TT plugins such as Koha.Preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:33:43 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:33:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:33:45 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34232|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 34911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34911&action=edit [PASSED QA] Bug 13408: Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... Signed-off-by: Owen Leonard This one works too! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:40:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:40:39 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- FAIL about.pl OK critic OK forbidden patterns OK pod FAIL valid !=~ should be !~ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:46:03 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 17:46:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 16:46:06 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #7 from Kyle M Hall --- Created attachment 34912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34912&action=edit Bug 13404 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 18:35:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 17:35:22 +0000 Subject: [Koha-bugs] [Bug 13508] New: Tags review page: Buttons "Approve" an "Reject" in table should display on same line Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13508 Bug ID: 13508 Summary: Tags review page: Buttons "Approve" an "Reject" in table should display on same line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The buttons "Approve" and "Reject" in the datatable on page /koha/tags/review.pl should display on the same line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 18:41:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 17:41:50 +0000 Subject: [Koha-bugs] [Bug 13509] New: Cross reference link for "Author" in search results always uses keyword search. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13509 Bug ID: 13509 Summary: Cross reference link for "Author" in search results always uses keyword search. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Doing an advanced search in the staff client using drop down "Title" search for "Black and Decker" The first search result is The complete guide to patios : plan, build and maintain by Schmidt, Philip. Black & Decker Corporation (Towson, Md.) Where 'Schmidt, Philip' and 'Black & Decker Corporation (Towson, Md.)' are separate author links. The link under 'Black & Decker Corporation (Towson, Md.)' Is http://.../cgi-bin/koha/catalogue/search.pl?q=au:%22Black%20&%20Decker%20Corporation%20(Towson,%20Md.)%22 This is a keyword search, rather than search by phrase, so the most relevant results are all authors with 'Black' in their names, rather than 'Black & Decker', which would have ranked higher in a search by phrase. The library is *not* using queryparser. Indexing using DOM. Possibly related bugs: The library in question is using authorities, but the bug description doesn't really match. Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5842 Cross-Reference links to authorized fields give incomplete search results --- This is old, and marked as 'pushed' it seems relevant, but I'm not sure. Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5941 Change the link in the authority search results to a phrase search --- Not directly related, but it also has to do with cross reference links... Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13301 Call number link in search results is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 18:50:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 17:50:24 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 18:50:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 17:50:26 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34163|0 |1 is obsolete| | Attachment #34404|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 34913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34913&action=edit [PASSED QA] Bug 13372: Items lost report improvements This enhancement adds new column to display the call number on the items lost report. On the way, DataTables and ColVis are added on the table. Test plan: 1/ Go on the items lost report (reports/itemslost.pl) and verify that the call number column is correctly filled. 2/ On the way, verify that the 'Library' and 'Current location' now contain the name instead of the code. 3/ Go on the columns configuration in the admin module (admin/columns_settings.pl), play with the ColVis plugin and confirm that all works correctly. Signed-off-by: David Roberts Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 18:50:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 17:50:34 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 --- Comment #8 from Kyle M Hall --- Created attachment 34914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34914&action=edit [PASSED QA] Bug 13372: Sort is done by DataTables This patch removes the order by filter on the items lost report. The sort can now be done by DataTables. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 18:57:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 17:57:15 +0000 Subject: [Koha-bugs] [Bug 8813] issue slip lists items as overdue that are not overdue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8813 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 19:10:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 18:10:41 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #22 from Kyle M Hall --- Works well! Some QA concerns: 1) Since the name of the feature has changed from "Virtual Shelves" to "Lists" can you change the permissions to "lists" and "manage_lists"? 2) Since this now only controls deletion, should it not be "delete_lists" instead? I think "delete_public_lists" would be most apt, as you cannot delete a patron's private lists. 3) Could you please add the new permissions to each languages permissions sql file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 19:14:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 18:14:12 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- QA Issue: The new authorized values need to be added to each translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 19:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 18:51:28 +0000 Subject: [Koha-bugs] [Bug 13262] Add parameters to XSLT Handler transform method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #12 from Kyle M Hall --- prove -v t/db_dependent/XSLT_Handler.t t/db_dependent/XSLT_Handler.t .. 1..26 ok 1 - Testing creation of handler object No XSLT file passed. at Koha/XSLT_Handler.pm line 322. ok 2 - Engine returns error on no file XSLT file not found. at Koha/XSLT_Handler.pm line 322. ok 3 - Engine returns error on bad file ok 4 - Test on invalid refresh ok 5 - Found my test stylesheet test01.xsl No string to transform. at Koha/XSLT_Handler.pm line 322. ok 6 - Engine returns error on undefined text Error while parsing input: Empty String at Koha/XSLT_Handler.pm line 179. ok 7 - Engine returns error on empty string Error while parsing input: :1: parser error : Start tag expected, '<' not found abcdef ^ ok 8 - Engine returns error on non-xml Error while parsing input: :1: parser error : Opening and ending tag mismatch: a line 1 and b ^ ok 9 - Engine returns error on malformed xml Error while parsing input: :1: parser error : Opening and ending tag mismatch: a line 1 and b ^ ok 10 - Engine respects do_not_return_source==1 Error while parsing input: :1: parser error : Opening and ending tag mismatch: a line 1 and b ^ ok 11 - Second engine respects it too Error while parsing input: :1: parser error : Opening and ending tag mismatch: a line 1 and b ^ ok 12 - Engine respects do_not_return_source==0 ok 13 - Test on valid refresh ok 14 - Test on repeated refresh ok 15 - Engine returned no error for xml_1 ok 16 - No real change expected for xml_1 ok 17 - Engine returned no error for xml_2 ok 18 - Saw the expected change for xml_2 ok 19 - Found my test stylesheet test02.xsl Error while parsing stylesheet: compilation error: file /var/lib/koha/kohaqa/kohaclone/t/db_dependent/XSLT_Handler/test02.xsl element variable redefinition of global variable redefine at Koha/XSLT_Handler.pm line 274. ok 20 - Engine returned error for parsing bad xsl ok 21 - Error string contains text ok 22 - Found my test stylesheet test03.xsl ok 23 - Unexpected error on transform with third xsl ok 24 - Final test on clearing cache ok 25 - Found my test stylesheet test04.xsl ok 26 - Successfully injected string into XSLT parameter/variable ok All tests successful. Files=1, Tests=26, 0 wallclock secs ( 0.03 usr 0.02 sys + 0.10 cusr 0.01 csys = 0.16 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 19:52:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 18:52:04 +0000 Subject: [Koha-bugs] [Bug 13262] Add parameters to XSLT Handler transform method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 19:52:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 18:52:06 +0000 Subject: [Koha-bugs] [Bug 13262] Add parameters to XSLT Handler transform method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33978|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 34915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34915&action=edit [PASSED QA] Bug 13262 - Add parameters to XSLT Handler transform method This patch adds an optional hashref argument to the XSLT_Handler transform() method. It allows you to send key => value pairs parameters to the XML::LibXSLT object, which you can reference in a XSLT via . The parameter value is evaluated as an XPath query, so you can only pass quoted strings (i.e. "'test'") or numbers. Otherwise, the XSLT engine will interpret it as a Xpath query and will run it on the XML that you're transforming. The most common use case is sending strings to a XSLT. In my case, this is an OAI-PMH identifier that comes in a OAI response but not the actual metadata. See the following link from the official POD: http://search.cpan.org/~shlomif/XML-LibXSLT-1.92/LibXSLT.pm#Parameters _TEST PLAN_ 1) Run "perl t/db_dependent/XSLT_Handler.t". If all tests pass, you should be free to sign off. Feel free to inspect the last test in XSLT_Handler.t and the XSL in test04.xsl to see how it works. If you really want to be thorough, you could write your own test cases using mine as an example. Alternatively, you could go into C4::XSLT, and try to pass a value to a parameter in the search results or the detail page, but that might be a bit over the top. It's a pretty simple patch. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 19:52:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 18:52:56 +0000 Subject: [Koha-bugs] [Bug 13262] Add parameters to XSLT Handler transform method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #14 from Kyle M Hall --- I assume the errors during the unit tests are not a problem since the test data is purposely malformed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 2 20:36:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jan 2015 19:36:08 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Summary|Add a proxy page |Add a page to display links | |to restricted sites --- Comment #13 from Chris Cormack --- Changed the bug report, this does no proxying at all. So the title was really confusing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 00:29:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Jan 2015 23:29:36 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #19 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 00:31:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Jan 2015 23:31:33 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #35 from Chris Cormack --- Major refactoring, and moving of code, so I wont be pushing this to a stable branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 15:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 14:16:11 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 34916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34916&action=edit Bug 13167: (QA followup) regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 15:16:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 14:16:46 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34699|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 34917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34917&action=edit Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13 If the ISBN of a UNIMARC record begins with 979 then the 'Stage MARC for import' hangs. If I use the same UNIMARC record and change 979 to 978 in the ISBN, 'Stage MARC for import' works perfectly. The patch deals with the fact that converting an ISBN-13 to ISBN-10 with Business::ISBN as_isbn10() method fails if the ISBN doesn't begin with 978. TEST PLAN: (1) Download, and decompress the ZIP file attached to BZ. (2) On a UNIMARC Koha instance, go in Tools > Stage MARC for import. (3) Choose the MARC file containing the record with an ISBN begining with 979. Click on Upload file, then Stage to import. (4) The Job progress bar stay at 0%. (5) Apply the patch. Repeat steps 2-3. The upload works. Signed-off-by: Colin Campbell Signed-off-by: Katrin Fischer Tested in a UNIMARC installation, confirmed that the patch fixes the problem. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 16:20:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 15:20:09 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frederic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 16:20:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 15:20:40 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 16:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 15:21:23 +0000 Subject: [Koha-bugs] [Bug 9124] 942e tied to undefined CN_EDITION in default MARC21 framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9124 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 16:22:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 15:22:11 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 16:22:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 15:22:57 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 16:23:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 15:23:24 +0000 Subject: [Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 17:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 16:06:41 +0000 Subject: [Koha-bugs] [Bug 8909] MARC21 240$a (Uniform title) is not a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8909 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 17:07:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 16:07:15 +0000 Subject: [Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 17:07:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 16:07:47 +0000 Subject: [Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #21 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 17:08:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 16:08:14 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 22:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 21:50:36 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #14 from David Cook --- (In reply to Chris Cormack from comment #13) > Changed the bug report, this does no proxying at all. So the title was > really confusing I think that makes a lot of sense. On that note, it might be worthwhile changing "opac-proxypage.pl" to something more representative of the functionality as well, although I suppose this is already passed QA... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 23:00:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 22:00:24 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #91 from Katrin Fischer --- No intention to block this, but still a bit worried about the possibility of people doing changes that might cause problems. Would people be ok with adding a separate permission for this tool? Currently it's tied to the batch delete permission, but not working with the restricted batch delete: flagsrequired => { tools => 'items_batchmod' }, Offering to write the patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 23:24:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 22:24:21 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 --- Comment #5 from Katrin Fischer --- Created attachment 34918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34918&action=edit [PASSED QA] Bug 13441 - Branchcodes should not be allowed to have spaces in them In multiple cases I've seen issues arise in Koha where a librarian accidentally puts a space at the end of a new branchcode. This of course causes endless confusion because the branchcode looks perfectly fine in every case unless you wrap the code with some characters to reveal the hidden space! Test Plan: 1) Try creating a new branch with one or more spaces in the branchcode 2) Note you are able to 3) Apply this patch 4) Repeat step 1 5) Note you are no longer able to Followed test plan with cache cleared. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 23:24:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 22:24:44 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 23:24:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 22:24:46 +0000 Subject: [Koha-bugs] [Bug 13441] Branchcodes should not be allowed to have spaces in them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34868|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 23:45:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 22:45:12 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34827|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 34919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34919&action=edit [PASSED QA] Bug 13457: Suggestions.t expects sample itemtypes TEST PLAN --------- 1) Make sure you have more than 8 item types, and preferably something with a non-sample default code for itemtypes. 2) prove t/db_dependent/Suggestions.t -- this will fail 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- this will succeed 5) run koha qa test tools Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 23:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 22:45:15 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 --- Comment #12 from Katrin Fischer --- Created attachment 34920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34920&action=edit [PASSED QA] Bug 13457 - Followup for CPL and S codes Based on comment #3, this corrects CPL and S issues if they do not exist in the DB. TEST PLAN --------- 0) Backup your DB. 1) Clear CPL and S from your DB. - delete from borrowers where categorycode='S'; - delete from categories where categorycode='S'; - delete from borrowers where branchcode='CPL'; - delete from branch where branchcode='CPL'; 2) prove t/db_dependent/Suggestions.t -- This should fail. 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- This should work. 5) Intentionally add categorycode 'S' and branchcode 'CPL' back into the database. 6) prove t/db_dependent/Suggestions.t -- This should work. 7) run koha qa test tools. 8) Restore your DB :) Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 23:45:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 22:45:40 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 23:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 22:45:42 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34828|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 4 23:47:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 22:47:15 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 --- Comment #13 from Katrin Fischer --- It's probably not the best solution, but I think it can be easily redone, once we figured out better ways. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 00:11:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 23:11:11 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Hi Olli-Antti, the problem in the bug description is a real one, but I am uncomfortable with the number of changes in this patch. The more changes, the more suspicious I get! I see like 3 different bugs here: 1) Translation problem, introduction of a new include - I think the include should be in the includes directory, starting with serials-... to match the existing includes. Pleaes fix. 2) STL is not saved correctly. - Problem seems to be fixed by this patch, but I want to test more for side effects of the variable changes after a follow-up. 3) Changes to serials/subscription-numberpatterns.pl/tt - I don't understand why those have been made - maybe it's too late tonight. Please include an explanation and amend test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 00:15:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 23:15:52 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 --- Comment #10 from Katrin Fischer --- As some of the dependencies still need QA, I will work on them first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 00:18:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Jan 2015 23:18:47 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #10 from Katrin Fischer --- If I see the dependencies correctly, this should be next - but it doesn't apply: Jonathan, can you check what's missing? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12976: Use the centralize VAT and prices calculation - invoice.pl fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12976: Use the centralize VAT and prices calculation - invoice.pl The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12976-Use-the-centralize-VAT-and-prices-calcul-H4QMVv.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 02:29:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 01:29:59 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32052|0 |1 is obsolete| | --- Comment #7 from Robin Sheat --- Created attachment 34923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34923&action=edit Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries (this fixes the merge conflict, looking into the other issues now.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 04:24:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 03:24:54 +0000 Subject: [Koha-bugs] [Bug 6849] idzebra modules not found on openSUSE 64-bit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6849 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #1 from Robin Sheat --- I made a wiki page for this sort of thing, though it would be good for the installer to handle this somehow. http://wiki.koha-community.org/wiki/Troubleshooting_Zebra#No_such_record_type -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 04:25:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 03:25:05 +0000 Subject: [Koha-bugs] [Bug 6849] idzebra modules not found on openSUSE 64-bit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6849 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 04:50:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 03:50:57 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #8 from Robin Sheat --- (In reply to Paola Rossi from comment #5) > 1) I selected no branch [so all branches were selected]. Then I've selected > a value for the two input fields: > From item call number > To item call number > > Koha has answered only about the current selected library, not about all the > libraries as required. Confirmed. This is an annoying interaction with the "strip non-local items" option. Going to have to think about how this should work for a minute. > 2) > By default all branches will be selected. > No, the default was the current selected library (that I could uncheck, > anyway). Confirmed. Turns out it was something that differed from using the database user vs. a real one, but it should behave like the old version which is to select "all" by default. Haven't looked at the other things yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 05:23:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 04:23:06 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #9 from Robin Sheat --- (In reply to Paola Rossi from comment #5) > 3) There were some records biblio in my DB, all the biblios had at least one > item. Exporting all records [no branch checked, item type ALL, the other > input fields empty] was OK. Then I catalogued a new biblio record [Default > framework] without items. And then I edited an old item changing the > barcode, inventory and something else. > Exporting in the same way as above, not all the records were exported, but > only some of them: in particular, the biblio record of the changed item was > not exported. > [I went back to master on the same DB. Exporting [ALL Library selected, item > type ALL, the other input fields empty], all the records were exported: the > biblio record without items too, as well as the biblio record whose item I > changed.] I can't confirm this. I did these steps, but my edited item was exported correctly, along with its biblio. > NB-2. If I didn't selected "From biblio number" and "To biblio number", in > some cases the export file is not sorted on biblio number. This seemed > strange to me: the sort of the export file could be an important information > for me, but I didn't recognize what it was. No ordering is provided to the SQL query, so it'll be whatever order the database responds in I think. This'll normally be the same order as the records were added, but that's not a guarantee. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 05:25:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 04:25:43 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34923|0 |1 is obsolete| | --- Comment #10 from Robin Sheat --- Created attachment 34924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34924&action=edit Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 05:26:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 04:26:37 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #11 from Robin Sheat --- This changes the behaviour slightly, I'm not sure if that'll be an issue or not. I'd appreciate a double-check on that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 08:21:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 07:21:42 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #73 from Katrin Fischer --- Working on this next. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 08:23:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 07:23:40 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org --- Comment #74 from Katrin Fischer --- Turns out I missed some of the conflicts when trying to resolve them - it's related to the push of the new Booksellers module from Jonathan. :( Julian, could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 09:55:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 08:55:08 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #92 from Jonathan Druart --- (In reply to Katrin Fischer from comment #91) > No intention to block this, but still a bit worried about the possibility of > people doing changes that might cause problems. > > Would people be ok with adding a separate permission for this tool? > Currently it's tied to the batch delete permission, but not working with the > restricted batch delete: > > flagsrequired => { tools => 'items_batchmod' }, > > Offering to write the patch :) The items_batchmod permission make sense to me. I would prefer to add the support for items_batchmod_restricted if it makes sense for you too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:08:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:08:41 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:08:44 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31983|0 |1 is obsolete| | Attachment #33573|0 |1 is obsolete| | Attachment #33613|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 34933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34933&action=edit Bug 12976: Use the centralize VAT and prices calculation - invoice.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:08:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:08:48 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #12 from Jonathan Druart --- Created attachment 34934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34934&action=edit Bug 12976: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:08:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:08:52 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #13 from Jonathan Druart --- Created attachment 34935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34935&action=edit Bug 12976: Fix some comment in tests Previous comments were wrong. Actually the main part of price values is correct. Only some rounding and tax values are badly calculated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:09:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:09:24 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #14 from Jonathan Druart --- Patches rebased. Conflicts with bug 12059 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:13:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:13:48 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 --- Comment #14 from Jonathan Druart --- (In reply to Katrin Fischer from comment #13) > It's probably not the best solution, but I think it can be easily redone, > once we figured out better ways. IMO what we do now (only pass with specific data) is not perfect but better than the idea behind this patch (copy and paste the data insertion). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:15:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:15:12 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 --- Comment #15 from Katrin Fischer --- So you feel it adds too much data? Sorry, not sure I understand yet! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:21:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:21:31 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #93 from Katrin Fischer --- Guess I am still a little worried about people breaking things with this new tool - so that's why I'd have preferred a separate permission. We have a separate permission for every other tool, so it would fit in well. But the combination with the restricted mode makes things more complicated here. Not sure what's best. If we leave it with item batchmod it would make sense to add the restricted behaviour, but also sounds more complicated to do :) Maybe we should open a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:22:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:22:50 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33308|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Created attachment 34936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34936&action=edit Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:22:55 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33309|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart --- Created attachment 34937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34937&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:22:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:22:59 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33310|0 |1 is obsolete| | --- Comment #77 from Jonathan Druart --- Created attachment 34938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34938&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:23:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:23:04 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33311|0 |1 is obsolete| | --- Comment #78 from Jonathan Druart --- Created attachment 34939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34939&action=edit Bug 11708: explicitly remove pagination The use of columnfilter seems to keep the pagination even if the sDom is 't'. We want to remove the pagination here in order to show all data in the table. To reproduce: Add 10+ closed basketgroup and verify all are displayed. Without this patch, only the 10 first are displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:23:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:23:08 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33312|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart --- Created attachment 34940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34940&action=edit Bug 11708: All basketgroups on one page - several fixes 1/ Change wording from "Basket grouping" to "Basket groups" 2/ Display vendor name in front of "Baskets group for" 3/ Change wording from "Charged amount" to "Amount spent" 4/ Change wording from "Ordered amount" to "Amount ordered" 5/ Add bug number in updatedatabase.pl 6/ Show "Basket groups" link in menu only if user have group_manage permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:23:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:23:13 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33313|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart --- Created attachment 34941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34941&action=edit Bug 11708: Remove the amount columns This should be managed in a specific bug. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:24:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:24:02 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #81 from Jonathan Druart --- Conflicts with bug 12896 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:26:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:26:28 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #82 from Katrin Fischer --- Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:29:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:29:27 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #94 from Jonathan Druart --- (In reply to Katrin Fischer from comment #93) > Maybe we should open a separate bug? It's certainly the best. While people will start to use it, we will get feedback to improve the existing behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:29:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:29:44 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #95 from Jonathan Druart --- s/While/When -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:31:30 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #96 from Jonathan Druart --- (In reply to Kyle M Hall from comment #90) > Created attachment 34883 [details] [review] > Bug 11023 [QA Followup] - Complete the renaming of "toggle new status" to > "automatic item modification by age" > > Signed-off-by: Kyle M Hall I am not sure it's a good idea to create files and rename them in the same patch set. Maybe should we squash patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:43:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:43:13 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:43:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:43:16 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #23 from Jonathan Druart --- Created attachment 34942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34942&action=edit Bug 13417: (qa follow-up) Rename the permission to delete_public_lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:43:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:43:20 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #24 from Jonathan Druart --- Created attachment 34943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34943&action=edit Bug 13417: Add the permission for all languages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 10:47:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 09:47:20 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart --- (In reply to Kyle M Hall from comment #12) > QA Issue: The new authorized values need to be added to each translation. Kyle, As you know, this change is very boring to do. I would prefer to wait for the QA step passes and the wording is validated before to add the changes to all languages. I hope it makes sense for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 11:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 10:04:44 +0000 Subject: [Koha-bugs] [Bug 13512] New: Add sort-string-utf.chr for Polish and Latin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13512 Bug ID: 13512 Summary: Add sort-string-utf.chr for Polish and Latin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: dudzikmichal at wp.pl QA Contact: testopia at bugs.koha-community.org Created attachment 34944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34944&action=edit Add sort-string-utf.chr for Polish This file have Zebra lang defs with charsets for Polish and Latin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 11:06:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 10:06:21 +0000 Subject: [Koha-bugs] [Bug 13512] Add sort-string-utf.chr for Polish and Latin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13512 Michal Dudzik changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34944|0 |1 is obsolete| | --- Comment #1 from Michal Dudzik --- Created attachment 34945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34945&action=edit Add sort-string-utf.chr for Polish -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 11:08:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 10:08:22 +0000 Subject: [Koha-bugs] [Bug 13512] Add sort-string-utf.chr for Polish and Latin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13512 --- Comment #2 from Michal Dudzik --- Created attachment 34946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34946&action=edit Polish ISO2709 records sample -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 11:14:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 10:14:01 +0000 Subject: [Koha-bugs] [Bug 13513] New: Improve POD of C4::Circulation AnonymiseIssueHistory Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13513 Bug ID: 13513 Summary: Improve POD of C4::Circulation AnonymiseIssueHistory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The documentation of AnonymiseIssueHistory doesn't appear to be correct - claims to update issues instead of old_issues - claims to write NULL, but seems to write the borrowernumber of the AnonymousPatron or 0 instead - claims it will delete the patron issue history for all borrowers if only date is given, doesn't mention it also checks for privacy setting in the patron account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 11:14:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 10:14:58 +0000 Subject: [Koha-bugs] [Bug 13513] Improve POD of C4::Circulation AnonymiseIssueHistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13513 --- Comment #1 from Katrin Fischer --- http://ilsma.bsz-bw.de/gitweb/?p=koha.git;a=blob;f=C4/Circulation.pm;h=5f7e866b33098abe097724da9ae90938f381551f;hb=8158fbab4765de2bf542e78fdfc8c113ac362682#l3160 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 11:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 10:16:11 +0000 Subject: [Koha-bugs] [Bug 13513] Improve POD of C4::Circulation AnonymiseIssueHistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13513 --- Comment #2 from Katrin Fischer --- http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Circulation.pm;h=5cd8ba312984e450d5b0364422c9e04a02d362be;hb=b4e843615a76d3a9a8516f82a2ebad96aa9c4d1a#l3161 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 11:48:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 10:48:59 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34513|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 34947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34947&action=edit Bug 13478: Database revision for table biblio_force_item_holds TEST PLAN: [1] Run the database revision. Check if the new table is present. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 11:49:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 10:49:03 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 --- Comment #4 from M. de Rooy --- Created attachment 34948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34948&action=edit Bug 13478: Force item holds only for specific biblios This patch adds the option to selectively force item holds for specific biblionumbers. These numbers are saved in a separate table. The patch adds routine C4::Reserves::CheckBiblioForceItemHolds. It is tested in Reserves.t. The preference OPACItemHolds gets a new choice: selectiveforce. The description of the pref is adjusted. Please note that this option is specifically targeted for the OPAC. Staff users still have both possibilities. A follow-up patch adds the possibility for staff users to add or remove a biblio from the list of books with forced item holds. TEST PLAN: [ 1] Run the unit test t/db_dependent/Reserves.t. [ 2] Set OPACItemHolds to force. [ 3] Add a hold in the OPAC; verify that you cannot place a next/av hold. [ 4] Set OPACItemHolds to Allow. [ 5] Add a hold in the OPAC; verify that you can place both hold types. [ 6] Set OPACItemHolds to Do not allow. [ 7] Add a hold in the OPAC; verify that you can only place next/av holds. [ 8] Add two biblio numbers into table biblio_force_item_holds. [ 9] Set OPACItemHolds to Selectively force. [10] Add a hold on three biblionumbers at once (including these two). Verify that you have two hold types for the single biblio and that you have only item holds for the two other biblios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:24:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:24:01 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > Jonathan, can you add some hints on how to run the tests? I don't know and I did not find any documentation on these tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:36:18 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #56 from M. de Rooy --- (In reply to Jonathan Druart from comment #55) > Marcel, all looks good to me but I have few questions: Thanks for testing, Jonathan. I hope to address your questions now. > 6/ From http://perldoc.perl.org/functions/do.html, it seems that > print "ERROR: $!\n" if $!; > should be > print "ERROR: $!\n" if $! and not $@; OK. That is fine with me. I first check $@; in the second print I will the condition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:36:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:36:43 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #57 from M. de Rooy --- I will the -> I will add the -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:43:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:43:16 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #58 from M. de Rooy --- > 3/ What means the $rv flag? rv= return value (from do or something similar); I use it later in the routine to check if I should call the atomicmemory routine: _atomic_memory( $atomicupd, $file ) if $rv; > 5/ > $rv = 1 if !$! && !$@; #apparently, the file does not end with 1; > I tested with a file without 1; and I don't get any error. That's just what this line did for you. If your file did not return 1 and I discovered no error, then I set rv to 1 for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:45:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:45:54 +0000 Subject: [Koha-bugs] [Bug 13261] Better check in message for patrons with indefinite restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #15 from Olli-Antti Kivilahti --- Thanks for the patch Marc! Just stumbled upon this issue having barred some of our patrons :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:46:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:46:28 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34070|0 |1 is obsolete| | --- Comment #59 from M. de Rooy --- Created attachment 34949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34949&action=edit Bug 13068: Follow-up for cleaning up atomicupdate folder The folder atomicupdate can be cleaned up. It mainly contains old files that are not used any more. I found two files that are still referenced: [1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl A readme file refers to it. The code in this file slightly differs from the TalkingTech db revision. It can probably be deleted too, but I will first check. [2] oai_sets.sql This file should remain. It is used in dbrev 3.07.00.029. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:46:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:46:35 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34071|0 |1 is obsolete| | --- Comment #60 from M. de Rooy --- Created attachment 34950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34950&action=edit Bug 13068: Counterpatch using atomicupdate directory This patch makes a distinction between atomicupdates belonging to an official db revision and development updates. It also keeps track of the dev updates since the last official db rev. (This is done via a local pref; so easily accessible if needed.) The db revs can be txt files, perl scripts or sql files. Sql files are run via the installer. A new db revision is now only a matter of dropping a file in atomicupdates for the developer. The RM only adds one line to updatedatabase like: ExecDBRev( $aupd, '13068', 'Refined dbrev', '13068.pl', '3.17.00.028'); This line should follow the last dbrev and preceed the call to RunRemainingAtomicUpdates. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Run updatestructure and check if all db revs and dev updates are run. Run updatestructure again. Nothing should be run now. Clear/delete the _LocalAtomicUpdates pref. Run updatestructure again. Only dev updates should be run. Reset the database version. You could edit Version in local preferences. Run updatestructure and check if all db revs and dev updates are run. Edit _LocalAtomicUpdates and remove one filename. Run updatestructure again. Only one dev update should be run. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:46:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:46:39 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34072|0 |1 is obsolete| | --- Comment #61 from M. de Rooy --- Created attachment 34951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34951&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:47:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:47:59 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #62 from M. de Rooy --- > 2/ ExecDBRev takes 5 parameters, but you use only 3, the idea is to call this > routine for each db rev in updatedatabase.pl? Yes. I gave this example in one of the commit messages: ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 12:58:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 11:58:36 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #63 from M. de Rooy --- > 1/ Could you please detail when the RESET mode should be used? The difference between TRACK and RESET concentrates on what you do when you run an official db rev on your dev machine. If you are very cautious, you got rid of all things that were done in dev updates BEFORE you run a real db rev. In that case RESET is your friend: it will reinstall all dev updates again. It may theoretically be better. If you know that the dev updates you installed do not interfere with the db rev at hand, TRACK will not try to run them again. More pragmatic. All depends on how you use them and how you interpret the *risks* on such a dev box. Instead of choosing one road to go, I offer them both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 13:02:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 12:02:56 +0000 Subject: [Koha-bugs] [Bug 13514] New: Move two files out of atomicupdate folder Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13514 Bug ID: 13514 Summary: Move two files out of atomicupdate folder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See also bug 13068. These two files are left: Bug-4246-Talking-Tech-itiva-phone-notifications.pl oai_sets.sql I will find another location for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 13:04:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 12:04:37 +0000 Subject: [Koha-bugs] [Bug 13514] Move two files out of atomicupdate folder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13514 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13068 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 13:04:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 12:04:37 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13514 --- Comment #64 from M. de Rooy --- > 4/ Don't you think we should move the 2 files to skip into another directory > (and use this one exclusively for this use)? I will open up a new report to move or delete them. After that we can clean up the hash variable. (See bug 13514.) This way they will not provide further noise in this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 13:05:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 12:05:08 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 13:19:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 12:19:14 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #65 from M. de Rooy --- > 7/ In TRACK mode, given the following file: > 1 use Modern::Perl; > 2 use C4::Context; > 3 my $dbh = C4::Context->dbh; > 4 $dbh->do("delete from foo"); > I executed perl installer/data/mysql/updatedatabase.pl > and I got > DBD::mysql::db do failed: Table 'koha.foo' doesn't exist > at /home/koha/src/installer/data/mysql/atomicupdate/test3.pl line 4. > Dev upgrade test3.pl done > The filename is appended to _localatomicupdates, it seems it should not, > could you confirm? Yes, I can reproduce this (does not depend on the mode). Problem here is if the db rev does not care about the errors raised, the calling program (updatedatabase) does not see them any more. Your last statement $dbh->do returns undef to the caller. But when you are back in updatedatabase, the $! and $@ are not set any more. (Note that if you had a trailing 1; in your file, I even would have received a 1.) In this case I assume everything is fine and I append your file to the pref. I agree that we ideally should not. But how should we catch this in a simple and elegant way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 15:23:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 14:23:29 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 15:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 14:50:10 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 15:50:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 14:50:14 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33929|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 34952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34952&action=edit Bug 11120: FIX the --date option for overdue_notices cronjob Bug 7447 introduces the --date option for overdue notices. This option has never worked: the code is waiting for a value but the option is defined as a boolean. This patch fixes the option and change the way to calculate the range of dates. This range is now managed in Perl instead of in the SQL query. To do it in Perl allows to build dates simply using the DateTime and DateTime::Duration modules. To test this patch you should have a DB with a lot of overdues, (I tested on a DB with 512 overdues). A test plan could be: 1/ Dump your message_queue table 2/ Verify the number of overdues in the database before applying the patch: mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v -t (the triggered option will generate overdue for today) mysql> SELECT COUNT(*) FROM message_queue; Note this value 2A mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v mysql> SELECT COUNT(*) FROM message_queue; Note this value 2B 2/ Apply the patch 4/ Verify the number of overdues generated by the patched script: mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v -t mysql> SELECT COUNT(*) FROM message_queue; Note this value 4A mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v mysql> SELECT COUNT(*) FROM message_queue; Note this value 4B mysql> DELETE FROM message_queue; # The date should be defined depending your dateformat preference # and should be the date of the current day perl misc/cronjobs/overdue_notices.pl -v -t --date="YYYY-MM-DD" mysql> SELECT COUNT(*) FROM message_queue; Note this value 4C mysql> DELETE FROM message_queue; # The date should be defined depending your dateformat preference # and should be the date of the current day perl misc/cronjobs/overdue_notices.pl -v --date="YYYY-MM-DD" mysql> SELECT COUNT(*) FROM message_queue; Note this value 4D 5/ Compare the values: All values generated with the -t options should be equals. Same for values without the -t options. => 2A == 4A == 4C and 2B == 4B == 4D 6/ Go back to a normal activity for 3 days or manually change the date_due for issues in the DB: mysql> update issues SET date_due = DATE_SUB(date_due, INTERVAL 3 DAY); Do again step 4C and 4D with a date equals to today - 3 days. Values should be the same as 4C and 4D. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 15:51:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 14:51:53 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #10 from Jonathan Druart --- Created attachment 34953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34953&action=edit script to populate the DB I use this simple script to insert overdues in the DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 15:53:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 14:53:48 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #11 from Jonathan Druart --- (In reply to Chris Cormack from comment #8) > I *think* I have reworked this, keeping the functionality, please test. If > not let me know and I will try again. Thank you very much to have resubmitted this patch. I tested it thoroughly and did not find any regression. The --date parameter works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:03:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:03:43 +0000 Subject: [Koha-bugs] [Bug 13515] New: Table messages is missing FK constraints and is never cleaned up Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Bug ID: 13515 Summary: Table messages is missing FK constraints and is never cleaned up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The table messages is used to store notes to the patron (visible in OPAC) and internal notes for circulation. There is no FK on the borrowernumber, so the data in this table is never cleaned up, not even on deleting the patron. There is also no FK on the branchcode, although the comments state otherwise. 2723 -- Table structure for table `messages` 2724 -- 2725 DROP TABLE IF EXISTS `messages`; 2726 CREATE TABLE `messages` ( -- circulation messages left via the patron's check out screen 2727 `message_id` int(11) NOT NULL auto_increment, -- unique identifier assigned by Koha 2728 `borrowernumber` int(11) NOT NULL, -- foreign key linking this message to the borrowers table 2729 `branchcode` varchar(10) default NULL, -- foreign key linking the message to the branches table 2730 `message_type` varchar(1) NOT NULL, -- whether the message is for the librarians (L) or the patron (B) 2731 `message` text NOT NULL, -- the text of the message 2732 `message_date` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, -- the date and time the message was written 2733 PRIMARY KEY (`message_id`) 2734 ) ENGINE=InnoDB DEFAULT CHARSET=utf8; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:10:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:10:45 +0000 Subject: [Koha-bugs] [Bug 13516] New: Display issue for search results with items both checkout out and lost Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Bug ID: 13516 Summary: Display issue for search results with items both checkout out and lost Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In the staff search results, if an item is both checked out and lost, the result will appears as two item lines like this: http://screencast.com/t/2Hczv1jhL when it should look like this: http://screencast.com/t/JDV2cGNq -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:10:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:10:50 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:14:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:14:22 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:14:24 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 --- Comment #1 from Kyle M Hall --- Created attachment 34954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34954&action=edit Bug 13516 - Tidy relevant code black -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:14:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:14:31 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 --- Comment #2 from Kyle M Hall --- Created attachment 34955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34955&action=edit Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:18:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:18:13 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:18:46 +0000 Subject: [Koha-bugs] [Bug 4998] OPAC Browse by Hierarchy fails badly, links to old Koha Wiki In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4998 --- Comment #2 from Marc V?ron --- Still valid on current master (3.19.00.005) I think the warning message should be re-worded in Opac and there should be a more technical error message in Staff client (About Koha: System Information). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:20:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:20:22 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34954|0 |1 is obsolete| | Attachment #34955|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34956&action=edit Bug 13516 - Tidy relevant code block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:20:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:20:29 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 --- Comment #4 from Kyle M Hall --- Created attachment 34957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34957&action=edit Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:44:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:44:09 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #1 from Marc V?ron --- Confirmed. With both Sysprefs AnonSuggestions and suggestion turned off, I was redirected to the login page and after login the page "Your purchase suggestions" displayed. I could even put a suggestion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:54:05 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #2 from Marc V?ron --- Pattern for solution in Bug 10595 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:54:12 +0000 Subject: [Koha-bugs] [Bug 13517] New: Show waiting date on reserve/request.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Bug ID: 13517 Summary: Show waiting date on reserve/request.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:54:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:54:17 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:57:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:57:10 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:57:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:57:13 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #1 from Kyle M Hall --- Created attachment 34958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34958&action=edit Bug 13517 - Tidy request.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 16:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 15:57:25 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #2 from Kyle M Hall --- Created attachment 34959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34959&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl Test Plan: 1) Apply this patch 2) Find a waiting hold 3) Browse to reserve/request.pl for that record 4) Notice the "Item waiting" message now has "since " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 17:01:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 16:01:55 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #3 from Marc V?ron --- Maybe something for the Catalyst Open Source Academy... (Starting today) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 17:04:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 16:04:29 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #66 from Jonathan Druart --- Created attachment 34960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34960&action=edit Bug 13068: Raise an error if a pl script has a sql error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 17:05:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 16:05:09 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #67 from Jonathan Druart --- (In reply to M. de Rooy from comment #65) > I agree that we ideally should not. But how should we catch this in a simple > and elegant way? What about the last patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 17:28:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 16:28:27 +0000 Subject: [Koha-bugs] [Bug 13518] New: Table borrower_modifications is missing FK and not deleted with the patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Bug ID: 13518 Summary: Table borrower_modifications is missing FK and not deleted with the patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The table borrower_modifications has no FK constraint on the borrowernumber and will remain untouched when the patron is deleted. If the borrowernumber doesn't exist in the database, the modification entry is no longer visible in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 17:35:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 16:35:12 +0000 Subject: [Koha-bugs] [Bug 6981] barcode not incrementing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6981 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Marc V?ron --- Could no longer reproduce the issue on current master 3.19.00.005 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 17:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 16:47:47 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #3 from Marc V?ron --- Maybe something for the Catalyst academy (starting today) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 18:10:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 17:10:22 +0000 Subject: [Koha-bugs] [Bug 1356] Lose original search term when select "More options" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1356 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13307 --- Comment #3 from Marc V?ron --- Bug 13307 creates links that populate the fields in Advanced search using jQuery. Maybe a solution could be based on the same mechanism. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 18:10:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 17:10:22 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=1356 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 18:33:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 17:33:12 +0000 Subject: [Koha-bugs] [Bug 13519] New: alternate email address not showing on patron record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13519 Bug ID: 13519 Summary: alternate email address not showing on patron record Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 34961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34961&action=edit display wrong of email addreses The patrons has a primary email address and an email address under alternate contact but the only email address showing on the patron record is the primary email address 2 times. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 19:06:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 18:06:52 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- You didn't change the status, and I can't successfully repeat your suggested test plan. $ git reset --hard origin/master $ git blame -w C4/Auth.pm | cut -f1 -d' ' > ~/before.txt $ git bz apply 13499 ... $ git blame -w C4/Auth.pm | cut -f1 -d' '> ~/after.txt $ diff ~/before.txt ~/after.txt | less At this point there is a highly repetitive number, let's say a734e040, which corresponds to your applied patch. $ diff ~/before.txt ~/after.txt | grep "[\<\>]" | cut -f2 -d' ' | grep -v a734e040 7535f2bf 493dcede 06d19958 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 19:53:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 18:53:19 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Martin Renvoize --- Hmmm, your right.. though it's still non-descructive in that all blames related to my tidy appear to simply be the addition of some blank lines to space the code out a little better. You advice here would be apreciated Mark, would you prefer an updated test plan, i.e. Before patch git blame -w Auth.pm > orig.blame After patch git blame -w Auth.pm > new.blame A diff (I tend to use vimdiff so I can understand what it's telling me) between orig.blame and new.blame should show the addition of a number of additional blank lines atributed to the tidy commit, and a number of whitespace changes on other lines but those changes should still be attributed to their original authors. I can attempt to prevent even these blank lines during the tidy, but I feel this would negate at least some of the point of doing such a tidy to aid in readability. Let me know your thoughts, and thanks for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 20:45:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 19:45:17 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 --- Comment #4 from M. Tompsett --- (In reply to Martin Renvoize from comment #3) > Let me know your thoughts, and thanks for testing $ git reset --hard origin/master $ cp C4/Auth.pm ~/before.txt $ git bz apply 13499 ... $ cp C4/Auth.pm ~/after.txt $ diff -w ~/before.txt ~/after.txt ... Adding and removing blank lines shown, so I don't have a problem EXCEPT... you made one code correction on line 669 by removing an extra and out of place semicolon. I don't mind signing off, BUT... I really feel the semicolon fix should be in a patch by itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:05:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:05:14 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:05:17 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34952|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 34962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34962&action=edit [PASSED QA] Bug 11120: FIX the --date option for overdue_notices cronjob Bug 7447 introduces the --date option for overdue notices. This option has never worked: the code is waiting for a value but the option is defined as a boolean. This patch fixes the option and change the way to calculate the range of dates. This range is now managed in Perl instead of in the SQL query. To do it in Perl allows to build dates simply using the DateTime and DateTime::Duration modules. To test this patch you should have a DB with a lot of overdues, (I tested on a DB with 512 overdues). A test plan could be: 1/ Dump your message_queue table 2/ Verify the number of overdues in the database before applying the patch: mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v -t (the triggered option will generate overdue for today) mysql> SELECT COUNT(*) FROM message_queue; Note this value 2A mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v mysql> SELECT COUNT(*) FROM message_queue; Note this value 2B 2/ Apply the patch 4/ Verify the number of overdues generated by the patched script: mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v -t mysql> SELECT COUNT(*) FROM message_queue; Note this value 4A mysql> DELETE FROM message_queue; perl misc/cronjobs/overdue_notices.pl -v mysql> SELECT COUNT(*) FROM message_queue; Note this value 4B mysql> DELETE FROM message_queue; # The date should be defined depending your dateformat preference # and should be the date of the current day perl misc/cronjobs/overdue_notices.pl -v -t --date="YYYY-MM-DD" mysql> SELECT COUNT(*) FROM message_queue; Note this value 4C mysql> DELETE FROM message_queue; # The date should be defined depending your dateformat preference # and should be the date of the current day perl misc/cronjobs/overdue_notices.pl -v --date="YYYY-MM-DD" mysql> SELECT COUNT(*) FROM message_queue; Note this value 4D 5/ Compare the values: All values generated with the -t options should be equals. Same for values without the -t options. => 2A == 4A == 4C and 2B == 4B == 4D 6/ Go back to a normal activity for 3 days or manually change the date_due for issues in the DB: mysql> update issues SET date_due = DATE_SUB(date_due, INTERVAL 3 DAY); Do again step 4C and 4D with a date equals to today - 3 days. Values should be the same as 4C and 4D. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Tested with my own test data, checked generating overdues with and without the --date option. All worked as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:08:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:08:09 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #13 from Katrin Fischer --- Created attachment 34963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34963&action=edit Bug 11120: Follow-up: adding a hint about the date format Adding 2 hints about the expected date format to the error message and the help. To test: - Run overdue_notices.pl --date - Run overdue_notices.pl -man - Verify hint about date format shows up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:25:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:25:11 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #83 from Katrin Fischer --- When trying to access the basket group page from the aquisition start page: Software error: Undefined subroutine &main::GetBookSeller called at /home/katrin/kohaclone/acqui/basketgroup.pl line 411. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:48:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:48:51 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #10 from Katrin Fischer --- Created attachment 34964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34964&action=edit [PASSED QA] Bug 12970: Use the centralize VAT and prices calculation - basket.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basket.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Go on the basket page 4/ Apply the patch 5/ Verify you don't see any difference before and after applying the patch Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:48:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:48:55 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #11 from Katrin Fischer --- Created attachment 34965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34965&action=edit [PASSED QA] Bug 12970: Format totals The total values should be formated too. Test plan: 1/ Go on the basket page 2/ Using the CurrencyFormat, verify the totals are correctly formated. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:48:58 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #12 from Katrin Fischer --- Created attachment 34966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34966&action=edit [PASSED QA] Bug 12970: Cancelled orders Previous patch does modify the code for cancelled orders. Test plan: Cancel 1+ orders and verify the prices are correct (i.e. the same as the non-cancelled orders) and that the prices are formated. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:49:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:49:01 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #13 from Katrin Fischer --- Created attachment 34967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34967&action=edit [PASSED QA] Bug 12970: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:49:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:49:26 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:49:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:49:30 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33572|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:49:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:49:33 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:49:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:49:35 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:49:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:49:37 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:57:38 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34825|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 34968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34968&action=edit Bug 13499: Tidy of Auth.pm This tidy should only change whitespace and not line breaks, thus retaining history. There are no code changes, and thus there should be no regressions to test for koha wise. To test the non-destrcutive nature of the patch, run a 'git blame -w' on the file before and after the patch. The resulting blame should include a comparabile history of the file, with only some additional blank lines being attributed to this commit. A 'git blame -wM' may also be useful for comparison purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 5 23:58:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 22:58:59 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 --- Comment #6 from Martin Renvoize --- Well spotted, I'de missed the colon change that tidy had also removed. I've removed it from my patch as I agree, such an actualy code change should go in it's own bug. Cheers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:03:38 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Pushed to 3.18.x, will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:09:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:09:00 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:23:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:23:26 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:23:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:23:30 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34933|0 |1 is obsolete| | Attachment #34934|0 |1 is obsolete| | Attachment #34935|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 34969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34969&action=edit [PASSED QA] Bug 12976: Use the centralize VAT and prices calculation - invoice.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:24:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:24:03 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34969|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 34970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34970&action=edit [PASSED QA] Bug 12976: Use the centralize VAT and prices calculation - invoice.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:24:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:24:06 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #17 from Katrin Fischer --- Created attachment 34971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34971&action=edit [PASSED QA] Bug 12976: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:24:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:24:09 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #18 from Katrin Fischer --- Created attachment 34972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34972&action=edit [PASSED QA] Bug 12976: Fix some comment in tests Previous comments were wrong. Actually the main part of price values is correct. Only some rounding and tax values are badly calculated. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:58:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:58:27 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 --- Comment #19 from Katrin Fischer --- I saw improvements with these patches applied - A missing cent showed up, fixing a total that was wrong before. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:59:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:59:04 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:59:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:59:08 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31982|0 |1 is obsolete| | Attachment #33900|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 34973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34973&action=edit [PASSED QA] Bug 13001: Refactor VAT and price calculation - parcel page Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/parcel.pl script. Test plan: 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Go on the parcel page 4/ You should see, on the "pending orders" table, the same prices as before this patch. Note that the prices are now correctly formated. You could see one change for the supplier configuration 3 (1 0): If the cost of the item is 82, discount 10% and vat 5%: The "Order cost" = 140.58 instead of 140.57. Indeed, before this patch, the order cost was wrong, now you should have 70.29*2 = 140.58 ( before: 140.58 + 7.03 = 147.61 now: 140.58 + 7.02 = 147.60 ) 5/ Receive the items and return on the parcel page Now the "Already received" table with the same prices as before this patch. Note some differences too: - There was a td tag missing, the table was badly formated, it's now fixed (column below the "Cancel receipt" link). - The prices are now correctly formated. - For the configuration 2 (1 1), if the cost of the item is 82, discount 10% and vat 5%: ( before: 140.57 + 7.03 = 147.60 now: 140.58 + 7.02 = 147.60 ) Note that 7.03 is the "correct" value, but on all other pages, 7.02 is displayed. To be consistent, we should display the same prices everywhere. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 00:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Jan 2015 23:59:28 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 --- Comment #21 from Katrin Fischer --- Created attachment 34974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34974&action=edit [PASSED QA] Bug 13001: The total for received order should be based on the unitprice For already received orders, the total should be calculated with the unitprice, not the estimated cost. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 01:06:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 00:06:42 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 01:07:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 00:07:05 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 01:08:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 00:08:36 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 01:08:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 00:08:53 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 01:38:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 00:38:04 +0000 Subject: [Koha-bugs] [Bug 13520] New: add rental to circ matrix Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13520 Bug ID: 13520 Summary: add rental to circ matrix Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries want to charge rental charges based on patron category but right now it's based on item type only. It would be nice if rental charge was in the circ matrix and then you don't need the rental charge discount on the circ matrix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 02:21:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 01:21:46 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- Hi Julian, I feel like this would have been a bit better split up into 2 separate bugs/features. Tried a few things and have some first feedback from code review and tests: Bug 13392: Add suggestions.ordereddate and suggestions.orderedby 1) I am not sure about adding ordereddate and orderedby as those seem duplicating the information we can get from aqorders.entrydate and aqbasket.authorisedby. Bug 13392: New statistics assistant for suggestions 1) The new tests don't give any information when run, please add a description. 2) Using the Koha:I18N is an option now, but I think we haven't created the po file that is needed for it yet. Those strings appear already multiple times in the templates, so the translators have to make sure to translate them the same as everywhere else. I feel it might be easier if we moved them to the template. But more important, the custom suggestion statuses are not supported by the new wizard (authorized value SUGGEST_STATUS) 3) For MARC21 the publicationyear is saved in the copyrightdate column in the database. Please change so that copyrightdate is used in the SQL query for MARC21 databases. 4) The bsort1 and bsort2 fields can be freetext if there are no entries in the authorised value categories - maybe show an input field in that case? 5) Please rename branch to library on the suggestion form. And maybe just "Reason" instead of "Reject reason"? The reasons can also be positive. In testing this I had difficulties with getting a suggestion into the ORDERED status with and without the patches - can you check if that works for you? The new database fields stayed empty too :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 07:09:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 06:09:03 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 --- Comment #7 from M. Tompsett --- And while I am noticing semicolon bugs, (In reply to Martin Renvoize from comment #6) > I've removed it from my patch as I agree, such an actualy code change should > go in it's own bug. Another semi-colon bug while looking through the code: line 353 is missing a semicolon. Did you make a bug report for the semi-colon bugs yet? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 07:35:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 06:35:30 +0000 Subject: [Koha-bugs] [Bug 12548] Auth::checkauth() needs more in-line comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13521 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 07:35:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 06:35:30 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13521 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 07:35:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 06:35:30 +0000 Subject: [Koha-bugs] [Bug 13521] New: Auth.pm code issues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Bug ID: 13521 Summary: Auth.pm code issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org, mtompset at hotmail.com Depends on: 13499 Blocks: 12548, 12954, 13503 Whilst working on bug #13499 a number of minor code issues were highlighted by perltidy. I'll collect patches in here to fix various issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 07:35:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 06:35:30 +0000 Subject: [Koha-bugs] [Bug 13503] Auth.pm needs tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13521 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 07:35:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 06:35:30 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13521 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 07:38:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 06:38:29 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 --- Comment #8 from Martin Renvoize --- I've now opened a bug (13521) to record code issues, but haven't yet submitted a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 07:57:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 06:57:28 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #1 from Martin Renvoize --- Created attachment 34975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34975&action=edit Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 07:57:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 06:57:30 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #2 from Martin Renvoize --- Created attachment 34976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34976&action=edit Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 08:01:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 07:01:03 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 --- Comment #9 from Martin Renvoize --- Now added two tiny patches to the new bug for those semicolon issues you spotted. I'm very impressed you spotted them, nice fine tooth comb aproach :). I intend to add a whole swatch of inline documentation to this script over the next few weeks to aid those attempting to work within it, and then hopefully improve the unit test coverage and clean out superflous code as I'm sure there are unreachable code blocks buried within but at present I can't prove it. Cheers again for looking at this first stage :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 08:14:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 07:14:29 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #3 from Martin Renvoize --- I believe that's all the semicolin issues caught now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 08:14:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 07:14:35 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 08:33:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 07:33:42 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #65 from Martin Renvoize --- So... I'm a tad confused, are we back at a point where I can test these patches for signoff..? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 09:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 08:15:44 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #14 from Jonathan Druart --- Comment on attachment 34963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34963 Bug 11120: Follow-up: adding a hint about the date format Review of attachment 34963: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11120&attachment=34963) ----------------------------------------------------------------- ::: misc/cronjobs/overdue_notices.pl @@ +364,4 @@ > eval { > $date_to_run = dt_from_string( $date_input ); > }; > + die "$date_input is not a valid date, aborting! Use a date in format YYYY-MM-DD." No, this is wrong. The format depends on the dateformat pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 09:28:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 08:28:49 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #84 from Jonathan Druart --- Created attachment 34977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34977&action=edit Bug 11708: Fix bad resolution conflict with bug 12896 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 09:29:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 08:29:04 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 11:50:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 10:50:47 +0000 Subject: [Koha-bugs] [Bug 13522] New: tools/viewlog.pl does not compile in older perls Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Bug ID: 13522 Summary: tools/viewlog.pl does not compile in older perls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Attempting to view logs on a system with a perl older than 5.12 gives the following compile time error: Type of arg 1 to keys must be hash (not array element) at viewlog.pl line 214, near "];" Prior to 5.12 keys could only be called on a hash sites using 5.10 cannot use viewlog as a result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 11:59:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 10:59:49 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- Well, we can just throw out the second patch, but I am confused. I definitely tested with YYYY-MM-DD as I had been looking for examples in the bug report. And it worked, although my preference is set to mm/dd/yyyy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 12:00:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 11:00:02 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34963|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 12:36:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 11:36:52 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 12:37:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 11:37:19 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #6 from Martin Renvoize --- David, as the current zebra guru, any chance you could give these patches a glance over? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 12:46:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 11:46:16 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #233 from Katrin Fischer --- I recently worked on database documentation for 3.18 and noticed that we now have a table misc_files in the database which currently stores scanned invoices from the acquisition module (bug 3050) If I saw it correctly, this patch set will add a table 'uploaded_files'. It looks to me like the new table was thought up to store different kinds of files. Not sure if a merge of both features would make sense, but it might be worth investigating in order to avoid having various ways of achieving similar things. We also choose to keep things separate for reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 12:51:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 11:51:53 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 34978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34978&action=edit Proposed patch To test. you need a perl version prior to 5.12 without the patch perl -wc tools/viewlog.pl gives the syntax error from the bug description and fails to compile wit the patch applied it should compile correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 12:53:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 11:53:03 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #234 from Katrin Fischer --- We _might_ also choose... I see now that one main difference is that we upload files to the file system here while misc_files seems to store the files directly in the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 12:58:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 11:58:03 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > Well, we can just throw out the second patch, but I am confused. I > definitely tested with YYYY-MM-DD as I had been looking for examples in the > bug report. And it worked, although my preference is set to mm/dd/yyyy. Yes you are right, it works too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 12:58:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 11:58:59 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #17 from Jonathan Druart --- Comment on attachment 34962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34962 [PASSED QA] Bug 11120: FIX the --date option for overdue_notices cronjob Review of attachment 34962: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11120&attachment=34962) ----------------------------------------------------------------- ::: misc/cronjobs/overdue_notices.pl @@ +359,5 @@ > } > my $date_to_run; > +my $date; > +if ( $date_input ){ > + $date = $dbh->quote($date); Should be $date = $dbh->quote($date_input); Isn't it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 13:09:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 12:09:58 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11317 CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 13:09:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 12:09:58 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6874 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 13:21:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 12:21:18 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #18 from Katrin Fischer --- I think you are right - it's used in the SQL script - but not sure what for? SELECT biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue, ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 13:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 12:24:40 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #61 from Katrin Fischer --- Looking at critical bugs I noticed this one - does the problem still exist and can we get the patch back into the queue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 13:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 12:25:14 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #65 from Martin Renvoize --- I can also confirm this is working well at the koha side, and that although the coce daemon itself presents that error mentioned by Jonathan periodically it doesn't appear to affect it's overall running. Would be nice to see this one making it's way though :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 13:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 12:55:24 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 13:57:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 12:57:13 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #62 from Sophie MEYNIEUX --- As I said in comment #59 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030#c59), this bug was splitted in many small one. It seems that all attached bugs are pushed except Bug 11173 (that won't apparently). So I think it could be closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 13:58:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 12:58:57 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |MOVED --- Comment #63 from Katrin Fischer --- Hi Sophie, thx for clarifying! I am closing this then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 13:58:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 12:58:58 +0000 Subject: [Koha-bugs] [Bug 5992] Biblibre various improvements for 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5992 Bug 5992 depends on bug 6030, which changed state. Bug 6030 Summary: Allow for html in letters in overdue notices http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:04:53 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #235 from Katrin Fischer --- Looked at the database some more and we got lots of tables where we store files - but no feature yet where we store the files outside the database as far as I can tell. So I think the idea of merging with misc_files is irrelevant - please don't let me keep you from signing off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:09:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:09:15 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:26:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:26:13 +0000 Subject: [Koha-bugs] [Bug 5597] holds to pull showing wrong item for item specific holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5597 --- Comment #7 from Katrin Fischer --- Is this still valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:32:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:32:37 +0000 Subject: [Koha-bugs] [Bug 5597] holds to pull showing wrong item for item specific holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5597 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer --- I tested this according to Nicole's video - the correct information is showing up in the holds queue report. Marking this WORKSFORME. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:35:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:35:39 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Component|Architecture, internals, |Authentication |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:41:24 +0000 Subject: [Koha-bugs] [Bug 11153] patron without fines permissions can forgive on check in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11153 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- This is fixed in current versions: [% IF ( CAN_user_updatecharges_writeoff && overduecharges ) %] overduecharges = Finesmode is not 'off' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:48:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:48:03 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #19 from Jonathan Druart --- Created attachment 34979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34979&action=edit Bug 11120: Follow-up: adding a hint about the date format Adding 2 hints about the expected date format to the error message and the help. To test: - Run overdue_notices.pl --date - Run overdue_notices.pl -man - Verify hint about date format shows up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:48:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:48:08 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #20 from Jonathan Druart --- Created attachment 34980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34980&action=edit Bug 11120: the date input should be in a iso format (YYYY-MM-DD) Note that it cans also accept a date in the same format defined in the dateformat system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:48:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:48:12 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #21 from Jonathan Druart --- Created attachment 34981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34981&action=edit Bug 11120: Should this test fail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:50:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:50:25 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #22 from Jonathan Druart --- About the last 3 patches: 1/ I reintroduced the Katrin's patch 2/ Try to force the date input format to 'iso' 3/ To me the test should not fail, but I don't have the time at the moment to deep into the DateUtils code. Any idea? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:55:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:55:18 +0000 Subject: [Koha-bugs] [Bug 7602] Spent and Ordered pages require full acquisition permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Katrin Fischer --- We could be more strict like only showing the link to the invoice if the user has the corresponding permission, but I will move this idea to a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 14:55:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 13:55:19 +0000 Subject: [Koha-bugs] [Bug 929] See details of a budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929 Bug 929 depends on bug 7602, which changed state. Bug 7602 Summary: Spent and Ordered pages require full acquisition permissions http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:03:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:03:30 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34284|0 |1 is obsolete| | --- Comment #3 from Colin Campbell --- Created attachment 34982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34982&action=edit Patch Signed Off Timeout invoked correctly in testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:03:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:03:55 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:06:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:06:00 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #8 from Martin Renvoize --- This could be a good one for the catalyst academy to extend upon :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:06:12 +0000 Subject: [Koha-bugs] [Bug 7602] Spent and Ordered pages require full acquisition permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7602 --- Comment #13 from Katrin Fischer --- After looking at the pages: The only links on the ordered page are to the vendor and to the invoice page - both are accessible with * (any acq permission). So I think there are no more changes needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:15:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:15:07 +0000 Subject: [Koha-bugs] [Bug 13523] New: AddBiblio fails on mysql with STRICT_TRANS_TABLES Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Bug ID: 13523 Summary: AddBiblio fails on mysql with STRICT_TRANS_TABLES Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: benjamin.rokseth at kul.oslo.kommune.no QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Adding a biblio either via /svc endpoint or via Cataloguing interface fails on mysql versions > 5.3.21 because of a change in the default settings in GLOBAL.sql_mode to add STRICT_TRANS_TABLES. when adding a biblio in Cataloguing or via /svc API: --- Software error: Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 683. --- Doing this manually in SQL results in: --- ERROR 1364 (HY000): Field 'marcxml' doesn't have a default value --- This is probably a change that will live (Mysql becomes stricter in v5.7) and is purposefully added to better handle syntax checks in the SQL. bugs #10732, #5366 and #10215 all relate to the same but do not propose a fix. This particular bug proposes to fix the particular issue with adding biblios, either by 1) changing the database schema to NOT set field `marcxml` to NOT NULL (field `marc` in the same table is NULLABLE) 2) changing the AddBiblio code in Biblio.pm so it doesn't require multiple INSERT statements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:24:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:24:35 +0000 Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Maybe this would be a good one to clean up for the academy too. As far I can see there are 4 files linking to the modification logs: koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc 33 [% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • [% END %] koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc 77 [% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt 77 [% IF ( CAN_user_parameters ) %][% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • [% END %] koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc 13 [% IF ( logview ) %]
  • [% ELSE %]
  • [% END %]Modification log
    • Only the first seems to be using the correct permission check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:35:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:35:04 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #34 from Martin Renvoize --- Hmm.. not sure why this got marked 'In Discussion', setting back to 'Needs Signoff' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:35:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:35:40 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #73 from Jonathan Druart --- (In reply to David Cook from comment #66) > tl;dr > > Kyle, if you rebase and fix the line that removes the XSLT syspref, I'd be > happy to test this. Kyle, this patch looks very easy to unblock. I tried to apply it to submit a follow-up, but the patch does not apply: fatal: sha1 information is lacking or useless (C4/Reserves.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:37:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:37:02 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31547|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Comment on attachment 31547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31547 [SIGNED-OFF] Bug 12904 - Force browser to load new javascript files after upgrade Obsoleting the original patch to make applying the current series easier... I would still like to hear others thoughts on this alternative approach however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:39:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:39:36 +0000 Subject: [Koha-bugs] [Bug 13524] New: stats not recording item type when returned Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13524 Bug ID: 13524 Summary: stats not recording item type when returned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: kyle at bywatersolutions.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The stats table is only recording item type when an item is checked out or renewed - not returned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:44:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:44:52 +0000 Subject: [Koha-bugs] [Bug 4527] Item details don't respect newlines in details data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- The TT filter looks promising - maybe worth having another go at this? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:46:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:46:53 +0000 Subject: [Koha-bugs] [Bug 13524] stats not recording item type when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Could this be a duplicate to bug 9351? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:52:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:52:16 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:52:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:52:19 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28657|0 |1 is obsolete| | Attachment #28659|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 34983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34983&action=edit Bug 5144 [1] - Unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:52:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:52:25 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #9 from Kyle M Hall --- Created attachment 34984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34984&action=edit Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:52:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:52:28 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #10 from Kyle M Hall --- Created attachment 34985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34985&action=edit Bug 5144 [3] - Add message for patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 15:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 14:56:22 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #3 from Katrin Fischer --- Still valid... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 16:01:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 15:01:02 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #38 from Owen Leonard --- I'm looking at this now for the first time, so my comments may come to late. But I think this isn't an improvement from a usability point of view. Combining each of the separate vendor tables into one makes the page much more difficult to scan. Are we trying to do too much on this page? Should we be focusing instead on adding filtering or advanced searching options to the order search page? I think it would be good to talk about what the expected workflow is here. I don't use acquisitions in production so I don't work with real data when I'm testing. I probably make incorrect assumptions about how people do things. The page seems to offer several end points: 1. Finding a vendor so you can view the details of that vendor 2. Showing a list of open baskets so that you can view one 3. Showing a list of open baskets so that you can add to one 4. Showing a list of basket groups so that you can view one If that's correct, then adding filtering should improve the ease of reaching one of those goals: 1. Finding a vendor -- I assume this isn't really a priority because we reach this page *from* a vendor search. 2. & 3. Finding a basket. Do we need to filter by basket information because we know the basket information but not the vendor? If we assume that we know the vendor and want to find a basket then we should keep the view which keeps each vendor in a separate table. If we assume that we're searching by basket information but *don't* know the vendor then we need to filter across all baskets. 4. Finding a basket group -- same questions as with 2. & 3. Can we assume that the vendor is known, or is it the case that sometimes only the basket group information is known? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 16:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 15:30:31 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34983|0 |1 is obsolete| | Attachment #34984|0 |1 is obsolete| | Attachment #34985|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 34986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34986&action=edit Bug 5144 [1] - Unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 16:30:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 15:30:37 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #12 from Kyle M Hall --- Created attachment 34987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34987&action=edit Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 16:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 15:30:40 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #13 from Kyle M Hall --- Created attachment 34988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34988&action=edit Bug 5144 [3] - Add message for patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 16:40:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 15:40:08 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 16:40:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 15:40:11 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #4 from Katrin Fischer --- Created attachment 34989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34989&action=edit Bug 4402: Date filter on parcels.tt required db date format The date filters on the parcel page would only work with dates formatted YYYY-MM-DD. To test: - Select a vendor, that already has a few invoices - "Receive shipment" - you are on the parcels page - Use the From and To filters on the left, notice there is now a date picker on those fields - Verify the search works correctly for different date formats -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 16:40:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 15:40:30 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 16:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 15:42:03 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #5 from Katrin Fischer --- Not sure about the date handling - probably should have been using Koha::DateUtils? Feedback appreciated. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 17:06:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 16:06:22 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Owen Leonard --- This fails in one particular situation: 1. Search for items while not logged in. 2. From the search results page, select multiple titles, at least one (but not all) of which you already have on hold. 3. Click the "place hold" button to place multiple holds at once. 4. Log in when prompted. This process will redirect you to opac-user.pl with the "holds were not placed" message without giving you the opportunity to place a hold on the titles which you didn't have on hold. I think we could be clearer than "One or more holds were not placed due to existing holds." "Due to existing holds" could mean "because of duplicates," or it could mean "because you have too many existing holds." Maybe: "One or more holds were not placed because you already have a hold on that title." -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 17:31:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 16:31:21 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should use C4/Auth.pm for user authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 --- Comment #1 from Colin Campbell --- For login authentication it calls C4/Auth check_api_auth ( so the fact it checks the password in the config file is a bit redundant) For patron status it checks against the db if a password is sent or will accept ''. For patron information the password is not a required field. The sip logic is that the borrower barcode is the patron's token allowing them to request to borrow books. A quick look at the checkpw routines in Auth suggests that they are doing more than testing the validity of the password as they are setting up parameters for a user session and I think we'd need a simpler 'is_this_password_valid' interface to Auth, but that could easily replace the call currently in ILS/Patron.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 17:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 16:33:11 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #6 from Marc V?ron --- Created attachment 34990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34990&action=edit [Signed-off] Bug 4402: Date filter on parcels.tt required db date format The date filters on the parcel page would only work with dates formatted YYYY-MM-DD. To test: - Select a vendor, that already has a few invoices - "Receive shipment" - you are on the parcels page - Use the From and To filters on the left, notice there is now a date picker on those fields - Verify the search works correctly for different date formats Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 17:33:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 16:33:28 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:22:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:22:53 +0000 Subject: [Koha-bugs] [Bug 4814] Item Type (MARC952 $c) not self-populating from imported OCLC bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4814 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All CC| |katrin.fischer at bsz-bw.de OS|Linux |All --- Comment #3 from Katrin Fischer --- I think we need more information on this and maybe an example record. What Koha does is that it suggests the itemtype from 942$c in the bib record as the item type for the item (952$y). The 942$c will only be populated on import, if it is in the imported record and contains a valid itemtype code that exists in Koha. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:25:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:25:15 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #11 from rgravel at marlboro.edu --- David, these suggested changes arose out of a project a colleague and I did at Marlboro College. We looked at how records are currently displaying, thought of ways to improve the display, particularly with an eye toward incorporating some RDA concepts like showing relationships, and asked ByWater whether the updates were possible. We then spoke with Nicole and she had the great idea of bridging the work we were doing with the larger Koha community, and so these bugs were created to flush out our ideas and get feedback. Regarding the vertical bar, we thought that might be a good choice for separating contributor listings because it parallels what is used to separate multiple subject headings and it provides a very clear visual clue that there are multiple, distinct bibliographic data points. We also suggested this solution for the 246 listings (see Bug 13386). A semi-colon is currently used to separate all the 700s lumped into the "By" field and varying titles under "Other Title," which I think makes reading and interpreting the record more challenging since it doesn't break up the bits very well visually. To address Winona's questions: 1) I would also support having the "Related Works" and "Contained Works" display after "Other Title." 2) If I understand this correctly, then I don't think there is a conflict, since a second indicator of 2 means it is a *contained work* and the appearance of a subfield $i means it is a *related work.* So, in the example you provided where there is a subfield $i, I would not code the second indicator as 2 to begin with, because the book is not contained in the DVD, but is rather a separate work related to the DVD; it cannot be both contained and related. But maybe others see this differently? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:25:39 +0000 Subject: [Koha-bugs] [Bug 5270] 007 variable control builder/Specific Material Designation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Tested this on current master and it works correctly. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:27:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:27:39 +0000 Subject: [Koha-bugs] [Bug 5388] Circulation of related/requiring items (like Book and CD sets) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5388 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.4 |master --- Comment #1 from Katrin Fischer --- This is still valid. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:29:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:29:16 +0000 Subject: [Koha-bugs] [Bug 5362] Simple (non-MARC) cataloging interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:37:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:37:58 +0000 Subject: [Koha-bugs] [Bug 6876] oai-pmh ListMetadataFormats marcxml definition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master Component|Tools |Web services CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I can confirm, that Koha still lists 2 URLs each in the response to ListMetadataFormats: http://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim.xsdhttp://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:38:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:38:51 +0000 Subject: [Koha-bugs] [Bug 5850] Should be able to define itypes or collection codes that generate "special handling" slip in SIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:45:06 +0000 Subject: [Koha-bugs] [Bug 5842] Cross-Reference links to authorized fields give incomplete search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Marking resolved fixed as of Jared's comment#4 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:46:50 +0000 Subject: [Koha-bugs] [Bug 5302] Replace current call number splitting code with a plug-in system based on classification source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5302 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.4 |master --- Comment #2 from Katrin Fischer --- Not sure about the state of this? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:47:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:47:10 +0000 Subject: [Koha-bugs] [Bug 4229] Need feature to view Label/Card batches from all branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:48:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:48:07 +0000 Subject: [Koha-bugs] [Bug 4454] Store Expirydate In Subscription In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:50:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:50:11 +0000 Subject: [Koha-bugs] [Bug 5348] currency handling & display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I am closing this RESOLVED MOVED as it seems to fit with the work Jonathan has done on Koha::Number:Price. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:50:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:50:11 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 5348, which changed state. Bug 5348 Summary: currency handling & display http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5348 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:53:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:53:10 +0000 Subject: [Koha-bugs] [Bug 4324] Let's tangoify Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:55:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:55:05 +0000 Subject: [Koha-bugs] [Bug 4892] Make the accounts page page, so that the list of records doesn't end up being huge. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|ASSIGNED |RESOLVED Version|3.4 |master --- Comment #8 from Katrin Fischer --- The account tab now is a datatable with paging and filters. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 18:56:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 17:56:12 +0000 Subject: [Koha-bugs] [Bug 7155] Claims Notice for Serials - No option for Issue Number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7155 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:03:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:03:11 +0000 Subject: [Koha-bugs] [Bug 6676] Acquisition basket access control trivially by-passable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Katrin Fischer --- Bug appears no longer valid on master. Without the order_manage and order_manage_all permissions the vendor search shows only the vendor names, no options to create or access baskets. Trying to reach a basket directly via URL fails - a login page is presented. Without oder_manage_all and AcqViewBaskets set to "created or managed by staff member" an error message is shown when trying to access another person's basket: You are not authorised to manage this basket. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:04:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:04:17 +0000 Subject: [Koha-bugs] [Bug 5851] SIP Slips printed in wrong circumstances -- Local hold and no hold items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5851 --- Comment #2 from Katrin Fischer --- Liz, can you tell if this is still valid for master? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:06:12 +0000 Subject: [Koha-bugs] [Bug 6798] Make koha-create send email with details of created site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6798 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:07:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:07:04 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #78 from Zeno Tajoli --- Hi, I'm testing on a Debian stable (Wheezy) with perl 5.14.2. Laste version of ft/bug_11944. All modules present and updated. With the code now in 'Need Signoff', no problem. If I insert by hand the changes of comment 73 and 77 I don't pass the test. The result is: search_utf8.t .. 19/64 # Failed test at search_utf8.t line 250. Wide character in print at /usr/local/share/perl/5.14.2/Test/Builder.pm line 1826. # 'Koha ??? Catalog ??? Results of search for 'kw,wrdl: ????????????????????'CirculationPatronsSearchCartMore ListsCatalogingAcquisitionsAuthoritiesSerialsReportsToolsAdministrationAbout Koha koha | NO LIBRARY SET Set libraryLog outHelpYour cart is empty.Enter patron card number or partial name: Scan a barcode to check in: Enter search keywords: Check outCheck inSearch the catalogHome ??? Catalog ??? Search for 'kw,wrdl: ????????????????????' No results found No results match your search for 'kw,wrdl: ????????????????????'. ' # doesn't match '(?^u:Publisher: ??????????)' # Failed test 'Base is like "(?^u:q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"' # at search_utf8.t line 254. # got: "http://192.168.216.128:8080/cgi-bin/koha/catalogue"... # length: 203 # doesn't match '(?^u:q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)' # Failed test 'UTF-8 chars are correctly present. Good' # at search_utf8.t line 257. search_utf8.t .. 26/64 http://192.168.216.128/cgi-bin/koha/opac-search.pl?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 at search_utf8.t line 279. search_utf8.t .. 49/64 # Failed test at search_utf8.t line 240. Wide character in print at /usr/local/share/perl/5.14.2/Test/Builder.pm line 1826. # 'Koha ??? Catalog ??? Results of search for 'kw,wrdl: T????mas'CirculationPatronsSearchCartMore ListsCatalogingAcquisitionsAuthoritiesSerialsReportsToolsAdministrationAbout Koha koha | NO LIBRARY SET Set libraryLog outHelpYour cart is empty.Enter patron card number or partial name: Scan a barcode to check in: Enter search keywords: Check outCheck inSearch the catalogHome ??? Catalog ??? Search for 'kw,wrdl: T????mas' No results found No results match your search for 'kw,wrdl: T????mas'. ' # doesn't match '(?^u:Publisher: Ram??n)' search_utf8.t .. 51/64 # Failed test at search_utf8.t line 250. Wide character in print at /usr/local/share/perl/5.14.2/Test/Builder.pm line 1826. # 'Koha ??? Catalog ??? Results of search for 'kw,wrdl: Ram????n'CirculationPatronsSearchCartMore ListsCatalogingAcquisitionsAuthoritiesSerialsReportsToolsAdministrationAbout Koha koha | NO LIBRARY SET Set libraryLog outHelpYour cart is empty.Enter patron card number or partial name: Scan a barcode to check in: Enter search keywords: Check outCheck inSearch the catalogHome ??? Catalog ??? Search for 'kw,wrdl: Ram????n' No results found No results match your search for 'kw,wrdl: Ram????n'. ' # doesn't match '(?^u:Publisher: Ram??n)' # Failed test 'Base is like "(?^u:q=Ram%C3%B2n)"' # at search_utf8.t line 254. # got: "http://192.168.216.128:8080/cgi-bin/koha/catalogue"... # length: 159 # doesn't match '(?^u:q=Ram%C3%B2n)' # Failed test 'UTF-8 chars are correctly present. Good' # at search_utf8.t line 257. search_utf8.t .. 58/64 http://192.168.216.128/cgi-bin/koha/opac-search.pl?idx=&q=Ram%C3%B2n at search_utf8.t line 279. search_utf8.t .. 64/64 # Looks like you failed 7 tests of 64. search_utf8.t .. Dubious, test returned 7 (wstat 1792, 0x700) Failed 7/64 subtests Test Summary Report ------------------- search_utf8.t (Wstat: 1792 Tests: 64 Failed: 7) Failed tests: 19-20, 22, 49, 51-52, 54 Non-zero exit status: 7 Files=1, Tests=64, 118 wallclock secs ( 0.04 usr 0.02 sys + 2.15 cusr 0.43 csys = 2.64 CPU) Result: FAIL There are changes on Unicode in 5.14/5.18/5.20 Are so huge ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:11:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:11:22 +0000 Subject: [Koha-bugs] [Bug 8285] Show OPAC suppress field (942n) for new basket items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- If you are creating items on order the system preference opachiddenitems can hide the order items and the order record (if there are no other items attached to it) nicely. You can tie it to the department location, a special itemtype, the library or whatever. There is also bug 12743 that will allowto set the opac suppression by default for all ordered records. As there is no way to set opac suppression only for some records during odering, I am leaving this open. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:12:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:12:08 +0000 Subject: [Koha-bugs] [Bug 6416] koha-remove fails when dropping user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Is this still valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:13:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:13:20 +0000 Subject: [Koha-bugs] [Bug 2635] Adding non-digit chars to cost fields in items causes data corruption In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master --- Comment #2 from Katrin Fischer --- Data validation of entry in 'price' fields is currently not done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:19:50 +0000 Subject: [Koha-bugs] [Bug 6481] Koha doesn't have a way to set a preferred language from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6481 --- Comment #3 from Katrin Fischer --- *** Bug 6563 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:19:50 +0000 Subject: [Koha-bugs] [Bug 6563] Default OPAC language not set properly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #10 from Katrin Fischer --- Browser language detection and cookies appear to work correctly right now, but there is still no option to force Koha to another default language than English for fallback. Closing this duplicate of the earlier bug 6481. *** This bug has been marked as a duplicate of bug 6481 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:22:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:22:08 +0000 Subject: [Koha-bugs] [Bug 6946] Import Batches _update_batch_record_counts has inefficient SQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- As we have authority batch import in current versions, I think the proposed improvement is invalid now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:27:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:27:01 +0000 Subject: [Koha-bugs] [Bug 8591] show sum of any outstanding fines for patron on the issue slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8591 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=1232 CC| |katrin.fischer at bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:27:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:27:01 +0000 Subject: [Koha-bugs] [Bug 1232] Add Invoice/Credit/Fines Payed For Day on Issues (Print Page) (Print Slip) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8591 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:28:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:28:24 +0000 Subject: [Koha-bugs] [Bug 8591] show sum of any outstanding fines for patron on the issue slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8591 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 1232 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:28:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:28:24 +0000 Subject: [Koha-bugs] [Bug 1232] Add Invoice/Credit/Fines Payed For Day on Issues (Print Page) (Print Slip) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #7 from Katrin Fischer --- *** Bug 8591 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:28:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:28:45 +0000 Subject: [Koha-bugs] [Bug 12285] Allow easy printing of patron's fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=1232 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:28:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:28:45 +0000 Subject: [Koha-bugs] [Bug 1232] Add Invoice/Credit/Fines Payed For Day on Issues (Print Page) (Print Slip) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12285 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:29:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:29:24 +0000 Subject: [Koha-bugs] [Bug 5302] Replace current call number splitting code with a plug-in system based on classification source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5302 --- Comment #3 from Chris Nighswonger --- This goal would probably be better served by adding a system preference which allowed for the storage of one (or many) custom regex's for splitting. In any case, this feature is still very much needed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:30:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:30:34 +0000 Subject: [Koha-bugs] [Bug 5302] Replace current call number splitting code with a plug-in system based on classification source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5302 --- Comment #4 from Katrin Fischer --- Thx for the update, Chris! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:33:53 +0000 Subject: [Koha-bugs] [Bug 8457] No results found on term/phrase click in scan index results list . In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Linux |All CC| |katrin.fischer at bsz-bw.de Version|3.6 |master --- Comment #7 from Katrin Fischer --- Unfortunately, this is still valid. The search URL is the same, but the preference QueryAutoTruncate changes the behaviour: index term was 'd': .../cgi-bin/koha/catalogue/search.pl?idx=&q="d" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:37:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:37:29 +0000 Subject: [Koha-bugs] [Bug 2280] authorized value for indicators in UNIMARC Framework at field level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #7 from Katrin Fischer --- *** Bug 7149 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:37:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:37:29 +0000 Subject: [Koha-bugs] [Bug 7149] authorized values for indicators don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7149 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 2280 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:38:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:38:13 +0000 Subject: [Koha-bugs] [Bug 2280] authorized value option for indicators doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|authorized value for |authorized value option for |indicators in UNIMARC |indicators doesn't work |Framework at field level | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:38:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:38:36 +0000 Subject: [Koha-bugs] [Bug 9701] Configure default indicator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8380, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2280 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:38:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:38:36 +0000 Subject: [Koha-bugs] [Bug 8380] Can not set indicators to required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9701 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:38:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:38:36 +0000 Subject: [Koha-bugs] [Bug 2280] authorized value option for indicators doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9701 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:38:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:38:58 +0000 Subject: [Koha-bugs] [Bug 8380] Can not set indicators to required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:47:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:47:17 +0000 Subject: [Koha-bugs] [Bug 2280] authorized value option for indicators doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2280 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:53:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:53:46 +0000 Subject: [Koha-bugs] [Bug 8331] hidden field does not hide from plain MARC view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8331 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|hidden field does not work |hidden field does not hide |accurately |from plain MARC view Severity|normal |major CC| |katrin.fischer at bsz-bw.de Version|3.6 |master --- Comment #1 from Katrin Fischer --- In my testing it shows that hiding from the plain MARC view indeed does not work :( To test: - Edit a MARC framework - change 245$a to not display in OPAC and staff - Check the plain MARC view in OPAC and staff - Notice that the field still displays - Notice that it hides correctly from the labelled MARC views -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:54:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:54:55 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:59:31 +0000 Subject: [Koha-bugs] [Bug 8928] shipping not showing in budget summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8928 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Severity|normal |enhancement --- Comment #2 from Katrin Fischer --- I think this does not apply to the current acq workflow. The shipping cost can only be entered when you receive an item - the 'spent' page shows it then at the bottom of the page, so the totals are correct. The example on Nicole's screenshot is from the ordered page, but there is no option to have shipping cost for ordered items currently. Please reopen, if I misunderstood. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 19:59:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 18:59:37 +0000 Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:01:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:01:38 +0000 Subject: [Koha-bugs] [Bug 8815] my tags not showing my tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8815 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- 3.8 is no longer maintained - closing WONTFIX. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:08:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:08:16 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:08:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:08:35 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:08:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:08:41 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:09:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:09:17 +0000 Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:09:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:09:30 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:11:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:11:27 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:16:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:16:00 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:22:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:22:01 +0000 Subject: [Koha-bugs] [Bug 8642] Custom CSS Pref for SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Good news on this one: SCOUserCSS SCOUserJS SelfCheckHelpMessage Please open a new bug report for anything else that is needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:28:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:28:12 +0000 Subject: [Koha-bugs] [Bug 8582] NULL issuedates with offline circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- The last comment on this is from 2012 - has this bug reappeared since or can this be closed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:29:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:29:13 +0000 Subject: [Koha-bugs] [Bug 8602] Patron card creator - 'Units' don't stick in layouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This is true for the patron card layouts. Couldn't reproduce the issue for the label editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:32:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:32:13 +0000 Subject: [Koha-bugs] [Bug 8767] Import patron can't handle large files well In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8767 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Failed to import patrons |Import patron can't handle |details from CSV file |large files well Version|3.8 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:35:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:35:19 +0000 Subject: [Koha-bugs] [Bug 9015] BiblioAddsAuthorities should probably be set to "allow" by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:36:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:36:25 +0000 Subject: [Koha-bugs] [Bug 8976] Sequence of subfield in Editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Linux |All Hardware|PC |All Version|3.8 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- It's currently not possible to change the sequence the subfields appear in in a framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:37:20 +0000 Subject: [Koha-bugs] [Bug 8964] AllowHoldsOnDamagedItems and AllowOnShelfHolds don't work with Professional category type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8964 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This is an interesting one - can someone confirm this is still the case? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:38:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:38:00 +0000 Subject: [Koha-bugs] [Bug 8951] Patron Card Creator_How many words for a text field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8951 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |cnighswonger at foundations.ed | |u Component|Tools |Label/patron card printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:40:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:40:37 +0000 Subject: [Koha-bugs] [Bug 9029] location switches under certain time-out conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- I believe the described behaviour to be correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:42:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:42:57 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:43:29 +0000 Subject: [Koha-bugs] [Bug 8857] Add and duplicate functionality inconsistent w/autobarcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8857 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master --- Comment #1 from Katrin Fischer --- Still valid in current master, the duplicate behaviour changes with the autobarcode setting - I think it should not duplicate the barcode, but leave it empty, or better: generate the next. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:47:21 +0000 Subject: [Koha-bugs] [Bug 9099] Checked-in barcode export should not send empty file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |3.18 --- Comment #1 from Katrin Fischer --- The feature is in the patron account > More > Export today's checked in barcodes. The problem still exists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:48:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:48:51 +0000 Subject: [Koha-bugs] [Bug 9159] Direct link to favourite vendors on the acq homepage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Need list of vendors at |Direct link to favourite |Acquisition module home |vendors on the acq homepage |page | Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:52:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:52:30 +0000 Subject: [Koha-bugs] [Bug 9355] Display of possible book title and author list in search box In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9355 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:57:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:57:34 +0000 Subject: [Koha-bugs] [Bug 9371] Troble with author import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Sorry, there is not enough information on this bug report, versions listed are no longer maintained. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 20:58:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 19:58:55 +0000 Subject: [Koha-bugs] [Bug 9489] Process message queue.pl couldn't send the body of the overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9489 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Overdue notices are working correctly in current versions of Koha (recently tested). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:02:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:02:52 +0000 Subject: [Koha-bugs] [Bug 9562] System preference 'insecure' shows wrong value after update to v3.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- This is WONTFIX as the insecure system preference has been totally removed since - bug 9827. Good to see this one gone. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:06:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:06:51 +0000 Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.10 |master --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:14:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:14:38 +0000 Subject: [Koha-bugs] [Bug 9992] Barcode generated without a branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- This appears to work correctly in current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:16:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:16:36 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D__Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:20:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:20:59 +0000 Subject: [Koha-bugs] [Bug 7594] Google Cover CSS suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7594 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:21:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:21:31 +0000 Subject: [Koha-bugs] [Bug 7594] Google Cover Javascript contains hardcoded CSS style In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7594 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Google Cover CSS |Google Cover Javascript |suggestions |contains hardcoded CSS | |style Version|3.6 |master --- Comment #4 from Katrin Fischer --- On current master: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js;h=b23599f24f97b83e6377943381bd31e81a13a6b8;hb=b4e843615a76d3a9a8516f82a2ebad96aa9c4d1a#l58 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:22:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:22:03 +0000 Subject: [Koha-bugs] [Bug 7223] Move borrowerRelationship to Authorised Values list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:22:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:22:03 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 koha at akafred.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at akafred.com --- Comment #1 from koha at akafred.com --- (In reply to Benjamin Rokseth from comment #0) > on mysql versions > 5.3.21 This should be 'on mysql versions > 5.6.21'. (not 5.3.21) 5.6.22 is the current stable version of mysql - released 2014-12-01: http://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-22.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:26:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:26:18 +0000 Subject: [Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master CC| |jonathan.druart at biblibre.co | |m, katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Still valid, adding Jonathan as the 'tax expert'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:27:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:27:40 +0000 Subject: [Koha-bugs] [Bug 10294] when the word "user" is included in default in framework, surname of login creating record inserted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:30:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:30:00 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- I think the changing the constraint is the best solution here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:36:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:36:00 +0000 Subject: [Koha-bugs] [Bug 7524] Make it possible to generate a .koc file using the Firefox KOCT plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Katrin Fischer --- The synching from the plugin now works nicely, no workaround needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:40:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:40:10 +0000 Subject: [Koha-bugs] [Bug 7343] search tag usability in MARC framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7343 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:40:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:40:18 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #79 from Tom?s Cohen Arazi --- I think there are several changes in 5.20, including the removal of core Koha dependencies (e.g. CGI) that propose further challenges. I'd go for pushing this patches working on 5.18 so we push the utf patches, and evaluate 5.20 in the future (at least when a stable debian release provides it as default). Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:40:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:40:38 +0000 Subject: [Koha-bugs] [Bug 7224] Allow patrons to pick their own preferred language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:42:03 +0000 Subject: [Koha-bugs] [Bug 7705] IE postdata issue - expiring sessions when back button is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7705 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I have run into this before: 1) log into Koha 2) Use the return button to get past the login page 3) Notice you are logged out It might happen in other circumstances too - don't have IE to do more testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:44:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:44:50 +0000 Subject: [Koha-bugs] [Bug 7377] Feature Request: Add Lexile Search for Ranges of Lexile Scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.6 |master See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11368 --- Comment #1 from Katrin Fischer --- Hi Larry, if there is already an index for searching the Lexile range, you could try to build something with jQuery and add it on the advanced search. Updating version to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:44:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:44:50 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7377 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:45:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:45:22 +0000 Subject: [Koha-bugs] [Bug 7989] RIS export file type incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Reading a bit into the code, it looks like more options are possible, depending on your settings in the leader. Some things like a journal it can't recognize yet, as it would need to look at other fields in the record as well: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Ris.pm;h=137b99dd6af23d4b05ead08b7c2d71c6d520f0c9;hb=b4e843615a76d3a9a8516f82a2ebad96aa9c4d1a#l311 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:45:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:45:28 +0000 Subject: [Koha-bugs] [Bug 7989] RIS export file type incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:46:48 +0000 Subject: [Koha-bugs] [Bug 7525] some database fields are displayed 'as is' when they are linked to autorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:48:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:48:36 +0000 Subject: [Koha-bugs] [Bug 8016] Items are not tie to the transaction using "global" action. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:50:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:50:56 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12857 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:50:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:50:56 +0000 Subject: [Koha-bugs] [Bug 12857] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12857 --- Comment #1 from Katrin Fischer --- *** Bug 12858 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:51:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:51:38 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #3 from Katrin Fischer --- Sorry, wrong way around, trying again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:51:43 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:52:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:52:16 +0000 Subject: [Koha-bugs] [Bug 7694] Syndetics_Editons not included In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7694 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement Version|3.6 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:52:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:52:50 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:53:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:53:54 +0000 Subject: [Koha-bugs] [Bug 10397] link_bibs_to_authorities.pl fails when gets to bibs linked to deleted authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10397 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Danielle, is this still happening on current versions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:56:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:56:49 +0000 Subject: [Koha-bugs] [Bug 10518] Relevance option for non-Latin scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10518 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master Component|Database |Searching See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11927 CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think Zebra uses a file to know how to sort - currently we probably don't have one for multiple scripts, bug 11927 could give some hints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:56:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:56:49 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10518 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:57:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:57:23 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 21:58:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 20:58:26 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:07:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:07:23 +0000 Subject: [Koha-bugs] [Bug 9706] xslt icon for artifacts isn't quite right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9706 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:07:46 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:08:06 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:11:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:11:10 +0000 Subject: [Koha-bugs] [Bug 10760] Street Number field is missing from the Alternate Address section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:12:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:12:44 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Heather, good catch - it makes no sense there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:13:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:13:47 +0000 Subject: [Koha-bugs] [Bug 8511] display due date times in AM/PM format rather than 24hr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Done with the TimeFormat system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:18:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:18:00 +0000 Subject: [Koha-bugs] [Bug 10943] impossible to check and make fines when borrowers flag is desactivate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master --- Comment #1 from Katrin Fischer --- It appears you also need the borrowers permission - I am not sure if this is intentional: pay.pl: 53 flagsrequired => { borrowers => 1, updatecharges => $updatecharges_permissions }, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:18:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:18:22 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|impossible to check and |Impossible to manage fines |make fines when borrowers |without borrowers |flag is desactivate |permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:21:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:21:03 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:21:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:21:35 +0000 Subject: [Koha-bugs] [Bug 10946] pay fine amout showing negative value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- It's the report, not a problem in Koha :) - you want to look at the column amountoutstanding instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:23:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:23:21 +0000 Subject: [Koha-bugs] [Bug 11000] koha-restore not working: Koha username error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |robin at catalyst.net.nz Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org Component|Command-line Utilities |Packaging -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:24:38 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:29:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:29:16 +0000 Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:30:03 +0000 Subject: [Koha-bugs] [Bug 11164] creator_batches table uses borrower_number not borrowernumber? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:34:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:34:55 +0000 Subject: [Koha-bugs] [Bug 13525] New: Date sorting on accounts (fines) tab doesn't work correctly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Bug ID: 13525 Summary: Date sorting on accounts (fines) tab doesn't work correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The date sorting in the new datatable on the first 'fines' tab in the patron account is off and not working correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:35:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:35:36 +0000 Subject: [Koha-bugs] [Bug 10167] payment not showing what's paid for if not an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10167 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:41:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:41:25 +0000 Subject: [Koha-bugs] [Bug 11223] Incorrect ind1 semantics for MARC21 785 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:42:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:42:11 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:45:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:45:36 +0000 Subject: [Koha-bugs] [Bug 10517] kohe-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:48:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:48:37 +0000 Subject: [Koha-bugs] [Bug 8876] branch not always stored in the stats table for payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Marking this duplicate to the other bug. *** This bug has been marked as a duplicate of bug 11229 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:48:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:48:37 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #3 from Katrin Fischer --- *** Bug 8876 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:49:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:49:52 +0000 Subject: [Koha-bugs] [Bug 11063] Add circulation message's patron when checkin items (returns.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:50:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:50:30 +0000 Subject: [Koha-bugs] [Bug 10977] Connexion Gateway: biblios not importing as a batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10977 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |kyle.m.hall at gmail.com --- Comment #1 from Katrin Fischer --- Kyle, do you know if this is still a problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:50:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:50:59 +0000 Subject: [Koha-bugs] [Bug 6341] Request for multiple calendar support option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6341 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 22:56:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 21:56:23 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |normal --- Comment #4 from Katrin Fischer --- I still see the missing branchcodes in my database: select branch, datetime, type, proccode from statistics where type= 'payment' order by datetime desc; This looks a bit suspicious: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Accounts.pm;hb=b4e843615a76d3a9a8516f82a2ebad96aa9c4d1a#l278 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:00:43 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master --- Comment #1 from Katrin Fischer --- The checkout history (record detail) shows the times, while the circulation history (patron account) does only show the dates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:01:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:01:58 +0000 Subject: [Koha-bugs] [Bug 8409] purchase order saying 'Books' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master --- Comment #2 from Katrin Fischer --- It's the itemtype description showing up there: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=acqui/pdfformat/layout2pages.pm;hb=b4e843615a76d3a9a8516f82a2ebad96aa9c4d1a#l83 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:04:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:04:30 +0000 Subject: [Koha-bugs] [Bug 11339] time due doesn't show on patron details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11339 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Works correctly on current master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:06:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:06:04 +0000 Subject: [Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:08:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:08:46 +0000 Subject: [Koha-bugs] [Bug 11428] errors showing that are not relevant In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11428 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- We haven't experienced this behaviour in any of our libraries running 3.12 - I believe it has been fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:08:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:08:53 +0000 Subject: [Koha-bugs] [Bug 5302] Replace current call number splitting code with a plug-in system based on classification source In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5302 --- Comment #5 from David Cook --- (In reply to Chris Nighswonger from comment #3) > This goal would probably be better served by adding a system preference > which allowed for the storage of one (or many) custom regex's for splitting. > In any case, this feature is still very much needed. I definitely recant my previous comment. This would be useful :). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:10:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:10:19 +0000 Subject: [Koha-bugs] [Bug 10849] z3950servers.pl multiple pages features/filter not working as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10849 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- The Z30.50 administration page is now using a datatable - please reopen if you still experience problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:12:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:12:35 +0000 Subject: [Koha-bugs] [Bug 11485] serial renew doing wonky things In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11485 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Nicole, do you still see this happening? Is it only 3.12 or other later versions as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:16:07 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:25:25 +0000 Subject: [Koha-bugs] [Bug 11266] Z39.50 search results: DATE blank - add PUBLISHER In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11266 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Cataloging |and plumbing | CC| |m.de.rooy at rijksmuseum.nl Version|3.12 |master --- Comment #2 from Katrin Fischer --- Tested on my UNIMARC and my MARC21 installation - the publication year now shows up for both. Adding the publisher might still be good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:27:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:27:19 +0000 Subject: [Koha-bugs] [Bug 11627] Branch Library not set for item when serial issue received In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- The branch library appears to be set correctly now :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:28:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:28:00 +0000 Subject: [Koha-bugs] [Bug 11754] Show "problematic" holds info on patron info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11754 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:30:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:30:17 +0000 Subject: [Koha-bugs] [Bug 11782] Need junktag file to remove specific marc fields/subfields on z39.50 import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11782 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- With bug 6536 in 3.18 now you can create add xsl files to your z39.50 server configuration to change the incoming record in the way you want. There are example files in Koha for removing the 952 in $9 fields that you can use as a base. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:40:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:40:01 +0000 Subject: [Koha-bugs] [Bug 11911] purchase suggestions permission can be bypassed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master --- Comment #1 from Katrin Fischer --- Suggestions are tied to a very low level permission: flagsrequired => { catalogue => 1 } So everyone can access the page, even without any acq related permission. I think fixing this cleanly we should add a permission for the suggestions and make sure its set for all existing staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:40:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:40:23 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|purchase suggestions |Purchase suggestions can be |permission can be bypassed |accessed by all staff | |members / no specific | |permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:40:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:40:47 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:42:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:42:31 +0000 Subject: [Koha-bugs] [Bug 11930] Add a dropdown menu to search instructor on course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11930 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:45:26 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #7 from David Cook --- Comment on attachment 34316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34316 Bug 13414 - Enable automatic right truncation while searching by relevance Review of attachment 34316: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13414&attachment=34316) ----------------------------------------------------------------- ::: C4/Search.pm @@ +1030,5 @@ > #$weighted_query .=" or kw,wrdl,r5=\"$operand\""; # word list any > $weighted_query .= " or wrdl,fuzzy,r8=\"$operand\"" > if $fuzzy_enabled; # add fuzzy, word list > + if ( $stemming and $stemmed_operand ) { > + $weighted_query .= " or wrdl,right-Truncation,r9=\"$stemmed_operand\"" No functional difference... would be better to have this in a separate patch. @@ +1620,4 @@ > # Apply Truncation > if ( > scalar(@$righttruncated) + scalar(@$lefttruncated) + > + scalar(@$rightlefttruncated) > 0 and $weight_fields < 2 ) This will disable all truncation except for right truncation (which will be forced), if "QueryWeightFields" is set to 2. I don't love this, but seeing as truncation currently disables "QueryWeightFields", it might be fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:50:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:50:02 +0000 Subject: [Koha-bugs] [Bug 9750] bring routing lists in to notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hing-choi.fung at dol.state.nj | |.us --- Comment #2 from Katrin Fischer --- *** Bug 11933 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:50:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:50:02 +0000 Subject: [Koha-bugs] [Bug 11933] Relace the "Date Due" column to "Routing Location" column in the Serial Rounting Slip Template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- There is a bug report for making the routing slip customizable in the notices tool. As there is currently no way to achieve what you want to do and libraries might disagree about how the slip should look like, this seems the best way to go. *** This bug has been marked as a duplicate of bug 9750 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:52:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:52:17 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Receiving items requires |Receiving multiple order |repetitive clicking. |lines at once Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:56:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:56:10 +0000 Subject: [Koha-bugs] [Bug 11838] catalog print buttons needs circ permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11838 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- Printing doesn't require any permission in current versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 6 23:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 22:56:26 +0000 Subject: [Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:08:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:08:07 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- This is from the template for the links: 152 [% IF ( EasyAnalyticalRecords && CAN_user_editcatalogue_edit_catalogue ) %] 153
  • Analyze items
    • 154 [% END %] 155 [% IF CAN_user_editcatalogue_edit_catalogue %] 156
  • New child record
    • 157 [% END %] We could easily hide the 'new child record' if EasyAnalytics is turned on - althought it would be nicer to find a way to have both coexist (item level linking and record level linking). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:08:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:08:25 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #8 from David Cook --- (In reply to Martin Renvoize from comment #6) > David, as the current zebra guru, any chance you could give these patches a > glance over? Honestly, "buildQuery" and "_build_weighted_query" are so badly written that any change is probably an improvement :p. While I think this patch is a workaround, I think it's probably a reasonable enough workaround. -- What we really need to do is have functions that test for "QueryStemming", "QueryFuzzy", "QueryWeightFields", "QueryAutoTruncate", manual truncation, and index type THEN add the appropriate qualifiers. Rather than the bizarre mishmash that we have currently. Ideally, QueryParser should do this, but it hasn't been finished yet. Personally, I want to re-write buildQuery, but haven't had the time. I'd like to use an object or a hash for each atomic query, process them (according to our sysprefs and to make them valid CCL), and then build those atomic queries into a the complete query. It's basically what we do now, except you can't do everything to a query when realistically you should be able to do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:15:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:15:36 +0000 Subject: [Koha-bugs] [Bug 12028] Add cardnumber on update patron records page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add cardnumber on update |Add cardnumber on update |patron records page |patron records page Version|3.12 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- That's a good idea for an improvement - I'd also like a link to the patron account that is going to be updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:17:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:17:07 +0000 Subject: [Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12028 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:17:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:17:07 +0000 Subject: [Koha-bugs] [Bug 12028] Add cardnumber on update patron records page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12352 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:21:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:21:03 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12028 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:21:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:21:03 +0000 Subject: [Koha-bugs] [Bug 12028] Add cardnumber on update patron records page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13349 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:21:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:21:38 +0000 Subject: [Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13349 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:21:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:21:38 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12352 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:23:15 +0000 Subject: [Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:23:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:23:24 +0000 Subject: [Koha-bugs] [Bug 12028] Add cardnumber on update patron records page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:27:34 +0000 Subject: [Koha-bugs] [Bug 11044] All the librarians managing a fund should see the suggestions related to this fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- You can now see not only the suggestions you managed, but also all other suggestions with filters for limiting to your own or all (3.18). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:27:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:27:52 +0000 Subject: [Koha-bugs] [Bug 12047] Add new suggestion page should hide inactive funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12047 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:28:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:28:52 +0000 Subject: [Koha-bugs] [Bug 12078] z3950_search.pl parser error when viewing card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12078 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Christopher, do you still see this happening? Does it happen on all records or only on some? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:29:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:29:32 +0000 Subject: [Koha-bugs] [Bug 10009] self check out not really logging out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |3.12 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:33:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:33:03 +0000 Subject: [Koha-bugs] [Bug 12188] fines duplicated after changing dateformat In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12188 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED Version|3.12 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Marjorie, there is currently no full fix, but a warning has been added to the pref - see 13104. Thx for reporting! *** This bug has been marked as a duplicate of bug 13104 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:33:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:33:03 +0000 Subject: [Koha-bugs] [Bug 13104] Changing date or time format on a production server will create duplicate fines! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca --- Comment #7 from Katrin Fischer --- *** Bug 12188 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:34:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:34:26 +0000 Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:36:35 +0000 Subject: [Koha-bugs] [Bug 8950] Patron Card Creator_Background Image and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |cnighswonger at foundations.ed | |u CC| |katrin.fischer at bsz-bw.de Component|Tools |Label/patron card printing Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:41:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:41:26 +0000 Subject: [Koha-bugs] [Bug 10881] Fast Add Framework has different item fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Version|3.12 |master CC| |katrin.fischer at bsz-bw.de OS|Windows |All --- Comment #2 from Katrin Fischer --- I just checked and the item form on the default FA framework includes really too many subfields, including some that should not be edited: q - Koha out on loan r - Koha date last seen s - Koha date last borrowed I think it would be good to remove at least those subfields and some oters from the editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:41:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:41:53 +0000 Subject: [Koha-bugs] [Bug 12490] Choose notices to receive in copy with OverdueNoticebcc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12490 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:43:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:43:36 +0000 Subject: [Koha-bugs] [Bug 12502] Add a column for note, order number ans ISBN in late order page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:44:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:44:10 +0000 Subject: [Koha-bugs] [Bug 12575] Add option to delete several issues on page Serial collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:46:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:46:24 +0000 Subject: [Koha-bugs] [Bug 11626] Cannot receive serial issues after subscription expiry date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:48:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:48:04 +0000 Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:49:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:49:14 +0000 Subject: [Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |cnighswonger at foundations.ed | |u Version|3.10 |master CC| |katrin.fischer at bsz-bw.de Component|Tools |Label/patron card printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:50:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:50:17 +0000 Subject: [Koha-bugs] [Bug 12912] trouble with opachiddenitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12912 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Marjorie, did you manage to get it working again? Maybe try adding a blank line at the end of the pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:52:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:52:17 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight circulation of reference books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8133 Version|3.6 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:52:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:52:17 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6796 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:55:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:55:04 +0000 Subject: [Koha-bugs] [Bug 6778] Display suggestor's name in catalog detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I agree that this would have to be optional. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:57:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:57:28 +0000 Subject: [Koha-bugs] [Bug 7855] Bug 7263 does not include maxlength field sets into a fresh install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:57:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:57:43 +0000 Subject: [Koha-bugs] [Bug 7569] Add Google Transliteration tool to fields during cataloging and in advanced search in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:58:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:58:14 +0000 Subject: [Koha-bugs] [Bug 6758] Capture membership renewal date for reporting purposes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 00:59:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Jan 2015 23:59:49 +0000 Subject: [Koha-bugs] [Bug 8601] Allow more pictures on Patron Cards In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8601 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 01:00:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 00:00:49 +0000 Subject: [Koha-bugs] [Bug 6780] Log duplicate card issuance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6780 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Savitra, can you add more information? I am not sure I understand what is meant by 'duplicate card' here. Thx! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 01:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 00:02:41 +0000 Subject: [Koha-bugs] [Bug 6760] Generate new card number on renewals and duplicate card issuance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6780 CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Savitra, can you explain this a bit more? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 01:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 00:02:41 +0000 Subject: [Koha-bugs] [Bug 6780] Log duplicate card issuance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6780 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6760 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 01:10:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 00:10:14 +0000 Subject: [Koha-bugs] [Bug 13263] Printing Callnumber in Koha 3.16.04.000. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13263 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |cnighswonger at foundations.ed | |u Component|Tools |Label/patron card printing CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 06:46:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 05:46:20 +0000 Subject: [Koha-bugs] [Bug 13526] New: Email can be mandatory and hidden in borrower self-registration Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Bug ID: 13526 Summary: Email can be mandatory and hidden in borrower self-registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using the self-registration, "email" is a mandatory field no matter what, if the "PatronSelfRegistrationVerifyByEmail" system preference is true. However, you can still hide the "email" field, which means the form will refuse to submit (saying that you haven't filled in all mandatory fields) even though you've filled out every mandatory field on the screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 07:04:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 06:04:13 +0000 Subject: [Koha-bugs] [Bug 13526] Hidden fields can be mandatory in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Email can be mandatory and |Hidden fields can be |hidden in borrower |mandatory in borrower |self-registration |self-registration --- Comment #1 from David Cook --- Actually, now that I think about it, any mandatory field can be hidden... and that would cause trouble. So really no mandatory field should be able to be hidden. That's easy enough to do... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 07:07:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 06:07:55 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hidden fields can be |Mandatory fields should not |mandatory in borrower |be able to be hidden in |self-registration |borrower self-registration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 07:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 06:33:41 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 07:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 06:33:44 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 --- Comment #2 from David Cook --- Created attachment 34991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34991&action=edit Bug 13526 - Mandatory fields should not be able to be hidden in borrower self-registration Currently, mandatory fields in the borrower self-registration can be hidden. This causes problems since the validator rejects the registration, even though all required fields on the screen have been filled out. This is especially a problem when using the system preference "PatronSelfRegistrationVerifyByEmail", since it automatically makes "email" a mandatory field. This patch makes it so that a mandatory field cannot be hidden on the self-registration page. _TEST PLAN_ Before applying 1) Hide the "email" and the "emailpro" fields using the "PatronSelfRegistrationBorrowerUnwantedField" system preference. 2) Make the "email" and the "emailpro" fields mandatory using the "PatronSelfRegistrationBorrowerMandatoryField" system preference. 3) Note that you cannot see "Primary email" or "Secondary email" on the self registration page. (The registration page which can be found by turning on "PatronSelfRegistration" and filling in "PatronSelfRegistrationDefaultCategory". The link will be on opac-main.pl on the right side of the screen under the login box.) 4) Note that you cannot submit a self-registration request as the system tells you that you have not filled in all the mandatory fields. 5) Apply the patch && refresh the self registration page 6) Note that you can now see "Primary email" and "Secondary email" on the self-registration screen". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 07:34:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 06:34:03 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 07:34:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 06:34:47 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #3 from David Cook --- This might be a useful one for Academy members to take a look at :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 07:39:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 06:39:06 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #9 from paxed --- (In reply to Dobrica Pavlinusic from comment #8) > Created attachment 34634 [details] [review] > Bug 10773 - add help for *_description fields Typo "Fileds" in there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 07:41:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 06:41:53 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 --- Comment #4 from M. Tompsett --- Comment on attachment 34991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34991 Bug 13526 - Mandatory fields should not be able to be hidden in borrower self-registration Review of attachment 34991: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13526&attachment=34991) ----------------------------------------------------------------- ::: opac/opac-memberentry.pl @@ +235,5 @@ > my $BorrowerUnwantedField = > C4::Context->preference("PatronSelfRegistrationBorrowerUnwantedField"); > > + #Fetch the mandatory fields to compare against hidden fields > + my @mandatory_fields = keys %{GetMandatoryFields($action)}; The GetMandatoryFields function is already called on line 62. This calls it again. Could this be optimized? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 08:48:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 07:48:48 +0000 Subject: [Koha-bugs] [Bug 12825] GST / VAT rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10253 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 08:48:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 07:48:48 +0000 Subject: [Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12825 --- Comment #3 from Jonathan Druart --- This is not fixed by the tax rewrite work (bug 12825). But it will be very easy to do when all patches will be pushed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 08:52:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 07:52:26 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Did this get folded into bug 10944 in the end? i.e. is this closable a duplicate fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:02:16 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13527 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:02:16 +0000 Subject: [Koha-bugs] [Bug 13527] New: Mixed content warnings in results and detail with Google images on https Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13527 Bug ID: 13527 Summary: Mixed content warnings in results and detail with Google images on https Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: rel_3_16_candidate Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: ed.veal at bywatersolutions.com, gitbot at bugs.koha-community.org, gmcharlt at gmail.com, katrin.fischer at bsz-bw.de, kyle at bywatersolutions.com, liz at catalyst.net.nz, marjorie.barry-vila at ccsr.qc.ca, martin.renvoize at ptfs-europe.com, robin at catalyst.net.nz, wizzyrea at gmail.com Depends on: 10944 We need a similar treatment as created for Bug #10944, only this time we need to apply it to the Google image provider. ----------------------------------------------------------------------------- It's probably going to become more popular to run Koha in SSL environments - currently on ssl, with Google images enabled, a SSL enabled site will either not show Google images (IE, some versions of Firefox?), or show a warning to users about mixed secure and insecure content (Firefox, Chrome). Since we now have the using_https template variable, it makes sense to use it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:02:34 +0000 Subject: [Koha-bugs] [Bug 13527] Mixed content warnings in results and detail with Google images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13527 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:02:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:02:49 +0000 Subject: [Koha-bugs] [Bug 13527] Mixed content warnings in results and detail with Google images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13527 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:02:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:02:49 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13527 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:02:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:02:56 +0000 Subject: [Koha-bugs] [Bug 13527] Mixed content warnings in results and detail with Google images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13527 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10944 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:02:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:02:56 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13527 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:13:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:13:23 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- This 'might' be a good one for the Catalyst Academy.. marking as thus. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:13:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:13:33 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:20:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:20:34 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Jonathan Druart --- To test these patches, have a look at http://lists.koha-community.org/pipermail/koha-devel/2014-December/041024.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:20:35 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix [Needs one more signoff] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #86 from Martin Renvoize --- Comment on attachment 34534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34534 [PASSED QA] Bug 5786 - Move AllowOnShelfHolds system preference to the Circulation Matrix Review of attachment 34534: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5786&attachment=34534) ----------------------------------------------------------------- ::: C4/Items.pm @@ +174,4 @@ > ($data->{'serialseq'} , $data->{'publisheddate'}) = $ssth->fetchrow_array(); > } > #if we don't have an items.itype, use biblioitems.itemtype. > + # FIXME this should respect the itypes systempreference Are we OK with this new FIXME being added? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:20:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:20:42 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from Jonathan Druart --- To test these patches, have a look at http://lists.koha-community.org/pipermail/koha-devel/2014-December/041024.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:20:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:20:49 +0000 Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax included values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Jonathan Druart --- To test these patches, have a look at http://lists.koha-community.org/pipermail/koha-devel/2014-December/041024.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:21:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:21:43 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix [Needs one more signoff] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #87 from Martin Renvoize --- Generally I'm happy with this patch.. though a comment on the above FIXME would hasten my signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:32:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:32:47 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 --- Comment #3 from Martin Renvoize --- Hmm, I'de totlay forgotten about this bug and analytics is now out of my mindspace :( I'de love to see a more thorough treatment of this allowing for the preferences to be used collaboratively. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:36:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:36:09 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 --- Comment #4 from Martin Renvoize --- I did start work on this.. though only to the level of documenting what the expected behaviour for analytics at the marc level should be.. http://wiki.koha-community.org/wiki/Analytics -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 09:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 08:46:50 +0000 Subject: [Koha-bugs] [Bug 13528] New: Ability to search on the different isbn variations Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Bug ID: 13528 Summary: Ability to search on the different isbn variations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 10:02:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 09:02:57 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 --- Comment #5 from Martin Renvoize --- Looks like that page is somewhat out of date compared to our internal one.. I'm just sanitzng and transfering my findings from 2013 onto the community wiki.. alsmost as a sort of RFC for this work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 10:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 09:03:18 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #3 from paxed --- (In reply to Katrin Fischer from comment #2) > We just ran into this again, giving it a little nudge :) > > In Germany I think it would be: > > > > > We don't use at the moment, I think often the part that would > be street type is already part of the street name (-gasse, -stra?e). > > The state is not needed for addresses within Germany. This also applies to Finland. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 10:23:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 09:23:45 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 10:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 09:24:59 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 10:35:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 09:35:23 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 --- Comment #4 from Marc V?ron --- Same for Switzerland. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 10:57:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 09:57:20 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 10:57:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 09:57:23 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 --- Comment #1 from Jonathan Druart --- Created attachment 34992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34992&action=edit Bug 13528: Use the different isbn variations on search on the isbn index (nb) This enhancement adds the ability to search on all isbn variations when searching on the isbn index. Test plan: 0/ Don't apply the patch 1/ Create or choose a notice with an isbn with dashes. 2/ Try to search the notice using the isbn index by it isbn without dashes. => It does not work. 3/ Apply the patch, enable the new pref SearchWithISBNVariations and disable UseQueryParser. 4/ repeat 2 and note that the record is now returned. Note that this only works if UseQueryParser is disabled. It looks like QueryParser does not manage more than 1 operator. See: QueryParser does not manage more than 1 operator? http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028.html and commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 Author: Galen Charlton Date: Mon May 5 19:31:00 2014 +0000 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 11:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 10:09:14 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 12:02:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 11:02:32 +0000 Subject: [Koha-bugs] [Bug 5632] SIP improvements = Date formatting & debarrement management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5632 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #7 from Olli-Antti Kivilahti --- Hi there! I went through the whole SIP2.0 manual from 3M and I got 15 instances of date-use using the SIP::timestamp and 3 usages with no definition (optional) of the timeformat (see down). All undefined usages are using the AH-field. 2.00 Item Information Response due date AH variable-length optional field. 2.00 Renew Response due date AH variable-length required field Checkout Response due date AH variable-length required field 2.00 Hold Response 2.00 expiration date BW 18-char, fixed-length optional field: YYYYMMDDZZZZHHMMSS I think one can strongly infer from the documentation that using the established timeformat (the SIP-format) is supposed to be used. The SIP-device vendor anyway should format the date to be displayed per configuration. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 12:19:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 11:19:30 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #3 from Benjamin Rokseth --- (In reply to Chris Cormack from comment #2) > I think the changing the constraint is the best solution here. If by this you mean removing the NOT NULL constraint on the marcxml field (as is the case with the marc field) we agree on the most reasonable solution. Hope this does not affect any other part of Koha. Will include a patch soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 12:25:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 11:25:51 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 12:25:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 11:25:54 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34989|0 |1 is obsolete| | Attachment #34990|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 34993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34993&action=edit Bug 4402: Date filter on parcels.tt required db date format The date filters on the parcel page would only work with dates formatted YYYY-MM-DD. To test: - Select a vendor, that already has a few invoices - "Receive shipment" - you are on the parcels page - Use the From and To filters on the left, notice there is now a date picker on those fields - Verify the search works correctly for different date formats -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 12:26:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 11:26:55 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |jonathan.druart at biblibre.co | |m CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- Katrin, I resubmitted quite the same patch using the DateUtils module. I Hope you are fine with it. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 12:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 11:42:27 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #36 from Kyle M Hall --- *** Bug 13524 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 12:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 11:42:27 +0000 Subject: [Koha-bugs] [Bug 13524] stats not recording item type when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 9351 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 12:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 11:57:37 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 --- Comment #6 from Martin Renvoize --- I've updated my ramblings and documentatino now: http://wiki.koha-community.org/wiki/Multipart_Bibliographics That page links out to three separate pages for each of the possible UseControlNumber combinations.. I need to add in the EasyAnalytics thoughts for each of those specific use cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 12:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 11:59:16 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #7 from Martin Renvoize --- For a quick fix however to this particular bug.. Katrins identified the right place in the templates that needs amending.. perhaps one for an Academy student? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:11 +0000 Subject: [Koha-bugs] [Bug 13529] New: Easy analyticals and UseControl number should be able to coexist Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13529 Bug ID: 13529 Summary: Easy analyticals and UseControl number should be able to coexist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: normal Priority: P4 Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: director at plaistowlibrary.com, eb at efdss.org, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, mathsabypro at gmail.com, nengard at gmail.com Depends on: 10241 +++ This bug was initially created as a clone of Bug #10241 +++ At current, EasyAnalytics and UseControlNumber are mutually exclusive and lead to all sorts of strange issues if both are enabled at the same time. I believe this should not be the case and that with some re-factoring the two features could be made to compliment each other. I've started putting together some documents to outline my understanding of how the MARC21 rules should fit together with the UseControlNumber piece as a whole, I suggest we enhance this and then look at adding in the EasyAnalytics functionality to that area rather than the other way around. http://wiki.koha-community.org/wiki/Multipart_Bibliographics -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:11 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13529 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:21 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13529 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:21 +0000 Subject: [Koha-bugs] [Bug 13529] Easy analyticals and UseControl number should be able to coexist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13529 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10241 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:28 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13529 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:28 +0000 Subject: [Koha-bugs] [Bug 13529] Easy analyticals and UseControl number should be able to coexist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13529 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10241 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:35 +0000 Subject: [Koha-bugs] [Bug 13529] Easy analyticals and UseControl number should be able to coexist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13529 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:49 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:52 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34818|0 |1 is obsolete| | Attachment #34819|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 34994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34994&action=edit [SIGNED-OFF] Bug 9351 - item type not recorded correctly in statistics for returns and some local use When returning a loan, or when returning an item for local use, the corresponding entry in the statistics table takes the item type from the bib level. This is incorrect when item-level item types is enabled. This patch corrects this problem by getting itemtype from $item->{'itype'} which comes from item or biblio level in GetItem(). Test plan : - On a catalogue with itemtype on item level, perform a return an look at statistics table - Idem for a catalogue with itemtype on biblio level Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:04:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:04:59 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #38 from Kyle M Hall --- Created attachment 34995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34995&action=edit [SIGNED-OFF] Bug 9351 - sql update on existing statistics Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:15:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:15:40 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #14 from Kyle M Hall --- Created attachment 34996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34996&action=edit Bug 13381 [2] - RDA: 245 field changes in XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:16:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:16:50 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:16:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:16:53 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34464|0 |1 is obsolete| | Attachment #34996|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 34997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34997&action=edit Bug 13381 - RDA: 245 field changes in XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:43:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:43:54 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34960|0 |1 is obsolete| | --- Comment #68 from M. de Rooy --- Created attachment 34998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34998&action=edit Bug 13068: Raise an error if a pl script has a sql error Signed-off-by: Marcel de Rooy Tested with some perl and sql dev updates. Checked the list of dev updates for the TRACK mode. Slightly amended the patch for printing the error message. Also the message now may tell you that a dev update failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:44:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:44:50 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #69 from M. de Rooy --- (In reply to Jonathan Druart from comment #67) > (In reply to M. de Rooy from comment #65) > > I agree that we ideally should not. But how should we catch this in a simple > > and elegant way? > > What about the last patch? Great! Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 13:57:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 12:57:23 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard --- This patch creates invalid markup. I think it's just a missing . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:12:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:12:15 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #9 from Katrin Fischer --- Hi Joubu, trying to improve on my programming skills so hints are very welcome. I tried using the DateUtils, but it didn't work for me because what I had included a time at the end of the string. Have to take another look at the documentation. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:16:11 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #145 from M. de Rooy --- Created attachment 34999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34999&action=edit Bug 8992: Add the greybox include file for the bootstrap theme testing utf-8 val?rie signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:16:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:16:29 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:20:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:20:18 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:20:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:20:23 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34949|0 |1 is obsolete| | Attachment #34950|0 |1 is obsolete| | Attachment #34951|0 |1 is obsolete| | Attachment #34998|0 |1 is obsolete| | --- Comment #70 from Jonathan Druart --- Created attachment 35000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35000&action=edit Bug 13068: Follow-up for cleaning up atomicupdate folder The folder atomicupdate can be cleaned up. It mainly contains old files that are not used any more. I found two files that are still referenced: [1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl A readme file refers to it. The code in this file slightly differs from the TalkingTech db revision. It can probably be deleted too, but I will first check. [2] oai_sets.sql This file should remain. It is used in dbrev 3.07.00.029. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:20:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:20:30 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #71 from Jonathan Druart --- Created attachment 35001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35001&action=edit Bug 13068: Counterpatch using atomicupdate directory This patch makes a distinction between atomicupdates belonging to an official db revision and development updates. It also keeps track of the dev updates since the last official db rev. (This is done via a local pref; so easily accessible if needed.) The db revs can be txt files, perl scripts or sql files. Sql files are run via the installer. A new db revision is now only a matter of dropping a file in atomicupdates for the developer. The RM only adds one line to updatedatabase like: ExecDBRev( $aupd, '13068', 'Refined dbrev', '13068.pl', '3.17.00.028'); This line should follow the last dbrev and preceed the call to RunRemainingAtomicUpdates. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Run updatestructure and check if all db revs and dev updates are run. Run updatestructure again. Nothing should be run now. Clear/delete the _LocalAtomicUpdates pref. Run updatestructure again. Only dev updates should be run. Reset the database version. You could edit Version in local preferences. Run updatestructure and check if all db revs and dev updates are run. Edit _LocalAtomicUpdates and remove one filename. Run updatestructure again. Only one dev update should be run. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:20:35 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #72 from Jonathan Druart --- Created attachment 35002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35002&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:20:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:20:40 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #73 from Jonathan Druart --- Created attachment 35003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35003&action=edit Bug 13068: Raise an error if a pl script has a sql error Signed-off-by: Marcel de Rooy Tested with some perl and sql dev updates. Checked the list of dev updates for the TRACK mode. Slightly amended the patch for printing the error message. Also the message now may tell you that a dev update failed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:22:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:22:53 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34201|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:22:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:22:56 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34999|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:25:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:25:15 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #49 from M. de Rooy --- (In reply to Jonathan Druart from comment #48) > (In reply to M. de Rooy from comment #47) > > I am having various encoding related problems with applying this patch set. > > Looks like it is related to latin accented chars in the commit messages and > > my version of git/git bz. > > Try without the -e option. Looks like replacing the ? of Val?rie to e is still the best option by far.. Sorry, Valerie. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:25:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:25:29 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #74 from Jonathan Druart --- QA comments: All works as expected, we really need this to avoid recurrent conflicts on the updatedatabase.pl file. At some places, the code is not really obvious, but it's a good start. It could be great to have an entry on the wiki (http://wiki.koha-community.org/wiki/Database_updates ?) to list the different available options and explain the new workflow (don't append to updatedatabase.pl but create a new file). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:27:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:27:13 +0000 Subject: [Koha-bugs] [Bug 13530] New: Typo in bulkmarcimport Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Bug ID: 13530 Summary: Typo in bulkmarcimport Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org A typo seems to have crept in bulkmarcimport causing GetMarcFrameworkCode to fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:31:05 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 --- Comment #1 from Owen Leonard --- Created attachment 35004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35004&action=edit Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:31:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:31:03 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:35:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:35:31 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Martin Renvoize --- Hint: Line 401 the GetFrameworkcode function is has one wrong case character ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:39:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:39:30 +0000 Subject: [Koha-bugs] [Bug 13531] New: bulkmarcimport bombs if no match is found Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Bug ID: 13531 Summary: bulkmarcimport bombs if no match is found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org When using bulkmarcimport with the below command it would appear that if the match attribute is missing from the import file that the script dies at that point in the import. ../kohaclone/misc/migration_tools/bulkmarcimport.pl -filter="952" -update -match="Control-number,001" -file Results/all_ches_bib.mrc -v -l Logs/overlay.log I feel this should report the error, but more conventiently continue with the rest of the import batch thereafter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:40:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:40:41 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 --- Comment #1 from Martin Renvoize --- The errors presented are: DBD::mysql::st execute failed: Column 'biblio_auth_number' cannot be null at /home/koha/kohaclone/C4/Biblio.pm line 2871. followed by: unable to search the database for duplicates : No query entered at ../kohaclone/misc/migration_tools/bulkmarcimport.pl line 272, line 60379 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:40:52 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:41:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:41:26 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:42:14 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:42:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:42:21 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:45:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:45:43 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:45:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:45:46 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 --- Comment #2 from Owen Leonard --- Created attachment 35005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35005&action=edit Bug 11239 - show hour of due date in history circulation The circulation history page (Patron -> Circulation history) does not show the time when displaying the date of checkout, due date, and check in. This patch adds the "with_hours => 1" flag to the KohaDates filter. To test, apply the patch and view the circulation history page for a patron with good circulation history data. Confirm that dates are displayed correctly with times and that date sorting still works correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 14:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 13:47:46 +0000 Subject: [Koha-bugs] [Bug 12188] fines duplicated after changing dateformat In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12188 --- Comment #2 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #1) > Hi Marjorie, there is currently no full fix, but a warning has been added to > the pref - see 13104. Thx for reporting! > > *** This bug has been marked as a duplicate of bug 13104 *** Thanks Katrin. Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:25:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:25:10 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:25:14 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33120|0 |1 is obsolete| | Attachment #33121|0 |1 is obsolete| | Attachment #33122|0 |1 is obsolete| | Attachment #34890|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 35006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35006&action=edit Bug 12252 - OAI-PMH result includes item data GetRecord for OAI-PMH was pulling the MARCXML directly from the database. Now it uses GetMarcBiblio and includes the item data with it, making it more generally useful. Test plan: * Run an OAI-PMH query, for example: http://koha/cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:52&metadataPrefix=marcxml to fetch biblionumber 52 * Note that it doesn't include the 952 data * Apply the patch * Do the same thing, but this time see that the 952 data is at the bottom of the MARCXML. Note: * This patch also includes a small tidy-up in C4::Biblios to group things semantically a bit better, so I don't spend ages looking for a function that was staring me in the face all along again. Signed-off-by: David Cook Works as described. Simple yet useful patch. Signed-off-by: Jonathan Druart Signed-off-by: Frederic Demians 952/995 item fields are back in response to GetRecord OAI verb. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:25:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:25:18 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #26 from Jonathan Druart --- Created attachment 35007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35007&action=edit Bug 12252 - OAI-PMH items respect OpacHiddenItems This allows the OAI-PMH service to not provide item information when there is a rule that would supress it in OpacHiddenItems. Test plan: * Find an OAI-PMH URL that shows you some items. * Add an entry to OpacHiddenItems that would block that. * Check that it's blocked. Signed-off-by: Frederic Demians Tested, playing with OpacHiddenItems. GetRecord OAI verb returns a record complying with OpacHiddenItems rules, for example without items from a specific library. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:25:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:25:22 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #27 from Jonathan Druart --- Created attachment 35008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35008&action=edit Bug 12252 - include item data in OAI-PMH ListRecords result Same in spirit to the other patch, this also includes the item detail in ListRecords. Test plan: * Fetch a URL like: http://koha/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml * Verify that there are 952 entries in the returned records where appropriate. Signed-off-by: Frederic Demians ListRecords OAI verb returns a list of records including items in 952/995 which are not hidden based on OpacHiddenItems syspref. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:25:26 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #28 from Jonathan Druart --- Created attachment 35009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35009&action=edit Bug 12252: Add tests for EmbedItemsInMarcBiblio Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:28:28 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Amber Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amber at marlboro.edu --- Comment #12 from Amber Hunt --- > What about the use of a double hyphen -- ? This is what is used in the 505 > field to separate contents and seems to work visually The vertical bar (|) is used to separate subject headings and I think works quite nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:30:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:30:29 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #29 from Jonathan Druart --- Created attachment 35010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35010&action=edit Bug 12252: (qa-follow-up) Remove perlcritic error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:32:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:32:35 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35010|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 35011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35011&action=edit Bug 12252: (qa-follow-up) Remove perlcritic error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:37:27 +0000 Subject: [Koha-bugs] [Bug 12912] trouble with opachiddenitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12912 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #1) > Hi Marjorie, > did you manage to get it working again? Maybe try adding a blank line at the > end of the pref. oh! thank you for the clue! it's works! Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:45:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:45:18 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #1) > It appears you also need the borrowers permission - I am not sure if this is > intentional: > > pay.pl: > 53 flagsrequired => { borrowers => 1, updatecharges => > $updatecharges_permissions }, Thanks Katrin. It works with borrowers permission. Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:50:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:50:41 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29165|0 |1 is obsolete| | --- Comment #50 from M. de Rooy --- Created attachment 35012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35012&action=edit Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link Signed-off-by: valerie bertrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:50:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:50:46 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29166|0 |1 is obsolete| | --- Comment #51 from M. de Rooy --- Created attachment 35013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35013&action=edit Bug 8992: DB changes - add the IdRef syspref Signed-off-by: valerie bertrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:50:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:50:51 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29167|0 |1 is obsolete| | --- Comment #52 from M. de Rooy --- Created attachment 35014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35014&action=edit Bug 8992: Add 7..$3 to the Indentifier-standard index Signed-off-by: valerie bertrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:50:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:50:55 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29168|0 |1 is obsolete| | --- Comment #53 from M. de Rooy --- Created attachment 35015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35015&action=edit Bug 8992: XSLT changes This patch add the same behavior as previous patches for the xslt view. Signed-off-by: valerie bertrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:50:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:50:59 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30920|0 |1 is obsolete| | --- Comment #54 from M. de Rooy --- Created attachment 35016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35016&action=edit Bug 8992: Use the existing greybox plugin in interface/theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:51:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:51:03 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32123|0 |1 is obsolete| | --- Comment #55 from M. de Rooy --- Created attachment 35017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35017&action=edit Bug 8992: Add the greybox include file for the bootstrap theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 15:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 14:52:55 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #56 from M. de Rooy --- QA Comment: Warning: commit message does not conform to UTF-8. I replaced the ? in Val?rie. Some/most combinations of git/git-bz still do not like non-ASCII commit messages. I rebased the second patch for updatedatabase. No complaints from qa tools. Code looks good (remarks below). I have mainly 'dry-tested' this patch set; I did not manage to get my unimarc test db in the right condition within reasonable time. Note that opac-idref.pl can be tested more or less separately. 1st patch: css in template file (no blocker) 3rd patch: + + + + + + + This does not look good to me. The for-each is repeated now. Same holds for 701, 702, 710, 711, 712 Note that you update biblio-zebra-indexdefs.xsl. But biblio-zebra-indexdefs.xsl should be automatically generated from a Koha index definition file with koha-indexdefs-to-zebra.xsl. Could you please add changes to biblio-koha-indexdefs and then run the xsl to create biblio-zebra-indexdefs.xsl ? Status to Failed QA for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:00:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:00:44 +0000 Subject: [Koha-bugs] [Bug 13532] New: Unit test for Bug 12361 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Bug ID: 13532 Summary: Unit test for Bug 12361 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com This patch adds a unit test to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:00:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:00:58 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unit test for Bug 12361 |Unit test for Bug 13261 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:01:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:01:09 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13261 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:01:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:01:09 +0000 Subject: [Koha-bugs] [Bug 13261] Better check in message for patrons with indefinite restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13532 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:02:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:02:28 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35018&action=edit Bug 13532 - Unit test for Bugg 13261 This patch adds a unit test to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:02:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:02:45 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:04:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:04:06 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35018|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 35019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35019&action=edit Bug 13532 - Unit test for Bugg 13261 This patch adds a unit test to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:05:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:05:00 +0000 Subject: [Koha-bugs] [Bug 12964] GST / VAT rewrite - Overview In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |ASSIGNED --- Comment #22 from M. de Rooy --- (In reply to Jonathan Druart from comment #20) > There is no patch on this one. > It's a document to review, see description. Suppose we could move the status to ASSIGNED and remove it from the SO queue. It does not belong here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:07:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:07:39 +0000 Subject: [Koha-bugs] [Bug 11847] [DEPENDS ON 11708] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display basketgroup closed |[DEPENDS ON 11708] Display |date at OPAC |basketgroup closed date at | |OPAC CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:13:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:13:42 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35014|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart --- Created attachment 35020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35020&action=edit Bug 8992: Add 7..$3 to the Indentifier-standard index Signed-off-by: valerie bertrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:14:39 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #58 from Jonathan Druart --- (In reply to M. de Rooy from comment #56) > Could you please add changes to biblio-koha-indexdefs and then run the xsl > to create biblio-zebra-indexdefs.xsl ? It seems I forgot to commit the changes to the xml file. Thanks for catching that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:23:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:23:01 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #85 from M. de Rooy --- Having a look at this one now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:28:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:28:11 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 rgravel at marlboro.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rgravel at marlboro.edu --- Comment #16 from rgravel at marlboro.edu --- Statement of Responsibility: I am a cataloger and I do like the full statement of responsibility, ie the whole 245 field, to display at the top of the record. I think it is in fact helpful to patrons, because it is written in plain language and so clearly indicates to a patron whether the record they've found matches their needs. It is fairly common in other systems and academic libraries to include the full statement, because it readily helps patrons understand what the record is a surrogate for, i.e. which book exactly the record really represents. Furthermore, sometimes the statement differs from what is included in 100s and 700s, because it is up to the cataloger's taste and judgement to decide whether to make an access point for those folks listed in the statement. So, as a result, you could have important bibliographic information included in the statement, but no where else in the record, which is another reason I think many systems chose to display it. GMD/Medium: Because there will be a mix of legacy AACR2 and new RDA records in our catalogs, we can no longer *consistently* rely on the GMD as the indicator of medium. The good news is, there are other indicators in the record that are consistent across AACR2 and RDA records, like the material type that is pulled from MARC's fixed fields/leader and already populates a Type tag in the record; a new medium or format tag that pulled the GMD in would be duplicative of this in my opinion. The type selected for the items, as well as any call number prefixes that might be use for DVDs or Ebooks, as also consistent indicators, not to mention RDA's new 33x fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:31:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:31:09 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 rgravel at marlboro.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rgravel at marlboro.edu --- Comment #3 from rgravel at marlboro.edu --- I agree with Katrin about the $4 and $e conflict- always favor the term over the code, as that is what patrons will more readily understand. I also still like the vertical bar as a separator for the reasons I mentioned in Bug 13382. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:33:31 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #86 from M. de Rooy --- QA Comment: Passes qa tools. Verified Basketgroups.t. This test does not contain any testnames in the calls to ok, is, etc. It is encouraged to do so. Could you please add? Question: Do we still need the column closed, if you add a closeddate in aqbasketgroups? Do we create redundancy? And what about confusion like: Hey closed=0 but there is a closeddate? Please convince me that we should have both columns. [PATCH 6/7] Bug 11708: Remove the amount columns Commit message says only: This should be managed in a specific bug. Please explain. Before continuing this QA session, I would appreciate feedback on the points listed. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:46:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:46:40 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:50:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:50:25 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35019|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 35021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35021&action=edit Bug 13532 - Unit test for Bugg 13261 This patch adds a unit test to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:58:24 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #59 from M. de Rooy --- Will not block this patch, just want to note this: Field 009 has been superseded by new UNIMARC field 035 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:59:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:59:29 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:59:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:59:32 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35012|0 |1 is obsolete| | --- Comment #60 from M. de Rooy --- Created attachment 35022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35022&action=edit Bug 8992: Interfacing with the Idref webservice On the detail page (in the opac), if the biblio comes from the Sudoc, you must have a link (on the right of the author link) which open a popup with informations about this author (publications by role). To test: 1/ Switch on the Idref system preference 2/ Simulate a SUDOC record: Fill a 7..$3 field with a ppn (032581270 for example). Fill the 009 field with an integer 3/ Go to the opac detail page of this notice. You should see the IDREF link. If you click on it, a popup displays a loading icon and after a few seconds (depending of the productivity of the authority :)), a list of roles. For each role, a table displays all his corresponding publications. 4/ On the right, you have 2 links: 1 for a koha search for this result and 1 for a SUDOC link Signed-off-by: valerie bertrand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:59:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:59:37 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35013|0 |1 is obsolete| | --- Comment #61 from M. de Rooy --- Created attachment 35023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35023&action=edit Bug 8992: DB changes - add the IdRef syspref Signed-off-by: valerie bertrand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:59:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:59:42 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35015|0 |1 is obsolete| | --- Comment #62 from M. de Rooy --- Created attachment 35024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35024&action=edit Bug 8992: XSLT changes This patch add the same behavior as previous patches for the xslt view. Signed-off-by: valerie bertrand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:59:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:59:47 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35016|0 |1 is obsolete| | --- Comment #63 from M. de Rooy --- Created attachment 35025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35025&action=edit Bug 8992: Use the existing greybox plugin in interface/theme Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:59:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:59:52 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35017|0 |1 is obsolete| | --- Comment #64 from M. de Rooy --- Created attachment 35026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35026&action=edit Bug 8992: Add the greybox include file for the bootstrap theme Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 16:59:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 15:59:57 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35020|0 |1 is obsolete| | --- Comment #65 from M. de Rooy --- Created attachment 35027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35027&action=edit Bug 8992: Add 7..$3 to the Indentifier-standard index Signed-off-by: valerie bertrand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 17:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 16:04:48 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 --- Comment #6 from M. Tompsett --- (In reply to Martin Renvoize from comment #5) > Did this get folded into bug 10944 in the end? i.e. is this closable a > duplicate fixed? Partially. I started looking that the Splinter Review between the two and noticed koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt differs. This one has more! This should be reworked conflict free and a full testing plan given, in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 17:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 16:28:48 +0000 Subject: [Koha-bugs] [Bug 13533] New: Table suggestions is missing FK constraints / borrowernumbers are kept on deletion of patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13533 Bug ID: 13533 Summary: Table suggestions is missing FK constraints / borrowernumbers are kept on deletion of patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The suggestions table never clears the borrowernumbers referenced in - suggestedby - managedby - acceptedby - rejectedby suggestedby is usually a patron not a staff user, I think on deletion of the patron it would make sense to set it to NULL. Maybe also for the other 3? There is also no FK on - budgetid - branchcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 17:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 16:30:40 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #91 from Zeno Tajoli --- Hi Jesse and all, my boss tells that we need to help as much as possible to insert this feature in master. Now the code is in "Failed QA" status. In which direction do you want to port the code ? Do you want to drop the use of Pazpar ? Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 18:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 17:27:10 +0000 Subject: [Koha-bugs] [Bug 13534] New: Deleting staff member who moderated a tag removes tags imcompletely Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13534 Bug ID: 13534 Summary: Deleting staff member who moderated a tag removes tags imcompletely Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I am trying to wrap my mind around the table structure, but what happens is: If you add a tag, it will be in tags_all and tags_approval. tags_approval has a column approved_by, that is linked to the staff patron who moderated the tag. If the staff patron is deleted, the entry in tags_approval is also deleted, but tags_all remains. The tag vanishes from the tag moderation tool and from the OPAC. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/kohastructure.sql;hb=b4e843615a76d3a9a8516f82a2ebad96aa9c4d1a#l2268 This doesn't feel like intended behaviour. I think it maybe it would make sense to set the borrowernumber to NULL when the staff patron is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 18:37:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 17:37:52 +0000 Subject: [Koha-bugs] [Bug 13535] New: Table alert is missing FK and not deleted with the patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 Bug ID: 13535 Summary: Table alert is missing FK and not deleted with the patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The table alert contains subscriptions for email notifications for new serial issues. There is no FK on the borrowernumber and no other permission I can see to clean the table once the patron has been deleted. 2806 DROP TABLE IF EXISTS `alert`; 2807 CREATE TABLE `alert` ( 2808 `alertid` int(11) NOT NULL auto_increment, 2809 `borrowernumber` int(11) NOT NULL default 0, 2810 `type` varchar(10) NOT NULL default '', 2811 `externalid` varchar(20) NOT NULL default '', 2812 PRIMARY KEY (`alertid`), 2813 KEY `borrowernumber` (`borrowernumber`), 2814 KEY `type` (`type`,`externalid`) 2815 ) ENGINE=InnoDB DEFAULT CHARSET=utf8; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 19:00:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 18:00:56 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #1 from Olli-Antti Kivilahti --- Hi! This issue is plaguing us as well. It manifested as we barred all Borrowers with fines during the new-year. Now our check-in machine is cutting the connection all the time :) I managed to fix the issue and will share a patch ASAP. Since Mr. Chittenden has identified this issue, I wonder why he hasn't shared a patch already? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 20:08:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 19:08:33 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com --- Comment #5 from Francois Charbonnier --- I tested this patch on BibLibre's sandbox17. Here is what I did. I created 4 new vendors to test 4 different set ups : Set up 1 = List prices INCLUDE TAX + Invoice prices INCLUDE TAX Set up 2 = List prices EXCLUDE TAX + Invoice prices EXCLUDE TAX Set up 3 = List prices INCLUDE TAX + Invoice prices EXCLUDE TAX Set up 4 = List prices EXCLUDE TAX + Invoice prices INCLUDE TAX For each vendor, default tax rate is 5%. Then, for each vendor : * I add 1 basket with 1 item. Vendor price is 10 euros. Default tax rate is 5%. * I check the prices and tax caculation on the basket page. Everything is well calculated (prices tax included or excluded) * I close the basket and go to the receive page * I receive the item and change the tax rate to 10%. * I check the prices and tax calculation on the receive page. For the set ups 1 and 2, I have what I expected. Not for the set ups 3 and 4. Set up 1 (List prices INCLUDE TAX + Invoice prices INCLUDE TAX): Ordering : Vendor price (tax incl) = 10 euros <---- what I entered Vendor price (tax excl) = 9.52 euros Tax amount (5%) = 0.48 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10 euros Receiving : Vendor price (tax incl) = 10 euros (= value in actual cost) Vendor price (tax excl) = 9.09 euros Tax amount (10%) = 0.91 euros Total (tax excl) = 9.09 euros Total (tax incl) = 10 euros Set up 2 (List prices EXCLUDE TAX + Invoice prices EXCLUDE TAX): Ordering : Vendor price (tax incl) = 10.5 euros Vendor price (tax excl) = 10 euros <---- what I entered Tax amount (5%) = 0.5 euros Total (tax excl) = 10 euros Total (tax incl) = 10.5 euros Receiving : Vendor price (tax incl) = 11 euros Vendor price (tax excl) = 10 euros (= value in actual cost) Tax amount (10%) = 1 euros Total (tax excl) = 10 euros Total (tax incl) = 11 euros Set up 3 (List prices INCLUDE TAX + Invoice prices EXCLUDE TAX): Ordering : Vendor price (tax incl) = 10 euros <---- what I entered Vendor price (tax excl) = 9.52 euros Tax amount (5%) = 0.48 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10 euros Receiving (what we have now): Vendor price (tax incl) = 10.47 euros Vendor price (tax excl) = 9.52 euros (= value in actual cost) Tax amount (10%) = 0.95 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10.47 euros Receiving (what I expected): Vendor price (tax incl) = 10 euros Vendor price (tax excl) = 9.09 euros (= value in actual cost) Tax amount (10%) = 0.91 euros Total (tax excl) = 9.09 euros Total (tax incl) = 10 euros Since I entered the price tax included and then changed the tax rate, I expected the actual cost, which is here the price tax excluded, to be recalculated. But here, the value in actual cost is the price tax excluded calculated on the price tax included with a 5% tax (but I changed it to 10%...) Set up 4 (List prices EXCLUDE TAX + Invoice prices INCLUDE TAX): Ordering : Vendor price (tax incl) = 10.5 euros Vendor price (tax excl) = 10 euros <---- what I entered Tax amount (5%) = 0.5 euros Total (tax excl) = 10 euros Total (tax incl) = 10.5 euros Receiving (what we have) : Vendor price (tax incl) = 10.50 euros (= value in actual cost) Vendor price (tax excl) = 9.55 euros Tax amount (10%) = 0.95 euros Total (tax excl) = 9.55 euros Total (tax incl) = 10.50 euros Receiving (what I expected) : Vendor price (tax incl) = 11 euros (= value in actual cost) Vendor price (tax excl) = 10 euros Tax amount (10%) = 1 euros Total (tax excl) = 10 euros Total (tax incl) = 11 euros Same logic than before. I expected the value in actual cost to be recalculated. In a few words, I expect the reference value on which calculation should be based to be the one I entered when I placed the order. So, if I change the tax rate during the receiving process, I expect the actual cost to be recalculated. Here, the actual cost calculation is always based on the tax rate we have when placing the order. To me, it's not logical. Jonathan, could you ask librarians in charge of acquisition what they think of this. I'll trust their judgment. If the logic in place is good. You can signed off these patches. If not, tell me when it's ready and I'll test it again. ;^) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 20:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 19:33:37 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #3 from sandboxes at biblibre.com --- Patch tested with a sandbox, by marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 20:33:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 19:33:51 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 20:33:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 19:33:58 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 --- Comment #4 from sandboxes at biblibre.com --- Created attachment 35028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35028&action=edit Bug 11239 - show hour of due date in history circulation The circulation history page (Patron -> Circulation history) does not show the time when displaying the date of checkout, due date, and check in. This patch adds the "with_hours => 1" flag to the KohaDates filter. To test, apply the patch and view the circulation history page for a patron with good circulation history data. Confirm that dates are displayed correctly with times and that date sorting still works correctly. Signed-off-by: marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 23:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 22:54:26 +0000 Subject: [Koha-bugs] [Bug 12078] z3950_search.pl parser error when viewing card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12078 --- Comment #2 from Christopher Brannon --- Katrin, it is still happening in 3.16.4. I don't know about master. My understanding is that it doesn't happen all the time. I think when this first came up months ago, we had determined it might have something to do with ISBNs that have some extra information, but I am not sure. It has been quite some time since I did some investigating, and I don't normally do any tasks dealing with this. Another staff member said it is still happening. I asked her to show me an example when she runs into it again. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 7 23:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 22:56:22 +0000 Subject: [Koha-bugs] [Bug 12078] z3950_search.pl parser error when viewing card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12078 --- Comment #3 from Katrin Fischer --- Having an example record/z39.50 search where it happens would be good -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 00:00:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 23:00:21 +0000 Subject: [Koha-bugs] [Bug 12078] z3950_search.pl parser error when viewing card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12078 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Could it be related to a wrong behaviour in NormalizeISBN with ISBN's starting with 939 (bug 13167). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 00:17:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 23:17:08 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 00:42:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 23:42:02 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 00:43:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 23:43:43 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 00:44:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 23:44:14 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 00:44:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 23:44:42 +0000 Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 00:45:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Jan 2015 23:45:11 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Tom?s Cohen Arazi --- Patches pushed to master. Nice one Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 01:02:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 00:02:54 +0000 Subject: [Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 01:03:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 00:03:27 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #22 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 01:03:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 00:03:53 +0000 Subject: [Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 01:08:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 00:08:42 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #17 from David Cook --- (In reply to rgravel from comment #16) > Statement of Responsibility: > I am a cataloger and I do like the full statement of responsibility, ie the > whole 245 field, to display at the top of the record. I think it is in fact > helpful to patrons, because it is written in plain language and so clearly > indicates to a patron whether the record they've found matches their needs. > It is fairly common in other systems and academic libraries to include the > full statement, because it readily helps patrons understand what the record > is a surrogate for, i.e. which book exactly the record really represents. > Hmm, fair enough. As a patron, I suppose I would prefer to see "Moby Dick / Herman Melville ; retold by Kathy Burke." rather than just "Moby Dick". As you say, it's a more accurate surrogate that way. Of course, if you have a lengthy statement of responsibility, the detail page is going to get awfully crowded as the title/statement of responsibility area is currently in a h1 element with a font size of about 140%. It's not so bad in the search results where the title/statement of responsibility is in an a element with about 104% font size. I suppose as a patron, (technical services) librarian, and developer, I'd like the display to be as useful as possible while also being usable/aesthetically pleasing. Maybe changing the font size for the h1 to 120% instead of 140% will allow for an easier to read heading, when more text is displayed. > Furthermore, sometimes the statement differs from what is included in 100s > and 700s, because it is up to the cataloger's taste and judgement to decide > whether to make an access point for those folks listed in the statement. So, > as a result, you could have important bibliographic information included in > the statement, but no where else in the record, which is another reason I > think many systems chose to display it. > Very true, especially in the case of AACR2 records where the "rule of three" was encouraged. That said, if I recall correctly, cataloguers can choose to snip the statement of responsibility as well if it's too long... but then that sort of negates my earlier point about being concerned about overly long statements of responsibility ;). > GMD/Medium: > Because there will be a mix of legacy AACR2 and new RDA records in our > catalogs, we can no longer *consistently* rely on the GMD as the indicator > of medium. The good news is, there are other indicators in the record that > are consistent across AACR2 and RDA records, like the material type that is > pulled from MARC's fixed fields/leader and already populates a Type tag in > the record; a new medium or format tag that pulled the GMD in would be > duplicative of this in my opinion. The type selected for the items, as well > as any call number prefixes that might be use for DVDs or Ebooks, as also > consistent indicators, not to mention RDA's new 33x fields. Unfortunately, most of the records I encounter don't have any data or correct data in the fixed fields/leader when it comes to the material type. I work mainly in special libraries where knowledge of library cataloguing standards, which can be readily found in public and academic libraries, is much more rare. On one hand, this can be incentive to clean-up old records and re-train staff to catalogue more "properly". On the other hand, no one in special libraries has time or money for that. In theory, I'd like to rely on the leader and the fixed fields, but in practice I find that cataloguers just aren't consistent enough. That's why I think libraries introduced the RDA 33x fields. All that data was already there, but now there is an easier (albeit also error-prone) way of writing it out. But yeah... 33x fields, leader/fixed fields, item type, GMD, call number prefixes... there isn't a whole lot of consistency or reliability. In all honesty, I've been thinking about the possibility of introducing a Koha-specific "record type". It seems that this sort of thing is pretty common in other systems like Summon and EDS. It would be indexed, so you could search it specifically or you could use it as a facet. It would display in the search results and on the detail page, so that patrons could easily see what sort of record the library deems it to be. The advantage of a record type over an item type is that item type is currently mixed up between items and bib records via the 942$c. It would be a high-level record type - completely unrelated to MARC - which would be based on improving discoverability. Why should we be bound to MARC? Ebsco and Serial Solutions ignore it/enhance it, and people love their systems and laud them for "discovery". (Of course, adding a Koha-specific "record type" would make bulk importing records more difficult without a predefined mapping to use something in MARC to map to the Koha-specific "record type") -- In summary, I'm sold on the statement of responsibility. Let's do it up. As for the Medium stuff... I still don't know the best solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 01:18:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 00:18:04 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #13 from David Cook --- (In reply to Amber Hunt from comment #12) > > > What about the use of a double hyphen -- ? This is what is used in the 505 > > field to separate contents and seems to work visually > > The vertical bar (|) is used to separate subject headings and I think works > quite nicely. I'm going to continue my Marlboro support today, and agree that the vertical bar/pipe (|) is probably the way to go. While notes uses "--", other parts of the detail page use the "|", so I think it's the way to go. Consistency as much as possible would probably be good. I'm not a huge fan of the word "Contributor(s)", but I think it's probably good enough. If my librarians don't like it, I'm happy to change it on a case-by-case basis. -- In summary, I think I'm in full support of the changes that Nicole has suggested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 01:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 00:21:39 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 --- Comment #5 from David Cook --- (In reply to M. Tompsett from comment #4) > Comment on attachment 34991 [details] [review] > Bug 13526 - Mandatory fields should not be able to be hidden in borrower > self-registration > > Review of attachment 34991 [details] [review]: > ----------------------------------------------------------------- > > ::: opac/opac-memberentry.pl > @@ +235,5 @@ > > my $BorrowerUnwantedField = > > C4::Context->preference("PatronSelfRegistrationBorrowerUnwantedField"); > > > > + #Fetch the mandatory fields to compare against hidden fields > > + my @mandatory_fields = keys %{GetMandatoryFields($action)}; > > The GetMandatoryFields function is already called on line 62. This calls it > again. Could this be optimized? Probably. I was thinking that it's pointless doing the grep as well as a person could just use the hash... I'll take another look at this pronto. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 01:54:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 00:54:58 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Sean changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spark at cclsd.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 07:04:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 06:04:56 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34991|0 |1 is obsolete| | --- Comment #6 from David Cook --- Created attachment 35029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35029&action=edit Bug 13526 - Mandatory fields should not be able to be hidden in borrower self-registration Currently, mandatory fields in the borrower self-registration can be hidden. This causes problems since the validator rejects the registration, even though all required fields on the screen have been filled out. This is especially a problem when using the system preference "PatronSelfRegistrationVerifyByEmail", since it automatically makes "email" a mandatory field. This patch makes it so that a mandatory field cannot be hidden on the self-registration page. _TEST PLAN_ Before applying 1) Hide the "email" and the "emailpro" fields using the "PatronSelfRegistrationBorrowerUnwantedField" system preference. 2) Make the "email" and the "emailpro" fields mandatory using the "PatronSelfRegistrationBorrowerMandatoryField" system preference. 3) Note that you cannot see "Primary email" or "Secondary email" on the self registration page. (The registration page which can be found by turning on "PatronSelfRegistration" and filling in "PatronSelfRegistrationDefaultCategory". The link will be on opac-main.pl on the right side of the screen under the login box.) 4) Note that you cannot submit a self-registration request as the system tells you that you have not filled in all the mandatory fields. 5) Apply the patch && refresh the self registration page 6) Note that you can now see "Primary email" and "Secondary email" on the self-registration screen". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 07:06:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 06:06:43 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 --- Comment #7 from David Cook --- (In reply to M. Tompsett from comment #4) > The GetMandatoryFields function is already called on line 62. This calls it > again. Could this be optimized? There we go. That should be much better! A fair number of my changes turned out to be needless, so I simplified it and it works a treat. Cheers! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 07:54:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 06:54:53 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #3 from Katrin Fischer --- I think we should think about changing this - or make all checks consistent, like not showing the fines tab when the user doesn't have all needed permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 10:04:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 09:04:57 +0000 Subject: [Koha-bugs] [Bug 12078] z3950_search.pl parser error when viewing card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12078 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.16 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 10:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 09:28:28 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #14 from Katrin Fischer --- > I am not sure about using | as a separator, it looks quite uncommon. Still not sure, but not opposed :) Maybe if we would put it in a span with a class http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 Bug ID: 13536 Summary: Date due without time on CHECKOUT alert Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org In the issues table date_due is a datetime field. If you do not have hourly loans, the 23:59:00 on the CHECKOUT notice may be somewhat confusing. (When does the library close?) In the patch submitted I virtually add a date_due_without_time column to the issues table by adding such a field in the SELECT statement in Letters.pm, routine _parseletter_sth. If you want to remove the time from the notice, now you can just edit the notice and replace <> by <>. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 12:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 11:59:16 +0000 Subject: [Koha-bugs] [Bug 13537] New: Focus should move to barcode after renewing via checkouts table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Bug ID: 13537 Summary: Focus should move to barcode after renewing via checkouts table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Koha's checkout screen automatically focuses on the barcode field each time it is loaded. Since we've moved the checkouts table functions for renewing and returning items to ajax methods, this page is no longer refreshed, and thus does not refocus to the barcode after performing those actions. This should be fixed so that renewing/returning items via the checkouts page moves the focus to the barcode field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:01:06 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #66 from Jonathan Druart --- (In reply to M. de Rooy from comment #59) > Will not block this patch, just want to note this: > Field 009 has been superseded by new UNIMARC field 035 ? At BibLibre, we store the ppn in 009. If someone else uses this feature and wants to use another field, it will be possible to make this field configurable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:02:03 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:02:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:02:05 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 --- Comment #1 from Kyle M Hall --- Created attachment 35032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35032&action=edit Bug 13537 - Focus should move to barcode after renewing via checkouts table Koha's checkout screen automatically focuses on the barcode field each time it is loaded. Since we've moved the checkouts table functions for renewing and returning items to ajax methods, this page is no longer refreshed, and thus does not refocus to the barcode after performing those actions. This should be fixed so that renewing/returning items via the checkouts page moves the focus to the barcode field. Test Plan: 1) Find a patron with checkouts. 2) Renew or return a checkout, note the focus does not move to the barcode. 3) Apply this patch. 4) Renew or return a checkout, note the focus *does* move to the barcode. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:02:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:02:15 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:02:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:02:32 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:02:34 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 --- Comment #1 from M. de Rooy --- Created attachment 35033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35033&action=edit Bug 13536: Remove time from CHECKOUT notice In the issues table date_due is a datetime field. If you do not have hourly loans, the 23:59:00 on the CHECKOUT notice may be somewhat confusing. (When does the library close?) In the patch submitted I virtually add a date_due_without_time column to the issues table by adding such a field in the SELECT statement in Letters.pm, routine _parseletter_sth. If you want to remove the time from the notice, now you can just edit the notice and replace <> by <>. Test plan: [1] Edit CHECKOUT notice as described above. [2] Check out a book to a patron (notice enabled in his messaging prefs). [3] Check the notice: Do you only see the date, not the time? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:10:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:10:10 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:10:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:10:06 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:14:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:14:17 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 --- Comment #13 from Jonathan Druart --- Comment on attachment 30493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30493 [PASSED QA] Bug 11331 - CSV export for viewlog.pl is missing newlines Review of attachment 30493: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11331&attachment=30493) ----------------------------------------------------------------- ::: tools/viewlog.pl @@ +201,5 @@ > + my $csv = Text::CSV::Encoded->new( { encoding_out => 'utf8', sep_char => $delimiter } ); > + $csv or die "Text::CSV::Encoded->new FAILED: " . Text::CSV::Encoded->error_diag(); > + # First line with heading > + # Exporting bd id seems useless > + my @headings = grep { $_ ne 'action_id' } sort keys $data[0]; Raises an error with perl <= 5.10 Type of arg 1 to keys must be hash (not array element) at /home/koha/src/tools/viewlog.pl line 214, near "];" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:15:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:15:00 +0000 Subject: [Koha-bugs] [Bug 13538] New: viewlog explodes with perl < 5.10 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13538 Bug ID: 13538 Summary: viewlog explodes with perl < 5.10 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:15:49 +0000 Subject: [Koha-bugs] [Bug 13538] viewlog explodes with perl < 5.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 13522 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:15:49 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- *** Bug 13538 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:16:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:16:01 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11331 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:16:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:16:01 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13522 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:19:50 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:19:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:19:53 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34978|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 35034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35034&action=edit Bug 13522: Make it explicit that scalar containd a hash ref Prior to perl 5.12 keys can only operate on a hash. So although $data[0] ( thats an abysmal variable name! ) will contain a hash ref the perl compiler cannot deduce that from the context and gives a syntax error. Add the hash sigil to make the context explicit and the compiler can generate the correct code. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:20:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:20:37 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major Patch complexity|--- |Trivial patch --- Comment #4 from Jonathan Druart --- I had exactly the same patch. I consider this as major since the page is not accessible at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:21:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:21:17 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 --- Comment #5 from Jonathan Druart --- I tested it on a sandbox (perl 5.10.1). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:24:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:24:53 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:24:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:24:56 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35028|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 35035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35035&action=edit Bug 11239 - show hour of due date in history circulation The circulation history page (Patron -> Circulation history) does not show the time when displaying the date of checkout, due date, and check in. This patch adds the "with_hours => 1" flag to the KohaDates filter. To test, apply the patch and view the circulation history page for a patron with good circulation history data. Confirm that dates are displayed correctly with times and that date sorting still works correctly. Signed-off-by: marjorie Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:25:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:25:18 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 13:29:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 12:29:10 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 35036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35036&action=edit Bug 13532 - Unit tests for Bugg 13261 This patch adds unit tests to check against timeout of: checking in an Item from a debarred borrower (a borrower whose koha.borrowers.debarred-column has year 9999) timeouts the SIP-server. This is because creating a new DateTime for year 9999 takes forever. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 14:09:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 13:09:11 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 35037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35037&action=edit Bug 13025 - Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 This error only appears when using the SIPServer, it doesn't manifest when using the SIP unit tests or when using the staff client. -------------------- ------------------ PREPARE THE TEST ------------------ -------------------- 0a. Find a borrower. 0b. Find an Item (cardnumber 'debar123') and check-out to the borrower 0c. Find a borrower and add a manual debarrment to it, indefinetely in effect. This is the default behaviour. 0d. Configure and start a SIP-server which you can access with telnet. See http://wiki.koha-community.org/wiki/Koha_SIP2_server_setup In this example, the Borrower defined as the Check-out/in machine has the following credentials: username: herkules password: palautathan branchcode: JOE_JOE but you are free to use your own, it doesn't affect this test plan. 0e. access your server with telnet ----------------------- --------------------- REPLICATE THE ISSUE --------------------- ----------------------- 1. Paste the following SIP-command to login: 9300CNherkules|COpalautathan|CPJOE_JOE| 2. Paste the following SIP-command to check-in the Item of the debarred Borrower: 09N20140721 07501620140721 075016AP|AO|ABdebar123|AC|BIN| 3. The connection should die and in the SIP Server's error log you can find the following error: Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 -------------------- ------------------ AFTER THIS PATCH ------------------ -------------------- Redo steps 1-2. 3. No error is given and the connection doesn't die. No unit tests included and never will, because setting up the test environment would be very tedious. It is entirely possible but the scaffolding required is beyond the scope of this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 14:10:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 13:10:58 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 14:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 13:14:06 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13532, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13261 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 14:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 13:14:06 +0000 Subject: [Koha-bugs] [Bug 13532] Unit test for Bug 13261 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13532 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13025 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 14:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 13:14:06 +0000 Subject: [Koha-bugs] [Bug 13261] Better check in message for patrons with indefinite restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13261 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13025 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 15:16:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 14:16:57 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- I am curious to know why C4::Circulation does not see HasOverdues. The subroutine is exported from C4::Member, which is used in C4::Circ. What I missed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 15:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 14:37:20 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from M. de Rooy --- (In reply to Jonathan Druart from comment #3) > I am curious to know why C4::Circulation does not see HasOverdues. The > subroutine is exported from C4::Member, which is used in C4::Circ. > What I missed? Yeah, must be something strange in C4/SIP/.. ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 15:41:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 14:41:34 +0000 Subject: [Koha-bugs] [Bug 10631] Table alert should have a FK on borrowernumber and entries be deleted with the referenced borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10631 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13535 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 15:41:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 14:41:34 +0000 Subject: [Koha-bugs] [Bug 13535] Table alert is missing FK and not deleted with the patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13535 --- Comment #1 from Katrin Fischer --- *** Bug 10631 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 15:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 14:42:27 +0000 Subject: [Koha-bugs] [Bug 10633] Table suggestions needs some work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13533 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 15:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 14:42:27 +0000 Subject: [Koha-bugs] [Bug 13533] Table suggestions is missing FK constraints / borrowernumbers are kept on deletion of patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13533 --- Comment #1 from Katrin Fischer --- *** Bug 10633 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 15:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 14:42:44 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 16:10:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 15:10:10 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #3 from Colin Campbell --- I think this works ok for the self check but it would be good if it logged something in this case as we might need to track odd behaviour (e.g. bug 11039 ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 16:37:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 15:37:30 +0000 Subject: [Koha-bugs] [Bug 13539] New: Table patroncards not used? Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Bug ID: 13539 Summary: Table patroncards not used? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It appears that creating patroncard batches and printing those is not adding data to the patroncards table, but the creator_batches table is used for storing the information. Looking and searching the code I couldn't find where data is inserted in the patroncards table - is it possible the table is no longer in use? Maybe since the rewrite of the label creators? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 16:37:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 15:37:46 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 16:51:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 15:51:59 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #102 from Zeno Tajoli --- I setup acq to test this patch. I use a 'FILE' edi account. When I try to close the basket and create the request I see Software error: Can't call method "branchcode" on an undefined value at /home/koha/test_edi/Koha/Edifact/Order.pm line 374. The link used: http://192.168.216.128:8080/cgi-bin/koha/acqui/basket.pl?basketno=1&op=ediorder&ean=111222&booksellerid=1&confirm=1&basketgroupname=bask1 Generaly speaking I think we need more details on how to do test of this feature. For example: -- EAN/SAN, names for budgets, funds and vendors -- files of different types -- ect. I run those tests, but I think it is not enough to sign-off: prove Ediorder.t: OK prove EdiInvoice.t: OK prove Edifact.t: OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 17:20:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 16:20:50 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 --- Comment #5 from Olli-Antti Kivilahti --- I agree. The issue is very strange, but I have a gut feeling finding the root cause is not going to be easy. Regardless using implicit function calls is bad practice (imho) and the Perl manual somewhere says that the Perl compiler/interpreter tries it's best to do-the-right-thing TM but implicit declarations are not always dealt with as is expected to happen. I'll test some more whether breaking the multiline boolean soup will fix anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 17:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 16:33:11 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 --- Comment #6 from Olli-Antti Kivilahti --- !!!!! This is the original code !!!!! # Remove any OVERDUES related debarment if the borrower has no overdues if ( $borrowernumber&& $borrower->{'debarred'} && C4::Context->preference('AutoRemoveOverduesRestrictions') && !HasOverdues( $borrowernumber ) && @{ GetDebarments({ borrowernumber => $borrowernumber, type => 'OVERDUES' }) } ) { DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' }); } !!!!! I tried with this one, but got the same error !!!!! # Remove any OVERDUES related debarment if the borrower has no overdues if ( not(HasOverdues( $borrowernumber )) ) { DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' }); } !!!!! If someone knows what is the root cause, let me know :) !!!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 17:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 16:33:53 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 18:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 17:00:43 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #1 from Chris Nighswonger --- hmm... that table appears to be vestigial mysql> SELECT count(*) FROM patroncards; +----------+ | count(*) | +----------+ | 5 | +----------+ 1 row in set (0.00 sec) but the timestamps are from 2008 and grep shows no code referencing that table And so this table may safetly be removed, IMHO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 18:27:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 17:27:28 +0000 Subject: [Koha-bugs] [Bug 13540] New: Item's permanent_location is set to CART if an Item is edited when it's location is CART. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Bug ID: 13540 Summary: Item's permanent_location is set to CART if an Item is edited when it's location is CART. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com :-:TEST SETUP:-: 0a. System preference "ReturnToShelvingCart" must be 'Move'. 0b. Find any Item (I69) 0c. Set I69's location to "Book Cart" (BC) or anything but empty. :-:REPLICATE ISSUE:-: 1. Check-in the I69 and the location should turn to 'CART' (returned today). 2. Go to the "Edit Item"-view for I69, don't change anything, simply click "Save changes" 3. Observe that the permanent_location has changed to 'CART'. This is not good since now the location data is forever lost again (Bugg 7817). The "cart_to_shelf.pl --hours 24"-script cannot return the Item to the proper place ;( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 18:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 17:27:58 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART if an Item is edited when it's location is CART. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7817 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 18:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 17:27:58 +0000 Subject: [Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13540 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 19:32:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 18:32:09 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART if an Item is edited when it's location is CART. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35038&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. This bug is rather nasty as it happens very discreetly when editing Items that are in either locations 'CART' or 'PROC'. For example when changing one of the Item's statuses or barcode, the permanent_location gets overwritten without the user noticing it immediately. The damage becomes apparent only weeks later when there are potentially thousands of Items missing the permanent_location and location. :-:TEST SETUP:-: 0a. System preference "ReturnToShelvingCart" must be 'Move'. 0b. Find any Item (I69) 0c. Set I69's location to "Book Cart" (BC) or anything but empty. :-:REPLICATE ISSUE:-: 1. Check-in the I69 and the location should turn to 'CART' (returned today). 2. Go to the "Edit Item"-view for I69, don't change anything, simply click "Save changes" 3. Observe that the permanent_location has changed to 'CART'. This is not good since now the location data is forever lost again (Bugg 7817). The "cart_to_shelf.pl --hours 24"-script cannot return the Item to the proper place ;( :-:AFTER THIS PATCH:-: Repeat steps 1-2. 3. Observe that the permanent_location is still the old one, instead of getting overwritten by 'CART'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 19:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 18:32:31 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item's permanent_location |Item's permanent_location |is set to CART if an Item |is set to CART|PROC if an |is edited when it's |Item is edited when it's |location is CART. |location is CART|PROC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 19:32:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 18:32:51 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Olli-Antti Kivilahti --- Unit tests to follow, gotta go home! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 19:38:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 18:38:30 +0000 Subject: [Koha-bugs] [Bug 5592] circ rule cloning can be dangerous In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5592 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 23:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 22:25:17 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- Should this be signed off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 23:28:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 22:28:13 +0000 Subject: [Koha-bugs] [Bug 10459] borrowers should have a timestamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #14 from Katrin Fischer --- I am looking for a way to determine easily when a patron was deleted, I think a timestamp in deletedborrowers would help a lot with that. So keen on seeing this move :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 8 23:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 22:51:27 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #92 from Jesse Weaver --- (In reply to Zeno Tajoli from comment #91) > Hi Jesse and all, > > my boss tells that we need to help as much as possible to insert this > feature in master. > Now the code is in "Failed QA" status. > In which direction do you want to port the code ? > Do you want to drop the use of Pazpar ? > > Bye Yes, I would. There's a basic metasearch that I added to bug 11559 that, while not perfect, is much more reliable than pazpar2. The one feature that it eliminates is on-the-fly merging; aka, how the current interface shows results as they come in. It also has slightly lower limits on how many records it can fetch, being written in pure Perl. Are either of these dealbreakers? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 00:27:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Jan 2015 23:27:13 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 01:35:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 00:35:07 +0000 Subject: [Koha-bugs] [Bug 13541] New: Cannot log in Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13541 Bug ID: 13541 Summary: Cannot log in Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: andersonhemmat at comcast.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Hello, since the first of the year we have not been able to login to our account. It is an old version of Koha. It says "invalid login" but I am certain we are entering our existing login. Please help. I cannot find any other way to contact Koha. Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 02:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 01:57:03 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #15 from David Cook --- (In reply to Katrin Fischer from comment #14) > > I am not sure about using | as a separator, it looks quite uncommon. > > Still not sure, but not opposed :) Maybe if we would put it in a span with a > class Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:22:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:22:58 +0000 Subject: [Koha-bugs] [Bug 13543] New: Differences in patron account sidebar cause translation problems Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13543 Bug ID: 13543 Summary: Differences in patron account sidebar cause translation problems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org There are some differences between the 2 files used to generate the side navigation tabs in the patron account that cause a prominently visible translation problem: Good: intranet-tmpl/prog/en/includes/circ-menu.inc:86 Purchase suggestions Bad: intranet-tmpl/prog/en/includes/circ-menu.tt:85 purchase
    suggestions The
    causes the entry to be split up into 2 separate strings in translation so the correct translation of "Anschaffungsvorschl?ge" is not possible for German (and possible other languages?) I think the break was added, bacause one of the navigations is indeed a bit narrower than the other, which also causes a problem with the correct translation "Anschaffungsvorschl?ge" that is too wide for the narrower version of the two. Small thing, but really annoying as this is in a central spot in the patron account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:23:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:23:31 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35042|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 35043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35043&action=edit [PASSED QA] Bug 11927 - Add gr install option Add greek as lang definition in installer. Developed in collaboration with Giannis Kourmoulis Test plan : - Install using "gr" in "Primary language for Zebra indexing" - check gr is used in etc/zebradb/zebra-*.cfg Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:23:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:23:42 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #22 from Kyle M Hall --- Created attachment 35044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35044&action=edit [PASSED QA] Bug 11927 - Add greek chr lang_def file Add the sort-string-utf.chr for sorting Greek catalog (it can also contain latin records). Developped in collaboration with Giannis Kourmoulis Test plan : - Install using "gr" in "Primary language for Zebra indexing" - Index a greek catalog - Sort by title and check sorting is correct Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:23:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:23:45 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #23 from Kyle M Hall --- Created attachment 35045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35045&action=edit [PASSED QA] Bug 11927 - Add greek to word-phrase-utf.chr Add greek support in word-phrase-utf.chr for searching in a Greek catalog (it can also contain latin records). Developped in collaboration with Giannis Kourmoulis Test plan : - Install using CHR zebra indexing - Index a greek catalog - Look for results with mixed uppercase, lowercase and diacritics in title Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:23:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:23:47 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #24 from Kyle M Hall --- Created attachment 35046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35046&action=edit [PASSED QA] Bug 11927 - Small corrections on word-phrase-utf.chr Small fixes : more space characters : ?? uppercase AE missing in equivalent some trailling spaces Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:28:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:28:01 +0000 Subject: [Koha-bugs] [Bug 13543] Differences in patron account sidebar cause translation problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13543 --- Comment #1 from Katrin Fischer --- For easier testing: The fines tab uses the problematic template! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:36:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:36:37 +0000 Subject: [Koha-bugs] [Bug 13543] Differences in patron account sidebar cause translation problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13543 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11804 CC| |pasi.kallinen at pttk.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:36:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:36:37 +0000 Subject: [Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13543 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:42:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:42:22 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 35047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35047&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC when... - Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:45:50 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Patch complexity|--- |Trivial patch Priority|P5 - low |P2 Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | --- Comment #4 from Olli-Antti Kivilahti --- Setting importance to Major P2, because this causes real loss of data in a very conspicious manner. Repairing the damage afterwards can be impossible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:47:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:47:48 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:47:51 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34405|0 |1 is obsolete| | Attachment #34406|0 |1 is obsolete| | Attachment #34407|0 |1 is obsolete| | Attachment #34408|0 |1 is obsolete| | Attachment #34409|0 |1 is obsolete| | Attachment #34410|0 |1 is obsolete| | Attachment #34411|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall --- Created attachment 35048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35048&action=edit [PASSED QA] Bug 12404: Add UT for marcrecord2csv Verify that these unit tests pass before any changes and after applying all patches. Signed-off-by: Courret Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:47:58 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #52 from Kyle M Hall --- Created attachment 35049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35049&action=edit [PASSED QA] Bug 12404: Add new unit tests These unit tests reflect the changes done in next patches. Signed-off-by: Courret Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:48:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:48:01 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #53 from Kyle M Hall --- Created attachment 35050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35050&action=edit [PASSED QA] Bug 12404: Allow TT tags for csv profiles This patch is the main patch. It contains the changes in C4::Record::marcrecord2csv. The goal of this development is to provide a better flexibility on creating a CSV profile. Currently it is not possible to: - Concatenate specific subfields into a csv column - Display a field/subfield using a condition - Extract a substring of a subfield value and a lot of other actions. This patch allows to write Template Toolkit code and to extract only data you want. See the help page for more information (in next patch). Test plan: Create some CSV profiles (MARC, not SQL) using some TT methods. Use the basket export and the export tool and verify the CSV file generated is what you expected. Signed-off-by: Courret Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:48:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:48:04 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #54 from Kyle M Hall --- Created attachment 35051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35051&action=edit [PASSED QA] Bug 12404: tools/export.pl allows CSV export Signed-off-by: Courret Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:48:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:48:07 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #55 from Kyle M Hall --- Created attachment 35052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35052&action=edit [PASSED QA] Bug 12404: Add some documentation in the help page. Signed-off-by: Courret Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:48:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:48:09 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #56 from Kyle M Hall --- Created attachment 35053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35053&action=edit [PASSED QA] Bug 12404: Allow equal sign '=' in the TT directive Signed-off-by: Courret Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:48:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:48:12 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #57 from Kyle M Hall --- Created attachment 35054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35054&action=edit [PASSED QA] Bug 12404: FIX documentation to join subfield To display all subfields, the join TT method must be used. Signed-off-by: Courret Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:48:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:48:48 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Olli, we barely use the P* values, I have upped this to critical. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 13:50:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 12:50:09 +0000 Subject: [Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Good catch, thx for linking to the other bug paxed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:07:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:07:17 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35047|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 35055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35055&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC when... - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:18:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:18:31 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:18:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:18:33 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34487|0 |1 is obsolete| | Attachment #34488|0 |1 is obsolete| | Attachment #34489|0 |1 is obsolete| | Attachment #34490|0 |1 is obsolete| | Attachment #34491|0 |1 is obsolete| | Attachment #34492|0 |1 is obsolete| | Attachment #34493|0 |1 is obsolete| | Attachment #34494|0 |1 is obsolete| | Attachment #34495|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall --- Created attachment 35056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35056&action=edit [PASSED QA] Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:20:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:20:27 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34779|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 35057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35057&action=edit Bug 13459: Fix datatables paging for admin > itemtypes To test: - Go to administration > itemtypes - Verify the display of the paging options is broken - Apply patch - Verify the display is now correct and works nicely Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:20:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:20:51 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35056|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall --- Created attachment 35058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35058&action=edit [PASSED QA] Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:21:19 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35058|0 |1 is obsolete| | --- Comment #52 from Kyle M Hall --- Created attachment 35059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35059&action=edit [PASSED QA] Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:21:26 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #53 from Kyle M Hall --- Created attachment 35060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35060&action=edit [PASSED QA] Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:21:29 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #54 from Kyle M Hall --- Created attachment 35061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35061&action=edit [PASSED QA] Bug 12648: The users added to basket should have a permission Before this enh, the users to add to a basket should have the acquisition.order_manage permission. This patch reintroduces this behavior. The code in acqui/add_user_search.pl was never used. The filter should be done in the members/search service. But it is not possible easily to filter using a sql query, so the filter is done after. This means that we cannot use the DT pagination (otherwise the results will become inconsistent). Test plan: 1/ On adding patrons to a basket, verify that the search patron results contain patron with the acquisition.order_manage permission. 2/ Verify that all patrons are return on the 'normal' patron search and when adding patrons to an order. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:21:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:21:31 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #55 from Kyle M Hall --- Created attachment 35062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35062&action=edit [PASSED QA] Bug 12648: Fix conflict with bug 12833 Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:21:34 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #56 from Kyle M Hall --- Created attachment 35063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35063&action=edit [PASSED QA] Bug 12648: Hide the result search on load When no search has been done yet, it's not necessary to display the result list. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:21:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:21:37 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #57 from Kyle M Hall --- Created attachment 35064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35064&action=edit [PASSED QA] Bug 12648: The patron's name should be the same as before The displayed patron's name should be surname + firstname Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:21:39 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #58 from Kyle M Hall --- Created attachment 35065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35065&action=edit [PASSED QA] Bug 12648: Add the new 'Acquisition' entry in the letter module list Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:21:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:21:42 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #59 from Kyle M Hall --- Created attachment 35066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35066&action=edit Bug 12648 - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:27:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:27:50 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #60 from Katrin Fischer --- I like this! Should we add a default letter (separate bug)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:40:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:40:54 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #21 from Kyle M Hall --- Created attachment 35067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35067&action=edit Bug 13364 - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:55:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:55:02 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34487|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:55:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:55:32 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #61 from Jonathan Druart --- (In reply to Katrin Fischer from comment #60) > I like this! Should we add a default letter (separate bug)? The patch existed but it has been obsoleted (certainly a mistake). I reintroduced it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 14:56:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 13:56:06 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:23:16 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:24:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:24:44 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34798|0 |1 is obsolete| | --- Comment #80 from Tom?s Cohen Arazi --- Created attachment 35068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35068&action=edit [SIGNED OFF] Bug 13264: UNIMARC and MARC21 records to test UTF-8 The records shares enough chars to do the same search ('deuteros') to find them and check the same utf-8 chars. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:25:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:25:00 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34799|0 |1 is obsolete| | --- Comment #81 from Tom?s Cohen Arazi --- Created attachment 35069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35069&action=edit [SIGNED OFF] Bug 13264: Test for utf-8 on Opac search This test need to setup zebraserver and background indexing. You need to set also KOHA_INTRANET_URL and KOHA_OPAC_URL in the user enviroment. It imports sample records and retrieves them on hte OPAC through Apache. To run it: prove opac_utf8.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:25:17 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34800|0 |1 is obsolete| | --- Comment #82 from Tom?s Cohen Arazi --- Created attachment 35070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35070&action=edit [SIGNED OFF] Bug 13264: Test for utf-8 on authorised values input/display/delete This test check utf-8 support on web intranet interface for authorized values. It test input, search and delete of utf-8 values. If all OK it destroy values inserted Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:25:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:25:29 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34801|0 |1 is obsolete| | --- Comment #83 from Tom?s Cohen Arazi --- Created attachment 35071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35071&action=edit [SIGNED OFF] Bug 13264: no need to test for MySQL This patch removes the test for a running MySQL process. It is already implied by successfuly loading C4::Context. It also fixes the license text. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:25:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:25:43 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34802|0 |1 is obsolete| | --- Comment #84 from Tom?s Cohen Arazi --- Created attachment 35072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35072&action=edit [SIGNED OFF] Bug 13264: Make opac_utf8.t launch its own helper processes This patch makes opac_utf8.t launch its own: - zebrasrv process - rebuild_zebra.pl (daemon mode) It also takes care of killing them when finished. It sets a frecquency of 5 seconds for the indexer, and waits 10 just in case before looking for the indexed records. To test: - Just launch the tests. Edit: fixes on the license text. Regards Tomas Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:25:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:25:55 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34803|0 |1 is obsolete| | --- Comment #85 from Tom?s Cohen Arazi --- Created attachment 35073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35073&action=edit [SIGNED OFF] Bug 13264: Follow up: in opac_utf8.t insert also delete of biblio In previous version of the test opac_utf8.t clears import from resevoir but it doesn't delete record from biblio table in MySQL. This the standard work of the feature, see: http://manual.koha-community.org/3.18/en/catalogtools.html#managestaged Now the script deletes also record on MySQL level. No necessary on Zebra level because it uses a temporaney Zebra index that it is clenaned at the end of the script. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:26:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:26:10 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34804|0 |1 is obsolete| | --- Comment #86 from Tom?s Cohen Arazi --- Created attachment 35074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35074&action=edit [SIGNED OFF] Bug 13264: Additional test for search in intranet calatogue The utf-8 test do: insert a biblio record with tool, search the record in intranet, delete batch upload and biblio records. To test: prove intranet_search_utf8.t Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:26:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:26:22 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34805|0 |1 is obsolete| | --- Comment #87 from Tom?s Cohen Arazi --- Created attachment 35075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35075&action=edit [SIGNED OFF] Bug 13264: Refactor search utf8 tests and add some more t/db_dependent/www/search_utf8.t and t/db_dependent/www/intranet_search_utf8.t were quite similar, I merged them into a single file (t/db_dependent/www/search_utf8.t). On the way, I added some tests for them. Note that you will need the last patch on branch bug_11944 to see the tests pass. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:26:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:26:42 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34806|0 |1 is obsolete| | --- Comment #88 from Tom?s Cohen Arazi --- Created attachment 35076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35076&action=edit [SIGNED OFF] Bug 13264: (QA followup) prevent double-encoding on the tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:26:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:26:57 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34807|0 |1 is obsolete| | --- Comment #89 from Tom?s Cohen Arazi --- Created attachment 35077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35077&action=edit [SIGNED OFF] Bug 13264: Add more records to the marc21 aand unimarc files Dupliacate record in marc21 and unimarc files, so the search finds always more than one result. http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:27:02 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #20 from Jonathan Druart --- Kyle, the patches apply cleanly here. They depends on bug 13007. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:27:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:27:45 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34808|0 |1 is obsolete| | --- Comment #90 from Tom?s Cohen Arazi --- Created attachment 35078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35078&action=edit [SIGNED OFF] Bug 13264: Add tests for Latin-1 vs. UTF-8 deduction add a test in auth_values_input_www to check chars that could be Latin-1 or UTF-8 http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:28:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:28:01 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34809|0 |1 is obsolete| | --- Comment #91 from Tom?s Cohen Arazi --- Created attachment 35079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35079&action=edit [SIGNED OFF] Bug 13264: Add Latin-1 vs UTF-8 test specific records This patch addes two new files .mrc for marc21 and unimarc to test chars in utf8/latin-1 section only, to be sure that perl doesn't switch between utf-8 nad ISO 8859-1 inside itself. http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:28:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:28:12 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34810|0 |1 is obsolete| | --- Comment #92 from Tom?s Cohen Arazi --- Created attachment 35080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35080&action=edit [SIGNED OFF] Bug 13264: Update of unimarc and marc21 record to search publisher http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:28:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:28:23 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34811|0 |1 is obsolete| | --- Comment #93 from Tom?s Cohen Arazi --- Created attachment 35081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35081&action=edit [SIGNED OFF] Bug 13264: More tests for Latin-1 vs. UTF-8 interpretation New tests in search_utf8.t, now are tested also records with only utf-8 chars that could see also as latin-1 chars http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:28:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:28:37 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34814|0 |1 is obsolete| | --- Comment #94 from Tom?s Cohen Arazi --- Created attachment 35082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35082&action=edit [SIGNED OFF] Bug 13264: Follow up on record files: deleted fields (952/995) with items info To insert items info you need to use correct code of sublibrary, not always the code is correct. Items info are not important for this test, so the fields are deleted (952 in MARC21, 995 in UNIMARC) http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:29:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:29:26 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:38:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:38:57 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Test about UTF-8 (bug |Full stack encoding tests |11944) |(UTF-8) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:39:35 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Sorry for this bug. In the same context, have a look at admin/auth_subfields_structure.pl, Line 102 : my @authtypes = (sort keys getauthtypes); getauthtypes return a harsh ref, not a hash. Is it also a dangerous code ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:40:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:40:54 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:40:57 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34743|0 |1 is obsolete| | Attachment #34744|0 |1 is obsolete| | Attachment #34942|0 |1 is obsolete| | Attachment #34943|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 35083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35083&action=edit [PASSED QA] Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:41:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:41:06 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #26 from Kyle M Hall --- Created attachment 35084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35084&action=edit [PASSED QA] Bug 13417: Limit the permission to delete It's preferable to limit the permission to delete shelves. Apply both patches before testing, then follow this test plan Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to delete all public lists Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:41:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:41:09 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #27 from Kyle M Hall --- Created attachment 35085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35085&action=edit [PASSED QA] Bug 13417: (qa follow-up) Rename the permission to delete_public_lists Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:41:11 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #28 from Kyle M Hall --- Created attachment 35086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35086&action=edit [PASSED QA] Bug 13417: Add the permission for all languages Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:42:14 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #29 from Kyle M Hall --- QA Note: One koha-qa.pl failure. AFAICT is not introduced by this patch set. FAIL C4/VirtualShelves.pm OK critic OK forbidden patterns OK pod FAIL valid Constant subroutine C4::VirtualShelves::SHELVES_COMBO_MAX redefined Constant subroutine C4::VirtualShelves::SHELVES_MGRPAGE_MAX redefined Constant subroutine C4::VirtualShelves::SHELVES_MASTHEAD_MAX redefined Constant subroutine C4::VirtualShelves::SHARE_INVITATION_EXPIRY_DAYS redefined Constant subroutine C4::VirtualShelves::SHELVES_POPUP_MAX redefined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:44:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:44:38 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 --- Comment #8 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #6) > !!!!! I tried with this one, but got the same error !!!!! > # Remove any OVERDUES related debarment if the borrower has no overdues > if ( not(HasOverdues( $borrowernumber )) ) { > DelUniqueDebarment({ borrowernumber => $borrowernumber, type => > 'OVERDUES' }); > } > > > !!!!! If someone knows what is the root cause, let me know :) !!!!! I don't understand the problem here. The error comes from HasOverdues, and it is still called in this code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:50:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:50:45 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:50:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:50:49 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 --- Comment #9 from Jonathan Druart --- Created attachment 35087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35087&action=edit Bug 13025 - Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 This error only appears when using the SIPServer, it doesn't manifest when using the SIP unit tests or when using the staff client. -------------------- ------------------ PREPARE THE TEST ------------------ -------------------- 0a. Find a borrower. 0b. Find an Item (cardnumber 'debar123') and check-out to the borrower 0c. Find a borrower and add a manual debarrment to it, indefinetely in effect. This is the default behaviour. 0d. Configure and start a SIP-server which you can access with telnet. See http://wiki.koha-community.org/wiki/Koha_SIP2_server_setup In this example, the Borrower defined as the Check-out/in machine has the following credentials: username: herkules password: palautathan branchcode: JOE_JOE but you are free to use your own, it doesn't affect this test plan. 0e. access your server with telnet ----------------------- --------------------- REPLICATE THE ISSUE --------------------- ----------------------- 1. Paste the following SIP-command to login: 9300CNherkules|COpalautathan|CPJOE_JOE| 2. Paste the following SIP-command to check-in the Item of the debarred Borrower: 09N20140721 07501620140721 075016AP|AO|ABdebar123|AC|BIN| 3. The connection should die and in the SIP Server's error log you can find the following error: Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 -------------------- ------------------ AFTER THIS PATCH ------------------ -------------------- Redo steps 1-2. 3. No error is given and the connection doesn't die. No unit tests included and never will, because setting up the test environment would be very tedious. It is entirely possible but the scaffolding required is beyond the scope of this patch. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Note: I did not test this patch with SIP, but I did not find any regression on checking or renewing an item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:51:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:51:25 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #16 from Winona Salesky --- This sounds like a good resolution. Thanks! -Winona -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:53:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:53:27 +0000 Subject: [Koha-bugs] [Bug 13544] New: admin/auth_subfields_structure.pl does not compile in older perls Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Bug ID: 13544 Summary: admin/auth_subfields_structure.pl does not compile in older perls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:53:49 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13522 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 15:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 14:53:49 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13544 --- Comment #8 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #7) > Sorry for this bug. > > In the same context, have a look at admin/auth_subfields_structure.pl, Line > 102 : > my @authtypes = (sort keys getauthtypes); > getauthtypes return a harsh ref, not a hash. > Is it also a dangerous code ? Good catch, I have opened bug 13544. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:04:14 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:04:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:04:17 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 --- Comment #1 from Jonathan Druart --- Created attachment 35088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35088&action=edit Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:04:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:04:32 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:10:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:10:51 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #30 from Jonathan Druart --- (In reply to Kyle M Hall from comment #29) > QA Note: One koha-qa.pl failure. AFAICT is not introduced by this patch set. Hum, actually yes, it comes from this patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:12:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:12:28 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #31 from Jonathan Druart --- Created attachment 35089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35089&action=edit Bug 13417: Remove warnings Without this patch perl -wc C4/VirtualShelves.pm failed: Constant subroutine C4::VirtualShelves::SHELVES_MASTHEAD_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_COMBO_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_MGRPAGE_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_POPUP_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHARE_INVITATION_EXPIRY_DAYS redefined at /usr/share/perl/5.20/constant.pm line 156. Subroutine GetShelves redefined at C4/VirtualShelves.pm line 103. Subroutine GetAllShelves redefined at C4/VirtualShelves.pm line 159. Subroutine GetSomeShelfNames redefined at C4/VirtualShelves.pm line 189. Subroutine GetShelf redefined at C4/VirtualShelves.pm line 230. Subroutine GetShelfContents redefined at C4/VirtualShelves.pm line 262. Subroutine AddShelf redefined at C4/VirtualShelves.pm line 315. Subroutine AddToShelf redefined at C4/VirtualShelves.pm line 353. Subroutine ModShelf redefined at C4/VirtualShelves.pm line 394. Subroutine ShelfPossibleAction redefined at C4/VirtualShelves.pm line 454. Subroutine DelFromShelf redefined at C4/VirtualShelves.pm line 545. Subroutine DelShelf redefined at C4/VirtualShelves.pm line 589. Subroutine GetBibliosShelves redefined at C4/VirtualShelves.pm line 603. Subroutine ShelvesMax redefined at C4/VirtualShelves.pm line 628. Subroutine HandleDelBorrower redefined at C4/VirtualShelves.pm line 648. Subroutine AddShare redefined at C4/VirtualShelves.pm line 683. Subroutine AcceptShare redefined at C4/VirtualShelves.pm line 703. Subroutine IsSharedList redefined at C4/VirtualShelves.pm line 731. Subroutine RemoveShare redefined at C4/VirtualShelves.pm line 750. Subroutine _shelf_count redefined at C4/VirtualShelves.pm line 764. Subroutine _CheckShelfName redefined at C4/VirtualShelves.pm line 788. C4/VirtualShelves.pm syntax OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:24:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:24:07 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:24:10 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34986|0 |1 is obsolete| | Attachment #34987|0 |1 is obsolete| | Attachment #34988|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 35090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35090&action=edit Bug 5144 [1] - Unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:24:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:24:17 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #16 from Kyle M Hall --- Created attachment 35091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35091&action=edit Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:24:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:24:19 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #17 from Kyle M Hall --- Created attachment 35092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35092&action=edit Bug 5144 [3] - Add message for patron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:24:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:24:22 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #18 from Kyle M Hall --- Created attachment 35093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35093&action=edit Bug 5144 [4] [QA Followup] - Fix message error and language used -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:26:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:26:08 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 R. Crago changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ridingthegravytrain at yahoo.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:26:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:26:46 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 R. Crago changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ridingthegravytrain at yahoo.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 16:27:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 15:27:15 +0000 Subject: [Koha-bugs] [Bug 11463] GetItem must use item-level_itypes syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 R. Crago changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ridingthegravytrain at yahoo.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 17:40:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 16:40:28 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 17:40:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 16:40:23 +0000 Subject: [Koha-bugs] [Bug 13545] New: Add barcode image generator service Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Bug ID: 13545 Summary: Add barcode image generator service Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 17:48:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 16:48:59 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 17:49:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 16:49:01 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #1 from Kyle M Hall --- Created attachment 35094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35094&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 18:02:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 17:02:39 +0000 Subject: [Koha-bugs] [Bug 13546] New: Branch transfer records orphaned when an item is withdrawn Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13546 Bug ID: 13546 Summary: Branch transfer records orphaned when an item is withdrawn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It is possible to withdraw an item that has an outstanding branch transfer, leaving an uncompleted branch transfer record. To reproduce: 1) Check in an item whose home branch is not the current branch 2) Confirm the transfer 3) Set the item to 'withdrawn' 4) Check the branch transfers table -- the branch transfer will still exist, even though the item is withdrawn (i.e. not in circulation). See Also: 12362 Branch transfer records orphaned on cancelled holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 18:02:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 17:02:44 +0000 Subject: [Koha-bugs] [Bug 13547] New: Item field 3 (Materials specified) would be useful to see on OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Bug ID: 13547 Summary: Item field 3 (Materials specified) would be useful to see on OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org The Materials specified (field 3) is show on the staff catalog in each item row in the record view, but not on the patron side. This would be helpful to see on the patron side. As it is now, patrons can see one general description of items in the bib record from field 300e. However, if there were some minor discrepancies between items (fewer discs, no bonus disc), your choices here are to either hope no one cares, or create a separate bib record. With this item field showing, you could list minor material differences. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 18:04:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 17:04:28 +0000 Subject: [Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 --- Comment #1 from Barton Chittenden --- See also Bug 13546 - Branch transfer records orphaned when an item is withdrawn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 18:13:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 17:13:12 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35094|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 35095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35095&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 20:43:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 19:43:24 +0000 Subject: [Koha-bugs] [Bug 13548] New: "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548 Bug ID: 13548 Summary: "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Partner wants to decrease the length of loans when *any* items are checked out. Setting 'decreaseLoahHighHolds' system preferences as follows: +-------------------------------+------------+ | variable | value | +-------------------------------+------------+ | decreaseLoanHighHolds | 1 [Enable] | | decreaseLoanHighHoldsDuration | 14 | | decreaseLoanHighHoldsValue | 0 | +-------------------------------+------------+ This shows on the system preferences screen as follows: [Enable] the reduction of loan period to [14] days for items with more than [0] holds. Checking out *any* item (regardless of whether or not it has holds) will trigger the following message: High demand item. Loan period shortened to 0 days (due ). Check out anyway? According to the system preferences description, this should not be triggered unless there is at least one hold. According to the partner, if decreaseLoanHighHoldsValue is set to 1, High Holds isn't triggered until an item is checked out that has two holds placed, meaning that it's impossible to trigger at exactly 1 hold placed. when decreaseLoanHighHoldsValue is 0, the loan period is *not* shortened, even though the message pops up. The description of decreaseLoanHighHoldsDuration is also misleading: [Enable] the reduction of loan period to [decreaseLoanHighHoldsDuration] days should read [Enable] the reduction of loan period by [decreaseLoanHighHoldsDuration] days because, the loan period is not set to a constant 'decreaseLoanHighHoldsDuration' days; rather it is decremented by that amount. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 22:18:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 21:18:38 +0000 Subject: [Koha-bugs] [Bug 13549] New: Add cardnumber to overdue circulation report overdue.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Bug ID: 13549 Summary: Add cardnumber to overdue circulation report overdue.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 35096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35096&action=edit overdue_report Hi, It would be fine to see borrower's cardnumber on overdue circulation report in patron column. Thanks. Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 22:43:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 21:43:20 +0000 Subject: [Koha-bugs] [Bug 13550] New: Automatic processing status Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13550 Bug ID: 13550 Summary: Automatic processing status Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be great if Koha had the ability to flag items based on criteria for automatic processing. For example, lets say you have a collection that rotates libraries. It would be great to have some way to flag that collection, and when criteria is met, and the item is checked in, it is put into a predetermined processing status and handed off rather than going back out on the shelves. Perhaps new items have a short loan period, and after a certain length of time in the collection, it needs to be changed. It could be flagged to either automatically change to a new loan period, or if it needs to be handled for processing (labels and such), it could be flagged for processing. Perhaps you have items that need to be reset, or batteries to be replaced, either every time it comes in or on a set interval. It could be flagged for processing. It would also be beneficial to have reports on flagged items past due, for items that have not necessarily circed. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 23:04:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 22:04:59 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 9 23:18:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 22:18:18 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Nick Clemens ---

    Something went wrong !

    Applying: Bug 12532 - Redirect guarantee email to guarantor Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Letters.pm Auto-merging C4/Members.pm Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 00:06:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 23:06:09 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 00:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 23:06:12 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34956|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 35097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35097&action=edit [SIGNED OFF] Bug 13516 - Tidy relevant code block Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 00:06:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Jan 2015 23:06:27 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34957|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 35098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35098&action=edit [SIGNED OFF] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Signed-off-by: Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 04:04:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 03:04:38 +0000 Subject: [Koha-bugs] [Bug 13551] New: Add the ability to sort results on cataloguing (addbooks.pl) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13551 Bug ID: 13551 Summary: Add the ability to sort results on cataloguing (addbooks.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, It would be nice to have the ability to sort results on cataloguing (addbooks.pl). Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 08:33:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 07:33:28 +0000 Subject: [Koha-bugs] [Bug 13552] New: Added: debarredcomment and debarreddate in batch patrons modification Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Bug ID: 13552 Summary: Added: debarredcomment and debarreddate in batch patrons modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org Added: debarredcomment and debarreddate in batch patrons modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 08:33:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 07:33:36 +0000 Subject: [Koha-bugs] [Bug 13552] Added: debarredcomment and debarreddate in batch patrons modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 08:34:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 07:34:39 +0000 Subject: [Koha-bugs] [Bug 13552] Added: debarredcomment and debarreddate in batch patrons modification In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com, | |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 09:42:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 08:42:16 +0000 Subject: [Koha-bugs] [Bug 13553] New: Save to your lists show extra unwanted titles Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13553 Bug ID: 13553 Summary: Save to your lists show extra unwanted titles Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: mowat at hmamail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 09:49:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 08:49:12 +0000 Subject: [Koha-bugs] [Bug 13553] Save to your lists show extra unwanted titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13553 --- Comment #1 from mowat at hmamail.com --- When I attempt to save a title to one of my lists, I frequently see extra titles I didn't select under Add items to a list. If I try again after refreshing the page and clicking Save to your lists I'll see even more unwanted titles. These extra titles appear to be originating from other Koha users. It's like Koha is assigning a timestamp of some kind and expecting it to be unique, without checking if the selected titles are coming in from different users/IPs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 20:06:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 19:06:52 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- What Perl version? I have the feeling that it should be fixed on SIP code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 20:10:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 19:10:06 +0000 Subject: [Koha-bugs] [Bug 11668] Untranslatable "Total" in borrowers stats and other reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- I'm not sure about the approach. We've been making an effort to remove the whole strings from the code, and there's no current workflow for including this .po on the translation processs... I'll mark it as In-Discussion, and probably try to post a counter-patch that avoids Koha::i18n. I'm open to discuss it on a dev meeting soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 20:18:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 19:18:34 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 20:19:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 19:19:01 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 20:19:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 19:19:27 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 20:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 19:19:58 +0000 Subject: [Koha-bugs] [Bug 13318] C4::Acq::GetParcel is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 20:20:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 19:20:27 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 20:21:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 19:21:05 +0000 Subject: [Koha-bugs] [Bug 12868] GetMemberDetails calls GetMemberAccountRecords incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12868 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Mark! AGJ345 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 10 22:43:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Jan 2015 21:43:44 +0000 Subject: [Koha-bugs] [Bug 12372] feature request: debian/scripts/koha-mysql should be able to handle arbitrary mysql arguments. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 Ian Bays changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.bays at ptfs-europe.com --- Comment #1 from Ian Bays --- Just to add support for this request as simple things like using -N to suppress column headings is not possible once at the mysql prompt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 11 08:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 07:45:39 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 11 08:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 07:59:50 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 11 09:06:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 08:06:39 +0000 Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #19 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 11 09:12:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 08:12:02 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #18 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 11 23:04:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 22:04:29 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #257 from Katrin Fischer --- Tried to apply this for testing the tests, but it won't apply. The branch also seems outdated. Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 11 23:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 22:06:02 +0000 Subject: [Koha-bugs] [Bug 13541] Cannot log in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13541 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Julie, please bring this to the mailing list as more people will see it there. Please also give the version of Koha you are using! Thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 11 23:13:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 22:13:20 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Not sure how to test this, my system uses perl 5.18, but I found no regressions in editing the authority frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 00:19:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 23:19:40 +0000 Subject: [Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #22 from Robin Sheat --- (In reply to Tom?s Cohen Arazi from comment #21) > Patch pushed to master. > > Thanks Jonathan! This causes tests to fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 00:21:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 23:21:10 +0000 Subject: [Koha-bugs] [Bug 13554] New: Bug 12969 introduces a test case that fails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Bug ID: 13554 Summary: Bug 12969 introduces a test case that fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Context.pm line 785 Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Context.pm line 785. Compilation failed in require at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Letters.pm line 27. BEGIN failed--compilation aborted at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Letters.pm line 27. Compilation failed in require at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Suggestions.pm line 30. BEGIN failed--compilation aborted at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Suggestions.pm line 30. Compilation failed in require at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Acquisition.pm line 27. BEGIN failed--compilation aborted at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Acquisition.pm line 27. Compilation failed in require at t/Prices.t line 5. BEGIN failed--compilation aborted at t/Prices.t line 5. # Looks like your test exited with 255 before it could output anything. t/Prices.t .......................... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 00:21:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 23:21:41 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12969 CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12969 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 00:21:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Jan 2015 23:21:41 +0000 Subject: [Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13554 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13554 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 01:13:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 00:13:38 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 01:15:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 00:15:07 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 07:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 06:24:10 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Katrin Fischer --- Hm, the new patch does cause some weird side effects. When I access the bookseller parcels page via 'receive shipment' the old shipments/open invoices don't show up. I think it's the same problem I've run into trying to avoid using C4::Dates, Koha::DateUtils date_to_string returns not only the date and it will also return "now" if no date is given: 2015-01-12T07:13:11 And that won't work in the SQL. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 07:30:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 06:30:19 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #11 from Katrin Fischer --- I am still not sure how to reformat a date formatted to our dateformat pref and convert to iso format :( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 07:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 06:37:35 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #12 from Katrin Fischer --- ... not using C4::Dates. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 07:41:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 06:41:21 +0000 Subject: [Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be useful to see on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think it would be good to make this optional and not turn on by default for existing installation as the field might have been used to store informaton that should not be visible for patrons in the OPAC in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 07:43:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 06:43:43 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 07:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 06:48:58 +0000 Subject: [Koha-bugs] [Bug 13553] Save to your lists show extra unwanted titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13553 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Which version of Koha are you using? Are there steps this can be reprocuded easily? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:09:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:09:42 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #258 from Jonathan Druart --- Branch rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:13:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:13:45 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 --- Comment #3 from Jonathan Druart --- You can use sandboxes, they use perl 5.10.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:36:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:36:57 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:36:59 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 --- Comment #1 from Jonathan Druart --- Created attachment 35099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35099&action=edit Bug 13554: t/Prices.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Prices.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Prices.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:37:28 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13275 Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:37:28 +0000 Subject: [Koha-bugs] [Bug 13275] (OMNIBUS) Tests on t/ should pass without a DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13275 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13554 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:48:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:48:13 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:48:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:48:15 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34993|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 35100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35100&action=edit Bug 4402: Date filter on parcels.tt required db date format The date filters on the parcel page would only work with dates formatted YYYY-MM-DD. To test: - Select a vendor, that already has a few invoices - "Receive shipment" - you are on the parcels page - Use the From and To filters on the left, notice there is now a date picker on those fields - Verify the search works correctly for different date formats -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:51:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:51:38 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #14 from Jonathan Druart --- (In reply to Katrin Fischer from comment #10) > Hm, the new patch does cause some weird side effects. When I access the > bookseller parcels page via 'receive shipment' the old shipments/open > invoices don't show up. > > I think it's the same problem I've run into trying to avoid using C4::Dates, > Koha::DateUtils date_to_string returns not only the date and it will also > return "now" if no date is given: > > 2015-01-12T07:13:11 > > And that won't work in the SQL. The date generated by dt_from_string(undef) is today, we don't want to generate a date if the date parameters are not set. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 09:54:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 08:54:20 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #15 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > I am still not sure how to reformat a date formatted to our dateformat pref > and convert to iso format :( my $dt = dt_from_string # Generate a DT for today (no date passed) my $date_string_pref = output_pref( $dt ); # Generate the date string for the given DT, depending on the syspref. my $date_string_iso = output_pref( $dt, 'iso' ); # Generate the date string for the given DT formatted to iso format. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 10:18:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 09:18:28 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35100|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 35101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35101&action=edit Bug 4402: Date filter on parcels.tt required db date format The date filters on the parcel page would only work with dates formatted YYYY-MM-DD. To test: - Select a vendor, that already has a few invoices - "Receive shipment" - you are on the parcels page - Use the From and To filters on the left, notice there is now a date picker on those fields - Verify the search works correctly for different date formats -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 10:23:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 09:23:39 +0000 Subject: [Koha-bugs] [Bug 13555] New: Encoding problems on the vendor summary and edit pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13555 Bug ID: 13555 Summary: Encoding problems on the vendor summary and edit pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We see kind of inconsistent encoding problems for the vendor in Koha 3.18.2. The encoding problems appear for umlauts in the data from the database and also for the strings in the templates. Examle: B?rbel as name for the contact, or "Kontakt f?r versp?tete Hefte" (contact for late issues). The problems are visible on the summary page and on the edit form. The problem is inconsistent, because sometimes when you open the page everything is ok... then only the database data shows the problem and the strings from the template are ok... and then both is broken. Not sure what's happening there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 10:27:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 09:27:52 +0000 Subject: [Koha-bugs] [Bug 13555] Encoding problems on the vendor summary and edit pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13555 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Should be fixed by 11944. To fix this issue without 11944, we need to escape the string with the html_entity TT filter in the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 11:19:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 10:19:05 +0000 Subject: [Koha-bugs] [Bug 13556] New: Undo Item deletion Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13556 Bug ID: 13556 Summary: Undo Item deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Our librarians are asking me why some Items cannot be found from Koha. The reason is that they have been deleted. Making a report for it doesn't help too much. What is needed is a GUI to look for Items in the koha.deleteditems-table and return the Item to active duty! That might be difficult for serials... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 11:38:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 10:38:21 +0000 Subject: [Koha-bugs] [Bug 12466] Bad updatedatabase.pl message for $DBversion = "3.15.00.049"; In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12466 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Should be backported in 3.18 and 3.16. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 12:07:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 11:07:31 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 12:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 11:07:36 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #203 from M. de Rooy --- Created attachment 35102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35102&action=edit Bug 7143: Release team 3.20 Updated the release team with the roles for 3.20 pages on the wiki and checked with the votes on the IRC meeting log. Simplified the section on Former release team members by moving that information (in a compressed format) to the Developers section. If someone had a role for multiple releases, I used constructs as 3.X. Sorted the Additional thanks-section. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 12:58:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 11:58:34 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #20 from M. de Rooy --- Patch still applies! +1 for unit tests. I have some hesitations however on signing this off: [1] The unit test contains: $dbh->do("INSERT INTO auth_types(authtypecode, authtypetext, auth_tag_to_report, summary) VALUES('TEST_PERSO', 'Personal Name', '109', 'Personal Names');"); This is only valid for UNIMARC. What about MARC21? [2] You do not include test plans. This could be a reason why this report has not received much attention lately. Changing status to Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 13:03:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 12:03:44 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35095|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 35103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35103&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 13:09:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 12:09:06 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31567|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 35104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35104&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 13:09:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 12:09:56 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #21 from M. de Rooy --- Hm. I cannot find any reference to field 109 in unimarc too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 13:25:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 12:25:29 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #22 from M. de Rooy --- OK. I had a closer look. But we are not there yet: I added some debug prints to the unit test: warn "L251a"; my @biblios = C4::AuthoritiesMarc::merge($authid2, undef, $authid1, undef); warn "L251b"; produces this: L251a at t/db_dependent/AuthoritiesMarc.t line 251. Use of uninitialized value $self in pattern match (m//) at /usr/local/share/perl5/MARC/File/XML.pm line 441. Can't call method "subfield" on an undefined value at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 1483. # Looks like you planned 15 tests but ran 8. # Looks like your test exited with 255 just after 8. Since the 251b warn is not issued anymore, the error is somewhere in the call to merge.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 13:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 12:31:05 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 13:32:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 12:32:20 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35099|0 |1 is obsolete| | --- Comment #2 from Paola Rossi --- Created attachment 35105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35105&action=edit Bug 13554: t/Prices.t shouldn't depend on the DB I've applied this patch against master 3.19.00.005 head 12868. NB. the 13275 patch is an omnibus one. Everything's OK. I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 13:34:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 12:34:25 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #23 from Jonathan Druart --- (In reply to M. de Rooy from comment #21) > Hm. I cannot find any reference to field 109 in unimarc too? Julian has certainly chosen 109 arbitrarily. The tests pass on a MARC21 installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 13:39:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 12:39:49 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #24 from M. de Rooy --- (In reply to Jonathan Druart from comment #23) > (In reply to M. de Rooy from comment #21) > > Hm. I cannot find any reference to field 109 in unimarc too? > > Julian has certainly chosen 109 arbitrarily. > The tests pass on a MARC21 installation. Not always. See comment22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 14:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 13:11:49 +0000 Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 --- Comment #3 from Magnus Enger --- I was just having this problem in a GRS1-installation that was upgraded (using the Debian packages) to 3.18.x. These errors were given: 11:12:01-16/12 zebraid10388) [warn] Couldn't open collection.abs [No such file or directory] 11:21:38-16/12 zebraid10388) [fatal] Out of memory - malloc (305152000 bytes) and search was not wrking. Adding these lines to koha-conf.xml solved the problem: grs1 grs1 (The site should still be "upgraded" to DOM indexing, to meet the future removal og GRS1.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 15:10:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 14:10:34 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |swarren at wwwdotorg.org --- Comment #8 from Tom?s Cohen Arazi --- *** Bug 13396 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 15:10:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 14:10:34 +0000 Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- This error is a consecquence of the GRS-1 deprecation, because of which all places where DOM vs. GRS-1 decisions need to be made, DOM is chosen as default. As this is a configuration error on the user side (and possibly a missing bigger warning on the release notes) I'll close this one as a duplicate of bug 13404, that takes care of telling the user about the mis-configuration and the steps to fix it. *** This bug has been marked as a duplicate of bug 13404 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 16:10:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 15:10:13 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 16:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 15:26:49 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #25 from Julian Maurice --- Hi Marcel, Unfortunately I am not able to reproduce your problem. Could you add some debug prints in the mock of ZOOM::Record::raw (line 242 of t/db_dependent/AuthoritiesMarc.t) ? Maybe something like this, just before the return: warn "biblionumber: " . $this->{_rec}->{biblionumber}; warn "marc: " . $marcs->[0]; This should tell us if the mocks don't work, if the record is not inserted in database, or if it's something else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 16:45:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 15:45:25 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #103 from Colin Campbell --- Created attachment 35106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35106&action=edit Supplementary patch When we dont create items the options for item processing by vendor are limited. But if we do go down this route we have to use delivery location as the (provisional) branch. The old basket.branch field which should point to branches is no longer maintained -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 16:46:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 15:46:25 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #104 from Colin Campbell --- (In reply to Zeno Tajoli from comment #102) > I setup acq to test this patch. > I use a 'FILE' edi account. > > When I try to close the basket and create the request I see > > Software error: > Can't call method "branchcode" on an undefined value at > /home/koha/test_edi/Koha/Edifact/Order.pm line 374. > > The link used: > http://192.168.216.128:8080/cgi-bin/koha/acqui/basket. > pl?basketno=1&op=ediorder&ean=111222&booksellerid=1&confirm=1&basketgroupname > =bask1 > > Generaly speaking I think we need more details on how to do test of this > feature. > For example: > -- EAN/SAN, names for budgets, funds and vendors > -- files of different types > -- ect. > > I run those tests, but I think it is not enough to sign-off: > > prove Ediorder.t: OK > prove EdiInvoice.t: OK > prove Edifact.t: OK Addeda supplementary patch handling derivation of branch from the basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 16:50:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 15:50:18 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #26 from Julian Maurice --- Jonathan reproduced the bug on one of the sandbox, so no need to do this on your side. I think I've found the problem and will submit a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 16:55:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 15:55:29 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #27 from Julian Maurice --- Created attachment 35107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35107&action=edit Bug 11700: Fix unit test when index mode is not defined Use the same default value as everywhere (dom) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 16:56:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 15:56:09 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 16:59:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 15:59:53 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:01:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:01:09 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:01:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:01:24 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:01:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:01:47 +0000 Subject: [Koha-bugs] [Bug 13557] New: In-house checkouts: Show in-house note on summary tab in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13557 Bug ID: 13557 Summary: In-house checkouts: Show in-house note on summary tab in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The in-house checkouts are clearly visible in the reading history, but not in the list of current checkouts in the OPAC. It would be nice to be also able to see the note there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:01:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:01:59 +0000 Subject: [Koha-bugs] [Bug 13234] Make on-site checkouts visible in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13234 --- Comment #15 from Katrin Fischer --- Note: this was only for the reading history, it appears not to show up for current checkouts - see bug 13557. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:02:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:02:38 +0000 Subject: [Koha-bugs] [Bug 12771] Enhancement to manage more than 3 levels of overdue notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12771 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:08:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:08:24 +0000 Subject: [Koha-bugs] [Bug 13558] New: In-house checkouts: optionally allow library to choose due date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13558 Bug ID: 13558 Summary: In-house checkouts: optionally allow library to choose due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently the on-site checkouts due date is hardcoded the "end of today". For libraries who store the items locally for the patrons to come back and use them again, it woudl be nice if the due date could be specified manually on the circ page. circ/circulation.pl l.163-165 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:16:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:16:53 +0000 Subject: [Koha-bugs] [Bug 13559] New: Forced item level hold should be highlighted on return Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13559 Bug ID: 13559 Summary: Forced item level hold should be highlighted on return Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When a hold is forced on an item that normally can't be placed on hold, on return the item will not trigger the hold notification. This makes sense for title level holds, but it would be nice to show note in case of an item level specific request that might need special handling (repairs or similar). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:17:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:17:01 +0000 Subject: [Koha-bugs] [Bug 13559] Forced item level hold should be highlighted on return In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13559 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11512 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:17:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:17:01 +0000 Subject: [Koha-bugs] [Bug 11512] Forced holds that violate issuing rules will never be filled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13559 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:39:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:39:23 +0000 Subject: [Koha-bugs] [Bug 13560] New: need an add option in marc modification templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Bug ID: 13560 Summary: need an add option in marc modification templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 35108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35108&action=edit add/update on marc mod is only updating Right now the marc modification templates have an add/update option but it's only updating. So let's say I want to add a new 650 (like attached) it's updating all existing 650s to have the value I want to add as a new 650. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 17:49:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 16:49:36 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #9 from Elaine Bradtke --- Can confirm in 3.18.02 - Debian - using Chrome. In a single record, clicking on "Open in new window" does not open a new window, but navigates to the OPAC in the current window. However, it does work as expected in Firefox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:07:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:07:41 +0000 Subject: [Koha-bugs] [Bug 13561] New: Item search: Allow searching for custom 952 subfields (more_subfields) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13561 Bug ID: 13561 Summary: Item search: Allow searching for custom 952 subfields (more_subfields) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if one could search for custom 952 item fields (more_subfields_xml). One problem here is that a-z and 0-9 are mostly used and the list of subfields in the form to add new fields is limited to those. Using capital A-Z is not possible from the GUI (Administration > Items search fields) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:07:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:07:59 +0000 Subject: [Koha-bugs] [Bug 13561] Item search: Allow searching for custom 952 subfields (more_subfields) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11425 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:07:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:07:59 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13561 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:11:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:11:04 +0000 Subject: [Koha-bugs] [Bug 12514] Pressing 'print and confirm hold' on check in triggers race condition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12514 Jason Burds changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |normal CC| |jburds at dubuque.lib.ia.us --- Comment #1 from Jason Burds --- This is a big deal for our library. We have to scan an item 2 times to get it to correctly print out hold information. Does other library have to check the item in and confirm 2 times to get it to print all of the slip information? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:15:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:15:31 +0000 Subject: [Koha-bugs] [Bug 13562] New: Item search: Not possible to add other search fields from 952? Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Bug ID: 13562 Summary: Item search: Not possible to add other search fields from 952? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I have added some additional fields to the search using administration > Items search fields: 952$1, LOST auth value (tried all settings for lost in the form at the bottom) 952$z, Opac note, free text Both searches don't appear to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:15:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:15:43 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13562 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:15:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:15:43 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11425 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:16:07 +0000 Subject: [Koha-bugs] [Bug 13563] New: AngularJS Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Bug ID: 13563 Summary: AngularJS Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Many areas of Koha's staff client would benefit greatly from a heavily AJAX driven workflow. AngularJS makes working with state clientside much easier than the alternatives. This bug gives the foundations of adding AngularJS to the Koha stack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:21:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:21:42 +0000 Subject: [Koha-bugs] [Bug 13564] New: Items search: rename Stock number to Inventory number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Bug ID: 13564 Summary: Items search: rename Stock number to Inventory number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In the English UNIMARC and MARC21 frameworks the subfield for items.stocknumber has the description "Inventory number". It would be good to use the same term on the items search form and results table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:23:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:23:38 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11425 --- Comment #1 from Katrin Fischer --- To test: - Go to Advanced search - Click on link 'go to item search' - Check the search options in the second section for "Stock number" - Do a search and note the column name appears as "Stock number" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:23:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:23:38 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13564 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 18:58:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 17:58:14 +0000 Subject: [Koha-bugs] [Bug 13565] New: Several "DBD::mysql::db do failed" during upgrade from 3.14.x to 3.18.x Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13565 Bug ID: 13565 Summary: Several "DBD::mysql::db do failed" during upgrade from 3.14.x to 3.18.x Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: rolando.isidoro at gmail.com QA Contact: testopia at bugs.koha-community.org When performing an upgrade from Koha 3.14.10 to 3.18.02 using packages in a Debian server I got these database occurrences: DBD::mysql::db do failed: Duplicate key name 'surname_idx' at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 7841. Upgrade to 3.15.00.006 done (Bug 11249 - Add DB indexes on borrower names) DBD::mysql::db do failed: Unknown column 'ctId' in 'collections_tracking' at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 7863. Upgrade to 3.15.00.008 done (Bug 11384) - change name of collections_tracker.ctId column) DBD::mysql::db do failed: Can't DROP 'marc'; check that column/key exists at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 7881. Upgrade to 3.15.00.010 done (Bug 6331: remove obsolete column in deleteditems.marc) DBD::mysql::db do failed: Duplicate entry 'SelfCheckReceiptPrompt' for key 'PRIMARY' at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 7940. Upgrade to 3.15.00.014 done (Bug 11415: add system preference for automatic self checkout receipt printing) DBD::mysql::db selectcol_arrayref failed: Table 'koha_fct.roadtype' doesn't exist at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 7988. Upgrade to 3.15.00.019 done (Bug 11256: Add system preference OpacMaxItemsToDisplay) DBD::mysql::db do failed: Can't DROP 'timestamp'; check that column/key exists at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 8035. Upgrade to 3.15.00.021 done (Bug 3445: Add indexes to action_logs table) DBD::mysql::db do failed: Duplicate entry 'OPACMySummaryNote' for key 'PRIMARY' at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 8129. Upgrade to 3.15.00.030 done (Bug 12052: Add OPACMySummaryNote syspref) None of them seem problematic, as they result of attempts to perform actions that were already done previously. Nevertheless they should be fixed so the upgrade performs with a clean log. Rolando Isidoro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 19:25:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 18:25:49 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 19:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 18:26:19 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 19:39:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 18:39:31 +0000 Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax included values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com --- Comment #3 from Francois Charbonnier --- I tested this patch on BibLibre's sanbox 17. I used 4 different setups for the vendors : Set up 1 = List prices INCLUDE TAX + Invoice prices INCLUDE TAX Set up 2 = List prices EXCLUDE TAX + Invoice prices EXCLUDE TAX Set up 3 = List prices INCLUDE TAX + Invoice prices EXCLUDE TAX Set up 4 = List prices EXCLUDE TAX + Invoice prices INCLUDE TAX Then I set up 8 different funds to test the calculation on the fund level and on the child fund level. Under each vendor, I added two baskets. Each with 1 order which would use one of the 8 funds I created. Vendor 1 = List prices INCLUDE TAX + Invoice prices INCLUDE TAX - basket 1 with order on a level 1 fund - basket 2 with order on a level 2 fund Vendor 2 = List prices EXCLUDE TAX + Invoice prices EXCLUDE TAX - basket 1 with order on a level 1 fund - basket 2 with order on a level 2 fund Vendor 3 = List prices INCLUDE TAX + Invoice prices EXCLUDE TAX - basket 1 with order on a level 1 fund - basket 2 with order on a level 2 fund Vendor 4 = List prices EXCLUDE TAX + Invoice prices INCLUDE TAX - basket 1 with order on a level 1 fund - basket 2 with order on a level 2 fund After ordering and receiving each order, I checked the funds levels on two pages : * aqbudgets.pl (admnistration) * acqui-home.pl (acquisition's home page) Each time, the calculation were good. Except for one, which is not linked to the calculation itself but on the approxination. For the vendor 3 (List prices INCLUDE TAX + Invoice prices EXCLUDE TAX) : I ordered two 10euros book. The price is taxe included. So I should paid 20euros When I received the books, the price is taxe excluded. The approximation is on two numbers which, in the end, lead the total cost to be 19.99 euros tax included where I expected 20 euros. For sure, it's not much, probably acceptable but I would like to know if there is an easy fix. What about managing more digits after the coma in the database and display just two? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 21:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 20:45:06 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 --- Comment #1 from Martin Renvoize --- Created attachment 35109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35109&action=edit Bug 13563: Add AngularJS Library to Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 21:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 20:47:47 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #95 from Katrin Fischer --- I am having problems testing this. I have 2 branches, one with the branch from biblibre repo and these patches on top and another with only those patches on top of community master. In both branches I see this when trying to run the 2 test files: $ perl t/db_dependent/www/auth_values_input_www.t 1..28 You tried to plan twice at t/db_dependent/www/auth_values_input_www.t line 47. # Looks like your test exited with 255 before it could output anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 22:04:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 21:04:46 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:07:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:07:55 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #96 from Katrin Fischer --- Created attachment 35110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35110&action=edit [PASSED QA] Bug 13264: UNIMARC and MARC21 records to test UTF-8 The records shares enough chars to do the same search ('deuteros') to find them and check the same utf-8 chars. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:07:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:07:59 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #97 from Katrin Fischer --- Created attachment 35111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35111&action=edit [PASSED QA] Bug 13264: Test for utf-8 on Opac search This test need to setup zebraserver and background indexing. You need to set also KOHA_INTRANET_URL and KOHA_OPAC_URL in the user enviroment. It imports sample records and retrieves them on hte OPAC through Apache. To run it: prove opac_utf8.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:03 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #98 from Katrin Fischer --- Created attachment 35112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35112&action=edit [PASSED QA] Bug 13264: Test for utf-8 on authorised values input/display/delete This test check utf-8 support on web intranet interface for authorized values. It test input, search and delete of utf-8 values. If all OK it destroy values inserted Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:07 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #99 from Katrin Fischer --- Created attachment 35113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35113&action=edit [PASSED QA] Bug 13264: no need to test for MySQL This patch removes the test for a running MySQL process. It is already implied by successfuly loading C4::Context. It also fixes the license text. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:11 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #100 from Katrin Fischer --- Created attachment 35114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35114&action=edit [PASSED QA] Bug 13264: Make opac_utf8.t launch its own helper processes This patch makes opac_utf8.t launch its own: - zebrasrv process - rebuild_zebra.pl (daemon mode) It also takes care of killing them when finished. It sets a frecquency of 5 seconds for the indexer, and waits 10 just in case before looking for the indexed records. To test: - Just launch the tests. Edit: fixes on the license text. Regards Tomas Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:15 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #101 from Katrin Fischer --- Created attachment 35115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35115&action=edit [PASSED QA] Bug 13264: Follow up: in opac_utf8.t insert also delete of biblio In previous version of the test opac_utf8.t clears import from resevoir but it doesn't delete record from biblio table in MySQL. This the standard work of the feature, see: http://manual.koha-community.org/3.18/en/catalogtools.html#managestaged Now the script deletes also record on MySQL level. No necessary on Zebra level because it uses a temporaney Zebra index that it is clenaned at the end of the script. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:19 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #102 from Katrin Fischer --- Created attachment 35116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35116&action=edit [PASSED QA] Bug 13264: Additional test for search in intranet calatogue The utf-8 test do: insert a biblio record with tool, search the record in intranet, delete batch upload and biblio records. To test: prove intranet_search_utf8.t Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:23 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #103 from Katrin Fischer --- Created attachment 35117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35117&action=edit [PASSED QA] Bug 13264: Refactor search utf8 tests and add some more t/db_dependent/www/search_utf8.t and t/db_dependent/www/intranet_search_utf8.t were quite similar, I merged them into a single file (t/db_dependent/www/search_utf8.t). On the way, I added some tests for them. Note that you will need the last patch on branch bug_11944 to see the tests pass. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:27 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #104 from Katrin Fischer --- Created attachment 35118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35118&action=edit [PASSED QA] Bug 13264: (QA followup) prevent double-encoding on the tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:32 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #105 from Katrin Fischer --- Created attachment 35119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35119&action=edit [PASSED QA] Bug 13264: Add more records to the marc21 aand unimarc files Dupliacate record in marc21 and unimarc files, so the search finds always more than one result. http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:36 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #106 from Katrin Fischer --- Created attachment 35120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35120&action=edit [PASSED QA] Bug 13264: Add tests for Latin-1 vs. UTF-8 deduction add a test in auth_values_input_www to check chars that could be Latin-1 or UTF-8 http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:41 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #107 from Katrin Fischer --- Created attachment 35121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35121&action=edit [PASSED QA] Bug 13264: Add Latin-1 vs UTF-8 test specific records This patch addes two new files .mrc for marc21 and unimarc to test chars in utf8/latin-1 section only, to be sure that perl doesn't switch between utf-8 nad ISO 8859-1 inside itself. http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:46 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #108 from Katrin Fischer --- Created attachment 35122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35122&action=edit [PASSED QA] Bug 13264: Update of unimarc and marc21 record to search publisher http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:51 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #109 from Katrin Fischer --- Created attachment 35123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35123&action=edit [PASSED QA] Bug 13264: More tests for Latin-1 vs. UTF-8 interpretation New tests in search_utf8.t, now are tested also records with only utf-8 chars that could see also as latin-1 chars http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:08:55 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #110 from Katrin Fischer --- Created attachment 35124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35124&action=edit [PASSED QA] Bug 13264: Follow up on record files: deleted fields (952/995) with items info To insert items info you need to use correct code of sublibrary, not always the code is correct. Items info are not important for this test, so the fields are deleted (952 in MARC21, 995 in UNIMARC) http://bugs.koha-community.org/show_bug.cgi?id=13264 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:09:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:09:47 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:09:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:09:52 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35072|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:09:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:09:56 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35073|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:09:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:09:59 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35074|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:02 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:06 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35076|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:09 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:13 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:16 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35079|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:19 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:22 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:25 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35082|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:28 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:31 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35069|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:34 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35070|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:10:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:10:41 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35071|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:39:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:39:59 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:40:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:40:04 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35102|0 |1 is obsolete| | --- Comment #204 from Justin Vos --- Created attachment 35125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35125&action=edit Bug 7143: Release team 3.20 Updated the release team with the roles for 3.20 pages on the wiki and checked with the votes on the IRC meeting log. Simplified the section on Former release team members by moving that information (in a compressed format) to the Developers section. If someone had a role for multiple releases, I used constructs as 3.X. Sorted the Additional thanks-section. Signed-off-by: Justin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 12 23:57:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 22:57:44 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rochellehealy.student at wegc. | |school.nz Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Rochelle Healy --- We tried applying bug 11430 first but it still doesn't apply, Applying: Bug 12460: Allow to start a new search from multiple search history lines fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12460: Allow to start a new search from multiple search history lines When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12460-Allow-to-start-a-new-search-from-multipl-UuxtJ9.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 00:17:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 23:17:01 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Abby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35029|0 |1 is obsolete| | --- Comment #8 from Abby --- Created attachment 35126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35126&action=edit Bug 13526 - Mandatory fields should not be able to be hidden in borrower self-registration Currently, mandatory fields in the borrower self-registration can be hidden. This causes problems since the validator rejects the registration, even though all required fields on the screen have been filled out. This is especially a problem when using the system preference "PatronSelfRegistrationVerifyByEmail", since it automatically makes "email" a mandatory field. This patch makes it so that a mandatory field cannot be hidden on the self-registration page. _TEST PLAN_ Before applying 1) Hide the "email" and the "emailpro" fields using the "PatronSelfRegistrationBorrowerUnwantedField" system preference. 2) Make the "email" and the "emailpro" fields mandatory using the "PatronSelfRegistrationBorrowerMandatoryField" system preference. 3) Note that you cannot see "Primary email" or "Secondary email" on the self registration page. (The registration page which can be found by turning on "PatronSelfRegistration" and filling in "PatronSelfRegistrationDefaultCategory". The link will be on opac-main.pl on the right side of the screen under the login box.) 4) Note that you cannot submit a self-registration request as the system tells you that you have not filled in all the mandatory fields. 5) Apply the patch && refresh the self registration page 6) Note that you can now see "Primary email" and "Secondary email" on the self-registration screen". Signed-off-by: Abby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 00:17:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Jan 2015 23:17:37 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Abby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abbyrobertson.student at wegc. | |school.nz Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 01:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 00:53:34 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the.invinnysible.one at gmail. | |com --- Comment #2 from the.invinnysible.one at gmail.com --- We all tryed to recreate the bug but were unable to replicate it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 02:07:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 01:07:48 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 02:07:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 01:07:51 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35032|0 |1 is obsolete| | --- Comment #2 from Thomas Wright --- Created attachment 35127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35127&action=edit Bug 13537 - Focus should move to barcode after renewing via checkouts table Koha's checkout screen automatically focuses on the barcode field each time it is loaded. Since we've moved the checkouts table functions for renewing and returning items to ajax methods, this page is no longer refreshed, and thus does not refocus to the barcode after performing those actions. This should be fixed so that renewing/returning items via the checkouts page moves the focus to the barcode field. Test Plan: 1) Find a patron with checkouts. 2) Renew or return a checkout, note the focus does not move to the barcode. 3) Apply this patch. 4) Renew or return a checkout, note the focus *does* move to the barcode. Signed-off-by: Kyle M Hall Signed-off-by: Thomas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 02:15:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 01:15:16 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Brandon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35103|0 |1 is obsolete| | --- Comment #4 from Brandon --- Created attachment 35128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35128&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image Signed-off-by: Brandon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 02:15:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 01:15:51 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Brandon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brandon_h27 at hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 02:37:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 01:37:34 +0000 Subject: [Koha-bugs] [Bug 12889] Improving documentation in C4::Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12889 --- Comment #4 from Rochelle Healy --- Created attachment 35129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35129&action=edit Updated pod for AddMember Signed-off-by: Rochelle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 02:39:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 01:39:05 +0000 Subject: [Koha-bugs] [Bug 12889] Improving documentation in C4::Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12889 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |rochellehealy.student at wegc. | |school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 03:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 02:04:58 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #146 from the.invinnysible.one at gmail.com --- Created attachment 35130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35130&action=edit Updated pod for AddMember Signed-off-by: Morag http://bugs.koha-community.org/show_bug.cgi?id=12889 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 03:07:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 02:07:48 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 --- Comment #2 from Rochelle Healy --- Created attachment 35131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35131&action=edit Bug 13564: Items search: rename Stock number to Inventory number To test: - Go to Advanced search - Click on link 'go to item search' - Check the search options in the second section for "Stock number" - Do a search and note the column name appears as "Stock number" - Apply patch - Try the search again and check that "Inventory number" shows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 03:08:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 02:08:11 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rochellehealy.student at wegc. | |school.nz Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 03:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 02:28:28 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |justinvos at live.com --- Comment #1 from Justin Vos --- I'm working on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 03:29:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 02:29:55 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomsStudy at gmail.com Status|NEW |ASSIGNED --- Comment #2 from Thomas Wright --- I'll work on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 03:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 02:29:57 +0000 Subject: [Koha-bugs] [Bug 12028] Add cardnumber on update patron records page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12028 Brandon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brandon_h27 at hotmail.com Status|NEW |ASSIGNED --- Comment #2 from Brandon --- I'm working on this :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 03:33:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 02:33:15 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the.invinnysible.one at gmail. | |com Status|NEW |ASSIGNED --- Comment #2 from the.invinnysible.one at gmail.com --- Will attempt to correct problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 03:48:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 02:48:20 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rochellehealy.student at wegc. | |school.nz Status|NEW |ASSIGNED --- Comment #2 from Rochelle Healy --- I am working on this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:03:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:03:20 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Abby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abbyrobertson.student at wegc. | |school.nz --- Comment #10 from Abby --- Can't recreate bug in Firefox 34.0 or Chromium 39.0.2171.65 Ubuntu 14.04 (64-bit) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:16:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:16:38 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:31:05 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #3 from the.invinnysible.one at gmail.com --- Created attachment 35132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35132&action=edit bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:33:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:33:07 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 --- Comment #3 from Thomas Wright --- Created attachment 35133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35133&action=edit Bug 13531 - bulkmarcimport bombs if no match is found Changed the die statment to a warn allowing the import to continue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:33:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:33:21 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 --- Comment #2 from Justin Vos --- Created attachment 35134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35134&action=edit Bug 13549: Add cardnumber to overdue circulation report overdue.pl Test Plan: - Create an overdue item. - Navigate to overdue circulation report (Home -> Circulation -> Overdues) - Notice there is no card number showing in the Patron column. - Apply patch. - Refresh page. - Notice there is a card number showing in the Patron column. Signed-off-by: Justin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:34:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:34:17 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:34:54 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:35:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:35:13 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from the.invinnysible.one at gmail.com --- Changed GetFrameworkcode to GetFrameworkCode on line 401. Needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:42:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:42:55 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #11 from Liz Rea --- I was able to reproduce this using Tim's plan. It seems to be to do with the number of results you get back, and whether or not there is search navigation. Maybe we can talk more about it tomorrow. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:58:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:58:02 +0000 Subject: [Koha-bugs] [Bug 13566] New: Change translation for 'Rotating collection' in German web installer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 Bug ID: 13566 Summary: Change translation for 'Rotating collection' in German web installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Translation should change from "Wandernde Sammlung" to "Rotationsbestand" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 04:58:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 03:58:19 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 05:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 04:14:08 +0000 Subject: [Koha-bugs] [Bug 13556] Undo Item deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13556 --- Comment #1 from Marc V?ron --- Created attachment 35135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35135&action=edit Bug 13566 - Change translation for 'Rotating collection' in German web installer This page changes 'Wanderned Sammlungen verwalten' to 'Rotationsbest?nde verwalten' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 05:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 04:19:18 +0000 Subject: [Koha-bugs] [Bug 13556] Undo Item deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13556 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35135|0 |1 is obsolete| | CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Comment on attachment 35135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35135 Bug 13566 - Change translation for 'Rotating collection' in German web installer Sorry, mistaked with Bug number -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 05:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 04:20:55 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 --- Comment #1 from Marc V?ron --- Created attachment 35136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35136&action=edit Bug 13566 - Change translation for 'Rotating collection' in German web installer This page changes 'Wanderned Sammlungen verwalten' to 'Rotationsbest?nde verwalten' http://bugs.koha-community.org/show_bug.cgi?id=13556 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 05:22:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 04:22:04 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |trivial Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 05:52:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 04:52:46 +0000 Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 --- Comment #5 from Stephen Warren --- Do you have a link to the instructions how to change from GRS1 to DOM? Note that mentioning this in the release notes doesn't feel like a good solution to the problem; my site was upgraded automatically through the Debian packages. If version upgrades are expected to cause this kind of incompatibility, the Debian repo should not automatically upgrade people to a new major release. Rather, once a particular major package version is installed, the install should stick at the same major version (with minor/patch updates) rather than moving to the new version. The sysadmin should be able to switch versions by explicitly choosing the new version. IIRC, Debian itself already has quite a few packages that work this way that could be used as examples. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 07:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 06:55:42 +0000 Subject: [Koha-bugs] [Bug 13567] New: Searching for system preferences broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13567 Bug ID: 13567 Summary: Searching for system preferences broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Searching for a system preference from the top search or the search on the administration start page results in an error: Software error: Cannot decode string with wide characters at /usr/lib/perl/5.18/Encode.pm line 176. The search term used was "date". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 07:58:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 06:58:19 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 --- Comment #3 from Katrin Fischer --- Created attachment 35137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35137&action=edit wrongly sorted dates in accountlines Thx for testing! It's easier to see when you have a lot of different dates and change the dateformat system preference to "dd/mm/yyyy". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:01:49 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:01:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:01:52 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35127|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 35138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35138&action=edit [PASSED QA] Bug 13537 - Focus should move to barcode after renewing via checkouts table Koha's checkout screen automatically focuses on the barcode field each time it is loaded. Since we've moved the checkouts table functions for renewing and returning items to ajax methods, this page is no longer refreshed, and thus does not refocus to the barcode after performing those actions. This should be fixed so that renewing/returning items via the checkouts page moves the focus to the barcode field. Test Plan: 1) Find a patron with checkouts. 2) Renew or return a checkout, note the focus does not move to the barcode. 3) Apply this patch. 4) Renew or return a checkout, note the focus *does* move to the barcode. Signed-off-by: Kyle M Hall Signed-off-by: Thomas Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:03:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:03:51 +0000 Subject: [Koha-bugs] [Bug 12889] Improving documentation in C4::Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:03:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:03:55 +0000 Subject: [Koha-bugs] [Bug 12889] Improving documentation in C4::Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12889 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35129|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 35139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35139&action=edit [PASSED QA] Updated pod for AddMember Signed-off-by: Rochelle http://bugs.koha-community.org/show_bug.cgi?id=12889 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:06:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:06:34 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:06:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:06:37 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35131|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 35140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35140&action=edit [SIGNED OFF] Bug 13564: Items search: rename Stock number to Inventory number To test: - Go to Advanced search - Click on link 'go to item search' - Check the search options in the second section for "Stock number" - Do a search and note the column name appears as "Stock number" - Apply patch - Try the search again and check that "Inventory number" shows Signed-off-by: Katrin Fischer Works as described, thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:12:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:12:52 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:12:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:12:57 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35134|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 35141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35141&action=edit [SIGNED OFF] Bug 13549: Add cardnumber to overdue circulation report overdue.pl Test Plan: - Create an overdue item. - Navigate to overdue circulation report (Home -> Circulation -> Overdues) - Notice there is no card number showing in the Patron column. - Apply patch. - Refresh page. - Notice there is a card number showing in the Patron column. Signed-off-by: Justin Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:15:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:15:17 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 --- Comment #2 from Katrin Fischer --- Created attachment 35142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35142&action=edit [SIGNED-OFF] Bug 13566 - Change translation for 'Rotating collection' in German web installer This page changes 'Wanderned Sammlungen verwalten' to 'Rotationsbest?nde verwalten' http://bugs.koha-community.org/show_bug.cgi?id=13556 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:15:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:15:36 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:15:37 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:20:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:20:11 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #78 from M. Tompsett --- Follow the test plan in comment #77. Though, I do hope to post instructions on how to install Test::DBIx::Class in Debian Jessie (yes, I said Jessie) for full testing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:23:11 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #5 from Katrin Fischer --- Created attachment 35143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35143&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:23:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:23:57 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:24:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:24:01 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35132|0 |1 is obsolete| | Attachment #35143|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 35144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35144&action=edit [PASSED QA] bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:25:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:25:05 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35144|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 35145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35145&action=edit [SIGNED-OFF] bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 08:27:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 07:27:46 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 09:38:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 08:38:32 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #205 from Katrin Fischer --- No QA problem with the patch, also ok with moving the roles from the extra section into the general list, but not sure about the syntax. 3.X = 3.10? TM/RMt/RM/QAM/DM? I think it's not clear and hard to understand if you don't know what you are looking for. Also hard to translate. There is a lot of room on the page after the names on the page, so the longer forms would fit well. And how are we going to find out how long we are doing our jobs now? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 09:39:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 08:39:52 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 --- Comment #2 from Martin Renvoize --- This is simply a foundation bug to add the Angular library to the staff client. I will be adding a dependancy tree with a few bugs to give examples of good angular use cases. To test, this bug shouldn't directly affect anything, so just checking that it passes the QA scripts should be enough :) Happy for any thoughts on the approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 09:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 08:53:49 +0000 Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax included values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 --- Comment #4 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #3) Bonjour Fran?ois, > For sure, it's not much, probably acceptable but I would like to know if > there is an easy fix. What about managing more digits after the coma in the > database and display just two? Actually it's what it's done :) Have a look at the data in the aqorders table for your order: ordernumber: 75 biblionumber: 4996 entrydate: 2015-01-12 quantity: 2 listprice: 10.000000 unitprice: 9.520000 unitprice_tax_excluded: 9.520000 unitprice_tax_included: 9.996000 quantityreceived: 2 basketno: 35 timestamp: 2015-01-12 18:21:52 rrp: 10.00 rrp_tax_excluded: 9.523810 rrp_tax_included: 10.000000 ecost: 10.00 ecost_tax_excluded: 9.523810 ecost_tax_included: 10.000000 tax_rate_on_ordering: 0.0500 tax_rate_on_receiving: 0.0500 tax_value_on_ordering: 0.476190 tax_value_on_receiving: 0.476000 The values are correct for the ordering. But on receiving, the inserted value is the one displayed on the interface (the rounded value, 9.52). So the fund total spend (calculated on the unit price included tax) is correct: 9.996 * 2 = 19.992 I really don't know how we could get rid of this problem, I am open to all ideas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:09:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:09:21 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:09:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:09:24 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35140|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 35146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35146&action=edit Bug 13564: Items search: rename Stock number to Inventory number To test: - Go to Advanced search - Click on link 'go to item search' - Check the search options in the second section for "Stock number" - Do a search and note the column name appears as "Stock number" - Apply patch - Try the search again and check that "Inventory number" shows Signed-off-by: Katrin Fischer Works as described, thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:11:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:11:20 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- It seems that some occurrences still exist. 2 for the item search feature: koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_items.inc: [% INCLUDE itemsearch_header name='stocknumber' label='stock number' text='Stock number' %] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.csv.tt:Title, Publication Date, Publisher, Collection, Barcode, Call number, Home library, Current location, Shelving location, Stock number, Status, Checkouts and 3 others: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: Stock number koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: Stock number koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: Stock number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:11:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:11:36 +0000 Subject: [Koha-bugs] [Bug 10591] Why do we allow holds on restricted items (952$5=Use restrictions)? Place a hold for reference? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I am currently investigating how we could possibly use the restricted field in Koha for a new library. This is what I found out: - the circulation will only be blocked, if restricted = 1 http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Circulation.pm;hb=483ad2aee510cb23f2bae61883d6b90de262d13d#l903 There seems no other functionality linked to it. So currently, if you added another authorised value != 1, you can check out the item just fine. I'd like to see us decide how this is intended to be used to avoid future problems. We already have the 'not for loan' status blocking circ and holds - maybe it makes sense to have another status that allows holds, but for example only allows for on-site checkouts? But I'd hesitate to change the current behaviour without a good plan and an email to the list, as libraries might have been using this field in different ways. Maybe even needs to be a parameter for a while. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:16:07 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12272 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:16:07 +0000 Subject: [Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13563 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:30:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:30:53 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, | |julian.maurice at biblibre.com --- Comment #1 from Jonathan Druart --- Since the items are not stored anymore in the marcxml (in the DB), it should not possible to do that. I asked Julian to confirm that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:34:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:34:27 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 --- Comment #2 from Katrin Fischer --- Hm, but does it have sense to have an item search that is limited to only a few specific fields? The OPAC note is a good example I think that people might want to search for. I am also missing the current library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:46:03 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35133|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 35147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35147&action=edit Bug 13531 - bulkmarcimport bombs if no match is found Changed the die statment to a warn allowing the import to continue. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:46:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:46:30 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35147|Bug 13531 - bulkmarcimport |[SIGNED OFF] Bug 13531 - description|bombs if no match is found |bulkmarcimport bombs if no |Changed the die statment to |match is found Changed the |a warn allowing the import |die statment to a warn |to continue. |allowing the import to | |continue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:47:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:47:07 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 --- Comment #5 from Martin Renvoize --- Thank Thomas, caught the error nicely and good clean handling :) Signing Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 10:49:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 09:49:12 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #8 from Martin Renvoize --- My colleague who uses this script often is now very happy.. thanks :) I'll try to poke someone in to QA this today, as as the reporter I think that rules me out. Cheers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 11:03:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 10:03:49 +0000 Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax included values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- I think the vagueness occurs somewhere else, i.e. when calculating the unitprice for the database. In the example it is: unitprice_tax_excluded: 9.520000 however, it should be: 9.523809523809524 (10 / 1.05) or rounded: 9.523810 which is the same as ecost_tax_excluded: 9.523810 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 11:26:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 10:26:07 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- (In reply to the.invinnysible.one from comment #4) > Changed GetFrameworkcode to GetFrameworkCode on line 401. Needs signoff. Hi mysterious author, Is there a chance to get a patch with your correct name? The patch's author is Some -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 11:29:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 10:29:16 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Paola Rossi --- I've applied the patch against master 3.19.00.005 Applying: Bug 5338: Serials Report Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/columns.def Auto-merging C4/Reports/Guided.pm CONFLICT (content): Merge conflict in C4/Reports/Guided.pm Failed to merge in the changes. Patch failed at 0001 Bug 5338: Serials Report I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 11:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 10:38:28 +0000 Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Paola Rossi --- I've tried to apply the patch against master 3.19.00.005 But: Patch format detection failed. So I pass the patch to the "Patch doesn't' apply" status. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 11:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 10:56:38 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #17 from Marc V?ron --- I tested with dateformat dd/m/yyy and entered manually: From: 1/2/2014 To: 15/2/2014 The date picker came up for both fields. I canceled date picker both times and then hit "Filter". Result: ----- Software error: The 'day' parameter ("2014") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback at /usr/lib/perl5/DateTime.pm line 199 DateTime::new(undef, 'month', 2, 'day', 2014, 'year', 1915, 'time_zone', 'Europe/Zurich', ...) called at /usr/share/perl5/DateTime/Format/DateParse.pm line 58 DateTime::Format::DateParse::parse_datetime('DateTime::Format::DateParse', '15/02/2014', 'Europe/Zurich') called at /usr/share/kohaclone/Koha/DateUtils.pm line 92 Koha::DateUtils::dt_from_string('15/02/2014', 'iso') called at /usr/share/kohaclone/acqui/parcels.pl line 145 ----- If I do the same without patch, no error occurs. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 11:58:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 10:58:19 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 11:58:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 10:58:22 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29271|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 35148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35148&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:00:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:00:03 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35148|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 35149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35149&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:24:40 +0000 Subject: [Koha-bugs] [Bug 13568] New: OAI Server doesn't handle properly resumption token Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Bug ID: 13568 Summary: OAI Server doesn't handle properly resumption token Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org When responding to ListRecords and ListIdentifiers verbs, OAI server doesn't return proper resumption token. At the end of a result set, OAI server generates a resumption token even if there isn't anymore records. Consequently, OAI harverster will send a new request, based on this invalid resumption, token. OAI Server responds with an empty resultset, which is considered as an invalid response by most of the harvesters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:25:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:25:11 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:28:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:28:39 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:28:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:28:41 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 --- Comment #1 from Fr?d?ric Demians --- Created attachment 35150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35150&action=edit Bug 13568 OAI Server doesn't handle properly resumption token When responding to ListRecords and ListIdentifiers verbs, OAI server doesn't return proper resumption token. At the end of a result set, OAI server generates a resumption token even if there isn't anymore records. Consequently, OAI harverster will send a new request, based on this invalid resumption, token. OAI Server responds with an empty resultset, which is considered as an invalid response by most of the harvesters. TO TEST: - Find in your DB, a day where a few biblio records have been created. The number of created biblios must inferior to OAI-PMH:MaxCount. - Let say this day is 2014-01-09. Send an OAI-PMH request to Koha OAI Server: /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2014-01-09&until=2014-01-09 - At the end of the result, you will see a resumption token which looks like that: marcxml/47/2014-01-09/2014-01-09/ This is wrong. No resumptiion token should be sent since there isn't anymore records to harvest. - Apply the patch. - Resend the OAI-PMH request. There is no resumption token at the end of the result. - You could test also with ListIdenfiers verb in place of ListRecord. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:38:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:38:02 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35101|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 35151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35151&action=edit Bug 4402: Date filter on parcels.tt required db date format The date filters on the parcel page would only work with dates formatted YYYY-MM-DD. To test: - Select a vendor, that already has a few invoices - "Receive shipment" - you are on the parcels page - Use the From and To filters on the left, notice there is now a date picker on those fields - Verify the search works correctly for different date formats -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:40:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:40:24 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #19 from Jonathan Druart --- (In reply to Marc V?ron from comment #17) > I tested with dateformat dd/m/yyy > and entered manually: > From: 1/2/2014 > To: 15/2/2014 > > The date picker came up for both fields. > I canceled date picker both times and then hit "Filter". Sorry, the patch was stupid. A DateTime object was sent to GetInvoices, instead of a date string in iso format. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:47:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:47:10 +0000 Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax included values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 --- Comment #6 from Jonathan Druart --- (In reply to Marc V?ron from comment #5) > I think the vagueness occurs somewhere else, i.e. when calculating the > unitprice for the database. > > In the example it is: > unitprice_tax_excluded: 9.520000 > > however, it should be: 9.523809523809524 Yes, but the problem is that the unitprice tax excluded is displayed on the interface (on receiving the items). And the value is rounded to 9.52 (because we don't want to display 9.523809523809524 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:57:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:57:21 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #11 from Jonathan Druart --- Created attachment 35152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35152&action=edit rounded issue for conf 1 0 This screenshot highlights the problem raised by Fran?ois and Marc on bug 13324 comment 3 to 6. On receiving, the rrp and ecost is rounded to '9.52' (for the display), but the exact values are 9.523810 (which is stored in DB). So the unitprice is displayed 9.52 too and will be stored in DB with this value (the rounded value). Should we store the exact unitprice value even if "9.52" is displayed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 12:58:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 11:58:02 +0000 Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax included values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 --- Comment #7 from Jonathan Druart --- Please continue the discussion on bug 13321 comment 11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 13:06:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 12:06:36 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 --- Comment #3 from Jonathan Druart --- Created attachment 35153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35153&action=edit Bug 13566 - Change translation for 'Rotating collection' in German web installer This page changes 'Wanderned Sammlungen verwalten' to 'Rotationsbest?nde verwalten' Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 13:06:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 12:06:53 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 13:22:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 12:22:36 +0000 Subject: [Koha-bugs] [Bug 10180] [master] Diacritics in Z39.50 search results in acquisitions are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- This seems to be fixed (with and without bug 11944). Could you confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 13:28:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 12:28:09 +0000 Subject: [Koha-bugs] [Bug 10075] Extend CGI to provide a param_utf8_decode method In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- With 11944, this will certainly become invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 13:50:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 12:50:31 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Jonathan Druart --- Not sure what was wrong, but I have just retested to apply this patch and prove Circulation.t, and it returns green. Needs QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 13:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 12:50:43 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 --- Comment #13 from Jonathan Druart --- Created attachment 35154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35154&action=edit Bug 10606: Remove MySQLism in GetUpcomingDueIssues To test: [1] Arrange to have at least one loan in your test database due one day from now. [2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 and note the number of loans reported. [3] Apply the patch. [4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again and verify that the number of loans reported remains the same. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer All tests and QA script pass. Also tested with unit tests from bug 10719. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:23:32 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:23:32 +0000 Subject: [Koha-bugs] [Bug 13569] New: Shibboleth example config for Packages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569 Bug ID: 13569 Summary: Shibboleth example config for Packages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, dpavlin at rot13.org, francart at gmail.com, frederic at tamil.fr, indradg at gmail.com, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, mathsabypro at gmail.com, matthias.meusburger at biblibre.com, paola.rossi at cineca.it, pgsengstock at wisc.edu, tomascohen at gmail.com, z.tajoli at cineca.it Depends on: 8446 Blocks: 12026, 12027, 12680, 12681, 12682, 13114 Bug 8446 introduces shibboleth authentication to Koha and adds a sample config to the koha-conf.xml file along with some other pieces. However, I somehow missed adding these comments form th package installs, this bug should fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:23:32 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:23:32 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:23:32 +0000 Subject: [Koha-bugs] [Bug 12681] Shibboleth attributes may contain lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:23:32 +0000 Subject: [Koha-bugs] [Bug 12680] Shibboleth adaptive config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12680 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:23:32 +0000 Subject: [Koha-bugs] [Bug 12682] Shibboleth attribute manipulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:23:32 +0000 Subject: [Koha-bugs] [Bug 13114] Disabled Shibboleth authentication spams logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13114 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:35:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:35:34 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35040|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:36:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:36:45 +0000 Subject: [Koha-bugs] [Bug 13570] New: koha-conf.xml mentions win32 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Bug ID: 13570 Summary: koha-conf.xml mentions win32 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The koha-conf.xml template in /etc/ still bears mention of MSWin32 systems. Unless we're ever thinking of suporting windows.. again? We should tidy up this file to remove mention of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:36:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:36:58 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:39:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:39:11 +0000 Subject: [Koha-bugs] [Bug 2894] Routing list holds are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 --- Comment #4 from Katrin Fischer --- There is another side effect of this: If you have RoutingListAddReserves to "place" in a 3.18 and you receive a new issue for the subscription, Koha tries to add a hold to the people on the routing list. This hold will break the new Ajax holds display so that no holds at all will display for this patron. Solution: Turn off the pref and delete the holds with the wrong constraint type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:49:34 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30099|0 |1 is obsolete| | Attachment #30100|0 |1 is obsolete| | Attachment #30101|0 |1 is obsolete| | Attachment #30102|0 |1 is obsolete| | Attachment #30103|0 |1 is obsolete| | Attachment #30104|0 |1 is obsolete| | Attachment #30108|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 35155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35155&action=edit Bug 12375 [1] - Update database Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:49:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:49:42 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #31 from Kyle M Hall --- Created attachment 35156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35156&action=edit Bug 12375 [2] - Update Serial schema file Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:49:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:49:45 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #32 from Kyle M Hall --- Created attachment 35157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35157&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:49:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:49:48 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #33 from Kyle M Hall --- Created attachment 35158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35158&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. 4) Inspect some existing serials. The update script will have made a best effort to recover the existing enumeration data to store in separate fields. Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:49:51 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #34 from Kyle M Hall --- Created attachment 35159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35159&action=edit Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:49:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:49:54 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #35 from Kyle M Hall --- Created attachment 35160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35160&action=edit Bug 12375 [6] [QA Followup] - Supress warnings for undefined indexes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:49:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:49:57 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #36 from Kyle M Hall --- Created attachment 35161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35161&action=edit Bug 12375: QA followup - remove trailing whitespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:52:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:52:13 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com --- Comment #12 from Francois Charbonnier --- +1 for your option : exact value stored in database and rounded value displayed. This way, we are more likely to get accurate values down to the last cents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:52:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:52:36 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13571 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:52:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:52:36 +0000 Subject: [Koha-bugs] [Bug 13571] New: koha-conf.xml.in has fallen out of sync with koha-conf.xml Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Bug ID: 13571 Summary: koha-conf.xml.in has fallen out of sync with koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Depends on: 13570 It would appear that koha-conf.xml (under /kohaclone/etc/) has moved forward and koha-conf.xml.in (in /kohaclone/debian/templates/) has not kept up.. These aught to be resynced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:53:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:53:36 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #1 from Martin Renvoize --- I wonder if Robin might be able to spend some time with an Acadmeny person working through this... form initial look there's not too much to it.. but a packaging pro to hand would instil a bit of extra confidence ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:53:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:53:48 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13571 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 14:53:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 13:53:48 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13570 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 15:11:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 14:11:47 +0000 Subject: [Koha-bugs] [Bug 13567] Searching for system preferences broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13567 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Looks ok on master with perl 5.20.1. Looks good on sandboxes too, with perl 5.10.1. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 15:12:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 14:12:36 +0000 Subject: [Koha-bugs] [Bug 13567] Searching for system preferences broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13567 --- Comment #2 from Katrin Fischer --- I will retest - it appeared on my master installation this morning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 15:13:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 14:13:08 +0000 Subject: [Koha-bugs] [Bug 13569] Shibboleth example config for Packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569 --- Comment #1 from Martin Renvoize --- Created attachment 35162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35162&action=edit Bug 13569: Add missing commented line to koha-conf-site.xml.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 15:13:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 14:13:35 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 15:13:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 14:13:35 +0000 Subject: [Koha-bugs] [Bug 13569] Shibboleth example config for Packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13571 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 15:13:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 14:13:52 +0000 Subject: [Koha-bugs] [Bug 13569] Shibboleth example config for Packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 15:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 14:14:39 +0000 Subject: [Koha-bugs] [Bug 13569] Shibboleth example config for Packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13569 --- Comment #2 from Martin Renvoize --- Just brings the debian packages template sligtly more into sync with the non-package one with regards to Shibboleth authentication. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 15:34:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 14:34:53 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Paola Rossi --- Thanks, Jonathan. I've applied the patch against master 3.19.00.005 Then, on Home ? Reports ? Guided reports wizard ? , I've tried to create a "New report" for serials: a "New guided report". 1) Before saving the new report, in the "Save your custom report" form, "Serials" was not in the "Report group" drop down list. So I could not select the "Serials" Report group [I had to create it as a new report-group]. I think that this can be an error (a lack) because the "Serials" option was available in the modules' drop down list on the "1 of 6" step. And because all the other 5 modules names (+ "none") were listed in the "Report group" drop down list. So I pass the patch to "Failed QA" status. NB1. I've selected a periodicity. In the report I saw the right periodicity, but there was the code (id 7), not the description ('1/month'). Was it right? NB2. I've chosen to create a "public" report, but the new report was not created as "public" (ERROR), as I've seen afterwards in the "Public" column of the "Saved reports" table: Home ? Reports ? Guided reports wizard ? Saved reports On the contrary (RIGHT), I could change the report to public on editing it. [I can't recognize if this error is related to this bug or not.] -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 15:42:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 14:42:05 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35039|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 35163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35163&action=edit Bug 13159 - Enhancements to the SIP2 command line emulator I needed to be able to perform checkout operations for testing from the command line. I ended up reengineering the SIP2 command line tester quite a bit. Enhancements: * Moved message generation code to subroutines * Added checkout message support * Added command line switches for each supported message * Enabled use of Sip::Constants to keep code DRY and more understandable * Moved script from misc to C4/SIP * Designed with an eye towards possibly moving some code to CPAN in the future * Also designed to make adding new messages much easier in the future Test Plan: 1) Apply this patch 2) Look at help via ./C4/SIP/sip_cli_emulator.pl --help 3) Test patron status request and patron information, should work as before except you need to pass the command line switche -m 4) Test the new checkout option using -m checkout -i -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:05:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:05:36 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #13 from Marc V?ron --- +1 for exact value stored in database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:11:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:11:51 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #14 from Jonathan Druart --- Yes, it should be quite easy to do. But I am wondering how to be clear on the order receive screen. The input will contain 9.52, but the inserted value will be 9.52XXX. Side effect: the user won't be able to insert 9.52 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:14:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:14:58 +0000 Subject: [Koha-bugs] [Bug 13572] New: Add onlyactives parameter to force_borrower_messaging_defaults script Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Bug ID: 13572 Summary: Add onlyactives parameter to force_borrower_messaging_defaults script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: simith.doliveira at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This patch adds the onlyactives parameter to force_borrower_messaging_defaults script to allow to update just actives (not expired) user records if changes in the user categories are made. Sponsored by CCSR -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:20:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:20:29 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 --- Comment #1 from simith.doliveira at inlibro.com --- To test: 1) Apply the patch 2) Active the preference system ?EnhancedMessagingPreferences? 3) In ?Administration ? Patron categories? modify the default messaging preferences for a category. Ex. Student 4) Run the script 5) Validate: expired Students don't have their patron messaging preferences changed 6) Validate: active Students do have their patron messaging preferences changed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:21:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:21:47 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 --- Comment #2 from simith.doliveira at inlibro.com --- Created attachment 35164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35164&action=edit Bug 13572 - Add onlyactives parameter to force_borrower_messaging_defaults script -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:28:31 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:29:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:29:12 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |eric.begin at inLibro.com, | |marjorie.barry-vila at ccsr.qc | |.ca, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:48:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:48:11 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #206 from M. de Rooy --- (In reply to Justin Vos from comment #204) > Signed-off-by: Justin Thanks, Justin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:53:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:53:48 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #207 from M. de Rooy --- (In reply to Katrin Fischer from comment #205) > No QA problem with the patch, also ok with moving the roles from the extra > section into the general list, but not sure about the syntax. > > 3.X = 3.10? > TM/RMt/RM/QAM/DM? > > I think it's not clear and hard to understand if you don't know what you are > looking for. Also hard to translate. There is a lot of room on the page > after the names on the page, so the longer forms would fit well. > > And how are we going to find out how long we are doing our jobs now? :) Thanks too, Katrin. Yes, I get the point (at least substantially :) That 3.X could mean 3.2 or 3.12 or 3.20 is imo not too hard. The X just says: A subversion of 3. The TM/RMt is indeed quite cryptical. Will add a followup for that. If you do not know how long you are doing something, well... Not sure if about is the right place to document that. I would refer to the wiki roles for [version]-pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 16:56:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 15:56:11 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC|m.de.rooy at rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:16:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:16:06 +0000 Subject: [Koha-bugs] [Bug 13573] New: Item level cataloging perl files have no perldocs. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13573 Bug ID: 13573 Summary: Item level cataloging perl files have no perldocs. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org ./cataloguing/additem.pl has no perldoc ./cataloguing/moveitem.pl has no perldoc ./cataloguing/linkitem.pl has no perldoc This makes trouble-shooting difficult -- it's hard to get an overview of how item level cataloging *should* work from the source code alone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:20:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:20:34 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #15 from Jonathan Druart --- Created attachment 35165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35165&action=edit Bug 13321: Fix unitprice rounding We need to display the rounded value, but insert the exact value. The unit price can be change on receiving, so the input value can be modified. But if it's not, we must insert the exact (not rounded) unit price, which is the ecost value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:20:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:20:59 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #111 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:23:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:23:20 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #16 from Jonathan Druart --- New commit on kohac/ft/bug_13323 and applied on the sandbox. It should fix the rounding problem for unit price on receiving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:30:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:30:36 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:32:11 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #259 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonthan and everyone involved. Hopefully no problems will arise, keep your eyes open to encoding issues! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:33:05 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19262|0 |1 is obsolete| | --- Comment #12 from Paola Rossi --- Created attachment 35166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35166&action=edit [SIGNED OFF] Bug 8436: Add limit on branch in checkexpiration.pl I've applied the patch against master 3.19.00.005 head 12868 If a subscription will expire in the future, it can be selected [and listed] by : /koha/serials/checkexpiration.pl Home ? Serials ? Check expiration either on master or after having applied this patch. So imo I can test this patch. After having applied this patch on checkexpiration.pl : 1) a superlibrarian could select all the subscriptions, just as required; 2) if IndependentBranches syspref is set to "Prevent", a (Staff) superlibrarian without "superserials" permission could select only the subscriptions of his own branch, just as required; 3) if IndependentBranches syspref is set to "Prevent", a "Patron" librarian without "superserials" permission (and with all the other serials' permissions + catalogue's permission) could select only the subscriptions of his own branch, just as required; 4) if IndependentBranches syspref is set to "Prevent", a librarian without "superserials" permission could select the subscriptions of "none" branch, just as required; 5) if IndependentBranches syspref is set to "Don't prevent", a superlibrarian without "superserials" permission could select all the subscriptions, just as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:45:50 +0000 Subject: [Koha-bugs] [Bug 13574] New: Repeatable item subfields don't show correctly in MARC view Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574 Bug ID: 13574 Summary: Repeatable item subfields don't show correctly in MARC view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Koha allows you to add new item subfields using the more_subfields_xml field in the items field. They can be marked as repeatable and adding/editing and deleting them works nicely. The item summary table abvoe the cataloguing form displays the repeated fields separated by a pipe "Test1 | Test2". But the item table on the MARC view in the staff catalog displays only the last of the repeated subfields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:50:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:50:35 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it Status|Needs Signoff |Patch doesn't apply --- Comment #25 from Paola Rossi --- I've tried to apply the patch against master 3.19.00.005 head 12868 Applying: Bug 8438: Users can only claim for serials related to their branch. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Serials_2.t CONFLICT (content): Merge conflict in t/db_dependent/Serials_2.t Auto-merging serials/claims.pl CONFLICT (content): Merge conflict in serials/claims.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt Auto-merging C4/Serials.pm Failed to merge in the changes. Patch failed at 0001 Bug 8438: Users can only claim for serials related to their branch. So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 17:55:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 16:55:29 +0000 Subject: [Koha-bugs] [Bug 13547] Item field 3 (Materials specified) would be useful to see on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 --- Comment #2 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > I think it would be good to make this optional and not turn on by default > for existing installation as the field might have been used to store > informaton that should not be visible for patrons in the OPAC in the past. Agreed. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 18:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 17:07:36 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #17 from Colin Campbell --- The real question is what we are doing with the values less than a cent? Remember also floats are not accurate. Financial apps that value accuracy convert the database value to an integer in cents and do all calculations on that then store it in a monetary form when saving it. That way any rounding is done predictably and it avoids errors arising from the approximation in how floats are stored and the inaccuracies in floating point arithmetic. If calculating a percentage for tax or discount purposes it needs to be calculated on the summed values, adding the individual values where they contain subdivisions of a cent are prone to error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 18:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 17:19:18 +0000 Subject: [Koha-bugs] [Bug 9822] No alert appears on adding an order to a basket if the budget has exceeded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pelletiermaxime at gmail.com --- Comment #10 from simith.doliveira at inlibro.com --- *** Bug 6832 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 18:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 17:19:18 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira at inlibro.co | |m Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #18 from simith.doliveira at inlibro.com --- Bugzilla ? Bug 9822 fix the problem *** This bug has been marked as a duplicate of bug 9822 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 19:02:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 18:02:49 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 21:14:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 20:14:46 +0000 Subject: [Koha-bugs] [Bug 13575] New: Updating developer list. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575 Bug ID: 13575 Summary: Updating developer list. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcharlt at gmail.com Reporter: brandon_h27 at hotmail.com QA Contact: testopia at bugs.koha-community.org Names do not appear in the Koha history Timeline. This would be a good addition. The names to be added are: Kahurangi Cormack, Alexander Cheeseman. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 21:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 20:23:11 +0000 Subject: [Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |justinvos at live.com --- Comment #1 from Justin Vos --- I've started working on this bug. Justin Vos -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 21:31:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 20:31:53 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #208 from Abby --- Created attachment 35167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35167&action=edit Bug 7143 adding releases to history file To test, verify that the latest releases appear in docs/history.txt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 21:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 20:32:39 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Abby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |abbyrobertson.student at wegc. | |school.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 21:43:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 20:43:34 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |the.invinnysible.one at gmail. | |com --- Comment #1 from the.invinnysible.one at gmail.com --- I will attempt to remove the section in the koha-conf.xml file that mentions this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 21:47:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 20:47:01 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomsStudy at gmail.com --- Comment #4 from Thomas Wright --- I'm working on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 21:47:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 20:47:34 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |justinvos at live.com Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 21:48:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 20:48:02 +0000 Subject: [Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 22:03:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 21:03:03 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 22:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 21:27:10 +0000 Subject: [Koha-bugs] [Bug 13575] Updating developer list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575 --- Comment #1 from Brandon --- Created attachment 35168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35168&action=edit Bug 13575 - Names do not appear in the Koha history Timeline. This would be a good addition. The names to be added are: Kahurangi Cormack, Alexander Cheeseman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 22:27:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 21:27:43 +0000 Subject: [Koha-bugs] [Bug 13575] Updating developer list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575 Brandon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 22:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 21:28:05 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from the.invinnysible.one at gmail.com --- Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Needs sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 22:28:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 21:28:54 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 --- Comment #3 from the.invinnysible.one at gmail.com --- Created attachment 35169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35169&action=edit Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 23:27:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 22:27:26 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #10 from the.invinnysible.one at gmail.com --- Created attachment 35170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35170&action=edit bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 13 23:28:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 22:28:21 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #11 from the.invinnysible.one at gmail.com --- (In reply to Jonathan Druart from comment #9) > (In reply to the.invinnysible.one from comment #4) > > Changed GetFrameworkcode to GetFrameworkCode on line 401. Needs signoff. > > Hi mysterious author, > Is there a chance to get a patch with your correct name? > The patch's author is Some My apologies, I have fixed the author name on the patch now. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 00:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 23:15:47 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |justinvos at live.com --- Comment #1 from Justin Vos --- I have started working on this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 00:26:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 23:26:10 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 John Andrews changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jandrews at washoecounty.us --- Comment #10 from John Andrews --- The JS solution is working brilliantly in the OPAC, but there is no change on the staff side when I include this in intranetuserjs -- any suggestions on how to make it work there as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 00:29:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 23:29:33 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #5 from Thomas Wright --- Created attachment 35171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35171&action=edit Bug 12702 - Suggestions still accessible in OPAC when deactivated Added check for suggestions turned off. If off user is redirected to 404 error. If patron suggestions are off guest sugestions will also redirect to 404 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 00:31:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 23:31:19 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 --- Comment #2 from Justin Vos --- Created attachment 35172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35172&action=edit Bug - 11345 - Self registration captcha Test Plan - Open the opac site - Navigate to the self registration page (Home -> Register here) - Notice that there is no note stating that the verification box is case-sensitive - Apply patch - Refresh page - Notice that there is now an extra note stating that the verification box is case-sensitive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 00:34:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Jan 2015 23:34:40 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 02:09:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 01:09:18 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 02:19:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 01:19:13 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #6 from Thomas Wright --- Test Plan: -Set preference 'suggestion' to 'Don't Allow'. Navigate to .../cgi-bin/koha/opac-suggestions.pl *You should be presented with a 404 error. This is the case even if 'AnonSuggestions' are allowed. I am assuming that if suggestions by patrons are not wanted that AnonSuggestions are also not wanted. I think this is a reasonable assumption. -Set preference 'suggestion' to 'Allow' and set preference 'AnonSuggestions' to 'Don't Allow' Navigate to .../cgi-bin/koha/opac-suggestions.pl from a non logged in user page. *You should be presented with a login screen. Log in using that page and you should be presented with the normal suggestions page. -Set preference 'suggestion' to 'Allow' and set preference 'AnonSuggestions' to 'Allow' Navigate to .../cgi-bin/koha/opac-suggestions.pl from a non logged in user page. *You should be presented with the normal suggestions page. Log in and navigate to .../cgi-bin/koha/opac-suggestions.pl *You should be presented with the normal suggestions page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 02:38:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 01:38:05 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED CC| |tomsStudy at gmail.com --- Comment #4 from Thomas Wright --- I' working on this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 04:06:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 03:06:06 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rochellehealy.student at wegc. | |school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 04:06:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 03:06:30 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 04:09:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 03:09:39 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |justinvos at live.com --- Comment #6 from Justin Vos --- I don't have a username/password, but if someone is able to provide me a BakerTaylorUsername and BakerTaylorPassword login, I would be happy to test and fix this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 08:56:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 07:56:04 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35169|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 35173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35173&action=edit Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 08:56:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 07:56:56 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35173|Bug 13570 - koha-conf.xml |[SIGNED OFF] Bug 13570 - description|mentions win32 |koha-conf.xml mentions | |win32 --- Comment #5 from Martin Renvoize --- Comment on attachment 35173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35173 [SIGNED OFF] Bug 13570 - koha-conf.xml mentions win32 Nice simple patch to tidy up the koha-conf file a little... No negative affects found, singing off. Thanks Morag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:04:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:04:16 +0000 Subject: [Koha-bugs] [Bug 13576] New: Add a default circulation rule to the optional sample data Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13576 Bug ID: 13576 Summary: Add a default circulation rule to the optional sample data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com How many times have we seen people confused by weird behaviour in Koha, which was caused by them not having entered a "catch all" basic circulation rule? If we had a very simple sample rule that would catch the combination of all patron categories and all item types, it might save some confusion. This should be a part of the optional sample data that users can choose to install as part of the web installer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:09:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:09:37 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 --- Comment #6 from Martin Renvoize --- Comment on attachment 35147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35147 [SIGNED OFF] Bug 13531 - bulkmarcimport bombs if no match is found Changed the die statment to a warn allowing the import to continue. Review of attachment 35147: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13531&attachment=35147) ----------------------------------------------------------------- A minor QA comment. ::: misc/migration_tools/bulkmarcimport.pl @@ +271,5 @@ > my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch( $query, 0, 3, [$server] ); > + # changed to warn so able to continue with one broken record > + if ( defined $error ) { > + warn "unable to search the database for duplicates : $error"; > + next; For consistency with the rest of the script, should this perhaps be: next RECORD; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:16:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:16:38 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #7 from Martin Renvoize --- This might be another good one for the Academy, marking as such.. Hopefully it's not too difficult to pull out the missing bits so the patch applies again... and get to the bottom of what this patch attempts to achieve that differs to the related bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:16:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:16:56 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:16:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:16:56 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11358 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:17:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:17:13 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:17:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:17:13 +0000 Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11358 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:20:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:20:52 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:20:56 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35145|0 |1 is obsolete| | Attachment #35170|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 35174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35174&action=edit Bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:21:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:21:33 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #13 from Jonathan Druart --- Note that I did not test this patch, because I never user bulkmarcimport. But the fix is trivial and makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:22:28 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #14 from Jonathan Druart --- (In reply to Martin Renvoize from comment #8) > I'll try to poke someone in to QA this today, as as the reporter I think > that rules me out. Where did you read that? I am not sure at all this rules exists :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:25:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:25:13 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #15 from Martin Renvoize --- (In reply to Jonathan Druart from comment #14) > (In reply to Martin Renvoize from comment #8) > > I'll try to poke someone in to QA this today, as as the reporter I think > > that rules me out. > > Where did you read that? > I am not sure at all this rules exists :) Just had a hunch it might be one.. if not then I could have QA'd it.. oops. Thnaks anyway Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:26:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:26:28 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #209 from Jonathan Druart --- Comment on attachment 35167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35167 Bug 7143 adding releases to history file Review of attachment 35167: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7143&attachment=35167) ----------------------------------------------------------------- Hello Abby, Could you please have a look at the release versions, the are not correctly written. ::: docs/history.txt @@ +780,5 @@ > +December 10 2014 Koha 3.18.01 security release > +December 11 2014 Koha 3.16.5 Security Release > +December 22 2014 Koha 3.14.12 released > +December 22 2014 Koha 3.18.2 Release > +December 24 2014 Koha 3.16.6 Release It's 3.16.0X (3.16.06 here). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:41:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:41:04 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35171|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 35175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35175&action=edit Bug 12702 - Suggestions still accessible in OPAC when deactivated Added check for suggestions turned off. If off user is redirected to 404 error. If patron suggestions are off guest sugestions will also redirect to 404 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:41:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:41:32 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35175|Bug 12702 - Suggestions |[SIGNED OFF] Bug 12702 - description|still accessible in OPAC |Suggestions still |when deactivated |accessible in OPAC when | |deactivated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:41:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:41:41 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:45:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:45:52 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #8 from Martin Renvoize --- OK, I'm happy with the logic here. I had to go digging a little to prove to mysefl that the assumption was valid. (Lines 530 -> 539 in commit http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt;hb=544520d6bdfacada4eba4caefedf42864db4b3a0#l529) So, this patch does indeed fix the problem.. however as a side note, I really don't like seeing this kind of logic at the template level.. it's not testable and leads to repetative code :'(. I'de rather see the template just ask the question 'to display, or not to display?', and have the actual logic involved in that question handled further up in the code, perferably in either C4/Suggestions.pm or as part of the Koha.preference plugin somehow. That way, we'd have a testable fix. Just a thought -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:48:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:48:25 +0000 Subject: [Koha-bugs] [Bug 13577] New: The correct COLLATE set to all DB tables Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Bug ID: 13577 Summary: The correct COLLATE set to all DB tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 11944 added the COLLATE=utf8_unicode_ci to all DB tables. But some new tables have been created between the write of the patch set and the push to master. So these new tables don't have the correct collate. The error is: ERROR 1005 (HY000) at line 3493: Can't create table 'koha.items_search_fields' (errno: 150) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:48:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:48:38 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED Depends on| |11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:48:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:48:38 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13577 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:50:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:50:17 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:58:09 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 09:58:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 08:58:12 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #1 from Jonathan Druart --- Created attachment 35176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35176&action=edit Bug 13577: Add the utf8_unicode_ci COLLATE to all tables Bug 11944 added the COLLATE=utf8_unicode_ci to all DB tables. But some new tables have been created between the write of the patch set and the push to master. So these new tables don't have the correct collate. Test plan: 0/ Reproduce the error: mysql> create database koha_test CHARACTER SET utf8 COLLATE utf8_unicode_ci; mysql koha_test < installer/data/mysql/kohastructure.sql It will boom with: ERROR 1005 (HY000) at line 3493: Can't create table `koha_test`.`items_search_fields` (errno: 150 "Foreign key constraint is incorrectly formed") 1/ Apply the patch, destroy the DB and recreate it: mysql> create database koha_test CHARACTER SET utf8 COLLATE utf8_unicode_ci; mysql> drop database koha_test; mysql koha_test < installer/data/mysql/kohastructure.sql All tables should be inserted without any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:00:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:00:53 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #69 from Jonathan Druart --- (In reply to Jonathan Druart from comment #68) > Ok, got it! > It comes from the different charset collate introduced by 11944. > Sorry for the noise. I should have cared more about this problem, see bug 13577 for a fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:01:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:01:01 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11425 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:01:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:01:01 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13577 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:10:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:10:31 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Laurence Lefaucheur changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.lefaucheur at biblibr | |e.com --- Comment #6 from Laurence Lefaucheur --- Set up 3 (List prices INCLUDE TAX + Invoice prices EXCLUDE TAX): I think that Vendor price (tax excl) when receiving should be the same as calculated in Ordering. In my mind this price is kind of 'base' price for the item. So the following seems to be logical for me : Ordering : Vendor price (tax incl) = 10 euros <---- what I entered Vendor price (tax excl) = 9.52 euros Tax amount (5%) = 0.48 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10 euros Receiving (what we have now): Vendor price (tax incl) = 10.47 euros Vendor price (tax excl) = 9.52 euros (= value in actual cost) Tax amount (10%) = 0.95 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10.47 euros Set up 4 (List prices EXCLUDE TAX + Invoice prices INCLUDE TAX): is less evident : I wonder if Vendor price (tax excl) should be changed between order and reception. If it's not the case, Fran?ois's proposition should be considered But we have no library examples of case where the way of using tax include/exclude changes between ordering and receiving, so I am not really for changing the calculation just now without more real experience of how it should be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:25:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:25:55 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #18 from Jonathan Druart --- (In reply to Colin Campbell from comment #17) > The real question is what we are doing with the values less than a cent? Hum, what are the different choices? :) > Remember also floats are not accurate. Financial apps that value accuracy > convert the database value to an integer in cents and do all calculations on > that then store it in a monetary form when saving it. That way any rounding > is done predictably and it avoids errors arising from the approximation in > how floats are stored and the inaccuracies in floating point arithmetic. Yes, you are totally right, we should not use float. But I did not want to change to many things. It could be done later. > If calculating a percentage for tax or discount purposes it needs to be > calculated on the summed values, adding the individual values where they > contain subdivisions of a cent are prone to error The estimated cost (discounted) is calculated for 1 item, and the total is * by the quantity. On the contrary, the tax value should be correctly calculated. I did not see any problem with the estimated cost so far. Did you understand the purpose of the last patch (Fix unitprice rounding)? Do you think it makes sense to fix the problem on this way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:32:31 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:32:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:32:35 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29211|0 |1 is obsolete| | Attachment #29212|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 35177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35177&action=edit Bug 8438: Users can only claim for serials related to their branch. Only superlibrarian users and users with superserials permission can override this limitation. This patch adds a new subroutine C4::Serials::can_claim_subscription. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:32:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:32:42 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #27 from Jonathan Druart --- Created attachment 35178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35178&action=edit Bug 8438: Followup Set the superserials permission for all users with the claim_serials permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:59:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:59:08 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:59:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:59:11 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35149|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 35179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35179&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 10:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 09:59:16 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #20 from Jonathan Druart --- Created attachment 35180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35180&action=edit Bug 5338: Add "Serials" to the report group list -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 11:00:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 10:00:58 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #21 from Jonathan Druart --- (In reply to Paola Rossi from comment #18) > Thanks, Jonathan. > 1) Before saving the new report, in the "Save your custom report" form, > "Serials" was not in the "Report group" drop down list. > So I could not select the "Serials" Report group [I had to create it as > a new report-group]. The last patch adds a new "Serials" group to the list. > NB1. I've selected a periodicity. In the report I saw the right periodicity, > but there was the code (id 7), not the description ('1/month'). Was it right? I don't plan to do that on this bug report. > NB2. I've chosen to create a "public" report, but the new report was not > created as "public" (ERROR), as I've seen afterwards in the "Public" column > of > the "Saved reports" table: > Home ? Reports ? Guided reports wizard ? Saved reports > > On the contrary (RIGHT), I could change the report to public on editing it. > > [I can't recognize if this error is related to this bug or not.] It's not, I reproduce the problem on master, I will try to submit a patch on another bug report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 12:02:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 11:02:57 +0000 Subject: [Koha-bugs] [Bug 13578] New: Parameter public is lost on creating a report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578 Bug ID: 13578 Summary: Parameter public is lost on creating a report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org With no caching system, it's not possible to create a public report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 12:03:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 11:03:07 +0000 Subject: [Koha-bugs] [Bug 13578] Parameter public is lost on creating a report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 12:12:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 11:12:11 +0000 Subject: [Koha-bugs] [Bug 13578] Parameter public is lost on creating a report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 12:12:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 11:12:14 +0000 Subject: [Koha-bugs] [Bug 13578] Parameter public is lost on creating a report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13578 --- Comment #1 from Jonathan Druart --- Created attachment 35181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35181&action=edit Bug 13578: Make sure the 'public' parameter is passed to the last step If no caching system is up ($usecache == 0), the public parameter is lost on the step 3. The hash passed to the template looks like: 'cache_expiry', 300, 'cache_expiry_units', 'public', 1 So the template receives cache_expiry = 300, cache_expiry_units = 'public' and 1 = undef. This patch fixes the problem passing the cache_expiry* parameters only if the usecache is set. Test plan: 0/ Disable any caching system 1/ Create a new public report and go up to the 6th step, save the report and verify the report is created as public 2/ Enable a caching system 2/ Create a public report with a cache expiry value, save it and verify the report is created as public and the cache expiry value is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 12:12:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 11:12:36 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #22 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) > It's not, I reproduce the problem on master, I will try to submit a patch on > another bug report. See bug 13578 for a patch. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:09:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:09:49 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:10:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:10:20 +0000 Subject: [Koha-bugs] [Bug 11926] HEA - Report usage statistics to Koha community In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #46 from Jonathan Druart --- Hi Mason, The patch set applies cleanly on 3.16.x (only 2 conflicts on installer/data/mysql/updatedatabase.pl and koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref, very easy to fix). You can backport it on 3.16.x if you like. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:10:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:10:44 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35176|0 |1 is obsolete| | --- Comment #2 from Paola Rossi --- Created attachment 35182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35182&action=edit [SIGNED OFF] Bug 13577: Add the utf8_unicode_ci COLLATE to all tables I've applied this patch against master 3.19.00.006 Everything's OK. I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:35:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:35:25 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #260 from M. de Rooy --- (In reply to Tom?s Cohen Arazi from comment #259) > Patches pushed to master. > > Thanks Jonthan and everyone involved. > Hopefully no problems will arise, keep your eyes open to encoding issues! Great work, guys. This has been a lot of work! So far I did not spot anything while testing with Latin and Chinese chars. Except one small thing: Fr??d??ric Demians on the about page, timeline tab (reading the history txt file). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:47:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:47:44 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35172|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 35183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35183&action=edit Bug - 11345 - Self registration captcha Test Plan - Open the opac site - Navigate to the self registration page (Home -> Register here) - Notice that there is no note stating that the verification box is case-sensitive - Apply patch - Refresh page - Notice that there is now an extra note stating that the verification box is case-sensitive. Followed test plan. Hint displays as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:48:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:48:29 +0000 Subject: [Koha-bugs] [Bug 13579] New: History file should be open using utf-8 encoding Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Bug ID: 13579 Summary: History file should be open using utf-8 encoding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:49:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:49:30 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:49:29 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:49:34 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 --- Comment #1 from Jonathan Druart --- Created attachment 35184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35184&action=edit Bug 13579: Open history.txt using utf-8 encoding Test plan: Verify about>Timeline is correctly encoded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:49:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:49:44 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|nengard at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:50:22 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13579 --- Comment #261 from Jonathan Druart --- (In reply to M. de Rooy from comment #260) > Fr??d??ric Demians on the about page, timeline tab (reading the history txt > file). See bug 13579 for a fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:50:22 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:57:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:57:33 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:57:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:57:36 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35184|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 35185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35185&action=edit [SIGNED OFF] Bug 13579: Open history.txt using utf-8 encoding Test plan: Verify about>Timeline is correctly encoded Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 13:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 12:58:09 +0000 Subject: [Koha-bugs] [Bug 13575] Updating developer list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Hello Brandon, See bug 7143, it is the bug report to submit history changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:02:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:02:35 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35185|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 35186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35186&action=edit Bug 13579: Open history.txt using utf-8 encoding Test plan: Verify about>Timeline is correctly encoded Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Replaced References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:16:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:16:37 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #12 from Tom?s Cohen Arazi --- Bernardo, could you please rebase this one? I want it :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:20:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:20:42 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #16 from Tom?s Cohen Arazi --- Hi Mark, it doesn't seem to apply on my master branch. Could you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:21:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:21:25 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34308|0 |1 is obsolete| | --- Comment #20 from M. de Rooy --- Created attachment 35187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35187&action=edit Bug 10480: New module and unit test for framework plugins This patch introduces the Koha::FrameworkPlugin object to Koha. This object supports the current "old-style" plugins while adding a new style based on the concept of two anynomous subroutines for building and launching. I will summarize the advantages of this new approach, justifying the additional lines of code in this patch: [1] Centralizing the code for building and launching plugins. [2] Extensive unit testing: this was not possible before. [3] Simplicity: Only define what you need in the plugin. A follow-up patch will delete 1500 lines with *empty* routines. [4] Make it possible to restore the warnings pragma for all plugins. New style plugins do no longer depend on redefinition. [5] Event binding moved from HTML attributes moved to jQuery code. This separates behavior and presentation. [6] Much more documentation, including EXAMPLE plugin in follow-up. [7] Improved error handling. [8] Usability: property noclick tells you if plugin's buttonDot is active. [9] More events supported: Change, keyboard/mouse events. See EXAMPLE. NOTE ON EXAMPLE PLUGIN: The example plugin is added in the third patch of this report. Since it is new style, it can be used only after we start using this object. It also contains an example for a keypress and mouseover event. NOTE ON ITEM PLUGINS: Old style plugins for items contain an additional parameter in the js functions for Blur, Focus and Change. This distinction has no actual use and is resolved for new plugins in the object code. When converting item plugins, this minor correction will be addressed. In the meantime old style item plugins behave as expected. TEST PLAN: Run the new test t/db_dependent/FrameworkPlugin.t At this point in time, you do not need to do anything more. Follow-up patches will incorporate the object in real-life Koha and provide additional test plans. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:21:29 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34309|0 |1 is obsolete| | --- Comment #21 from M. de Rooy --- Created attachment 35188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35188&action=edit Bug 10480: Use the framework plugin object in cataloguing This patch implements the use of Koha::FrameworkPlugin in Cataloguing, Authorities, Acquisition, Serials and Tools. The main change is architectural: see the commit message of the previous patch. No changes in behavior are expected, but the support of new events may provide additional functionality in the future. Some small bugs are resolved along the way. The change primarily focuses on the MARC and items editor in Cataloguing. But the MARC editor for Authorities and the item editor in Acquisition, Serials and Tools are touched too. This commit message gives some comments per module. NOTE FOR CATALOGUING: A new plugin without popup (or other click event code) now shows the title No popup when hovering over the tag editor image. The image alerts the user on a plugin, the title tells about its status. The noclick property allows for further style modifications in the template. Note that a follow-up patch will clean up the old style plugins too with the same effect. Some additional code in cataloging.js makes it possible to clone subfields with plugins (although only theoretically useful). The clones use the same javascript functions but event.data contains an updated id. This effectively resolves bug 13306. Note that if old plugins do not use the javascript parameter for the id but the perl variable, cloning does still operate on the wrong field (with and without this patch set). In the absence of report 12176 in master, it is not yet necessary to modify additem.tt. When it gets pushed, it should be an easy rebase. New style item plugins will no longer need an extra parameter. (The code in the FrameworkPlugin object actually takes care of that.) NOTE FOR AUTHORITIES: This patch also adds class name tag_editor to the buttonDot anchors. This effectively makes the same tag editor image appear as in Cataloguing. Futhermore it removes the button from the tab sequence if there is no click event (really effective after conversion to the new style, since the old style plugins contain empty onclicks and launchers). Both small adjustments increase consistency between auth and bib edits. NOTE FOR ACQUISITION: In Acquisition two scripts use an item editor, but in a different way. The scripts addorderiso2709 and neworderempty both rely on the routine PrepareItemrecordDisplay in C4::Items, but neworderempty creates item blocks dynamically via an ajax call to services/itemrecorddisplay.pl. In order to make the dynamic item blocks work with plugins, some code changes were needed in additem.js. (Normally the event binding is done at document ready time; now it must be done later.) At this moment the routine in Items.pm contains the html tags, and this makes changes to the following templates not necessary for now: * acqui/addorderiso2709.tt * services/itemrecorddisplay.tt Report 13397 has been opened to address moving the html to the templates. NOTE FOR SERIALS: Script serial-edit relies also on C4::Items (just as in Acquisition). This makes changes to serials/serials-edit.tt not necessary for now. NOTE FOR TOOLS: The current code in tools/batchMod.pl allows the use of plugins for batch modification of items. This patch just converts that code to use the new object. Most item plugins however may not be very useful for operating on multiple items at once. PERFORMANCE: I have benchmarked build_tabs in addbiblio to see how especially the additional processing of the javascript in the FrameworkPlugin object would impact performance. Testing default MARC21 framework with 8 plugins gave the following figures: - Old situation: 851 ms - New situation: 942 ms (+10,7%) - New situation after plugin cleanup: 881 ms (+3,4%) Note also that adding lines for event binding is compensated by removing lines for unused events. Page load should essentially be the same. TEST PLAN: Suggestion: If you also apply the next patch with the EXAMPLE plugin, you can test with a rather harmless plugin (with popup) on various places :) But your test should also include old style plugins, with[out] popups. If you want to test a new plugin without popup, rename/remove Click$id in the javascript code of the $builder definition (temporarily). [1] Test Cataloguing: - Add/Edit biblio. Try plugins with and without popup. - Add/Edit items. (EXAMPLE can be used as an item plugin with popup.) - Clone a subfield with plugin (use EXAMPLE): Verify that the plugin works on both original and clone with the respective field values. Is the value put back in the right field too? [2] Test Authorities: Edit an authority record. Try plugins with an without popup. [3] Test Acquisition: Set system preference AcqCreateItem to "placing an order". Check the item editor in the following two places: a- addorderiso2709: Open a basket, add an order from a staged file. Select a file, click Add orders, and go to tab Item information. b- neworderempty: Open a basket, add an order from a new empty record. [4] Test Serials: Check the item editor on serials-edit. Go to subscription detail. Click Receive. Choose "Click to add item". (Note that this subscription should create an item record when receiving this serial.) [5] Test Tools: Check the item editor for batch item modification. Enter a few valid barcodes and press Continue to reach the item editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:21:34 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34310|0 |1 is obsolete| | --- Comment #22 from M. de Rooy --- Created attachment 35189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35189&action=edit Bug 10480: EXAMPLE plugin with associated template The EXAMPLE plugin helps you to create a new style framework plugin by providing a simple working example and additional documentation for developers. Test plan: [1] Connect the EXAMPLE plugin to one or more fields. [2] Try the following events: a- Focus: If the field is empty, it should put EXAMPLE: into it. b- MouseOver: If the field is empty and you move your mouse over it, it should have the same effect as Focus. c- Change: Edit the field in the editor and tab out of it, the color of the text should toggle (randomly) between red, green and blue. d- KeyPress: If you edit the field and you type @, it should give AT. e- Click: Click on the tag editor. Change the value in the popup. If you press OK, the field should be changed. [3] Would the documentation in the perl script help you to create a plugin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:21:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:21:38 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34311|0 |1 is obsolete| | --- Comment #23 from M. de Rooy --- Created attachment 35190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35190&action=edit Bug 10480: Remove useless routines and irrelevant pod lines This patch makes the following cleanup actions for all plugins: 1- Remove sub plugin_parameters. This function is not used. 2- Remove empty plugin or empty plugin_javascript subs. 3- Remove empty Blur, Clic or Focus routines from javascript. 4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs. 5- Remove the last 1; line. It is no longer needed. Test plan: Run the unit test t/db_dependent/FrameworkPlugins.t Test some cataloguing plugins in addbiblio. Test some item plugins in additem and neworderempty. Signed-off-by: Marcel de Rooy I also checked the syntax of all plugins with perl -c. And checked the pod (if any) with podchecker: Two files still produce a warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:21:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:21:42 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34312|0 |1 is obsolete| | --- Comment #24 from M. de Rooy --- Created attachment 35191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35191&action=edit Bug 10480: Follow-up for unimarc_field_686a/_700-4.pl This patch fixes the pod errors on those two files by removing the pod section that actually does not add anything useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:22:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:22:18 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #25 from M. de Rooy --- Rebased. Anyone willing to help getting this further? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:37:27 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35125|0 |1 is obsolete| | --- Comment #210 from M. de Rooy --- Created attachment 35192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35192&action=edit Bug 7143: Release team 3.20 Updated the release team with the roles for 3.20 pages on the wiki and checked with the votes on the IRC meeting log. Simplified the section on Former release team members by moving that information (in a compressed format) to the Developers section. If someone had a role for multiple releases, I used constructs as 3.X. Sorted the Additional thanks-section. Signed-off-by: Justin Signed-off-by: Marcel de Rooy 2015-01-14: Amended. Replaced abbreviations like RM by Release Manager. Replaced one occurrence of 3.x by 3.X (for Owen). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:45:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:45:02 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #20 from Marc V?ron --- Sorry, I can still provocate a crash bei entering an invalid date (e.g.invalid month) and skipping the date picker. Example: From: 01/12/2014 => Works OK From: 01/16/2014 => Crash Software error: The 'day' parameter ("2014") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback at /usr/lib/perl5/DateTime.pm line 199 DateTime::new(undef, 'day', 2014, 'year', 1916, 'time_zone', 'Europe/Zurich') called at /usr/share/perl5/DateTime/Format/DateParse.pm line 58 DateTime::Format::DateParse::parse_datetime('DateTime::Format::DateParse', '16/01/2014', 'Europe/Zurich') called at /usr/share/kohaclone/Koha/DateUtils.pm line 92 Koha::DateUtils::dt_from_string('01/16/2014') called at /usr/share/kohaclone/acqui/parcels.pl line 145 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 14:50:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 13:50:27 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:00:23 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 --- Comment #3 from Julian Maurice --- The code actually doesn't allow to search in 952 (or 995 for UNTh?se, M?moire, Rapport IMARC), but it should, so this is a bug. I'll try to work on that this week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:00:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:00:49 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #21 from Katrin Fischer --- Hm, maybe we could catch the error and just give back a message that an invalid date was entered? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:01:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:01:21 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 --- Comment #4 from Katrin Fischer --- Thank you Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:02:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:02:02 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35167|0 |1 is obsolete| | --- Comment #211 from M. de Rooy --- Created attachment 35193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35193&action=edit Bug 7143: Adding releases to history file To test, verify that the latest releases appear in docs/history.txt Signed-off-by: Marcel de Rooy Verified some release dates and still added a few missing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:02:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:02:24 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:14:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:14:46 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #22 from Jonathan Druart --- Not sure it's valid. Koha does not catch this kind of error. You are not suppose to enter an invalid date :) That's why we use a date picker. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:20:56 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #23 from Katrin Fischer --- I think maybe out of scope here, but we should have a general solution. The datepicker is not accessible, I had to unlock a few fields for a library because of that. But I also have reports from other libraries that complain about having to use the datepicker for dates and feel entering manually is much easier. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:22:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:22:40 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Justin, Do you agree if I add your surname to the patch author? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:23:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:23:33 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 --- Comment #5 from Julian Maurice --- It seems I made a copy/paste error (will you find it ? :p) I meant "(or 995 for UNIMARC)" of course -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:24:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:24:25 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEPENDS ON 11944] UTF-8 |UTF-8 problems when |problems when creating a |creating a patron list from |patron list from the patron |the patron search results |search results page |page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:30:40 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #24 from Jonathan Druart --- The input is not readonly, so they are able to enter a date. I agree with what you said, it should be fixed. But not here :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:33:43 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #212 from M. de Rooy --- Created attachment 35194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35194&action=edit Bug 7143: QA Follow-up for abbrev PM Replacing PM by Packaging Manager Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:44:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:44:14 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Paola Rossi --- (In reply to Jonathan Druart from comment #21) > (In reply to Paola Rossi from comment #18) > > Thanks, Jonathan. > > > 1) Before saving the new report, in the "Save your custom report" form, > > "Serials" was not in the "Report group" drop down list. > > So I could not select the "Serials" Report group [I had to create it as > > a new report-group]. > > The last patch adds a new "Serials" group to the list. > I've applied the patch against master 3.19.00.006 Thanks, Jonathan: now the "Report group" list is OK! Now on the 2-nd step: Step 2 of 6: Pick a report type 3 values were listed [Tabular,Summary,Matrix], but only the first one was available. So I pass the patch to "Failed QA" status. NB. About the Mathieu's problem in Comment 9, now the report got 1 line for each serial's record in the DB (RIGHT imo). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:48:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:48:09 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #25 from Katrin Fischer --- I agree. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:49:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:49:07 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 35195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35195&action=edit Bug 13579: (regression tests) Encoding issues on about > timeline get tested This patch introduces two tests for encoding issues on about > timeline To test: - Apply the patch and run $ KOHA_USER=kohaadmin KOHA_PASS=katikoan KOHA_INTRANET_URL=http://koha-dev.biblioadmin prove t/db_dependent/www/history.t (adjust to your own settings, the user needs to have access to the about page) Regards Signed-off-by: Manuel Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:57:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:57:34 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #26 from Marc V?ron --- I agree with Jonathan that I am not supposed to give a wrong date. I did it accidentally, and other users will do that for sure :-) Koha should handle it gracefully and not crash with a software error. And I agree with Katrin that we should have a more general solution for fields that involve DatePicker. This would be an other bug. (Keep in mind Bug 11448 /Accessibility) At other places the date is validated by JavaScript, e.g. on memberentry.pl. If I enter a wrong month for date of birth, I get a warning "Invalid month entered in field dateofbirth" The related JavaScript function CheckDate() comes from /intranet-tmpl/prog/en/js/members.js (= local solution) For this bug the question is: Keep DatePicker and have the chance for crashes if a user skips the DatePicker with a wrong date? If yes, I'll sign-off. Or keep it the old way (no DatePicker, no crash) until we have a more general solution? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:57:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:57:58 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11448 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 15:57:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 14:57:58 +0000 Subject: [Koha-bugs] [Bug 11448] Accessibility: Make it possible to enter date for restriction without using the datepicker widget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11448 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4402 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:08:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:08:22 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #27 from Katrin Fischer --- I think the datepicker is not the problem here - that's just the way data gets into the field. The date processing in the .pl is what throws the error. It didn't before, because there was no date processing :( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:08:59 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:09:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:09:07 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34204|0 |1 is obsolete| | Attachment #34205|0 |1 is obsolete| | Attachment #34206|0 |1 is obsolete| | Attachment #34207|0 |1 is obsolete| | Attachment #34208|0 |1 is obsolete| | Attachment #34209|0 |1 is obsolete| | Attachment #34210|0 |1 is obsolete| | Attachment #34211|0 |1 is obsolete| | Attachment #34212|0 |1 is obsolete| | Attachment #34213|0 |1 is obsolete| | Attachment #34214|0 |1 is obsolete| | Attachment #34215|0 |1 is obsolete| | --- Comment #600 from Kyle M Hall --- Created attachment 35196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35196&action=edit [SIGNED-OFF] Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:09:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:09:28 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #601 from Kyle M Hall --- Created attachment 35197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35197&action=edit [SIGNED-OFF] Bug 6427 - Update schema files Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:09:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:09:36 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #602 from Kyle M Hall --- Created attachment 35198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35198&action=edit [SIGNED-OFF] Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:09:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:09:44 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #603 from Kyle M Hall --- Created attachment 35199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35199&action=edit [SIGNED-OFF] Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:10:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:10:03 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #605 from Kyle M Hall --- Created attachment 35201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35201&action=edit [SIGNED-OFF] Bug 6427 - Add TableTools plugin for DataTables Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:09:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:09:52 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #604 from Kyle M Hall --- Created attachment 35200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35200&action=edit [SIGNED-OFF] Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:10:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:10:12 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #606 from Kyle M Hall --- Created attachment 35202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35202&action=edit [SIGNED-OFF] Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:10:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:10:21 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #607 from Kyle M Hall --- Created attachment 35203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35203&action=edit [SIGNED-OFF] Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:10:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:10:29 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #608 from Kyle M Hall --- Created attachment 35204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35204&action=edit [SIGNED-OFF] Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:10:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:10:37 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #609 from Kyle M Hall --- Created attachment 35205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35205&action=edit [SIGNED-OFF] Bug 6427 - Add & update cron scripts Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:10:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:10:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #610 from Kyle M Hall --- Created attachment 35206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35206&action=edit [SIGNED-OFF] Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:10:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:10:54 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #611 from Kyle M Hall --- Created attachment 35207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35207&action=edit [SIGNED-OFF] Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:11:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:11:02 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #612 from Kyle M Hall --- Created attachment 35208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35208&action=edit [SIGNED-OFF] Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:11:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:11:18 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35195|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 35209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35209&action=edit Bug 13579: (regression tests) Encoding issues on about > timeline get tested This patch introduces two tests for encoding issues on about > timeline To test: - Apply the patch and run $ KOHA_USER=kohaadmin KOHA_PASS=katikoan KOHA_INTRANET_URL=http://koha-dev.biblioadmin prove t/db_dependent/www/history.t (adjust to your own settings, the user needs to have access to the about page) Regards Signed-off-by: Manuel Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:11:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:11:22 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 --- Comment #6 from Jonathan Druart --- Created attachment 35210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35210&action=edit Bug 13579: Prefer like instead of ok to match a regex Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:15:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:15:34 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 --- Comment #17 from Paola Rossi --- In master 3.19.00.006 t/db_dependent/Suggestions.t has 1 more line: use C4::Budgets; So the 2-nd patch would need to be rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:31:38 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28929|0 |1 is obsolete| | Attachment #28930|0 |1 is obsolete| | Attachment #28931|0 |1 is obsolete| | Attachment #28932|0 |1 is obsolete| | Attachment #28933|0 |1 is obsolete| | Attachment #28934|0 |1 is obsolete| | Attachment #28935|0 |1 is obsolete| | Attachment #28936|0 |1 is obsolete| | Attachment #28937|0 |1 is obsolete| | Attachment #28938|0 |1 is obsolete| | Attachment #28939|0 |1 is obsolete| | Attachment #28940|0 |1 is obsolete| | Attachment #28941|0 |1 is obsolete| | Attachment #29161|0 |1 is obsolete| | --- Comment #167 from Jonathan Druart --- Created attachment 35211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35211&action=edit Bug 10855: Add the new package Koha::AdditionalField -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:31:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:31:45 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #168 from Jonathan Druart --- Created attachment 35212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35212&action=edit Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:31:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:31:50 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #169 from Jonathan Druart --- Created attachment 35213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35213&action=edit Bug 10855: interface configuration for adding new fields to subscriptions This patch adds an interface configuration for adding fields to subscriptions. Test plan: - go to serials/serials-home.pl - click on the "Add subscription fields" link on the left of the screen - try to add/update/delete new fields You are not abble to add a field with an authorised value category and a marcfield. Columns are sortable - for the rest, you should have, at least: * a new field named af1, sortable, linked to a category * a new field named af2, sortable, linked to a marcfield * a new field named af3, not sortable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:32:02 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #170 from Jonathan Druart --- Created attachment 35214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35214&action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:32:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:32:14 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #171 from Jonathan Druart --- Created attachment 35215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35215&action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:32:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:32:20 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #172 from Jonathan Druart --- Created attachment 35216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35216&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:32:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:32:27 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #173 from Jonathan Druart --- Created attachment 35217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35217&action=edit Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields -> additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField->all method take "tablename" not "table" in parameter". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:32:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:32:33 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #174 from Jonathan Druart --- Created attachment 35218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35218&action=edit Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:32:45 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #176 from Jonathan Druart --- Created attachment 35220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35220&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:32:39 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #175 from Jonathan Druart --- Created attachment 35219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35219&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:32:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:32:52 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #177 from Jonathan Druart --- Created attachment 35221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35221&action=edit Bug 10855: Additional marc fields are not inserted In subscription-add.pl, the code for inserting additional_fields is not the same for updating and inserting. This patch refactores this code in code to do the same tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:35:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:35:28 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- (In reply to Owen Leonard from comment #6) > (In reply to Katrin Fischer from comment #5) > > This doesn't work for me as a stand alone patch > > I tested this on top of the Biblibre branch for Bug 11944. Looks like the > patch git generated when I signed off inserted an extra Content-Type line: > > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > Content-Type: text/plain; charset="utf-8" > > It might work if you edit the extra line out. If anyone knows how I can > prevent that from happening in the future please let me know. This was a known bug in Git. I reported it, and a nice git developer fixed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:35:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:35:41 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #178 from Jonathan Druart --- Back to needs signoff for even more fun :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:37:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:37:49 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35142|0 |1 is obsolete| | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:38:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:38:40 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33157|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 35222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35222&action=edit Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:39:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:39:05 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 --- Comment #13 from Jonathan Druart --- Rebase against master (with 11944), small conflict fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:42:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:42:05 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #262 from Jonathan Druart --- I am going to reupload on this bug report the 31 patches pushed into master, for the history and/or backport them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:42:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:42:22 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29981|0 |1 is obsolete| | --- Comment #263 from Jonathan Druart --- Created attachment 35223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35223&action=edit Bug 11944: Remove all utf8 filter from templates This patch - removes all html_entity usages in tt file which hide utf8 bugs - removes all encode utf8 in tt plugins because we should get correctly marked data from DBIC and other sources directly (cf plugin EncodeUTF8 used in renew.tt) - adds some cleanup in C4::Templates::output: we now use perl utf8 file handler output so we don't need to decode tt variables manually. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:42:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:42:29 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29982|0 |1 is obsolete| | --- Comment #264 from Jonathan Druart --- Created attachment 35224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35224&action=edit Bug 11944: replace use of utf8 with Encode See the wiki page for the explanation. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29983|0 |1 is obsolete| | --- Comment #265 from Jonathan Druart --- Created attachment 35225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35225&action=edit Bug 11944: Encoding UTF8 in C4::Templates Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:42:40 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29984|0 |1 is obsolete| | --- Comment #266 from Jonathan Druart --- Created attachment 35226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35226&action=edit Bug 11944: Set ImplicitUnicode for YAML Before this patch, string for yaml files used in preferences.pl were broken. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:42:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:42:46 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29985|0 |1 is obsolete| | --- Comment #267 from Jonathan Druart --- Created attachment 35227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35227&action=edit Bug 11944: Library name variable should be decoded Test on preferences.pl and on some others pages when mysql is used to store session. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:42:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:42:52 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29986|0 |1 is obsolete| | --- Comment #268 from Jonathan Druart --- Created attachment 35228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35228&action=edit Bug 11944: replace uri_escape with uri_escape_utf8 everywhere To reproduce, edit, index notice with utf-8 char and search for it Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:42:58 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29987|0 |1 is obsolete| | --- Comment #269 from Jonathan Druart --- Created attachment 35229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35229&action=edit Bug 11944: Never use decode/encode in TT Plugins The EncodeUTF8 TT plugin is useless, we should NEVER use encode in templates. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:43:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:43:04 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29988|0 |1 is obsolete| | --- Comment #270 from Jonathan Druart --- Created attachment 35230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35230&action=edit Bug 11944: Remove obsolete encoding routines We don't need to decode manually which provide nice performance boost. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:43:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:43:12 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29989|0 |1 is obsolete| | --- Comment #271 from Jonathan Druart --- Created attachment 35231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35231&action=edit Bug 11944: TT Plugins should not encode strings Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:43:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:43:19 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29990|0 |1 is obsolete| | --- Comment #272 from Jonathan Druart --- Created attachment 35232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35232&action=edit Bug 11944: Some refresh don't indicate the charset to use This patch replaces occurrences of META HTTP-EQUIV=Refresh with a redirection. Note: The list of modified files has been got with the following grep: git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator | grep -v \.js Test plan: 1) admin/auth_tag_structure.pl - Go on an authority MARC framework for an authority type (admin/auth_tag_structure.pl?authtypecode=CO for instance) - Click on the "Add a new tag" button - Fill fields - Save - You should be redirected on the auth_tag_structure.pl page - Try to modify an existing tag - The redirection should be done 2) admin/auth_subfields_structure.pl - From the previous page, click on a "subfields" link - Edit/Add a new subfields - Save - You should be redirected to the subfield list - Delete a subfield - You should be redirected to the subfield list 3) admin/authorised_values.pl - Add/Edit an authorised value - Save - You should be redirected to the authorised value list (with the right category selected) 4) admin/categorie.pl - Add/Edit a patron category - Save - You should be redirected to the category list - Delete a patron category - You should be redirected to the category list 5) admin/koha2marclinks.pl - Go on the Koha to MARC mapping configuration page - Edit a field - Map a field and click on "OK" - You should be redirected to the list 6) admin/marc_subfields_structure.pl - Go on the MARC frameworks page - Click on "MARC structure" for one on the list - Click on "Subfields" for one on the list - Add/Edit a subfield - Save - You should be redirected to the subfield list 7) admin/systempreferences.pl - Go on the system preferences admin page - Click on the "Local use" tab - Add/Edit a pref - Save - You shold be redirected to the Local use preference list 8) serials/subscription-detail.pl - Go on a subscription detail page - Delete the subscription (using Edit > Delete subscription) - You should be redirected on the serials home page Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:43:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:43:26 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29991|0 |1 is obsolete| | --- Comment #273 from Jonathan Druart --- Created attachment 35233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35233&action=edit Bug 11944: FIX Error on editing an authority Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:43:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:43:32 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29992|0 |1 is obsolete| | --- Comment #274 from Jonathan Druart --- Created attachment 35234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35234&action=edit Bug 11944: Fix encoding issue on searching The search patch should fix non-latin character searches. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:43:39 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29993|0 |1 is obsolete| | --- Comment #275 from Jonathan Druart --- Created attachment 35235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35235&action=edit Bug 11944: Authentication The password should be encoded before hashing. Test plan: - Before applying the patch, create a user with utf-8 in password - apply patches - try to log in - change the password - log out - try to log in Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:43:45 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29994|0 |1 is obsolete| | --- Comment #276 from Jonathan Druart --- Created attachment 35236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35236&action=edit Bug 11944: Fix fund names encoding on the parcel page On the parcel page, the subtotal values are stored in an hashref. The key was the fund name. The fund name being encoded in utf8, the hashref was broken. This patch replaces this logic creating a key based on an integer. The budget name is now stored in a new "budget_name" key. Note: It also fixes a small ergonomic issue (a td was missing in the tfoot). Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:43:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:43:51 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29995|0 |1 is obsolete| | --- Comment #277 from Jonathan Druart --- Created attachment 35237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35237&action=edit Bug 11944: Fix encoding issue on adding a subscription If frequencies or numbering patterns contain non-latin characters, so output was broken. To reproduce: - Create a frequency and a numbering pattern with non-latin characters - Add a new subscription using these values - The screen should not contain bad encoded characters. Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:43:58 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29996|0 |1 is obsolete| | --- Comment #278 from Jonathan Druart --- Created attachment 35238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35238&action=edit Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:05 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29997|0 |1 is obsolete| | --- Comment #279 from Jonathan Druart --- Created attachment 35239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35239&action=edit Bug 11944: Fix encoding on sending emails This patch fixes 2 places where mails were badly encoded: 1/ At the opac and the intranet, on sending baskets 2/ At the opac and the intranet, on sending shelf/list Test plan: Shelf/List: - Create a list with non-latin characters in the name. - Add some items containing non-latin characters in their content. - Send the list by email Basket/Cart: - Add some items containing non-latin characters in their content to your cart.. - Send the cart by email Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:11 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29998|0 |1 is obsolete| | --- Comment #280 from Jonathan Druart --- Created attachment 35240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35240&action=edit Bug 11944: Fix encoding issue for the "Did you mean" feature Test plan: 1/ Go on admin/didyoumean.pl and enable the feature for the OPAC 2/ Generate and use the french templates 3/ Launch a search at the OPAC 4/ You should see correctly encoded message Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:18 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29999|0 |1 is obsolete| | --- Comment #281 from Jonathan Druart --- Created attachment 35241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35241&action=edit Bug 11944: Fix encoding issue on search history Newly introduced by patches from bug 10807, the string was decoded before to be stored in session. To reproduce: Enable history search Go at the OPAC and log out Search for something with utf-8 Go on your search history The search description should be correctly encoded Signed-off-by: Jonathan Druart Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:24 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30000|0 |1 is obsolete| | --- Comment #282 from Jonathan Druart --- Created attachment 35242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35242&action=edit Bug 11944: Remove bad FIXME in guided_report Bug 11679 introduced a FIXME for this but it is wrong. The strings have to be encoded before generating the ods file. However, it is useless to decode column names. Signed-off-by: Jonathan Druart Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:31 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30002|0 |1 is obsolete| | --- Comment #283 from Jonathan Druart --- Created attachment 35243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35243&action=edit Bug 11944: Fix encoding issue in C4::ItemType There is no need to encode strings coming from DB. To reproduce: go on admin/item_circulation_alerts.pl The headers contain bad encoded characters. Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:33 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Morag, and congratulations! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:37 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30003|0 |1 is obsolete| | --- Comment #284 from Jonathan Druart --- Created attachment 35244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35244&action=edit Bug 11944: (follow-up) Remove all utf8 filter from templates This patch removes 2 new occurrences introduced by bug 11351 and bug 10493. Signed-off-by: Magnus Enger Removes a nasty "Template process failed: plugin error - EncodeUTF8: plugin not found at /home/magnus/scripts/kohaclone/C4/Templates.pm line 124" from /cgi-bin/koha/admin/itemtypes.pl Signed-off-by: Dobrica Pavlinusic Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:44 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30004|0 |1 is obsolete| | --- Comment #285 from Jonathan Druart --- Created attachment 35245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35245&action=edit Revert "Bug 12279: Diacritics in system preference editor broken" This reverts commit 2fa2480447a58f9d5d3f7834bcfdcf62a0a95df3. Signed-off-by: Tomas Cohen Arazi Conflicts: admin/preferences.pl Signed-off-by: Dobrica Pavlinusic http://bugs.koha-community.org/show_bug.cgi?id=11944 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:51 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30005|0 |1 is obsolete| | --- Comment #286 from Jonathan Druart --- Created attachment 35246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35246&action=edit Bug 11944: remove url/uri filter from query_cgi We don't need to pass query_cgi through url (or uri) filter since this will turn query string (correctly escaped inside code) back into two-byte escaped string which CGI( -utf8 ) won't turn back into proper utf-8 Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:44:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:44:58 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30006|0 |1 is obsolete| | --- Comment #287 from Jonathan Druart --- Created attachment 35247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35247&action=edit Bug 11944: decode uri_unescape data This data is passed into form so it needs to be correctly marked as utf-8 if we want form submit to work correctly This change fixes sort issues which use form submit. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:45:04 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:45:06 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30016|0 |1 is obsolete| | --- Comment #288 from Jonathan Druart --- Created attachment 35248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35248&action=edit Bug 11944: Convert DB tables to utf8_unicode_ci Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:45:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:45:14 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30945|0 |1 is obsolete| | --- Comment #289 from Jonathan Druart --- Created attachment 35249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35249&action=edit Bug 11944: Fix suggestion at the OPAC for perl v5.10 Without this patch and using Perl v5.10, on adding a suggestion at the OPAC, the script explodes with the following error: "cannot decode string with wide characters". With this patch, all is fine using Perl v5.10 and v5.18. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:45:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:45:22 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31299|0 |1 is obsolete| | --- Comment #290 from Jonathan Druart --- Created attachment 35250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35250&action=edit Bug 11944: (follow-up) Convert DB tables to utf8_unicode_ci Some lines didn't match the regex I used! Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:45:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:45:35 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #291 from Jonathan Druart --- Created attachment 35251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35251&action=edit Bug 11944: revert unneeded IsStringUTF8ish behaviour change Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:45:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:45:38 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:45:42 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #292 from Jonathan Druart --- Created attachment 35252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35252&action=edit Bug 11944: Fix problems introduced by bug 11515 The game continue... Patch for bug 11515 introduced regression on this patch set. To reproduce: search with utf8 characters at the opac Test plan: Verify that the issue described on bug 11515 is still fixed and that no regression is found at the OPAC. Note that I am pretty sure this patch is not enough. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:46:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:46:02 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #28 from Marc V?ron --- The crash occurs in Koha/DateUtils.pm DateUtils.pm line 92, sub dt_from_string return DateTime::Format::DateParse->parse_datetime( $date_string, $tz->name() ); Description: Passed a date string returns a DateTime object format and timezone default to the system preferences. If the date string is empty DateTime->now is returned I propose to have a new bug to change the function for testing the validity of the string and return DateTime->now as well if the date string is not valid. Validation could be done e.g. with DateTime::Format::DateManip->parse_datetime ( $datestring ). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:45:50 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #293 from Jonathan Druart --- Created attachment 35253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35253&action=edit Bug 11944: (RM followup) Missing dependency in C4::Context Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:46:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:46:21 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:47:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:47:01 +0000 Subject: [Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:48:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:48:38 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30001|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:50:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:50:12 +0000 Subject: [Koha-bugs] [Bug 4402] Date filter in parcels.tt requires db format dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4402 --- Comment #29 from Jonathan Druart --- The easier thing to do would be to add a check on all inputs managed by datepicker to validate what the user filled. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:51:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:51:29 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:51:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:51:32 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34920|0 |1 is obsolete| | --- Comment #18 from M. Tompsett --- Created attachment 35254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35254&action=edit [PASSED QA] Bug 13457 - Followup for CPL and S codes Based on comment #3, this corrects CPL and S issues if they do not exist in the DB. TEST PLAN --------- 0) Backup your DB. 1) Clear CPL and S from your DB. - delete from borrowers where categorycode='S'; - delete from categories where categorycode='S'; - delete from borrowers where branchcode='CPL'; - delete from branch where branchcode='CPL'; 2) prove t/db_dependent/Suggestions.t -- This should fail. 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- This should work. 5) Intentionally add categorycode 'S' and branchcode 'CPL' back into the database. 6) prove t/db_dependent/Suggestions.t -- This should work. 7) run koha qa test tools. 8) Restore your DB :) Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Rebased. Paola Rossi's comment #17 was correct. Simple fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:52:40 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE are not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The correct COLLATE set to |The correct COLLATE are not |all DB tables |set to all DB tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 16:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 15:52:48 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The correct COLLATE are not |The correct COLLATE is not |set to all DB tables |set to all DB tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 17:36:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 16:36:13 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 --- Comment #11 from Christopher Brannon --- (In reply to John Andrews from comment #10) > The JS solution is working brilliantly in the OPAC, but there is no change > on the staff side when I include this in intranetuserjs -- any suggestions > on how to make it work there as well? It's working on our end. Perhaps there is a conflicting jQuery? What version of Koha on you on? Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 17:43:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 16:43:28 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32788|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 35255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35255&action=edit Bug 12632 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 17:43:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 16:43:26 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 17:43:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 16:43:40 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #13 from Kyle M Hall --- Created attachment 35256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35256&action=edit Bug 12632 - Hold limits ignored for record level holds with item level itemtypes The crux of the issue is that if you are using item level itemtypes, but are allowing biblio levels holds, those holds do not have items. So, in CanItemBeReserved, when Koha counts the number of holds to compare against the given rule, it will always give 0 ( except of course for found holds, and the occasional item-level hold ). So the query is saying "link each of these reserves to the reserved item, and count the number of reserves this patron where the itemtype is DVD". However, since these are all record level reserves, there are no items to link to, and so when it looks for all reserves this and item whose itemtype is DVD, it finds zero reserves! This patch solves the problem by looking first at the item level itemtype, and if it does not exist, then it looks at the record level itemtype. For installations using record level itemtypes, the behavior remains unchanged. Test plan: 1) Enable item level itemtypes 2) Create two records with one item each of a given itemtype 3) Create a single issuing rule and limit the holds allowed for that itemtype to 1 4) Place a record level hold on your first record 5) Attempt to place a record level hold for the same patron on your second record. You should not be able to but you can! 6) Apply this patch 7) Repeat step 5, note you can no longer place the hold! Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 17:45:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 16:45:31 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35255|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 35257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35257&action=edit Bug 12632 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 17:47:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 16:47:00 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 --- Comment #12 from John Andrews --- We're on 3.16.03.000. There are no other scripts in intranetuserjs that should affect details pages at all so I'm not sure where to even begin looking for a conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 17:49:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 16:49:21 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 --- Comment #13 from Christopher Brannon --- (In reply to John Andrews from comment #12) > We're on 3.16.03.000. > > There are no other scripts in intranetuserjs that should affect details > pages at all so I'm not sure where to even begin looking for a conflict. There may be conditions it is not able to catch. Have you tried other searches? Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 18:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 17:21:26 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 --- Comment #14 from John Andrews --- Have tried various searches -- links with no parentheses work fine, all links I've found with parentheses return the broken search results. Cache cleared, and double-checked to make sure I copied the full script -- everything *looks* like it should be working correctly, but we still only get parentheses removed in the opac and not the staff client. John -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 18:34:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 17:34:43 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34862|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Created attachment 35258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35258&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing added) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 18:35:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 17:35:34 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 18:35:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 17:35:37 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 --- Comment #15 from Christopher Brannon --- Sorry. I wish I could figure out what's stopping it from working. I guess someone will actually need to fix this. :/ Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 18:57:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 17:57:47 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35222|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 35259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35259&action=edit Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 18:58:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 17:58:51 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 20:12:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 19:12:16 +0000 Subject: [Koha-bugs] [Bug 6758] Capture membership renewal date for reporting purposes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |director at plaistowlibrary.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 20:19:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 19:19:30 +0000 Subject: [Koha-bugs] [Bug 13581] New: item circ history has 'last seen' labeled wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13581 Bug ID: 13581 Summary: item circ history has 'last seen' labeled wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org On this page: cgi-bin/koha/circ/bookcount.pl?&biblionumber=106124&bi=106124&itm=140197 the 'last seen' column is actually the timestamp - not the date last seen so it's confusing. The label should be changed or the value should be changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 21:11:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 20:11:45 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #9 from Thomas Wright --- (In reply to Martin Renvoize from comment #8) > OK, I'm happy with the logic here. I had to go digging a little to prove to > mysefl that the assumption was valid. (Lines 530 -> 539 in commit > http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac- > tmpl/bootstrap/en/modules/opac-results.tt; > hb=544520d6bdfacada4eba4caefedf42864db4b3a0#l529) > > So, this patch does indeed fix the problem.. however as a side note, I > really don't like seeing this kind of logic at the template level.. it's not > testable and leads to repetative code :'(. > > I'de rather see the template just ask the question 'to display, or not to > display?', and have the actual logic involved in that question handled > further up in the code, perferably in either C4/Suggestions.pm or as part of > the Koha.preference plugin somehow. That way, we'd have a testable fix. > Just a thought Should I work on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 21:13:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 20:13:05 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #10 from Katrin Fischer --- I think not a blocker for your patch - just some thoughts about how we could handle things better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 21:22:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 20:22:21 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 --- Comment #7 from Thomas Wright --- Created attachment 35260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35260&action=edit Bug 13531: QA follow up A minor QA comment. ::: misc/migration_tools/bulkmarcimport.pl @@ +271,5 @@ > my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch( $query, 0, 3, [$server] ); > + # changed to warn so able to continue with one broken record > + if ( defined $error ) { > + warn "unable to search the database for duplicates : $error"; > + next; For consistency with the rest of the script, should this perhaps be: next RECORD; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 21:25:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 20:25:37 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 21:26:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 20:26:16 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rochellehealy.student at wegc. | |school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 21:45:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 20:45:53 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |justinvos at live.com --- Comment #5 from Justin Vos --- In my test, I applied the patch and ran updatedatabase.pl. However I received this error message: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 13 at ./updatedatabase.pl line 9735. DBD::mysql::db do failed: Can't create table 'koha_kohadev.#sql-a48_3a' (errno: 150) at ./updatedatabase.pl line 9776. DBD::mysql::db do failed: Can't create table 'koha_kohadev.#sql-a48_3a' (errno: 150) at ./updatedatabase.pl line 9782. DBD::mysql::db do failed: Table 'koha_kohadev.club_templates' doesn't exist at ./updatedatabase.pl line 9801. DBD::mysql::db do failed: Can't create table 'koha_kohadev.#sql-a48_3a' (errno: 150) at ./updatedatabase.pl line 9806. DBD::mysql::db do failed: Can't create table 'koha_kohadev.#sql-a48_3a' (errno: 150) at ./updatedatabase.pl line 9811. Upgrade to 3.19.00.XXX done (Bug 12461 - Add patron clubs feature) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 21:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 20:55:27 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #5 from Thomas Wright --- Created attachment 35261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35261&action=edit Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines. Test Plan: -Search for a patron from an account without the 'borrowers' permission and with the 'updatecharges' permission. *The fines tab should not be present. -Update the account's permissions to include the 'borrowers' permission *The fines tab should now be present. -Update the account's permissions so it has neither 'borrowers' or 'updatecharges' *The fines tab should not be present -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 22:16:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 21:16:04 +0000 Subject: [Koha-bugs] [Bug 13582] New: Able to view menu for Circulation History even when user does not have permission Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Bug ID: 13582 Summary: Able to view menu for Circulation History even when user does not have permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: tomsStudy at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Same problem as Bug 10943. The page requires borrowers to access but the menu item is still shown to users who do not have the borrowers permission. >From readingrec.pl we see: flagsrequired => {borrowers => 1}, Yet in the include the only thing checked is: [% IF ( readingrecordview ) %] So a user who doesn't have permission to access Circulation history can still see the menu item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 22:16:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 21:16:25 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Thomas Wright --- I'm working on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 22:21:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 21:21:03 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Abby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abbyrobertson.student at wegc. | |school.nz Status|Needs Signoff |In Discussion --- Comment #3 from Abby --- The search cookie is no longer used in master, search history is stored in the database. Have we missed anything? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 22:27:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 21:27:27 +0000 Subject: [Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Justin Vos --- I'm not sure what is required here. While editing a patron's details in the staff client, there is already a link back to the patron's details page in the left side-bar named "Details". Is the link needed somewhere else? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 22:29:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 21:29:23 +0000 Subject: [Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 --- Comment #3 from Katrin Fischer --- Hi Justin, try the following: - go to the patron account from the OPAC - enter an address change request from the details page there - see that a note appears in the patron module and on the start page of the staff client - the entry asking to moderate the modification is the one to change -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 22:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 21:29:34 +0000 Subject: [Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:06:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:06:20 +0000 Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 --- Comment #3 from Rochelle Healy --- Created attachment 35262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35262&action=edit Bug 7996: Patron Modification Log Requires Parameters Permission To test 1- Open 'set permissions' on patron page and uncheck '(parameters) Set koha system parameters' 2- Open patron page and notice that there is no 'modification log' tab 3- Apply patch 4- Refresh page and notice 'modification log' tab is there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:06:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:06:49 +0000 Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |rochellehealy.student at wegc. | |school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:07:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:07:56 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 --- Comment #2 from Thomas Wright --- Created attachment 35263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35263&action=edit Bug 13582 - Able to view menu for Circulation History even when user does not have permission Added check for borrowers that stops the Circulation History link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Circulation history should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Circulation history should be present in the menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:16:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:16:43 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 --- Comment #8 from Justin Vos --- Created attachment 35264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35264&action=edit Bug: 11358 - Use HTTPS Amazon images when Koha is using HTTPS. We've tried to fix the conflicts, not entirely sure if correct, please test thoroughly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:27:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:27:32 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Thomas Wright --- After discussion with Chris the decision has been made to hide the unnavigable menu items. This could be done with the CSS and greying out the unavailable options but currently that appears to be broken. This may in fact be a better solution as it removes any confusion users may have as to why when they click on things they don't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:46:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:46:43 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #4 from Brandon --- Created attachment 35265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35265&action=edit Bug 10177 - whitespace is a valid password causing pernicious perturbations. Test plan: Go to your patron, go to change username and/or password. change password to whitespace, notice it is accepted, apply this patch, change password again, to whitespace, notice password is not valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:49:20 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz Component|Architecture, internals, |Packaging |and plumbing | Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:52:40 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |justinvos at live.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:58:42 +0000 Subject: [Koha-bugs] [Bug 13583] New: Able to view menu for Statistics even when user does not have permission Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Bug ID: 13583 Summary: Able to view menu for Statistics even when user does not have permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: tomsStudy at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Same problem as Bug 10943. The page requires borrowers to access but the menu item is still shown to users who do not have the borrowers permission. >From statistics.pl we see: flagsrequired => {borrowers => 1}, No permissions are currently checked. So a user who doesn't have permission to access Statistics can still see the menu item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 14 23:58:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 22:58:52 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Thomas Wright --- Working on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:09:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:09:09 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 --- Comment #2 from Thomas Wright --- Created attachment 35266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35266&action=edit Bug 13583 - Able to view menu for Statistics even when user does not have permission Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Statistics should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Statistics should be present in the menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:10:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:10:14 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:10:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:10:50 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:11:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:11:14 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:23:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:23:37 +0000 Subject: [Koha-bugs] [Bug 13584] New: Able to view menu for Purchase Suggestions even when user does not have permission Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Bug ID: 13584 Summary: Able to view menu for Purchase Suggestions even when user does not have permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: tomsStudy at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Same problem as Bug 10943. The page requires borrowers to access but the menu item is still shown to users who do not have the borrowers permission. >From purchase-suggestions.pl we can see there is no check for which permissions are required to visit the linked page. Yet in the include the only thing checked is: [% IF ( suggestionsview ) %] So a user who doesn't have permission to access Purchase suggestions can still see the menu item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:25:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:25:56 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Thomas Wright --- I'm working on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:29:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:29:54 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 --- Comment #2 from Thomas Wright --- Created attachment 35267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35267&action=edit Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission Added check for borrowers that stops the Purchase Suggestions link being shown. This could be done through the css but that function currently appears to be broken Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Purchase suggestions item should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Purchase suggestions item should be present in the menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:30:35 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:43:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:43:38 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.18.x, will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 00:54:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Jan 2015 23:54:20 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 --- Comment #4 from David Cook --- (In reply to Abby from comment #3) > The search cookie is no longer used in master, search history is stored in > the database. > > Have we missed anything? Interesting! I haven't looked at master recently, so I'm not sure. I wonder which commit changed the use of the search cookie... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:02:12 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Brandon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |brandon_h27 at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:02:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:02:43 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #2 from Rochelle Healy --- Created attachment 35268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35268&action=edit Bug 13571: Koha-conf.xml.in has fallen out of sync with koha-conf.xml To test: 1- Build new koha packages 2- Check that the conflist file contains the changes we have made -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:31:30 +0000 Subject: [Koha-bugs] [Bug 12845] C4::Output::FormatData is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12845 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:34:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:34:22 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:34:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:34:53 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Please rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:37:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:37:29 +0000 Subject: [Koha-bugs] [Bug 12868] GetMemberDetails calls GetMemberAccountRecords incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12868 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Passed QA |Pushed to Stable --- Comment #15 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:37:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:37:42 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:38:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:38:13 +0000 Subject: [Koha-bugs] [Bug 13222] Accessors for import_record.status have variable names suggesting overlay_status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13222 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:38:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:38:44 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:39:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:39:28 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Rochelle, and congratulations! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:40:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:40:26 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:40:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:40:50 +0000 Subject: [Koha-bugs] [Bug 12850] C4::Serials::GetLateIssues is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12850 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:47:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:47:15 +0000 Subject: [Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 --- Comment #1 from David Cook --- This may or may not be fixed... will have to double-check this one of these days... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:47:42 +0000 Subject: [Koha-bugs] [Bug 12442] Query... variables should be defined within loop in Search.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12442 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au --- Comment #1 from David Cook --- This is still a thing last time I checked... should fix this one of these days... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 01:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 00:49:51 +0000 Subject: [Koha-bugs] [Bug 12889] Improving documentation in C4::Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12889 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks and congratulations! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 02:58:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 01:58:10 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #147 from Justin Vos --- Created attachment 35269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35269&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 02:58:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 01:58:39 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 --- Comment #8 from Thomas Wright --- Created attachment 35270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35270&action=edit Bug 10241 - Easy analyticals creates two 773 fields. Search/link from host to children is broken Hidden 'New child record' if 'EasyAnalytics' is set to display. Testing plan: -Turn on 'EasyAnalytics'. Check the drop down menu from the records page *The drop down menu should include 'Analyze items' and not include 'New child record' -Turn off 'EasyAnalytics'. Again check the drop down menu from the records page *The drop down menu should include 'New child record' and not inlucde 'Analyze items' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 02:59:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 01:59:05 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomsStudy at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 03:14:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 02:14:31 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Abby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abbyrobertson.student at wegc. | |school.nz Status|Needs Signoff |In Discussion --- Comment #3 from Abby --- I followed the test plan but I can't verify the patch fixes it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 03:34:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 02:34:12 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35268|0 |1 is obsolete| | --- Comment #3 from Robin Sheat --- Created attachment 35271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35271&action=edit Bug 13571: Koha-conf.xml.in has fallen out of sync with koha-conf.xml To test: 1- Build new koha packages 2- Check that the conflist file contains the changes we have made Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 03:34:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 02:34:09 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 03:35:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 02:35:40 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 03:35:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 02:35:44 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #4 from Robin Sheat --- Created attachment 35272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35272&action=edit Bug 13571: followup to remove some now-unused options The memcache parameters aren't used by anything (except C4::SQLHelper, but that's a cancer on the face of the earth) anymore, so they can go. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 03:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 02:48:24 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #5 from Robin Sheat --- Actually, I'll remove my Passed QA in favour of a second look-over, just to be on the safe side. Martin, can you have a look and mark it as Passed QA if it seems good to you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 03:54:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 02:54:57 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35269|0 |1 is obsolete| | --- Comment #148 from Justin Vos --- Created attachment 35273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35273&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 04:04:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 03:04:45 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35273|0 |1 is obsolete| | --- Comment #149 from Justin Vos --- Created attachment 35274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35274&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 04:17:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 03:17:42 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35274|0 |1 is obsolete| | --- Comment #150 from Justin Vos --- Created attachment 35275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35275&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (?????)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 04:22:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 03:22:14 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35275|0 |1 is obsolete| | --- Comment #151 from Justin Vos --- Created attachment 35276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35276&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 04:25:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 03:25:34 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35276|0 |1 is obsolete| | --- Comment #152 from Justin Vos --- Created attachment 35277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35277&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (?????)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 04:27:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 03:27:31 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34924|0 |1 is obsolete| | --- Comment #12 from Thomas Wright --- Created attachment 35278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35278&action=edit Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries Signed-off-by: Thomas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 04:27:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 03:27:38 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35277|0 |1 is obsolete| | --- Comment #153 from Justin Vos --- Created attachment 35279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35279&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (?????)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 04:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 03:27:54 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomsStudy at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 04:28:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 03:28:44 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35279|0 |1 is obsolete| | --- Comment #154 from Justin Vos --- Created attachment 35280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35280&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (?????)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 04:51:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 03:51:03 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the.invinnysible.one at gmail. | |com Status|Needs Signoff |In Discussion --- Comment #2 from the.invinnysible.one at gmail.com --- I am currently working on this but I am having a conflict with the git commit. It should be able to sign off on this soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 05:26:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 04:26:24 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- When did Koha lose the ability to be installed in a home directory? This hard coded path and __KOHASITE__ instead of __ZEBRA{WHATEVER}__ seems like a step backwards. When did that come in? $ cd ~/kohaclone $ diff etc/koha-conf.xml debian/templates/koha-conf-site.xml.in > ~/file.txt $ cat ~/file.txt 1d0 < 3,13c2,4 < < < < < unix:__ZEBRA_RUN_DIR__/bibliosocket < unix:__ZEBRA_RUN_DIR__/authoritysocket < < --- > > unix:/var/run/koha/__KOHASITE__/bibliosocket > unix:/var/run/koha/__KOHASITE__/authoritysocket 16c7 < Also uncomment the and sections for id 'publicserver' --- > Also uncomment the and sections for id 'publicserver' 18,20c9,11 < --- > __START_SRU_PUBLICSERVER__ > tcp:@:__SRU_BIBLIOS_PORT__ > __END_SRU_PUBLICSERVER__ 26c17 < __PAZPAR2_TOGGLE_XML_PRE__ --- > 36,41c27,96 < < __ZEBRA_DATA_DIR__/biblios < __ZEBRA_CONF_DIR__/__ZEBRA_BIB_CFG__ < __ZEBRA_CONF_DIR__/pqf.properties < < --- > > /var/lib/koha/__KOHASITE__/biblios > /etc/koha/sites/__KOHASITE__/__ZEBRA_BIBLIOS_CFG__ > /etc/koha/zebradb/pqf.properties > > __START_BIBLIOS_RETRIEVAL_INFO__ > > > > > identifier="info:srw/schema/1/marcxml-v1.1"> > > inputcharset="utf-8"/> > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > __END_BIBLIOS_RETRIEVAL_INFO__ > > 44,45c99,100 < __ZEBRA_CONF_DIR__/ccl.properties < __ZEBRA_USER__ --- > /etc/koha/zebradb/ccl.properties > kohauser 51,55c106,165 < __ZEBRA_DATA_DIR__/authorities < __ZEBRA_CONF_DIR__/__ZEBRA_AUTH_CFG__ < __ZEBRA_CONF_DIR__/pqf.properties < < --- > /var/lib/koha/__KOHASITE__/authorities > /etc/koha/sites/__KOHASITE__/__ZEBRA_AUTHORITIES_CFG__ > /etc/koha/zebradb/pqf.properties > > __START_AUTHORITIES_RETRIEVAL_INFO__ > > > identifier="info:srw/schema/1/marcxml-v1.1"> > > inputcharset="utf-8"/> > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > __END_AUTHORITIES_RETRIEVAL_INFO__ > > 58,59c168,169 < __ZEBRA_CONF_DIR__/ccl.properties < __ZEBRA_USER__ --- > /etc/koha/zebradb/ccl.properties > kohauser 64,70c174,241 < > __START_SRU_PUBLICSERVER__ > > /var/lib/koha/__KOHASITE__/biblios > /etc/koha/sites/__KOHASITE__/__ZEBRA_BIBLIOS_CFG__ > /etc/koha/zebradb/pqf.properties > > __START_BIBLIOS_RETRIEVAL_INFO__ > > > > > identifier="info:srw/schema/1/marcxml-v1.1"> > > inputcharset="utf-8"/> > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > > > inputcharset="utf-8"/> > > > > __END_BIBLIOS_RETRIEVAL_INFO__ > > xmlns:xi="http://www.w3.org/2001/XInclude"> > > > > __ZEBRA_SRU_HOST__ > __ZEBRA_SRU_BIBLIOS_PORT__ > biblios > > > > 73,74c244,245 < __ZEBRA_CONF_DIR__/ccl.properties < __ZEBRA_USER__ --- > /etc/koha/zebradb/ccl.properties > kohauser 77c248 < --> --- > __END_SRU_PUBLICSERVER__ 79,82d249 < < < < 84c251 < __DB_TYPE__ --- > mysql 87c254 < __DB_PORT__ --- > 3306 96,103c263,270 < __INTRANET_CGI_DIR__ < __OPAC_CGI_DIR__/opac < __OPAC_TMPL_DIR__ < __INTRANET_TMPL_DIR__ < __INTRANET_TMPL_DIR__/prog/en/includes/ < __LOG_DIR__ < __DOC_DIR__ < __BACKUP_DIR__ --- > /usr/share/koha/intranet/cgi-bin > /usr/share/koha/opac/cgi-bin/opac > /usr/share/koha/opac/htdocs/opac-tmpl > /usr/share/koha/intranet/htdocs/intranet-tmpl > /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/includes/ > /var/log/koha/__KOHASITE__ > /usr/share/doc/koha-common > /var/spool/koha/__KOHASITE__ 109,114c276,277 < < < http://__PAZPAR2_HOST__:__PAZPAR2_PORT__/search.pz2 < __MISC_DIR__/koha-install-log --- > > /usr/share/koha/misc/koha-install-log 116,119c279,283 < 0 < __BIB_INDEX_MODE__ < __AUTH_INDEX_MODE__ < __ZEBRA_LOCK_DIR__ --- > __MEMCACHED_SERVERS__ > __MEMCACHED_NAMESPACE__ > __BIBLIOS_INDEXING_MODE__ > __AUTHORITIES_INDEXING_MODE__ > /var/lock/koha/__KOHASITE__ 121,138c285 < __KOHA_CONF_DIR__/searchengine/queryparser.yaml < < < < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif-Bold.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif-Italic.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif-BoldItalic.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono-Bold.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono-Oblique.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono-BoldOblique.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans-Oblique.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans-Bold.ttf < /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans-BoldOblique.ttf < < --- > /etc/koha/searchengine/queryparser.yaml 139a287 > -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:14:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:14:14 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:14:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:14:17 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35175|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 35281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35281&action=edit [PASSED QA] Bug 12702 - Suggestions still accessible in OPAC when deactivated Added check for suggestions turned off. If off user is redirected to 404 error. If patron suggestions are off guest sugestions will also redirect to 404 Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:17:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:17:01 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35183|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 35282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35282&action=edit [PASSED QA] Bug - 11345 - Self registration captcha Test Plan - Open the opac site - Navigate to the self registration page (Home -> Register here) - Notice that there is no note stating that the verification box is case-sensitive - Apply patch - Refresh page - Notice that there is now an extra note stating that the verification box is case-sensitive. Followed test plan. Hint displays as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:16:58 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:17:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:17:22 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:17:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:17:57 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:18:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:18:51 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 --- Comment #6 from Katrin Fischer --- Thx for the patch, but a special thanks for fixing "git-bz attach -e" to work with a commit message including non-ascii characters! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:23:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:23:04 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Should we remove the bits about Windows from Makefile.PL as well? (git grep MSWin32): Makefile.PL:if ( $^O eq 'MSWin32' ) { ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:24:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:24:05 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:24:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:24:11 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35173|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 35283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35283&action=edit [PASSED QA] Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:28:31 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:28:34 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35270|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 35284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35284&action=edit [SIGNED OFF] Bug 10241 - Easy analyticals creates two 773 fields. Search/link from host to children is broken Hidden 'New child record' if 'EasyAnalytics' is set to display. Testing plan: -Turn on 'EasyAnalytics'. Check the drop down menu from the records page *The drop down menu should include 'Analyze items' and not include 'New child record' -Turn off 'EasyAnalytics'. Again check the drop down menu from the records page *The drop down menu should include 'New child record' and not inlucde 'Analyze items' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:34:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:34:57 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:35:00 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35267|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 35285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35285&action=edit [SIGNED OFF] Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission Added check for borrowers that stops the Purchase Suggestions link being shown. This could be done through the css but that function currently appears to be broken Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Purchase suggestions item should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Purchase suggestions item should be present in the menu. Signed-off-by: Katrin Fischer The page requires borrowers permission, so the link should act accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:38:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:38:01 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Currently there is a second file for building the navigation that could be changed too, but this patch is correct and an improvement. / koha-tmpl / intranet-tmpl / prog / en / includes / circ-menu.tt There is a bug report to remove the file in favor of the .inc, as both have some differences right now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 07:40:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 06:40:33 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 --- Comment #7 from Katrin Fischer --- Jonathan found some more occurrences, probably in the CSV export (comment#5) - can we get another patch for those? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 08:44:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 07:44:22 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35190|0 |1 is obsolete| | Attachment #35191|0 |1 is obsolete| | --- Comment #26 from M. de Rooy --- Created attachment 35286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35286&action=edit Bug 10480: Remove useless routines and irrelevant pod lines This patch makes the following cleanup actions for all plugins: 1- Remove sub plugin_parameters. This function is not used. 2- Remove empty plugin or empty plugin_javascript subs. 3- Remove empty Blur, Clic or Focus routines from javascript. 4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs. 5- Remove the last 1; line. It is no longer needed. Test plan: Run the unit test t/db_dependent/FrameworkPlugins.t Test some cataloguing plugins in addbiblio. Test some item plugins in additem and neworderempty. Signed-off-by: Marcel de Rooy I also checked the syntax of all plugins with perl -c. And checked the pod (if any) with podchecker: Two files still produce a warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 08:44:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 07:44:27 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #27 from M. de Rooy --- Created attachment 35287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35287&action=edit Bug 10480: Follow-up for unimarc_field_686a/_700-4.pl This patch fixes the pod errors on those two files by removing the pod section that actually does not add anything useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 09:20:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 08:20:21 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #7 from Robin Sheat --- This is for the packages, you can never install the packages in your home directory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 09:54:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 08:54:46 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 --- Comment #6 from Julian Maurice --- Created attachment 35288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35288&action=edit Bug 13562: Fix item search on item MARC subfields Test plan: 1. Add 4 item search fields (in Administration ? Items search fields): a. 1 biblio field linked to a DB field b. 1 biblio field not linked to a DB field c. 1 item field linked to a DB field d. 1 item field not linked to a DB field 2. Make sure you have some data in those fields to search on. 3. Go to item search page and do a search using these new fields, make sure the result is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 09:55:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 08:55:17 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 09:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 08:56:26 +0000 Subject: [Koha-bugs] [Bug 12845] C4::Output::FormatData is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 09:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 08:56:30 +0000 Subject: [Koha-bugs] [Bug 12845] C4::Output::FormatData is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31345|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 35289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35289&action=edit Bug 12845: C4::Output::FormatData can be removed Test plan: git grep FormatData should not return any result in pl and pm files. Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:01:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:01:38 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34992|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 35290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35290&action=edit Bug 13528: Use the different isbn variations on search on the isbn index (nb) This enhancement adds the ability to search on all isbn variations when searching on the isbn index. Test plan: 0/ Don't apply the patch 1/ Create or choose a notice with an isbn with dashes. 2/ Try to search the notice using the isbn index by it isbn without dashes. => It does not work. 3/ Apply the patch, enable the new pref SearchWithISBNVariations and disable UseQueryParser. 4/ repeat 2 and note that the record is now returned. Note that this only works if UseQueryParser is disabled. It looks like QueryParser does not manage more than 1 operator. See: QueryParser does not manage more than 1 operator? http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028.html and commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 Author: Galen Charlton Date: Mon May 5 19:31:00 2014 +0000 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:01:34 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:02:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:02:26 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 --- Comment #4 from Jonathan Druart --- (In reply to the.invinnysible.one from comment #2) > I am currently working on this but I am having a conflict with the git > commit. It should be able to sign off on this soon. Thanks! Note that the correct status is "Does not apply". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:03:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:03:56 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 --- Comment #4 from Martin Renvoize --- Created attachment 35291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35291&action=edit Bug 13549: Add cardnumber to overdue circulation report overdue.pl Test Plan: - Create an overdue item. - Navigate to overdue circulation report (Home -> Circulation -> Overdues) - Notice there is no card number showing in the Patron column. - Apply patch. - Refresh page. - Notice there is a card number showing in the Patron column. Signed-off-by: Justin Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:05:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:05:20 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Passing QA, passes scripts, tests all still pass and is a nice fix.. Thanks Justin (and assuming you the same Justin that also fixed utf8 in git-bz.. double thanks :) ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:05:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:05:42 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35141|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:05:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:05:58 +0000 Subject: [Koha-bugs] [Bug 13549] Add cardnumber to overdue circulation report overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13549 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35291|Bug 13549: Add cardnumber |[PASSED QA] Bug 13549: Add description|to overdue circulation |cardnumber to overdue |report overdue.pl |circulation report | |overdue.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:10:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:10:35 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #8 from Martin Renvoize --- Oh brill, you guys jumped on this whilst i was sleeping.. that's fast action :) Yes, I can also varify that this only affects packages Mark, you can still run through makefile using a tarball or git install and select dev to install wherever you want. Packages never gave you a choice of where to install.. and shouldn't. I'll build a package from this today to test.. but a quick glance at the code leads me to believe it 'should' all just work fine :) Thanks Rochelle -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:22:05 +0000 Subject: [Koha-bugs] [Bug 11926] HEA - Report usage statistics to Koha community In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13585 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:22:05 +0000 Subject: [Koha-bugs] [Bug 13585] New: HEA - Report usage statistics to Koha community Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Bug ID: 13585 Summary: HEA - Report usage statistics to Koha community Change sponsored?: --- Product: Koha Version: master Hardware: All URL: http://hea.koha-community.org OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: claire.hernandez at biblibre.com, fridolyn.somers at biblibre.com, indradg at gmail.com, jonathan.druart at biblibre.com, julian.maurice at biblibre.com, katrin.fischer at bsz-bw.de, magnus at enger.priv.no, mtj at kohaaloha.com, tomascohen at gmail.com Depends on: 11926 Blocks: 13149 Bug #11926 added the ability for koha to collect usage statistics. Problem is, to set them up you have to both change the system preferences and jump on the server to add the cron script to your crontab. I think the server-side bit should be done at install time thus allwoing simple on/off switching via the staff client configurable sysprefs. To do this, we need to add the a line to: for packages: /kohaclone/debian/koha-common.cron.monthly and perhaps add something to get the file installed as it's new (our first monthly cronjob for packages :) ) for other installs, there's a cron template in /kohaclone/misc/cronjobs/crontab.example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:22:05 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13585 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:22:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:22:17 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Report usage statistics to Koha community In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:24:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:24:18 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #5 from Marc V?ron --- I did not test, but I compared with Bug 13441 and I think this patch should behave the same way resulting in a message like "The password entered contains whitespace characters. Please remove any whitespace characters." With other words: There should be no whitespace characters accepted at all (or at least no leading and/or trailing whitespace characters). Test in Bug 13441 is: match(/\s/) Test in this patch is: match(/^\s*$/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:24:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:24:47 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|HEA - Report usage |HEA - Cronjob Setup |statistics to Koha | |community | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:26:56 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #6 from Chris Cormack --- (In reply to Marc V?ron from comment #5) > I did not test, but I compared with Bug 13441 and I think this patch should > behave the same way resulting in a message like "The password entered > contains whitespace characters. Please remove any whitespace characters." > > With other words: There should be no whitespace characters accepted at all > (or at least no leading and/or trailing whitespace characters). > > Test in Bug 13441 is: > match(/\s/) > > Test in this patch is: > match(/^\s*$/) I disagree, whitespace in passwords is totally valid, a strong password is a phrase. However having a password that is entirely whitespace (which is what we are testing) is not a strong password. This patch will allow you to have whitespace in your password, but you must have other characters also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:33:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:33:49 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #7 from Marc V?ron --- Hi Chris, I agree with whitespace inside of passwords is OK. What about leading / trailing whitespace? See comment #1: --- 2. gmcharlt suggests that patches submitted in the future may strip trailing whitespace characters in form input, causing pernicious perturbations. --- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:40:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:40:17 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35271|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 35292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35292&action=edit Bug 13571: Koha-conf.xml.in has fallen out of sync with koha-conf.xml To test: 1- Build new koha packages 2- Check that the conflist file contains the changes we have made Signed-off-by: Robin Sheat Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:41:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:41:17 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:41:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:41:19 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35272|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 35293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35293&action=edit Bug 13571: followup to remove some now-unused options The memcache parameters aren't used by anything (except C4::SQLHelper, but that's a cancer on the face of the earth) anymore, so they can go. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:42:01 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35292|Bug 13571: Koha-conf.xml.in |[PASSED QA] Bug 13571: description|has fallen out of sync with |Koha-conf.xml.in has fallen |koha-conf.xml |out of sync with | |koha-conf.xml -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:42:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:42:16 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35293|Bug 13571: followup to |[PASSED QA] Bug 13571: description|remove some now-unused |followup to remove some |options |now-unused options -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:43:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:43:35 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #11 from Martin Renvoize --- I'm happy that this does what it says and causes no regressions for packages :) At some point I'de love to see mass of inline zebra config moved as per the non-package installs, but that's sort of out of scope for this particular bug as it would require hacking in more places ;) Passing QA Cheers Rochelle -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:44:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:44:08 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:45:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:45:19 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #12 from Martin Renvoize --- Marcel, I've just added you to the cc list for this bug.. as you did (i think) the work in breaking out the zebra configs from koha-conf into their own file, any chance you could glance over this and possibly do the same for zebra in packages? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:47:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:47:07 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #13 from M. de Rooy --- (In reply to Martin Renvoize from comment #12) > Marcel, I've just added you to the cc list for this bug.. as you did (i > think) the work in breaking out the zebra configs from koha-conf into their > own file, any chance you could glance over this and possibly do the same for > zebra in packages? Yes, I still have some report open on my list to move some changes to the packages env.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:47:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:47:27 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #8 from Martin Renvoize --- I'de vote toward allowing whitespace within password, but not allowing it to be leading or trailing.. that allows for strong passphrases without giving ourselves headaches in the future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:49:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:49:41 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:49:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:49:44 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 --- Comment #10 from Martin Renvoize --- Created attachment 35294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35294&action=edit Bug 10241 - Easy analyticals creates two 773 fields. Search/link from host to children is broken Hidden 'New child record' if 'EasyAnalytics' is set to display. Testing plan: -Turn on 'EasyAnalytics'. Check the drop down menu from the records page *The drop down menu should include 'Analyze items' and not include 'New child record' -Turn off 'EasyAnalytics'. Again check the drop down menu from the records page *The drop down menu should include 'New child record' and not inlucde 'Analyze items' Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:50:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:50:06 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35294|Bug 10241 - Easy |[PASSED QA] Bug 10241 - description|analyticals creates two 773 |Easy analyticals creates |fields. Search/link from |two 773 fields. Search/link |host to children is broken |from host to children is | |broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:50:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:50:15 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35284|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:50:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:50:47 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 --- Comment #11 from Martin Renvoize --- Cheers Thomas, another bug bites the dust :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:53:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:53:07 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 --- Comment #8 from Martin Renvoize --- (In reply to Katrin Fischer from comment #6) > Should we remove the bits about Windows from Makefile.PL as well? (git grep > MSWin32): > Makefile.PL:if ( $^O eq 'MSWin32' ) { > ... Well spotted Katrin.. not sure how I missed those when I spotted these ;).. I'll open another bug for it, save this one going backwards ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:54:15 +0000 Subject: [Koha-bugs] [Bug 13586] New: Makefile.PL mentions win32 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Bug ID: 13586 Summary: Makefile.PL mentions win32 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: katrin.fischer at bsz-bw.de, rochellehealy.student at wegc.school.nz, the.invinnysible.one at gmail.com Depends on: 13570 Whilst working on Bug #13570, Katrin spotted that MSWin32 is also still mentioned within the makefile.. we should also clean it up in there :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:54:15 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13586 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:58:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:58:35 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #12 from Martin Renvoize --- Agreed, not a blocker here.. it's not your job to go cleaning the code up.. this was more just a comment trying to get anyone that sees it to think a bit more when implementing such code in the first place.. had such a request been centralised in the first place this fix probably wouldn't have been needed ;) Cheers Thomas, you guys are doing a great job this year :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 10:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 09:59:14 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34488|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 11:01:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 10:01:22 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35260|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 35295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35295&action=edit Bug 13531: QA follow up A minor QA comment. ::: misc/migration_tools/bulkmarcimport.pl @@ +271,5 @@ > my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch( $query, 0, 3, [$server] ); > + # changed to warn so able to continue with one broken record > + if ( defined $error ) { > + warn "unable to search the database for duplicates : $error"; > + next; For consistency with the rest of the script, should this perhaps be: next RECORD; Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 11:01:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 10:01:52 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize --- Awesome speedy followup there Thomas.. thanks :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 11:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 10:02:03 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35295|Bug 13531: QA follow up |[SIGNED OFF] Bug 13531: QA description| |follow up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 11:17:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 10:17:11 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32232|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 35296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35296&action=edit Bug 13021: guarantor search - main patch This patch is the main patch. The "common" template is improved to allow different type of picking: "add" or "select". The first one appends a patron to a list, the second one selects the patron and close the result search window. The members/guarantor_search.pl has completly changed but is quite the same file as acqui/add_user_search.pl. Both should exist: they don't belong to the same module (acqui vs members), the picking type is different (add vs select) and the columns are not the same. The changes in the common template are very powerful, it's now possible to list the column we want! This will be very useful for further reusability. Before this patch, all patrons mathing the pattern were return. Now only the first 20 are (depends on the DataTables selected value). For QA: This patch introduces a new template plugin "To", for now it permits to convert a perl structure to json. In the idea, it could permit to convert foo to bar too. Test plan: 1/ Verify there is no regression in the guarantor search. When the selection has been done, all data from the guarantor should fill the form in the "main address" section. Note that the request is done when the search input in not empty and the user stop to write for 1 sec. 2/ Verify there is no regression on the 2 other pages where this patron search is used: link a patron to an order and to a basket (in the acquisition module). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 11:17:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 10:17:15 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32233|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 35297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35297&action=edit Bug 13021: guarantor search - guarantor_search.tt is useless The guarantor_search.tt is now useless, no script uses it. It can be removed safely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 11:58:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 10:58:52 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from Jonathan Druart --- (In reply to Paola Rossi from comment #23) > Now on the 2-nd step: > Step 2 of 6: Pick a report type > > 3 values were listed [Tabular,Summary,Matrix], but only the first one was > available. Hello Paola, Yes, it's expected. It's the same for all reports you will create. If you look at the code, the other options are disabled: 460 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:08:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:08:09 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:08:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:08:12 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35285|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 35298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35298&action=edit Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission Added check for borrowers that stops the Purchase Suggestions link being shown. This could be done through the css but that function currently appears to be broken Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Purchase suggestions item should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Purchase suggestions item should be present in the menu. Signed-off-by: Katrin Fischer The page requires borrowers permission, so the link should act accordingly. Signed-off-by: Jonathan Druart Same problem for Fines, Circulation history, Notices and Statistics tabs. circ-menu.tt is only used from the Fines tab (which is not accessible), to it's not useful to add this check to it. But for the consistency, it makes sense. follow-up coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:08:27 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 --- Comment #6 from Jonathan Druart --- Created attachment 35299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35299&action=edit Bug 13584: (follow-up) Able to view menu for Purchase Suggestions even when user does not have permission Same changes as the previous patch, for the .tt file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:09:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:09:18 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomsStudy at gmail.com |ity.org | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:11:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:11:13 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #9 from Marc V?ron --- I agree with Martin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:11:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:11:45 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:13:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:13:11 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Pete Edwards changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at jsense.co.uk --- Comment #1 from Pete Edwards --- I am getting the same issue - is there a workaround? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:13:44 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35179|0 |1 is obsolete| | --- Comment #25 from Paola Rossi --- Created attachment 35300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35300&action=edit [SIGNED OFF] Bug 5338: Serials Report Thanks, Jonathan! So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:14:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:14:30 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35180|0 |1 is obsolete| | --- Comment #26 from Paola Rossi --- Created attachment 35301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35301&action=edit [SIGNED OFF] Bug 5338: Add "Serials" to the report group list -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:21:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:21:35 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, oleonard at myacpl.org --- Comment #13 from Jonathan Druart --- Don't you think a select multiple would be more adapted? I cc Owen to get his opinion on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:22:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:22:20 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #213 from Martin Renvoize --- I have to agree with Katrin here.. there's not many places we show apreciation to people working on Koha. Taking Owen as an example; As far as I'm aware, he's been working on koha for many years and I beleive has been submitting bugs for the entire 3.x release series. With this new model, he would in efect be given the same credit as a new contributor whose only been around for one 6 month release cycle. This seems a bit of a backwards step to me :(. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:35:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:35:11 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #10 from Jonathan Druart --- Martin, shouldn't we call the printlog subroutine too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:35:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:35:56 +0000 Subject: [Koha-bugs] [Bug 13587] New: Authorized Values toolbar missing '+' Icons Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Bug ID: 13587 Summary: Authorized Values toolbar missing '+' Icons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The toolbar in 'Home ? Administration ? Authorized values' is inconsistent with those in other pages under 'Administration'. The toolbar buttons should include associated icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:36:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:36:02 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 12:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 11:51:28 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #214 from M. de Rooy --- (In reply to Martin Renvoize from comment #213) > I have to agree with Katrin here.. there's not many places we show > apreciation to people working on Koha. > > Taking Owen as an example; As far as I'm aware, he's been working on koha > for many years and I beleive has been submitting bugs for the entire 3.x > release series. With this new model, he would in efect be given the same > credit as a new contributor whose only been around for one 6 month release > cycle. > > This seems a bit of a backwards step to me :(. There is no actual text change for Owen. Except the x became an X. Is your objection the position of the line on the page? Because I only moved it down. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 13:18:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 12:18:32 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #14 from Robin Sheat --- No one knows that control+click is a thing you can do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 13:27:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 12:27:09 +0000 Subject: [Koha-bugs] [Bug 13588] New: Should GetKohaAuthorisedValueLib return lib if lib_opac is empty and opac==1 ? Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13588 Bug ID: 13588 Summary: Should GetKohaAuthorisedValueLib return lib if lib_opac is empty and opac==1 ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org C4/Koha.pm subroutine GetKohaAuthorisedValueLib returns the staff description if there is no opac description. This is the case too if the opac flag is true. What is the result? If you do not have an opac description (because you want translated descriptions for item statuses), the staff description is returned (in the only available language used in authorized values). This effectively hides the translated terms in templates. Example: The item-status include contains the translation for Not for loan, but this is overruled by the staff description in one language. A similar remark could be made for lost, damaged, restricted. Workaround: If you have only e.g. two languages in your opac, you could add both translation in the lib_opac field of authorized values. Solution: We could say opac==2 means: do not return the staff description. Changing the call for itemnotforloan in C4/Items from 1 to 2, would resolve the display on opac-detail for Status. Each of the 6? calls should however be examined more carefully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 13:28:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 12:28:01 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #15 from Jonathan Druart --- Have a look at the plugin I used for the OpacAdvSearchMoreOptions pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 13:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 12:31:28 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #16 from Jonathan Druart --- Robin, we have a customer with 42 branches (yes it's the right number). I am not sure the checkboxes will be display correctly with as many branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 13:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 12:33:52 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #613 from Kyle M Hall --- Created attachment 35302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35302&action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 14:12:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 13:12:12 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #155 from M. de Rooy --- Created attachment 35303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35303&action=edit Bug 6473: Test UTF8 in commit message ???? ????? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 14:12:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 13:12:39 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Paola Rossi --- I've applied the patches against master 3.19.00.006 head 12889 On Home ? Serials , clicking on Claims' link: Software error: Global symbol "@missingissues" requires explicit package name at [...]/serials/claims.pl line 83. Execution of [...]/serials/claims.pl aborted due to compilation errors. I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 14:14:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 13:14:31 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #156 from M. de Rooy --- Test UTF8 in commit message Seems still not to work: fatal: cannot convert from utf-8utf-8 to utf-8 Patch file contains: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 14:16:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 13:16:38 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #157 from M. de Rooy --- Justin: What do you have in the i18n section of your .gitconfig ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 14:18:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 13:18:21 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC|magnus at enger.priv.no | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 14:24:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 13:24:16 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #1 from Paul Poulain --- I have another idea to ease HEA : add a test in mainpage. If the user has admin rights, ask him about HEA, and/or send the data. That would almost not slow Koha, and no more need for the cronjob ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 14:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 13:45:42 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 14:45:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 13:45:45 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32782|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 35304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35304&action=edit Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Instead of 10 warnings, I now have only 4 warnings. We're going in the right direction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 14:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 13:54:33 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 --- Comment #5 from M. de Rooy --- opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 172. opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 176. opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 179. opac-authorities-home.pl: Use of uninitialized value $i in string eq at /usr/share/koha/testclone/C4/AuthoritiesMarc.pm line 183. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:00:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:00:24 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:00:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:00:25 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #179 from Paola Rossi --- I've applied the 11 patches against master 3.19.00.006 head 12889 Then: prove t/db_dependent/AdditionalField.t t/db_dependent/AdditionalField.t .. 1/37 Undefined subroutine &C4::Bookseller::AddBookseller called at t/db_dependent/AdditionalField.t line 110. # Looks like you planned 37 tests but ran 20. # Looks like your test exited with 255 just after 20. t/db_dependent/AdditionalField.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 17/37 subtests Test Summary Report ------------------- t/db_dependent/AdditionalField.t (Wstat: 65280 Tests: 20 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 37 tests but ran 20. Files=1, Tests=20, 1 wallclock secs ( 0.00 usr 0.02 sys + 0.76 cusr 0.11 csys = 0.89 CPU) Result: FAIL So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:00:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:00:34 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #30 from Jonathan Druart --- Created attachment 35306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35306&action=edit Bug 8438: Followup Set the superserials permission for all users with the claim_serials permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:00:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:00:28 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35177|0 |1 is obsolete| | Attachment #35178|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 35305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35305&action=edit Bug 8438: Users can only claim for serials related to their branch. Only superlibrarian users and users with superserials permission can override this limitation. This patch adds a new subroutine C4::Serials::can_claim_subscription. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:00:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:00:37 +0000 Subject: [Koha-bugs] [Bug 13304] Authorised values disappear if it uses diacritics in values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13304 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #5 from M. de Rooy --- (In reply to Jonathan Druart from comment #4) > This is certainly fixed by bug 11944. Closing this report. I checked with NOT_LOAN authorized value and had no problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:01:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:01:24 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #31 from Jonathan Druart --- (In reply to Paola Rossi from comment #28) > I've applied the patches against master 3.19.00.006 head 12889 > > On Home ? Serials , clicking on Claims' link: > > Software error: Sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:04:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:04:16 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from M. de Rooy --- CONFLICT (content): Merge conflict in t/db_dependent/Holds.t Auto-merging reserve/request.pl CONFLICT (content): Merge conflict in reserve/request.pl Auto-merging opac/opac-reserve.pl CONFLICT (content): Merge conflict in opac/opac-reserve.pl Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Auto-merging C4/ILSDI/Services.pm CONFLICT (content): Merge conflict in C4/ILSDI/Services.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:04:48 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 --- Comment #2 from Jonathan Druart --- Paul, the problem is that we want to get data regularly (every month). We don't want to ask every month (need a test to know when to ask) manual action, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:09:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:09:12 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 --- Comment #3 from Paul Poulain --- (In reply to Jonathan Druart from comment #2) > Paul, the problem is that we want to get data regularly (every month). > We don't want to ask every month (need a test to know when to ask) manual > action, don't you think? sorry, i've been unclear: * on mainpage.pl : * if the sysprefs are not set, display a clear block to say the library must choose * if the syspref are set => did we submit more than one month ago ? No=> submit I agree that, for a library without any admin login regularly, the data will not be submitted regularly. But this situation is an uncommon one I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:11:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:11:09 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #25 from Manos PETRIDIS --- Will the option to use "gr" as "Primary language for Zebra indexing" be available to current (package) installations when they are upgraded to versions incorporating Bug 11927? I understand there is no such system preference and any changes will have to be applied manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:14:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:14:40 +0000 Subject: [Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:14:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:14:43 +0000 Subject: [Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32793|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 35307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35307&action=edit Bug 12543 - Add userid as matchpoint for "Import patrons" tool The a patron's userid should be a matchpoint in the same manner as cardnumber. Though not enforced as a unique key by the database yet ( pending bug 1861 ), this field is effectively unique as uniqueness is enforced by Koha itself. Test Plan: 1) Apply this patch 2) Browse to tools/import_borrowers.pl 3) Download the starter CSV file 4) Edit the csv file to include 1 or more patrons * Make sure to leave the borrowernumber field empty * Make sure the userid field matches the patrons you wish to overwrite 5) From import_borrowers.pl, upload your file * Set "Field to use for record matching" to "Username" * Set "If matching record is already in the borrowers table" to "Overwrite the existing one with this" 6) Click "Import" 7) Verify the patrons in your file have been updated in Koha Signed-off-by: Frederic Demians Do exactly what's announced. This may help. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:20:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:20:49 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 --- Comment #6 from Jonathan Druart --- Created attachment 35308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35308&action=edit Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:21:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:21:48 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Assignee|oleonard at myacpl.org |chris at bigballofwax.co.nz --- Comment #7 from Jonathan Druart --- Could I get a signoff on the second patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:31:28 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #180 from Paola Rossi --- I add to my last comment (179): NB. about the 9-th patch, the updated database has no "COLLATE". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:39:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:39:19 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #181 from Jonathan Druart --- Created attachment 35309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35309&action=edit Bug 10855: Make tests to pass Some recent changes in master make these tests fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:39:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:39:43 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:39:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:39:48 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35219|0 |1 is obsolete| | --- Comment #182 from Jonathan Druart --- Created attachment 35310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35310&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 15:54:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 14:54:38 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 --- Comment #7 from Peggy Thrasher --- I have sent you credentials in an email. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 16:10:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 15:10:19 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 --- Comment #2 from Pete Edwards --- I'm not familiar enough with Koha to offer a patch but here is a workaround that is OK for me. I had to modify C4::Templates::themelanguage(). For normal pages this is fine but plugin templates have an absolute path (in $tmpl) so the code to check for a template in the correct language completely fails: for my $theme (@themes) { if ( -e "$htdocs/$theme/$lang/$where/$tmpl" ) { return ( $theme, $lang, uniq( \@themes ) ); } } Instead, we drop through both loops and come out of the function without any return. This seems pretty bad practice. At the end of the function I added: if ($tmpl =~ /^\//) { return ( $themes[0], $lang, uniq( \@themes ) ); } This probably doesn't fix every possible situation, nor do I know about themes but it might help whoever does try and fix the problem. As an aside, it would be better to run uniq on the themes array before checking for files existing so it reduces the number of times it may try the wrong location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:02:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:02:18 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:05:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:05:25 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35305|0 |1 is obsolete| | --- Comment #32 from Paola Rossi --- Created attachment 35311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35311&action=edit [SIGNED OFF] Bug 8438: Users can only claim for serials related to their branch. I've applied the patch against master 3.19.00.006 head 12889 The upgrading of the DB was as required: for each [PT/S] patron with the permission "claim_serials" ON, the permission "superserials" became[/was kept to] ON. Then, after having checked the DB upgrading, to test the currently adding limitation: > Users can only claim for serials related to their branch , I reset 2 PT/S patrons-users to: permission claim_serials: YES permission superserials: NO and I set the syspref "IndependendeBranches" to "Prevent". For: > Only superlibrarian users can override this limitation. the S patron-user could list AND claim: A) subscriptions of his own branch, B) subscriptions of other branch, C) subscriptions without branch. For: > Only users with superserials permission can override this limitation. the PT patron-user could list: A) subscriptions of his own branch, B) subscriptions of other branch, C) subscriptions without branch, and could claim only: A) subscriptions of his own branch, C) subscriptions without branch. NB: a subscription is selected to be claimed. Then I set the syspref "IndependendeBranches" to "Don't prevent". The behaviour was [exactly the same as in master] without the added limitation. On [S/PT] patrons, if permission claim_serials was NO, no Claims' link was available on Serials' page, either under "Prevent" or under "Don't prevent". So everything was OK just as required. I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:06:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:06:09 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35306|0 |1 is obsolete| | --- Comment #33 from Paola Rossi --- Created attachment 35312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35312&action=edit [SIGNED OFF] Bug 8438: Followup Set the superserials permission for all users with the claim_serials permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:08:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:08:08 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30747|0 |1 is obsolete| | --- Comment #6 from simith.doliveira at inlibro.com --- Created attachment 35313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35313&action=edit Bug 12532 - Redirect guarantee email to guarantor All email message placed in message_queue table will be affected. Patch updated; system preference EnableRedirectGuaranteeEmail added to enable this feature. Testing: I Apply the patch II Run updatedatabase.pl 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:09:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:09:27 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #12 from Nicole C. Engard --- Do we need a new patch for this? Or is this supposed to be Needs Signoff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:09:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:09:29 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:15:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:15:43 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #34 from Paola Rossi --- I add to my comment 32: I reset the PT patrons-users to: [permission claim_serials: YES] permission superserials: YES under the syspref "IndependentBranches" set either to "Prevent" or to "Don't prevent". For: > Only users with superserials permission can override this limitation. the PT patron-user could list AND claim: A) subscriptions of his own branch, B) subscriptions of other branch, C) subscriptions without branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:20:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:20:52 +0000 Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30703|0 |1 is obsolete| | Status|Patch doesn't apply |Needs Signoff Assignee|simith.doliveira at inlibro.co |charles.farmer at inlibro.com |m | --- Comment #13 from Charles Farmer --- Created attachment 35314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35314&action=edit this patch is exactly the same diff as the previous patch, but formatted differently I'm resubmitting the last patch, which I could apply on master 3.19.00.006, in a slightly different format. Hoping this solves your issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:22:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:22:15 +0000 Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35314|this patch is exactly the |Bug 6968 - Check expiration description|same diff as the previous |in serials expired before |patch, but formatted |today.patch |differently | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 17:22:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 16:22:41 +0000 Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35314|Bug 6968 - Check expiration |Bug 6968 - Check expiration description|in serials expired before |in serials expired before |today.patch |today -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 20:29:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 19:29:45 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 20:31:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 19:31:44 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #21 from simith.doliveira at inlibro.com --- Created attachment 35315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35315&action=edit Fix comment 9 and 19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 20:32:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 19:32:12 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 20:33:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 19:33:16 +0000 Subject: [Koha-bugs] [Bug 13562] Item search: Not possible to add other search fields from 952? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13562 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 20:45:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 19:45:34 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from simith.doliveira at inlibro.com --- The fix for the comment 19 I have already done in 2014-11-03 (to fix the comment 9) but was sent to obsolete by mistake, so I recreated it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 21:19:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 20:19:20 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35290|0 |1 is obsolete| | --- Comment #5 from the.invinnysible.one at gmail.com --- Created attachment 35316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35316&action=edit Bug 13528: Use the different isbn variations on search on the isbn index (nb) This enhancement adds the ability to search on all isbn variations when searching on the isbn index. Test plan: 0/ Don't apply the patch 1/ Create or choose a notice with an isbn with dashes. 2/ Try to search the notice using the isbn index by it isbn without dashes. => It does not work. 3/ Apply the patch, enable the new pref SearchWithISBNVariations and disable UseQueryParser. 4/ repeat 2 and note that the record is now returned. Note that this only works if UseQueryParser is disabled. It looks like QueryParser does not manage more than 1 operator. See: QueryParser does not manage more than 1 operator? http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028.html and commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 Author: Galen Charlton Date: Mon May 5 19:31:00 2014 +0000 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on Signed-off-by: Morag Hills -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 21:23:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 20:23:02 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from the.invinnysible.one at gmail.com --- Bug 13528 - Ability to search on the different isbn variations Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 21:25:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 20:25:13 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 21:37:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 20:37:36 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 --- Comment #1 from Abby --- Created attachment 35317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35317&action=edit Bug 13587: Fix Authorised Values Toolbar To test: 1. Go to Home > Administration > Authorised Values 2. Notice no plus icons are appearing infront "New Authorised Value..." and "New Category" in the toolbar. 3. Apply the patch. 4. Check that the plus icons infront of "New Authorised Value..." and "New Category" in the toolbar are appearing as they should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 21:42:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 20:42:19 +0000 Subject: [Koha-bugs] [Bug 8337] System preferences for longoverdue cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13589 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 21:42:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 20:42:19 +0000 Subject: [Koha-bugs] [Bug 13589] New: add --mark-returned as a longoverdue sys pref Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589 Bug ID: 13589 Summary: add --mark-returned as a longoverdue sys pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 8337 It makes sense to add --mark-returned as a system preference like the other longoverdue settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 22:04:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 21:04:03 +0000 Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 --- Comment #1 from Rochelle Healy --- Created attachment 35318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35318&action=edit Bug 13586: Makefile.PL mentions win32 Edited Makefile.PL to remove mentions of win32 To test: Run Makefile.PL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 22:06:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 21:06:14 +0000 Subject: [Koha-bugs] [Bug 13586] Makefile.PL mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13586 Rochelle Healy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 22:20:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 21:20:32 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Abby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |abbyrobertson.student at wegc. | |school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 22:37:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 21:37:17 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 --- Comment #2 from Abby --- Created attachment 35319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35319&action=edit Bug 10887: Batch item deletion -- doesn't need Use default values section To test: 1. Go to Home > Tools > Batch item deletion 2. Notice that there is an unnecessary option for "use default values section" to "Populate fields with default values from default work" 3. Apply the patch. 4. Check that this section has disappeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 22:37:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 21:37:37 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Abby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abbyrobertson.student at wegc. | |school.nz Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 23:40:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 22:40:56 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #14 from Robin Sheat --- (In reply to M. de Rooy from comment #13) > Yes, I still have some report open on my list to move some changes to the > packages env.. That would be swell. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 23:43:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 22:43:25 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |tomsStudy at gmail.com --- Comment #9 from Thomas Wright --- Conflict in 3 files. Unable to resolve the conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 23:51:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 22:51:20 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #10 from Brandon --- Created attachment 35320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35320&action=edit Bug 10177 - Whitespace is accepted within the password but leading and trailing spaces are not. Test plan: 1: Go to your patron 2: Go to change username and/or password. 3: Change password to something with spaces in the middle. Notice it is invalid. 4: Apply this patch. 5: Change password again using spaces in the middle. Notice it is accepted. 6: Change password with leading and/or trailing spaces, notice they are not accepted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 23:51:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 22:51:41 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Brandon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 15 23:51:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 22:51:50 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35265|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 00:08:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 23:08:19 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35297|0 |1 is obsolete| | --- Comment #12 from the.invinnysible.one at gmail.com --- Created attachment 35321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35321&action=edit Bug 13021: guarantor search - guarantor_search.tt is useless The guarantor_search.tt is now useless, no script uses it. It can be removed safely. Signed-off-by: Morag Hills -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 00:09:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Jan 2015 23:09:30 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 the.invinnysible.one at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the.invinnysible.one at gmail. | |com Status|Needs Signoff |Signed Off --- Comment #13 from the.invinnysible.one at gmail.com --- I think everything looks okay. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 03:55:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 02:55:28 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 --- Comment #3 from Bob Ewart --- That worked for me on installing KitchenSink. I have some other plugins that I will test. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 05:50:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 04:50:33 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 09:50:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 08:50:26 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35296|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 35323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35323&action=edit Bug 13021: guarantor search - main patch This patch is the main patch. The "common" template is improved to allow different type of picking: "add" or "select". The first one appends a patron to a list, the second one selects the patron and close the result search window. The members/guarantor_search.pl has completly changed but is quite the same file as acqui/add_user_search.pl. Both should exist: they don't belong to the same module (acqui vs members), the picking type is different (add vs select) and the columns are not the same. The changes in the common template are very powerful, it's now possible to list the column we want! This will be very useful for further reusability. Before this patch, all patrons mathing the pattern were return. Now only the first 20 are (depends on the DataTables selected value). For QA: This patch introduces a new template plugin "To", for now it permits to convert a perl structure to json. In the idea, it could permit to convert foo to bar too. Test plan: 1/ Verify there is no regression in the guarantor search. When the selection has been done, all data from the guarantor should fill the form in the "main address" section. Note that the request is done when the search input in not empty and the user stop to write for 1 sec. 2/ Verify there is no regression on the 2 other pages where this patron search is used: link a patron to an order and to a basket (in the acquisition module). Signed-off-by: Morag Hills -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 09:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 08:50:22 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32231|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 35322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35322&action=edit Bug 13021: guarantor search - prepare existing code to be reused The add_user_search tt file will be reuse in next commits, this commit just moves it in a "common" directory. Signed-off-by: Morag Hills -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 09:50:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 08:50:29 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35321|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 35324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35324&action=edit Bug 13021: guarantor search - guarantor_search.tt is useless The guarantor_search.tt is now useless, no script uses it. It can be removed safely. Signed-off-by: Morag Hills -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 09:51:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 08:51:42 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 --- Comment #17 from Jonathan Druart --- (In reply to the.invinnysible.one from comment #13) > I think everything looks okay. Signing off. Thanks Morag! I added you signed off to the 3 patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 10:05:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 09:05:41 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #23 from Martin Renvoize --- (In reply to Kyle M Hall from comment #16) > (In reply to Jonathan Druart from comment #15) I agree with Joubu that I don't like having a second GetOverdues added to the code.. it's not DRY.. if you really want to be able to access the function from C4::Members rather than directly from C4::Overdues, then it should be a sugar function that refers to C4::Overdues in my mind, else it's confusing to future people working on the code. If it does perform a different function.. then surely that should be made clear by naming it something completely different, or enahcning the C4::Overdues function with the required extras and a filter perhaps? Just my thoughts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 10:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 09:55:51 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #18 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > I am sorry, but t/db_dependent/HoldsQueue.t is failing in my installation: I got the same error, but when I executed the updatedb entry, the tests passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 10:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 09:59:20 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #23 from Jonathan Druart --- I don't understand the status, to me the second patch needs a signoff. Simith, could you please provide a decent commit message for it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 11:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 10:12:24 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 11:12:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 10:12:27 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35128|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 35325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35325&action=edit Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image Signed-off-by: Brandon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 11:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 10:13:46 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- It could be great to have a small POD, to know the codes it's possible to use. And maybe should we catch potential errors raised by the last line of the script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 11:14:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 10:14:19 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 11:49:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 10:49:10 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- I am wondering if we need to take into account this kind of configuration problems. Maybe a check in the about page is more appropriate? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 11:56:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 10:56:59 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #75 from Koha Team Lyon 3 --- (In reply to Kyle M Hall from comment #74) > If I choose only this item for OverduesBlockRenewing, all my items are > blocked from renewal. I tested again and it's still OK. I can't see why you could have this result. Could you be more precise ? is it on the personnal file, on the pro interface ? some other clue ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 12:13:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 11:13:50 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 --- Comment #11 from Martin Renvoize --- (In reply to Jonathan Druart from comment #10) > Martin, shouldn't we call the printlog subroutine too? Indeed, I think your right Jonathan.. this is something worth logging to file rather than just dumping to stdout.. it looks like in the above invocations it does both.. which seems a little messy to me.. but I suppose it does make the user aware that they should look at the log file. Cheers for pointing it out.. perhaps another qa followup. I have a feeling Thomas has completed his academy placement now.. I'll leave it for him for a few days just in case he want to complete the work, but go ahead and do it myself if it doesn't get done. Cheers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 12:14:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 11:14:28 +0000 Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 12:23:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 11:23:31 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 12:24:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 11:24:21 +0000 Subject: [Koha-bugs] [Bug 10190] notices based on item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 12:35:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 11:35:29 +0000 Subject: [Koha-bugs] [Bug 9190] Problem with holds - allow place a hold without all items checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9190 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:10:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:10:30 +0000 Subject: [Koha-bugs] [Bug 13590] New: Add ability to charge fines at start of charge period Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Bug ID: 13590 Summary: Add ability to charge fines at start of charge period Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:10:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:10:52 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:11:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:11:10 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:11:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:11:39 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:11:41 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #1 from Kyle M Hall --- Created attachment 35326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35326&action=edit Bug 13590 - Add ability to charge fines at start of charge period -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:14:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:14:26 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35326|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 35327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35327&action=edit Bug 13590 - Add ability to charge fines at start of charge period -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:15:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:15:23 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35327|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 35328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35328&action=edit Bug 13590 - Add ability to charge fines at start of charge period -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:17:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:17:12 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35328|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 35329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35329&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Circulation_Issuingrule.t 3) prove t/db_dependent/Fines.t 4) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:19:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:19:01 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35329|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 35330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35330&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:34:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:34:23 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi Kyle, this sounds very interesting - how is the grace period treated? Currently we have something like, if the grace period is < the charging interval, it won't have any effect, but only if it's > (iirc). We have libraries that would like something like: due date 2 days grace period 1st fine 7 days interval 2nd fine 7 days interval 3rd fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:41:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:41:14 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #7 from Kyle M Hall --- Grace period behavior remains unchanged, but this patch should allow you to get the behavior you are looking for. (In reply to Katrin Fischer from comment #6) > Hi Kyle, > > this sounds very interesting - how is the grace period treated? > > Currently we have something like, if the grace period is < the charging > interval, it won't have any effect, but only if it's > (iirc). > > We have libraries that would like something like: > due date > 2 days grace period > 1st fine > 7 days interval > 2nd fine > 7 days interval > 3rd fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:59:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:59:41 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 15:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 14:59:44 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35126|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 35331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35331&action=edit [PASSED QA] Bug 13526 - Mandatory fields should not be able to be hidden in borrower self-registration Currently, mandatory fields in the borrower self-registration can be hidden. This causes problems since the validator rejects the registration, even though all required fields on the screen have been filled out. This is especially a problem when using the system preference "PatronSelfRegistrationVerifyByEmail", since it automatically makes "email" a mandatory field. This patch makes it so that a mandatory field cannot be hidden on the self-registration page. _TEST PLAN_ Before applying 1) Hide the "email" and the "emailpro" fields using the "PatronSelfRegistrationBorrowerUnwantedField" system preference. 2) Make the "email" and the "emailpro" fields mandatory using the "PatronSelfRegistrationBorrowerMandatoryField" system preference. 3) Note that you cannot see "Primary email" or "Secondary email" on the self registration page. (The registration page which can be found by turning on "PatronSelfRegistration" and filling in "PatronSelfRegistrationDefaultCategory". The link will be on opac-main.pl on the right side of the screen under the login box.) 4) Note that you cannot submit a self-registration request as the system tells you that you have not filled in all the mandatory fields. 5) Apply the patch && refresh the self registration page 6) Note that you can now see "Primary email" and "Secondary email" on the self-registration screen". Signed-off-by: Abby Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 16:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 15:00:45 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- I think both would be good! I know I'd welcome and additional report and patch to add a warning for these conflicts to the about page. (In reply to Jonathan Druart from comment #9) > I am wondering if we need to take into account this kind of configuration > problems. > Maybe a check in the about page is more appropriate? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 16:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 15:18:46 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 16:18:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 15:18:49 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35154|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 35332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35332&action=edit [PASSED QA] Bug 10606: Remove MySQLism in GetUpcomingDueIssues To test: [1] Arrange to have at least one loan in your test database due one day from now. [2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 and note the number of loans reported. [3] Apply the patch. [4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again and verify that the number of loans reported remains the same. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer All tests and QA script pass. Also tested with unit tests from bug 10719. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 16:26:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 15:26:05 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 --- Comment #15 from Jonathan Druart --- Kyle, did you test with MariaDB? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 16:49:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 15:49:40 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #183 from Paola Rossi --- Thanks, Jonathan. I've applied the 12 patches against master 3.19.00.006 head 12889. In Comment 168: >Test plan: >- prove t/db_dependent/AdditionalField.t OK! In Comment 169: >Test plan: >- go to serials/serials-home.pl >- click on the "Add subscription fields" link on the left of the screen >- try to add/update/delete new fields I've added a new field with no "Authorised value category" and no MARC field [either searchable or not-searchable]. I think this is an error. For now I pass the patch to "Failed QA". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 16:52:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 15:52:44 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #184 from Jonathan Druart --- (In reply to Paola Rossi from comment #183) > I've added a new field with no "Authorised value category" and no MARC field > [either searchable or not-searchable]. > > I think this is an error. No, it is just a free text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:06:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:06:06 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #185 from Paola Rossi --- (In reply to Jonathan Druart from comment #184) > (In reply to Paola Rossi from comment #183) > > I've added a new field with no "Authorised value category" and no MARC field > > [either searchable or not-searchable]. > > > > I think this is an error. > > No, it is just a free text. Thanks, Jonathan. So I turn back to "Needs Signed Off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:06:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:06:23 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #21 from Jonathan Druart --- Is there a doc somewhere? I did not find it... I tried but failed: $ git remote add catalyst git://git.catalyst.net.nz/koha.git $ git checkout -b elastic_search catalyst/elastic_search $ perl installer/data/mysql/updatedatabase.pl $ sudo apt-get install elasticsearch $ perl misc/search_tools/rebuild_elastic_search.pl -h Can't locate Elasticsearch.pm in @INC (you may need to install the Elasticsearch module) (@INC contains: blablabla) $ apt-cache search elasticsearch | grep perl libcatmandu-perl - metadata toolkit $ sudo apt-get install libcatmandu-perl But got the same error. The ElasticSearch module on the cpan is marked as deprecated: http://search.cpan.org/~drtech/ElasticSearch-0.68/lib/ElasticSearch.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:08:38 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #22 from Jonathan Druart --- I also added the lines in the $KOHA_CONF file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:34:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:34:25 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #15 from Kyle M Hall --- The library and category filters on moremember.pl appear to be preset to the library and category of the patron you are viewing. This seems improper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:44:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:44:39 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #186 from Paola Rossi --- (In reply to Jonathan Druart from comment #171) > Created attachment 35215 [details] [review] > Bug 10855: Search subscriptions by additional fields > > Now you will abble to search subscriptions by additional fields. > The additional field values will be displayed in the table results. > > Test plan: > - go on the subscriptions advanced search page > (serials/serials-search.pl). > - verify all searchable additional fields are displayed on the form. > - combine 1 or more values and verify results are consistent. > - verify the values are displayed in new columns of the table. > - for field linked to an authorised value category, the description is > displayed (not the code). I've applied the patches. Everything was OK as required in the "Open (X)" tag (RIGHT). In the "Close (X)" tag the MARC additional fields of the subscriptions were displayed (RIGHT) whilst the category additional fields were not displayed (I think it was an ERROR). I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:45:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:45:11 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #18 from Kyle M Hall --- The patron name column appears to be missing from the search results table! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:47:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:47:13 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:47:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:47:15 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35182|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 35333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35333&action=edit [PASSED QA] Bug 13577: Add the utf8_unicode_ci COLLATE to all tables Bug 11944 added the COLLATE=utf8_unicode_ci to all DB tables. But some new tables have been created between the write of the patch set and the push to master. So these new tables don't have the correct collate. Test plan: 0/ Reproduce the error: mysql> create database koha_test CHARACTER SET utf8 COLLATE utf8_unicode_ci; mysql koha_test < installer/data/mysql/kohastructure.sql It will boom with: ERROR 1005 (HY000) at line 3493: Can't create table `koha_test`.`items_search_fields` (errno: 150 "Foreign key constraint is incorrectly formed") 1/ Apply the patch, destroy the DB and recreate it: mysql> create database koha_test CHARACTER SET utf8 COLLATE utf8_unicode_ci; mysql> drop database koha_test; mysql koha_test < installer/data/mysql/kohastructure.sql All tables should be inserted without any error. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:48:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:48:11 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- QA Question: Should we also be fixing this via updatedatabase.pl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:51:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:51:06 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 17:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 16:51:09 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35105|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 35334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35334&action=edit [PASSED QA] Bug 13554: t/Prices.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Prices.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Prices.t Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 18:12:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 17:12:18 +0000 Subject: [Koha-bugs] [Bug 13591] New: Rss sample templates have hardcoded urls Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Bug ID: 13591 Summary: Rss sample templates have hardcoded urls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The sample templates in misc/cronjobs/rss have hardcoded urls the should be using suspref OPACBaseURL The contents of rss are rather neglected but many sites seem to want to use this, while most may want some customizations the samples should work out of the box in a sensible fashion at present if you create a list of new acquisitions The links are hardcoded to nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 18:27:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 17:27:59 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35316|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 35335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35335&action=edit [PASSED QA] Bug 13528: Use the different isbn variations on search on the isbn index (nb) This enhancement adds the ability to search on all isbn variations when searching on the isbn index. Test plan: 0/ Don't apply the patch 1/ Create or choose a notice with an isbn with dashes. 2/ Try to search the notice using the isbn index by it isbn without dashes. => It does not work. 3/ Apply the patch, enable the new pref SearchWithISBNVariations and disable UseQueryParser. 4/ repeat 2 and note that the record is now returned. Note that this only works if UseQueryParser is disabled. It looks like QueryParser does not manage more than 1 operator. See: QueryParser does not manage more than 1 operator? http://lists.koha-community.org/pipermail/koha-devel/2014-December/041028.html and commit 036f2a50e11dab97ef8509f2f585c4cc407ea728 Author: Galen Charlton Date: Mon May 5 19:31:00 2014 +0000 Bug 10500: (follow-up) disable AggressiveMatchOnISBN if UseQueryParser is on Signed-off-by: Morag Hills Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 18:27:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 17:27:56 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 19:10:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 18:10:40 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 --- Comment #16 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 19:22:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 18:22:32 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|master |3.16 --- Comment #8 from Mason James --- (In reply to Chris Cormack from comment #6) > Contains string changes, holding for 3.18.3 Contains string changes, holding for 3.18.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 19:23:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 18:23:20 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 --- Comment #9 from Mason James --- (In reply to Mason James from comment #8) > (In reply to Chris Cormack from comment #6) > > Contains string changes, holding for 3.18.3 > > Contains string changes, holding for 3.18.8 oops ^ Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 19:28:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 18:28:37 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|master |3.16 --- Comment #9 from Mason James --- Template changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 19:35:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 18:35:01 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 19:42:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 18:42:38 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|master |3.16 --- Comment #11 from Mason James --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 19:47:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 18:47:06 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|master |3.16 --- Comment #7 from Mason James --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 19:50:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 18:50:47 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 19:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 18:54:10 +0000 Subject: [Koha-bugs] [Bug 12565] Acq: Link to basket in breadcrumbs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|master |3.16 --- Comment #8 from Mason James --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:01:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:01:44 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|master |3.16 --- Comment #16 from Mason James --- hmm, a possible inclusion for the Hea backport to 3.16? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:06:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:06:14 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- Contains DB changes, passing for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:10:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:10:45 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|master |3.16 --- Comment #8 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:12:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:12:01 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 --- Comment #17 from Katrin Fischer --- Hm, might be good, but need to make sure the database update is ok for udpating from 3.16 to 3.18 with it running twice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:25:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:25:53 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 CC| |mtj at kohaaloha.com --- Comment #34 from Mason James --- Contains DB changes, passing for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:28:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:28:20 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|master |3.16 --- Comment #6 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:29:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:29:51 +0000 Subject: [Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:31:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:31:13 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hm, I think if the update is ok between stable releases and as the utf-8 patches have just been pushed, it's probably ok to skip the database update here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:32:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:32:06 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:34:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:34:13 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.16 CC| |mtj at kohaaloha.com --- Comment #17 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:34:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:34:46 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.16 |3.18 --- Comment #10 from Katrin Fischer --- Hi Mason, item search is new in 3.18, so you should not need this :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:36:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:36:12 +0000 Subject: [Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Contains DB changes, passing for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:38:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:38:03 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials description misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Version|master |3.16 --- Comment #9 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:42:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:42:51 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials description misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 --- Comment #10 from Mason James --- (In reply to Mason James from comment #9) > Pushed to 3.16.x, patch will be in 3.16.7 oops, correction! Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:45:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:45:01 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:53:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:53:08 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj at kohaaloha.com --- Comment #19 from Mason James --- potential inclusion for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:55:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:55:13 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13190 CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:55:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:55:13 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11703 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 20:55:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 19:55:54 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 21:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 20:33:53 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 21:36:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 20:36:26 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 21:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 20:43:09 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 21:46:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 20:46:17 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #19 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 21:51:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 20:51:34 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #20 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 21:53:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 20:53:31 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #17 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 22:01:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 21:01:13 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 --- Comment #20 from Katrin Fischer --- Hm, wondering, looks like 1861 is not in 3.16 - so should this be? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 16 22:16:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 21:16:44 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 00:25:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 23:25:06 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 00:26:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 23:26:41 +0000 Subject: [Koha-bugs] [Bug 11872] Lost overdue items should not generate fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #20 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 00:28:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 23:28:29 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #19 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 00:29:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 23:29:54 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 00:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 23:34:20 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 00:36:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 23:36:28 +0000 Subject: [Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 00:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 23:38:10 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 00:41:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Jan 2015 23:41:30 +0000 Subject: [Koha-bugs] [Bug 12868] GetMemberDetails calls GetMemberAccountRecords incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12868 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 01:11:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Jan 2015 00:11:04 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 --- Comment #21 from Mason James --- (In reply to Katrin Fischer from comment #20) > Hm, wondering, looks like 1861 is not in 3.16 - so should this be? ah yes, i just noticed this myself - i'll revert it now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 14:43:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Jan 2015 13:43:37 +0000 Subject: [Koha-bugs] [Bug 13393] The C4::VirtualShelves::Merge package is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13393 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks JOnathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 14:44:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Jan 2015 13:44:12 +0000 Subject: [Koha-bugs] [Bug 12845] C4::Output::FormatData is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12845 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 14:45:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Jan 2015 13:45:11 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 14:45:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Jan 2015 13:45:47 +0000 Subject: [Koha-bugs] [Bug 13554] Bug 12969 introduces a test case that fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13554 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks JOnathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 14:46:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Jan 2015 13:46:13 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Morag! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 14:46:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Jan 2015 13:46:43 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Rochelle! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 15:49:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Jan 2015 14:49:04 +0000 Subject: [Koha-bugs] [Bug 9717] localuse recorded for holds/transfers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 17 21:57:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Jan 2015 20:57:28 +0000 Subject: [Koha-bugs] [Bug 3642] Modify Overdue.pl export to include other borrower information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om --- Comment #2 from David Roberts --- I'd like to add support for having the user's barcode number included in the output of the report, especially in the CSV export. Exporting the borrower number in this format is of little use to most users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 01:26:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 00:26:54 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 --- Comment #10 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 01:31:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 00:31:21 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 --- Comment #10 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 01:37:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 00:37:51 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 --- Comment #12 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 01:42:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 00:42:30 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 --- Comment #12 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 01:43:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 00:43:54 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 --- Comment #8 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 01:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 00:45:37 +0000 Subject: [Koha-bugs] [Bug 12565] Acq: Link to basket in breadcrumbs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 --- Comment #9 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 01:51:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 00:51:29 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials description misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 --- Comment #11 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 01:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 00:56:18 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #9 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 02:49:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 01:49:26 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #112 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 02:55:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 01:55:32 +0000 Subject: [Koha-bugs] [Bug 13530] Typo in bulkmarcimport In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #17 from Chris Cormack --- Pushed to 3.18.x, will be in the 3.18.3 release so your code will be out in use by libraries around the world by the end of January, Morag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:01:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:01:21 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:10:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:10:31 +0000 Subject: [Koha-bugs] [Bug 13566] Change translation for 'Rotating collection' in German web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13566 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:21:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:21:44 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:25:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:25:18 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #17 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:28:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:28:22 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 --- Comment #18 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:30:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:30:15 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:31:17 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:33:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:33:15 +0000 Subject: [Koha-bugs] [Bug 12889] Improving documentation in C4::Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12889 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:35:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:35:44 +0000 Subject: [Koha-bugs] [Bug 13570] koha-conf.xml mentions win32 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 03:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 02:36:35 +0000 Subject: [Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:17:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:17:55 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35038|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 35336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35336&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. This bug is rather nasty as it happens very discreetly when editing Items that are in either locations 'CART' or 'PROC'. For example when changing one of the Item's statuses or barcode, the permanent_location gets overwritten without the user noticing it immediately. The damage becomes apparent only weeks later when there are potentially thousands of Items missing the permanent_location and location. :-:TEST SETUP:-: 0a. System preference "ReturnToShelvingCart" must be 'Move'. 0b. Find any Item (I69) 0c. Set I69's location to "Book Cart" (BC) or anything but empty. :-:REPLICATE ISSUE:-: 1. Check-in the I69 and the location should turn to 'CART' (returned today). 2. Go to the "Edit Item"-view for I69, don't change anything, simply click "Save changes" 3. Observe that the permanent_location has changed to 'CART'. This is not good since now the location data is forever lost again (Bugg 7817). The "cart_to_shelf.pl --hours 24"-script cannot return the Item to the proper place ;( :-:AFTER THIS PATCH:-: Repeat steps 1-2. 3. Observe that the permanent_location is still the old one, instead of getting overwritten by 'CART'. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:19:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:19:26 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:19:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:19:30 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35055|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 35337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35337&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC when... - Unit tests Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:22:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:22:07 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:23:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:23:59 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:24:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:24:04 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34968|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 35338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35338&action=edit Bug 13499: Tidy of Auth.pm This tidy should only change whitespace and not line breaks, thus retaining history. There are no code changes, and thus there should be no regressions to test for koha wise. To test the non-destrcutive nature of the patch, run a 'git blame -w' on the file before and after the patch. The resulting blame should include a comparabile history of the file, with only some additional blank lines being attributed to this commit. A 'git blame -wM' may also be useful for comparison purposes. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:25:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:25:50 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34975|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 35339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35339&action=edit Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:26:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:26:04 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:26:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:26:08 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34976|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 35340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35340&action=edit Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:28:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:28:19 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 06:28:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 05:28:23 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34551|0 |1 is obsolete| | Attachment #34829|0 |1 is obsolete| | --- Comment #15 from Chris Cormack --- Created attachment 35341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35341&action=edit Bug 12954: Failed login should retain anonymous session A failed login should not leave the user in a half logged authenticated state, but rather return them to an anonymouse session as per the pre-login attempt state. To replicate error: 1. Try to log in with some nonexisting user id or wrong password in the OPAC 2. Go directly to /opac-user.pl (e.g., enter it in the browser address bar, or just click on the "Log in" link) 3. Observe a DBI error displayed on the screen 4. You are now in the "deadloop" of sorts (opac/opac-user.pl refuses to display the login screen, no matter how many times you try to reload it); to break the deadloop, one needs to: - remove session cookie from the browser (or cause the session to expire in some other way - closing browser window would be probably enough for that) - remove offending session on the server (from mysql sessions table, ..) - log in with proper credentials using some other page (like opac/opac-main.pl right-side panel), which does not involve opac/opac-user.pl being called without "userid" CGI parameter. To test: 1. Test as above, the DBI error should no longer be present 2. Check that search history works across failed and sucessful login attempts Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 09:26:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 08:26:12 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #11 from Marc V?ron --- Patch #35320 does not apply, it seems that it needs obsoleted #35265 first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 09:26:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 08:26:32 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35265|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 09:38:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 08:38:51 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 --- Comment #16 from Marc V?ron --- Created attachment 35342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35342&action=edit [Signed-off] Bug 10177 - whitespace is a valid password causing pernicious perturbations. Test plan: Go to your patron, go to change username and/or password. change password to whitespace, notice it is accepted, apply this patch, change password again, to whitespace, notice password is not valid. Tested with both patches together. Passwords with leading/trailing whitspaces are rejected as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 09:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 08:47:51 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35342|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Comment on attachment 35342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35342 [Signed-off] Bug 10177 - whitespace is a valid password causing pernicious perturbations. Sorry for the noise, mistaked wit bug number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 09:48:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 08:48:30 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #12 from Marc V?ron --- Created attachment 35343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35343&action=edit [Signede-off] Bug 10177 - whitespace is a valid password causing pernicious perturbations. Test plan: Go to your patron, go to change username and/or password. change password to whitespace, notice it is accepted, apply this patch, change password again, to whitespace, notice password is not valid. Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 09:50:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 08:50:57 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #13 from Marc V?ron --- Created attachment 35344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35344&action=edit [Signed-off] Bug 10177 - Whitespace is accepted within the password but leading and trailing spaces are not. Test plan: 1: Go to your patron 2: Go to change username and/or password. 3: Change password to something with spaces in the middle. Notice it is invalid. 4: Apply this patch. 5: Change password again using spaces in the middle. Notice it is accepted. 6: Change password with leading and/or trailing spaces, notice they are not accepted. Applied bothe patches. Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 09:51:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 08:51:35 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35265|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 09:51:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 08:51:50 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 09:52:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 08:52:17 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 11:17:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 10:17:11 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 --- Comment #12 from Thomas Wright --- (In reply to Martin Renvoize from comment #11) > (In reply to Jonathan Druart from comment #10) > > Martin, shouldn't we call the printlog subroutine too? > > Indeed, I think your right Jonathan.. this is something worth logging to > file rather than just dumping to stdout.. it looks like in the above > invocations it does both.. which seems a little messy to me.. but I suppose > it does make the user aware that they should look at the log file. > > Cheers for pointing it out.. perhaps another qa followup. > > I have a feeling Thomas has completed his academy placement now.. I'll leave > it for him for a few days just in case he want to complete the work, but go > ahead and do it myself if it doesn't get done. > > Cheers Hey Martin, The academy is over, but I am hoping to continue with contribution to Koha. Without Chris to guide me could you please advise me as to where I would find an example of the log syntax. Not sure if I will be able to figure it out, but i'll try! Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 14:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 13:26:00 +0000 Subject: [Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 35345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35345&action=edit Bug 12973: (QA followup) warnings are features, test them This patch makes the test look for the warnings Koha::XSLT_Handler raises instead of just throwing them to STDERR. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 14:53:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 13:53:51 +0000 Subject: [Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Enhancement pushed to master. Thanks Marcel! PS Maybe we should fill a bug for removing to old API, as the new one makes a lot of sense and this patches don't target the stable branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 14:54:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 13:54:29 +0000 Subject: [Koha-bugs] [Bug 8096] Card number twice on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 14:55:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 13:55:18 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Thomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 14:56:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 13:56:44 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 16:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 15:17:40 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 16:29:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 15:29:26 +0000 Subject: [Koha-bugs] [Bug 4283] Merge bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- Does not apply. Applying: Bug 4283 - Merge bibliographic records Applying: Bug 4283 - Merge bibliographic records. Followup. fatal: sha1 information is lacking or useless (Koha/Deduplicator.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 4283 - Merge bibliographic records. Followup. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 16:44:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 15:44:44 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #12 from Marc V?ron --- DOes not apply Applying: Bug 5685: Validation of email address field Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-memberentry.pl Auto-merging members/memberentry.pl CONFLICT (content): Merge conflict in members/memberentry.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/less/opac.less CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/less/opac.less Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Failed to merge in the changes. Patch failed at 0001 Bug 5685: Validation of email address field -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 16:52:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 15:52:46 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #29 from Marc V?ron --- Does not apply. Applying: Bug 7595 - Add branchcode to accountlines Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Auto-merging C4/Overdues.pm Auto-merging C4/Circulation.pm Auto-merging C4/Accounts.pm CONFLICT (content): Merge conflict in C4/Accounts.pm Failed to merge in the changes. Patch failed at 0001 Bug 7595 - Add branchcode to accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 17:04:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 16:04:33 +0000 Subject: [Koha-bugs] [Bug 13301] Call number link in search results is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13301 --- Comment #5 from Katrin Fischer --- Hm, could you check ICU vs. CHR? I think that might be it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 17:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 16:07:43 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #71 from Marc V?ron --- Does not apply Applying: Bug 8753 - Add forgot password link to OPAC Using index info to reconstruct a base tree... :471: trailing whitespace. :500: trailing whitespace. ); :511: trailing whitespace. } ); :25: new blank line at EOF. + :126: new blank line at EOF. + warning: squelched 1 whitespace error warning: 6 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Failed to merge in the changes. Patch failed at 0001 Bug 8753 - Add forgot password link to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 17:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 16:08:23 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #9 from Katrin Fischer --- David, thx for your comments. Could you give this a second sign-off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 17:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 16:31:59 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #18 from Katrin Fischer --- I am ok with displaying the statement of responsibility, but would suggest wrapping it in a with a nice class so libraries can decide to hide it easily and that way get back to the old display - and also use a similar technique for the $h. --- About the "material type" information: If I understood correctly. 245$h is going to go away and the coded fields LDR/007/008 as well. So we will need to put some thought into how we want to display material type information in future. The existing code for the material type is a bit messy - for example the display logic for the result page differs from the detail page. I think cleaning that up would be a good first step. For example we can put the logic in a template that will be used on both pages. Then we could add support of 336-338 and display this information instead whenever they exist. We also have to keep in mind that the new fields are repeatable. Suggestion: Make only changes to the title on this bug and move the bigger task of displaying good material type information into a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 17:43:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 16:43:53 +0000 Subject: [Koha-bugs] [Bug 13567] Searching for system preferences broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- Not sure what caused the problem in the first place, but I no longer see the bad behaviour in my installation. Thx for testing Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 17:46:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 16:46:19 +0000 Subject: [Koha-bugs] [Bug 9527] add all-all-all circulation rule to sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13576 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 17:46:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 16:46:19 +0000 Subject: [Koha-bugs] [Bug 13576] Add a default circulation rule to the optional sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Katrin Fischer --- *** Bug 9527 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 18:23:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 17:23:45 +0000 Subject: [Koha-bugs] [Bug 13588] Should GetKohaAuthorisedValueLib return lib if lib_opac is empty and opac==1 ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think what you describe is a workaround for a translation issue that should be solved in general - But I agree this is a bigger problem :( The problem is that the current behaviour has been the default behaviour forever, so people expect it to work that way. The sample data doesn't include OPAC descriptions and also in our libraries only the lib description is set as long as its the same. I am not sure we should change this, but if we do, some more thought needs to go into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 18:25:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 17:25:32 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13589 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 18:25:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 17:25:32 +0000 Subject: [Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12812 CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Adding bug 12812 as a depends on - I haven't retested, but would be glad if someone else did and confirms if the option works/doesn't work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 18:27:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 17:27:56 +0000 Subject: [Koha-bugs] [Bug 2894] Routing list holds are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 --- Comment #5 from Katrin Fischer --- I thinks as this pref is causing problems when turned on, we should make sure it's turned off by default for new installations. Maybe also add a warning? Fixing the problem would of course be preferred... but I think as this has been broken for a longer time, it's probably not easy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 18:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 17:34:07 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- 9740 is still "in discussion" - not sure about the patches here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 18:35:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 17:35:36 +0000 Subject: [Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 --- Comment #23 from Katrin Fischer --- (In reply to Robin Sheat from comment #22) > This causes tests to fail. I think the problem got fixed now, with bug 13554. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 18:38:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 17:38:52 +0000 Subject: [Koha-bugs] [Bug 10180] [master] Diacritics in Z39.50 search results in acquisitions are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- I confirm this works ok now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 18:48:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 17:48:48 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #11 from Katrin Fischer --- I think the other problem blocking this is that people haven't been able to see the issue, could we get a more detailed test plan? Maybe with an example date? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 18:51:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 17:51:46 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 19:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 18:09:41 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #23 from Katrin Fischer --- Could the problem be similar to what we saw on the patch for the parcels page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 19:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 18:12:07 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #31 from Katrin Fischer --- Didn't test yet, but wondering: how are we dealing with the subfields marked as 'don't show in OPAC'? Thinking of the internal notes especially. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 19:21:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 18:21:40 +0000 Subject: [Koha-bugs] [Bug 13592] New: Hold fee not being applied on placing a hold Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Bug ID: 13592 Summary: Hold fee not being applied on placing a hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com There was an email on the mailing list reporting problems with the hold fee set on the patron category. I tested on master and can confirm, that no fee was set on placing a hold. 1) Administration > patron category > Add a hold fee 2) Place a hold for a patron of that category in the OPAC 3) Check the patron account - no fee was applied -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 19:26:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 18:26:22 +0000 Subject: [Koha-bugs] [Bug 5632] SIP improvements = Date formatting & debarrement management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5632 --- Comment #9 from Katrin Fischer --- Reading the last 2 comments it looks like we should not change the date formatting (assuming we are using sip formatted dates right now). Should we close this bug? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 19:41:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 18:41:57 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:02:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:02:09 +0000 Subject: [Koha-bugs] [Bug 13593] New: 'Stock number' should be 'Inventory number' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Bug ID: 13593 Summary: 'Stock number' should be 'Inventory number' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We should be consistent in how we use terms in Koha, there are some cases where we use 'stock number' instead of 'inventory number'. Jonathan identified some places that need to be fixed in bug 13564: 2 for the item search feature: koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_items.inc: [% INCLUDE itemsearch_header name='stocknumber' label='stock number' text='Stock number' %] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.csv.tt:Title, Publication Date, Publisher, Collection, Barcode, Call number, Home library, Current location, Shelving location, Stock number, Status, Checkouts and 3 others: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: Stock number koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: Stock number koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: Stock number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:02:16 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13564 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:02:16 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13593 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:26:19 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 --- Comment #1 from Katrin Fischer --- Failing to trigger this one: koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_items.inc: [% INCLUDE itemsearch_header name='stocknumber' label='stock number' text='Stock number' %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:35:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:35:43 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 --- Comment #9 from Katrin Fischer --- Created attachment 35346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35346&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:36:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:36:09 +0000 Subject: [Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35346|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:37:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:37:00 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:37:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:37:03 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 --- Comment #2 from Katrin Fischer --- Created attachment 35347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35347&action=edit Bug 13593: 'stock number' should be 'inventory number' To make Koha easier to use, we should use terms consistently. This patch fixes some occurrences of 'stock number' to be 'inventory number' as this is also the term used in the frameworks. Item search, accessible via the link from staff's advanced search 1) Do a search for items, but choose CSV as output 2) Verify that the header row says 'inventory number' Acquisition 3) Set AcqCreateItem to 'order' 4) Create a new order, check the labels on the item table in the order 5) Receive the order, check the labels on the item table on receive 6) Set AcqCreateItem to 'receive' 7) Check the item table on receiving an order http://bugs.koha-community.org/show_bug.cgi?id=13564 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:41:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:41:54 +0000 Subject: [Koha-bugs] [Bug 10695] Koha does not warn about holds when renewing an item via checkboxes on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10695 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Currently, you can not renew or return items with holds from the circulation page. Instead of the checkboxes, a link 'on hold' is displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 20:48:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 19:48:31 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35193|0 |1 is obsolete| | --- Comment #215 from Katrin Fischer --- Created attachment 35348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35348&action=edit [PASSED QA] Bug 7143: Adding releases to history file To test, verify that the latest releases appear in docs/history.txt Signed-off-by: Marcel de Rooy Verified some release dates and still added a few missing. Signed-off-by: Katrin Fischer Thx Abby! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 22:28:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 21:28:30 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35348|0 |1 is obsolete| | --- Comment #216 from Katrin Fischer --- Created attachment 35349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35349&action=edit Bug 7143: Adding back version numbers Adding back version numbers to the former release team members in the list of developers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 22:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 21:29:05 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #217 from Katrin Fischer --- Created attachment 35350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35350&action=edit [PASSED QA] Bug 7143: Adding releases to history file To test, verify that the latest releases appear in docs/history.txt Signed-off-by: Marcel de Rooy Verified some release dates and still added a few missing. Signed-off-by: Katrin Fischer Thx Abby! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 22:30:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 21:30:25 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #218 from Katrin Fischer --- I passed QA on the patch from Abby for the history file, thx Abby! Also proposing a follow up patch to Marcel's patches that adds back the version numbers for discussion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 22:31:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 21:31:06 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Table patroncards not used? |Table patroncards not used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 22:31:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 21:31:13 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |katrin.fischer at bsz-bw.de |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 22:46:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 21:46:42 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #2 from Katrin Fischer --- Created attachment 35351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35351&action=edit Bug 13539 - Remove unused table patroncards It appears that the table patroncards hasn't been used since the database updates for the rewritten label modules ('3.01.00.107'). It's time to remove them from the database. As the patron card batches were needed for printing and the data has not been accessible in a long time, it seems safe to delete it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 22:46:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 21:46:39 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 22:48:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 21:48:54 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #3 from Katrin Fischer --- I'd consider the batch data kind of temporary as it's only needed for printing. There is no way to clean out the old data from within Koha and it's not been accessible in the GUI apart from reports for a long time. If someone sees a reason to be more careful here, please comment :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 22:50:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 21:50:54 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #4 from Katrin Fischer --- Test plan: - Check the table exists in your database - Run the database update - Confirm the table has been deleted - Verify the table is not necessary for printing patroncards (using the feature and/or checking the codebase) - Make sure the web installer still works correctly on creating a new database, but that patroncards is no longer created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:05:45 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- There is also koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt but there are many more differences to resolve between both files, so I think this should not be a blocker here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:06:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:06:32 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:06:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:06:35 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35266|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 35352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35352&action=edit [SIGNED OFF] Bug 13583 - Able to view menu for Statistics even when user does not have permission Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Statistics should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Statistics should be present in the menu. Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:07:38 +0000 Subject: [Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13583 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:07:38 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |--- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11804 Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:07:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:07:47 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:12:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:12:50 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:12:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:12:53 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35317|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 35353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35353&action=edit [SIGNED OFF] Bug 13587: Fix Authorised Values Toolbar To test: 1. Go to Home > Administration > Authorised Values 2. Notice no plus icons are appearing infront "New Authorised Value..." and "New Category" in the toolbar. 3. Apply the patch. 4. Check that the plus icons infront of "New Authorised Value..." and "New Category" in the toolbar are appearing as they should. Signed-off-by: Katrin Fischer Nice addition! I added spaces to match the formatting on the other pages a bit more closely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:13:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:13:25 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |abbyrobertson.student at wegc. | |school.nz CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:14:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:14:07 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35353|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 35354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35354&action=edit [SIGNED OFF] Bug 13587: Fix Authorised Values Toolbar To test: 1. Go to Home > Administration > Authorised Values 2. Notice no plus icons are appearing infront "New Authorised Value..." and "New Category" in the toolbar. 3. Apply the patch. 4. Check that the plus icons infront of "New Authorised Value..." and "New Category" in the toolbar are appearing as they should. Signed-off-by: Katrin Fischer Nice addition! I added spaces to match the formatting on the other pages a bit more closely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:20:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:20:58 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:21:02 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35261|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 35355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35355&action=edit [SIGNED OFF] Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines. Test Plan: -Search for a patron from an account without the 'borrowers' permission and with the 'updatecharges' permission. *The fines tab should not be present. -Update the account's permissions to include the 'borrowers' permission *The fines tab should now be present. -Update the account's permissions so it has neither 'borrowers' or 'updatecharges' *The fines tab should not be present Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 18 23:21:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Jan 2015 22:21:08 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #7 from Katrin Fischer --- Hm, wondering if the other way around would make more sense: Allow paying fines without the permission to manage borrowers. I think the permission page doesn't suggest that you'd need to combine both. What do people think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 04:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 03:26:56 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #194 from Mason James --- This fix needs to be applied to 3.16.x, also Marked for inclusion in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 04:29:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 03:29:23 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 04:33:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 03:33:40 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #195 from Mason James --- keyword = rel_3_16_7_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 04:40:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 03:40:20 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #33 from Mason James --- this needs to be added to 3.16.x, as 'ajax-circ' feature (11703) depends on it i'll only attempt to pull QAed patches from this set keyword: rel_3_16_7_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:09:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:09:38 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #209 from M. Tompsett --- Comment on attachment 34197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34197 Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm Review of attachment 34197: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6679&attachment=34197) ----------------------------------------------------------------- ::: C4/TmplTokenType.pm @@ +90,5 @@ > +sub DECL { $_decl } > +sub PI { $_pi } > +sub DIRECTIVE { $_directive } > +sub COMMENT { $_comment } > +sub UNKNOWN { $_unknown } DECL, PI, COMMENT, and UNKNOWN seem to have no easy way to test them. Consider improving testing coverage for TmplTokenType explicitly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:09:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:09:44 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- Hi Abby, the same page (bachMod.tt) is used for 2 tools: batch item modification and batch item delete. The 'default values' option only makes sense if you want to batch modify, but not if you want to batch delete. Your patch removes from both tools, what we need is some kind of condition, so it shows only for one, but not the other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:11:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:11:19 +0000 Subject: [Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:17:47 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:17:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:17:50 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35343|0 |1 is obsolete| | Attachment #35344|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 35356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35356&action=edit [PASSED QA] Bug 10177 - whitespace is a valid password causing pernicious perturbations. Test plan: Go to your patron, go to change username and/or password. change password to whitespace, notice it is accepted, apply this patch, change password again, to whitespace, notice password is not valid. Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:18:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:18:06 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #15 from Katrin Fischer --- Created attachment 35357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35357&action=edit [PASSED QA] Bug 10177 - Whitespace is accepted within the password but leading and trailing spaces are not. Test plan: 1: Go to your patron 2: Go to change username and/or password. 3: Change password to something with spaces in the middle. Notice it is invalid. 4: Apply this patch. 5: Change password again using spaces in the middle. Notice it is accepted. 6: Change password with leading and/or trailing spaces, notice they are not accepted. Applied bothe patches. Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:19:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:19:36 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Hi Brandon, thx for your patch, works great! I suggest to leave this bug open after pushing the patch as there are 2 more pages where you can chane the password: the patron edit screen and in the OPAC. I think adding the check to the OPAC too would be good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:25:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:25:59 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:26:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:26:02 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35004|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 35358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35358&action=edit [PASSED QA] Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. Signed-off-by: Katrin Fischer Works as described and fixes sorting problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:31:04 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:31:08 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35263|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 35359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35359&action=edit [SIGNED OFF] Bug 13582 - Able to view menu for Circulation History even when user does not have permission Added check for borrowers that stops the Circulation History link being shown. This could be done through the css but that function currently appears to be broken. Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Circulation history should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Circulation history should be present in the menu. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:31:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:31:51 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11804 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:31:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:31:51 +0000 Subject: [Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13582 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:32:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:32:07 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 07:56:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 06:56:31 +0000 Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- Hi Rochelle, the way it works after your patch, it will need both the permission 'parameters' and 'view_system_logs'. I think what we need to do here is take a look at all the conditions [IF ...] that apply to show the link and check which are really needed / make sense. My feeling is that it would make sense to use 'view_system_logs' everywhere, as this is the more specific permission. What do others think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 08:09:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 07:09:28 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #19 from Katrin Fischer --- Hi Kyle and Jonathan, I retested and made sure I ran the database update. ok 20 - Holds queue filling 2nd correct hold for default holds policy 'from home library' not ok 21 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 310. # got: '2' # expected: '1' ok 22 - Holds queue filling correct number for holds for default holds policy 'from any library' not ok 23 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 327. # got: '3' # expected: '2' # Looks like you failed 2 tests of 23. Without the patch and before the database update all the tests pass nicely on my db. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 08:38:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 07:38:35 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 08:38:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 07:38:38 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35308|0 |1 is obsolete| | --- Comment #8 from M. de Rooy --- Created attachment 35360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35360&action=edit Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 08:47:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 07:47:30 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer --- Comment #17 from Martin Renvoize --- Pushing this to the authentication module maintainers branch. https://github.com/mrenvoize/Koha/tree/authentication Cheers Brandon :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 08:54:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 07:54:28 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 --- Comment #4 from Martin Renvoize --- I think these are really two different things. The addition of the cronjobs to both the crontab.example file and almost more importantly the package templates file would simply mean enabling HEA for reporting statistics would be a simpler task (and make it in reach of 'just a librarian', i.e. clientside only user). Adding a prompt routine to remind said admin level users to enable the statistics is a seperate piece.. which so long as it was too obtrusive I would probably support. I'de personally prefer it simply warns say three days after an upgrade to a version supporting HEA, and has the options of enabling HEA, (disabling the warning permanently), Remind me later (suggesting a popup would appear again in another three days), or just disable the popup forever. Perhaps submit another bug for the above proposal? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 08:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 07:57:42 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13149 Blocks|13149 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 08:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 07:57:42 +0000 Subject: [Koha-bugs] [Bug 13149] B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13585 Depends on|13585 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:06:17 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 --- Comment #13 from Martin Renvoize --- (In reply to Thomas Wright from comment #12) > Hey Martin, > > The academy is over, but I am hoping to continue with contribution to Koha. > Without Chris to guide me could you please advise me as to where I would > find an example of the log syntax. Not sure if I will be able to figure it > out, but i'll try! > > Thanks That's great news that your tempted to stick around Thomas, we can always do with more keen contributors and you'll find even outside the Catalyst environment you should get allot of support for us.. Have you discovered the IRC channel, it's a great place to seek advice if/whenever your stuck :) As for the log syntax, this script is a bit of a special case for logging (there's a whole debate regarding logging in general for koha going on at the moment). But, having said that, the bulkmarcimport tool already impliments it's own loggin system; An example of this can be seen aroud line: 404 (This should be the best example for your particular required followup ;) ).. to see how the logging itself works (just for interest) you could take a look at the routine itself found on lines 592 -> 595. Cheers Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:16:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:16:22 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:16:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:16:25 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #6 from M. de Rooy --- Created attachment 35361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35361&action=edit Bug 13240: Remove some code obfuscation my $bar; my $foo = $bar->{borrowernumber} ||= {}; $foo->{one} ||= 'something'; $foo->{two}++; What does $bar contain? $VAR1 = { 'borrowernumber' => { 'two' => 1, 'bar' => 'something' } }; Not really obvious. Maybe something I did not see is hidden. Test plan: Verify the digest for DUE and PREDUE work as before. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:16:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:16:29 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33479|0 |1 is obsolete| | --- Comment #7 from M. de Rooy --- Created attachment 35362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35362&action=edit Bug 13240: Remove commented warns Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:20:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:20:40 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #8 from M. de Rooy --- (In reply to Jonathan Druart from comment #5) > (In reply to M. Tompsett from comment #4) > > > And the second syntax uses $h->{}{} which isn't so > > > good: $h->{}->{} should be preferred, imho. > > > > I agree with Fr?d?ric Demians on this, though only because it makes the > > change more apparently equal to me, not because it actually generates a > > better or different data structure. > > I have always used this syntax (4 years), and I won't change now :) Although $a->{b}->{c} is more readable, it seems that both variations are both widespread in Koha. Changing a habit can be a good thing (at least sometimes) .. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:36:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:36:17 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #219 from M. de Rooy --- (In reply to Katrin Fischer from comment #218) > Also proposing a follow up patch to Marcel's patches that adds back the > version numbers for discussion. No problem with adding the figures again, but there may be some small typos: i see 3.6 with galen; should be 3.16 ? no version with Rmaint mason should be up to 3.14 ? what about remaining 3.x? Note: this was no extensive check -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:41:11 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #220 from Katrin Fischer --- Hi Marcel, thx for checking, you are right about Galen and Mason, I will correct. Remaining 3.x was meant to mean "all verseions 3.x", but I also thought about writing "3.0 to present", maybe a little later for the packages? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:41:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:41:28 +0000 Subject: [Koha-bugs] [Bug 13594] New: Long running database updates lack feedback Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13594 Bug ID: 13594 Summary: Long running database updates lack feedback Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There are a few very long running db updates in updatedatabase now (the utf8 collation change being one example). We really aught to give the user some feedback somewhere when running these updates rather than just letting the browser time out. Not sure hwo to do this ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:43:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:43:16 +0000 Subject: [Koha-bugs] [Bug 10363] [DEPENDS ON 13019] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|There is no package for |[DEPENDS ON 13019] There is |authorised values. |no package for authorised | |values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 09:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 08:45:48 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com Patch complexity|--- |Trivial patch CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:00:23 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #32 from Gaetan Boisson --- I might be arriving late to the party but, if i am not mistaken, OAI in Koha can work in extended mode, with a custom xslt. I think that would be the right way of filtering things out in the exported data. Otherwise we might have situations where we need to hide certain fields on the opac, but want to have them in the exported data, which wouldn't be possible then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:03:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:03:21 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:03:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:03:47 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:03:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:03:50 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35338|0 |1 is obsolete| | --- Comment #11 from M. de Rooy --- Created attachment 35363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35363&action=edit Bug 13499: Tidy of Auth.pm This tidy should only change whitespace and not line breaks, thus retaining history. There are no code changes, and thus there should be no regressions to test for koha wise. To test the non-destrcutive nature of the patch, run a 'git blame -w' on the file before and after the patch. The resulting blame should include a comparabile history of the file, with only some additional blank lines being attributed to this commit. A 'git blame -wM' may also be useful for comparison purposes. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:04:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:04:17 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #33 from Katrin Fischer --- Hm, not sure I agree. I think internal note holds the promise that noone outside the library can see it and afaik the extended mode is not documented in a way that it would be easy to add those constraints for a library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:05:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:05:40 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #12 from M. de Rooy --- Looks good to me. Checked git-blame output. Running diff -w -B with both versions convinced me :) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:06:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:06:27 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- I wish I'd spotted this before it had been pushed.. oops. I would have said, can we do a check on whether tables are _mb4 before running the change.. I know we've got mb4 set which give minor advantages over not _mb4 encoding.. but mroe importantly, if you've already got a utf8 database (especialyl with _mb4) you shuld nto have to run the db update at all, thus saving allot of time at upgrade time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:06:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:06:34 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #34 from Katrin Fischer --- Maybe better documentation and a switch to include/not include? The export feature in the staff client allows to list fields to 'not export'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:16:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:16:18 +0000 Subject: [Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #1) > Failing to trigger this one: > koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_items.inc: > [% INCLUDE itemsearch_header name='stocknumber' label='stock number' > text='Stock number' %] Julian, Could you please have a look? It seems that the script catalogue/itemsearch.pl is never caller with format="html". Actually the html value is set in the form, but it is DT that calls the script with format="json". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:28:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:28:45 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #8 from Martin Renvoize --- Also,.. i believe the use of ->tables is deprecated? https://metacpan.org/pod/DBI#tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:33:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:33:56 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #210 from Jonathan Druart --- (In reply to M. Tompsett from comment #209) > Comment on attachment 34197 [details] [review] > Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm > > Review of attachment 34197 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/TmplTokenType.pm > @@ +90,5 @@ > > +sub DECL { $_decl } > > +sub PI { $_pi } > > +sub DIRECTIVE { $_directive } > > +sub COMMENT { $_comment } > > +sub UNKNOWN { $_unknown } > > DECL, PI, COMMENT, and UNKNOWN seem to have no easy way to test them. > Consider improving testing coverage for TmplTokenType explicitly. Hello Mark, The patch did not modify the contain of these subroutines, I don't think tests should be mandatory here. And I don't have any ideas how I could test them :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:37:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:37:02 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:37:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:37:05 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35304|0 |1 is obsolete| | Attachment #35360|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 35364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35364&action=edit Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Instead of 10 warnings, I now have only 4 warnings. We're going in the right direction. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:37:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:37:11 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 --- Comment #10 from Jonathan Druart --- Created attachment 35365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35365&action=edit Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 10:59:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 09:59:58 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_4_candidate --- Comment #196 from Mason James --- (In reply to Mason James from comment #194) > This fix needs to be applied to 3.16.x, also > > Marked for inclusion in 3.16.7 oops, ignore this comment ^ patch is already applied to 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:04:53 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #35 from Gaetan Boisson --- That's more complicated than i first thought indeed. My understanding at first was that the library would want to filter out some fields to import in the OAI harvester, but Jonathan pointed out that anyone can query the koha OAI provider and that the real issue is data that would be considered confidential and that should never be exported. I would say we have two separate issues though: - Having items data in the OAI export. If we don't have it, this is a problem for harvesting purposes, which even defeats the point of being an OAI provider in some situations. - Some confidential data can be exposed through this. But Jonathan and i just tried it, and it's not just the OAI interface, if you save the record as marc or marcxml from the opac, this data will be in there. So we don't respect this confidentiality here either. I would say this ticket should remain about adding item data, and we should create another bug report, that would tackle the issue of exporting sensitive data everywhere this could happen. what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:05:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:05:03 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC|paola.rossi at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:27:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:27:26 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #36 from Katrin Fischer --- I am not sure if the current problem is something that 'used to work'. I filed a bug recently about the plain MARC view in OPAC where I was fairly sure that the fields would not be included - but they show. So this is indeed a wider issue, just not sure if it's new or things we broke with some other changes over time :( If we just quietly add the items and expose the data, this seems problematic to me. Could it be a switch with a warning for now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:30:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:30:05 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35002|0 |1 is obsolete| | --- Comment #75 from M. de Rooy --- Created attachment 35366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35366&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:30:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:30:11 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35003|0 |1 is obsolete| | --- Comment #76 from M. de Rooy --- Created attachment 35367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35367&action=edit Bug 13068: Raise an error if a pl script has a sql error Signed-off-by: Marcel de Rooy Tested with some perl and sql dev updates. Checked the list of dev updates for the TRACK mode. Slightly amended the patch for printing the error message. Also the message now may tell you that a dev update failed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:30:54 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #77 from M. de Rooy --- Trivial rebase on debian/templates/koha-conf-site.xml.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:34:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:34:11 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35366|0 |1 is obsolete| | --- Comment #78 from M. de Rooy --- Created attachment 35368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35368&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:34:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:34:34 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:34:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:34:41 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #187 from Jonathan Druart --- Created attachment 35369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35369&action=edit Bug 10855: (follow-up) Search subscriptions by additional fields 1 occurrence of KohaAuthorisedValues had not been replaced with AuthorisedValues on fixing a previous conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:35:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:35:21 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35367|0 |1 is obsolete| | --- Comment #79 from M. de Rooy --- Created attachment 35370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35370&action=edit Bug 13068: Raise an error if a pl script has a sql error Signed-off-by: Marcel de Rooy Tested with some perl and sql dev updates. Checked the list of dev updates for the TRACK mode. Slightly amended the patch for printing the error message. Also the message now may tell you that a dev update failed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:35:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:35:35 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #188 from Jonathan Druart --- (In reply to Paola Rossi from comment #186) > In the "Close (X)" tag the MARC additional fields of the subscriptions were > displayed (RIGHT) whilst the category additional fields were not displayed > (I think it was an ERROR). Good catch! This is fixed with the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:48:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:48:36 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:48:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:48:39 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 --- Comment #19 from Jonathan Druart --- Created attachment 35371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35371&action=edit Bug 13021: Reintroduce the name column for guarantor search Previous patch removed the name column, it's a regression. This patch reintroduces it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 11:49:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 10:49:11 +0000 Subject: [Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021 --- Comment #20 from Jonathan Druart --- (In reply to Kyle M Hall from comment #18) > The patron name column appears to be missing from the search results table! Thanks for catching that! The last patch reintroduced the name column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 12:37:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 11:37:34 +0000 Subject: [Koha-bugs] [Bug 13595] New: Checking out an issued item doesn't return it after confirmation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13595 Bug ID: 13595 Summary: Checking out an issued item doesn't return it after confirmation Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When you are checking out an issued item, we can see this confirmation: Item "Title (barcode)" is checked out to "Member (cardnumber)" Check in and check out? But after clicking "Yes" button, the item is just issued to current member, but is NOT checked in before! It looks like the all confirmations works the same way, but this one is special and need additional action (checking in the item). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 12:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 11:38:56 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34322|0 |1 is obsolete| | --- Comment #76 from Koha Team Lyon 3 --- Created attachment 35372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35372&action=edit Bug 8236 Renewing policy in overdue or restriction case patch rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 12:49:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 11:49:53 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #4 from M. de Rooy --- Created attachment 35373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35373&action=edit Bug 11193 : edit Queryparser configuration to take changes of bug 8252 into account This patch make some changes to queryparser.yaml, to take into account the changes made in ccl.properties * new indexes : bio, char-encoding, country-publication, cumulative-index-availability, ff7-00, ff7-01, ff7-02, ff7-01-02, ff8-18, ff8-18-21, ff8-19, ff8-21, ff8-28,ff8-29,ff8-30,ff8-31, ta, lf, music-number, title-page-availability, script-title, tpubdate, rtype * deleted indexes : audience and ff8-22 (alias of ta), biography and ff-834 (alias of bio), format (alias of ff8-23), l-format (alias of ff7-01-02), illustration-code (alias of ff8-18-21), regularity-code, type-of-serial (alias of ff8-21), literature-code (alias of lf), music (alias of music-number), record-type (alias of rtype) * changed index : graphics-type, graphics-support, video-mt I am not sure if I understood well the behavior of this file, and of the best way for testing the changes made... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 12:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 11:52:54 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Needs Signoff |Failed QA --- Comment #5 from M. de Rooy --- Rebased a trivial merge conflict in the yaml file. Note that running koha qa tools on this patch produces quite some output. And finally: FAIL etc/searchengine/queryparser.yaml FAIL yaml_valid YAML Error: Inconsistent indentation level Moving to FQA to express need for clarification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:04:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:04:06 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30455|0 |1 is obsolete| | --- Comment #12 from M. de Rooy --- Created attachment 35374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35374&action=edit Bug 12637: UTF-8 problems when creating a patron list Encoding problems appear when creating a patron list from the patron search results page. Test plan: 1. Perform a patron search in the patrons module 2. Select one or more patrons 3. Choose "Add selected patrons to: [ New list ]" 4. Enter a patron list title with UTF-8 characters. 5. The list will be created with bad encoding. 6. Apply the patch and verify there is no bad encoding anymore. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Patch works fine. Note that I - very ironically - had to remove UTF8 characters from the commit message to apply and attach the patches with git/git-bz. Hopefully, an upgrade to a newer git version will resolve that too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:05:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:05:15 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Passed QA Patch complexity|--- |Small patch --- Comment #13 from M. de Rooy --- Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:07:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:07:09 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #6 from mathieu saby --- I'll take a look next week end Thanks for testing. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:11:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:11:24 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #37 from Katrin Fischer --- OPAC visibility turns out to be quite a mess. Not blocking this, but still wondering if we can document this somewhere. Maybe add a note to the pref that it will include all item data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:18:46 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #7 from mathieu saby --- Generally speaking, I find that QP behavior and configuration is not well documented, especially for a librarian like me... My personal opinion is that QP having been introduced in 2012, it should be well documented and bug-proof, and the older code should have been deprecated. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:31:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:31:25 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34870|0 |1 is obsolete| | Attachment #34871|0 |1 is obsolete| | Attachment #34872|0 |1 is obsolete| | Attachment #34873|0 |1 is obsolete| | Attachment #34874|0 |1 is obsolete| | Attachment #34875|0 |1 is obsolete| | Attachment #34876|0 |1 is obsolete| | Attachment #34877|0 |1 is obsolete| | Attachment #34878|0 |1 is obsolete| | Attachment #34879|0 |1 is obsolete| | Attachment #34880|0 |1 is obsolete| | Attachment #34883|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart --- Created attachment 35375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35375&action=edit Bug 11023: Automatic item modification by age (Was Toggle "new" status") This patch adds: - a new DB field items.new. - a new page to configure this new status (tools/toggle_new_status.pl). - a new cronjob script (misc/cronjobs/automatic_item_modification_by_age.pl was misc/cronjob/toggle_new_status.pl) Why this status is useful for some libraries ? The use cases are: - to know easily what are the new items (with a simple sql query). - to display an icon in the search results. - issuing rules can be adapt for new items. Automatically (using the cronjob script), the status change (depending the configuration) and the item can be issued, for example. - a RSS/Atom feeds can be created on these new items. Test plan: - log in with a librarian having the tools > items_batchmod permission. - navigate to Home > Tools > Automatic item modifications by age (was: Toggle new status) - click on the edit button - there are 3 "blocks": * duration: the duration during an item is considered as new. * conditions: the status will change only if the conditions are meet. * substitutions: if there is no substitution, no action will be done. You can add some change to apply to the matching items. E.g. ccode=3 new='' If the value is an empty string (in other words, the input does not contain anything), the field will be deleted. You can create as many rules as you want. - test the interface : add/remove rule, conditions, substitutions, submit the form, edit, etc. (There is a looot of JS everywhere, so certainly a looot of bugs...). - when you have your rules defined, you can now launch the cronjob script without any parameter. A report will be displayed with the matching itemnumber and the substitutions to apply. Verify results are consistent. - launch the script with the -c argument and verify values have been modified depending the substitution rules. Signed-off-by: juliette et remy Signed-off-by: Kyle M Hall Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. Signed-off-by: juliette et remy Signed-off-by: Kyle M Hall Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t Signed-off-by: juliette et remy Signed-off-by: Kyle M Hall Bug 11023: FIX - condition on biblioitems table does not work If a rule contains a condition on the biblioitems table, the match won't work. This patch fixes this issue. Signed-off-by: Kyle M Hall Bug 11023: Use DBIx-Class to retrieve column names Signed-off-by: Kyle M Hall Bug 11023: Don't use the biblioitems fields for the subtitution It's dangerous to allow a change on the biblioitems fields with this feature. Signed-off-by: Kyle M Hall Bug 11023: Rename the duration parameter with 'age' Signed-off-by: Kyle M Hall Bug 11023: The age parameter should be a number The template should check if the age parameter is correctly filled (should be a number). Signed-off-by: Kyle M Hall Bug 11023: Change the name of the feature Originaly this feature only permits to update the "new" field. Now all item fields can be updated. The name of the feature is now "Automatic item modifications by age". Signed-off-by: Kyle M Hall Bug 11023 [QA Followup] * Update DB version * Fix capitalization error * Rename misc/cronjobs/toggle_new_status.pl to misc/cronjobs/automatic_item_modification_by_age.pl Signed-off-by: Kyle M Hall Bug 11023 [QA Followup] - Complete the renaming of "toggle new status" to "automatic item modification by age" Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:31:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:31:33 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #98 from Jonathan Druart --- Created attachment 35376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35376&action=edit Bug 11023: DB changes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:32:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:32:13 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #99 from Jonathan Druart --- (In reply to Jonathan Druart from comment #96) > (In reply to Kyle M Hall from comment #90) > > Created attachment 34883 [details] [review] [review] > > Bug 11023 [QA Followup] - Complete the renaming of "toggle new status" to > > "automatic item modification by age" > > > > Signed-off-by: Kyle M Hall > > I am not sure it's a good idea to create files and rename them in the same > patch set. > Maybe should we squash patches? I squashed all patches, except the DB changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:32:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:32:43 +0000 Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Toggle new status for items |Automatic item modification | |by age (Was "Toggle new | |status for items") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:52:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:52:01 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:52:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:52:05 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 --- Comment #5 from Jonathan Druart --- Created attachment 35377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35377&action=edit Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. Signed-off-by: Katrin Fischer Works as described and fixes sorting problem. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:52:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:52:18 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35358|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:54:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:54:02 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 --- Comment #6 from Jonathan Druart --- I must note I was not able to reproduce the issue, even with dd/mm/yyyy, I got: 15/07/2013 11/06/2014 20/08/2014 19/01/2015 I can confirm this patch introduces the correct way to sort dates with datatables and I did not find any regression. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:55:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:55:32 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 13:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 12:55:35 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35354|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 35378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35378&action=edit Bug 13587: Fix Authorised Values Toolbar To test: 1. Go to Home > Administration > Authorised Values 2. Notice no plus icons are appearing infront "New Authorised Value..." and "New Category" in the toolbar. 3. Apply the patch. 4. Check that the plus icons infront of "New Authorised Value..." and "New Category" in the toolbar are appearing as they should. Signed-off-by: Katrin Fischer Nice addition! I added spaces to match the formatting on the other pages a bit more closely. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:07:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:07:16 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #34 from Mason James --- (In reply to Mason James from comment #33) > this needs to be added to 3.16.x, as 'ajax-circ' feature (11703) depends on > it > > i'll only attempt to pull QAed patches from this set > > keyword: rel_3_16_7_candidate 4 patches pushed to 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:08:06 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:08:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:08:09 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35352|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 35379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35379&action=edit Bug 13583 - Able to view menu for Statistics even when user does not have permission Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Statistics should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Statistics should be present in the menu. Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:08:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:08:17 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 --- Comment #6 from Jonathan Druart --- Created attachment 35380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35380&action=edit Bug 13583: (follow-up) Able to view menu for Statistics even when user does not have permission Same changes as the previous patch, for the .tt file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:10:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:10:52 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35380|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 35381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35381&action=edit Bug 13583: (follow-up) Able to view menu for Statistics even when user does not have permission Same changes as the previous patch, for the .tt file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:16:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:16:09 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #19 from M. de Rooy --- QA Comment: Tax rate: no default This is a confusing term. Would something like manual be better? Or a word that expresses that it is a different/deviating rate than those in the table (read: preference)? If you have item-level_itypes==biblio, the selection seems to work. If you have item-level_itypes==item, the situation is confusing. The first rate of the pref is selected (fine). But I save my first item, I would expect that it would update my tax rate (at least the first time). It does not. I understand that if you add another item of another type, you cannot make a choice. You could choose for defaulting to the rate of the first item. When I set AcqCreateItem <> ordering, the situation is still different. You have no items/item types. So no defaults. My conclusion is that adding this rate to the item type page in Administration promises much, but does not bring that much. Note that the item type page does not tell you that filling the tax rate is only useful when you item-level_itypes==biblio and AcqCreateItem == ordering. Perhaps you should tell that or only show them in that case? I am moving this report to FQA for this functional perspective. This still needs some attention imo before pushing it to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:16:27 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:16:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:16:30 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35359|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 35382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35382&action=edit Bug 13582 - Able to view menu for Circulation History even when user does not have permission Added check for borrowers that stops the Circulation History link being shown. This could be done through the css but that function currently appears to be broken. Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Circulation history should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Circulation history should be present in the menu. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:16:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:16:34 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:16:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:16:37 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 --- Comment #6 from Jonathan Druart --- Created attachment 35383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35383&action=edit Bug 13582: (follow-up) Able to view menu for Circulation History even when user does not have permission Same changes as the previous patch, for the .tt file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:16:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:16:39 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:19:58 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #20 from M. de Rooy --- (In reply to M. de Rooy from comment #19) > Tax rate: no default > This is a confusing term. Would something like manual be better? Or a word > that expresses that it is a different/deviating rate than those in the table > (read: preference)? Please add how this would work given the context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:22:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:22:34 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #20 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:28:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:28:26 +0000 Subject: [Koha-bugs] [Bug 12778] Regression: Item lost status doesn't show in list of checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12778 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #10 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:28:48 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Needs Signoff |Patch doesn't apply --- Comment #19 from M. de Rooy --- Applying: Bug 12669: Use floating timezone when handling dates without hours, minutes and seconds. Applying: Bug 12669: Centralize the timezone handle into Koha::DateUtils fatal: sha1 information is lacking or useless (Koha/DateUtils.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:38:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:38:31 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #38 from Gaetan Boisson --- Adding a note to the OAI-PMH preference so that it reads like the following would be ok for me: able/disable Koha's OAI-PMH server. The data exposed will not include items hidden through the OpacHiddenItems system preference, but everything else will be available for harvest. If you need to hide some data, look into extended mode and the OAI-PMH:ConfFile system preference. (It does look to me as enabling extended mode with a configuration file allowing only one type of metadata that would result from a custom xslt removing the confidential fields would be enough.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:51:49 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #9 from Martin Renvoize --- Created attachment 35384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35384&action=edit BUG 7134 [QA Followup]: Prevent utf8mb4 collation change utf8mb4 is a superset of utf8 adn thus is compatible. We should not force an entire db change upon people who have proactively set utf8 encoding before now. This patch aslo removed the deprecaed ->tables stanze in favour of the table_info stanze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:53:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:53:32 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 --- Comment #10 from Ahmed --- Created attachment 35385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35385&action=edit This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr Bug 11371 - Add a new report : Orders by budget -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:58:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:58:10 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Ahmed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |ahmed.sfayhi at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 14:58:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 13:58:59 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Ahmed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahmed.sfayhi at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:06:54 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:07:22 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34237|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 35386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35386&action=edit Bug 13418: Clean C4::VirtualShelves::Page a bit I tried to reuse this package for a new development, I did not manage. It's a really hard to read and to understand. Here my first try, this patch only remove the call to _shelf_count in the GetShelves subroutine. Someone might want to get this value for another reason and from somewhere else. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:07:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:07:27 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 --- Comment #4 from M. de Rooy --- Created attachment 35387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35387&action=edit Bug 13418: [QA Follow-up] Use unshift instead of push Some SQL parameters are added to the wrong side of the list. This effectively clears all private lists from view :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:08:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:08:36 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 --- Comment #5 from M. de Rooy --- Still looking at the second original patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:16:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:16:05 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #51 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:20:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:20:48 +0000 Subject: [Koha-bugs] [Bug 12971] Regression: Patron print summary doesn't show checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- (In reply to Liz Rea from comment #15) > Will we be pulling this fix back to 3.16? > > Cheers, > Liz Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:25:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:25:50 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34238|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 35388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35388&action=edit Bug 13418: Clean C4::VirtualShelves::Page - Part 2 I don't understand at all the usefulness of $privshelflist and $privtotshelves in C4::VirtualShelves::Page They look useless. If you deep in the git history, you will find commit 25eb36f21fe952118327d2c84dfef5d38eee31a7 Bug #2531 Cannot delete private shelf I am not able to reproduce this issue after this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:26:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:26:22 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35388|Bug 13418: Clean |[NOT_SIGNED] Bug 13418: description|C4::VirtualShelves::Page - |Clean |Part 2 |C4::VirtualShelves::Page - | |Part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:26:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:26:46 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 --- Comment #7 from M. de Rooy --- (In reply to M. de Rooy from comment #5) > Still looking at the second original patch. Hope to finish this one later this week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:40:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:40:00 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:40:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:40:03 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33914|0 |1 is obsolete| | Attachment #33915|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 35389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35389&action=edit Bug 12669: Use floating timezone when handling dates without hours, minutes and seconds. Test plan: 1. Create a new serial record or pick an existing one; 2. Add a "New subscription" and set the "First issue publication date" and "Frequency" values so that the "Planned date" for a given issue hits a day where a transition to Daylight Saving Time (DST) occurs ex:. 1979-04-01 in Europe/Lisbon (http://www.timeanddate.com/time/change/portugal/lisbon?year=1979) ... use this website page as a source http://www.timeanddate.com/time/dst/2014.html to find a suitable transition to DST in your timezone in the current year. 3. From the "Subscription detail" page in Koha for the given record click the "Serial collection" link on the left side context menu. Expected result: Prior to applying the patch the error described in this bug report should occur. After the patch is applied the "Serial collection" page should load correctly. Signed-off-by: Colin Campbell -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:40:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:40:12 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 --- Comment #21 from Jonathan Druart --- Created attachment 35390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35390&action=edit Bug 12669: Centralize the timezone handle into Koha::DateUtils This patch adds unit tests for the previous changes and centralize the timezone handle into the Koha::DateUtils module. Like that the behavior will affect all date manipulations using this module (should be all dates in Koha). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:42:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:42:08 +0000 Subject: [Koha-bugs] [Bug 13122] Patron holds table no longer display date item went in transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13122 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #6 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 15:45:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 14:45:53 +0000 Subject: [Koha-bugs] [Bug 13168] "Today's checkouts" sort improperly because issuedate lacks seconds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13168 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- (In reply to Tom?s Cohen Arazi from comment #6) > Patch pushed to master. > > Thanks Owen! Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:36:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:36:46 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #10 from Martin Renvoize --- Wrong bug.. my bad. Making a new one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:41:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:41:46 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35384|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 13596] New: Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Bug ID: 13596 Summary: Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: abl at biblos.pk.edu.pl, benjamin.rokseth at kul.oslo.kommune.no, bgkriegel at gmail.com, boutrosboutrosboutros at gmail.com, dpavlin at rot13.org, hbraum at nekls.org, jonathan.druart at biblibre.com, josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, m.de.rooy at rijksmuseum.nl, magnus at enger.priv.no, martin.renvoize at ptfs-europe.com, paola.rossi at cineca.it, tomascohen at gmail.com, z.tajoli at cineca.it Depends on: 11248, 11906, 11944, 13264 Blocks: 7380, 10855, 11844, 12176, 12637, 12832, 13239, 13345, 13577, 13579 Bug #11944 fixed utf8 encoding koha wide, however as part of it, it updates all database table to utf8 charset and utf8_unicode_ci collation. This is a good thing for anyone who left the default coallition to being with, but is a step backwards for those working on Wheezy and Ubuntu who may have chosen the utf8_mb4 pragma. The update should first check for such cases, and skip if found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 11248] Problems with translated list email sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11248 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 11906] Bad display of utf-8 chars in Patron lists (Datatable) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11906 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13596 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 13264] Full stack encoding tests (UTF-8) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 12832] Basketgroup printing doesn't support no latin chars In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12832 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 13239] MySQL Character encoding utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13239 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:44:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:44:33 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 --- Comment #1 from Martin Renvoize --- Created attachment 35391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35391&action=edit BUG 13596: Prevent utf8mb4 -> utf8 convertion utf8mb4 is a superset of utf8 and thus is compatible. We should not force an entire db change upon people who have proactively set utf8mb4 encoding before now. This patch aslo removed the deprecated use of ->tables stanza in favour of the table_info stanze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:49:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:49:31 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35391|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 35392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35392&action=edit BUG 13596: Prevent utf8mb4 -> utf8 convertion utf8mb4 is a superset of utf8 and thus is compatible. We should not force an entire db change upon people who have proactively set utf8mb4 encoding before now. This patch aslo removed the deprecated use of ->tables stanza in favour of the table_info stanze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:52:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:52:35 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35392|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 35393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35393&action=edit BUG 13596: Prevent utf8mb4 -> utf8 convertion utf8mb4 is a superset of utf8 and thus is compatible. We should not force an entire db change upon people who have proactively set utf8mb4 encoding before now. This patch aslo removed the deprecated use of ->tables stanza in favour of the table_info stanze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:54:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:54:42 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #21 from Jonathan Druart --- Created attachment 35394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35394&action=edit Bug 12993: (qa-follow-up) Display the column only when it is useful As mention by comment 19, the default tax rate defined for item types is only useful when the items are created on ordering and the item type is defined at the biblio level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:56:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:56:33 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #7 from Koha Team Lyon 3 --- For the setup 3 (List prices INCLUDE TAX + Invoice prices EXCLUDE TAX), I would have the same analysis as Laurence : the change of tax between order and receipt should not change prices tax excl. that are the basis. So this patch introduce the right calculation. For the setup4 (List prices EXCLUDE TAX + Invoice prices INCLUDE TAX), It would be better that the price tax incl. was recalculated in the order receive page. But for me, it's not the most important. What really matters is that the calculation is right after the receipt was recorded. There's often a change of price between the order and the receipt and the calculation have to take into account the entered price. Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 16:56:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 15:56:57 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from Jonathan Druart --- (In reply to M. de Rooy from comment #19) Hi Marcel, Yes you are right, this development only works if the item types are defined at the biblio level and if the items are created on ordering. The last patch removes the column in other cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 17:04:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 16:04:55 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35393|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 35395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35395&action=edit BUG 13596: Prevent utf8mb4 -> utf8 convertion utf8mb4 is a superset of utf8 and thus is compatible. We should not force an entire db change upon people who have proactively set utf8mb4 encoding before now. This patch aslo removed the deprecated use of ->tables stanza in favour of the table_info stanze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 17:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 16:07:49 +0000 Subject: [Koha-bugs] [Bug 13597] New: no image needs a class in the staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Bug ID: 13597 Summary: no image needs a class in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 35396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35396&action=edit no image and cover image In the OPAC you can hide the no image found icon using the class. But in the staff client there is no such class and so if you have a local cover image it shows the local image and the no image found icon. The code is: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 20:06:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 19:06:10 +0000 Subject: [Koha-bugs] [Bug 8096] Card number twice on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 20:06:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 19:06:39 +0000 Subject: [Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 20:08:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 19:08:18 +0000 Subject: [Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 22:54:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 21:54:04 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #39 from Robin Sheat --- (In reply to Gaetan Boisson from comment #35) > I would say this ticket should remain about adding item data, and we should > create another bug report, that would tackle the issue of exporting > sensitive data everywhere this could happen. what do you think? Yes, this! :) I kinda think that internal notes shouldn't ever go into the MARC anyway, it should perhaps be a separate table. Otherwise the chance of leak is quite high. But this is definitely a separate issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 19 22:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 21:59:14 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #40 from Katrin Fischer --- I like Gaetan's suggestion - we discussed this some more on IRC earlier today, the 'visibility' problem is indeed too big for this bug. But apart from how it should be... We have an 'internal note' in the item and the configuration options to hide in OPAC ... but we are not doing it right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 00:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Jan 2015 23:02:41 +0000 Subject: [Koha-bugs] [Bug 13598] New: Tax Rate displays different from Acquisition Preference gist Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13598 Bug ID: 13598 Summary: Tax Rate displays different from Acquisition Preference gist Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jmorash at pacbell.net QA Contact: testopia at bugs.koha-community.org When I set the Acquisitions Preference gist to 8.75%, it displays in the order Accounting details as 875.0% When I set the Acquisitions Preference gist to 0.0875, it displays in the order Accounting Details as 8.8% With either it should display as 8.75% -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 03:14:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 02:14:25 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #10 from David Cook --- (In reply to Katrin Fischer from comment #9) > David, thx for your comments. Could you give this a second sign-off? Yep, but not today. I'll put it on my to do list for later this week! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 03:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 02:15:37 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #19 from David Cook --- (In reply to Katrin Fischer from comment #18) > Suggestion: Make only changes to the title on this bug and move the bigger > task of displaying good material type information into a separate bug. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 03:22:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 02:22:13 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #41 from David Cook --- (In reply to Robin Sheat from comment #39) > (In reply to Gaetan Boisson from comment #35) > > I would say this ticket should remain about adding item data, and we should > > create another bug report, that would tackle the issue of exporting > > sensitive data everywhere this could happen. what do you think? > > Yes, this! :) > > I kinda think that internal notes shouldn't ever go into the MARC anyway, it > should perhaps be a separate table. Otherwise the chance of leak is quite > high. But this is definitely a separate issue. +1 Gaetan: There's been a bit of work done on the opac detail page (see http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592), but I'd definitely like to see a more consistent approach that respects the "visibility settings" everywhere in Koha (i.e. tools export, OAI, cart, search results, detail page, etc.) I think Tomas had an idea about this... about using the frameworks to generate an "exclusion" XSLT which MARCXML would be run through after retrieving a record from Zebra or MySQL. I suppose the only time that you might want to not use the "exclusion" XSLT would be for... well perhaps a few scenarios. Most places in the staff client would probably want to show it, and only hide it if you're sending the record elsewhere... (unless you're exporting it to a cataloguing tool where you want to re-import afteward). Hmm, food for thought! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 03:23:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 02:23:34 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #42 from David Cook --- (In reply to Katrin Fischer from comment #40) > I like Gaetan's suggestion - we discussed this some more on IRC earlier > today, the 'visibility' problem is indeed too big for this bug. > > But apart from how it should be... We have an 'internal note' in the item > and the configuration options to hide in OPAC ... but we are not doing it > right. Agreed. Definitely too big for this bug... but perhaps the "visibility" problem blocks this bug? Yeah, an "internal note" in the item and ineffectual configuration options to hide in the OPAC :/. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 06:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 05:06:17 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #11 from paxed --- (In reply to Ahmed Sfayhi from comment #10) > > A "[i]" is also added before the names of inactive budgets in the budget > selection box. > That "[i]" is not translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 06:50:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 05:50:53 +0000 Subject: [Koha-bugs] [Bug 13195] Regression: Circulation checkouts table no longer shows item type description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13195 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 10:44:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 09:44:06 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 10:44:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 09:44:12 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30218|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart --- Created attachment 35397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35397&action=edit Bug 7710 - multiple holds per title Adds the ability to allow multiple holds on the same record for the same borrower. Adds new system preference MaxHoldsPerRecord, which controls how many holds one person can have on items for the same record. Test Plan: 1) Apply patch for Bug 9394 2) Apply this patch 3) Run updatedatabase.pl 4) Attempt to place 2 holds for the same patron on the same record, you should not be able to ( default is 1 per record ) 5) Set MaxHoldsPerRecord to 3 6) Attempt to place multiple holds for one patron on one record, you should be able to place 3 holds for one patron on a given record. A 4th hold should result in a message stating the patron has placed the max number of holds allowed on this record. Signed-off-by: Maxime Pelletier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 10:46:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 09:46:08 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #75 from Jonathan Druart --- I rebased this patch manually (using git apply --reject) and recreated the patch. Note that I did *not* test it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 10:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 09:46:33 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #76 from Jonathan Druart --- (In reply to M. de Rooy from comment #65) > Another question too: > Why do you remove this line: > -('XSLTResultsDisplay','default','','Enable XSL stylesheet control over > results page display on intranet','Free'), I reintroduced this line in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 11:18:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 10:18:21 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34612|0 |1 is obsolete| | Attachment #34613|0 |1 is obsolete| | --- Comment #8 from Rafal Kopaczka --- Created attachment 35398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35398&action=edit Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 11:18:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 10:18:29 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #9 from Rafal Kopaczka --- Created attachment 35399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35399&action=edit Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 11:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 10:18:35 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #10 from Rafal Kopaczka --- Created attachment 35400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35400&action=edit Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 11:24:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 10:24:17 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #11 from Rafal Kopaczka --- Hi Katrin, thanks for testing. I've could replicate only one issue: "ERROR 1062 (23000) at line 4090: Duplicate entry 'CF-952-i' for key 'PRIMARY'". It's fixed in followup. Other errors are from files, that are deleted in patch. It looks like you have applied only first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 11:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 10:24:55 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 12:09:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 11:09:17 +0000 Subject: [Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Paola Rossi --- (In reply to Charles Farmer from comment #13) > Created attachment 35314 [details] [review] > Bug 6968 - Check expiration in serials expired before today > > I'm resubmitting the last patch, which I could apply on master 3.19.00.006, > in a slightly different format. > > Hoping this solves your issue. Kind Charles, I've applied the patch against master 3.19.00.006 head 13526. Soon after having applied, when I: git format-patch -s origin/master, 1-A) I got a file where "From" is: charles instead of : charles It could be an error. 1-B) In that file there was this: Subject: [PATCH] Patch sponsored by our client http://www.ccsr.qc.ca/ instead of the usual commit message: Bug 6968 - Show items expired before today in check expiration of serials page identifying the patch and describing the content of the patch. [The patches' commit messages will be seen in the master branch: ] So I pass the patch to "Patch doesn't apply" again. ---------------------------------------------------------------------------- Anyway I've gone on and tested your patch, that is fixing a lasting bug. I'm not a QA, I don't know precisely the QA guidelines. I write some considerations of mine you can evaluate. The patch you wrote added a true difference between: subscriptions "already" expired until today [included] (added to the selection by the new checkbox) subscriptions that "will" expire (from tomorrow [included] to the input date [excluded], chosen by the calendar). But IMO in master this difference was not so present: as you can see, the calendar is not limited from tomorrow on. So I think that your patch could "match" this "error" not so well. Perhaps : A) extending the current selection to all the end-dates of the subscriptions, and B) adding a "From" and a "To" dates input fields (as an improvement), could be a more "matching" solution. The default values of "From" and "To" could be the MIN and MAX end-date of the subscriptions in DB, whilst "today" could be set as the default in the 2 calendars. C) moreover, the resulting table could be sortable, on end-date at least (as a further improvement). Otherwise, if the solution provided by the patch has been already considered as being the best one, consider that some inaccuracies occur: 1-A) when I checked the checkbox and I chose an year ago as input date, the selection is not about "before today", but "before an year ago": the result is shown (IMO right). 1-B) if I didn't check the checkbox and I chose an year ago as input date, the selection is null, as you know [this result is wrong IMO]. If you limit the calendar from tomorrow on, the user will not be able to get a selection limited like 1-A). If you don't limit the calendar from tomorrow on, B) is an available case of choice to the user, and it is unfriendly to the user (misleading). Anyway, if the solution provided by the patch has been already considered as being the best one, in the form "before" won't be used in the same meaning: once "<", and the other time as " <=". This difference is unfriendly to the user: the resulting table could miss some particular subscriptions. To solve, a better solution can choose one of the 2 cases: hypothesis 2-1) ("<") "before" excluding the upper limit: Adding "Show expired before tomorrow:" instead of adding "Show expired before today:" could be better. hypothesis 2-2) ("<=") "before" including the upper limit (better, IMO): The patch should keep "Show expired before today:". But the patch should also modify the "Expiring before: " behaviour, to include the chosen value too in the selection. Anyway, if the solution provided by the patch has been already considered as being the best one, being the form a "Filters" one, its default should be better set to select all the subscriptions. So I think that: 3-A) a default could be set in the input fields: checked checkbox (!), usefull upper limit [=MAX end-date+included (2-2), or greater than MAX end-date]. As a further inprovement, the sort could be add to the table. If the expiring' time is so important to the user, the default sorting could be set to end-data DESC [in spite of the current subscription code, not related]. I hope these considerations can be of some help. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 12:37:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 11:37:21 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #24 from Jonathan Druart --- (In reply to Katrin Fischer from comment #23) > Could the problem be similar to what we saw on the patch for the parcels > page? Yes, actually I noticed this problem for the first time when I worked on this one. I started a discussion on koha-devel this morning [1], it seems that DateTime::Format::DateParse introduces more problems than it is supposed to help. [1] http://lists.koha-community.org/pipermail/koha-devel/2015-January/041095.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 13:17:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 12:17:54 +0000 Subject: [Koha-bugs] [Bug 13599] New: Add patron cardnumber to self registration confirmation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Bug ID: 13599 Summary: Add patron cardnumber to self registration confirmation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 13:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 12:18:02 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 13:19:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 12:19:40 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 13:19:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 12:19:42 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 --- Comment #1 from Kyle M Hall --- Created attachment 35401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35401&action=edit Bug 13599 - Add patron cardnumber to self registration confirmation Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. Test Plan: 1) Apply this patch 2) Self-register a new patron 3) Note confirmation screen now displays the patron cardnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 13:25:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 12:25:49 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35401|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 35402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35402&action=edit Bug 13599 - Add patron cardnumber to self registration confirmation Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. Test Plan: 1) Apply this patch 2) Self-register a new patron 3) Note confirmation screen now displays the patron cardnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 13:39:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 12:39:17 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #3 from Kyle M Hall --- *** Bug 12381 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 13:39:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 12:39:17 +0000 Subject: [Koha-bugs] [Bug 12381] show patron barcode on self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12381 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 13599 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 13:42:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 12:42:42 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35402|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 35403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35403&action=edit Bug 13599 - Add patron cardnumber to self registration confirmation Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. Test Plan: 1) Apply this patch 2) Ensure that autoMemberNum is enabled 3) Self-register a new patron 4) Note confirmation screen now displays the patron cardnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 14:01:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 13:01:48 +0000 Subject: [Koha-bugs] [Bug 10654] Add feature: export basket in CSV, list of custom formats for various vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10654 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 14:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 13:23:52 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 14:35:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 13:35:25 +0000 Subject: [Koha-bugs] [Bug 13595] Checking out an issued item doesn't return it after confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13595 --- Comment #1 from Owen Leonard --- (In reply to Josef Moravec from comment #0) > But after clicking "Yes" button, the item is just issued to current member, > but is NOT checked in before! Are you saying that the item remains checked out to both patrons, or that some action which is supposed to be performed upon check-in is not being performed? When I test it in master it works as I expect it to: The item is removed from the previous patron's account and checked out to the current one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 14:36:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 13:36:22 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #72 from M. Tompsett --- simith.doliveira at inlibro.com, could you squash your patches together too? Just my preference. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 14:45:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 13:45:11 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #73 from Owen Leonard --- (In reply to M. Tompsett from comment #72) > Just my preference. :) Last I heard it was not the RM's preference, but that may have been a previous RM. Perhaps this is something we should add to the coding guidelines? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 14:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 13:47:21 +0000 Subject: [Koha-bugs] [Bug 13595] Checking out an issued item doesn't return it after confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13595 --- Comment #2 from Josef Moravec --- Yes, but now I tested it on master and on another 3.18.2 stable installation and everything went right, so It looks like there is something wrong with one concrete installation... I'll investigate it deeper... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 14:47:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 13:47:32 +0000 Subject: [Koha-bugs] [Bug 13595] Checking out an issued item doesn't return it after confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13595 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 14:56:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 13:56:24 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #74 from M. Tompsett --- The patches were never signed off. I figure a squash isn't so bad at this stage. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:01:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:01:19 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:03:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:03:32 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:04:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:04:55 +0000 Subject: [Koha-bugs] [Bug 13237] Regression: List of previous checkouts should be ordered by due date ascending In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:05:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:05:09 +0000 Subject: [Koha-bugs] [Bug 13236] Regression: Table of checkouts no longer preselects overdue items for rewewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:05:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:05:22 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:20:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:20:59 +0000 Subject: [Koha-bugs] [Bug 13600] New: XSLT: 8xx not showing if there is no 4xx Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Bug ID: 13600 Summary: XSLT: 8xx not showing if there is no 4xx Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org In records with series field(s) 800/810/830 only (no 4XX series), no series are displayed. The MARC21 rules say: "An 810 field is usually justified by a series statement (field 490) or a general note (field 500) relating to the series." "usually" means it should show even if there is no 490 http://www.loc.gov/marc/bibliographic/bd810.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:22:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:22:04 +0000 Subject: [Koha-bugs] [Bug 13601] New: Get rid of DateTime::Format::DateParse Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Bug ID: 13601 Summary: Get rid of DateTime::Format::DateParse Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org For a couple of reasons, dt_from_string should not use DateTime::Format::DateParse: 1/ It does not manage date < 1900 (certainly caused by l.47 of this module: $p{ year } = $year ? $year + 1900 : DateTime->now->year; 2/ It considers 31/01/2015 as a valid us date, which is not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:23:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:23:28 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:31:08 +0000 Subject: [Koha-bugs] [Bug 11577] Automatic renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #126 from Mason James --- Skipping patch for 3.16.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:41:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:41:54 +0000 Subject: [Koha-bugs] [Bug 13602] New: Username/password already exists when editing borrower attributes and messaging preferences Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Bug ID: 13602 Summary: Username/password already exists when editing borrower attributes and messaging preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. AFTER THIS PATCH: Check_Userid() is not called when modifying or saving partial borrower properties. Userid is changed using a separate module. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:47:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:47:10 +0000 Subject: [Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #89 from Mason James --- Skipping patch for 3.16.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:49:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:49:39 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35404&action=edit Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. AFTER THIS PATCH: Check_Userid() is not called when modifying or saving partial borrower properties. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:49:58 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 15:50:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 14:50:55 +0000 Subject: [Koha-bugs] [Bug 13603] New: autoBarcode setting hbyymmincr not taking month into account when looking up next increment Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Bug ID: 13603 Summary: autoBarcode setting hbyymmincr not taking month into account when looking up next increment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The hbyymmincr autoBarcode builder looks up all barcodes that begin with any number of letters ( the branchcode ) and a two-digit year directly afterward ( e.g. MPL15 ), then grabs the last four digits as the increment counter. The problem is, this does not take months into account, so unlike the description that says the system is limited to 10,000 items a month, it is limited to 10,000 items per *year*. This situation can easily be corrected my adding the month into the lookup ( e.g. MPL1501 ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:02:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:02:30 +0000 Subject: [Koha-bugs] [Bug 13253] Unnecessary white space above checkouts table in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #5 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:12:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:12:16 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:12:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:12:20 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #1 from Jonathan Druart --- Created attachment 35405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35405&action=edit Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:12:24 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #2 from Jonathan Druart --- Created attachment 35406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35406&action=edit Bug 13601: Make dt_from_string not using DateTime::Format::DateParse For a couple of reasons, dt_from_string should not use DateTime::Format::DateParse: 1/ It does not manage date < 1900, certainly caused by l.47 of this module: $p{ year } = $year ? $year + 1900 : DateTime->now->year; 2/ It considers 31/01/2015 as a valid us date, which is not. Test plan: 1/ Verify that prove t/DateUtils.t returns green 2/ Play with dates in Koha (yes I know, it's vague...) 3/ Try to find a regression with dates 4/ Create a date with year <= 1900 and confirm it works QA comment: Why the sql format switch was: - $date_string =~ -s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/; >From where a date like "yyyymmdd hhmmss" can come? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:12:32 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #3 from Jonathan Druart --- Created attachment 35407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35407&action=edit Bug 13601: get rid of DateTime::Format::DateParse This module is used in C4::Members::GetPendingIssues too, but we can use dt_from_string. Test plan: 1/ Verify that prove t/db_dependent/Members/GetPendingIssues.t returns green 2/ On the patron pending issue list, verify that the issue and the due dates are correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:12:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:12:45 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #4 from Jonathan Druart --- Created attachment 35408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35408&action=edit Bug 13601: Add a fallback check for compability with existing code There are a lot of places where the date comes from the DB but the dateformat parameter is not set to 'sql'. dt_from_string needs to fallback with this format if the pref format does not match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:14:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:14:20 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #5 from Jonathan Druart --- Colin, As you are the main author of Koha::DateUtils, I really would like to get your opinion on this patch set :) Especially on the QA comment (second patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:17:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:17:48 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:17:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:17:55 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:18:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:18:11 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 --- Comment #1 from Kyle M Hall --- Created attachment 35409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35409&action=edit Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment The hbyymmincr autoBarcode builder looks up all barcodes that begin with any number of letters ( the branchcode ) and a two-digit year directly afterward ( e.g. MPL15 ), then grabs the last four digits as the increment counter. The problem is, this does not take months into account, so unlike the description that says the system is limited to 10,000 items a month, it is limited to 10,000 items per *year*. This situation can easily be corrected my adding the month into the lookup ( e.g. MPL1501 ). Test Plan: 1) Enable autoBarcode, set to hbyymmincr 2) Catalog an item, let the barcode.pl plugin generate the next barcode. 3) Catalog an item with the barcode MPL15009999 4) Catalog another item, use the barcode.pl plugin to generate the next barcode. 5) Note the barcode is generated ends with '0001' instead of the correct increment 6) Apply this patch 7) Repeat step 4 8) Note the barcode now ends with the correct increment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:18:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:18:08 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:18:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:18:41 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13258 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:18:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:18:41 +0000 Subject: [Koha-bugs] [Bug 13258] Clicking the "show checkouts" button should return focus to the barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13258 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13537 CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:43:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:43:55 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:43:58 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35339|0 |1 is obsolete| | Attachment #35340|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 35410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35410&action=edit Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:44:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:44:03 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #7 from Jonathan Druart --- Created attachment 35411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35411&action=edit Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:44:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:44:32 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch Severity|enhancement |trivial Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 16:49:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 15:49:22 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #13 from Jonathan Druart --- I was a little bit uncertain with this patch, there are something like 25 patches modifying C4/Auth.pm in the bug queue. Most of them are FQA and won't help the rebase. But they are mainly 1 or 2 lines patches, it should not be too difficult to rebase them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:01:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:01:52 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:01:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:01:56 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35341|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 35412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35412&action=edit Bug 12954: Failed login should retain anonymous session A failed login should not leave the user in a half logged authenticated state, but rather return them to an anonymouse session as per the pre-login attempt state. To replicate error: 1. Try to log in with some nonexisting user id or wrong password in the OPAC 2. Go directly to /opac-user.pl (e.g., enter it in the browser address bar, or just click on the "Log in" link) 3. Observe a DBI error displayed on the screen 4. You are now in the "deadloop" of sorts (opac/opac-user.pl refuses to display the login screen, no matter how many times you try to reload it); to break the deadloop, one needs to: - remove session cookie from the browser (or cause the session to expire in some other way - closing browser window would be probably enough for that) - remove offending session on the server (from mysql sessions table, ..) - log in with proper credentials using some other page (like opac/opac-main.pl right-side panel), which does not involve opac/opac-user.pl being called without "userid" CGI parameter. To test: 1. Test as above, the DBI error should no longer be present 2. Check that search history works across failed and sucessful login attempts Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:03:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:03:19 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #17 from Jonathan Druart --- This is a very bad bug! I tried to fix something in opac-user.pl, to avoid the script to continue (a redirect if get_template_and_user does not return a $borrowernumber?), but don't know how to do it correctly. I confirm this patch fixes the issues. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:07:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:07:06 +0000 Subject: [Koha-bugs] [Bug 13301] Call number link in search results is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13301 --- Comment #6 from Barton Chittenden --- (In reply to Katrin Fischer from comment #5) > Hm, could you check ICU vs. CHR? I think that might be it. The 'UseICU' system preference is set to 'Using'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:09:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:09:28 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- Looks like something is wrong for me: % prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 23/67 # Failed test 'ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location.' # at t/db_dependent/Circulation.t line 648. # Looks like you failed 1 test of 67. Does it come from my DB? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:10:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:10:35 +0000 Subject: [Koha-bugs] [Bug 13604] New: CSS incorrectly formatted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13604 Bug ID: 13604 Summary: CSS incorrectly formatted Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org opac.css is no longer formatted correctly. All elements are running into each other, for example: .shadowed{-webkit-box-shadow:0 1px 1px 0 rgba(0,0,0,0.2);-moz-box-shadow:0 1px 1px 0 rgba(0,0,0,0.2);box-shadow:0 1px 1px 0 rgba(0,0,0,0.2)}body{background-color:#eaeae6}html,body{height:100%}.no-js .dateformat{display:inline;white-space:nowrap}.no-js .modal-body{padding:0} (etc.) This makes it impossible to read and to work with. It ought to be formatted as, for example: .shadowed { -webkit-box-shadow:0 1px 1px 0 rgba(0,0,0,0.2); -moz-box-shadow:0 1px 1px 0 rgba(0,0,0,0.2); box-shadow:0 1px 1px 0 rgba(0,0,0,0.2) } body { background-color:#eaeae6 } (etc) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:10:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:10:55 +0000 Subject: [Koha-bugs] [Bug 13604] CSS incorrectly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13604 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:21:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:21:40 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #6 from Colin Campbell --- (In reply to Jonathan Druart from comment #0) > For a couple of reasons, dt_from_string should not use > DateTime::Format::DateParse: > 1/ It does not manage date < 1900 (certainly caused by l.47 of this module: > $p{ year } = $year ? $year + 1900 : DateTime->now->year; > 2/ It considers 31/01/2015 as a valid us date, which is not. The reason dates before 1900 are not handled is in the doc for Date::Parse Date::Parse uses Time::Local internally, so is limited to only parsing dates which result in valid values for Time::Local::timelocal. This generally means dates between 1901-12-17 00:00:00 GMT and 2038-01-16 23:59:59 GMT That wasnt a problem with DateUtils as it was just ensuring the old C4::Dates routines could be handled which were also unable to handle pre 1900 dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:24:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:24:58 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #7 from Colin Campbell --- (In reply to Jonathan Druart from comment #2) > Created attachment 35406 [details] [review] > Bug 13601: Make dt_from_string not using DateTime::Format::DateParse > > For a couple of reasons, dt_from_string should not use > DateTime::Format::DateParse: > 1/ It does not manage date < 1900, certainly caused by l.47 of this > module: > $p{ year } = $year ? $year + 1900 : DateTime->now->year; > > 2/ It considers 31/01/2015 as a valid us date, which is not. > > Test plan: > 1/ Verify that > prove t/DateUtils.t > returns green > 2/ Play with dates in Koha (yes I know, it's vague...) > 3/ Try to find a regression with dates > 4/ Create a date with year <= 1900 and confirm it works > > QA comment: > Why the sql format switch was: > - $date_string =~ > -s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/; > > From where a date like "yyyymmdd hhmmss" can come? C4::Dates supported the format so DateUtils had to accept it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:25:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:25:03 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #22 from Jonathan Druart --- Kyle, Does this pass qa? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:27:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:27:29 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #23 from Jonathan Druart --- Note: The tablesorter jquery plugin has been removed from the src. Does not it possible to do the same thing using DataTables? + => This is wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:45:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:45:38 +0000 Subject: [Koha-bugs] [Bug 5501] why is there a 'do not notify' option? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #3 from Olli-Antti Kivilahti --- We have confusion as well. The worst thing is that it actually doesn't do what it says. We still have print messages even if the "do not notify"-option is used. Looking into adding a new message-transport-type "do not notify" used to catch that. So instead of clicking an "clear"-button in the GUI we actually select a viable transport alternative overriding message sending behaviour. Sometimes the message_transport_type defaults to print if no transport is defined. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 17:55:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 16:55:04 +0000 Subject: [Koha-bugs] [Bug 13604] CSS incorrectly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13604 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- The OPAC now uses a LESS file (opac.less) which compiles into minified CSS. opac.css should not be modified. http://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 19:07:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 18:07:06 +0000 Subject: [Koha-bugs] [Bug 5501] why is there a 'do not notify' option? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 35413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35413&action=edit Bug 5501 - Improve the 'do not notify' option Introducing the message_transport_type 'none' and enabling it for all messages. Enabling print-option for "HOLD Fulfilled". Print option can be added for other messages as well, but HOLD seems to make the most sense. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 19:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 18:07:46 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|why is there a 'do not |Improve the 'do not notify' |notify' option? |option -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:01:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:01:29 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 35414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35414&action=edit Bug 5501 - Improve the 'do not notify' option. HOLD-letter. TEST PLAN: 1. Find a Borrower and edit "Patron messaging preferences". 2. Check the "Do not notify" for "Hold filled" -letter. 3. Check any other checkboxes for "Hold filled" -letter. The "Do not notify"-checkbox should get unchecked. 4. Check the "Do not notify" -checkbox again for the "Hold filled" -letter. Other selections for the row get unchecked. 5. Save changes. 6. Make a hold for a borrower. 7. Check-in the reserved Item and catch the hold. 8. In the notices-tab for the Borrower, there should be no message for the borrower about getting the caught Hold. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:03:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:03:23 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #6 from Olli-Antti Kivilahti --- This feature is about enabling explicit message rejection for selectable message types. Default behaviour is only overridden if the "Do not notify"-checkbox is checked. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:16:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:16:16 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35330|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 35415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35415&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:23:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:23:04 +0000 Subject: [Koha-bugs] [Bug 13301] Call number link in search results is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13301 --- Comment #7 from Katrin Fischer --- Hm, in both the working and non-working installation? And are they both actually using ICU? The pref influences how some search links work in the XSLT (afaik) but will not actually turn it off or on) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:23:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:23:24 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | Severity|enhancement |normal --- Comment #2 from Owen Leonard --- Can you please describe how to reproduce this bug? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:24:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:24:29 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:25:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:25:31 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #24 from Katrin Fischer --- Hm, well spotted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:31:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:31:18 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer --- I asked Owen on IRC and he confirmed that we have removed the tablesorter plugin - I think we should avoid adding it back and having different implementations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:34:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:34:55 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:34:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:34:58 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35403|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 35416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35416&action=edit [SIGNED-OFF] Bug 13599 - Add patron cardnumber to self registration confirmation Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. Test Plan: 1) Apply this patch 2) Ensure that autoMemberNum is enabled 3) Self-register a new patron 4) Note confirmation screen now displays the patron cardnumber Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 20:36:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 19:36:12 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #6 from Owen Leonard --- I consider this a bug-fix rather than an enhancement because of the complexity of explaining to users who register online how to find their library card number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 21:17:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 20:17:14 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #14 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 21:17:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 20:17:27 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35258|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 21:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 20:17:36 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #15 from sandboxes at biblibre.com --- Created attachment 35417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35417&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing added) Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 21:33:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 20:33:14 +0000 Subject: [Koha-bugs] [Bug 13425] There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13425 --- Comment #46 from Chris Cormack --- We got this assigned a CVE number CVE-2014-9446 http://www.cvedetails.com/cve/CVE-2014-9446/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 22:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 21:17:36 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #166 from Katrin Fischer --- Hi Kyle, I tried to retest the problem, but the database update gives me problems :( bumblebee:~/kohaclone (38-9303-relativecheckouts|AM 1/1) $ ./installer/data/mysql/updatedatabase.pl DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists at ./installer/data/mysql/updatedatabase.pl line 9681. DBD::mysql::db do failed: Can't DROP 'itemnumber_idx'; check that column/key exists at ./installer/data/mysql/updatedatabase.pl line 9687. DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists at ./installer/data/mysql/updatedatabase.pl line 9690. DBD::mysql::db do failed: Cannot drop index 'itemnumber_idx': needed in a foreign key constraint at ./installer/data/mysql/updatedatabase.pl line 9696. DBD::mysql::db do failed: Duplicate key name 'itemnumber_idx' at ./installer/data/mysql/updatedatabase.pl line 9699. Upgrade to 3.19.00.XXX done (Bug 9303 - relative's checkouts in the opac) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 22:19:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 21:19:04 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #167 from Katrin Fischer --- Just realized I didn't have all the patches... and that it might be a bit too late tonight for this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 22:19:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 21:19:27 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 22:33:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 21:33:02 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 22:33:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 21:33:06 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30772|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 35418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35418&action=edit This patch fix the QA critical error, fix the capitalization and the UNIMARC support. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 22:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 21:43:09 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 22:43:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 21:43:12 +0000 Subject: [Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35088|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 35419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35419&action=edit [SIGNED OFF] Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" Signed-off-by: Katrin Fischer Confirmed problem and tested patch on a sandbox, signed off locally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 22:58:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 21:58:33 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35349|0 |1 is obsolete| | --- Comment #221 from Katrin Fischer --- Created attachment 35420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35420&action=edit Bug 7143: Adding back version numbers Adding back version numbers to the former release team members in the list of developers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:00:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:00:15 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #222 from Katrin Fischer --- Corrected the typos Marcel pointed out and replaced 3.x by 3.0+/3.2+ as discussed on IRC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:25:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:25:23 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #12 from Katrin Fischer --- Hi Rafal, your follow-up works and you were right about the patches, signing off now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:28:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:28:10 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:28:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:28:14 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35398|0 |1 is obsolete| | Attachment #35399|0 |1 is obsolete| | Attachment #35400|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 35421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35421&action=edit [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:28:31 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35421|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 35422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35422&action=edit [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:28:48 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #15 from Katrin Fischer --- Created attachment 35423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35423&action=edit [SIGNED OFF] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:30:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:30:33 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35422|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 35424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35424&action=edit [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:30:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:30:38 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #17 from Katrin Fischer --- Created attachment 35425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35425&action=edit [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:30:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:30:42 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35423|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 35426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35426&action=edit [SIGNED OFF] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:38:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:38:21 +0000 Subject: [Koha-bugs] [Bug 13598] Tax Rate displays different from Acquisition Preference gist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think you can only use the 0.0875 syntax in the gist preference, but there is another bug about the number of decimals to show: bug 10253. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 20 23:41:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 22:41:30 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I don't have time to test this thoroughly, but I can confirm the problem: If you use the small 'edit' links for a section of the patron record instead of the 'edit' link in the toolbar, you can't save changes - as you get an error message: The following fields are wrong. Please fix them. Username/password already exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 00:10:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Jan 2015 23:10:38 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Aleisha Amohia --- Can't see <> to replace <> when editing the notice - setting to Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 02:39:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 01:39:18 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #8 from David Cook --- (In reply to mathieu saby from comment #7) > My personal opinion is that QP having been introduced in 2012, it should be > well documented and bug-proof, and the older code should have been > deprecated. > > Mathieu That would imply that someone was still working on QP ;). As far as I know, no one is actually actively maintaining or enhancing that code. I have some ideas about how to do that, but I don't have the time/money/sponsorship/whatever to do it. The older code is still used in many many cases even when QP is activated, so deprecating the older code is really not an option at this stage. As for documentation, http://evergreen-ils.org/dokuwiki/doku.php?id=documentation:technical:search_grammar might give you some guidance, although obviously it won't be the same since it's implemented differently in Koha. As far as I know, Evergreen doesn't have a search engine per se. Rather, it uses special tables and full-text indexing within PostgreSQL, so a lot of things (like facets) are totally irrelevant for Koha. But yeah... in the end there's no one who is currently maintaining QP, as far as I know, so I wouldn't expect too much from it at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 02:43:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 01:43:04 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #9 from David Cook --- (In reply to M. de Rooy from comment #5) > Rebased a trivial merge conflict in the yaml file. > > Note that running koha qa tools on this patch produces quite some output. > And finally: > FAIL etc/searchengine/queryparser.yaml > FAIL yaml_valid > YAML Error: Inconsistent indentation level > > Moving to FQA to express need for clarification. Why are there two patches at the moment? Is one with a correct indentation level and the other is not? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 08:04:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 07:04:45 +0000 Subject: [Koha-bugs] [Bug 13258] Clicking the "show checkouts" button should return focus to the barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13258 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate --- Comment #5 from Mason James --- This needs to be backported to 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 08:07:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 07:07:42 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 --- Comment #5 from Mason James --- This needs to be backported to 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 08:11:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 07:11:01 +0000 Subject: [Koha-bugs] [Bug 13236] Regression: Table of checkouts no longer preselects overdue items for rewewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 --- Comment #5 from Mason James --- This needs to be backported to 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 08:14:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 07:14:47 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I am not sure I understand this correctly. 1) With and without the patch my staff result list for the checked out item with lost status = 1 looks the same: 2 items, 1 available: Books Midway Book Cart (1) Books 1 on loan: Computer Files Midway Book Cart (1) date due: 11/01/2015 Computer Files Should we not include the information that the item is lost somehow? Please take a look and explain! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 08:22:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 07:22:04 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|adrien.saurat at biblibre.com |jonathan.druart at biblibre.co | |m CC| |tomascohen at gmail.com --- Comment #8 from Katrin Fischer --- Does noone know how to run these tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 08:24:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 07:24:47 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #11 from Katrin Fischer --- Hi Jonathan, it looks like all dependencies are in master now, but I got problems applying this patch: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13320: Move price calculation from tt to pl fatal: sha1 information is lacking or useless (acqui/parcel.pl). Can you take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 08:40:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 07:40:53 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #7 from Zeno Tajoli --- Is this patch ready to be tested ? If yes, we need to set as "Needs sign-off" -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 08:49:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 07:49:45 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:38:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:38:02 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 --- Comment #23 from Jonathan Druart --- Tomas, This is *not* in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:38:24 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #12 from Jonathan Druart --- Bug 13001 is not in master, the status seems to be wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:44:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:44:41 +0000 Subject: [Koha-bugs] [Bug 13605] New: _AUTHOR_ not replaced in relatives checkouts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605 Bug ID: 13605 Summary: _AUTHOR_ not replaced in relatives checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In members/moremember.pl, in relatives checkouts tab, "by _AUTHOR_" appears before author. This code sould be replaced in JS. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:45:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:45:38 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 --- Comment #24 from Jonathan Druart --- Created attachment 35427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35427&action=edit Bug 13001: Refactor VAT and price calculation - parcel page Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/parcel.pl script. Test plan: 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Go on the parcel page 4/ You should see, on the "pending orders" table, the same prices as before this patch. Note that the prices are now correctly formated. You could see one change for the supplier configuration 3 (1 0): If the cost of the item is 82, discount 10% and vat 5%: The "Order cost" = 140.58 instead of 140.57. Indeed, before this patch, the order cost was wrong, now you should have 70.29*2 = 140.58 ( before: 140.58 + 7.03 = 147.61 now: 140.58 + 7.02 = 147.60 ) 5/ Receive the items and return on the parcel page Now the "Already received" table with the same prices as before this patch. Note some differences too: - There was a td tag missing, the table was badly formated, it's now fixed (column below the "Cancel receipt" link). - The prices are now correctly formated. - For the configuration 2 (1 1), if the cost of the item is 82, discount 10% and vat 5%: ( before: 140.57 + 7.03 = 147.60 now: 140.58 + 7.02 = 147.60 ) Note that 7.03 is the "correct" value, but on all other pages, 7.02 is displayed. To be consistent, we should display the same prices everywhere. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:45:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:45:41 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 --- Comment #25 from Jonathan Druart --- Created attachment 35428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35428&action=edit Bug 13001: The total for received order should be based on the unitprice For already received orders, the total should be calculated with the unitprice, not the estimated cost. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:48:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:48:31 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:48:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:48:36 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:48:58 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 --- Comment #26 from Jonathan Druart --- Conflict with bug 11944 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:58:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:58:59 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34755|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 35429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35429&action=edit Bug 13320: Move price calculation from tt to pl In parcel.tt, total are calculated for subtotal. This could be done in the pl script for more consistency. Test plan: Go on a parcel page with several already received orders. Orders must be linked to different funds. If possible ecost and unitprice (price on ordering and on receiving) should changed (different values will be displayed in the table). The values displayed before and after the patch must be the same. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:59:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:59:02 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34756|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 35430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35430&action=edit Bug 13320: Fix "Tax inc." vs "Tax exc." The parcel page always displayes "Tax exc." even when values don't include taxes. Test plan: On the parcel page, verify that the string "Tax *" is correct. This appears in the already received order table. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 09:59:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 08:59:24 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 --- Comment #15 from Jonathan Druart --- Conflicts with bug 11944 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 10:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 09:33:11 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 10:40:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 09:40:13 +0000 Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605 --- Comment #1 from Fridolin SOMERS --- Created attachment 35431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35431&action=edit Bug 13605 - _AUTHOR_ not replaced in relatives checkouts In members/moremember.pl, in relatives checkouts tab, "by _AUTHOR_" appears before author. This code sould be replaced in JS. Test plan : - Go to a borrower with relative's checkouts => without patch : you see "by _AUTHOR_" string before author name => with patch : you see "by" string before author name -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 10:40:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 09:40:26 +0000 Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 10:40:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 09:40:33 +0000 Subject: [Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 10:47:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 09:47:36 +0000 Subject: [Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #52 from Fridolin SOMERS --- I set to pushed to stable since its in 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 10:55:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 09:55:30 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35395|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 35432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35432&action=edit BUG 13596: Prevent utf8mb4 -> utf8 convertion utf8mb4 is a superset of utf8 and thus is compatible. We should not force an entire db change upon people who have proactively set utf8mb4 encoding before now. This patch also removed the deprecated use of ->tables stanza in favour of the table_info stanza. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 10:55:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 09:55:47 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 11:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 10:25:47 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 --- Comment #9 from Colin Campbell --- (In reply to Katrin Fischer from comment #8) > Does noone know how to run these tests? The only documentation is the README in the directory. I took a look ages ago but a lot of the tests have hardcoded references to a test setup on a Liblime test system. As a whole they need rewitten as part of the test suite and to handle dependencies in a reproduceable way. They arnt a test suite they are a reminder that one needs to be written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 11:34:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 10:34:55 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34981|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Comment on attachment 34981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34981 Bug 11120: Should this test fail? This is fixed by bug 13601. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 11:35:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 10:35:36 +0000 Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13601 --- Comment #26 from Jonathan Druart --- With bug 13601, the wrong date format will be correctly caught. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 11:35:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 10:35:36 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11120 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 12:28:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 11:28:01 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 --- Comment #10 from Katrin Fischer --- Ouch. What do you suggest for this bug? Should we push it to the 'reminder'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 12:36:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 11:36:03 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #8 from Jonathan Druart --- Created attachment 35433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35433&action=edit Bug 13601: Fix special case in basket.pl There is a badly managed date in acqui/basket.pl: if the date is 15/01/2015 (metric format), it will become 2015-1-15 after the following line: $estimateddeliverydate = "$year-$month-$day"; Add_Delta_Days is used at several place, and the ouput is forced to display date on 4 digits and month/day on 2 digits. This patch does the same thing for $estimateddeliverydate. Note that I previously developed a patch to take this format into account (with missing 0) in Koha::DateUtils::dt_from_string, but I don't think it's a good idea to manage bad formated dates. We will certainly find some issues after previous patches, but it will permit to catch them! IMO it's preferable than to keep them hidden. The patch was: diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm index 5fe2653..4434a67 100644 --- a/Koha/DateUtils.pm +++ b/Koha/DateUtils.pm @@ -72,17 +72,17 @@ sub dt_from_string { my $fallback_re = qr| (?\d{4}) - - (?\d{2}) + (?\d{1,2}) - - (?\d{2}) + (?\d{1,2}) |xms; if ( $date_format eq 'metric' ) { # metric format is "dd/mm/yyyy[ hh:mm:ss]" $regex = qr| - (?\d{2}) + (?\d{1,2}) / - (?\d{2}) + (?\d{1,2}) / (?\d{4}) |xms; @@ -90,9 +90,9 @@ sub dt_from_string { elsif ( $date_format eq 'us' ) { # us format is "mm/dd/yyyy[ hh:mm:ss]" $regex = qr| - (?\d{2}) + (?\d{1,2}) / - (?\d{2}) + (?\d{1,2}) / (?\d{4}) |xms; diff --git a/t/DateUtils.t b/t/DateUtils.t index 886e1d6..0877240 100755 --- a/t/DateUtils.t +++ b/t/DateUtils.t @@ -189,3 +189,8 @@ is( output_pref( { dt => $dt } ), '31/01/2015 12:34', 'dt_from_string should mat # date before 1900 $dt = dt_from_string('01/01/1900'); is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/1900', 'dt_from_string should manage date < 1900' ); + +# missing 0 +$dt = dt_from_string('1/1/2015'); +is( output_pref( { dt => $dt, dateonly => 1 } ), '01/01/2015', 'dt_from_string should generate a DT object even if 0 are missing' ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 12:37:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 11:37:12 +0000 Subject: [Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #9 from Jonathan Druart --- > display date on 4 digits and month/day on 2 digits. It was display *year* on 4 digits and month/day on 2 digits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:07:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:07:51 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22673|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:08:20 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #10 from M. de Rooy --- (In reply to David Cook from comment #9) > Why are there two patches at the moment? Is one with a correct indentation > level and the other is not? No, old one is obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:20:41 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:20:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:20:47 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35420|0 |1 is obsolete| | --- Comment #223 from M. de Rooy --- Created attachment 35434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35434&action=edit Bug 7143: Adding back version numbers Adding back version numbers to the former release team members in the list of developers. Signed-off-by: Marcel de Rooy Added prefix "3.16" to Galen's Release Maintainer. (See Roles for 3.18) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:36:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:36:05 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35404|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 35435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35435&action=edit Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. AFTER THIS PATCH: Check_Userid() get the $userid from the new parameters, or if not present, from the koha.borrowers-table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:43:42 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35435|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 35436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35436&action=edit Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. REPLICATE THE ISSUE: 1. Find a Borrower. 2. Go to the details-tab. 3. Under "Patron messaging preferences" click edit to edit just the messaging preferences. 4. Just save, no need to make any modifications. 5. Observe the error "Username/password already exists" This happens to all/most of the sub-forms in the Borrower's Details-view. AFTER THIS PATCH: Check_Userid() get the $userid from the new parameters, or if not present, from the koha.borrowers-table. TEST FOR REGRESSION: 1. Edit a borrower normally. Notice no errors. 2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:45:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:45:36 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35436|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 35437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35437&action=edit Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. REPLICATE THE ISSUE: 1. Find a Borrower. 2. Go to the details-tab. 3. Under "Patron messaging preferences" click edit to edit just the messaging preferences. 4. Just save, no need to make any modifications. 5. Observe the error "Username/password already exists" This happens to all/most of the sub-forms in the Borrower's Details-view. AFTER THIS PATCH: Check_Userid() get the $userid from the new parameters, or if not present, from the koha.borrowers-table. TEST FOR REGRESSION: 1. Edit a borrower normally. Notice no errors. 2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no errors. DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's extent without my permission. As long as it makes to Koha I am happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:48:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:48:37 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:48:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:48:40 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 --- Comment #8 from M. de Rooy --- Created attachment 35438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35438&action=edit Bug 13418: Clean C4::VirtualShelves::Page - Part 2 I don't understand at all the usefulness of $privshelflist and $privtotshelves in C4::VirtualShelves::Page They look useless. If you deep in the git history, you will find commit 25eb36f21fe952118327d2c84dfef5d38eee31a7 Bug #2531 Cannot delete private shelf I am not able to reproduce this issue after this patch Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 13:49:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 12:49:16 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35388|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:11:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:11:11 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Chris and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:12:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:12:04 +0000 Subject: [Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Thomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:13:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:13:37 +0000 Subject: [Koha-bugs] [Bug 13587] Authorized Values toolbar missing '+' Icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13587 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Abby! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:14:41 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #26 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:15:44 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:17:47 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Thomas! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:19:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:19:40 +0000 Subject: [Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:20:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:20:10 +0000 Subject: [Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:20:41 +0000 Subject: [Koha-bugs] [Bug 11345] self registration captcha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Justin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:21:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:21:31 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35350|0 |1 is obsolete| | --- Comment #224 from Tom?s Cohen Arazi --- Comment on attachment 35350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35350 [PASSED QA] Bug 7143: Adding releases to history file Patch pushed to master. Thansk Abby! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:29:05 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #5 from Tom?s Cohen Arazi --- It is not applying on master, could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:34:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:34:01 +0000 Subject: [Koha-bugs] [Bug 13606] New: Batch modification for records is limited to ~500 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Bug ID: 13606 Summary: Batch modification for records is limited to ~500 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 11395 uses the session to store the report sent to the interface (update on biblio XX OK, etc.). If the session is stored in mysql, the max size of the sessions.a_session will be reached easily (TEXT field). I found a first problem: The C4::BackgroundJob module append to the session each job information. Example for 2 jobs launched during the same session: --- _SESSION_ATIME: '1421843399' _SESSION_CTIME: '1421843222' _SESSION_ID: a5ffa813fc694706245cfe51dedc7697 _SESSION_REMOTE_ADDR: 192.168.113.2 branch: NO_LIBRARY_SET branchname: NO_LIBRARY_SET cardnumber: koha emailaddress: koha at exampe.org firstname: koha flags: 1 id: koha ip: 1.2.3.4 job_94357aff68a60dee98819f627c8a7f57: !!perl/hash:C4::BackgroundJob extra_values: messages: - biblionumber: 1 code: biblio_modified type: success - biblionumber: 2 code: biblio_modified type: success - biblionumber: 3 code: biblio_modified type: success - biblionumber: 4 code: biblio_modified type: success - biblionumber: 5 code: biblio_modified type: success report: total_records: 5 total_success: 5 view: report invoker: /cgi-bin/koha/tools/batch_record_modification.pl jobID: 94357aff68a60dee98819f627c8a7f57 name: FIXME progress: 5 results: ~ sessionID: a5ffa813fc694706245cfe51dedc7697 size: 5 status: completed job_98a251e034eec15b87027ea9c5c0a8cd: !!perl/hash:C4::BackgroundJob extra_values: messages: - biblionumber: 6 code: biblio_modified type: success - biblionumber: 7 code: biblio_modified type: success - biblionumber: 8 code: biblio_modified type: success - biblionumber: 9 code: biblio_modified type: success - biblionumber: 10 code: biblio_modified type: success report: total_records: 5 total_success: 5 view: report invoker: /cgi-bin/koha/tools/batch_record_modification.pl jobID: 98a251e034eec15b87027ea9c5c0a8cd name: FIXME progress: 5 results: ~ sessionID: a5ffa813fc694706245cfe51dedc7697 size: 5 status: completed It's useless to keep old job information. To reproduce: 1/ Create a file with 500 biblionumbers: mysql -e "select biblionumber from biblio limit 500;" | tail -n 500 > /tmp/biblionumbers.txt 2/ Define a marc modification template 3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool 4/ Repeat 3 You will get: Syck parser (line 1534, column 6): syntax error at /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75. The sessions.a_session field has reach its maximum size and the yaml stored in it is not complete and not well formed. To fix that I would like to 1/ Remove previous job information on creating a new one 2/ Increase the size of sessions.a_session from TEXT (64kb) to MEDIUMTEXT (32mb) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:34:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:34:14 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:34:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:34:45 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11395 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:34:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:34:45 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13606 --- Comment #97 from Jonathan Druart --- This is limited to 500, see bug 13606 for more information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:39:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:39:44 +0000 Subject: [Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:41:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:41:03 +0000 Subject: [Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 --- Comment #27 from Tom?s Cohen Arazi --- NOw, patches REALLY pushed to master. Sorry for that Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:42:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:42:47 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:42:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:42:49 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34152|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 35439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35439&action=edit Bug 13333: Fix Display basket group for already received orders Bug 11111 adds a basket group column on the parcel page. But it seems that the already received orders never contain the value (always 'no basket group'). Test plan: Receive an order which is in a basket group and verify the basket group column is correctly filled. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:49:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:49:07 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35192|0 |1 is obsolete| | --- Comment #225 from Tom?s Cohen Arazi --- Created attachment 35440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35440&action=edit [PASSED QA] Bug 7143: Release team 3.20 Updated the release team with the roles for 3.20 pages on the wiki and checked with the votes on the IRC meeting log. Simplified the section on Former release team members by moving that information (in a compressed format) to the Developers section. If someone had a role for multiple releases, I used constructs as 3.X. Sorted the Additional thanks-section. Signed-off-by: Justin Signed-off-by: Marcel de Rooy 2015-01-14: Amended. Replaced abbreviations like RM by Release Manager. Replaced one occurrence of 3.x by 3.X (for Owen). Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:49:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:49:28 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35194|0 |1 is obsolete| | --- Comment #226 from Tom?s Cohen Arazi --- Created attachment 35441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35441&action=edit [PASSED QA] Bug 7143: QA Follow-up for abbrev PM Replacing PM by Packaging Manager Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:49:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:49:47 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35434|0 |1 is obsolete| | --- Comment #227 from Tom?s Cohen Arazi --- Created attachment 35442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35442&action=edit [PASSED QA] Bug 7143: Adding back version numbers Adding back version numbers to the former release team members in the list of developers. Signed-off-by: Marcel de Rooy Added prefix "3.16" to Galen's Release Maintainer. (See Roles for 3.18) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:52:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:52:39 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #228 from Tom?s Cohen Arazi --- I think I'm allowed to pass this one :-D The about page is really important in the sense it is the only place where we acknowledge people's involvement in the Koha project, and I think Katrina's followup is pertinent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:53:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:53:41 +0000 Subject: [Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- For the most part the system goes like this for selecting circulation rules: If CircControl is set to "the library you are logged in at" circ rules will be selected based on the logged in branchcode If CircControl is set to "the library the patron is from" circ rules will be selected based on the patron's branchcode If CircControl is set to "the library the item is from" circ rules will be selected based on the items branchcode where HomeOrHoldingBranch chooses if items.homebranch is used or items.holdingbranch is used. Also, from my reading of master, it appears that the system preference in question is HomeOrHoldingBranch, not CircControl. That is, if IndependentBranches is enabled, and the item's branchcode does not match the logged in library branchcode ( the choosing of which is via HomeOrHoldingBranch ), the item cannot be issued ( unless you are a super-librarian ). Really, what we should do is remove the "the library the item is from" option from CircControl and add "the library that owns the item" and "the library that is holding the item" so we can remove HomeOrHoldingBranch from the circulation rules logic altogether. Then, we can identify what HomeOrHoldingBranch still does, and rename it to something more descriptive and accurate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:55:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:55:02 +0000 Subject: [Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 --- Comment #4 from Kyle M Hall --- For the most part the system goes like this for selecting circulation rules: 1) If CircControl is set to "the library you are logged in at" circ rules will be selected based on the logged in branchcode 2) If CircControl is set to "the library the patron is from" circ rules will be selected based on the patron's branchcode 3) If CircControl is set to "the library the item is from" circ rules will be selected based on the items branchcode where HomeOrHoldingBranch chooses if items.homebranch is used or items.holdingbranch is used. Also, if IndependentBranches is enabled, and the item's branchcode ( the choosing of which is via HomeOrHoldingBranch ) does not match the logged in library branchcode , the item cannot be issued ( unless you are a super-librarian ). Really, what we should do is remove the "the library the item is from" option from CircControl and add "the library that owns the item" and "the library that is holding the item" so we can remove HomeOrHoldingBranch from the circulation rules logic altogether. Then, we can identify what HomeOrHoldingBranch still does, and rename it to something more descriptive and accurate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 15:55:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 14:55:34 +0000 Subject: [Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 --- Comment #5 from Kyle M Hall --- Ignore comment 3, I rewrote it as comment 4 to make it more readable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:00:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:00:24 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 --- Comment #3 from M. de Rooy --- Created attachment 35443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35443&action=edit Bug 13536: Follow-up for adding date_due_without_time in column list This patch adds the ("virtual") column date_due_without_time to the list of available columns when editing a notice (for the issues table). Test plan: Add the column to the CHECKOUT notice. Verify that the actual notice at checkout now contains the expected data. Signed-off-by: Marcel de Rooy I also tested this by adding the field to DUE and running the overdues cron job. Note that in that case it must be included in an section. (This is a restriction imposed by the code in the overdue_notices.pl script.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:00:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:00:22 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:01:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:01:15 +0000 Subject: [Koha-bugs] [Bug 13239] MySQL Character encoding utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13239 --- Comment #3 from Tom?s Cohen Arazi --- Martin, do u plan to provide a patch for this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:02:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:02:11 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:02:12 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #229 from M. de Rooy --- (In reply to Tom?s Cohen Arazi from comment #228) > I think I'm allowed to pass this one :-D I would be happy to pass you some more numbers :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:02:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:02:18 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #2 from Jonathan Druart --- Created attachment 35445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35445&action=edit Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT The previous patch fixed partially the problem. If you try to update more that 1000 records, you will get the same error. This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb). Test plan: 1/ Try to modify a huge amount of records (1000 should be enough) 2/ Confirm it worked! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:02:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:02:14 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #1 from Jonathan Druart --- Created attachment 35444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35444&action=edit Bug 13606: Remove previous job data from the session Bug 11395 uses the session to store the report sent to the interface (update on biblio XX OK, etc.). If the session is stored in mysql, the max size of the sessions.a_session will be reached easily (TEXT field). To reproduce: 0/ Set SessionStorage to 'mysql' 1/ Create a file with 500 biblionumbers: mysql -e "select biblionumber from biblio limit 500;" | tail -n 500 > /tmp/biblionumbers.txt 2/ Define a marc modification template (something like "delete field 99$9" is nice) 3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool 4/ Repeat 3 You will get: Syck parser (line 1534, column 6): syntax error at /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75. None Koha page is reachable. It comes from get_template_and_user > checkauth > get_session > l.1595 $session = new CGI::Session("driver:MySQL;serializer:yaml;id:md5", $sessionID, {Handle=>$dbh}); 5/ Get your sessionID contained in your CGISESSID cookie Have a look at the value a_session in the sessions table: mysql> select a_session from sessions where id="YOUR_SESSIONID"; You should see that the yaml is not correctly ended. The size of the DB field has been reached and the yaml is truncated. Test plan: 0/ Delete your CGISESSID cookie 1/ Try to reproduce the previous issue 2/ After the second batch, have a look at the sessions table and confirm that only one job_$JOB_ID exist in the yaml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:03:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:03:03 +0000 Subject: [Koha-bugs] [Bug 10601] Add a counter on batch items modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13606 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:03:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:03:03 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10601 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:05:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:05:03 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 --- Comment #4 from M. de Rooy --- (In reply to Aleisha Amohia from comment #2) > Can't see <> to replace <> > when editing the notice - setting to Failed QA Thanks, Aleisha for testing. Hopefully, you still have the time to check the follow-up .. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:07:36 +0000 Subject: [Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 --- Comment #6 from Nicole C. Engard --- I updated the manual (changes will be available tomorrow) to note these differences - please let me know if I should edit them: http://manual.koha-community.org/3.18/en/administration.html#CircControl http://manual.koha-community.org/3.18/en/administration.html#HomeOrHoldingBranch http://manual.koha-community.org/3.18/en/patscirc.html#circfinerules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 16:41:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 15:41:39 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #77 from M. de Rooy --- (In reply to Jonathan Druart from comment #75) > I rebased this patch manually (using git apply --reject) and recreated the > patch. > Note that I did *not* test it! Thanks for doing so. I would be interested too in seeing this get further. The current patch suggest that Kyle wrote it and Maxime signed off. Could you add a comment about your rebase; I assume that it was not a trivial one? Of course, it would be great if you also tested [as second author]. This feature cannot be tested enough in a part of Koha (circulation/holds) that is sensible to bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:25:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:25:28 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #27 from Fridolin SOMERS --- Created attachment 35446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35446&action=edit Bug 11927 - Add greek support to CHR (followup) Small error in word-phrase-utf.chr. It generates this logs : 17:03:25-21/01 zebraidx(10636) [warn] Map: '?' has no mapping 17:03:25-21/01 zebraidx(10636) [warn] duplicate entry for charmap from '?' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:27:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:27:31 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #28 from Fridolin SOMERS --- last patch needs SO. It should fix UT t/db_dependant/Search.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:27:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:27:41 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:38:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:38:27 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #8 from Olli-Antti Kivilahti --- Zeno, this feature is ready to be tested regarding the patches I made, but this is still missing a lot more message types. I need to take a look at our acquisitions department as they report severe slowdowns in the acquisitions process (and a ton of stuff) so I'll let you sign off these if you want. But followups need to be provided for the other message_types. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:39:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:39:12 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #9 from Olli-Antti Kivilahti --- But I feel like this is a good start for improving on this feature. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:41:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:41:35 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 --- Comment #7 from Martin Renvoize --- Test Plan This patch is all about plumbing.. basically having a working SIP server config before the patches, should work exactly the same after a service restart after the patches :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:44:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:44:46 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #189 from Paola Rossi --- Thanks, Jonathan. I've applied the [13] patches against master 3.19.00.006 head 13526 (!). As required in comment 172 [but I think that this step could also be added to the test plan in comment 171] - try filters on columns. a particular problem arose on FILTERING. See below. Moreover, being this patch closely related to authorized values and categories, I was in doubt about the displaying of the branch-limited additional values, as it is described by 3.18 manual. I've provided a possible "solution". Please see all in the NB.1 below. I think that on FILTERING there can be an error. For now I pass the patch in the "Failed QA" status. If FILTERING is not an error, and displaying AV is not a problem, and no other follow up is needed, I can sign off this patch attaching the 13 patches as usual. ---- FILTERING RIGHT: Some subscriptions had "periodicals" in a field of theirs. I've selected all of them in some way. Filtering by "perioa" at once no subscription was expected to be selected. It happened in 1 second (RIGHT) [subscriptions disappeared] I cancelled all the filter value: all those subscriptions were expected to be selected. It happened in 1 second (RIGHT) [subscriptions appeared again] [Now there was no filter value] Filtering by "perio?" at once [CTRL v] no subscription were expected to selected. It happened in 1 second (RIGHT). RIGHT "Incremental" filtering: Filtering by "perio" at once all those subscriptions were expected to be selected. It happened (RIGHT): nothing changed in the table. I added "a" at the right of the value, so I was "incrementally" filtering by "perioa". No subscription were expected to selected. It happened in 1 second (RIGHT). ERROR: "Incremental" filtering by adding diacritics exited in ERROR: Some subscriptions had "periodicals" in a field of theirs. I've selected all of them in some way. Filtering by "perio" all subscriptions were filtered (OK, like above RIGHT). I added "?" at the right of the value, so I was "incrementally" filtering by "perio?". No limitation happened in the resulting table in 30 seconds (ERROR). After 30 sec, I added "?" at the right of the value, so I was "incrementally" filtering by "perio??". No limitation happened in the resulting table in 30 seconds (ERROR). This error didn't happened adding "incrementally" to "perio": a Japanese (?) char, a number, a Greek (?) char. This error occurred either on searching subscriptions' table or on serials claims' one. ---- FILTERING's ERROR END NB1. A special case of authorized values is about categories with branches-limited AV. See: At point 232, [3.18] manual says about their setting: "If you would like to limit this authorized value category to only specific libraries you can choose them from the 'Branches limitation' menu. To have it show for all libraries just choose 'All branches' at the top of the list." This patch's behaviour about the branches-limited AVs was OK (RIGHT). At my tests, patch is OK [=as plan require] on a category whose AVs are all branch-limited, and also on a category whose AVs are a mixture of limited and not-limited. As desired and required by this patch's test plans: branches-limited AV are displayed on viewing a subscription, (subscription-detail.pl) (B) categories names [not the limited AVs' drop down list, like manual says] are shown on editing a subscription (subscription-add.pl) branches-limited AV are all displayed in the resulting tables, branches-limited AV are all "filter-able" in the resulting tables, (A) categories names [not the limited AVs' drop down list, like manual says] are shown among search fields on the left on searching subscriptions. IMO these branches-limited AV could also be displayed in the (A) drop down list (A), to be available to the selecting user. Assigning an attribute is not modifying/adding a value to a category. So IMO the (B) drop down list could also be shown. In simple terms the limit in 3.18 manual would be updated from: "To have it show" to: "A branch-limited AV is always shown to all libraries. To have it added and modified" Otherwise, if the current manual prevales, the part of this patch requiring to "show" AdVs could need to be reviewed. [Or Additional Values are not exactly a kind of Authorized Values.] Anyway, now this sentence of the manual: "If you would like to limit this authorized value category to only specific libraries you can choose them from the 'Branches limitation' menu." appears a little generic to me, not enough to let understand the "limit". The sentence could also be changed into: "If you would like to limit this authorized value to only specific libraries [...]" because each AuV can be "limited". NB2. This patch is closely related to authorized values&categories [adding/modifying]. http://manual.koha-community.org/3.18/en/basicparams.html#authorizedvalues point 232: "Limit your Category to 10 characters (something short to make it clear what the category is for)" The user of this enhancement 10855 would probably be interested in using more than 10 chars. This manual's warning limit might be increased. ------------------------------------------------ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:56:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:56:24 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33057|0 |1 is obsolete| | Attachment #33400|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 35447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35447&action=edit [SIGNED-OFF] Bug 7904 Change SIP modules to use standard LIB path For historical reasons the SIPServer and SIP modules have used an extra module path in addition to the standard Koha one. This has caused numerous irritants in attempting to set up scripts and basic tests. It does not help in attempting to modify or debug this code This patch changes the package value in the modules under the C4/SIP directory and makes calls to them use the full package name. Where the export mechanism was being short circuited routines have been explicitly exported and imported declarations of 'use ILS' when that module was not being used and which only generated warnings have been removed. As a lot of the changes affect lines where an object is instantiated with new. The opportunity has been taken to replace the ambiguous indirect syntax with the preferred direct call In intializing ILS the full path is added as this will not require any changes to existing configs. I suspect this feature is unused, and adds obfuscation rather than flexibility but have kept the feature as we need this change in order to rationalize and extend the testing of the server. The visible difference is that with the normal Koha PERL5LIB setting. Compilation of Modules under C4/SIP should be successful and not fail with unlocated modules, allowing developers to see any perl warnings All the SIP modules can now be run through the tests in t/00-load.t now except for SIPServer itself Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:56:22 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:56:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:56:32 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 --- Comment #9 from Kyle M Hall --- Created attachment 35448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35448&action=edit [SIGNED-OFF] Bug 7904 - remove unnecessary path from SIP script With the fixing of the namespace in the SIP code, we don't need to modify the PERL5LIB to have the old one. To test: * do a package install using this and the other patches on bug 7904 * enable SIP * make sure koha-start-sip and koha-stop-sip work Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 17:57:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 16:57:44 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Tested by launching sip server with just ./C4/SIP/SIPServer.pm /path/to/SIPconfig.xml Used sip_cli_emulator to make some SIP requests, everything looks good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 18:03:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 17:03:26 +0000 Subject: [Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35447|0 |1 is obsolete| | --- Comment #11 from Colin Campbell --- Created attachment 35449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35449&action=edit Rebase main path rebased original patch against current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 19:22:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 18:22:23 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 19:22:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 18:22:26 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35409|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 35450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35450&action=edit [SIGNED-OFF] Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment The hbyymmincr autoBarcode builder looks up all barcodes that begin with any number of letters ( the branchcode ) and a two-digit year directly afterward ( e.g. MPL15 ), then grabs the last four digits as the increment counter. The problem is, this does not take months into account, so unlike the description that says the system is limited to 10,000 items a month, it is limited to 10,000 items per *year*. This situation can easily be corrected my adding the month into the lookup ( e.g. MPL1501 ). Test Plan: 1) Enable autoBarcode, set to hbyymmincr 2) Catalog an item, let the barcode.pl plugin generate the next barcode. 3) Catalog an item with the barcode MPL15009999 4) Catalog another item, use the barcode.pl plugin to generate the next barcode. 5) Note the barcode is generated ends with '0001' instead of the correct increment 6) Apply this patch 7) Repeat step 4 8) Note the barcode now ends with the correct increment Signed-off-by: Kyle M Hall Signed-off-by: Jeanne Heicher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 20:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 19:48:27 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35093|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia --- Created attachment 35451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35451&action=edit Bug 5144 [4] [QA Followup] - Fix message error and language used Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 20:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 19:48:23 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 21:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 20:22:28 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #50 from Ahmed Sfayhi --- Created attachment 35452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35452&action=edit Bug 10937 - Grouped ItemTypes - Patch should apply properly on latest master. This allows to group certain item types in a category, to be displayed (and searched) as such in OPAC's advanced search. For example, you can group Reserve 2h and Reserve 12h into a Reserve category. The 2 and 12h types won't appear anymore. This also allows to simply prevent an item type from displaying as a search option. TEST PLAN ------------------ 0) Back up database, so you can reset and retest easily. ;) 1) Apply the patch 2) Run Koha QA tool. 3) prove -v t/db_dependent/Koha.t -- all tests should pass. 4) run ./installer/data/mysql/updatedatabase.pl to add the two columns to itemtypes -- Does a meaningful message get printed? Are the columns added? "DESCRIBE itemtypes;" should list hideinopac and searchcategory. 5) You need to add a category to group your item types: a) In Intranet/Koha Admin/Authorized values, select DOCTYPECAT in the 'Show category:' dropdown i) If you do not have a DOCTYPECAT category, create one. b) Click button "New authorized value for DOCTYPECAT" c) Enter Authorized value: HARDWARE Description : Hardware Description (OPAC): Hardware 6) Group your items under that new category a) In Intranet/Koha Admin/Item types, choose (at least) two item types and for each: - Click action/Edit on the right column - Third row (below Description) is the Search category list box, select Hardware - click Save changes at the bottom 7) Select at least one item to be hidden in the OPAC search a) In Intranet/Koha Admin/Item types (again), choose a different item type: - Click action/Edit - Click the checkbox "Hide in OPAC" below the list of icons. 8) Go test your modifications a) Go to OPAC/Adv search. b) Validate that all items modified above (hidden or grouped) do not appear in Item type list c) Validate that new item type Hardware does appear instead. d) Select item Hardware, start Search. ) Validate returned items are the of the two types that were grouped into the Hardware category in step 4. Sponsored-by: Vanier college -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 21:25:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 20:25:11 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Ahmed Sfayhi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |ahmed.sfayhi at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 21:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 20:25:30 +0000 Subject: [Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055 Ahmed Sfayhi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahmed.sfayhi at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 21:26:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 20:26:21 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Ahmed Sfayhi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahmed.sfayhi at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 22:24:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 21:24:17 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 22:24:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 21:24:21 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35443|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 35453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35453&action=edit Bug 13536: Follow-up for adding date_due_without_time in column list This patch adds the ("virtual") column date_due_without_time to the list of available columns when editing a notice (for the issues table). Test plan: Add the column to the CHECKOUT notice. Verify that the actual notice at checkout now contains the expected data. Signed-off-by: Marcel de Rooy I also tested this by adding the field to DUE and running the overdues cron job. Note that in that case it must be included in an section. (This is a restriction imposed by the code in the overdue_notices.pl script.) Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 23:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 22:04:01 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 23:41:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 22:41:17 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34959|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 35454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35454&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl Test Plan: 1) Apply this patch 2) Find a waiting hold 3) Browse to reserve/request.pl for that record 4) Notice the "Item waiting" message now has "since " Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 21 23:41:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 22:41:14 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 00:12:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 23:12:42 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #29 from Robin Sheat --- (In reply to Manos PETRIDIS from comment #25) > Will the option to use "gr" as "Primary language for Zebra indexing" be > available to current (package) installations when they are upgraded to > versions incorporating Bug 11927? > I understand there is no such system preference and any changes will have to > be applied manually. It's already available: --zebralang lang Choose the primary language for Zebra indexing. Valid values are en (default), es, fr, gr, nb, ru and uk. assuming that's the same as what you're talking about. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 00:17:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 23:17:00 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #23 from Robin Sheat --- (In reply to Jonathan Druart from comment #21) > $ perl misc/search_tools/rebuild_elastic_search.pl -h > Can't locate Elasticsearch.pm in @INC (you may need to install the > Elasticsearch module) (@INC contains: blablabla) > > $ apt-cache search elasticsearch | grep perl > libcatmandu-perl - metadata toolkit In comment #6 I added a link to the dependencies needed. It's a bit old now, I've been working on making some new ones, but that archive may still work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 00:30:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Jan 2015 23:30:47 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Aleisha Amohia --- Tried to test but got the following errors when applying patch it depends on from Bug 10212: Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt CONFLICT (add/add): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc CONFLICT (add/add): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc Auto-merging admin/columns_settings.yml CONFLICT (add/add): Merge conflict in admin/columns_settings.yml Auto-merging C4/Utils/DataTables/ColumnsSettings.pm CONFLICT (add/add): Merge conflict in C4/Utils/DataTables/ColumnsSettings.pm Failed to merge in the changes. Patch failed at 0001 Bug 10212: Columns configuration for tables Setting to Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 02:00:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 01:00:56 +0000 Subject: [Koha-bugs] [Bug 13607] New: Patron management API Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Bug ID: 13607 Summary: Patron management API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Koha needs an API that allows creation, updating, and deleting of patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 02:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 01:01:04 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 02:32:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 01:32:23 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 --- Comment #1 from Robin Sheat --- Created attachment 35455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35455&action=edit Bug 13607: patron management API This provides a patron management API. It allows a remote service to: * add patrons * update patron details * delete patrons It presents a simple POST-based API and returns its results as XML. This API supports fields available in the borrower table, and extended attribute types also. Full documentation will be on a wiki page linked to from the bug. To test: * construct a sequence of API requests, make sure it works. * ensure that no side effects of these changes came about, particularly dealing with unrelated things (default_messageprefs.pl, sco-patron-image.pl, systempreferences.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 02:38:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 01:38:22 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 02:52:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 01:52:52 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Robin Sheat --- Documentation of the API is currently here: http://wiki.koha-community.org/wiki/Talk:Koha_/svc/_HTTP_API#Patron_Management_API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 06:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 05:43:58 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 06:45:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 05:45:44 +0000 Subject: [Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 06:46:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 05:46:35 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #19 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 09:19:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 08:19:56 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Hi Robin, Did you have a look at koha-restful? It seems it does the same job as this patch. https://git.biblibre.com/biblibre/koha-restful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 10:01:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 09:01:23 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Jonathan Druart --- Hi Aleisha, bug 10212 is already pushed to master, you don't need to apply it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 10:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 09:02:29 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Hi Robin, A much needed feature.. but I'm not 100% I agree with the implementation. I think we should really be attempting to follow restful best practice. Personally, I would: Use POST for the create operation only Use PUT for the update operation (possibly with your current implementation in here 'update or create' use DELETE for the delete operation only use GET for retrieving patron records use json (or xml) bodies to actually move the data around.. The above would bring us much more in line with the rest of the modern world. Parsing XML is hard in the browser, and such an API should be designed for maximum flexibility, i.e to be simply used in as many environments as possible.. including the browser. Anywho.. If I get the time, I might submit an alternative patch.. if not I'll go ahead and test this.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 10:05:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 09:05:56 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 --- Comment #5 from Martin Renvoize --- Also... have you seen Jesse's work on Koha::Service? https://github.com/pianohacker/koha/commit/40908d6e58c40e6ffaa488266a70ef5233fe9642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 11:23:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 10:23:54 +0000 Subject: [Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #5 from Olli-Antti Kivilahti --- Beating the dead horse... I am sorry but I have to agree with Jonathan and Katrin here. We should teach our librarians to use the browser properly, instead of trying to programmatically fix user errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 11:54:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 10:54:57 +0000 Subject: [Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 12:29:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 11:29:32 +0000 Subject: [Koha-bugs] [Bug 13608] New: Displaying parcel.pl is inefficient when lots of orders for a bookseller/vendor Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13608 Bug ID: 13608 Summary: Displaying parcel.pl is inefficient when lots of orders for a bookseller/vendor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org In the acqui/parcel.pl-view: When you have 2752 orderlines waiting for receiving and 178 received orderlines for a bookseller, loading the page takes 15s. this is problematic when receiving lots of items. Workaround is to effectively avoid loading the parcel.pl by opening pages into new tabs. This view desperately needs optimization. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 12:36:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 11:36:34 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #4 from Benjamin Rokseth --- Created attachment 35456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35456&action=edit Bug 13523 - AddBiblio fails on mysql with STRICT_TRANS_TABLES This patch removes the NOT NULL restriction on biblioitems.marcxml and deletedbiblioitems.marcxml due to STRICT_TRANS_TABLES default in Mysql 5.6.22 and onwards. Test: 1. check mysql global settings: mysql > SELECT @@GLOBAL.sql_mode; verify that STRICT_TRANS_TABLES is not set 2. set STRICT_TRANS_TABLES (or upgrade mysql to > 5.6.21) mysql > SET @@GLOBAL.sql_mode = 'STRICT_TRANS_TABLES'; 3. try to add biblio in Cataloguing module verify that it fails with a "software error" 4. apply patch 5. repeat 3 and verify that there is no "software error" any more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 12:37:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 11:37:16 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 12:38:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 11:38:42 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 --- Comment #6 from Robin Sheat --- (In reply to Jonathan Druart from comment #3) > Hi Robin, > Did you have a look at koha-restful? > It seems it does the same job as this patch. > > https://git.biblibre.com/biblibre/koha-restful I didn't because I didn't see it in koha, so I didn't really know it existed or what it could do. (In reply to Martin Renvoize from comment #4) > Use POST for the create operation only > Use PUT for the update operation (possibly with your current implementation > in here 'update or create' You don't always know if you're creating or updating from a membership management system thing. Hence upsert. Which is a word, look in wikipedia :) > use DELETE for the delete operation only > use GET for retrieving patron records > use json (or xml) bodies to actually move the data around.. Some of these verbs are (I think, though I haven't checked) harder to use from a browser. > The above would bring us much more in line with the rest of the modern > world. Parsing XML is hard in the browser, and such an API should be > designed for maximum flexibility, i.e to be simply used in as many > environments as possible.. including the browser. a) if you use things like DELETE and PUT, IIRC they're hard to use from a browser (I might be wrong, that used the be the case though), b) with the changes I added to C4::Service you can add switching to JSON easily ... but then you still need XML to authenticate. It's silly to mix technologies like that (even though they are already mixed, at least you can do user management using all one thing), c) the intention of this isn't really to work from a browser, but to add integration to things like salesforce that manage users. (In reply to Martin Renvoize from comment #5) > Also... have you seen Jesse's work on Koha::Service? > > https://github.com/pianohacker/koha/commit/ > 40908d6e58c40e6ffaa488266a70ef5233fe9642 I hadn't, again, it's not in Koha so I didn't know it existed. At a (very quick) glance, it looks to be a definite improvement over the original C4::Service, but as it is, too much stuff is being crammed into C4::Service. My first impression of that is that it needs to be split up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:12:40 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35163|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 35457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35457&action=edit Bug 13159 - Enhancements to the SIP2 command line emulator I needed to be able to perform checkout operations for testing from the command line. I ended up reengineering the SIP2 command line tester quite a bit. Enhancements: * Moved message generation code to subroutines * Added support for more messages * Added command line switches for each supported message * Enabled use of Sip::Constants to keep code DRY and more understandable * Moved script from misc to C4/SIP * Designed with an eye towards possibly moving some code to CPAN in the future * Also designed to make adding new messages much easier in the future Test Plan: 1) Apply this patch 2) Look at help via ./C4/SIP/sip_cli_emulator.pl --help 3) Test patron status request and patron information, should work as before except you need to pass the command line switche -m 4) Test the new checkout option using -m checkout -i -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:17:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:17:37 +0000 Subject: [Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #29 from Jonathan Druart --- Comment on attachment 32502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32502 Bug 13084 [Master] - QA Followup - Use DBIx::Class to simplify logic This patch breaks misc/cronjob/delete_patrons.pl on debian squeeze, and maybe other things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:21:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:21:35 +0000 Subject: [Koha-bugs] [Bug 13610] New: delete_patrons.pl crashes on debian squeeze Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13610 Bug ID: 13610 Summary: delete_patrons.pl crashes on debian squeeze Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org $ perl misc/cronjobs/delete_patrons.pl -c Failed to delete patron 42, error handling its lists: (DBD::mysql::db do failed: MySQL server has gone away at /home/koha/src/C4/VirtualShelves.pm line 651. ) $ perl -v This is perl, v5.10.1 (*) built for x86_64-linux-gnu-thread-multi $ more /etc/debian_version 6.0.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:24:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:24:01 +0000 Subject: [Koha-bugs] [Bug 13610] delete_patrons.pl crashes on debian squeeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13610 --- Comment #1 from Jonathan Druart --- Created attachment 35458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35458&action=edit Simple script to reproduce the issue koha at test1-sandbox:~/src$ perl mysql_has_gone_away.pl Failed to delete patron 999999999999, error handling its lists: (DBD::mysql::db do failed: MySQL server has gone away at /home/koha/src/C4/VirtualShelves.pm line 651. ) ROLLBACK DBD::mysql::db rollback failed: MySQL server has gone away at mysql_has_gone_away.pl line 33. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:25:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:25:37 +0000 Subject: [Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13610 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:25:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:25:37 +0000 Subject: [Koha-bugs] [Bug 13610] delete_patrons.pl crashes on debian squeeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13084 --- Comment #2 from Jonathan Druart --- $ git show b95617ec9eb62d3b4b9b2b97848b3efd7d207fb6 commit b95617ec9eb62d3b4b9b2b97848b3efd7d207fb6 Author: Kyle M Hall Date: Fri Oct 17 07:52:13 2014 -0400 Bug 13084 [Master] - QA Followup - Use DBIx::Class to simplify logic Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi diff --git a/C4/Members.pm b/C4/Members.pm index da8dfaf..0978078 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -1814,28 +1814,16 @@ The routine returns 1 for success, undef for failure. sub MoveMemberToDeleted { my ($member) = shift or return; - my $dbh = C4::Context->dbh; - my $query = qq|SELECT * - FROM borrowers - WHERE borrowernumber=?|; - my $sth = $dbh->prepare($query); - $sth->execute($member); - my $data = $sth->fetchrow_hashref; - return if !$data; # probably bad borrowernumber - - #now construct a insert query that does not depend on the same order of - #columns in borrowers and deletedborrowers (see BZ 13084) - my $insertq = "INSERT INTO deletedborrowers ("; - my @values; - foreach my $key ( keys %$data ) { - $insertq.= $key.","; - push @values, $data->{$key}; - } - $insertq =~ s/,$//; #remove last comma - $insertq .= ") VALUES (" . ( "?," x ( scalar(@values) - 1 ) ) . "?)"; - $sth = $dbh->prepare( $insertq ); - $sth->execute(@values); - return $sth->err? undef: 1; + + my $schema = Koha::Database->new()->schema(); + my $borrowers_rs = $schema->resultset('Borrower'); + $borrowers_rs->result_class('DBIx::Class::ResultClass::HashRefInflator'); + my $borrower = $borrowers_rs->find($member); + return unless $borrower; + + my $deleted = $schema->resultset('Deletedborrower')->create($borrower); + + return $deleted ? 1 : undef; } =head2 DelMember $ git revert b95617ec9eb62d3b4b9b2b97848b3efd7d207fb6 $ perl mysql_has_gone_away.pl No error! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:30:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:30:41 +0000 Subject: [Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #30 from Jonathan Druart --- RMaints, be care, don't backport this! Or at least without the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:38:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:38:59 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 --- Comment #11 from Colin Campbell --- (In reply to Katrin Fischer from comment #10) > Ouch. What do you suggest for this bug? Should we push it to the 'reminder'? The patch makes logical sense. The problem is as it appears noone runs these tests regularly, noone is confident about verifying it. No problem with it, we must assume Adrien did run these to find the problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:53:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:53:03 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 --- Comment #7 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 13:54:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 12:54:37 +0000 Subject: [Koha-bugs] [Bug 13610] delete_patrons.pl crashes on debian squeeze In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13610 --- Comment #3 from Jonathan Druart --- Created attachment 35459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35459&action=edit Even more simplistic script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:02:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:02:23 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24984|0 |1 is obsolete| | Attachment #24985|0 |1 is obsolete| | Attachment #25840|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 35460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35460&action=edit Bug 11625 - Default to logged in library for circ rules and notices & slips This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes QA script and tests. Small ergonomic improvement, no regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:02:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:02:33 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #21 from Kyle M Hall --- Created attachment 35461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35461&action=edit Bug 11625 [QA Followup] - Default to logged in library for circ rules and notices & slips Signed-off-by: Katrin Fischer Fixes the case that someone logs in as database user and changes circulation rules without explicitly selecting a library first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:02:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:02:36 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #22 from Kyle M Hall --- Created attachment 35462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35462&action=edit Bug 11625 [QA Followup 2] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:41:11 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #23 from Kyle M Hall --- Created attachment 35463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35463&action=edit Bug 11625 [QA Followup 3] - Use system preferences to control behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:46:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:46:10 +0000 Subject: [Koha-bugs] [Bug 13236] Regression: Table of checkouts no longer preselects overdue items for rewewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 --- Comment #6 from Mason James --- (In reply to Mason James from comment #5) > This needs to be backported to 3.16.x Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:47:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:47:11 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #24 from Kyle M Hall --- I don't think we'll ever get consensus on this, so I think the best way to move forward is to make this behavior controlled via system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:51:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:51:56 +0000 Subject: [Koha-bugs] [Bug 13611] New: Serial enumeration not visible in the opac-user.pl when browsing own holds. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611 Bug ID: 13611 Summary: Serial enumeration not visible in the opac-user.pl when browsing own holds. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Having placed holds on Serial Items with an enumchron, and browsing the opac-user.pl's "Holds"-tab, the user cannot see which numbers of magazines/serials he has on hold. This patch appends the koha.items.enumchron after the title component in the opac-user.pl's Holds-view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:52:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:52:29 +0000 Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the opac-user.pl when browsing own holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13430 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:52:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:52:29 +0000 Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13611 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:53:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:53:23 +0000 Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the opac-user.pl when browsing own holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 35465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35465&action=edit Bug 13611 - Serial enumeration not visible in the opac-user.pl when browsing own holds. Having placed holds on Serial Items with an enumchron, and browsing the opac-user.pl's "Holds"-tab, the user cannot see which numbers of magazines/serials he has on hold. This patch appends the koha.items.enumchron after the title component in the opac-user.pl's Holds-view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:57:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:57:04 +0000 Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the opac-user.pl when browsing own holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 14:58:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 13:58:31 +0000 Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the opac-user.pl when browsing own holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611 --- Comment #2 from Olli-Antti Kivilahti --- BTW: This is based on the following user feedback: Hei! T?h?n menness? olen antanut t?ydet 10 pistett? varaus systeemillenne, mutta nyt pit?? pudottaa neloseen aikakauslehtien osalta. Miksi siit? on tehty niin monipolvinen ja aikaa viep? toimenpide? Ohjeenne etusivulla ei ole kovinkummoinen, koska minunkin piti k?yd? kysym?ss? sit? kahdelta virkailijalta. Ohjeeseen voitte ottaa oppia esim Digikuva-lehden osiosta, jossa kuvank?sittely? opetetaan porras portaalta kaapatuilla n?ytt?kuvilla. Varausluettelossa ei my?sk??n en?? n?y lehden numeroa. Kyll? t?m? nyt minulta sujuu, mutta saattaapa olla v?hemm?n tietokoneeen n?pyttelyyn perehtyneit?, joilta tilaus ei synny, eiv?tk? kehtaa pyyt?? apua. Ei uusien tekniikoiden k?ytt??notto v?ltt?m?tt? tarvitse merkit? askelta taaksep?in jollakin osa-alueella. Toinen asia on se, ett? viel?k??n ei ole mahdollisuutta saada tietoa kirjaston uutuushankinnoista, kuten edellisess? systeemiss?. Onko tulossa parannusta, vai pit??k? jatkossakin selailla kirjakauppojen luetteloita josko jotain mielenkiintoista l?ytyisi? Muuten min? olen ihan mahdottoman tyytyv?inen. Happy translating! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 15:07:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 14:07:05 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25347|0 |1 is obsolete| | Attachment #25842|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 35466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35466&action=edit Bug 11747 - Default to logged in library for Overdue notice/status triggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart This behavior is consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 15:07:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 14:07:19 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 --- Comment #9 from Kyle M Hall --- Created attachment 35467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35467&action=edit Bug 11747 [QA Followup] - Don't default to branch specific rules if only one branch exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 15:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 14:07:22 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 --- Comment #10 from Kyle M Hall --- Created attachment 35468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35468&action=edit Bug 11747 [QA Followup 2] - Use system preference to control behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 15:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 14:07:38 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #11 from Kyle M Hall --- I don't think we'll ever get consensus on this, so I think the best way to move forward is to make this behavior controlled via system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 15:21:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 14:21:36 +0000 Subject: [Koha-bugs] [Bug 13612] New: Remove old YUI javacript libraries from opac-tmpl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Bug ID: 13612 Summary: Remove old YUI javacript libraries from opac-tmpl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org After checking with Owen it appears that the opac-tmpl/lib/yui directory can be removed now that we only support Bootstrap OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 15:28:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 14:28:41 +0000 Subject: [Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #6 from Owen Leonard --- If clicking a link results in the unexpected loss of state when the user is in the process of entering data I would call that a problem. I think it's a pretty well established pattern that if you doing something like filling out a form on a shopping site's checkout page and there is a link to something like privacy policy or terms of service that clicking the link will open in a new window, tab, or modal view. If this situation is similar, then it requires a similar solution. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 15:28:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 14:28:52 +0000 Subject: [Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 16:01:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 15:01:28 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #24 from Jonathan Druart --- Back here, $ mkdir catmandu-deps $ cd catmandu-deps $ wget www.kallisti.net.nz/~robin/catmandu-deps.tar.gz $ tar zxvf catmandu-deps.tar.gz $ sudo dpkg -i *.deb I got some dpkg: warning: downgrading $package from $version_a+ to $version_a And it finished with: dpkg: dependency problems prevent configuration of libdata-messagepack-perl: libdata-messagepack-perl depends on perlapi-5.18.2; however: Package perlapi-5.18.2 is not installed. dpkg: error processing package libdata-messagepack-perl (--install): dependency problems - leaving unconfigured Setting up libdata-spreadpagination-perl (0.1.2-1) ... Setting up libdispatch-class-perl (0.01-1) ... Setting up libelasticsearch-perl (1.04-1) ... Setting up libhijk-perl (0.13-1) ... Setting up libhttp-tiny-perl (0.043-1) ... Setting up libjson-maybexs-perl (1.002002-1) ... Setting up liblog-any-adapter-callback-perl (0.07-1) ... dpkg: dependency problems prevent configuration of libmarpa-r2-perl: libmarpa-r2-perl depends on perlapi-5.18.2; however: Package perlapi-5.18.2 is not installed. dpkg: error processing package libmarpa-r2-perl (--install): dependency problems - leaving unconfigured Setting up libmoox-log-any-perl (0.001-1) ... Setting up libsearch-elasticsearch-perl (1.11-1) ... Setting up libtry-tiny-byclass-perl (0.01-1) ... Setting up libyaml-perl (0.90-1) ... dpkg: dependency problems prevent configuration of libcatmandu-perl: libcatmandu-perl depends on libmarpa-r2-perl (>= 2.084000); however: Package libmarpa-r2-perl is not configured yet. dpkg: error processing package libcatmandu-perl (--install): dependency problems - leaving unconfigured dpkg: dependency problems prevent configuration of libcatmandu-store-elasticsearch-perl: libcatmandu-store-elasticsearch-perl depends on libcatmandu-perl (>= 0.8); however: Package libcatmandu-perl is not configured yet. dpkg: error processing package libcatmandu-store-elasticsearch-perl (--install): dependency problems - leaving unconfigured Setting up libelasticsearch-compat-perl (0.03-1) ... Setting up libsearch-elasticsearch-compat-perl (0.10-1) ... dpkg: dependency problems prevent configuration of libcatmandu-marc-perl: libcatmandu-marc-perl depends on libcatmandu-perl (>= 0.08); however: Package libcatmandu-perl is not configured yet. dpkg: error processing package libcatmandu-marc-perl (--install): dependency problems - leaving unconfigured Processing triggers for man-db (2.6.7.1-1) ... Errors were encountered while processing: libdata-messagepack-perl libmarpa-r2-perl libcatmandu-perl libcatmandu-store-elasticsearch-perl libcatmandu-marc-perl Note: libossp-uuid-perl was missing, I installed it. I have perl v.5.20 installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 16:22:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 15:22:50 +0000 Subject: [Koha-bugs] [Bug 13607] Patron management API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 16:45:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 15:45:24 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #190 from Jonathan Druart --- (In reply to Paola Rossi from comment #189) Hello Paola, Thanks for this complete feedback :) > ---- FILTERING > No limitation happened in the resulting table in 30 seconds (ERROR). > After 30 sec, I added "?" at the right of the value, so I was > "incrementally" filtering by "perio??". > No limitation happened in the resulting table in 30 seconds (ERROR). 1 sec should be enough, the results are filtered on client-side. I am sorry but I don't reproduce your problem. On the serial claims page (but tested also on the serials result page), I have 10 subscriptions, 3 of them have "Psychologies" as a value of an additional field named "test?". If I enter "Psycho" in the filter, I got the 3 (OK). If I enter "Psycho?", "Psycho?" or whatever different of "Psychol", the table displays no result. ---- NB1 > (A) categories names [not the limited AVs' drop down list, like manual says] > are shown among search fields on the left on searching subscriptions. > > IMO these branches-limited AV could also be displayed in the (A) drop down > list (A), to be available to the selecting user. > Assigning an attribute is not modifying/adding a value to a category. So IMO > the (B) drop down list could also be shown. > In simple terms the limit in 3.18 manual would be updated from: > "To have it show" > to: > "A branch-limited AV is always shown to all libraries. To have it added and > modified" Yes, I see what you meant. I don't really know what is the behavior to have here, I would prefer to wait for the QA step before submitting a new patch for that. This point could be relevant. > NB2. This patch is closely related to authorized values&categories > [adding/modifying]. > http://manual.koha-community.org/3.18/en/basicparams.html#authorizedvalues > point 232: "Limit your Category to 10 characters (something short to make > it clear what the category is for)" > > The user of this enhancement 10855 would probably be interested in using > more > than 10 chars. This manual's warning limit might be increased. The manual is right, for 3.18. But since bug 13379 (pushed to master), authorised_values.category is a varchar(32). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 16:46:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 15:46:55 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #191 from Jonathan Druart --- It would be great if you managed to reproduce the filtering issue on a sandbox (and tell me which one you have used) or took a screenshot before and after you filled the filter with the diacritic character. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 17:30:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 16:30:55 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 17:34:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 16:34:27 +0000 Subject: [Koha-bugs] [Bug 12730] Pre-due Notices not being sent. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12730 --- Comment #6 from Kyle M Hall --- Tested on master today. Both due and predue notices work if email is checked, and email and digest are checked, and *not* if only digest is checked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 17:38:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 16:38:55 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 --- Comment #1 from Owen Leonard --- Created attachment 35470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35470&action=edit Bug 13612 - Remove old YUI javacript libraries from opac-tmpl YUI files were left behind in opac-tmpl/lib/yui after the removal of the prog theme. These files are unused and can be safely removed. To test, apply the patch and search for references to any of the YUI files. You should find none in the OPAC templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 17:38:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 16:38:52 +0000 Subject: [Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 17:41:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 16:41:49 +0000 Subject: [Koha-bugs] [Bug 13293] Regression: Override renewal limit option broken with AJAX circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:11:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:11:04 +0000 Subject: [Koha-bugs] [Bug 12730] Pre-due Notices not being sent. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12730 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:25:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:25:41 +0000 Subject: [Koha-bugs] [Bug 13613] New: Don't allow digest to be selected without a digest-able transport selected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Bug ID: 13613 Summary: Don't allow digest to be selected without a digest-able transport selected Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org By default, only the email transport is enabled. This gives the messaging preferences the look of having email and digest and two options. I.E. to some users it appears that you check email for single emails, *or* you check digest for a digest email. To help remove this possible confusion, the digest mode checkbox should be disabled if no digest-able transports are checked for a given notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:25:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:25:51 +0000 Subject: [Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:29:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:29:24 +0000 Subject: [Koha-bugs] [Bug 12373] yuipath system preference affects OPAC but is filed under Staff Client: Appearance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12373 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:40:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:40:38 +0000 Subject: [Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 --- Comment #1 from Kyle M Hall --- Created attachment 35471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35471&action=edit Bug 13613 - Don't allow digest to be selected without a digest-able transport selected By default, only the email transport is enabled. This gives the messaging preferences the look of having email and digest and two options. I.E. to some users it appears that you check email for single emails, *or* you check digest for a digest email. To help remove this possible confusion, the digest mode checkbox should be disabled if no digest-able transports are checked for a given notice. Test Plan: 1) Apply this patch 2) For both the staff interface and the opac, note that the digest checkbox is disabled any time that no digest enabled transport ( email, sms if enabled ) is checked for the patron editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:40:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:40:35 +0000 Subject: [Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:40:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:40:55 +0000 Subject: [Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:47:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:47:43 +0000 Subject: [Koha-bugs] [Bug 13614] New: Replace usage of YUI on basket groups page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Bug ID: 13614 Summary: Replace usage of YUI on basket groups page Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/basketgroup.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org basketgroup.tt is the last part of Koha that uses any YUI JavaScript. The YUI library files are now six years old and unsupported. It's time to figure out some way to update basket grouping behavior without using YUI. The jQueryUI distribution we use already includes the Sortable interaction (http://jqueryui.com/sortable/), which may offer an alternative solution without requiring that we add additional JavaScript dependencies. However, I'm not familiar enough with it (or with basket groups) to know for sure. I hope someone can work on this. I would really like to kill YUI JS for good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:57:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:57:11 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 --- Comment #6 from Owen Leonard --- (In reply to Mason James from comment #5) > This needs to be backported to 3.16.x This patch depends on Bug 12550, so I assume it is not relevant to 3.16.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 18:57:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 17:57:33 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:14:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:14:58 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34153|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 35472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35472&action=edit [PASSED QA] [Rebased] Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:15:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:15:06 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34154|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 35473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35473&action=edit [PASSED QA] Bug 13235: Move onclick attr to javacsript code Refactor 1 line of code and add a preventDefault. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:15:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:15:57 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #13 from Owen Leonard --- I have rebased my patch and re-attached the follow-up so that they are in the right order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:17:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:17:28 +0000 Subject: [Koha-bugs] [Bug 13581] item circ history has 'last seen' labeled wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13581 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 13580 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:20:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:20:31 +0000 Subject: [Koha-bugs] [Bug 13348] Perpetual login loop when patron attempts to renew/request items from iPhone/Mac. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13348 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Owen Leonard --- With no additional information about how to reproduce this problem I will consider this report invalid. Please re-open if you can provide additional details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:26:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:26:33 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED Version|3.16 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:32:11 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:32:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:32:13 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 --- Comment #1 from Owen Leonard --- Created attachment 35475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35475&action=edit Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:42:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:42:17 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #230 from Tom?s Cohen Arazi --- 3.20 release team pushed. Thanks Marcel and Katrin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:42:26 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35440|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:42:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:42:34 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35441|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:42:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:42:41 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35442|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:43:59 +0000 Subject: [Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Thomas! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:44:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:44:31 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:47:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:47:28 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:47:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:47:54 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31957|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 35478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35478&action=edit [Revised] Bug 9528 - Add delivery branch to the place hold display When viewing the list of a patron's holds from the circulation or patron detail page the pickup library is not listed. This patch adds a column to the table of holds which shows the pickup branch. This patch also removes some unnecessary markup from the generation of the table and corrects an instance where the term "reserve" was used instead of "hold." This patch also modifies the language describing an item which is marked waiting at the current library: "Item is waiting here" instead of "Item waiting." To test, add several holds to a patron's account with various pickup locations. - Confirm that those pickup locations are correctly displayed under the Holds tab in Circulation. - Check in and confirm a hold which is to be picked up at the current branch. Confirm that the revised language appears. - Confirm that table sorting works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:47:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:47:52 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 20:50:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 19:50:04 +0000 Subject: [Koha-bugs] [Bug 13615] New: callnumber.pl when editing existing 942h or 952o adds a space and digit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13615 Bug ID: 13615 Summary: callnumber.pl when editing existing 942h or 952o adds a space and digit Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: eb at efdss.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Disclaimer: I'm not certain I understand what callnumber.pl should do. I have been experimenting with enabling it in 942h to pull the callnumber from our 099 field (it doesn't) and / or in 952o to do the same thing (it does if the plugin is not enabled in the 942). If I enable it only in the 942h, it will automatically populate the 952o using what's entered in the 942h. That in itself seems counter-intuitive. Note: our call numbers are not unique. I don't know how this relates to bug 13364, or if there is an underlying assumption that a field with callnumber.pl enabled will be unique. When editing a catalogue record, we manually type in the contents of the 942$h (call number). When editing this field in a reopened record, after hitting save, a space and numeral 1 magically appear following the call number, completely without our input. Here it is in a record - the call number should be only "QM" as it is in the 099 field. It appears to be adding 0001 in the 942 $6 which we have set to ignore. If the 1 is successfully deleted from the $h, the 0001 also vanishes from $6. 000 00720ndm a22002057a 4500 001 201501211025.nw 003 UkLoVW 005 20150121224121.0 008 150121q1926 enkfmle nn 0 eng d 040 _aUkLoVW_beng_cUkLoVW 099 _aQM 100 1 _913719_aHooton, P. M. 245 10 _aManuscript music book / 300 _a6 p. :_bmusic ;_c30 cm. 500 _aManuscript music book with country morris and sword dance tunes, including bass parts in some cases. The name P. M. Hooton is on the front cover, probably Miss P. M. Hooton of Norwich who was an EFDS member in the 1920s. 650 7 _9127_aDance music 650 7 _9163_aEngland 850 _aUkLoVW 942 _2VWML_cMS_hQM 1_n0_6QM0001 999 _c65844_d65844 Other tests I've run: The following things happen only after I edit the field in question. With the plugin callnumber.pl activated in both 942h and 952$o : the 1 appears after the call number in 942h as described above. But, it vanishes again without being deleted manually - it does not appear in the MARC after saving. The 952$o is populated automatically with the information from 942 h. With the plugin enabled in 942h, if I click on the box to the right of the 942h (this is only visible when the plugin is activated) - it inserts the 1. If I disable the plugin in 942 and enable it in 952, it will pull the information directly from the 099 field to 952o. But if you edit an existing item's 952o, it adds the 1. If there is an item attached to the same biblio that has the 1 already inserted, a subsequently edited item will add a 2. I haven't gone further than that, but it appears to be keeping track and incrementally changing the number it inserts. The problem was reported by staff using Windows and Chrome. I have replicated it on Mac OSX using Chrome and Firefox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 22:33:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 21:33:48 +0000 Subject: [Koha-bugs] [Bug 13616] New: can't edit budget because of commas Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13616 Bug ID: 13616 Summary: can't edit budget because of commas Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 35479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35479&action=edit comma in amount When you click to edit a budget it puts commas in to the number field and then you get an error saying you can't save because it's not a valid number. I like the error, but I didn't put the commas there - Koha did so I have to remember to delete them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 22:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 21:33:59 +0000 Subject: [Koha-bugs] [Bug 13616] can't edit budget because of commas In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13616 --- Comment #1 from Nicole C. Engard --- Created attachment 35480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35480&action=edit error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 22:53:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 21:53:00 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #10 from Aleisha Amohia --- When I applied the patches, it got rid of all the checkboxes for Do not notify completely so I can't check or uncheck the boxes to test. I feel like this wasn't the preferred outcome? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 23:16:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 22:16:24 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 23:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 22:16:27 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34664|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia --- Created attachment 35481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35481&action=edit Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 22 23:26:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 22:26:37 +0000 Subject: [Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 00:19:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 23:19:33 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Katrin Fischer --- *** Bug 13616 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 00:19:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 23:19:33 +0000 Subject: [Koha-bugs] [Bug 13616] can't edit budget because of commas In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13352 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 00:19:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Jan 2015 23:19:52 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.16 |3.18 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 01:00:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 00:00:49 +0000 Subject: [Koha-bugs] [Bug 13617] New: Change wording on suspend Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13617 Bug ID: 13617 Summary: Change wording on suspend Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I would like to suggest changing some wording on opac-user.pl. Currently the suspend button/link confuses patrons. The wording causes them to think the item is suspended. I know...it doesn't say suspended...but that doesn't seem to make a difference to the users. We would like to suggest the wording "Click to suspend", and likewise for "Click to resume". Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 01:54:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 00:54:42 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 01:54:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 00:54:48 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23297|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 35482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35482&action=edit Bug 11337: Remove the C4::Serials::GetSubscriptions routine Since SearchSubscriptions is the way to search subscriptions, each call to GetSubscriptions could be replaced by a call to SearchSubscriptions. Test plan: Verify following pages display the same thing as before this patch: - catalogue/detail.pl - opac/opac-ISBDdetail.pl - opac/opac-detail.pl Verify the following page returns correct results: - serials/checkexpiration.pl Verify the Serials UT file still passes: - prove t/db_dependent/Serials.t Note: The title filter on checkexpiration now only searches on the title DB field. I don't think it is a regression, it should be the way to use this field. Maybe should we add new search fields on this form. Bug 5337 reintroduces a bug fixed by bug 5864, this patch restore the right way to search subscription (based on biblionumber). Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 03:05:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 02:05:11 +0000 Subject: [Koha-bugs] [Bug 13615] callnumber.pl when editing existing 942h or 952o adds a space and digit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13615 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org Severity|normal |minor --- Comment #1 from Elaine Bradtke --- After discussing this with the IT wizard, I now understand where the numbers are coming from. Many of our call numbers consist of nothing more than two upper case letters, for example QM. The plugin is looking at that and seeing a prefix and adding sequential numbers. It still doesn't explain why the plugin pulls from the 099 when used in the 952 field, but not when used in the 942 field. Perhaps a brief explanation of what this plugin is meant to do would be a useful addition to the manual? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 03:26:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 02:26:18 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 03:26:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 02:26:21 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31676|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 35483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35483&action=edit Bug 12412 - Add ability for plugins to convert arbitrary files to MARC from record staging tool Many libraries would like to be able to import various types of files as MARC records ( citations, csv files, etc ). We can add a new function to the plugins system to allow that kind of behavior at a very custom level. Test Plan: 1) Ensure you have plugins enabled and configured correctly 2) Installed the attached version 2.00 of the Kitchen Sink plugin 3) Download the attached text file 4) Browse to "Stage MARC records for import" 5) Select the downloaded text file for staging 6) After uploading, you should see a new area "Transform file to MARC:", select "Example Kitchen-Sink Plugin" from the pulldown menu 7) Click 'Stage for import" 8) Click 'Manage staged records" 9) You should now see two new MARC records! Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 07:58:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 06:58:37 +0000 Subject: [Koha-bugs] [Bug 13510] Cross site scripting in opac lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13510 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org Version|unspecified |master Component|Koha |OPAC Assignee|chris at bigballofwax.co.nz |oleonard at myacpl.org Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 08:06:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 07:06:31 +0000 Subject: [Koha-bugs] [Bug 13617] Change wording on suspend In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13617 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Maybe 'suspend item' instead? I am not sure about changing the wording to have 'click' - it would also make for an awful long translation in German. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 10:24:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 09:24:04 +0000 Subject: [Koha-bugs] [Bug 13510] Cross site scripting in opac lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13510 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #20 from Fridolin SOMERS --- Pushed to 3.14.x will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 10:33:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 09:33:14 +0000 Subject: [Koha-bugs] [Bug 12971] Regression: Patron print summary doesn't show checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 --- Comment #17 from Mason James --- (In reply to Liz Rea from comment #15) > Will we be pulling this fix back to 3.16? > > Cheers, > Liz Hmm, I cant reproduce this bug in 3.16.6+ ie: the checkouts are showing OK from print-summary you are hitting this bug in 3.16.x Liz? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 10:42:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 09:42:13 +0000 Subject: [Koha-bugs] [Bug 12971] Regression: Patron print summary doesn't show checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 --- Comment #18 from Mason James --- Created attachment 35484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35484&action=edit checkouts show in summary, 3.16.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 11:40:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 10:40:04 +0000 Subject: [Koha-bugs] [Bug 13618] New: Prevent XSS everywhere at the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Bug ID: 13618 Summary: Prevent XSS everywhere at the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 11:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 10:43:29 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS everywhere at the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13609, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13510, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13425, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11341, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13426 --- Comment #1 from Jonathan Druart --- Recently, we got a lot of security bugs related to potential XSS attack. We should think about a global solution instead of escaping everything manually in the templates. Any thoughs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 11:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 10:43:29 +0000 Subject: [Koha-bugs] [Bug 13510] Cross site scripting in opac lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13510 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13618 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 11:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 10:43:29 +0000 Subject: [Koha-bugs] [Bug 11341] XSS attack vector in facets in OPAC - prog theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13618 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 11:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 10:43:29 +0000 Subject: [Koha-bugs] [Bug 13425] There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13425 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13618 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 11:43:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 10:43:43 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS everywhere at the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 11:59:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 10:59:55 +0000 Subject: [Koha-bugs] [Bug 13617] Change wording on suspend In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13617 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #2 from paxed --- (In reply to Katrin Fischer from comment #1) > Maybe 'suspend item' instead? I am not sure about changing the wording to > have 'click' - it would also make for an awful long translation in German. Also, why state something that should be obvious - if the user doesn't know it's a clickable element, something is seriously wrong with the element style. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 12:18:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 11:18:55 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS everywhere at the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #2 from Jonathan Druart --- http://www.perlmonks.org/?node_id=1059961 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:13:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:13:19 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #23 from Kyle M Hall --- > Instead of using a separate system preference, maybe allowing overwriting > existing fields would be an option? Then you could use > *ExportAdditionalFields with 942$c for the itemtype feature or even use > another arbitrary field the library thinks is best suited. That is a capital idea! I will be implementing this shortly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:19:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:19:15 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:19:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:19:19 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33123|0 |1 is obsolete| | Attachment #33124|0 |1 is obsolete| | Attachment #33125|0 |1 is obsolete| | Attachment #33126|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 35485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35485&action=edit Bug 12357 - Enhancements to RIS and BibTeX exporting Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: TY: 942$c LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field, a 942$c field, and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the replaced TY field, the LC field, and multiple NT fields 7) Add the following to the new syspref BibtexExportAdditionalFields: '@': 942$c lccn: 010$a notes: [501$a, 505$g] 9) Using the previously selected record, choose "Save" and select BIBTEX 10) Inspect the downloaded file, note the lccn, the multiple note fields, and the new record type value Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:20:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:20:43 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 --- Comment #14 from Thomas Wright --- Created attachment 35486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35486&action=edit Follow up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:21:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:21:06 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #25 from Kyle M Hall --- Created attachment 35487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35487&action=edit Bug 12357 - Tidy Ris.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:21:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:21:36 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS everywhere at the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #3 from Jonathan Druart --- Created attachment 35488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35488&action=edit Bug 13618: [wip] Use Template::Stash::HTML::Entities to use the html filter Test plan: 0/ sudo cpanm Template::Stash::HTML::Entities 1/ Verify don't reproduce the XSS issue described on bug 13609. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:21:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:21:58 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Thomas Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #15 from Thomas Wright --- Not sure if I did the logging correctly, but I had a go! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:26:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:26:40 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #26 from Kyle M Hall --- Created attachment 35489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35489&action=edit Bug 12357 - Tidy Record.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:38:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:38:52 +0000 Subject: [Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolyn.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Looks like patch is not needs for 3.14.x, I set as resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:41:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:41:46 +0000 Subject: [Koha-bugs] [Bug 12717] Library no longer receiving Overdue email for patrons without email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12717 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolyn.somers at biblibre.co | |m --- Comment #21 from Fridolin SOMERS --- Bug 10832 is not in 3.14.x so this one is not needed. I set as resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:45:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:45:34 +0000 Subject: [Koha-bugs] [Bug 12371] Links in every patron self-registration email points to a single borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12371 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- Pushed to 3.14.x will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:47:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:47:22 +0000 Subject: [Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolyn.somers at biblibre.co | |m --- Comment #25 from Fridolin SOMERS --- I choose to not push to 3.14.x I set as resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:47:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:47:23 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Bug 12593 depends on bug 12151, which changed state. Bug 12151 Summary: remove remaining uses of the Perl smartmatch operator http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:48:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:48:10 +0000 Subject: [Koha-bugs] [Bug 12593] search facets die with regex error if biblio has square brackets in fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12593 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolyn.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS --- Bug 12151 not in 3.14.x I set as resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:49:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:49:28 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:49:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:49:31 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26516|0 |1 is obsolete| | Attachment #35418|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 35490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35490&action=edit [PASSED QA] Bug 11961 - Add a "Z39.50 search" button to the authority creation and modification pages. This button lets you replace existing authorities using a Z39.50 search. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Nicole C. Engard All tests pass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:49:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:49:42 +0000 Subject: [Koha-bugs] [Bug 11961] Add a "Z39.50 search" button to the authority creation and modfication forms. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 --- Comment #9 from Kyle M Hall --- Created attachment 35491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35491&action=edit [PASSED QA] Bug 11961 - This patch fix the QA critical error, fix the capitalization and the UNIMARC support. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:53:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:53:07 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:53:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:53:11 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20015|0 |1 is obsolete| | Attachment #20016|0 |1 is obsolete| | Attachment #20017|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 35492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35492&action=edit Bug 9223: Multiple values of AdvancedSearchTypes in suggestions Suggestion form uses C4::Koha::GetSupportList to get a list of supports that can come from itemtypes or authoritized values LOC or CCODE. C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one value. But this syspref can contain several values separated by a pipe. This patch introduces a new syspref SupportsAuthorizedValues to select wich authorized values category that represents the physical support (itemtypes by default, loc or ccode). These authorized values will be used in suggestion management, known as 'document type'. (Note that database field is still 'itemtype'). Test plan : ----------- - Set SupportsAuthorizedValues with itemtypes or loc or ccode - Get to suggestion form (OPAC or intranet) - Look at "Document type" combobox, it must contains descriptions of selected authorized values - Save the suggestion - Get to intranet suggestions management - Organize suggestions by document type => your suggestion must appear in a tab with its document type description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:53:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:53:20 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #28 from Jonathan Druart --- Created attachment 35493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35493&action=edit Bug 9223: Add SupportsAuthorizedValues syspref (followup 1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:53:25 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #29 from Jonathan Druart --- Created attachment 35494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35494&action=edit Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions This follow-up implements some things I think will improve on the previous patches: - Change the system preference name to "SuggestionsUseValues" - Change the description of the preference to "Suggestions can be submitted using the following authorized values:" - Move the new preference to the OPAC tab so that it is grouped with other suggestions-related preferences. - Add the option offer no itemtype/collection code chooser on the submission form. - Display the correct label on the submission form depending on the value of the SuggestionsUseValues preference. To test, apply this patch on top of the previous ones. Test submission of purchase suggestions through the OPAC and staff client with the SuggestionsUseValues preference set to all the various choices: item type, collection code, shelving location, and 'none.' The suggestion forms should look correct and work correctly. HOWEVER, neither the previous patches nor mine address the problem of the suggestions management page's "organize by" option, which is hard-coded to work with item types. Whether or not my patch is acceptable this issue will need to be addressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:54:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:54:20 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #30 from Jonathan Druart --- I would like to see this one moving forward. I rebased the 3 patches against master and adapted them to the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:55:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:55:37 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #17 from Kyle M Hall --- FAIL koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc OK forbidden patterns FAIL tt_valid lines 12 OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/export.tt FAIL forbidden patterns forbidden pattern: tab char (line 26) forbidden pattern: tab char (line 18) OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:57:25 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:57:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:57:28 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35424|0 |1 is obsolete| | Attachment #35425|0 |1 is obsolete| | Attachment #35426|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 35495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35495&action=edit [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:57:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:57:35 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35495|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 35496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35496&action=edit [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 13:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 12:57:38 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #21 from Kyle M Hall --- Created attachment 35497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35497&action=edit [PASSED QA] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:02:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:02:13 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #45 from Fridolin SOMERS --- Pushed to 3.14.x will be in 3.14.13 Second commit : c07a3d0 Bug 10519: (followup) Fix context for evalyating $borrowernumber Is not needed, $borrowernumber does not existe on this line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:04:53 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35496|0 |1 is obsolete| | Attachment #35497|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 35498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35498&action=edit [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:05:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:05:00 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35498|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 35499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35499&action=edit [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:05:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:05:03 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #24 from Kyle M Hall --- Created attachment 35500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35500&action=edit [PASSED QA] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:05:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:05:48 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35499|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 35501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35501&action=edit [PASSED QA] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:06:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:06:56 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35500|0 |1 is obsolete| | Attachment #35501|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 35502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35502&action=edit [PASSED QA] Bug 13373 [1/2] - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:07:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:07:09 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #28 from Kyle M Hall --- Created attachment 35504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35504&action=edit [PASSED QA] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:07:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:07:06 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #27 from Kyle M Hall --- Created attachment 35503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35503&action=edit [PASSED QA] Bug 13373 [2/2] - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:22:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:22:21 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolyn.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #18 from Fridolin SOMERS --- Not needed for 3.14.x. I set as resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:32:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:32:21 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #31 from Joseph DeVore --- Hi Jonathan! its nice to see some one finally working on this again =D good luck. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:33:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:33:12 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #17 from Fridolin SOMERS --- Patch is in 3.16.x, I set to Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:33:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:33:20 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:46:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:46:43 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 --- Comment #18 from Fridolin SOMERS --- Pushed to 3.14.x will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:47:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:47:53 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:47:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:47:56 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35278|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 35505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35505&action=edit [PASSED QA] Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries Signed-off-by: Thomas Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:48:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:48:05 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #19 from Kyle M Hall --- Created attachment 35506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35506&action=edit Bug 13040 [QA Followup] - Fix koha-qa.pl issues Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 14:50:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 13:50:40 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #20 from Kyle M Hall --- Tried using the multi-select, but it doesn't seem to be able to handle the pulldown stylistically. Also, given the number of possible options, the pulldown would fall far off the page. I haven't tested it with 40+ branches, but I'm afraid some browsers would stop the scrolldown from even making it the end of the list ( i.e. the bottom would fall off the visible page )! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 15:06:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 14:06:33 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 --- Comment #6 from Kyle M Hall --- Created attachment 35507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35507&action=edit Bug 13536 [Proposed Followup] - Use multi-select -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 15:06:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 14:06:57 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35507|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 15:07:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 14:07:31 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #21 from Kyle M Hall --- Created attachment 35508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35508&action=edit Bug 13040 [Proposed Followup] - Use multi-select -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 15:11:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 14:11:04 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 15:23:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 14:23:03 +0000 Subject: [Koha-bugs] [Bug 13617] Change wording on suspend In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13617 --- Comment #3 from Owen Leonard --- (In reply to paxed from comment #2) > something is seriously wrong with the element > style. And since it is styled as a link just like any other, there shouldn't be ambiguity about its being clickable. In general I think it's not useful to tell users to click things... Especially since many of our users now use touches instead of mouse clicks. Another option is to style it as a button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 15:33:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 14:33:58 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34392|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 35509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35509&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 15:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 14:34:51 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13345 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 15:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 14:34:51 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13596 | --- Comment #5 from Jonathan Druart --- Last patch fixes conflicts with bug 13510. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 15:57:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 14:57:23 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #27 from Jonathan Druart --- Kyle, How did you tidy Ris.pm? It seems you did not used perltidy: $ perltidy C4/Ris.pm $ diff C4/Ris.pm C4/Ris.pm.tdy | wc 214 1064 10403 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:08:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:08:24 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #70 from Jonathan Druart --- Dear RM, what about this feature? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:11:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:11:17 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 --- Comment #22 from Owen Leonard --- Created attachment 35510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35510&action=edit Bug 13040 [CSS follow-up] Improve exporter to allow multiple branch selections This patch adds a little bit of CSS to style the branch checkbox boxes. I hope that this helps the readability, especially in systems with a large number of branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:22:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:22:54 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #25 from Jonathan Druart --- Kyle, do you think it's relevant to have 2 prefs for 11747 and this one? Maybe 1 generic pref could be used for the both places. Katrin, Nick: an opinion? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:23:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:23:21 +0000 Subject: [Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8367 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:23:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:23:21 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9004 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:24:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:24:03 +0000 Subject: [Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8367 Depends on| |8367 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:24:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:24:03 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9004 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9004 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:24:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:24:16 +0000 Subject: [Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8367 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:24:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:24:16 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9004 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:24:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:24:51 +0000 Subject: [Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:29:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:29:31 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- (In reply to Kyle M Hall from comment #1) > Created attachment 34958 [details] [review] > Bug 13517 - Tidy request.pl This is not needed, it will introduce conflict with other patches in the queue. Why did you tidy this file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 16:39:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 15:39:43 +0000 Subject: [Koha-bugs] [Bug 13617] Change wording on suspend In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13617 --- Comment #4 from Christopher Brannon --- (In reply to Owen Leonard from comment #3) > (In reply to paxed from comment #2) > > something is seriously wrong with the element > > style. > > And since it is styled as a link just like any other, there shouldn't be > ambiguity about its being clickable. In general I think it's not useful to > tell users to click things... Especially since many of our users now use > touches instead of mouse clicks. > > Another option is to style it as a button. IF we are concerned about touches, IMO, we should try to stay away from links and use buttons everywhere. Buttons are more touch friendly. Unfortunately, if people took the time to look things over better, I wouldn't even be reporting this. I think that is crazy that there are people trying to read books, but can't read the controls on a screen. With that said, if a button is favored over making the link a more obvious action with words, then go for it. It really does look confusing as is. Even the staff side of things makes more sense. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:04:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:04:08 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #20 from Jonathan Druart --- Comment on attachment 35091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35091 Bug 5144 [2] - Duplicate holds allowed if patron clicks back button after placing hold Review of attachment 35091: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5144&attachment=35091) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +161,5 @@ > + ( $biblionumber, $borrowernumber ) > + ); > + if ( $count > 0 ) { > + carp("AddReserve: borrower $borrowernumber already has $count holds for biblionumber $biblionumber"); > + return; This will be in conflict with bug 7710. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:14:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:14:01 +0000 Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:17:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:17:00 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #18 from Marjorie Barry-Vila --- Hi, Is anyone working on this? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:28:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:28:32 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34662|0 |1 is obsolete| | Attachment #34663|0 |1 is obsolete| | Attachment #35481|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 35511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35511&action=edit [PASSED QA] Bug 13492: Add the column configuration for the checkouts table - circulation.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (circulation.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:28:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:28:30 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:28:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:28:39 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #8 from Kyle M Hall --- Created attachment 35512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35512&action=edit [PASSED QA] Bug 13492: Add the column configuration for the checkouts table - morember.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (moremember.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:28:43 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #9 from Kyle M Hall --- Created attachment 35513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35513&action=edit [PASSED QA] Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:34:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:34:11 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- I would also prefer $a->{b}->{c}. I think it's more readable. Maybe we should vote on this for coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:41:51 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:42:32 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:58:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:58:08 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 17:58:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 16:58:11 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35482|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 35514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35514&action=edit [PASSED QA] Bug 11337: Remove the C4::Serials::GetSubscriptions routine Since SearchSubscriptions is the way to search subscriptions, each call to GetSubscriptions could be replaced by a call to SearchSubscriptions. Test plan: Verify following pages display the same thing as before this patch: - catalogue/detail.pl - opac/opac-ISBDdetail.pl - opac/opac-detail.pl Verify the following page returns correct results: - serials/checkexpiration.pl Verify the Serials UT file still passes: - prove t/db_dependent/Serials.t Note: The title filter on checkexpiration now only searches on the title DB field. I don't think it is a regression, it should be the way to use this field. Maybe should we add new search fields on this form. Bug 5337 reintroduces a bug fixed by bug 5864, this patch restore the right way to search subscription (based on biblionumber). Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 18:11:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 17:11:52 +0000 Subject: [Koha-bugs] [Bug 13619] New: Add a link for pending suggestion on acqui-home.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Bug ID: 13619 Summary: Add a link for pending suggestion on acqui-home.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Created attachment 35515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35515&action=edit suggestion Hi, It would be nice that a link be added on text "suggestion waiting" to arrive in pending tab in suggestion.pl. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 18:54:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 17:54:16 +0000 Subject: [Koha-bugs] [Bug 13240] advanced_notices.pl contains code obfuscation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 --- Comment #10 from M. Tompsett --- (In reply to Kyle M Hall from comment #9) > Maybe we should vote on this for coding guidelines. I added it as an agenda item to http://wiki.koha-community.org/wiki/Development_IRC_meeting_4_February_2015#Agenda -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 19:39:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 18:39:49 +0000 Subject: [Koha-bugs] [Bug 12962] easier to see circ rule edits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12962 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 20:09:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 19:09:22 +0000 Subject: [Koha-bugs] [Bug 13620] New: Add item when modifying an order (items created when placing an order) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13620 Bug ID: 13620 Summary: Add item when modifying an order (items created when placing an order) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Hi, When we modifying an order, we should have the possibility to add an item. Actually we have an error message to place a new order line. Adding items here should be the same as when creating a new order line. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 21:49:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 20:49:42 +0000 Subject: [Koha-bugs] [Bug 13609] Cross Site Scripting problem in authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13609 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |OPAC Version|unspecified |master Group|Koha security | CC| |chris at bigballofwax.co.nz Product|Koha security |Koha Status|Pushed to Master |Pushed to Stable QA Contact| |testopia at bugs.koha-communit | |y.org --- Comment #10 from Chris Cormack --- Is in 3.18.x and 3.16.x also -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 21:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 20:49:51 +0000 Subject: [Koha-bugs] [Bug 13609] Cross Site Scripting problem in authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13609 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 21:53:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 20:53:08 +0000 Subject: [Koha-bugs] [Bug 6138] Show local help and isbd punctuation automatically when we are cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 21:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 20:54:05 +0000 Subject: [Koha-bugs] [Bug 10437] Greater flexibility on Marc Edit screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10437 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 21:54:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 20:54:24 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 22:02:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 21:02:19 +0000 Subject: [Koha-bugs] [Bug 8618] Z3950 is not processing CCL Queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8618 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 22:12:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 21:12:35 +0000 Subject: [Koha-bugs] [Bug 13621] New: OpacTopissue Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13621 Bug ID: 13621 Summary: OpacTopissue Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Would like to know what parameters this feature is working off of and if it is actually working. We turned it on briefly to see what shows up, and there are really obscure and unexpected results. Thanks. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 23 22:12:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Jan 2015 21:12:50 +0000 Subject: [Koha-bugs] [Bug 13621] OpacTopissue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13621 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 24 20:26:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Jan 2015 19:26:17 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #30 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 24 20:26:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Jan 2015 19:26:41 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 24 20:27:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Jan 2015 19:27:01 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 24 20:28:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Jan 2015 19:28:14 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #14 from Tom?s Cohen Arazi --- Enhancement pushed to master. Looking forward for this work on making C4::Auth better! Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 24 20:28:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Jan 2015 19:28:45 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 24 20:29:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Jan 2015 19:29:21 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 24 22:14:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Jan 2015 21:14:40 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 25 11:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Jan 2015 10:32:01 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 --- Comment #15 from Martin Renvoize --- Thanks for pushing.. should make life a bit easier. I'll get to re-basing the various bugs as promised this coming week :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 25 20:41:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Jan 2015 19:41:44 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #32 from Katrin Fischer --- Hi Joseph, this has the status 'needs signoff' now, which means it's waiting for a tester. Anyone can test and we have sandboxes, so you don't need a development environment to do it :) Maybe you'd like to have a try - it would really help getting this further: http://wiki.koha-community.org/wiki/Sandboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 25 20:51:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Jan 2015 19:51:22 +0000 Subject: [Koha-bugs] [Bug 12971] Regression: Patron print summary doesn't show checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 --- Comment #19 from Liz Rea --- Comment on attachment 35484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35484 checkouts show in summary, 3.16.6 Yes, we saw it, but it's been ages ago. Possibly it was fixed somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 25 21:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Jan 2015 20:36:18 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 25 21:38:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Jan 2015 20:38:26 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 00:25:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Jan 2015 23:25:20 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #33 from Joseph DeVore --- I took a quick look at this sandboxing.... seems a bit too much for me... that is the setup seem a bit complex so I don't really know what I would be doing... I will pass this on the tech lady at my local library, and see if she can do anything to test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 04:17:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 03:17:25 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #25 from Robin Sheat --- Yeah, they worked on Ubuntu 14.10 last I looked. I'm in the process of making a new set for Debian Jessie. As for the deprecated bits, there are some issues there that make it not quite worth messing with the new versions just yet. Check out the discussion thread here: http://mail.librecat.org/pipermail/librecat-dev/2015-January/000322.html There should be very few, if any, API changes as the result of switching to the new version when it's suitable, too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 06:56:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 05:56:29 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #26 from Robin Sheat --- You can grab the new dependencies from here: http://debian.koha-community.org/koha/otherthings/ make sure you uninstall liblog-any-adapter-perl before doing anything, it conflicts with the new liblog-any-perl, and is no longer needed. I've added a dummy version of it to keep those packages that think they need it happy. It should just be a matter of doing: sudo dpkg -i *.deb sudo apt-get -f install Oh, and this requires Debian Jessie, as most of the old dependencies made it into there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 09:45:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 08:45:38 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS everywhere at the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #4 from Jonathan Druart --- Created attachment 35516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35516&action=edit Revert "Bug 13609: Cross Site Scripting problem in authority search result list paging" This reverts commit c667b9ddbf42f9729d8f4035c7e872d5e980a5e9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 10:06:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 09:06:40 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #11 from mathieu saby --- > But yeah... in the end there's no one who is currently maintaining QP, as > far as I know, so I wouldn't expect too much from it at the moment. Well, searching is a pretty important feature in a ILS ;-) So I hope somebody will take care of that. Even if there is no formal maintainer, at least writing up-to-date documentation about how it works and how configuring it would be great... I'm experiencing difficulties with my VM, but I will try to fix this patch today. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 10:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 09:27:37 +0000 Subject: [Koha-bugs] [Bug 12979] Price formatting should only be defined at one place In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13352 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 10:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 09:27:37 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12979 Version|3.18 |master Severity|minor |major Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 10:27:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 09:27:45 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 10:36:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 09:36:46 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 10:36:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 09:36:49 +0000 Subject: [Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352 --- Comment #3 from Jonathan Druart --- Created attachment 35517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35517&action=edit Bug 13352: On editing, prices should not be formatted Bug 12979 refactored the way to display prices. The price format configuration was duplicated everywhere it was used. All calls looks good except the one in admin/aqbudgetperiods.pl In this one, the prices are formatted for an edition field (input). This means the input is incorrectly filled even if the user does not update the field. At the end, maybe should we manage formatted prices everywhere, even in inputs, but it's not in the scope of this bug. Technically, a new subroutine format_for_editing is added to the Koha::Number::Price module. It should be called everywhere a price is displayed in an input field. At the moment, it only does a sprintf("%.2f"), but it is a first step to let the number of decimals to display configurable. To test: 1/ Verify the issue described is fixed (editing a budget with a total amount > 1000 (With CurrencyFormat is US or FR). 2/ Verify you can edit a fund with a total amount > 1000 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 11:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 10:07:36 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #78 from Jonathan Druart --- (In reply to M. de Rooy from comment #77) > Thanks for doing so. I would be interested too in seeing this get further. > The current patch suggest that Kyle wrote it and Maxime signed off. Could > you add a comment about your rebase; I assume that it was not a trivial one? About the manual rebase I did: It was not trivial because the patch did not applied even on 3-way merge. I used 'git apply --reject' to apply it, caught the errors and manually applied the changes that have not been applied (caused by a big diff on some hunks). I compared visually the 2 patches and quickly tested to be sure I did not introduced a big issue (compilation error, etc.). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 11:12:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 10:12:23 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #11 from Olli-Antti Kivilahti --- Hi there and thanks for testing this! Did you run the updatedatabase.pl-script? I think I should have mentioned it in the TEST PLAN, but I have a bad habit of not doing so :) Thanks for reminding me! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 11:56:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 10:56:35 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35397|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart --- Created attachment 35518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35518&action=edit Bug 7710 - multiple holds per title Adds the ability to allow multiple holds on the same record for the same borrower. Adds new system preference MaxHoldsPerRecord, which controls how many holds one person can have on items for the same record. Test Plan: 1) Apply patch for Bug 9394 2) Apply this patch 3) Run updatedatabase.pl 4) Attempt to place 2 holds for the same patron on the same record, you should not be able to ( default is 1 per record ) 5) Set MaxHoldsPerRecord to 3 6) Attempt to place multiple holds for one patron on one record, you should be able to place 3 holds for one patron on a given record. A 4th hold should result in a message stating the patron has placed the max number of holds allowed on this record. Signed-off-by: Maxime Pelletier Note: Jonathan Druart has manually rebased this patch using git apply --reject and has not tested it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 13:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 12:04:35 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #27 from Jonathan Druart --- Looks better with these new packages. Continuing debugging... Catmandu::Importer::MARC was missing, I installed it using cpanm: $ sudo cpanm Catmandu::Importer::MARC Now I got: $ perl rebuild_elastic_search.pl 1 to 115 is displayed Committing... And nothing else... $ ps aux | grep elasticsearch returns nothing $ sudo service elasticsearch start $ ps aux | grep elasticsearch returns nothing $ curl -X GET http://localhost:9200/ curl: (7) Failed to connect to localhost port 9200: Connection refused Editing /etc/init.d/elasticsearch, I found the binary: /usr/share/elasticsearch/bin/elasticsearch $ cd /usr/share/elasticsearch $ slog4j:WARN No appenders could be found for logger (node). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.udo bin/elasticsearch $ apt-cache show elasticsearch Package: elasticsearch Version: 1.0.3+dfsg-5 Should I installed another version? Something is missing in my jvm configuration? Something to do in the elasticsearch config? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 13:09:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 12:09:19 +0000 Subject: [Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |kyle at bywatersolutions.com Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 13:09:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 12:09:19 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Bug 10327 depends on bug 10329, which changed state. Bug 10329 Summary: Rename system preference marcflavour to MarcFormat http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 13:12:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 12:12:06 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #28 from Kyle M Hall --- (In reply to Jonathan Druart from comment #27) > Kyle, How did you tidy Ris.pm? > It seems you did not used perltidy: > $ perltidy C4/Ris.pm > $ diff C4/Ris.pm C4/Ris.pm.tdy | wc > 214 1064 10403 Yes, I did indeed use perltidy. I think this is a really good opportunity to tidy both of these modules. Only bug 12404 modifies Record.pm in any serious way, and that will be pushed to master before this one ( and I'll have to submit a fresh followup ). Ris.pm has no other patches in process that touch it at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 13:17:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 12:17:32 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- Marcel, don't you think it could be better to let the choice to the user? We could imagine a filter like <>. Like that we could have a global solution, for all fields, not only for date_due. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 13:24:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 12:24:07 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #29 from Jonathan Druart --- (In reply to Kyle M Hall from comment #28) > (In reply to Jonathan Druart from comment #27) > > Kyle, How did you tidy Ris.pm? > > It seems you did not used perltidy: > > $ perltidy C4/Ris.pm > > $ diff C4/Ris.pm C4/Ris.pm.tdy | wc > > 214 1064 10403 > > Yes, I did indeed use perltidy. Do you use a specific .perltidyrc file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 13:39:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 12:39:47 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 --- Comment #8 from M. de Rooy --- (In reply to Jonathan Druart from comment #7) > Marcel, don't you think it could be better to let the choice to the user? We > could imagine a filter like <>. > Like that we could have a global solution, for all fields, not only for > date_due. The user cannot choose now: he gets the time inclusive. I offer him the choice of removing the time with the new field. I would welcome a global solution. This is indeed quite ad-hoc (like more things in Koha, so very consistent :) Building a filter option in the notices would take more time. Actually, we could consider building the notices through TT and add translation as well.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:02:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:02:17 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #168 from Kyle M Hall --- Created attachment 35519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35519&action=edit Bug 9303 [QA Followup 3] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:05:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:05:22 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34629|0 |1 is obsolete| | Attachment #34630|0 |1 is obsolete| | Attachment #34631|0 |1 is obsolete| | Attachment #34632|0 |1 is obsolete| | Attachment #34633|0 |1 is obsolete| | Attachment #35519|0 |1 is obsolete| | --- Comment #169 from Kyle M Hall --- Created attachment 35520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35520&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:05:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:05:32 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #170 from Kyle M Hall --- Created attachment 35521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35521&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:05:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:05:37 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #171 from Kyle M Hall --- Created attachment 35522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35522&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:05:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:05:41 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #172 from Kyle M Hall --- Created attachment 35523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35523&action=edit Bug 9303 [QA Followup] - Don't drop non-existant keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:05:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:05:46 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #173 from Kyle M Hall --- Created attachment 35524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35524&action=edit Bug 9303 [QA Followup 2] - Fix db update, move 'show' field to guarantor area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:05:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:05:50 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #174 from Kyle M Hall --- Created attachment 35525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35525&action=edit Bug 9303 [QA Followup 3] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:28:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:28:54 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:28:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:28:58 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35520|0 |1 is obsolete| | Attachment #35521|0 |1 is obsolete| | Attachment #35522|0 |1 is obsolete| | Attachment #35523|0 |1 is obsolete| | Attachment #35524|0 |1 is obsolete| | Attachment #35525|0 |1 is obsolete| | --- Comment #175 from Kyle M Hall --- Created attachment 35526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35526&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:29:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:29:20 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35526|0 |1 is obsolete| | --- Comment #176 from Kyle M Hall --- Created attachment 35527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35527&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:29:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:29:31 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #177 from Kyle M Hall --- Created attachment 35528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35528&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:29:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:29:35 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #178 from Kyle M Hall --- Created attachment 35529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35529&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:29:40 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #179 from Kyle M Hall --- Created attachment 35530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35530&action=edit Bug 9303 [QA Followup] - Don't drop non-existant keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:29:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:29:44 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #180 from Kyle M Hall --- Created attachment 35531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35531&action=edit Bug 9303 [QA Followup 2] - Fix db update, move 'show' field to guarantor area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:29:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:29:49 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #181 from Kyle M Hall --- Created attachment 35532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35532&action=edit Bug 9393 [QA Followup 3] - Remove use of EncodeUTF8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:31:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:31:46 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #182 from Kyle M Hall --- (In reply to Katrin Fischer from comment #166) > Hi Kyle, > > I tried to retest the problem, but the database update gives me problems :( > > bumblebee:~/kohaclone (38-9303-relativecheckouts|AM 1/1) $ > ./installer/data/mysql/updatedatabase.pl > DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists > at ./installer/data/mysql/updatedatabase.pl line 9681. > DBD::mysql::db do failed: Can't DROP 'itemnumber_idx'; check that column/key > exists at ./installer/data/mysql/updatedatabase.pl line 9687. > DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists > at ./installer/data/mysql/updatedatabase.pl line 9690. > DBD::mysql::db do failed: Cannot drop index 'itemnumber_idx': needed in a > foreign key constraint at ./installer/data/mysql/updatedatabase.pl line 9696. > DBD::mysql::db do failed: Duplicate key name 'itemnumber_idx' at > ./installer/data/mysql/updatedatabase.pl line 9699. > Upgrade to 3.19.00.XXX done (Bug 9303 - relative's checkouts in the opac) Please try again. Are you sure your database is using the stock Koha schema? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:38:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:38:12 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #183 from Katrin Fischer --- Kyle, ignore comment#166 - see comment#167. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:45:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:45:35 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:45:39 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34884|0 |1 is obsolete| | Attachment #34885|0 |1 is obsolete| | Attachment #34888|0 |1 is obsolete| | Attachment #34889|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 35533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35533&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:45:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:45:46 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #25 from Kyle M Hall --- Created attachment 35534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35534&action=edit Bug 12933 - Add new OVERDUES_SLIP letter Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:45:50 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #26 from Kyle M Hall --- Created attachment 35535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35535&action=edit Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:45:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:45:53 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #27 from Kyle M Hall --- Created attachment 35536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35536&action=edit Bug 12933 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:45:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:45:57 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #28 from Kyle M Hall --- Created attachment 35537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35537&action=edit Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 14:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 13:46:00 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #29 from Kyle M Hall --- Created attachment 35538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35538&action=edit Bug 12933 [QA Followup] - Remove trailing whitespace from Members.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 16:13:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 15:13:57 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC|paola.rossi at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:26:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:26:53 +0000 Subject: [Koha-bugs] [Bug 13622] New: Display a datetime without time in a notice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Bug ID: 13622 Summary: Display a datetime without time in a notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 13536 fixes an issue for 1 specific datetime. I would like to make this possible for all date fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:27:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:27:17 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13622 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:27:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:27:17 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13536 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:28:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:28:46 +0000 Subject: [Koha-bugs] [Bug 13623] New: Enhance html for holds queue viewer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 Bug ID: 13623 Summary: Enhance html for holds queue viewer Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:30:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:30:29 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:30:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:30:33 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #1 from Jonathan Druart --- Created attachment 35539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35539&action=edit Bug 13536: Display a datetime without time in a notice For some needs, a librarian would like to display a datetime or timestamp field without the time. This patch a filter logic in the notice/letter parsing process. Test plan: 1/ Defined a notice using a datetime or timestamp DB field (biblio.timestamp for instance). 2/ Generate the notice 3/ Verify that the letter is generated with the time 4/ Use the "dateonly" filter like: <> <> 5/ Generate the notice 6/ Confirm the the letter is generated without the time for this field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:30:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:30:51 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:30:54 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 --- Comment #1 from Kyle M Hall --- Created attachment 35540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35540&action=edit Bug 13623 - Enhance html for holds queue viewer It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. Test Plan: 1) Apply this patch 2) Load the holds queue report ( view_holdsqueue.pl ) 3) Inspect an author name with your web browser ( or view the html ) a) Note the hq-author class of the wrapping div b) Note the hidden hq-biblionumber div -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:32:31 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35540|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 35541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35541&action=edit Bug 13623 - Enhance html for holds queue viewer It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. Test Plan: 1) Apply this patch 2) Load the holds queue report ( view_holdsqueue.pl ) 3) Inspect an author name with your web browser ( or view the html ) a) Note the hq-author class of the wrapping div b) Note the hidden hq-biblionumber div -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 17:34:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 16:34:08 +0000 Subject: [Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 --- Comment #9 from Jonathan Druart --- (In reply to M. de Rooy from comment #8) > I would welcome a global solution. I had a try on bug 13622, feedback welcomed ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:03:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:03:06 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34355|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 35542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35542&action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep "::set_userenv" `find .` grep "\->set_userenv" `find .` The first grep demonstrated that the smaller change is from :: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use ->) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Rebase required because of shibboleth change in C4/Context.pm Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:03:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:03:11 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34356|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize --- Created attachment 35543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35543&action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN --------- 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:03:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:03:17 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34357|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize --- Created attachment 35544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35544&action=edit Bug 10900: 2 occurrences more Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:04:18 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #49 from Martin Renvoize --- Rebased after auth.pm tidy in bug 13499 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:05:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:05:05 +0000 Subject: [Koha-bugs] [Bug 10148] 007/006 not filling in with existing values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:06:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:06:05 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer --- Comment #50 from Martin Renvoize --- Pushed to Module Maintainers Branch - https://github.com/mrenvoize/Koha/tree/authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:10:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:10:48 +0000 Subject: [Koha-bugs] [Bug 13624] New: Remove columns branchcode, categorytype from table overduerules_transport_types Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Bug ID: 13624 Summary: Remove columns branchcode, categorytype from table overduerules_transport_types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: charles.farmer at inlibro.com QA Contact: testopia at bugs.koha-community.org Sponsored by Halland County Library This patch is a requirement to Bug #12771. Instead of keeping 'branchcode' and 'categorytype' in the table overduerules_transport_types, a foreign key named 'overduerules_fk' now references the appropriate entry in the table overduerules. This will be necessary once we start managing more than 3 levels of overdue notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:23:52 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix [Needs one more signoff] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #88 from Martin Renvoize --- Created attachment 35545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35545&action=edit Bug 5786 - Move AllowOnShelfHolds system preference to the Circulation Matrix C4::Reserves: * Added OnShelfHoldsAllowed() to check issuingrules * Added OPACItemHoldsAllowed() to check issuingrules * IsAvailableForItemLevelRequest() changed interface, now takes $item_record,$borrower_record; calls OnShelfHoldsAllowed() opac/opac-reserve.pl and opac/opac-search.pl: * rewrote hold allowed rule to use OPACItemHoldsAllowed() * also use OnShelfHoldsAllowed() through * IsAvailableForItemLevelRequest() templates: * Removed AllowOnShelfHolds and OPACItemHolds global flags, they now only have meaning per item type Signed-off-by: Nicole C. Engard I have tested this patch left, right and upside down for the last several months. All tests have passed. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:23:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:23:58 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix [Needs one more signoff] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #89 from Martin Renvoize --- Created attachment 35546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35546&action=edit Bug 5786 [QA Followup] Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:25:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:25:53 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix [Needs one more signoff] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:26:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:26:03 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix [Needs one more signoff] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:26:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:26:30 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move AllowOnShelfHolds |Move AllowOnShelfHolds |system preference to the |system preference to the |Circulation Matrix [Needs |Circulation Matrix |one more signoff] | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:29:19 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #90 from Martin Renvoize --- Rebased patches after Auth.pm tidy in bug 13499 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:33:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:33:56 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #91 from Martin Renvoize --- OK.. that's another signoff.. happily tested and can't find any regressions this end. I'll pop it through the qa script and run the tests again then perhaps add my qa signature too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:43:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:43:13 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35545|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize --- Created attachment 35547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35547&action=edit Bug 5786 - Move AllowOnShelfHolds system preference to the Circulation Matrix C4::Reserves: * Added OnShelfHoldsAllowed() to check issuingrules * Added OPACItemHoldsAllowed() to check issuingrules * IsAvailableForItemLevelRequest() changed interface, now takes $item_record,$borrower_record; calls OnShelfHoldsAllowed() opac/opac-reserve.pl and opac/opac-search.pl: * rewrote hold allowed rule to use OPACItemHoldsAllowed() * also use OnShelfHoldsAllowed() through * IsAvailableForItemLevelRequest() templates: * Removed AllowOnShelfHolds and OPACItemHolds global flags, they now only have meaning per item type Signed-off-by: Nicole C. Engard I have tested this patch left, right and upside down for the last several months. All tests have passed. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:43:17 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35546|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize --- Created attachment 35548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35548&action=edit Bug 5786 [QA Followup] Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:43:58 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #94 from Martin Renvoize --- Passing QA on this.. would be lovely to see it in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:47:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:47:59 +0000 Subject: [Koha-bugs] [Bug 13617] Change wording on suspend In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13617 --- Comment #5 from Christopher Brannon --- I was able to modify the link to look like a button for the time being with jQuery, to see how that flies with patrons: //Change Suspend/Resume link to button $("#holdst td:nth-of-type(6) a,#holdst td:nth-of-type(6) button").removeClass("btn-link"); //end Change suspend link A couple odd things I notice. The class I remove is forcing it to look like a link. When I remove the class, it turns into a button! I also notice that Suspend is a an anchor tag and the Resume is a button tag. Very unusual and inconsistent. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 18:54:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 17:54:21 +0000 Subject: [Koha-bugs] [Bug 13625] New: RenewalSendNotice setting should be reflected in messaging Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13625 Bug ID: 13625 Summary: RenewalSendNotice setting should be reflected in messaging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When RenewalSendNotice is enabled(Send), it isn't reflected in messaging (opac-messaging.pl/moremember.pl). The row marked as "Item checkout" should be updated to "Item checkout/renew". Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 26 19:36:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Jan 2015 18:36:50 +0000 Subject: [Koha-bugs] [Bug 13617] Change wording on suspend In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13617 --- Comment #6 from Owen Leonard --- > I also notice that Suspend is a an anchor tag and the Resume is a button > tag. Very unusual and inconsistent. The suspend link is a trigger to a modal form. It could be anything--