[Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 6 15:24:35 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe this would be a good one to clean up for the academy too. As far I can
see there are 4 files linking to the modification logs:

koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc    
33 [% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li
class="active">[% ELSE %]<li>[% END %]<a
href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=[%
biblionumber %]">Modification log</a> </li>[% END %]

koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc    
77         [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a
href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=[%
borrowernumber %]&src=circ">Modification log</a></li>

koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt    
77     [% IF ( CAN_user_parameters ) %][% IF ( logview ) %]<li
class="active">[% ELSE %]<li>[% END %]<a
href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=[%
borrower.borrowernumber %]&src=circ">Modification log</a></li>[% END %]

koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc    
13         [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a
href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&action=MODIFY&object=[%
borrowernumber %]">Modification log</a></li>

Only the first seems to be using the correct permission check.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list