[Koha-bugs] [Bug 13414] Enable right truncation with search by relevance

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 7 00:08:25 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #6)
> David, as the current zebra guru, any chance you could give these patches a
> glance over?

Honestly, "buildQuery" and "_build_weighted_query" are so badly written that
any change is probably an improvement :p.

While I think this patch is a workaround, I think it's probably a reasonable
enough workaround. 

--

What we really need to do is have functions that test for "QueryStemming",
"QueryFuzzy", "QueryWeightFields", "QueryAutoTruncate", manual truncation, and
index type THEN add the appropriate qualifiers. Rather than the bizarre
mishmash that we have currently. 

Ideally, QueryParser should do this, but it hasn't been finished yet.

Personally, I want to re-write buildQuery, but haven't had the time. I'd like
to use an object or a hash for each atomic query, process them (according to
our sysprefs and to make them valid CCL), and then build those atomic queries
into a the complete query.

It's basically what we do now, except you can't do everything to a query when
realistically you should be able to do so.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list