[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #56 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:

Warning: commit message does not conform to UTF-8.
I replaced the é in Valérie.
Some/most combinations of git/git-bz still do not like non-ASCII commit
messages.
I rebased the second patch for updatedatabase.

No complaints from qa tools. Code looks good (remarks below).
I have mainly 'dry-tested' this patch set; I did not manage to get my unimarc
test db in the right condition within reasonable time. Note that opac-idref.pl
can be tested more or less separately.

1st patch: css in template file (no blocker)
3rd patch:
     <xslo:for-each select="marc:subfield">
+      <xslo:if test="contains('3', @code)">
+        <z:index name="Identifier-standard:w">
+          <xslo:value-of select="."/>
+        </z:index>
+      </xslo:if>
+    </xslo:for-each>
+    <xslo:for-each select="marc:subfield">
This does not look good to me. The for-each is repeated now.
Same holds for 701, 702, 710, 711, 712
Note that you update biblio-zebra-indexdefs.xsl. But biblio-zebra-indexdefs.xsl
should be automatically generated from a Koha index definition file with
koha-indexdefs-to-zebra.xsl.
Could you please add changes to biblio-koha-indexdefs and then run the xsl to
create biblio-zebra-indexdefs.xsl ?

Status to Failed QA for now.

-- 
You are receiving this mail because:
You are watching all bug changes.