[Koha-bugs] [Bug 13526] Mandatory fields should not be able to be hidden in borrower self-registration

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13526

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
(In reply to M. Tompsett from comment #4)
> Comment on attachment 34991 [details] [review]
> Bug 13526 - Mandatory fields should not be able to be hidden in borrower
> self-registration
> 
> Review of attachment 34991 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: opac/opac-memberentry.pl
> @@ +235,5 @@
> >      my $BorrowerUnwantedField =
> >        C4::Context->preference("PatronSelfRegistrationBorrowerUnwantedField");
> >  
> > +    #Fetch the mandatory fields to compare against hidden fields
> > +    my @mandatory_fields = keys %{GetMandatoryFields($action)};
> 
> The GetMandatoryFields function is already called on line 62. This calls it
> again. Could this be optimized?

Probably. I was thinking that it's pointless doing the grep as well as a person
could just use the hash... I'll take another look at this pronto.

-- 
You are receiving this mail because:
You are watching all bug changes.