[Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 35147
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35147
[SIGNED OFF] Bug 13531 - bulkmarcimport bombs if no match is found Changed the
die statment to a warn allowing the import to continue.

Review of attachment 35147:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13531&attachment=35147)
-----------------------------------------------------------------

A minor QA comment.

::: misc/migration_tools/bulkmarcimport.pl
@@ +271,5 @@
>          my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch( $query, 0, 3, [$server] );
> +        # changed to warn so able to continue with one broken record
> +        if ( defined $error ) {
> +            warn "unable to search the database for duplicates : $error";
> +            next;

For consistency with the rest of the script, should this perhaps be:

next RECORD;

-- 
You are receiving this mail because:
You are watching all bug changes.