[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702

--- Comment #9 from Thomas Wright <tomsStudy at gmail.com> ---
(In reply to Martin Renvoize from comment #8)
> OK, I'm happy with the logic here.  I had to go digging a little to prove to
> mysefl that the assumption was valid.  (Lines 530 -> 539 in commit
> http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-
> tmpl/bootstrap/en/modules/opac-results.tt;
> hb=544520d6bdfacada4eba4caefedf42864db4b3a0#l529)
> 
> So, this patch does indeed fix the problem.. however as a side note, I
> really don't like seeing this kind of logic at the template level.. it's not
> testable and leads to repetative code :'(.
> 
> I'de rather see the template just ask the question 'to display, or not to
> display?', and have the actual logic involved in that question handled
> further up in the code, perferably in either C4/Suggestions.pm or as part of
> the Koha.preference plugin somehow.  That way, we'd have a testable fix. 
> Just a thought

Should I work on this?

-- 
You are receiving this mail because:
You are watching all bug changes.