[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jan 19 07:09:38 CET 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #209 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 34197
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34197
Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm

Review of attachment 34197:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6679&attachment=34197)
-----------------------------------------------------------------

::: C4/TmplTokenType.pm
@@ +90,5 @@
> +sub DECL              { $_decl }
> +sub PI                { $_pi }
> +sub DIRECTIVE         { $_directive }
> +sub COMMENT           { $_comment }
> +sub UNKNOWN           { $_unknown }

DECL, PI, COMMENT, and UNKNOWN seem to have no easy way to test them. Consider
improving testing coverage for TmplTokenType explicitly.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list