[Koha-bugs] [Bug 10855] Additional fields for subscriptions

Wed Jan 21 17:44:46 CET 2015

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #189 from Paola Rossi <paola.rossi at cineca.it> ---
Thanks, Jonathan.
I've applied the [13] patches against master 3.19.00.006 head 13526 (!).

As required in comment 172 [but I think that this step could also be added 
to the test plan in comment 171]
- try filters on columns.
a particular problem arose on FILTERING. See below.

Moreover, being this patch closely related to authorized values and categories, 
I was in doubt about the displaying of the branch-limited additional values, as 
it is described by 3.18 manual. I've provided a possible "solution". Please 
see all in the NB.1 below.

I think that on FILTERING there can be an error.
For now I pass the patch in the "Failed QA" status.

If FILTERING is not an error, and displaying AV is not a problem, and no other 
follow up is needed, I can sign off this patch attaching the 13 patches as 
usual.

---- FILTERING
RIGHT:
Some subscriptions had "periodicals" in a field of theirs. I've selected all of
 them in some way.
Filtering by "perioa" at once no subscription was expected to be selected.
It happened in 1 second (RIGHT) [subscriptions disappeared]
I cancelled all the filter value: all those subscriptions were expected to be 
selected.
It happened in 1 second (RIGHT) [subscriptions appeared again]
[Now there was no filter value]
Filtering by "perioà" at once [CTRL v] no subscription were expected to
selected.
It happened in 1 second (RIGHT).
RIGHT "Incremental" filtering:
Filtering by "perio" at once all those subscriptions were expected to be 
selected.
It happened (RIGHT): nothing changed in the table.
I added "a" at the right of the value, so I was "incrementally" filtering by
"perioa".
No subscription were expected to selected.
It happened in 1 second (RIGHT).

ERROR: "Incremental" filtering by adding diacritics exited in ERROR:
Some subscriptions had "periodicals" in a field of theirs. I've selected all of 
them in some way.
Filtering by "perio" all subscriptions were filtered (OK, like above RIGHT).
I added "à" at the right of the value, so I was "incrementally" filtering by
"perioà".
No limitation happened in the resulting table in 30 seconds (ERROR).
After 30 sec, I added "ò" at the right of the value, so I was "incrementally"
filtering by "perioàò".
No limitation happened in the resulting table in 30 seconds (ERROR).

This error didn't happened adding "incrementally" to "perio":
a Japanese (会) char, 
a number,
a Greek (γ) char.

This error occurred either on searching subscriptions' table or on serials 
claims' one.
---- FILTERING's ERROR END

NB1. A special case of authorized values is about categories with 
branches-limited AV. See:
<http://manual.koha-community.org/3.18/en/basicparams.html#authorizedvalues>
At point 232, [3.18] manual says about their setting:
"If you would like to limit this authorized value category to only specific 
libraries you can choose them from the 'Branches limitation' menu. To have it 
show for all libraries just choose 'All branches' at the top of the list."

This patch's behaviour about the branches-limited AVs was OK (RIGHT).
At my tests, patch is OK [=as plan require] on a category whose AVs are all
branch-limited, and 
also on a category whose AVs are a mixture of limited and not-limited.
As desired and required by this patch's test plans:
branches-limited AV are displayed on viewing a subscription,
(subscription-detail.pl)
(B) categories names [not the limited AVs' drop down list, like manual says]
are shown on editing a subscription (subscription-add.pl)
branches-limited AV are all displayed in the resulting tables,
branches-limited AV are all "filter-able" in the resulting tables,
(A) categories names [not the limited AVs' drop down list, like manual says]
are shown among search fields on the left on searching subscriptions.

IMO these branches-limited AV could also be displayed in the (A) drop down list
(A), to be available to the selecting user.
Assigning an attribute is not modifying/adding a value to a category. So IMO 
the (B) drop down list could also be shown.
In simple terms the limit in 3.18 manual would be updated from:
"To have it show"
to:
"A branch-limited AV is always shown to all libraries. To have it added and
modified"

Otherwise, if the current manual prevales, the part of this patch requiring to 
"show" AdVs could need to be reviewed. 
[Or Additional Values are not exactly a kind of Authorized Values.]

Anyway, now this sentence of the manual:
"If you would like to limit this authorized value category to only specific
libraries you can choose them from the 'Branches limitation' menu."
appears a little generic to me, not enough to let understand the "limit". 
The sentence could also be changed into:
"If you would like to limit this authorized value to only specific libraries
[...]"
because each AuV can be "limited".

NB2. This patch is closely related to authorized values&categories 
[adding/modifying].
http://manual.koha-community.org/3.18/en/basicparams.html#authorizedvalues
point 232: "Limit your Category to 10 characters  (something short to make it
clear what the category is for)"

The user of this enhancement 10855 would probably be interested in using more 
than 10 chars. This manual's warning limit might be increased.
------------------------------------------------

-- 
You are receiving this mail because:
You are watching all bug changes.