[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

--- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 35494
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35494&action=edit
Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions

This follow-up implements some things I think will improve on the
previous patches:

- Change the system preference name to "SuggestionsUseValues"
- Change the description of the preference to "Suggestions can be
  submitted using the following authorized values:"
- Move the new preference to the OPAC tab so that it is grouped with
  other suggestions-related preferences.
- Add the option offer no itemtype/collection code chooser on the
  submission form.
- Display the correct label on the submission form depending on the
  value of the SuggestionsUseValues preference.

To test, apply this patch on top of the previous ones. Test submission
of purchase suggestions through the OPAC and staff client with the
SuggestionsUseValues preference set to all the various choices: item
type, collection code, shelving location, and 'none.' The suggestion
forms should look correct and work correctly.

HOWEVER, neither the previous patches nor mine address the problem of
the suggestions management page's "organize by" option, which is
hard-coded to work with item types. Whether or not my patch is
acceptable this issue will need to be addressed.

-- 
You are receiving this mail because:
You are watching all bug changes.