[Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
The qa script fails with

1/ tab chars
2/ n FAIL   C4/SIP/t/SIPtest.pm
   FAIL   valid
       Name "Sip::error_detection" used only once: possible typo
3/
 FAIL   C4/SIP/Sip/MsgType.pm
   FAIL   valid
      UNIVERSAL->import is deprecated and will be removed in a future perl

There are not valid, they existed before this patch set.

But t/00-load.t now fails:
% prove t/00-load.t
t/00-load.t .. UNIVERSAL->import is deprecated and will be removed in a future
perl at C4/SIP/Sip/MsgType.pm line 22.
t/00-load.t .. 1/? Bailout called.  Further testing stopped:  ***** PROBLEMS
LOADING FILE 'C4::SIP::SIPServer'

#   Failed test 'use C4::SIP::SIPServer;'
#   at t/00-load.t line 47.
#     Tried to use 'C4::SIP::SIPServer'.
#     Error:  Could not find 00-load.xml in t/ at C4/SIP/Sip/Configuration.pm
line 32.
# Compilation failed in require at t/00-load.t line 47.
# BEGIN failed--compilation aborted at t/00-load.t line 47.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 1.
FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE
'C4::SIP::SIPServer'

To test, I did:
diff --git a/t/00-load.t b/t/00-load.t
index 7569606..238a349 100644
--- a/t/00-load.t
+++ b/t/00-load.t
@@ -43,7 +43,7 @@ find({
         $m =~ s{^.*/C4/}{C4/};
         $m =~ s{/}{::}g;
         return if $m =~ /Auth_with_ldap/; # Dont test this, it will fail on
use
-        return if $m =~ /SIPServer/; # SIP Server module has old package usage
+        return unless $m =~ /SIPServer/; # SIP Server module has old package
usage
         use_ok($m) || BAIL_OUT("***** PROBLEMS LOADING FILE '$m'");
     },
 }, $lib);

Otherwise, all looks good so far!

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.