[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

--- Comment #42 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to David Cook from comment #40)
> (In reply to Katrin Fischer from comment #39)
> > Hm, bit confused. 
> > 
> > I tested checkouts and returns with itemtype on the item level. 
> > For returns the itype column in statistics is set to NULL.
> > 
> > Can you please check?
> 
> Nice catch, Katrin!
> 
> This block:
> 
> @@ -1988,7 +1988,7 @@ sub AddReturn {
>                  branch => $branch,
>                  type => $stat_type,
>                  itemnumber => $item->{'itemnumber'},
> -                itemtype => $biblio->{'itemtype'},
> +                itemtype => $biblio->{'itype'},
>                  borrowernumber => $borrowernumber,
>                  ccode => $item->{'ccode'}}
>      );
> 
> Should actually be like this:
> 
> @@ -1988,7 +1988,7 @@ sub AddReturn {
>                  branch => $branch,
>                  type => $stat_type,
>                  itemnumber => $item->{'itemnumber'},
> -                itemtype => $biblio->{'itemtype'},
> +                itemtype => $item->{'itype'},
>                  borrowernumber => $borrowernumber,
>                  ccode => $item->{'ccode'}}
>      );
> 
> There's no such thing as $biblio->{'itype'}.

Indeed.
This patch seems to live a lot.

I've added a followup to correct this.
In fact the $biblio in AddReturn is not used nor set anywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.