[Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
OK. The test passes now.
Overall, it looks good. One small question:
This does not look good?

    $query .= $cancelled
      ? q|
                aqorders_transfers.ordernumber_from AS transferred_to,
                aqorders_transfers.timestamp AS transferred_to_timestamp
    |
      : q|
                aqorders_transfers.ordernumber_from AS transferred_from,
                aqorders_transfers.timestamp AS transferred_from_timestamp
    |;

Did you mixup to and from in the first line?
Please compare with the lines you removed:

-            aqorders_transfers.ordernumber_to AS transferred_to,
-            aqorders_transfers.timestamp AS transferred_to_timestamp

Parking in FQA

-- 
You are receiving this mail because:
You are watching all bug changes.