[Koha-bugs] [Bug 13645] New: Koha::Acquisition::Bookseller->search() performance / efficiency problems

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645

            Bug ID: 13645
           Summary: Koha::Acquisition::Bookseller->search() performance /
                    efficiency problems
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: abl at biblos.pk.edu.pl
        QA Contact: testopia at bugs.koha-community.org

After Bug 12896, loading times for some acqui scripts increased quite
significantly, e.g. (for a test setup with ca 170 bookseller records in the
database):

   acqui/booksellers.pl: before - 800ms, after - 4100ms
   acqui/invoices.pl: before - 650ms, after - 3900ms

Koha::Acquisition::Bookseller->search(), especially when called with empty
search string in order to fetch list of all booksellers, seems to be very
inefficient.

Looks like it is predominantly caused by lack of DBIx object / DB connection
caching (?). For each bookseller record found, search() method calls fetch()
individually. Each time fetch() is getting called, it creates (and destroys on
exit) a brand new Koha::Database object (and probably a brand new DB connection
as well ?), which is rather expensive performance-wise.

-- 
You are receiving this mail because:
You are watching all bug changes.