From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 01:59:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jun 2015 23:59:43 +0000 Subject: [Koha-bugs] [Bug 11991] "Item is already waiting" message after in-transit item on hold checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11991 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Heather Braum --- Koha still behaves as this report describes, but we are no longer interested in pursuing changes. The current behavior is good enough. What's the best way to close this bug report? Resolved --> Wontfix? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 01:59:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jun 2015 23:59:54 +0000 Subject: [Koha-bugs] [Bug 11991] "Item is already waiting" message after in-transit item on hold checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11991 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:00:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 00:00:19 +0000 Subject: [Koha-bugs] [Bug 11992] detail.pl display issue after item on hold & in transit is checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11992 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Heather Braum --- Koha still behaves as this report describes, but we are no longer interested in pursuing changes. The current behavior is good enough. What's the best way to close this bug report? Resolved --> Wontfix? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:10:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 00:10:33 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:10:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 00:10:36 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40699|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 40741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40741&action=edit [SIGNED OFF] Bug 14468: Remove warnings when creating Labels This patch removes 2 types of warnings when creating Labels a) Using '0' as filling char is not to the like of prStrWidth On C4/Creators/Layout.pm b) A RM followup from Galen on Bug 8375 to C4/Creators/PDF.pm makes impossible to find properly a font :( (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=f7ef93e758850e991091e7268b8d1b1453082df4) on C4/Labels/Label.pm To test: Pre patch 1) Go to Tools > Labels 2) Create a new layout, name ABC, type 'Barcode/Biblio' 3) Create a new batch, add 2 items 4) Export as PDF using the new layout 5) Look at logs, you will find something like a) label-create-pdf.pl: Use of uninitialized value $strwidth in numeric lt (<) at /home/bgkriegel/kohaclone/C4/Creators/Layout.pm line 233., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl (Only one of this kind) b) Two related lines similar to this examples label-create-pdf.pl: Use of uninitialized value in -e at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 226., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl label-create-pdf.pl: ERROR in koha-conf.xml -- missing /path/to/font.ttf at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 229., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl (many many lines x number of items on batch) 6) Apply the patch 7) Export the same PDF, no more warnings 8) Bonus 1: change main font to Courier and Helvetica and check results 9) Bonus 2: check using arabic records Many hours to find :( Easy to fix Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:12:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 00:12:17 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #8 from Nick Clemens --- Bonus 1 - Works! Bonus 2 - I only tried with pasting arabic text in as call number but it displayed nicely in PDF which I think is an improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:28:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 00:28:40 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #5 from Heather Braum --- Checking back in to see if the patch for this has moved forward, any further. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:02:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 02:02:51 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:02:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 02:02:54 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40681|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 40742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40742&action=edit [SIGNED OFF] Bug 14467 - Security updates break some Koha plugins The new security updates break previously functioning plugins, most notably the cover flow plugin and the Ebsco EDS plugin. Test Plan: 1) Install and configure the cover flow plugin ( http://bywatersolutions.com/koha-plugins/ ) 2) Note that attempting to access coverflow.pl from the OPAC results in an error 3) Apply this patch 4) Note that coverflow.pl now output html again Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 06:23:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 04:23:34 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 06:23:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 04:23:36 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #3 from Aleisha Amohia --- Created attachment 40743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40743&action=edit Bug 14445: Silences warns in letter.tt When creating a new notice, warn is triggered "Argument "" isn't numeric in numeric gt (>) at line 400". Same warn is triggered when changing Koha module option to any other module. To test: 1) Go to Tools, then Notices & Slips 2) Click 'new notice'. Notice warn in intranet-error.log 3) Change Koha module to another module. Notice warn is triggered for every change 4) Apply patch and reload page 5) Change Koha module to another module. Notice there are no longer warns 6) Go back to Notices & Slips and click 'new notice' again. Notice there are no warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:02:34 +0000 Subject: [Koha-bugs] [Bug 14480] New: Warns when modifying patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 Bug ID: 14480 Summary: Warns when modifying patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate warns, go to any patron page (ie a link such as http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1369) and click 'Edit' memberentry.pl: Argument "" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/members/memberentry.pl line 566 memberentry.pl: Argument "" isn't numeric in numeric lt (<) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt line 949 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:15:39 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:15:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:15:42 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 --- Comment #1 from Aleisha Amohia --- Created attachment 40744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40744&action=edit Bug 14480: Silences warns triggered when modifying patron These warns are triggered when editing a patron: memberentry.pl: Argument "" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/members/memberentry.pl line 566 memberentry.pl: Argument "" isn't numeric in numeric lt (<) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt line 949 To test: 1) Go to any patron (ie this link http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1369) 2) Click Edit 3) Notice the above warns 4) Apply patch and reload page 5) Notice warns are gone but page still works correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:19:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:19:14 +0000 Subject: [Koha-bugs] [Bug 14481] New: Warns when setting permissions for patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Bug ID: 14481 Summary: Warns when setting permissions for patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate warns, go to any patron and click More --> Set permissions (ie follow this link http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-flags.pl line 176 member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-flags.pl line 176 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:23:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:23:24 +0000 Subject: [Koha-bugs] [Bug 14481] Warns when setting permissions for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:23:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:23:26 +0000 Subject: [Koha-bugs] [Bug 14481] Warns when setting permissions for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 --- Comment #1 from Aleisha Amohia --- Created attachment 40745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40745&action=edit Bug 14481: Silences warns triggered when setting patron permissions Use of uninitialized value $roadtype To test: 1) Go to any patron page and click More --> Set permissions (or follow this link --> http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=1369) 2) Notice the warns 3) Apply patch and reload page 4) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:27:34 +0000 Subject: [Koha-bugs] [Bug 14482] New: Warns when exporting patron's checked-in barcodes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 Bug ID: 14482 Summary: Warns when exporting patron's checked-in barcodes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate warns, go to any patron page and click More --> Export today's checked in barcodes readingrec.pl: Use of uninitialized value $borrowercardnumber in concatenation (.) or string at /home/vagrant/kohaclone/members/readingrec.pl line 88 readingrec.pl: Use of uninitialized value $borrowercardnumber in concatenation (.) or string at /home/vagrant/kohaclone/members/readingrec.pl line 88 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:30:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:30:38 +0000 Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in barcodes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:30:40 +0000 Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in barcodes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 --- Comment #1 from Aleisha Amohia --- Created attachment 40746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40746&action=edit Bug 14482: Silences warns triggered when exporting patron's checked in barcodes Use of uninitialized value $borrowercardnumber To test: 1) Go to any patron page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1369), click 'More' then 'Export today's checked in barcodes' 2) Notice warns in error log 3) Click cancel on the pop-up 4) Apply patch, reload page, click 'More' then 'Export today's checked in barcodes' again 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:35:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:35:29 +0000 Subject: [Koha-bugs] [Bug 14483] New: Warns when printing summary slip for patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483 Bug ID: 14483 Summary: Warns when printing summary slip for patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate, go to any patron page, click Print --> Print summary summary-print.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/summary-print.pl line 61 summary-print.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/summary-print.pl line 61 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:38:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:38:17 +0000 Subject: [Koha-bugs] [Bug 14483] Warns when printing summary slip for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:38:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:38:20 +0000 Subject: [Koha-bugs] [Bug 14483] Warns when printing summary slip for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483 --- Comment #1 from Aleisha Amohia --- Created attachment 40747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40747&action=edit Bug 14483: Silences warns triggered when printing summary slip for patron Use of uninitialized value $roadtype To test: 1) Go to any patron's page, click Print --> Print summary 2) Notice warns in error log 3) Click cancel, apply patch, reload page 4) Click Print --> Print summary 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:40:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:40:41 +0000 Subject: [Koha-bugs] [Bug 14484] New: Warns when changing patron password Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Bug ID: 14484 Summary: Warns when changing patron password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate, go to any patron's page and click Change Password member-password.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-password.pl line 105 member-password.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /home/vagrant/kohaclone/members/member-password.pl line 105 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:42:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:42:41 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 05:42:44 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 --- Comment #1 from Aleisha Amohia --- Created attachment 40748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40748&action=edit Bug 14484: Silences warns triggered when changing patron password Use of uninitialized value $roadtype To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 10:15:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 08:15:18 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 16:27:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 14:27:01 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 16:29:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 14:29:52 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 --- Comment #3 from Fridolin SOMERS --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > Hi, > on unimarc/dom install, I can link 610 with new auth, and auth search shows > 1 link etc... without patch! Mmmh, the search is made on the authority id, maybe this authority is already used somewhere else in your catalogue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:41:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 17:41:14 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #33 from Kyle M Hall --- (In reply to Bernardo Gonzalez Kriegel from comment #32) > Hi, > on your first patch you add on kohastructure.pl > `printed` tinyint(1) DEFAULT NULL, > for reserves and old_reserves > > But on final updatedatabase.pl (needs to be on atomicupdate!), you > "only" alter reserves but using a different type > > $dbh->do("ALTER TABLE reserves ADD printed DATETIME NULL AFTER > suspend_until"); > > Both patches have conflicts Good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:42:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 17:42:04 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:42:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 17:42:07 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36833|0 |1 is obsolete| | Attachment #36834|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 40749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40749&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 17:42:14 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #35 from Kyle M Hall --- Created attachment 40750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40750&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:42:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 17:42:17 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #36 from Kyle M Hall --- Created attachment 40751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40751&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 20:05:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 18:05:18 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #37 from Bernardo Gonzalez Kriegel --- All patches apply, but think you need to add this line to atomicupdate file: ALTER TABLE old_reserves ADD printed DATETIME NULL AFTER suspend_until; Both tables are modified on kohastructure Is 'Signed Off' the right status? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 22:23:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 20:23:51 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 22:23:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Jul 2015 20:23:53 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40697|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver --- Created attachment 40752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40752&action=edit Bug 14464 - Add ability to cancel waiting holds from checkin screen Test plan: 1. Ensure that ExpireReservesMaxPickUpDelayCharge is set to 0. 2. Place a hold (doesn't matter whether it's a bib/item-level hold), then confirm the hold by checking it in. 3. Check in the item again, and hit Cancel. 4. The reserve in question should be cancelled. 5. Repeat steps 2-4 twice, once after setting ExpireReservesMaxPickUpDelayCharge to a nonzero value and again after clicking the "Forgive fees for manually expired holds" checkbox. A fine should only be applied when the syspref is enabled and the checkbox is not checked. Also, the checkbox should only appear after enabling the syspref. And finally, the checkbox should remember whether it is checked across multiple checkins, same as the "Forgive overdue charges" and "Book drop mode" checkboxes. Signed-off-by: Jason Burds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 05:42:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 03:42:11 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 07:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 05:02:41 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 10:07:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 08:07:50 +0000 Subject: [Koha-bugs] [Bug 14485] New: HTML comment disables translation in cataloguing/addbooks.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Bug ID: 14485 Summary: HTML comment disables translation in cataloguing/addbooks.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 10:22:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 08:22:32 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #8) > Pinging Chris This has been pushed to master before the 3.20 release, so it can be marked as resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 10:42:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 08:42:50 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40488|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 40753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40753&action=edit Bug 14435: Drop table saved_reports The table saved_reports is never populated and is not used since 14be4400d84b28369d095b3b0bfa79c3396f44d4 (2009). The 2 subroutines store_results and format_results are never reachable and will also be removed. Note that an empty column "Saved results" were always displayed on the saved report list. Test plan: 0/ Confirm that there is nothing in the saved_reports table and that you have never seen something in it before. 1/ After applying the patch, confirm that you have still acess to the saved report list (reports/guided_reports.pl?phase=Use saved) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 10:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 08:42:58 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 10:43:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 08:43:00 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 --- Comment #1 from Fridolin SOMERS --- Created attachment 40754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40754&action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment. Test plan : - without patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 10:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 08:44:20 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #6 from Jonathan Druart --- (In reply to M. Tompsett from comment #3) > Comment on attachment 40488 [details] [review] > Bug 14435: Drop table saved_reports > > Review of attachment 40488 [details] [review]: > ----------------------------------------------------------------- > > My quick eyeball only noticed this. Not tested yet. > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt > @@ +345,1 @@ > > > > Unmatched , I believe. Good catch! Fixed in the last patch. (In reply to M. Tompsett from comment #4) > Comment on attachment 40489 [details] [review] > Bug 14435: Drop table saved_reports - DB Changes > > Review of attachment 40489 [details] [review]: > ----------------------------------------------------------------- > > The drop table saved reports atomic update is empty. What do you mean? The file is empty? --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_14435_drop_table_saved_reports.sql @@ -0,0 +1 @@ +DROP TABLE IF EXISTS saved_reports; It only contains 1 line but it's not empty :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 10:51:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 08:51:41 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 --- Comment #2 from Fridolin SOMERS --- Maybe there are other places where HTML comment should be converted. In my opinion, HTML comments should not be used since we can use TT comments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 10:59:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 08:59:00 +0000 Subject: [Koha-bugs] [Bug 13739] KohaDates should display hours if they exists by default unless specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 --- Comment #6 from Jonathan Druart --- Kyle, Before your patch, [% my_date | $KohaDates as_due_date => 1 %] worked to display a date as a due date. After your patch, this parameter is not checked to display the date as requested. And you should also have a look at t/db_dependent/Koha_template_plugin_KohaDates.t, the tests don't pass with your patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:22:02 +0000 Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:22:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:22:08 +0000 Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #13 from Jonathan Druart --- Created attachment 40756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40756&action=edit Bug 13853: Add tests for is_waiting Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:22:05 +0000 Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40673|0 |1 is obsolete| | Attachment #40674|0 |1 is obsolete| | Attachment #40675|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 40755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40755&action=edit Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax datatable We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Place a second hold and set it to waiting by checking it in 4) Place a third hold with an expiration date 5) View the holds tab on circulation.pl and moremember.pl 6) Note the first hold has no expiration date 7) Note the second hold has an expiration date of today + ReservesMaxPickUpDelay days 8) Note the thrid hold has an expiration date of whatever you set it to Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:22:12 +0000 Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #14 from Jonathan Druart --- Created attachment 40757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40757&action=edit Bug 13853 [QA Followup] - Add unit tests for branch getting methods Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:22:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:22:15 +0000 Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #15 from Jonathan Druart --- Created attachment 40758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40758&action=edit Bug 13853: (follow-up) unit tests Specify the reference, we should receive Koha::Object. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:22:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:22:56 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:23:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:23:13 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:31:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:31:50 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #33 from Jonathan Druart --- Oops, it seems that my pass qa was an error. Not a big deal, but looking at the diff, it seems that the code could be improved: in the template, we have: IF RESERVED display_button ELSIF RESERVE_WAITING display_button Could be changed with a IF RESERVED or RESERVE_WAITING. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:46:50 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 11:51:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 09:51:55 +0000 Subject: [Koha-bugs] [Bug 14431] Encoding issues - search in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 --- Comment #9 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #8) > Please add a regression test in t/db_dependent/www/search_utf8.t I'd say the existing tests are enough. Could someone confirm? Tomas, looking at http://jenkins.koha-community.org/job/Koha_Master_D7/lastBuild/testReport/%28root%29/ the tests are not launch by jenkins, they should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:06:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:06:46 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #78 from Jonathan Druart --- FAIL C4/Members.pm OK critic FAIL forbidden patterns forbidden pattern: trailing space char (line 1493) OK pod OK spelling OK valid FAIL misc/cronjobs/membership_expiry.pl OK critic FAIL forbidden patterns forbidden pattern: trailing space char (line 172) forbidden pattern: trailing space char (line 226) forbidden pattern: trailing space char (line 121) forbidden pattern: trailing space char (line 36) forbidden pattern: trailing space char (line 156) forbidden pattern: trailing space char (line 176) forbidden pattern: trailing space char (line 115) FAIL pod *** ERROR: Apparent command =cut not preceded by blank line in file misc/cronjobs/membership_expiry.pl FAIL spelling Usefull ==> Useful OK valid Please run the qa script before submitting patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:09:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:09:35 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:09:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:09:37 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #2 from Kyle M Hall --- Created attachment 40759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40759&action=edit Bug 11250 - "too many holds" message appears inappropriately This patch gives the various reasons precedence in this order: 1) Already in possesion 2) Already on hold 3) Age restricted 4) No items available 5) Too many holds Test Plan: 1) Attempt to place a hold where both "too many holds" and "no items available" messages display 2) Apply this patch 3) Refresh 4) Note only the "no items available" message displays -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:09:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:09:47 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:15:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:15:56 +0000 Subject: [Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6427 --- Comment #1 from Kyle M Hall --- I believe bug 6427 will resolve this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:15:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:15:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13098 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:18:26 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #118 from Jonathan Druart --- (In reply to Kyle M Hall from comment #116) > B) Switch back to the original patch set ( using a new db column to store > the last borrower to check out an item ) It seems that at least 3 persons (Paul, Galen and Katrin) have raised concerns about it, so I'm not sure it's a good idea. But it would be great to get their opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:33:22 +0000 Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links for other branches' items in staff detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:34:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:34:56 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #9 from Jonathan Druart --- Kyle, Thanks for these patches, it's a much more complete solution than the one I have proposed. I have a doubt with the changes in GetReserveFee: Before the patches: if ( $const eq "a" ) { push @biblioitems, $data1; } else { some code; } now you always execute some code. But before the patch, $const was sometime equal to "a". I am not sure about the consequences of this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:40:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:40:28 +0000 Subject: [Koha-bugs] [Bug 14431] Encoding issues - search in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 --- Comment #10 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #9) > (In reply to Tom?s Cohen Arazi from comment #8) > > Please add a regression test in t/db_dependent/www/search_utf8.t > > I'd say the existing tests are enough. Could someone confirm? > > Tomas, looking at > http://jenkins.koha-community.org/job/Koha_Master_D7/lastBuild/testReport/ > %28root%29/ the tests are not launch by jenkins, they should. You are right, I only set those tests to be run on 14.04 when we pushed them, and left the other VMs 'for later'. I'll try to set it. Sorry for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 12:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 10:52:48 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #101 from Jonathan Druart --- (In reply to Jesse Weaver from comment #99) > Will be posting a followup soon. For 1/ 2/, I have still the same issues. I also tested on sandbox 1 to confirm it didn't come from my install. > > 3/ On adding a new record, I get: > > > > 000 > > 100 _ _ > > 101 _ _ $a fre > > 801 _ _ > > > > What about the other fields? > > You don't retrieve default values, is it expected? > > Other fields are added as needed; the only fields that show up in a new > record are mandatory fields. 200$a is mandatory and does not appears. > It would be easy enough to fill in default values. IMO it should be a requirement. > > 4/ When the focus is on a dropdown list, there is no way to continue editing > > without the mouse (tab put the focus on "keywords", on the left. enter does > > not do anything) > > This is odd, what field and subfield caused this bug? UNIMARC 101$a for instance. > > 6/ I see > > GET http://pro.koha-qa.vm/intranet-tmpl/prog/en/data/marc21_field_006.xml > > GET http://pro.koha-qa.vm/intranet-tmpl/prog/en/data/marc21_field_008.xml > > in Firebug. But I use UNIMARC. Is it normal? > > > > Fixed. I still see them (see http://pro.test1.biblibre.com/cgi-bin/koha/cataloguing/editor.pl#new/ today or install the patches on sandbox 1). > > 7/ Try to reproduce the encoding error, I edited another record, but get > > TypeError: nonRepeatableSubfields[field.tagnumber(...)] is undefined > > koha-backend.js (ligne 201) > > > > on clicking on "Save" (I haven't click on the editor, so no previous js > > error). > > > > hum... Did I miss something here? > > I've seen this bug pop up a time or two, could I see the record in question? Will see later and other bugs will be fixed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 13:26:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 11:26:18 +0000 Subject: [Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 13:26:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 11:26:21 +0000 Subject: [Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40598|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 40760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40760&action=edit Bug 14345: broken isbn logic prevents display of idreambooks image TEST PLAN --------- 1) Ensure you have a book that would pull up an idreambooks image (e.g. The road to character / David Brooks.) -- I imported from the Library of Congress via z39.50 2) Ensure your system preferences for idreambook stuff is set. 3) Ensure you have multiple 020$a's for your book, and the first one must just be an ISBN number! -- I removed the '(hardcover: acidfree paper)' from the first. -- I took the second 020 field and changed 020$z to 020$a 4) Search for that book in OPAC and go to details. -- There should be a readometer image, but it will be broken. -- Notice the ISBN line has "#############; ..." This could also be attained by just putting two semi-colon separated ISBN's on the first 020$a. 5) Apply this patch 6) Refresh page -- readometer image appears. YAY! 7) run koha qa test tools NOTE: Only changed test plan, so leaving sign-off on. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 13:50:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 11:50:32 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20488|0 |1 is obsolete| | Attachment #20489|0 |1 is obsolete| | Attachment #20490|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 40761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40761&action=edit Bug 10314 - CanItemBeReserved does not respect the holds policies CanItemBeReserved will return 1 as long as the circulation rules have a non-zero number of holds allowed and the patron hasn't reached his or her "Holds allowed" count. However, the subroutine completely ignores the holds policies which would contravene reserving the item even if the patron has not reached the maximum holds allowed count. Test Plan: 1) Place an item on hold for a patron 2) Clear any existing hold policies 3) Set the appropriate circ rule so that the patron should be allowed 4) Attempt to place am item-level hold for this item/patron, it should succeed 5) Create a hold policy rule that would stop this patron from placing a hold on this item 6) Attempt to place an item-level hold on this item/patron, it should fail, but instead it will succeed 7) Apply this patch 8) Repeat step 6, this time you should be unable to place a specific hold on this item Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 13:50:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 11:50:38 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 --- Comment #18 from Kyle M Hall --- Created attachment 40762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40762&action=edit Bug 10314 - CanItemBeReserved does not respect the holds policies - Followup - QA Bugfix Signed-off-by: Katrin Fischer Passes all tests and QA script. Note: Unit tests to ensure the fix has the desired effect and behaviour is not accidentally changed in the future should be added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 14:13:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 12:13:58 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- Sorry, there is something wrong in my configuration, I don't manage to test plugins (always got a 403). I am wondering if it's useful to put Cwd in the deps list, it's part of the Perl core modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 14:29:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 12:29:52 +0000 Subject: [Koha-bugs] [Bug 14486] New: C4/Accountlines.pm needs better documentation and removal of stale code Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14486 Bug ID: 14486 Summary: C4/Accountlines.pm needs better documentation and removal of stale code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The documentation in C4/Accountlines.pm is confusing. There is no clear statement of what the module is for, and some poor programmer has sprinkled the code with 'FIXME' comments to the effect of "I don't understand what this function does." The intent and proper use of these functions should be documented, and the FIXME comments should be removed. fixaccounts() is entirely commented out. This should be removed. The following functions are not documented: chargelostitem() getcharges() ModNote() getcredits() getrefunds() ReversePayment() makepartialpayment() These should have at least minimal documentation saying "It does what you think it does", and any functions which modify the accountlines need a complete explanation of what they're changing in the database and why. The weakness of the accountlines table is that there is no link between fines and issues/old_issues which is a perennial source of bugs. This needs to be explicitly documented as a gotcha. Obviously work on documentation will be obsoleted by Bug 6427 - Rewrite of the accounts system, but in some sense, because the re-write is supposed to work with legacy code, I feel that the lack of clear documentation in the old code is an impediment to the testing of the new. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 15:40:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 13:40:19 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40742|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 40763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40763&action=edit Bug 14467 - Security updates break some Koha plugins The new security updates break previously functioning plugins, most notably the cover flow plugin and the Ebsco EDS plugin. Test Plan: 1) Install and configure the cover flow plugin ( http://bywatersolutions.com/koha-plugins/ ) 2) Note that attempting to access coverflow.pl from the OPAC results in an error 3) Apply this patch 4) Note that coverflow.pl now output html again Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Since Cwd is part of the Perl code modules, it's certainly useless to put it in the dependency list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 15:40:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 13:40:17 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 15:56:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 13:56:35 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 15:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 13:56:38 +0000 Subject: [Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38848|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 40764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40764&action=edit Bug 14107: Patron cards: Make barcode width and height scaling editable The size of the barcode in patron card creator was hardcoded to 1% of the card height and 80% of the card width. This patch exposes both values in the layout editor. If no values are given, the previousely hard coded values (0.01 / 0.8) are used in order to work with existing card definitions. To test: - Go to Home > Tools > Patron card creator - Export a patron card (PDF) from en existing definition - Apply patch - Export patron card again, compare results (should be the same) - Go to Home > Tools > Patron card creator > Manage card layouts - Edit the layout you use for testing and set barcode scaling values e.g. to 0.03 for height and 0.4 for widht - Export patron card again, verify that barcode size changed Signed-off-by: Chris Nighswonger Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 15:58:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 13:58:47 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #18 from Jonathan Druart --- Comment on attachment 40677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40677 Bug 13517 [QA Followup] - Add unit tests Review of attachment 40677: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13517&attachment=40677) ----------------------------------------------------------------- Please amend the last patch. ::: t/db_dependent/Hold.t @@ +48,5 @@ > is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if ReservesMaxPickUpDelay is not set"); > > is( $hold->is_waiting, 1, 'The hold is waiting' ); > +is( $hold->is_found, 1, 'The hold is found'); > +isnt( $hold->is_in_transit, 'The hold is not in transit' ); This is wrong. @@ +66,5 @@ > $dt = $hold->waiting_expires_on(); > is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to empty string )"); > isnt( $hold->is_waiting, 1, 'The hold is not waiting (W)' ); > +is( $hold->is_found, 0, 'The hold is not found' ); > +isnt( $hold->is_in_transit, 'The hold is not in transit' ); Same here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 15:58:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 13:58:55 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:03:05 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Jesse, You have to provide tests for changes in subroutines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:13:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:13:05 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Olli, You have to provide changes for the record.abs file, have a look at this wiki page: http://wiki.koha-community.org/wiki/MRenvoize/zebra#DOM_indexing to generate the xsl and xml files from record.abs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:19:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:19:09 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Jonathan Druart --- Maybe not, waiting for an answer from Tomas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:21:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:21:35 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 --- Comment #7 from Olli-Antti Kivilahti --- I know nothing about the record.abs Is that something new? I haven't seen other bugs that modify indexes to modify record.abs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:22:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:22:19 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Severity|enhancement |minor CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:22:28 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |jonathan.druart at biblibre.co | |m Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:22:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:22:35 +0000 Subject: [Koha-bugs] [Bug 14481] Warns when setting permissions for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:22:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:22:41 +0000 Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in barcodes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Severity|enhancement |minor CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:22:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:22:51 +0000 Subject: [Koha-bugs] [Bug 14483] Warns when printing summary slip for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:22:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:22:57 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:23:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:23:34 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:30:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:30:16 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart --- Fridolin, I am not sure it's right fix. In the po files, I get: msgid "%s %s No results found %s %s %s %s result(s) found in catalog, " Which is not easily translatable. I'd suggest to put span around the strings in order to have something like: msgid "%s result(s) found in catalog," and msgid "No results found" By the way this second string is already translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:36:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:36:47 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart --- I'd suggest my $roadtype = C4::Koha::GetAuthorisedValueByCode( 'ROADTYPE', $bor->{streettype} ) // ''; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:38:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:38:23 +0000 Subject: [Koha-bugs] [Bug 14483] Warns when printing summary slip for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Jonathan Druart --- You have re-added the entire file: CONFLICT (add/add): Merge conflict in members/summary-print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:47:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:47:20 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 --- Comment #2 from Jonathan Druart --- Comment on attachment 40744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40744 Bug 14480: Silences warns triggered when modifying patron Review of attachment 40744: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14480&attachment=40744) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +916,4 @@ >
> Patron restrictions > > + [% IF ( debarments.size && debarments.size < 1 ) %] It should be IF debarments and debarments.size That makes more sense. ::: members/memberentry.pl @@ +563,4 @@ > > if ($default_city) { # flag the current or default val > for my $city ( @{$city_arrayref} ) { > + if ($default_city eq $city->{cityid}) { I don't get this warning but cityid is an integer, so == makes sense. $default_city is tested before so cityid is empty? Don't understand how it's possible (comes from the DB, stored as int) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:47:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:47:27 +0000 Subject: [Koha-bugs] [Bug 14480] Warns when modifying patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:52:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:52:21 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #4 from Jonathan Druart --- $code //= ''; should be put at the beginning of the subroutine, not right in the middle :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:53:25 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #5 from Jonathan Druart --- Comment on attachment 40743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40743 Bug 14445: Silences warns in letter.tt Review of attachment 40743: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14445&attachment=40743) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt @@ +397,4 @@ >
  • > > [% IF letter.message_transport_type == 'sms' %] > + [% IF letter.length && letter.length > 0 %][% letter.length %][% ELSE %]0[% END %]/160 characters This is wrong, we want to display the length of the content. With your patch, the string displayed is always "Message body: 0/160 characters" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:53:34 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 16:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 14:56:38 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 --- Comment #8 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #7) > I know nothing about the record.abs > Is that something new? > I haven't seen other bugs that modify indexes to modify record.abs? It's used for GRS1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 17:00:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 15:00:17 +0000 Subject: [Koha-bugs] [Bug 14437] Refactor C4::Auth::haspermission() to Koha::Object and return better errors. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 17:01:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 15:01:55 +0000 Subject: [Koha-bugs] [Bug 14437] Refactor C4::Auth::haspermission() to Koha::Object and return better errors. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14437 --- Comment #5 from Jonathan Druart --- Comment on attachment 40719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40719 Bug 14437 - Refactor C4::Auth::haspermission() to Koha::Object and return better errors. Review of attachment 40719: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14437&attachment=40719) ----------------------------------------------------------------- ::: C4/Auth.pm @@ +38,5 @@ > use List::MoreUtils qw/ any /; > use Encode qw( encode is_utf8); > > +use Koha::Exception::BadParameter; > +use Koha::Exception::UnknownObject; So should depend on bug 13995. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 17:02:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 15:02:01 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14437 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 17:02:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 15:02:01 +0000 Subject: [Koha-bugs] [Bug 14437] Refactor C4::Auth::haspermission() to Koha::Object and return better errors. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14437 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13995 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 17:03:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 15:03:32 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- Olli, could you please sent an email on koha-devel about this to explain your choices and get some feedbacks? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 17:44:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 15:44:56 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 17:44:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 15:44:59 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #1 from Jonathan Druart --- Created attachment 40765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40765&action=edit Bug 14388: Funds should be sorted by budget_code Before this patch, the funds were sorted by budget_id, which does not make any sense. This patch adds a sort by budget_code on the fund list (acqui/acqui-home.pl and admin/aqbudgets.pl) Test plan: On both pages (acqui/acqui-home.pl and admin/aqbudgets.pl) confirm that the funds are now sorted by fund code (DB column budget_code) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 17:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 15:45:15 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 18:12:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 16:12:30 +0000 Subject: [Koha-bugs] [Bug 14446] More noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- It comes from the null option of the OpacRenewalBranch pref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 19:38:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 17:38:36 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40701|0 |1 is obsolete| | --- Comment #79 from Amit --- Created attachment 40766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40766&action=edit Bug 6810: Squashed Fixes QA failures QA script result: Processing files before patches |========================>| 5 / 5 (100.00%) Processing files after patches |========================>| 5 / 5 (100.00%) OK C4/Members.pm OK critic OK forbidden patterns OK pod OK spelling OK valid OK misc/cronjobs/membership_expiry.pl OK critic OK forbidden patterns OK pod OK spelling 0 OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 20:00:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 18:00:22 +0000 Subject: [Koha-bugs] [Bug 13681] Enable/Disable Marc Frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13681 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 22:13:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 20:13:06 +0000 Subject: [Koha-bugs] [Bug 13467] acq tab still says ordered even if completed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13467 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 2 22:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 20:31:04 +0000 Subject: [Koha-bugs] [Bug 14487] New: Warns from returns.pl during checkin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Bug ID: 14487 Summary: Warns from returns.pl during checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Suppress these warns during returning an item returns.pl: Use of uninitialized value $holdingBranch in string eq at /home/l2c2technologies/koha/circ/returns.pl line 623., referer: http://kohamaster.l2c2.co.in/cgi-bin/koha/members/readingrec.pl?borrowernumber=51 returns.pl: Use of uninitialized value $collectionBranch in string eq at /home/l2c2technologies/koha/circ/returns.pl line 623., referer: http://kohamaster.l2c2.co.in/cgi-bin/koha/members/readingrec.pl?borrowernumber=51 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 00:17:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 22:17:57 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #102 from Jesse Weaver --- > > > > Other fields are added as needed; the only fields that show up in a new > > record are mandatory fields. > > 200$a is mandatory and does not appears. > Yes, as the 200 tag is not mandatory, but if any 200 field _does_ appear, it must have an $a subfield. This constraint is enforced when the record is saved. > > It would be easy enough to fill in default values. > > IMO it should be a requirement. > For pre-filled mandatory fields, yes. I'm a bit worried that filling in default values for other subfields as the record is edited would be a bit too much magic. > > > 4/ When the focus is on a dropdown list, there is no way to continue editing > > > without the mouse (tab put the focus on "keywords", on the left. enter does > > > not do anything) > > > > This is odd, what field and subfield caused this bug? > > UNIMARC 101$a for instance. > Reproduced, but I suspect this will be fixed by my fixes for some of these other issues. > > > 6/ I see > > > GET http://pro.koha-qa.vm/intranet-tmpl/prog/en/data/marc21_field_006.xml > > > GET http://pro.koha-qa.vm/intranet-tmpl/prog/en/data/marc21_field_008.xml > > > in Firebug. But I use UNIMARC. Is it normal? > > > > > > > Fixed. > > I still see them (see > http://pro.test1.biblibre.com/cgi-bin/koha/cataloguing/editor.pl#new/ today > or install the patches on sandbox 1). > Sorry, was a bit unclear, have found a fix for some of these issues but haven't submitted a patch yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 00:37:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 22:37:46 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #103 from Katrin Fischer --- Hm, I am not sure about only filling in the default values for mandatory fields - I think this is kind of confusing as the configuration options are not connected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 00:53:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 22:53:06 +0000 Subject: [Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #16 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 11250 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 00:53:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 22:53:06 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #3 from Nick Clemens --- *** Bug 10912 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 01:45:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 23:45:09 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #18 from M. Tompsett --- Nicole, if you could fix the whitespace issues below, I'll gladly sign off. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/members/member-flags.tt FAIL forbidden patterns forbidden pattern: tab char (line 128) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 74) forbidden pattern: tab char (line 465) forbidden pattern: tab char (line 206) forbidden pattern: tab char (line 132) forbidden pattern: tab char (line 467) forbidden pattern: tab char (line 130) forbidden pattern: tab char (line 224) forbidden pattern: tab char (line 432) forbidden pattern: tab char (line 429) forbidden pattern: tab char (line 125) forbidden pattern: tab char (line 222) forbidden pattern: tab char (line 91) forbidden pattern: tab char (line 225) forbidden pattern: tab char (line 131) forbidden pattern: tab char (line 93) forbidden pattern: tab char (line 204) forbidden pattern: tab char (line 523) forbidden pattern: tab char (line 207) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 521) forbidden pattern: tab char (line 431) forbidden pattern: tab char (line 468) OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/members/member.tt FAIL forbidden patterns forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 47) forbidden pattern: tab char (line 52) OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/members/members-home.tt FAIL forbidden patterns forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 54) forbidden pattern: tab char (line 44) OK tt_valid OK valid_template And for people who don't have time to figure out the UI (like myself), you can trigger them all directly using these URLs. Make sure to change {STAFF CLIENT} to the appropriate value (e.g. http://library-admin.debiankoha.ca) {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/member-flags.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/member.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/members-home.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/cataloguing/addbiblio.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/cataloguing/addbooks.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/cataloguing/merge.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/discharge.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/members/moremember.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/acqui/basket.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/acqui/newordersubscription.pl {STAFF CLIENT}/cgi-bin/koha/help.pl?url={STAFF CLIENT}/cgi-bin/koha/circ/on-site_checkouts.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 01:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jul 2015 23:49:29 +0000 Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35672|0 |1 is obsolete| | --- Comment #6 from Benjamin Rokseth --- Created attachment 40767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40767&action=edit Bug 13666 - Allow SIP2 checkin/checkout to get branch from institution_id field AO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 02:03:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 00:03:30 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #2 from M. Tompsett --- Comment on attachment 40765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40765 Bug 14388: Funds should be sorted by budget_code Review of attachment 40765: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14388&attachment=40765) ----------------------------------------------------------------- ::: t/db_dependent/Budgets.t @@ +428,5 @@ > ); > > $budget_hierarchy = GetBudgetHierarchy($budget_period_id); > +is( $budget_hierarchy->[0]->{children}->[0]->{budget_name}, 'budget_11', 'GetBudgetHierarchy should return budgets ordered by name, first child is budget_11' ); > +is( $budget_hierarchy->[0]->{children}->[1]->{budget_name}, 'budget_12', 'GetBudgetHierarchy should return budgets ordered by name, first child is budget_12' ); second child, not first. Please fix typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 02:10:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 00:10:19 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- I was not able to duplicate issue with Debian Jessie on Master. Though, this patch clearly forces sorting. Additionally, tests failed to run with my initial data set. Requires CPL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 02:25:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 00:25:08 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Summary|Prevent XSS everywhere at |Prevent XSS in the Staff |the OPAC |Client and the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 02:49:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 00:49:32 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #4 from M. Tompsett --- Comment on attachment 40759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40759 Bug 11250 - "too many holds" message appears inappropriately Review of attachment 40759: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11250&attachment=40759) ----------------------------------------------------------------- Though I like the shift to the IF/ELSIF structure, I'm not sure it addresses the first two comments. ::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ +309,5 @@ > +
  • [% borrowerfirstname %] [% borrowersurname %] already has a hold on this item
    • > + [% ELSIF ( ageRestricted ) %] > +
  • Age restricted
    • > + [% ELSIF ( none_available ) %] > +
  • No items are available to be placed on hold
    • There is a difference between none_available (but eventually some may) vs. comment #2's "{item} is not allowed to be placed on hold". Is there a way to check for this? @@ +311,5 @@ > +
  • Age restricted
    • > + [% ELSIF ( none_available ) %] > +
  • No items are available to be placed on hold
    • > + [% ELSIF ( maxreserves ) %] > +
  • Too many holds: [% borrowerfirstname %] [% borrowersurname %] has too many holds.
    • Similarly there is a minor difference between a borrower who has too many holds (non-zero), and one who isn't allowed to place any at all, as per my understanding of comment #1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 02:50:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 00:50:41 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- Sorry for the off-by-1 error in my comment. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 03:27:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 01:27:44 +0000 Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40767|0 |1 is obsolete| | --- Comment #7 from Benjamin Rokseth --- Created attachment 40768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40768&action=edit Bug 13666 - Allow SIP2 checkin/checkout to get branch from institution_id field AO last patch failed tests due to fuzzy patching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 03:32:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 01:32:29 +0000 Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40768|0 |1 is obsolete| | --- Comment #8 from Benjamin Rokseth --- Created attachment 40769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40769&action=edit Bug 13666 - Allow SIP2 checkin/checkout to get branch from institution_id field AO giving up on patching /etc/SIPconfig.xml ... for now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 04:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 02:47:04 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #6 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #5) > > This is wrong, we want to display the length of the content. > With your patch, the string displayed is always > "Message body: 0/160 characters" Hi Jonathan, this tests correctly for me, but do you know a better way to silence this warn? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 05:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 03:43:59 +0000 Subject: [Koha-bugs] [Bug 14483] Warns when printing summary slip for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483 --- Comment #3 from Aleisha Amohia --- Created attachment 40770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40770&action=edit Bug 14483: Same change but better Use of uninitialized value $roadtype To test: 1) Go to any patron's page, click Print --> Print summary 2) Notice warns in error log 3) Click cancel, apply patch, reload page 4) Click Print --> Print summary 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 05:44:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 03:44:48 +0000 Subject: [Koha-bugs] [Bug 14483] Warns when printing summary slip for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 07:11:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 05:11:02 +0000 Subject: [Koha-bugs] [Bug 14488] New: Multi-Volume ordering through acquisition Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14488 Bug ID: 14488 Summary: Multi-Volume ordering through acquisition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mishravk79 at gmail.com QA Contact: testopia at bugs.koha-community.org Dear All, I observed there is some difficulty while placing order for multivolume books which is described below: What to enter in acquisition in a Quantity field if a book is multi volume (say 10 volume) and library has to place one set, if we enter 10 than price will become ten times and if we enter only 1 than we will be able to receive only one item (one barcode) and rest 9 volumes we have to enter through catalog directly. There should be some check box option near quantity field for multi volume so if number of volumes is added it should not multiply the cost (i.e number of copy X price of one copy). But i am still confuse what will happen if a library wants to place two copy of a multi volume set? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 08:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 06:08:06 +0000 Subject: [Koha-bugs] [Bug 14408] Path traversal vulnerabilty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14408 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14467 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 08:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 06:08:06 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14408 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 08:09:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 06:09:22 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:18:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:18:19 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > I think we need to implement something more generic. I agree that if we are adding similar "overlay code" here and there, we will not improve the code. It is a workaround. If you would pick your translations from a new table, we would still be working on separate roads (translation table and PO files). Could we use the Koha::I18N approach here? This modules was pushed some time ago but without actual use. We should need two things at least: [1] add calls to gettext( $authvalue ) [2] add all authvalues to the PO creation process in misc/translator A similar approach could be used for item types etc. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:22:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:22:13 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 --- Comment #7 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #6) > [1] add calls to gettext( $authvalue ) Hm. Not dynamic enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:27:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:27:09 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Mirko Tietgen --- (In reply to Kyle M Hall from comment #13) > 3) prove t/db_dependent/Circulation_Issuingrule.t t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 2 wallclock secs ( 0.06 usr 0.02 sys + 1.98 cusr 0.23 csys = 2.29 CPU) Result: PASS > 4) prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 22/61 DBD::mysql::st execute failed: Duplicate entry '4' for key 'PRIMARY' at /home/mirko/koha/C4/Circulation.pm line 2100. DBD::mysql::st execute failed: Duplicate entry '4' for key 'PRIMARY' at /home/mirko/koha/C4/Circulation.pm line 2100. # Looks like you planned 61 tests but ran 43. # Looks like your test exited with 255 just after 43. t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 18/61 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 65280 Tests: 43 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 61 tests but ran 43. Files=1, Tests=43, 5 wallclock secs ( 0.07 usr 0.03 sys + 3.02 cusr 0.40 csys = 3.52 CPU) Result: FAIL > 5) prove t/db_dependent/Fines.t t/db_dependent/Fines.t .. DBIx::Class::ResultSet::create(): No such column chargeperiod_charge_at on Koha::Schema::Result::Issuingrule at t/db_dependent/Fines.t line 21 # Looks like your test exited with 255 before it could output anything. t/db_dependent/Fines.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 5/5 subtests Test Summary Report ------------------- t/db_dependent/Fines.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 0. Files=1, Tests=0, 3 wallclock secs ( 0.05 usr 0.03 sys + 1.84 cusr 0.23 csys = 2.15 CPU) Result: FAIL I ran updatedatabase before I tested, so I wonder if something is missing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:32:45 +0000 Subject: [Koha-bugs] [Bug 14427] Use Koha::version() instead of C4::Context->KOHAVERSION In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:32:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:32:47 +0000 Subject: [Koha-bugs] [Bug 14427] Use Koha::version() instead of C4::Context->KOHAVERSION In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40458|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 40771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40771&action=edit Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION While testing bug 9006, I discovered this gem in installer/install.pl TEST PLAN --------- 1) back up DB 2) drop db and create db 3) git reset --hard origin/3.20.x 4) run web installer and all sample data 5) git reset --hard origin/master 6) empty your koha intranet error log 7) run web installer to upgrade -- there will be warnings regarding regex around installer/install.pl line 328 or so. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 8) repeat steps 2-6 9) apply this patch 10) run web installer to upgrade -- no regex warnings. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 11) koha qa test tools Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:32:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:32:58 +0000 Subject: [Koha-bugs] [Bug 14427] Use Koha::version() instead of C4::Context->KOHAVERSION In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:41:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:41:09 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #1 from Indranil Das Gupta --- (In reply to Indranil Das Gupta from comment #0) > Suppress these warns during returning an item The warns have stopped for some reason. I need to investigate this a bit more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:41:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:41:56 +0000 Subject: [Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:41:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:41:59 +0000 Subject: [Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40361|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 40772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40772&action=edit Bug 14389 - Editing a syspref in a textarea does not enable the Save button Test plan: 1. Navigate to the "opaccredits" syspref (or any other textarea, i.e., "Click to Edit", syspref) in the system preferences editor. 2. Change its contents, by either pasting or typing. The field may not be marked as modified, even after you click outside the box. 3. Apply the patch. 4. Reload the page and try again; either pasting or typing should mark the field as changed and allow you to save. Signed-off-by: Jesse Weaver Confirmed working for normal input, paste and middle-click paste in Chrome and Firefox in Linux. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:42:28 +0000 Subject: [Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 09:50:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 07:50:44 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:11:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:11:03 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #2 from Indranil Das Gupta --- Created attachment 40773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40773&action=edit Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:12:07 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED --- Comment #3 from Indranil Das Gupta --- (In reply to Indranil Das Gupta from comment #1) > (In reply to Indranil Das Gupta from comment #0) > > Suppress these warns during returning an item > > The warns have stopped for some reason. I need to investigate this a bit > more. please ignore comment #1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:12:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:12:46 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:18:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:18:23 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > A similar approach could be used for item types etc. I had a try on bug 14100. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:19:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:19:41 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:19:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:19:44 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #11 from Marcel de Rooy --- Created attachment 40774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40774&action=edit Bug 11880: Select the barcode index by default then searching for label items. Test case: * Go to "Tools -> Label creator -> Manage batches" * Click on the "New batch" button * Click on the "Add item(s)" button * A search window should open. The "Barcode" value should be selected in the the selectbox. Followed test case. Patch behaves as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:19:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:19:49 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #12 from Marcel de Rooy --- Created attachment 40775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40775&action=edit Bug 11880: Select what has been selected before The previous patch wants to select the barcode option when the user is on the item search for label, in all cases. So even if 'title' is selected, a search done, and there is no result, the barcode index is selected anyway. In this case, the title option should be kept. Test plan: Confirm that the barcode option is the default choice, but other values are kept if the search does not return any result. Followed test plan, behaves as expected. Tested with all choices. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:20:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:20:17 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:20:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:20:19 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:20:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:20:21 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:21:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:21:17 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #13 from Marcel de Rooy --- Thx for cleaning up, Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:22:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:22:46 +0000 Subject: [Koha-bugs] [Bug 9525] group floating rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #12 from Mirko Tietgen --- Would test if it had a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:30:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:30:00 +0000 Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 --- Comment #16 from Olli-Antti Kivilahti --- With Swagger2-plugin extension I mean Koha::REST::V1::Plugins::KohaliciousSwagtenticator which extends Mojolicious::Plugin::Swagger2, making it possible to define the needed permissions in the swagger.json -file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:31:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:31:49 +0000 Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 --- Comment #17 from Olli-Antti Kivilahti --- (In reply to Julian Maurice from comment #13) > As SwaggerUI has its own bug now, the authentication code for SwaggerUI was > also moved in another bug: bug 14461 But I have a gut-feeling that I am misunderstanding what you mean with "the authentication code for SwaggerUI" Since the Swagtenticator-patch seems to still be in this bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:37:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:37:23 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #140 from Marcel de Rooy --- The number of patches this report touches does not justify the trivial patch status imo btw.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:38:10 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #141 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #140) > The number of patches this report touches does not justify the trivial patch > status imo btw.. patches -> files OR touches -> includes :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 10:59:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 08:59:45 +0000 Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 --- Comment #18 from Julian Maurice --- (In reply to Olli-Antti Kivilahti from comment #17) > But I have a gut-feeling that I am misunderstanding what you mean with > "the authentication code for SwaggerUI" > Since the Swagtenticator-patch seems to still be in this bug :) SwaggerUI (the thing in api/v1/doc) was modified to work with the authentication system proposed in this bug. Only these modifications were moved in another bug. Swagtenticator is still here and it's not a mistake ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 11:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 09:28:43 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 11:28:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 09:28:46 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40691|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 40776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40776&action=edit Bug 14382: Non-ISO Date parameters generate empty reports. The issue is that SQL expects ISO dates, but the user may wish to view dates according to the dateformat system preference. By detecting a date preference, the non-ISO dates can be converted to ISO dates before being stuffed back into the SQL query to be executed. TEST PLAN --------- 1) Add a report with date parameters. -- I used 'Holds placed in date range' from http://wiki.koha-community.org/wiki/SQL_Reports_Library 2) Set your dateformat to YYYY-MM-DD 3) Run the report -- Note the SQL reads "... BETWEEN '{date formatted in YYYY-MM-DD}'..." -- If there is supposed to be data, there is some. 4) Set your dateformat to MM/DD/YYYY 5) Run the report -- Note the SQL reads "... BETWEEN '{date formatted in MM/DD/YYYY}'..." -- If there is supposed to be data, there is none. 6) Apply patch 7) Repeat steps 2-5 -- The SQL will always read YYYY-MM-DD (ISO) format. -- The report will have data, if there is some. 8) koha qa test tools. Signed-off-by: Amit Gupta Signed-off-by: Marcel de Rooy Adding a QA follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 11:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 09:28:50 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 --- Comment #19 from Marcel de Rooy --- Created attachment 40777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40777&action=edit Bug 14382: [QA Follow-up] Bad regex alarm The regex /|date>>/ will match much more than you like :) The unescaped pipe is bad, but you also need to remove the >> because the split a few lines above it removes them already. This allows you to recover from an error like this one, running another report with a string parameter: The given date (india%) does not match the date format (us) at Koha/DateUtils.pm line 144. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 11:29:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 09:29:59 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #20 from Marcel de Rooy --- $a= "<>"; $b= "test"; if ($a =~ /|date>>/) { print "a true"; } if ($b =~ /|date>>/) { print "b true"; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 11:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 09:30:50 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 11:31:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 09:31:12 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 --- Comment #12 from Gaetan Boisson --- Does this need to remain in discussion? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 11:36:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 09:36:45 +0000 Subject: [Koha-bugs] [Bug 9525] group floating rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #13 from Olli-Antti Kivilahti --- +-----------------------------+ | USAGE TIPS (sorry didn't document these in the GUI | +-----------------------------+ When modifying a floating route rule, pressing "%" accepts the modification and pressing "V" cancels the modifications and reverts the old rule. The empty text box in the center of the route rule (under the floating type dropdown list) is the box for conditional rules, where you put the logical expression. +-----------------------------+ | SETTING UP THE TEST CONTEXT | +-----------------------------+ -2. Set syspref "HomeOrHoldingBranchReturn" to homebranch. -1. Find an Item, which can be circulated freely, and has homebranch B and any holdingbranch. 0. Read the instructions at admin/floating-matrix.pl. +-----------+ | TEST PLAN: Disabled floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Disabled" and vice versa (B -> A). 1. Set your current library to A. 2. Check-in the Item. 3. Observe the started transport to branch B. 4. Set your current library to B. 5. Check-in to receive the transfer. +-----------+ | TEST PLAN: Always floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Allowed". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is not transport prompt to branch B and the Item is not "in-transit" -state. +-----------+ | TEST PLAN: Possibly floating: +-----------+ 0. Make sure that the floating rules from branch A to branch B (A -> B) are "Possible". 1. Set your current library to A. 2. Check-in the Item. 3. Observe that there is a transport prompt to branch B. You can decide if you want to transfer or no. +-----------+ | TEST PLAN: Conditional floating: +-----------+ 0. Same as Always floating if the given condition matches. See the feature description at admin/floating-matrix.pl explaining Conditional floating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 12:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 10:27:06 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 12:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 10:27:54 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 13:23:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 11:23:06 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Hope I understood Marcel's comment correctly: I feel like the po process is not flexible enough for the values stored in the database. If you enter a new itemtype, you'd have to do 'server side' things first in order to get your additional translation show up. I think something in the GUI would be better here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 13:42:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 11:42:09 +0000 Subject: [Koha-bugs] [Bug 14488] Multi-Volume ordering through acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14488 Vinod changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 13:42:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 11:42:53 +0000 Subject: [Koha-bugs] [Bug 14488] Multi-Volume ordering through acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14488 Vinod changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com, | |kohapatch at gmail.com, | |mishravk79 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 13:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 11:45:39 +0000 Subject: [Koha-bugs] [Bug 14488] Multi-Volume ordering through acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14488 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P5 - low -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 13:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 11:53:16 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 15:05:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 13:05:00 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 --- Comment #21 from M. Tompsett --- Comment on attachment 40777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40777 Bug 14382: [QA Follow-up] Bad regex alarm Review of attachment 40777: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14382&attachment=40777) ----------------------------------------------------------------- ::: reports/guided_reports.pl @@ +754,4 @@ > my $quoted = $sql_params[$i]; > # if there are special regexp chars, we must \ them > $split[$i*2+1] =~ s/(\||\?|\.|\*|\(|\)|\%)/\\$1/g; > + if ($split[$i*2+1] =~ /\|date$/) { While I agree with the escaping (I really should have caught that, DOH!), the $ does not work. Why not leave >>? >'s are not special characters, are they? I was thinking it may be better to put: /\|\s*date\s*>>/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 15:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 13:50:39 +0000 Subject: [Koha-bugs] [Bug 14490] New: duplicate armenian translator Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Bug ID: 14490 Summary: duplicate armenian translator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: rdbiblio at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 15:55:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 13:55:31 +0000 Subject: [Koha-bugs] [Bug 14490] duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Samanta Tello changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samantatellob at yahoo.com.ar Assignee|nengard at gmail.com |samantatellob at yahoo.com.ar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:00:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:00:26 +0000 Subject: [Koha-bugs] [Bug 14490] duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:00:43 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|duplicate armenian |Duplicate armenian |translator |translator Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:01:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:01:37 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:10:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:10:17 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:20:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:20:23 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 --- Comment #1 from Samanta Tello --- Created attachment 40778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40778&action=edit Proposed patch Bug 14490: Duplicate armenian translator This patch fix trivial duplicate in about page. To test: 1) Go to about page > translations 2) Check duplicate entry for Armenian first in 4th line, second before indonesian 3) Apply patch 4) Reload page and check again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:21:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:21:13 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Samanta Tello changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:23:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:23:09 +0000 Subject: [Koha-bugs] [Bug 13764] Installation of git In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13764 Marcos Benincasa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |biblioprocesos at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:32:11 +0000 Subject: [Koha-bugs] [Bug 13764] Installation of git In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13764 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #1 from Nick Clemens --- Hi Rakesh, This is not really a bug, but a question much better suited to the mailing lists or IRC, info on both can be found here: http://koha-community.org/support/ For your issue, quick googling suggests there isn't a git package for Ubuntu 10.10, but there are some workarounds available: -http://stackoverflow.com/questions/17226056/how-to-install-git-client-in-ubuntu-10-10 -http://superuser.com/questions/209471/how-to-install-the-latest-git-version-on-ubuntu-10-10 Good luck! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:34:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:34:08 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40778|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 40779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40779&action=edit [SIGNED OFF]?Bug 14490: Duplicate armenian translator Works as expected. Trivial string fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:34:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:34:15 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:55:21 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 --- Comment #3 from Katrin Fischer --- Created attachment 40780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40780&action=edit [PASSED QA] Bug 14490: Duplicate armenian translator This patch fix trivial duplicate in about page. To test: 1) Go to about page > translations 2) Check duplicate entry for Armenian first in 4th line, second before indonesian 3) Apply patch 4) Reload page and check again Signed-off-by: Tomas Cohen Arazi Trivial string patch. The restults are the expected. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:56:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:56:25 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 16:57:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 14:57:06 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer --- I had some problems treating this with git bz - maybe something about the encoding settings in git? Uploaded patch should be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 17:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 15:12:10 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 --- Comment #22 from Marcel de Rooy --- (In reply to M. Tompsett from comment #21) > Comment on attachment 40777 [details] [review] > Bug 14382: [QA Follow-up] Bad regex alarm > > Review of attachment 40777 [details] [review]: > ----------------------------------------------------------------- > > ::: reports/guided_reports.pl > @@ +754,4 @@ > > my $quoted = $sql_params[$i]; > > # if there are special regexp chars, we must \ them > > $split[$i*2+1] =~ s/(\||\?|\.|\*|\(|\)|\%)/\\$1/g; > > + if ($split[$i*2+1] =~ /\|date$/) { > > While I agree with the escaping (I really should have caught that, DOH!), > the $ does not work. Why not leave >>? >'s are not special characters, are > they? > I was thinking it may be better to put: > /\|\s*date\s*>>/ Please explain why the $ should not work. I agree btw that \s* could be put in additionally. But the >> should be removed, because of the split /<<|>>/,$sql. When I tested this, it worked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 17:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 15:27:37 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 --- Comment #23 from M. Tompsett --- I wrote: >> I was thinking it may be better to put: >> /\|\s*date\s*>>/ Marcel wrote: > Please explain why the $ should not work. ... > But the >> should be removed, because of the split > /<<|>>/,$sql. DOH! Larger code context. You are right. > I agree btw that \s* could be put > in additionally. > When I tested this, it worked. So we agree that: /\|\s*date\s*$/ would be better. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 17:41:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 15:41:29 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40777|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy --- Created attachment 40781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40781&action=edit Bug 14382: [QA Follow-up] Bad regex alarm The regex /|date>>/ will match much more than you like :) The unescaped pipe is bad, but you also need to remove the >> because the split a few lines above it removes them already. This allows you to recover from an error like this one, running another report with a string parameter: The given date (india%) does not match the date format (us) at Koha/DateUtils.pm line 144. Signed-off-by: Marcel de Rooy Amended for possible spaces around the word date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 17:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 15:42:26 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 --- Comment #4 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #3) Yep, that was one of my ideas. I propose a even a div. We should fix the fact that TT comments should not be translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 17:46:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 15:46:01 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 17:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 15:46:03 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40754|0 |1 is obsolete| | --- Comment #5 from Fridolin SOMERS --- Created attachment 40782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40782&action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate. Test plan : - without patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 17:53:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 15:53:46 +0000 Subject: [Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 18:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 16:04:58 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Parche aplicado a master. ?Muchas gracias Samanta! Y felicitaciones por tu primer commit :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 21:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 19:55:27 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40773|0 |1 is obsolete| | --- Comment #4 from Indranil Das Gupta --- Created attachment 40783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40783&action=edit Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 23:05:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 21:05:50 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 23:05:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 21:05:52 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40783|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 40784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40784&action=edit Bug 14487 - silence warns during checkin Test plan ========= 1/ check out an item and then check it back in. 1/ check the logs after the check-in to see the warns from returns.pl line 623 of : (a) Use of uninitialized value $holdingBranch (b) Use of uninitialized value $collectionBranch 2/ apply patch 3/ check out and check-in again. no warns are recorded this time. NOTE: Under Debian Jessie, there are other messages. Additionally, this only corrects the line 623 ones. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 23:08:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 21:08:39 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- [Fri Jul 03 17:00:54.327367 2015] [cgi:error] [pid 2960] [client 192.168.45.37:62532] AH01215: [Fri Jul 3 17:00:54 2015] returns.pl: Use of uninitialized value in hash element at /home/mtompset/kohaclone/circ/returns.pl line 469., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/circ/returns.pl This probably applies to more than just Debian Jessie. [Fri Jul 03 17:00:54.334787 2015] [cgi:error] [pid 2960] [client 192.168.45.37:62532] AH01215: [Fri Jul 3 17:00:54 2015] returns.pl: CGI::param called in list context from package main line 620, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://library-admin.debiankoha.ca/cgi-bin/koha/circ/returns.pl This probably applies to only Debian Jessie context. Moving this back to ASSIGNED, since I believe 469 should be fixed at least based on the bug description given. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 23:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 21:11:32 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #7 from M. Tompsett --- (In reply to M. Tompsett from comment #6) > [Fri Jul 03 17:00:54.327367 2015] [cgi:error] [pid 2960] [client > 192.168.45.37:62532] AH01215: [Fri Jul 3 17:00:54 2015] returns.pl: Use of > uninitialized value in hash element at > /home/mtompset/kohaclone/circ/returns.pl line 469., referer: > http://library-admin.debiankoha.ca/cgi-bin/koha/circ/returns.pl Trigger case: check in something that isn't checked out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 3 23:43:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 21:43:56 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 00:10:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 22:10:05 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 00:10:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 22:10:07 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #8 from M. Tompsett --- Created attachment 40785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40785&action=edit Bug 14487: Noise best detected under Debian 8 The first error is caused by the fact that $messages->{'IsPermanent'} is undefined. The second error is caused by querying the CGI parameter 'barcode' inside a function call. This is not required. There is a variable $barcode set with the parameter. Changed to use the variable. TEST PLAN ---------- 1) Test first patch. 2) Clear the log 3) Put in a barcode which is not checked out. 4) Check the log. -- should be two errors. One about a hash, the other will only be detectable under Debian 8. 5) Apply this second patch 6) Clear the log 7) Put in a barcode which is not checked out. 8) Check the log. -- should be empty. 9) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 00:10:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 22:10:09 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39654|0 |1 is obsolete| | --- Comment #73 from H?ctor Eduardo Castro Avalos --- Created attachment 40786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40786&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. The recommendation can be consulted at . This new feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patches. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C. 7) DC-XML cannot valid if not exist a valid XSD schema. 8) OAI-DC can be validated using and the proper schema typed in text field for URL. 9) Since unit test fail last time, test with prove t/db_dependent/Record.t Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities, HTML::Entities and, HTML::Entities::Numbered were eliminated from patch, use instead C4::Record::_entity_encode, RDF::Helper has been eliminated too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 00:35:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 22:35:20 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40786|0 |1 is obsolete| | --- Comment #74 from H?ctor Eduardo Castro Avalos --- Created attachment 40787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40787&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. The recommendation can be consulted at . This new feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patches. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C. 7) DC-XML cannot valid if not exist a valid XSD schema. 8) OAI-DC can be validated using and the proper schema typed in text field for URL. 9) Since unit test fail last time, test with prove t/db_dependent/Record.t Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities, HTML::Entities and, HTML::Entities::Numbered were eliminated from patch, use instead C4::Record::_entity_encode, RDF::Helper has been eliminated too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 00:41:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jul 2015 22:41:48 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #75 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #72) > It's much more better now! > > Still some minor issues: > 1/ Could you try to add some style to the modal window? And create a label > for the radio buttons. > 2/ > +use Modern::Perl; > +use strict; > +use warnings::register; > => You don't need to use strict and warnings if you use Modern::Perl; > 3/ Use POD to document your subroutines. > 4/ Since the modal is only used from the detail page, why do you set the JS > code in script.js and the modal code in masthead.inc? > 5/ Choose a correct id for the modal div element (something better than > myModal :)) Hi Jonathan All changes done according with your comment. Review the patch to see if it's Ok! Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 04:57:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 02:57:13 +0000 Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 07:29:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 05:29:13 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40785|0 |1 is obsolete| | --- Comment #9 from Indranil Das Gupta --- Created attachment 40788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40788&action=edit Bug 14487: Noise best detected under Debian 8 The first error is caused by the fact that $messages->{'IsPermanent'} is undefined. The second error is caused by querying the CGI parameter 'barcode' inside a function call. This is not required. There is a variable $barcode set with the parameter. Changed to use the variable. TEST PLAN ---------- 1) Test first patch. 2) Clear the log 3) Put in a barcode which is not checked out. 4) Check the log. -- should be two errors. One about a hash, the other will only be detectable under Debian 8. 5) Apply this second patch 6) Clear the log 7) Put in a barcode which is not checked out. 8) Check the log. -- should be empty. 9) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 08:02:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 06:02:57 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40782|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 40789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40789&action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate. Test plan : - without patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos Works as advertised. Just one msgid appear with msgid "%s result(s) found in catalog," -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 08:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 06:03:48 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 08:38:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 06:38:48 +0000 Subject: [Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete "by" and display of publication year for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #4 from H?ctor Eduardo Castro Avalos --- (In reply to Bernardo Gonzalez Kriegel from comment #3) > (In reply to Marc V?ron from comment #2) > ... > > Signed-off-by: Marc V?ron > > Marc, you forgot to set to 'Signed Off' It's right, Marc, you forget to change the status of the bug to Signed-off, the bug still appear as Needs Signoff Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 11:46:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 09:46:21 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37545|0 |1 is obsolete| | --- Comment #12 from Amit --- Created attachment 40790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40790&action=edit Bug 8684: Fix duplicate check on creating items in the acquisition module Works well, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 11:47:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 09:47:03 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37712|0 |1 is obsolete| | --- Comment #13 from Amit --- Created attachment 40791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40791&action=edit Bug 8684: Add regression tests for SearchItemsByField -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 11:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 09:48:06 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 11:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 09:58:13 +0000 Subject: [Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete "by" and display of publication year for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 4 13:44:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jul 2015 11:44:39 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 03:38:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 01:38:35 +0000 Subject: [Koha-bugs] [Bug 14264] Export of CSV from late orders form does only work in English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 06:16:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 04:16:47 +0000 Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 06:31:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 04:31:10 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #3 from M. Tompsett --- Comment on attachment 40004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40004 Bug 13452: 'Average loan time' report to obey item-level_itypes preference Review of attachment 40004: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13452&attachment=40004) ----------------------------------------------------------------- ::: reports/issues_avg_stats.pl @@ +407,4 @@ > if (( @colfilter ) and ($colfilter[1])){ > $sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'"); > } elsif ($colfilter[0]) { > + $sth2->execute; Perhaps a shallow reading of the changes doesn't make this obvious, but why did this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 08:12:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 06:12:50 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #8 from Amit --- simith any plan to rebase this patch on master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 13:31:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 11:31:03 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch complexity|--- |Small patch CC| |m.de.rooy at rijksmuseum.nl Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 13:31:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 11:31:25 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 13:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 11:31:28 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 --- Comment #4 from Marcel de Rooy --- Created attachment 40792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40792&action=edit Bug 11693: Default emailing preferences not loaded for self registering patron The call to AddMember_Opac does not take care of the messaging prefs when enhanced messaging is enabled. This patch adds the call to handle_form_action to do that. Test plan: Enable self registering patrons and enhanced messaging. Check the (default) message prefs for the relevant patron category. At least enable email for one notice. Self-register a user with and without verification email enabled. Check in both cases that the message prefs of the user conform to those in the patron category. (So at least one enabled.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 13:36:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 11:36:27 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #4 from Katrin Fischer --- Comment on attachment 40004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40004 Bug 13452: 'Average loan time' report to obey item-level_itypes preference Review of attachment 40004: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13452&attachment=40004) ----------------------------------------------------------------- ::: reports/issues_avg_stats.pl @@ +407,4 @@ > if (( @colfilter ) and ($colfilter[1])){ > $sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'"); > } elsif ($colfilter[0]) { > + $sth2->execute; Because without this change there was always an error in the logs - without any of the other changes of the patch. I needed to change it to get it working first... that's how I remember. The answer should be further above in the code... this whole script should be rewritten to create the SQL in cleaner ways. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 15:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 13:55:27 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 16:06:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 14:06:55 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #13 from Indranil Das Gupta --- this could prolly use a Passed QA status ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 16:37:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 14:37:14 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #14 from Katrin Fischer --- ... or another sign-off to give QA more incentive! ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 16:49:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 14:49:01 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37868|0 |1 is obsolete| | --- Comment #142 from Marc V?ron --- Comment on attachment 37868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37868 Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-ratings.pl Obsoleted because int hte meantime the line use C4::Dates qw(format_date) was removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 16:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 14:57:03 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 17:34:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 15:34:46 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 --- Comment #5 from Marc V?ron --- Created attachment 40793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40793&action=edit [Signed-off] Bug 11693: Default emailing preferences not loaded for self registering patron The call to AddMember_Opac does not take care of the messaging prefs when enhanced messaging is enabled. This patch adds the call to handle_form_action to do that. Test plan: Enable self registering patrons and enhanced messaging. Check the (default) message prefs for the relevant patron category. At least enable email for one notice. Self-register a user with and without verification email enabled. Check in both cases that the message prefs of the user conform to those in the patron category. (So at least one enabled.) Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 17:35:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 15:35:23 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #40792|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 17:36:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 15:36:09 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 17:46:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 15:46:28 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 --- Comment #10 from Marc V?ron --- Jonathan proposed a Proof of concept for a more generic solution: Bug 14100 - Generic solution for language overlay I tested the proof of concept. It works as described and I think it is the way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 23:14:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 21:14:02 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39281|0 |1 is obsolete| | --- Comment #15 from Indranil Das Gupta --- Created attachment 40794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40794&action=edit Bug 13622: Display a datetime without time in a notice For some needs, a librarian would like to display a datetime or timestamp field without the time. This patch adds filter logic in the notice/letter parsing process. Test plan: 1/ Defined a notice using a datetime or timestamp DB field (biblio.timestamp for instance). 2/ Generate the notice 3/ Verify that the letter is generated with the time 4/ Use the "dateonly" filter like: <> <> 5/ Generate the notice 6/ Confirm the the letter is generated without the time for this field. Signed-off-by: Marcel de Rooy Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Updated the count of tests to 64 for t/db_dependent/Letters.t to pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 23:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 21:18:17 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39282|0 |1 is obsolete| | --- Comment #16 from Indranil Das Gupta --- Created attachment 40795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40795&action=edit Bug 13622: [QA Follow-up] Add unit test descriptions This report adds a few unit tests for datonly flag in notices. This patch adds (very trivial) unit test descriptions. Signed-off-by: Marcel de Rooy Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 23:21:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 21:21:35 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #17 from Indranil Das Gupta --- (In reply to Katrin Fischer from comment #14) > ... or another sign-off to give QA more incentive! ;) heh! done... updated the tests count in t/db_dependent/Letters.t to 64 (it is already 61 in the current master). Hope I've not messed up the author this time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 23:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 21:33:11 +0000 Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 --- Comment #4 from Indranil Das Gupta --- Comment on attachment 40724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40724 Bug 14472 - Wrong ISSN search index in record matching rules Review of attachment 40724: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14472&attachment=40724) ----------------------------------------------------------------- Hi Amit, You may want to squash these two commits into one. Makes little sense to have a separate one-line commit. -idg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 23:41:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 21:41:44 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40489|0 |1 is obsolete| | --- Comment #7 from Indranil Das Gupta --- Created attachment 40796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40796&action=edit Bug 14435: Drop table saved_reports - DB Changes Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 23:42:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 21:42:54 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40753|0 |1 is obsolete| | --- Comment #8 from Indranil Das Gupta --- Created attachment 40797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40797&action=edit Bug 14435: Drop table saved_reports The table saved_reports is never populated and is not used since 14be4400d84b28369d095b3b0bfa79c3396f44d4 (2009). The 2 subroutines store_results and format_results are never reachable and will also be removed. Note that an empty column "Saved results" were always displayed on the saved report list. Test plan: 0/ Confirm that there is nothing in the saved_reports table and that you have never seen something in it before. 1/ After applying the patch, confirm that you have still acess to the saved report list (reports/guided_reports.pl?phase=Use saved) Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 23:43:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 21:43:35 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 23:55:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 21:55:00 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40004|0 |1 is obsolete| | --- Comment #5 from Indranil Das Gupta --- Created attachment 40798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40798&action=edit Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 5 23:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 21:55:24 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 00:01:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 22:01:47 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 00:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 22:34:51 +0000 Subject: [Koha-bugs] [Bug 14491] New: Noisy warns at reserve/request.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14491 Bug ID: 14491 Summary: Noisy warns at reserve/request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl [error] request.pl: Use of uninitialized value in hash element at /home/vagrant/kohaclone/reserve/request.pl line 313 [error] request.pl: Use of uninitialized value in hash element at /home/vagrant/kohaclone/reserve/request.pl line 320 [error] [client 10.0.2.2] request.pl: Use of uninitialized value in hash element at /home/vagrant/kohaclone/reserve/request.pl line 330 [error] request.pl: Use of uninitialized value in hash element at /home/vagrant/kohaclone/reserve/request.pl line 331 To trigger warns: 1) Go to circulation 2) Go to Holds awaiting pickup 3) Click on any item title that has a hold (doesn't matter which library or if under 'waiting' tab or 'over' tab) 4) Will take you to a link like this --> http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=91094 5) Click 'Place a hold' button or 'Holds' tab. Notice warns NB: I think the warns are only triggered by items with holds that have a 'waiting' priority so best to go through Holds awaiting pickup - less likely to find an item that will trigger these warns just by going through catalog search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 01:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 23:06:17 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 --- Comment #2 from Aleisha Amohia --- Found another warn when using the search bar to Check out (Enter patron card number or partial name:) Use of uninitialized value $searchtype in string eq at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 79. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 01:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jul 2015 23:14:24 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 --- Comment #3 from Aleisha Amohia --- Created attachment 40799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40799&action=edit Bug 14436: Undefined $searchtype causing warns Don't forget to apply both patches and test for the first patch too! To test this patch: 1) Use Check out tab on search bar 'enter patron card number or partial name' 2) Notice warns 3) Apply patch and reload page (ie make new search) 4) Notice page still works but no warns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 03:55:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 01:55:10 +0000 Subject: [Koha-bugs] [Bug 14492] New: Adding serials predicts wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14492 Bug ID: 14492 Summary: Adding serials predicts wrong Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jb.australian at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Created attachment 40800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40800&action=edit screencap of incorrect prediction pattern When adding a new subscription but not starting at No.1, the Vol. number doesn't change until the initial No. (4 in the example) is reached again, rather than changing when the No. is reset. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 03:58:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 01:58:27 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #23 from David Cook --- Jonathan: Is this ready for testing now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 04:27:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 02:27:38 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #56 from David Cook --- (In reply to Nick Clemens from comment #55) > Not sure what needs to be done here, more than a signoff? Failing because of > Mark's test request I think Katrin just rebased the patches to keep them current. I think the signoff just needed another check. Seeing as Mark isn't a member of the QA or release teams, I don't think it's necessary to fail the patch because of a lack of unit tests. That said, tests never hurt, but I don't have time to write any right now, so leaving this as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 04:36:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 02:36:06 +0000 Subject: [Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 --- Comment #9 from David Cook --- (In reply to Fridolin SOMERS from comment #8) > Note that using numeric search is only useful when using comparisons greater > or lower than. That's probably a valid point. We could probably add itemnumber to a non-numeric index for MARC21, although then we're indexing it twice when we could just index it once and change the CCL alias instead. > Default search is phrase so indexing itemnumber subfield as phrase should be > enough to allow searching : "itemnumber:9999" I believe the default search is actually wordlist (:w), but that's true enough. In MARC21, the biblionumber is indexed like so: "Local-Number:n Local-Number:w Local-Number:s". So "local-number:9999" will get you the biblionumber stored in the local-number "w" index. The ":s" is probably unnecessary as that's just for sorting... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 05:38:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 03:38:37 +0000 Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40724|0 |1 is obsolete| | Attachment #40725|0 |1 is obsolete| | CC| |amitddng135 at gmail.com --- Comment #5 from Amit --- Created attachment 40801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40801&action=edit Bug 14472 - Squashed Wrong ISSN search index in matching rules Thanks IDG for comments I squashed two patches for simplicity. Bug 14472 - Wrong ISSN search index in record matching rules TEST PLAN --------- 1) Apply the patch 2) Export some MARC bibliographic records from Koha 3) Import those same MARC bibliographic records using the "ISSN(022$a)" record matching rule. 4) The incoming records should match perfectly 5) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. For new Koha installation 1) create the koha database 2) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 3) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 07:13:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 05:13:17 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com --- Comment #4 from Indranil Das Gupta --- Hi Aleisha, I feel these two one-liners should be squashed into one patch. What say? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 10:47:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 08:47:02 +0000 Subject: [Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 11:49:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 09:49:49 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |Seeking cosponsors --- Comment #11 from Indranil Das Gupta --- Just received co-sponsorship from the following librarians: Jasimudeen S St.Stephen's College Uzhavoor, Kerala. jasimndd at gmail.com Vimal Kumar Vazhappally M G University Library Kottayam, Kerala. vimal0212 at gmail.com Biju Verghese Sacred Heart College Thevara, Kerala. bijuvvlis at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 11:57:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 09:57:43 +0000 Subject: [Koha-bugs] [Bug 14492] Adding serials predicts wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14492 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- Hi James, if you want to start with number 4 try entering a 3 for the inner counter in the first column, then this should work correctly. An example for starting not with the first issue can be found in the manual: http://translate.koha-community.org/manual/master/en/html-desktop/#backpackerserial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 13:09:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 11:09:57 +0000 Subject: [Koha-bugs] [Bug 14493] New: export_borrowers.pl - Export patron attributes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Bug ID: 14493 Summary: export_borrowers.pl - Export patron attributes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: vfernandes at keep.pt QA Contact: testopia at bugs.koha-community.org When using the script export_borrowers.pl the patron attributes are not exposed to the CSV. The idea is to have a field called patron_attributes that exposes all the extended attributes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 13:29:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 11:29:58 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 --- Comment #1 from Vitor Fernandes --- Created attachment 40802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40802&action=edit Export borrowers script Sorry I couldn't create a patch for this. Can someone please do that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 13:33:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 11:33:00 +0000 Subject: [Koha-bugs] [Bug 14494] New: Terribly slow checkout caused by DateTime->new in far future Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Bug ID: 14494 Summary: Terribly slow checkout caused by DateTime->new in far future Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org An expiry date of 9999-12-31 for organizations was a nice idea :) But checking out an item to that patron takes 1 minute or longer ! The cause? The following lines in CanBookBeIssued seem to be the main cause: my $expiry_dt = DateTime->new( year => $y, month => $m, day => $d, time_zone => C4::Context->tz, ); This call takes forever with 9999-12-31 when the timezone is not 'floating' or 'UTC', but e.g. Europe/Amsterdam. If the timezone is UTC, it takes 0.0002 seconds. DateTime gives the following advices: === Do not try to use named time zones (like "America/Chicago") with dates very far in the future (thousands of years). The current implementation of DateTime::TimeZone will use a huge amount of memory calculating all the DST changes from now until the future date. Use UTC or the floating time zone and you will be safe. ?use UTC for all calculations If you do care about time zones (particularly DST) or leap seconds, try to use non-UTC time zones for presentation and user input only. Convert to UTC immediately and convert back to the local time zone for presentation The results DateTime.pm produces are predictable and correct, and mostly intuitive, but datetime math gets very ugly when time zones are involved ... === We are not doing that currently. We use in C4::Context: DateTime::TimeZone->new(name => 'local') Could we implement the calculation/presentation advice of DateTime in Koha somehow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 14:11:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 12:11:37 +0000 Subject: [Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #40 from Marcel de Rooy --- Found checks like: if ( $dt->ymd !~ /^9999/ ) { $dt_params{year} < 9999 Note that if you would pick year 3000 or 9000, it still would take forever to let DateTime calculate things in a named timezone. If the date is more than a few days/weeks in the future, I suppose that we already could jump to floating or UTC instead of the named timezone? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 14:18:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 12:18:21 +0000 Subject: [Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14494 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 14:18:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 12:18:21 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13242 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 14:20:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 12:20:44 +0000 Subject: [Koha-bugs] [Bug 14495] New: WebDriver/WebTester Factory for easy generation of Web testing UserAgents. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Bug ID: 14495 Summary: WebDriver/WebTester Factory for easy generation of Web testing UserAgents. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org Because life is short, getting test web drivers should be easy. In Ubuntu 14.04, Selenium no longer requires a stand-alone testing Server, so running integration tests is much much more fun! This factory encapsulates all the boring bits about getting a web driver to mimic user behaviour in the GUI. Tests included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 15:01:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 13:01:26 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 40803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40803&action=edit Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing UserAgents. Because life is short, getting test web drivers must be easy. use t::lib::WebDriverFactory; my ($firefox) = t::lib::WebDriverFactory::getUserAgentDrivers('firefox'); In Ubuntu 14.04, Selenium no longer requires a stand-alone testing Server, so running integration tests is much much more fun! This factory encapsulates all the boring bits about getting a web driver to mimic user behaviour in the GUI. And makes it super easy to get a test driver for any testing type environment. Adds support for Test::Mojo and Selenium, see t::lib::WebDriverFactory for installation and usage instructions. run t::lib::webDriverFactory.t to see your configured capabilities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 15:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 13:04:14 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40803|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 40804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40804&action=edit Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing UserAgents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 15:17:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 13:17:09 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14496 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 15:17:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 13:17:09 +0000 Subject: [Koha-bugs] [Bug 14496] New: Improving opac-detail.pl performances Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Bug ID: 14496 Summary: Improving opac-detail.pl performances Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.fiol at biblibre.com Reporter: julian.fiol at biblibre.com QA Contact: testopia at bugs.koha-community.org Blocks: 7923 Get notes and subjects from MARC record ONLY when XSLT is not activated. It's useless doing it when XSLT is activated, because XSLT takes care of it by its own. => With this patch, we are saving precious milliseconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 15:18:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 13:18:37 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 15:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 13:18:39 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 --- Comment #1 from Julian FIOL --- Created attachment 40805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40805&action=edit Bug 14496 : Improving opac-detail.pl performances Get notes and subjects from MARC record ONLY when XSLT is not activated. It's useless doing it when XSLT is activated, because XSLT takes care of it by its own. => With this patch, we are saving precious milliseconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 15:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 13:43:29 +0000 Subject: [Koha-bugs] [Bug 14497] New: Add warning to patron details page if patron's fines exceed noissuescharge Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497 Bug ID: 14497 Summary: Add warning to patron details page if patron's fines exceed noissuescharge Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some librarians have requested that the same warning on the check out page be placed on the patron details page if a patron's fines exceed the system preference noissuescharge. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 15:47:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 13:47:26 +0000 Subject: [Koha-bugs] [Bug 14497] Add warning to patron details page if patron's fines exceed noissuescharge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 15:47:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 13:47:28 +0000 Subject: [Koha-bugs] [Bug 14497] Add warning to patron details page if patron's fines exceed noissuescharge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497 --- Comment #1 from Kyle M Hall --- Created attachment 40806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40806&action=edit Bug 14497 - Add warning to patron details page if patron's fines exceed noissuescharge Some librarians have requested that the same warning on the check out page be placed on the patron details page if a patron's fines exceed the system preference noissuescharge. Test Plan: 1) Apply this patch 2) Find or create a patron who's fines exceed noissuescharge 3) Browse to that patron's details ( moremember.pl ) 4) You should see a warning near the top of the page with links to the patron's account page and the pay fines page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 16:52:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 14:52:41 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 16:55:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 14:55:15 +0000 Subject: [Koha-bugs] [Bug 12552] Odd error caused by URI Escape In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #9 from Kyle M Hall --- I believe the issue is no longer related to URI::Escape. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:00:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:00:15 +0000 Subject: [Koha-bugs] [Bug 14498] New: uri_escape error triggered by duplicate accountno's for patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Bug ID: 14498 Summary: uri_escape error triggered by duplicate accountno's for patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron has duplicate accountno's for two different fines in Koha this will trigger the error usi_escape: Unmatched [ in regex; marked by <-- HERE in m/([ <-- HERE ])/ at (eval 133) line 1. upon attempt to pay. How those accountno's get duplicated is unknown, but considering accountno is somewhat vestigial at this point in time, it would be much more sensible to use accountlines_id which is has guaranteed uniqueness at the database level. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:03:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:03:04 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:03:05 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 --- Comment #1 from Kyle M Hall --- Created attachment 40807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40807&action=edit Bug 14498 - uri_escape error triggered by duplicate accountno's for patron If a patron has duplicate accountno's for two different fines in Koha this will trigger the error usi_escape: Unmatched [ in regex; marked by <-- HERE in m/([ <-- HERE ])/ at (eval 133) line 1. upon attempt to pay. How those accountno's get duplicated is unknown, but considering accountno is somewhat vestigial at this point in time, it would be much more sensible to use accountlines_id which is has guaranteed uniqueness at the database level. Test Plan: 1) Create a patron with 2 fines 2) Edit the accountno's for those fines and set them to 0 3) Attempt to pay one, note the error 4) Apply this patch 5) Refesh the page 6) Attempt to pay one, no error this time! 7) Test Pay, Write off, Pay amount, Write off all, and Pay selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:03:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:03:13 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:04:15 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40807|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 40808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40808&action=edit Bug 14498 - uri_escape error triggered by duplicate accountno's for patron If a patron has duplicate accountno's for two different fines in Koha this will trigger the error usi_escape: Unmatched [ in regex; marked by <-- HERE in m/([ <-- HERE ])/ at (eval 133) line 1. upon attempt to pay. How those accountno's get duplicated is unknown, but considering accountno is somewhat vestigial at this point in time, it would be much more sensible to use accountlines_id which is has guaranteed uniqueness at the database level. Test Plan: 1) Create a patron with 2 fines 2) Edit the accountno's for those fines and set them to 0 3) Attempt to pay one, note the error 4) Apply this patch 5) Refesh the page 6) Attempt to pay one, no error this time! 7) Test Pay, Write off, Pay amount, Write off all, and Pay selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:26:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:26:33 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40804|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 40809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40809&action=edit Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing UserAgents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:27:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:27:17 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14495 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:27:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:27:17 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13691 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:31:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:31:12 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 --- Comment #10 from Olli-Antti Kivilahti --- Hi there! I just added bug 14495 to easily generate all kinds of WebDrivers/Test::Mojo things to do integration tests. This basically creates Selenium::Remote::Drivers based on the given parameters. Looking into implementing a PageObject to test password authentication, but it might be a bit difficult regarding how Koha deals with the authentication. This is to test the Authentication Rewriting at Bug 7174 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 17:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 15:45:04 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 --- Comment #2 from Fridolin SOMERS --- nice job Julian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 18:15:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 16:15:06 +0000 Subject: [Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Discussion |RESOLVED --- Comment #13 from Kyle M Hall --- Confirmed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 18:33:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 16:33:01 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #15 from Kyle M Hall --- (In reply to Mirko Tietgen from comment #14) > (In reply to Kyle M Hall from comment #13) > > > 3) prove t/db_dependent/Circulation_Issuingrule.t > > t/db_dependent/Circulation_Issuingrule.t .. ok > All tests successful. > Files=1, Tests=9, 2 wallclock secs ( 0.06 usr 0.02 sys + 1.98 cusr 0.23 > csys = 2.29 CPU) > Result: PASS > > > 4) prove t/db_dependent/Circulation.t > > t/db_dependent/Circulation.t .. 22/61 DBD::mysql::st execute failed: > Duplicate entry '4' for key 'PRIMARY' at /home/mirko/koha/C4/Circulation.pm > line 2100. > DBD::mysql::st execute failed: Duplicate entry '4' for key 'PRIMARY' at > /home/mirko/koha/C4/Circulation.pm line 2100. > # Looks like you planned 61 tests but ran 43. > # Looks like your test exited with 255 just after 43. > t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, > 0xff00) > Failed 18/61 subtests > > > Test Summary Report > ------------------- > t/db_dependent/Circulation.t (Wstat: 65280 Tests: 43 Failed: 0) > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 61 tests but ran 43. > Files=1, Tests=43, 5 wallclock secs ( 0.07 usr 0.03 sys + 3.02 cusr 0.40 > csys = 3.52 CPU) > Result: FAIL > > > > 5) prove t/db_dependent/Fines.t > > t/db_dependent/Fines.t .. DBIx::Class::ResultSet::create(): No such column > chargeperiod_charge_at on Koha::Schema::Result::Issuingrule at > t/db_dependent/Fines.t line 21 > # Looks like your test exited with 255 before it could output anything. > t/db_dependent/Fines.t .. Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 5/5 subtests > > Test Summary Report > ------------------- > t/db_dependent/Fines.t (Wstat: 65280 Tests: 0 Failed: 0) > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 5 tests but ran 0. > Files=1, Tests=0, 3 wallclock secs ( 0.05 usr 0.03 sys + 1.84 cusr 0.23 > csys = 2.15 CPU) > Result: FAIL > > I ran updatedatabase before I tested, so I wonder if something is missing? Did you run the unit tests with a fresh install of Koha with the default data? Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 18:35:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 16:35:48 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #16 from Kyle M Hall --- To follow up on that question, on my test server those unit tests often fail unless I'm using a fresh install with all the default data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 18:43:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 16:43:28 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 --- Comment #11 from Olli-Antti Kivilahti --- Hi! just drew a schematic to implement a PageObjectPattern-system on. There is a nice code example to make robust UI tests. https://docs.google.com/drawings/d/1k_y1YZi72UFxlVEDpqINT68TGQBEy-f2ZkTGLpMcTJU/edit?usp=sharing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 18:53:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 16:53:52 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 18:54:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 16:54:00 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 19:13:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 17:13:34 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 19:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 17:13:36 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40808|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 40810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40810&action=edit Bug 14498 - uri_escape error triggered by duplicate accountno's for patron If a patron has duplicate accountno's for two different fines in Koha this will trigger the error usi_escape: Unmatched [ in regex; marked by <-- HERE in m/([ <-- HERE ])/ at (eval 133) line 1. upon attempt to pay. How those accountno's get duplicated is unknown, but considering accountno is somewhat vestigial at this point in time, it would be much more sensible to use accountlines_id which is has guaranteed uniqueness at the database level. Test Plan: 1) Create a patron with 2 fines 2) Edit the accountno's for those fines and set them to 0 3) Attempt to pay one, note the error 4) Apply this patch 5) Refesh the page 6) Attempt to pay one, no error this time! 7) Test Pay, Write off, Pay amount, Write off all, and Pay selected Signed-off-by: Deborah Duce -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 20:29:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 18:29:59 +0000 Subject: [Koha-bugs] [Bug 12327] option to not check in with inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12327 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 20:30:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 18:30:46 +0000 Subject: [Koha-bugs] [Bug 9666] add columns for status to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9666 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 20:31:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 18:31:18 +0000 Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with date last seen greater than the inventory date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 20:32:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 18:32:10 +0000 Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 20:32:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 18:32:30 +0000 Subject: [Koha-bugs] [Bug 12733] Interactive inventory tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12733 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 20:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 18:33:05 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 20:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 18:33:26 +0000 Subject: [Koha-bugs] [Bug 10707] inventory not removing lost status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10707 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 20:34:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 18:34:04 +0000 Subject: [Koha-bugs] [Bug 14398] Duplicate inventory results when an item is in the wrong place (ie using branch/location filter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14398 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 20:50:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 18:50:34 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 21:03:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 19:03:27 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 21:05:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 19:05:39 +0000 Subject: [Koha-bugs] [Bug 14029] Provide link to clear reports search filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 21:06:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 19:06:19 +0000 Subject: [Koha-bugs] [Bug 14008] Filters are not displayed on search for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 21:13:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 19:13:01 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:21:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:21:01 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:21:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:21:05 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40555|0 |1 is obsolete| | --- Comment #104 from Jesse Weaver --- Created attachment 40811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40811&action=edit Bug 11559: Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Extends humanmsg to allow per-message classes * Adds proper charset to results of svc/bib Test plan: 1. C4/Auth.pm and .../intranet/.../auth.tt: verify that login/usage works as expected, despite the change to pass on the fragment (...#blah) from the URL. 2. C4/Service.pm and humanmsg.js: verify that editing system preferences (the main user of these modules) works correctly despite updates. 3. svc/bib: verify that records can be correctly downloaded with the change of character set. This can be done in a Firebug/Chrome Devtools console by running `$.get('/cgi-bin/koha/svc/bib/1')` and inspecting the results (possibly replacing 1 with a different valid biblionumber). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:21:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:21:15 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40556|0 |1 is obsolete| | --- Comment #105 from Jesse Weaver --- Created attachment 40812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40812&action=edit Bug 11559: New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * require - dependency resolver and module loader -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:21:26 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40557|0 |1 is obsolete| | --- Comment #106 from Jesse Weaver --- Created attachment 40813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40813&action=edit Bug 11559: Rancor: advanced cataloging interface Full test plan is posted on bug. Test plan for system preference: 1. Apply patch, clear cookies. 2. Go to "Cataloging." 3. Add new record, verify that basic editor is used. 4. Navigate to existing record, click on "Edit record", verify that basic editor is used. 5. Inside basic editor, verify that no button appears to switch to the advanced editor. 6. Enable the "EnableAdvancedCatalogingEditor" syspref. 7. Repeat above steps, should still go to basic editor, but button should appear to switch to the advanced editor; click it. 8. Now, adding new records and editing existing records should go to the advanced editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:21:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:21:35 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40558|0 |1 is obsolete| | --- Comment #107 from Jesse Weaver --- Created attachment 40814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40814&action=edit Bug 11559: (followup) Fix keyboard control bugs, make labels clickable This fixes the following issues: * Labels of search server checkboxes cannot be clicked * Quick search fields cannot be focused * Search results cannot be scrolled with a keyboard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:21:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:21:42 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #108 from Jesse Weaver --- Created attachment 40815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40815&action=edit Bug 11559: (followup) Fill in default values, fix redirect and UNIMARC This fixes the following issues: * Help for UNIMARC tags broken * MARC21 resources loaded when in UNIMARC * Clicking on "advanced editor" in basic editor fails * Shift-Tab goes to the beginning of a fixed-field widget rather than the end -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:23:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:23:50 +0000 Subject: [Koha-bugs] [Bug 10119] Calculation of fines on return needs to be documented In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10119 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:25:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:25:57 +0000 Subject: [Koha-bugs] [Bug 10063] Correct the documentation for the C4:Members sub: IsMemberBlocked In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #15 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:27:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:27:19 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:28:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:28:51 +0000 Subject: [Koha-bugs] [Bug 4925] Remove Smithsonian as a delivered z39.50 target In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4925 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:29:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:29:00 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #109 from Jesse Weaver --- (In reply to Katrin Fischer from comment #103) > Hm, I am not sure about only filling in the default values for mandatory > fields - I think this is kind of confusing as the configuration options are > not connected. Well, mandatory subfields should trivially be filled in because they are added to new/existing records if they do not exist. Before, they just got an empty subfield (e.g., "245 _ _ $a"), but now, if the subfield has a default value, it will be filled in. For non-mandatory subfields, however, they could only be filled in after the user entered them. For instance (where "|" is the user's cursor and 245$c has a default value of "foobar"): 245 _ _ $a The hitchhiker's guide to the galaxy /| 245 _ _ $a The hitchhiker's guide to the galaxy /$| 245 _ _ $a The hitchhiker's guide to the galaxy /$a| 245 _ _ $a The hitchhiker's guide to the galaxy /$a |foobar This might work, but I'm a bit hesitant to do this, seems a bit overly magical. I know there's a number of catalogers CC'd on this bug; please, add your thoughts! Also, note that subfields with authorized values will have the default value preselected if it exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:30:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:30:02 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #110 from Jesse Weaver --- (In reply to Jesse Weaver from comment #109) > (In reply to Katrin Fischer from comment #103) > > Hm, I am not sure about only filling in the default values for mandatory > > fields - I think this is kind of confusing as the configuration options are > > not connected. > > Well, mandatory subfields should trivially be filled in because they are > added to new/existing records if they do not exist. Before, they just got an > empty subfield (e.g., "245 _ _ $a"), but now, if the subfield has a default > value, it will be filled in. > > For non-mandatory subfields, however, they could only be filled in after the > user entered them. For instance (where "|" is the user's cursor and 245$c > has a default value of "foobar"): > > 245 _ _ $a The hitchhiker's guide to the galaxy /| > 245 _ _ $a The hitchhiker's guide to the galaxy /$| > 245 _ _ $a The hitchhiker's guide to the galaxy /$a| > 245 _ _ $a The hitchhiker's guide to the galaxy /$a |foobar > > This might work, but I'm a bit hesitant to do this, seems a bit overly > magical. I know there's a number of catalogers CC'd on this bug; please, add > your thoughts! > > Also, note that subfields with authorized values will have the default value > preselected if it exists. Doh, that should be: 245 _ _ $a The hitchhiker's guide to the galaxy /| 245 _ _ $a The hitchhiker's guide to the galaxy /$| 245 _ _ $a The hitchhiker's guide to the galaxy /$c| 245 _ _ $a The hitchhiker's guide to the galaxy /$c |foobar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:30:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:30:25 +0000 Subject: [Koha-bugs] [Bug 14422] Typographical error in updatedatabase.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14422 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:32:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:32:19 +0000 Subject: [Koha-bugs] [Bug 14394] Fix documentation of OpacHiddenItems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14394 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|enhancement |trivial Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 6 23:43:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 21:43:15 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #3 from Eivin Giske Skaaren --- Before I post the patch let me address the question about a general spellchecking/did you mean. There is already did you mean facilities to plug into and I also used the suggestionengine and made the spellchecker a plugin of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 00:29:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 22:29:52 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #4 from Eivin Giske Skaaren --- Created attachment 40816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40816&action=edit Bug 14457: Integrate LIBRIS spellchecking This patch makes it possible to configure LIBRIS spellchecker as a "did you mean" feature. When searching for a word or phrase and misspelling the query will be sent to LIBRIS and if they have a suggestion it will be shown in the yellow did you mean box in the results page. The API is not very quick so this type of implementation was chosen to not disrupt the real-time feeling of the search. To test: 1. Apply the patch. 2. Go to http://api.libris.kb.se/bibspell/, enter the koha servers IP and click on the "Generera nyckel" button. 3. Under "Nyckel" you can copy the value that looks like this: E47B44829E265607274B677BC17B8D78, and enter it into the LibrisKey syspref (cgi-bin/koha/admin/preferences.pl?tab=searching). 4. In cgi-bin/koha/admin/didyoumean.pl check the box for using the LIBRIS API. It is only implemented for OPAC. 5. Perform some searches: tset - Did you mean should suggest: test jeg ?r p? smester - suggestion: jag ?r p? semester dantes inferna - suggestion: dantes inferno -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 00:30:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jul 2015 22:30:21 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 02:50:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 00:50:35 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- I like this idea! Locally, Prosentient has already implemented a "Did you mean" spellcheck plugin using a pre-existing dictionary. Perhaps I should have him take a look at this bug as well... By the way, I'll provide a bit of feedback about some things I noticed at a glance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 02:52:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 00:52:10 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #6 from David Cook --- Comment on attachment 40816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40816 Bug 14457: Integrate LIBRIS spellchecking Review of attachment 40816: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14457&attachment=40816) ----------------------------------------------------------------- ::: opac/opac-search.pl @@ +189,4 @@ > } > if ($cgi->cookie("search_path_code")) { > my $pathcode = $cgi->cookie("search_path_code"); > + given ($pathcode) We don't use the given/when construct in Koha... I also don't see why this change would be required here. It looks like it was included accidentally? @@ +578,4 @@ > # This sorts the facets into alphabetical order > if ($facets) { > foreach my $f (@$facets) { > + $f->{facets} = [ sort { uc($a->{facet_title_value}) cmp uc($b->{facet_title_value}) } @{ $f->{facets} } ]; This looks like it's outside the scope of this bug... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 02:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 00:55:35 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I believe the non-XSLT detail display is deprecated or scheduled to be deprecated, no? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 03:08:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 01:08:53 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 03:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 01:08:55 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 --- Comment #19 from Liz Rea --- Created attachment 40817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40817&action=edit Bug 13143 - Detect if the password is in a pipe 1. cd kohaclone/debian/scripts 2. sudo koha-passwd instance | cat Output should be password only 3. sudo koha-passwd instance Output should be "Password for $instance is: $password" Does this get at what you were wanting, Robin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 05:06:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 03:06:53 +0000 Subject: [Koha-bugs] [Bug 13143] Add a tool to show a Koha's password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143 --- Comment #20 from Liz Rea --- Note that you'll need the whole set of patches to test this. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 09:35:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 07:35:06 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #7 from Eivin Giske Skaaren --- Hi David, I actually did most of the work several weeks ago but regarding the two issues I think that I just followed the example/plugin that was there. I will take a look at it and re-upload tonight. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 10:55:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 08:55:04 +0000 Subject: [Koha-bugs] [Bug 14499] New: Privilege to change currency rate by patron from acquisition module Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14499 Bug ID: 14499 Summary: Privilege to change currency rate by patron from acquisition module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org Dear Developers, Library staff engaged in acquisition section need to change the currency exchange rate frequently. It would be convenient to add Currency Exchange rates privileges in Set Permissions. In current status Library staff from acquisition section request super librarian to change currency rate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 11:00:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 09:00:21 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #19 from Liz Rea --- Feeling like this might be a candidate for 3.18, so making note to myself to check it. -Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 11:33:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 09:33:17 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 --- Comment #20 from Liz Rea --- This is a problem all the way back into 3.18, and the patches won't come over cleanly. Might we have a 3.18 version of this? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:00:43 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #8 from Katrin Fischer --- The problem is that given-when is experimental and will spam the logs. It really needs to be rewritten to be an if-else-construct instead. And if there are more we should rewrite them as well. The facet change might just have slipped in by a rebase or something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:02:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:02:20 +0000 Subject: [Koha-bugs] [Bug 14499] Privilege to change currency rate by patron from acquisition module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- You don't need super librarian, but parameters - but that's almost as bad :) *** This bug has been marked as a duplicate of bug 7651 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:02:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:02:20 +0000 Subject: [Koha-bugs] [Bug 7651] Updating currency exchange rates should not require 'parameters' permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com --- Comment #4 from Katrin Fischer --- *** Bug 14499 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:11:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:11:03 +0000 Subject: [Koha-bugs] [Bug 14500] New: Norwegian patron database: Warn if cardnumber does not look like a national cardnumber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14500 Bug ID: 14500 Summary: Norwegian patron database: Warn if cardnumber does not look like a national cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: magnus at libriotech.no Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Today, Koha will try to sync any cardnumber to NL, but NL will reject any cardnumber that does not look like a national cardnumber. Koha should at least give a warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:25:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:25:07 +0000 Subject: [Koha-bugs] [Bug 14501] New: Norwegian patron database: Social security number should be mandatory Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14501 Bug ID: 14501 Summary: Norwegian patron database: Social security number should be mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: magnus at libriotech.no Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It is possible to mark a borrower for syncing to NL without providing a social security number. It shouldn't be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:28:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:28:10 +0000 Subject: [Koha-bugs] [Bug 14502] New: Norwegian patron database: Validate social security numbers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14502 Bug ID: 14502 Summary: Norwegian patron database: Validate social security numbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: magnus at libriotech.no Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Social security numbers should be validated before they are saved. This could be generalized into validating any kind of extended patron attribute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:30:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:30:24 +0000 Subject: [Koha-bugs] [Bug 14503] New: Norwegian patron database: Hide social security number from staff Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14503 Bug ID: 14503 Summary: Norwegian patron database: Hide social security number from staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: magnus at libriotech.no Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Make it possible to hide extended patron attributes from staff. It could be displayed as a password field with *** instead of the actual text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:31:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:31:43 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- (In reply to Jonathan Druart from comment #9) > Kyle, > Thanks for these patches, it's a much more complete solution than the one I > have proposed. > > I have a doubt with the changes in GetReserveFee: > Before the patches: > if ( $const eq "a" ) { > push @biblioitems, $data1; > } > else { > some code; > } > > now you always execute some code. > > But before the patch, $const was sometime equal to "a". > I am not sure about the consequences of this change. Can you add a splinter review? I'm not sure exactly where the code you are referencing is. You can also add a followup to fix it if that's easier. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:40:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:40:15 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #11 from Katrin Fischer --- Comment on attachment 40738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40738 Bug 9809 - Update AddReserve prototype to remove constraint parameter Review of attachment 40738: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9809&attachment=40738) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ -694,5 @@ > $sth1->execute($biblionumber); > while ( my $data1 = $sth1->fetchrow_hashref ) { > - if ( $const eq "a" ) { > - push @biblioitems, $data1; > - } Could it be this here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:43:39 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40809|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 40818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40818&action=edit Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing UserAgents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:45:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:45:02 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:45:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:45:34 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz Component|Tools |Command-line Utilities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 14:47:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 12:47:15 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- There were some performance issues raised about the XSLT view - I think we haven't gotten to officially deprecate it afaik. So this should be fine. Might also be worth taking a look how big the performance difference is between both views. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 15:30:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 13:30:18 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 --- Comment #5 from Julian FIOL --- I've made some measures without XSLT and with the Default one. My results were : On opac-detail with XSLT by Default is ~ 4 % longer than without any. On opac-search with XSLT by Default is ~ 2,5% longer than without any. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 15:46:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 13:46:11 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu at inlibro.com Assignee|simith.doliveira at inlibro.co |maxime.beaulieu at inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 16:07:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 14:07:40 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 --- Comment #6 from Katrin Fischer --- Thx Julian! - Do you happen to have some times for the page loads to compare too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 16:09:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 14:09:24 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu at inlibro.com Assignee|philippe.blouin at inlibro.com |maxime.beaulieu at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 16:13:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 14:13:47 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 --- Comment #12 from Olli-Antti Kivilahti --- Created attachment 40819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40819&action=edit Bug 13691 - PageObjectPattern implementation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 16:15:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 14:15:28 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu at inlibro.com Assignee|simith.doliveira at inlibro.co |maxime.beaulieu at inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 16:42:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 14:42:41 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 --- Comment #7 from Julian FIOL --- Here are my results (in seconds) : Opac-details ------------ No XSLT | Default XSLT 11,222 | 12,217 11,836 | 11,334 11,246 | 11,611 11,508 | 12,236 11,288 | 12,055 average No XSLT --> Default XSLT 11,42s --> 11,89s (+470ms) Opac-search ------------ No XSLT | Default XSLT 3,092 | 3,153 3,322 | 3,248 3,088 | 3,405 3,172 | 3,183 3,119 | 3,205 average No XSLT --> Default XSLT 3,15s --> 3,24s (+90ms) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 16:56:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 14:56:05 +0000 Subject: [Koha-bugs] [Bug 11620] Add dissertation-information index for non-UNIMARC installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11620 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Just a note for people interested on this bug, we don't touch GRS1-related stuff anymore as of the 3.16 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 16:57:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 14:57:18 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Tom?s Cohen Arazi --- Just a note for people interested on this bug, we don't touch GRS1-related stuff anymore as of the 3.16 release. record.abs is the file used in GRS-1 for defining indexes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:19:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:19:13 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34909|0 |1 is obsolete| | --- Comment #16 from Maxime Beaulieu --- Created attachment 40820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40820&action=edit Bug 13485 - Add a proxy page To test: I) Apply the patch II) Run updatedatabase.pl scenario I) 1) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 2) Add your machine ip (ex. 127.0.0) 3) Validate cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents. scenario II) 1) Logout opac page 2) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 3) Add other ip that your machine ip. 4) Validate: cgi-bin/koha/opac-proxypage.pl shows a login page. 5) Validate: cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents after login. Followed both scenarios, works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:19:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:19:31 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34910|0 |1 is obsolete| | --- Comment #17 from Maxime Beaulieu --- Created attachment 40821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40821&action=edit Bug 13485 [QA Followup] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:20:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:20:44 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:20:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:20:46 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #18 from Maxime Beaulieu --- Created attachment 40822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40822&action=edit Bug 13485 - Atomic Update + Rename Proxy page to Restricted page Test plan: I) Apply the patch II) Run updatedatabase.pl scenario I) 1) Add some content in RestrictedPageContent and RestrictedPageTitle sysprefs. 2) Add your machine ip (ex. 127.0.0) 3) Validate cgi-bin/koha/opac-restrictedpage.pl shows a page with RestrictedPageContent and RestrictedPageTitle contents. scenario II) 1) Logout opac page 2) Add some content in RestrictedPageContent and RestrictedPageTitle sysprefs. 3) Add a diffrent ip. 4) Validate: cgi-bin/koha/opac-restrictedpage.pl shows a login page. 5) Validate: cgi-bin/koha/opac-restrictedpage.pl shows a page with RestrictedPageContent and RestrictedPageTitle contents after login. new file: installer/data/mysql/atomicupdate/Bug13485_RestrictedSitesPage.sql modified: installer/data/mysql/sysprefs.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref renamed: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-proxypage.tt -> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-restrictedpage.tt renamed: opac/opac-proxypage.pl -> opac/opac-restrictedpage.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:33:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:33:12 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu at inlibro.com Status|Failed QA |Signed Off --- Comment #26 from Maxime Beaulieu --- (In reply to Kyle M Hall from comment #24) > Please provide a test plan. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : ... /tmp/koha-public ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:33:52 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fcapovilla at live.ca |maxime.beaulieu at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:38:10 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:38:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:38:12 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35090|0 |1 is obsolete| | Attachment #35091|0 |1 is obsolete| | Attachment #35092|0 |1 is obsolete| | Attachment #35451|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 40823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40823&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:39:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:39:58 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40823|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 40824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40824&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:43:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:43:46 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40763|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 40825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40825&action=edit Bug 14467 - Security updates break some Koha plugins The new security updates break previously functioning plugins, most notably the cover flow plugin and the Ebsco EDS plugin. Test Plan: 1) Install and configure the cover flow plugin ( http://bywatersolutions.com/koha-plugins/ ) 2) Note that attempting to access coverflow.pl from the OPAC results in an error 3) Apply this patch 4) Note that coverflow.pl now output html again Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:44:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:44:19 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40825|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 40826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40826&action=edit Bug 14467 - Security updates break some Koha plugins The new security updates break previously functioning plugins, most notably the cover flow plugin and the Ebsco EDS plugin. Test Plan: 1) Install and configure the cover flow plugin ( http://bywatersolutions.com/koha-plugins/ ) 2) Note that attempting to access coverflow.pl from the OPAC results in an error 3) Apply this patch 4) Note that coverflow.pl now output html again Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 17:45:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 15:45:11 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu at inlibro.com Assignee|fcapovilla at live.ca |maxime.beaulieu at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 18:18:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 16:18:13 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #9 from Eivin Giske Skaaren --- It was indeed the rebase. I have reviewed my original commit and those 2 changes was not part of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 18:23:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 16:23:41 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40816|0 |1 is obsolete| | --- Comment #10 from Eivin Giske Skaaren --- Created attachment 40827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40827&action=edit Bug 14457: Integrate LIBRIS spellchecking This patch makes it possible to configure LIBRIS spellchecker as a "did you mean" feature. When searching for a word or phrase and misspelling the query will be sent to LIBRIS and if they have a suggestion it will be shown in the yellow did you mean box in the results page. The API is not very quick so this type of implementation was chosen to not disrupt the real-time feeling of the search. To test: 1. Apply the patch. 2. Go to http://api.libris.kb.se/bibspell/, enter the koha servers IP and click on the "Generera nyckel" button. 3. Under "Nyckel" you can copy the value that looks like this: E47B44829E265607274B677BC17B8D78, and enter it into the LibrisKey syspref (cgi-bin/koha/admin/preferences.pl?tab=searching). 4. In cgi-bin/koha/admin/didyoumean.pl check the box for using the LIBRIS API. It is only implemented for OPAC. 5. Perform some searches: tset - Did you mean should suggest: test jeg ?r p? smester - suggestion: jag ?r p? semester dantes inferna - suggestion: dantes inferno Restored opac-search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:28:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:28:14 +0000 Subject: [Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:28:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:28:45 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! Thanks for amending it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:29:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:29:06 +0000 Subject: [Koha-bugs] [Bug 14431] Encoding issues - search in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:29:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:29:31 +0000 Subject: [Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:29:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:29:56 +0000 Subject: [Koha-bugs] [Bug 14427] Use Koha::version() instead of C4::Context->KOHAVERSION In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:30:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:30:20 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #25 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Mark and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:30:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:30:46 +0000 Subject: [Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #21 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Indranil! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:31:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:31:15 +0000 Subject: [Koha-bugs] [Bug 14207] Improving circulation performance by caching yaml file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:56:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:56:09 +0000 Subject: [Koha-bugs] [Bug 14368] Add discharges history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Failed QA --- Comment #11 from Tom?s Cohen Arazi --- It makes sense to have more than one discharge in a patron's lifetime (requested when ending studies, and then if he leaves the institution as a professor...). I tested the feature and it showed more information about the discharge, but I doesn't seem to be working as expected as only the first discharge is being saved... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 20:57:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 18:57:12 +0000 Subject: [Koha-bugs] [Bug 8147] suggestions management forgets branch info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8147 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 21:03:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 19:03:50 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 21:03:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 19:03:52 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 --- Comment #4 from Jesse Weaver --- Created attachment 40828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40828&action=edit Bug 14464 - (QA followup) add unit tests This followup adds several tests to t/db_dependent/Reserves.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 21:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 19:15:11 +0000 Subject: [Koha-bugs] [Bug 14504] New: Add command-line script to batch delete items based on lost/withdrawn statuses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Bug ID: 14504 Summary: Add command-line script to batch delete items based on lost/withdrawn statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Intention of development: To create a script to delete items based on a series of criteria, primarily itemlost, timestamp, itemlost_on, and withdrawn delete_items.pl --criteria EXPRESSION [--commit] Where EXPRESSION is a valid SQL conditional, operating on the items table, e.g. items.itemlost => 1 or items.timestamp < 2014-06-07 --criteria may be called multiple times. --commit is necessary to actually delete the items. Here are a few examples of how this might be called: delete_items.pl --verbose --criteria "items.itemlost >= 1" --criteria "items.itemlost <= 4" --criteria "items.itemlost_on < '$(date --date="13 month ago" --rfc-3339=date)'" --commit delete_items.pl --verbose --criteria "items.itemlost >= 1" --criteria "items.itemlost <= 4" --criteria "items.timestamp < '$(date --date="13 month ago" --rfc-3339=date)'" --commit delete_items.pl --verbose --criteria "items.withdrawn != 0" --criteria "items.timestamp < '$(date --date="13 month ago" --rfc-3339=date)'" --commit delete_items.pl --verbose --criteria "items.withdrawn != 0" --criteria "items.itemlost_on < '$(date --date="13 month ago" --rfc-3339=date)'" --commit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 21:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 19:16:28 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |barton at bywatersolutions.com Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 21:18:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 19:18:59 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #1 from Barton Chittenden --- NAME delete_items.pl - A batch item deletion tool, which generates a query against the items database and deletes the items matching the criteria specified in the command line arguments. SYNOPSIS delete_items.pl [--help|--manual|--version] delete_items.pl [--verbose] [--dry-run] --criteria "*SQL CONDITIONAL EXPRESSION*" ... [--commit] OPTIONS --help Show the brief help information. --manual Read the manual, with examples. --version Show the version number and exit. --verbose Send the "WHERE" clause generated by the collected "--criteria" arguments, as well as items affected to Standard Out. --criteria The "--criteria" option may called multiple times. The following argument must be a syntactically valid SQL statement which is part of the "WHERE" clause querying the items table. These are joined by "AND". --commit No items will be deleted unless the "--commit" flag is present. --dry-run Disables "--commit" flag and enables "--verbose" flag. EXAMPLES The following is an example of this script: delete_items.pl --criteria "items.withdrawn ! 0" --criteria "items.withdrawn_on < $(date --date="13 month ago" --rfc-3339=date)" --commit delete_items.pl --criteria "itemlost >= '1'" --criteria "itemlost <='4'" --criteria "itemlost_on < '2014-04-28'" --commit DESCRIPTION This is a lightweight batch deletion tool for items, suitable for running in a cron job. AUTHOR Barton Chittenden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 21:51:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 19:51:46 +0000 Subject: [Koha-bugs] [Bug 14368] Add discharges history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368 --- Comment #12 from Tom?s Cohen Arazi --- Matts, a few notes on this patch. - I like the idea, I think we should've had this for the 3.20 release already. - There's a bug on the unit test you introduce for lifting the discharge, because it should look like: ok( ! Koha::Borrower::Discharge::is_discharged({ borrowernumber => $borrowernumber }), 'The patron is not discharged after the restriction has been lifted' ); And you will notice it fails :/ - There's a problem with Koha::Borrower::Discharge::discharge (not introduced by your patch, but affects the beaviour): it overwrites the already defined discharges... so no history! Heh. - For fixing the previous, you will need to add a column to address the fact that the discharge is active/non active. So you can have more than one discharges for a borrowernumber, and always check only one is active at a time. I'm attaching a followup with those changes on the tests, It'd be great if you could take a look and maybe talk tomorrow on IRC about this to have this ready ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 21:52:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 19:52:37 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23144|0 |1 is obsolete| | Attachment #23145|0 |1 is obsolete| | --- Comment #8 from Maxime Beaulieu --- Created attachment 40829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40829&action=edit Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 22:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 20:46:33 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #2 from Barton Chittenden --- Created attachment 40830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40830&action=edit add delete_items.pl: a command line batch deletion tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 22:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 20:47:04 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 7 23:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jul 2015 21:17:43 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #3 from Barton Chittenden --- Test plan: TESTING THE MAIN FUNCTIONALITY OF THE SCRIPT: ============================================= Create items with various values of itemlost and, withdrawn. Back-date the respective timestamps (itemlost_on, timestamp). Check out one or two of these items (this will exercise the safeguards against deleting checked out items). run delete_items.pl --criteria "items.itemlost = " --criteria "itemlost_on < " --dry-run do the same using items.withdrawn and items.timestamp. The results of the queries will be written to STDOUT. If you are working in an instance that has lost or withdrawn items that you want to keep, you may want to adjust the itemlost_on or timestamp values of your test items accordingly. Once satisfied with the output using the '--dry-run' option, use '--commit' instead, then verifiy that the items have been deleted. run delete_items.pl on checked-out items. If you are running '--verbose' or '--dry-run', you should receive a message to stdout showing that the item was not deleted. OTHER THINGS TO TEST: ===================== Run the script with the following options. Check the spelling and accuracy on --help and --manual, and make sure that the output from --version contains a version number. --help Show the brief help information. --manual Read the manual, with examples. --version Show the version number and exit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 04:51:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 02:51:42 +0000 Subject: [Koha-bugs] [Bug 14505] New: single quotes in journal number cause print routing list window to not appear Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Bug ID: 14505 Summary: single quotes in journal number cause print routing list window to not appear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To replicate: Have a serial, receive a serial with a number as follows: iam 1000: The World's Leading Patent Professionals 2015 Set up a routing list for this serial. Click on "Serial Collection" [Fail condition] Click "Print routing list" - the window will not appear. Edit the received serials, remove the single quote from the number, save it. [Success condition] Click "Print routing list" - the window will appear, and the list can be printed. There may be other characters that cause this as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 05:23:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 03:23:42 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #73 from M. Tompsett --- Please rebase and fix the issue raised in comment #71. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 05:35:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 03:35:10 +0000 Subject: [Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 05:47:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 03:47:18 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #74 from M. Tompsett --- (In reply to M. Tompsett from comment #73) > Please rebase and fix the issue raised in comment #71. And comment #69. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 05:51:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 03:51:13 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 --- Comment #21 from Liz Rea --- Actually I was wrong, it wasn't the slash, it was \r\n in the address fields that are doing it - so yeah, backslashes explode this in 3.18. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 09:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 07:28:43 +0000 Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 10:42:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 08:42:41 +0000 Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 12:59:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 10:59:03 +0000 Subject: [Koha-bugs] [Bug 14503] Norwegian patron database: Hide social security number from staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14503 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- Please think of it the most general as possible. I think other people could reuse the patron db feature if it was more general. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 13:51:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 11:51:42 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 14:28:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 12:28:51 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #19 from Maxime Beaulieu --- Created attachment 40831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40831&action=edit Bug 11299 - Follow-up to QA failure Fixes problems reported by koha-qa use Modern::Perl Changed required permission to editauthorities pertidy cataloguing/automatic_linker.pl Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. The message box should now show "600 - No matching authority found." if no matching authority was found. For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup should appear, containing a "Modify authority" form. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". I tried it and got the expected results. (In reply to Jonathan Druart from comment #18) > 5/ * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." > > No, I got > Automatic authority link results: > 700 - No matching authority found. > ... Jonathan, did you create the biblio from scratch? The record you tested probably had data in the 700 field. Tests will be included in a future patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 15:12:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 13:12:25 +0000 Subject: [Koha-bugs] [Bug 14506] New: barcode printing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14506 Bug ID: 14506 Summary: barcode printing Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: pedro.m.ferreira at mail.cm-portel.pt QA Contact: testopia at bugs.koha-community.org Hello, I have trying to print labels and the barcode generation always fails. the procedure is : i go to home > tools > labels home > new batch i add 2 or 3 items and i get this errors in koha_error.log [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:32 2015] label-create-pdf.pl: Use of uninitialized value $strwidth in numeric lt (<) at /var/www/koha3.20.01/lib/C4/Creators/Layout.pm line 233. [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Use of uninitialized value $num_of_bars in multiplication (*) at /var/www/koha3.20.01/lib/C4/Labels/Label.pm line 532. [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Use of uninitialized value $params{"barcode_data"} in concatenation (.) or string at /var/www/koha3.20.01/lib/C4/Labels/Label.pm line 535. [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Barcode generation failed for item 114 with this error: Invalid Characters [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Use of uninitialized value $strwidth in numeric lt (<) at /var/www/koha3.20.01/lib/C4/Creators/Layout.pm line 233. [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Use of uninitialized value $num_of_bars in multiplication (*) at /var/www/koha3.20.01/lib/C4/Labels/Label.pm line 532. [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Use of uninitialized value $params{"barcode_data"} in concatenation (.) or string at /var/www/koha3.20.01/lib/C4/Labels/Label.pm line 535. [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Barcode generation failed for item 113 with this error: Invalid Characters [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Use of uninitialized value $strwidth in numeric lt (<) at /var/www/koha3.20.01/lib/C4/Creators/Layout.pm line 233. [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Use of uninitialized value $num_of_bars in multiplication (*) at /var/www/koha3.20.01/lib/C4/Labels/Label.pm line 532. [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Use of uninitialized value $params{"barcode_data"} in concatenation (.) or string at /var/www/koha3.20.01/lib/C4/Labels/Label.pm line 535. [Wed Jul 08 12:57:33 2015] [error] [client 127.0.0.1] [Wed Jul 8 12:57:33 2015] label-create-pdf.pl: Barcode generation failed for item 115 with this error: Invalid Characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 15:58:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 13:58:15 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #24 from Jonathan Druart --- (In reply to David Cook from comment #23) > Jonathan: Is this ready for testing now? yep :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 16:13:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 14:13:43 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 16:16:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 14:16:00 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 16:16:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 14:16:03 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40249|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 40832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40832&action=edit Bug 14404 [QA Followup] - Rename class nosort to no-sort for readability and consistency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 16:16:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 14:16:31 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40249|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 16:25:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 14:25:34 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14453 Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 16:25:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 14:25:34 +0000 Subject: [Koha-bugs] [Bug 14453] kohaidx is missing for id in authority-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14217 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 16:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 14:55:21 +0000 Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- > UPDATE matchpoints SET search_index = 'issn' WHERE matcher_id = 2; How do you know the matcher_id is 2 for everyone? Your fresh install modifications change isbn to issn, is that correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 16:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 14:55:42 +0000 Subject: [Koha-bugs] [Bug 12329] Inventory setting date last seen to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12329 --- Comment #3 from Nicole C. Engard --- I cannot reproduce on master. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:09:41 +0000 Subject: [Koha-bugs] [Bug 12329] Inventory setting date last seen to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12329 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14001 --- Comment #4 from M. Tompsett --- I may have resolved this. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001#c10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:09:41 +0000 Subject: [Koha-bugs] [Bug 14001] Inventory has bad $_ references In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12329 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:39:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:39:33 +0000 Subject: [Koha-bugs] [Bug 14001] Inventory has bad $_ references In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate, | |rel_3_16_candidate, | |rel_3_18_candidate --- Comment #13 from M. Tompsett --- As per Jonathan's comment #11, I confirmed the fix cleanly applies back to 3.14.x, and added candidate keywords. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:56:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:56:06 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from M. Tompsett --- As per my discussion with tcohen on IRC, I'm signing off, because "we are loos[en]ing the coding guidelines for the help pages, because Nicole copy/pastes from the manual, otherwise is too much work" For future reference, Nicole, these git commands are handy in preventing whitespace issues like this: git config --global core.whitespace trailing-space,space-before-tab git config --global apply.whitespace fix Just type them once in your Koha git area, and never think about it again. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:57:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:57:32 +0000 Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 --- Comment #7 from Amit Gupta --- Hi Mark, Thanks for comments >How do you know the matcher_id is 2 for everyone? Yes you are right matcher_id is 2 not for everyone. ------------------------------------------------------- update marc_matchers set search_index ='issn' where matcher_id = (select matcher_id from marc_matchers where code = 'ISSN'); ------------------------------------------------------- >Your fresh install modifications change isbn to issn, is that correct? Currently if you upload MARC records using "ISSN(022$a)" record matching rule. It will not match any record due to wrong search index. After applying this patch the incoming records should match perfectly using ("ISSN(022$a)" record matching rule). Will resend patch again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:58:42 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40536|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 40833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40833&action=edit Bug 14424 : Patron Help Files for 3.20 This patch updates the help files for 3.20 To test: * Visit * Main patron page * Patron search page * Patron permissions page * Confirm the text is right on all three Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:58:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:58:47 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40537|0 |1 is obsolete| | --- Comment #21 from M. Tompsett --- Created attachment 40834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40834&action=edit Bug 14424: Update cataloging help for 3.20 This patch updates 3 help files for catalolging in 3.20 To test: * Visit * cataloging home * cataloging a new record * mergin bib records * Confirm text is right and visible Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:58:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:58:56 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40539|0 |1 is obsolete| | --- Comment #23 from M. Tompsett --- Created attachment 40836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40836&action=edit Bug 14424: Update Acq Help for 3.20 This patch adds the missing order from subscription help and updates basket help. To test: * Visit a basket, review the help * Click order from a subscrption, review the help Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:58:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:58:51 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40538|0 |1 is obsolete| | --- Comment #22 from M. Tompsett --- Created attachment 40835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40835&action=edit Bug 14424: Update Discharge Help for 3.20 This patch adds the missing discharge help file and updates the moremember file with info on discharges. To test: * Visit a patron * View and confirm help is right * Visit the discharge page on the patron * Confirm help file loads and is right Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 17:59:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 15:59:00 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40540|0 |1 is obsolete| | --- Comment #24 from M. Tompsett --- Created attachment 40837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40837&action=edit Bug 14424: Add on site checkouts help for 3.20 There is no help for the pending on site checkouts report. This patch adds it. To test: * visit pending on site checkouts * click help * confirm help is there and correct Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 18:12:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 16:12:29 +0000 Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 --- Comment #8 from Amit Gupta --- correct sql -------------------- UPDATE matchpoints SET search_index ='issn' where matcher_id = (SELECT matcher_id FROM marc_matchers WHERE code = 'ISSN'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 18:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 16:23:11 +0000 Subject: [Koha-bugs] [Bug 14453] kohaidx is missing for id in authority-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40634|0 |1 is obsolete| | Attachment #40639|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 40838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40838&action=edit [PASSED QA] Bug 14453: kohaidx is missing for id in authority-koha-indexdefs.xml In authority-koha-indexdefs.xml, all tags use the namespace "kohaidx" except the tag "id". When re-generating authority-zebra-indexdefs.xsl, the line : is modified : This is an error. This patch adds kohaidx namespace to correct. Test plan : - Without patch - go to etc/zebradb/marc_defs/marc21/authorities/ - run : xslproc xsltproc ../../../xsl/koha-indexdefs-to-zebra.xsl authority-koha-indexdefs.xml > authority-zebra-indexdefs.xsl - read authority-zebra-indexdefs.xsl => the line has changed : - Apply patch - go to etc/zebradb/marc_defs/marc21/authorities/ - run : xslproc xsltproc ../../../xsl/koha-indexdefs-to-zebra.xsl authority-koha-indexdefs.xml > authority-zebra-indexdefs.xsl - read authority-zebra-indexdefs.xsl => the line has not changed (same for unimarc flavor) Signed-off-by: Mirko Tietgen Signed-off-by: Tomas Cohen Arazi As Mirko mentioned, the xslt's now generate the facet-processing templates in the authority xslt's too. They are harmless because we don't define facets for authority records. If we did, it would be harmless too. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 18:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 16:23:17 +0000 Subject: [Koha-bugs] [Bug 14453] kohaidx is missing for id in authority-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 --- Comment #14 from Kyle M Hall --- Created attachment 40839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40839&action=edit [PASSED QA] Bug 14453: (followup) Fix shipped XSLT files Make the shipped XSLTs for authorities (MARC21 and UNIMARC) the same as the generated version Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 18:23:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 16:23:28 +0000 Subject: [Koha-bugs] [Bug 14453] kohaidx is missing for id in authority-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 18:34:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 16:34:10 +0000 Subject: [Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40801|0 |1 is obsolete| | --- Comment #9 from Amit Gupta --- Created attachment 40840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40840&action=edit Bug 14472 - Wrong ISSN search index in record matching rules Bug 14472 - Wrong ISSN search index in record matching rules TEST PLAN --------- 1) Apply the patch 2) Export some MARC bibliographic records from Koha 3) Import those same MARC bibliographic records using the "ISSN(022$a)" record matching rule. 4) The incoming records should match perfectly 5) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. For new Koha installation 1) create the koha database 2) Go to the staff client page, and do a "fresh" install making sure to select lots of optional marc 21 matching rules so the .../marc21/optional/marc21_default_matching_rules.sql gets triggered. 3) Check the mysql tables (marc_matchers, matchpoints, matcher_matchpoints, matchpoint_components, matchpoint_component_norms) to make sure the values were inserted as expected. Fix SQL: UPDATE matchpoints SET search_index ='issn' where matcher_id = (SELECT matcher_id FROM marc_matchers WHERE code = 'ISSN'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 18:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 16:46:33 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #9 from Amit Gupta --- Hi maxime.beaulieu at inlibro.com, Need this patch one of our client. Can i take on this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:06:50 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #117 from Brendan Gallagher --- Any update on this? Now is the time to really get a move on this so we have enough months left to test and fix for getting into 3.22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:19:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:19:41 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 40841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40841&action=edit Sample MARCXML record Sample record containing a 100$a field, with ind2=7 for testing purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:20:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:20:24 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 40842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40842&action=edit Bug 14217: Add 'condition' attribute for DOM index definition This patch introduces an extension to the current syntax for DOM index definition. Specifically, it extends the 'index_subfields' tag to allow adding a 'condition' attribute that is used as a condition ofr applying the specified index. This (exotic) example is self-explanatory: The previous syntax (which is keeped by this patch) took this snippet from biblio-koha-indexdefs.xml Encuadernador:w and generated an XSLT snippet in the DOM indexing XSLT that looks like this: This patch introduces this syntax change (note the 'condition' attribute: Encuadernador:w which yields to this XSLT snippet in the DOM indexing XSLT: To test: - Verify that the shipped XSLT files are current regarding the shipped index definitions: $ for i in marc21 normarc unimarc; do xsltproc etc/zebradb/xsl/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/$i/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/$i/biblios/biblio-zebra-indexdefs.xsl done $ git status (repeat for authorities, skip normarc which doesn't have authorities) - Apply the patch - Re-run the previous commands => SUCCESS: no changes - Add a condition to an index_subfields tag (for example, condition="@ind2='7'" in the Author's index - Regenerate the specific XSLT => SUCCESS: doing a diff shows the only change is the code has been wrapped inside an xslo:if using the condition for the test - Apply the generated xsl to a MARCXML record that has a field matching the condition like this: $ xsltproc .../biblio-zebra-indexdefs.xsl sample_record.xml => SUCCESS: There's an index on the result, containing the configured field/subfields, that matches the criteria. - Sign off and feel really happy :-D Note: the attached sample record includes a 100 field, with ind2=7 and $a=Tomasito Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:20:41 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:27:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:27:43 +0000 Subject: [Koha-bugs] [Bug 13340] Add a Koha::Config::SystemPreference class for handling sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13340 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 13967 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:27:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:27:43 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #29 from Tom?s Cohen Arazi --- *** Bug 13340 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:41:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:41:28 +0000 Subject: [Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:42:00 +0000 Subject: [Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Eivin and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:42:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:42:23 +0000 Subject: [Koha-bugs] [Bug 14326] XSLT Syntax error in MARC21slimOPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14326 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:42:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:42:45 +0000 Subject: [Koha-bugs] [Bug 14453] kohaidx is missing for id in authority-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14453 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Good catch Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:49:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:49:31 +0000 Subject: [Koha-bugs] [Bug 14507] New: SIP Authentication broken when LDAP Auth Enabled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Bug ID: 14507 Summary: SIP Authentication broken when LDAP Auth Enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: shiundu at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org SIP Authentication is broken when LDAP Auth Enabled. With ldap enabled, testing via telnet using 9300CNkohasipuserid|COkohasipuserpwd|CPmybranch| returns 941 but sip.err shows: LDAP bind failed as kohauser kohasipuser: LDAP error #49: LDAP_INVALID_CREDENTIALS # The wrong password was supplied or the SASL credentials could not be processed When ldap auth is disabled in koha-xml.conf everything works as advertised. When kohasipuser is added to ldap the above error in sip.err goes away but Koha users still cannot login via SIP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:51:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:51:23 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #10 from Maxime Beaulieu --- Created attachment 40843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40843&action=edit Bug 10076 - Fixed merge conflicts. Patch now applies properly modified: C4/Letters.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:51:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:51:32 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31397|0 |1 is obsolete| | --- Comment #11 from Maxime Beaulieu --- Created attachment 40844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40844&action=edit syspref.sql and updatedatabase.pl Added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 19:51:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 17:51:44 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #12 from Maxime Beaulieu --- Created attachment 40845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40845&action=edit Bug 10076 - Atomic Update new file: installer/data/mysql/atomicupdate/Bug10076_ClaimsBccCopy.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:04:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:04:45 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31262|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:04:58 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40843|Bug 10076 - Fixed merge |Bug 10076 - Add Bcc syspref description|conflicts. |for claimacquisition and | |claimissues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:05:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:05:12 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:06:02 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #13 from Maxime Beaulieu --- Patch has been rebased to current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:07:49 +0000 Subject: [Koha-bugs] [Bug 3206] OAI repositry deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 --- Comment #26 from Tom?s Cohen Arazi --- Created attachment 40846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40846&action=edit Bug 3206: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:15:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:15:17 +0000 Subject: [Koha-bugs] [Bug 3206] OAI repository deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|OAI repositry deleted |OAI repository deleted |record support |record support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:18:46 +0000 Subject: [Koha-bugs] [Bug 14163] "Show all" in acquisition confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:19:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:19:10 +0000 Subject: [Koha-bugs] [Bug 13950] Sort Item search home library list by branch name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13950 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:19:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:19:44 +0000 Subject: [Koha-bugs] [Bug 14366] Units doesn't get saved usefully for patroncards In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14366 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:20:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:20:34 +0000 Subject: [Koha-bugs] [Bug 3206] OAI repository deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #27 from Tom?s Cohen Arazi --- Enahcement pushed to master. Good job Matthias! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:32:31 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |tomascohen at gmail.com --- Comment #43 from Tom?s Cohen Arazi --- I definitely think this might not be a feature for some institutions and we should make it opt-in. Because as Galen mentioned, it is not obvious that everyone will want to include items data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 20:34:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 18:34:27 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 22:10:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 20:10:48 +0000 Subject: [Koha-bugs] [Bug 14508] New: 'New patron' dropdown empty list on circulation.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Bug ID: 14508 Summary: 'New patron' dropdown empty list on circulation.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 22:12:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 20:12:59 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 40847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40847&action=edit (wrong) Dropdown empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 22:13:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 20:13:26 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 40848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40848&action=edit (correct) Dropdown with categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 22:16:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 20:16:08 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 --- Comment #3 from Tom?s Cohen Arazi --- Steps to reproduce: - On master (and 3.20 at least) - On the checkout form, perform a search that (a) returns more than one result (b) returns zero results - Click the dropdown menu to create a new patron => FAIL: Dropdown is empty - Repeat for (a) or (b) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:02:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:02:35 +0000 Subject: [Koha-bugs] [Bug 14401] Zebra index configuration doesn't allow exact search for 'C.' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14401 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable Severity|enhancement |normal --- Comment #5 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:05:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:05:08 +0000 Subject: [Koha-bugs] [Bug 14001] Inventory has bad $_ references In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:12:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:12:59 +0000 Subject: [Koha-bugs] [Bug 13874] rotating collections and calendar are circ tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13874 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:18:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:18:45 +0000 Subject: [Koha-bugs] [Bug 3206] OAI repository deleted record support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 --- Comment #28 from Tom?s Cohen Arazi --- Created attachment 40849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40849&action=edit Bug 3206: (QA followup) missing comma on sysprefs.sql Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:36:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:36:37 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:36:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:36:40 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 40850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40850&action=edit Bug 14508: 'New patron' dropdown empty list on circulation.pl This patch makes includes/patron-toolbar.inc (the one in charge of rendering the 'New patron' dropdown) make use of the Categories Template Toolkit plugin to create the list of categories. (1) To check the setup is sane: - Go to the Patrons page => SUCCESS: The 'New patron' dropdown is populated - Click on the [+] symbol on the Patron search on the top => SUCCESS: The Categories dropdown is populated (2) To test the patch: - On the checkout form, perform a patron search that (a) returns more than one result (b) returns zero results - Click the dropdown menu to create a new patron => FAIL: Dropdown is empty - Repeat for (a) or (b) - Apply the patch and reload => SUCCESS: The dropdown is correctly populated - Repeat (1) => SUCCESS: Nothing got broken - Verify the logs => SUCCESS: No new warnings - Sign off :-D - Get a cookie - Smile Regards Discussion: we might need a new bug to start cleaning stuff like this: @categories=C4::Category->all; if(scalar(@categories) < 1){ $no_add = 1; $template->param(no_categories => 1); } else { $template->param(categories=>\@categories); } but it belongs to a new bug me thinks. Well, suggestions are welcome, but this must be fixed on stable ASAP so hurry :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:39:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:39:25 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:46:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:46:09 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #33 from Tom?s Cohen Arazi --- *** Bug 12982 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:46:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:46:09 +0000 Subject: [Koha-bugs] [Bug 12982] Patron category dropdown empty in header search form on patron entry page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12982 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch fixes an issue, but also implements a way to get the patron categories through TT plugins. I think it has already been addressed by bug 7380. Feel free to report a new bug if the mentioned bug is already present for you (I didn't manage to reproduce it, on top of master/7380). *** This bug has been marked as a duplicate of bug 7380 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 8 23:54:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 21:54:20 +0000 Subject: [Koha-bugs] [Bug 12480] Encoding problem with "New patron" -button categories when no patron found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12480 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- I think this bug is no longer valid. In current master the list doesn't show at all :-D but is fixed by 14508 anyway. Closing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 00:45:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 22:45:13 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #44 from Robin Sheat --- (In reply to Tom?s Cohen Arazi from comment #43) > I definitely think this might not be a feature for some institutions and we > should make it opt-in. Because as Galen mentioned, it is not obvious that > everyone will want to include items data. Well, it is there for harvesting. The reason I added it is because the harvesting required the item data so it could be presented. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 01:51:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Jul 2015 23:51:40 +0000 Subject: [Koha-bugs] [Bug 11620] Add dissertation-information index for non-UNIMARC installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11620 --- Comment #6 from Katrin Fischer --- Thx Tomas - so this is ready for QA! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 02:25:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 00:25:54 +0000 Subject: [Koha-bugs] [Bug 14492] Adding serials predicts wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14492 --- Comment #2 from James --- Thanks Katrin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 02:27:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 00:27:35 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 02:27:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 00:27:38 +0000 Subject: [Koha-bugs] [Bug 14259] OPAC system preference BiblioDefaultView is ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14259 --- Comment #6 from M. Tompsett --- Created attachment 40851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40851&action=edit Bug 14259: OPAC system preference BiblioDefaultView is ignored Cover image links ignore the BiblioDefaultView value for non-XSLT. XSLT was corrected in 12574. TEST PLAN --------- 1) Back up your database 2) drop you db and do a fresh install of the sample data 3) set koha admin to a super librarian, and set up a username and password for it. 4) catalog "The Road To Character" by David Brooks. 5) using koha admin import a small set of data. 6) stop zebra and do a full reindex then restart it. 7) Change the 'OPACXSLTDetailsDisplay' and 'OPACXSLTResultsDisplay' system preferences to blank! -- This corrects the non-XSLT things missed by 12574. 7) Change the 'GoogleJackets' system preference to 'Add'. 8) Change the 'BiblioDefaultView' system preference to 'in their MARC form'. 9) Change the 'IDreamBooksResults' system preference to 'Add'. 10) Search for something that will find "The Road To Character" and something else in the OPAC. 11) Run your mouse over the title text in the search results. -- Link will be to opac-MARCdetail.pl 12) Run your mouse over the cover image or lack thereof. -- Link will be to opac-detail.pl -- This will fail for both "The Road to Character" and the non-"The Road to Character" entries. 13) Apply this patch 14) Refresh the OPAC page -- Links under the cover images will be corrected. 15) In the staff client, change 'IDreamBooksReviews' to 'Add'. 16) Refresh the OPAC page -- "The Road to Character" will be correct, but have a '#idb_critic_reviews' appended. 17) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 02:52:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 00:52:03 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #17 from Katrin Fischer --- I agree with Jonathan, I think creating authorized values is not necessary. If we are going with extended patron attributes, then I'd just copy the values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 02:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 00:57:42 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #12 from Katrin Fischer --- > Signed-off-by: Chris Cormack > > This does what it says it will do, however I think it might be a > change of behaviour, in terms of the specify due date. It now clears > it the date after ever item is checked out. > > Previously the due date would stay, until the current borrower is > dealt with. And remember for session sets it so that it stays until > the staff member logs out, or clears it. > > With the patch, now the date is clear after every check out .. this is > a change that may annoy some people. Hm I agree with Chris that this change of behaviour might not be good for every library and use case - so people might get annoyed. I'd prefer if the date was only cleared out after checking out an item where the due date gets shortened. Would that work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 03:22:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 01:22:25 +0000 Subject: [Koha-bugs] [Bug 14509] New: Koha still allows spaces at the end, beginning or as your password Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Bug ID: 14509 Summary: Koha still allows spaces at the end, beginning or as your password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org This is a follow-up bug for bug 10177 which fixed the 'change password' page to not allow your password to have spaces at the beginning or ending or to consist solely of spaces. But there are still 2 other pages to fix: - Patron account > Edit patron - OPAC > Change password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 03:22:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 01:22:39 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10177 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 03:22:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 01:22:39 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14509 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 03:29:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 01:29:37 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|acquisitions shows |Publication information can |publisher from 260 only |only be mapped to either |(RDA) |260 or 264 (RDA) --- Comment #2 from Katrin Fischer --- It's really important that we fix this, because otherwise while the catalogs still contain 'mixed data' we will have lots of places not only in acq where there will no publication year, publication place or publisher be shown for part of the records. I think changing the mapping so you can have 2 fields is probably the more complicated thing to do - also, how will the system act if both are present? My feeling would be to prefer the newer field 264 over the older 260 in case both are present. I am not sure how to reflect this in the GUI properly, but we need a fix soon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 03:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 01:30:54 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #3 from Katrin Fischer --- To be clear, the problem stems from our Koha-to-MARC-Mappings - the problem will show up whereever we get the information from the biblio and biblioitems tables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:05:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:05:54 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #60 from Katrin Fischer --- Comment on attachment 36856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36856 [PASSED QA] Bug 10937 - Option to hide and group itemtypes from advanced search Review of attachment 36856: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10937&attachment=36856) ----------------------------------------------------------------- I talked to Tomas about this a while ago and finally got around to put my concerns in writing. Leaving to Tomas for final decision as this is PQA right now. ::: C4/Koha.pm @@ +33,2 @@ > use DBI qw(:sql_types); > + use Data::Dumper; This here doesn't look quite right, first you have: use autouse 'Data::cselectall_arrayref' => qw(Dumper); then an additional use Data::Dumper; Can you explain? @@ +279,5 @@ > + $categories = GetItemTypesCategorized(); > + > +Returns a hashref containing search categories. > +A search category will be put in the hash if at least one of its itemtypes is visible in OPAC. > +The categories must be part of Authorized Values (DOCTYPECAT) I am not happy with the name: DOCTYPECAT. If this is to help group itemtypes, why not name it accordingly? ITYPECAT or ITEMTYPECAT? Or a bit different: ITYPEGROUP? ::: installer/data/mysql/kohastructure.sql @@ +1276,5 @@ > checkinmsg VARCHAR(255), -- message that is displayed when an item with the given item type is checked in > checkinmsgtype CHAR(16) DEFAULT 'message' NOT NULL, -- type (CSS class) for the checkinmsg, can be "alert" or "message" > sip_media_type VARCHAR(3) DEFAULT NULL, -- SIP2 protocol media type for this itemtype > + hideinopac tinyint(1) NOT NULL DEFAULT 0, -- Hide the item type from the search options in OPAC > + searchcategory varchar(20) default NULL, -- Group this item type with others with the same value on OPAC search options I think this is used to store the authorised value code picked from the authorized value DOCTYPECAT category. If I am not wrong, they should match in length to avoid problems: authorised_values.authorised_value is varchar(80) ::: installer/data/mysql/updatedatabase.pl @@ +9838,5 @@ > + $dbh->do(q{ > + ALTER TABLE itemtypes > + ADD hideinopac TINYINT(1) NOT NULL DEFAULT 0 > + AFTER sip_media_type, > + ADD searchcategory VARCHAR(20) DEFAULT NULL See above! ::: t/db_dependent/Koha.t @@ +7,4 @@ > use warnings; > use C4::Context; > use Koha::DateUtils qw(dt_from_string); > +use Data::Dumper; I am not sure if this is needed here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:06:50 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40613|0 |1 is obsolete| | --- Comment #6 from Nicholas van Oudtshoorn --- Created attachment 40852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40852&action=edit Bug 14407 - Allow web-based self checkout to be limited by IP addresses/ranges Allow web-based self-checkout to be limited to only certain IPs or IP ranges As per Robin's suggestion in Comment 4, it no longer uses an XS module. I have, however, gone for Net::CIDR instead of Net::IP::Match. For one thing, it looks like it's already packaged for Debian (and, as a bonus, for Fedora too!) For another, Net::IP::Match seemed to want to know a list of addresses etc. to match at "compile time". If this patch is acceptable, would another to adjust opac-search to use Net::CIDR be a nice "tidying to one standard" patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:09:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:09:15 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:09:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:09:17 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40044|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 40853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40853&action=edit Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue notices The patch changes the sequence of cronjobs in the crontab example file and in the cron.daily file of the packages. This is why: 1) Renew automatically ... only when we can't renew, we want to 2) Calculate fines ... once the fine are calculated and charged we can print the amount into the 3) Overdue notices Before the change it could happen that you'd charge for an item, that would then be renewed. Or that you'd try to print fine amounts into the overdue notices, when they would only be charged moments later. To test: - configure your system so you have items that should - be charged with fines - renew automatically - configure your crontabs according to the example file or switch the cron.daily in your package installation with the new one - configure your overdue notices so that one should be generated <> - Wait for the cronjobs or schedule them to run earlier - Verify all is well and as it should be -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:09:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:09:49 +0000 Subject: [Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #10 from Katrin Fischer --- Thx for checking Mark, I have uploaded a hopefully fixed patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:19:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:19:00 +0000 Subject: [Koha-bugs] [Bug 9254] New option to block patrons from changing messaging preferences in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #39 from Katrin Fischer --- I am not sure moderation is the right answer here. What will you do if you don't agree with the settings the user has changed? Will you contact them by email to tell them why their choice wasn't good or just deny the change without any explanation? Moderation is great for a lot of things, but I think for switches like that, it wouldn't work really well. Another suggestion would be to only allow changing settings for some, but not all notices/messages. But I feel like this should be separate from this bug and would be another enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:23:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:23:24 +0000 Subject: [Koha-bugs] [Bug 14397] Typo 'foriegn' in table comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14397 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Aleisha, I think they are generated from kohastructure.sql - the typo is also visible there: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/kohastructure.sql;hb=6e9086fb2c4d031e6e99efca85ad4a5f3c0b9f42#l120 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:27:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:27:42 +0000 Subject: [Koha-bugs] [Bug 1368] Use of FOREIGN_KEY_CHECKS = 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:27:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:27:44 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #7 from Robin Sheat --- (In reply to Nicholas van Oudtshoorn from comment #6) > As per Robin's suggestion in Comment 4, it no longer uses an XS module. I > have, however, gone for Net::CIDR instead of Net::IP::Match. For one thing, > it looks like it's already packaged for Debian (and, as a bonus, for Fedora > too!) For another, Net::IP::Match seemed to want to know a list of addresses > etc. to match at "compile time". Brilliant, Net::CIDR has been in Debian since the dawn of time, so that makes me happier :) You've missed updating the use lines in sco-patron-image.pl though. Also don't forget to update C4/Installer/PerlDependencies.pm (keep an eye on the version version numbers being correct, wheezy has 0.15.) > If this patch is acceptable, would another to adjust opac-search to use > Net::CIDR be a nice "tidying to one standard" patch? I'd make a new bug for that, it'll possibly be more complicated than you expect as it'll have to account for the possibility of the format of a syspref changing, and either correcting that in the database or accepting the old form as well as the new one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:34:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:34:55 +0000 Subject: [Koha-bugs] [Bug 4503] Javascript files in js directory are not translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4503 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m Assignee|frederic at tamil.fr |jweaver at bywatersolutions.co | |m --- Comment #2 from Jesse Weaver --- Starting work on this, patch to follow. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:40:21 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 --- Comment #19 from Katrin Fischer --- Comment on attachment 38518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38518 Bug 6815: Capture picture from web cam Review of attachment 38518: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6815&attachment=38518) ----------------------------------------------------------------- I have to say I am in favour of a client side solution and we are not supporting IE for the staff client officially. I think for a feature that is not a core functionality it would be ok for me if it was limited to Firefox/Chromium. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +271,5 @@ > > >
    > +      > + [% IF ( webcam ) %]    [% END %] Using multiple   for styling is no good style - this should be done using CSS. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:42:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:42:18 +0000 Subject: [Koha-bugs] [Bug 12906] Show shipment date in invoice search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12906 --- Comment #5 from Katrin Fischer --- Thx for the follow-up Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:42:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:42:34 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 04:44:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 02:44:49 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #65 from Katrin Fischer --- I think we are not far - please fix so this long story can have a happy end :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 05:14:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 03:14:48 +0000 Subject: [Koha-bugs] [Bug 14510] New: Allow column visibility in additem.pl to be customized Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Bug ID: 14510 Summary: Allow column visibility in additem.pl to be customized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It should be possible to customize column visibility in the items table in additem.pl through the columns configuration tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 08:56:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 06:56:14 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40852|0 |1 is obsolete| | --- Comment #8 from Nicholas van Oudtshoorn --- Created attachment 40854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40854&action=edit Bug 14407 - Allow web-based self checkout to be limited by IP addresses/ranges (In reply to Robin in Comment #7) >Brilliant, Net::CIDR has been in Debian since the dawn of time, so that makes >me happier :) :-) Glad to have brought a sigh of relief! > You've missed updating the use lines in sco-patron-image.pl though. D'oh! Fixed that now >Also don't forget to update C4/Installer/PerlDependencies.pm (keep an eye on the version version numbers being correct, wheezy has 0.15.) Ah! Hadn't thought about that at all. Should be done now. >> If this patch is acceptable, would another to adjust opac-search to use >> Net::CIDR be a nice "tidying to one standard" patch? >I'd make a new bug for that, it'll possibly be more complicated than you >expect as it'll have to account for the possibility of the format of a syspref >changing, and either correcting that in the database or accepting the old form >as well as the new one. Agreed it would need a new bug. Have had a quick squiz, and it seems that NET::CIDR::range2cidr is perfectly happy with the format required by the current preference. It could, however, be changed to allow for much greater variety... (multiple subnets, individual IPs, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:19:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:19:21 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #13 from Eivin Giske Skaaren --- Obviuously I am rather new to Koha but I actually thought it was the other way. Since you have the "Remember for session" checkbox and also probably a default due date in the system (perhaps even on item level? have not checked/can not remember right now) I found it strange that the value was not cleared. Do we want the default behavior to be that the value is cleared only when the due date is shortened? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:23:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:23:29 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #45 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #43) > I definitely think this might not be a feature for some institutions and we > should make it opt-in. Because as Galen mentioned, it is not obvious that > everyone will want to include items data. I am pretty sure it's a bug and a regression introduced by bug 5579. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:31:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:31:49 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #16) > The patch removes the tables/fields if data exist (which is certainly not > the case), or leave them. Hum, trying again... The patch removes the tables/fields when they don't contain any data (which is certainly the case) or keep them if they are not empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:32:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:32:23 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40765|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 40855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40855&action=edit Bug 14388: Funds should be sorted by budget_code Before this patch, the funds were sorted by budget_id, which does not make any sense. This patch adds a sort by budget_code on the fund list (acqui/acqui-home.pl and admin/aqbudgets.pl) Test plan: On both pages (acqui/acqui-home.pl and admin/aqbudgets.pl) confirm that the funds are now sorted by fund code (DB column budget_code) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:34:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:34:05 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #5 from Jonathan Druart --- (In reply to M. Tompsett from comment #2) > second child, not first. Please fix typo. Fixed, thanks (In reply to M. Tompsett from comment #3) > I was not able to duplicate issue with Debian Jessie on Master. Though, this > patch clearly forces sorting. They are currently sorted by budget_id. > Additionally, tests failed to run with my initial data set. Requires CPL. Which is the case for almost all tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:42:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:42:31 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40545|0 |1 is obsolete| | Attachment #40743|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 40856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40856&action=edit Bug 14445: Silences warn in letter.pl When changing Koha module to 'Circulation', there is a warn saying that $code is uninitialized. This patch sets $code to an empty string to silence the warn. To test: 1) Go to Tools, the Notices & Slips 2) Click 'new notice' (This will trigger warns, but ignore these as they will be corrected in the next patch) 3) Change Koha module to 'Circulation' 4) Notice warn about uninitialized $code variable 5) Apply patch and reload page, change Koha module to 'Circulation' 6) Notice page still works and warns are gone Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:42:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:42:29 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:42:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:42:36 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #8 from Jonathan Druart --- Created attachment 40857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40857&action=edit Bug 14445: Silences warns in letter.tt When creating a new notice, warn is triggered "Argument "" isn't numeric in numeric gt (>) at line 400". Same warn is triggered when changing Koha module option to any other module. To test: 1) Go to Tools, then Notices & Slips 2) Click 'new notice'. Notice warn in intranet-error.log 3) Change Koha module to another module. Notice warn is triggered for every change 4) Apply patch and reload page 5) Change Koha module to another module. Notice there are no longer warns 6) Go back to Notices & Slips and click 'new notice' again. Notice there are no warns Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:46:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:46:57 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #9 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #6) > (In reply to Jonathan Druart from comment #5) > > > > This is wrong, we want to display the length of the content. > > With your patch, the string displayed is always > > "Message body: 0/160 characters" > > Hi Jonathan, this tests correctly for me, but do you know a better way to > silence this warn? You should have used letter.content.length. I have amended your 2 patches, please have a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:53:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:53:17 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 09:53:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 07:53:19 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40789|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 40858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40858&action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate. Test plan : - without patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos Works as advertised. Just one msgid appear with msgid "%s result(s) found in catalog," Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 10:34:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 08:34:36 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 10:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 08:36:35 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #2 from Jonathan Druart --- Created attachment 40859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40859&action=edit Bug 14197: TestBuilder - Remove the error on starting the transaction DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 10:38:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 08:38:52 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- The rule for developing on Koha is that we don't change behaviour that people will have been using for years. (The specify due date feature is about 8 years old, so suddenly changing the way it works will most definitely catch some people out) The reason we have this rule is so people won't be scared to upgrade (it's also the rule why new features go in switched off by default on upgrade) Hope this makes sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:00:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:00:58 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #1 from Jonathan Druart --- Created attachment 40860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40860&action=edit Bug 14494: Prevent slow checkout if the patron does not have an expiry date If a patron has a expiry date set to 9999-12-31 (for organizations for instance), the checkouts are very slow. It's caused by 2 different calls to DateTime in CanBookBeIssued: 1/ DateTime->new( year => 9999, month => 12, day => 31, time_zone => C4::Context->tz ); The time_zone should not be set (as it's done in Koha::DateUtils), set to UTC or floating tz. 2/ DateTime->compare($today, $expiry_dt) The comparaison of 2 DT with 1 related to 9999 is very slow, as you can imagine. For 1/ we need to call Koha::DateUtils::dt_from_string (actually, we should never call DateTime directly). For 2/ we just need to test if the date is != 9999, no need to compare it in this case. Test plan: Before this patch, confirm that the checkouts are slow if the patron has a dateexpiry set to 9999-12-31. update borrowers set dateexpiry="9999-12-31" where borrowernumber=42; After this patch, you should not see any regression when checking out items to an expired patron and to a valid patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:00:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:00:54 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:01:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:01:52 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14494 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > To see the warning see patches on bug 14045. And the errors with the patch on bug 14494. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:01:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:01:52 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14197 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:02:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:02:23 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14197 | Depends on| |14197 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:02:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:02:23 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14494 Depends on|14494 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:05:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:05:32 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #2 from Katrin Fischer --- Hm, I feel a bit like this builds in a secret feature - if I use 9998 it will be slow, but if I use 9999 it will be faster? When we fixed the same thing for debarments it made more sense, as the 'ulimited' debarment uses 9999 automatically, without the user entering a date. For the patron expiry the date is defined by the library and could be anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:18:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:18:18 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #2) > Hm, I feel a bit like this builds in a secret feature - if I use 9998 it > will be slow, but if I use 9999 it will be faster? > > When we fixed the same thing for debarments it made more sense, as the > 'ulimited' debarment uses 9999 automatically, without the user entering a > date. For the patron expiry the date is defined by the library and could be > anything. As I understood the description, the feature has existed. Anyway we should call Koha::DateUtils here and not directly DateTime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:30:03 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I don't think it's a feature - it has to be typed in manually in the configuration. I think it would make sense to me if we introduced an option to have an 'unlimited' expiry date in the GUI - then the check on 9999 would make more sense to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:32:31 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:32:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:32:33 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40249|0 |1 is obsolete| | Attachment #40832|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 40861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40861&action=edit Bug 14404 - Checkouts default sort order for Self Checkout (SCO) confusing for patrons Libraries are reporting that patrons are very confused during self-checkout. The problem is they are expecting the list of checkouts to be in the order they checked out the items ( first checkout on the bottom, last item checked out on top ). However, the checkouts table is sorted by title ( ascending ) then due date ( descending ). This is not intuitive. Test Plan: 1) Enable Koha's self checkout 2) Use the SCO to check out a random assortment of items, make sure you don't check them out in alphabetical order 3) Note the order of the items in the list is not based on the order you checked them out in 4) Apply this patch 5) Refresh the page 6) Note the items are now in the order you checked them out with the last on top and the first on bottom Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:32:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:32:48 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 --- Comment #6 from Jonathan Druart --- Created attachment 40862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40862&action=edit Bug 14404: Rename class no-show to noshow for consistency with nosort Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:35:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:35:40 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 --- Comment #7 from Jonathan Druart --- (In reply to Kyle M Hall from comment #4) > Created attachment 40832 [details] [review] > Bug 14404 [QA Followup] - Rename class nosort to no-sort for readability and > consistency I am against this patch, the "nosort" already exists in other places. Tomas, either 1/ you push my patch to get consistency between nosort (existented before this patch and in other places) or 2/ don't push it for readability and we will need to fix the existent occurrences of nosort. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:42:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:42:05 +0000 Subject: [Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |BLOCKED --- Comment #6 from Katrin Fischer --- I think pushing this without it being use makes no sense - there is a dependency on 6427 - marking this blocked for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:42:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:42:54 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:42:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:42:57 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40476|0 |1 is obsolete| | Attachment #40477|0 |1 is obsolete| | Attachment #40833|0 |1 is obsolete| | Attachment #40834|0 |1 is obsolete| | Attachment #40835|0 |1 is obsolete| | Attachment #40836|0 |1 is obsolete| | Attachment #40837|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 40863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40863&action=edit Bug 14424 : Patron Help Files for 3.20 This patch updates the help files for 3.20 To test: * Visit * Main patron page * Patron search page * Patron permissions page * Confirm the text is right on all three Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:43:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:43:01 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #26 from Jonathan Druart --- Created attachment 40864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40864&action=edit Bug 14424: Update cataloging help for 3.20 This patch updates 3 help files for catalolging in 3.20 To test: * Visit * cataloging home * cataloging a new record * mergin bib records * Confirm text is right and visible Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:43:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:43:05 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #27 from Jonathan Druart --- Created attachment 40865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40865&action=edit Bug 14424: Update Discharge Help for 3.20 This patch adds the missing discharge help file and updates the moremember file with info on discharges. To test: * Visit a patron * View and confirm help is right * Visit the discharge page on the patron * Confirm help file loads and is right Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:43:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:43:08 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #28 from Jonathan Druart --- Created attachment 40866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40866&action=edit Bug 14424: Update Acq Help for 3.20 This patch adds the missing order from subscription help and updates basket help. To test: * Visit a basket, review the help * Click order from a subscrption, review the help Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:43:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:43:11 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #29 from Jonathan Druart --- Created attachment 40867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40867&action=edit Bug 14424: Add on site checkouts help for 3.20 There is no help for the pending on site checkouts report. This patch adds it. To test: * visit pending on site checkouts * click help * confirm help is there and correct Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:43:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:43:47 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40863|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 40868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40868&action=edit Bug 14424 : Patron Help Files for 3.20 This patch updates the help files for 3.20 To test: * Visit * Main patron page * Patron search page * Patron permissions page * Confirm the text is right on all three Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:43:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:43:50 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40864|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 40869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40869&action=edit Bug 14424: Update cataloging help for 3.20 This patch updates 3 help files for catalolging in 3.20 To test: * Visit * cataloging home * cataloging a new record * mergin bib records * Confirm text is right and visible Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:43:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:43:53 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40865|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 40870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40870&action=edit Bug 14424: Update Discharge Help for 3.20 This patch adds the missing discharge help file and updates the moremember file with info on discharges. To test: * Visit a patron * View and confirm help is right * Visit the discharge page on the patron * Confirm help file loads and is right Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:43:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:43:56 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40866|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 40871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40871&action=edit Bug 14424: Update Acq Help for 3.20 This patch adds the missing order from subscription help and updates basket help. To test: * Visit a basket, review the help * Click order from a subscrption, review the help Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:43:59 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40867|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 40872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40872&action=edit Bug 14424: Add on site checkouts help for 3.20 There is no help for the pending on site checkouts report. This patch adds it. To test: * visit pending on site checkouts * click help * confirm help is there and correct Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:44:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:44:29 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #35 from Jonathan Druart --- Sorry for the flood, I forgot my signed-off-by line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 11:49:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 09:49:53 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #6 from M. Tompsett --- I wrote: > I was not able to duplicate issue with Debian Jessie on Master. > Though, this patch clearly forces sorting. (In reply to Jonathan Druart from comment #5) > They are currently sorted by budget_id. My screen says otherwise. I'm wondering if this is a hashes are stored in a random order issue, because it ordered 2,1,3 on my screen without the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:00:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:00:20 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #5 from Marcel de Rooy --- Created attachment 40873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40873&action=edit Bug 14494: Terribly slow checkout caused by DateTime->new in far future An expiry date like 9999-12-31 in the local timezone will make DateTime spend a lot of time (maybe 60 seconds) on date calculation. See the DateTime documention on CPAN. A calculation in floating (or alternatively in UTC) would only take a few milliseconds. This patch makes two changes in this regard: [1] The compare between expiry date and today in CanBookBeIssued is now done in the floating timezone. [2] If ReturnBeforeExpiry is enabled, CalcDateDue compares the normal due date with the expiry date. The comparison is now done in the floating timezone. If the expiry date is before the due date, it is returned in the user context's timezone. NOTE: The calls to set_time_zone moving to or from floating do not adjust the local time. TEST PLAN: First without this patch: [1] Set expiry date to 9999-12-31 for a patron. [2] Enable ReturnBeforeExpiry. [3] Checkout a book to this patron. This will be (very) slow. Continue now with this patch applied: [4] Check in the same book. [5] Check it out again. Should be much faster. Bonus test: [6] Set borrower expiry date to today. Change relevant circulation rule to loan period of 21 hours. Test checking out with a manual due date /time just before today 23:59 and after that. In the second case the due date/time should become today 23:59 (note that 23:59 is not shown on the checkout form). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:01:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:01:17 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #6 from Marcel de Rooy --- Typical example of patch collision. Can we get the best of both? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:01:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:01:51 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #7 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #2) > Hm, I feel a bit like this builds in a secret feature - if I use 9998 it > will be slow, but if I use 9999 it will be faster? > > When we fixed the same thing for debarments it made more sense, as the > 'ulimited' debarment uses 9999 automatically, without the user entering a > date. For the patron expiry the date is defined by the library and could be > anything. We should not do hardcoded tests on 9999. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:02:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:02:02 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #44 from Katrin Fischer --- Sadly, there was no reaction on the mailing list to the e-mail Marcel sent (thx for that!) I suggest moving this back into the queue - I personally see no cleaner way to do that, the only additions I can think of is a small warning in Release notes. To me this kind of fixes a bug - I can't search for other branches subscriptions without superserials/superlibrarian, but I can claim their late issues... that appears illogical to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:08:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:08:28 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > Typical example of patch collision. > Can we get the best of both? As I already said, IMO we should not use DateTime outside of Koha::DateUtils. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:11:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:11:12 +0000 Subject: [Koha-bugs] [Bug 14447] Show the vol./ no. on the child record based from the host entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Jill, which feature are you using for creating your analytical records? The EasyAnalytics feature or the "New > New child record" link from the staff detail screen? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:14:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:14:25 +0000 Subject: [Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:14:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:14:35 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > (In reply to Marcel de Rooy from comment #6) > > Typical example of patch collision. > > Can we get the best of both? > > As I already said, IMO we should not use DateTime outside of Koha::DateUtils. That is fine. My patch also touches CalcDateDue. I will rework it now. Can we prevent another duplication of effort? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:16:02 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #10 from Marcel de Rooy --- btw I will also remove the 9999 Note that I am having trouble now with the Circulation test. It fails with me on test 49 already. not ok 49 - No items due in less than one day (0 days in advance) # Failed test 'No items due in less than one day (0 days in advance)' # at t/db_dependent/Circulation.t line 527. # got: '2' # expected: '0' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:18:26 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at biblibre.co |m.de.rooy at rijksmuseum.nl |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:20:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:20:34 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 --- Comment #5 from Jonathan Druart --- Comment on attachment 40752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40752 Bug 14464 - Add ability to cancel waiting holds from checkin screen Review of attachment 40752: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14464&attachment=40752) ----------------------------------------------------------------- ::: circ/returns.pl @@ +30,5 @@ > use strict; > use warnings; > > +use Carp 'verbose'; > +$SIG{ __DIE__ } = sub { Carp::confess( @_ ) }; Why do you need that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:37:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:37:04 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40873|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 40874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40874&action=edit Bug 14494: Terribly slow checkout caused by DateTime->new in far future An expiry date like 9999-12-31 in the local timezone will make DateTime spend a lot of time (maybe 60 seconds) on date calculation. See the DateTime documention on CPAN. A calculation in floating (or alternatively in UTC) would only take a few milliseconds. This patch makes two changes in this regard: [1] The compare between expiry date and today in CanBookBeIssued has been adjusted in Jonathan's patch. I am moving the compare to the floating timezone (as was done in my original patch). This removes a hardcoded 9999. [2] If ReturnBeforeExpiry is enabled, CalcDateDue compares the normal due date with the expiry date. The comparison is now done in the floating timezone. If the expiry date is before the due date, it is returned in the user context's timezone. NOTE: The calls to set_time_zone moving to or from floating do not adjust the local time. TEST PLAN: First without this patch (and the one from Jonathan): [1] Set expiry date to 9999-12-31 for a patron. [2] Enable ReturnBeforeExpiry. [3] Checkout a book to this patron. This will be (very) slow. Continue now with this patch applied: [4] Check in the same book. [5] Check it out again. Should be much faster. Bonus test: [6] Set borrower expiry date to today. Change relevant circulation rule to loan period of 21 hours. Test checking out with a manual due date /time just before today 23:59 and after that. In the second case the due date/time should become today 23:59 (note that 23:59 is not shown on the checkout form). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:37:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:37:56 +0000 Subject: [Koha-bugs] [Bug 14452] Remember if user used more/fewer options on advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14452 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- I'd tempt to remove the pref and use sessionStorage, but it won't work at the OPAC if JS is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:56:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:56:45 +0000 Subject: [Koha-bugs] [Bug 14452] Remember if user used more/fewer options on advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14452 --- Comment #2 from Katrin Fischer --- Thinking of our libraries there seems to be a difference in what people like to be the default - so I am not sure about removing the pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 12:58:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 10:58:38 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #12 from Marcel de Rooy --- not ok 49 - No items due in less than one day (0 days in advance) # Failed test 'No items due in less than one day (0 days in advance)' # at t/db_dependent/Circulation.t line 527. # got: '2' # expected: '0' Resolved this one now. The staff expiry was too quick :) Still looking now at: ok 61 - Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. DBIx::Class::Schema::txn_begin(): DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. at /home/koha/testclone/t/lib/TestBuilder.pm line 75 DBIx::Class::Schema::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xb24823c), attempting ROLLBACK anyway at /home/koha/testclone/t/lib/TestBuilder.pm line 360 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:03:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:03:35 +0000 Subject: [Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:03:38 +0000 Subject: [Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40695|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 40875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40875&action=edit Bug 14387 - Merge reference selection has no effect when merging authorities. This patch swaps the authority records according to the refenrece record selection. To TEST: Merge two authority records, select the second as merge reference. The reference authority is always the first. Apply the patch. Repeat previous steps, the authority is now merged using the selected reference record. modified: authorities/merge.pl Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:11:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:11:38 +0000 Subject: [Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete "by" and display of publication year for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:11:41 +0000 Subject: [Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete "by" and display of publication year for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40029|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 40876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40876&action=edit Bug 14303: Fix item search CSV export - obsolete "by" and display of publication year for MARC21 The exported CSV file from the item search didn't display the publication year in MARC21 installations and the title always contained 'by' even if there was no author information to display. Also the by is not needed by MARC21 as the data should include punctuation. This basically copies the changes done to the JSON format on bug 13859 to the CSV include. To test: Switch from 'Screen' to 'CSV' - Check publication date always displays (MARC21 and UNIMARC) - Check that for MARC21 the 'by' has been removed from the title information - Check that for UNIMARC the 'by' only displays when there is also an author to display Tested for MARC21, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:13:36 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 --- Comment #14 from Jonathan Druart --- (In reply to Liz Rea from comment #13) > Created attachment 40505 [details] [review] > Bug 12919 - perltidy and consistent sub naming Liz, could you confirm this one can leave the FQA queue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:28:48 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:28:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:28:51 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40793|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 40877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40877&action=edit Bug 11693: Default emailing preferences not loaded for self registering patron The call to AddMember_Opac does not take care of the messaging prefs when enhanced messaging is enabled. This patch adds the call to handle_form_action to do that. Test plan: Enable self registering patrons and enhanced messaging. Check the (default) message prefs for the relevant patron category. At least enable email for one notice. Self-register a user with and without verification email enabled. Check in both cases that the message prefs of the user conform to those in the patron category. (So at least one enabled.) Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:40:57 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40214|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer --- Created attachment 40878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40878&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC when... - Unit tests Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:41:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:41:56 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- I won't use the splinter review, it will be confusing. 1/ There are 2 different ways to do the same thing: 247 if ( $line=~/itemtype/ ) { $line = $itype; } 257 $linefilter[0] = @$filters[9] if ($line =~ /itemtype/ ) ; and 263 if ( $column=~/itemtype/ ) { $column = $itype; } 274 $colfilter[0] = @$filters[9] if ($column =~ $itype ) ; 2/ Please use sql placeholders for "issuingrules.itemtype=$itype" (x3) 3/ if (( @colfilter ) and ($colfilter[1])){ $sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'"); } elsif ($colfilter[0]) { $sth2->execute; } else { $sth2->execute; } Could be : if (( @colfilter ) and ($colfilter[1])){ $sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'"); } else { $sth2->execute; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:42:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:42:07 +0000 Subject: [Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #28 from Katrin Fischer --- I have rebased the last patch hopefully correctly and fixed problems with the POD in the test file noted by the QA script. But: $ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 25/69 # Failed test 'ReturnToShelvingCart: Modifying the whole Item doesn't overwrite permanent_location!' # at t/db_dependent/Circulation.t line 684. # Failed test 'ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location.'$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 25/69 # Failed test 'ReturnToShelvingCart: Modifying the whole Item doesn't overwrite permanent_location!' # at t/db_dependent/Circulation.t line 684. # Failed test 'ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location.' # at t/db_dependent/Circulation.t line 704. # Looks like you failed 2 tests of 69. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/69 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 512 Tests: 69 Failed: 2) Failed tests: 67, 69 Non-zero exit status: 2 Files=1, Tests=69, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.50 cusr 0.08 csys = 1.61 CPU) Result: FAIL # at t/db_dependent/Circulation.t line 704. # Looks like you failed 2 tests of 69. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/69 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 512 Tests: 69 Failed: 2) Failed tests: 67, 69 Non-zero exit status: 2 Files=1, Tests=69, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.50 cusr 0.08 csys = 1.61 CPU) Result: FAIL Leaving this in Failed QA for now - but would love to see this fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:51:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:51:36 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Hi Nicolas, are the patches in the right order? Could they be squashed? I am not sure how they are divided up and the first seems to refer +use C4::Desks;, which is only added by the third patch. Also, should this be needs sign-off? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:53:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:53:13 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart --- I would like to get another signoff to confirm that the concerns raised in comment 11 are fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:56:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:56:47 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #61 from Blou --- All those comments are perfectly valid. I'll correct them all (the use Dumper are most probably something forgotten by the dev, no excuse). Regarding the name, which one would you prefer "ITYPECAT or ITEMTYPECAT? Or a bit different: ITYPEGROUP" If no response, I'll go with ITYPEGROUP (of course, I'll do a patch's patch. I'm not messing with a passed qa) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:58:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:58:21 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40860|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 40879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40879&action=edit Bug 14494: Prevent slow checkout if the patron does not have an expiry date If a patron has a expiry date set to 9999-12-31 (for organizations for instance), the checkouts are very slow. It's caused by 2 different calls to DateTime in CanBookBeIssued: 1/ DateTime->new( year => 9999, month => 12, day => 31, time_zone => C4::Context->tz ); The time_zone should not be set (as it's done in Koha::DateUtils), set to UTC or floating tz. 2/ DateTime->compare($today, $expiry_dt) The comparaison of 2 DT with 1 related to 9999 is very slow, as you can imagine. For 1/ we need to call Koha::DateUtils::dt_from_string (actually, we should never call DateTime directly). For 2/ we just need to test if the date is != 9999, no need to compare it in this case. Test plan: Before this patch, confirm that the checkouts are slow if the patron has a dateexpiry set to 9999-12-31. update borrowers set dateexpiry="9999-12-31" where borrowernumber=42; After this patch, you should not see any regression when checking out items to an expired patron and to a valid patron. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:58:24 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40874|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 40880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40880&action=edit Bug 14494: Terribly slow checkout caused by DateTime->new in far future An expiry date like 9999-12-31 in the local timezone will make DateTime spend a lot of time (maybe 60 seconds) on date calculation. See the DateTime documention on CPAN. A calculation in floating (or alternatively in UTC) would only take a few milliseconds. This patch makes two changes in this regard: [1] The compare between expiry date and today in CanBookBeIssued has been adjusted in Jonathan's patch. I am moving the compare to the floating timezone (as was done in my original patch). This removes a hardcoded 9999. [2] If ReturnBeforeExpiry is enabled, CalcDateDue compares the normal due date with the expiry date. The comparison is now done in the floating timezone. If the expiry date is before the due date, it is returned in the user context's timezone. NOTE: The calls to set_time_zone moving to or from floating do not adjust the local time. TEST PLAN: First without this patch (and the one from Jonathan): [1] Set expiry date to 9999-12-31 for a patron. [2] Enable ReturnBeforeExpiry. [3] Checkout a book to this patron. This will be (very) slow. Continue now with this patch applied: [4] Check in the same book. [5] Check it out again. Should be much faster. Bonus test: [6] Set borrower expiry date to today. Change relevant circulation rule to loan period of 21 hours. Test checking out with a manual due date /time just before today 23:59 and after that. In the second case the due date/time should become today 23:59 (note that 23:59 is not shown on the checkout form). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:58:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:58:28 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #15 from Marcel de Rooy --- Created attachment 40881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40881&action=edit Bug 14494: Unit test Signed-off-by: Marcel de Rooy Moved the test on its own. Nicer than adding TestBuilder in the final part of the test. No warnings/errors from TestBuilder, no dependency.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:58:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:58:46 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14197 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:58:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:58:46 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14494 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:59:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:59:08 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14197 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:59:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:59:08 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14494 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 13:59:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 11:59:26 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nicolas.legrand at bulac.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:00:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:00:32 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- (In reply to Chris Nighswonger from comment #6) > That all sounds good. I wish I had time to sign off! Chris, I am not confident with part of code, it would be great to get your signoff on this one :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:02:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:02:02 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #16 from Marcel de Rooy --- Needs a signoff on the second path to get this into SO queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:02:29 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:09:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:09:56 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:09:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:09:58 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40881|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 40882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40882&action=edit Bug 14494: Unit test Signed-off-by: Marcel de Rooy Moved the test on its own. Nicer than adding TestBuilder in the final part of the test. No warnings/errors from TestBuilder, no dependency.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:11:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:11:31 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #67 from Katrin Fischer --- I think the last new patch is ok as a QA follow-up - shifting back to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:17:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:17:52 +0000 Subject: [Koha-bugs] [Bug 13622] Display a datetime without time in a notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #18 from Katrin Fischer --- Patches look ok to me on first glance, thx Indranil! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:20:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:20:12 +0000 Subject: [Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 --- Comment #2 from Katrin Fischer --- Hi Vitor, can you please add a test plan? Some sample records might also be helpful to make this easier to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:20:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:20:59 +0000 Subject: [Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 --- Comment #3 from Katrin Fischer --- Ah, also make sure test plan and problem description are part of your commit message! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:23:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:23:30 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40882|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 40883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40883&action=edit Bug 14494: Unit tests for CanBookBeIssued related to dateexpiry Signed-off-by: Marcel de Rooy Moved the test on its own. Nicer than adding TestBuilder in the final part of the test. No warnings/errors from TestBuilder, no dependency.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:33:52 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #46 from Katrin Fischer --- (In reply to Gaetan Boisson from comment #38) > Adding a note to the OAI-PMH preference so that it reads like the following > would be ok for me: > > able/disable Koha's OAI-PMH server. The data exposed will not include items > hidden through the OpacHiddenItems system preference, but everything else > will be available for harvest. If you need to hide some data, look into > extended mode and the OAI-PMH:ConfFile system preference. > > (It does look to me as enabling extended mode with a configuration file > allowing only one type of metadata that would result from a custom xslt > removing the confidential fields would be enough.) I liked this idea from Gaetan. But thinking about it more I am still torn: This is a change in behaviour. People might have built things assuming the item data is not there and might suddenly expose more data, than they wanted to. I know that Jonathan is probably right in that this was initially a regression from bug 5579, but we missed to fix this for a really long time now :( Would it be really bad to make the items a configuration option? I know some people hate new prefs... but the Web Services tab still has plenty of room... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:41:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:41:15 +0000 Subject: [Koha-bugs] [Bug 14511] New: Allow zebra search for MARC 027 tag Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 Bug ID: 14511 Summary: Allow zebra search for MARC 027 tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org MARC21 027 tag Standard technical report number should be indexed by Zebra. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:41:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:41:31 +0000 Subject: [Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:41:51 +0000 Subject: [Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 14:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 12:42:03 +0000 Subject: [Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:11:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:11:21 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Jerwyn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |os.jerwynfernandez at gmail.co | |m --- Comment #2 from Jerwyn --- Oh yeah! This is a nice feature! Its been almost 2 years any update on this? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:18:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:18:10 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #119 from Jonathan Druart --- (In reply to Kyle M Hall from comment #115) > As far as I can tell there is no way around this. I tried to use a left join > but you cannot use a group by in an update statement. Kyle, Just a quick thought: wouldn't it be possible to execute another update statement after the existing one, instead of adding complexity to it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:26:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:26:11 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #62 from Blou --- Created attachment 40884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40884&action=edit Bug 10937 - cleanup and rename DOCTYPECAT to ITEMTYPECAT - "Item" and not "Document" is the word used throughout Koha. - Moved the updates to an atomic update - changed searchcategory from varchar(20) to (80) - cleanup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:30:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:30:01 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #63 from Blou --- Since the word "category" was used throughout the patch, I kept it instead of using "group". updatedatabase.pl doesn't apply anymore with the first patch, but since it's PassedQA, I'm not touching it. The second patch puts it all in atomicupdate, to help in case it all falls apart and someone recreate a new squashed patch from 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:30:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:30:45 +0000 Subject: [Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 --- Comment #1 from Indranil Das Gupta --- (In reply to Amit Gupta from comment #0) > MARC21 027 tag Standard technical report number should be indexed by Zebra. so what are you proposing to do here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:33:44 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Hi David, Could you please add tinyMCE to the about page? Idea: why don't you add a pref to enable/disable the wysiwyg editor to all textarea pref? Please rebase, there is a conflict: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:44:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:44:10 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com --- Comment #3 from Eugene Espinoza --- This will be a nice feature added into Koha ILS, instead of trying out different technologies just to make this work, which can be a migration headache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:50:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:50:28 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart --- % more /etc/debian_version jessie/sid % perl --version | grep version This is perl 5, version 20, subversion 2 (v5.20.2) built for i586-linux-gnu-thread-multi-64int % git reset --hard origin/master % prove t/db_dependent/Auth_with_cas.t t/db_dependent/Auth_with_cas.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.96 cusr 0.02 csys = 1.00 CPU) Result: PASS No warn here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:51:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:51:29 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #16 from Jonathan Druart --- % pmvers CGI 3.65 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:52:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:52:57 +0000 Subject: [Koha-bugs] [Bug 14512] New: Add support for AV field to Koha's SIP2 Server Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 Bug ID: 14512 Summary: Add support for AV field to Koha's SIP2 Server Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Koha's SIP2 server should have support for the AV field ( field items ). The biggest problem with this field is that its' contents are not really defined in SIP2 protocol specification. All it says is "this field should be sent for each fine item". Due to this, I think the contents of the field need to be configurable at the login level, so that the contents can be defined based on the SIP2 devices requirements for the AV field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:53:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:53:01 +0000 Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:56:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:56:55 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #17 from Jonathan Druart --- I suppose it comes from this line: 217 $uri_params_part .= URI::Escape::uri_escape( $query->param($_) ); Could you confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:58:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:58:43 +0000 Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 15:58:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 13:58:45 +0000 Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 --- Comment #1 from Kyle M Hall --- Created attachment 40885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40885&action=edit Bug 14512 - Add support for AV field to Koha's SIP2 Server Koha's SIP2 server should have support for the AV field ( field items ). The biggest problem with this field is that its' contents are not really defined in SIP2 protocol specification. All it says is "this field should be sent for each fine item". Due to this, I think the contents of the field need to be configurable at the login level, so that the contents can be defined based on the SIP2 devices requirements for the AV field. Test Plan: 1) Apply this patch 2) Find a patron with outstanding fines 3) Run a patron information request using misc/sip_cli_emulator.pl using the new -s option with the value " Y " 4) Note there is an AV field for each fee containing the description and amount 5) Edit your sip config, add an av_field_template parameter to the login you are using such as av_field_template="TEST [% accountline.description %] [% accountline.amountoutstanding | format('%.2f') %]" 6) Restart your SIP server 7) Repeat the patron information request 8) Note your custom AV field is being used! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:01:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:01:20 +0000 Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40885|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 40886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40886&action=edit Bug 14512 - Add support for AV field to Koha's SIP2 Server Koha's SIP2 server should have support for the AV field ( field items ). The biggest problem with this field is that its' contents are not really defined in SIP2 protocol specification. All it says is "this field should be sent for each fine item". Due to this, I think the contents of the field need to be configurable at the login level, so that the contents can be defined based on the SIP2 devices requirements for the AV field. Test Plan: 1) Apply this patch 2) Find a patron with outstanding fines 3) Run a patron information request using misc/sip_cli_emulator.pl using the new -s option with the value " Y " 4) Note there is an AV field for each fee containing the description and amount 5) Edit your sip config, add an av_field_template parameter to the login you are using such as av_field_template="TEST [% accountline.description %] [% accountline.amountoutstanding | format('%.2f') %]" 6) Restart your SIP server 7) Repeat the patron information request 8) Note your custom AV field is being used! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:10:16 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- > 2) Edit the accountno's for those fines and set them to 0 I suppose you mean by editing the row in DB using the sql CLI? Do you have an idea how it's possible to generate 2 rows with the same accountno for the same patron? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:11:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:11:14 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:21:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:21:00 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Jonathan Druart --- Kyle, 1/ You propose a --test option to the script, but I think the test behavior should be the default and --confirm should sent the job to the printer, don't you think? 2/ Please avoid sql queries in pl scripts. 3/ You should also address Bernardo's concern. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:22:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:22:50 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #47 from Gaetan Boisson --- > This is a change in behaviour. People might have built things assuming the > item data is not there and might suddenly expose more data, than they wanted > to. I agree but they will still be exposing this data, even if they switch it off for OAI, through the marc view, the marc downloads, etc. It's true i think we have enough sysprefs, but especially here, i feel we will add one to do something that can already be achieved using extended mode, and that it will only very partially fix an issue we have in a lot of other places. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:25:30 +0000 Subject: [Koha-bugs] [Bug 2735] authority search stops at 15 pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Jonathan Druart --- This is fixed: Authority search results << < 1 2 3 ... 204 > >> Results 1 to 20 of 4066 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:32:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:32:18 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 --- Comment #5 from Marc V?ron --- Created attachment 40887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40887&action=edit [Signed-off] Bug 14508: 'New patron' dropdown empty list on circulation.pl This patch makes includes/patron-toolbar.inc (the one in charge of rendering the 'New patron' dropdown) make use of the Categories Template Toolkit plugin to create the list of categories. (1) To check the setup is sane: - Go to the Patrons page => SUCCESS: The 'New patron' dropdown is populated - Click on the [+] symbol on the Patron search on the top => SUCCESS: The Categories dropdown is populated (2) To test the patch: - On the checkout form, perform a patron search that (a) returns more than one result (b) returns zero results - Click the dropdown menu to create a new patron => FAIL: Dropdown is empty - Repeat for (a) or (b) - Apply the patch and reload => SUCCESS: The dropdown is correctly populated - Repeat (1) => SUCCESS: Nothing got broken - Verify the logs => SUCCESS: No new warnings - Sign off :-D - Get a cookie - Smile Regards Discussion: we might need a new bug to start cleaning stuff like this: @categories=C4::Category->all; if(scalar(@categories) < 1){ $no_add = 1; $template->param(no_categories => 1); } else { $template->param(categories=>\@categories); } but it belongs to a new bug me thinks. Well, suggestions are welcome, but this must be fixed on stable ASAP so hurry :-D Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:32:39 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #40850|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:32:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:32:50 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:33:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:33:20 +0000 Subject: [Koha-bugs] [Bug 14506] barcode printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14506 Pedro Ferreira changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.m.ferreira at mail.cm-po | |rtel.pt --- Comment #1 from Pedro Ferreira --- Created attachment 40888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40888&action=edit two C4/Labels : version 3.12 and version 3.20 With C4/Labels/Label.pm from version 3.12 i can print labels. With C4/Labels/Label.pm from version 3.20.X label printing does not work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:51:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:51:23 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #9 from Marc V?ron --- Created attachment 40889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40889&action=edit [Signed-off] Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:51:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:51:44 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #40829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 16:51:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 14:51:54 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:01:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:01:27 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 --- Comment #8 from Marc V?ron --- Created attachment 40890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40890&action=edit [Signed-off] Bug 14496 : Improving opac-detail.pl performances Get notes and subjects from MARC record ONLY when XSLT is not activated. It's useless doing it when XSLT is activated, because XSLT takes care of it by its own. => With this patch, we are saving precious milliseconds I compared the display of some records in XSLT view with and without patch, was the same (as expected). Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:01:45 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #40805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:02:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:02:05 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:03:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:03:27 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #48 from Tom?s Cohen Arazi --- Maybe we should add an option to control this on the YAML configuration for OAI sets, so it is set-specific. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:17:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:17:31 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14508 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:17:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:17:31 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |7380 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:17:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:17:56 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:17:59 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40887|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 40891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40891&action=edit Bug 14508: 'New patron' dropdown empty list on circulation.pl This patch makes includes/patron-toolbar.inc (the one in charge of rendering the 'New patron' dropdown) make use of the Categories Template Toolkit plugin to create the list of categories. (1) To check the setup is sane: - Go to the Patrons page => SUCCESS: The 'New patron' dropdown is populated - Click on the [+] symbol on the Patron search on the top => SUCCESS: The Categories dropdown is populated (2) To test the patch: - On the checkout form, perform a patron search that (a) returns more than one result (b) returns zero results - Click the dropdown menu to create a new patron => FAIL: Dropdown is empty - Repeat for (a) or (b) - Apply the patch and reload => SUCCESS: The dropdown is correctly populated - Repeat (1) => SUCCESS: Nothing got broken - Verify the logs => SUCCESS: No new warnings - Sign off :-D - Get a cookie - Smile Regards Discussion: we might need a new bug to start cleaning stuff like this: @categories=C4::Category->all; if(scalar(@categories) < 1){ $no_add = 1; $template->param(no_categories => 1); } else { $template->param(categories=>\@categories); } but it belongs to a new bug me thinks. Well, suggestions are welcome, but this must be fixed on stable ASAP so hurry :-D Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:24:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:24:21 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:24:23 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #19 from Kyle M Hall --- Created attachment 40892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40892&action=edit Bug 13517 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:25:39 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40892|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 40893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40893&action=edit Bug 13517 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:32:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:32:00 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37873|0 |1 is obsolete| | --- Comment #143 from Marc V?ron --- Created attachment 40894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40894&action=edit Bug 13813 - Remove C4::Dates from circ/circ/transferstoreceive.pl To test: Go to Home > Circulation > Transfers to your library (Circulation Reports - Transfers to receive) Verify that date in page title appears correcty Amendend following comment #58 /MV Signed-off-by: Jonathan Druart It ssemed that the amendent did not work out. Amended again following comment #58 / MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:32:36 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #10 from Nicolas Legrand --- Created attachment 40895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40895&action=edit Bug 13881: Add desk management Desks can be created for a branch. If a librarian sets a desk in the intranet and check in a document on hold, the document is then attached to a desk. Test plan, basic desk creation/modification/deletion: 1/ perl installer/data/mysql/updatedatabase.pl (create new table desks) 2/ prove t/db_dependent/Desks.t 3/ go to admin page, click on desk management, try to create, modify and delete desks Test plan, setting desk in the intranet: 1/ Go to the intranet administration, remove all desks if you have any. The desks should not appear in the header. 2/ add some desks in administration, without selecting some. The message ? NO DESK SET ? should appear at the left of the branchname. 3/ set a desk for your session. The desk deskcode should appear beside the branchname. 4/ change desk, the new name should appear also. Test plan, attach holds awaiting pickup to a desk: Set a desk, put a book on hold, check it in, confirm hold, it should appear in the "holds awaiting pickup" circulation page, it should appear as waiting at the desk on the patron's session. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:34:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:34:12 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:34:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:34:36 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40569|0 |1 is obsolete| | --- Comment #11 from Nicolas Legrand --- Comment on attachment 40569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40569 Bug 13881: attach a reserve to a desk >From 61e00bd675d86d6f3f3f6590c0ad403e19e2a1e0 Mon Sep 17 00:00:00 2001 >From: Nicolas Legrand >Date: Wed, 24 Jun 2015 12:20:27 +0200 >Subject: [PATCH] Bug 13881: attach a reserve to a desk > >In the intranet, if desks are defined, a librarian can set her desk as >she sets her branch. If the desk is set, and she checks in an items on >which a patron made a hold, the desk deskcode is attached to the >reserve and can be viewed in the Holds awaiting pickup circulation >report. > >Test plan: > >Set a desk, put a book on hold, check it in, confirm hold, it should >appear in the "holds awaiting pickup" circulation page, it should >appear as waiting at the desk on the patron's session. >--- > C4/Auth.pm | 32 ++++++++++---------- > C4/Reserves.pm | 20 ++++++++++-- > circ/returns.pl | 3 +- > circ/waitingreserves.pl | 9 ++++++ > .../bug_138881_link_desk_to_reserves.sql | 10 ++++++ > installer/data/mysql/kohastructure.sql | 6 +++- > .../prog/en/modules/circ/waitingreserves.tt | 6 ++++ > .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- > opac/opac-user.pl | 7 +++++ > 9 files changed, 73 insertions(+), 22 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_138881_link_desk_to_reserves.sql > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 5cd5823..2dd92d5 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -392,21 +392,6 @@ sub get_template_and_user { > persona => C4::Context->preference("persona"), > OPACBaseURL => C4::Context->preference('OPACBaseURL'), > ); >- if (C4::Context->userenv->{"branch"}) { >- my $desksaref = GetDesks(C4::Context->userenv->{"branch"}); >- if ($#$desksaref > -1) { >- $template->param( >- LoginDeskcode => ( C4::Context->userenv ? C4::Context->userenv->{"deskcode"} : undef ), >- LoginDeskname => ( C4::Context->userenv ? C4::Context->userenv->{"deskname"} : undef ), >- HasDesk => (1), >- ); >- } >- else { >- $template->param( >- HasDesk => (undef), >- ); >- } >- } > if ( $in->{'type'} eq "intranet" ) { > $template->param( > AmazonCoverImages => C4::Context->preference("AmazonCoverImages"), >@@ -441,7 +426,22 @@ sub get_template_and_user { > UseKohaPlugins => C4::Context->preference('UseKohaPlugins'), > UseCourseReserves => C4::Context->preference("UseCourseReserves"), > useDischarge => C4::Context->preference('useDischarge'), >- ); >+ ); >+ if ( C4::Context->userenv ? C4::Context->userenv->{"branch"} : undef) { >+ my $desksaref = GetDesks(C4::Context->userenv->{"branch"}); >+ if ($#$desksaref > -1) { >+ $template->param( >+ LoginDeskcode => ( C4::Context->userenv->{"deskcode"} ), >+ LoginDeskname => ( C4::Context->userenv->{"deskname"} ), >+ HasDesk => (1), >+ ); >+ } >+ else { >+ $template->param( >+ HasDesk => ( undef ), >+ ); >+ } >+ } > } > else { > warn "template type should be OPAC, here it is=[" . $in->{'type'} . "]" unless ( $in->{'type'} eq 'opac' ); >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 9c760b6..9a43585 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -843,7 +843,7 @@ sub GetReservesForBranch { > my $dbh = C4::Context->dbh; > > my $query = " >- SELECT reserve_id,borrowernumber,reservedate,itemnumber,waitingdate >+ SELECT reserve_id,borrowernumber,reservedate,itemnumber,waitingdate, deskcode > FROM reserves > WHERE priority='0' > AND found='W' >@@ -1353,7 +1353,7 @@ sub ModReserveStatus { > > =head2 ModReserveAffect > >- &ModReserveAffect($itemnumber,$borrowernumber,$diffBranchSend); >+ &ModReserveAffect($itemnumber,$borrowernumber,$diffBranchSend, $deskcode); > > This function affect an item and a status for a given reserve > The itemnumber parameter is used to find the biblionumber. >@@ -1367,7 +1367,7 @@ take care of the waiting status > =cut > > sub ModReserveAffect { >- my ( $itemnumber, $borrowernumber,$transferToDo ) = @_; >+ my ( $itemnumber, $borrowernumber,$transferToDo, $deskcode ) = @_; > my $dbh = C4::Context->dbh; > > # we want to attach $itemnumber to $borrowernumber, find the biblionumber >@@ -1398,6 +1398,19 @@ sub ModReserveAffect { > AND biblionumber = ? > "; > } >+ elsif ($deskcode) { >+ # add deskcode with waiting >+ $query = " >+ UPDATE reserves >+ SET priority = 0, >+ found = 'W', >+ waitingdate = NOW(), >+ deskcode = '$deskcode', >+ itemnumber = ? >+ WHERE borrowernumber = ? >+ AND biblionumber = ? >+ "; >+ } > else { > # affect the reserve to Waiting as well. > $query = " >@@ -1405,6 +1418,7 @@ sub ModReserveAffect { > SET priority = 0, > found = 'W', > waitingdate = NOW(), >+ deskcode = NULL, > itemnumber = ? > WHERE borrowernumber = ? > AND biblionumber = ? >diff --git a/circ/returns.pl b/circ/returns.pl >index 8b70e1a..67864e9 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -144,12 +144,13 @@ if ( $query->param('resbarcode') ) { > my $resbarcode = $query->param('resbarcode'); > my $diffBranchReturned = $query->param('diffBranch'); > my $iteminfo = GetBiblioFromItemNumber($item); >+ my $deskcode = C4::Context->userenv->{"deskcode"} || undef; > # fix up item type for display > $iteminfo->{'itemtype'} = C4::Context->preference('item-level_itypes') ? $iteminfo->{'itype'} : $iteminfo->{'itemtype'}; > my $diffBranchSend = ($userenv_branch ne $diffBranchReturned) ? $diffBranchReturned : undef; > # diffBranchSend tells ModReserveAffect whether document is expected in this library or not, > # i.e., whether to apply waiting status >- ModReserveAffect( $item, $borrowernumber, $diffBranchSend); >+ ModReserveAffect( $item, $borrowernumber, $diffBranchSend, $deskcode); > # check if we have other reserves for this document, if we have a return send the message of transfer > my ( $messages, $nextreservinfo ) = GetOtherReserves($item); > >diff --git a/circ/waitingreserves.pl b/circ/waitingreserves.pl >index 5471643..0ce4eb3 100755 >--- a/circ/waitingreserves.pl >+++ b/circ/waitingreserves.pl >@@ -24,6 +24,7 @@ use CGI qw ( -utf8 ); > use C4::Context; > use C4::Output; > use C4::Branch; # GetBranchName >+use C4::Desks; > use C4::Auth; > use C4::Dates qw/format_date/; > use C4::Circulation; >@@ -93,18 +94,26 @@ foreach my $num (@getreserves) { > my $itemnumber = $num->{'itemnumber'}; > my $gettitle = GetBiblioFromItemNumber( $itemnumber ); > my $borrowernum = $num->{'borrowernumber'}; >+ my $deskcode = $num->{'deskcode'}; >+ my $desk = GetDesk($deskcode); >+ my $deskname; >+ if ($desk) { >+ $deskname = $desk->{'deskname'}; >+ } > my $holdingbranch = $gettitle->{'holdingbranch'}; > my $homebranch = $gettitle->{'homebranch'}; > > my %getreserv = ( > itemnumber => $itemnumber, > borrowernum => $borrowernum, >+ deskname => $deskname, > ); > > # fix up item type for display > $gettitle->{'itemtype'} = C4::Context->preference('item-level_itypes') ? $gettitle->{'itype'} : $gettitle->{'itemtype'}; > my $getborrower = GetMember(borrowernumber => $num->{'borrowernumber'}); > my $itemtypeinfo = getitemtypeinfo( $gettitle->{'itemtype'} ); # using the fixed up itype/itemtype >+ > $getreserv{'waitingdate'} = $num->{'waitingdate'}; > my ( $waiting_year, $waiting_month, $waiting_day ) = split (/-/, $num->{'waitingdate'}); > ( $waiting_year, $waiting_month, $waiting_day ) = >diff --git a/installer/data/mysql/atomicupdate/bug_138881_link_desk_to_reserves.sql b/installer/data/mysql/atomicupdate/bug_138881_link_desk_to_reserves.sql >new file mode 100644 >index 0000000..e412527 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_138881_link_desk_to_reserves.sql >@@ -0,0 +1,10 @@ >+ALTER TABLE reserves ADD COLUMN deskcode VARCHAR(10) DEFAULT NULL AFTER branchcode >+ ADD KEY deskcode (deskcode) >+ ADD CONSTRAINT reserves_ibfk_5 >+ FOREIGN KEY (deskcode) REFERENCES desks (deskcode) >+ ON DELETE CASCADE ON UPDATE CASCADE; >+ALTER TABLE old_reserves ADD COLUMN deskcode VARCHAR(10) DEFAULT NULL AFTER branchcode >+ ADD KEY deskcode (deskcode) >+ ADD CONSTRAINT old_reserves_ibfk_4 >+ FOREIGN KEY (deskcode) REFERENCES desks (deskcode) >+ ON DELETE SET NULL ON UPDATE SET NULL; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index d3fca1d..554ca7e 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1676,6 +1676,7 @@ CREATE TABLE `old_reserves` ( -- this table holds all holds/reserves that have b > `biblionumber` int(11) default NULL, -- foreign key from the biblio table defining which bib record this hold is on > `constrainttype` varchar(1) default NULL, > `branchcode` varchar(10) default NULL, -- foreign key from the branches table defining which branch the patron wishes to pick this hold up at >+ `deskcode` varchar(10) default NULL, -- foreign key from the desks table defining which desk the patron may pick this hold up from > `notificationdate` date default NULL, -- currently unused > `reminderdate` date default NULL, -- currently unused > `cancellationdate` date default NULL, -- the date this hold was cancelled >@@ -1863,6 +1864,7 @@ CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha > `biblionumber` int(11) NOT NULL default 0, -- foreign key from the biblio table defining which bib record this hold is on > `constrainttype` varchar(1) default NULL, > `branchcode` varchar(10) default NULL, -- foreign key from the branches table defining which branch the patron wishes to pick this hold up at >+ `deskcode` varchar(10) default NULL, -- foreign key from the desks table defining which desk the patron may pick this hold up from > `notificationdate` date default NULL, -- currently unused > `reminderdate` date default NULL, -- currently unused > `cancellationdate` date default NULL, -- the date this hold was cancelled >@@ -1882,10 +1884,12 @@ CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha > KEY `biblionumber` (`biblionumber`), > KEY `itemnumber` (`itemnumber`), > KEY `branchcode` (`branchcode`), >+ KEY `deskcode` (`deskcode`), > CONSTRAINT `reserves_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, > CONSTRAINT `reserves_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE, > CONSTRAINT `reserves_ibfk_3` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE, >- CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE >+ CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE, >+ CONSTRAINT `reserves_ibfk_5` FOREIGN KEY (`deskcode`) REFERENCES `desks` (`deskcode`) ON DELETE CASCADE ON UPDATE CASCADE > ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; > > -- >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >index 1d5faf4..31294ec 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >@@ -82,6 +82,9 @@ > Title > Patron > Location >+ [% IF HasDesk %] >+ Desk >+ [% END %] > Copy number > Enumeration > Action >@@ -101,6 +104,9 @@ > [% reserveloo.borrowermail %][% END %] > > [% Branches.GetName( reserveloo.homebranch ) %]
    [% reserveloo.itemcallnumber %] >+ [% IF HasDesk %] >+ [% reserveloo.deskname %] >+ [% END %] > [% reserveloo.copynumber %] > [% reserveloo.enumchron %] > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 85c985d..5945492 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -566,7 +566,7 @@ > [% IF ( RESERVE.wait ) %] > [% IF ( RESERVE.atdestination ) %] > [% IF ( RESERVE.found ) %] >- Item waiting at [% RESERVE.wbrname %][% IF ( RESERVE.waitingdate ) %] since [% RESERVE.waitingdate | $KohaDates %][% END %] >+ Item waiting at [% RESERVE.wbrname %][% IF (RESERVE.wdkname) %], [% RESERVE.wdkname %][% END %][% IF ( RESERVE.waitingdate ) %], since [% RESERVE.waitingdate | $KohaDates %][% END %] > > [% ELSE %] > Item waiting to be pulled from [% RESERVE.wbrname %] >diff --git a/opac/opac-user.pl b/opac/opac-user.pl >index 18dfec6..a8cdd38 100755 >--- a/opac/opac-user.pl >+++ b/opac/opac-user.pl >@@ -34,6 +34,7 @@ use C4::Biblio; > use C4::Items; > use C4::Letters; > use C4::Branch; # GetBranches >+use C4::Desks; > use Koha::DateUtils; > use Koha::Borrower::Debarments qw(IsDebarred); > >@@ -325,6 +326,12 @@ foreach my $res (@reserves) { > $res->{'wbrcode'} = $res->{'branchcode'}; > $res->{'itemnumber'} = $res->{'itemnumber'}; > $res->{'wbrname'} = $branches->{$res->{'branchcode'}}->{'branchname'}; >+ if ($res->{'deskcode'}) { >+ my $desk = GetDesk($res->{'deskcode'}); >+ if ($desk) { >+ $res->{'wdkname'} = $desk->{'deskname'}; >+ } >+ } > if($res->{'holdingbranch'} eq $res->{'wbrcode'}){ > $res->{'atdestination'} = 1; > } >-- >1.7.10.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:34:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:34:42 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40709|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:39:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:39:59 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #12 from Nicolas Legrand --- (In reply to Katrin Fischer from comment #9) Hey Katrin, > are the patches in the right order? Could they be squashed? I am not sure > how they are divided up and the first seems to refer +use C4::Desks;, which > is only added by the third patch. Yes, I wanted to change the first commit and then it appeared at the end of the list. Anyway, I just squashed them as you suggested. > Also, should this be needs sign-off? Sadely, there is a bit more work on databases, I'm fighting with constraints, the db updates doesn't work yet. I have been working on something else hoping it will be plain clear next time I look upon it ^^. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 17:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 15:43:45 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 --- Comment #6 from Jesse Weaver --- (In reply to Jonathan Druart from comment #5) > Comment on attachment 40752 [details] [review] > Bug 14464 - Add ability to cancel waiting holds from checkin screen > > Review of attachment 40752 [details] [review]: > ----------------------------------------------------------------- > > ::: circ/returns.pl > @@ +30,5 @@ > > use strict; > > use warnings; > > > > +use Carp 'verbose'; > > +$SIG{ __DIE__ } = sub { Carp::confess( @_ ) }; > > Why do you need that? ... because I forgot to remove some debugging code, apologies. That's safe to remove. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:11:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:11:48 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40752|0 |1 is obsolete| | Attachment #40828|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 40896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40896&action=edit Bug 14464 - Add ability to cancel waiting holds from checkin screen Test plan: 1. Ensure that ExpireReservesMaxPickUpDelayCharge is set to 0. 2. Place a hold (doesn't matter whether it's a bib/item-level hold), then confirm the hold by checking it in. 3. Check in the item again, and hit Cancel. 4. The reserve in question should be cancelled. 5. Repeat steps 2-4 twice, once after setting ExpireReservesMaxPickUpDelayCharge to a nonzero value and again after clicking the "Forgive fees for manually expired holds" checkbox. A fine should only be applied when the syspref is enabled and the checkbox is not checked. Also, the checkbox should only appear after enabling the syspref. And finally, the checkbox should remember whether it is checked across multiple checkins, same as the "Forgive overdue charges" and "Book drop mode" checkboxes. Signed-off-by: Jason Burds Signed-off-by: Jonathan Druart Amended patch: Removed 2 debugging lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:11:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:11:45 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:11:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:11:51 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 --- Comment #8 from Jonathan Druart --- Created attachment 40897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40897&action=edit Bug 14464 - (QA followup) add unit tests This followup adds several tests to t/db_dependent/Reserves.t. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:28:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:28:40 +0000 Subject: [Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 --- Comment #2 from Amit Gupta --- > so what are you proposing to do here? Giving option to search "Standard technical report number" in both OPAC advance search and Staff search i.e 027$a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:36:24 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #21 from Jonathan Druart --- So... I was passing qa on this one (I promise!) and, during my last test, I have found a waiting reserve in my DB without itemnumber (??) Which makes the script explodes: Can't call method "holdingbranch" on an undefined value at /home/koha/src/reserve/request.pl line 488. It's an old data and a DB I used to test, so maybe this case is impossible to reach reserve_id: 2051 borrowernumber: 7781 reservedate: 2011-08-19 biblionumber: 4934 constrainttype: a branchcode: MAURES notificationdate: NULL reminderdate: NULL cancellationdate: NULL reservenotes: priority: 0 found: W timestamp: 2015-04-28 16:41:22 itemnumber: NULL waitingdate: 2015-04-28 expirationdate: NULL lowestPriority: 0 suspend: 0 suspend_until: NULL Sorry I don't remember what I did on April 28th :) I don't really know what to do, we could let the code as it, and see if someone report the issue. Or add an existing test on the item. What do you prefer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:47:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:47:52 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:47:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:47:55 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40676|0 |1 is obsolete| | Attachment #40677|0 |1 is obsolete| | Attachment #40893|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 40898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40898&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since " 6) Notice the expiration field now has the date of + 7 days Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:48:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:48:02 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #23 from Jonathan Druart --- Created attachment 40899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40899&action=edit Bug 13517 [QA Followup] - Add unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:48:06 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #24 from Jonathan Druart --- Created attachment 40900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40900&action=edit Bug 13517 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:50:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:50:45 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #25 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) Ok, let's consider it comes from my DB. I think it's better to know if a bug exists somewhere else, instead of adding useless tests in this (already messy) script. But, dear RM, don't push it just before the release :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 18:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 16:57:38 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 19:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 17:09:23 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #18 from M. Tompsett --- (In reply to Jonathan Druart from comment #17) > I suppose it comes from this line: > 217 $uri_params_part .= URI::Escape::uri_escape( > $query->param($_) ); > > Could you confirm? Yes, the other change is an optimization. It's faster to access a variable than function call twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 19:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 17:20:06 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #19 from M. Tompsett --- mtompset at debian:~/kohaclone$ cat /etc/debian_version 8.1 mtompset at debian:~/kohaclone$ perl --version | grep version This is perl 5, version 20, subversion 2 (v5.20.2) built for x86_64-linux-gnu-thread-multi mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 6e9086f Bug 3206: (QA followup) missing comma on sysprefs.sql mtompset at debian:~/kohaclone$ prove t/db_dependent/Auth_with_cas.t t/db_dependent/Auth_with_cas.t .. 1/4 CGI::param called in list context from package C4::Auth_with_cas line 217, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package C4::Auth_with_cas line 217, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. t/db_dependent/Auth_with_cas.t .. ok All tests successful. Files=1, Tests=4, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.67 cusr 0.01 csys = 0.70 CPU) Result: PASS mtompset at debian:~/kohaclone$ pmvers CGI 4.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 20:06:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 18:06:31 +0000 Subject: [Koha-bugs] [Bug 14513] New: keep track of patron last activity Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14513 Bug ID: 14513 Summary: keep track of patron last activity Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, jsasse at plumcreeklibrary.net, kyle.m.hall at gmail.com, nick at quecheelibrary.org It would be nice if there was a way on the patron record to see the date of their last activity - their last checkout, renewal, return - like there is on the items with date last seen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 20:24:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 18:24:51 +0000 Subject: [Koha-bugs] [Bug 13924] LocalHoldsPriority needs dateaccessioned limits. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13924 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12632 CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- I imagine a good solution would be to move the LocalHoldsPriority settings to the circulation rules. That way you could give new items a different itemtype than older items such that the new items honor LocalHoldsPriority and the older items do not. This would only work if bug 12632 is a dependency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 20:24:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 18:24:51 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13924 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 20:32:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 18:32:37 +0000 Subject: [Koha-bugs] [Bug 14514] New: LocalHoldsPriority and the HoldsQueue conflict with each other Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Bug ID: 14514 Summary: LocalHoldsPriority and the HoldsQueue conflict with each other Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It appears that the LocalHoldsPriority feature and the Holds Queue are fundamentally at odds with each other. The problem appears to be that both are attempting to choose the best way to fill holds. When you are using the holds queue and you check in an item that has been selected by the holds queue builder, that part of Koha where the LocalHoldsPriority feature lives doesn't get to see all the holds in order to pick the best one. Instead only the hold selected by the holds queue builder is returned so to the LocalHoldsPriority feature, that is only one hold to pick from! The solution *may* be to add the similar logic that appears C4::Reserves::CheckReserves for handling local hold priority to C4::HoldsQueue::MapItemsToHoldRequests at the very beginning before it even attempts to match item level requests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 20:46:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 18:46:09 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Juan Romay Sieira changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juan.sieira at xercode.es --- Comment #62 from Juan Romay Sieira --- I'm testing ES. My problem is that Koha is always trying to connect to localhost:9200, but my koha-conf.xml has: 192.168.0.213:9200 core my instance of ES it not in localhost. Do I have to do something to force to connect to 192.168.0.213 and not to localhost? This is the error: [NoNodes] ** No nodes are available: [http://localhost:9200], called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/local/share/perl/5.10.1/Catmandu/Store/ElasticSearch.pm line 61 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 21:19:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 19:19:05 +0000 Subject: [Koha-bugs] [Bug 14515] New: Add biblioitems table to notices in C4/Reserves.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Bug ID: 14515 Summary: Add biblioitems table to notices in C4/Reserves.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Add 'biblioitems' to the 'tables' hashref for the following notices in C4/Reserves.pm: HOLD HOLDPLACED RESERVESLIP message_name => 'Hold_Filled' See also Bug 13819 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 21:20:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 19:20:36 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |barton at bywatersolutions.com |ity.org | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13819 Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 21:20:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 19:20:36 +0000 Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in ISSUESLIP and ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14515 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 21:56:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 19:56:55 +0000 Subject: [Koha-bugs] [Bug 14516] New: Dropbox mode barcode input has odd coloring (alert class css) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14516 Bug ID: 14516 Summary: Dropbox mode barcode input has odd coloring (alert class css) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at quecheelibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 40901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40901&action=edit Picture of colored barcode input When dropbox mode is checked the barcode input box changes color (see attached screenshot) This coloring is unusual and makes the barcode input hard to read. Additionally, once you click anywhere else on the screen the coloring disappears, which is odd too. To reproduce: 1 - Browse to Circulation->Returns 2 - Check the dropbox mode box 3 - Check in a book or enter an invalid barcode 4 - See the input box change 5 - Click anywhere outside of that box 6 - See the box revert The relevant styling comes from: FILE boostrap.min.css: .alert,.alert h4{color:#c09853;} FILE staff-global.css: input.alert { background-color : #FFFF99; border-color: #900; } returns.tt has multiple addClass("alert") and removeClass("alert") so I am not sure if this is intentional or a bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 21:57:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 19:57:20 +0000 Subject: [Koha-bugs] [Bug 14516] Dropbox mode barcode input has odd coloring (alert class css) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14516 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 22:25:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 20:25:08 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 --- Comment #1 from Barton Chittenden --- Created attachment 40902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40902&action=edit Add biblioitems to messages in C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 22:25:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 20:25:36 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 23:04:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 21:04:37 +0000 Subject: [Koha-bugs] [Bug 14094] DDC - Add separators for repeated $a subfields (MARC21) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14094 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 23:09:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 21:09:36 +0000 Subject: [Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 23:17:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 21:17:35 +0000 Subject: [Koha-bugs] [Bug 8330] Overdues email subject contains untranslatable 'Overdue:' string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 23:18:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 21:18:49 +0000 Subject: [Koha-bugs] [Bug 12616] Locale in subscriptions not preselecting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #17 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 23:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 21:33:26 +0000 Subject: [Koha-bugs] [Bug 14290] Add a table foot to circulation matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 9 23:33:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 21:33:42 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 --- Comment #2 from Barton Chittenden --- Test plan: Choose a bib, and populate several fields in its biblioitems record, e.g. volume, isbn, publicationyear. Set up RESERVESLIP under tools->notices and slips. Add a field from biblioitems to RESERVESLIP, e.g. <> Place a hold on the bib and print the reserveslip Inspect the slip, and make sure that the field from biblioitems printed correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 00:02:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 22:02:53 +0000 Subject: [Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 00:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 22:07:08 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #15 from Liz Rea --- Nope, it still needs unit tests and pod2usage updates as well. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 00:36:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 22:36:53 +0000 Subject: [Koha-bugs] [Bug 5025] discrepancy between opac doc-head-open.inc and staff doc-head-open.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 01:02:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 23:02:52 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #63 from Robin Sheat --- (In reply to Juan Romay Sieira from comment #62) > I'm testing ES. My problem is that Koha is always trying to connect to > localhost:9200, but my koha-conf.xml has: > > > 192.168.0.213:9200 > core > > > my instance of ES it not in localhost. Do I have to do something to force to > connect to 192.168.0.213 and not to localhost? > > This is the error: [NoNodes] ** No nodes are available: > [http://localhost:9200], called from sub > Search::Elasticsearch::Role::Client::Direct::__ANON__ at > /usr/local/share/perl/5.10.1/Catmandu/Store/ElasticSearch.pm line 61 It definitely doesn't require localhost, my own test system runs against a remote ES server. I'm not sure what could cause that, are you sure you've got the right koha-conf? I'll attach the whole of mine to make sure the context is right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 01:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 23:03:38 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #64 from Robin Sheat --- Created attachment 40903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40903&action=edit My koha-conf.xml as an example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 01:12:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Jul 2015 23:12:46 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #9 from Robin Sheat --- As far as I can tell, this patch is looking good to me from a packaging-related POV. (In reply to Nicholas van Oudtshoorn from comment #8) > Agreed it would need a new bug. Have had a quick squiz, and it seems that > NET::CIDR::range2cidr is perfectly happy with the format required by the > current preference. It could, however, be changed to allow for much greater > variety... (multiple subnets, individual IPs, etc.) If it's backwards compatible, then that's the best of all worlds. I'd make a new bug for that, it certainly would be nice to gain a bit of standardisation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 02:51:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 00:51:41 +0000 Subject: [Koha-bugs] [Bug 14517] New: Private lists browsing broken in translated staff interface Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Bug ID: 14517 Summary: Private lists browsing broken in translated staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This bug affects (at least) master and 3.20.x. To reproduce: - On the staff interface create a private list - Go to More > Lists ('Your lists' tab) => SUCCESS: Your private list is shown. - Translate the templates to any language like: $ cd misc/translator/ $ perl translate install es-ES - Enable the translated templates on the sysprefs - Switch to the translated language - Go to the lists page (Mas > Listas in es-ES) => FAIL: The datatable hangs waiting for the svc/shelves script to return data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 02:53:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 00:53:17 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 40904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40904&action=edit Sample broken lists (es-ES) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 02:53:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 00:53:50 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 40905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40905&action=edit Sample working lists (en) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 04:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 02:19:58 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #158 from Chris Cormack --- testing upgraded bugzilla --- Comment #159 from Chris Cormack --- test 2 --- Comment #160 from Chris Cormack --- test 2 --- Comment #161 from Chris Cormack --- test 2 --- Comment #162 from Chris Cormack --- test 2 --- Comment #163 from Chris Cormack --- test 2 --- Comment #164 from Chris Cormack --- test 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 04:22:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 02:22:45 +0000 Subject: [Koha-bugs] [Bug 14356] Improvements to the 'Transfers to receive' page (branchname, mailto link) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14356 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 06:54:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 04:54:36 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|use dbh directly, not |Remove C4::Input |C4::Context->prepare | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 06:56:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 04:56:04 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 --- Comment #1 from M. Tompsett --- After discussing on mailing list a little, and with no objections, it seems that C4/Input.pm is beyond its useful days. This bug has been repurposed to remove it, rather than correct the C4::Context->prepare autoload mess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 07:04:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 05:04:20 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 --- Comment #2 from M. Tompsett --- mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 6e9086f Bug 3206: (QA followup) missing comma on sysprefs.sql mtompset at debian:~/kohaclone$ git grep C4::Input C4/Input.pm:package C4::Input; #assumes C4/Input C4/Input.pm:C4::Input - Miscellaneous sanity checks C4/Input.pm: use C4::Input; acqui/addorderiso2709.pl:use C4::Input; acqui/basketgroup.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/uncertainprice.pl:use C4::Input; admin/aqplan.pl:use C4::Input; members/memberentry.pl:use C4::Input; t/Input.t: use_ok('C4::Input'); mtompset at debian:~/kohaclone$ grep sub C4/Input.pm sub checkdigit ($;$) { my $temp2 = substr($infl,$i,1); if ($rem eq substr($infl,8,1)) { } # sub checkdigit mtompset at debian:~/kohaclone$ grep checkdigit `find acqui -type f` mtompset at debian:~/kohaclone$ grep checkdigit `find admin -type f` mtompset at debian:~/kohaclone$ grep checkdigit `find members -type f` mtompset at debian:~/kohaclone$ cat t/Input.t #!/usr/bin/perl # # This Koha test module is a stub! # Add more tests here!!! use strict; use warnings; use Test::More tests => 1; BEGIN { use_ok('C4::Input'); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 07:19:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 05:19:01 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 07:19:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 05:19:31 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 --- Comment #3 from M. Tompsett --- Created attachment 40906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40906&action=edit Bug 14428: Remove C4::Input Jonathan Druart agreed that C4::Input is vestigial code that should be removed. Here is how I checked. First I found where C4::Input was used. Then, I checked what functions are in the package: just checkdigit. Then, I confirmed that checkdigit is not used at all in any acquisition, administration, or member related perl scripts. Lastly, I took a look at our supposed test file for the package. It was painfully sparse. As such, this patch removes the test file and the package file, and removes C4::Input references from these six files: - acqui/addorderiso2709.pl - acqui/basketgroup.pl - acqui/neworderempty.pl - acqui/uncertainprice.pl - admin/aqplan.pl - members/memberentry.pl NOTE: neworderempty had 3 lines of it?! Didn't anyone see that?! Here is the output of what I did to confirm this correction: mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 6e9086f Bug 3206: (QA followup) missing comma on sysprefs.sql mtompset at debian:~/kohaclone$ git grep C4::Input C4/Input.pm:package C4::Input; #assumes C4/Input C4/Input.pm:C4::Input - Miscellaneous sanity checks C4/Input.pm: use C4::Input; acqui/addorderiso2709.pl:use C4::Input; acqui/basketgroup.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/uncertainprice.pl:use C4::Input; admin/aqplan.pl:use C4::Input; members/memberentry.pl:use C4::Input; t/Input.t: use_ok('C4::Input'); mtompset at debian:~/kohaclone$ grep sub C4/Input.pm sub checkdigit ($;$) { my $temp2 = substr($infl,$i,1); if ($rem eq substr($infl,8,1)) { } # sub checkdigit mtompset at debian:~/kohaclone$ grep checkdigit `find acqui -type f` mtompset at debian:~/kohaclone$ grep checkdigit `find admin -type f` mtompset at debian:~/kohaclone$ grep checkdigit `find members -type f` mtompset at debian:~/kohaclone$ cat t/Input.t use strict; use warnings; use Test::More tests => 1; BEGIN { use_ok('C4::Input'); } Apply this patch, and the output of git grep C4::Input will be empty. Run koha qa test tools (kind of overkill) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 07:28:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 05:28:44 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED Depends on| |14428 --- Comment #7 from M. Tompsett --- Setting this to depends on 14428, because 14428 removes the one non-intranetdir autoload by removing C4::Input (good bye, crud!). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 [Bug 14428] Remove C4::Input -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 07:28:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 05:28:44 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9006 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 [Bug 9006] autoload in C4::Context is a bad idea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 08:23:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 06:23:33 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #65 from Juan Romay Sieira --- Yes, its the right koha-conf, and Koha gets the right configuration. Now I change it to put the timeout tag and . I put a warn in Koha/SearchEngine/Elasticsearch/Search.pm warn Data::Dumper::Dumper(\%$params); $self->store( Catmandu::Store::ElasticSearch->new( %$params, trace_calls => 1, ) ) unless $self->store; this is what it show in koha opac log $VAR1 = { 'index_name' => 'core_biblios', 'timeout' => '10', 'servers' => [ '192.168.0.213:9200' ] }; The ES instance is running too, if I visit the URL of ES in a browser it returns: { "status" : 200, "name" : "koha-es", "cluster_name" : "koha-cluster", "version" : { "number" : "1.6.0", "build_hash" : "cdd3ac4dde4f69524ec0a14de3828cb95bbb86d0", "build_timestamp" : "2015-06-09T13:36:34Z", "build_snapshot" : false, "lucene_version" : "4.10.4" }, "tagline" : "You Know, for Search" } To temporaly fix it I wrote a iptables rule to forward my 9200 port to the other machine... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 09:05:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 07:05:06 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #20 from Jonathan Druart --- (In reply to M. Tompsett from comment #19) > mtompset at debian:~/kohaclone$ pmvers CGI > 4.09 Did you install it using from CPAN? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 09:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 07:12:24 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 --- Comment #16 from Jonathan Druart --- Comment on attachment 39260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39260 [SIGNED-OFF] Bug 12919 : Module to facilitate sending new (or updated or deleted) cataloguing records somewhere Review of attachment 39260: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12919&attachment=39260) ----------------------------------------------------------------- Don't you think it would be better to sent the mail to the message queue and let the users define a template letter? ::: C4/RecordExporter.pm @@ +274,5 @@ > +sub get_isbns { > + my ($record) = @_; > + > + my $res = ''; > + my @fields = $record->field('020'); This is MARC21 specific. You should use a subroutine from C4::Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 09:15:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 07:15:22 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #8 from Jonathan Druart --- (In reply to M. Tompsett from comment #7) > Setting this to depends on 14428, because 14428 removes the one > non-intranetdir autoload by removing C4::Input (good bye, crud!). This cans still be signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 09:23:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 07:23:43 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 09:25:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 07:25:06 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40906|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 40907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40907&action=edit Bug 14428: Remove C4::Input Jonathan Druart agreed that C4::Input is vestigial code that should be removed. Here is how I checked. First I found where C4::Input was used. Then, I checked what functions are in the package: just checkdigit. Then, I confirmed that checkdigit is not used at all in any acquisition, administration, or member related perl scripts. Lastly, I took a look at our supposed test file for the package. It was painfully sparse. As such, this patch removes the test file and the package file, and removes C4::Input references from these six files: - acqui/addorderiso2709.pl - acqui/basketgroup.pl - acqui/neworderempty.pl - acqui/uncertainprice.pl - admin/aqplan.pl - members/memberentry.pl NOTE: neworderempty had 3 lines of it?! Didn't anyone see that?! Here is the output of what I did to confirm this correction: mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 6e9086f Bug 3206: (QA followup) missing comma on sysprefs.sql mtompset at debian:~/kohaclone$ git grep C4::Input C4/Input.pm:package C4::Input; #assumes C4/Input C4/Input.pm:C4::Input - Miscellaneous sanity checks C4/Input.pm: use C4::Input; acqui/addorderiso2709.pl:use C4::Input; acqui/basketgroup.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/uncertainprice.pl:use C4::Input; admin/aqplan.pl:use C4::Input; members/memberentry.pl:use C4::Input; t/Input.t: use_ok('C4::Input'); mtompset at debian:~/kohaclone$ grep sub C4/Input.pm sub checkdigit ($;$) { my $temp2 = substr($infl,$i,1); if ($rem eq substr($infl,8,1)) { } # sub checkdigit mtompset at debian:~/kohaclone$ grep checkdigit `find acqui -type f` mtompset at debian:~/kohaclone$ grep checkdigit `find admin -type f` mtompset at debian:~/kohaclone$ grep checkdigit `find members -type f` mtompset at debian:~/kohaclone$ cat t/Input.t use strict; use warnings; use Test::More tests => 1; BEGIN { use_ok('C4::Input'); } Apply this patch, and the output of git grep C4::Input will be empty. Run koha qa test tools (kind of overkill) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 09:42:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 07:42:04 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 09:48:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 07:48:04 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #19 from Marcel de Rooy --- Created attachment 40908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40908&action=edit Bug 14494: Add some unit tests too for CalcDateDue The second patch of this report made some changes to CalcDateDue. We are adding some unit tests here. See the commments on the third patch too. Test plan: Run t/db_dependent/Circulation_dateexpiry.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 10:21:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 08:21:51 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 10:22:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 08:22:09 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40879|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 40909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40909&action=edit Bug 14494: Prevent slow checkout if the patron does not have an expiry date If a patron has a expiry date set to 9999-12-31 (for organizations for instance), the checkouts are very slow. It's caused by 2 different calls to DateTime in CanBookBeIssued: 1/ DateTime->new( year => 9999, month => 12, day => 31, time_zone => C4::Context->tz ); The time_zone should not be set (as it's done in Koha::DateUtils), set to UTC or floating tz. 2/ DateTime->compare($today, $expiry_dt) The comparaison of 2 DT with 1 related to 9999 is very slow, as you can imagine. For 1/ we need to call Koha::DateUtils::dt_from_string (actually, we should never call DateTime directly). For 2/ we just need to test if the date is != 9999, no need to compare it in this case. Test plan: Before this patch, confirm that the checkouts are slow if the patron has a dateexpiry set to 9999-12-31. update borrowers set dateexpiry="9999-12-31" where borrowernumber=42; After this patch, you should not see any regression when checking out items to an expired patron and to a valid patron. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 10:22:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 08:22:13 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40880|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 40910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40910&action=edit Bug 14494: Terribly slow checkout caused by DateTime->new in far future An expiry date like 9999-12-31 in the local timezone will make DateTime spend a lot of time (maybe 60 seconds) on date calculation. See the DateTime documention on CPAN. A calculation in floating (or alternatively in UTC) would only take a few milliseconds. This patch makes two changes in this regard: [1] The compare between expiry date and today in CanBookBeIssued has been adjusted in Jonathan's patch. I am moving the compare to the floating timezone (as was done in my original patch). This removes a hardcoded 9999. [2] If ReturnBeforeExpiry is enabled, CalcDateDue compares the normal due date with the expiry date. The comparison is now done in the floating timezone. If the expiry date is before the due date, it is returned in the user context's timezone. NOTE: The calls to set_time_zone moving to or from floating do not adjust the local time. TEST PLAN: First without this patch (and the one from Jonathan): [1] Set expiry date to 9999-12-31 for a patron. [2] Enable ReturnBeforeExpiry. [3] Checkout a book to this patron. This will be (very) slow. Continue now with this patch applied: [4] Check in the same book. [5] Check it out again. Should be much faster. Bonus test: [6] Set borrower expiry date to today. Change relevant circulation rule to loan period of 21 hours. Test checking out with a manual due date /time just before today 23:59 and after that. In the second case the due date/time should become today 23:59 (note that 23:59 is not shown on the checkout form). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 10:22:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 08:22:16 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40883|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 40911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40911&action=edit Bug 14494: Unit tests for CanBookBeIssued related to dateexpiry Signed-off-by: Marcel de Rooy Moved the test on its own. Nicer than adding TestBuilder in the final part of the test. No warnings/errors from TestBuilder, no dependency.. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 10:22:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 08:22:20 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40908|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 40912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40912&action=edit Bug 14494: Add some unit tests too for CalcDateDue The second patch of this report made some changes to CalcDateDue. We are adding some unit tests here. See the commments on the third patch too. Test plan: Run t/db_dependent/Circulation_dateexpiry.t Signed-off-by: Jonathan Druart Amended patch: Set the number of tests for the second subtest (was commented) and perltidy the second block. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 10:55:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 08:55:06 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 10:56:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 08:56:07 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40907|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 40913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40913&action=edit Bug 14428: Remove C4::Input Jonathan Druart agreed that C4::Input is vestigial code that should be removed. Here is how I checked. First I found where C4::Input was used. Then, I checked what functions are in the package: just checkdigit. Then, I confirmed that checkdigit is not used at all in any acquisition, administration, or member related perl scripts. Lastly, I took a look at our supposed test file for the package. It was painfully sparse. As such, this patch removes the test file and the package file, and removes C4::Input references from these six files: - acqui/addorderiso2709.pl - acqui/basketgroup.pl - acqui/neworderempty.pl - acqui/uncertainprice.pl - admin/aqplan.pl - members/memberentry.pl NOTE: neworderempty had 3 lines of it?! Didn't anyone see that?! Here is the output of what I did to confirm this correction: mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 6e9086f Bug 3206: (QA followup) missing comma on sysprefs.sql mtompset at debian:~/kohaclone$ git grep C4::Input C4/Input.pm:package C4::Input; #assumes C4/Input C4/Input.pm:C4::Input - Miscellaneous sanity checks C4/Input.pm: use C4::Input; acqui/addorderiso2709.pl:use C4::Input; acqui/basketgroup.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/neworderempty.pl:use C4::Input; acqui/uncertainprice.pl:use C4::Input; admin/aqplan.pl:use C4::Input; members/memberentry.pl:use C4::Input; t/Input.t: use_ok('C4::Input'); mtompset at debian:~/kohaclone$ grep sub C4/Input.pm sub checkdigit ($;$) { my $temp2 = substr($infl,$i,1); if ($rem eq substr($infl,8,1)) { } # sub checkdigit mtompset at debian:~/kohaclone$ grep checkdigit `find acqui -type f` mtompset at debian:~/kohaclone$ grep checkdigit `find admin -type f` mtompset at debian:~/kohaclone$ grep checkdigit `find members -type f` mtompset at debian:~/kohaclone$ cat t/Input.t use strict; use warnings; use Test::More tests => 1; BEGIN { use_ok('C4::Input'); } Apply this patch, and the output of git grep C4::Input will be empty. Run koha qa test tools (kind of overkill) Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 10:56:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 08:56:55 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 10:58:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 08:58:52 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 --- Comment #6 from Marcel de Rooy --- Checked enabling the pref checkdigit. This triggers code in C4::Members:fixup_cardnumber that apparently replaced the stuff in C4::Input at some point in time.. Still works :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 11:17:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 09:17:00 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy --- (In reply to David Cook from comment #3) > I believe the non-XSLT detail display is deprecated or scheduled to be > deprecated, no? Yes, and this helps the XSLT view a little bit further. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 11:17:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 09:17:34 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 --- Comment #10 from Marcel de Rooy --- Created attachment 40914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40914&action=edit Bug 14496 : Improving opac-detail.pl performances Get notes and subjects from MARC record ONLY when XSLT is not activated. It's useless doing it when XSLT is activated, because XSLT takes care of it by its own. => With this patch, we are saving precious milliseconds I compared the display of some records in XSLT view with and without patch, was the same (as expected). Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy On a slower server, I saw a time save of 0.0274 to 0.0908 seconds (with XSLT). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 11:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 09:17:47 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 11:18:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 09:18:16 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 11:23:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 09:23:00 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |OPAC |and plumbing | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 11:23:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 09:23:53 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40890|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 11:46:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 09:46:05 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #36 from Jonathan Druart --- Comment on attachment 40442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40442 Bug 10988: Allow login via Google OAuth2 Review of attachment 40442: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10988&attachment=40442) ----------------------------------------------------------------- I don't have an installation with a public ip, so I cannot test this patch. Following a code review: 1/ Fix the patch's author (From: root ) 2/ perltidy the new file (opac/svc/googleoauth2) 3/ Maybe opac/svc/auth/googleoauth2 is more appropriate? 4/ the following: ::: opac/svc/googleoauth2 @@ +1,1 @@ > +#!/usr/bin/perl -w Remove -w @@ +36,5 @@ > +# means caching some information and updating it daily. But that > +# would make things a lot faster > + > +use Modern::Perl; > +use CGI qw/escape/; and -utf8, even if not needed. @@ +63,5 @@ > + $query->delete('code'); > + $query->param( 'OAuth2Failed' => $reason ); > + my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > + { > + template_name => 'opac-user.tmpl', Should be opac-user.tt @@ +75,5 @@ > + $template->param( 'loginprompt' => 1 ); > + output_html_with_http_headers $query, $cookie, $template->output; > +} > + > +#die $query->param('code'); To remove. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 11:59:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 09:59:12 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy --- I have added three tags with a normal user: Biblio 1: tag1 tag2 Biblio 2: tag1 I have approved tag1 in staff, did not touch tag2. I see the tag1 in opac-detail. I can click on it and have two results. With the normal user, I go to opac-tags. Both tags are marked not-approved. Somehow the $my_approved_tags array is empty. Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 13:00:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 11:00:38 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #12 from Jonathan Druart --- Created attachment 40915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40915&action=edit Bug 6379: Fix if the reviewer is not the same patron get_approval_rows does a left join on tags_approval.approved_by = borrowers.borrowernumber This means it cannot return the approval tags for a given patron. Note that this patch could be time-consuming if there is a lot of tags in the DB. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 13:01:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 11:01:15 +0000 Subject: [Koha-bugs] [Bug 14506] barcode printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14506 Pedro Ferreira changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Pedro Ferreira --- Bug solved. In my koha, the table ITEMS in the collumn HOMEBRANCH every item was set to NULL. I updated the filed to the correct homebranch id and it solved. update items set homebranch='MY_CORRECT_HOMEBRANCH_ID' Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 13:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 11:01:43 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #13 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #11) > I have added three tags with a normal user: > Biblio 1: tag1 tag2 > Biblio 2: tag1 > > I have approved tag1 in staff, did not touch tag2. > > I see the tag1 in opac-detail. I can click on it and have two results. > With the normal user, I go to opac-tags. > Both tags are marked not-approved. > Somehow the $my_approved_tags array is empty. > > Failed QA Good catch! This C4::Tags module is really a mess and I prefer not to touch it. The patch I propose should work but is not the best way to do. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 13:15:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 11:15:17 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 13:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 11:33:59 +0000 Subject: [Koha-bugs] [Bug 8132] batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart --- What about merging the Batch item deletion tool with the Batch record deletion tool? We could have Record type Bibliographic: Authorities: Items: Not sure an item is a record... Because at the moment, the batch item deletion and modification use the same script/template and it will be very hard to modify. Moreover the batch item deletion display all the item info, which is not needed. We would prefer to see the number of holds and checkouts, as is it for the Batch record deletion tool. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 13:42:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 11:42:30 +0000 Subject: [Koha-bugs] [Bug 13959] itemBarcodeFallbackSearch does not appear to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|critical |normal --- Comment #5 from Jonathan Druart --- Lowering the severity. Nicole Could you please provide more info if the issue is confirmed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 13:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 11:47:42 +0000 Subject: [Koha-bugs] [Bug 13951] patron card problem: When i choose the "Download as PDF" I always get an empty fields and iam getting patron image , barcode correctly in PDF FILE. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13951 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|critical |normal --- Comment #3 from Jonathan Druart --- Did you solve your problem? Did you have a look at the documentation? The error you got is a warning and should not break the feature. Lowering the severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 13:57:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 11:57:02 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Nicole, Which plugin are you talking about? There is no plugin linked to 600$a by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 13:58:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 11:58:22 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #2 from Jonathan Druart --- Looking at the code, it happens when the authority does not exist (authid=948 for you). Maybe it has been deleted but not removed from the Zebra index yet? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 14:03:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 12:03:56 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #10 from Julian Maurice --- Is this bug still relevant with bug 12412 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 14:10:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 12:10:28 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #49 from Tom?s Cohen Arazi --- (In reply to Tom?s Cohen Arazi from comment #48) > Maybe we should add an option to control this on the YAML configuration for > OAI sets, so it is set-specific. Something like: format: with_items: metadataPrefix: with_items metadataNamespace: http://koha-community.org/marcxml/with_items schema: http://koha-community.org/marcxml/with_items/xsd xsl_file: /usr/local/koha/xslt/marcxml.xsl include_items: yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 14:15:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 12:15:13 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to Julian Maurice from comment #10) > Is this bug still relevant with bug 12412 ? It is still relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 14:49:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 12:49:43 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #39 from Mirko Tietgen --- (In reply to M. Tompsett from comment #38) > NOTE: I rebased this so it applies nicely. I'm setting into > 'In Discussion', so the original author can rebase himself or > confirm this is good. Thanks Mark for the rebase! I wasn't aware you did that and wondered why my rebase was much easier than expected now :) I will add an up-to-date version with changes for bootstrap once I figure out how to make git bz and the new bugzilla version friends again, can't submit anything atm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 15:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 13:04:05 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 15:04:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 13:04:38 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40349|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 40916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40916&action=edit Bug 9006: Remove AUTOLOAD in C4::Context Happily this was only used for intranetdir. It's time to remove it and replace existing calls. I used the following commands to catch calls to C4::Context: git grep 'C4::Context\->' | grep -v 'C4::Context->preference' | grep -v 'C4::Context->config' | grep -v 'C4::Context->userenv' | grep -v 'C4::Context->IsSuperLibrarian' | grep -v 'C4::Context->dbh' | grep -v 'C4::Context->set_preference' | grep -v '_syspref_cache' | grep -v _userenv | grep -v 'C4::Context->interface' | grep -v 'C4::Context->Zconn' | grep -v 'C4::Context->queryparser' | grep -v 'C4::Context->tz' | grep -v 'C4::Context->boolean_preference' | grep -v 'C4::Context->memcached' NOTE: I applied 14428, and then did what I suggested in comment #2. Only intranetdir references appeared. I applied this patch, and repeated. Nothing appeared. This means the autoload references are properly removed. koha qa test tools complained about whitespace, I just fixed those. Though, we may wish to perltidy auth_fields_substructure.pl on another bug. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 15:15:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 13:15:57 +0000 Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 15:28:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 13:28:15 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #21 from M. Tompsett --- (In reply to Jonathan Druart from comment #20) > Did you install [CGI] using from CPAN? https://packages.debian.org/jessie/libcgi-pm-perl Not that I can tell. I avoid CPAN like the plague. And the latest is 4.21 as far as I can tell. JD wrote: > % more /etc/debian_version > jessie/sid I wrote: > mtompset at debian:~/kohaclone$ cat /etc/debian_version > 8.1 Your debian version is an experimental pre-release of Jessie? Try a fresher install? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 15:30:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 13:30:08 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38727|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 40917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40917&action=edit Bug 14100: [POC] Generic solution for language overlay This is a proof of concept! Test plan: 1/ update the Schema (misc/devel/update_dbix_class_files.pl) 2/ Translate templates for some languages (es-DE, de-DE for instance) 3/ Enable them in the pref (search for 'lang') for the staff interface 4/ Go on the item type admin page (admin/itemtypes.pl) 5/ Edit one 6/ Click on the 'translate for other languages' link 7/ You are now on the interface to translate the item type's description in the languages you want. So translate some :) 8/ Go back on the item type list view (admin/itemtypes.pl) 9/ You should see the original description (non translated) 10/ Switch the language 11/ You should see the translated description in the correct language. If the description is non translated, the original description is displayed. Think further / Todo: 1/ Update all occurrences of the item type's description 2/ Implement for authorised values 3/ Implement for syspref value (at least textarea) 4/ Implement for branch names 5/ Centralize all the translation on a single page in the admin area ... N/ Implement a webservice to centralize all the translations and give the ability to sync the item types/authorised values description with the rest of the world (push and pull). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 15:50:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 13:50:12 +0000 Subject: [Koha-bugs] [Bug 14518] New: Deleting notices with reservations (and no item) does not work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Bug ID: 14518 Summary: Deleting notices with reservations (and no item) does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl There's a popup asking for confirmation, but the Yes is ignored. The change to the code is very simple. In intranet-tmpl/prog/en/includes/cat-toolbar.inc: 54 else if ( holdcount > 0 ) { 55 is_confirmed = confirm( _("%s holds(s) for this ... 56 } else { 57 is_confirmed = confirm(_("Are you sure you want ... 58 } 59 if (is_confirmed) { 60 if ( count > 0 || holdcount > 0 ){ <<== but we just confirmed!! 61 return false; <<== Nooooooo!!! 62 } else { 63 window.location="/cgi-bin/koha/cataloguing/addbiblio.pl?op=delete&biblionumber=[% biblionumber %]"; 64 } Our proposed fix is just to remove that extra if. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 15:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 13:51:09 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting notices with reservations (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com, | |maxime.beaulieu at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 15:51:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 13:51:33 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting notices with reservations (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 15:59:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 13:59:27 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting notices with reservations (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 --- Comment #1 from Blou --- Created attachment 40918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40918&action=edit Bug 14518 - Allow deleting notices with reservations (and no item) after confirmation Cleaning up notices with no item but reservation is impossible since the code does not consider the result from the confirmation popup. This situation happens to our client in their (annual) cleanup. I suppose those are notices for orders that never materialized, but people already made reservations on them. Test: 1) create (or find) a notice with no item. 2) make a reservation on it. 3) try to delete the notice. a) a popup will ask for confirmation b) after accepting, validate if the notice is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:01:34 +0000 Subject: [Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:02:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:02:09 +0000 Subject: [Koha-bugs] [Bug 14424] Update Help Files for 3.20 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Nicole! Chris: there ya go! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:03:05 +0000 Subject: [Koha-bugs] [Bug 14496] Improving opac-detail.pl performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Nice improvement Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:03:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:03:25 +0000 Subject: [Koha-bugs] [Bug 14508] 'New patron' dropdown empty list on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14508 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks for QAing this fast! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:04:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:04:13 +0000 Subject: [Koha-bugs] [Bug 14428] Remove C4::Input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14428 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:04:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:04:27 +0000 Subject: [Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete "by" and display of publication year for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:06:54 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting notices with reservations (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:24:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:24:50 +0000 Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #10 from Jonathan Druart --- Created attachment 40919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40919&action=edit Bug 8723: Cover the existing behavior This patch cover the MoveItemFromBiblio subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:24:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:24:53 +0000 Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #11 from Jonathan Druart --- Created attachment 40920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40920&action=edit Bug 8723: Update the reserves table for item-level holds If an item is moved from a biblio to another, the holds should be updated too. See discussion on the bug report for more information. Test plan: 1/ Place a item-level hold on biblio1 2/ Move the item to biblio2 3/ Confirm that the hold still exists and point to the biblio2 This patch should not change the existing behavior for bib-level holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:24:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:24:57 +0000 Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #12 from Jonathan Druart --- Created attachment 40921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40921&action=edit Bug 8723: Update hold_fill_targets, tmp_holdsqueue and linktracker tables Same as previous patch for 3 other tables. Test plan: Same as before but the hold should exist to the 3 tables before the move. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:27:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:27:21 +0000 Subject: [Koha-bugs] [Bug 8723] holds don't transfer when moving items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #13 from Jonathan Druart --- (In reply to Galen Charlton from comment #9) > It's not just item-level hold requests -- it's also bib-level hold requests > that have been captured. > > The following tables definitely should be updated when an item is moved to a > different bib: > > reserves > hold_fill_targets > tmp_holdsqueue > linktracker Agreed and done. > The following tables perhaps should be updated: > > aqorders_items No biblionumber field. > reserveconstraints It will be removed by bug 9809. > import_items Maybe, but I don't understand what to do here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:27:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:27:49 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- (In reply to Indranil Das Gupta from comment #4) > Hi Aleisha, > > I feel these two one-liners should be squashed into one patch. What say? Not only that, but I think you fixed them in the wrong place. These are parameters set at the beginning of the function. I would correct $searchmember after line 21. -- after looking further, bug 14344 corrected the issue with the second patch. As such, I am obsoleting the second patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:28:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:28:06 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14344 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:28:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:28:06 +0000 Subject: [Koha-bugs] [Bug 14344] uninitialized value warning C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14344 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14436 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:28:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:28:32 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40799|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:29:29 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:30:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:30:07 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #10 from Kyle M Hall --- Created attachment 40922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40922&action=edit [PASSED QA] Bug 14445: Silences warn in letter.pl When changing Koha module to 'Circulation', there is a warn saying that $code is uninitialized. This patch sets $code to an empty string to silence the warn. To test: 1) Go to Tools, the Notices & Slips 2) Click 'new notice' (This will trigger warns, but ignore these as they will be corrected in the next patch) 3) Change Koha module to 'Circulation' 4) Notice warn about uninitialized $code variable 5) Apply patch and reload page, change Koha module to 'Circulation' 6) Notice page still works and warns are gone Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:30:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:30:16 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #11 from Kyle M Hall --- Created attachment 40923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40923&action=edit [PASSED QA] Bug 14445: Silences warns in letter.tt When creating a new notice, warn is triggered "Argument "" isn't numeric in numeric gt (>) at line 400". Same warn is triggered when changing Koha module option to any other module. To test: 1) Go to Tools, then Notices & Slips 2) Click 'new notice'. Notice warn in intranet-error.log 3) Change Koha module to another module. Notice warn is triggered for every change 4) Apply patch and reload page 5) Change Koha module to another module. Notice there are no longer warns 6) Go back to Notices & Slips and click 'new notice' again. Notice there are no warns Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:30:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:30:32 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #40856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:30:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:30:36 +0000 Subject: [Koha-bugs] [Bug 9190] Problem with holds - allow place a hold without all items checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |In Discussion Severity|critical |enhancement --- Comment #8 from Jonathan Druart --- This is not critical but an enhancement request. Vitor, could you confirm that what you mean is the same as bug 6837? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:30:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:30:37 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:34:07 +0000 Subject: [Koha-bugs] [Bug 13263] Printing Callnumber in Koha 3.16.04.000. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13263 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|critical |normal Priority|P1 - high |P5 - low --- Comment #3 from Jonathan Druart --- Lowering the severity. Jerwyn, could you detail? It worked as you expected in 3.12 but not in 3.16, that's it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:35:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:35:28 +0000 Subject: [Koha-bugs] [Bug 10009] self check out not really logging out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10009 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Nicole, could you confirm the issue is fixed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:36:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:36:15 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #8 from Gaetan Boisson --- I like this feature very much :) I agree with Marc regarding the language code. (A good example for this would be zh_CN and zh_TW where the two variants don't use the same characters.) Right now the tool is offering you a list of languages to choose from that doesn't match the templates you have installed. I think this will confuse users. (It certainly confused me.) Jonathan explained me that his idea was to make the languages available even if they are not installed yet, so that you can translate and it will work immediately when you decide to install them. In my experience users decide which translation they want at the very beginning of a project, and set everything up from there onwards. There should be a fallback mechanism to a translated string if none exists for the selected language though. Long story short, i think we should display a list that fits the installed templates (like for news). I agree with Josef's suggestion of displaying the translations directly in the table with the list of itemtypes. This will make it easy to spot what is missing a translated string. I doubt users will ever install more than a handful of translations, so it should remain manageable. Maybe they could all be displayed directly in the description column like this: Audio tape (en) Cassette audio (fr-FR) Audiokassette (de-DE) The language corresponding to the currently selected language could be highlighted. And obviously on other pages where we don't have to manage the translation, we would only see the translation for the currently selected language. Adding a translate link in a separate column doesn't look ?ber-important to me, since i think this will be part of setting up itemtypes (and others) at the beginning, and not something we will keep coming back to. But i don't mind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:42:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:42:54 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40916|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 40924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40924&action=edit [PASSED QA] Bug 9006: Remove AUTOLOAD in C4::Context Happily this was only used for intranetdir. It's time to remove it and replace existing calls. I used the following commands to catch calls to C4::Context: git grep 'C4::Context\->' | grep -v 'C4::Context->preference' | grep -v 'C4::Context->config' | grep -v 'C4::Context->userenv' | grep -v 'C4::Context->IsSuperLibrarian' | grep -v 'C4::Context->dbh' | grep -v 'C4::Context->set_preference' | grep -v '_syspref_cache' | grep -v _userenv | grep -v 'C4::Context->interface' | grep -v 'C4::Context->Zconn' | grep -v 'C4::Context->queryparser' | grep -v 'C4::Context->tz' | grep -v 'C4::Context->boolean_preference' | grep -v 'C4::Context->memcached' NOTE: I applied 14428, and then did what I suggested in comment #2. Only intranetdir references appeared. I applied this patch, and repeated. Nothing appeared. This means the autoload references are properly removed. koha qa test tools complained about whitespace, I just fixed those. Though, we may wish to perltidy auth_fields_substructure.pl on another bug. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:49:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:49:48 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:50:10 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 --- Comment #18 from Kyle M Hall --- Created attachment 40925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40925&action=edit [PASSED QA] Bug 12054: Inactive vendors should be inactive This patch make inactive vendors really inactive. That means an inactive vendor would not be able to add a basket / add an order. Revised test plan ================= 1/ In the acquisition module create 2 vendors: 1 active and 1 inactive. 2/ On the acqui/booksellers.pl, acqui/uncertainprice.pl, admin/aqcontract.pl and acqui/supplier.pl (pages which include the acq toolbar), you should be able to, for both the 'active' as well as the inactive vendor : (a) add new basket (b) add order items to the basket Remark: This is *wrong*. You should be able to do so only for active vendor. 3/ Apply the patch 4/ Go to the links in step #2 above and select the inactive vendor you should no longer be able to: (a) add new basket (b) add order items to the basket Remark: This is the *correct* behaviour 5/ No change should be noted for vendor marked "active", and should be able to undertake operations 4 (a), 4 (b) and 4 (c). Remark: This is the *correct* behaviour. 6/ run koha qa tests tool Bug 12054: (follow-up) Inactive vendors should be inactive Don't display "add order""block and buttons if the vendor is inactive. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:50:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:50:25 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #40205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:57:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:57:06 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 16:57:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 14:57:31 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40507|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 40926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40926&action=edit Bug 14436: Noisy warns in C4/Utils/DataTables/Members.pm TEST PLAN --------- 1) Backup the koha intranet error log. 2) Empty the koha intranet error log. 3) In staff client, go to Patrons (/cgi-bin/koha/members/members-home.pl) 4) Pick any letter to 'Browse by last name' -- koha intranet error log now has warns. -- the one of importance is the uninitalized value. 5) Empty the koha intranet error log. 6) apply this patch 7) Repeat steps 3 & 4. -- koha intranet error log does not contain the uninitialized value error. 8) run koha qa test tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:00:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:00:14 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Unit test fails: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. 1/18 DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' at C4/Reports/Guided.pm line 664. DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' at C4/Reports/Guided.pm line 664. # Looks like you planned 18 tests but ran 7. # Looks like your test exited with 255 just after 7. t/db_dependent/Reports_Guided.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 11/18 subtests Test Summary Report ------------------- t/db_dependent/Reports_Guided.t (Wstat: 65280 Tests: 7 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 18 tests but ran 7. Files=1, Tests=7, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.26 cusr 0.00 csys = 0.28 CPU) Result: FAIL Also, can you delete Koha/Schema/Result/SavedReport.pm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:14:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:14:50 +0000 Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 --- Comment #2 from Jonathan Druart --- Created attachment 40928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40928&action=edit Bug 12965: Prevent to erase an existing item type On creating an item type, if it already exists, it will replace the existing one. This patch prevent that and display a message to the interface. Note: The fields are lost. Test plan: 1/ Create an item type 'AAA', description 'AAA' 2/ Edit it, update the description with 'BBB' 3/ Create an item type 'AAA' with a description 'CCC' => you should get a warning "already exists". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:15:11 +0000 Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |Needs Signoff Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:19:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:19:24 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #10 from Jonathan Druart --- Created attachment 40929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40929&action=edit Bug 14435: Make the tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:21:23 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Jonathan Druart --- (In reply to Kyle M Hall from comment #9) Good catch, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:21:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:21:01 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #11 from Jonathan Druart --- Created attachment 40930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40930&action=edit Bug 14435: Remove the SavedReport DBIx::Class schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:23:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:23:04 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:24:40 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40926|0 |1 is obsolete| | --- Comment #7 from Indranil Das Gupta --- Created attachment 40931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40931&action=edit Bug 14436: Noisy warns in C4/Utils/DataTables/Members.pm TEST PLAN --------- 1) Backup the koha intranet error log. 2) Empty the koha intranet error log. 3) In staff client, go to Patrons (/cgi-bin/koha/members/members-home.pl) 4) Pick any letter to 'Browse by last name' -- koha intranet error log now has warns. -- the one of importance is the uninitalized value. 5) Empty the koha intranet error log. 6) apply this patch 7) Repeat steps 3 & 4. -- koha intranet error log does not contain the uninitialized value error. 8) run koha qa test tools. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:25:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:25:33 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:29:48 +0000 Subject: [Koha-bugs] [Bug 13048] Serial Error when NULL date encountered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Joy, are you able to give more info to reproduce this issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:33:11 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #24 from Kyle M Hall --- Created attachment 40932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40932&action=edit [PASSED QA] Bug 14494: Prevent slow checkout if the patron does not have an expiry date If a patron has a expiry date set to 9999-12-31 (for organizations for instance), the checkouts are very slow. It's caused by 2 different calls to DateTime in CanBookBeIssued: 1/ DateTime->new( year => 9999, month => 12, day => 31, time_zone => C4::Context->tz ); The time_zone should not be set (as it's done in Koha::DateUtils), set to UTC or floating tz. 2/ DateTime->compare($today, $expiry_dt) The comparaison of 2 DT with 1 related to 9999 is very slow, as you can imagine. For 1/ we need to call Koha::DateUtils::dt_from_string (actually, we should never call DateTime directly). For 2/ we just need to test if the date is != 9999, no need to compare it in this case. Test plan: Before this patch, confirm that the checkouts are slow if the patron has a dateexpiry set to 9999-12-31. update borrowers set dateexpiry="9999-12-31" where borrowernumber=42; After this patch, you should not see any regression when checking out items to an expired patron and to a valid patron. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:33:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:33:15 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #25 from Kyle M Hall --- Created attachment 40933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40933&action=edit [PASSED QA] Bug 14494: Terribly slow checkout caused by DateTime->new in far future An expiry date like 9999-12-31 in the local timezone will make DateTime spend a lot of time (maybe 60 seconds) on date calculation. See the DateTime documention on CPAN. A calculation in floating (or alternatively in UTC) would only take a few milliseconds. This patch makes two changes in this regard: [1] The compare between expiry date and today in CanBookBeIssued has been adjusted in Jonathan's patch. I am moving the compare to the floating timezone (as was done in my original patch). This removes a hardcoded 9999. [2] If ReturnBeforeExpiry is enabled, CalcDateDue compares the normal due date with the expiry date. The comparison is now done in the floating timezone. If the expiry date is before the due date, it is returned in the user context's timezone. NOTE: The calls to set_time_zone moving to or from floating do not adjust the local time. TEST PLAN: First without this patch (and the one from Jonathan): [1] Set expiry date to 9999-12-31 for a patron. [2] Enable ReturnBeforeExpiry. [3] Checkout a book to this patron. This will be (very) slow. Continue now with this patch applied: [4] Check in the same book. [5] Check it out again. Should be much faster. Bonus test: [6] Set borrower expiry date to today. Change relevant circulation rule to loan period of 21 hours. Test checking out with a manual due date /time just before today 23:59 and after that. In the second case the due date/time should become today 23:59 (note that 23:59 is not shown on the checkout form). Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:33:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:33:19 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #26 from Kyle M Hall --- Created attachment 40934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40934&action=edit [PASSED QA] Bug 14494: Unit tests for CanBookBeIssued related to dateexpiry Signed-off-by: Marcel de Rooy Moved the test on its own. Nicer than adding TestBuilder in the final part of the test. No warnings/errors from TestBuilder, no dependency.. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:33:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:33:20 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #40909|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:33:22 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #27 from Kyle M Hall --- Created attachment 40935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40935&action=edit [PASSED QA] Bug 14494: Add some unit tests too for CalcDateDue The second patch of this report made some changes to CalcDateDue. We are adding some unit tests here. See the commments on the third patch too. Test plan: Run t/db_dependent/Circulation_dateexpiry.t Signed-off-by: Jonathan Druart Amended patch: Set the number of tests for the second subtest (was commented) and perltidy the second block. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:33:26 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40910|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:33:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:33:33 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40911|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:33:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:33:40 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:33:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:33:47 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:42:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:42:43 +0000 Subject: [Koha-bugs] [Bug 12903] UseQueryParse, Staff client search incatalog, Duplicated records massage when adding a record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12903 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|critical |normal --- Comment #1 from Jonathan Druart --- Hello Abdou, You should prefer the mailing list for this kind of questions, to get a quickest answer :) > # search duplicate on ISBN, easy and fast.. > # ... normalize first > if ( $result->{isbn} ) { > $result->{isbn} =~ s/\(.*$//; > $result->{isbn} =~ s/\s+$//; > $query = "isbn:$result->{isbn}"; > } This will search for the isbn if an isbn is filled when creating the record. So if you don't fill it, it shouldn't. You can try to debug in C4/Search.pm: 141 warn "SEARCH $query"; 142 my ( $error, $searchresults, undef ) = SimpleSearch($query); # FIXME :: hardcoded ! To know what is the generated query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:46:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:46:44 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #22 from Kyle M Hall --- Created attachment 40936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40936&action=edit [PASSED QA] Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t TEST PLAN --------- 1) $ prove t/db_dependent/Auth_with_cas.t -- CGI security warning 2) apply patch 3) $ prove t/db_dependent/Auth_with_cas.t -- no noise. 4) koha qa test tools Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Not able to reproduce the error on my setup, but the code is a clear improvement over the previous version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:46:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:46:27 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:47:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:47:03 +0000 Subject: [Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #40696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:52:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:52:09 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:52:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:52:27 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #7 from Kyle M Hall --- Created attachment 40937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40937&action=edit [PASSED QA] Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank Display 773 in opac and staff details when ind1 !=1 Test plan ========= 1/ Add a new record which uses the 773 field to an instance running master code. (the selected MARC framework should have the 773's relevant sub-fields enabled and visible on staff client, opac and the editor). 2/ Set ind1 as '0' (zero). The note should be displayed both on OPAC as well as the staff client. 3/ Reset ind1 with a non-zero value or leave it blank. The display note should no longer be visible from either client or opac. 4/ Apply the patch. 5/ Repeat step #1 and #2. The note is displayed on staff and opac. 6/ Repeat step #3. The display note should be visible on both staff and opac. 7/ run koha-qa.pl -c 1 -v 2 Note : For #1 above, the following LoC record was used: http://www.loc.gov/marc/bibliographic/examples.html#monographic The patch applied cleanly and performed as expected. The koha-qa.pl gave OK as results. Signed-off-by: Indranil Das Gupta Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:52:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:52:30 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #39054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:58:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:58:18 +0000 Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5533 CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |nengard at gmail.com Status|NEW |In Discussion --- Comment #1 from Jonathan Druart --- It seems that this behavior exists for a while. There was a discussion on bug 5533 and I am not sure how we should fix this bug. bug 5533 comment 2: "Another update - if you mark items lost using the batch edit tool the lost items remain on the patron's record as checked out instead of being removed." I am sure it's easy to fix, but I would like to know the different use cases to take into account. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 [Bug 5533] marking item lost diff in two places -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:59:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:59:08 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #39927|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:58:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:58:18 +0000 Subject: [Koha-bugs] [Bug 5533] marking item lost diff in two places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12311 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 [Bug 12311] Batch modification of checked out and lost items checks them in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:58:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:58:34 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 --- Comment #16 from Kyle M Hall --- Created attachment 40938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40938&action=edit [PASSED QA] Bug 13387 - Uniform titles (130 / 240 / 730) Display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 130/240/730 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Fields show subfields a,d,f,g,h,k,l,m,n,o,p,r,s,t with multiple fields separated by span class=separator | 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 17:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 15:59:20 +0000 Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 --- Comment #2 from Jonathan Druart --- The code is: 200 if ( my $item = ModItemFromMarc( $localmarcitem, $itemdata->{biblionumber}, $itemnumber ) ) { 201 LostItem($itemnumber, 'MARK RETURNED') if $item->{itemlost}; 202 } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:00:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:00:44 +0000 Subject: [Koha-bugs] [Bug 13263] Printing Callnumber in Koha 3.16.04.000. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13263 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10821 --- Comment #4 from Chris Nighswonger --- If these are LLC call numbers, we split based on the standard and have chosen not to attempt to accommodate local variations. In any case this is most likely corrected by bug 10821. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:00:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:00:44 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:01:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:01:38 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:11:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:11:14 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 --- Comment #10 from Kyle M Hall --- Created attachment 40939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40939&action=edit [PASSED QA] Bug 11194: Add a new index for "Edition Statement" of a MARC Record Adds the "Edition Statement" MARC-field as a sortable search index in Koha. This Field is also used by the MARC::Record->edition(). It is mapped to search keyword "edition" and it targets the following MARC-fields: UNIMARC: all 205-subfields concatenated MARC21 : all 250-subfields concatenated NORMARC: all 250-subfields concatenated After applying this patch a full biblio reindexing needs to be done to make old records searchable. New Biblios, and Biblios that are part of some operations (checkin/out/hold/...), are searchable. These generate good test data to test this feature without fully reindexing the search index. TEST PLAN: 0. Move the search index and search word definitions from the koha source code to the directory where Zebra uses them. This is most easiest to do by reinstalling Koha, but can be manually moved as well. 1. Find a record with some data in the "Edition Statement" -field. 2. Modify that Record and reindex it. 3. Search with the keyword "edition=''" where is the stuff you wrote in the MARC-field. 4. Observe the found record. Signed-off-by: Bernardo Gonzalez Kriegel Tested on MARC21 and UNIMARC, works No errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:11:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:11:33 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #40321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:11:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:11:51 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:13:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:13:02 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40321|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:14:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:14:48 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:15:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:15:08 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:19:48 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 --- Comment #24 from Kyle M Hall --- Created attachment 40940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40940&action=edit [PASSED QA] Bug 13383 - RDA: 100/110/111 changes to XSLT Test plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 100,110,111 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 100,110,111 to show subfields a,b,c,d,q and t.Multiple fields are separated by span class=separator |. Includes 100$j and handles multiple relator terms/codes. 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:20:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:20:39 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #39926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 18:20:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 16:20:46 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 20:00:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 18:00:28 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 --- Comment #10 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #9) > (In reply to Chris Nighswonger from comment #6) > > That all sounds good. I wish I had time to sign off! > > Chris, > I am not confident with part of code, it would be great to get your signoff > on this one :) Hi Jonathan, while waiting to Chris, which part of the code is giving you trouble? I can review it if you want -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 22:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 20:17:40 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39735|0 |1 is obsolete| | Attachment #39791|0 |1 is obsolete| | --- Comment #15 from H?ctor Eduardo Castro Avalos --- Created attachment 40941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40941&action=edit Bug 14198: RDA: Indexing 264 field (Zebra) This patch add zebra indexes to RDA 264 field. The new Provider index is added too. QA comments corrected. To test: 1) Download RDA records with 264 fields from this attachment . Import the file and re-index/rebuild zebra. These records contain 260 and 264 fields per record. 2) Do a search with pb:Bethany two records will appear with title The guardian. Search with pl:Minneapolis too, the two records will appear. 3) Select one record of both records and delete the 260 field keeping the 264 field and save, rebuild your zebra. 4) Search again with pb:Bethany and just one record will appear. Thats mean 264 is not indexed. 5) Apply patches. 6) Rebuild your zebra but this time all biblio records. 7) Search again with pv:Bethany or Provider:Bethany, this time will appear the two records, 264 is indexed. Note that if you search again with pb only one record appear. This is because the suggestion of LOC. 10) Search with copydate:2013 only launch records with 260 fields and pv:2013 show both fields, i.e., 260 and 264. 11) Apply QA Test Tools Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 10 22:18:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Jul 2015 20:18:51 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 05:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 03:41:11 +0000 Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 05:42:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 03:42:37 +0000 Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40928|0 |1 is obsolete| | --- Comment #3 from Amit Gupta --- Created attachment 40942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40942&action=edit Bug 12965: Prevent to erase an existing item type Tested: Works well, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 05:42:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 03:42:50 +0000 Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 06:28:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 04:28:29 +0000 Subject: [Koha-bugs] [Bug 13263] Printing Callnumber in Koha 3.16.04.000. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13263 --- Comment #5 from Jerwyn --- Hi Jonathan! Sorry this case is closed, I just forgot to go over this report. The institution that we support is using lcc however, they are not using ( . ) in their cutters. What we advised them is to change the lcc format the "item record" to ddc so that we can generate the callnumber correctly. After we have seen the bug 10821 Chris has mentioned, yes we just found out how does it works! Cutters must have ( . ) in lcc format. Otherwise the resolution for this is to change it to ddc if an institution doesn't put ( . ) at the beginning of the cutters. Thank you and best regards, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 12:52:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 10:52:14 +0000 Subject: [Koha-bugs] [Bug 13263] Printing Callnumber in Koha 3.16.04.000. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13263 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 19:43:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 17:43:32 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #1 from Marcel de Rooy --- Created attachment 40943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40943&action=edit Bug 14199: Unify marc orgcode plugins, not overwriting existing values This patch copies code from marc21_field_003.pl to create marc21_orgcode.pl for more generic use. Other fields like 040c or 040d should use it too. Note: The plugin is used for authorities too (003, 040a). One behaviour change is added: If the corresponding field is already filled, it will not be overwritten. In the unit test marc21_orgcode already replaces marc21_field_003. Test plan: [1] Attach plugin marc21_orgcode to a field (e.g. 003) and test it in the MARC editor of Cataloguing or Authorities. [2] Check if a value is not overwritten any more. [3] Run unit test t/db_dependent/FrameworkPlugin.t; don't be distracted by the noisy warnings of marc21_field_007.pl. They will be addressed on another report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 19:43:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 17:43:40 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #2 from Marcel de Rooy --- Created attachment 40944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40944&action=edit Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin This patch updates the sql installer files for new installations. Occurrences to the three plugins marc21_field_003, 040c and 040d are replaced by marc21_orgcode.pl. This has been generated by one sed statement. Test plan: [1] Run a new installation or run some of the changed sql files manually. [2] Verify that marc21_orgcode is linked to fields previously linked to the three old plugins. [3] Do a git grep on the three plugin file names. No occurrences expected. Signed-off-by: Marcel de Rooy Have tested the three english sql files: authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a for 9 auth codes) marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch does not add them to 040c or 040d; no behavior change.. marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 19:43:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 17:43:44 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 --- Comment #3 from Marcel de Rooy --- Created attachment 40945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40945&action=edit Bug 14199: Database revision for marc21_orgcode.pl This patch adds the dbrev in atomicupdate, updating the marc structure for existing installations. (New installation in previous patch.) And it removes the obsolete plugin files. Test plan: Run upgrade. Verify that new plugin is linked (for bib and auth). Check plugin in editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 19:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 17:44:16 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 19:46:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 17:46:37 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 20:05:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 18:05:16 +0000 Subject: [Koha-bugs] [Bug 13444] OPACFallback has option 'Prog' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13444 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |indradg at gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Indranil Das Gupta --- *** This bug has been marked as a duplicate of bug 13291 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 20:05:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 18:05:16 +0000 Subject: [Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #2 from Indranil Das Gupta --- *** Bug 13444 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 20:07:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 18:07:09 +0000 Subject: [Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org Component|Architecture, internals, |System Administration |and plumbing | Status|NEW |ASSIGNED CC| |gmcharlt at gmail.com, | |indradg at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 20:07:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 18:07:24 +0000 Subject: [Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |indradg at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 20:08:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 18:08:35 +0000 Subject: [Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 20:28:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 18:28:25 +0000 Subject: [Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 --- Comment #3 from Indranil Das Gupta --- Created attachment 40946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40946&action=edit Bug 13291 - remove prog as fallback theme The 'prog' theme for OPAC was removed from Koha. The OPACFallback syspref was added in 3.18.0 with prog|bootstrap options. This patch proposes to remove the prog option, but still maintain the syspref for reasons outlined in Bug 13291 comment #1. Test plan : run updatedatabase.pl and check the value of OpacFallback under OPAC sysprefs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 20:29:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 18:29:07 +0000 Subject: [Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 20:29:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 18:29:49 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suppress OPACFallback |Remove prog option from |syspref - its use and |OPACFallback syspref |itself | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 21:16:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 19:16:49 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 --- Comment #4 from M. Tompsett --- Comment on attachment 40946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40946 Bug 13291 - remove prog as fallback theme Review of attachment 40946: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13291&attachment=40946) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_13291-remove-prog-as-listed-fallback-theme.sql @@ +1,1 @@ > +INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('OPACFallback', 'bootstrap', 'Define the fallback theme for the OPAC interface.', 'bootstrap', 'Themes'); Works fine for systems lacking the system preference, but where's the UPDATE for those which already have it set? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 21:38:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 19:38:40 +0000 Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #4 from Nicole C. Engard --- The coverflow plugin : http://bywatersolutions.com/koha-plugins/ uses the public reports to generate a responsive carousel of books. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 21:46:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 19:46:10 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40946|0 |1 is obsolete| | --- Comment #5 from Indranil Das Gupta --- Created attachment 40947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40947&action=edit Bug 13291 - remove prog as fallback theme The 'prog' theme for OPAC was removed from Koha. The OPACFallback syspref was added in 3.18.0 with prog|bootstrap options. This patch proposes to remove the prog option, but still maintain the syspref for reasons outlined in Bug 13291 comment #1. Test plan : run updatedatabase.pl and check the value of OpacFallback under OPAC sysprefs. Current patch-complexity: Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 21:51:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 19:51:13 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40947|0 |1 is obsolete| | --- Comment #6 from Indranil Das Gupta --- Created attachment 40948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40948&action=edit Bug 13291 - remove prog as fallback theme The 'prog' theme for OPAC was removed from Koha. The OPACFallback syspref was added in 3.18.0 with prog|bootstrap options. This patch proposes to remove the prog option, but still maintain the syspref for reasons outlined in Bug 13291 comment #1. Test plan : run updatedatabase.pl and check the value of OpacFallback under OPAC sysprefs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 21:52:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 19:52:30 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 --- Comment #7 from Indranil Das Gupta --- (In reply to M. Tompsett from comment #4) > Comment on attachment 40946 [details] [review] > Bug 13291 - remove prog as fallback theme > Works fine for systems lacking the system preference, but where's the UPDATE > for those which already have it set? Addressed. Also adds the missing edits to opac.pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 22:45:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 20:45:49 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 11 22:46:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Jul 2015 20:46:10 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40948|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 40949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40949&action=edit Bug 13291 - remove prog as fallback theme The 'prog' theme for OPAC was removed from Koha. The OPACFallback syspref was added in 3.18.0 with prog|bootstrap options. This patch proposes to remove the prog option, but still maintain the syspref for reasons outlined in Bug 13291 comment #1. TEST PLAN --------- 1) back up DB 2) in sql client: > select * from systempreferences where variable like '%OPACFallback%'; -- 1 record, should have bootstrap and prog choices, and likely prog fallback. 3) at command line: ./installer/data/mysql/updatedatabase.pl 4) in sql client: > select * from systempreferences where variable like '%OPACFallback%'; -- 1 record, should have bootstrap and bootstrap values now. 5) in sql client: > delete from systempreferences where variable like '%OPACFallback%'; -- now there should be no OPACFallback system preference. 6) at command line: ./installer/data/mysql/updatedatabase.pl 7) in sql client: > select * from systempreferences where variable like '%OPACFallback%'; -- 1 record, should have bootstrap and bootstrap values now. 8) in sql client (substitute your koha database name!): > drop database koha_library; > create database koha_library; > use koha_library; 9) Run web installer 10) in sql client: > select * from systempreferences where variable like '%OPACFallback%'; -- 1 record, should have bootstrap and bootstrap values now. 11) run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 07:07:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 05:07:11 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #32 from M. Tompsett --- There are a couple of things that I just don't have the time to check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 12:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 10:51:07 +0000 Subject: [Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 12:58:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 10:58:22 +0000 Subject: [Koha-bugs] [Bug 14519] New: Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14519 Bug ID: 14519 Summary: Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz This new script in misc/cronjobs/ it is written to send courtesy notices when sys pref EnhancedMessagingPreferences is OFF. You can limit by library, setup how many day the message is sent, select the digest template to use for message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 12:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 10:59:14 +0000 Subject: [Koha-bugs] [Bug 14519] Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14519 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 13:07:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 11:07:54 +0000 Subject: [Koha-bugs] [Bug 14519] Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14519 --- Comment #1 from Zeno Tajoli --- Created attachment 40950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40950&action=edit new script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 13:08:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 11:08:13 +0000 Subject: [Koha-bugs] [Bug 14519] Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14519 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 18:11:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 16:11:58 +0000 Subject: [Koha-bugs] [Bug 14520] New: Prevent to override the existing currency code. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Bug ID: 14520 Summary: Prevent to override the existing currency code. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com While creating a new currency, if currency already exists then it will override the existing currency without warning any error message to the user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 18:12:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 16:12:11 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 18:18:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 16:18:24 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com --- Comment #1 from Amit Gupta --- Created attachment 40951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40951&action=edit Bug 14520 - Prevent to override the existing currency code. On creating a currency, if it already exists, it will replace the existing one. This patch prevent that and display a message to the user interface. Test case 1. Create a currency new 'INR' with a symbol 'INR' and rate '1'. 2. Click on Edit and update the symbol with 'RS'. 3. Create a currency 'INR' with a symbol 'RUP' and rate '1' you should get a warning message "This currency already exists". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 18:19:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 16:19:06 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 18:19:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 16:19:28 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 18:35:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 16:35:55 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 21:35:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 19:35:29 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36310|1 |0 is obsolete| | --- Comment #20 from Benjamin Rokseth --- Comment on attachment 36310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36310 Bug 13411 [QA Followup] - Add logging moved namespace fix to other patch of this bug. It has nothing to do with logging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 21:35:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 19:35:57 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36428|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 21:41:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 19:41:29 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36271|0 |1 is obsolete| | --- Comment #21 from Benjamin Rokseth --- Created attachment 40952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40952&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out corrected line $circ->patron( $patron = new ILS::Patron $item->{patron} ); to $circ->patron($patron = C4::SIP::ILS::Patron->new( $item->{patron})); in patch, as it breaks checkin and conforms to namespace used in file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 21:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 19:57:38 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36310|0 |1 is obsolete| | --- Comment #22 from Benjamin Rokseth --- Created attachment 40953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40953&action=edit Bug 13411 [QA Followup] - Add logging Revert ordering of patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 22:56:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 20:56:55 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35280|0 |1 is obsolete| | --- Comment #165 from Chris Cormack --- Created attachment 40954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40954&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 22:58:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 20:58:11 +0000 Subject: [Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 --- Comment #13 from Barton Chittenden --- TODO: Update debian/docs/koha-mysql.xml: The synopsis should change to koha-mysql INSTANCE-NAME [ mysql arguments ] Also, the '-e' option is now available, so the example usage may change to koha-mysql {instancename} -e "Some SQL query" It would also be useful to provide an explicit example of a mysql argument whose functionality was previously entirely unavailable, e.g. koha-mysql {instancename} --skip-column-names 'See Also' should mention mysql. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 23:00:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 21:00:09 +0000 Subject: [Koha-bugs] [Bug 14443] Man pages need to be updated for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14443 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Barton Chittenden --- Added 'TODO' note to 12372 which covers documentation. Closing this bug as a duplicate. *** This bug has been marked as a duplicate of bug 12372 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 23:00:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 21:00:09 +0000 Subject: [Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 --- Comment #14 from Barton Chittenden --- *** Bug 14443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 23:50:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 21:50:41 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #50 from Katrin Fischer --- Hm, I am not sure it works setting this on Set level as a lot of libraries might not be using sets - they are an optional feature and not needed if you want to get harvest the full catalog I think. Maybe Gaetan is right - I am really not sure what's best here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 23:52:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 21:52:29 +0000 Subject: [Koha-bugs] [Bug 8802] Library group records - category type reverts to "searchdomain" when editing group record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8802 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 12 23:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 21:55:27 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting notices with reservations (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Blou, please be careful - notices are letters in Koha, but I think you are talking about the bibliographic records? >From reading the problem description I think we got a different problem here - Koha should not allow to place holds on records without items ever. So maybe we need to find out why this happens first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 00:29:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 22:29:41 +0000 Subject: [Koha-bugs] [Bug 14519] Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Zeno, I am not sure about the idea of this patch. It seems to duplicate a lot of the existing script with the only difference being additional command line parameters? I wonder if we shouldn't include this in the existing script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 00:53:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Jul 2015 22:53:55 +0000 Subject: [Koha-bugs] [Bug 14324] "Add Child" button missing on moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14324 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 02:50:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 00:50:12 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #51 from David Cook --- (In reply to Katrin Fischer from comment #50) > Hm, I am not sure it works setting this on Set level as a lot of libraries > might not be using sets - they are an optional feature and not needed if you > want to get harvest the full catalog I think. Yeah, doing it at the set level wouldn't make sense. I don't know anything about Koha's "OAI-PMH:ConfFile" or "extended mode", so can't really comment there... I certainly get the idea of it being optional though and having the default be not to include items... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 02:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 00:54:32 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #7 from David Cook --- (In reply to Jonathan Druart from comment #6) > Hi David, > > Could you please add tinyMCE to the about page? > Do you mean add it to the Licences section? > Idea: why don't you add a pref to enable/disable the wysiwyg editor to all > textarea pref? > I don't think the WYSIWYG would be appropriate or functional for a lot of textarea prefs (e.g. MARCAuthorityControlField008, UNIMARCAuthorityField100, ISBD, SpineLabelFormat, OPACUserCSS, opacuserjs, etc.). But I like the idea of using a system preference to disable/enable the WYSIWYG... I could add that as a second patch to this bug... > Please rebase, there is a conflict: > CONFLICT (content): Merge conflict in > koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt Sure thing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 04:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 02:46:50 +0000 Subject: [Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 --- Comment #17 from Liz Rea --- Making it use a letter template and the letter queue is a good idea, but a scope creep. Happy to make another bug for that once the dev itself goes in. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 06:20:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 04:20:31 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 06:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 04:29:03 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 06:35:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 04:35:50 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 06:35:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 04:35:55 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40954|0 |1 is obsolete| | --- Comment #166 from Chris Cormack --- Created attachment 40957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40957&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 06:36:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 04:36:48 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 07:32:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 05:32:07 +0000 Subject: [Koha-bugs] [Bug 14447] Show the vol./ no. on the child record based from the host entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14447 --- Comment #2 from Jill Adolfo --- (In reply to Katrin Fischer from comment #1) > Hi Jill, > > which feature are you using for creating your analytical records? > The EasyAnalytics feature or the "New > New child record" link from the > staff detail screen? Hello Katrin, I use the Analytics feature from the staff detail screen when I'm creating a child record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 08:36:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 06:36:12 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 08:36:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 06:36:45 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40255|0 |1 is obsolete| | --- Comment #8 from David Cook --- Created attachment 40958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40958&action=edit Bug 14393 - Add collection code filter to inventory This patch adds the ability to do inventory by collection. _TEST PLAN_ Before applying: 1) Go to "Tools > Inventory/stocktaking" 2) Note that there is no "Collection code:" option Optionally: 2b) You can create a Barcode file with a single barcode 2c) Don't select anything from "Select items you want to check" (or filter if you know how to filter to make it faster... doesn't matter) 2d) Click "Submit" at the bottom of the screen 2e) Note that there is no "Collection code" column in the screen output or CSV output (ie with/without the "Export to CSV file" box ticked before submitting) Apply the patch. After applying: 3) Note that there is a "Collection code" filter on the main inventory screen 4) Create a Barcode file with a single barcode for an item with a collection and upload it using the "Choose file" button. 5) Select that item's collection code from the "Collection code" filter 6) Click "Submit" 7) Note that the screen output and the CSV output contains a "Collection code" column (ie with/without the "Export to CSV file" box ticked before submitting) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 08:37:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 06:37:57 +0000 Subject: [Koha-bugs] [Bug 14393] Add collection code filter to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #9 from David Cook --- (In reply to Jonathan Druart from comment #6) > Some libraries don't use this ccode value, it's the case in my installation. > I this case, the dropdown list is wrongly populated with all authorized > values! Could you give that a look? That should be a lot better now... thanks for looking at this bug! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 08:47:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 06:47:39 +0000 Subject: [Koha-bugs] [Bug 7879] Memoize::Memcached two times slower than it should be In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7879 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 08:49:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 06:49:33 +0000 Subject: [Koha-bugs] [Bug 14522] New: Use Koha::Cache for accessing single_holidays() Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Bug ID: 14522 Summary: Use Koha::Cache for accessing single_holidays() Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org more info to come -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 08:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 06:50:43 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14315 Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 08:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 06:50:43 +0000 Subject: [Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14522 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 [Bug 14522] Use Koha::Cache for accessing single_holidays() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 08:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 06:51:28 +0000 Subject: [Koha-bugs] [Bug 14519] Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14519 --- Comment #3 from Zeno Tajoli --- Hi Katrin, in fact the script is a simplified version of advance_notices.pl, with those differences: -- It works when EnhancedMessagingPreferences is OFF (reverse of advance_notices.pl) -- You can limit by library -- You can select the print template -- You can't select digest/no digest, only digest In copyright notice I mantain "Liblime 2008" because I reuse much code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 09:03:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 07:03:10 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 09:03:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 07:03:14 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40694|0 |1 is obsolete| | --- Comment #8 from David Cook --- Created attachment 40959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40959&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML This patch adds the ability to use a WYSIWYG editor for system preferences. The key files that I touch are: 1) admin/systempreferences.pl 2) koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt 3) koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt I also add: 4) koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc and 5) koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/advimage This plugin is part of the TinyMCE distribution. It used to be in Koha, but then someone removed it. It's useful for preferences like "opacheader" though. -- _TEST PLAN_ Before applying: Note that there is no WYSIWYG editors for system preferences and that it's not an option when creating a new local system preference. Apply the patch. After applying: 1) Go to Global System Preferences 2) Go to "Local use" 3) Create a new system preference with a variable type of "Htmlarea". 4) Click "Save" 5) Note that your system preference has a WYSIWYG editor instead of a textarea or some other type of input field. 6) Enter some content, bold it, insert images, etc. 7) Click "Save" 8) Reload the page 9) Note that your content is still there 10) Find koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref* 11) Change the "type" for "opacheader" from "textarea" to "htmlarea" 12) Reload the "OPAC" tab in Global System Preferences 13) Note that there is a WYSIWYG editor instead of a textarea for "opacheader" 14) Try different ways of changing the field's contents (e.g. typing with the keyboard, pasting content using the browser's paste option [note that browser security will probably prevent you using the context menu paste option], dragging text into the WYSIWYG editor box, etc.)** 15) Note that the preference says "opacheader (modified)" and the "Save all OPAC preferences" button has been enabled. 16) Click the save button and reload the page 17) Note that the content is there exactly as you entered it! 18) Try editing it again only using editor buttons (e.g. "bold", "link", etc) and note that the preference says "opacheader (modified)" and the save button has been enabled. 19) Look on the actual OPAC to see how your content has been rendered!*** *I opted not to edit any *.pref files with this commit as I think that's a separate step to actually adding the "ability" to use the WYSIWYG **If you're using anything except IE, this should work super well. If you're using IE, it'll probably only work for keyboard input and dragging text within the editor box but not from outside of it. IE has worse security, so you can probably paste using the context menu paste. ***While I think a WYSIWYG editor can be useful, there might be times where the content is displayed differently than it is in the editor because of higher level CSS and Javascript. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 09:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 07:05:45 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #9 from David Cook --- (In reply to Jonathan Druart from comment #6) > Could you please add tinyMCE to the about page? > > Idea: why don't you add a pref to enable/disable the wysiwyg editor to all > textarea pref? > I'll look at doing this tomorrow, as I'm done for the day now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 09:17:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 07:17:35 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38522|0 |1 is obsolete| | --- Comment #33 from Julian Maurice --- Created attachment 40960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40960&action=edit Bug 11904: New module Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 09:17:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 07:17:45 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38523|0 |1 is obsolete| | --- Comment #34 from Julian Maurice --- Created attachment 40961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40961&action=edit Bug 11904: Unit tests for Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 09:17:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 07:17:57 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38524|0 |1 is obsolete| | --- Comment #35 from Julian Maurice --- Created attachment 40962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40962&action=edit Bug 11904: Example usage of new module Koha::Messages Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 09:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 07:18:17 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 09:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 07:24:10 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12965 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 09:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 07:24:10 +0000 Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 10:15:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 08:15:15 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|kyle at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Librarian able to checkout |Restrict the actions for |item without setting branch |the DB user |first | --- Comment #7 from Jonathan Druart --- Since we already agreed on not to use the DB user to navigate into Koha, I am stealing this bug report to submit a patch to restrict the actions of this user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 10:15:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 08:15:29 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 10:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 08:21:49 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 10:21:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 08:21:52 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24595|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 40963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40963&action=edit Bug 11590: Restrict the actions for the DB user The DB user (the one defined in the KOHA_CONF file, section config) should not be used to navigate into Koha. It has been decided to let it actif to create the first user easily. This patch suggests to restrict as much as possible the actions for this user. If logged with this user, the administrator will only be able to create the first user and that's all. Automatically the new user created will be a superlibrarian. Test plan: 1/ Use the DB user to log you in into Koha. 2/ Make sure you are just able to go to the about and help pages. On the main page, you are pleased to create an user. 3/ Click on the link to create a new user 4/ Fill the form and save 5/ You are redirected to the loggin page 6/ Use the new user credentials and confirm it has been created as a superlibrarian. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 11:55:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 09:55:41 +0000 Subject: [Koha-bugs] [Bug 14523] New: Google jackets being blocked when OPAC using HTTPS Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Bug ID: 14523 Summary: Google jackets being blocked when OPAC using HTTPS Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: bc at interleaf.ie QA Contact: testopia at bugs.koha-community.org Google jackets are not displayed in OPAC if site is configured to server HTTPS. It looks like the google-jackets.js file is hard coded to request the content via HTTP. Most browsers will block this mixed content. Changing the google-jackets.js to "https://books.google.com" resolves the problems - and displays the image correctly. Maybe we should pass another variable to GetCoverFromIsbn() specifying if we are using HTTPS or not? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 11:56:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 09:56:29 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12481 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 11:56:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 09:56:29 +0000 Subject: [Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13265 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 [Bug 13265] Still too many search cursor cookies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 12:17:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 10:17:27 +0000 Subject: [Koha-bugs] [Bug 14524] New: Result list RSS feed broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Bug ID: 14524 Summary: Result list RSS feed broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When subscribing to a RSS feed from the OPAC result list, no results are shown for it. Tested with a dynamic bookmark in Firefox. Reason might be the use of |html instead of |url/uri as TT filter. Tested in 3.18.8 so far, but I think other versions are probably also affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 12:56:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 10:56:45 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 13:02:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 11:02:45 +0000 Subject: [Koha-bugs] [Bug 14524] Result list RSS feed broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- Confirmed on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 13:03:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 11:03:35 +0000 Subject: [Koha-bugs] [Bug 14524] Result list RSS feed broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 --- Comment #2 from Magnus Enger --- ...and 3.20.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 13:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 11:07:43 +0000 Subject: [Koha-bugs] [Bug 14524] Result list RSS feed broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 --- Comment #3 from Magnus Enger --- I have this in the OPAC error log: [Mon Jul 13 13:07:02.090923 2015] [cgi:error] [pid 4481] [client 127.0.0.1:55102] AH01215: [Mon Jul 13 13:07:02 2015] opac-search.pl: Use of uninitialized value in split at /home/magnus/scripts/kohaclone/opac/opac-search.pl line 501. [Mon Jul 13 13:07:02.096514 2015] [cgi:error] [pid 4481] [client 127.0.0.1:55102] AH01215: [Mon Jul 13 13:07:02 2015] opac-search.pl: WARNING: query problem with ZOOM error 10014 "CCL parsing error" (addinfo: "Search word expected") from diag-set 'ZOOM' at /home/magnus/scripts/kohaclone/C4/Search.pm line 379. Not sure what is relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 13:53:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 11:53:02 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #66 from Juan Romay Sieira --- Finally I can do index, search, ... and with the same configuration. My problem is that I was using Squeeze instead Jessie. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:13:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:13:14 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with reservations (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deleting notices with |Deleting records with |reservations (and no item) |reservations (and no item) |does not work |does not work --- Comment #3 from Blou --- Well, the library seems to use it, so in that sense, I think Koha should allow it. :) I think the usage is that they publicize future arrivals before getting them. They created the records, did their orders, told their "clients" and allowed them to reserve them. It does make sense to me as a user, but I'm no librarian. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:15:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:15:34 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with reservations (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 --- Comment #4 from Katrin Fischer --- It should not be possible - because the hold might never be filled. I think they are misusing a bug - and that could turn into a big problem for them on updating. For me it's not possible to place holds for records without items from the OPAC - I have no idea, how they are doing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:28:48 +0000 Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14520 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:28:48 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12965 | CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Currency is not item type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:30:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:30:30 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12146 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:30:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:30:30 +0000 Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:31:28 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7571 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:31:28 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:31:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:31:58 +0000 Subject: [Koha-bugs] [Bug 13988] Log activities related to Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7571 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:31:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:31:58 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13988 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:34:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:34:22 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 --- Comment #3 from M. Tompsett --- You need to keep bug 7571 in perspective when writing your patch. This patch is attempting to put a bandage on a larger problem: currency is poorly handled in Koha. If you fix 7571, this bug should become unnecessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:34:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:34:41 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset at hotmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:38:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:38:20 +0000 Subject: [Koha-bugs] [Bug 5711] Distinction between authors/additional authors in opac normal view (MARC21/XSLT) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- +1 for changing the OPAC display to match the staff client display (and do further improvements to it as a next step!) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:42:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:42:56 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14520 | CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:42:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:42:56 +0000 Subject: [Koha-bugs] [Bug 14520] Prevent to override the existing currency code. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7571 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:46:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:46:24 +0000 Subject: [Koha-bugs] [Bug 14525] New: undo checkin/out when accompanying message appears Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525 Bug ID: 14525 Summary: undo checkin/out when accompanying message appears Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if when the 'note about accompanying materials' appeared on checkin or checkout you could 'undo' the process if the item is missing a piece. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:53:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:53:55 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:53:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:53:58 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40917|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 40965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40965&action=edit Bug 14100: Generic solution for language overlay - Item types Test plan: 1/ update the Schema (misc/devel/update_dbix_class_files.pl) 2/ Translate templates for some languages (es-DE, de-DE for instance) 3/ Enable them in the pref (search for 'lang') for the staff interface 4/ Go on the item type admin page (admin/itemtypes.pl) 5/ Edit one 6/ Click on the 'translate for other languages' link 7/ You are now on the interface to translate the item type's description in the languages you want. So translate some :) 8/ Go back on the item type list view (admin/itemtypes.pl) 9/ You should see the original description (non translated) 10/ Switch the language 11/ You should see the translated description in the correct language. If the description is non translated, the original description is displayed. 12/ On the different page where the item type is displayed, confirm that the translated description appears. Think further / Todo: 1/ Update all occurrences of the item type's description (DONE) 2/ Implement for authorised values 3/ Implement for syspref value (at least textarea) 4/ Implement for branch names 5/ Centralize all the translation on a single page in the admin area ... N/ Implement a webservice to centralize all the translations and give the ability to sync the item types/authorised values description with the rest of the world (push and pull). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 14:58:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 12:58:52 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #10 from Jonathan Druart --- Here a version to sign off. Changes done in the last patch: 1/ Remove the gstrate in C4/Koha.pm and admin/itemtypes.pl. Sorry about that. 2/ Display the translated languages only. The full language codes are displayed. fr-FR and fr-CA can be translated. 3/ Display the translated string at several places. There are certainly some missing, please find them. What it's not done: Change the link from the edit to the list page. Because I did not find an ergonomic way to do. I don't want to update the list view when a translation is added in ajax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:04:14 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:08:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:08:57 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- I am not sure a syspref with 1 option is really useful. The fallback could be done automatically on the bootstrap theme, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:12:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:12:19 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:12:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:12:39 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40931|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 40966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40966&action=edit Bug 14436: Noisy warns in C4/Utils/DataTables/Members.pm TEST PLAN --------- 1) Backup the koha intranet error log. 2) Empty the koha intranet error log. 3) In staff client, go to Patrons (/cgi-bin/koha/members/members-home.pl) 4) Pick any letter to 'Browse by last name' -- koha intranet error log now has warns. -- the one of importance is the uninitalized value. 5) Empty the koha intranet error log. 6) apply this patch 7) Repeat steps 3 & 4. -- koha intranet error log does not contain the uninitialized value error. 8) run koha qa test tools. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:13:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:13:07 +0000 Subject: [Koha-bugs] [Bug 14436] Noisy warns in C4/Utils/DataTables/Members.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:14:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:14:13 +0000 Subject: [Koha-bugs] [Bug 14526] New: MoveReserve should look at future holds too Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Bug ID: 14526 Summary: MoveReserve should look at future holds too Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com MoveReserve is called when checking out a book (AddIssue). When filling a hold, it moves a reserve to old_reserves (with ModReserveFill). But if the hold is a future one (say tomorrow), and it is confirmed today and waiting for pickup, and the patron comes a day sooner, it should be moved too when checking out. Small patch forthcoming. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:14:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:14:48 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:18:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:18:03 +0000 Subject: [Koha-bugs] [Bug 14527] New: zebra error 114 when searching for items added before or after a specific date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 Bug ID: 14527 Summary: zebra error 114 when searching for items added before or after a specific date Change sponsored?: --- Product: Koha Version: 3.20 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: pedro.m.ferreira at mail.cm-portel.pt QA Contact: testopia at bugs.koha-community.org Created attachment 40967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40967&action=edit printscreen of zebra error Hello when i am adding a new bathc for labeling in 127.0.1.1:8080/cgi-bin/koha/cgi-bin/labels/label-item-search.pl and searching on or after a specific date, ZEBRA returns the error: Search biblios ERROR 114 1+0 RPN @attrset Bib-1 @attr 1=32 @attr 4=5 @attr 2=4 2015-07-13 And no data is returned. in the attachement i send two printscreen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:34:29 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with reservations (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 --- Comment #5 from Blou --- I clarified with Francois: This happened due to a migration to Koha. So you're right, it shouldn't happen in Koha. THAT said, we can argue about handling such case or not, but Koha is clearly misbehaving on the prompt: it asks if we want to do it anyway, then it totally ignores the result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:39:22 +0000 Subject: [Koha-bugs] [Bug 12144] Book drop mode mode erasing fine when CalculateFinesOnReturn is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I did not manage to reproduce this bug. Could you please confirm it's fixed on master? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:43:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:43:37 +0000 Subject: [Koha-bugs] [Bug 9996] Fix search for existing/upgraded Debian package instances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9996 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Is it fixed or still need to be fixed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:47:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:47:34 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with reservations (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 --- Comment #6 from Katrin Fischer --- Yep - but we need a new test plan - I think the only way you can do it is make an item... place a hold and then delete the item using SQL or something like that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:49:58 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 --- Comment #10 from Katrin Fischer --- Hm, thinking about this, you are probably right. If you have your own set of templates, hardcoding the fallback to the only available OPAC template seems right. OTH if we want to allow people to add other fallbacks and avoid changing files in Koha, this should not be a pull down but a text field? Hm, I feel like I am missing something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:52:54 +0000 Subject: [Koha-bugs] [Bug 8411] merging allows for creation of duplicate fields where not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8064 Severity|critical |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I did not test, but I think bug 8064 fixes this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 15:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 13:52:55 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8411 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:08:47 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39264|0 |1 is obsolete| | --- Comment #36 from Julian Maurice --- Created attachment 40968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40968&action=edit [SIGNED_OFF] Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:09:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:09:09 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39265|0 |1 is obsolete| | --- Comment #37 from Julian Maurice --- Created attachment 40969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40969&action=edit [SIGNED_OFF] Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:09:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:09:34 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39268|0 |1 is obsolete| | --- Comment #38 from Julian Maurice --- Created attachment 40970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40970&action=edit [SIGNED_OFF] Bug 11700: Avoid to try to delete the authority twice Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:10:16 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39266|0 |1 is obsolete| | Attachment #39267|0 |1 is obsolete| | Attachment #39269|0 |1 is obsolete| | --- Comment #39 from Julian Maurice --- Created attachment 40971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40971&action=edit [SIGNED_OFF] Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Rebased on master and squashed with others unit tests patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:10:26 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #40 from Julian Maurice --- Created attachment 40972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40972&action=edit Bug 11700: Add description to unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:13:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:13:50 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #41 from Julian Maurice --- Test plan: 1/ Launch unit tests: prove t/db_dependent/AuthoritiesMarc.t 2/ Check the authorities merge feature still works (search for authorities in staff interface and click 'Merge' on two different authorities, possibly used by 1 or more biblios) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:40:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:40:47 +0000 Subject: [Koha-bugs] [Bug 14418] XSS Flaws in OPAC Interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14418 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14524 --- Comment #16 from Jonathan Druart --- This patch breaks the RSS link, see bug 14524. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 [Bug 14524] Result list RSS feed broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:40:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:40:47 +0000 Subject: [Koha-bugs] [Bug 14524] Result list RSS feed broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14418 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14418 [Bug 14418] XSS Flaws in OPAC Interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:42:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:42:38 +0000 Subject: [Koha-bugs] [Bug 14524] Result list RSS feed broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Introduced by 14418. Since query_cgi contains something like "idx=kw&q=42", we should not use the uri filter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:50:43 +0000 Subject: [Koha-bugs] [Bug 14525] undo checkin/out when accompanying message appears In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:50:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:50:46 +0000 Subject: [Koha-bugs] [Bug 14525] undo checkin/out when accompanying message appears In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525 --- Comment #1 from Jonathan Druart --- Created attachment 40973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40973&action=edit Bug 14525: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: "idx=kw&q=42", we should not escape the & char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42&count=50&sort_by=acqdate_dsc&format=rss2 The & has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:51:49 +0000 Subject: [Koha-bugs] [Bug 14524] Result list RSS feed broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:51:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:51:52 +0000 Subject: [Koha-bugs] [Bug 14524] Result list RSS feed broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 --- Comment #5 from Jonathan Druart --- Created attachment 40974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40974&action=edit Bug 14524: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: "idx=kw&q=42", we should not escape the & char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42&count=50&sort_by=acqdate_dsc&format=rss2 The & has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:51:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:51:59 +0000 Subject: [Koha-bugs] [Bug 14525] undo checkin/out when accompanying message appears In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #40973|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 16:53:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 14:53:53 +0000 Subject: [Koha-bugs] [Bug 14525] undo checkin/out when accompanying message appears In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525 --- Comment #2 from Jonathan Druart --- Sorry for the noise, should be one bug 14524. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 17:13:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 15:13:00 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- Can we get a step-by-step plan to reproduce the issue please? Does it happen with the "en" templates? What versions of chromium, all? Is there a JS error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 17:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 15:26:59 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 --- Comment #11 from Katrin Fischer --- Hi Joubu, try the following: - Do a search with mulitple results - Go to the detail page (make sure results browser shows up!) - Use the "Edit items" link from the toolbar - Delete item - Choose "cancel" - Watch item getting deleted I just tested this in Firefox - hope it's going to happen consequently now at least... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:21:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:21:11 +0000 Subject: [Koha-bugs] [Bug 14528] New: Viewing lists fails silently when not having correct permisison Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Bug ID: 14528 Summary: Viewing lists fails silently when not having correct permisison Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: koha at jsense.co.uk QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Whilst testing the list permissions I found a problem. I have an account with staff client access and I went to the Lists module. You immediately get "Processing..." whilst an Ajax request takes place but then nothing else happens. I can debug to see that the search request failed to to not having permission. My primary concern is that I don't think any Ajax service call should fail silently like this - the user need to know it has failed. In this case the permission needed was "borrowers" - see /svc/virtualshelves/search. That doesn't make any sense to me - why would I need to have permission to "Add or modify patrons" when I just want to see Lists? Lastly, there may be some connection to issue 6960 but fixing that would only hide the primary problem described above. To reproduce: 1. Set up a user without "borrowers" permission 2. Go to /cgi-bin/koha/virtualshelves/shelves.pl 3. Note that it says "Processing..." and never completes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:23:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:23:13 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Pete Edwards changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at jsense.co.uk --- Comment #45 from Pete Edwards --- This isn't working as I would expect. I just upgraded from 3.18.03 to 3.20.01 and can see the new permissions. I cannot set them since I have superlibrarian permission but that is expected. However, when I go to public lists I still cannot edit or delete them. If I try another user without superlibrarian permission and add the new permission, still nothing changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:38:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:38:15 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:38:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:38:18 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 --- Comment #12 from Jonathan Druart --- Created attachment 40975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40975&action=edit Bug 13943: Prevent the deletion of items if the user cancels On the edit items page, there is some weird JS code: if the user clicks on the delete link and then cancel, the item is deleted anyway. Test plan: - Do a search with multiple results - Go to the detail page (make sure results browser shows up!) - Use the "Edit items" link from the toolbar - Delete item (try both way) - Choose "cancel" Note: Before this patch, the 2 first columns didn't contain the edit/delete item links, now it's only the 1st one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:38:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:38:29 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:49:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:49:44 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #46 from Jonathan Druart --- (In reply to Pete Edwards from comment #45) > This isn't working as I would expect. I just upgraded from 3.18.03 to > 3.20.01 and can see the new permissions. I cannot set them since I have > superlibrarian permission but that is expected. However, when I go to public > lists I still cannot edit or delete them. If I try another user without > superlibrarian permission and add the new permission, still nothing changes. Hi Pete, There is a bug, I will provide a patch soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:52:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:52:04 +0000 Subject: [Koha-bugs] [Bug 14529] New: Cannot delete a list even if the permission is set Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Bug ID: 14529 Summary: Cannot delete a list even if the permission is set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Lists Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:52:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:52:13 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14529 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 [Bug 14529] Cannot delete a list even if the permission is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:52:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:52:13 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13417 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 [Bug 13417] New permission to allow staff to remove public lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:55:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:55:47 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:55:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:55:49 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 --- Comment #1 from Jonathan Druart --- Created attachment 40976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40976&action=edit Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 18:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 16:56:30 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #47 from Jonathan Druart --- See bug 14529. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 21:40:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 19:40:54 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 --- Comment #11 from Indranil Das Gupta --- (In reply to Jonathan Druart from comment #9) > I am not sure a syspref with 1 option is really useful. we already have a related syspref with 1 option - opacthemes > The fallback could be done automatically on the bootstrap theme, don't you > think? We seem to have that already in C4/Templates.pm in the form of my $hardcoded_theme = ($interface eq 'intranet') ? 'prog' : 'bootstrap'; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 21:47:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 19:47:06 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 --- Comment #12 from Indranil Das Gupta --- (In reply to Katrin Fischer from comment #10) > Hm, thinking about this, you are probably right. If you have your own set of > templates, hardcoding the fallback to the only available OPAC template seems > right. OTH if we want to allow people to add other fallbacks and avoid > changing files in Koha, this should not be a pull down but a text field? Sounds like a fair argument - like say bootstrap|prog|custom_theme_name The ordering of these could then drive the selection in C4::Templates::themelanguage() Not that it would address Tomas's observation in line 243 about the hardcoding in case of an unpopulated db -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 21:47:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 19:47:48 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 21:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 19:59:28 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #13 from M. Tompsett --- (In reply to Indranil Das Gupta from comment #12) > (In reply to Katrin Fischer from comment #10) > > OTH if we want to allow people to add other fallbacks and avoid > > changing files in Koha, this should not be a pull down but a text field? > > Sounds like a fair argument - like say bootstrap|prog|custom_theme_name Yuck, no. Let's not do that. Drop downs prevent people messing up data. If people wish to install custom themes, it has to go in a known directory. Can't we calculate the drop down from the directory, rather than require the list be updated in the opac.pref file? Yes, I know the system preference code might get ugly looking. But I rather have ugly code than bad, hard to debug data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 22:01:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 20:01:38 +0000 Subject: [Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291 --- Comment #14 from M. Tompsett --- (In reply to Jonathan Druart from comment #9) > I am not sure a syspref with 1 option is really useful. > The fallback could be done automatically on the bootstrap theme, don't you > think? Though 1 is kind of silly now, it does allow for bringing back multiple themes in the future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 23:06:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 21:06:10 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 23:06:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 21:06:12 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 --- Comment #1 from Jesse Weaver --- Created attachment 40977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40977&action=edit Bug 14510: Allow column visibility in additem.pl to be customized This patch adds the table of items on additem.pl to the columns customizer. Test plan: 1. Open item editor on a record, and verify that all columns are visible. 2. Apply patch. 3. Reload editor, and verify that column visibility hasn't changed. 4. Open "Hide/show columns," and verify that you can add and remove columns. 5. Change the visibility and togglability of some columns in columns_settings.pl, and verify that these correctly apply to additem.pl. NOTE: The columns that are configurable are selected from the non-hidden columns that have mappings to MARC subfields in the default MARC21 framework (and can thus be displayed in the item editor). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 23:07:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 21:07:41 +0000 Subject: [Koha-bugs] [Bug 14524] Result list RSS feed broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 23:07:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 21:07:44 +0000 Subject: [Koha-bugs] [Bug 14524] Result list RSS feed broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40974|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 40978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40978&action=edit Bug 14524: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: "idx=kw&q=42", we should not escape the & char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42&count=50&sort_by=acqdate_dsc&format=rss2 The & has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 23:13:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 21:13:14 +0000 Subject: [Koha-bugs] [Bug 14439] Typo in Bug 14408 regexp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14439 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 23:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 21:27:57 +0000 Subject: [Koha-bugs] [Bug 14002] Show patron expiry date in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 13 23:33:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 21:33:20 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Danielle Elder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om --- Comment #15 from Danielle Elder --- (In reply to Mason James from comment #14) > Pushed to 3.16.x, will be in 3.16.11 I just wanted to say THANK YOU for adding the version that this is pushed to in the post! So helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 00:40:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 22:40:05 +0000 Subject: [Koha-bugs] [Bug 14490] Duplicate armenian translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14490 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 00:48:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 22:48:11 +0000 Subject: [Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 00:53:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 22:53:00 +0000 Subject: [Koha-bugs] [Bug 9996] Fix search for existing/upgraded Debian package instances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9996 --- Comment #8 from Robin Sheat --- (In reply to Jonathan Druart from comment #7) > Is it fixed or still need to be fixed? I haven't heard of it causing any problems lately. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 00:54:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 22:54:07 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #67 from Robin Sheat --- (In reply to Juan Romay Sieira from comment #66) > Finally I can do index, search, ... and with the same configuration. My > problem is that I was using Squeeze instead Jessie. Thank you! Oh, excellent! I'm surprised it even let you install the modules on squeeze, to be honest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 01:26:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 23:26:09 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 01:28:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 23:28:04 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 --- Comment #13 from David Cook --- Jonathan, have you tested this? At a glance, it looks like the main delete button will work because the href attribute points to "/cgi-bin/koha/mainpage.pl" instead of "/cgi-bin/koha/cataloguing/additem.pl?op=delitem&biblionumber=[% biblionumber %]&itemnumber=[% item_loo.itemnumber %]", but I don't know why you'd point at "/cgi-bin/koha/mainpage.pl"... I think that would be a surprising result when successfully deleting an item, no? I imagine the inline delete link will work since browser.js should try to bind the problematic click handler using the selector $('a[href*="biblionumber="]') before the inline links get created. Anyway... just some thoughts... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 01:42:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 23:42:47 +0000 Subject: [Koha-bugs] [Bug 14431] Encoding issues - search in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 01:50:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Jul 2015 23:50:53 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- You might consider the mailing lists (http://koha-community.org/support/koha-mailing-lists/) for finding a resolution to this problem. How did you install Koha? Do any search queries return results? You can see a fuller explanation of error codes here (http://www.loc.gov/z3950/agency/defns/bib1diag.html), but I've noticed error 114 happens when you don't have anything indexed. My guess is that you installed Koha via git or the tarball? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 02:00:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jul 2015 00:00:22 +0000 Subject: [Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 02:04:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jul 2015 00:04:38 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I have asked him to file the bug, but haven't got around to test and confirm the problem. Maybe someone else can? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 02:07:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jul 2015 00:07:41 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #3 from Katrin Fischer --- Hm, it seems t work on on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 02:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jul 2015 00:09:14 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #101 from Liz Rea --- Hi, Just wondering if you all at inLibro were going to come back to this bug? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 05:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jul 2015 03:41:24 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #4 from David Cook --- I would be really curious to know if Pedro is able to get search results back for any query. It really does sound to me like an empty Zebra database or at the very least an empty index being searched. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 06:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jul 2015 04:53:16 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from Nicholas van Oudtshoorn --- Thanks Robin! In that case, I'll change it to "needs signoff"! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 07:12:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jul 2015 05:12:53 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40442|0 |1 is obsolete| | --- Comment #37 from Nicholas van Oudtshoorn --- Created attachment 40979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40979&action=edit Bug 10988: Allow login via Google OAuth2 Adds googleoauth2 login to koha. Adds applicable system preferences. Modifies templates to support oauth2 login failures changes the login links to use googleoauth2 when oauth2 is enabled. Updated patch to address the concerns in Comment 36. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 07:16:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jul 2015 05:16:24 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #38 from M. Tompsett --- (In reply to Jonathan Druart from comment #36) > I don't have an installation with a public ip, > so I cannot test this patch. You don't need a public ip, as far as I recall, since the redirect is done at the browser level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 14 09:02:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Jul 2015 07:02:42 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #10 from David Cook --- I'm working on changing the system preferences and wrapping the WYSIWYG editor with a a system preference... I don't think WYSIWYG editors necessarily make sense everywhere you can use HTML though. If the HTML is going into a
    , then it's probably OK. However, if the HTML is a fragment going into an element like a