[Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 40743
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40743
Bug 14445: Silences warns in letter.tt

Review of attachment 40743:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14445&attachment=40743)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
@@ +397,4 @@
>                  <li>
>                    <label for="SQLfieldname_[% letter.message_transport_type %]">Message body:</label>
>                    [% IF letter.message_transport_type == 'sms' %]
> +                    <span id="sms_counter">[% IF letter.length && letter.length > 0 %][% letter.length %][% ELSE %]0[% END %]/160 characters</span>

This is wrong, we want to display the length of the content.
With your patch, the string displayed is always
   "Message body: 0/160 characters"

-- 
You are receiving this mail because:
You are watching all bug changes.