[Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 40777
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40777
Bug 14382: [QA Follow-up] Bad regex alarm

Review of attachment 40777:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14382&attachment=40777)
-----------------------------------------------------------------

::: reports/guided_reports.pl
@@ +754,4 @@
>                  my $quoted = $sql_params[$i];
>                  # if there are special regexp chars, we must \ them
>                  $split[$i*2+1] =~ s/(\||\?|\.|\*|\(|\)|\%)/\\$1/g;
> +                if ($split[$i*2+1] =~ /\|date$/) {

While I agree with the escaping (I really should have caught that, DOH!), the $
does not work. Why not leave >>? >'s are not special characters, are they?
I was thinking it may be better to put:
/\|\s*date\s*>>/

-- 
You are receiving this mail because:
You are watching all bug changes.