[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Jul 5 13:36:27 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 40004
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40004
Bug 13452: 'Average loan time' report to obey item-level_itypes preference

Review of attachment 40004:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13452&attachment=40004)
-----------------------------------------------------------------

::: reports/issues_avg_stats.pl
@@ +407,4 @@
>      if (( @colfilter ) and ($colfilter[1])){
>          $sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'");
>      } elsif ($colfilter[0]) {
> +        $sth2->execute;

Because without this change there was always an error in the logs - without any
of the other changes of the patch. I needed to change it to get it working
first... that's how I remember. The answer should be further above in the
code... this whole script should be rewritten to create the SQL in cleaner
ways.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list