[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 7 02:52:10 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 40816
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40816
Bug 14457: Integrate LIBRIS spellchecking

Review of attachment 40816:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14457&attachment=40816)
-----------------------------------------------------------------

::: opac/opac-search.pl
@@ +189,4 @@
>  }
>  if ($cgi->cookie("search_path_code")) {
>      my $pathcode = $cgi->cookie("search_path_code");
> +    given ($pathcode)

We don't use the given/when construct in Koha... I also don't see why this
change would be required here. It looks like it was included accidentally?

@@ +578,4 @@
>  # This sorts the facets into alphabetical order
>  if ($facets) {
>      foreach my $f (@$facets) {
> +        $f->{facets} = [ sort { uc($a->{facet_title_value}) cmp uc($b->{facet_title_value}) } @{ $f->{facets} } ];

This looks like it's outside the scope of this bug...

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list